[00:01:51] 10Wiki-Setup: Close chairwiki - https://phabricator.wikimedia.org/T184961 (10Urbanecm) [00:04:40] 10WikimediaMessages, 10Patch-For-Review: Add pmswikisource to WikimediaMessages - https://phabricator.wikimedia.org/T195018 (10Urbanecm) [00:04:44] 10Design: Design review for MontserratFont extension - https://phabricator.wikimedia.org/T194580 (10Urbanecm) [00:04:48] 10Security-Team-Reviews: Security review for MontserratFont - https://phabricator.wikimedia.org/T194578 (10Urbanecm) [01:13:34] 10Design, 10MontserratFont: Design review for MontserratFont extension - https://phabricator.wikimedia.org/T194580 (10Peachey88) [01:14:11] 10MontserratFont, 10Security-Team-Reviews: Security review for MontserratFont - https://phabricator.wikimedia.org/T194578 (10Peachey88) [01:29:03] 10Timeless, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Use icons with text for actions etc at higher resolutions so people don't get confused when they switch to icons only at lower ones - https://phabricator.wikimedia.org/T197520 (10Isarra) 05Open→03Resolved a:03Isarra [02:33:09] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Wikimedia-production-error: Investigate magically missing array key in ResourceLoaderWikiModule - https://phabricator.wikimedia.org/T229433 (10tstarling) Only three instances in the logs in 5 days. Maybe it should throw an exception instead of just logging a... [02:34:51] 10Timeless: Purge page tab not working - https://phabricator.wikimedia.org/T214207 (10Isarra) 05Open→03Declined So basically, lacking more information, we can assume anything actually doing this //right// should be working fine at this point? [02:58:57] 10Timeless: Few issues with layout when using timeless screen - https://phabricator.wikimedia.org/T175831 (10Isarra) 05Open→03Resolved a:03Isarra All right: # Flow issues seem resolved. # Icon issues on the manual appear to be a combination of bad styles on those items (negative margins for intentional im... [03:05:21] 10Timeless, 10Mobile: When using the search bar on mobile suggestions should be shown - https://phabricator.wikimedia.org/T161471 (10Isarra) 05Open→03Resolved a:03Isarra Honestly this seems to work fine now, though maybe this is just because I'm using a newer/much larger phone... [03:05:56] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech (Kanban (Q1 2019-20)), 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Outreachy (Round 17), 10User-Ryasmeen: Inconsistent handling of missing Required values in TemplateWizard - https://phabricator.wikimedia.org/T206096 (10ifried) 05Open→03Resolv... [03:14:48] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Implement Information Bar for Who Wrote That - https://phabricator.wikimedia.org/T226771 (10ifried) Since WWT won't follow a traditional release cycle, I'll mark such work as 'Done' when it has been demoed or tested. In this case, the information bar wa... [03:15:03] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Implement Information Bar for Who Wrote That - https://phabricator.wikimedia.org/T226771 (10ifried) 05Open→03Resolved [03:17:07] (03PS1) 10Isarra: Kill weird table normalisation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532285 (https://phabricator.wikimedia.org/T215608) [03:18:20] 10Timeless: Clicking on the "context menu icon" on an alert message shows the message below the alert window - https://phabricator.wikimedia.org/T175832 (10Isarra) Do we have an examples how to replicate this? What generates such alert windows, icons, etc? [03:18:40] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Wikimedia-production-error: Investigate magically missing array key in ResourceLoaderWikiModule - https://phabricator.wikimedia.org/T229433 (10tstarling) This would probably be enough to make it successfully do a core dump in production: `lang=php posix_setr... [03:18:42] (03PS5) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [03:27:26] 10MediaWiki-extensions-Translate, 10Timeless: Timeless has a bit larger padding on Special:Translate - https://phabricator.wikimedia.org/T197037 (10Isarra) Can someone confirm if this is still an issue, and where the problematic paddings are presenting themselves at this point? (Is it added by translate, only... [03:36:00] 10ContentTranslation, 10Timeless: Category input widget has extra space above input field on the Timeless skin - https://phabricator.wikimedia.org/T216503 (10Isarra) 05Open→03Resolved a:03Isarra [03:37:44] 10Timeless: White-on-white text in Media Viewer with timeless skin when the page contains an inputbox - https://phabricator.wikimedia.org/T192109 (10Isarra) Ah, what a lovely bug report... steps to reproduce, even a link. You spoil me. [03:39:42] (03CR) 10jerkins-bot: [V: 04-1] Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) (owner: 10DannyS712) [03:40:27] (03CR) 10jerkins-bot: [V: 04-1] Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) (owner: 10DannyS712) [03:41:20] 10Timeless: White-on-white text in Media Viewer with timeless skin when the page contains an inputbox - https://phabricator.wikimedia.org/T192109 (10Isarra) 05Open→03Resolved a:03Isarra All right, confirmed fixed in the meantime (general form cleanup, most likely). [03:44:05] (03PS6) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [03:50:09] (03PS1) 10Samwilson: Use plural variable name everywhere for page ID arrays [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 [03:55:39] (03PS2) 10Samwilson: Use plural variable name everywhere for page ID arrays [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 [04:01:13] (03PS4) 10Aaron Schulz: HashRing optimizations and PhpStorm warning work-arounds [core] - 10https://gerrit.wikimedia.org/r/530707 [04:06:52] (03CR) 10Aaron Schulz: [C: 03+2] title: Fix flaky TitlePermissionTest::testUserBlock [core] - 10https://gerrit.wikimedia.org/r/532244 (https://phabricator.wikimedia.org/T231166) (owner: 10Krinkle) [04:20:55] (03CR) 10Mooeypoo: [C: 03+1] "Looks good to me, but I didn't have a chance to test." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532286 (owner: 10Samwilson) [04:21:45] (03PS2) 10Tim Starling: REST: call MediaWiki::preOutputCommit and doPostOutputShutdown [core] - 10https://gerrit.wikimedia.org/r/530462 [04:28:59] (03CR) 10Tim Starling: "> Probably a call to MediaWiki::preOutputCommit() should be added somewhere in here too. Whether you do that in this patch or a separate p" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530462 (owner: 10Tim Starling) [04:36:03] (03Merged) 10jenkins-bot: title: Fix flaky TitlePermissionTest::testUserBlock [core] - 10https://gerrit.wikimedia.org/r/532244 (https://phabricator.wikimedia.org/T231166) (owner: 10Krinkle) [04:45:44] 10MediaWiki-extensions-Translate, 10translatewiki.net: Add PLURAL validators for projects using the new Validator framework - https://phabricator.wikimedia.org/T231181 (10abi_) [04:45:57] 10MediaWiki-extensions-Translate, 10translatewiki.net: Add PLURAL validators for projects using the new Validator framework - https://phabricator.wikimedia.org/T231181 (10abi_) [04:46:02] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [04:50:57] (03CR) 10jenkins-bot: title: Fix flaky TitlePermissionTest::testUserBlock [core] - 10https://gerrit.wikimedia.org/r/532244 (https://phabricator.wikimedia.org/T231166) (owner: 10Krinkle) [05:25:13] 10InternetArchiveBot: Find all InternetArchiveBot activities related to an external site - https://phabricator.wikimedia.org/T202958 (10Cyberpower678) 05Open→03Invalid Unclear what is being asked. If it's what I think it is, this beyond the scope of IABot and not doable. [05:42:09] (03PS1) 10Pwirth: Fix version [extensions/BlueSpiceSocialResolve] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532288 [05:42:24] (03PS1) 10Pwirth: Fix version [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532289 [05:42:48] (03CR) 10Pwirth: [C: 03+2] Fix version [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532289 (owner: 10Pwirth) [05:42:52] (03CR) 10Pwirth: [C: 03+2] Fix version [extensions/BlueSpiceSocialResolve] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532288 (owner: 10Pwirth) [05:44:56] (03CR) 10Pwirth: [C: 03+2] Rearrange language links in header [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531674 (owner: 10Dvogel hallowelt) [05:45:02] (03PS1) 10Pwirth: Rearrange language links in header [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/532290 [05:45:05] (03CR) 10Pwirth: [C: 03+2] Rearrange language links in header [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/532290 (owner: 10Pwirth) [05:50:29] (03Merged) 10jenkins-bot: Fix version [extensions/BlueSpiceSocialBlog] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532289 (owner: 10Pwirth) [05:50:44] (03Merged) 10jenkins-bot: Fix version [extensions/BlueSpiceSocialResolve] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/532288 (owner: 10Pwirth) [05:50:45] (03Merged) 10jenkins-bot: Rearrange language links in header [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531674 (owner: 10Dvogel hallowelt) [05:50:48] (03Merged) 10jenkins-bot: Rearrange language links in header [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/532290 (owner: 10Pwirth) [05:52:56] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Language-Team (Language-2019-July-September), 10Patch-For-Review, 10User-abi_: Migrate a few projects to the new Validator framework - https://phabricator.wikimedia.org/T224025 (10abi_) [06:04:33] (03PS1) 10Aaron Schulz: rdbms: simplify comment in LoadBalancer::reuseConnection() [core] - 10https://gerrit.wikimedia.org/r/532291 [06:16:23] 10Space (Jul-Sep-2019): In Space blog the "No comments" link doesn't work - https://phabricator.wikimedia.org/T229851 (10Qgil) a:03CKoerner_WMF [06:18:23] (03CR) 10Tim Starling: [C: 04-1] "In the description of T221177, I proposed allowing parameter types to be specified in the JSON routes file. I don't think it was discussed" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [06:22:01] (03Abandoned) 10Tim Starling: [WIP] stubs for Router::executeHandler subtasks [core] - 10https://gerrit.wikimedia.org/r/510636 (owner: 10Tim Starling) [06:23:45] 10MediaWiki-REST-API: MediaWiki REST API router should handle HEAD requests - https://phabricator.wikimedia.org/T226043 (10tstarling) [06:25:34] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [06:31:06] 10WMSE-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) [06:32:06] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Implement time-to-first-paragraph using Element Timing - https://phabricator.wikimedia.org/T230808 (10Peter) Time to first paragraph = FCP = First paint for us. I wonder if we have... [06:33:04] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/532295 [06:33:25] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/532294 (owner: 10L10n-bot) [06:37:47] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [core] - 10https://gerrit.wikimedia.org/r/532294 (owner: 10L10n-bot) [06:38:12] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Story: Reader gets a page - https://phabricator.wikimedia.org/T229663 (10tstarling) Like @mobrovac I think it's very unclear what sort of reader would want a page as JSON, and what should be in the JSON. Is the user here rea... [06:39:35] 10MediaWiki-REST-API, 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Story: REST: Reader gets a page - https://phabricator.wikimedia.org/T229663 (10tstarling) [06:53:20] (03PS2) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/532295 [06:56:41] 10CPT Initiatives (Core REST API in PHP), 10Core Platform Team Workboards (Green), 10Story: Contributor updates a page - https://phabricator.wikimedia.org/T230843 (10tstarling) This is a long way short of being a functional edit API. Have a look at ApiEditPage, it has 27 parameters, this proposal has 4. And... [06:56:56] 10Community-Tech (Kanban (Q1 2019-20)): Spike: Password Reset Project [Timebox: 12 hours] - https://phabricator.wikimedia.org/T230436 (10MaxSem) > Investigate the technical and UX considerations of requiring both a username and email address to successfully generate a password reset request email Technically, i... [06:59:03] (03CR) 10Nischayn22: [V: 03+2 C: 03+2] Fix for T196760 [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/530694 (owner: 10Nischayn22) [07:01:59] (03CR) 10Mooeypoo: [C: 03+1] "LGTM, but didn't test yet. Awaiting for other comments to resolve before merging." (034 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/530977 (https://phabricator.wikimedia.org/T230455) (owner: 10MusikAnimal) [07:18:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/532311 (owner: 10L10n-bot) [07:21:33] 10Mathe für Nicht-Freaks: Artikel "Untervektorraum" besenrein machen - https://phabricator.wikimedia.org/T210058 (10ZornschesLemma) Der Inhaltsplan der ersten Hälfte ist eingearbeitet. Das kann schon ausformuliert werden. Die zweite Hälfte ist noch nicht überarbeitet, ist aber grob geplant. [07:22:01] (03PS1) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/532330 [07:22:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/532314 (owner: 10L10n-bot) [07:22:19] 10Mathe für Nicht-Freaks: Artikel "Untervektorraum" - https://phabricator.wikimedia.org/T210058 (10ZornschesLemma) [07:23:48] 10MediaWiki-extensions-DocBookExport: DocBookExport: Fails when $wgJobRunRate === 0 - https://phabricator.wikimedia.org/T196760 (10Nischayn22) 05Open→03Resolved [07:24:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/532294 (owner: 10L10n-bot) [07:25:19] (03CR) 10Bmansurov: [C: 03+1] "We have to remove the +2 and add it again, I think." [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/523779 (https://phabricator.wikimedia.org/T216750) (owner: 10Usmanmuhd) [07:26:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532309 (owner: 10L10n-bot) [07:28:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/532315 (owner: 10L10n-bot) [07:29:04] 10Security-Team: Create incident play by play dashboard - https://phabricator.wikimedia.org/T221664 (10Dsharpe) 05Open→03Declined [07:30:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/532312 (owner: 10L10n-bot) [07:33:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/532322 (owner: 10L10n-bot) [07:40:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532321 (owner: 10L10n-bot) [07:42:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/532323 (owner: 10L10n-bot) [07:43:22] 10MediaWiki-REST-API, 10CPT Initiatives (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Workboards (Green), 10Patch-For-Review, 10Services (watching): REST API i18n - https://phabricator.wikimedia.org/T226598 (10tstarling) > That strikes me as rather dangerous. The caller has no way to know wheth... [07:44:08] 10MediaWiki-Change-tagging, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Bridge-Sprint-3, and 3 others: Add tags parameter to Wikibase APIs that edit entities - https://phabricator.wikimedia.org/T229917 (10Lydia_Pintscher) Moving back to todo to get the list. [07:50:18] 10WMEE: Wikiedu/Outreach Dashboardi tõlkimine eesti keelde - https://phabricator.wikimedia.org/T225356 (10tramm) [07:51:16] (03PS3) 10Daimona Eaytoy: Tell AbuseFilter not to filter moves during a rename [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) [07:51:20] (03PS4) 10Ankita Mandal: Fixed order_by css styling of autocompletion list. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 [07:51:31] (03Abandoned) 10Daimona Eaytoy: Temporarily exclude Jobs from TitleMove hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482408 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [07:52:01] 10WMEE: Wikiedu/Outreach Dashboardi tõlkimine eesti keelde - https://phabricator.wikimedia.org/T225356 (10tramm) Tõlge valmib 30. septembri hommikuks. [07:53:08] (03PS5) 10Ankita Mandal: Updated tooltip alias messages. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) [07:57:01] (03CR) 10Daimona Eaytoy: [C: 04-2] "Good, thanks! Leaving the -2 as precaution, can be removed after WMF production is ALTERed." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) (owner: 10DannyS712) [08:00:49] (03CR) 10Daimona Eaytoy: [C: 04-1] "I don't agree with the CSS part, OK for the readme" (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [08:00:56] (03PS2) 10simetrical: Reset services in setContentLang() for tests [core] - 10https://gerrit.wikimedia.org/r/532261 [08:04:17] (03PS3) 10Daimona Eaytoy: Fix data types for Postgres [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/530770 (https://phabricator.wikimedia.org/T230672) [08:04:25] (03CR) 10Daimona Eaytoy: "> Thanks for the patch! Unfortunately this isn't all that's needed, I" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/530770 (https://phabricator.wikimedia.org/T230672) (owner: 10Daimona Eaytoy) [08:04:46] (03CR) 10MarcoAurelio: [C: 03+2] "Poking jenkins." [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/523779 (https://phabricator.wikimedia.org/T216750) (owner: 10Usmanmuhd) [08:06:04] (03Merged) 10jenkins-bot: Replace Wikidata Query Service with MediaWiki API [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/523779 (https://phabricator.wikimedia.org/T216750) (owner: 10Usmanmuhd) [08:06:16] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Implement time-to-first-paragraph using Element Timing - https://phabricator.wikimedia.org/T230808 (10Gilles) This is precisely to figure out if there is a meaningful difference in... [08:07:39] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Convert Translate to use extension registration - https://phabricator.wikimedia.org/T87985 (10Nikerabbit) [08:08:30] (03PS13) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [08:13:59] 10MediaWiki-File-management, 10Commons, 10Operations, 10Traffic, and 2 others: Picture from Commons not found from Singapore - https://phabricator.wikimedia.org/T231086 (10Joe) p:05Triage→03Normal [08:15:56] (03PS2) 10Daimona Eaytoy: Add new number syntax as experimental [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/529475 (https://phabricator.wikimedia.org/T212730) [08:16:51] 10CommRel-Specialists-Support (Jul-Sep-2019): Help with massmessage! - https://phabricator.wikimedia.org/T230748 (10Elitre) @Whatamidoing-WMF @Rmaung I thought https://meta.wikimedia.org/wiki/Community_Insights/Translation/2019/1-Invitation was the only message out there, then I stumbled on https://meta.wikimedi... [08:17:05] 10Recommendation-API, 10Research, 10Article-Recommendation, 10Google-Summer-of-Code (2019), 10Patch-For-Review: Article recommendation API: replace WDQS with MW API - https://phabricator.wikimedia.org/T216750 (10Joe) @leila I just stumbled upon this task, and besides being happy that patch was merged I'm... [08:17:23] (03PS49) 10Daimona Eaytoy: Split afl_filter in afl_filter_id and afl_global [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/459818 (https://phabricator.wikimedia.org/T220791) [08:17:50] 10CommRel-Specialists-Support (Jul-Sep-2019): Help with massmessage! - https://phabricator.wikimedia.org/T230748 (10Elitre) [08:17:52] 10CommRel-Specialists-Support (Jul-Sep-2019): Volunteer translator help for Community Insights Survey - https://phabricator.wikimedia.org/T228548 (10Elitre) [08:18:45] 10MediaWiki-Page-protection, 10MediaWiki-Uploading: [BUG] File protected status not immediately updated; temporarily allows reupload - https://phabricator.wikimedia.org/T231069 (10dom_walden) >>! In T231069#5434475, @Tgr wrote: > It makes little sense that having the page open would affect permission handling... [08:18:58] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test-and-publish" [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/523779 (https://phabricator.wikimedia.org/T216750) (owner: 10Usmanmuhd) [08:19:00] (03CR) 10jenkins-bot: Replace Wikidata Query Service with MediaWiki API [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/523779 (https://phabricator.wikimedia.org/T216750) (owner: 10Usmanmuhd) [08:19:56] (03PS1) 10simetrical: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 [08:20:42] 10MediaWiki-Cache, 10MediaWiki-Internationalization: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Nikerabbit) [08:22:40] (03PS18) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [08:24:10] 10ContentTranslation, 10Malayalam-Sites: Make content translation suggestion popup menu not intrusive - https://phabricator.wikimedia.org/T213750 (10Elitre) @Pginer-WMF , while talking to @Praveenp about Boost at ml.wp, this task was brought up again. I see that the related task was actually resolved recently,... [08:24:53] (03CR) 10DannyS712: [C: 03+1] "Looks good to me" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/529917 (https://phabricator.wikimedia.org/T212082) (owner: 10Daimona Eaytoy) [08:26:20] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [08:27:47] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [08:28:39] 10MediaWiki-extensions-NSFileRepo, 10Continuous-Integration-Config: NSFileRepo depends upon Lockdown extension - https://phabricator.wikimedia.org/T185610 (10hashar) 05Open→03Resolved a:03Pwirth I guess that is solved so :) [08:29:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [08:29:47] (03CR) 10DannyS712: Cleanup readme and css, no change to code (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [08:30:31] (03CR) 10simetrical: LanguageFactory to replace Language::factory() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:30:43] 10MediaWiki-Cache, 10MediaWiki-Internationalization: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Nikerabbit) p:05Triage→03Unbreak! Git bisect points to {e4468a1d6b6b9fdc5b64800febdc8748d21f213d}. Setting UBN! for attention. I feel this doesn't affect everyone, though, or... [08:31:22] (03CR) 10Nikerabbit: "This seems to have broken LC very badly: T231183" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [08:31:27] (03PS4) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [08:31:29] (03PS6) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [08:31:31] (03PS6) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [08:31:33] (03PS23) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [08:35:30] 10BlueSpice: [BlueSpiceExtendedStatistics] BSApiStatisticsTasksTest::testGetData : API reported failure - https://phabricator.wikimedia.org/T199719 (10hashar) [08:35:49] 10BlueSpice: [BlueSpiceUsageTracker] autoloader entries are broken - https://phabricator.wikimedia.org/T199775 (10hashar) [08:36:05] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [08:36:28] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [08:40:31] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:42:22] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:47:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [08:49:25] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10User-DannyS712: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10DannyS712) p:05Triage→03Normal a:03DannyS712 [08:52:58] 10MediaWiki-Cache, 10MediaWiki-Internationalization: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Nikerabbit) Does not revert cleanly. Only workaround seems to be to roll back to commit before it. [08:53:00] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [08:53:01] (03CR) 10Daimona Eaytoy: [C: 04-1] Cleanup readme and css, no change to code (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [08:55:20] (03CR) 10Tchanders: [C: 04-1] WIP Introduce a formatter service for block errors [core] - 10https://gerrit.wikimedia.org/r/528918 (https://phabricator.wikimedia.org/T227174) (owner: 10Tchanders) [08:56:38] (03PS1) 10simetrical: [DNM] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 [08:57:23] (03Abandoned) 10simetrical: Reset services in setContentLang() for tests [core] - 10https://gerrit.wikimedia.org/r/532261 (owner: 10simetrical) [08:57:36] (03PS2) 10simetrical: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 [08:58:32] (03CR) 10simetrical: "I was surprised by how few failures there were. Given how little breakage this causes, I think we should definitely take it. In some cases" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [08:58:48] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [08:59:18] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [09:03:37] 10WMSE-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) Svar FB {F30116329,width=800} [09:05:46] (03CR) 10Mglaser: [C: 03+1] "looks good, waiting for i18n" [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/531494 (owner: 10ItSpiderman) [09:06:02] (03CR) 10ItSpiderman: [C: 04-1] Add phpcs (034 comments) [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/532295 (owner: 10Pwirth) [09:06:38] 10ISA: Warning message on next/previous image with unsaved changes - https://phabricator.wikimedia.org/T226304 (10NavinoEvans) [09:07:09] (03CR) 10ItSpiderman: [C: 04-1] Add phpcs (031 comment) [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/532330 (owner: 10Pwirth) [09:09:35] (03PS19) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [09:12:08] 10WMSE-Riksarkivet-NAD: Feature request: URL to the archive with NAD number as argument that always work - https://phabricator.wikimedia.org/T200046 (10Salgo60) Svar FB {F30116329,width=600} email skickat riksarkivet@riksarkivet.se {F30116357,width=600} [09:12:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [09:12:53] (03PS3) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/532295 [09:13:45] (03PS4) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/532295 [09:13:47] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [09:14:07] (03CR) 10Mathew.onipe: "recheck" [services/kartotherian] - 10https://gerrit.wikimedia.org/r/530836 (https://phabricator.wikimedia.org/T223275) (owner: 10Mathew.onipe) [09:14:11] (03PS2) 10Pwirth: Add phpcs [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/532330 [09:14:38] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10User-DannyS712: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10DannyS712) Preliminary API plan, which doesn't allow //all// of the functionality of the special page, but is the first step: Parameters: * Filter: inte... [09:14:59] 10Article-Recommendation, 10Google-Summer-of-Code (2019): Improve article recommendation pipeline - https://phabricator.wikimedia.org/T217655 (10Usmanmuhd) [09:15:01] 10Recommendation-API, 10Research, 10Article-Recommendation, 10Google-Summer-of-Code (2019), 10Patch-For-Review: Article recommendation API: replace WDQS with MW API - https://phabricator.wikimedia.org/T216750 (10Usmanmuhd) 05Open→03Resolved [09:15:18] 10WMSE-Riksarkivet-TORA: Task to gather questions WD <> Alvin - https://phabricator.wikimedia.org/T226099 (10Salgo60) [09:15:29] 10WMSE-Riksarkivet-TORA: Task to gather questions WD <> Alvin - https://phabricator.wikimedia.org/T226099 (10Salgo60) [09:18:17] (03CR) 10jerkins-bot: [V: 04-1] Prepare pipeline for deployment [services/kartotherian] - 10https://gerrit.wikimedia.org/r/530836 (https://phabricator.wikimedia.org/T223275) (owner: 10Mathew.onipe) [09:18:49] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10User-DannyS712: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10Daimona) >>! In T213037#5437164, @DannyS712 wrote: > @Huji @Daimona #core_platform_team Is it okay to be introducing an api module that wouldn't include... [09:20:55] 10ISA: Change "images improved" to "contributions" on stats tables - https://phabricator.wikimedia.org/T231186 (10NavinoEvans) [09:22:03] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [09:22:17] 10ISA: Change "images improved" to "contributions" on stats tables - https://phabricator.wikimedia.org/T231186 (10NavinoEvans) [09:22:42] 10ISA: Change "images improved" to "contributions" on stats tables - https://phabricator.wikimedia.org/T231186 (10NavinoEvans) p:05Triage→03Low [09:23:50] (03PS1) 10PortalsBuilder: Assets build - 2019-08-26 09:23:46+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/532338 [09:23:52] 10ISA: Add info popup text for caption languages selection - https://phabricator.wikimedia.org/T231187 (10NavinoEvans) [09:23:59] 10ISA: Add info popup text for caption languages selection - https://phabricator.wikimedia.org/T231187 (10NavinoEvans) p:05Triage→03Normal [09:24:17] 10ISA: Non latin script in Campaign title breaks it completely - https://phabricator.wikimedia.org/T231167 (10NavinoEvans) a:03Eugene233 [09:25:54] 10MediaWiki-History-and-Diffs: No difference shown in history whereas there is a difference of 1 bit in the diff - https://phabricator.wikimedia.org/T231141 (10WMDE-Fisch) [09:25:56] 10MediaWiki-History-and-Diffs: Diffs of trailing newlines addition and removal don't work properly - https://phabricator.wikimedia.org/T44669 (10WMDE-Fisch) [09:27:32] 10MediaWiki-History-and-Diffs: Diffs of trailing newlines addition and removal don't work properly - https://phabricator.wikimedia.org/T44669 (10WMDE-Fisch) [09:28:03] (03PS2) 10simetrical: [DNM] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 [09:28:19] (03PS3) 10simetrical: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 [09:28:22] (03PS1) 10simetrical: Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 [09:28:40] 10ContentTranslation, 10Language-Team (Language-2019-July-September): References using template:Cite arXiv would be corrupted - https://phabricator.wikimedia.org/T230770 (10Pginer-WMF) p:05Triage→03Normal [09:28:42] (03CR) 10ItSpiderman: [C: 03+1] "Waiting for i18n review" [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/525261 (owner: 10Pwirth) [09:29:33] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Tracking-Neverending: CX2: Support for References - https://phabricator.wikimedia.org/T200786 (10Pginer-WMF) [09:29:35] 10ContentTranslation, 10Language-Team (Language-2019-July-September): References using template:Cite arXiv would be corrupted - https://phabricator.wikimedia.org/T230770 (10Pginer-WMF) [09:34:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [09:34:47] 10MediaWiki-Cache, 10MediaWiki-Internationalization: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) You need to revert LanguageNameUtils too, then it works fine (other than RELEASE-NOTES conflicts, obviously): 2e52f48c2ed Obviously someone should revert immediately.... [09:37:51] 04(no projects): document statement sorting - https://phabricator.wikimedia.org/T231189 (10Lydia_Pintscher) [09:40:20] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [09:40:49] 10ISA, 10Patch-For-Review: Can't remove existing captions - https://phabricator.wikimedia.org/T231133 (10NavinoEvans) a:03NavinoEvans [09:41:11] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [09:41:20] 10MediaWiki-Cache, 10MediaWiki-Internationalization: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) I think I see the problem: ` + $storeArg['directory'] = + $conf['storeDirectory'] ?? $services->getMainConfig()->get( 'CacheDirectory' ); ` vs. ` -... [09:45:38] (03PS1) 10simetrical: Correctly register storeDirectory in l10n cache [core] - 10https://gerrit.wikimedia.org/r/532343 (https://phabricator.wikimedia.org/T231183) [09:46:36] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Patch-For-Review: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) The breakage of rebuildLocalisationCache.php is an entirely separate problem. Separate patch coming for that. See, this is why tests before refac... [09:52:35] 10Quibble: Remove composer dump-autoload --optimize from mw-fetch-composer-dev.sh and Quibble - https://phabricator.wikimedia.org/T181940 (10hashar) [09:53:20] 10MediaWiki-Core-Testing, 10Operations, 10HHVM: Re-add complete URL parsing fix from 3.18.7 release - https://phabricator.wikimedia.org/T185024 (10hashar) [09:53:41] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [09:54:22] (03CR) 10jerkins-bot: [V: 04-1] Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [09:56:11] (03PS1) 10simetrical: Pass correct store to rebuildLocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/532346 [09:56:48] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Patch-For-Review: L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) So those two patches should fix the two issues that you ran into. I leave it up to the people with +2 access to decide whether it's wise to just... [09:57:14] (03PS2) 10simetrical: Pass correct store to rebuildLocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/532346 (https://phabricator.wikimedia.org/T231183) [10:01:43] (03Abandoned) 10D3r1ck01: parser: Strip off HTML comments from/beside image name [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [10:01:44] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Translation issues "Next Issue" button doesn't work: Uncaught TypeError: Cannot read property 'id' of undefined - https://phabricator.wikimedia.org/T229230 (10Nikerabbit) T... [10:17:12] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Spike: Investigate relationship of book referencing project and parsers - https://phabricator.wikimedia.org/T230920 (10WMDE-Fisch) [10:17:14] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Patch-For-Review, 10Spike: Investigation: Where would we need to do changes in order to display book references correctly in the VisualEditor - https://phabricator.wikimedia.org/T231004 (10WMDE-Fisch) 05Open→03Resolved The above PoC gives a good rough understanding f... [10:17:28] 10 WMDE-QWERTY-Sprint-2019-08-21 , 10Spike: Investigate relationship of book referencing project and parsers - https://phabricator.wikimedia.org/T230920 (10WMDE-Fisch) [10:18:12] (03PS1) 10Samwilson: Remove 'broken' group from ArticleMetadataTest [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/532349 [10:18:40] 10MediaWiki-Watchlist, 10Growth-Team: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10DannyS712) Now at https://www.mediawiki.org/wiki/File:T25387.png [10:19:38] 10ISA: Random unlabeled starting file? - https://phabricator.wikimedia.org/T230210 (10Astinson) Thanks all! [10:23:44] 10ISA: Suggest most frequently use depicts statements - https://phabricator.wikimedia.org/T231193 (10Astinson) [10:27:32] (03CR) 10Jdrewniak: "recheck" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/532338 (owner: 10PortalsBuilder) [10:30:27] (03CR) 10jerkins-bot: [V: 04-1] Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [10:31:21] (03CR) 10Jdrewniak: [C: 03+2] Assets build - 2019-08-26 09:23:46+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/532338 (owner: 10PortalsBuilder) [10:31:57] (03Merged) 10jenkins-bot: Assets build - 2019-08-26 09:23:46+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/532338 (owner: 10PortalsBuilder) [10:32:51] (03CR) 10Ladsgroup: [C: 03+1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [10:35:21] (03PS1) 10Mobrovac: [TEMP] cirusSearchCheckerJob: Increase concurrency to 20 [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/532357 [10:36:31] (03PS4) 10DannyS712: Cleanup readme, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) [10:36:59] (03PS5) 10DannyS712: Cleanup readme, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) [11:01:01] 10MediaWiki-Watchlist, 10Growth-Team: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10kostajh) See also T220245 which proposes to change this further. [11:02:58] (03CR) 10Esanders: [C: 03+1] mobile.init/editor: Use the same loading transition for wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529452 (https://phabricator.wikimedia.org/T228159) (owner: 10Bartosz Dziewoński) [11:05:37] 10Accessibility, 10MediaWiki-User-login-and-signup, 10Browser-Support-Apple-Safari: Log in form is missing critical components through keyboard navigation in Safari - https://phabricator.wikimedia.org/T216834 (10TheDJ) Yeah this is one of Safari's quirks. By default tab navigation only works between textfiel... [11:09:09] 10Wikidata-Bridge: Context-aware save button - https://phabricator.wikimedia.org/T230342 (10Pablo-WMDE) [11:10:32] 10Space: Randomly stuck in saving loop - https://phabricator.wikimedia.org/T230009 (10Elitre) I'd like to acknowledge that I may have figured out what my issue was. I had "just" forgotten that I had actually just installed Privacy Badger. Hence, following your guide should have fixed things now. [11:13:05] (03PS24) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [11:14:41] (03PS1) 10Jakob: Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) [11:16:36] (03CR) 10jerkins-bot: [V: 04-1] Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [11:16:39] 10MediaWiki-Change-tagging, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Bridge-Sprint-3, and 3 others: Add tags parameter to Wikibase APIs that edit entities - https://phabricator.wikimedia.org/T229917 (10Pablo-WMDE) Hi @Lydia_Pintscher & @Lea_Lacroix_WMDE, the API modules which gain... [11:17:34] (03PS2) 10Jakob: Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) [11:19:10] (03CR) 10Daimona Eaytoy: [C: 03+2] Cleanup readme, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [11:19:13] (03PS3) 10Jakob: Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) [11:25:21] (03CR) 10Jakob: "This change is ready for review." [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [11:29:08] (03PS2) 10Krinkle: language: Move ConverterRule to includes/ and add unit test [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) [11:29:47] (03PS4) 10simetrical: Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 [11:29:49] (03PS2) 10simetrical: Remove unneeded overrideMwServices/resetServices [core] - 10https://gerrit.wikimedia.org/r/532340 [11:32:22] (03CR) 10Noa wmde: [C: 03+1] Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [11:32:24] (03PS3) 10Krinkle: language: Move ConverterRule to includes/ and add test case [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) [11:32:26] (03PS4) 10Krinkle: language: Move ConverterRule to includes/ and add test case [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) [11:37:13] (03CR) 10DCausse: [C: 03+1] [TEMP] cirusSearchCheckerJob: Increase concurrency to 20 (031 comment) [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/532357 (owner: 10Mobrovac) [11:37:14] (03CR) 10Krinkle: "Why are these no longer needed, where they ever needed?" [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [11:38:12] (03CR) 10Ladsgroup: [C: 03+2] Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [11:39:29] (03PS2) 10Mobrovac: [TEMP] cirusSearchCheckerJob: Increase concurrency to 20 [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/532357 (https://phabricator.wikimedia.org/T231194) [11:40:26] (03CR) 10Krinkle: [C: 03+2] Correctly register storeDirectory in l10n cache [core] - 10https://gerrit.wikimedia.org/r/532343 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [11:40:29] (03CR) 10Mobrovac: [V: 03+2 C: 03+2] [TEMP] cirusSearchCheckerJob: Increase concurrency to 20 [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/532357 (https://phabricator.wikimedia.org/T231194) (owner: 10Mobrovac) [11:41:06] (03CR) 10Krinkle: "I suspect this would make tests significantly slower. Can you verify that it does/doesn't? Eyeballing the jobs that are passing so far, th" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [11:43:23] (03CR) 10simetrical: "A few were never needed, but most are no longer needed because of the parent commit." [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [11:45:00] (03PS3) 10simetrical: Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 [11:46:38] (03PS6) 10simetrical: [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [11:49:33] (03PS4) 10simetrical: Correctly format null error reporting level [core] - 10https://gerrit.wikimedia.org/r/465153 [11:54:08] 10MediaWiki-Documentation, 10Wikibase-Lua, 10Wikidata, 10Wikidata-Campsite: Update Wikibase Lua documentation - https://phabricator.wikimedia.org/T225497 (10Lea_Lacroix_WMDE) Hello @RolandUnger, this task is present in our (quite huge) to-do list and we didn't forget about it. However, it is currently bloc... [11:57:36] (03CR) 10Krinkle: [C: 03+2] Pass correct store to rebuildLocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/532346 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [11:58:54] (03CR) 10Ladsgroup: [C: 03+2] language: Move ConverterRule to includes/ and add test case [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [11:59:49] (03CR) 10Krinkle: "How does it remove tests?" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [12:03:03] (03CR) 10Ladsgroup: "> Patch Set 4:" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [12:03:04] 10WMEE: Vikipeedia sünnipäeva üritus Tartus 24. augustil 2019 - https://phabricator.wikimedia.org/T230929 (10tramm) 05Open→03Resolved [12:04:11] (03PS6) 10Pmiazga: skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 [12:04:16] (03CR) 10Krinkle: "Ah it moves, not removes. I thought maybe there were some inherited test cases like testCovers that are in Integration* but not Unit*. OK." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [12:04:26] (03CR) 10Krinkle: [C: 03+1] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [12:04:57] 10MediaWiki-extensions-Scribunto, 10Code-Health, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Migrate Scribunto to stop using MediaWikiIntegrationTestCase on unit tests - https://phabricator.wikimedia.org/T230701 (10Krinkle) [12:05:02] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [12:06:54] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [12:11:59] (03Abandoned) 10Reedy: [WIP] Use AuthManager data change methods [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/294861 (https://phabricator.wikimedia.org/T110457) (owner: 10Gergő Tisza) [12:12:10] (03CR) 10Krinkle: [C: 03+1] skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [12:13:01] (03CR) 10Krinkle: [C: 03+1] "LGTM. CC-ing @simetrical who's been doing a lot of similar work and might have additional ideas or catch things from a consistency point o" [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [12:13:24] (03PS2) 10Reedy: Add method to clear all keys associated with the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/531602 (owner: 10ItSpiderman) [12:13:32] (03CR) 10Reedy: [C: 03+2] "Obviously not plumbed in anywhere yet..." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/531602 (owner: 10ItSpiderman) [12:21:07] (03PS1) 10D3r1ck01: export: Inject CommentStore into WikiExporter and XmlDumpWriter [core] - 10https://gerrit.wikimedia.org/r/532364 [12:24:25] 10MediaWiki-General: $wgActorTableSchemaMigrationStage = SCHEMA_COMPAT_NEW; brings down translatewiki.net - https://phabricator.wikimedia.org/T231196 (10Nikerabbit) [12:24:56] 10MediaWiki-General: $wgActorTableSchemaMigrationStage = SCHEMA_COMPAT_NEW; brings down translatewiki.net - https://phabricator.wikimedia.org/T231196 (10Nikerabbit) [12:24:59] 10MediaWiki-General, 10Tracking-Neverending: Issues affecting translatewiki.net - https://phabricator.wikimedia.org/T41480 (10Nikerabbit) [12:26:31] (03CR) 10Nikerabbit: "I'd appreciate if this was not merged before I have found solution to T231196" [core] - 10https://gerrit.wikimedia.org/r/525605 (https://phabricator.wikimedia.org/T188327) (owner: 10Anomie) [12:29:35] (03PS2) 10D3r1ck01: export: Inject CommentStore into WikiExporter and XmlDumpWriter [core] - 10https://gerrit.wikimedia.org/r/532364 [12:30:04] (03PS1) 10TK-999: rdbms: Defer instantiating the DBLoadBalancerFactory service [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) [12:30:45] (03PS1) 10simetrical: Change config only before we've started testing [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532368 [12:30:52] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [12:31:43] (03PS1) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [12:35:40] (03CR) 10simetrical: [C: 03+1] "LGTM, thanks!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [12:36:57] 10MediaWiki-Comment-backend, 10Editing-team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, and 2 others: The "Prompt me when entering a blank edit summary" wrongly triggers for undo edits - https://phabricator.wikimedia.org/T10912 (10mobrovac) [12:37:09] (03CR) 10Daimona Eaytoy: [C: 03+2] "Looks good, thanks. This also avoids situations where you forget to add the cache type to a new test, and waste lots of time trying to und" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532368 (owner: 10simetrical) [12:39:48] (03PS7) 10simetrical: [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [12:40:02] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532340 (owner: 10simetrical) [12:40:34] (03CR) 10Ladsgroup: "Any chance this can be moved forward? merged, abandoned. Anything." [core] - 10https://gerrit.wikimedia.org/r/413891 (https://phabricator.wikimedia.org/T135155) (owner: 10Ladsgroup) [12:42:02] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Tracking-Neverending: CX2: Support for References - https://phabricator.wikimedia.org/T200786 (10Jpita) [12:42:50] 10MediaWiki-Internationalization, 10Wikimania-Hackathon-2019, 10translatewiki.net, 10Google-Code-in-2019, and 2 others: Hunt and remove unused i18n messages in mediawiki core - https://phabricator.wikimedia.org/T224429 (10Nikerabbit) I think best would be to require annotating all dynamic message uses (nea... [12:44:26] (03Abandoned) 10Ladsgroup: Add change_tag_statistics table to speed up tag hitcount retrieval [core] - 10https://gerrit.wikimedia.org/r/334337 (https://phabricator.wikimedia.org/T91535) (owner: 10Cenarium) [12:44:51] (03CR) 10Ladsgroup: "I think this should be abandoned now" [core] - 10https://gerrit.wikimedia.org/r/405375 (https://phabricator.wikimedia.org/T185355) (owner: 10Catrope) [12:45:46] (03CR) 10Catrope: [C: 04-1] resourceloader: Compile documentElement.className server-side (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) (owner: 10Krinkle) [12:46:02] (03CR) 10TerraCodes: [C: 03+1] Make `tog-forceeditsummary` message accurate. [core] - 10https://gerrit.wikimedia.org/r/530807 (https://phabricator.wikimedia.org/T10912) (owner: 10DannyS712) [12:46:21] 10Community-Tech (Kanban (Q1 2019-20)): Spike: Password Reset Project [Timebox: 12 hours] - https://phabricator.wikimedia.org/T230436 (10Prtksxna) Ooh, thanks for this @MaxSem 🤩So the proportion of no(~¼), unconfirmed(~½), and confirmed(~¼) emails looks something like this: {F30116738} Note that the total of ot... [12:47:15] (03PS6) 10Ankita Mandal: Updated tooltip alias messages. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) [12:48:28] (03Abandoned) 10Ankita Mandal: Improve the interface of Special:CargoQuery page in the Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532230 (owner: 10Ankita Mandal) [12:48:47] (03Abandoned) 10Ankita Mandal: CargoQuery messages updated. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/521184 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [12:50:07] (03CR) 10Ladsgroup: [C: 04-1] "Can this be abandoned?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/511018 (owner: 10Jdlrobson) [12:50:19] 10CX-TranslationList, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Articles in the "for later" list should be shown regardless of language selection for translation suggestions - https://phabricator.wikimedia.org/T194476 (10Jpita) 05Open→03Resolved [12:50:21] 10ContentTranslation, 10Epic: Design polishing for Content Translation - https://phabricator.wikimedia.org/T127695 (10Jpita) [12:50:32] (03Abandoned) 10Ladsgroup: [DNM] Noop [core] - 10https://gerrit.wikimedia.org/r/528787 (owner: 10Ladsgroup) [12:50:35] (03Abandoned) 10Ladsgroup: [DNM] Try running with array [core] - 10https://gerrit.wikimedia.org/r/529782 (owner: 10Ladsgroup) [12:51:10] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Convert Translate to use extension registration - https://phabricator.wikimedia.org/T87985 (10Jpita) 05Open→03Resolved [12:51:18] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal: Convert all Wikimedia-deployed extensions and skins to use extension registration - https://phabricator.wikimedia.org/T87875 (10Jpita) [12:52:26] (03CR) 10Catrope: [C: 03+2] Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [12:54:40] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/532364 (owner: 10D3r1ck01) [12:57:39] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [13:00:52] (03CR) 10jerkins-bot: [V: 04-1] Call resetServices() when setting globals in tests [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [13:03:15] (03CR) 10Ankita Mandal: ">" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [13:03:22] (03PS1) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [13:05:05] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [13:05:07] (03PS1) 10D3r1ck01: mail: Avoid use of global state and use MediaWiki services DI [core] - 10https://gerrit.wikimedia.org/r/532376 [13:08:16] (03CR) 10Alaa Sarhan: [C: 03+1] Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [13:09:08] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:09:17] (03PS18) 10D3r1ck01: Avoid usage of deprecated setTags() method, use addTags() instead [core] - 10https://gerrit.wikimedia.org/r/521178 [13:10:45] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:10:58] 10MediaWiki-extensions-Translate, 10Timeless: Timeless has a bit larger padding on Special:Translate - https://phabricator.wikimedia.org/T197037 (10Nikerabbit) It looks resolved to me. @Tacsipacsi can you confirm? [13:11:41] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:13:06] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [13:13:46] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [13:14:13] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [13:14:16] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [13:14:18] (03CR) 10D3r1ck01: "> Is this theoretical or have we seen an issue in the wild?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529783 (owner: 10D3r1ck01) [13:14:25] (03PS6) 10D3r1ck01: 🐛 AMC: Safe guard against when user not found in DB or anon user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529783 [13:14:29] (03CR) 10Ladsgroup: Split LuaEngineTestBase to LuaEngineUnitTestBase and LuaEngineTestBase (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/527854 (https://phabricator.wikimedia.org/T230701) (owner: 10Ladsgroup) [13:15:24] (03PS5) 10D3r1ck01: [parser][edit] Introduce IParser interface with `getOutput()` method [core] - 10https://gerrit.wikimedia.org/r/531314 [13:16:56] 10Accessibility, 10Design, 10ProveIt-Gadget: Mouseover help text under ProveIt header. - https://phabricator.wikimedia.org/T161958 (10Sophivorus) I have studied this issue and unfortunately it's not easy to fix. The tooltip hides behind the header because the entire form hides behind the header, so changing... [13:17:02] (03PS1) 10Gilles: Make max-age configurable for logged-out users [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) [13:20:32] 10Advanced Mobile Contributions, 10MinervaNeue, 10Mobile, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), and 2 others: Fix icon sizing by updating all 24x24 icons to 20x20 icons - https://phabricator.wikimedia.org/T229440 (10alexhollender) @Jdlrobson to clarify: it is not only the old SVGs... [13:21:53] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [13:22:25] (03Merged) 10jenkins-bot: Cleanup readme, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [13:22:28] (03Merged) 10jenkins-bot: Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [13:25:07] 10MediaWiki-API, 10AbuseFilter, 10Core Platform Team, 10User-DannyS712: AbuseFilter should have an edit API - https://phabricator.wikimedia.org/T213037 (10Huji) I second Daimona's comment: we should try to avoid technical debt as much as possible. And that I think this could be a good reason for us to try... [13:25:59] (03CR) 10Noa wmde: "recheck" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/531461 (https://phabricator.wikimedia.org/T230398) (owner: 10Rosalie Perside (WMDE)) [13:31:38] 10ProveIt-Gadget: proveit-tag not applied after 'Show preview' or 'Show changes' - https://phabricator.wikimedia.org/T154357 (10Sophivorus) 05Open→03Resolved This has been fixed for a while. [13:31:48] 10MediaWiki-Change-tagging, 10MediaWiki-Page-editing, 10VisualEditor, 10Wikimedia-Israel-Hackers, 10Patch-For-Review: Support tags from editing form - https://phabricator.wikimedia.org/T109032 (10Sophivorus) [13:32:25] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/532376 (owner: 10D3r1ck01) [13:33:30] (03PS2) 10ItSpiderman: Change protection rights assignments to correspond with MW defaults [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531878 [13:36:44] (03PS7) 10Ankita Mandal: Fixed bug in tooltip messages. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) [13:38:22] (03CR) 10Pwirth: [C: 04-1] Change protection rights assignments to correspond with MW defaults (031 comment) [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531878 (owner: 10ItSpiderman) [13:39:25] (03PS2) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [13:39:53] (03PS20) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [13:39:59] (03CR) 10jerkins-bot: [V: 04-1] Make max-age configurable for logged-out users [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) (owner: 10Gilles) [13:40:01] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [13:40:03] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [13:41:59] (03CR) 10D3r1ck01: [C: 03+2] "kicking Jenkins again per MaxSem!" [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [13:42:11] (03CR) 10ArielGlenn: "I"m just haveing a close look at the ticket and then I'll look at the code closely and do some tests this week." [core] - 10https://gerrit.wikimedia.org/r/531308 (https://phabricator.wikimedia.org/T228988) (owner: 10Ppchelko) [13:42:47] (03PS3) 10ItSpiderman: Change protection rights assignments to correspond with MW defaults [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531878 [13:43:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) - https://phabricator.wikimedia.org/T228293 (10alaa_wmde) These errors still appear in our logs. https://logstas... [13:44:06] (03PS21) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [13:44:08] (03PS2) 10Gilles: Make max-age configurable for logged-out users [core] - 10https://gerrit.wikimedia.org/r/532378 (https://phabricator.wikimedia.org/T231184) [13:45:12] (03PS3) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [13:48:12] (03CR) 10Pwirth: Add warn on leave for all modified entities to prevent data loss. ERM:7326 (031 comment) [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/525261 (owner: 10Pwirth) [13:49:57] (03CR) 10jerkins-bot: [V: 04-1] Adjust the save button of the Entity Schema editor [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/531461 (https://phabricator.wikimedia.org/T230398) (owner: 10Rosalie Perside (WMDE)) [13:50:07] (03CR) 10Jdrewniak: [C: 04-1] Icons should not be defined in stylesheets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (owner: 10Jdlrobson) [13:50:26] 10MediaWiki-File-management, 10DBA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar): Drop filejournal table from WMF - https://phabricator.wikimedia.org/T51195 (10Marostegui) I have renamed this table on `db2112.enwiki` and will leave it for a few hours to make sure nothing writes t... [13:50:30] (03CR) 10Catrope: [C: 04-1] Pass the user and context into BlockManager::getUserBlock (036 comments) [core] - 10https://gerrit.wikimedia.org/r/531946 (https://phabricator.wikimedia.org/T230363) (owner: 10Tchanders) [13:51:05] 10MediaWiki-File-management, 10DBA, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar): Drop filejournal table from WMF - https://phabricator.wikimedia.org/T51195 (10Marostegui) [13:54:23] (03CR) 10Ottomata: [C: 03+1] ":)" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/530446 (https://phabricator.wikimedia.org/T229863) (owner: 10Ppchelko) [13:54:25] (03Merged) 10jenkins-bot: Correctly register storeDirectory in l10n cache [core] - 10https://gerrit.wikimedia.org/r/532343 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [13:58:18] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Nikerabbit) https://gerrit.wikimedia.org/g/mediawiki/extensions/Translate/+/b3cdb6f7059cf102852dd096841e422... [13:58:42] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Nikerabbit) [13:59:13] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) - https://phabricator.wikimedia.org/T228293 (10alaa_wmde) [13:59:44] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) - https://phabricator.wikimedia.org/T228293 (10alaa_wmde) p:05Triage→03Normal [13:59:57] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [14:00:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Wikimedia-production-error: [4h invstigation] RevisionedUnresolvedRedirectException: Unresolved redirect from Q.. to Q.. (API and Job) - https://phabricator.wikimedia.org/T228293 (10alaa_wmde) [14:01:21] (03CR) 10jenkins-bot: Fix MediaWikiPageUpdaterFactoryTest::testGetPageUpdater [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/532360 (https://phabricator.wikimedia.org/T231065) (owner: 10Jakob) [14:02:12] 10Design, 10ProveIt-Gadget: Improve ProveIt's 'Add' page - https://phabricator.wikimedia.org/T166990 (10Sophivorus) 05Open→03Declined I evaluated this once more. Again, the difficulties seem to outdo the benefits. Deciding which fields should remain full-width and which ones half-width would require more f... [14:02:54] (03CR) 10Niedzielski: [C: 04-1] Upgrade to Sinon 4.5.0 (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/528500 (owner: 10Jdlrobson) [14:04:12] (03CR) 10jenkins-bot: Cleanup readme, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) (owner: 10DannyS712) [14:04:42] (03CR) 10Jdrewniak: Dev: Don't access globals inside components (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (owner: 10Jdlrobson) [14:08:39] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [14:09:11] (03PS4) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [14:11:08] (03CR) 10Nikerabbit: "Technically, this is a breaking change (previously there was a bug in core as opposed to documented behavior) to a public interface that s" [core] - 10https://gerrit.wikimedia.org/r/525196 (owner: 10Samwilson) [14:13:10] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Nikerabbit) > Parser::getTitle() is documented to return Title|null I just came acro... [14:13:29] (03PS1) 10Fomafix: Use local variabe $services instead of MediaWikiServices::getInstance() [core] - 10https://gerrit.wikimedia.org/r/532384 [14:13:32] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Nikerabbit) p:05Triage→03Normal [14:15:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [14:16:20] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [14:16:38] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Nikerabbit) I'm planning to leave this task unattended unless one of the following ha... [14:24:13] 10MediaWiki-Parser, 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle: "PageTranslationHooks.php": Call to a member function getIsSectionPreview() on null - https://phabricator.wikimedia.org/T228881 (10Kghbln) Thanks for the info. I am not sure if @Samwilson who authored the change is a... [14:24:42] 10WMEE: Võistkondlik 24h artiklivõistlus - https://phabricator.wikimedia.org/T231202 (10Lmk2K18) [14:31:27] 10GrowthExperiments, 10Epic, 10Growth-Team (Current Sprint): [EPIC] Growth: Welcome survey - https://phabricator.wikimedia.org/T206365 (10kostajh) [14:31:49] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [14:32:53] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 2 others: Click trash on recent changes doesn't clear open filter menus - https://phabricator.wikimedia.org/T231053 (10kostajh) @MMiller_WMF seems like this could go into a future quarter, un... [14:33:25] (03CR) 10jenkins-bot: Correctly register storeDirectory in l10n cache [core] - 10https://gerrit.wikimedia.org/r/532343 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [14:34:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 (owner: 10Daimona Eaytoy) [14:35:27] 10MediaWiki-Watchlist, 10Growth-Team: Improve watchlist/edit layout - https://phabricator.wikimedia.org/T25387 (10kostajh) 05Open→03Invalid Nothing especially actionable here so I'm going to mark this as invalid. As noted in T25387#5437418, the layout will probably change soon anyway as a result of the pat... [14:35:32] (03CR) 10Niedzielski: [C: 04-1] Document all our components in storybook (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [14:38:10] (03CR) 10Huji: Refactor and speed up other tests (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [14:40:19] 10Design, 10MediaWiki-Interface, 10Readers-Web-Backlog, 10TechCom-RFC, 10Patch-For-Review: RFC: Section headings should have a clickable anchor - https://phabricator.wikimedia.org/T18691 (10alexhollender) [14:41:55] 10ISA: Depicts suggestions based on chosen language - https://phabricator.wikimedia.org/T231034 (10Hatonjan) >>! In T231034#5434877, @NavinoEvans wrote: > I think we have this covered in {T230789} ? I's exactly that ! Thanks [14:43:26] 10MediaWiki-History-and-Diffs, 10MediaWiki-Recent-changes, 10MediaWiki-Special-pages, 10Growth-Team, 10patch-welcome: Please display revision length in characters, not bytes, in history and Recent Changes - https://phabricator.wikimedia.org/T27198 (10kostajh) This is not something the #Growth-team plans... [14:44:15] 10Wikidata-Bridge: Context-aware save button - https://phabricator.wikimedia.org/T230342 (10Pablo-WMDE) [14:45:18] 10Accessibility, 10Growth-Team, 10PageCuration: New page patrol uses only color to indicate patrol status - https://phabricator.wikimedia.org/T172765 (10kostajh) 05Open→03Invalid Marking as invalid per T172765#5434983, please reopen (with more detail please) if this is still an issue. [14:46:42] 10MediaWiki-General, 10Wikimedia-production-error: LegacyHandler.php: PHP Warning: Host lookup failed [-10002]: Unknown error -10002 - https://phabricator.wikimedia.org/T231025 (10Jdforrester-WMF) 05Resolved→03Invalid That'd be Invalid rather than Resolved then. ;-) [14:49:50] 10I18n: Wikimedia Shop should be translatable to all languages - https://phabricator.wikimedia.org/T39797 (10Nemo_bis) This is a valid task for #Wikimedia-General-or-Unknown: the shop is on an ever-changing software, so whatever is the current software's issue tracker matters little, but the overall task remain... [14:50:30] 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Remove redundant invite to create new page by translating - https://phabricator.wikimedia.org/T230362 (10Pginer-WMF) p:05Triage→03Normal [14:51:25] 10MediaWiki-Internationalization, 10Wikimania-Hackathon-2019, 10translatewiki.net, 10Google-Code-in-2019, and 2 others: Hunt and remove unused i18n messages in mediawiki core - https://phabricator.wikimedia.org/T224429 (10Nemo_bis) p:05Triage→03Low [14:51:28] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: JS Error occurs when cancelling writing a comment on mobile structured talk pages - https://phabricator.wikimedia.org/T230445 (10ovasileva) 05Open→03Resolved a:03o... [14:51:42] 10MediaWiki-extensions-WikibaseClient, 10SDC General, 10Structured Data Engineering, 10Wikibase-Lua, and 3 others: Extend mw.wikibase.getEntity lua function to allow accessing Structured Data on Commons items - https://phabricator.wikimedia.org/T223792 (10matthiasmullie) a:03matthiasmullie [14:51:45] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Trying to expand issues doesn't show content - https://phabricator.wikimedia.org/T226247 (10Jpita) Using the article from the description, translating from english to esperanto, I managed to fin... [14:53:45] 10Readers-Web-Backlog: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10alexhollender) [14:54:16] 10Structured Data Engineering, 10WikibaseMediaInfo, 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Statements with unsupported properties are displayed weirdly on edit - https://phabricator.wikimedia.org/T229679 (10matthiasmullie) 05Open→03Resolved a:03matthiasm... [14:54:28] (03CR) 10Krinkle: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [14:56:45] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): AMC Outreach - Modal - https://phabricator.wikimedia.org/T226068 (10ovasileva) [14:57:26] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Large numbers not handled properly in quantity qualifier field - https://phabricator.wikimedia.org/T227220 (10matthiasmullie) @Ramsey-WMF Is thi... [14:57:45] (03CR) 10Krinkle: "If the main cost of that 2% was the statements in Setup (apart from service creation), then another solution could be to set a callable th" [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [14:59:10] 10MediaWiki-Uploading, 10Multimedia, 10UploadWizard: 4 files, that will not upload with uploadwizard (Internal error: Server failed to store temporary file.) for server-side upload - https://phabricator.wikimedia.org/T229249 (10Urbanecm) @C.Suthorn Please answer my questions in T229249#5389462. If I won't he... [14:59:14] 10MobileFrontend, 10Readers-Web-Backlog: Circle for notification number is cut and not completely round on mobile web of MediaWiki - https://phabricator.wikimedia.org/T229902 (10alexhollender) 05Open→03Resolved a:03alexhollender Thanks @Jdlrobson. Confirming this is fixed on production: | {F30117318} | {... [14:59:28] 10Structured Data Engineering, 10WikibaseMediaInfo, 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Statements with unsupported properties are displayed weirdly on edit - https://phabricator.wikimedia.org/T229679 (10LucasWerkmeister) It’s mostly working well now, but... [14:59:34] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in selected small Wikipedias as a default tool - https://phabricator.wikimedia.org/T225302 (10Pginer-WMF) [14:59:41] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in selected small Wikipedias as a default tool - https://phabricator.wikimedia.org/T225302 (10Pginer-WMF) p:05Triage→03Normal [15:00:11] 10Readers-Web-Backlog: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10ovasileva) p:05Triage→03Normal [15:00:43] (03PS1) 10Pmiazga: Postpone call to MobileContext::shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532389 (https://phabricator.wikimedia.org/T231014) [15:03:31] 10TimedMediaHandler-Transcode: Transcoding fails for large videos for QHD and UHD resolution - https://phabricator.wikimedia.org/T227074 (10Urbanecm) I presume it's about https://commons.wikimedia.org/wiki/File:Politparade.webm and https://commons.wikimedia.org/wiki/File:Genderwahn.webm. I've requeued the transc... [15:04:07] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10WDoranWMF) @zeljkofilipin of the 3 pathways @Anomie laid out, is it... [15:04:11] 10Structured Data Engineering, 10WikibaseMediaInfo, 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Statements with unsupported properties are displayed weirdly on edit - https://phabricator.wikimedia.org/T229679 (10matthiasmullie) It's greyed out because that specifi... [15:04:14] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Turn on AMC outreach modal - https://phabricator.wikimedia.org/T231206 (10ovasileva) [15:04:21] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Turn on AMC outreach modal - https://phabricator.wikimedia.org/T231206 (10ovasileva) p:05Triage→03High [15:04:23] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in Javanese Wikipedia as a default tool - https://phabricator.wikimedia.org/T231207 (10Pginer-WMF) [15:04:51] 10CX-boost, 10CX-out-of-beta, 10Language-Team (Language-2019-July-September): Enable Content Translation in Javanese Wikipedia as a default tool - https://phabricator.wikimedia.org/T231207 (10Pginer-WMF) p:05Triage→03Normal [15:05:05] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): AMC Outreach - Modal - https://phabricator.wikimedia.org/T226068 (10ovasileva) [15:05:07] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Turn on AMC outreach modal - https://phabricator.wikimedia.org/T231206 (10ovasileva) [15:05:59] (03CR) 10TK-999: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [15:06:25] (03Merged) 10jenkins-bot: Pass correct store to rebuildLocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/532346 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [15:07:30] 10Readers-Web-Backlog: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10Niedzielski) @alexhollender, should we update the notification drawer shadow? {F30117333 width=512} [15:09:18] (03Merged) 10jenkins-bot: language: Move ConverterRule to includes/ and add test case [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [15:09:24] (03PS1) 10Hashar: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 [15:09:26] (03Merged) 10jenkins-bot: Add method to clear all keys associated with the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/531602 (owner: 10ItSpiderman) [15:09:28] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): [BUG] Image caption CTA in gallery view should be based on article language - https://phabricator.wikimedia.org/T231064 (10schoenbaechler) Works as expected now, thanks @cooltey CC: @RHo [15:09:53] (03CR) 10Hashar: [C: 04-1] "Checking whether wmf-quibble* jobs get faster as a result of this revert ..." [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:10:06] 10MediaWiki-Core-Testing, 10Lexicographical data, 10Wikidata, 10Release-Engineering-Team-TODO (201908), 10ci-test-error: WikibaseLexeme test broken by refactor of MediaWiki's Language class - https://phabricator.wikimedia.org/T231103 (10Jdforrester-WMF) 05Open→03Resolved [15:10:29] 10Wikimedia-Site-requests: Blocking any IP and new account users from creating new articles in Malay Wikipedia - https://phabricator.wikimedia.org/T231127 (10Urbanecm) 05Open→03Stalled Stalled per the above. [15:10:30] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:10:39] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:10:53] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:10:56] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:11:29] 10Research: Determine important article features with respect to readership - https://phabricator.wikimedia.org/T228319 (10Isaac) [15:12:16] 10Design, 10CX-boost, 10Language-Team (Language-2019-July-September), 10WorkType-NewFunctionality: Explore ways to restrict suggestions to a given knowledge area - https://phabricator.wikimedia.org/T229242 (10Pginer-WMF) p:05Triage→03Normal [15:13:30] (03Abandoned) 10Hashar: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532390 (owner: 10Hashar) [15:15:01] (03PS11) 10Reedy: UI upgrade [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/527089 (https://phabricator.wikimedia.org/T218214) (owner: 10ItSpiderman) [15:15:17] 10CX-cxserver, 10Language-Team (Language-2019-July-September): MT stops translating "randomly" - https://phabricator.wikimedia.org/T230195 (10Pginer-WMF) p:05Triage→03Normal [15:17:48] 10MediaWiki-History-and-Diffs, 10MediaWiki-Special-pages, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10User-DannyS712: Add Special-page redirects for page actions for easy wiki linkage (Special:History, Special:Edit, Special:Purge, Spe... - https://phabricator.wikimedia.org/T13456 [15:18:07] (03CR) 10Krinkle: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [15:18:17] 10CSS: HtmlFormatter incorrectly removes partial matches for elements with hypens - https://phabricator.wikimedia.org/T231160 (10Jdlrobson) [15:19:09] 10MediaWiki-General, 10Core Platform Team, 10CSS: HtmlFormatter incorrectly removes partial matches for elements with hypens - https://phabricator.wikimedia.org/T231160 (10Jdlrobson) Adding a class `nomobile` will delete content from **the mobile domain** and is used and documented in a variety of places. I... [15:19:37] (03CR) 10Dmaza: [C: 03+2] Disambiguate confusing $fromReplica variable in BlockManager [core] - 10https://gerrit.wikimedia.org/r/531921 (owner: 10Tchanders) [15:22:20] (03PS22) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [15:22:51] (03CR) 10jenkins-bot: Pass correct store to rebuildLocalisationCache.php [core] - 10https://gerrit.wikimedia.org/r/532346 (https://phabricator.wikimedia.org/T231183) (owner: 10simetrical) [15:23:02] (03PS5) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [15:23:04] (03PS6) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [15:23:13] (03CR) 10Daimona Eaytoy: Refactor and speed up other tests (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [15:24:54] (03PS8) 10Rosalie Perside (WMDE): Adjust the save button of the Entity Schema editor [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/531461 (https://phabricator.wikimedia.org/T230398) [15:27:00] 10MediaWiki-General, 10Core Platform Team, 10RemexHtml, 10CSS: HtmlFormatter incorrectly removes partial matches for elements with hypens - https://phabricator.wikimedia.org/T231160 (10Jdlrobson) Maybe this is a good motivation for adopting Remex? [15:29:38] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [AMC] Updates to "User rights" menu item - https://phabricator.wikimedia.org/T230694 (10Jdlrobson) a:05ovasileva→03alexhollender @alexhollender User rights has a logo: https://en.m.wikipedia.beta.wmflabs.org/wiki/User:Kaldari - it just didn't hit prod... [15:30:03] (03CR) 10Krinkle: [C: 03+2] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [15:30:09] (03CR) 10Krinkle: [C: 03+2] Warn if a function has been given too many parameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [15:31:01] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [AMC] Updates to "User rights" menu item - https://phabricator.wikimedia.org/T230694 (10Jdlrobson) [15:31:42] (03CR) 10Krinkle: "What about the other two calls to bufferTagsToSetByAction() in Runner.php?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [15:33:15] 10MediaWiki-extensions-Translate, 10Patch-For-Review: (Schedule) hard deprecation (emit notices) for old style registration in Translate - https://phabricator.wikimedia.org/T228054 (10Jdforrester-WMF) [15:33:17] 10Wikimedia-Site-requests, 10Patch-For-Review: Update Wikimedia production config to use extension registration for Translate - https://phabricator.wikimedia.org/T228051 (10Jdforrester-WMF) [15:34:54] 10Wikimedia-Site-requests, 10Patch-For-Review: Update Wikimedia production config to use extension registration for Translate - https://phabricator.wikimedia.org/T228051 (10Jdforrester-WMF) a:03Jdforrester-WMF [15:35:25] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: JS Error occurs when cancelling writing a comment on mobile structured talk pages - https://phabricator.wikimedia.org/T230445 (10Patriccck) Thank you! [15:35:38] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [15:38:35] 10Space (Jul-Sep-2019): Improve events list view text - https://phabricator.wikimedia.org/T230936 (10elappen-WMF) [15:39:18] 10Space (Jul-Sep-2019): Improve events list view text - https://phabricator.wikimedia.org/T230936 (10elappen-WMF) [15:39:39] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): [BUG] Gallery randomly outputs (unstructured) image description and (structured) image caption - https://phabricator.wikimedia.org/T230603 (10ABorbaWMF) Unable to reproduce on 2.7.50288-beta-2019-08-22 [15:40:20] (03CR) 10Aaron Schulz: [C: 03+2] Use local variabe $services instead of MediaWikiServices::getInstance() [core] - 10https://gerrit.wikimedia.org/r/532384 (owner: 10Fomafix) [15:40:57] 10Wikimedia-Site-requests, 10Patch-For-Review: Update Wikimedia production config to use extension registration for Translate - https://phabricator.wikimedia.org/T228051 (10Jdforrester-WMF) 05Open→03Resolved All seems well. [15:40:59] 10MediaWiki-extensions-Translate, 10Patch-For-Review: (Schedule) hard deprecation (emit notices) for old style registration in Translate - https://phabricator.wikimedia.org/T228054 (10Jdforrester-WMF) [15:41:01] 10MediaWiki-Uploading, 10Multimedia, 10UploadWizard: 4 files, that will not upload with uploadwizard (Internal error: Server failed to store temporary file.) for server-side upload - https://phabricator.wikimedia.org/T229249 (10C.Suthorn) I am trying to avoid these errors in the uploadwizard. Upload files ta... [15:42:36] (03CR) 10Niedzielski: [C: 03+2] Postpone call to MobileContext::shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532389 (https://phabricator.wikimedia.org/T231014) (owner: 10Pmiazga) [15:43:07] (03CR) 10Krinkle: [C: 03+1] parserTests: Add parser test with filename containing single quotes [core] - 10https://gerrit.wikimedia.org/r/528920 (owner: 10Fomafix) [15:43:34] (03CR) 10Krinkle: Let Html::element do the HTML encoding [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [15:44:19] 10MediaWiki-extensions-WikimediaMaintenance, 10Wikimedia-Interwiki-links, 10Wikimedia-Site-requests, 10Patch-For-Review: The href of be-tarask: interlanguage link points to the be-x-old domain - https://phabricator.wikimedia.org/T111853 (10Krinkle) [15:45:18] (03CR) 10Krinkle: "Where is this used? Looks like something that will have many more problems and inconsistencies. There is a large list of exceptions in wmf" [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/529916 (https://phabricator.wikimedia.org/T111853) (owner: 10Fomafix) [15:47:26] (03CR) 10jenkins-bot: language: Move ConverterRule to includes/ and add test case [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [15:48:21] (03CR) 10Aaron Schulz: "@simetrical: feel free to add test and take over this patch (it's more of a CPT thing anyway). I mostly just want to deprecate some BagOSt" [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [15:49:16] (03PS6) 10Krinkle: Remove @embed where it needlessly delays the page load [skins/Vector] - 10https://gerrit.wikimedia.org/r/528480 (https://phabricator.wikimedia.org/T121730) [15:49:28] (03PS12) 10Krinkle: resources: Remove `@embed` where it may do more harm than good [core] - 10https://gerrit.wikimedia.org/r/525840 (https://phabricator.wikimedia.org/T121730) [15:50:53] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [15:51:19] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] "The use-case can be found in I51bc8c9703 (I guess Gerrit doesn’t have a Special:WhatLinksHere for Depends-On connections)." [core] - 10https://gerrit.wikimedia.org/r/525784 (owner: 10Matthias Mullie) [15:51:38] (03PS13) 10Krinkle: filerepo: move bits of logic from subclasses up to LocalRepo [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [15:52:17] (03PS14) 10Krinkle: filerepo: move bits of logic from subclasses up to LocalRepo [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [15:53:05] 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10good first bug: Bug: Section edit links should be hidden for blocked users - https://phabricator.wikimedia.org/T206265 (10Niedzielski) a:03Niedzielski [15:53:08] 10Wikimania-Hackathon-2019: Tool to get an overview of a topic/category - https://phabricator.wikimedia.org/T230678 (10Niharika) >>! In T230678#5420330, @putnik wrote: > Great tool, many thanks for this work. > > Is it possible to transfer it to the Wikimedia Toolforge and add a choice of language and project?... [15:53:38] 10TimedMediaHandler-Transcode: Transcoding fails for large videos for QHD and UHD resolution - https://phabricator.wikimedia.org/T227074 (10C.Suthorn) Just saw that the transcoding is now at 42 minutes, and while looking at it, came about this thought: the files are 4GiB (to the byte) each. Maybe the transcoded... [15:54:11] 10Wikimania-Hackathon-2019: Tool to get an overview of a topic/category - https://phabricator.wikimedia.org/T230678 (10Niharika) [15:56:27] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): [BUG] Image caption CTA in gallery view should be based on article language - https://phabricator.wikimedia.org/T231064 (10ABorbaWMF) Looks good to me on 2.7.50288-beta-2019-08-22 [15:56:58] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Design): Updates to notifications container on mobile and desktop - https://phabricator.wikimedia.org/T226125 (10alexhollender) [15:57:03] (03CR) 10Ladsgroup: "This caused several UBN issues T231198 and T231200. I don't know how to properly revert this without breaking everything else but this nee" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [15:57:25] (03PS1) 10Ladsgroup: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 [15:57:52] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [15:58:06] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [15:58:08] (03CR) 10jerkins-bot: [V: 04-1] filerepo: move bits of logic from subclasses up to LocalRepo [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [15:58:22] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [15:58:32] (03CR) 10jerkins-bot: [V: 04-1] Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [15:59:11] (03CR) 10jerkins-bot: [V: 04-1] filerepo: move bits of logic from subclasses up to LocalRepo [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [15:59:53] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Suggested Edits analytics not tracking suggestion impressions correctly sometimes - https://phabricator.wikimedia.org/T230496 (10ABorbaWMF) Looking good on 2.7.50289-beta-2019-08-23 [15:59:55] (03CR) 10Ladsgroup: "Why there is no ticket attached to this patch?" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [16:01:27] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10MaxBioHazard) I'll test this in the coming days. Except Safari and iOS broswer, 'cause I don't have Apple devices. [16:01:52] (03CR) 10simetrical: "I don't see any mention of LocalisationCache at T231200 or T231198?" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [16:02:20] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Design): Updates to notifications container on mobile and desktop - https://phabricator.wikimedia.org/T226125 (10Niedzielski) [16:02:32] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) This should be fixed now, can you test? [16:02:53] (03CR) 10Jforrester: [C: 03+1] build: Add mediawiki/mediawiki-phan-config [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/528599 (https://phabricator.wikimedia.org/T224766) (owner: 10Umherirrender) [16:02:57] (03CR) 10Ladsgroup: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [16:03:02] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Design): Updates to notifications container on mobile and desktop - https://phabricator.wikimedia.org/T226125 (10Niedzielski) [16:06:26] (03PS4) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [16:07:33] (03CR) 10Krinkle: "This updates the code to leave globals alone if there is no whitelist configured (e.g. when run from phpunit.php). This is effectively the" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [16:08:21] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531876 (owner: 10Dvogel hallowelt) [16:08:24] (03PS8) 10Ankita Mandal: Improve the interface of Special:Cargo Query page in Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) [16:08:41] (03PS7) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [16:08:43] (03PS7) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [16:08:45] (03PS25) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [16:08:47] (03PS2) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [16:09:01] (03Abandoned) 10Ankita Mandal: Renamed View Data to Cargo Query. Select2 library added. Does not yet fully address T213513. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/518369 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [16:09:44] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10translatewiki.net, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Krinkle) [16:10:05] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10translatewiki.net, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Krinkle) [16:10:07] (03CR) 10Ankita Mandal: "> >" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [16:10:30] (03CR) 10jerkins-bot: [V: 04-1] filerepo: move bits of logic from subclasses up to LocalRepo [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [16:11:08] (03PS8) 10simetrical: [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [16:12:36] (03CR) 10Krinkle: Integration tests for Language fallback methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [16:12:48] (03CR) 10Ladsgroup: "Since this doesn't work I'm going to revert your patches one by one." [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [16:13:28] (03CR) 10Krinkle: Integration tests for Language fallback methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [16:15:13] (03PS1) 10Ladsgroup: Revert "Pass correct store to rebuildLocalisationCache.php" [core] - 10https://gerrit.wikimedia.org/r/532396 [16:15:15] (03PS1) 10Aaron Schulz: rdbms: rename $db => $conn in remaining places in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/532397 [16:16:30] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/531494 (owner: 10ItSpiderman) [16:17:01] (03CR) 10jerkins-bot: [V: 04-1] Modify autocomplete-pupup colors [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531876 (owner: 10Dvogel hallowelt) [16:17:03] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [16:17:56] (03CR) 10Jforrester: [C: 03+2] Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [16:17:58] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:18:35] (03CR) 10Jforrester: Fix config name (031 comment) [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 (owner: 10Paladox) [16:19:13] 10Space: Randomly stuck in saving loop - https://phabricator.wikimedia.org/T230009 (10Aklapper) If you think there is nothing left to do in this task (?), please feel free to set the task status to `invalid` via the {nav name=Add Action... > Change Status} dropdown. Thanks! :) [16:19:29] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/531878 (owner: 10ItSpiderman) [16:19:41] (03CR) 10Dmaza: Log DNS blacklist matches with info level, non-matches with debug level (031 comment) [core] - 10https://gerrit.wikimedia.org/r/531287 (https://phabricator.wikimedia.org/T230822) (owner: 10Urbanecm) [16:20:44] (03CR) 10Krinkle: "If this is the only place that doesn't meet the new expectation of https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/532334/4 - then tha" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [16:20:46] (03CR) 10Krinkle: [C: 03+2] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [16:20:51] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/525261 (owner: 10Pwirth) [16:21:05] (03PS3) 10Paladox: Fix config name [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 [16:21:07] (03PS3) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [16:21:09] (03CR) 10Paladox: Fix config name (031 comment) [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 (owner: 10Paladox) [16:21:22] (03CR) 10Krinkle: [C: 03+2] rdbms: rename $db => $conn in remaining places in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/532397 (owner: 10Aaron Schulz) [16:21:37] (03CR) 10simetrical: "> Patch Set 29:" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [16:21:46] (03CR) 10Krinkle: [C: 03+2] rdbms: simplify comment in LoadBalancer::reuseConnection() [core] - 10https://gerrit.wikimedia.org/r/532291 (owner: 10Aaron Schulz) [16:21:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Anti-Harassment (The Letter Song), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 3 others: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10WMDE-leszek) 05Open→03Resolved thanks... [16:21:59] 10MediaWiki-User-management, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase support for Partial Blocks - https://phabricator.wikimedia.org/T214992 (10WMDE-leszek) [16:22:57] (03CR) 10simetrical: "Sorry, you'll have to revert b78b8804d076618e967c7b31ec15a1bd9e35d1d0 and 76a940350d36c323ebedb4ab45cc81ed1c6b6c92 as well, of course. Tho" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [16:23:10] 10MediaWiki-API, 10Core Platform Team, 10Security-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Should the Action API allow cross-origin requests by default? - https://phabricator.wikimedia.org/T210790 (10WDoranWMF) [16:23:38] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:25:40] (03PS5) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [16:25:42] (03PS8) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [16:25:44] (03PS8) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [16:25:46] (03PS26) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [16:25:48] (03PS4) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [16:26:10] (03CR) 10Krinkle: [C: 03+1] "Which warning? Does it not support empty array, but non-empty is fine? Or does it not support the second arg at all? If the latter, then t" [core] - 10https://gerrit.wikimedia.org/r/532279 (owner: 10Aaron Schulz) [16:26:30] (03PS6) 10Krinkle: objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [16:26:32] (03CR) 10Krinkle: [C: 03+2] objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [16:27:05] 10Research: HostBot-AI study coordination with NotConfusing - https://phabricator.wikimedia.org/T211160 (10notconfusing) Hi @Krinkle , Thanks for writing. Yes, as you noticed there are many confounding factors. The original Teahouse paper (BTW I just used your SUL tool, which worked very well so thanks for th... [16:27:45] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [16:27:48] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [16:27:50] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:27:52] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:27:54] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [16:27:56] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:30:05] (03PS1) 10Ladsgroup: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532399 (https://phabricator.wikimedia.org/T231200) [16:30:54] (03Abandoned) 10Ladsgroup: Revert "Pass correct store to rebuildLocalisationCache.php" [core] - 10https://gerrit.wikimedia.org/r/532396 (owner: 10Ladsgroup) [16:31:00] (03CR) 10Krinkle: [C: 03+1] Drop PHP message file support [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/502471 (owner: 10simetrical) [16:32:19] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [16:32:32] (03CR) 10simetrical: "Well, that change passes tests, so you can look for yourself what tests had to be fixed. I think there were a total of three tests that we" [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [16:32:43] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [16:33:18] (03CR) 10simetrical: New LanguageFallback service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [16:33:19] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:34:23] (03PS6) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [16:34:25] (03PS9) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [16:34:27] (03PS9) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [16:34:29] (03PS27) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [16:34:31] (03PS5) 10simetrical: Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 [16:34:33] (03CR) 10Daimona Eaytoy: "> What about the other two calls to bufferTagsToSetByAction() in" (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [16:34:44] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532334 (owner: 10simetrical) [16:34:56] (03CR) 10simetrical: "I don't see any cross-repo changes that failed to merge . . ." [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [16:35:28] (03Abandoned) 10Ladsgroup: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532394 (owner: 10Ladsgroup) [16:35:44] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [16:35:52] (03CR) 10Krinkle: "thx so the $wgAbuseFilterConditionLimit case is a change in behaviour / bug fix." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [16:36:18] (03CR) 10Daimona Eaytoy: "> thx so the $wgAbuseFilterConditionLimit case is a change in" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [16:36:50] (03PS1) 10Paladox: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 [16:36:52] 10Research: Analyze Demographics Surveys - https://phabricator.wikimedia.org/T228285 (10Isaac) I presented preliminary results at Wikimania: https://wikimania.wikimedia.org/wiki/2019:Research/Characterizing_Reader_Behavior_on_Wikipedia We will hopefully release fuller results in the next several weeks after doi... [16:36:54] (03CR) 10Jforrester: [C: 03+2] "Ah, already broken? Whoops." [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 (owner: 10Paladox) [16:39:06] (03CR) 10simetrical: Integration tests for Language fallback methods (032 comments) [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [16:39:41] 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Krinkle) See also where I explain a few reasons for why maki... [16:40:39] (03Merged) 10jenkins-bot: Change config only before we've started testing [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532368 (owner: 10simetrical) [16:41:44] (03PS7) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [16:42:35] (03Merged) 10jenkins-bot: Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [16:42:56] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [16:43:00] 10Wiki-Loves-Monuments-Database: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes - https://phabricator.wikimedia.org/T231215 (10JeanFred) [16:43:06] 10Wiki-Loves-Monuments-Database: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes - https://phabricator.wikimedia.org/T231215 (10JeanFred) p:05Triage→03Low [16:43:10] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [16:43:57] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [16:45:22] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [16:45:30] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [AMC] Updates to "User rights" menu item - https://phabricator.wikimedia.org/T230694 (10alexhollender) @Jdlrobson let's use the icon in the task description. It will work better with "User groups". [16:48:18] 10Readers-Web-Backlog: Add shadow to nav menu drawer - https://phabricator.wikimedia.org/T231205 (10alexhollender) >>! In T231205#5437984, @Niedzielski wrote: > @alexhollender, should we update the notification drawer shadow? I'm not opposed to that, though if we proceed with the changes proposed in T226125 I d... [16:50:06] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Readers-Web-Backlog (Design): Updates to notifications container on mobile and desktop - https://phabricator.wikimedia.org/T226125 (10alexhollender) [16:51:37] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10translatewiki.net, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Jdforrester-WMF) [16:53:37] (03CR) 10Ladsgroup: [C: 03+2] "Currently it takes four hours to merge a patch, let's just put this in front of the queue." [core] - 10https://gerrit.wikimedia.org/r/532399 (https://phabricator.wikimedia.org/T231200) (owner: 10Ladsgroup) [16:59:57] (03PS1) 10Jdlrobson: Dev: Explicitly reference `less` file extension when importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532404 [17:00:42] 10Research: Determine important article features with respect to readership - https://phabricator.wikimedia.org/T228319 (10Isaac) My first attempt at building a language-independent means of representing article topic -- i.e. grouping article page views into categories regardless of which Wikipedia language edit... [17:03:05] (03PS5) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 [17:03:07] (03CR) 10Jdlrobson: Icons should not be defined in stylesheets (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (owner: 10Jdlrobson) [17:06:25] (03CR) 10Niedzielski: [C: 03+2] Dev: Explicitly reference `less` file extension when importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532404 (owner: 10Jdlrobson) [17:07:09] 10Structured-Data-Design: Machine-aided Depicts tagging - https://phabricator.wikimedia.org/T214414 (10PDrouin-WMF) [17:08:32] (03CR) 10jerkins-bot: [V: 04-1] NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [17:08:34] (03CR) 10Krinkle: [C: 04-1] "ApiComparePagesTest fails on this commit." [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [17:08:44] 10Accessibility, 10MobileFrontend, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Touch targets not large enough - https://phabricator.wikimedia.org/T230033 (10Niedzielski) a:05Nirzar→03alexhollender > @Nirzar, please weigh in on Design's requirements when y... [17:09:29] (03PS2) 10Paladox: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) [17:09:39] (03PS7) 10Jdlrobson: Track all menu interactions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/529180 (https://phabricator.wikimedia.org/T220016) (owner: 10Pmiazga) [17:11:18] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [17:11:42] 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10dbarratt) Should `RequestInfo` be aware of "sub" requests? i.e. should it know the "Master" request and the "Current" request? Or should there be a si... [17:14:18] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [17:14:30] 10Android-app-Bugs, 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog: Wrong file page URL on the overlay at caption editing task in Android app - https://phabricator.wikimedia.org/T231130 (10Dbrant) a:03Dbrant [17:15:00] 10Android-app-Bugs, 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Wrong file page URL on the overlay at caption editing task in Android app - https://phabricator.wikimedia.org/T231130 (10Dbrant) [17:15:14] (03PS5) 10AndreG-P: Added support for popups for annotated math [extensions/Math] - 10https://gerrit.wikimedia.org/r/527556 (https://phabricator.wikimedia.org/T208758) [17:15:48] 10Advanced Mobile Contributions, 10MinervaNeue, 10Mobile, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), and 2 others: Fix icon sizing by updating all 24x24 icons to 20x20 icons - https://phabricator.wikimedia.org/T229440 (10Jdlrobson) a:03Jdrewniak [17:15:55] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [17:16:55] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [17:17:46] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [17:17:58] (03PS3) 10Ppchelko: Remove usages of Title::quickUserCan [core] - 10https://gerrit.wikimedia.org/r/531988 [17:18:24] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [17:18:36] 10Timeless: Page tools and languages toggles on mobile have no tooltips - https://phabricator.wikimedia.org/T231216 (10Isarra) [17:19:02] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [17:19:52] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [17:20:45] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [17:20:53] 10MediaWiki-REST-API, 10CPT Initiatives (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Workboards (Green), 10Patch-For-Review, 10Services (watching): REST API i18n - https://phabricator.wikimedia.org/T226598 (10Anomie) >>! In T226598#5437045, @tstarling wrote: >> That strikes me as rather danger... [17:20:58] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [17:21:02] 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Simetrical) Few services will actually want direct access to the request info, so I'd think it doesn't make sense to make a service for this without s... [17:22:45] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Lead image obscures upper part of the article on Android Tablets - https://phabricator.wikimedia.org/T231217 (10ABorbaWMF) [17:23:52] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [17:24:05] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [17:24:28] 10Accessibility, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Menu handle has no active state - https://phabricator.wikimedia.org/T230034 (10alexhollender) @Niedzielski currently when I tap on the menu handles they have a highlighted touch state, so my hope... [17:25:36] 10MediaWiki-ContentHandler, 10MediaWiki-User-management, 10User-DannyS712: Investigate separate user right for creating pages with custom content models - https://phabricator.wikimedia.org/T226926 (10Pppery) >>! In T226926#5404471, @Izno wrote: > I'd rather just see TEs get editcontentmodel tbh. Definitely... [17:26:01] (03CR) 10jerkins-bot: [V: 04-1] [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 (owner: 10simetrical) [17:27:46] (03CR) 10jenkins-bot: Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [17:28:16] (03CR) 10simetrical: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [17:28:38] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Performance-Team (Radar), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Main menu should slide over content - https://phabricator.wikimedia.org/T206354 (10alexhollender) @phuedx great catch on the drop shadow. I actually noticed t... [17:32:06] (03CR) 10jenkins-bot: Change config only before we've started testing [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532368 (owner: 10simetrical) [17:33:12] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Rotating in Nearby appears to automatically navigate to the users location - https://phabricator.wikimedia.org/T231218 (10ABorbaWMF) [17:33:18] (03CR) 10Krinkle: [C: 04-1] "check php" [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [17:34:16] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [17:37:20] (03PS8) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [17:37:44] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [17:37:52] (03CR) 10jerkins-bot: [V: 04-1] Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 (owner: 10Daimona Eaytoy) [17:38:33] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Nikerabbit) (Not related or affecting translatewiki.net at the moment). No directly observable errors seen... [17:39:03] 10MediaWiki-Uploading, 10Multimedia, 10UploadWizard: 4 files, that will not upload with uploadwizard (Internal error: Server failed to store temporary file.) for server-side upload - https://phabricator.wikimedia.org/T229249 (10Urbanecm) That seems like another issue. Please keep only one issue per task, to... [17:46:36] 10MediaWiki-General: $wgActorTableSchemaMigrationStage = SCHEMA_COMPAT_NEW; brings down translatewiki.net - https://phabricator.wikimedia.org/T231196 (10Nikerabbit) For comparison, this is the query with SCHEMA_COMPAT_READ_OLD: ` MariaDB [translatewiki_net]> EXPLAIN SELECT rev_id,rev_page,rev_timestamp,rev_min... [17:46:55] 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Krinkle) I would expect that long-term, any information from the WebRequest can be processed in the entry points (index.php/MediaWiki.php, etc.) and p... [17:47:00] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10zeljkofilipin) @WDoranWMF I don't know much about this error. I've... [17:48:02] 10Wiki-Loves-Monuments: Wlm/heritage/erfgoedbot sprint at Wikimania Hackathon 2017 - https://phabricator.wikimedia.org/T172772 (10JeanFred) [17:48:04] 10Wiki-Loves-Monuments-Database: Harvest Wikidata into the Monuments database - https://phabricator.wikimedia.org/T138668 (10JeanFred) [17:48:07] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Investigate time-out issues with Wikidata harvests - https://phabricator.wikimedia.org/T172690 (10JeanFred) 05Resolved→03Open I am not sure the timeout catch actually works: testing the nl_nl, I got the timeout on the Query service UI, but on pywikibot s... [17:48:12] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10WDoranWMF) @zeljkofilipin grand, who can we check with to see what... [17:48:14] 10MediaWiki-General: Figure out how to make LocalisationCache a service without hurting performance - https://phabricator.wikimedia.org/T231220 (10Simetrical) [17:49:38] 10MediaWiki-General: Figure out how to make LocalisationCache a service without hurting performance - https://phabricator.wikimedia.org/T231220 (10Simetrical) By the way, @Ladsgroup, how did you actually measure the performance hit here? I'm going to need a way to test it to make sure I've fixed the problem befo... [17:51:04] (03CR) 10Krinkle: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [17:51:14] 10Developer-Advocacy, 10wikimedia.biterg.io: Provide FY2018-19 development contributors statistics for WMF Audit report - https://phabricator.wikimedia.org/T231221 (10Aklapper) p:05Triage→03High [17:51:25] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Simetrical) Then I think it's resolved, although the patch is being backed out anyway for now because of T23... [17:51:30] 10wikimedia.biterg.io, 10Developer-Advocacy (Jul-Sep 2019): Provide FY2018-19 development contributors statistics for WMF Audit report - https://phabricator.wikimedia.org/T231221 (10Aklapper) [17:51:55] 10MediaWiki-Uploading, 10Multimedia, 10UploadWizard: 4 files, that will not upload with uploadwizard (Internal error: Server failed to store temporary file.) for server-side upload - https://phabricator.wikimedia.org/T229249 (10C.Suthorn) It is sporadic. I can think of no way to reproduce (provoke) it. I am... [17:52:15] 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): Clicking to the right of table at the end of a document throws an exception (regression) - https://phabricator.wikimedia.org/T231085 (10matmarex) Note from testing: to reproduce the issue, you have to be editing in full-page mode (not section e... [17:52:26] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10zeljkofilipin) @WDoranWMF subscribers of this task should know the... [17:55:13] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10Krinkle) Excluding this error as-is from Logstash dashboards is a p... [17:56:57] 10CPT Initiatives (Decoupling (CDP2)): Provide access to WebRequest and associated information via a service object - https://phabricator.wikimedia.org/T218555 (10Simetrical) So let's say for LBFactory, how would you suggest making it not depend at all on the current request? How should it get the request's IP a... [17:57:30] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10tramm) Veebileht on üleval wikimedia.ee peal ja Wordpressi vana leht raha eest uuele saidile suunatud. Nüüd on vaja veel teha ära see osa "täiendada esialgs... [17:57:57] 10MobileFrontend, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Documentation, 10Readers-Web-Backlog (Tracking): Migrate documentation generation to Node 10.15.2 from node 6.11.0 - https://phabricator.wikimedia.org/T230841 (10Jdforrester-WMF) a:03Jdforrester-WMF The replacement for the... [17:58:09] (03CR) 10simetrical: rdbms: Defer instantiating the DBLoadBalancerFactory service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532367 (https://phabricator.wikimedia.org/T228895) (owner: 10TK-999) [17:58:39] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Lead image obscures upper part of the article on Android Tablets - https://phabricator.wikimedia.org/T231217 (10Sharvaniharan) a:03Sharvaniharan [17:59:04] (03CR) 10simetrical: "recheck" [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [17:59:06] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Lead image obscures upper part of the article on Android Tablets - https://phabricator.wikimedia.org/T231217 (10Sharvaniharan) [17:59:15] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Lead image obscures upper part of the article on Android Tablets - https://phabricator.wikimedia.org/T231217 (10Sharvaniharan) [17:59:41] (03PS7) 10Pmiazga: skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 [18:01:05] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [18:01:07] (03CR) 10Jforrester: [C: 03+2] Split apihelp messages to a separate file [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/532121 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [18:01:13] (03CR) 10jerkins-bot: [V: 04-1] Remove Language::factory and getParentLanguage use [core] - 10https://gerrit.wikimedia.org/r/532369 (owner: 10simetrical) [18:01:19] (03CR) 10Jforrester: [C: 03+2] Split apihelp messages to a separate file [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/532123 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [18:01:30] (03CR) 10Jforrester: [C: 03+2] Split apihelp messages to a separate file [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/532122 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [18:01:32] 10MediaWiki-User-preferences, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech, 10Wikimedia-production-error: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code - https://phabricator.wikimedia.org/T231029 (10zeljkofilipin) Friendly reminder, this is block... [18:01:56] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10zeljkofilipin) Friendly reminder, this is blocking the train. Will... [18:02:10] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10zeljkofilipin) Friendly reminder, this is blocking the train. Will it be resolved by [[ https://wikitech.wik... [18:02:21] (03PS8) 10Pmiazga: Track all menu interactions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/529180 (https://phabricator.wikimedia.org/T220016) [18:03:11] (03PS1) 10Bartosz Dziewoński: SpecialNewSection: Fix handling of 'preloadparams' [core] - 10https://gerrit.wikimedia.org/r/532421 (https://phabricator.wikimedia.org/T231088) [18:04:10] 10MediaWiki-User-management, 10Anti-Harassment, 10Core Platform Team, 10GlobalBlocking, 10CPT Initiatives (Decoupling (CDP2)): Remove Core coupling with GlobalBlocking extension - https://phabricator.wikimedia.org/T231109 (10dmaza) [18:04:13] (03CR) 10jerkins-bot: [V: 04-1] Drop strings for wgExternalDiffEngine, deprecated in 1.27 and 1.32 [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [18:08:31] (03CR) 10Krinkle: [C: 04-1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/520328 (owner: 10Jforrester) [18:09:17] 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: Avoid hyphenation in URLs that span multiple lines - https://phabricator.wikimedia.org/T230860 (10alexhollender) It's fine to remove the hyphen. {F30117850} [18:09:54] (03PS4) 10Ppchelko: Make DefaultPreferencesFactory depend on PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) [18:11:08] 10Accessibility, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Menu handle has no active state - https://phabricator.wikimedia.org/T230034 (10Niedzielski) Ok, I think we want something like this then: ` .toggle-list__checkbox:checked + .toggle-list__toggle... [18:11:40] 10wikimedia.biterg.io, 10Developer-Advocacy (Jul-Sep 2019): Provide FY2018-19 development contributors statistics for WMF Audit report - https://phabricator.wikimedia.org/T231221 (10Aklapper) 05Open→03Resolved Steps anyone can perform to retrieve the requested data: 1. Go to https://wikimedia.biterg.io/ 2.... [18:11:51] 10MediaWiki-Cache, 10MediaWiki-Internationalization, 10Core Platform Team, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): L10n cache is completely broken - https://phabricator.wikimedia.org/T231183 (10Ladsgroup) https://gerrit.wikimedia.org/r/c/mediawiki/core/+/532399 resolves this as well. [18:12:27] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [18:12:28] (03CR) 10Ppchelko: Make DefaultPreferencesFactory depend on PermissionManager. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:12:53] (03CR) 10Jdlrobson: Track all menu interactions (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/529180 (https://phabricator.wikimedia.org/T220016) (owner: 10Pmiazga) [18:13:36] 10Wiki-Loves-Monuments-Database: Upgrade Heritage to PHP 7 - https://phabricator.wikimedia.org/T231223 (10JeanFred) [18:13:47] 10Wiki-Loves-Monuments-Database: Upgrade Heritage to PHP 7 - https://phabricator.wikimedia.org/T231223 (10JeanFred) p:05Triage→03Low [18:13:57] 10Wiki-Loves-Monuments-Database: Upgrade Heritage to PHP 7 - https://phabricator.wikimedia.org/T231223 (10JeanFred) [18:14:01] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): AMC Outreach - contextual hooks via new Drawer (showing AMC optin drawer within workflows) - https://phabricator.wikimedia.org/T226069 (10alexhollender) @ovasileva I don't have a large concern and am fine either way. [18:14:22] 10Wiki-Loves-Monuments-Database: Upgrade Heritage to PHP 7 - https://phabricator.wikimedia.org/T231223 (10JeanFred) [18:14:32] (03PS9) 10simetrical: [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [18:14:38] 10Wiki-Loves-Monuments-Database: Upgrade Heritage to PHP 7 - https://phabricator.wikimedia.org/T231223 (10JeanFred) [18:14:39] (03CR) 10simetrical: "Is there any way to figure out which one?" [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:15:54] (03CR) 10jerkins-bot: [V: 04-1] skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [18:16:04] (03CR) 10jerkins-bot: [V: 04-1] skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [18:17:24] 10MediaWiki-User-preferences, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech (Kanban (Q1 2019-20)), 10Wikimedia-production-error: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code - https://phabricator.wikimedia.org/T231029 (10MaxSem) a:03MaxSem [18:17:48] (03CR) 10jerkins-bot: [V: 04-1] skins: Move Skin::getAllowedSkins() to SkinFactory [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [18:19:37] 10Utilities-mwdumper: MWDumper loads titles but revisions aren't accessible - https://phabricator.wikimedia.org/T231224 (10Uziel302) [18:19:38] (03CR) 10Krinkle: "ConfigException: GlobalVarConfig::get: undefined option: 'LocalisationCacheConf'" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:19:53] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [18:20:09] (03CR) 10Jforrester: [C: 03+2] NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [18:20:52] (03CR) 10Jforrester: "How is there a REL1_34 branch for this repo already? We're not going to be making it for another two months…" [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 (owner: 10Paladox) [18:21:54] (03PS14) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [18:22:32] (03CR) 10Daimona Eaytoy: "> ConfigException: GlobalVarConfig::get: undefined option:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:23:23] (03CR) 10Krinkle: "Also REL1_34-5 and REL1_35." [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 (owner: 10Paladox) [18:23:31] (03CR) 10Huji: [C: 03+2] Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [18:24:37] (03CR) 10Krinkle: "It just means there is a merge conflict when it tries to apply this patch and parent(s) to latest master." [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:24:52] 10Structured Data Engineering, 10Structured-Data-Backlog, 10SDC-Statements (Campaigns-jogging): Explore simple, campaign-specific "sync" functionality for statements in UploadWizard - https://phabricator.wikimedia.org/T231225 (10Ramsey-WMF) [18:25:10] (03CR) 10Krinkle: "(rebase locally and you'll find out for all patches at once, or press "Rebase" within gerrit from the bottom up until you find one that wo" [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:25:51] 10MediaWiki-Page-editing, 10Patch-For-Review: Special:NewSection does not properly handle preloadparams - https://phabricator.wikimedia.org/T231088 (10matmarex) As a side note, I noticed that the redirect generates URL parameters that don't work in VE. I submitted a patch for that too: https://gerrit.wikimedia... [18:26:00] (03CR) 10Daimona Eaytoy: "check php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:27:18] 10MediaWiki-extensions-InputBox: Extension:InputBox preloadparams include %5B0%5D (additional 0) instead of %5B%5D - https://phabricator.wikimedia.org/T212769 (10matmarex) Apparently either of the formats can be used: ...&preloadparams[]=a&preloadparams[]=b ...&preloadparams[0]=a&preloadparams[1]=b Why is... [18:28:23] (03CR) 10Krinkle: [C: 03+1] Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 (owner: 10simetrical) [18:28:49] (03CR) 10Krinkle: "Catchable fatal error: Argument 5 passed to MediaWiki\Preferences\DefaultPreferencesFactory::__construct() must be an instance of SkinFact" [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [18:29:08] (03CR) 10jerkins-bot: [V: 04-1] Make DefaultPreferencesFactory depend on PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:30:00] (03PS6) 10Daimona Eaytoy: Warn if a function has been given too many parameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) [18:30:10] (03CR) 10jerkins-bot: [V: 04-1] Make DefaultPreferencesFactory depend on PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:31:02] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Uploaded patch set 6." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [18:31:27] 10Wiki-Loves-Monuments-Database: update_database crashing due to KeyboardInterrupt - https://phabricator.wikimedia.org/T203417 (10JeanFred) 05Open→03Resolved a:03JeanFred Tentatively closing this as resolved − grepped through the latest update logs, no mention of KeyboardInterrupt since September 2018 [18:31:46] 10MobileFrontend, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Documentation, and 2 others: Migrate documentation generation to Node 10.15.2 from node 6.11.0 - https://phabricator.wikimedia.org/T230841 (10Jdforrester-WMF) [18:31:55] 10MobileFrontend, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Documentation, and 2 others: Migrate documentation generation to Node 10.15.2 from node 6.11.0 - https://phabricator.wikimedia.org/T230841 (10Jdforrester-WMF) [18:32:01] (03PS23) 10Daimona Eaytoy: [WIP] Factor out variables-related methods [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519064 [18:32:03] (03PS9) 10Daimona Eaytoy: Refactor and speed up other tests [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532375 [18:32:44] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:33:00] (03CR) 10Krinkle: skins: Move Skin::getAllowedSkins() to SkinFactory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530587 (owner: 10Pmiazga) [18:33:41] 10Wiki-Loves-Monuments-Database: Heritage unit tests throw WARNING: TestResult has no addExpectedFailure method, reporting as passes - https://phabricator.wikimedia.org/T231215 (10JeanFred) Upstream issue with Nose. I should pick up that migration to py.test again :) [18:35:30] 10Timeless: Since the interwiki links have been moved, it is not possible anymore to add interwiki links - https://phabricator.wikimedia.org/T231234 (10Pamputt) [18:35:32] 10Wiki-Loves-Monuments-Database: Upgrade heritage to Strech - https://phabricator.wikimedia.org/T216364 (10JeanFred) 05Open→03Resolved >>! In T216364#5214062, @Lokal_Profil wrote: >>>! In T216364#5052139, @Lokal_Profil wrote: >> Did this also make the statistics bit work? > > Is there anything left to do in... [18:36:09] 10MediaWiki-General: Figure out how to make LocalisationCache a service without hurting performance - https://phabricator.wikimedia.org/T231220 (10Krinkle) See also T225730#5400979 which is about making Quibble use a file-based LCStore (instead of LCStoreDB). We can also think about setting $wgUseLocalMessageCa... [18:36:28] (03CR) 10jerkins-bot: [V: 04-1] Make DefaultPreferencesFactory depend on PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [18:37:07] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10alexhollender) @Jdlrobson >Does the address bar still change when the talk button is open? Yes, it should have a uniq... [18:37:52] (03CR) 10Mglaser: [C: 03+2] Add new widgets [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/531494 (owner: 10ItSpiderman) [18:41:10] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10alexhollender) [18:41:12] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:41:28] 10Timeless, 10CSS, 10Mobile: Picture render with points - https://phabricator.wikimedia.org/T180299 (10Isarra) Okay, so the weird thumbhandling isn't necessarily an issue in general, just how it interacts with this specifically, so we might need to change how the containers are... And the reason for the ful... [18:41:35] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Merging tables into mouments_all takes a crazy amout of time - https://phabricator.wikimedia.org/T203500 (10JeanFred) 05Open→03Invalid Latest runs: 2019-08-26_13:45:03 Update monuments_all table... 2019-08-26_13:50:34 Make statistics... → 5 mi... [18:41:45] (03PS1) 10Jdlrobson: Edit icon should trigger UI click tracking events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532427 (https://phabricator.wikimedia.org/T220016) [18:42:13] 10Wiki-Loves-Monuments-Database: Investigate parallelisation of harvesting job - https://phabricator.wikimedia.org/T203482 (10JeanFred) This is still roughly 10.5 hours. 2019-08-26_03:01:05 Full source database update... 2019-08-26_13:45:03 Update monuments_all table... [18:43:26] (03PS9) 10Jdlrobson: Track all menu interactions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/529180 (https://phabricator.wikimedia.org/T220016) (owner: 10Pmiazga) [18:43:28] (03PS1) 10Jdlrobson: Avoid unnecessary stopPropagation usage so event click tracking can work [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532429 (https://phabricator.wikimedia.org/T220016) [18:44:09] (03CR) 10Jdlrobson: [C: 03+2] "Merge blocked on https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/532429/1 which makes sure the other actions are logged. " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/529180 (https://phabricator.wikimedia.org/T220016) (owner: 10Pmiazga) [18:44:35] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [18:45:04] (03Merged) 10jenkins-bot: Disambiguate confusing $fromReplica variable in BlockManager [core] - 10https://gerrit.wikimedia.org/r/531921 (owner: 10Tchanders) [18:46:03] (03PS15) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [18:46:16] (03CR) 10Daimona Eaytoy: "check php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [18:46:45] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10alexhollender) @Jdlrobson @ovasileva I just added a note to the description which was previously not clear: >**Note:**... [18:46:47] (03CR) 10Jforrester: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532321 (owner: 10L10n-bot) [18:48:16] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Wikimedia-production-error: ServiceContainer.php: Circular dependency when creating MobileFrontend service "AMC.UserMode > AMC.Manager > FeaturesManager > UserModes > ... - https://phabricator.wikimedia.org/T231014 [18:49:06] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10alexhollender) [18:52:37] 04(no projects): missing {{col-end}} breaks collapsing section functionality on mobile devices - https://phabricator.wikimedia.org/T231243 (10Danbloch) [18:54:22] 10MobileFrontend: missing {{col-end}} breaks collapsing section functionality on mobile devices - https://phabricator.wikimedia.org/T231243 (10Reedy) [18:55:10] 10Timeless, 10CSS, 10Mobile: Picture render with points - https://phabricator.wikimedia.org/T180299 (10Isarra) 05Open→03Resolved a:03Isarra Went ahead and just fixed it in the template, since this isn't really something we can reasonably predict mw-side: https://fr.wikipedia.org/w/index.php?title=Modè... [18:56:25] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Tracking/Epic] Problems with RecentChanges advanced mobile contribution experience - https://phabricator.wikimedia.org/T229360 (10Jdlrobson) [18:56:53] wikimedia/banana-checker#261 (dependabot/npm_and_yarn/eslint-utils-1.4.2 - c864cb0 dependabot[bot]): The build passed. - https://travis-ci.org/wikimedia/banana-checker/builds/576969520 [18:57:27] (03CR) 10Jdlrobson: [C: 03+2] Disable hyphenation for links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/530783 (https://phabricator.wikimedia.org/T230860) (owner: 10Shreyasminocha) [18:57:46] 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Avoid hyphenation in URLs that span multiple lines - https://phabricator.wikimedia.org/T230860 (10Jdlrobson) Okay merging! [18:58:44] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Turn on AMC outreach modal - https://phabricator.wikimedia.org/T231206 (10Jdlrobson) needs a dev to document what the required config change would be. [18:58:48] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Needs estimate/discussion] Highlighting on mobile is messy - disable or make work? - https://phabricator.wikimedia.org/T231054 (10alexhollender) a:05alexhollender→03None... [18:59:21] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Needs estimate/discussion] Highlighting on mobile is messy - disable or make work? - https://phabricator.wikimedia.org/T231054 (10Jdlrobson) [18:59:36] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Needs estimate/discussion] Highlighting on mobile is messy - disable or make work? - https://phabricator.wikimedia.org/T231054 (10Jdlrobson) [19:00:03] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [19:00:39] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Large numbers not handled properly in quantity qualifier field - https://phabricator.wikimedia.org/T227220 (10Ramsey-WMF) 05Open→03Resolved... [19:00:45] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Interaction Timeline: Setup a unit test framework for front-end - https://phabricator.wikimedia.org/T183988 (10Niharika) [19:00:48] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Add option to switch the order of revisions - https://phabricator.wikimedia.org/T189907 (10Niharika) [19:00:54] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Interaction Timeline should let me choose a language - https://phabricator.wikimedia.org/T189839 (10Niharika) [19:01:02] 10InteractionTimeline, 10Anti-Harassment (The Letter Song): Timeline: Namespace filter - https://phabricator.wikimedia.org/T190973 (10Niharika) [19:01:12] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [19:02:35] 10Accessibility, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Menu handle has no active state - https://phabricator.wikimedia.org/T230034 (10alexhollender) a:05alexhollender→03None >>! In T230034#5438691, @Niedzielski wrote: > Ok, I think we want someth... [19:04:52] (03CR) 10Anomie: "> In the description of T221177, I proposed allowing parameter types to be specified in the JSON routes file. I don't think it was discuss" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [19:05:01] wikimedia/banana-checker#263 (master - 6ca21e6 dependabot[bot]): The build passed. - https://travis-ci.org/wikimedia/banana-checker/builds/576972537 [19:05:18] (03Merged) 10jenkins-bot: Use local variabe $services instead of MediaWikiServices::getInstance() [core] - 10https://gerrit.wikimedia.org/r/532384 (owner: 10Fomafix) [19:06:06] (03PS11) 10Anomie: rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) [19:06:24] (03CR) 10jerkins-bot: [V: 04-1] Edit icon should trigger UI click tracking events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532427 (https://phabricator.wikimedia.org/T220016) (owner: 10Jdlrobson) [19:09:28] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10Jdlrobson) [19:10:10] (03PS2) 10Krinkle: ChangesListSpecialPage: Cache the change tag list and its summary [core] - 10https://gerrit.wikimedia.org/r/525882 (https://phabricator.wikimedia.org/T223260) (owner: 10Catrope) [19:11:16] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: [wmf.15-mobile] Homepage: 'Ask mentor'/'Ask help desk' flashes 'undefined' - https://phabricator.wikimedia.org/T229271 (10Krinkle) [19:12:10] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Needs estimate/discussion] Disabling the recent changes highlighting feature on mobile - https://phabricator.wikimedia.org/T231054 (10Jdlrobson) [19:12:17] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.19; 2019-08-20), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [Needs estimate/discussion] Disabling the recent changes highlighting feature on Minerva - https://phabricator.wikimedia.org/T231054 (10Jdlrobson) [19:12:30] (03PS16) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [19:12:42] (03CR) 10Daimona Eaytoy: "check php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [19:12:48] (03PS6) 10Jdlrobson: Separate AMC icons from non-AMC icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531756 (https://phabricator.wikimedia.org/T229295) [19:13:01] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10Jdlrobson) a:05Jdlrobson→03Jdrewniak Jan wil... [19:13:36] (03PS6) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 [19:15:37] (03PS1) 10Anomie: MessageCache: Add STRAIGHT_JOIN to avoid planner oddness [core] - 10https://gerrit.wikimedia.org/r/532433 (https://phabricator.wikimedia.org/T231196) [19:15:49] 10MediaWiki-General, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: $wgActorTableSchemaMigrationStage = SCHEMA_COMPAT_NEW; brings down translatewiki.net - https://phabricator.wikimedia.org/T231196 (10Anomie) a:03Anomie [19:15:56] 10Community-Tech (Kanban (Q1 2019-20)): Spike: Password Reset Project [Timebox: 12 hours] - https://phabricator.wikimedia.org/T230436 (10MaxSem) > Is this correct? Yes. [19:17:14] (03PS1) 10Aaron Schulz: rdbms: remove unused $fulltextEnabled field from DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532434 [19:17:16] (03PS1) 10Aaron Schulz: rdbms: clean up use of ATTATCH queries in DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532435 [19:20:25] (03CR) 10jenkins-bot: Disambiguate confusing $fromReplica variable in BlockManager [core] - 10https://gerrit.wikimedia.org/r/531921 (owner: 10Tchanders) [19:21:07] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10CDanis) Per @Anomie's comment this isn't caused by any change in Me... [19:23:35] 10MediaWiki-API, 10Core Platform Team, 10Wikimedia-production-error: /w/api.php... ErrorException from line 0 of : PHP Notice: Unable to unserialize ... Size of serialized string ... exceeds max - https://phabricator.wikimedia.org/T231071 (10Anomie) >>! In T231071#5439210, @CDanis wrote: > Per @Anomie's comm... [19:24:55] (03Merged) 10jenkins-bot: Postpone call to MobileContext::shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532389 (https://phabricator.wikimedia.org/T231014) (owner: 10Pmiazga) [19:25:04] 10Timeless: Collapse sections on small screens on long pages - https://phabricator.wikimedia.org/T231246 (10Isarra) [19:26:07] (03CR) 10Tpt: [C: 03+2] Split apihelp messages to a separate file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/532124 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [19:27:14] (03PS3) 10Anomie: Revert actor changes to populateLogSearch.php [core] - 10https://gerrit.wikimedia.org/r/528952 (https://phabricator.wikimedia.org/T188327) [19:27:16] (03PS7) 10Anomie: Mostly drop old pre-actor user schemas [core] - 10https://gerrit.wikimedia.org/r/525605 (https://phabricator.wikimedia.org/T188327) [19:27:18] (03PS4) 10Anomie: Fix typo in ChangesListSpecialPageTest [core] - 10https://gerrit.wikimedia.org/r/528953 [19:29:22] (03CR) 10Krinkle: [C: 03+1] rdbms: remove unused $fulltextEnabled field from DatabaseSqlite [core] - 10https://gerrit.wikimedia.org/r/532434 (owner: 10Aaron Schulz) [19:30:19] (03CR) 10Anomie: [C: 03+2] SpecialNewSection: Fix handling of 'preloadparams' [core] - 10https://gerrit.wikimedia.org/r/532421 (https://phabricator.wikimedia.org/T231088) (owner: 10Bartosz Dziewoński) [19:30:34] (03CR) 10Krinkle: [C: 03+1] Revert actor changes to populateLogSearch.php [core] - 10https://gerrit.wikimedia.org/r/528952 (https://phabricator.wikimedia.org/T188327) (owner: 10Anomie) [19:33:11] (03CR) 10Anomie: [C: 03+2] REST: call MediaWiki::preOutputCommit and doPostOutputShutdown [core] - 10https://gerrit.wikimedia.org/r/530462 (owner: 10Tim Starling) [19:39:39] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Action API: Detect POST without Content-Type - https://phabricator.wikimedia.org/T230735 (10Anomie) 05Open→03Resolved [19:40:41] (03CR) 10Anomie: "Note that if this turns out to overload logstash, I9d8a05f896a3f8efc1818cda67a0a4cf4f947153 exists to keep the client warning without logg" [core] - 10https://gerrit.wikimedia.org/r/530904 (https://phabricator.wikimedia.org/T230735) (owner: 10Anomie) [19:43:16] 10wikimedia.biterg.io, 10Developer-Advocacy (Jul-Sep 2019): Provide FY2018-19 development contributors statistics for WMF Audit report - https://phabricator.wikimedia.org/T231221 (10bd808) [19:44:59] (03CR) 10jerkins-bot: [V: 04-1] rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) (owner: 10Anomie) [19:47:10] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Wikidata-Trailblazing-Exploration, 10Performance, 10Performance-Team (Radar): Reconsider caching in Wikibase\SitesModule::getScript - https://phabricator.wikimedia.org/T229153 (10Krinkle) I vaguely recall you doing some work on this, but I'm not sure i... [19:47:36] (03PS1) 10Isarra: Remove extra padding on thumbcaptions [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532440 [19:47:40] (03CR) 10Aaron Schulz: [C: 03+2] Setup: Remove scopedProfileIn() calls [core] - 10https://gerrit.wikimedia.org/r/532264 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [19:48:02] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: mentor message text style issue in mobile mentorship module dialog - https://phabricator.wikimedia.org/T230374 (10Etonkovidova) Checked in betalabs - `letter-spacing` is removed -... [19:50:47] 10Timeless: Better category handling in Timeless - https://phabricator.wikimedia.org/T160645 (10Isarra) [19:53:03] 10MediaWiki-Core-Testing, 10Performance-Team, 10Wikimedia-Rdbms, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10User-Addshore: LoadBalancer opening extra connections in different connection categories doesn't work with PHPUnit & temporary tables - https://phabricator.wikimedia.org/T202116 (10Krinkle) [19:53:06] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [19:53:26] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Code-Health, 10Continuous-Integration-Config, and 5 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [19:54:55] (03CR) 10Jdlrobson: Dev: Don't access globals inside components (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 (owner: 10Jdlrobson) [19:55:05] (03PS12) 10Anomie: rest: Use ParamValidator library, add BodyValidator [core] - 10https://gerrit.wikimedia.org/r/517076 (https://phabricator.wikimedia.org/T223239) [19:57:07] (03PS1) 10Jforrester: resources: Also add jQuery Migrate to foreign-resources.yaml [core] - 10https://gerrit.wikimedia.org/r/532442 [19:57:09] (03PS1) 10Jforrester: resources: Upgrade jQuery from v3.3.1 (patched) to v3.4.1 [core] - 10https://gerrit.wikimedia.org/r/532443 [19:57:11] (03PS1) 10Jforrester: resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 [core] - 10https://gerrit.wikimedia.org/r/532444 [19:57:37] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Mobile: Homepage: update "posted on" timestamp client-side when overlay is opened - https://phabricator.wikimedia.org/T225941 (10Etonkovidova) The timestamp gets updated prope... [19:57:39] 10Timeless: Since the interwiki links have been moved, it is not possible anymore to add interwiki links - https://phabricator.wikimedia.org/T231234 (10Isarra) Should we just put the languages back in the sidebar? In retrospect, I'm not actually sure this (moving it out) was such a great idea... [19:58:08] (03CR) 10Jforrester: [C: 04-2] resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 [core] - 10https://gerrit.wikimedia.org/r/532444 (owner: 10Jforrester) [19:58:11] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [19:58:15] (03CR) 10Jforrester: [C: 04-2] resources: Upgrade jQuery from v3.3.1 (patched) to v3.4.1 [core] - 10https://gerrit.wikimedia.org/r/532443 (owner: 10Jforrester) [19:59:18] (03CR) 10Jforrester: "To verify, run `php maintenance/manageForeignResources.php --conf=includes/DefaultSettings.php update jquery` then rescue the patch files " [core] - 10https://gerrit.wikimedia.org/r/532442 (owner: 10Jforrester) [20:00:34] (03CR) 10Jforrester: [C: 04-2] resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532444 (owner: 10Jforrester) [20:02:40] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Trying to expand issues doesn't show content - https://phabricator.wikimedia.org/T226247 (10Petar.petkovic) `Uncaught TypeError: Cannot read property 'id' of undefined` is already reported at T2... [20:02:55] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: bigamount-error is overly precise for other currencies - https://phabricator.wikimedia.org/T231013 (10Ejegg) [20:03:15] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Translation issues "Next Issue" button doesn't work: Uncaught TypeError: Cannot read property 'id' of undefined - https://phabricator.wikimedia.org/T229230 (10Petar.petkovic) Steps to reproduce... [20:09:39] 10Timeless: Since the interwiki links have been moved, it is not possible anymore to add interwiki links - https://phabricator.wikimedia.org/T231234 (10Isarra) Apparently some wikis still have CLL under 'beta features' and off by default, so actually, yeah, this was definitely a bad idea. [20:13:10] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): [AMC] Render talk page as a tab (rather than a modal) - https://phabricator.wikimedia.org/T230695 (10ovasileva) >>! In T230695#5439071, @alexhollender wrote: > @Jdlrobson @ovasileva I just added a note to the description... [20:14:02] 10WMEE: Wikimedia uus veebileht üles, koguda kasutajate tagasiside ja siis täiendada kuni esialgse rahuloluni - https://phabricator.wikimedia.org/T204043 (10tramm) [20:14:04] 10WMEE: Loetelu Phabricatori taskidest kanda automaatselt üle meie veebilehe rubriiki "vabatahtlik paneb käe külge" - https://phabricator.wikimedia.org/T223263 (10tramm) [20:14:40] 10Timeless: Use icons for previous, next, index tabs on Wikisource pages - https://phabricator.wikimedia.org/T231250 (10Isarra) [20:19:26] (03PS1) 10Ppchelko: Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) [20:20:21] 10MediaWiki-extensions-DonationInterface, 10FR-Ingenico, 10Fundraising-Backlog, 10Fundraising Sprint Quick and the Deadlocked, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Legacy GlobalCollect: don't generate order IDs starting with 4 or 7 - https://phabricator.wikimedia.org/T230809 (10Ejegg) 05Open→0... [20:22:18] 10MobileFrontend, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): Use native image lazy loading on mobile site - https://phabricator.wikimedia.org/T230812 (10kchapman) [20:22:54] 10foundation.wikimedia.org, 10Performance-Team (Radar): Use of Flickity JS library on Foundation website seems unnecessary - https://phabricator.wikimedia.org/T230776 (10kchapman) [20:26:40] (03CR) 10Ppchelko: "The getMultiWithUnionSetCallback pretty much does everything we need already - it loads as a batch only the missing addresses, thus we don" [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [20:27:08] 10MediaWiki-General: Figure out how to make LocalisationCache a service without hurting performance - https://phabricator.wikimedia.org/T231220 (10hashar) >>! In T231220#5438931, @Krinkle wrote: > See also T225730#5400979 which is about making Quibble use a file-based LCStore (instead of LCStoreDB). The patch fo... [20:28:08] (03CR) 10jerkins-bot: [V: 04-1] resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 [core] - 10https://gerrit.wikimedia.org/r/532444 (owner: 10Jforrester) [20:33:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532321 (owner: 10L10n-bot) [20:35:13] (03CR) 10Ppchelko: [C: 03+2] Fix typo in ChangesListSpecialPageTest [core] - 10https://gerrit.wikimedia.org/r/528953 (owner: 10Anomie) [20:38:19] (03CR) 10jenkins-bot: Postpone call to MobileContext::shouldDisplayMobileView() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532389 (https://phabricator.wikimedia.org/T231014) (owner: 10Pmiazga) [20:43:24] (03Merged) 10jenkins-bot: Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:45:07] (03CR) 10Krinkle: Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:45:11] (03CR) 10Krinkle: "Thanks :)" [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [20:47:38] (03CR) 10DannyS712: [C: 03+1] "Looks good to me" [core] - 10https://gerrit.wikimedia.org/r/532421 (https://phabricator.wikimedia.org/T231088) (owner: 10Bartosz Dziewoński) [20:48:46] (03CR) 10jerkins-bot: [V: 04-1] Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [20:49:15] (03CR) 10jerkins-bot: [V: 04-1] Workaround setMwGlobals resetting services [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/532336 (owner: 10simetrical) [20:51:31] (03CR) 10jerkins-bot: [V: 04-1] resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 [core] - 10https://gerrit.wikimedia.org/r/532444 (owner: 10Jforrester) [20:52:05] (03CR) 10jenkins-bot: Use local variabe $services instead of MediaWikiServices::getInstance() [core] - 10https://gerrit.wikimedia.org/r/532384 (owner: 10Fomafix) [20:53:53] (03PS1) 10Isarra: Better position notifications area (watchlist ajax, preferences changes, etc) to account for fixed header [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532460 [20:54:44] (03CR) 10Jforrester: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532321 (owner: 10L10n-bot) [20:56:18] (03CR) 10jerkins-bot: [V: 04-1] resources: Upgrade jQuery Migrate from v3.0.1 (patched) to v3.1.0 [core] - 10https://gerrit.wikimedia.org/r/532444 (owner: 10Jforrester) [20:57:09] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [20:58:42] (03CR) 10jerkins-bot: [V: 04-1] Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [21:00:15] 10Research: San Francisco Rotary Club talk - https://phabricator.wikimedia.org/T229272 (10leila) [21:01:46] 10Accessibility, 10Growth-Team, 10PageCuration, 10UX-Debt, and 2 others: NewPagesFeed article snippet fails WCAG AA - https://phabricator.wikimedia.org/T217781 (10kostajh) [21:03:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532321 (owner: 10L10n-bot) [21:03:26] 10Research: San Francisco Rotary Club talk - https://phabricator.wikimedia.org/T229272 (10leila) >>! In T229272#5391287, @jcrben wrote: > Saw this at https://lists.wikimedia.org/pipermail/wikimedia-sf/2019-July/thread.html > > A good place to start looking for meetups anywhere is https://en.wikipedia.org/wiki/W... [21:05:08] 10Research: San Francisco Rotary Club talk - https://phabricator.wikimedia.org/T229272 (10leila) [21:06:12] (03CR) 10jerkins-bot: [V: 04-1] Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [21:07:50] (03PS6) 10Jdlrobson: Dev: Don't access globals inside components [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 [21:07:52] (03PS7) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 [21:07:54] (03PS25) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [21:08:01] (03PS1) 10Isarra: Make editsection icon part of first editsection link [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532461 [21:09:45] 10MediaWiki-General: Stop converting html in json content pages - https://phabricator.wikimedia.org/T204454 (10matmarex) [21:10:09] (03CR) 10jerkins-bot: [V: 04-1] Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) (owner: 10Ppchelko) [21:12:29] 10UploadWizard: UploadWizard Campaign error message for invalid JSON is broken - https://phabricator.wikimedia.org/T231252 (10matmarex) [21:13:01] 10MobileFrontend, 10Release-Engineering-Team, 10Continuous-Integration-Config, 10Documentation, and 2 others: Migrate documentation generation to Node 10.15.2 from node 6.11.0 - https://phabricator.wikimedia.org/T230841 (10Jdforrester-WMF) @Jdlrobson: Unfortunately it's not passing in CI: > 00:02:07.087... [21:15:51] 10UploadWizard, 10Patch-For-Review: UploadWizard Campaign error message for invalid JSON is broken - https://phabricator.wikimedia.org/T231252 (10matmarex) a:03matmarex Expected results with the patch, on my local testing wiki: {F30120192} `lang=json { "error": { "code": "eventlogging-invalid-js... [21:16:48] (03CR) 10jenkins-bot: Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [21:18:28] (03PS5) 10Kosta Harlan: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:19:31] (03PS1) 10Isarra: Better contrast on wikitable borders [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532464 (https://phabricator.wikimedia.org/T220255) [21:21:39] (03Merged) 10jenkins-bot: rdbms: rename $db => $conn in remaining places in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/532397 (owner: 10Aaron Schulz) [21:23:32] (03Merged) 10jenkins-bot: rdbms: simplify comment in LoadBalancer::reuseConnection() [core] - 10https://gerrit.wikimedia.org/r/532291 (owner: 10Aaron Schulz) [21:23:58] (03CR) 10Jforrester: "check experimental" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532135 (owner: 10L10n-bot) [21:24:15] 10MediaWiki-API, 10Core Platform Team: API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set - https://phabricator.wikimedia.org/T231253 (10matmarex) [21:24:24] 10MediaWiki-API, 10Core Platform Team: API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set - https://phabricator.wikimedia.org/T231253 (10matmarex) [21:24:27] 10Patch-For-Review, 10VisualEditor (Current work): VisualEditor should use errorformat=html and maybe drop some of our custom error messages in favor of default ones - https://phabricator.wikimedia.org/T229532 (10matmarex) [21:24:31] 10MediaWiki-API, 10Core Platform Team: API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set - https://phabricator.wikimedia.org/T231253 (10matmarex) a:03matmarex [21:24:33] (03PS2) 10Ppchelko: Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) [21:24:49] (03CR) 10Kosta Harlan: "with PS5, I can do vendor/bin/phpunit tests/phpunit/unit/includes/changes/ and php tests/phpunit/phpunit.php tests/phpunit/unit/includes/" [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:25:20] (03PS1) 10Bartosz Dziewoński: EditPage: Don't set 'hookaborted' error if the hook set a better error [core] - 10https://gerrit.wikimedia.org/r/532465 (https://phabricator.wikimedia.org/T231253) [21:25:45] (03PS26) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [21:27:43] (03CR) 10Jdlrobson: Document all our components in storybook (039 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [21:29:51] 10Epic, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Utilize the displaytitle returned by /page/summary wherever article titles are displayed - https://phabricator.wikimedia.org/T227092 (10cooltey) a:03cooltey [21:30:25] (03PS12) 10Jdlrobson: mobile.init/editor: Use the same loading transition for wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529452 (https://phabricator.wikimedia.org/T228159) (owner: 10Bartosz Dziewoński) [21:31:01] (03PS7) 10Jdlrobson: Dev: Don't access globals inside components [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 [21:32:34] (03PS13) 10Jdlrobson: mobile.init/editor: Use the same loading transition for wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529452 (https://phabricator.wikimedia.org/T228159) (owner: 10Bartosz Dziewoński) [21:32:48] (03CR) 10Jdlrobson: [C: 03+2] mobile.init/editor: Use the same loading transition for wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529452 (https://phabricator.wikimedia.org/T228159) (owner: 10Bartosz Dziewoński) [21:33:46] (03PS8) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 [21:33:54] (03PS27) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [21:34:32] (03CR) 10jerkins-bot: [V: 04-1] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [21:34:54] (03PS28) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [21:35:14] (03PS5) 10Jdlrobson: Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) [21:35:56] (03CR) 10Jdlrobson: [C: 03+2] [LESS] remove unused variables [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531720 (owner: 10Niedzielski) [21:36:29] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set - https://phabricator.wikimedia.org/T231253 (10WDoranWMF) [21:37:55] (03CR) 10jenkins-bot: rdbms: rename $db => $conn in remaining places in LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/532397 (owner: 10Aaron Schulz) [21:38:10] (03PS1) 10Isarra: Style datatables consistently with wikitables [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532469 (https://phabricator.wikimedia.org/T220232) [21:38:18] (03CR) 10jerkins-bot: [V: 04-1] Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (owner: 10Jdlrobson) [21:41:28] (03PS1) 10Jforrester: [DNM] Don't run storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532470 [21:41:41] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [21:41:44] (03CR) 10Jforrester: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532470 (owner: 10Jforrester) [21:43:38] (03CR) 10Dmaza: [C: 03+1] Use GetUserBlock hook instead of GetBlockedStatus [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/525665 (https://phabricator.wikimedia.org/T229692) (owner: 10Tchanders) [21:44:07] (03CR) 10Jforrester: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [21:49:53] (03PS3) 10Bartosz Dziewoński: Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) [21:50:03] (03PS5) 10Bartosz Dziewoński: Actually return errors for action=edit API [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/526829 (https://phabricator.wikimedia.org/T229539) [21:50:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532135 (owner: 10L10n-bot) [21:50:49] 10Timeless, 10Patch-For-Review: Style datatables consistently with wikitables - https://phabricator.wikimedia.org/T220232 (10Izno) On an aside, I don't entirely understand why mw-datatable and wikitable are two separate sets of styling. :^) [21:51:13] (03CR) 10jerkins-bot: [V: 04-1] Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) (owner: 10Bartosz Dziewoński) [21:52:01] (03CR) 10jerkins-bot: [V: 04-1] Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) (owner: 10Bartosz Dziewoński) [21:52:30] (03PS1) 10Accraze: (WIP) Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/532471 (https://phabricator.wikimedia.org/T199834) [21:52:45] (03CR) 10jerkins-bot: [V: 04-1] (WIP) Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/532471 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [21:53:57] (03CR) 10jerkins-bot: [V: 04-1] (WIP) Implement api modules [extensions/Jade] - 10https://gerrit.wikimedia.org/r/532471 (https://phabricator.wikimedia.org/T199834) (owner: 10Accraze) [21:56:13] (03PS4) 10Bartosz Dziewoński: Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) [21:57:54] (03CR) 10Jforrester: "OK, this successfully runs the doc build and publishes it: https://doc.wikimedia.org/MobileFrontend/master/js/js/ (but it'd be nice to fix" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532470 (owner: 10Jforrester) [21:58:54] (03CR) 10Jforrester: "This hangs in about the same place, "70%" of the second WebPack build step." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [21:59:19] (03CR) 10jerkins-bot: [V: 04-1] Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) (owner: 10Bartosz Dziewoński) [21:59:37] 10MediaWiki-API, 10AbuseFilter, 10SpamBlacklist, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: AbuseFilter and SpamBlacklist return a "successful" action=edit API response when they prevent edits - https://phabricator.wikimedia.org/T229539 (10matmarex) @mobrovac All patches here... [21:59:43] 10MediaWiki-API, 10AbuseFilter, 10SpamBlacklist, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: AbuseFilter and SpamBlacklist return a "successful" action=edit API response when they prevent edits - https://phabricator.wikimedia.org/T229539 (10matmarex) a:03matmarex [22:00:44] (03Merged) 10jenkins-bot: objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [22:00:45] (03Merged) 10jenkins-bot: Fix config name [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 (owner: 10Paladox) [22:00:51] (03Merged) 10jenkins-bot: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532399 (https://phabricator.wikimedia.org/T231200) (owner: 10Ladsgroup) [22:00:55] (03Merged) 10jenkins-bot: Dev: Explicitly reference `less` file extension when importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532404 (owner: 10Jdlrobson) [22:01:10] 10MediaWiki-API, 10AbuseFilter, 10SpamBlacklist, 10Core Platform Team Workboards (Clinic Duty Team), and 2 others: AbuseFilter and SpamBlacklist return a "successful" action=edit API response when they prevent edits - https://phabricator.wikimedia.org/T229539 (10matmarex) [22:01:24] (03PS1) 10Paladox: Fix config name [extensions/DisqusTag] (REL1_33) - 10https://gerrit.wikimedia.org/r/532472 [22:01:39] 10MediaWiki-API, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review, 10VisualEditor (Current work): API action=edit with errorformat=html returns a redundant 'hookaborted' error even when an error message is set - https://phabricator.wikimedia.org/T231253 (10matmarex) [22:02:19] 10Timeless, 10Patch-For-Review: Style datatables consistently with wikitables - https://phabricator.wikimedia.org/T220232 (10Isarra) Understanding? In MY MediaWiki? ...it's probably not any more likely than you think. [22:02:24] (03CR) 10Paladox: "I'm not sure why this branch was created." [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 (owner: 10Paladox) [22:03:55] (03CR) 10jenkins-bot: rdbms: simplify comment in LoadBalancer::reuseConnection() [core] - 10https://gerrit.wikimedia.org/r/532291 (owner: 10Aaron Schulz) [22:05:47] (03CR) 10Jforrester: "check experimental" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/532192 (owner: 10L10n-bot) [22:07:23] (03CR) 10jerkins-bot: [V: 04-1] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [22:08:37] (03CR) 10jerkins-bot: [V: 04-1] Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) (owner: 10Jdlrobson) [22:10:06] (03CR) 10jerkins-bot: [V: 04-1] Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 (owner: 10Jdlrobson) [22:12:45] (03CR) 10Jdrewniak: [C: 03+2] Separate AMC icons from non-AMC icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531756 (https://phabricator.wikimedia.org/T229295) (owner: 10Jdlrobson) [22:14:15] (03CR) 10Jack Phoenix: [C: 03+2] "Mmm, consistency." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532469 (https://phabricator.wikimedia.org/T220232) (owner: 10Isarra) [22:14:39] (03CR) 10Jack Phoenix: [C: 03+2] Better contrast on wikitable borders [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532464 (https://phabricator.wikimedia.org/T220255) (owner: 10Isarra) [22:15:34] (03CR) 10Jack Phoenix: [C: 03+2] "Makes sense." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532461 (owner: 10Isarra) [22:15:59] (03CR) 10jerkins-bot: [V: 04-1] Actually return errors for action=edit API [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526828 (https://phabricator.wikimedia.org/T229539) (owner: 10Bartosz Dziewoński) [22:16:22] (03CR) 10Jack Phoenix: [C: 03+2] Better position notifications area (watchlist ajax, preferences changes, etc) to account for fixed header [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532460 (owner: 10Isarra) [22:16:27] (03CR) 10Jack Phoenix: [C: 03+2] Remove extra padding on thumbcaptions [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532440 (owner: 10Isarra) [22:21:10] (03CR) 10Jdlrobson: [C: 03+2] Support other ways to get the description of the page [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/531960 (https://phabricator.wikimedia.org/T230947) (owner: 10Martineznovo) [22:21:33] 10CPT Initiatives (Decoupling (CDP2)), 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10Patch-For-Review: Remove calls to deprecated methods in Title and User with calls to the new PermissionManager service. - https://phabricator.wikimedia.org/T220191 (10Pch... [22:22:09] (03CR) 10Jforrester: [C: 03+2] Prepend in-topic mention matches to results [extensions/Flow] - 10https://gerrit.wikimedia.org/r/531947 (owner: 10Esanders) [22:22:46] (03CR) 10Jforrester: [C: 03+2] MentionInspector: Don't assume the board can be found [extensions/Flow] - 10https://gerrit.wikimedia.org/r/531949 (https://phabricator.wikimedia.org/T201511) (owner: 10Esanders) [22:23:12] (03CR) 10jenkins-bot: Dev: Explicitly reference `less` file extension when importing LESS files [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532404 (owner: 10Jdlrobson) [22:25:50] (03PS29) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [22:26:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/532192 (owner: 10L10n-bot) [22:29:31] (03PS8) 10Jdlrobson: Dev: Don't access globals inside components [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 [22:30:40] 10Epic, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Utilize the displaytitle returned by /page/summary wherever article titles are displayed - https://phabricator.wikimedia.org/T227092 (10cooltey) Note: we can apply the correct `displaytitle` to the following places: 1. Trend... [22:33:46] (03CR) 10jenkins-bot: objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [22:35:04] (03PS9) 10Jdlrobson: Dev: Don't access globals inside components [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531758 [22:35:08] (03PS9) 10Jdlrobson: Icons should not be defined in stylesheets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/531742 [22:35:17] (03PS30) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [22:37:46] (03CR) 10jenkins-bot: mobile.init/editor: Use the same loading transition for wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529452 (https://phabricator.wikimedia.org/T228159) (owner: 10Bartosz Dziewoński) [22:38:07] (03PS6) 10Jdlrobson: Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) [22:39:21] (03PS2) 10Jdlrobson: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [22:40:01] (03CR) 10Samwilson: "check php" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (https://phabricator.wikimedia.org/T213513) (owner: 10Ankita Mandal) [22:40:03] (03PS1) 10Urbanecm: Introduce wmgRealm [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/532477 [22:40:52] (03PS3) 10Ppchelko: Introduce BlobStore::getBlobBatch method. [core] - 10https://gerrit.wikimedia.org/r/532449 (https://phabricator.wikimedia.org/T230834) [22:44:45] 10Timeless: hamburger is broken on mobile when viewing wikipedia main page - https://phabricator.wikimedia.org/T231256 (10Paladox) [22:44:55] 10Timeless: hamburger is broken on mobile when viewing wikipedia main page - https://phabricator.wikimedia.org/T231256 (10Paladox) p:05Triage→03High [22:45:31] (03PS2) 10Urbanecm: Introduce wmgRealm [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/532477 [22:47:56] (03CR) 10jenkins-bot: Revert "Make LocalisationCache a service" [core] - 10https://gerrit.wikimedia.org/r/532399 (https://phabricator.wikimedia.org/T231200) (owner: 10Ladsgroup) [22:50:03] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/532121 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [22:52:01] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/532123 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [22:52:43] (03CR) 10jenkins-bot: Split apihelp messages to a separate file [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/532121 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [22:54:43] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/532122 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [22:55:46] 10UI-Standardization, 10Advanced Mobile Contributions, 10Confirmation prompt for rollback action, 10MinervaNeue, and 2 others: Minerva styles the wrong selector for rollback link - https://phabricator.wikimedia.org/T230656 (10Jdrewniak) Per AQ steps: this looks good on beta. [22:55:59] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [22:56:02] 10UI-Standardization, 10Advanced Mobile Contributions, 10Confirmation prompt for rollback action, 10MinervaNeue, and 2 others: Minerva styles the wrong selector for rollback link - https://phabricator.wikimedia.org/T230656 (10Jdrewniak) a:05Jdrewniak→03None [22:58:19] (03Merged) 10jenkins-bot: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [23:00:15] (03CR) 10jerkins-bot: [V: 04-1] Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) (owner: 10Jdlrobson) [23:00:24] 10MediaWiki-User-preferences, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech (Kanban (Q1 2019-20)), 10Wikimedia-production-error: DefaultPreferencesFactory.php: Global default '' is invalid for field incubatortestwiki-code - https://phabricator.wikimedia.org/T231029 (10MaxSem) Working on it, ho... [23:02:07] (03CR) 10jerkins-bot: [V: 04-1] Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 (owner: 10Jdlrobson) [23:04:56] (03PS1) 10Jdrewniak: [POC] merge .mw-ui-icon-element class into .mw-ui-icon class [core] - 10https://gerrit.wikimedia.org/r/532480 [23:06:16] (03PS3) 10Jdlrobson: [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [23:06:18] (03PS5) 10Jdlrobson: WIP: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [23:06:46] (03PS6) 10Jdlrobson: Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) [23:07:04] (03PS2) 10Paladox: Use addDescription() instead of accessing guts directly [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530703 [23:07:16] 10Wikimedia-Site-requests, 10Performance: Consider raising $wgMaxImageArea / $wgMaxAnimatedGifArea - https://phabricator.wikimedia.org/T64463 (10Perhelion) [23:07:22] (03PS31) 10Jdlrobson: Document all our components in storybook [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529138 [23:07:34] (03PS7) 10Jdlrobson: Dev: Pull out SearchHeader from SearchOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/529833 (https://phabricator.wikimedia.org/T220849) [23:07:38] (03CR) 10Urbanecm: [C: 03+2] Introduce wmgRealm [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/532477 (owner: 10Urbanecm) [23:08:44] (03CR) 10Esanders: "ping" [core] - 10https://gerrit.wikimedia.org/r/507793 (https://phabricator.wikimedia.org/T230559) (owner: 10Esanders) [23:09:58] (03Merged) 10jenkins-bot: Introduce wmgRealm [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/532477 (owner: 10Urbanecm) [23:10:34] 10Wikimedia-Site-requests, 10Performance: Consider raising $wgMaxImageArea / $wgMaxAnimatedGifArea - https://phabricator.wikimedia.org/T64463 (10Perhelion) [23:11:08] 10MediaWiki-REST-API, 10CPT Initiatives (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Workboards (Green), 10Patch-For-Review, 10Services (watching): REST API i18n - https://phabricator.wikimedia.org/T226598 (10tstarling) That's why the plaintext type was omitted from the WIP patch, although I s... [23:12:57] 10Design, 10Wikimedia-Portals, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog, and 2 others: Improve presentation of apps on portal - https://phabricator.wikimedia.org/T225648 (10Jdrewniak) a:05Jdrewniak→03None [23:14:02] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10Jdrewniak) a:05Jdrewniak→03None [23:14:08] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10MinervaNeue (Desktop), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Cleanup AMC feature flagging - https://phabricator.wikimedia.org/T229295 (10Jdrewniak) a:03Edtadros [23:14:43] (03Merged) 10jenkins-bot: Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [23:15:09] (03PS3) 10Paladox: Use addDescription() instead of accessing guts directly [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530703 [23:15:12] (03PS1) 10Paladox: removeOrphanedEvents.php: Don't remove events waiting to be emailed [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532481 [23:15:15] (03PS1) 10Paladox: removeOrphanedEvents.php: Also remove echo_target_page rows [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532482 (https://phabricator.wikimedia.org/T221261) [23:16:13] 10Structured Data Engineering, 10SDC-Statements (Campaigns-jogging), 10Structured-Data-Backlog (Current Work): Explore simple, campaign-specific "sync" functionality for statements in UploadWizard - https://phabricator.wikimedia.org/T231225 (10egardner) [23:20:24] (03Merged) 10jenkins-bot: Warn if a function has been given too many parameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [23:20:26] (03Merged) 10jenkins-bot: Add new widgets [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/531494 (owner: 10ItSpiderman) [23:20:35] (03PS1) 10Paladox: Proactively delete echo_event rows when they become orphaned [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532483 (https://phabricator.wikimedia.org/T221262) [23:29:34] 10ISA: Only allow specific country selection on Wiki Loves campaigns - https://phabricator.wikimedia.org/T229827 (10Anthere) I'd say checking syntax and stoping creation if wrong selections might be the best... [23:30:08] (03Merged) 10jenkins-bot: Disable hyphenation for links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/530783 (https://phabricator.wikimedia.org/T230860) (owner: 10Shreyasminocha) [23:30:10] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/532124 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [23:30:17] (03Merged) 10jenkins-bot: SpecialNewSection: Fix handling of 'preloadparams' [core] - 10https://gerrit.wikimedia.org/r/532421 (https://phabricator.wikimedia.org/T231088) (owner: 10Bartosz Dziewoński) [23:34:31] (03CR) 10jerkins-bot: [V: 04-1] [icon] revise icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531713 (https://phabricator.wikimedia.org/T229440) (owner: 10Niedzielski) [23:36:40] (03Merged) 10jenkins-bot: REST: call MediaWiki::preOutputCommit and doPostOutputShutdown [core] - 10https://gerrit.wikimedia.org/r/530462 (owner: 10Tim Starling) [23:36:48] (03Merged) 10jenkins-bot: Setup: Remove scopedProfileIn() calls [core] - 10https://gerrit.wikimedia.org/r/532264 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [23:37:25] (03PS1) 10Ppchelko: Move User::getAll{Rights,Groups} to PermissionManager. [core] - 10https://gerrit.wikimedia.org/r/532486 (https://phabricator.wikimedia.org/T220191) [23:38:31] 10ISA: campaign #8 broken - https://phabricator.wikimedia.org/T231257 (10Anthere) [23:42:10] 10ISA: Wrong number of improved images in a campaign - https://phabricator.wikimedia.org/T231258 (10Anthere) [23:43:15] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [23:44:01] (03CR) 10jerkins-bot: [V: 04-1] Change the default behaviour for mw-ui-icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/531558 (https://phabricator.wikimedia.org/T229447) (owner: 10Jdlrobson) [23:44:15] 10ISA: Can't remove existing captions - https://phabricator.wikimedia.org/T231133 (10Anthere) Note: deletion of depict work : https://commons.wikimedia.org/w/index.php?title=File:Tabernacle_chapel_(Cong),_Maenclochog_NLW3363833.jpg&action=history [23:44:32] 10Structured Data Engineering, 10Structured-Data-Backlog (Current Work): Labels for newly-added values don't show up as links - https://phabricator.wikimedia.org/T230849 (10Ramsey-WMF) p:05Triage→03Normal [23:45:09] 10Structured Data Engineering, 10Structured-Data-Backlog (Current Work): Labels for newly-added values don't show up as links - https://phabricator.wikimedia.org/T230849 (10Ramsey-WMF) Seems fine on Beta, but now that the bug is present on production as well, need to verify this fix makes it to prod. [23:47:19] 10ISA: campaign #8 broken - https://phabricator.wikimedia.org/T231257 (10Anthere) This is actually bug https://phabricator.wikimedia.org/T231167 [23:50:57] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Avoid hyphenation in URLs that span multiple lines - https://phabricator.wikimedia.org/T230860 (10Jdlrobson) Thanks for your patience and patch submission @Shreyasminocha! [23:51:15] 10ISA: WLX campaign 7 is broken - https://phabricator.wikimedia.org/T231259 (10Anthere) [23:51:17] (03CR) 10jenkins-bot: Split apihelp messages to a separate file [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/532122 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [23:51:19] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Avoid hyphenation in URLs that span multiple lines - https://phabricator.wikimedia.org/T230860 (10Jdlrobson) [23:52:17] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/532401 (owner: 10Paladox) [23:53:56] (03CR) 10jenkins-bot: Disable hyphenation for links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/530783 (https://phabricator.wikimedia.org/T230860) (owner: 10Shreyasminocha) [23:54:08] 10Structured Data Engineering, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10SDC-Statements (Other-statements-running), 10Structured-Data-Backlog (Current Work): Handle language fallback chain consistently in Statement UI - https://phabricator.wikimedia.org/T229602 (10Ramsey-WMF) Tested on Beta, seems to... [23:54:23] (03PS1) 10EBernhardson: Move choosing config file to dedicated module [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/532488 [23:54:25] (03PS1) 10EBernhardson: bulk_daemon: Minor cleanups [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/532489 [23:54:28] (03PS1) 10EBernhardson: Add progressive typing to daemons [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/532490 [23:54:29] (03PS1) 10EBernhardson: Move bulk daemon configuration to yaml [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/532491 [23:55:37] (03CR) 10jenkins-bot: NotificationJob: make sure we retry to load the event from master [extensions/Echo] (REL1_33) - 10https://gerrit.wikimedia.org/r/530701 (https://phabricator.wikimedia.org/T204894) (owner: 10Paladox) [23:55:45] 10ISA: Can't remove existing captions - https://phabricator.wikimedia.org/T231133 (10Anthere) [23:56:59] (03CR) 10EBernhardson: [C: 03+2] "Makes sense, usage with new result classes seems fairly obvious. I do wonder if this is truly necessary to split since core is following t" [core] - 10https://gerrit.wikimedia.org/r/527159 (owner: 10DCausse) [23:58:50] (03CR) 10EBernhardson: [C: 03+2] Hard deprecate new SearchResult() and introduce RevisionSearchResult [core] - 10https://gerrit.wikimedia.org/r/527216 (https://phabricator.wikimedia.org/T228626) (owner: 10DCausse)