[00:01:46] (03PS1) 10SLF bot: Updating domains.php from Mozilla [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/532112 [00:05:11] (03CR) 10jenkins-bot: objectcache: make WANObjectCache::relayPurge() actually use $holdoff [core] - 10https://gerrit.wikimedia.org/r/525467 (owner: 10Aaron Schulz) [00:06:39] 10MediaWiki-API, 10Documentation, 10User-Jayprakash12345: Review code snippets (PHP, Javascript & MediaWiki JS) around Action API for on-wiki documentation - https://phabricator.wikimedia.org/T228549 (10Jayprakash12345) 05Open→03Resolved a:03Jayprakash12345 [00:15:52] 10MediaWiki-Parser, 10MediaWiki-User-management, 10Core Platform Team, 10Patch-For-Review, 10User-DannyS712: Option to disable user "block" links - https://phabricator.wikimedia.org/T36888 (10DannyS712) Would #core_platform_team be willing to review this? [00:18:13] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/532107 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [00:18:34] (03PS1) 10DannyS712: Add filter to `Special:BlockList` to exclude indefinite blocks [core] - 10https://gerrit.wikimedia.org/r/532113 (https://phabricator.wikimedia.org/T112380) [00:20:43] (03CR) 10jenkins-bot: Split apihelp messages to a separate file [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/532107 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [00:21:58] (03CR) 10jenkins-bot: rdbms: make LBFactory close/rollback dangling handles like LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/529199 (https://phabricator.wikimedia.org/T225103) (owner: 10Aaron Schulz) [00:42:59] (03PS2) 10DannyS712: Add filter to `Special:BlockList` to exclude indefinite blocks [core] - 10https://gerrit.wikimedia.org/r/532113 (https://phabricator.wikimedia.org/T112380) [00:49:26] (03PS2) 10Aaron Schulz: Migrate edit count caching classes to WANObjectCache [extensions/EditcountAdditions] - 10https://gerrit.wikimedia.org/r/529455 [00:49:59] (03PS4) 10Aaron Schulz: Migrate count caching classes to WANObjectCache [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/529445 [00:53:32] (03PS4) 10Aaron Schulz: parsercache: use WRITE_ALLOW_SEGMENTS for cached ParserOutput values [core] - 10https://gerrit.wikimedia.org/r/517679 (https://phabricator.wikimedia.org/T204742) [00:58:36] (03CR) 10Alex Monk: "https://github.com/wikimedia/banana-checker/pull/79 for the banana failure." [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/532110 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [00:58:59] wikimedia/banana-checker#252 (g532110 - c98d467 Alex Monk): The build failed. - https://travis-ci.org/wikimedia/banana-checker/builds/576333007 [01:00:02] well that's interesting, we don't have notifications to say a PR was opened in github but we do have travis results? [01:01:42] wikimedia/banana-checker#254 (g532110 - ecfb3a8 Alex Monk): The build was fixed. - https://travis-ci.org/wikimedia/banana-checker/builds/576333370 [01:11:28] (03PS2) 10Aaron Schulz: objectcache: add "coalesceKeys" option to WANObjectCache for key grouping [core] - 10https://gerrit.wikimedia.org/r/531805 [01:13:11] (03CR) 10Aaron Schulz: "A different patch eventually adds it to the class that IExpiringStore aliases...I'm trying to avoid conflicts though." [core] - 10https://gerrit.wikimedia.org/r/529440 (owner: 10Aaron Schulz) [01:14:41] (03CR) 10Aaron Schulz: objectcache: SqlBagOStuff cleanups for sqlite and postgres (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [01:15:42] (03PS2) 10Aaron Schulz: Migrate BagOStuff::incr() calls to incrWithInit() [core] - 10https://gerrit.wikimedia.org/r/529441 [01:20:56] (03CR) 10Huji: [C: 03+2] Split apihelp messages to a separate file [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/532106 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [01:22:37] (03PS4) 10Aaron Schulz: [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) [01:23:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [01:24:14] (03PS6) 10Aaron Schulz: Make NameTableStore use LoadBalancer::getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/527859 [01:24:20] (03PS7) 10Aaron Schulz: Make NameTableStore use LoadBalancer::getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/527859 [01:25:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [01:26:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [01:26:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP] rdbms: improve LoadBalancer connection pool reuse [core] - 10https://gerrit.wikimedia.org/r/519305 (https://phabricator.wikimedia.org/T226595) (owner: 10Aaron Schulz) [01:30:02] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532105 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [01:30:05] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/532106 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [01:30:39] (03PS30) 10Aaron Schulz: objectcache: split out various interfaces from BagOStuff [core] - 10https://gerrit.wikimedia.org/r/524663 [01:32:39] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Krenair) [01:35:52] (03PS1) 10Alex Monk: Split apihelp messages to a separate file [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/532121 (https://phabricator.wikimedia.org/T189982) [01:35:54] (03CR) 10jenkins-bot: Split apihelp messages to a separate file [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532105 (https://phabricator.wikimedia.org/T189982) (owner: 10Alex Monk) [01:38:05] (03PS1) 10Alex Monk: Split apihelp messages to a separate file [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/532122 (https://phabricator.wikimedia.org/T189982) [01:41:10] (03PS1) 10Alex Monk: Split apihelp messages to a separate file [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/532123 (https://phabricator.wikimedia.org/T189982) [01:43:05] (03PS1) 10Alex Monk: Split apihelp messages to a separate file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/532124 (https://phabricator.wikimedia.org/T189982) [01:45:28] (03PS1) 10Alex Monk: Split apihelp messages to a separate file [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/532125 (https://phabricator.wikimedia.org/T189982) [01:49:32] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Krenair) [01:50:06] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Krenair) [01:53:23] (03CR) 10jerkins-bot: [V: 04-1] objectcache: split out various interfaces from BagOStuff [core] - 10https://gerrit.wikimedia.org/r/524663 (owner: 10Aaron Schulz) [01:54:26] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Krenair) [02:38:27] (03PS1) 10Jack Phoenix: Use regex to remove (mutilated) Cite citation numbers (like this [9]) from the meta description [extensions/ArticleMetaDescription] - 10https://gerrit.wikimedia.org/r/532128 [02:50:35] (03PS2) 10Isarra: Merge 'skins.timeless.misc' back into 'skins.timeless' [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532101 (owner: 10Krinkle) [02:59:10] (03CR) 10Isarra: [C: 03+2] Merge 'skins.timeless.misc' back into 'skins.timeless' [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532101 (owner: 10Krinkle) [03:03:43] (03Merged) 10jenkins-bot: Merge 'skins.timeless.misc' back into 'skins.timeless' [skins/Timeless] - 10https://gerrit.wikimedia.org/r/532101 (owner: 10Krinkle) [03:16:28] (03PS31) 10Aaron Schulz: objectcache: split out various interfaces from BagOStuff [core] - 10https://gerrit.wikimedia.org/r/524663 [03:46:49] 04(no projects): Roccitrhyno@gmail.com - https://phabricator.wikimedia.org/T230614 (10Rhyno8412) p:05Triage→03Unbreak! [03:47:41] (03PS1) 10DannyS712: Add invert namespace option to Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) [03:49:45] 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Elections: Carry out the 2019 fawiki elections on votewiki - https://phabricator.wikimedia.org/T230614 (10JJMC89) p:05Unbreak!→03Triage [03:59:38] (03PS2) 10DannyS712: Add invert namespace option to Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) [04:03:26] (03CR) 10jerkins-bot: [V: 04-1] Add invert namespace option to Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) (owner: 10DannyS712) [04:06:15] (03PS3) 10DannyS712: Add invert namespace option to Special:LintErrors [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532129 (https://phabricator.wikimedia.org/T172703) [06:01:03] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage) - https://phabricator.wikimedia.org/T230260 (10alex-mashin) >>! In T230260#5435781, @Umherirrender wrote: > Looks good now Will it be b... [06:49:07] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [06:49:27] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10MaxBioHazard) I know, but the rest that I wrote remains valid. Why is this annoying warning needed, if any browser, used in 2019, saves text fields cont... [06:52:36] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Sentence highlighting not working on articles with math formulas - https://phabricator.wikimedia.org/T231076 (10Petar.petkovic) [07:22:50] (03CR) 10simetrical: "> Patch Set 5:" [core] - 10https://gerrit.wikimedia.org/r/531485 (owner: 10simetrical) [07:23:20] (03PS10) 10simetrical: LockManagerGroupFactory to replace singletons [core] - 10https://gerrit.wikimedia.org/r/530540 [07:23:22] (03PS6) 10simetrical: Integration tests for FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/531485 [07:23:24] (03PS5) 10simetrical: Convert FileBackendGroup to service [core] - 10https://gerrit.wikimedia.org/r/531486 [07:23:47] (03Abandoned) 10simetrical: Warn on circular service dependencies, don't throw [core] - 10https://gerrit.wikimedia.org/r/531729 (https://phabricator.wikimedia.org/T231014) (owner: 10simetrical) [07:24:56] (03CR) 10simetrical: LockManagerGroupFactory to replace singletons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530540 (owner: 10simetrical) [07:26:46] (03PS11) 10simetrical: LockManagerGroupFactory to replace singletons [core] - 10https://gerrit.wikimedia.org/r/530540 [07:57:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/532135 (owner: 10L10n-bot) [07:58:09] 10MediaWiki-extensions-General, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): Remove deprecated mediawiki.api.* dependencies from extensions - https://phabricator.wikimedia.org/T196802 (10Kghbln) @Krinkle Thanks for clarifying. We were working on [[ https://github.com/SemanticMediaWiki/Semant... [08:06:49] 10Wiki-Loves-Monuments-Database: Flake8 fails on labs-tools-heritage, complaining about NameError: name 'unicode' is not defined - https://phabricator.wikimedia.org/T231152 (10JeanFred) [08:07:05] 10Wiki-Loves-Monuments-Database: Flake8 fails on labs-tools-heritage, complaining about NameError: name 'unicode' is not defined - https://phabricator.wikimedia.org/T231152 (10JeanFred) p:05Triage→03High Prevents merges [08:07:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/532131 (owner: 10L10n-bot) [08:15:54] 10Map-of-monuments: Add more/all countries to the map of monuments - https://phabricator.wikimedia.org/T231153 (10JeanFred) [08:16:09] 10Map-of-monuments, 10Wiki-Loves-Monuments (2019): Add more/all countries to the map of monuments - https://phabricator.wikimedia.org/T231153 (10JeanFred) [08:18:32] 10Map-of-monuments, 10Wiki-Loves-Monuments (2019): Additional filtering for the map of monuments - https://phabricator.wikimedia.org/T231154 (10JeanFred) [08:27:21] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Flake8 fails on labs-tools-heritage, complaining about py3 stuff - https://phabricator.wikimedia.org/T231152 (10JeanFred) [08:35:02] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/532169 (owner: 10L10n-bot) [08:37:40] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/532219 (owner: 10L10n-bot) [08:41:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532139 (owner: 10L10n-bot) [08:42:23] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Flake8 fails on labs-tools-heritage, complaining about py3 stuff - https://phabricator.wikimedia.org/T231152 (10JeanFred) The unicode-string-litteral issue was the top of the iceberg: now that flake8 runs, it complains about a lot of violations: ` ./tests/te... [08:44:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/532165 (owner: 10L10n-bot) [08:48:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532148 (owner: 10L10n-bot) [08:50:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/532155 (owner: 10L10n-bot) [08:52:03] 10Map-of-monuments, 10Wiki-Loves-Monuments (2019): Add Upload button to monument pop-up in the map of monuments - https://phabricator.wikimedia.org/T231155 (10JeanFred) [08:53:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/532152 (owner: 10L10n-bot) [08:54:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/532160 (owner: 10L10n-bot) [09:02:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/532167 (owner: 10L10n-bot) [09:03:03] (03CR) 10simetrical: "Overall, looks like a great change! I looked over all the code and it seems reasonable to me. However, I see 0% test coverage for these cl" (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/520854 (owner: 10Aaron Schulz) [09:06:06] (03CR) 10simetrical: "\o/" [core] - 10https://gerrit.wikimedia.org/r/507856 (owner: 10simetrical) [09:09:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/532168 (owner: 10L10n-bot) [09:11:27] 10MediaWiki-Core-Testing, 10Lexicographical data, 10Wikidata, 10Release-Engineering-Team-TODO (201908), 10ci-test-error: WikibaseLexeme test broken by refactor of MediaWiki's Language class - https://phabricator.wikimedia.org/T231103 (10Simetrical) WikibaseLexeme tests were accessing a private property o... [09:13:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/532174 (owner: 10L10n-bot) [09:16:02] 10MediaWiki-Internationalization, 10Wikimania-Hackathon-2019, 10translatewiki.net, 10Google-Code-in-2019, and 2 others: Hunt and remove unused i18n messages in mediawiki core - https://phabricator.wikimedia.org/T224429 (10Simetrical) We definitely should have a test that checks for this. Any existing cases... [09:17:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532183 (owner: 10L10n-bot) [09:19:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/532179 (owner: 10L10n-bot) [09:20:10] (03PS5) 10simetrical: [DNM] FileJournal tests [core] - 10https://gerrit.wikimedia.org/r/531698 [09:20:50] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Suggestion: Global rename request queue - add home wiki column - https://phabricator.wikimedia.org/T231158 (10TheSandDoctor) [09:21:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/532189 (owner: 10L10n-bot) [09:23:41] 10MediaWiki-Internationalization, 10Wikimania-Hackathon-2019, 10translatewiki.net, 10Google-Code-in-2019, and 2 others: Hunt and remove unused i18n messages in mediawiki core - https://phabricator.wikimedia.org/T224429 (10Daimona) >>! In T224429#5436013, @Simetrical wrote: > We definitely should have a tes... [09:24:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/532185 (owner: 10L10n-bot) [09:27:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/532193 (owner: 10L10n-bot) [09:29:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/532192 (owner: 10L10n-bot) [09:30:30] (03CR) 10simetrical: Make DefaultPreferencesFactory depend on PermissionManager. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/531761 (https://phabricator.wikimedia.org/T220191) (owner: 10Ppchelko) [09:33:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/532204 (owner: 10L10n-bot) [10:28:12] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "syntax error (missing > ) fixed with https://translatewiki.net/w/i.php?title=MediaWiki:Apierror-gettingstarted-nosuggester/pt-br&diff=prev" [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/532169 (owner: 10L10n-bot) [10:28:46] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/532219 (owner: 10L10n-bot) [10:36:22] 10Wikimedia-Site-requests: Blocking any IP and new account users from creating new articles in Malay Wikipedia - https://phabricator.wikimedia.org/T231127 (10SNN95) >>! In T231127#5435328, @MarcoAurelio wrote: > Disabling non-autoconfirmed users from creating new articles has been controversial over the time. Se... [10:55:22] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Suggestion: Global rename request queue - add home wiki column - https://phabricator.wikimedia.org/T231158 (101997kB) Duplicate of T217099? [11:09:28] 10ISA: Contributions saved with Unicode image filename breaks stats downloads - https://phabricator.wikimedia.org/T228630 (10NavinoEvans) [11:13:54] (03PS1) 10Ankita Mandal: Improve the interface of Special:CargoQuery in the Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532230 [11:17:01] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Suggestion: Global rename request queue - add home wiki column - https://phabricator.wikimedia.org/T231158 (10MarcoAurelio) Yup, duplicate. Feel free to close this one as duplicate. [11:30:16] (03PS2) 10Ankita Mandal: Improve the interface of Special:CargoQuery page in the Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532230 [11:31:31] 10ISA: Language dropdown and scripts not updating after language change - https://phabricator.wikimedia.org/T230422 (10NavinoEvans) [11:41:44] (03PS1) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [11:41:46] (03PS1) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [11:58:26] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:02:47] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:06:06] 04(no projects): Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Simetrical) [12:06:25] 10MediaWiki-Core-Testing: Wrap file access so it can be mocked - https://phabricator.wikimedia.org/T231159 (10Simetrical) [12:09:56] (03PS2) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [12:19:53] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:20:49] 10MobileFrontend, 10CSS: CSS nomobile class conflict - https://phabricator.wikimedia.org/T231160 (10XanonymusX) [12:20:51] 10ISA: Only allow specific country selection on Wiki Loves campaigns - https://phabricator.wikimedia.org/T229827 (10NavinoEvans) [12:24:20] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:24:43] 10ISA: Only allow specific country selection on Wiki Loves campaigns - https://phabricator.wikimedia.org/T229827 (10NavinoEvans) [12:27:41] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:44:45] (03PS1) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [12:45:56] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [12:48:58] (03PS1) 10simetrical: Cache nonexistence of grammar transformations [core] - 10https://gerrit.wikimedia.org/r/532241 [12:51:34] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [12:55:37] 10MediaWiki-extensions-Linter: Add in/not in content namespace to Special:Linterrors - https://phabricator.wikimedia.org/T231161 (10Izno) [13:03:39] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [13:15:27] 10Commons-Datasets, 10Discovery, 10WMF-Legal: Provide Legal comment on [[c:Commons:Deletion requests/Data talk:Kuala Lumpur Districts.map]] concerning derivates from OSM acceptability in Data namespace - https://phabricator.wikimedia.org/T178210 (10Mrjohncummings) Non CC0 datasets are now possible to license... [13:23:41] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [13:25:09] (03CR) 10Foxtrott: [C: 03+1] "Looks good to me. :)" [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/530694 (owner: 10Nischayn22) [13:28:47] (03PS4) 10Idrisz19: Adapting the Dark theme for Timeless skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/528973 [13:35:24] 10Commons-Datasets, 10Discovery, 10WMF-Legal: Provide Legal comment on [[c:Commons:Deletion requests/Data talk:Kuala Lumpur Districts.map]] concerning derivates from OSM acceptability in Data namespace - https://phabricator.wikimedia.org/T178210 (10Doc_James) I think so... Plan to check it out in more detail... [13:40:49] 10MediaWiki-extensions-DocBookExport: DocBookExport: Breaks when page name contains a "/" (slash) - https://phabricator.wikimedia.org/T196774 (10Foxtrott) This is about **page** names that contain slashes, e.g. any sub-page. Something like https://www.mediawiki.org/wiki/Extension:Page_Forms/Linking_to_forms [13:42:10] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Suggestion: Global rename request queue - add home wiki column - https://phabricator.wikimedia.org/T231158 (10Urbanecm) [13:42:15] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Restore usage of 'local wiki' field - https://phabricator.wikimedia.org/T217099 (10Urbanecm) [13:42:20] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Suggestion: Global rename request queue - add home wiki column - https://phabricator.wikimedia.org/T231158 (10Urbanecm) Done [13:43:16] (03PS2) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [13:56:33] (03PS1) 10Paladox: Fix config name [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 [13:56:55] (03PS2) 10Paladox: Fix config name [extensions/DisqusTag] - 10https://gerrit.wikimedia.org/r/532242 [13:57:59] 10MediaWiki-Cache, 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team: Page view triggers ResourceLoaderWikiModule db queries for enabled gadgets (from OutputPage) - https://phabricator.wikimedia.org/T230260 (10Krinkle) @alex-mashin No, it's not a straight-forward bug fix. Would rather not risk the... [13:58:42] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [13:59:04] (03CR) 10Krinkle: New LanguageFallback service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [13:59:36] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [14:02:31] (03CR) 10Krinkle: [C: 03+2] Make NameTableStore use LoadBalancer::getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/527859 (owner: 10Aaron Schulz) [14:02:34] (03Restored) 10simetrical: Split Language static methods into LanguageFactory [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [14:03:12] (03CR) 10Krinkle: [C: 03+2] Migrate BagOStuff::incr() calls to incrWithInit() [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [14:06:35] (03CR) 10Krinkle: objectcache: SqlBagOStuff cleanups for sqlite and postgres (032 comments) [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [14:07:28] (03PS4) 10Krinkle: Make the JobRunner flushReplicaSnapshots() call cover the first job [core] - 10https://gerrit.wikimedia.org/r/527628 (owner: 10Aaron Schulz) [14:07:31] (03CR) 10Krinkle: [C: 03+2] Make the JobRunner flushReplicaSnapshots() call cover the first job [core] - 10https://gerrit.wikimedia.org/r/527628 (owner: 10Aaron Schulz) [14:08:15] (03CR) 10Krinkle: [C: 04-1] "LGTM, need merge conflict resolution." [core] - 10https://gerrit.wikimedia.org/r/528958 (owner: 10Aaron Schulz) [14:11:00] hi [14:11:16] (03CR) 10Krinkle: [C: 03+2] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:13:25] 10MediaWiki-Recent-changes, 10Growth-Team: Change comma and semicolon in 'Recent Changes' on Sindhi Wikipedia - https://phabricator.wikimedia.org/T231149 (10Aklapper) [14:15:49] (03CR) 10Krinkle: [C: 03+1] rdbms: refactor caching in LoadBalancer::getReadOnlyReason() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [14:15:58] (03PS6) 10Krinkle: rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [14:17:01] (03CR) 10Krinkle: [C: 03+1] "Not sure if everything still is meant to apply the same way after the rebase. Please double check :)" [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [14:17:35] 10MediaWiki-Recent-changes, 10Growth-Team: Change comma and semicolon in 'Recent Changes' on Sindhi Wikipedia - https://phabricator.wikimedia.org/T231149 (10Aklapper) 05Open→03Invalid Hi @mehtab.ahmed, thanks for reporting this. Please always include links: This makes it easier for someone else to reproduc... [14:18:28] (03CR) 10Krinkle: [C: 03+2] rdbms: add setTempTablesOnlyMode() to suppress CONN_TRX_AUTOCOMMIT during tests [core] - 10https://gerrit.wikimedia.org/r/530982 (https://phabricator.wikimedia.org/T202116) (owner: 10Aaron Schulz) [14:19:48] (03CR) 10simetrical: "So I'm working on reviving this patch, and I ran into a bit of a problem trying to untangle Language and LanguageConverter. Language needs" [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [14:22:05] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [14:23:02] (03CR) 10jenkins-bot: parsercache: use WRITE_ALLOW_SEGMENTS for cached ParserOutput values [core] - 10https://gerrit.wikimedia.org/r/517679 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [14:24:41] 10MediaWiki-User-preferences: Turn off by default "Warn me when I leave an edit page with unsaved changes" option - https://phabricator.wikimedia.org/T231126 (10Aklapper) >>! In T231126#5435891, @MaxBioHazard wrote: > Why is this annoying warning needed, if any browser, used in 2019, saves text fields content?... [14:27:27] (03CR) 10simetrical: "> Patch Set 19:" [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [14:27:50] 10MediaWiki-Cache, 10MediaWiki-Internationalization: failure of service creation for service 'ContentLanguage' not shown - https://phabricator.wikimedia.org/T231150 (10Aklapper) [14:33:49] (03CR) 10Krinkle: HashRing optimizations and PhpStorm warning work-arounds (033 comments) [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [14:35:51] 10Gerrit-Privilege-Requests, 10Research: Give WMF Research folks rights to merge code in the "mediawiki-services-recommendation-api" Gerrit repository - https://phabricator.wikimedia.org/T231163 (10Aklapper) [14:36:55] (03PS1) 10Ankita Mandal: Improve the interface of Special:CargoQuery in the Cargo extension.Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532243 [14:39:01] (03Merged) 10jenkins-bot: Make NameTableStore use LoadBalancer::getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/527859 (owner: 10Aaron Schulz) [14:39:05] (03CR) 10jerkins-bot: [V: 04-1] Migrate BagOStuff::incr() calls to incrWithInit() [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [14:40:18] (03CR) 10Krinkle: [C: 03+1] "This will need careful testing wrt to prod templates, infoboxes, nav things, hat note headers, and also MobileFrontend formatting stuff." [core] - 10https://gerrit.wikimedia.org/r/531456 (https://phabricator.wikimedia.org/T230808) (owner: 10Gilles) [14:41:49] (03CR) 10Krinkle: [C: 03+1] "The static var might be problematic as it assumes the first invocation of Parser will be for the article, which might not be the case, giv" [core] - 10https://gerrit.wikimedia.org/r/531456 (https://phabricator.wikimedia.org/T230808) (owner: 10Gilles) [14:42:36] (03CR) 10Krinkle: [C: 03+2] "Flaky failure:" [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [14:53:10] 10ISA: Only allow specific country selection on Wiki Loves campaigns - https://phabricator.wikimedia.org/T229827 (10NavinoEvans) @Anthere this feature is live now, but I've noticed that it prevents any contributions happening if someone selects "wiki loves campaign" with categories of the wrong format. The drop... [14:54:23] (03Merged) 10jenkins-bot: Make the JobRunner flushReplicaSnapshots() call cover the first job [core] - 10https://gerrit.wikimedia.org/r/527628 (owner: 10Aaron Schulz) [14:54:30] (03CR) 10jenkins-bot: Make NameTableStore use LoadBalancer::getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/527859 (owner: 10Aaron Schulz) [14:56:04] (03CR) 10jerkins-bot: [V: 04-1] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [15:01:27] (03PS2) 10Ankita Mandal: Improve the interface of Special:CargoQuery page in the Cargo extension.Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532243 [15:01:55] 10MediaWiki-Core-Testing: Flaky test failure from TitlePermissionTest::testUserBlock - https://phabricator.wikimedia.org/T231166 (10Krinkle) [15:02:09] 10MediaWiki-Core-Testing: Flaky test failure from TitlePermissionTest::testUserBlock - https://phabricator.wikimedia.org/T231166 (10Krinkle) Seems to have been introduced in 5ec53b028 / rSVN65609. [15:02:53] (03Merged) 10jenkins-bot: rdbms: add setTempTablesOnlyMode() to suppress CONN_TRX_AUTOCOMMIT during tests [core] - 10https://gerrit.wikimedia.org/r/530982 (https://phabricator.wikimedia.org/T202116) (owner: 10Aaron Schulz) [15:07:25] (03PS1) 10Krinkle: title: Fix flaky TitlePermissionTest::testUserBlock [core] - 10https://gerrit.wikimedia.org/r/532244 (https://phabricator.wikimedia.org/T231166) [15:07:28] (03CR) 10Krinkle: [C: 03+2] "Filed as T231166." [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [15:08:40] 10MediaWiki-Core-Testing, 10Performance-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Flaky test failure from TitlePermissionTest::testUserBlock - https://phabricator.wikimedia.org/T231166 (10Krinkle) p:05Triage→03Normal a:03Krinkle [15:11:54] (03Merged) 10jenkins-bot: Migrate BagOStuff::incr() calls to incrWithInit() [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [15:15:22] (03CR) 10jenkins-bot: Make the JobRunner flushReplicaSnapshots() call cover the first job [core] - 10https://gerrit.wikimedia.org/r/527628 (owner: 10Aaron Schulz) [15:21:05] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Flake8 fails on labs-tools-heritage, complaining about py3 stuff - https://phabricator.wikimedia.org/T231152 (10JeanFred) Ah, setting `basepython` is good enough as it seems :) [15:21:14] (03PS3) 10Ankita Mandal: Improve the interface of Special:CargoQuery page.Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532243 [15:21:54] 10ISA: Non latin script in Campaign title breaks it completely - https://phabricator.wikimedia.org/T231167 (10NavinoEvans) [15:22:05] 10ISA: Non latin script in Campaign title breaks it completely - https://phabricator.wikimedia.org/T231167 (10NavinoEvans) p:05Triage→03High [15:24:25] 10MediaWiki-Recent-changes, 10Growth-Team: Change comma and semicolon in 'Recent Changes' on Sindhi Wikipedia - https://phabricator.wikimedia.org/T231149 (10mehtab.ahmed) @Aklapper thank you so much for your guidance, issue is with my web browser (PHX Browser). I apologize for inconvenience caused and I will t... [15:29:55] (03CR) 10jenkins-bot: rdbms: add setTempTablesOnlyMode() to suppress CONN_TRX_AUTOCOMMIT during tests [core] - 10https://gerrit.wikimedia.org/r/530982 (https://phabricator.wikimedia.org/T202116) (owner: 10Aaron Schulz) [15:47:15] (03CR) 10jenkins-bot: Migrate BagOStuff::incr() calls to incrWithInit() [core] - 10https://gerrit.wikimedia.org/r/529441 (owner: 10Aaron Schulz) [15:55:23] 10MediaWiki-History-and-Diffs, 10MediaWiki-Recent-changes, 10MediaWiki-Special-pages, 10Growth-Team: Please display revision length in characters, not bytes, in history and Recent Changes - https://phabricator.wikimedia.org/T27198 (10matej_suchanek) [15:55:31] (03PS3) 10Ankita Mandal: Improve the interface of Special:CargoQuery page in the Cargo extension. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532230 [16:04:31] 10MediaWiki-Interface, 10Performance-Team, 10Readers-Web-Backlog (Tracking): Fit above-the-fold layout and first paragraph HTML in 14 KB - https://phabricator.wikimedia.org/T231168 (10Krinkle) ### How to measurSize of HTTP headers: * `curl -i https://en.wikipedia.org/wiki/Stockholm > http-head` * trim until... [16:09:18] (03PS1) 10Ankita Mandal: Improve the interface of Special:CargoQuery page.Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 [16:14:14] (03Abandoned) 10Ankita Mandal: Improve the interface of Special:CargoQuery page.Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532243 (owner: 10Ankita Mandal) [16:25:53] (03PS1) 10Krinkle: resourceloader: Compile documentElement.className server-side [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) [16:25:57] 10MediaWiki-Interface, 10Performance-Team, 10Readers-Web-Backlog (Tracking): Fit above-the-fold layout and first paragraph HTML in 14 KB - https://phabricator.wikimedia.org/T231168 (10Krinkle) p:05Triage→03Normal [16:26:51] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Patch-For-Review: Convert Translate to use extension registration - https://phabricator.wikimedia.org/T87985 (10Nikerabbit) There is noth... [16:27:03] (03CR) 10Krinkle: [C: 04-1] "Fails vendor-postgres-php72-docker:" [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [16:27:24] (03CR) 10Krinkle: [C: 03+2] objectcache: make MediumSpecificBagOStuff::mergeViaCas() handle negative TTLs [core] - 10https://gerrit.wikimedia.org/r/529440 (owner: 10Aaron Schulz) [16:29:51] (03CR) 10Krinkle: Cleanup setTriageStatus() and IDatabase::affectedRows() usage (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [16:30:34] (03PS1) 10Urbanecm: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 [16:32:17] (03PS1) 10D3r1ck01: parser: Strip off HTML comments from/beside image name [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) [16:32:45] (03CR) 10Krinkle: "fresnel: - 74 B (html)" [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) (owner: 10Krinkle) [16:36:08] (03CR) 10D3r1ck01: "I've tested this patch locally, and it works fine!" [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [16:37:16] (03CR) 10Krinkle: [C: 04-1] "The cost of additional features in the Parser is very high, and should be taken seriously. I think in this case, things are already workin" [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [16:37:32] 10Wikimedia-Site-requests: Update Wikimedia production config to use extension registration for Translate - https://phabricator.wikimedia.org/T228051 (10Nikerabbit) This is ready to be implemented now. [16:38:10] (03CR) 10Krinkle: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532248 (owner: 10Urbanecm) [16:38:27] (03CR) 10Rxy: [C: 03+1] Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 (owner: 10Urbanecm) [16:38:37] Krinkle: working on it [16:38:55] (03CR) 10Krinkle: "I can view https://en.wikipedia.beta.wmflabs.org/wiki/Main_Page and https://en.wikipedia.beta.wmflabs.org/w/index.php?title=Main_Page&acti" [core] - 10https://gerrit.wikimedia.org/r/532248 (owner: 10Urbanecm) [16:39:15] (03CR) 10Urbanecm: "> Patch Set 1:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532248 (owner: 10Urbanecm) [16:39:37] (03PS2) 10Urbanecm: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 (https://phabricator.wikimedia.org/T231162) [16:40:10] (03CR) 10Krinkle: [C: 03+2] "OK :)" [core] - 10https://gerrit.wikimedia.org/r/532248 (https://phabricator.wikimedia.org/T231162) (owner: 10Urbanecm) [16:40:45] 10MediaWiki-General, 10Core Platform Team, 10Performance-Team, 10Wikimedia-Rdbms, 10Patch-For-Review: Table 'enwiki.blobs' doesn't exist thrown on beta after 45831e6 - https://phabricator.wikimedia.org/T231162 (10Rxy) p:05Low→03Unbreak! a:05aaron→03None [16:41:10] 10MediaWiki-General, 10Core Platform Team, 10Performance-Team, 10Wikimedia-Rdbms, 10Patch-For-Review: Table 'enwiki.blobs' doesn't exist thrown on beta after 45831e6 - https://phabricator.wikimedia.org/T231162 (10Krinkle) Immediate issue is resolved in master and beta (prod was not yet affected). Assigni... [16:42:40] (03CR) 10D3r1ck01: "Okay, so should we close the phab ticket?" [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [16:47:33] (03CR) 10D3r1ck01: [C: 03+1] "lgtm! Leaving if @Lego has any concerns. Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532100 (https://phabricator.wikimedia.org/T231147) (owner: 10DannyS712) [16:49:38] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Compile documentElement.className server-side [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) (owner: 10Krinkle) [16:56:56] (03CR) 10Krinkle: [C: 04-1] "Yeah. For feature requests generally best to ask a maintainer if the feature is approved before implementing (e.g. Parsing team in this ca" [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [16:57:20] 10MediaWiki-Gallery, 10MediaWiki-Parser, 10Parsing-Team, 10Patch-For-Review: HTML comments inside galleries cause images not to be rendered - https://phabricator.wikimedia.org/T18057 (10Krinkle) [16:57:45] (03Merged) 10jenkins-bot: objectcache: make MediumSpecificBagOStuff::mergeViaCas() handle negative TTLs [core] - 10https://gerrit.wikimedia.org/r/529440 (owner: 10Aaron Schulz) [16:57:53] (03PS2) 10Krinkle: resourceloader: Compile documentElement.className server-side [core] - 10https://gerrit.wikimedia.org/r/532247 (https://phabricator.wikimedia.org/T231168) [16:58:33] (03PS2) 10Krinkle: Kill oracle and mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:00:34] (03PS3) 10Krinkle: Kill oracle and mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:01:42] (03PS4) 10Krinkle: Kill oracle and mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:02:08] (03PS5) 10Krinkle: Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:02:48] (03CR) 10Krinkle: [C: 03+1] "I restored two inline comments about DBO_SYSDBA/DBO_DDLMODE relating to Oracle which may be useful for whoever looks at it in the future. " [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:03:00] (03CR) 10Krinkle: [C: 03+2] Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:03:11] (03CR) 10Daimona Eaytoy: [C: 04-2] "This value is inserted in the globalblocks table, where gb_reason (i.e. the reason field) is still a TINYBLOB [1], thus only holding 255 c" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) (owner: 10DannyS712) [17:04:00] (03CR) 10Daimona Eaytoy: "> I restored two inline comments about DBO_SYSDBA/DBO_DDLMODE" [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:05:01] (03PS3) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) [17:05:38] (03CR) 10Krinkle: phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [17:05:55] (03PS2) 10Krinkle: resourceloader: Make ResourceLoaderSkinModuleTest a purer unit test [core] - 10https://gerrit.wikimedia.org/r/528807 [17:06:44] (03CR) 10D3r1ck01: "> For feature requests generally best to ask a maintainer if the feature is approved before implementing" [core] - 10https://gerrit.wikimedia.org/r/532249 (https://phabricator.wikimedia.org/T18057) (owner: 10D3r1ck01) [17:09:26] (03Merged) 10jenkins-bot: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 (https://phabricator.wikimedia.org/T231162) (owner: 10Urbanecm) [17:09:28] (03CR) 10jerkins-bot: [V: 04-1] Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:09:58] (03CR) 10jenkins-bot: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 (https://phabricator.wikimedia.org/T231162) (owner: 10Urbanecm) [17:10:00] (03CR) 10Krinkle: Move parser tests to /unit (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [17:10:02] (03CR) 10Krinkle: [C: 03+1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [17:10:12] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [17:10:26] (03PS4) 10Matěj Suchánek: Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) [17:11:19] (03PS11) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [17:11:34] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [17:11:39] (03CR) 10Daimona Eaytoy: Move parser tests to /unit (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [17:11:43] (03CR) 10jerkins-bot: [V: 04-1] Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 (owner: 10Daimona Eaytoy) [17:12:59] (03PS12) 10Daimona Eaytoy: Move parser tests to /unit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531452 [17:14:15] (03CR) 10jerkins-bot: [V: 04-1] Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:14:34] (03CR) 10Krinkle: Lazy load the module 'mediawiki.searchSuggest' (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [17:14:57] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [17:16:25] (03CR) 10jenkins-bot: objectcache: make MediumSpecificBagOStuff::mergeViaCas() handle negative TTLs [core] - 10https://gerrit.wikimedia.org/r/529440 (owner: 10Aaron Schulz) [17:17:23] (03CR) 10jerkins-bot: [V: 04-1] Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:20:18] (03CR) 10jerkins-bot: [V: 04-1] phpunit: Repair GLOBALS reset in MediaWikiUnitTestCase [core] - 10https://gerrit.wikimedia.org/r/528794 (https://phabricator.wikimedia.org/T230023) (owner: 10Krinkle) [17:21:53] (03PS6) 10Krinkle: Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:21:58] (03CR) 10Krinkle: Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:22:00] (03CR) 10Krinkle: [C: 03+2] Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:23:32] (03PS1) 10simetrical: Nuke MediaWikiIntegrationTestCase::resetNamespace [core] - 10https://gerrit.wikimedia.org/r/532254 [17:23:37] 10QRpedia-General, 10Wikimania-Hackathon-2019, 10Wikimedia Australia, 10Patch-For-Review: Page titles are being double-encoded - https://phabricator.wikimedia.org/T210050 (10Pigsonthewing) >>! In T210050#5430260, @Samwilson wrote: > I think progress here is waiting on feedback from WMUK. Who, at WMUK? [17:24:14] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [17:24:34] 10Wiki-Loves-Monuments-Database: Flake8 fails on labs-tools-heritage, complaining about py3 stuff - https://phabricator.wikimedia.org/T231152 (10JeanFred) 05Open→03Resolved [17:24:43] (03CR) 10Krinkle: [C: 03+2] Warn if a function has been given too many parameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [17:24:55] (03CR) 10Krinkle: [C: 04-1] "Merge conflict. LGTM otherwise." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [17:26:17] (03CR) 10Krinkle: Add a new class for the CachingParser's AST (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 (owner: 10Daimona Eaytoy) [17:27:16] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Make ResourceLoaderSkinModuleTest a purer unit test [core] - 10https://gerrit.wikimedia.org/r/528807 (owner: 10Krinkle) [17:27:43] (03PS5) 10Daimona Eaytoy: Warn if a function has been given too many parameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531438 (https://phabricator.wikimedia.org/T230803) [17:27:55] (03PS6) 10Daimona Eaytoy: Really throw for too many params [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531441 (https://phabricator.wikimedia.org/T230803) [17:28:23] (03CR) 10Daimona Eaytoy: Add a new class for the CachingParser's AST (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 (owner: 10Daimona Eaytoy) [17:28:32] (03PS6) 10Daimona Eaytoy: Add a new class for the CachingParser's AST [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 [17:29:19] (03PS7) 10Daimona Eaytoy: Add a new class for the CachingParser's AST [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 [17:30:35] (03CR) 10Krinkle: [C: 03+2] Add a new class for the CachingParser's AST [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 (owner: 10Daimona Eaytoy) [17:31:04] (03CR) 10jenkins-bot: Revert "rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX" [core] - 10https://gerrit.wikimedia.org/r/532248 (https://phabricator.wikimedia.org/T231162) (owner: 10Urbanecm) [17:32:15] (03CR) 10jerkins-bot: [V: 04-1] Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [17:36:29] (03CR) 10Jack Phoenix: [C: 03+2] "Let's just do this to unbreak the extension for more recent (1.32+) MWs..." [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/483925 (owner: 10Jack Phoenix) [17:36:36] (03PS5) 10Matěj Suchánek: Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) [17:37:46] (03CR) 10Jack Phoenix: "Noting this down so that I don't forget: I'm not sure if this code is in the right place. It seems to me that some of that & nonse" [extensions/ArticleMetaDescription] - 10https://gerrit.wikimedia.org/r/532128 (owner: 10Jack Phoenix) [17:46:07] (03CR) 10jerkins-bot: [V: 04-1] Nuke MediaWikiIntegrationTestCase::resetNamespace [core] - 10https://gerrit.wikimedia.org/r/532254 (owner: 10simetrical) [17:49:30] (03PS2) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [17:49:32] (03PS3) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [17:49:34] (03PS3) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [17:49:36] (03PS20) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [17:50:59] (03CR) 10Jack Phoenix: "Something that just occurred to me..." [extensions/Comments] - 10https://gerrit.wikimedia.org/r/529182 (https://phabricator.wikimedia.org/T148933) (owner: 10Jack Phoenix) [17:54:11] 10QRpedia-General, 10Wikimania-Hackathon-2019, 10Wikimedia Australia, 10Patch-For-Review: Page titles are being double-encoded - https://phabricator.wikimedia.org/T210050 (10MichaelMaggs) a:05ErrantX→03None Jkbr I believe. [17:54:16] (03Abandoned) 10simetrical: Nuke MediaWikiIntegrationTestCase::resetNamespace [core] - 10https://gerrit.wikimedia.org/r/532254 (owner: 10simetrical) [17:54:50] (03Merged) 10jenkins-bot: Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [17:55:01] (03PS3) 10simetrical: Integration tests for Language fallback methods [core] - 10https://gerrit.wikimedia.org/r/532231 [17:55:03] (03PS4) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [17:55:05] (03PS4) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [17:55:07] (03PS21) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [17:55:18] 10QRpedia-General, 10Wikimania-Hackathon-2019, 10Wikimedia Australia, 10Patch-For-Review: Page titles are being double-encoded - https://phabricator.wikimedia.org/T210050 (10MichaelMaggs) a:03Jkbr [17:56:56] (03PS1) 10Krinkle: language: Move ConverterRule to includes/ and add unit test [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) [17:58:21] (03CR) 10jerkins-bot: [V: 04-1] Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) (owner: 10Matěj Suchánek) [17:59:09] 10ISA: Improve help text on create page - https://phabricator.wikimedia.org/T231169 (10Seantime) [17:59:57] (03PS2) 10Ankita Mandal: Updated autocompletion options for order by. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 [18:00:29] (03Merged) 10jenkins-bot: Add a new class for the CachingParser's AST [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 (owner: 10Daimona Eaytoy) [18:00:31] (03Merged) 10jenkins-bot: Replace dieUsage() with dieWithError() in the API module + bump version number [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/483925 (owner: 10Jack Phoenix) [18:02:11] (03PS1) 10Krinkle: resourceloader: Add coverage for internal Context::getReqBase() [core] - 10https://gerrit.wikimedia.org/r/532260 [18:03:17] (03PS2) 10Krinkle: resourceloader: Add coverage for internal Context::getReqBase() [core] - 10https://gerrit.wikimedia.org/r/532260 [18:04:07] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:06:24] (03CR) 10Krinkle: LanguageFactory to replace Language::factory() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:08:19] (03CR) 10Krinkle: LanguageFactory to replace Language::factory() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:08:36] (03PS1) 10simetrical: Reset services in setContentLang() [core] - 10https://gerrit.wikimedia.org/r/532261 [18:09:28] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:10:02] (03Abandoned) 10Krinkle: ResourceLoader: Use PIFEs for functions that are called immediately [core] - 10https://gerrit.wikimedia.org/r/531538 (owner: 10Catrope) [18:10:03] (03PS5) 10simetrical: New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 [18:10:05] (03PS5) 10simetrical: Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 [18:10:07] (03PS22) 10simetrical: LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) [18:11:16] (03CR) 10Krinkle: [C: 03+1] Reset services in setContentLang() [core] - 10https://gerrit.wikimedia.org/r/532261 (owner: 10simetrical) [18:12:01] (03CR) 10Krinkle: [C: 03+1] Reset services in setContentLang() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/532261 (owner: 10simetrical) [18:12:28] (03PS6) 10Matěj Suchánek: Clean up LinkRenderer usage in IndexPager and extensions [core] - 10https://gerrit.wikimedia.org/r/521466 (https://phabricator.wikimedia.org/T149346) [18:12:30] (03CR) 10Krinkle: "coverage: +27.66 %" [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [18:12:32] (03CR) 10Isarra: [C: 03+1] "Does echo provide an interface to remove notifications after the fact on certain events (like comment deletion)?" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/529182 (https://phabricator.wikimedia.org/T148933) (owner: 10Jack Phoenix) [18:12:34] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [18:12:40] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [18:12:42] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [18:12:54] 10MediaWiki-Internationalization, 10Language-Team, 10Patch-For-Review: Clean up languages/ directory in MediaWiki core (June 2019) - https://phabricator.wikimedia.org/T225756 (10Krinkle) [18:14:21] (03CR) 10jenkins-bot: Add a new class for the CachingParser's AST [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/532063 (owner: 10Daimona Eaytoy) [18:15:07] (03CR) 10Jack Phoenix: [C: 03+2] Add a hook to determine whether the current action should be filtered [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526183 (https://phabricator.wikimedia.org/T229252) (owner: 10Daimona Eaytoy) [18:17:31] (03PS1) 10Krinkle: WebStart: Avoid DB or uselang for nonwrite-api-promise-error message [core] - 10https://gerrit.wikimedia.org/r/532263 (https://phabricator.wikimedia.org/T189966) [18:18:56] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:21:25] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:22:19] (03CR) 10jerkins-bot: [V: 04-1] language: Move ConverterRule to includes/ and add unit test [core] - 10https://gerrit.wikimedia.org/r/532258 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [18:22:31] (03CR) 10jenkins-bot: Remove more Oracle and Mssql leftovers [core] - 10https://gerrit.wikimedia.org/r/530355 (https://phabricator.wikimedia.org/T230418) (owner: 10Daimona Eaytoy) [18:26:34] (03PS1) 10Krinkle: Setup: Remove scopedProfileIn() calls [core] - 10https://gerrit.wikimedia.org/r/532264 (https://phabricator.wikimedia.org/T189966) [18:28:19] (03PS1) 10DannyS712: Switch global blocking table to use `blob` for for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [18:31:49] (03CR) 10jerkins-bot: [V: 04-1] Reset services in setContentLang() [core] - 10https://gerrit.wikimedia.org/r/532261 (owner: 10simetrical) [18:32:54] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [18:34:11] (03PS2) 10DannyS712: Switch global blocking tables to use `varbinary(767)` for for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [18:34:42] (03PS3) 10DannyS712: Increase global block reason maximum length to use `CommentStore::COMMENT_CHARACTER_LIMIT` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) [18:35:09] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [18:36:10] (03PS6) 10Don-vip: api: Update QueryFilearchive to provide limited information to everyone [core] - 10https://gerrit.wikimedia.org/r/530775 [18:36:36] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [18:38:13] (03PS7) 10Don-vip: api: Update QueryFilearchive to provide limited information to everyone [core] - 10https://gerrit.wikimedia.org/r/530775 [18:38:23] (03CR) 10Reedy: [C: 04-1] "Needs adding to onLoadExtensionSchemaUpdates" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [18:40:05] (03CR) 10Isarra: [C: 03+1] "If not, or it'd be too much of a mess, like... whatever? Maybe see what the other comments extension (enterprise) does, if that's at all s" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/529182 (https://phabricator.wikimedia.org/T148933) (owner: 10Jack Phoenix) [18:40:51] (03PS8) 10Don-vip: api: Update QueryFilearchive to provide information to everyone [core] - 10https://gerrit.wikimedia.org/r/530775 [18:41:07] (03CR) 10Reedy: [C: 04-1] "I'd also suggest splitting the change sql to separate files for each table... As in most cases, both tables probably won't exist in the sa" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [18:45:08] (03Merged) 10jenkins-bot: Add a hook to determine whether the current action should be filtered [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526183 (https://phabricator.wikimedia.org/T229252) (owner: 10Daimona Eaytoy) [18:46:09] (03CR) 10Tpt: [C: 03+2] Do not take empty string as Category title in Index: pages editing UI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/531551 (owner: 10Tpt) [18:47:01] (03CR) 10Reedy: [C: 04-1] "Also, alter localdb_patches/setup-global_block_whitelist.sql" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [18:49:47] (03CR) 10jerkins-bot: [V: 04-1] New LanguageFallback service [core] - 10https://gerrit.wikimedia.org/r/532232 (owner: 10simetrical) [18:50:20] (03CR) 10jerkins-bot: [V: 04-1] Inject grammar transform cache in Language [core] - 10https://gerrit.wikimedia.org/r/532240 (owner: 10simetrical) [18:50:50] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10Patch-For-Review: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) [18:52:45] (03CR) 10jenkins-bot: Add a hook to determine whether the current action should be filtered [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/526183 (https://phabricator.wikimedia.org/T229252) (owner: 10Daimona Eaytoy) [18:52:57] (03PS3) 10DannyS712: Switch global blocking tables to use `varbinary(767)` for for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [18:55:59] (03PS1) 10DannyS712: General cleanup of massmessage files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) [18:56:22] (03CR) 10Reedy: "Still needs onLoadExtensionSchemaUpdates" (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [18:57:40] (03Merged) 10jenkins-bot: Do not take empty string as Category title in Index: pages editing UI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/531551 (owner: 10Tpt) [18:59:08] (03PS1) 10MJL: extension.json: updated version numbers [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532267 [18:59:28] (03PS2) 10DannyS712: General cleanup of massmessage files [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) [18:59:50] (03PS6) 10Isarra: Add custom WikiLove heart icon [skins/Timeless] - 10https://gerrit.wikimedia.org/r/379967 (https://phabricator.wikimedia.org/T173219) (owner: 10Jack Phoenix) [18:59:52] (03CR) 10jerkins-bot: [V: 04-1] LanguageFactory to replace Language::factory() [core] - 10https://gerrit.wikimedia.org/r/450996 (https://phabricator.wikimedia.org/T201405) (owner: 10simetrical) [19:00:44] (03CR) 10jenkins-bot: Do not take empty string as Category title in Index: pages editing UI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/531551 (owner: 10Tpt) [19:01:03] (03CR) 10Isarra: Add custom WikiLove heart icon [skins/Timeless] - 10https://gerrit.wikimedia.org/r/379967 (https://phabricator.wikimedia.org/T173219) (owner: 10Jack Phoenix) [19:01:18] (03CR) 10Isarra: "Let's just go ahead and merge this..." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/379967 (https://phabricator.wikimedia.org/T173219) (owner: 10Jack Phoenix) [19:01:25] (03CR) 10Isarra: [C: 03+2] Add custom WikiLove heart icon [skins/Timeless] - 10https://gerrit.wikimedia.org/r/379967 (https://phabricator.wikimedia.org/T173219) (owner: 10Jack Phoenix) [19:02:04] (03CR) 10jerkins-bot: [V: 04-1] api: Update QueryFilearchive to provide information to everyone [core] - 10https://gerrit.wikimedia.org/r/530775 (owner: 10Don-vip) [19:03:49] (03CR) 10MJL: [C: 03+2] extension.json: updated version numbers [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532267 (owner: 10MJL) [19:04:01] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Let other extensions specify if the current action should be filtered or not - https://phabricator.wikimedia.org/T229252 (10DannyS712) [19:04:06] 10AbuseFilter, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27): Let other extensions specify if the current action should be filtered or not - https://phabricator.wikimedia.org/T229252 (10DannyS712) 05Open→03Resolved [19:05:38] (03CR) 10Isarra: "Should we just be using one config variable instead of two for each, and figure out what to do with it based on if it's an array or string" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/531994 (https://phabricator.wikimedia.org/T132004) (owner: 10Isarra) [19:05:55] (03Merged) 10jenkins-bot: Add custom WikiLove heart icon [skins/Timeless] - 10https://gerrit.wikimedia.org/r/379967 (https://phabricator.wikimedia.org/T173219) (owner: 10Jack Phoenix) [19:07:48] (03CR) 10MJL: [V: 03+2 C: 03+2] extension.json: updated version numbers [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532267 (owner: 10MJL) [19:07:57] (03CR) 10Reedy: [C: 04-1] Switch global blocking tables to use `varbinary(767)` for for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [19:12:29] (03PS9) 10Don-vip: api: Update QueryFilearchive to provide information to everyone [core] - 10https://gerrit.wikimedia.org/r/530775 [19:16:49] (03PS3) 10DannyS712: Cleanup readme and css, no change to code [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/532266 (https://phabricator.wikimedia.org/T231171) [19:22:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Privacy: Concept URI in sidebar uses HTTP instead of HTTPS - https://phabricator.wikimedia.org/T226453 (10Multichill) As pointed out, the concept URI is http, not https. See also https://www.w3.org/DesignIssues/Security-NotTheS.html . It's too widespre... [19:32:30] 10MediaWiki-General, 10Performance-Team, 10Core Platform Team Workboards (Clinic Duty Team), 10MW-1.34-notes (1.34.0-wmf.17; 2019-08-06), 10Patch-For-Review: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) Within the `SessionManager::... [19:33:41] 10MassMessage: MassMessage is able to make pages exceed the maximum page length - https://phabricator.wikimedia.org/T211331 (10DannyS712) Is this still an issue? https://en.wikipedia.org/wiki/Special:Log?type=massmessage&user=&page=&wpdate=&tagfilter=&subtype=failure shows multiple failures due to `contenttoobig... [19:35:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug, 10patch-welcome: Add monolingual language code "sa-Sidd" and "pi-Sidd" - https://phabricator.wikimedia.org/T230881 (10Mahir256) @StevenJ81 what are your thoughts on this request? [19:36:21] (03CR) 10Reedy: [C: 04-1] Increase global block reason maximum length to use `CommentStore::COMMENT_CHARACTER_LIMIT` (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) (owner: 10DannyS712) [19:39:19] 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review: Increase limit for edit summary in Flagged Revisions to COMMENT_CHARACTER_LIMIT - https://phabricator.wikimedia.org/T194588 (10Reedy) [19:39:44] (03CR) 10Pwirth: [C: 03+2] Init commit [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/531923 (owner: 10Pwirth) [19:39:58] (03CR) 10Pwirth: [C: 03+2] Init commit [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/531931 (owner: 10Pwirth) [19:42:13] 10GlobalBlocking: Extend gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Marostegui) Can you also paste the Gerrit link to the alter table? https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change I'm going to remove the #blocked-on-schema-change tag,... [19:45:52] (03CR) 10Fomafix: Lazy load the module 'mediawiki.searchSuggest' (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [19:46:01] (03PS9) 10Fomafix: Lazy load the module 'mediawiki.searchSuggest' [core] - 10https://gerrit.wikimedia.org/r/507067 [19:46:15] (03PS4) 10DannyS712: Switch global blocking tables to use `varbinary(767)` for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [19:47:28] 10GlobalBlocking: Extend gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10DannyS712) >>! In T231172#5436500, @Marostegui wrote: > Can you also paste the Gerrit link to the alter table? > https://wikitech.wikimedia.org/wiki/Schema_changes#Workflow_of_a_schema_change > > I'm g... [19:49:01] (03Merged) 10jenkins-bot: Init commit [extensions/BlueSpiceSocialBlog] - 10https://gerrit.wikimedia.org/r/531923 (owner: 10Pwirth) [19:49:03] (03Merged) 10jenkins-bot: Init commit [extensions/BlueSpiceSocialResolve] - 10https://gerrit.wikimedia.org/r/531931 (owner: 10Pwirth) [19:50:17] (03PS4) 10DannyS712: Increase global block reason maximum length to use `CommentStore::COMMENT_CHARACTER_LIMIT` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) [19:50:58] (03CR) 10Reedy: [C: 04-1] Switch global blocking tables to use `varbinary(767)` for reason (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [19:52:51] (03PS5) 10DannyS712: Switch global blocking tables to use `varbinary(767)` for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [19:52:57] (03CR) 10jerkins-bot: [V: 04-1] Increase global block reason maximum length to use `CommentStore::COMMENT_CHARACTER_LIMIT` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) (owner: 10DannyS712) [19:56:09] (03CR) 10Krinkle: [C: 03+1] "Code LGTM, but still want to do additional UX testing under slower connections to see how far it gets delayed. In particular, what I worry" [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [20:03:34] 10GlobalBlocking: Change varchar columns into varbinary - https://phabricator.wikimedia.org/T231174 (10Reedy) [20:03:45] 10GlobalBlocking, 10Schema-change: Change varchar columns into varbinary - https://phabricator.wikimedia.org/T231174 (10Reedy) [20:06:42] (03CR) 10Reedy: [C: 04-1] Switch global blocking tables to use `varbinary(767)` for reason (033 comments) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [20:07:34] 10GlobalBlocking, 10Schema-change: Change varchar columns into varbinary - https://phabricator.wikimedia.org/T231174 (10Reedy) [20:11:19] 10GlobalBlocking: Alter gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:14:39] 10GlobalBlocking: Alter gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:14:40] 10GlobalBlocking, 10Schema-change: Change varchar columns into varbinary - https://phabricator.wikimedia.org/T231174 (10Reedy) [20:15:58] (03PS6) 10DannyS712: Switch global blocking tables to use `varbinary(767)` for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) [20:17:44] (03PS1) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) [20:18:05] (03CR) 10Reedy: [C: 03+2] "LGTM now. Thanks!" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [20:19:12] 10GlobalBlocking: Alter gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:19:27] (03PS8) 10Jack Phoenix: Support actor and comment table schema migration [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/526506 (owner: 10Paladox) [20:20:01] (03PS2) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) [20:21:50] (03CR) 10jerkins-bot: [V: 04-1] Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:23:46] (03CR) 10Reedy: [C: 04-1] "File should have an sql suffix. Rebase ontop of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GlobalBlocking/+/532265/ which is " [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:23:55] (03Merged) 10jenkins-bot: Switch global blocking tables to use `varbinary(767)` for reason [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532265 (https://phabricator.wikimedia.org/T231170) (owner: 10DannyS712) [20:24:26] 10UniversalLanguageSelector, 10Language-Team (Language-2019-July-September): getFrequentLanguageList: expected behavior for 'redirected' languages - https://phabricator.wikimedia.org/T222790 (10Petar.petkovic) >>! In T222790#5368309, @Ladsgroup wrote: > I think given my patch, it's actually should be resolved... [20:24:59] (03PS3) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) [20:25:06] (03CR) 10jerkins-bot: [V: 04-1] Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:26:48] (03CR) 10DannyS712: "This change could not be rebased due to a conflict in merge - should I just abandon this and upload another patch separately?" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:27:20] (03CR) 10Reedy: "Or just rebase it locally. Whichever is easier" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:27:53] (03PS1) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532271 (https://phabricator.wikimedia.org/T231174) [20:28:04] (03Abandoned) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532270 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:29:27] (03PS2) 10DannyS712: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532271 (https://phabricator.wikimedia.org/T231174) [20:32:11] 10GlobalBlocking: Alter gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:33:05] 10GlobalBlocking: Alter gbw_reason/gb_reason on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:33:50] 10GlobalBlocking: Alter gbw_reason/gb_reason/gbw_by_text on WMF production - https://phabricator.wikimedia.org/T231172 (10DannyS712) [20:35:00] (03CR) 10DannyS712: "Recheck" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532099 (https://phabricator.wikimedia.org/T231146) (owner: 10DannyS712) [20:36:49] (03PS3) 10Ankita Mandal: Fixed order_by css styling of autocompletion list. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 [20:40:59] (03CR) 10Fomafix: "> In particular, what I worry about is the delay from using $() ..." [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [20:41:55] (03CR) 10Reedy: [C: 03+2] Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532271 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:46:18] (03Merged) 10jenkins-bot: Convert `gbw_by_text` column to `varbinary` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532271 (https://phabricator.wikimedia.org/T231174) (owner: 10DannyS712) [20:46:33] 10GlobalBlocking: Alter gbw_reason/gb_reason/gbw_by_text on WMF production - https://phabricator.wikimedia.org/T231172 (10Reedy) [20:46:37] 10Timeless: Optimise icons - https://phabricator.wikimedia.org/T161369 (10Isarra) 05Open→03Invalid Pretty sure we already did this, now if only I could find how so I can apply it to the new ones too... [20:47:33] (03PS1) 10DannyS712: Use `global_block_whitelist` instead of `global-block-whitelist` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 [20:49:11] (03PS2) 10DannyS712: Use `global_block_whitelist` instead of `global-block-whitelist` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 [20:49:30] 10CommRel-Specialists-Support (Jul-Sep-2019), 10Growth-Team (Current Sprint): Growth: training for how to help newcomers - https://phabricator.wikimedia.org/T224633 (10Urbanecm) >>! In T224633#5420070, @Trizek-WMF wrote: > Wikidata created a mentorship program: https://www.wikidata.org/wiki/Wikidata:Train_the_... [20:50:10] (03PS3) 10DannyS712: Use `global_block_whitelist` instead of `global-block-whitelist` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 [20:50:11] (03CR) 10Krinkle: [C: 03+1] "Also, one could use a delegate event listener on document. Matching the css selector might be tricky for that one. But, if we add 'mw-sear" [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [20:54:10] (03CR) 10Reedy: [C: 03+2] Use `global_block_whitelist` instead of `global-block-whitelist` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 (owner: 10DannyS712) [20:57:46] (03CR) 10DannyS712: "Recheck" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532246 (owner: 10Ankita Mandal) [21:00:08] (03CR) 10DannyS712: "Recheck" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/532230 (owner: 10Ankita Mandal) [21:04:18] (03CR) 10Reedy: [C: 03+2] "resubmit" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 (owner: 10DannyS712) [21:05:46] (03CR) 10DannyS712: "> resubmit" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 (owner: 10DannyS712) [21:06:52] (03CR) 10Reedy: [C: 03+2] "it's put it back in gate-and-submit, so I guess so ;)" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 (owner: 10DannyS712) [21:07:39] (03PS4) 10Isarra: Add icons to desktop cactions and overhaul icon alignment and usage throughout [skins/Timeless] - 10https://gerrit.wikimedia.org/r/531724 (https://phabricator.wikimedia.org/T197520) [21:08:57] (03Merged) 10jenkins-bot: Use `global_block_whitelist` instead of `global-block-whitelist` [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/532272 (owner: 10DannyS712) [21:11:11] 10Timeless: Junk optimise timeless - https://phabricator.wikimedia.org/T231177 (10Isarra) [21:11:31] (03PS1) 10Paladox: Fix extension.json [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532273 [21:11:49] (03PS2) 10Paladox: Fix extension.json [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532273 [21:13:31] 10GlobalBlocking: Alter gbw_reason/gb_reason/gbw_by_text on WMF production - https://phabricator.wikimedia.org/T231172 (10DannyS712) [21:13:59] (03CR) 10MJL: [V: 03+2 C: 03+2] Fix extension.json [extensions/SoftRedirector] - 10https://gerrit.wikimedia.org/r/532273 (owner: 10Paladox) [21:14:10] (03PS1) 10Paladox: Fix extension.json [extensions/SoftRedirector] (REL1_34) - 10https://gerrit.wikimedia.org/r/532274 [21:14:34] (03CR) 10Jack Phoenix: [C: 03+2] Add icons to desktop cactions and overhaul icon alignment and usage throughout [skins/Timeless] - 10https://gerrit.wikimedia.org/r/531724 (https://phabricator.wikimedia.org/T197520) (owner: 10Isarra) [21:19:07] (03Merged) 10jenkins-bot: Add icons to desktop cactions and overhaul icon alignment and usage throughout [skins/Timeless] - 10https://gerrit.wikimedia.org/r/531724 (https://phabricator.wikimedia.org/T197520) (owner: 10Isarra) [21:23:28] (03PS1) 10Aaron Schulz: [DNM] rdbms: make LoadBalancer::reallyOpenConnection() handle setting DBO_TRX [core] - 10https://gerrit.wikimedia.org/r/532275 [21:27:46] 10Timeless, 10Performance-Team (Radar): Junk optimise timeless - https://phabricator.wikimedia.org/T231177 (10Krinkle) [21:30:07] (03PS2) 10Aaron Schulz: rdbms: make IDatabase comments more up-to-date and stylistically consistent [core] - 10https://gerrit.wikimedia.org/r/528958 [21:31:32] (03PS7) 10Aaron Schulz: rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) [21:32:23] (03CR) 10Krinkle: [C: 03+2] rdbms: make IDatabase comments more up-to-date and stylistically consistent [core] - 10https://gerrit.wikimedia.org/r/528958 (owner: 10Aaron Schulz) [21:36:40] (03CR) 10Aaron Schulz: [C: 03+1] rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [21:37:49] 10MediaWiki-Core-Testing, 10Performance-Team, 10Wikimedia-Rdbms, 10MW-1.34-notes (1.34.0-wmf.20; 2019-08-27), 10User-Addshore: LoadBalancer opening extra connections in different connection categories doesn't work with PHPUnit & temporary tables - https://phabricator.wikimedia.org/T202116 (10aaron) 05Op... [21:38:34] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Wikimedia-production-error: Investigate magically missing array key in ResourceLoaderWikiModule - https://phabricator.wikimedia.org/T229433 (10Krinkle) [21:39:13] (03CR) 10Krinkle: [C: 03+2] rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [21:40:24] (03PS17) 10Krinkle: resourceloader: Reduce width of module hash from 7 chars to 5 [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) [21:41:19] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Reduce width of module hash from 7 chars to 5 [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) (owner: 10Krinkle) [21:41:21] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Reduce width of module hash from 7 chars to 5 [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) (owner: 10Krinkle) [21:41:34] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Reduce width of module hash from 7 chars to 5 [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) (owner: 10Krinkle) [21:42:07] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Reduce width of module hash from 7 chars to 5 [core] - 10https://gerrit.wikimedia.org/r/526182 (https://phabricator.wikimedia.org/T229245) (owner: 10Krinkle) [21:44:58] (03CR) 10Jack Phoenix: [C: 04-1] "Thanks for the patch! Unfortunately this isn't all that's needed, I believe, because the other two user_points_* tables (user_points_month" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/530770 (https://phabricator.wikimedia.org/T230672) (owner: 10Daimona Eaytoy) [21:45:06] (03CR) 10Aaron Schulz: "Does the Xhprof::enable call happen soon enough to cover Setup.php?" [core] - 10https://gerrit.wikimedia.org/r/532264 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [21:45:35] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Add coverage for internal Context::getReqBase() [core] - 10https://gerrit.wikimedia.org/r/532260 (owner: 10Krinkle) [21:49:52] (03PS1) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [21:51:10] (03CR) 10Aaron Schulz: Cleanup setTriageStatus() and IDatabase::affectedRows() usage (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [21:55:42] (03PS2) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [21:57:03] (03PS5) 10Aaron Schulz: objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 [21:57:34] (03CR) 10Aaron Schulz: objectcache: SqlBagOStuff cleanups for sqlite and postgres (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [21:58:53] (03CR) 10Krinkle: [C: 03+1] Cleanup setTriageStatus() and IDatabase::affectedRows() usage [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/526594 (https://phabricator.wikimedia.org/T229456) (owner: 10Aaron Schulz) [21:59:33] (03CR) 10Krinkle: [C: 03+1] objectcache: SqlBagOStuff cleanups for sqlite and postgres [core] - 10https://gerrit.wikimedia.org/r/530375 (owner: 10Aaron Schulz) [22:02:55] (03PS3) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [22:03:07] (03Merged) 10jenkins-bot: rdbms: make IDatabase comments more up-to-date and stylistically consistent [core] - 10https://gerrit.wikimedia.org/r/528958 (owner: 10Aaron Schulz) [22:03:28] (03PS4) 10DannyS712: Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) [22:03:43] (03PS1) 10Aaron Schulz: Avoid PHP warning due to bogus second tideways_xhprof_enable() argument [core] - 10https://gerrit.wikimedia.org/r/532279 [22:04:07] 10MediaWiki-Installer: Installer should check for old StartProfiler.php files - https://phabricator.wikimedia.org/T34760 (10Krinkle) Support for StartProfiler.php was removed in MW 1.32. Any old file on disk can no longer cause issues in the way described here. 10MediaWiki-Installer: Installer should check for old StartProfiler.php files - https://phabricator.wikimedia.org/T34760 (10Krinkle) 05Open→03Declined [22:07:11] (03CR) 10Krinkle: "For prod yes, we use PHP auto_prepend. See also T180183." [core] - 10https://gerrit.wikimedia.org/r/532264 (https://phabricator.wikimedia.org/T189966) (owner: 10Krinkle) [22:12:05] (03Merged) 10jenkins-bot: rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [22:12:42] (03CR) 10Huji: [C: 03+1] "Obviously, do not merge until WMF catches up. But otherwise it looks good to me." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/531441 (https://phabricator.wikimedia.org/T230803) (owner: 10Daimona Eaytoy) [22:13:08] (03CR) 10jerkins-bot: [V: 04-1] Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) (owner: 10DannyS712) [22:15:06] (03Merged) 10jenkins-bot: resourceloader: Add coverage for internal Context::getReqBase() [core] - 10https://gerrit.wikimedia.org/r/532260 (owner: 10Krinkle) [22:15:59] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: OAuth throws "duplicate key" at some occasions - https://phabricator.wikimedia.org/T231122 (10Tgr) p:05Triage→03Low This would presumably happen due to replication lag (maybe when you double-submit, although in theory OAuth has a nonce to prevent... [22:19:25] (03CR) 10jenkins-bot: rdbms: make IDatabase comments more up-to-date and stylistically consistent [core] - 10https://gerrit.wikimedia.org/r/528958 (owner: 10Aaron Schulz) [22:19:27] (03CR) 10jerkins-bot: [V: 04-1] Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) (owner: 10DannyS712) [22:22:21] (03CR) 10Aaron Schulz: HashRing optimizations and PhpStorm warning work-arounds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [22:23:26] (03PS1) 10Krinkle: Setup: Move wgRCLinkDays logic from Setup to ChangesListSpecialPage [core] - 10https://gerrit.wikimedia.org/r/532281 (https://phabricator.wikimedia.org/T189966) [22:25:35] (03CR) 10Krinkle: HashRing optimizations and PhpStorm warning work-arounds (031 comment) [core] - 10https://gerrit.wikimedia.org/r/530707 (owner: 10Aaron Schulz) [22:38:32] (03CR) 10jenkins-bot: rdbms: refactor caching in LoadBalancer::getReadOnlyReason() [core] - 10https://gerrit.wikimedia.org/r/523660 (https://phabricator.wikimedia.org/T227838) (owner: 10Aaron Schulz) [22:52:59] (03CR) 10jenkins-bot: resourceloader: Add coverage for internal Context::getReqBase() [core] - 10https://gerrit.wikimedia.org/r/532260 (owner: 10Krinkle) [22:53:16] (03PS10) 10Reedy: updater: Simplify SQL by removing duplicated SQL [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/471031 (owner: 10Paladox) [22:55:31] (03CR) 10jerkins-bot: [V: 04-1] Make wgDisableAnonTalk disable anon links in automatic edit summaries [core] - 10https://gerrit.wikimedia.org/r/532278 (https://phabricator.wikimedia.org/T31539) (owner: 10DannyS712) [22:55:56] (03PS6) 10Reedy: Update path to GlobalBlocking sql file [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/471499 (owner: 10Paladox) [23:12:38] (03CR) 10Reedy: [C: 03+2] updater: Simplify SQL by removing duplicated SQL [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/471031 (owner: 10Paladox) [23:17:05] (03Merged) 10jenkins-bot: updater: Simplify SQL by removing duplicated SQL [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/471031 (owner: 10Paladox) [23:18:16] (03CR) 10Reedy: [C: 03+2] Update path to GlobalBlocking sql file [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/471499 (owner: 10Paladox) [23:22:55] (03Merged) 10jenkins-bot: Update path to GlobalBlocking sql file [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/471499 (owner: 10Paladox) [23:28:55] 10Timeless: performance optimize timeless - https://phabricator.wikimedia.org/T219541 (10Isarra) [23:28:57] 10Timeless, 10Performance-Team (Radar): Junk optimise timeless - https://phabricator.wikimedia.org/T231177 (10Isarra) [23:46:45] 10Wikimedia-Site-requests: Search engine indexing on the Icelandic Wikipedia - https://phabricator.wikimedia.org/T231179 (10Thjarkur)