[00:00:05] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/521760 (owner: 10Jforrester) [00:00:46] (03PS1) 10Jack Phoenix: Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 [00:02:36] (03CR) 10jerkins-bot: [V: 04-1] Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 (owner: 10Jack Phoenix) [00:12:29] (03PS1) 10Jdlrobson: WIP: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [00:15:23] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/521768 (owner: 10Jforrester) [00:16:33] 10GrowthExperiments, 10Growth-Team (Current Sprint): Homepage Mentorship - issues with parsing mentor added descriptions - https://phabricator.wikimedia.org/T227535 (10Catrope) It turns out that if you have a mentor with an empty description like on the first line (here, `[[User:ET125]]|`), then that mentor's... [00:16:36] (03CR) 10Jdlrobson: [C: 04-1] "Strangely babel is now generating eslint5 unfriendly JS because of the package.json in mobile.startup. Will investigate tomorrow." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521303 (owner: 10Jdlrobson) [00:19:19] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ZeroPortal] - 10https://gerrit.wikimedia.org/r/521767 (owner: 10Jforrester) [00:19:31] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/521768 (owner: 10Jforrester) [00:20:50] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Installer aborts on outdated sqlite module though "--dbtype mysql" was passed - https://phabricator.wikimedia.org/T46511 (10RazeSoldier) I checked the Status returned by SqliteInstaller::checkPrerequisites() in inc... [00:23:46] (03CR) 10jerkins-bot: [V: 04-1] WIP: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [00:28:01] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/521749 (owner: 10Jforrester) [00:28:03] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/521765 (owner: 10Jforrester) [00:29:17] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/521762 (owner: 10Jforrester) [00:31:48] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/521734 (owner: 10Jforrester) [00:33:42] 10MediaWiki-extensions-WikibaseRepository, 10CirrusSearch, 10Discovery-Search, 10Reading-Infrastructure-Team-Backlog, and 2 others: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch - https://phabricator.wikimedia.org/T224125 (10Smalyshev) @zeljkofilipin Do we h... [00:41:14] 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Instrument revised *link* edit workflows - https://phabricator.wikimedia.org/T221249 (10JTannerWMF) [00:41:41] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Score] - 10https://gerrit.wikimedia.org/r/521717 (owner: 10Jforrester) [00:41:59] 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10VisualEditor (Current work): Instrument revised *citation* edit workflows - https://phabricator.wikimedia.org/T221305 (10JTannerWMF) [00:42:58] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/521723 (owner: 10Jforrester) [00:43:02] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/521748 (owner: 10Jforrester) [00:43:04] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/521746 (owner: 10Jforrester) [00:43:08] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UploadsLink] - 10https://gerrit.wikimedia.org/r/521745 (owner: 10Jforrester) [00:43:49] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Vector] - 10https://gerrit.wikimedia.org/r/521785 (owner: 10Jforrester) [00:43:54] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/521731 (owner: 10Jforrester) [00:44:04] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/521716 (owner: 10Jforrester) [00:44:18] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/521698 (owner: 10Jforrester) [00:44:20] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/521704 (owner: 10Jforrester) [00:44:24] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/521706 (owner: 10Jforrester) [00:44:47] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/521696 (owner: 10Jforrester) [00:44:51] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/521736 (owner: 10Jforrester) [00:44:56] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/521694 (owner: 10Jforrester) [00:44:58] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Petition] - 10https://gerrit.wikimedia.org/r/521702 (owner: 10Jforrester) [00:45:00] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/521697 (owner: 10Jforrester) [00:45:02] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/RSS] - 10https://gerrit.wikimedia.org/r/521711 (owner: 10Jforrester) [00:45:04] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/521714 (owner: 10Jforrester) [00:45:06] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/521700 (owner: 10Jforrester) [00:45:18] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/521683 (owner: 10Jforrester) [00:45:20] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/521687 (owner: 10Jforrester) [00:45:42] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/521657 (owner: 10Jforrester) [00:45:47] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/521658 (owner: 10Jforrester) [00:45:49] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/521675 (owner: 10Jforrester) [00:45:51] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/521674 (owner: 10Jforrester) [00:46:06] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/521721 (owner: 10Jforrester) [00:46:08] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/521693 (owner: 10Jforrester) [00:46:10] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/521659 (owner: 10Jforrester) [00:46:12] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SearchExtraNS] - 10https://gerrit.wikimedia.org/r/521719 (owner: 10Jforrester) [00:46:14] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/521722 (owner: 10Jforrester) [00:46:18] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/521668 (owner: 10Jforrester) [00:46:20] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/521651 (owner: 10Jforrester) [00:46:32] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/521685 (owner: 10Jforrester) [00:46:39] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/521652 (owner: 10Jforrester) [00:46:40] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/521634 (owner: 10Jforrester) [00:46:42] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/521650 (owner: 10Jforrester) [00:46:45] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/521653 (owner: 10Jforrester) [00:47:11] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/521649 (owner: 10Jforrester) [00:47:13] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/521645 (owner: 10Jforrester) [00:47:21] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/521636 (owner: 10Jforrester) [00:47:27] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/521670 (owner: 10Jforrester) [00:47:38] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/521624 (owner: 10Jforrester) [00:47:40] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/521616 (owner: 10Jforrester) [00:47:42] (03CR) 10Krinkle: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/521648 (owner: 10Jforrester) [00:49:11] (03CR) 10DannyS712: [C: 03+1] "Looks good to me" [core] - 10https://gerrit.wikimedia.org/r/521549 (owner: 10Tchanders) [00:50:52] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/521707 (owner: 10Jforrester) [00:52:34] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/521647 (owner: 10Jforrester) [00:52:38] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TrustedXFF] - 10https://gerrit.wikimedia.org/r/521741 (owner: 10Jforrester) [00:52:40] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/521737 (owner: 10Jforrester) [00:52:42] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/521728 (owner: 10Jforrester) [00:52:44] (03Merged) 10jenkins-bot: Remove old entry points [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/521229 (https://phabricator.wikimedia.org/T202320) (owner: 10Reedy) [01:00:38] (03CR) 10Krinkle: [C: 03+1] "Improvement as the old urls were broken, but should probably ref 6.x instead of 8.x. I also wonder if this test might be more suitable to " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/512671 (owner: 10Tchanders) [01:02:48] (03CR) 10Krinkle: resourceloader: Omit parameter 'lang' from image URLs when not vary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519384 (owner: 10Fomafix) [01:03:21] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/521736 (owner: 10Jforrester) [01:06:03] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/521746 (owner: 10Jforrester) [01:08:08] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Vector] - 10https://gerrit.wikimedia.org/r/521785 (owner: 10Jforrester) [01:08:10] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/521731 (owner: 10Jforrester) [01:08:12] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/521716 (owner: 10Jforrester) [01:08:15] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/521698 (owner: 10Jforrester) [01:08:17] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/521704 (owner: 10Jforrester) [01:08:21] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/521706 (owner: 10Jforrester) [01:08:25] (03CR) 10jenkins-bot: Remove old entry points [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/521229 (https://phabricator.wikimedia.org/T202320) (owner: 10Reedy) [01:08:27] (03CR) 10Krinkle: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [01:09:07] (03CR) 10Krinkle: [C: 04-1] "LGTM, needs a merge conflict resolution though." [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [01:09:20] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/521696 (owner: 10Jforrester) [01:09:23] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/521694 (owner: 10Jforrester) [01:09:24] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Petition] - 10https://gerrit.wikimedia.org/r/521702 (owner: 10Jforrester) [01:09:26] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/521697 (owner: 10Jforrester) [01:09:29] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/RSS] - 10https://gerrit.wikimedia.org/r/521711 (owner: 10Jforrester) [01:09:31] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/521714 (owner: 10Jforrester) [01:09:54] (03CR) 10Krinkle: [C: 03+2] Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) (owner: 10DannyS712) [01:10:59] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/521647 (owner: 10Jforrester) [01:16:49] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/521700 (owner: 10Jforrester) [01:16:55] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/521683 (owner: 10Jforrester) [01:16:57] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/521687 (owner: 10Jforrester) [01:23:00] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/521657 (owner: 10Jforrester) [01:23:19] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/521658 (owner: 10Jforrester) [01:23:21] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/521675 (owner: 10Jforrester) [01:23:23] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/521674 (owner: 10Jforrester) [01:23:25] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/521721 (owner: 10Jforrester) [01:23:27] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/521693 (owner: 10Jforrester) [01:26:49] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/521659 (owner: 10Jforrester) [01:26:51] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SearchExtraNS] - 10https://gerrit.wikimedia.org/r/521719 (owner: 10Jforrester) [01:26:53] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/521722 (owner: 10Jforrester) [01:26:57] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/521668 (owner: 10Jforrester) [01:29:37] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/521651 (owner: 10Jforrester) [01:33:28] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/NewUserMessage] - 10https://gerrit.wikimedia.org/r/521685 (owner: 10Jforrester) [01:33:30] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/521652 (owner: 10Jforrester) [01:33:34] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/521683 (owner: 10Jforrester) [01:33:38] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/521698 (owner: 10Jforrester) [01:33:52] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/521634 (owner: 10Jforrester) [01:33:55] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/521650 (owner: 10Jforrester) [01:33:56] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/521653 (owner: 10Jforrester) [01:33:58] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/521649 (owner: 10Jforrester) [01:35:11] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Modern] - 10https://gerrit.wikimedia.org/r/521782 (owner: 10Jforrester) [01:35:24] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/521733 (owner: 10Jforrester) [01:35:40] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/521732 (owner: 10Jforrester) [01:35:48] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/521731 (owner: 10Jforrester) [01:35:50] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/521730 (owner: 10Jforrester) [01:35:58] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/521727 (owner: 10Jforrester) [01:36:47] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/521645 (owner: 10Jforrester) [01:36:49] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/521636 (owner: 10Jforrester) [01:36:53] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/521670 (owner: 10Jforrester) [01:36:55] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/521624 (owner: 10Jforrester) [01:38:38] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/521616 (owner: 10Jforrester) [01:38:40] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/521648 (owner: 10Jforrester) [01:39:53] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/521696 (owner: 10Jforrester) [01:40:43] (03Merged) 10jenkins-bot: Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) (owner: 10DannyS712) [01:40:45] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Modern] - 10https://gerrit.wikimedia.org/r/521782 (owner: 10Jforrester) [01:40:47] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/521733 (owner: 10Jforrester) [01:41:20] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/521732 (owner: 10Jforrester) [01:41:22] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/521730 (owner: 10Jforrester) [01:41:24] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SubpageSortkey] - 10https://gerrit.wikimedia.org/r/521727 (owner: 10Jforrester) [01:42:06] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/521706 (owner: 10Jforrester) [01:42:56] 10MediaWiki-Cache: MessageCache does not work due to empty hash - https://phabricator.wikimedia.org/T215726 (10alex-mashin) p:05Triage→03High [01:44:21] (03CR) 10jenkins-bot: Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) (owner: 10DannyS712) [01:45:50] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/521694 (owner: 10Jforrester) [01:48:49] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/521726 (owner: 10Jforrester) [01:48:57] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Poem] - 10https://gerrit.wikimedia.org/r/521703 (owner: 10Jforrester) [01:49:04] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/521713 (owner: 10Jforrester) [01:49:20] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/521724 (owner: 10Jforrester) [01:49:35] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/521705 (owner: 10Jforrester) [01:49:41] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/521677 (owner: 10Jforrester) [01:49:47] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Listings] - 10https://gerrit.wikimedia.org/r/521673 (owner: 10Jforrester) [01:49:49] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/521657 (owner: 10Jforrester) [01:50:02] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/521671 (owner: 10Jforrester) [01:50:15] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Josa] - 10https://gerrit.wikimedia.org/r/521665 (owner: 10Jforrester) [01:50:48] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Insider] - 10https://gerrit.wikimedia.org/r/521660 (owner: 10Jforrester) [01:51:01] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/521646 (owner: 10Jforrester) [01:51:07] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/521637 (owner: 10Jforrester) [01:51:44] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/521627 (owner: 10Jforrester) [01:51:51] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/521609 (owner: 10Jforrester) [01:51:56] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/521623 (owner: 10Jforrester) [01:52:03] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/521622 (owner: 10Jforrester) [01:52:10] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/521610 (owner: 10Jforrester) [01:52:16] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/521626 (owner: 10Jforrester) [01:52:22] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/521621 (owner: 10Jforrester) [01:52:37] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521613 (owner: 10Jforrester) [01:52:48] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/521618 (owner: 10Jforrester) [01:52:53] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/521617 (owner: 10Jforrester) [01:53:14] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/521599 (owner: 10Jforrester) [01:53:22] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/521600 (owner: 10Jforrester) [01:53:27] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/521598 (owner: 10Jforrester) [01:53:33] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/521597 (owner: 10Jforrester) [01:53:40] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/521594 (owner: 10Jforrester) [01:53:45] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/521593 (owner: 10Jforrester) [01:53:51] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/521590 (owner: 10Jforrester) [01:54:23] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/521726 (owner: 10Jforrester) [01:56:17] 10MediaWiki-extensions-ContactPage, 10Stewards-and-global-tools, 10Security: Should https://meta.wikimedia.org/wiki/Special:Contact/Stewards require a login - https://phabricator.wikimedia.org/T224059 (10revi) I can see a spike (for last few days to weeks) with someone pretending to be WMF department, employ... [01:57:32] 10MediaWiki-Interwiki, 10MediaWiki-Special-pages, 10MediaWiki-extensions-Interwiki: Edit interface of Special:Interwiki is missing - https://phabricator.wikimedia.org/T198431 (10DannyS712) If this is on a wikimedia foundation wiki, it may be because the interwiki map is controlled globally from meta [02:02:27] (03CR) 10Jforrester: [C: 03+2] "..." [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/521707 (owner: 10Jforrester) [02:03:27] 10MediaWiki-API, 10Documentation, 10Goal: Improve and update: https://www.mediawiki.org/wiki/API:Data_formats - https://phabricator.wikimedia.org/T204888 (10srishakatux) 05Open→03Resolved @jeropbrenda Nice work! Thanks :) [02:03:29] 10MediaWiki-API, 10Documentation, 10Goal: Review and improve top viewed overview pages of the Action API - https://phabricator.wikimedia.org/T203858 (10srishakatux) [02:03:50] (03CR) 10Jforrester: [C: 03+2] Fix typo in table documentation [core] - 10https://gerrit.wikimedia.org/r/521549 (owner: 10Tchanders) [02:03:52] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Poem] - 10https://gerrit.wikimedia.org/r/521703 (owner: 10Jforrester) [02:03:54] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/521713 (owner: 10Jforrester) [02:03:56] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/521724 (owner: 10Jforrester) [02:04:01] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/521705 (owner: 10Jforrester) [02:04:04] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/521677 (owner: 10Jforrester) [02:04:06] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Listings] - 10https://gerrit.wikimedia.org/r/521673 (owner: 10Jforrester) [02:04:08] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/521671 (owner: 10Jforrester) [02:04:12] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Josa] - 10https://gerrit.wikimedia.org/r/521665 (owner: 10Jforrester) [02:04:16] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Insider] - 10https://gerrit.wikimedia.org/r/521660 (owner: 10Jforrester) [02:04:20] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/521646 (owner: 10Jforrester) [02:04:22] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FeaturedFeeds] - 10https://gerrit.wikimedia.org/r/521637 (owner: 10Jforrester) [02:08:52] (03PS2) 10MaxSem: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/521781 (owner: 10Jforrester) [02:11:05] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/521627 (owner: 10Jforrester) [02:11:08] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/521609 (owner: 10Jforrester) [02:16:21] (03PS2) 10MaxSem: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [02:16:33] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/521623 (owner: 10Jforrester) [02:16:58] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Dashiki] - 10https://gerrit.wikimedia.org/r/521622 (owner: 10Jforrester) [02:17:00] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/521610 (owner: 10Jforrester) [02:17:02] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/521626 (owner: 10Jforrester) [02:17:04] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/521621 (owner: 10Jforrester) [02:17:08] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521613 (owner: 10Jforrester) [02:17:12] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/521618 (owner: 10Jforrester) [02:17:14] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CongressLookup] - 10https://gerrit.wikimedia.org/r/521617 (owner: 10Jforrester) [02:17:27] (03CR) 10MaxSem: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/521609 (owner: 10Jforrester) [02:20:01] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/521599 (owner: 10Jforrester) [02:20:03] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/521600 (owner: 10Jforrester) [02:21:04] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/521598 (owner: 10Jforrester) [02:21:06] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/521597 (owner: 10Jforrester) [02:21:08] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/521594 (owner: 10Jforrester) [02:21:11] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/521593 (owner: 10Jforrester) [02:21:13] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/521590 (owner: 10Jforrester) [02:23:07] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/521651 (owner: 10Jforrester) [02:23:55] (03CR) 10Jforrester: [C: 03+1] "One way to fix it. ;-)" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [02:24:46] (03CR) 10Jforrester: [C: 03+1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/521781 (owner: 10Jforrester) [02:25:01] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/521675 (owner: 10Jforrester) [02:26:11] (03CR) 10Legoktm: "Why can't we archive this again?" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [02:31:05] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/521650 (owner: 10Jforrester) [02:32:46] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/521634 (owner: 10Jforrester) [02:34:42] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/521636 (owner: 10Jforrester) [02:36:24] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/521645 (owner: 10Jforrester) [02:38:03] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/521733 (owner: 10Jforrester) [02:38:58] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/521707 (owner: 10Jforrester) [02:39:03] (03Merged) 10jenkins-bot: Fix typo in table documentation [core] - 10https://gerrit.wikimedia.org/r/521549 (owner: 10Tchanders) [02:39:06] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/521609 (owner: 10Jforrester) [02:39:47] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/521616 (owner: 10Jforrester) [02:41:43] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/521705 (owner: 10Jforrester) [02:45:21] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/521671 (owner: 10Jforrester) [02:48:25] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/521677 (owner: 10Jforrester) [02:50:14] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/521610 (owner: 10Jforrester) [02:53:33] (03CR) 10jenkins-bot: Fix typo in table documentation [core] - 10https://gerrit.wikimedia.org/r/521549 (owner: 10Tchanders) [02:55:59] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521613 (owner: 10Jforrester) [02:57:50] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/521598 (owner: 10Jforrester) [03:01:37] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/521594 (owner: 10Jforrester) [03:03:18] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/521597 (owner: 10Jforrester) [03:12:13] (03PS1) 10Aaron Schulz: Make MapCacheLRU::get() accept a default value and improve $maxAge default [core] - 10https://gerrit.wikimedia.org/r/521805 [03:13:40] (03CR) 10Tim Starling: "> Patch Set 11:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [03:28:51] 10Product-Analytics, 10VisualEditor (Current work): Context items: enhanced instrumentation post-deployment data checks - https://phabricator.wikimedia.org/T221254 (10ppelberg) [03:32:39] (03CR) 10Jforrester: [C: 03+1] "> Patch Set 2:" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [03:34:04] (03CR) 10Jforrester: "check perf" [core] - 10https://gerrit.wikimedia.org/r/519384 (owner: 10Fomafix) [03:34:40] legoktm: Isn't everything wonderful? ;-( [03:50:45] 10Gerrit-Privilege-Requests, 10TechCom: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10tstarling) I endorse this request. [03:50:58] 10Gerrit-Privilege-Requests, 10TechCom, 10Utilities-grabbers: +2 for Ciencia Al Poder in mediawiki/tools/grabbers - https://phabricator.wikimedia.org/T218362 (10tstarling) I endorse this request. [03:51:08] (03CR) 10Dmaza: [C: 03+2] Pass in ServiceOptions to BlockManager [core] - 10https://gerrit.wikimedia.org/r/519255 (owner: 10Tchanders) [03:57:03] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Technical-Debt: Identify prevalent component antipatterns in MobileFrontend - https://phabricator.wikimedia.org/T225453 (10santhosh) Thanks for writing this down. I agree with all of th... [04:01:27] 10Multi-Content-Revisions, 10TechCom, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Tracking), 10Technical-Debt (RW-Tech-Debt): [EPIC] Core should provide inline diffs as well as side by side (Move InlineDifferenceEngine into core / remo... - https://phabricator.wikimedia.org/T117279 [04:15:51] 10VisualEditor (Current work): Conduct Edit Cards v2 on-wiki test - https://phabricator.wikimedia.org/T227616 (10ppelberg) **Update | 9 July** - Draft of test is written. See: [Edit Cards v2 on-wiki test](https://docs.google.com/document/d/1zq8v1sPt9l0yqVNWfnyAw3JQPl2dyIJHulftigFn1yI/edit#) **Next steps** - [ ]... [04:25:43] (03CR) 10Fomafix: mediawiki.util: Simplify test-only setOptions methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521361 (owner: 10Krinkle) [04:58:01] (03CR) 10Fomafix: resourceloader: Omit parameter 'lang' from image URLs when not vary (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519384 (owner: 10Fomafix) [04:58:13] (03PS7) 10Fomafix: resourceloader: Omit parameter 'lang' from image URLs when not vary [core] - 10https://gerrit.wikimedia.org/r/519384 [05:04:02] 10MediaWiki-General-or-Unknown, 10TechCom: Register namespaces in the database - https://phabricator.wikimedia.org/T226667 (10tstarling) Previous tasks related to this subject: * {T9803} ** A patch submitted in 2006 which moved namespace names to the database. It was never merged. ** The related project page,... [05:08:11] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Content copied from Content Translation into Visual Editor exposes internal attributes - https://phabricator.wikimedia.org/T220495 (10santhosh) a:03Esanders [05:30:24] (03PS1) 10Aaron Schulz: objectcache: move version numbers to the main wrapper in WANObjectCache [core] - 10https://gerrit.wikimedia.org/r/521811 [05:38:04] (03PS2) 10MaxSem: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [05:39:28] (03CR) 10Robert Vogel: [C: 03+2] Message keys for new page header. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521231 (owner: 10Dvogel hallowelt) [05:39:33] (03CR) 10MaxSem: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [05:41:56] (03PS5) 10Aaron Schulz: Switch various LoadBalancer::getConnection() callers to getConnectionRef() [core] - 10https://gerrit.wikimedia.org/r/519705 [05:42:42] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [05:43:45] (03Merged) 10jenkins-bot: Message keys for new page header. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521231 (owner: 10Dvogel hallowelt) [05:47:11] (03CR) 10Aaron Schulz: rdbms: cleanup DatabaseSqlite::lock() error handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521002 (owner: 10Aaron Schulz) [05:55:32] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10Aseques) This are the settings I have currently for the LDAP backend configuration ` wfLoadExtension( 'PluggableAuth' ); wfLoadExtensi... [05:57:39] (03PS5) 10Aaron Schulz: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) [06:01:41] (03CR) 10Aaron Schulz: "It looks like there is a CaptchaSessionStore class already. Not sure how well it works." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/521019 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [06:03:06] (03PS5) 10Aaron Schulz: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 [06:05:14] (03PS6) 10Aaron Schulz: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 [06:05:45] (03PS2) 10Aaron Schulz: objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) [06:06:20] (03PS5) 10Aaron Schulz: resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) [06:07:15] (03PS7) 10Aaron Schulz: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods [core] - 10https://gerrit.wikimedia.org/r/519946 [06:07:27] (03CR) 10jerkins-bot: [V: 04-1] objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:08:24] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:09:51] (03CR) 10jerkins-bot: [V: 04-1] objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:10:19] (03CR) 10jerkins-bot: [V: 04-1] objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:10:44] (03CR) 10jerkins-bot: [V: 04-1] objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:11:33] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:11:46] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:12:24] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [06:15:59] (03PS1) 10Pwirth: Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/521815 [06:18:38] (03CR) 10Robert Vogel: [C: 03+2] Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/521815 (owner: 10Pwirth) [06:18:51] (03PS1) 10Robert Vogel: Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521816 [06:18:55] (03CR) 10Robert Vogel: [C: 03+2] Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521816 (owner: 10Robert Vogel) [06:22:38] (03Merged) 10jenkins-bot: Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/521815 (owner: 10Pwirth) [06:22:55] (03Merged) 10jenkins-bot: Remove direct access to the result property in the ResultWraper. [extensions/BlueSpicePageTemplates] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521816 (owner: 10Robert Vogel) [06:27:35] (03CR) 10Tim Starling: [C: 03+2] maintenance: Script to rename titles for Unicode uppercasing changes [core] - 10https://gerrit.wikimedia.org/r/507596 (https://phabricator.wikimedia.org/T219279) (owner: 10Anomie) [06:32:14] 04(no projects): Digital award for closing reception contest - https://phabricator.wikimedia.org/T227634 (10Alicia_Fagerving_WMSE) [06:32:24] 10WMSE-Wikimania-2019: Digital award for closing reception contest - https://phabricator.wikimedia.org/T227634 (10Alicia_Fagerving_WMSE) [06:33:27] (03PS8) 10Aaron Schulz: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods [core] - 10https://gerrit.wikimedia.org/r/519946 [06:33:51] 10MediaWiki-extensions-CentralAuth, 10Operations, 10TimedMediaHandler, 10Traffic, and 3 others: Consistent HTTP 503 Error on some urls for some logged-in users (CentralAuth Set-Cookie storm) - https://phabricator.wikimedia.org/T226840 (10TheDJ) Maybe an update to the class documentation to make it easier t... [06:40:52] (03PS1) 10ItSpiderman: Add extension config [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) [06:42:22] (03Merged) 10jenkins-bot: maintenance: Script to rename titles for Unicode uppercasing changes [core] - 10https://gerrit.wikimedia.org/r/507596 (https://phabricator.wikimedia.org/T219279) (owner: 10Anomie) [06:43:22] 10MediaWiki-extensions-WebDAV, 10Patch-For-Review: ConfigRegistry missing in extension.json - https://phabricator.wikimedia.org/T227580 (10ItSpiderman) @Sebastian.Schmid91: Thank you for opening this ticket. The issue is resolved in the patch above [06:44:23] (03CR) 10Robert Vogel: [C: 03+2] Add extension config [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) (owner: 10ItSpiderman) [06:47:58] (03CR) 10jerkins-bot: [V: 04-1] Add extension config [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) (owner: 10ItSpiderman) [06:53:14] (03PS2) 10Pwirth: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521399 [06:54:37] (03PS1) 10Aaron Schulz: rdbms: make IDatabase::isReadOnly() return true for replica DBs managed by LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/521821 [06:54:39] (03PS1) 10Aaron Schulz: objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 [06:55:09] (03PS1) 10Robert Vogel: Message keys for new page header. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521823 [06:55:12] (03CR) 10Robert Vogel: [C: 03+2] Message keys for new page header. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521823 (owner: 10Robert Vogel) [06:57:00] (03CR) 10jenkins-bot: maintenance: Script to rename titles for Unicode uppercasing changes [core] - 10https://gerrit.wikimedia.org/r/507596 (https://phabricator.wikimedia.org/T219279) (owner: 10Anomie) [06:57:32] (03CR) 10Physikerwelt: "Is this the reason why ci failed:" [extensions/Math] - 10https://gerrit.wikimedia.org/r/521678 (owner: 10Jforrester) [06:58:56] (03Merged) 10jenkins-bot: Message keys for new page header. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521823 (owner: 10Robert Vogel) [07:02:14] 10Phabricator, 10Operations, 10Release-Engineering-Team-TODO, 10serviceops, and 2 others: Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10MoritzMuehlenhoff) >>! In T190568#5319370, @Dzahn wrote: > Next we need to make a decision whether we keep phab1003 as the p... [07:02:42] 10WMSE-Wikimania-2019: Digital award for closing reception contest - https://phabricator.wikimedia.org/T227634 (10Alicia_Fagerving_WMSE) [[ https://wikimania.wikimedia.org/wiki/User:Alicia_Fagerving_(WMSE)/Sandbox | Sandboxing ]] [07:06:01] (03PS5) 10Pwirth: Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:07:31] (03CR) 10jerkins-bot: [V: 04-1] Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:09:22] 10MediaWiki-General-or-Unknown, 10Core Platform Team (MCR), 10Core Platform Team Workboards (Team 3), 10MW-1.32-release, and 4 others: Failed to access name from slot_roles using id = 1 - https://phabricator.wikimedia.org/T224949 (10Absorbcium) >>! In T224949#5317435, @daniel wrote: > Caching should not be... [07:09:27] (03PS6) 10Pwirth: Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:11:03] (03CR) 10jerkins-bot: [V: 04-1] Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:11:05] (03CR) 10Pwirth: [C: 04-1] Real fullscreen mode (031 comment) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:12:59] (03PS7) 10Pwirth: Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:15:47] (03PS8) 10Pwirth: Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:15:54] (03CR) 10Pwirth: [C: 03+2] Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:16:01] (03PS1) 10Pwirth: Real fullscreen mode [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521827 [07:16:06] (03CR) 10Pwirth: [C: 03+2] Real fullscreen mode [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521827 (owner: 10Pwirth) [07:19:48] (03Merged) 10jenkins-bot: Real fullscreen mode [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/519618 (owner: 10DmitriyShevliakov) [07:19:50] (03Merged) 10jenkins-bot: Real fullscreen mode [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521827 (owner: 10Pwirth) [07:20:00] (03PS2) 10Dvogel hallowelt: [WIP] Mobile menu: add close button [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521251 [07:20:29] 10wikimediafoundation.org: wikimediafoundation.org: ltr/rtl not properly handled in yellow box - https://phabricator.wikimedia.org/T227636 (10Volans) [07:22:03] (03PS3) 10Dvogel hallowelt: [WIP] Mobile menu: add close button [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521251 [07:25:26] (03PS2) 10ItSpiderman: Add extension config + remove global consts [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) [07:29:06] (03PS4) 10Aaron Schulz: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 [07:29:15] 10MediaWiki-extensions-Translate: MLEB instance requires createaccount rights for all users for TwnMainPage extension - https://phabricator.wikimedia.org/T227637 (10abi_) [07:29:31] 10MediaWiki-extensions-Translate: MLEB instance requires createaccount rights for all users for TwnMainPage extension - https://phabricator.wikimedia.org/T227637 (10abi_) [07:29:33] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-abi_: Account name is not free to use again after account request is rejected - https://phabricator.wikimedia.org/T225999 (10abi_) [07:29:38] (03CR) 10Robert Vogel: [C: 03+2] Add extension config + remove global consts [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) (owner: 10ItSpiderman) [07:29:56] 10MediaWiki-extensions-Translate: MLEB instance requires createaccount rights for all users for TwnMainPage extension - https://phabricator.wikimedia.org/T227637 (10abi_) [07:29:58] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-abi_: Account name is not free to use again after account request is rejected - https://phabricator.wikimedia.org/T225999 (10abi_) [07:30:00] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September): Setup the MLEB instance as a test instance for the Translate extension - https://phabricator.wikimedia.org/T224652 (10abi_) [07:30:24] 10MediaWiki-extensions-Translate: MLEB instance requires createaccount rights for all users for TwnMainPage extension - https://phabricator.wikimedia.org/T227637 (10abi_) p:05Triage→03Low [07:31:50] 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2: Apply the right target when creating a missing link - https://phabricator.wikimedia.org/T197787 (10Pginer-WMF) [07:32:53] (03Merged) 10jenkins-bot: Add extension config + remove global consts [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/521818 (https://phabricator.wikimedia.org/T227580) (owner: 10ItSpiderman) [07:37:59] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-July-September): Setup the MLEB instance as a test instance for the Translate extension - https://phabricator.wikimedia.org/T224652 (10abi_) I spent some time fixing the related issue but was not very satisfied with the solution I came up with. I... [07:43:57] (03CR) 10Daimona Eaytoy: "I'm unsure about this one, I'd just say suppress it." [extensions/Math] - 10https://gerrit.wikimedia.org/r/521678 (owner: 10Jforrester) [07:44:28] (03CR) 10Daimona Eaytoy: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [07:46:06] (03CR) 10Daimona Eaytoy: "Apparently, we have to install php-ast in the non-voting jobs, too." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [07:47:17] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [07:47:41] 10GrowthExperiments, 10GrowthExperiments- MentorshipModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Homepage Mentorship: allow mentors to configure their presentation - https://phabricator.wikimedia.org/T220145 (10Cntlsn) Thanks @Dyolf77_WMF and @revi for your input on... [07:49:07] (03CR) 10Daimona Eaytoy: [C: 03+1] "Hah, I like this!" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [07:53:19] (03CR) 10Daimona Eaytoy: [C: 03+1] "Confirming that this was a genuine issue." [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/521781 (owner: 10Jforrester) [07:56:45] (03CR) 10Daimona Eaytoy: "Oh lord, I refuse to check whether this is a false positive with all of that nesting. That's confusing for humans, and it could be for too" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/521784 (owner: 10Jforrester) [08:01:44] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-July-September): Fully remove $wgTranslateCC - https://phabricator.wikimedia.org/T214356 (10abi_) a:03abi_ [08:02:35] (03CR) 10Physikerwelt: "I think it would be better to properly escape the message that is printed to the SVG. I have to figure out how that works. Tips are most w" [extensions/Math] - 10https://gerrit.wikimedia.org/r/521678 (owner: 10Jforrester) [08:03:11] 10ContentTranslation, 10Design-Research, 10Language-Team (Language-2019-July-September): CX2: User research study for Content Translation version 2 - https://phabricator.wikimedia.org/T207831 (10Pginer-WMF) [08:04:16] (03CR) 10Daimona Eaytoy: "I'm uncertain about this one" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [08:04:24] 10ContentTranslation, 10Design-Research, 10Language-Team (Language-2019-July-September): CX2: User research study for Content Translation version 2 - https://phabricator.wikimedia.org/T207831 (10Pginer-WMF) [08:04:47] 10ContentTranslation, 10Design-Research, 10Language-Team (Language-2019-July-September): CX2: User research study for Content Translation version 2 - https://phabricator.wikimedia.org/T207831 (10Pginer-WMF) 05Open→03Resolved The results report is available at https://commons.wikimedia.org/wiki/File:2019.... [08:07:28] (03CR) 10Daimona Eaytoy: "These seemed false positives at my first look, see T227171#5306248. Not sure, though." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/521628 (owner: 10Jforrester) [08:12:24] (03CR) 10Daimona Eaytoy: "It could be a false positive, but I'm unsure. Either way, it's for a maint script, and I guess their input should be considered trusted." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/521695 (owner: 10Jforrester) [08:12:54] 10WMSE-FindingGLAMs-2018 (Campaign): Monumental development check-in - https://phabricator.wikimedia.org/T227641 (10Alicia_Fagerving_WMSE) [08:12:59] (03CR) 10Daimona Eaytoy: "See comment at T227171#5306248, needs further investigation" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521641 (owner: 10Jforrester) [08:13:41] (03PS7) 10Robert Vogel: Make RunJobsTriggerHanlder intervals configurable [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/475059 [08:15:58] (03CR) 10Daimona Eaytoy: "Sounds like a false positive. This method is similar to core's makeExternalLink, which has a special handling inside the plugin." [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/521631 (owner: 10Jforrester) [08:18:30] (03CR) 10Daimona Eaytoy: "Uncertain." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/521771 (owner: 10Jforrester) [08:21:45] (03CR) 10Daimona Eaytoy: "I'd have to understand what array element is bringing taint in, first. As for the second issue, I don't get it." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [08:24:00] (03CR) 10Daimona Eaytoy: "Dunno if this is genuine, but I think it *could* help to avoid reusing the name $html in fixMap." [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [08:26:31] (03CR) 10Daimona Eaytoy: "This is probably a false positive due to the method taking a parameter to decide whether to escape stuff. It's similar to core's makeExter" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521605 (owner: 10Jforrester) [08:31:48] (03CR) 10Daimona Eaytoy: "False positive, suppress, see T227171#5306248." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/521725 (owner: 10Jforrester) [08:34:53] (03PS8) 10Robert Vogel: Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/475059 [08:37:50] 10Wikimania-Hackathon-2019: Wikidata infoboxes workshop @ Wikimania hackathon 2019 - https://phabricator.wikimedia.org/T227559 (10Lea_Lacroix_WMDE) @RexxS Thanks! Feel free to update the description to reflect the prerequisites you expect from participants. @Mike_Peel I'm fine merging this proposal with another... [08:40:54] (03CR) 10Daimona Eaytoy: "Likely a false positive" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/521718 (owner: 10Jforrester) [08:42:17] 10GrowthExperiments, 10GrowthExperiments- MentorshipModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Homepage Mentorship: allow mentors to configure their presentation - https://phabricator.wikimedia.org/T220145 (10Tgr) It's used [[https://codesearch.wmflabs.org/search/?... [08:43:48] (03CR) 10TheDJ: "The second is likely just due to the variable name being same as the param name ?" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [08:44:26] (03CR) 10Daimona Eaytoy: "This is because there's an escaped attribute. However, I'm unsure whether that can be considered DoubleEscaped. Or maybe Xml::input needs " [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/521709 (owner: 10Jforrester) [08:44:51] 10WMNO-General, 10WMNO-Sami: Merch for IYIL 2019: before July 2 - https://phabricator.wikimedia.org/T222599 (10jhsoby-WMNO) 05Open→03Resolved [08:44:58] (03CR) 10Daimona Eaytoy: "> The second is likely just due to the variable name being same as" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [08:45:25] (03CR) 10Daimona Eaytoy: [C: 04-1] "Duplicate of Ia2fa424bf9e8a76ed9cef4b48c84dacacb1d3d0f" [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/521710 (owner: 10Jforrester) [08:45:41] (03CR) 10Daimona Eaytoy: "recheck" [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [08:46:27] (03CR) 10Daimona Eaytoy: "I'd try to rename the variable, instead of reusing the parameter name." [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/521692 (owner: 10Jforrester) [08:48:10] (03CR) 10Daimona Eaytoy: "Unrelated to taint-check, this is some phan issue likely caused by a doc change somewhere outside of this extension." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [08:48:31] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [08:49:19] (03CR) 10Daimona Eaytoy: "It seems the same false positive as reported in T227171#5306248 for AbuseFilter and SpamBlacklist, just suppress." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/521661 (owner: 10Jforrester) [08:49:53] (03CR) 10Daimona Eaytoy: "Seems the same as ORES, unrelated to taint-check. This requires a doc change, either here or in a separate patch." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [08:53:16] (03CR) 10Daimona Eaytoy: "One of the two variables inside default is considered tainted, but I can't tell anything more." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/521688 (owner: 10Jforrester) [08:54:24] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10WorkType-NewFunctionality: ContentTranslation should auto-adapt templates that don't have parameters and have a directly corresponding template in the target language - https://phabricator.wikimedia.org/T104005 (10Pginer-WMF) [08:55:34] (03CR) 10Daimona Eaytoy: "taint-check is correct, the arguments to both setSubmitText and setWrapperLegend should not be escaped, and use text() instead." [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/521676 (owner: 10Jforrester) [08:56:20] (03CR) 10Daimona Eaytoy: "Yet another unrelated phan issue, needs a doc change here or in a separate patch" [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [08:56:55] 10MediaWiki-extensions-Translate, 10Technical-Debt: Remove hooks TranslateGetAPIMessageGroupsParameterList and TranslateGetAPIMessageGroupsPropertyDescs - https://phabricator.wikimedia.org/T227644 (10Nikerabbit) [08:58:00] (03CR) 10Daimona Eaytoy: "The first one I don't know, second one seems a false positive" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/521654 (owner: 10Jforrester) [08:59:11] (03CR) 10Daimona Eaytoy: "Seems a false positive" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/521644 (owner: 10Jforrester) [09:02:30] (03CR) 10Daimona Eaytoy: "All genuine, see T227171#5306248" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [09:03:28] (03CR) 10Daimona Eaytoy: "Try renaming the variables to avoid reusing the parameter name." [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/521625 (owner: 10Jforrester) [09:04:39] (03CR) 10Daimona Eaytoy: "Seems a false positive, maybe avoiding name reuse could help." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/521606 (owner: 10Jforrester) [09:05:55] (03CR) 10Daimona Eaytoy: "All false positives, T227171#5306248" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/521589 (owner: 10Jforrester) [09:15:53] (03PS16) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [09:16:12] (03CR) 10Daimona Eaytoy: "recheck" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 (owner: 10Daimona Eaytoy) [09:17:23] (03CR) 10jerkins-bot: [V: 04-1] Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 (owner: 10Daimona Eaytoy) [09:18:08] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "Overriding jenkins because the issues are fixed in the next patch, restoring CR by Brian that got lost between the rebases." [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 (owner: 10Daimona Eaytoy) [09:18:43] (03CR) 10Daimona Eaytoy: [C: 03+2] "Re-applying Brian's CR+2" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 (owner: 10Daimona Eaytoy) [09:18:44] (03PS15) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [09:19:43] (03CR) 10jerkins-bot: [V: 04-1] Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 (owner: 10Daimona Eaytoy) [09:19:53] (03CR) 10Daimona Eaytoy: [C: 03+2] "recheck" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 (owner: 10Daimona Eaytoy) [09:25:11] (03CR) 10Daniel Kinzler: "> Patch Set 11:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [09:29:22] (03PS16) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [09:29:44] (03CR) 10jerkins-bot: [V: 04-1] Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 (owner: 10Daimona Eaytoy) [09:29:55] (03CR) 10Daimona Eaytoy: "recheck" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 (owner: 10Daimona Eaytoy) [09:31:13] (03CR) 10Daimona Eaytoy: [C: 03+2] "Restoring after whitespace fix" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 (owner: 10Daimona Eaytoy) [09:32:16] (03Merged) 10jenkins-bot: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 (owner: 10Daimona Eaytoy) [09:32:31] 10WikibaseMediaInfo, 10Discovery-Search (Current work), 10Patch-For-Review: Index captions as description fields not label - https://phabricator.wikimedia.org/T226722 (10Cparle) Erm ... this is getting a bit philosophical, but I don't really see that labels and descriptions have much semantic meaning associa... [09:36:02] (03PS1) 10Daimona Eaytoy: Fix a crash with the literal 'class' [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/521838 [09:37:17] 10Library-Card-Platform: Escape special characters in CentralAuth URL - https://phabricator.wikimedia.org/T227646 (10Samwalton9) [09:38:14] 10phan-taint-check-plugin: Release taint-check 2.0.2 and 2.1.0 - https://phabricator.wikimedia.org/T227406 (10Daimona) [09:38:51] 10phan-taint-check-plugin: Release taint-check 2.0.2 and 2.1.0 - https://phabricator.wikimedia.org/T227406 (10Daimona) I've added https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/SecurityCheckPlugin/+/521838/, and it's the only patch which needs CR before the 2.0.2 release. [09:38:58] 10Library-Card-Platform: Escape special characters in CentralAuth and GUC URLs - https://phabricator.wikimedia.org/T227646 (10Samwalton9) [09:39:17] 10Library-Card-Platform, 10good first bug: Escape special characters in CentralAuth and GUC URLs - https://phabricator.wikimedia.org/T227646 (10Samwalton9) p:05Triage→03Low [09:40:00] (03PS10) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [09:40:02] (03PS11) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [09:40:15] (03CR) 10jerkins-bot: [V: 04-1] Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 (owner: 10Daimona Eaytoy) [09:40:32] (03CR) 10jerkins-bot: [V: 04-1] Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [09:42:07] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) Reported again today by User:Zapte. It's not obvious to me where the decoding issue is. [09:42:19] (03PS14) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [09:42:21] (03PS9) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [09:43:01] (03CR) 10jerkins-bot: [V: 04-1] Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 (owner: 10Daimona Eaytoy) [09:43:09] (03CR) 10jerkins-bot: [V: 04-1] Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 (owner: 10Daimona Eaytoy) [09:43:37] 10MediaWiki-extensions-StopForumSpam, 10Technical-Debt: Remove StopForumSpam/updateBlacklist.php in favour of maintenance/updateBlacklist.php - https://phabricator.wikimedia.org/T202320 (10MarcoAurelio) 05Open→03Resolved a:03Reedy Closing as they've been removed on `master`. If a port to any REL is neede... [09:45:58] (03PS1) 10Dvogel hallowelt: Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521841 [09:46:24] (03PS9) 10Robert Vogel: Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/475059 [09:46:50] (03CR) 10Daniel Kinzler: [C: 03+2] REST: add write access checks to BasicAccess [core] - 10https://gerrit.wikimedia.org/r/521408 (owner: 10Tim Starling) [09:47:05] 10MediaWiki-Installer, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Workboards (Done with CPT), 10User-Nikerabbit: Allow extensions to define additional command line parameters to "update.php" - https://phabricator.wikimedia.org/T213893 (10TheDJ) I no... [09:47:12] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) I thought I'd managed to reproduce this by attempting to apply to multiple partners at https://wikipedialibrary.wmflabs.org/applications/request/, with one of them as Érudit. That sa... [09:47:28] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) [09:47:34] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) p:05Triage→03High [09:48:15] (03CR) 10MarcoAurelio: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [09:48:27] (03CR) 10MarcoAurelio: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [09:49:07] (03CR) 10MarcoAurelio: "Are the non-voting jobs a blocker to this? Shall we attempt to fix those issues first?" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [09:49:10] (03PS7) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [09:49:36] (03CR) 10MarcoAurelio: "> Patch Set 2: Code-Review+2" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [09:49:55] (03CR) 10jerkins-bot: [V: 04-1] Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 (owner: 10Daimona Eaytoy) [09:50:18] 10MediaWiki-Comment-backend, 10MediaWiki-Installer: MediaWiki updater error: revision_comment_temp - https://phabricator.wikimedia.org/T227489 (10Reedy) >Maybe it's time to get rid of that ridiculous special page dependency in the updater script. Well, it's relatively new and I wanted to avoid re-inventing th... [09:51:02] (03CR) 10Daimona Eaytoy: "> Are the non-voting jobs a blocker to this? Shall we attempt to fix" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [09:52:50] (03CR) 10Pwirth: [C: 03+2] Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/475059 (owner: 10Robert Vogel) [09:52:59] (03PS1) 10Pwirth: Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521842 [09:53:07] (03CR) 10Pwirth: [C: 03+2] Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521842 (owner: 10Pwirth) [09:53:09] (03CR) 10Daniel Kinzler: [C: 03+2] REST: basic read restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [09:53:25] (03PS11) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [09:53:35] (03PS12) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [09:54:49] (03CR) 10jerkins-bot: [V: 04-1] Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [09:54:51] (03CR) 10jerkins-bot: [V: 04-1] Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 (owner: 10Daimona Eaytoy) [09:56:46] (03Merged) 10jenkins-bot: Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/475059 (owner: 10Robert Vogel) [09:56:54] (03CR) 10Daniel Kinzler: [C: 03+1] "LGTM, but perhaps Anomie wants to have another look." [core] - 10https://gerrit.wikimedia.org/r/506325 (https://phabricator.wikimedia.org/T198341) (owner: 10BPirkle) [09:56:57] (03PS1) 10Dvogel hallowelt: Add label for system user to the LastEdit sentence. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521843 [09:57:03] (03CR) 10jerkins-bot: [V: 04-1] Add label for system user to the LastEdit sentence. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521843 (owner: 10Dvogel hallowelt) [09:57:16] (03PS12) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [09:57:55] (03CR) 10jerkins-bot: [V: 04-1] Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 (owner: 10Daimona Eaytoy) [09:58:37] (03Merged) 10jenkins-bot: Make RunJobsTriggerHander intervals configurable [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521842 (owner: 10Pwirth) [09:59:07] (03PS13) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [09:59:11] (03PS13) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [09:59:27] (03PS1) 10Dvogel hallowelt: [WIP] Add style rules for page header [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521844 [09:59:41] (03CR) 10jerkins-bot: [V: 04-1] Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [10:00:32] (03PS20) 10Daimona Eaytoy: Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) [10:01:28] (03PS14) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [10:01:42] (03CR) 10Daimona Eaytoy: [C: 03+2] "Restoring after whitespace fix in test" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [10:01:59] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) (owner: 10Daimona Eaytoy) [10:02:15] (03CR) 10jerkins-bot: [V: 04-1] Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [10:03:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add style rules for page header [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521844 (owner: 10Dvogel hallowelt) [10:03:21] (03Abandoned) 10MarcoAurelio: README.md: format tweaks, visual indicator of npm dev dependencies [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/459257 (owner: 10MarcoAurelio) [10:03:33] (03PS15) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [10:04:51] 10MediaWiki-General-or-Unknown, 10Core Platform Team (MCR), 10Core Platform Team Workboards (Team 3), 10MW-1.32-release, and 4 others: Failed to access name from slot_roles using id = 1 - https://phabricator.wikimedia.org/T224949 (10daniel) > Before upgrade the wiki was 1.31.0, cache was filled with its da... [10:06:57] (03CR) 10Daimona Eaytoy: [C: 03+2] "> Restoring after whitespace fix in test" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 (owner: 10Daimona Eaytoy) [10:07:32] (03PS3) 10MarcoAurelio: Empty PHP entry points where JSON entry points exist [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/513765 (https://phabricator.wikimedia.org/T140007) (owner: 10Ananth subray) [10:08:34] (03CR) 10MarcoAurelio: "Shall we bump extension.json's version number to 0.3.1?" [extensions/ContributionsList] - 10https://gerrit.wikimedia.org/r/513765 (https://phabricator.wikimedia.org/T140007) (owner: 10Ananth subray) [10:08:36] (03CR) 10jerkins-bot: [V: 04-1] REST: basic read restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [10:08:38] (03CR) 10jerkins-bot: [V: 04-1] Add rest.php (REST API endpoint) with feature flag [core] - 10https://gerrit.wikimedia.org/r/510637 (owner: 10Tim Starling) [10:08:40] (03CR) 10jerkins-bot: [V: 04-1] REST: add write access checks to BasicAccess [core] - 10https://gerrit.wikimedia.org/r/521408 (owner: 10Tim Starling) [10:10:51] (03CR) 10Daniel Kinzler: [C: 03+2] "Flaky Wikibase Selenium test is flaky." [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [10:16:57] 10AICaptcha, 10Security-Team: Statistics on Captcha success/failure rate - https://phabricator.wikimedia.org/T152219 (10Seewolf) Can someone please update the statistics? From the account creation log and the spam volume since the beginning of 2019 it seems to me that our captchas are broken. [10:18:07] 10MediaWiki-extensions-CollaborationKit: CollaborationKit uses non-existing showRedlink config option - https://phabricator.wikimedia.org/T227647 (10Nikerabbit) [10:19:19] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy Growth team experiments on Arabic Wikipedia - https://phabricator.wikimedia.org/T227573 (10Dyolf77_WMF) @MMiller_WMF no problem with these modifications. That's perfect, I already informed the community about possible slight changes. [10:20:14] 10GrowthExperiments, 10GrowthExperiments- MentorshipModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Homepage Mentorship: allow mentors to configure their presentation - https://phabricator.wikimedia.org/T220145 (10Cntlsn) thanks @Tgr I didn't know about the mediawiki co... [10:23:16] 10AICaptcha, 10Security-Team: Statistics on Captcha success/failure rate - https://phabricator.wikimedia.org/T152219 (10Tgr) Grafana stats haven't changed significantly since 2018. These stats are probably not very good for measuring false acceptance rates (ie. how many spambots get through), though - if only... [10:23:51] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) Noting here that our tests should almost certainly include partners with non-ascii names so that things like this get caught. [10:25:19] 10MediaWiki-Releasing, 10Patch-For-Review: Review 1.33.1 tarball - https://phabricator.wikimedia.org/T227599 (10Reedy) The .1 patch file looks rather large to me, 40KB gzipped and 199KB ungzipped I'm confused by the removal of the avro libaries; they're not in mediawiki/core REL1_33 or mediawiki/vendor REL1_3... [10:25:32] 10Library-Card-Platform: UnicodeDecodeError when applying for resources - https://phabricator.wikimedia.org/T226793 (10Samwalton9) Ok this time when I applied for multiple partners I got the expected server error for a UnicodeDecodeError... [10:26:30] (03Merged) 10jenkins-bot: REST: basic read restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [10:26:38] (03Merged) 10jenkins-bot: Add rest.php (REST API endpoint) with feature flag [core] - 10https://gerrit.wikimedia.org/r/510637 (owner: 10Tim Starling) [10:26:40] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10Dyolf77_WMF) - Desktop: (Privacy box) The link for "New User Welcome Survey Privacy Statement" goes to the English page. I think, we have an Arabic translation of it. [10:28:18] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Release-Engineering-Team-TODO, 10Browser-Tests, 10Release-Engineering-Team (Unit & Int & System Tooling): Write browser tests for DonationInterface - https://phabricator.wikimedia.org/T99955 (10zeljkofilipin) [10:28:50] (03CR) 10jenkins-bot: REST: basic read restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [10:30:24] (03CR) 10jenkins-bot: Add rest.php (REST API endpoint) with feature flag [core] - 10https://gerrit.wikimedia.org/r/510637 (owner: 10Tim Starling) [10:32:41] 10AICaptcha, 10Security-Team: Statistics on Captcha success/failure rate - https://phabricator.wikimedia.org/T152219 (10Reedy) a:05Reedy→03None [10:35:25] 10MediaWiki-extensions-WikibaseRepository, 10CirrusSearch, 10Discovery-Search, 10Reading-Infrastructure-Team-Backlog, and 2 others: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch - https://phabricator.wikimedia.org/T224125 (10zeljkofilipin) I think there's a... [10:38:59] 10MediaWiki-extensions-WikibaseRepository, 10CirrusSearch, 10Discovery-Search, 10Reading-Infrastructure-Team-Backlog, and 4 others: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch - https://phabricator.wikimedia.org/T224125 (10zeljkofilipin) [10:40:48] 10MediaWiki-extensions-WikibaseRepository, 10CirrusSearch, 10Discovery-Search, 10Reading-Infrastructure-Team-Backlog, and 4 others: Wikibase and WikibaseLexeme Selenium tests fail when UseCirrus is true in WikibaseCirrusSearch - https://phabricator.wikimedia.org/T224125 (10zeljkofilipin) [10:41:15] (03Merged) 10jenkins-bot: REST: add write access checks to BasicAccess [core] - 10https://gerrit.wikimedia.org/r/521408 (owner: 10Tim Starling) [10:42:01] 10Phabricator, 10Developer-Advocacy (Jul-Sep 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) As announced in https://lists.wikimedia.org/pipermail/wikitech-l/2019-May/092063.html and described above, this has now happened: **Conpherence has b... [10:43:02] (03CR) 10jenkins-bot: REST: add write access checks to BasicAccess [core] - 10https://gerrit.wikimedia.org/r/521408 (owner: 10Tim Starling) [10:45:35] 10Wikimedia-General-or-Unknown: Not possible to move a page to a redirect you created - https://phabricator.wikimedia.org/T227648 (10Luke081515) [10:52:43] 10Indic-TechCom, 10Trust-and-Safety: Disable 2FA for Wikimedia account Shubha - https://phabricator.wikimedia.org/T227574 (10Aklapper) Could Shubha please send an email (to ca at wikimedia dot org) from the registered email address of her wiki account, in order to confirm? Please also include the URL of this t... [11:01:41] 10Research: first version of the algorithm that prioritizes missing sections - https://phabricator.wikimedia.org/T227651 (10diego) [11:02:50] 10MediaWiki-Installer, 10Core Platform Team Workboards (Clinic Duty Team), 10Patch-For-Review: Installer aborts on outdated sqlite module though "--dbtype mysql" was passed - https://phabricator.wikimedia.org/T46511 (10RazeSoldier) From the logic of the code, no-good Status are handled by two implementations... [11:06:16] 10address-knowledge-gaps, 10Epic: Output 1.4: Public test APIs corresponding to section recommendation algorithms - https://phabricator.wikimedia.org/T203046 (10diego) 05Open→03Resolved [11:09:37] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10Dyolf77_WMF) >>! In T226221#5319712, @MMiller_WMF wrote: > @Dyolf77_WMF -- the welcome survey is ready for you to test in Beta wiki. You can try out the survey with the... [11:09:59] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10Dyolf77_WMF) [11:12:42] (03CR) 10Robert Vogel: [C: 03+2] Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521399 (owner: 10Pwirth) [11:12:54] (03PS1) 10Robert Vogel: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31) - 10https://gerrit.wikimedia.org/r/521853 [11:12:57] (03CR) 10Robert Vogel: [C: 03+2] Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31) - 10https://gerrit.wikimedia.org/r/521853 (owner: 10Robert Vogel) [11:13:02] (03PS1) 10Robert Vogel: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521854 [11:13:06] (03CR) 10Robert Vogel: [C: 03+2] Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521854 (owner: 10Robert Vogel) [11:13:19] (03PS2) 10Robert Vogel: Quickfix to support removed rc_comment field for MW 1.32+ [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521410 (owner: 10Pwirth) [11:13:25] (03CR) 10Robert Vogel: [V: 03+2 C: 03+2] Quickfix to support removed rc_comment field for MW 1.32+ [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521410 (owner: 10Pwirth) [11:13:37] (03Merged) 10jenkins-bot: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521399 (owner: 10Pwirth) [11:13:39] (03Merged) 10jenkins-bot: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31) - 10https://gerrit.wikimedia.org/r/521853 (owner: 10Robert Vogel) [11:13:41] (03Merged) 10jenkins-bot: Fix broken RSS feed when no specific protocol configured [extensions/BlueSpiceRSSFeeder] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521854 (owner: 10Robert Vogel) [11:13:51] (03CR) 10Robert Vogel: [C: 03+2] Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521841 (owner: 10Dvogel hallowelt) [11:14:00] (03PS1) 10Robert Vogel: Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521855 [11:14:04] (03CR) 10Robert Vogel: [C: 03+2] Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521855 (owner: 10Robert Vogel) [11:14:21] (03Merged) 10jenkins-bot: Quickfix to support removed rc_comment field for MW 1.32+ [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/521410 (owner: 10Pwirth) [11:17:39] (03Merged) 10jenkins-bot: Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521841 (owner: 10Dvogel hallowelt) [11:17:41] 10Research: first version of the algorithm that prioritizes missing sections - https://phabricator.wikimedia.org/T227651 (10diego) Considering the feedback obtained in T225136, we conclude that the prioritization should be adapted to the characteristic of the editor being assisted. We can split editors in two di... [11:17:55] 10Research: first version of the algorithm that prioritizes missing sections - https://phabricator.wikimedia.org/T227651 (10diego) 05Open→03Resolved [11:18:17] (03Merged) 10jenkins-bot: Fix notice for undefined variable at PageInfoSentenceBuilder [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521855 (owner: 10Robert Vogel) [11:22:10] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-July-September): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10diego) @Pginer-WMF , I'm going to put this task as resolved from me side, and we can continue the follow-up somewhere else, ok? [11:22:28] (03CR) 10Pwirth: [C: 03+2] Fix notices in unauthorized contexts [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521420 (owner: 10Robert Vogel) [11:22:34] (03PS1) 10Pwirth: Fix notices in unauthorized contexts [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521856 [11:22:39] (03CR) 10Pwirth: [C: 03+2] Fix notices in unauthorized contexts [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521856 (owner: 10Pwirth) [11:24:35] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-July-September): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10diego) 05Open→03Resolved [11:24:41] (03CR) 10Daimona Eaytoy: "> ` (03PS15) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:26:22] (03Merged) 10jenkins-bot: Fix notices in unauthorized contexts [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521420 (owner: 10Robert Vogel) [11:26:24] (03Merged) 10jenkins-bot: Fix notices in unauthorized contexts [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/521856 (owner: 10Pwirth) [11:26:35] (03CR) 10jerkins-bot: [V: 04-1] Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 (owner: 10Daimona Eaytoy) [11:26:40] (03PS10) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [11:26:51] (03PS8) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [11:26:53] 10Research: first version of the algorithm that prioritizes missing sections - https://phabricator.wikimedia.org/T227651 (10diego) [11:26:55] 10address-knowledge-gaps, 10Epic: Output 1.5: The first version of the algorithm that prioritizes missing sections - https://phabricator.wikimedia.org/T203047 (10diego) [11:27:12] (03CR) 10jerkins-bot: [V: 04-1] Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 (owner: 10Daimona Eaytoy) [11:27:30] (03CR) 10jerkins-bot: [V: 04-1] Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 (owner: 10Daimona Eaytoy) [11:30:15] (03PS16) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:30:54] (03CR) 10jerkins-bot: [V: 04-1] Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 (owner: 10Daimona Eaytoy) [11:32:09] (03PS2) 10Pwirth: Add label for system user to the LastEdit sentence. [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521843 (owner: 10Dvogel hallowelt) [11:32:41] 10ISA: Single quotation marks ' in file name breaks save of edit - https://phabricator.wikimedia.org/T227652 (10Seantime) [11:33:56] (03CR) 10Pwirth: [C: 04-1] Add label for system user to the LastEdit sentence. (031 comment) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521843 (owner: 10Dvogel hallowelt) [11:36:59] 10ISA: Language dropdown not working on participate page - https://phabricator.wikimedia.org/T227653 (10Seantime) [11:43:25] (03PS11) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [11:43:35] (03PS9) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [11:44:14] (03CR) 10jerkins-bot: [V: 04-1] Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 (owner: 10Daimona Eaytoy) [11:46:43] 10WMSE-Riksarkivet-NAD: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) [11:47:05] (03PS77) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [11:47:39] 10WMSE-Riksarkivet-NAD: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) [11:48:56] (03PS17) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:49:20] (03CR) 10jerkins-bot: [V: 04-1] Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 (owner: 10Daimona Eaytoy) [11:49:53] (03PS18) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:50:19] (03CR) 10jerkins-bot: [V: 04-1] Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 (owner: 10Daimona Eaytoy) [11:51:21] (03PS19) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:51:51] (03PS10) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [11:52:44] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) a:05zeljkofilipin→03None [11:53:27] (03CR) 10Daimona Eaytoy: [C: 03+2] "Restoring CR after whitespace fix" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 (owner: 10Daimona Eaytoy) [11:54:18] 10ContentTranslation: Red links are shown as blue in translation view when using Timeless skin - https://phabricator.wikimedia.org/T227654 (10Nikerabbit) [11:55:57] 10WMSE-Riksarkivet-NAD: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) [11:56:42] (03PS6) 10Daimona Eaytoy: Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) [11:56:56] (03CR) 10jerkins-bot: [V: 04-1] Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [11:57:04] (03CR) 10jerkins-bot: [V: 04-1] Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [11:57:22] 10WMSE-Riksarkivet-NAD: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) [11:57:39] (03PS7) 10Daimona Eaytoy: Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) [11:57:57] (03CR) 10Daimona Eaytoy: Fix the regex for numbers, start deprecation of non-decimal numbers (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [11:59:50] (03CR) 10jerkins-bot: [V: 04-1] Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [12:01:52] (03CR) 10jerkins-bot: [V: 04-1] Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [12:02:05] (03PS1) 10ItSpiderman: Change extension URL [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/521860 [12:02:45] (03CR) 10jerkins-bot: [V: 04-1] Change extension URL [extensions/OOJSPlus] - 10https://gerrit.wikimedia.org/r/521860 (owner: 10ItSpiderman) [12:06:39] (03PS1) 10Daniel Kinzler: Work around dephpend being incomatible with symphony 4.3 [tools/dependency-analysis] - 10https://gerrit.wikimedia.org/r/521861 [12:06:59] (03CR) 10Daniel Kinzler: [V: 03+2 C: 03+2] Work around dephpend being incomatible with symphony 4.3 [tools/dependency-analysis] - 10https://gerrit.wikimedia.org/r/521861 (owner: 10Daniel Kinzler) [12:08:40] 10ISA: Store statement id for existing depict statements - https://phabricator.wikimedia.org/T226092 (10NavinoEvans) [12:08:48] 10ISA: Store statement id for existing depict statements - https://phabricator.wikimedia.org/T226092 (10NavinoEvans) a:03NavinoEvans [12:08:55] 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2 adds unnecessary id attributes to tables, table cells - https://phabricator.wikimedia.org/T213273 (10NicoV) 05Resolved→03Open Reopening the task as it still doesn't work all the time: there are still id attributes in table titles. See h... [12:25:30] 04(no projects): "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10Shirayuki) [12:30:38] 10MediaWiki-History-and-Diffs: "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10Reedy) >IP addresses of anonymous editors should be shown. Well, not necessarily. It is possible to suppress IP addresses like you can usernames [12:35:47] 10GrowthExperiments, 10Growth-Team (Current Sprint): Deploy Growth team experiments on Arabic Wikipedia - https://phabricator.wikimedia.org/T227573 (10Trizek-WMF) p:05Triage→03High [12:36:14] 10wikimediafoundation.org, 10I18n, 10RTL: wikimediafoundation.org: ltr/rtl not properly handled in yellow box - https://phabricator.wikimedia.org/T227636 (10Reedy) [12:36:30] 10MediaWiki-Core-Testing, 10Release-Engineering-Team-TODO, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) a:03zeljkofilipin [12:37:24] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:37:55] 10MediaWiki-History-and-Diffs: "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10Shirayuki) Special:RecentChanges and Special:Watchlist shows IP addresses, but action=history does not. [12:41:18] 10MediaWiki-History-and-Diffs: "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10Reedy) p:05Triage→03Unbreak! Looks like a .13 train blocker [12:42:10] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Nemo_bis) >>! In T200742#4476636, @Nemo_bis wrote: > Notice the lack of a lang attribute, which means the root lang will apply: > >> The b... [12:42:42] 10wikimediafoundation.org, 10I18n, 10RTL: wikimediafoundation.org: ltr/rtl not properly handled in yellow box - https://phabricator.wikimedia.org/T227636 (10Nemo_bis) The HTML still lies about the language of the content (T200742#5320718)... [12:42:46] 10MediaWiki-History-and-Diffs: "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10Reedy) [12:43:35] 10GrowthExperiments, 10GrowthExperiments- MentorshipModule, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Homepage Mentorship: allow mentors to configure their presentation - https://phabricator.wikimedia.org/T220145 (10Trizek-WMF) I'm preparing the documentation for this fea... [12:45:21] 10MediaWiki-Database, 10MSSQL: Error when deleting uploaded image file: WikiPage::archiveRevisions: No column name was specified for column 1 of 'tmp_count' - https://phabricator.wikimedia.org/T227607 (10Reedy) What version of MediaWiki? >This is not an MSSQL-related issue and I can't even temporarily correct... [12:45:49] (03CR) 10Dmaza: "See my comments. Looks good otherwise and works as intended. Sorry for the back and forth." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/519254 (owner: 10Tchanders) [12:45:57] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10kostajh) > Privacy page is in English, please see my comment above. Yes, we need to set `wgWelcomeSurveyPrivacyPolicyUrl` in the configuration repository. The other wi... [12:46:20] 10MediaWiki-Database, 10MSSQL: Error When Viewing New Files: "Ambiguous column name 'img_timestamp'" - https://phabricator.wikimedia.org/T227608 (10Reedy) What version of MediaWiki? I'm presuming it doesn't like that there is an index called `img_timestamp` too [12:46:49] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10CCicalese_WMF) You are missing: `wfLoadExtension( 'LDAPAuthentication2' );` [12:48:06] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:48:20] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:49:02] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:50:33] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:50:48] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10cicalese) You are missing: `wfLoadExtension( 'LDAPAuthentication2' );` That step was missing from the LDAPAuthentication2 documentati... [12:51:36] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:52:50] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10Reedy) >>! In T227458#5320751, @cicalese wrote: > You are missing: > > `wfLoadExtension( 'LDAPAuthentication2' );` > > That step was... [12:53:25] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) [12:58:43] 10wikimediafoundation.org, 10I18n: Regression: only English available - https://phabricator.wikimedia.org/T201024 (10Nemo_bis) I still don't see a process to add translations, so this bug is not fixed. The announcement https://lists.wikimedia.org/pipermail/wikimedia-l/2019-July/093048.html only says there migh... [13:02:03] 10MediaWiki-History-and-Diffs: "username removed" on mediawiki.org - https://phabricator.wikimedia.org/T227656 (10MarcoAurelio) I see no suppressions in the logs that could cause [[ https://www.mediawiki.org/w/index.php?title=Translations:Template:Main_page/22/it&action=history | this issue ]]. A bug indeed unle... [13:03:19] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10cicalese) Right, that should be done as well. @Osnard, thoughts? [13:06:06] (03PS1) 10VolkerE: Update OOUI to v0.33.2 [vendor] - 10https://gerrit.wikimedia.org/r/521867 [13:08:51] (03PS5) 10DmitriyShevliakov: [WIP] Add local storage notification [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520910 [13:10:18] 10Library-Card-Platform: Investigate database locale issues - https://phabricator.wikimedia.org/T227659 (10Samwalton9) [13:11:17] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10dmaza) I'm a bit confused as to what is the issue here ` Expected Result: Either: Grey 'Editing their own talk page' when... [13:11:19] 10Library-Card-Platform: Investigate database locale issues - https://phabricator.wikimedia.org/T227659 (10Samwalton9) p:05Triage→03High [13:11:36] 10MediaWiki-History-and-Diffs: action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addresses - https://phabricator.wikimedia.org/T227656 (10Aklapper) [13:13:21] (03PS3) 10DmitriyShevliakov: [WIP] Create notification for successful login [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521301 [13:16:48] 10MediaWiki-extensions-Pluggable-Auth: PHP error with mediawiki 1.33 when going to login: "Undefined index: wgPluggableAuth_Class" - https://phabricator.wikimedia.org/T227458 (10cicalese) Actually, the requires statement is already present in LDAPAUthentication2. That did not detect the current problem, however,... [13:16:56] 10MediaWiki-General-or-Unknown, 10Core Platform Team, 10Multi-Content-Revisions, 10User-DannyS712, 10Wikimedia-production-error: MWException when moving talk page on enwiki: "Failed to create null revision while moving page" - https://phabricator.wikimedia.org/T227517 (10Anomie) [13:16:59] 10MediaWiki-General-or-Unknown, 10Core Platform Team (MCR), 10Core Platform Team Backlog (Next), 10Multi-Content-Revisions (Reactive), and 3 others: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given" - https://phabricator.wikimedia.org/T205675 (10Anomie) [13:17:42] (03CR) 10jerkins-bot: [V: 04-1] Update OOUI to v0.33.2 [vendor] - 10https://gerrit.wikimedia.org/r/521867 (owner: 10VolkerE) [13:17:49] 10acl*stewards: Proxies - https://phabricator.wikimedia.org/T227660 (10Daimona) [13:26:40] (03PS8) 10Daimona Eaytoy: Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) [13:36:30] (03PS4) 10Tchanders: Report more information about composite blocks in block error messages [core] - 10https://gerrit.wikimedia.org/r/520479 (https://phabricator.wikimedia.org/T212326) [13:53:12] (03CR) 10Anomie: [C: 04-1] "Seems like a good start, but I see a few issues." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/513732 (https://phabricator.wikimedia.org/T217855) (owner: 10星耀晨曦) [13:54:20] (03PS13) 10Jdrewniak: Adapt Recent Changes advanced filters for mobile usage [core] - 10https://gerrit.wikimedia.org/r/517026 (https://phabricator.wikimedia.org/T225499) [13:54:37] (03CR) 10Kosta Harlan: [C: 03+2] Isolate globals for ContentSecurityPolicy tests [core] - 10https://gerrit.wikimedia.org/r/516759 (owner: 10Hashar) [13:56:14] (03CR) 10Daimona Eaytoy: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [13:57:16] (03PS4) 10Kosta Harlan: Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [14:00:09] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/521769 (owner: 10Jforrester) [14:00:30] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @amir1 & @ottomata - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:00:49] (03PS2) 10Tchanders: Replace old URLs in SampleTest [core] - 10https://gerrit.wikimedia.org/r/512671 [14:01:13] (03CR) 10jerkins-bot: [V: 04-1] Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [14:04:14] (03CR) 10jerkins-bot: [V: 04-1] Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [14:07:58] (03PS6) 10DmitriyShevliakov: Add local storage notification [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520910 [14:08:29] (03PS1) 10Pwirth: Implement MessageLocalizer interface to slowly get rid of wfMessage calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/521873 [14:09:08] (03PS4) 10DmitriyShevliakov: Create notification for successful login [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521301 [14:09:31] (03Merged) 10jenkins-bot: Isolate globals for ContentSecurityPolicy tests [core] - 10https://gerrit.wikimedia.org/r/516759 (owner: 10Hashar) [14:11:46] (03CR) 10Tchanders: "Agree with not executing costly tests needlessly, though these might become un-maintained and broken if never run. Perhaps they could test" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/512671 (owner: 10Tchanders) [14:13:23] (03PS1) 10VolkerE: Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) [14:16:34] (03CR) 10jenkins-bot: Isolate globals for ContentSecurityPolicy tests [core] - 10https://gerrit.wikimedia.org/r/516759 (owner: 10Hashar) [14:17:29] (03PS2) 10Pwirth: Implement MessageLocalizer interface to slowly get rid of wfMessage calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/521873 [14:17:58] (03PS2) 10VolkerE: Update OOUI to v0.33.2 [vendor] - 10https://gerrit.wikimedia.org/r/521867 [14:18:04] (03CR) 10jerkins-bot: [V: 04-1] Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [14:19:49] (03PS1) 10Pwirth: [WIP] Add excludes for external file index. ERM:15784 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/521878 [14:21:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add excludes for external file index. ERM:15784 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/521878 (owner: 10Pwirth) [14:26:20] (03PS1) 10Zfilipin: Delete Ruby Selenium tests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/521879 (https://phabricator.wikimedia.org/T173989) [14:29:51] (03CR) 10Anomie: [C: 04-1] "Seems straightforward. Most of the comments are missing `use` directives, missing blank lines between the file-level comment and the added" (0327 comments) [core] - 10https://gerrit.wikimedia.org/r/519090 (owner: 10Legoktm) [14:30:22] (03CR) 10jerkins-bot: [V: 04-1] Delete Ruby Selenium tests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/521879 (https://phabricator.wikimedia.org/T173989) (owner: 10Zfilipin) [14:33:21] (03PS1) 10Effie Mouzeli: Switch more high traffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) [14:34:50] (03PS2) 10Zfilipin: Delete Ruby Selenium tests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/521879 (https://phabricator.wikimedia.org/T173989) [14:35:08] (03CR) 10Zfilipin: "PS2 adds Depends-On." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/521879 (https://phabricator.wikimedia.org/T173989) (owner: 10Zfilipin) [14:36:25] (03CR) 10Anomie: [C: 03+1] "Seems good in itself (and thanks for librarizing it), so +1. Should be good to go once the load order issue is resolved." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519089 (owner: 10Legoktm) [14:38:02] (03CR) 10jerkins-bot: [V: 04-1] Delete Ruby Selenium tests [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/521879 (https://phabricator.wikimedia.org/T173989) (owner: 10Zfilipin) [14:39:08] (03CR) 10Bartosz Dziewoński: "" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [14:40:42] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/521781 (owner: 10Jforrester) [14:42:23] (03PS7) 10Robert Vogel: Add local storage notification [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520910 (owner: 10DmitriyShevliakov) [14:43:37] (03CR) 10Ppchelko: [C: 04-1] "You know what?! With this we would switch all jobs in `high_traffic_jobs_config` to php7. Why don't we go into config.yaml, set the php7 c" [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) (owner: 10Effie Mouzeli) [14:43:49] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/521781 (owner: 10Jforrester) [14:48:32] (03CR) 10Anomie: [C: 03+2] "Seems fine to me too. Most of the references I see left are guarded by $wgMultiContentRevisionSchemaMigrationStage, so they should be fine" [core] - 10https://gerrit.wikimedia.org/r/506325 (https://phabricator.wikimedia.org/T198341) (owner: 10BPirkle) [14:50:29] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @amir1 & @ottomata - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:58:29] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [14:59:39] (03PS2) 10Jforrester: Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [15:00:56] (03PS2) 10Jack Phoenix: Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 [15:01:23] (03Merged) 10jenkins-bot: Remove references to db field ar_text_id [core] - 10https://gerrit.wikimedia.org/r/506325 (https://phabricator.wikimedia.org/T198341) (owner: 10BPirkle) [15:03:24] (03CR) 10jenkins-bot: Remove references to db field ar_text_id [core] - 10https://gerrit.wikimedia.org/r/506325 (https://phabricator.wikimedia.org/T198341) (owner: 10BPirkle) [15:04:25] (03CR) 10jerkins-bot: [V: 04-1] Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 (owner: 10Jack Phoenix) [15:06:09] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/521843 (owner: 10Dvogel hallowelt) [15:08:08] (03CR) 10Jforrester: "recheck" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [15:08:21] (03CR) 10Jforrester: "Whoops, didn't update the non-voting job templates. Now pushed, this should be "fine" but is also fine to merge, yes." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [15:08:37] (03CR) 10Jforrester: [C: 03+1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [15:11:37] 10wikimediafoundation.org: News author page heading shows raw HTML - https://phabricator.wikimedia.org/T227674 (10Aklapper) [15:12:26] 10Editing Design, 10VisualEditor (Current work): Finalize the copy for Edit Cards v2 - https://phabricator.wikimedia.org/T226511 (10iamjessklein) 05Open→03Resolved We are in a good place with the content. Everything is already being tested so lets ship this ticket. [15:12:34] 10VisualEditor (Current work): Finalize the copy for Edit Cards v2 - https://phabricator.wikimedia.org/T226511 (10iamjessklein) [15:12:55] (03CR) 10Jforrester: [C: 03+2] Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [15:13:01] 10Editing Design, 10VisualEditor (Current work): Edit cards v2: conduct usertesting.com test - https://phabricator.wikimedia.org/T221299 (10iamjessklein) [15:13:03] (03CR) 10Jforrester: [C: 03+2] Update OOUI to v0.33.2 [vendor] - 10https://gerrit.wikimedia.org/r/521867 (owner: 10VolkerE) [15:13:10] (03PS2) 10Bartosz Dziewoński: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [15:13:37] 10Editing Design, 10VisualEditor (Current work): Edit cards v2: conduct usertesting.com test - https://phabricator.wikimedia.org/T221299 (10iamjessklein) The test is up and running on usertesting.com right now. It should take a few days to get the results in and then I will provide a synthesis after watching t... [15:14:15] 10Editing Design, 10VisualEditor (Current work): Edit cards v2: conduct usertesting.com test - https://phabricator.wikimedia.org/T221299 (10ppelberg) a:05ppelberg→03iamjessklein [15:16:40] 10wikimediafoundation.org: "Recent posts" on profile does not show most recent post - https://phabricator.wikimedia.org/T227675 (10Aklapper) [15:17:31] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Never Ending Query: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (10mepps) @AndyRussG @DStrine Maybe we should take this off the board until we get a new patch? [15:18:33] (03CR) 10Bartosz Dziewoński: "I guess if this helps? I'd appreciate a comment from some Phab SecCheck expert if escapes_htmlnoent really does what I think it does (see " [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [15:20:06] (03PS3) 10Jack Phoenix: Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 [15:20:35] 10MediaWiki-Installer: Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10Reedy) [15:20:54] (03PS2) 10Bartosz Dziewoński: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/521784 (owner: 10Jforrester) [15:21:00] (03CR) 10Daimona Eaytoy: "I propose to fix the one in VoterEligibilityPage, where the message assigned to $name should be escaped()." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [15:21:28] 10MediaWiki-File-management, 10MediaWiki-General-or-Unknown, 10Commons, 10Multimedia: Renaming a page in File namespace without a file associated triggers an error - https://phabricator.wikimedia.org/T227590 (10Aklapper) [15:23:06] (03CR) 10jerkins-bot: [V: 04-1] Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 (owner: 10Jack Phoenix) [15:24:22] (03CR) 10Daimona Eaytoy: "Well, this is a sort of hack. The alternative being to just suppress the issue, because seccheck is not so smart to understand these custo" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [15:24:57] 10MediaWiki-Installer: Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10Reedy) >...comment table already exists. `lang=php [ 'addTable', 'comment', 'patch-comment-table.sql' ], ` ^ So, it thinks it has already run the `patch-comment-table.sql` update... Wh... [15:26:52] (03CR) 10Krinkle: [C: 03+2] Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [15:26:57] (03Merged) 10jenkins-bot: Update OOUI to v0.33.2 [vendor] - 10https://gerrit.wikimedia.org/r/521867 (owner: 10VolkerE) [15:28:31] (03Merged) 10jenkins-bot: Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [15:29:05] (03PS2) 10Effie Mouzeli: Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) [15:29:57] (03PS1) 10DCausse: Adapt IndexLookupFallback method for glent requirements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521887 (https://phabricator.wikimedia.org/T227262) [15:30:33] (03PS3) 10Effie Mouzeli: Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) [15:30:35] (03CR) 10jenkins-bot: Update OOUI to v0.33.2 [core] - 10https://gerrit.wikimedia.org/r/521875 (https://phabricator.wikimedia.org/T158708) (owner: 10VolkerE) [15:30:55] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/521589 (owner: 10Jforrester) [15:32:52] 10Discovery-Search, 10Product-Analytics: Reorganize metrics dashboard for Search Platform - https://phabricator.wikimedia.org/T186044 (10TJones) Below is a list of metrics that seem like they be most beneficial as always available dashboards in Superset. (Lots of other metrics are important, but others are fin... [15:33:05] anyone here? I can't create new task on phab, where I can report this? [15:33:27] mbh: hello [15:33:42] 10Security: Security Issue Access Request for colewhite - https://phabricator.wikimedia.org/T227629 (10sbassett) p:05Triage→03Normal [15:34:03] Unhandled Exception ("Error") [15:34:16] when I try to create new task [15:34:32] (03PS5) 10Tchanders: Tidy up conditions for applying a block from a cookie [core] - 10https://gerrit.wikimedia.org/r/519254 [15:34:34] (03PS5) 10Tchanders: Pass in ServiceOptions to BlockManager [core] - 10https://gerrit.wikimedia.org/r/519255 [15:34:55] also tasks https://phabricator.wikimedia.org/T213144 [15:35:03] are unaccessible too [15:35:28] MatmaRex [15:35:38] 10Security: Security Issue Access Request for colewhite - https://phabricator.wikimedia.org/T227629 (10sbassett) Approved by the #security-team and @JBennett. I'd add them, but I don't have the privs for #Security, so a Phab admin will need to as @Reedy and @chasemp are technically away on leave right now. [15:36:01] 10Security-Team: #Security access for Urbanecm - https://phabricator.wikimedia.org/T227483 (10sbassett) 05Stalled→03Open Approved by the #security-team and @JBennett. I'd add them, but I don't have the privs for #Security, so a Phab admin will need to as @Reedy and @chasemp are technically away on leave rig... [15:36:41] other tasks seem to work fine. but that one is broken for me too [15:37:42] 04(no projects): Testing task creation - https://phabricator.wikimedia.org/T227677 (10matmarex) [15:37:56] mbh: task creation works for me. i just created this one https://phabricator.wikimedia.org/T227677 using this form https://phabricator.wikimedia.org/maniphest/task/edit/form/1/ [15:38:05] (03Merged) 10jenkins-bot: Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [15:38:25] https://phabricator.wikimedia.org/T213144 [15:38:36] can you open this tasks? [15:38:49] no. all i see is "Unhandled Exception ("Error")" "Call to undefined method PhutilDOMNode::setRawContent()" [15:39:12] I see this also when I trying to create my task [15:40:09] (03PS1) 10Ladsgroup: Stop autoloading test classes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/521890 [15:42:11] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521887 (https://phabricator.wikimedia.org/T227262) (owner: 10DCausse) [15:42:35] (03PS1) 10Nray: Convert Page.js to ES6 class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521891 (https://phabricator.wikimedia.org/T193077) [15:42:37] (03PS1) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [15:44:33] (03CR) 10jenkins-bot: Fix the regex for numbers, start deprecation of non-decimal numbers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481635 (https://phabricator.wikimedia.org/T212726) (owner: 10Daimona Eaytoy) [15:44:57] 10Anti-Harassment: Clear block cookie if the value is invalid - https://phabricator.wikimedia.org/T227678 (10Tchanders) [15:45:13] (03CR) 10Ppchelko: [C: 04-1] "One minor nit" (031 comment) [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) (owner: 10Effie Mouzeli) [15:45:39] 10Security: Security Issue Access Request for colewhite - https://phabricator.wikimedia.org/T227629 (10Legoktm) 05Open→03Resolved a:03Legoktm Done then :) [15:46:10] (03CR) 10Daimona Eaytoy: "OK, so the problem here is: this code is calling getIndexErrorOutput, which escapes its third argument. The resulting string is passed as " [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/521629 (owner: 10Jforrester) [15:46:21] 10Security-Team: #Security access for Urbanecm - https://phabricator.wikimedia.org/T227483 (10Urbanecm) >>! In T227483#5321274, @sbassett wrote: > Approved by the #security-team and @JBennett. I'd add them, but I don't have the privs for #Security, so a Phab admin will need to as @Reedy and @chasemp are technic... [15:48:19] (03CR) 10jerkins-bot: [V: 04-1] Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) (owner: 10Nray) [15:48:26] (03PS5) 10Ladsgroup: Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 [15:54:14] 10Space (Jul-Sep-2019): Write documentation on how to add media to Wikimedia Space blog - https://phabricator.wikimedia.org/T227679 (10CKoerner_WMF) [15:54:52] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Release-Engineering-Team-TODO (201907): ReleaseNotesTest:testReleaseNotesFilesExistAndAreNotMalformed takes ~ 4 seconds - https://phabricator.wikimedia.org/T227067 (10hashar) [15:55:09] (03CR) 10Kosta Harlan: [C: 04-1] Move unit tests to the new structure (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [15:55:44] 10Security-Team: #Security access for Urbanecm - https://phabricator.wikimedia.org/T227483 (10Aklapper) 05Open→03Resolved >>! In T227483#5321274, @sbassett wrote: > Approved by the #security-team and @JBennett. I've added @Urbanecm to https://phabricator.wikimedia.org/project/members/30/ [15:56:12] 10Documentation, 10Space (Jul-Sep-2019): Write documentation on how to add media to Wikimedia Space blog - https://phabricator.wikimedia.org/T227679 (10Aklapper) [15:56:55] (03CR) 10Krinkle: [C: 03+2] rdbms: make IDatabase::isReadOnly() return true for replica DBs managed by LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/521821 (owner: 10Aaron Schulz) [15:57:11] 10WMSE-Riksarkivet-NAD: P777 Swedish civil parish code/ATA code need care - https://phabricator.wikimedia.org/T227554 (10Salgo60) [15:57:36] (03CR) 10Krinkle: [C: 03+1] objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521822 (owner: 10Aaron Schulz) [15:57:51] (03CR) 10Daimona Eaytoy: "line 61: seccheck is right. Replace escaped() with text()" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [15:58:05] (03CR) 10Ladsgroup: Move unit tests to the new structure (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [15:58:47] (03CR) 10jerkins-bot: [V: 04-1] Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [15:58:59] 10Security-Team: #Security access for Urbanecm - https://phabricator.wikimedia.org/T227483 (10Urbanecm) Thanks! [15:59:28] (03CR) 10Krinkle: "See also https://phabricator.wikimedia.org/T205482 - might not be worth investing in, unless it helps make the static dumps better." [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [15:59:42] (03Abandoned) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/521710 (owner: 10Jforrester) [15:59:49] (03PS1) 10Kosta Harlan: Move non-unit test out of unit directory [core] - 10https://gerrit.wikimedia.org/r/521896 [16:00:34] (03CR) 10Daimona Eaytoy: "> See also https://phabricator.wikimedia.org/T205482 - might not be" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [16:00:48] (03CR) 10Kosta Harlan: [C: 04-1] Move unit tests to the new structure (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [16:01:29] (03CR) 10Daimona Eaytoy: "recheck" [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [16:01:49] (03CR) 10Kosta Harlan: "In master, when running `composer phpunit:unit` I get:" [core] - 10https://gerrit.wikimedia.org/r/521896 (owner: 10Kosta Harlan) [16:03:14] (03CR) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:04:03] 10MediaWiki-Installer, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Workboards (Done with CPT), 10User-Nikerabbit: Allow extensions to define additional command line parameters to "update.php" - https://phabricator.wikimedia.org/T213893 (10MarkAHershbe... [16:05:02] (03CR) 10Tjones: Adapt IndexLookupFallback method for glent requirements (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521887 (https://phabricator.wikimedia.org/T227262) (owner: 10DCausse) [16:05:22] (03PS2) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 [16:05:35] (03CR) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 (032 comments) [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/521625 (owner: 10Jforrester) [16:06:42] 10Anti-Harassment (The Letter Song ): Special:Block checkboxes should remember checked state - https://phabricator.wikimedia.org/T221117 (10Tchanders) [16:07:21] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:08:16] (03CR) 10Tchanders: Tidy up conditions for applying a block from a cookie (032 comments) [core] - 10https://gerrit.wikimedia.org/r/519254 (owner: 10Tchanders) [16:09:08] 10MediaWiki-Cache, 10Operations, 10serviceops-radar, 10Core Platform Team (Mainstash Multi-DC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10EvanProdromou) >>>! In T212129#5211137, @EvanProdromou wrote: >> I'd assume there w... [16:11:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Never Ending Query: Review Campaign Fallback - https://phabricator.wikimedia.org/T226344 (10DStrine) They have been able to turn around patches within a week. I feel like we'd just be pulling this back in before the end of the... [16:11:42] 10MediaWiki-Installer, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Workboards (Done with CPT), 10User-Nikerabbit: Allow extensions to define additional command line parameters to "update.php" - https://phabricator.wikimedia.org/T213893 (10Kghbln) > I... [16:11:50] 10MediaWiki-Cache, 10Operations, 10serviceops-radar, 10Core Platform Team (Mainstash Multi-DC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10EvanProdromou) @Krinkle Also, it sounds like we'd be changing the contract as loosel... [16:12:19] (03CR) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 (035 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [16:12:59] (03Merged) 10jenkins-bot: rdbms: make IDatabase::isReadOnly() return true for replica DBs managed by LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/521821 (owner: 10Aaron Schulz) [16:14:37] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (10DStrine) p:05Low→03High Hi all, We would like to deploy this as soon as possible. Does anyone in security need mor... [16:14:42] (03PS3) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 [16:15:08] (03CR) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 (033 comments) [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [16:15:11] 10Indic-TechCom, 10Trust-and-Safety: Disable 2FA for Wikimedia account Shubha - https://phabricator.wikimedia.org/T227574 (10Jayprakash12345) Shubha Ji told me that Samual helped her from ca@wikimedia.org, we should give Samual the proper attribution If possible. [16:15:42] 10Indic-TechCom, 10Trust-and-Safety: Disable 2FA for Wikimedia account Shubha - https://phabricator.wikimedia.org/T227574 (10Urbanecm) a:03sguebo_WMF If you want :) [16:16:44] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:17:25] (03PS1) 10Ladsgroup: Stop autoloading test classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521897 [16:17:44] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/521692 (owner: 10Jforrester) [16:19:02] (03PS4) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:19:27] (03CR) 10Krinkle: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [16:19:29] (03CR) 10Krinkle: [C: 03+2] bagostuff: optimize SqlBagOStuff and fix failing segmentation tests [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [16:19:48] 10Space (Jul-Sep-2019): Investigate changing the "Publish..." button in Wikimedia Space blog to "Submit for Review" for the contributor role - https://phabricator.wikimedia.org/T227533 (10CKoerner_WMF) p:05Normal→03Low [16:20:10] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), and 2 others: Homepage: discovery of homepage after account creation (desktop) - https://phabricator.wikimedia.org/T222852 (10kostajh) @MMiller_WMF @Cntlsn the mock up says "Close and go back to... [16:20:40] 10Documentation, 10Space (Jul-Sep-2019): Write documentation on how to add media to Wikimedia Space blog - https://phabricator.wikimedia.org/T227679 (10CKoerner_WMF) p:05Triage→03Normal [16:20:49] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:22:19] (03PS5) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 [16:22:51] (03CR) 10jenkins-bot: rdbms: make IDatabase::isReadOnly() return true for replica DBs managed by LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/521821 (owner: 10Aaron Schulz) [16:23:46] (03CR) 10Krinkle: jobqueue: migrate root job deduplication to the WAN cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520964 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [16:24:00] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (10sbassett) @DStrine @AndyRussG - I don't think anyone's been able to look at this as the #security-team is currently ver... [16:24:19] (03CR) 10Daimona Eaytoy: [C: 03+1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/521692 (owner: 10Jforrester) [16:25:17] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [16:25:37] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), and 2 others: Homepage: discovery of homepage after account creation (desktop) - https://phabricator.wikimedia.org/T222852 (10Cntlsn) @kostajh sure, even better of course! My only question woul... [16:26:06] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [16:26:38] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [16:26:48] (03CR) 10Krinkle: jobqueue: migrate root job deduplication to the WAN cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520964 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [16:26:52] (03CR) 10Krinkle: [C: 04-1] jobqueue: migrate root job deduplication to the WAN cache [core] - 10https://gerrit.wikimedia.org/r/520964 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [16:27:03] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/521784 (owner: 10Jforrester) [16:27:11] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), and 2 others: Homepage: discovery of homepage after account creation (desktop) - https://phabricator.wikimedia.org/T222852 (10kostajh) > My only question would be: is it possible that we send th... [16:27:22] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [16:27:28] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/521589 (owner: 10Jforrester) [16:27:40] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:28:38] (03CR) 10Ladsgroup: Move unit tests to the new structure (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [16:29:03] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [16:29:30] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/521692 (owner: 10Jforrester) [16:30:11] (03PS6) 10Ladsgroup: Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 [16:30:13] 10MediaWiki-Core-Testing, 10Epic, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Port Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T139740 (10zeljkofilipin) a:03zeljkofilipin [16:30:28] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/521625 (owner: 10Jforrester) [16:30:43] (03CR) 10Krinkle: [C: 03+2] "Hm.. I always assumed it was scoped to the database already, but I guess MySQL ignores the currently USE'd database name when doing locks," [core] - 10https://gerrit.wikimedia.org/r/521015 (owner: 10Aaron Schulz) [16:31:34] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/521606 (owner: 10Jforrester) [16:32:08] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [16:32:54] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/521661 (owner: 10Jforrester) [16:33:49] 10MediaWiki-User-management, 10Anti-Harassment: Clear block cookie if the value is invalid - https://phabricator.wikimedia.org/T227678 (10JJMC89) [16:34:51] (03Merged) 10jenkins-bot: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [16:35:00] 10MediaWiki-Special-pages, 10MediaWiki-User-management, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10User-DannyS712: Add "help" link to Special:Unblock - https://phabricator.wikimedia.org/T227295 (10JJMC89) [16:35:44] (03CR) 10Jforrester: [C: 03+2] "Let's merge this for now." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [16:36:04] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/521625 (owner: 10Jforrester) [16:36:36] 10Security-Team: Onboard Jennifer Cross to Security Team as Project Manager (May 24th) - https://phabricator.wikimedia.org/T225554 (10Jcross) [16:36:54] (03CR) 10jenkins-bot: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [16:37:01] (03CR) 10Krinkle: [C: 04-1] "The expected retention of this data is to persist longer than a typical session would, given it is used for security purposes between unre" [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/521017 (https://phabricator.wikimedia.org/T227376) (owner: 10Aaron Schulz) [16:37:21] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [16:37:31] 10Wikimedia-Site-requests: Remove usergroup communityapps from officewiki - https://phabricator.wikimedia.org/T227680 (10Quiddity) [16:37:43] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ): Special:Block checkboxes should remember checked state - https://phabricator.wikimedia.org/T221117 (10JJMC89) [16:38:07] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [16:38:20] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/521629 (owner: 10Jforrester) [16:38:26] (03PS1) 10Ladsgroup: Move unit tests to the new structure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521898 [16:39:31] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/521766 (owner: 10Jforrester) [16:39:34] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/521784 (owner: 10Jforrester) [16:39:36] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/521783 (owner: 10Jforrester) [16:39:40] (03PS3) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [16:41:47] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/521589 (owner: 10Jforrester) [16:41:49] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 and make pass [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/521686 (owner: 10Jforrester) [16:41:51] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [16:41:53] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/521692 (owner: 10Jforrester) [16:41:55] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [16:41:57] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/521720 (owner: 10Jforrester) [16:41:59] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DoubleWiki] - 10https://gerrit.wikimedia.org/r/521625 (owner: 10Jforrester) [16:42:17] (03CR) 10Kosta Harlan: "Unsetting all globals causes issues, e.g. https://integration.wikimedia.org/ci/job/mwext-codehealth-patch/1434/console "12:36:53 Notice: U" [core] - 10https://gerrit.wikimedia.org/r/521268 (https://phabricator.wikimedia.org/T87781) (owner: 10Ladsgroup) [16:42:52] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-July-September): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10dr0ptp4kt) @diego @Pginer-WMF thanks for the earlier replies on this task. I had some annual planning and vacation stuff that drew... [16:43:39] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [16:44:08] (03CR) 10Krinkle: [C: 03+2] "Yep, there's no need for these to be in the autoloader. I believe there is (or was?) a separate autoloader for non-TestCase classes that a" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/521890 (owner: 10Ladsgroup) [16:44:36] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/521708 (owner: 10Jforrester) [16:45:26] (03CR) 10jerkins-bot: [V: 04-1] Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [16:45:52] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [16:45:54] 10Space (Jul-Sep-2019): Make author's biography visible on the blogposts they publish - https://phabricator.wikimedia.org/T227551 (10CKoerner_WMF) I've added a plugin to provide this capability. Let's see how well it works for our needs. I've added a bio to my own profile. You can see an example of this workin... [16:45:57] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/521606 (owner: 10Jforrester) [16:46:14] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [16:47:28] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [16:48:31] (03CR) 10Krinkle: [C: 03+2] Replace old URLs in SampleTest [core] - 10https://gerrit.wikimedia.org/r/512671 (owner: 10Tchanders) [16:49:46] (03PS1) 10Ladsgroup: Make RouterTest extend MediawikiUnitTestCase and not integration [core] - 10https://gerrit.wikimedia.org/r/521899 [16:49:48] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [16:49:52] 10MediaWiki-Database, 10Performance-Team: Announce or revert ResultWrapper iteration change - https://phabricator.wikimedia.org/T227665 (10Krinkle) [16:50:20] (03CR) 10Ladsgroup: "All tests pass for me without this patch :/ That's weird" [core] - 10https://gerrit.wikimedia.org/r/521896 (owner: 10Kosta Harlan) [16:51:18] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (10sbassett) **Update:** Comment and +1 added to [[ https://gerrit.wikimedia.org/r/519974 | r519974 ]]. Still having a lo... [16:52:48] (03PS20) 10Niedzielski: New: add user menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/519126 (https://phabricator.wikimedia.org/T214540) [16:52:50] (03PS5) 10Niedzielski: [UI] reduce icon sizes to 54px [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521558 (https://phabricator.wikimedia.org/T214540) [16:52:52] (03CR) 10Niedzielski: [C: 04-1] [UI] reduce icon sizes to 54px [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521558 (https://phabricator.wikimedia.org/T214540) (owner: 10Niedzielski) [16:53:14] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/521661 (owner: 10Jforrester) [16:53:19] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/521629 (owner: 10Jforrester) [16:53:20] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Spike: [SPIKE, 8hrs] Allow recent changes to display list items in AMC mode - https://phabricator.wikimedia.org/T224432 (10ovasileva) [16:53:37] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/521589 (owner: 10Jforrester) [16:53:39] (03PS3) 10Jforrester: build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 [16:54:25] 10MobileFrontend, 10Analytics, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Having trouble setting up MobileFrontend for development - https://phabricator.wikimedia.org/T226071 (10ovasileva) [16:55:23] (03CR) 10Jforrester: [C: 03+2] Stop autoloading test classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521897 (owner: 10Ladsgroup) [16:55:56] 10OOUI: MenuTagMultiselectWidget (allowArbitrary: false) doesn't accept non-arbitrary value when tabbed or clicked outside - https://phabricator.wikimedia.org/T227682 (10Volker_E) [16:56:59] (03Merged) 10jenkins-bot: Stop autoloading test classes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/521890 (owner: 10Ladsgroup) [16:57:41] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10Tchanders) Without JavaScript it is possible for the form to be in a state where "Editing" is unchecked but "Editing their... [16:58:41] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/521606 (owner: 10Jforrester) [16:58:43] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [16:59:21] 10MediaWiki-Cache, 10Operations, 10serviceops-radar, 10Core Platform Team (Mainstash Multi-DC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10Krinkle) Yeah, I think we need to choose between making the Stash a 1) non-ephemeral... [17:00:31] 10MediaWiki-User-management, 10Anti-Harassment: QA the no-JS experience of Partial Blocks by filing all defects in Phab - https://phabricator.wikimedia.org/T205130 (10Tchanders) With JS, a number of checkboxes become disabled depending on the block parameters entered in the form. Obviously this doesn't happen... [17:00:44] (03PS2) 10Ladsgroup: Move unit tests to the new structure [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521898 [17:02:08] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Wikimedia-production-error: BlockManager->trackBlockWithCookie triggers "Recursion detected in RequestContext::getLanguage" warning - https://phabricator.wikimedia.org/T226777 (10Krinkle) It'll roll out with the train tomorrow, but generall... [17:02:21] (03Merged) 10jenkins-bot: Replace old URLs in SampleTest [core] - 10https://gerrit.wikimedia.org/r/512671 (owner: 10Tchanders) [17:02:29] (03PS7) 10Ladsgroup: Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 [17:03:02] 10Wikimedia Design Style Guide: standardize use of italic/oblique property for non-latin-script alphabets - https://phabricator.wikimedia.org/T227683 (10Cntlsn) [17:03:11] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Jade] - 10https://gerrit.wikimedia.org/r/521664 (owner: 10Jforrester) [17:03:25] (03CR) 10Krinkle: Factor out all the extract production into a service (031 comment) [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/519779 (owner: 10MaxSem) [17:03:30] 10Phabricator: Call to undefined method PhutilDOMNode::newRawString() when opening ticket in Phabricator - https://phabricator.wikimedia.org/T227684 (10beleg_tal) [17:04:23] 10PageCuration, 10Community-Tech (Kanban (Q1 2019-20)): 'Potential Issues' from ORES should be flagged in Page Curation Toolbar Page Info flyout - https://phabricator.wikimedia.org/T207847 (10MusikAnimal) a:05MusikAnimal→03None [17:04:59] (03CR) 10jenkins-bot: Replace old URLs in SampleTest [core] - 10https://gerrit.wikimedia.org/r/512671 (owner: 10Tchanders) [17:05:01] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/521611 (owner: 10Jforrester) [17:06:14] 10MinervaNeue, 10Page-Issue-Warnings, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Technical-Debt: Update page issues folder structure - https://phabricator.wikimedia.org/T212944 (10Niedzielski) a:03Niedzielski [17:06:53] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/521661 (owner: 10Jforrester) [17:06:58] (03CR) 10jenkins-bot: Stop autoloading test classes [extensions/Echo] - 10https://gerrit.wikimedia.org/r/521890 (owner: 10Ladsgroup) [17:08:18] 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Not possible to configure Minerva main menu to use Special:RandomRoot instead of Special:Random - https://phabricator.wikimedia.org/T188697 (10ovasileva) a:03Edtadros [17:08:22] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Elastica] - 10https://gerrit.wikimedia.org/r/521629 (owner: 10Jforrester) [17:08:30] (03CR) 10Tpt: [C: 03+2] Add phan [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/499802 (https://phabricator.wikimedia.org/T224758) (owner: 10Daimona Eaytoy) [17:09:11] (03CR) 10Krinkle: Stop using wfDebugLog in LocalisationCache (032 comments) [core] - 10https://gerrit.wikimedia.org/r/521468 (owner: 10Ladsgroup) [17:09:12] 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Minerva: Add support for SkinAfterContent hook - https://phabricator.wikimedia.org/T226143 (10pmiazga) Waiting for 1.34.0-wmf.13 available everywhere. [17:10:02] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 (owner: 10Jforrester) [17:11:04] 10MediaWiki-History-and-Diffs, 10MediaWiki-User-management, 10Core Platform Team (Revision Storage Schema Improvements): action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addresses - https://phabricator.wikimedia.org/T227656 (10Jdforrester-WMF) I assume this is rela... [17:11:53] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [17:12:24] (03Merged) 10jenkins-bot: Stop autoloading test classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521897 (owner: 10Ladsgroup) [17:12:46] (03PS3) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [17:14:23] (03PS3) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [17:14:27] (03Merged) 10jenkins-bot: Add phan [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/499802 (https://phabricator.wikimedia.org/T224758) (owner: 10Daimona Eaytoy) [17:14:36] (03CR) 10Daimona Eaytoy: "> Dunno if this is genuine, but I think it *could* help to avoid" [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [17:14:45] 10Growth Design, 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: discovery of homepage after account creation (mobile) - https://phabricator.wikimedia.org/T224883 (10Cntlsn) a:05Cntlsn→03MMiller_WMF [17:16:05] (03CR) 10Kosta Harlan: [C: 03+2] Make RouterTest extend MediawikiUnitTestCase and not integration [core] - 10https://gerrit.wikimedia.org/r/521899 (owner: 10Ladsgroup) [17:16:15] 10Growth Design, 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, and 2 others: Homepage: homepage discovery for no-JS users - https://phabricator.wikimedia.org/T225318 (10Cntlsn) a:05Cntlsn→03MMiller_WMF [17:16:19] 10UI-Standardization, 10RelatedArticles, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): "article" icons need to be updated in Related Articles mobile view - https://phabricator.wikimedia.org/T222717 (10Jdlrobson) Looks like this got merged ages ago, i... [17:16:22] 10UI-Standardization, 10RelatedArticles, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): "article" icons need to be updated in Related Articles mobile view - https://phabricator.wikimedia.org/T222717 (10Jdlrobson) a:03alexhollender [17:16:26] 10Product-Analytics, 10Patch-For-Review, 10VisualEditor (Current work): VE mobile default: A/B test post-deployment data checks - https://phabricator.wikimedia.org/T221197 (10Neil_P._Quinn_WMF) >>! In T221197#5319337, @Neil_P._Quinn_WMF wrote: > In the `default-visual` bucket, a lot fewer sessions reach `rea... [17:16:29] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10I18n, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Homepage: mobile start preview word length issues - https://phabricator.wikimedia.org/T227109 (10Cntlsn) [17:16:43] (03CR) 10jerkins-bot: [V: 04-1] Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 (owner: 10Ladsgroup) [17:17:10] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [17:17:21] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/timeline] - 10https://gerrit.wikimedia.org/r/521770 (owner: 10Jforrester) [17:17:31] (03CR) 10jenkins-bot: Add phan [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/499802 (https://phabricator.wikimedia.org/T224758) (owner: 10Daimona Eaytoy) [17:18:38] (03PS4) 10Jforrester: build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 [17:18:59] 10Growth Design, 10GrowthExperiments- HelpModule, 10GrowthExperiments- MentorshipModule, 10GrowthExperiments-Help panel, and 5 others: Homepage and help panel: identify when a question has been responded to - https://phabricator.wikimedia.org/T220753 (10Cntlsn) a:05Cntlsn→03MMiller_WMF [17:19:01] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/521676 (owner: 10Jforrester) [17:19:24] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [17:19:41] 10Phabricator: Call to undefined method PhutilDOMNode::newRawString() when opening ticket in Phabricator - https://phabricator.wikimedia.org/T227684 (10JJMC89) [17:20:15] 10OOUI: Audit probably incorrect uses of .scrollLeft (bad scrolling-related operations in RTL) - https://phabricator.wikimedia.org/T158708 (10Jdforrester-WMF) [17:20:26] 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10OOUI (OOUI-0.33.2), 10Regression: Adding icons to dialog actions results in wrong padding - https://phabricator.wikimedia.org/T226780 (10Jdforrester-WMF) [17:20:38] 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10OOUI (OOUI-0.33.2): Dialog title is neither centered nor left-aligned on mobile - https://phabricator.wikimedia.org/T227040 (10Jdforrester-WMF) [17:21:35] 10Documentation, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10OOUI (OOUI-0.33.2): MenuSelectWidget width config - https://phabricator.wikimedia.org/T227275 (10Jdforrester-WMF) 05Open→03Resolved a:03matmarex [17:21:39] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10RhinosF1) >>! In T227199#5321559, @Tchanders wrote: > Without JavaScript it is possible for the form to be in a state wher... [17:21:40] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/521644 (owner: 10Jforrester) [17:23:50] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10RhinosF1) {F29732455} {F29732454} [17:23:52] (03CR) 10jenkins-bot: Stop autoloading test classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/521897 (owner: 10Ladsgroup) [17:24:15] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [17:26:21] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/521604 (owner: 10Jforrester) [17:27:39] 10OOUI: MenuTagMultiselectWidget (allowArbitrary: false) doesn't accept non-arbitrary value when tabbed or clicked outside - https://phabricator.wikimedia.org/T227682 (10matmarex) If you enter 'jkl', it accepts it. There must be some confusion between items' labels and data. [17:28:39] (03Merged) 10jenkins-bot: Make RouterTest extend MediawikiUnitTestCase and not integration [core] - 10https://gerrit.wikimedia.org/r/521899 (owner: 10Ladsgroup) [17:28:42] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [17:29:49] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Krinkle) [17:30:01] (03PS2) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:31:03] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/521691 (owner: 10Jforrester) [17:31:54] (03PS4) 10Jack Phoenix: Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 [17:32:15] (03PS1) 10Anomie: Linker: Fix incorrect test added in Ib9816d8b [core] - 10https://gerrit.wikimedia.org/r/521907 (https://phabricator.wikimedia.org/T227656) [17:32:48] (03CR) 10Anomie: Check for valid user info before calling Linker::userLink() in Linker::revUserTools() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516440 (https://phabricator.wikimedia.org/T224368) (owner: 10BPirkle) [17:33:24] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Low bottom sheet popup on tablet when adding/translating/editing image captions - https://phabricator.wikimedia.org/T227690 (10ABorbaWMF) [17:33:26] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/521676 (owner: 10Jforrester) [17:33:34] (03CR) 10Jforrester: [C: 03+2] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/521644 (owner: 10Jforrester) [17:34:01] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Bottom sheet popup for adding/translating/editing image captions - https://phabricator.wikimedia.org/T223130 (10ABorbaWMF) Looks good to me. Tracking the issue with tablets here: T227690 [17:34:06] (03PS1) 10Kosta Harlan: PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) [17:34:45] (03CR) 10jerkins-bot: [V: 04-1] Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 (owner: 10Jack Phoenix) [17:35:16] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/521735 (owner: 10Jforrester) [17:36:36] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:36:49] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Unit & Int & System Tooling), 10Release-Engineering-Team-TODO (201907), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10Addshore) [17:36:52] (03PS3) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:36:53] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10Krinkle) [17:37:13] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10Krinkle) > * Only seen from PHP 7.2 processes. Ping T219148. [17:38:54] (03CR) 10jerkins-bot: [V: 04-1] PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:39:01] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:40:40] (03CR) 10Krinkle: PHPUnit bootstrap: less aggressive unsetting of globals (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:40:51] (03CR) 10Krinkle: "oops :) Nice catch. Didnt' realise it would affect superglobals." [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:40:59] (03CR) 10Jforrester: [C: 03+2] "We should have a test ensuring this behaviour doesn't regress." [core] - 10https://gerrit.wikimedia.org/r/521907 (https://phabricator.wikimedia.org/T227656) (owner: 10Anomie) [17:41:15] (03CR) 10jenkins-bot: Make RouterTest extend MediawikiUnitTestCase and not integration [core] - 10https://gerrit.wikimedia.org/r/521899 (owner: 10Ladsgroup) [17:41:33] (03PS4) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:42:01] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1): Bug: Order of some paragraphs is flipped on mobile - https://phabricator.wikimedia.org/T201131 (10Jdlrobson) [17:42:23] (03PS1) 10Kosta Harlan: Tests: Assert that integration tests are not in unit test directory [core] - 10https://gerrit.wikimedia.org/r/521909 (https://phabricator.wikimedia.org/T87781) [17:42:52] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Send mentor's gender to growthexperiments-tour-mentor-response-tip-personal-text message - https://phabricator.wikimedia.org/T227289 (10Jdforrester-WMF) [17:43:33] (03CR) 10jerkins-bot: [V: 04-1] PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:43:37] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10greg) Given "Affecting both 1.34-wmf.11 and 1.34-wmf.13." can we move forward with the train without... [17:44:34] 10MediaWiki-History-and-Diffs, 10MediaWiki-User-management, 10Core Platform Team (Revision Storage Schema Improvements), 10Patch-For-Review: action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addresses - https://phabricator.wikimedia.org/T227656 (10Urbanecm) [17:45:26] 10MediaWiki-History-and-Diffs, 10Security: Rolling back a revision with (username removed) exposes removed IP - https://phabricator.wikimedia.org/T227151 (10Urbanecm) This doesn't need to stay private - not a security bug. [17:45:31] 10MediaWiki-History-and-Diffs, 10Security: Rolling back a revision with (username removed) exposes removed IP - https://phabricator.wikimedia.org/T227151 (10Urbanecm) [17:45:49] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10greg) @Krinkle I can't see the errors in logstash (maybe just because we're only on group0 with wmf.13?),... [17:46:17] (03CR) 10jerkins-bot: [V: 04-1] PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:47:13] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/521676 (owner: 10Jforrester) [17:47:15] (03Merged) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/521644 (owner: 10Jforrester) [17:47:29] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [17:47:45] 10Product-Analytics: Calculate and report readers health metrics for June 2019 - https://phabricator.wikimedia.org/T225488 (10MNeisler) Calculations for June 2019 complete. I've added my notes/analysis to the [[ https://docs.google.com/presentation/d/1D_MuQ4Cf23Agn1o_ausJtH5rrJysqtGIYzmK8xxEX7M/edit#slide=id.g57... [17:48:08] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10greg) Got it: https://logstash.wikimedia.org/goto/d11569bd468085431327400e8ff9db1d 4 of them on mw.org to... [17:48:33] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (10DStrine) Thanks so much. I understand having to balance priorities. CentralNotice had a few vulnerabilities that were f... [17:48:36] (03PS2) 10Kosta Harlan: PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) [17:48:50] 10OOUI, 10Patch-For-Review: Replace `em` based sizing in favor of `px` based where applicable - https://phabricator.wikimedia.org/T220671 (10Volker_E) >>! In T220671#5292614, @Esanders wrote: > That's only a problem if you have to mix your ems with px. If you do everything in ems then everything will just scal... [17:49:14] (03CR) 10Dmaza: [C: 03+2] Tidy up conditions for applying a block from a cookie [core] - 10https://gerrit.wikimedia.org/r/519254 (owner: 10Tchanders) [17:49:22] (03CR) 10jenkins-bot: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/521644 (owner: 10Jforrester) [17:49:54] 10Product-Analytics: Calculate and report readers health metrics for July 2019 - https://phabricator.wikimedia.org/T227694 (10MNeisler) [17:50:18] 10Product-Analytics: Calculate and report readers health metrics for July 2019 - https://phabricator.wikimedia.org/T227694 (10MNeisler) [17:50:40] 10OOUI, 10Patch-For-Review: Replace `em` based sizing in favor of `px` based where applicable - https://phabricator.wikimedia.org/T220671 (10Volker_E) [17:50:46] 10Product-Analytics: Calculate and report readers health metrics for June 2019 - https://phabricator.wikimedia.org/T225488 (10MNeisler) [17:52:12] (03PS3) 10Kosta Harlan: PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) [17:53:07] (03PS1) 10Krinkle: Remove fixJobQueueExplosion.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/521911 [17:53:28] (03CR) 10Jforrester: [C: 03+2] Fix a crash with the literal 'class' [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/521838 (owner: 10Daimona Eaytoy) [17:53:50] (03Merged) 10jenkins-bot: Linker: Fix incorrect test added in Ib9816d8b [core] - 10https://gerrit.wikimedia.org/r/521907 (https://phabricator.wikimedia.org/T227656) (owner: 10Anomie) [17:54:07] 10MediaWiki-Installer, 10Performance-Team, 10Technical-Debt: Remove and parser functions from MW installer parser - https://phabricator.wikimedia.org/T227297 (10Krinkle) (There's a few more `` uses to be fixed before it can be removed entirely from the Installer.) [17:54:16] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Re-create automatic browser tests on node selenium - https://phabricator.wikimedia.org/T223634 (10Jdforrester-WMF) [17:54:59] (03Merged) 10jenkins-bot: Fix a crash with the literal 'class' [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/521838 (owner: 10Daimona Eaytoy) [17:55:35] (03CR) 10Kosta Harlan: "This would catch e.g. the RouterTest that was fixed in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/521899" [core] - 10https://gerrit.wikimedia.org/r/521909 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [17:55:58] 10Space (Jul-Sep-2019): Make author's biography visible on the blogposts they publish - https://phabricator.wikimedia.org/T227551 (10hdothiduc) Cool! I think it looks nice! Would links be just the standard blue without underline? I think when there is no bio, it looks weird: https://space.wmflabs.org/2019/07/... [17:56:05] (03PS1) 10Jforrester: Linker: Fix incorrect test added in Ib9816d8b [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521912 (https://phabricator.wikimedia.org/T227656) [17:56:12] (03CR) 10Jforrester: [C: 03+2] Linker: Fix incorrect test added in Ib9816d8b [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521912 (https://phabricator.wikimedia.org/T227656) (owner: 10Jforrester) [17:56:24] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata: Lua functions do not resolve redirects - https://phabricator.wikimedia.org/T157868 (10Mike_Peel) p:05Normal→03High We've just come across this issue on Commons, see discussion at https://commons.wikimedia.org/w/index.php?title=Template_ta... [17:56:57] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: hierarchical analysis - https://phabricator.wikimedia.org/T227239 (10nettrom_WMF) I've completed gathering data for this analysis using the 2019-06 MediaWiki history snapshot. Moving it to "In Progress" as I'll start doing the actual analysis. [17:57:58] (03PS1) 10Jforrester: Drop stil/gd-text, ZeroBanner no longer needs it [vendor] - 10https://gerrit.wikimedia.org/r/521914 (https://phabricator.wikimedia.org/T215745) [17:59:44] (03PS5) 10Jack Phoenix: Version 2.2: OOUI-ful live preview JS + shim API module for exposing the list of themes per each skin [extensions/Theme] - 10https://gerrit.wikimedia.org/r/521799 [18:02:22] (03PS5) 10Daimona Eaytoy: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [18:02:41] (03Merged) 10jenkins-bot: Tidy up conditions for applying a block from a cookie [core] - 10https://gerrit.wikimedia.org/r/519254 (owner: 10Tchanders) [18:02:43] (03CR) 10Nray: "this is still WIP, but any feedback could be helpful. I need to figure out the test failures and write a more descriptive commit msg" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) (owner: 10Nray) [18:02:49] (03Merged) 10jenkins-bot: Pass in ServiceOptions to BlockManager [core] - 10https://gerrit.wikimedia.org/r/519255 (owner: 10Tchanders) [18:03:10] (03CR) 10Daimona Eaytoy: "The remaining two issues seem false positives, but I'll investigate" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [18:05:58] (03CR) 10jenkins-bot: Linker: Fix incorrect test added in Ib9816d8b [core] - 10https://gerrit.wikimedia.org/r/521907 (https://phabricator.wikimedia.org/T227656) (owner: 10Anomie) [18:07:43] (03CR) 10Jforrester: [C: 03+2] Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) (owner: 10Daimona Eaytoy) [18:08:00] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/521640 (owner: 10Jforrester) [18:08:53] (03PS1) 10Daimona Eaytoy: Merge remote-tracking branch 'origin/2.x' [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/521919 [18:09:05] (03Merged) 10jenkins-bot: Linker: Fix incorrect test added in Ib9816d8b [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521912 (https://phabricator.wikimedia.org/T227656) (owner: 10Jforrester) [18:09:40] (03PS1) 10Hoo man: LoadBalancer::getConnectionIndex: Also fallback to generic group [core] - 10https://gerrit.wikimedia.org/r/521920 (https://phabricator.wikimedia.org/T221917) [18:10:11] 10MediaWiki-Recent-changes, 10Growth-Team, 10Wikidata, 10Wikidata-Campsite, 10UX-Debt: Wikidata changes and categorization changes are in Special:RecentChanges even not enabled in preferences - https://phabricator.wikimedia.org/T224426 (10JTannerWMF) The #growth-team will revisit this task sometime this... [18:10:22] 10MediaWiki-extensions-WikibaseRepository, 10ConfirmEdit (CAPTCHA extension), 10Wikidata: allow showing captchas on Wikibase items and properties - https://phabricator.wikimedia.org/T87854 (10Lydia_Pintscher) [18:10:34] (03CR) 10Daimona Eaytoy: [C: 03+2] "Everything was already reviewed in 2.x" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/521919 (owner: 10Daimona Eaytoy) [18:10:41] 10MediaWiki-extensions-WikibaseRepository, 10Multimedia, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Wikidata: Creating a Commons gallery page incorrectly states "This entity does not exist." - https://phabricator.wikimedia.org/T227699 (10Krinkle) [18:10:44] 10MediaWiki-extensions-WikibaseRepository, 10Multimedia, 10StructuredDataOnCommons, 10WikibaseMediaInfo, 10Wikidata: Creating a Commons gallery page incorrectly states "This entity does not exist." - https://phabricator.wikimedia.org/T227699 (10Krinkle) [18:10:51] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10Tchanders) @RhinosF1 Thanks for the screenshots. It looks like the site is using 1.33.0 (https://publictestwiki.com/wiki/S... [18:11:42] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: link from Special:Contributions (desktop) - https://phabricator.wikimedia.org/T225328 (10kostajh) @Cntlsn on my 24" monitor, the centered text looks a little weir... [18:11:57] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/2.x' [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/521919 (owner: 10Daimona Eaytoy) [18:12:25] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Basic support for units in quantity datatype - https://phabricator.wikimedia.org/T65722 (10Lydia_Pintscher) [18:12:28] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata, 10Story, 10patch-welcome: [Story] create demo infoboxes - https://phabricator.wikimedia.org/T76229 (10Lydia_Pintscher) [18:12:59] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Tgr) {dd6b940} would be the obvious culprit as it added a `__get()` magic method to User, but the timing d... [18:13:09] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] JSON should (optionally) contain full URIs for referenced external entities - https://phabricator.wikimedia.org/T73992 (10Lydia_Pintscher) [18:13:59] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata, 10Story: [Story] Useful empty state of item and property - https://phabricator.wikimedia.org/T76243 (10Lydia_Pintscher) [18:14:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] allow editing of more languages in the in other languages box than the ones defined via babel boxes - https://phabricator.wikimedia.org/T92759 (10Lydia_Pintscher) [18:15:07] 10MediaWiki-Internationalization, 10Core Platform Team, 10Wikimedia-production-error: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link" - https://phabricator.wikimedia.org/T227700 (10Krinkle) [18:15:40] 10MediaWiki-extensions-WikibaseRepository, 10Outreach-Programs-Projects, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] Adding new datatypes to Wikidata (tracking) - https://phabricator.wikimedia.org/T91505 (10Lydia_Pintscher) [18:15:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Task] Allow to inject new datatypes in javascript - https://phabricator.wikimedia.org/T125771 (10Lydia_Pintscher) [18:16:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review: [Task] Create central registry for datatypes - https://phabricator.wikimedia.org/T104329 (10Lydia_Pintscher) [18:16:07] 10phan-taint-check-plugin: Release taint-check 2.0.2 and 2.1.0 - https://phabricator.wikimedia.org/T227406 (10Daimona) Version 2.0.2 [[https://gerrit.wikimedia.org/g/mediawiki/tools/phan/SecurityCheckPlugin/+/refs/tags/2.0.2|tagged]] just now. It includes the 5 patches mentioned in the task description. Next ste... [18:16:59] (03CR) 10jenkins-bot: Tidy up conditions for applying a block from a cookie [core] - 10https://gerrit.wikimedia.org/r/519254 (owner: 10Tchanders) [18:17:14] 10MediaWiki-History-and-Diffs, 10MediaWiki-User-management, 10Core Platform Team (Revision Storage Schema Improvements), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): action=history shows "username removed" for anonymous editors on mediawiki.org instead of IP addres... - https://phabricator.wikimedia.org/T227656 [18:17:36] 10MediaWiki-extensions-WikibaseRepository, 10Outreach-Programs-Projects, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] Adding new datatypes to Wikidata (tracking) - https://phabricator.wikimedia.org/T91505 (10Lydia_Pintscher) [18:18:15] 10GrowthExperiments- HelpModule, 10GrowthExperiments- MentorshipModule, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, and 3 others: Homepage: "ask a question" dialog and overlay issues - https://phabricator.wikimedia.org/T225669 (10Catrope) Ugh, it looks like there were more OOUI changes in... [18:20:51] 10GrowthExperiments- HelpModule, 10GrowthExperiments- MentorshipModule, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, and 3 others: Homepage: "ask a question" dialog and overlay issues - https://phabricator.wikimedia.org/T225669 (10Jdforrester-WMF) >>! In T225669#5322050, @Catrope wrote: >... [18:21:59] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Tgr) Oh wait, no train last week due to July 4. It does match then. I guess this is a PHP bug of sorts? I... [18:22:16] (03Merged) 10jenkins-bot: Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) (owner: 10Daimona Eaytoy) [18:22:28] (03PS2) 10Hoo man: LoadBalancer::getConnectionIndex: Also fallback to generic group [core] - 10https://gerrit.wikimedia.org/r/521920 (https://phabricator.wikimedia.org/T221917) [18:25:31] 10MediaWiki-Special-pages, 10MediaWiki-extensions-Translate, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10User-DannyS712: Move special pages added by translate extension to separate section in Special:SpecialPages - https://phabricator.wikimedia.org/T227393 (10Nikerabbit) 05Open→03Resolved [18:26:47] (03CR) 10Hoo man: "Tested this on beta." [core] - 10https://gerrit.wikimedia.org/r/521920 (https://phabricator.wikimedia.org/T221917) (owner: 10Hoo man) [18:27:57] (03CR) 10Jforrester: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) (owner: 10Daimona Eaytoy) [18:28:34] 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10phan: Add phan to Flow extension - https://phabricator.wikimedia.org/T224759 (10Jdforrester-WMF) 05Open→03Resolved [18:29:38] (03CR) 10Dbarratt: [C: 03+1] "I haven't tested this, but looks good to me!" [core] - 10https://gerrit.wikimedia.org/r/520479 (https://phabricator.wikimedia.org/T212326) (owner: 10Tchanders) [18:29:42] (03CR) 10jenkins-bot: Pass in ServiceOptions to BlockManager [core] - 10https://gerrit.wikimedia.org/r/519255 (owner: 10Tchanders) [18:30:18] 10MediaWiki-extensions-ORES, 10Growth-Team, 10ORES, 10Scoring-platform-team: Why are there three Q-marks (???) in threshholds in Special:ORESModels? - https://phabricator.wikimedia.org/T221870 (10JTannerWMF) THe #growth-team is moving this to external for the Scoring Platform team [18:31:02] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Re-create automatic browser tests on node selenium - https://phabricator.wikimedia.org/T223634 (10AndyRussG) @Jdforrester-WMF Thanks!!! [18:32:19] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Install Cassandra table properties Debian package on Cassandra hosts - https://phabricator.wikimedia.org/T226553 (10WDoranWMF) [18:33:10] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10WDoranWMF) [18:34:56] (03CR) 10jenkins-bot: Add phan [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495966 (https://phabricator.wikimedia.org/T224759) (owner: 10Daimona Eaytoy) [18:38:56] 10MediaWiki-extensions-OAuth, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Tgr) >>! In T227688#5322066, @Tgr wrote: > I guess this is a PHP bug of sorts? PHP devs seem to disagree,... [18:39:03] 10Space (Jul-Sep-2019): Make author's biography visible on the blogposts they publish - https://phabricator.wikimedia.org/T227551 (10CKoerner_WMF) Good feedback. I can fix the issue when there is no bio. I just changed a setting. Now it won't appear if the bio is empty. [18:42:15] tgr|away: Thanks for making me laugh on T227688 :-) [18:42:15] T227688: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 [18:42:31] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata, 10Wikidata-Campsite: Lua functions do not resolve redirects - https://phabricator.wikimedia.org/T157868 (10Lydia_Pintscher) [18:44:13] (03CR) 10jenkins-bot: Linker: Fix incorrect test added in Ib9816d8b [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521912 (https://phabricator.wikimedia.org/T227656) (owner: 10Jforrester) [18:46:01] (03PS4) 10Effie Mouzeli: Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) [18:46:45] (03CR) 10Ppchelko: [C: 03+1] Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) (owner: 10Effie Mouzeli) [18:51:54] (03PS7) 10Aaron Schulz: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 [18:52:23] (03CR) 10Jforrester: [C: 03+1] PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [18:52:44] 10Core Platform Team: Make RESTBagOStuff::add() atomic - https://phabricator.wikimedia.org/T219526 (10Eevans) [18:53:19] 10Core Platform Team: Make RESTBagOStuff::add() atomic - https://phabricator.wikimedia.org/T219526 (10Eevans) p:05Triage→03Normal [18:56:02] (03PS1) 10Jforrester: Remove non-existing showRedlink optiong being passed to mw.widgets.TitleSearchWidget [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 [18:58:08] (03PS1) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) [18:58:10] (03CR) 10Jforrester: [C: 03+2] Tests: Assert that integration tests are not in unit test directory [core] - 10https://gerrit.wikimedia.org/r/521909 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [18:58:16] (03CR) 10Jforrester: [C: 03+2] Remove fixJobQueueExplosion.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/521911 (owner: 10Krinkle) [19:01:10] 10MediaWiki-Releasing, 10Core Platform Team Backlog (Later), 10Service-Architecture, 10Services (later): Distribution strategy option: Use Debian packages - https://phabricator.wikimedia.org/T88154 (10Pchelolo) 05Open→03Declined It has been decided that we are going to use docker images for service dep... [19:01:15] 10MediaWiki-Releasing, 10Parsoid, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, and 3 others: Evaluate and decide on a distribution strategy targeted at VMs - https://phabricator.wikimedia.org/T87774 (10Pchelolo) [19:01:29] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not ticked - https://phabricator.wikimedia.org/T227199 (10RhinosF1) >>! In T227199#5321999, @Tchanders wrote: > @RhinosF1 Thanks for the screenshots. It looks like the site is usin... [19:02:24] (03CR) 10jerkins-bot: [V: 04-1] Remove non-existing showRedlink optiong being passed to mw.widgets.TitleSearchWidget [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 (owner: 10Jforrester) [19:03:04] (03CR) 10Effie Mouzeli: [C: 03+2] Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) (owner: 10Effie Mouzeli) [19:03:23] (03CR) 10Effie Mouzeli: [V: 03+2 C: 03+2] Add PHP7 cookie for all hightraffic jobs to PHP7. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/521880 (https://phabricator.wikimedia.org/T219148) (owner: 10Effie Mouzeli) [19:04:58] (03PS3) 10Hoo man: LoadBalancer::getConnectionIndex: Also fallback to generic group [core] - 10https://gerrit.wikimedia.org/r/521920 (https://phabricator.wikimedia.org/T221917) [19:09:51] 10MediaWiki-Releasing, 10Parsoid, 10Release-Engineering-Team, 10Release-Engineering-Team-TODO, and 3 others: Evaluate and decide on a MediaWiki distribution strategy targeted at VMs - https://phabricator.wikimedia.org/T87774 (10Jdforrester-WMF) [19:09:55] (03CR) 10Anomie: [C: 04-1] User: support setting custom fields + array autocreation in non-existent field (034 comments) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:10:30] (03Merged) 10jenkins-bot: Tests: Assert that integration tests are not in unit test directory [core] - 10https://gerrit.wikimedia.org/r/521909 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [19:10:32] (03Merged) 10jenkins-bot: Remove fixJobQueueExplosion.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/521911 (owner: 10Krinkle) [19:10:45] (03CR) 10Krinkle: [C: 04-1] "update.php calls meetsMinimumRequirement() and returns fatal exit if !isOK()." [core] - 10https://gerrit.wikimedia.org/r/518352 (https://phabricator.wikimedia.org/T46511) (owner: 10星耀晨曦) [19:12:39] 10MediaWiki-Database, 10Performance-Team: Announce or revert ResultWrapper iteration change - https://phabricator.wikimedia.org/T227665 (10aaron) I strongly prefer 0-based. I can do the unit test part (plus grepping for iteration code). ` " [19:13:51] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10Tchanders) [19:14:45] (03PS2) 10Aaron Schulz: objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 [19:14:55] (03PS3) 10Aaron Schulz: objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 [19:15:39] (03CR) 10Krinkle: [WIP] Start using AFPData::DNONE (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478424 (https://phabricator.wikimedia.org/T204654) (owner: 10Daimona Eaytoy) [19:16:52] (03PS2) 10Jforrester: Remove non-existing showRedlink optiong being passed to mw.widgets.TitleSearchWidget [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 [19:18:15] (03PS8) 10Krinkle: [WIP] Start using AFPData::DNONE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478424 (https://phabricator.wikimedia.org/T204654) (owner: 10Daimona Eaytoy) [19:18:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Start using AFPData::DNONE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478424 (https://phabricator.wikimedia.org/T204654) (owner: 10Daimona Eaytoy) [19:18:36] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Start using AFPData::DNONE [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478424 (https://phabricator.wikimedia.org/T204654) (owner: 10Daimona Eaytoy) [19:18:40] 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10OOUI (OOUI-0.33.0), 10Patch-For-Review, 10VisualEditor (Current work): Distinguish "back" from "close" actions in OOUI dialogs - https://phabricator.wikimedia.org/T225021 (10matmarex) ping @Jdforrester-WMF @Volker_E @Esanders >>! In T225021#5298488, @matma... [19:22:15] 10ChangeProp, 10WMF-JobQueue, 10Core Platform Team (Code Health (TEC13)): Create LimitedConcurrencyKafkaConsumer - https://phabricator.wikimedia.org/T206186 (10Pchelolo) p:05Triage→03Low [19:22:30] 10GrowthExperiments, 10Growth-Team (Current Sprint): Setup Welcome Survey for Arabic Wikipedia - https://phabricator.wikimedia.org/T226221 (10MMiller_WMF) I will ask Legal to move Habib's translations to the correct location on foundation.wikimedia.org. I will let you know when it is there. [19:24:53] (03PS2) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [19:26:01] 10Design, 10Editing Design, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Improve process dialog appearance – simplify actions - https://phabricator.wikimedia.org/T226045 (10matmarex) Is this done now? [19:26:10] (03PS2) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) [19:26:34] (03PS1) 10Gergő Tisza: Do not rely on array autocreation for custom User properties [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521930 (https://phabricator.wikimedia.org/T227688) [19:26:44] (03CR) 10jerkins-bot: [V: 04-1] User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:26:45] (03CR) 10jerkins-bot: [V: 04-1] User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:26:47] (03CR) 10jerkins-bot: [V: 04-1] User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:26:51] (03CR) 10jerkins-bot: [V: 04-1] User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:26:53] (03CR) 10jenkins-bot: Tests: Assert that integration tests are not in unit test directory [core] - 10https://gerrit.wikimedia.org/r/521909 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [19:27:56] 10GrowthExperiments, 10Epic, 10Growth-Team (Current Sprint): [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Trizek-WMF) [19:29:59] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Add caption CTA on article pages - https://phabricator.wikimedia.org/T224728 (10ABorbaWMF) Looks good to me on 2.7.50282-alpha-2019-07-10 [19:30:12] (03CR) 10DannyS712: [C: 04-1] "See comment" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [19:30:37] (03CR) 10MaxSem: [C: 03+2] Drop stil/gd-text, ZeroBanner no longer needs it [vendor] - 10https://gerrit.wikimedia.org/r/521914 (https://phabricator.wikimedia.org/T215745) (owner: 10Jforrester) [19:34:57] (03CR) 10Krinkle: [C: 03+2] Do not rely on array autocreation for custom User properties [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521930 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:35:02] (03PS1) 10Krinkle: Do not rely on array autocreation for custom User properties [extensions/OAuth] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521931 (https://phabricator.wikimedia.org/T227688) [19:37:46] 10MediaWiki-extensions-OAuth, 10Patch-For-Review, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Jdforrester-WMF) a:03Tgr [19:38:15] 10MediaWiki-extensions-OAuth, 10Patch-For-Review, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Tgr) `lang=php public function __set( $name, $value ) { // A shortcut for $mRights... [19:38:24] 10MediaWiki-Special-pages, 10User-DannyS712: Add "help" link to Special:BlankPage - https://phabricator.wikimedia.org/T227705 (10DannyS712) [19:41:16] (03CR) 10Krinkle: [C: 03+2] objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 (owner: 10Aaron Schulz) [19:43:03] (03PS3) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) [19:43:43] (03CR) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field (032 comments) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:43:47] 10GlobalBlocking, 10Stewards-and-global-tools: Avoid patchwork messages (using 'comma-separator') in locally disabled block entries - https://phabricator.wikimedia.org/T68308 (10Krinkle) [19:44:01] 10GlobalBlocking, 10Stewards-and-global-tools, 10I18n: Avoid patchwork messages (using 'comma-separator') in locally disabled block entries - https://phabricator.wikimedia.org/T68308 (10Krinkle) [19:44:13] (03Merged) 10jenkins-bot: Drop stil/gd-text, ZeroBanner no longer needs it [vendor] - 10https://gerrit.wikimedia.org/r/521914 (https://phabricator.wikimedia.org/T215745) (owner: 10Jforrester) [19:44:15] (03Merged) 10jenkins-bot: Do not rely on array autocreation for custom User properties [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521930 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:46:24] (03CR) 10jenkins-bot: Do not rely on array autocreation for custom User properties [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521930 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:47:30] 10GlobalBlocking, 10Stewards-and-global-tools: Special:GlobalBlockList incorrectly says "The requested IP address is not blocked." when no filter was applied and there are no blocked IPs yet - https://phabricator.wikimedia.org/T121871 (10Krinkle) [19:49:16] 10GlobalBlocking, 10Stewards-and-global-tools: Special:GlobalBlockList incorrectly says "The requested IP address is not blocked." when no filter was applied and there are no blocked IPs yet - https://phabricator.wikimedia.org/T121871 (10Krinkle) When there are no blocks at all, and searching for one, the curr... [19:50:46] 10GlobalBlocking, 10Stewards-and-global-tools, 10Mobile: Global block screen at login doesn't parse wikitext (e.g. link syntax not working) - https://phabricator.wikimedia.org/T154421 (10Krinkle) [19:51:12] (03CR) 10Anomie: "IMO probably better to avoid unnecessary __get methods than to avoid array autocreation." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521930 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:52:06] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10EBernhardson) The error here will only block a class of secondary numerical data updates, the primary... [19:53:21] (03PS1) 10Aaron Schulz: Add ResultWrapper/FakeResultWrapper tests [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) [19:56:16] (03Merged) 10jenkins-bot: objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 (owner: 10Aaron Schulz) [19:56:28] 10MediaWiki-Installer: Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10TheDJ) User is using MariaDb. Another user just reported: > Similar problem with 1.32.x to 1.33 upgrade of migrateComments script, except on column 'pt_reason_id'. Checked MySQL schema and... [19:57:15] 10Discovery-Search (Current work): Investigate impact of folding diacritics in Slovak - https://phabricator.wikimedia.org/T223787 (10TJones) Sorry for the delay getting back to this. In addition to my planned two weeks away from the office I had another unexpected week away. I've been catching up on everything t... [19:57:16] (03PS6) 10Niedzielski: [UI] reduce toolbar and icon sizes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521558 (https://phabricator.wikimedia.org/T214540) [19:57:38] (03CR) 10Anomie: [C: 03+2] "Since T227688 is marked as a train blocker even though it's not set as UBN, let's +2 this now since it works for the immediate issue and f" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:58:27] (03CR) 10Krinkle: User: support setting custom fields + array autocreation in non-existent field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [19:58:53] (03CR) 10Anomie: [C: 04-1] "Err, maybe not. Testing something." [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:00:57] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10Tchanders) Here are some screenshots of the block notice shown on trying to edit an article on desktop, after https://ger... [20:01:02] (03CR) 10Krinkle: Add ResultWrapper/FakeResultWrapper tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [20:01:04] (03CR) 10Anomie: [C: 03+2] "It's good, I was wrong." [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:03:10] (03PS2) 10Gergő Tisza: Add ResultWrapper/FakeResultWrapper tests [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [20:03:27] 10MediaWiki-Vendor, 10Reading-Infrastructure-Team-Backlog, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Release-Engineering-Team-TODO (201907): Remove stil/gd-text from mediawiki/vendor once the Zero extensions have been undeployed - https://phabricator.wikimedia.org/T215745 (10Jdforrester-WMF) a:03Jdfo... [20:03:36] 10MediaWiki-Vendor, 10Reading-Infrastructure-Team-Backlog, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Release-Engineering-Team-TODO (201907): Remove stil/gd-text from mediawiki/vendor once the Zero extensions have been undeployed - https://phabricator.wikimedia.org/T215745 (10Jdforrester-WMF) 05Open→... [20:06:22] (03CR) 10Gergő Tisza: "Fixed some small typos in PS2." [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [20:07:35] (03PS2) 10Ankita Mandal: Modified ext.cargo.query.js. Bug: T213513 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/521184 (https://phabricator.wikimedia.org/T213513) [20:08:29] (03CR) 10jenkins-bot: objectcache: rename "slaveOnly" parameter to "replicaOnly" in SQLBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521822 (owner: 10Aaron Schulz) [20:08:46] (03PS18) 10Bartosz Dziewoński: Allow skins/extensions to define custom OOUI themes [core] - 10https://gerrit.wikimedia.org/r/343239 (https://phabricator.wikimedia.org/T100896) [20:08:56] (03PS8) 10Bartosz Dziewoński: [DO NOT MERGE] Example of defining custom OOUI theme [skins/Example] - 10https://gerrit.wikimedia.org/r/343240 (https://phabricator.wikimedia.org/T100896) [20:09:18] (03CR) 10Gergő Tisza: [C: 03+1] Add ResultWrapper/FakeResultWrapper tests [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [20:09:53] (03PS1) 10Niedzielski: [dev] move page issues tests to page-issues/ subdir [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521940 (https://phabricator.wikimedia.org/T212944) [20:09:54] 10MediaWiki-Database, 10Performance-Team, 10Patch-For-Review: Announce or revert ResultWrapper iteration change - https://phabricator.wikimedia.org/T227665 (10Tgr) Thanks @aaron! [20:10:00] (03CR) 10Bartosz Dziewoński: "Rebased. There were several conflicts with a few different changes, fairly easy to resolve:" [core] - 10https://gerrit.wikimedia.org/r/343239 (https://phabricator.wikimedia.org/T100896) (owner: 10Bartosz Dziewoński) [20:10:49] 10MediaWiki-Interface, 10OOUI (OOjs-UI-0.20.1), 10Patch-For-Review: Allow skins to use different, custom OOUI themes - https://phabricator.wikimedia.org/T100896 (10matmarex) Not really any progress. (I fixed a few merge conflicts in the patches.) [20:12:11] (03PS1) 10Niedzielski: [dev] match page issues LESS filename to JS naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521943 (https://phabricator.wikimedia.org/T212944) [20:12:43] 10MinervaNeue, 10Page-Issue-Warnings, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review, and 2 others: Update page issues folder structure - https://phabricator.wikimedia.org/T212944 (10Niedzielski) a:05Niedzielski→03None [20:12:58] 10MediaWiki-Internationalization, 10I18n: Add grammar support for Icelandic language names - https://phabricator.wikimedia.org/T227706 (10Snaevar) [20:15:09] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10Niharika) @Tchanders This looks great. Way better than what we have at the moment. Is there a possibility to link to the... [20:17:40] (03PS1) 10Catrope: WatchedItemStore: Fix fatal when revision is deleted [core] - 10https://gerrit.wikimedia.org/r/521946 (https://phabricator.wikimedia.org/T226741) [20:17:58] 10MediaWiki-Watchlist, 10Growth-Team, 10Patch-For-Review, 10Wikimedia-production-error: WatchedItemStore fatals on some logged-in pageviews: Argument to RevisionStore::getNextRevision must be RevisionRecord, null given - https://phabricator.wikimedia.org/T226741 (10Catrope) a:03Catrope [20:18:50] (03CR) 10Jforrester: [C: 03+1] WatchedItemStore: Fix fatal when revision is deleted [core] - 10https://gerrit.wikimedia.org/r/521946 (https://phabricator.wikimedia.org/T226741) (owner: 10Catrope) [20:18:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/521936 (owner: 10L10n-bot) [20:19:20] (03CR) 10jerkins-bot: [V: 04-1] [dev] move page issues tests to page-issues/ subdir [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521940 (https://phabricator.wikimedia.org/T212944) (owner: 10Niedzielski) [20:19:25] (03CR) 10jerkins-bot: [V: 04-1] [dev] match page issues LESS filename to JS naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521943 (https://phabricator.wikimedia.org/T212944) (owner: 10Niedzielski) [20:19:26] 10Research: Gather experienced editor feedback beyond EnWiki - https://phabricator.wikimedia.org/T221422 (10Capt_Swing) Findings, design implications, and research directions have been added here: https://meta.wikimedia.org/wiki/Research:Expanding_Wikipedia_articles_across_languages/Inter_language_approach#Feedb... [20:20:05] 10Design, 10Editing Design, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Improve process dialog appearance – simplify actions - https://phabricator.wikimedia.org/T226045 (10Esanders) The patch didn't switch all 'back' buttons to use an icon on desktop, which we may want to address is a future release? [20:21:56] (03PS2) 10Niedzielski: [dev] move page issues tests to page-issues/ subdir [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521940 (https://phabricator.wikimedia.org/T212944) [20:21:58] (03PS2) 10Niedzielski: [dev] match page issues LESS filename to JS naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521943 (https://phabricator.wikimedia.org/T212944) [20:22:32] 10Research: V1 report for Responsible Recommendations/Ethical AI process at WMF - https://phabricator.wikimedia.org/T212445 (10Capt_Swing) All deliverables are completed - white paper on Figshare: https://figshare.com/articles/Ethical_Human_Centered_AI/8044553 - white paper on Commons: https://commons.wikim... [20:22:49] (03PS1) 10EBernhardson: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) [20:23:49] 10Research: Iteration on recommender system bias and auditability report - https://phabricator.wikimedia.org/T206051 (10Capt_Swing) This is done, and inputs have been incorporated into T212445 [20:24:04] (03PS1) 10Snaevar: Add Grammar support for Icelandic language names. Testcases: {{grammar:accusative|íslenska}} -> íslensku {{grammar:accusative|danska}} -> dönsku {{grammar:genitive|asímál}} -> asímáls [core] - 10https://gerrit.wikimedia.org/r/521949 [20:24:06] 10Research: Gather feedback on algorithmic bias report from internal stakeholders - https://phabricator.wikimedia.org/T207515 (10Capt_Swing) This is done, and inputs have been incorporated into T212445 [20:24:33] 10Research: HostBot-AI study coordination with NotConfusing - https://phabricator.wikimedia.org/T211160 (10Capt_Swing) [20:25:03] (03CR) 10EBernhardson: "This doesn't really fix the underlying error, but it does fix the error that was directly triggered afaict. If this is correct, then the u" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [20:25:35] (03CR) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:26:58] (03CR) 10Catrope: [C: 04-1] Show edit links in Special:DisambiguationPageLinks only if user can edit (031 comment) [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/463679 (https://phabricator.wikimedia.org/T205796) (owner: 10Urbanecm) [20:27:23] (03PS2) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [20:27:31] 10Research: HostBot-AI study coordination with NotConfusing - https://phabricator.wikimedia.org/T211160 (10Capt_Swing) The [[ https://en.wikipedia.org/wiki/Wikipedia_talk:Teahouse#HostBot-AI_pilot_ending | trial has concluded ]], and @Maximilianklein will perform the analysis of the data we collected. [20:29:45] (03CR) 10Krinkle: User: support setting custom fields + array autocreation in non-existent field (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:31:39] (03CR) 10Gergő Tisza: [C: 03+2] "Reapplying Anomie's +2, looks like Gerrit got confused" [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:31:52] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Security-Team-Reviews: CentralNotice: Security review of banner preview feature - https://phabricator.wikimedia.org/T226963 (10sbassett) @DStrine @AndyRussG - ok, a few more comments with minor issues added to the other three patch sets from T226... [20:33:11] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [20:35:08] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DatabaseMysqlBase: domain schemas are not supported. - https://phabricator.wikimedia.org/T227708 (10Krinkle) [20:35:36] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DatabaseMysqlBase: domain schemas are not supported. - https://phabricator.wikimedia.org/T227708 (10Krinkle) [20:35:38] (03CR) 10Gergő Tisza: [C: 03+2] "Oh, right, Depends-On probably can't differentiate between the master and cherry-pick version of the patch. Let's get rid of it." [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:36:01] (03PS4) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) [20:36:41] 10CX-analytics, 10Product-Analytics: Measure the surviving translations by newcomers - https://phabricator.wikimedia.org/T194650 (10chelsyx) 05Open→03Resolved Thanks @Neil_P._Quinn_WMF for the review! I've pushed the code and result to github https://github.com/wikimedia-research/2018-19-Language-annual-pl... [20:36:42] 10CX-analytics, 10Product-Analytics: Measure 2018-19 annual plan metrics for the Language team - https://phabricator.wikimedia.org/T199342 (10chelsyx) [20:36:46] 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10OOUI (OOUI-0.33.1): New dialog action design doesn't work well for labelled safe actions - https://phabricator.wikimedia.org/T226822 (10Esanders) 05Resolved→03Open If the action has a 'back' flag then it doesn't get the correct styling as it assumes the messag... [20:37:00] 10Design, 10Editing Design, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review: Improve process dialog appearance – simplify actions - https://phabricator.wikimedia.org/T226045 (10Esanders) [20:37:59] (03CR) 10Gergő Tisza: [C: 03+2] User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:39:00] (03CR) 10jerkins-bot: [V: 04-1] Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [20:40:53] (03PS1) 10BPirkle: Allow separating OAuth and per-wiki session storage. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/521950 (https://phabricator.wikimedia.org/T227696) [20:41:39] 10MediaWiki-Installer, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Workboards (Done with CPT), 10User-Nikerabbit: Allow extensions to define additional command line parameters to "update.php" - https://phabricator.wikimedia.org/T213893 (10TheDJ) >>!... [20:43:52] 10MediaWiki-extensions-Translate, 10Language-Team, 10Wikimedia-production-error: PHP error from Special:ExportTranslations: "get_class() expects parameter 1 to be object, null given" - https://phabricator.wikimedia.org/T227709 (10Krinkle) [20:44:01] 10GrowthExperiments- HelpModule, 10GrowthExperiments- MentorshipModule, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, and 3 others: Homepage: "ask a question" dialog and overlay issues - https://phabricator.wikimedia.org/T225669 (10Catrope) Since it appears that it's intentional that these... [20:45:33] (03CR) 10Ladsgroup: [C: 03+2] PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [20:46:34] (03CR) 10DCausse: RedirectsAndIncomingLinks: succeede or fail, but not both (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [20:47:10] 10MediaWiki-Recent-changes, 10Growth-Team, 10good first bug: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10Catrope) >>! In T177281#5079060, @Catrope wrote: > Specifically, there are now CSS classes that are added for every tag, so you could write a CSS rule for... [20:47:33] (03CR) 10Krinkle: [C: 03+1] "The private method is only used in one place, to construct ActivityUpdateJob and its 'notifTime' option, which then uses it for $dbw->time" [core] - 10https://gerrit.wikimedia.org/r/521946 (https://phabricator.wikimedia.org/T226741) (owner: 10Catrope) [20:48:07] 10MediaWiki-Recent-changes, 10Growth-Team, 10good first bug: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10Catrope) [20:48:10] (03PS8) 10Ladsgroup: Move unit tests to the new structure [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520211 [20:49:42] (03CR) 10Ottomata: Remove CirrusSearchRequestSet code (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [20:50:53] (03PS2) 10Jforrester: Do not rely on array autocreation for custom User properties [extensions/OAuth] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521931 (https://phabricator.wikimedia.org/T227688) (owner: 10Krinkle) [20:51:02] (03PS2) 10Ottomata: Remove CirrusSearchRequestSet code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) [20:51:06] (03CR) 10Jdlrobson: [C: 03+2] "Got it! Sorry for adding more confusion! :)" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/511053 (https://phabricator.wikimedia.org/T223649) (owner: 10Simon04) [20:51:08] 10MediaWiki-extensions-OAuth, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Patch-For-Review, 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Jdforrester-WMF) p:05Triage→03Unbr... [20:51:59] 10MediaWiki-Internationalization, 10Core Platform Team, 10Wikimedia-production-error: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link" - https://phabricator.wikimedia.org/T227700 (10Jdforrester-WMF) p:05Triage→03Unbreak! [20:52:01] 10DC-Ops, 10Operations-Software-Development, 10netbox: add procurement task audit report to netbox - https://phabricator.wikimedia.org/T227710 (10RobH) p:05Triage→03Low [20:52:03] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DatabaseMysqlBase: domain schemas are not supported. - https://phabricator.wikimedia.org/T227708 (10Jdforrester-WMF) p:05Triage→03Unbreak! [20:52:05] 10MediaWiki-Internationalization, 10Core Platform Team, 10Wikimedia-production-error: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link" - https://phabricator.wikimedia.org/T227700 (10Jdforrester-WMF) [20:52:20] 10DC-Ops, 10Operations-Software-Development, 10netbox: add procurement task audit report to netbox - https://phabricator.wikimedia.org/T227710 (10RobH) I assume this is just going to be a coherence report sub-section, but whatever works for #operations-software-development works for me. [20:53:06] (03Merged) 10jenkins-bot: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [20:53:23] (03PS3) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [20:58:06] (03Merged) 10jenkins-bot: PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [20:59:59] (03PS2) 10EBernhardson: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) [21:00:26] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: bannerHistoryLogger not present when banner history mixin enabled - https://phabricator.wikimedia.org/T227711 (10Pcoombe) [21:00:40] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10Eevans) [21:01:38] (03CR) 10DCausse: [C: 03+2] RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [21:03:03] (03PS1) 10Aaron Schulz: Update $wgMainStash comments and merge in those from a deprecated ObjectCache method [core] - 10https://gerrit.wikimedia.org/r/521953 [21:03:36] (03CR) 10jenkins-bot: User: support setting custom fields + array autocreation in non-existent field [core] - 10https://gerrit.wikimedia.org/r/521928 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [21:05:24] (03CR) 10Jdlrobson: [C: 03+2] [dev] match page issues LESS filename to JS naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521943 (https://phabricator.wikimedia.org/T212944) (owner: 10Niedzielski) [21:05:42] (03CR) 10jerkins-bot: [V: 04-1] Remove CirrusSearchRequestSet code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [21:06:02] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not selected - https://phabricator.wikimedia.org/T227199 (10Niharika) [21:07:49] (03CR) 10Jdlrobson: [C: 03+1] "NITPICKS!" (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521940 (https://phabricator.wikimedia.org/T212944) (owner: 10Niedzielski) [21:08:02] (03CR) 10Catrope: [C: 03+2] build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 (owner: 10Jforrester) [21:08:16] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/521949 (owner: 10Snaevar) [21:08:17] 10MediaWiki-Cache, 10Operations, 10serviceops-radar, 10Core Platform Team (Mainstash Multi-DC), and 3 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10aaron) I think (1) is more useful and fills a needed gap of writes on GET/HEAD. What... [21:08:38] (03PS2) 10Jforrester: Add Grammar support for Icelandic language names. Testcases: {{grammar:accusative|íslenska}} -> íslensku {{grammar:accusative|danska}} -> dönsku {{grammar:genitive|asímál}} -> asímáls [core] - 10https://gerrit.wikimedia.org/r/521949 (https://phabricator.wikimedia.org/T227706) (owner: 10Snaevar) [21:08:51] (03PS2) 10Jdlrobson: Adjustments to Notification tray margins and borders [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/521777 (https://phabricator.wikimedia.org/T225260) [21:08:57] (03PS3) 10Jforrester: Add Grammar support for Icelandic language names [core] - 10https://gerrit.wikimedia.org/r/521949 (https://phabricator.wikimedia.org/T227706) (owner: 10Snaevar) [21:09:37] (03Abandoned) 10Jdlrobson: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521776 (owner: 10Jforrester) [21:09:48] (03PS2) 10Jdlrobson: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521681 (owner: 10Jforrester) [21:10:24] (03CR) 10Jforrester: "Oops, thanks." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521776 (owner: 10Jforrester) [21:10:49] (03PS4) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [21:10:51] (03CR) 10Jforrester: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521681 (owner: 10Jforrester) [21:11:05] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-2019-20-Q1), 10Technical-Debt: Identify prevalent component antipatterns in MobileFrontend - https://phabricator.wikimedia.org/T225453 (10Niedzielski) {icon thumbs-up} Thank you, @santhosh! Your persp... [21:11:06] 10Security-Team: Onboard Jennifer Cross to Security Team as Project Manager (May 24th) - https://phabricator.wikimedia.org/T225554 (10sbassett) [21:11:13] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [21:11:47] (03CR) 10Jdlrobson: [C: 03+2] Convert Page.js to ES6 class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521891 (https://phabricator.wikimedia.org/T193077) (owner: 10Nray) [21:13:18] (03PS3) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [21:13:21] 10Space (Jul-Sep-2019): Make author's biography visible on the blogposts they publish - https://phabricator.wikimedia.org/T227551 (10Qgil) Very nice! I think this will be an incentive especially for volunteers. [21:13:47] (03Merged) 10jenkins-bot: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [21:14:31] (03PS1) 10Ladsgroup: Move unit tests to the new structure [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521955 [21:14:47] (03CR) 10jenkins-bot: PHPUnit bootstrap: less aggressive unsetting of globals [core] - 10https://gerrit.wikimedia.org/r/521908 (https://phabricator.wikimedia.org/T87781) (owner: 10Kosta Harlan) [21:14:53] (03CR) 10jerkins-bot: [V: 04-1] Add Grammar support for Icelandic language names [core] - 10https://gerrit.wikimedia.org/r/521949 (https://phabricator.wikimedia.org/T227706) (owner: 10Snaevar) [21:15:19] (03PS4) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [21:17:33] (03PS1) 10Jforrester: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521956 (https://phabricator.wikimedia.org/T227691) [21:19:12] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10Eevans) [21:19:47] (03CR) 10jerkins-bot: [V: 04-1] Add Grammar support for Icelandic language names [core] - 10https://gerrit.wikimedia.org/r/521949 (https://phabricator.wikimedia.org/T227706) (owner: 10Snaevar) [21:20:48] 10OOUI, 10Documentation, 10Patch-For-Review, 10good first bug: Missing links to OOUI libraries in OOUI tutorial - https://phabricator.wikimedia.org/T211268 (10srishakatux) Looking at the tutorial again, I see that instructions to install the `oojs-ui` modules via npm is in here: https://doc.wikimedia.org/o... [21:20:54] 10Growth Design, 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: discovery of homepage after account creation (mobile) - https://phabricator.wikimedia.org/T224883 (10Catrope) >>! In T224883#5314183, @Cntlsn wrote: > Also, @Catrope... [21:23:59] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 (owner: 10Jforrester) [21:24:02] (03Merged) 10jenkins-bot: Convert Page.js to ES6 class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521891 (https://phabricator.wikimedia.org/T193077) (owner: 10Nray) [21:24:26] (03PS1) 10Gergő Tisza: User: support setting custom fields + array autocreation in non-existent field [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521957 (https://phabricator.wikimedia.org/T227688) [21:24:28] (03CR) 10Jforrester: "Hi there." [core] - 10https://gerrit.wikimedia.org/r/521949 (https://phabricator.wikimedia.org/T227706) (owner: 10Snaevar) [21:24:50] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521681 (owner: 10Jforrester) [21:24:59] (03CR) 10jenkins-bot: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521948 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [21:27:53] (03CR) 10jenkins-bot: Convert Page.js to ES6 class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521891 (https://phabricator.wikimedia.org/T193077) (owner: 10Nray) [21:28:06] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10Eevans) The task description has been updated with information on a working prototype created by @holger.knust.... [21:28:54] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521955 (owner: 10Ladsgroup) [21:29:27] (03PS1) 10EBernhardson: Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 [21:29:31] (03CR) 10jerkins-bot: [V: 04-1] Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [21:30:19] (03CR) 10Dmaza: Add support for extentions to change Special:Mute form (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520050 (https://phabricator.wikimedia.org/T220163) (owner: 10Dmaza) [21:30:38] (03PS2) 10EBernhardson: Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 [21:31:32] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10Eevans) [21:32:43] (03CR) 10EBernhardson: "does this have a ticket to reference for the new structure?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521955 (owner: 10Ladsgroup) [21:33:10] (03PS5) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [21:33:22] (03CR) 10jerkins-bot: [V: 04-1] Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [21:35:22] (03CR) 10Aaron Schulz: Add ResultWrapper/FakeResultWrapper tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [21:36:04] (03CR) 10Aaron Schulz: [C: 03+1] Add ResultWrapper/FakeResultWrapper tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521934 (https://phabricator.wikimedia.org/T227665) (owner: 10Aaron Schulz) [21:36:22] (03CR) 10Ladsgroup: "> Patch Set 1:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521955 (owner: 10Ladsgroup) [21:36:42] (03CR) 10Aaron Schulz: [C: 03+2] Allow false as return type of FileBackendStore::doGetFileXAttributes [core] - 10https://gerrit.wikimedia.org/r/517721 (owner: 10Umherirrender) [21:36:44] (03PS3) 10EBernhardson: Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 (https://phabricator.wikimedia.org/T227691) [21:37:07] (03CR) 10Krinkle: [C: 04-1] objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519768 (owner: 10Aaron Schulz) [21:37:26] (03PS9) 10Aaron Schulz: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods [core] - 10https://gerrit.wikimedia.org/r/519946 [21:37:37] (03PS5) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [21:37:52] (03PS3) 10Aaron Schulz: objectcache: clean up RedisBagOStuff and optimize changeTTLMulti() [core] - 10https://gerrit.wikimedia.org/r/520148 (https://phabricator.wikimedia.org/T113916) [21:38:02] (03PS6) 10Aaron Schulz: resourceloader: move indirect module dependency path tracking to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/519741 (https://phabricator.wikimedia.org/T113916) [21:38:05] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-phan-config to 0.6.1 [core] - 10https://gerrit.wikimedia.org/r/516326 (owner: 10Jforrester) [21:38:15] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team-TODO, 10TechCom-RFC, 10PHP 7.0 support, and 2 others: Drop PHP 7.0 support from MediaWiki - https://phabricator.wikimedia.org/T216165 (10daniel) [21:38:40] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Low bottom sheet popup on tablet when adding/translating/editing image captions - https://phabricator.wikimedia.org/T227690 (10Charlotte) Sad tablet is sad. @Dbrant @Sharvaniharan @cooltey - what would be a reasonable ETA to fix this? I'd rather not roll out... [21:38:49] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team-TODO, 10TechCom-RFC, 10PHP 7.0 support, and 2 others: Drop PHP 7.0 support from MediaWiki - https://phabricator.wikimedia.org/T216165 (10daniel) This should be an RFC since it has wide ranging implications. [21:39:05] 10Space (Jul-Sep-2019): Bootstrapping the Wikimedia Space program - https://phabricator.wikimedia.org/T226720 (10Qgil) [21:39:42] (03Abandoned) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [21:40:14] (03PS2) 10EBernhardson: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521956 (https://phabricator.wikimedia.org/T227691) (owner: 10Jforrester) [21:40:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Set .json-ld as an alias of .jsonld - https://phabricator.wikimedia.org/T227712 (10abian) [21:40:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Set .json-ld as an alias of .jsonld - https://phabricator.wikimedia.org/T227712 (10abian) [21:41:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Provide JSON-LD support for Wikidata - https://phabricator.wikimedia.org/T207168 (10abian) [21:42:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Set .json-ld as an alias of .jsonld - https://phabricator.wikimedia.org/T227712 (10abian) [21:46:36] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [21:47:40] (03PS1) 10Aaron Schulz: objectcache: remove inheritence from CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521964 [21:50:05] (03Merged) 10jenkins-bot: Allow false as return type of FileBackendStore::doGetFileXAttributes [core] - 10https://gerrit.wikimedia.org/r/517721 (owner: 10Umherirrender) [21:50:58] (03CR) 10Krinkle: [C: 03+1] objectcache: remove inheritence from CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521964 (owner: 10Aaron Schulz) [21:51:32] 10CommRel-Design, 10Space (Jul-Sep-2019): Space materials for Wikimania - https://phabricator.wikimedia.org/T227604 (10elappen-WMF) a:05elappen-WMF→03mcruzWMF [21:52:19] 10CommRel-Design, 10Space (Jul-Sep-2019): Space materials for Wikimania - https://phabricator.wikimedia.org/T227604 (10elappen-WMF) María is going to be the point person on materials and distribution of those materials at Wikimania. Elena will support. [21:53:05] (03CR) 10Krinkle: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519946 (owner: 10Aaron Schulz) [21:53:15] 10service-template-node, 10Core Platform Team (Security, stability, performance and scalability (TEC1)): Sampled logging in all services - https://phabricator.wikimedia.org/T139674 (10Pchelolo) [21:54:35] 10Space (Jul-Sep-2019): Configure Space blog to display translations when available - https://phabricator.wikimedia.org/T226757 (10Qgil) First we need a process to handle translations in the Blog, though. [21:55:42] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Low bottom sheet popup on tablet when adding/translating/editing image captions - https://phabricator.wikimedia.org/T227690 (10Dbrant) [21:55:47] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Low bottom sheet popup on tablet when adding/translating/editing image captions - https://phabricator.wikimedia.org/T227690 (10Dbrant) [21:56:05] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Low bottom sheet popup on tablet when adding/translating/editing image captions - https://phabricator.wikimedia.org/T227690 (10Dbrant) a:03Sharvaniharan [21:57:51] 10MediaWiki-Email, 10Release-Engineering-Team: [betalabs] Cannot confirm email address - confirmation never received - https://phabricator.wikimedia.org/T227714 (10Etonkovidova) [21:58:15] (03PS8) 10Aaron Schulz: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 [21:59:46] 10Space (Jul-Sep-2019): Document process for translation of Space blog - https://phabricator.wikimedia.org/T226755 (10Qgil) I think organizing translations isn't as simple. There needs to be a chain of trust assuring that the translations submitted are actually translations. Otherwise anyone could just submit Lo... [22:01:41] 10Space (Jul-Sep-2019): Add feature to convert posts to wikitext - https://phabricator.wikimedia.org/T226848 (10Qgil) I am not sure we have a clear use case for this feature to be committed in this quarter. [22:02:14] (03CR) 10jenkins-bot: Allow false as return type of FileBackendStore::doGetFileXAttributes [core] - 10https://gerrit.wikimedia.org/r/517721 (owner: 10Umherirrender) [22:02:32] 10Space: Add feature to convert posts to wikitext - https://phabricator.wikimedia.org/T226848 (10elappen-WMF) p:05Normal→03Low [22:02:54] (03PS3) 10EBernhardson: Remove CirrusSearchRequestSet code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [22:03:17] (03CR) 10Isarra: [C: 03+2] "Thanks." [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 (owner: 10Jforrester) [22:03:25] 10Space (Jul-Sep-2019): Display edits related to events and locations plugin - https://phabricator.wikimedia.org/T226779 (10elappen-WMF) p:05Normal→03Low [22:06:17] (03PS1) 10Aaron Schulz: Normalize the code style of some ResultWrapper iteration loops [core] - 10https://gerrit.wikimedia.org/r/521969 [22:06:49] 10Developer-Advocacy, 10Discourse, 10Space (Jul-Sep-2019): Discourse-MediaWiki instance needs Terms of Use - https://phabricator.wikimedia.org/T184373 (10elappen-WMF) I am finalizing the temporary Terms of Use text with Legal for Space. Once completed, I will copy it to Discourse-MediaWiki. [22:09:57] (03PS6) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [22:10:10] (03Merged) 10jenkins-bot: Remove non-existing showRedlink optiong being passed to mw.widgets.TitleSearchWidget [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 (owner: 10Jforrester) [22:11:19] (03PS1) 10Jack Phoenix: Language#truncate no longer exists in core in MW 1.33+, use truncateForVisual() instead [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/521971 (https://phabricator.wikimedia.org/T227601) [22:11:38] (03PS7) 10Nray: Move parsing responsibilities from Page.js into PageHTMLParser.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521892 (https://phabricator.wikimedia.org/T193077) [22:11:45] (03PS6) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [22:11:58] (03CR) 10Jack Phoenix: [C: 03+2] Language#truncate no longer exists in core in MW 1.33+, use truncateForVisual() instead [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/521971 (https://phabricator.wikimedia.org/T227601) (owner: 10Jack Phoenix) [22:12:27] (03CR) 10jerkins-bot: [V: 04-1] Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [22:13:13] (03CR) 10jenkins-bot: Remove non-existing showRedlink optiong being passed to mw.widgets.TitleSearchWidget [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/521927 (owner: 10Jforrester) [22:13:55] (03PS7) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [22:14:29] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [22:14:31] (03PS8) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 [22:15:23] 10Space (Jul-Sep-2019): Setup notifications for Wikimedia Space blog posts submitted for review - https://phabricator.wikimedia.org/T227525 (10Qgil) [22:15:24] 10DC-Ops, 10Operations-Software-Development, 10netbox: add procurement task audit report to netbox - https://phabricator.wikimedia.org/T227710 (10RobH) 05Open→03Declined Oh, it turns out that https://netbox.wikimedia.org/extras/reports/accounting.Accounting/ does a similar thing to check for the task in... [22:15:41] (03CR) 10Aaron Schulz: LoadBalancer::getConnectionIndex: Also fallback to generic group (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521920 (https://phabricator.wikimedia.org/T221917) (owner: 10Hoo man) [22:16:17] (03Merged) 10jenkins-bot: Language#truncate no longer exists in core in MW 1.33+, use truncateForVisual() instead [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/521971 (https://phabricator.wikimedia.org/T227601) (owner: 10Jack Phoenix) [22:17:09] (03CR) 10Krinkle: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods (032 comments) [core] - 10https://gerrit.wikimedia.org/r/519946 (owner: 10Aaron Schulz) [22:17:26] 10MediaWiki-Interface, 10OOUI (OOjs-UI-0.20.1), 10Patch-For-Review: Allow skins to use different, custom OOUI themes - https://phabricator.wikimedia.org/T100896 (10Lorentz21) a:05Daegontaven→03None [22:18:47] (03CR) 10jerkins-bot: [V: 04-1] Normalize the code style of some ResultWrapper iteration loops [core] - 10https://gerrit.wikimedia.org/r/521969 (owner: 10Aaron Schulz) [22:19:01] (03PS1) 10Aaron Schulz: Add NS_MEDIAWIKI to LinkCache::isCacheable() to help MessageBlobStore cache regeneration [core] - 10https://gerrit.wikimedia.org/r/521976 [22:19:14] (03CR) 10Krinkle: [C: 04-1] rdbms: cleanup DatabaseSqlite::lock() error handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521002 (owner: 10Aaron Schulz) [22:20:06] 10MediaWiki-Vendor, 10Reading-Infrastructure-Team-Backlog, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Release-Engineering-Team-TODO (201907): Remove stil/gd-text from mediawiki/vendor once the Zero extensions have been undeployed - https://phabricator.wikimedia.org/T215745 (10Jdforrester-WMF) [22:20:10] (03CR) 10Krinkle: Make MapCacheLRU::get() accept a default value and improve $maxAge default (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521805 (owner: 10Aaron Schulz) [22:20:22] (03CR) 10Jdlrobson: Get rid of toHtmlString and simplify overlay header construction (0320 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/521800 (owner: 10Jdlrobson) [22:20:24] (03PS2) 10Aaron Schulz: Normalize the code style of some ResultWrapper iteration loops [core] - 10https://gerrit.wikimedia.org/r/521969 [22:20:48] (03CR) 10Catrope: "> Patch Set 1: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/521946 (https://phabricator.wikimedia.org/T226741) (owner: 10Catrope) [22:21:33] (03Abandoned) 10Jdlrobson: Drop Anchor templatePartial usage in Overlays and CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482252 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [22:23:24] (03CR) 10Krinkle: objectcache: move version numbers to the main wrapper in WANObjectCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521811 (owner: 10Aaron Schulz) [22:24:41] (03CR) 10Krinkle: objectcache: move version numbers to the main wrapper in WANObjectCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521811 (owner: 10Aaron Schulz) [22:25:23] (03PS10) 10Aaron Schulz: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods [core] - 10https://gerrit.wikimedia.org/r/519946 [22:26:11] (03CR) 10Aaron Schulz: objectcache: optimize MemcachedPeclBagOStuff::*Multi() write methods (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519946 (owner: 10Aaron Schulz) [22:27:01] 10Anti-Harassment, 10Wikimedia-Takedown-Tools: Disable the `Child protection` button on Takedown Tools - https://phabricator.wikimedia.org/T227715 (10jrbs) p:05Triage→03Low [22:27:09] (03CR) 10Catrope: "OTOH, line 1041 sets the entry in the latestUpdateCache to "now" if the revision doesn't exist, but I'm not sure why that is either" [core] - 10https://gerrit.wikimedia.org/r/521946 (https://phabricator.wikimedia.org/T226741) (owner: 10Catrope) [22:27:19] 10Anti-Harassment, 10Trust-and-Safety, 10Wikimedia-Takedown-Tools: Disable the `Child protection` button on Takedown Tools - https://phabricator.wikimedia.org/T227715 (10jrbs) [22:27:22] (03CR) 10Aaron Schulz: rdbms: cleanup DatabaseSqlite::lock() error handling (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521002 (owner: 10Aaron Schulz) [22:27:30] 10Core Platform Team (Cassandra Operational ), 10Core Platform Team Workboards (Team 2): Management of Cassandra schema and keyspace/table configuration - https://phabricator.wikimedia.org/T220246 (10holger.knust) [22:28:00] (03PS3) 10Ladsgroup: Stop using wfDebugLog in LocalisationCache [core] - 10https://gerrit.wikimedia.org/r/521468 [22:28:03] (03PS2) 10Aaron Schulz: Make MapCacheLRU::get() accept a default value and improve $maxAge default [core] - 10https://gerrit.wikimedia.org/r/521805 [22:28:05] (03CR) 10Ladsgroup: Stop using wfDebugLog in LocalisationCache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/521468 (owner: 10Ladsgroup) [22:29:45] (03CR) 10EBernhardson: [C: 03+2] Remove CirrusSearchRequestSet code (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [22:35:38] 10observability: log spam from mtail 3.0.0~rc19 on wezen - https://phabricator.wikimedia.org/T225604 (10Dzahn) on cp4031 the varnish-mtail service fails to start with: 17:32 < mutante> cp4031 varnishmtail-backend[12858]: flag provided but not defined: -logfds This seems to be due to the latest update. Unsure... [22:38:44] 10MediaWiki-extensions-WikibaseRepository, 10Discovery, 10Wikidata, 10Wikidata-Query-Service, and 3 others: Whether a data type should be treated as a reference type in RDF should be defined in WikibaseRepo.datatypes.php - https://phabricator.wikimedia.org/T161991 (10Smalyshev) [22:40:40] (03CR) 10Jforrester: [C: 03+2] User: support setting custom fields + array autocreation in non-existent field [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521957 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [22:40:44] (03CR) 10Jforrester: [C: 03+2] Do not rely on array autocreation for custom User properties [extensions/OAuth] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521931 (https://phabricator.wikimedia.org/T227688) (owner: 10Krinkle) [22:40:51] (03CR) 10Jforrester: [C: 03+2] RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521956 (https://phabricator.wikimedia.org/T227691) (owner: 10Jforrester) [22:42:16] (03Merged) 10jenkins-bot: Remove CirrusSearchRequestSet code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [22:45:50] 10Wikimedia-Site-requests: Turn off mobile main page special casing - https://phabricator.wikimedia.org/T227719 (10Tacsipacsi) [22:47:40] 10CirrusSearch, 10Discovery-Search, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16), 10Patch-For-Review, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10Jdforrester-WMF) a:03EBernhards... [22:50:51] 10MediaWiki-Installer: Update.php failure when upgrading from 1.32.1 to 1.33 - https://phabricator.wikimedia.org/T227662 (10Bttfvgo) I have the same problem. Using MySQL. Used to use MW 1.29, then 1.30. Switched to 1.32 two weeks ago and tried switching to 1.33 today when I ran into the same error. I don't h... [22:52:06] (03Merged) 10jenkins-bot: User: support setting custom fields + array autocreation in non-existent field [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521957 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [22:52:08] (03Merged) 10jenkins-bot: Do not rely on array autocreation for custom User properties [extensions/OAuth] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521931 (https://phabricator.wikimedia.org/T227688) (owner: 10Krinkle) [22:52:43] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team-TODO, 10TechCom-RFC, 10PHP 7.0 support, and 2 others: Drop PHP 7.0 support from MediaWiki - https://phabricator.wikimedia.org/T216165 (10Jdforrester-WMF) >>! In T216165#5322563, @daniel wrote: > This should be an RFC since it has wide ranging impli... [22:54:00] (03CR) 10jenkins-bot: Remove CirrusSearchRequestSet code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/519010 (https://phabricator.wikimedia.org/T226436) (owner: 10Ottomata) [22:55:36] (03Merged) 10jenkins-bot: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521956 (https://phabricator.wikimedia.org/T227691) (owner: 10Jforrester) [22:55:52] (03CR) 10jenkins-bot: Do not rely on array autocreation for custom User properties [extensions/OAuth] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521931 (https://phabricator.wikimedia.org/T227688) (owner: 10Krinkle) [22:59:23] (03PS1) 10Jack Phoenix: [DNM][WIP?][OMGWTFBBQ] Actor support [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/521982 (https://phabricator.wikimedia.org/T227345) [23:00:52] (03CR) 10Dbarratt: [C: 03+1] "Looks good to me. Tested the Special:Mute page and it continues to function as expected." [core] - 10https://gerrit.wikimedia.org/r/520050 (https://phabricator.wikimedia.org/T220163) (owner: 10Dmaza) [23:01:26] (03PS2) 10Jack Phoenix: [DNM][WIP?][OMGWTFBBQ] Actor support [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/521982 (https://phabricator.wikimedia.org/T227345) [23:03:32] (03CR) 10Krinkle: [C: 03+2] "Previously the TCP_NODELAY option was unset, and this sets it by default to false. I thought that would be a change in behaviour (assuming" [core] - 10https://gerrit.wikimedia.org/r/519768 (owner: 10Aaron Schulz) [23:03:45] (03CR) 10Krinkle: [C: 03+2] objectcache: remove inheritence from CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521964 (owner: 10Aaron Schulz) [23:03:58] (03CR) 10jenkins-bot: RedirectsAndIncomingLinks: succeede or fail, but not both [extensions/CirrusSearch] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521956 (https://phabricator.wikimedia.org/T227691) (owner: 10Jforrester) [23:04:10] (03PS1) 10Catrope: Html: Make linkButton() documentation less confusing [core] - 10https://gerrit.wikimedia.org/r/521983 [23:05:04] (03PS2) 10Catrope: Html: Make linkButton() documentation less confusing [core] - 10https://gerrit.wikimedia.org/r/521983 [23:06:18] (03CR) 10jenkins-bot: User: support setting custom fields + array autocreation in non-existent field [core] (wmf/1.34.0-wmf.13) - 10https://gerrit.wikimedia.org/r/521957 (https://phabricator.wikimedia.org/T227688) (owner: 10Gergő Tisza) [23:06:27] 10MediaWiki-extensions-OAuth, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Wikimedia-production-error: PHP error from Special:OAuth: "Indirect modification of overloaded property User::$oAuthUserData" - https://phabricator.wikimedia.org/T227688 (10Jdforrester-WMF) 05Open→03Resolved Deployed. [23:07:04] 10Technical-Tool-Request: Microphone upload from browser for reading tutoring with pronunciation assessment in Wiktionary - https://phabricator.wikimedia.org/T166929 (10Jsalsman) @Halfak can you find someone who wants to make a chatbot summarizing automatic parses of various speech recognition engines using, for... [23:08:20] (03CR) 10Dbarratt: [C: 03+2] "Beautiful" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520051 (https://phabricator.wikimedia.org/T220163) (owner: 10Dmaza) [23:09:03] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10I18n, 10MW-1.34-notes (1.34.0-wmf.14; 2019-07-16): Homepage: mobile start preview word length issues - https://phabricator.wikimedia.org/T227109 (10Etonkovidova) The screenshots are from iPhone 6S: |{F29733744}|{F2973374... [23:12:17] 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Allow user to mute notifications from Special:Mute page - https://phabricator.wikimedia.org/T220163 (10dbarratt) Instead of saying "Mute emails from this user" and "Mute emails from this user" would it be better to say: "Mute emails from user ABC" and "... [23:12:42] 10observability: log spam from mtail 3.0.0~rc19 on wezen - https://phabricator.wikimedia.org/T225604 (10colewhite) @jbond there appears to be a missing feature around the -logfds flag in mtail rc24. This causes varnishmtail and varnishmtail-backend to fail to start because the -logfds flag is missing. Downgrad... [23:16:27] (03Merged) 10jenkins-bot: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 (owner: 10Aaron Schulz) [23:17:05] 10CirrusSearch, 10Discovery-Search, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review, 10Wikimedia-production-error: Fatal from CirrusSearch\Job\LinksUpdate: "Call to a member function getLogVariables() on null" - https://phabricator.wikimedia.org/T227691 (10Jdforrester-WMF) 05Open→03Res... [23:17:29] (03Merged) 10jenkins-bot: objectcache: remove inheritence from CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521964 (owner: 10Aaron Schulz) [23:17:52] (03CR) 10Catrope: Use packageFiles instead of startup module for config vars (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520660 (https://phabricator.wikimedia.org/T73539) (owner: 10Catrope) [23:19:53] 10MediaWiki-Internationalization, 10Core Platform Team, 10Wikimedia-production-error: Fatal on some Special:MyLanguage urls: MWException "Can't determine talk page associated with interwiki link" - https://phabricator.wikimedia.org/T227700 (10Jdforrester-WMF) I'm provisionally blaming dbce648a15ee7100383c3ec... [23:20:30] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DatabaseMysqlBase: domain schemas are not supported. - https://phabricator.wikimedia.org/T227708 (10Jdforrester-WMF) 🤷🏽‍♂️ [23:29:23] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/521988 [23:29:25] (03CR) 10jenkins-bot: objectcache: use OPT_TCP_NODELAY for MemcachedPeclBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519768 (owner: 10Aaron Schulz) [23:30:18] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/521989 [23:30:21] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10dbarratt) >>! In T212326#5322380, @Niharika wrote: > Is there a possibility to link to the relevant blocks when we have... [23:30:36] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/521991 [23:30:42] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/521992 [23:30:48] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/521993 [23:30:55] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/521994 [23:31:06] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/521995 [23:31:14] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/521996 [23:31:21] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/521997 [23:31:27] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/521998 [23:31:38] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TEI] - 10https://gerrit.wikimedia.org/r/521999 [23:31:44] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/522000 [23:31:51] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Variables] - 10https://gerrit.wikimedia.org/r/522001 [23:31:58] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/522002 [23:32:33] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Anisa] - 10https://gerrit.wikimedia.org/r/522003 [23:32:39] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/522004 [23:32:43] (03CR) 10Smalyshev: [C: 03+2] Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [23:32:45] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Example] - 10https://gerrit.wikimedia.org/r/522005 [23:32:52] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/522006 [23:33:00] (03PS1) 10Jforrester: build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/522007 [23:33:09] 10MediaWiki-User-management, 10Anti-Harassment (The Letter Song ), 10Patch-For-Review: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10dbarratt) >>! In T212326#5322894, @dbarratt wrote: > I just realized that that page does not list the block id. :/ I wond... [23:34:10] (03CR) 10Dbarratt: "Some open questions on the ticket: https://phabricator.wikimedia.org/T212326#5322380" [core] - 10https://gerrit.wikimedia.org/r/520479 (https://phabricator.wikimedia.org/T212326) (owner: 10Tchanders) [23:35:27] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/521995 (owner: 10Jforrester) [23:37:33] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/521991 (owner: 10Jforrester) [23:38:35] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/522002 (owner: 10Jforrester) [23:40:28] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Anisa] - 10https://gerrit.wikimedia.org/r/522003 (owner: 10Jforrester) [23:40:56] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/Variables] - 10https://gerrit.wikimedia.org/r/522001 (owner: 10Jforrester) [23:41:33] 10VisualEditor (Current work): Conduct Edit Cards v2 on-wiki test - https://phabricator.wikimedia.org/T227616 (10ppelberg) >>! In T227616#5320037, @ppelberg wrote: > **Next steps** > - [x] Review test with @Whatamidoing-WMF + @iamjessklein **Update | 10 July** - Test has been posted on the /Edit Cards talk pag... [23:42:06] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [skins/Example] - 10https://gerrit.wikimedia.org/r/522005 (owner: 10Jforrester) [23:42:22] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/TEI] - 10https://gerrit.wikimedia.org/r/521999 (owner: 10Jforrester) [23:42:22] 10VisualEditor (Current work): Conduct Edit Cards v2 on-wiki test - https://phabricator.wikimedia.org/T227616 (10ppelberg) [23:42:57] (03PS12) 10Jdlrobson: POC: A preact component within in an Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/481111 [23:43:55] (03CR) 10jenkins-bot: objectcache: remove inheritence from CachedBagOStuff [core] - 10https://gerrit.wikimedia.org/r/521964 (owner: 10Aaron Schulz) [23:46:52] 10MediaWiki-User-management: Rename 'Editing their own talk page' as 'Their own talk page' and move it under 'Editing' on Special:Block - https://phabricator.wikimedia.org/T227721 (10dbarratt) [23:47:24] 10MediaWiki-User-management: Rename 'Editing their own talk page' as 'Their own talk page' and move it under 'Editing' on Special:Block - https://phabricator.wikimedia.org/T227721 (10dbarratt) [23:48:05] 10MediaWiki-User-management, 10Anti-Harassment, 10User-RhinosF1: 'Editing their own talk page' option has no affect when editing not selected - https://phabricator.wikimedia.org/T227199 (10dbarratt) I created T227721 to move out the discussion about moving the checkbox which is not a solution to this task. [23:48:17] (03Merged) 10jenkins-bot: Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson) [23:48:37] 10MediaWiki-User-management: Rename 'Editing their own talk page' as 'Their own talk page' and move it under 'Editing' on Special:Block - https://phabricator.wikimedia.org/T227721 (10dbarratt) [23:48:52] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade phan-taint-check-plugin from 1.5.x to 2.0.1 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/521996 (owner: 10Jforrester) [23:53:47] (03CR) 10jerkins-bot: [V: 04-1] POC: A preact component within in an Overlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/481111 (owner: 10Jdlrobson) [23:54:47] 10Anti-Harassment (The Letter Song ): Write a proposal for IP Blocks - https://phabricator.wikimedia.org/T227722 (10dbarratt) [23:55:05] 10MobileFrontend, 10Contributors-Team, 10Section Editing, 10VisualEditor-MediaWiki, and 5 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10ppelberg) [23:57:50] 10Dumps-Rewrite: Draft usage scenarios for job/workflow manager - https://phabricator.wikimedia.org/T143205 (10leila) [23:58:14] 10Hashtags, 10Product-Analytics: Discuss edit hashtag support with major bot/tool/gadget creators - https://phabricator.wikimedia.org/T123636 (10leila) [23:58:53] 10Research-Backlog: Top 500K ranked link recommendation for wp - https://phabricator.wikimedia.org/T151243 (10leila) 05Open→03Declined [23:58:55] 10Research-Archive: The top 1M ranked link recommendation for wp - https://phabricator.wikimedia.org/T148003 (10leila) [23:59:32] 10Research-Backlog, 10Research-outreach: Set up a repository for published works subject to the Wikimedia Foundation's Open Access policy - https://phabricator.wikimedia.org/T122869 (10leila) 05Open→03Declined [23:59:41] (03CR) 10jenkins-bot: Log failing RedirectsAndIncomingLinks searches [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/521960 (https://phabricator.wikimedia.org/T227691) (owner: 10EBernhardson)