[00:03:55] (03PS13) 10Reedy: Support for multiple keys, improved module form logic #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (owner: 10ItSpiderman) [00:04:01] (03PS8) 10Reedy: Revoke user's rights if not logged in over 2FA [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/513090 (owner: 10ItSpiderman) [00:04:04] 10Editing QA, 10VisualEditor (Current work): [Regression] Opening an existing gallery throws error "Uncaught TypeError: Cannot read property 'model' of undefined" - https://phabricator.wikimedia.org/T221287 (10matmarex) [00:04:27] 10Design, 10Editing QA, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor-Mobile-UsabilityImprovements, 10VisualEditor (Current work): Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) [00:05:10] (03CR) 10Krinkle: Refactor `includes` to `src` #2 (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (owner: 10Robert Vogel) [00:07:00] 10VisualEditor (Current work): [Regression?] In Safari, context menus don't get re-painted/closed upon selecting another node inside VE - https://phabricator.wikimedia.org/T226872 (10matmarex) The additional context menus are not actually interactive, but just visual glitches? Somebody using a similar OS/browse... [00:09:06] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): Special:Manage_Two-factor_authentication looks odd - https://phabricator.wikimedia.org/T226053 (10Reedy) a:05ItSpiderman→03None [00:13:58] 10VisualEditor (Current work): 'Change label' and label preview in link inspector doesn't work on single character links - https://phabricator.wikimedia.org/T227241 (10matmarex) [00:15:53] 10Phabricator, 10Wikimedia-Logstash: Improve error reporting / integration between Kibana and Phabricator - https://phabricator.wikimedia.org/T185155 (10mmodell) [00:15:55] 10Wikimedia-Logstash: Automatically log fatals/exceptions into Phabricator with stack traces - https://phabricator.wikimedia.org/T70820 (10mmodell) [00:16:22] 10Wikimedia-Site-requests: Deploy WebAuthn to Wikimedia Wikis - https://phabricator.wikimedia.org/T227242 (10Reedy) [00:17:36] 10Wikimedia-Site-requests: Deploy WebAuthn to Wikimedia Wikis - https://phabricator.wikimedia.org/T227242 (10Reedy) [00:17:38] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): WebAuthn (U2F) integration for Extension:OATHAuth - https://phabricator.wikimedia.org/T100373 (10Reedy) [00:17:56] 10MediaWiki-extensions-GuidedTour, 10Growth-Team: [betalabs-regression] RC and Watchlist pages cannot be loaded - https://phabricator.wikimedia.org/T227233 (10Catrope) I suspect that this is because of a code path in `ChangeTags::tagShortDescriptionMessage()` that returns a `RawMessage` (specifically, `new Raw... [00:18:31] 10Security-Team-Reviews: Security review of WebAuthn dependancies - https://phabricator.wikimedia.org/T227244 (10Reedy) [00:19:49] 10Wikimedia-Site-requests: Deploy WebAuthn to Wikimedia Wikis - https://phabricator.wikimedia.org/T227242 (10Reedy) 05Open→03Stalled [00:20:23] 10Wikimedia-Site-requests: Deploy WebAuthn to Wikimedia Wikis - https://phabricator.wikimedia.org/T227242 (10Reedy) [00:22:13] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Mobile: Mobile Homepage: instrumentation - https://phabricator.wikimedia.org/T222836 (10Etonkovidova) @kostajh `- the commit message says that "the schema did not accept "star... [00:24:16] 10Security-Team-Reviews: Security review of WebAuthn dependancies - https://phabricator.wikimedia.org/T227244 (10Reedy) [00:24:18] 10Security-Team-Reviews: Security review of WebAuthn dependancies - https://phabricator.wikimedia.org/T227244 (10Reedy) [00:27:54] (03PS1) 10MusikAnimal: Fix indentation of underscore templates and make style consistent [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/520657 [00:29:11] 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work on single character links - https://phabricator.wikimedia.org/T227241 (10matmarex) [00:29:13] 10Security-Team-Reviews: Security review of WebAuthn library dependancies - https://phabricator.wikimedia.org/T227244 (10Reedy) 05Open→03Stalled [00:29:44] (03PS6) 10Tim Starling: REST: basic read/write restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 [00:29:46] (03CR) 10Tim Starling: REST: basic read/write restrictions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [00:29:48] (03PS17) 10Tim Starling: Add rest.php (REST API endpoint) with feature flag [core] - 10https://gerrit.wikimedia.org/r/510637 [00:31:37] (03PS1) 10Catrope: Follow-up 9c9cfa2ec3d7: fix non-session entry point error [core] - 10https://gerrit.wikimedia.org/r/520658 (https://phabricator.wikimedia.org/T227233) [00:31:48] Reedy: Blocked by PHP7 migration. Just a minor blocker. ;-) [00:32:36] libraries need php 72, yo [00:32:54] Yeah. If only prod was further along… [00:33:32] 10MediaWiki-extensions-GuidedTour, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs-regression] RC and Watchlist pages cannot be loaded - https://phabricator.wikimedia.org/T227233 (10Catrope) a:03Catrope [00:37:44] 10MediaWiki-DjVu, 10Commons, 10Multimedia, 10ProofreadPage, and 2 others: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Aklapper) @Peteforsyth: Thanks, I can see it now :) And yes, image file permissions are a b... [00:38:27] 10WikibaseMediaInfo, 10Discovery-Search (Current work), 10Patch-For-Review: Index captions as description fields not label - https://phabricator.wikimedia.org/T226722 (10Addshore) Would representing captions as captions rather than labels in the JSON structure help? Or rather than pretending media info entit... [00:46:59] 10Patch-For-Review, 10VisualEditor (Current work): 'Change label' and label preview in link context don't work on single character links - https://phabricator.wikimedia.org/T227241 (10matmarex) [00:57:03] (03PS1) 10Catrope: Use packageFiles instead of startup module for config vars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520660 [00:57:22] (03PS7) 10Tim Starling: REST: basic read/write restrictions [core] - 10https://gerrit.wikimedia.org/r/520138 [00:57:24] (03PS18) 10Tim Starling: Add rest.php (REST API endpoint) with feature flag [core] - 10https://gerrit.wikimedia.org/r/510637 [00:58:36] (03CR) 10Tim Starling: REST: basic read/write restrictions (032 comments) [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [01:04:53] (03CR) 10Dmaza: Add option to mute/unmute notifications on Special:Mute (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520051 (https://phabricator.wikimedia.org/T220163) (owner: 10Dmaza) [01:10:51] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Restore using updated content only when no user data is lost, using the original version as a fallback - https://phabricator.wikimedia.org/T220790 (10Petar.petkovic) @Pginer-WMF two remarks: # In my patch for this ticke... [01:25:41] 10Legalpad, 10Wiki-Loves-Monuments (2018): Create Legalpad for WLM permission form - https://phabricator.wikimedia.org/T207051 (10Aklapper) [01:43:33] (03PS1) 10Catrope: ResourceLoaderStartupModule: Add wgWikiID [core] - 10https://gerrit.wikimedia.org/r/520662 [01:45:10] (03PS4) 10Catrope: Stop exporting wgWikiId, use wgWikiID from core [extensions/Echo] - 10https://gerrit.wikimedia.org/r/517560 [01:46:07] (03CR) 10Catrope: "Associated patch in Echo: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/517560" [core] - 10https://gerrit.wikimedia.org/r/520662 (owner: 10Catrope) [01:50:52] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Product-Analytics, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile instrumentation post-deployment QA - https://phabricator.wikimedia.org/T226222 (10nettrom_WMF) I added Vietnamese WP to my Leading Indicator notebook and all measurements the... [01:53:58] 10Community-Tech (Kanban (Q1 2019-20)), 10E-Book-Export-Reliability: PDF generation times out - https://phabricator.wikimedia.org/T227245 (10MaxSem) a:03MaxSem The timeout was implicitly added in https://github.com/wsexport/tool/commit/2f7f5a9598786975d26d74df6d6e2cf8168b413b Fix ready for review: https://g... [01:56:58] (03PS1) 10Ephemeralwaves: WIP Fix failing test by only running tests tagged @daily [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520663 [02:04:48] 10GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Wikimedia-Hackathon-2019 (Newcomer friendly): Growth: help users understand where to find responses (desktop) - https://phabricator.wikimedia.org/T220146 (10kostajh) > @kostajh - if the GuidedTour popup is n... [02:06:12] 10CX-analytics, 10Product-Analytics, 10Language-Team (Language-2019-April-June): Measure the surviving translations by newcomers - https://phabricator.wikimedia.org/T194650 (10chelsyx) Thanks so much @Neil_P._Quinn_WMF ! Please let me know if you see any issues in the query below. (I had some problems conne... [02:10:07] 10Phabricator, 10Regression: All Burnup Rate charts (burndown) are 404 - https://phabricator.wikimedia.org/T227247 (10Aklapper) [02:17:48] 10SVG Translate Tool: SVG Translate: Highlight languages that already have translations in ULS - https://phabricator.wikimedia.org/T227248 (10Prtksxna) [02:25:57] 10Who-Wrote-That, 10Community-Tech (Kanban (Q1 2019-20)): Investigate whether WhoWroteThat browser extension can have access to the `window` global on MediaWiki sites - https://phabricator.wikimedia.org/T227160 (10Mooeypoo) a:03Mooeypoo [02:26:09] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Mobile: Mobile Homepage: instrumentation - https://phabricator.wikimedia.org/T222836 (10kostajh) > So the fix was to make start a valid value for HomepageMolule schema? Yes,... [02:28:41] 10Developer-Advocacy (Jul-Sep 2019), 10Documentation: Update screenshots in "Introduction to Phabricator" slides after 2019-07-03 update - https://phabricator.wikimedia.org/T227249 (10Aklapper) p:05Triage→03Normal [03:01:20] (03PS2) 10Dmaza: [WIP] Add support for extentions to modify page form [core] - 10https://gerrit.wikimedia.org/r/520050 (https://phabricator.wikimedia.org/T220163) [03:06:10] (03CR) 10Jforrester: [C: 03+1] Use packageFiles instead of startup module for config vars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/520660 (owner: 10Catrope) [03:13:41] (03CR) 10Samwilson: [C: 03+2] Support for autoglobal preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/516983 (https://phabricator.wikimedia.org/T224245) (owner: 10MaxSem) [03:24:06] (03Merged) 10jenkins-bot: Support for autoglobal preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/516983 (https://phabricator.wikimedia.org/T224245) (owner: 10MaxSem) [03:26:18] (03CR) 10jenkins-bot: Support for autoglobal preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/516983 (https://phabricator.wikimedia.org/T224245) (owner: 10MaxSem) [03:31:59] 10MediaWiki-User-management, 10Anti-Harassment: Improve the consistency of block error notices - https://phabricator.wikimedia.org/T227174 (10dbarratt) [03:32:28] 10MediaWiki-User-management, 10Anti-Harassment: Improve the consistency of block error notices - https://phabricator.wikimedia.org/T227174 (10dbarratt) [03:35:51] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Tested with trackdebug and the wrong data is logged (see inline), otherwise looks good." (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [03:39:44] 10Wikimedia-General-or-Unknown: Article Wizard workflow support at Wikipedia article search page - https://phabricator.wikimedia.org/T173988 (10Aklapper) 05Stalled→03Declined > the Guided Tour sounds nearly ideal, I will share it back with the community discussion that this request came from and update this... [03:46:01] 10MediaWiki-Installer, 10TestMe: Running update.php fails on old database which have edits by inexistent user "Mediawiki default" - https://phabricator.wikimedia.org/T171315 (10Aklapper) 05Open→03Resolved >>! In T171315#3997102, @Anomie wrote: > This may be fixed by https://gerrit.wikimedia.org/r/413767 or... [03:48:19] 10Wikimedia-Shop: store.wikimedia.org site does not allow unsubscribe to mailing list - https://phabricator.wikimedia.org/T202996 (10Aklapper) 05Open→03Resolved Indeed, it now says `Just email merchandise[at]wikimedia.org and we will unsubscribe you from our mailing list.` Not sure if that's better or worse,... [03:51:33] (03CR) 10Tim Starling: [C: 04-1] "Looks good apart from the inline comments" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507596 (https://phabricator.wikimedia.org/T219279) (owner: 10Anomie) [03:54:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Allow sitelinks to redirect pages to fix the 'Bonnie and Clyde problem' - https://phabricator.wikimedia.org/T54564 (10Bovlb) >>! In T54564#3957162, @Izno wrote: > Thought of a technical solution, might as well throw it out there: > > # Let's say we create... [04:25:09] 10MediaWiki-Special-pages, 10User-DannyS712: Special:MyPage should preserve safemode parameter - https://phabricator.wikimedia.org/T202031 (10Yair_rand) Agree, having all redirect special pages work preserve `safemode` would be a good thing. [04:31:49] 10English-Wikipedia-New-Pages-Patrol: Incorrect backlog cutoff for redirects in the New Page Patrol queue - https://phabricator.wikimedia.org/T227250 (10Rosguill) [04:32:23] 10English-Wikipedia-New-Pages-Patrol: Incorrect backlog cutoff for redirects in the New Page Patrol queue - https://phabricator.wikimedia.org/T227250 (10Rosguill) [04:36:29] (03PS3) 10DLynch: Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) [05:00:44] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Marostegui) [05:21:18] (03CR) 10Tim Starling: [C: 03+1] "LGTM, but I would feel more comfortable merging it if I knew how it was tested." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/516730 (https://phabricator.wikimedia.org/T217829) (owner: 10BPirkle) [05:42:31] 10MediaWiki-extensions-CentralAuth, 10XTools: User account on MediaWiki shows it has two edits, but nothing visible in deleted contributions - https://phabricator.wikimedia.org/T184884 (10MusikAnimal) Removing #xtools as we have our own task for adding Flow contributions: {T136950} [05:42:44] 10MediaWiki-extensions-CentralAuth: User account on MediaWiki shows it has two edits, but nothing visible in deleted contributions - https://phabricator.wikimedia.org/T184884 (10MusikAnimal) [05:53:32] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) I'm cleaning up the worker queue to lighten the load. It should subside soon. [05:54:43] (03CR) 10Robert Vogel: [C: 03+2] Replace deprecated method setAppied with setApplied [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/520421 (owner: 10Pwirth) [05:54:51] (03PS1) 10Robert Vogel: Replace deprecated method setAppied with setApplied [extensions/BlueSpiceRating] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520675 [05:54:56] (03CR) 10Robert Vogel: [C: 03+2] Replace deprecated method setAppied with setApplied [extensions/BlueSpiceRating] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520675 (owner: 10Robert Vogel) [05:55:07] (03CR) 10Robert Vogel: [C: 03+2] Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/520420 (owner: 10Pwirth) [05:55:18] (03PS1) 10Robert Vogel: Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520676 [05:55:22] (03CR) 10Robert Vogel: [C: 03+2] Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520676 (owner: 10Robert Vogel) [05:55:28] (03PS1) 10Robert Vogel: Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/520677 [05:55:33] (03CR) 10Robert Vogel: [C: 03+2] Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/520677 (owner: 10Robert Vogel) [05:56:30] (03CR) 10Robert Vogel: [C: 03+2] Fix database filter set as applied even not handled anywhere [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/520417 (owner: 10Pwirth) [05:56:41] (03PS1) 10Robert Vogel: Fix database filter set as applied even not handled anywhere [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520678 [05:56:44] (03CR) 10Robert Vogel: [C: 03+2] Fix database filter set as applied even not handled anywhere [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520678 (owner: 10Robert Vogel) [05:58:28] (03Merged) 10jenkins-bot: Replace deprecated method setAppied with setApplied [extensions/BlueSpiceRating] - 10https://gerrit.wikimedia.org/r/520421 (owner: 10Pwirth) [06:00:35] (03Merged) 10jenkins-bot: Replace deprecated method setAppied with setApplied [extensions/BlueSpiceRating] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520675 (owner: 10Robert Vogel) [06:00:37] (03Merged) 10jenkins-bot: Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/520420 (owner: 10Pwirth) [06:00:39] (03Merged) 10jenkins-bot: Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520676 (owner: 10Robert Vogel) [06:00:41] (03Merged) 10jenkins-bot: Replace deprecated method setAppied with setApplied [extensions/BlueSpicePageAssignments] (REL1_31) - 10https://gerrit.wikimedia.org/r/520677 (owner: 10Robert Vogel) [06:01:04] (03Merged) 10jenkins-bot: Fix database filter set as applied even not handled anywhere [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/520417 (owner: 10Pwirth) [06:01:06] (03Merged) 10jenkins-bot: Fix database filter set as applied even not handled anywhere [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520678 (owner: 10Robert Vogel) [06:01:54] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/520550 (owner: 10L10n-bot) [06:02:33] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/520631 (owner: 10L10n-bot) [06:09:44] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10good first bug: Remove unused $wgTranslateTestUsers from Translate - https://phabricator.wikimedia.org/T224965 (10Nikerabbit) [06:10:17] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Remove unused $wgTranslateSandboxSuggestions - https://phabricator.wikimedia.org/T224964 (10Nikerabbit) [06:12:19] 10ContentTranslation, 10WorkType-NewFunctionality: Add common process-related templates from the publish settings - https://phabricator.wikimedia.org/T197696 (10santhosh) [06:15:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/520550 (owner: 10L10n-bot) [06:20:28] (03PS1) 10Fomafix: Remove htmlspecialchars where HTML escaping is already present [skins/Anisa] - 10https://gerrit.wikimedia.org/r/520679 [06:28:16] (03PS30) 10ItSpiderman: Rework the way user interacts with 2FA settings [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (owner: 10Robert Vogel) [06:28:41] (03CR) 10ItSpiderman: Rework the way user interacts with 2FA settings (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (owner: 10Robert Vogel) [06:28:56] (03PS1) 10Fomafix: Avoid double HTML escaping [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520680 [06:29:34] (03PS1) 10Aaron Schulz: rdbms: fix typo and clean up some cruft in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/520681 [06:33:08] (03PS1) 10Fomafix: Remove htmlspecialchars where HTML escaping is already present [skins/WoOgLeShades] - 10https://gerrit.wikimedia.org/r/520682 [06:35:21] (03PS6) 10Pwirth: Upgrade to BS3 architecture [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/520006 [06:35:40] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Do not provide MT servies option for en->simple or simple->en language pairs - https://phabricator.wikimedia.org/T227252 (10santhosh) [06:36:11] 10ContentTranslation, 10Language-Team (Language-2019-July-September): Issue with MT on a single section - https://phabricator.wikimedia.org/T226611 (10santhosh) >>! In T226611#5302850, @santhosh wrote: >>>! In T226611#5285948, @Jpita wrote: >> also happens with https://simple.wikipedia.org/wiki/Special:Content... [06:38:37] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): Special:Manage_Two-factor_authentication looks odd - https://phabricator.wikimedia.org/T226053 (10ItSpiderman) This is fixed in https://gerrit.wik... [06:46:10] (03PS1) 10Aaron Schulz: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 [06:46:29] (03PS1) 10Aaron Schulz: rdbms: optimize DatabaseDomain::newFromId() to remember the string form [core] - 10https://gerrit.wikimedia.org/r/520685 [06:59:43] (03PS1) 10Robert Vogel: Add UnitTests for Topic:V1k0yrv1f3ir7y6r [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/520687 [07:00:33] (03CR) 10jerkins-bot: [V: 04-1] rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 (owner: 10Aaron Schulz) [07:10:54] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10Patch-For-Review: Do not provide MT servies option for en->simple or simple->en language pairs - https://phabricator.wikimedia.org/T227252 (10santhosh) a:03santhosh [07:14:46] 10Phabricator: Activity column is shown three times - https://phabricator.wikimedia.org/T227254 (10Alicia_Fagerving_WMSE) [07:19:38] 10Discourse, 10Space (Jul-Sep-2019): Loop trying to create an account in Wikimedia Space in certain cases - https://phabricator.wikimedia.org/T226545 (10Qgil) As far as I am aware, since T226823 was applied there haven't been more reports about the loop, and I see that users who got the loop now are registered... [07:27:36] 10Phabricator, 10Regression: Paging Phabricator Flags feature throws exception - https://phabricator.wikimedia.org/T227255 (10matej_suchanek) [07:27:40] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): Special:Manage_Two-factor_authentication looks odd - https://phabricator.wikimedia.org/T226053 (10Osnard) Belongs to T218214 [07:28:54] (03PS31) 10Robert Vogel: Rework the way user interacts with 2FA settings [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (https://phabricator.wikimedia.org/T218210) [07:28:59] (03CR) 10Hashar: [C: 03+1] "Thank you Ejegg! That slightly speed up the test run :-]" [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/517397 (https://phabricator.wikimedia.org/T225496) (owner: 10Hashar) [07:29:26] (03PS13) 10Robert Vogel: Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) [07:30:47] (03CR) 10Hashar: "Very nice. I am so outdated on the PHP front that I wasn't even aware it had generator (since 5.5 apparently). Way cleaner this way and " [core] - 10https://gerrit.wikimedia.org/r/520298 (owner: 10Krinkle) [07:31:34] (03PS14) 10ItSpiderman: Support for multiple keys, improved module form logic #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) [07:31:42] (03PS7) 10Robert Vogel: Implement WebAuthn module [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [07:33:02] (03CR) 10jerkins-bot: [V: 04-1] Implement WebAuthn module [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/508788 (https://phabricator.wikimedia.org/T218211) (owner: 10ItSpiderman) [07:42:26] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: “All” missing from namespace selector of Special:UnconnectedPages on Wiktionaries - https://phabricator.wikimedia.org/T227202 (10matej_suchanek) a:03matej_suchanek [07:51:01] 10DC-Ops, 10decommission, 10Patch-For-Review: decommission db1069 - https://phabricator.wikimedia.org/T227166 (10Marostegui) [07:52:11] (03CR) 10TheDJ: "@Jforrester" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/518128 (https://phabricator.wikimedia.org/T116154) (owner: 10TheDJ) [08:04:11] (03CR) 10Daimona Eaytoy: "recheck" [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:04:32] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:04:43] (03PS1) 10Matěj Suchánek: Don't process "all" option in Html::namespaceSelectorOptions [core] - 10https://gerrit.wikimedia.org/r/520700 (https://phabricator.wikimedia.org/T227202) [08:07:11] (03PS2) 10Daimona Eaytoy: Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 [08:07:47] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:11:40] 10MediaWiki-extensions-Translate, 10MediaWiki Language Extension Bundle, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Convert Translate to use extension registration - https://phabricator.wikimedia.org/T87985 (10Nikerabbit) Currently wai... [08:14:03] (03PS1) 10Aaron Schulz: Migrate various callers away from wfWikiId() to WikiMap [core] - 10https://gerrit.wikimedia.org/r/520701 [08:14:05] (03PS1) 10Aaron Schulz: storage: remove wfWikiId() call from RevisionStore::checkDatabaseDomain() [core] - 10https://gerrit.wikimedia.org/r/520702 [08:14:07] (03PS1) 10Aaron Schulz: filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 [08:17:26] (03CR) 10jerkins-bot: [V: 04-1] Don't process "all" option in Html::namespaceSelectorOptions [core] - 10https://gerrit.wikimedia.org/r/520700 (https://phabricator.wikimedia.org/T227202) (owner: 10Matěj Suchánek) [08:17:54] (03PS3) 10Daimona Eaytoy: Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 [08:18:23] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:18:54] (03PS2) 10Matěj Suchánek: Don't process "all" option in Html::namespaceSelectorOptions [core] - 10https://gerrit.wikimedia.org/r/520700 (https://phabricator.wikimedia.org/T227202) [08:21:54] (03PS7) 10Matěj Suchánek: DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/501876 [08:26:25] (03PS4) 10Daimona Eaytoy: Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 [08:26:52] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:29:27] (03PS5) 10Daimona Eaytoy: Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 [08:29:55] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:30:20] (03PS2) 10Mglaser: Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520003 [08:32:37] (03PS1) 10Aaron Schulz: Replace wfWiki() usage with WikiMap in some additional places [core] - 10https://gerrit.wikimedia.org/r/520704 [08:34:22] 10CommRel-Specialists-Support: Document how and where communities communicate with each other - https://phabricator.wikimedia.org/T217691 (10Elitre) I put this at https://discuss-space.wmflabs.org/t/which-tools-do-communities-use-to-communicate/408 . Maybe this task is done? [08:34:31] 10MediaWiki-General-or-Unknown: StatusValue should be thoroughly encapsulated - https://phabricator.wikimedia.org/T227259 (10RazeSoldier) [08:35:31] 10MediaWiki-General-or-Unknown, 10TechCom: StatusValue should be thoroughly encapsulated - https://phabricator.wikimedia.org/T227259 (10RazeSoldier) I hope the TC team can guide this task. [08:36:14] (03CR) 10jerkins-bot: [V: 04-1] DO NOT MERGE [core] - 10https://gerrit.wikimedia.org/r/501876 (owner: 10Matěj Suchánek) [08:36:48] (03PS1) 10Mglaser: Recreate tagsearch tag inspector [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520705 [08:37:34] (03CR) 10jerkins-bot: [V: 04-1] Recreate tagsearch tag inspector [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520705 (owner: 10Mglaser) [08:39:17] (03PS6) 10Daimona Eaytoy: Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 [08:39:46] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/517441 (owner: 10Daimona Eaytoy) [08:41:48] (03PS21) 10Daimona Eaytoy: Rearrange config to provide better experience [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/468696 (https://phabricator.wikimedia.org/T191740) [08:47:00] 10Space (Oct-Dec-2019): One feed to pull all the announcements published by the Foundation - https://phabricator.wikimedia.org/T227204 (10Qgil) Thank you very much, @Headbomb. I suggest to continue the discussion flexibly here. As this discussion results in specific objectives, we can create the tasks to track i... [08:47:44] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision - https://phabricator.wikimedia.org/T227260 (10Ata) [08:48:36] 10Space (Jul-Sep-2019): One feed to pull all the announcements published by the Foundation - https://phabricator.wikimedia.org/T227204 (10Qgil) p:05Triage→03Normal a:03Qgil [08:48:44] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests: Last reviewed revision is shown to logged-out users in ukwiki instead of last revision - https://phabricator.wikimedia.org/T227260 (10Ata) [08:56:02] (03PS1) 10Daniel Kinzler: SlotRecord:compute sha1 if empty. [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) [08:57:03] (03PS1) 10Fomafix: Use HTTPS instead of HTTP where possible [extensions/cldr] - 10https://gerrit.wikimedia.org/r/520708 [08:57:20] (03PS2) 10Daniel Kinzler: SlotRecord:compute sha1 if empty. [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) [08:58:07] (03PS5) 10Daniel Kinzler: Update populateRevisionSha1.php for MCR schema changes [core] - 10https://gerrit.wikimedia.org/r/516730 (https://phabricator.wikimedia.org/T217829) (owner: 10BPirkle) [08:59:37] (03CR) 10Daniel Kinzler: "I tried this out, and it did nothing. It *said* it did something, but it did not. Turns out, the SHA1 wasn't re-computed when empty, becau" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516730 (https://phabricator.wikimedia.org/T217829) (owner: 10BPirkle) [09:04:21] (03CR) 10Daniel Kinzler: [V: 03+1 C: 03+2] "Code looks good, and works as expected now." [core] - 10https://gerrit.wikimedia.org/r/516730 (https://phabricator.wikimedia.org/T217829) (owner: 10BPirkle) [09:04:35] (03CR) 10jerkins-bot: [V: 04-1] Use HTTPS instead of HTTP where possible [extensions/cldr] - 10https://gerrit.wikimedia.org/r/520708 (owner: 10Fomafix) [09:05:02] (03CR) 10jerkins-bot: [V: 04-1] SlotRecord:compute sha1 if empty. [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) (owner: 10Daniel Kinzler) [09:06:39] (03CR) 10jerkins-bot: [V: 04-1] Use HTTPS instead of HTTP where possible [extensions/cldr] - 10https://gerrit.wikimedia.org/r/520708 (owner: 10Fomafix) [09:07:24] 10MediaWiki-General-or-Unknown, 10Core Platform Team: StatusValue should be thoroughly encapsulated - https://phabricator.wikimedia.org/T227259 (10daniel) Tagging CPT instead of TechCom, since this is not cross-cutting. For the record, we have public members in quite a few places. They feel a bit dirty, but a... [09:08:53] (03CR) 10Daniel Kinzler: "Huh." [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) (owner: 10Daniel Kinzler) [09:09:00] (03CR) 10Daniel Kinzler: "recheck" [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) (owner: 10Daniel Kinzler) [09:11:36] 10CommRel-Specialists-Support: Followup from preprocessor fixups' retrospective - https://phabricator.wikimedia.org/T170671 (10Elitre) 05Open→03Declined [09:13:59] (03CR) 10DCausse: "lgtm, just few nits in the new esbulk workflow" (036 comments) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/514964 (https://phabricator.wikimedia.org/T216783) (owner: 10EBernhardson) [09:15:00] (03CR) 10jerkins-bot: [V: 04-1] SlotRecord:compute sha1 if empty. [core] - 10https://gerrit.wikimedia.org/r/520707 (https://phabricator.wikimedia.org/T200653) (owner: 10Daniel Kinzler) [09:15:08] (03CR) 10DCausse: Glent method zero and one prep/run actions (031 comment) [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/514964 (https://phabricator.wikimedia.org/T216783) (owner: 10EBernhardson) [09:15:11] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Deep link action should open a new tab - https://phabricator.wikimedia.org/T224789 (10schoenbaechler) Thanks @cooltey, one thing that @Dbrant and I discussed a while ago when we improved the navigation model (T222056). We don’t want to lead... [09:18:44] 10MediaWiki-General-or-Unknown, 10CDB: Transient CDB read/write failures - https://phabricator.wikimedia.org/T35409 (10ArielGlenn) Isn't CDB a thing of the past? I.e. can't we close this now? [09:20:02] 10Phabricator: Activity column is shown three times - https://phabricator.wikimedia.org/T227254 (10Schnark) The Activity Feed on the left is shown twice, too. [09:27:42] 10CirrusSearch, 10Discovery-Search: Adapt IndexLookupFallbackMethod for glent requirements - https://phabricator.wikimedia.org/T227262 (10dcausse) [09:28:37] 10CirrusSearch, 10Discovery-Search: Adapt IndexLookupFallbackMethod for glent requirements - https://phabricator.wikimedia.org/T227262 (10dcausse) p:05Triage→03Normal [09:31:59] (03PS1) 10Pwirth: Activate mediaViewer attachments on special pages and outside of the content. [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/520710 [09:34:01] (03CR) 10jerkins-bot: [V: 04-1] Activate mediaViewer attachments on special pages and outside of the content. [extensions/BlueSpiceSocial] - 10https://gerrit.wikimedia.org/r/520710 (owner: 10Pwirth) [09:37:24] 10ContentTranslation, 10Language-Team (Language-2019-July-September), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09): Restore using updated content only when no user data is lost, using the original version as a fallback - https://phabricator.wikimedia.org/T220790 (10Pginer-WMF) >>! In T220790#5305604, @Petar.p... [09:37:51] (03PS1) 10Fomafix: Use $this->getMsg instead of wfMessage [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520712 [09:50:38] 10Product-Analytics, 10VisualEditor (Current work): VE mobile default: post-deployment QA A/B test - https://phabricator.wikimedia.org/T221197 (10Neil_P._Quinn_WMF) >>! In T221197#5305169, @DLynch wrote: > To copy from chat: > >> Post-mortem: The original patch didn't account for EventLogging's validation beh... [09:52:47] (03CR) 10Robert Vogel: [C: 03+2] Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520003 (owner: 10Mglaser) [09:52:56] (03PS1) 10Robert Vogel: Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/520716 [09:53:02] (03CR) 10Robert Vogel: [C: 03+2] Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/520716 (owner: 10Robert Vogel) [09:54:47] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sju, sje, smj, sjd, and rmf ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Yupik) [09:55:14] (03PS1) 10Mglaser: Add pdfpagebreak tag to InsertMagic and VisualEditor [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520717 [09:56:20] (03PS2) 10Mglaser: Add pdfpagebreak tag to InsertMagic and VisualEditor [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520717 [09:56:33] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sju, sje, smj, sjd, and rmf ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Yupik) This shouldn't be time-consuming to do, since this has been done re... [09:58:02] 10phan-taint-check-plugin, 10Patch-For-Review: Release taint-check 2.0.0 - https://phabricator.wikimedia.org/T227171 (10Daimona) ===Extension testing results=== Using mwext-fast-config, on master. Using PHP 7.3.4 with php-ast 1.0.1. ====AbuseFilter==== ` includes/AbuseFilterModifyLogFormatter.php:34 SecurityC... [09:59:24] 10TimedMediaHandler-Player, 10WMSE-Bug-Reporting-and-Translation-2019, 10Performance: Beta player slow at loading many videos in Firefox - https://phabricator.wikimedia.org/T226371 (10TheDJ) @Aklapper's results are strange.. All video elements are hinted not to preload.. All JS instantiations on pages with m... [10:04:08] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Peachey88) [10:10:26] 10Research: Publish models and data for the Citation Reason and Citation Needed classifier - https://phabricator.wikimedia.org/T221006 (10Miriam) Models and code can be found in this repository: https://github.com/mirrys/citation-needed-paper [10:10:47] 10Research: Publish models and data for the Citation Reason and Citation Needed classifier - https://phabricator.wikimedia.org/T221006 (10Miriam) 05Open→03Resolved [10:18:59] (03PS1) 10Aaron Schulz: [WIP] parser: add vary-revision-sha1 and related ParserOutput methods [core] - 10https://gerrit.wikimedia.org/r/520721 [10:22:22] (03PS1) 10MarcoAurelio: WIP [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 [10:25:53] (03CR) 10Daniel Kinzler: "Looks good, commented on some documentation issues and a few nitpicks." (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/520138 (owner: 10Tim Starling) [10:26:24] (03PS3) 10Aaron Schulz: [WIP] Use "vary-revision-sha1" over "vary-revision" in getContentInternal() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/519574 [10:28:39] (03PS2) 10MarcoAurelio: Add `Daimona Eaytoy` to authors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 [10:30:20] (03PS3) 10MarcoAurelio: Add `Daimona Eaytoy` to authors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 [10:34:11] (03Merged) 10jenkins-bot: Update for namespace moves [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/515099 (owner: 10Lucas Werkmeister (WMDE)) [10:36:46] 10MediaWiki-File-management, 10MediaWiki-Parser, 10Multimedia: SVG rendered with 'frame' option do not have the 'srcset' attribute with 1.5x an 2x images for high DPI screens - https://phabricator.wikimedia.org/T133489 (10Peachey88) a:05brion→03None Assuming @brion isn't actually working on this. [10:43:44] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sju, sje, smj, sjd, and rmf ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Zache) for sju, sjd, and rmf this will be already done in T226701. For t... [10:44:45] 10Phabricator: Permission to edit Forms No. 31, 32 and 33 for MarcoAurelio - https://phabricator.wikimedia.org/T227267 (10MarcoAurelio) [10:45:07] (03PS75) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [10:45:37] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Marostegui) @mmodell there has not been any significant change to the amount of INSERTs the master is getting https://grafana.wikimedia.org/d/000000273/mysql?... [10:48:18] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sje and smj ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Yupik) [10:48:21] 10Phabricator, 10WMSE-Bug-Reporting-and-Translation-2019: Activity column is shown three times - https://phabricator.wikimedia.org/T227254 (10Alicia_Fagerving_WMSE) [10:48:44] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sje and smj ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Yupik) I've removed sju, sjd, and rmf out of this task as redundant. Thanks! [10:48:51] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Marostegui) >>! In T227251#5306333, @Stashbot wrote: > {nav icon=file, name=Mentioned in SAL (#wikimedia-operations), href=https://tools.wmflabs.org/sal/log/A... [10:56:20] (03Merged) 10jenkins-bot: Update for namespace moves [extensions/Math] - 10https://gerrit.wikimedia.org/r/515098 (owner: 10Lucas Werkmeister (WMDE)) [10:57:59] (03Merged) 10jenkins-bot: Update for namespace moves [extensions/Score] - 10https://gerrit.wikimedia.org/r/515097 (owner: 10Lucas Werkmeister (WMDE)) [11:00:19] (03CR) 10jenkins-bot: Update for namespace moves [extensions/Math] - 10https://gerrit.wikimedia.org/r/515098 (owner: 10Lucas Werkmeister (WMDE)) [11:00:57] (03Merged) 10jenkins-bot: Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520003 (owner: 10Mglaser) [11:00:59] (03Merged) 10jenkins-bot: Add option to use a placeholder text in tag inspectors [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/520716 (owner: 10Robert Vogel) [11:11:11] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10IKhitron) [11:12:38] 04(no projects): The Extension-MagicNoCache uses a depreceated features - https://phabricator.wikimedia.org/T227269 (10Tjoneslow) [11:17:41] 10MediaWiki-extensions-Other: The Extension-MagicNoCache uses a depreceated features - https://phabricator.wikimedia.org/T227269 (10MarcoAurelio) [11:19:10] (03PS2) 10Tchanders: Tidy up conditions for applying block from cookie [core] - 10https://gerrit.wikimedia.org/r/519254 [11:19:12] (03PS2) 10Tchanders: Pass in ServiceOptions to BlockManager [core] - 10https://gerrit.wikimedia.org/r/519255 [11:21:00] 10MediaWiki-Internationalization, 10Language-strategy, 10WMFI, 10WMNO-Sami: Replace sje and smj ISO codes with language's own autonym in the Commons information template - https://phabricator.wikimedia.org/T227263 (10Yupik) [11:21:03] 10MediaWiki-Internationalization, 10Language-strategy, 10Multimedia, 10SDC Engineering, and 2 others: Add the Saami languages to Commons - https://phabricator.wikimedia.org/T224293 (10Yupik) [11:22:07] 10MediaWiki-extensions-Other: The Extension-MagicNoCache uses a depreceated features - https://phabricator.wikimedia.org/T227269 (10MarcoAurelio) Hi @Tjoneslow - welcome to Phabricator and thanks for filing this task. Given that you seem to know what needs to be done to fix the issue, would you be interested i... [11:23:51] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceUniversalExport] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520717 (owner: 10Mglaser) [11:23:52] 10MediaWiki-extensions-Other: [MagicNoCache] use of depreciated magicword::get function - https://phabricator.wikimedia.org/T227269 (10Peachey88) [11:26:57] (03PS1) 10Amire80: Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) [11:27:17] 10MediaWiki-extensions-Other: [MagicNoCache] use of depreciated magicword::get function - https://phabricator.wikimedia.org/T227269 (10MarcoAurelio) [[ https://codesearch.wmflabs.org/search/?q=MagicWord%3A%3Aget&i=nope&files=&repos=Extension:MagicNoCache | Looks ]] like a single instance where `MagicWord::get()`... [11:30:27] (03CR) 10jerkins-bot: [V: 04-1] Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [11:33:43] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Provide JSON-LD support for Wikidata - https://phabricator.wikimedia.org/T207168 (10Lea_Lacroix_WMDE) This should be deployed on July 11th. I'll take care of the announcement. [11:35:49] 10OOUI: Dialog footers should be moved up on iOS when navigation menu isn't visible. - https://phabricator.wikimedia.org/T227271 (10Esanders) [11:38:18] (03PS2) 10Amire80: Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) [11:46:02] 10Growth Design, 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10I18n: Homepage: mobile start preview word length issues - https://phabricator.wikimedia.org/T227109 (10Cntlsn) Thanks @MMiller_WMF for your input. @Catrope @kostajh @SBisson, before adding specs to the t... [11:46:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Have a more fine-grained history for property values on item pages - https://phabricator.wikimedia.org/T217324 (10Bugreporter) Related declined tasks: {T110839} and {T60437} [11:47:04] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] API module for retrieving diffs between entity revisions (wbentitydiff) - https://phabricator.wikimedia.org/T106306 (10Bugreporter) [11:49:52] 10MediaWiki-History-and-Diffs, 10Patch-For-Review: Improve handling of diffs between different content types - https://phabricator.wikimedia.org/T214217 (10Bugreporter) [11:51:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: The wbeditentity API seems to overwrite labels/descriptions even with the "add" parameter (that should preserve them) - https://phabricator.wikimedia.org/T183939 (10Bugreporter) [11:52:57] (03CR) 10Daimona Eaytoy: "Well, I thought the field was meant for people who first created the extension, but now that I think about it, it seems it's not." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [11:53:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review: wbeditentity: try to use appropriate autocomment instead of the generic one - https://phabricator.wikimedia.org/T67846 (10Bugreporter) [11:55:32] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [11:56:48] 10MediaWiki-Vendor, 10Multimedia, 10Wikidata, 10wikidata-tech-focus, and 3 others: Wikibase\MediaInfo\DataModel\MediaInfo must implement method `clear` - https://phabricator.wikimedia.org/T204488 (10Cparle) 05Open→03Resolved [12:00:41] (03CR) 10MarcoAurelio: "Hi," [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [12:00:45] (03PS1) 10Daniel Kinzler: PopulateContentTables: compute sha1 and length if needed. [core] - 10https://gerrit.wikimedia.org/r/520735 (https://phabricator.wikimedia.org/T217831) [12:02:41] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release, 10Patch-For-Review: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10daniel) I only now stumbled across the fact that PopulateRevisionSha1 is run out of se... [12:09:52] 10ContentTranslation, 10WorkType-NewFunctionality: Allow anonymous users to translate - https://phabricator.wikimedia.org/T90224 (10Bugreporter) [12:09:54] 10Design, 10ContentTranslation, 10Language-Team (Language-2019-July-September): Allow anonymous users to translate - https://phabricator.wikimedia.org/T217322 (10Bugreporter) [12:16:14] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: link from Special:Contributions - https://phabricator.wikimedia.org/T225328 (10Cntlsn) [12:17:12] 10MediaWiki-extensions-Cargo: Extension Cargo version 2.2 with MediaWiki 1.33 uses depreciated features - https://phabricator.wikimedia.org/T227273 (10Tjoneslow) [12:17:47] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: link from Special:Contributions - https://phabricator.wikimedia.org/T225328 (10Cntlsn) a:05Cntlsn→03None Thanks @MMiller_WMF for updated copy. Specifications added to... [12:21:14] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/226272 (owner: 10Hashar) [12:23:19] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [12:28:59] 10MediaWiki-extensions-Other: [MagicNoCache] use of depreciated magicword::get function - https://phabricator.wikimedia.org/T227269 (10Tjoneslow) ` diff --git a/MagicNoCache.hooks.php b/MagicNoCache.hooks.php index 24f0ea6..a00e1cb 100644 --- a/MagicNoCache.hooks.php +++ b/MagicNoCache.hooks.php @@ -1,4 +1,6 @@... [12:36:10] (03PS1) 10DannyS712: Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) [12:36:14] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/441083 (owner: 10Hashar) [12:38:08] (03PS1) 10Amire80: Split apihelp messages to a separate file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/520743 (https://phabricator.wikimedia.org/T189982) [12:38:41] (03PS2) 10DannyS712: Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) [12:43:58] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Marostegui) I have restored the defaults after db2065 caught up [12:45:21] 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), and 2 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [12:45:32] (03PS32) 10Reedy: Rework the way user interacts with 2FA settings [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [12:46:01] (03CR) 10Reedy: [C: 03+2] "PS32 fixes all the aliases so they're not broken/orphaned" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [12:49:47] 10MediaWiki-extensions-Cargo: Extension Cargo version 2.2 with MediaWiki 1.33 uses depreciated features - https://phabricator.wikimedia.org/T227273 (10Tjoneslow) This only seems to appear on the tables using "Wikitext" columns. I have several tables, some using the Wikitext column type, and the warning appears v... [12:50:16] 10OOUI, 10Documentation: MenuSelectWidget width config - https://phabricator.wikimedia.org/T227275 (10Jdoggs91) [12:52:06] 10OOUI, 10Documentation: MenuSelectWidget width config - https://phabricator.wikimedia.org/T227275 (10Jdoggs91) [13:08:13] (03CR) 10Krinkle: [C: 03+1] Add safemode to special redirect parameters that are preserved [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) (owner: 10DannyS712) [13:08:34] 10MediaWiki-ResourceLoader, 10MediaWiki-Special-pages, 10Performance-Team, 10Patch-For-Review, 10User-DannyS712: Special:MyPage should preserve safemode parameter - https://phabricator.wikimedia.org/T202031 (10Krinkle) [13:08:36] (03CR) 10Krinkle: [C: 03+1] "Use case and code LGTM. Haven't tested it though." [core] - 10https://gerrit.wikimedia.org/r/520742 (https://phabricator.wikimedia.org/T202031) (owner: 10DannyS712) [13:08:38] 10MediaWiki-ResourceLoader, 10MediaWiki-Special-pages, 10Performance-Team, 10Patch-For-Review, 10User-DannyS712: Special:MyPage should preserve safemode parameter - https://phabricator.wikimedia.org/T202031 (10Krinkle) p:05Triage→03Normal [13:09:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes - https://phabricator.wikimedia.org/T227207 (10Lea_Lacroix_WMDE) @Envlh We're work... [13:09:04] (03Merged) 10jenkins-bot: Rework the way user interacts with 2FA settings [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/499183 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:11:46] (03CR) 10Krinkle: [C: 03+2] rdbms: optimize DatabaseDomain::newFromId() to remember the string form [core] - 10https://gerrit.wikimedia.org/r/520685 (owner: 10Aaron Schulz) [13:12:49] (03CR) 10Krinkle: [C: 03+2] Simplify by using mw.util.getUrl [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/520361 (owner: 10Fomafix) [13:14:04] (03CR) 10Krinkle: [C: 04-1] "It seems ext.guidedTour.lib.internal does not have any dependencies declared." [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/520372 (owner: 10Fomafix) [13:15:33] (03CR) 10Krinkle: rdbms: fix typo and clean up some cruft in MWLBFactory (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520681 (owner: 10Aaron Schulz) [13:22:33] (03PS7) 10Pwirth: Upgrade to BS3 architecture [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/520006 [13:24:15] (03CR) 10Krinkle: [C: 04-1] "I think I misunderstood, it appears broken now as well." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519304 (owner: 10Aaron Schulz) [13:26:14] (03Merged) 10jenkins-bot: rdbms: optimize DatabaseDomain::newFromId() to remember the string form [core] - 10https://gerrit.wikimedia.org/r/520685 (owner: 10Aaron Schulz) [13:26:16] (03Merged) 10jenkins-bot: Simplify by using mw.util.getUrl [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/520361 (owner: 10Fomafix) [13:26:22] 10Internet-Archive, 10InternetArchiveBot (v2.0): WebCite conversion problems - https://phabricator.wikimedia.org/T227155 (10Green_Cardamom) [13:27:44] (03CR) 10Reedy: [C: 04-1] "Needs rebasing and updating ontop of Iaa6f6ae1c25f47ef43a0e6467474284d89a7a213 please" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 (owner: 10MarcoAurelio) [13:27:56] (03PS9) 10Reedy: Revoke user's rights if not logged in over 2FA [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/513090 (owner: 10ItSpiderman) [13:27:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Check usages/ purpose of GenericServices::getCompactBaseDataModelSerializerFactory - https://phabricator.wikimedia.org/T227276 (10hoo) [13:28:09] (03PS14) 10Reedy: Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:28:16] (03CR) 10jerkins-bot: [V: 04-1] Revoke user's rights if not logged in over 2FA [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/513090 (owner: 10ItSpiderman) [13:29:40] 10observability, 10Performance-Team (Radar), 10Wikimedia-Incident: Plot User::pingLimiter() actions in Grafana - https://phabricator.wikimedia.org/T67478 (10Krinkle) [13:31:06] (03PS15) 10Reedy: Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:31:10] (03CR) 10Reedy: [C: 03+2] Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:32:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Create integration test for dump scripts using the scripts via CLI - https://phabricator.wikimedia.org/T227283 (10hoo) [13:33:02] (03CR) 10jerkins-bot: [V: 04-1] Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:33:30] (03CR) 10jerkins-bot: [V: 04-1] Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:34:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Wikibase JSON output (dumps, Special:EntityData) lacks qualifier hashes - https://phabricator.wikimedia.org/T227207 (10hoo) This is all done. Follow up t... [13:36:18] (03PS16) 10Reedy: Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:36:22] (03CR) 10Reedy: [C: 03+2] Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:36:35] (03PS4) 10Krinkle: rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 (owner: 10Aaron Schulz) [13:36:39] (03CR) 10Krinkle: [C: 03+2] rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 (owner: 10Aaron Schulz) [13:37:09] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10schoenbaechler) Thanks @cooltey; 06), 07), 33) and 34) look good. I love... [13:37:16] (03CR) 10jenkins-bot: rdbms: optimize DatabaseDomain::newFromId() to remember the string form [core] - 10https://gerrit.wikimedia.org/r/520685 (owner: 10Aaron Schulz) [13:37:24] (03CR) 10Jack Phoenix: [C: 03+2] Remove htmlspecialchars where HTML escaping is already present [skins/Anisa] - 10https://gerrit.wikimedia.org/r/520679 (owner: 10Fomafix) [13:37:26] (03CR) 10Jack Phoenix: [C: 03+2] Remove htmlspecialchars where HTML escaping is already present [skins/WoOgLeShades] - 10https://gerrit.wikimedia.org/r/520682 (owner: 10Fomafix) [13:38:44] (03PS4) 10Krinkle: installer: Tweak MysqlUpdater::doWatchlistUpdate query [core] - 10https://gerrit.wikimedia.org/r/499733 (https://phabricator.wikimedia.org/T160993) (owner: 10Aaron Schulz) [13:39:42] (03PS2) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [13:40:00] gj ashley [13:40:20] ikr [13:41:58] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [13:42:12] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10schoenbaechler) Btw., did you find out what was causing the issue below... [13:42:47] 10Design, 10ContentTranslation, 10Language-Team (Language-2019-July-September): Allow anonymous users to translate - https://phabricator.wikimedia.org/T217322 (10Pginer-WMF) 05duplicate→03Open Thanks for finding the duplicates. Although T90224 was created earlier, I think it is better to merge them the o... [13:42:51] (03CR) 10Krinkle: rdbms: make implement IResultWrapper directly instead of via inheritence (031 comment) [core] - 10https://gerrit.wikimedia.org/r/518177 (owner: 10Aaron Schulz) [13:42:57] (03PS4) 10Krinkle: rdbms: make implement IResultWrapper directly instead of via inheritence [core] - 10https://gerrit.wikimedia.org/r/518177 (owner: 10Aaron Schulz) [13:43:02] 10Design, 10ContentTranslation, 10Language-Team (Language-2019-July-September): Allow anonymous users to translate - https://phabricator.wikimedia.org/T217322 (10Pginer-WMF) [13:43:03] 10ContentTranslation, 10WorkType-NewFunctionality: Allow anonymous users to translate - https://phabricator.wikimedia.org/T90224 (10Pginer-WMF) [13:43:12] 10Internet-Archive, 10InternetArchiveBot (v2.0): WebCite conversion problems - https://phabricator.wikimedia.org/T227155 (10Green_Cardamom) [13:43:50] yeah, that's right jerkins-bot, complain about a comment that is never parsed by anything and only seen by developers :^) that's very smart /s [13:45:35] ashley: link ? [13:46:12] (03CR) 10Krinkle: [C: 03+2] rdbms: make implement IResultWrapper directly instead of via inheritence [core] - 10https://gerrit.wikimedia.org/r/518177 (owner: 10Aaron Schulz) [13:46:20] 10Internet-Archive, 10InternetArchiveBot (v2.0): WebCite conversion problems - https://phabricator.wikimedia.org/T227155 (10Green_Cardamom) [13:46:49] but yeah, the thing can get a bit strict at times.. also since there are so many checks these days, i can't even begin keeping all that stuff running locally, so you only find out through 4 iterations of patch revisions ;) [13:47:07] (03CR) 10Krinkle: [C: 03+2] Rename various $wikiId fields/parameters to $dbDomain in user classes [core] - 10https://gerrit.wikimedia.org/r/519585 (owner: 10Aaron Schulz) [13:47:17] (03PS1) 10Robert Vogel: Refactor `UploadDialogType` to be easier extendable [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520755 [13:47:43] * thedj wants a npm ci-check that submits his code to CI before submitting it to gerrit for review [13:47:50] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ArticleFeedbackv5/+/520356/ <-- nevermind that we're talking about a giant (and very lazy) hack (though I'll admit that I'm doing this only because jquery.i18n didn't want to play ball with me), I don't understand the failures *at all*. for example, in the Timeless skin, the skin.json has a @NOTE annotation in one RL module definition and I don't recall jerkins ever complaining about [13:47:50] that, and it's the closest thing to "comments" in JSON that we have [13:48:48] ashley: manifest_version 1/2 [13:49:52] huh, it needs manifest_version 2 to _not_ complain about that? alrighty then, thanks Krinkle! [13:50:03] https://phabricator.wikimedia.org/source/mediawiki/browse/master/docs/extension.schema.v2.json$7 [13:50:17] was one of the reasons a v2 was made ;) [13:50:21] (03PS3) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [13:50:38] no, in v2 you can do "description" on config items [13:50:42] there are some other changes in v2 that might need to be adhered to at the same time, but overall that's what you want I guess :) [13:51:22] https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#Changes_in_manifest_version_2 [13:52:08] 10MediaWiki-extensions-Cargo: Extension Cargo version 2.2 with MediaWiki 1.33 uses deprecated features - https://phabricator.wikimedia.org/T227273 (10Aklapper) [13:52:12] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [13:52:28] 10MediaWiki-extensions-Cargo: Extension Cargo version 2.2 with MediaWiki 1.33 uses deprecated ParserOptions::setWrapOutputClass - https://phabricator.wikimedia.org/T227273 (10Aklapper) [13:52:44] (03CR) 10Krinkle: [C: 04-1] "LGTM, but merge conflicts." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519547 (owner: 10Aaron Schulz) [13:53:11] I do like the descriptions. [13:54:14] 10MediaWiki-extensions-Other: [MagicNoCache] use of depreciated magicword::get function - https://phabricator.wikimedia.org/T227269 (10Aklapper) @Tjoneslow: Thanks for taking a look at the code! Please feel free to use [[ https://www.mediawiki.org/wiki/Developer_access | developer access ]] to submit the propose... [13:56:14] 10MediaWiki-Internationalization, 10I18n, 10Patch-For-Review: Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl - https://phabricator.wikimedia.org/T117845 (10Fomafix) >>! In T117845#5175196, @Joe wrote: > 1. I see no community discussion approving this change across m... [13:57:41] (03Merged) 10jenkins-bot: Refactor `includes` to `src` #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510147 (https://phabricator.wikimedia.org/T218210) (owner: 10Robert Vogel) [13:57:46] (03Merged) 10jenkins-bot: rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 (owner: 10Aaron Schulz) [13:57:48] (03Merged) 10jenkins-bot: Remove htmlspecialchars where HTML escaping is already present [skins/Anisa] - 10https://gerrit.wikimedia.org/r/520679 (owner: 10Fomafix) [13:57:50] (03Merged) 10jenkins-bot: Remove htmlspecialchars where HTML escaping is already present [skins/WoOgLeShades] - 10https://gerrit.wikimedia.org/r/520682 (owner: 10Fomafix) [13:58:05] (03CR) 10Krinkle: bagostuff: optimize SqlBagOStuff and fix failing segmentation tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519766 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [13:58:21] (03Merged) 10jenkins-bot: rdbms: make implement IResultWrapper directly instead of via inheritence [core] - 10https://gerrit.wikimedia.org/r/518177 (owner: 10Aaron Schulz) [13:58:58] (03Merged) 10jenkins-bot: Rename various $wikiId fields/parameters to $dbDomain in user classes [core] - 10https://gerrit.wikimedia.org/r/519585 (owner: 10Aaron Schulz) [13:59:12] (03PS2) 10Krinkle: objectcache: optmize lock() and unlock() for SqlBagOStuff and clean up base method [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:00:16] (03PS3) 10Krinkle: objectcache: optimize lock() and unlock() methods in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:00:23] (03CR) 10Krinkle: "(fixes typo in commitmsg)" [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:00:37] (03CR) 10Krinkle: [C: 03+2] objectcache: optimize lock() and unlock() methods in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:01:42] (03PS1) 10Pwirth: [WIP] Upgrade to BS3 architecture [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/520757 [14:01:54] (03CR) 10Krinkle: [C: 03+2] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:02:11] (03PS2) 10Krinkle: filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:02:21] (03CR) 10Krinkle: [C: 03+2] "(de-based from stack)" [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:02:26] (03CR) 10Krinkle: [C: 03+2] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:02:56] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrade to BS3 architecture [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/520757 (owner: 10Pwirth) [14:03:05] (03PS15) 10Reedy: Support for multiple keys, improved module form logic #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [14:03:53] (03PS10) 10Reedy: Revoke user's rights if not logged in over 2FA [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/513090 (owner: 10ItSpiderman) [14:04:26] (03CR) 10Krinkle: Replace wfWiki() usage with WikiMap in some additional places (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520704 (owner: 10Aaron Schulz) [14:05:40] (03CR) 10Krinkle: [C: 04-1] Replace wfWiki() usage with WikiMap in some additional places (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520704 (owner: 10Aaron Schulz) [14:06:22] 10MediaWiki-Internationalization, 10I18n, 10Patch-For-Review: Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl - https://phabricator.wikimedia.org/T117845 (10TheDJ) >>! In T117845#5306809, @Fomafix wrote: >>>! In T117845#5175196, @Joe wrote: >> 1. I see no community d... [14:11:48] (03CR) 10jenkins-bot: rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 (owner: 10Aaron Schulz) [14:13:55] (03Merged) 10jenkins-bot: objectcache: optimize lock() and unlock() methods in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:17:52] 10Readers-Web-Backlog, 10RelatedArticles, 10Wikimedia-Incident: Create a browser test to make sure that the related articles are shown on the beta cluster - https://phabricator.wikimedia.org/T225225 (10dcausse) Thanks, we will try to be more cautious on this feature in the future, if there is anything else w... [14:18:13] (03CR) 10jerkins-bot: [V: 04-1] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:18:38] 10Phabricator, 10WMSE-Bug-Reporting-and-Translation-2019: Activity column is shown three times - https://phabricator.wikimedia.org/T227254 (10Aklapper) 05Open→03Resolved a:03Aklapper Thanks! Weird; I have no idea what happened. I don't see any changes in the last six weeks to the Dashboard content either... [14:22:44] 10TimedMediaHandler, 10Wikimedia-Site-requests: Refresh metadata on very old midi uploads using the audio/mid mime type - https://phabricator.wikimedia.org/T226784 (10TheDJ) Files purged.. Seems to be an issues with the mid files on ja.wp however... I suspect the handler can't read them or something, as i don... [14:23:02] (03CR) 10jerkins-bot: [V: 04-1] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:23:16] 10TimedMediaHandler, 10Wikimedia-Site-requests: Refresh metadata on very old midi uploads using the audio/mid mime type - https://phabricator.wikimedia.org/T226784 (10TheDJ) 05Open→03Resolved a:03TheDJ [14:23:18] 10MediaWiki-extensions-Score, 10TimedMediaHandler, 10Wikimedia-Hackathon-2019, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-notice: Move MIDI to audio conversion from Score into TimedMediaHandler - https://phabricator.wikimedia.org/T135597 (10TheDJ) [14:23:37] (03CR) 10jenkins-bot: rdbms: make implement IResultWrapper directly instead of via inheritence [core] - 10https://gerrit.wikimedia.org/r/518177 (owner: 10Aaron Schulz) [14:23:43] 10Space (Jul-Sep-2019): One feed to pull all the announcements published by the Foundation - https://phabricator.wikimedia.org/T227204 (10Headbomb) While related to the general issue of communications, my proposal above focuses on one specific aspect: Keeping the WMF people up to date on high-level discussions h... [14:27:36] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10Aklapper) 05Open→03Invalid I opened https://cs.wikipedia.org/w/index.php?title=Alfons_Mucha&type=revision&diff=16784497&oldid=16715219 i... [14:27:39] (03CR) 10jerkins-bot: [V: 04-1] filebackend: avoid use of wfWikiId() in FileBackendGroup [core] - 10https://gerrit.wikimedia.org/r/520703 (owner: 10Aaron Schulz) [14:28:11] (03PS4) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [14:28:42] 10WikibaseMediaInfo, 10Discovery-Search (Current work), 10Patch-For-Review: Index captions as description fields not label - https://phabricator.wikimedia.org/T226722 (10Cparle) Not really sure which JSON structure you mean @Addshore - but yeah, perhaps we should just explicitly index this stuff differently... [14:29:39] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [14:29:55] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10IKhitron) >>! In T227268#5306854, @Aklapper wrote: > I opened https://cs.wikipedia.org/w/index.php?title=Alfons_Mucha&type=revision&diff=167... [14:31:00] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10Aklapper) > About the link - any diff fits, as I already said. "Any" is not a link. :) Please choose any link and post that any link. Always... [14:33:08] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10IKhitron) >>! In T227268#5306880, @Aklapper wrote: >> About the link - any diff fits, as I already said. > "Any" is not a link. :) Please ch... [14:33:33] (03CR) 10jenkins-bot: Rename various $wikiId fields/parameters to $dbDomain in user classes [core] - 10https://gerrit.wikimedia.org/r/519585 (owner: 10Aaron Schulz) [14:34:25] 10Wikidata-Bridge: Host storybook(s) - https://phabricator.wikimedia.org/T227285 (10Pablo-WMDE) [14:36:13] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) @Marostegui: The phabricator work queue is almost empty now, see https://phabricator.wikimedia.org/daemon/ (There were well over 1 million jobs, now... [14:36:38] 10MediaWiki-Internationalization, 10I18n, 10Patch-For-Review: Rename the language codes sr-el and sr-ec to the BCP 47 conform codes sr-Latn and sr-Cyrl - https://phabricator.wikimedia.org/T117845 (10Fomafix) >>! In T117845#5306821, @TheDJ wrote: > No of course not, as the website literally predates the new f... [14:38:33] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10Marostegui) From what I can see now, the UPDATEs have stopped, but the INSERT rate is still at the same level on the master: https://grafana.wikimedia.org/d/0... [14:40:10] 10MediaWiki-History-and-Diffs, 10Browser-Support-Firefox: Choose a word with a mouse in pages diff does not work in Firefox - https://phabricator.wikimedia.org/T227268 (10Aklapper) > OK, if you think there is anyone here that does not know what is version diff. I ask you to provide clear steps to reproduce whi... [14:42:36] (03PS1) 10Robert Vogel: Add confid definitions [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520766 [14:44:18] (03CR) 10jenkins-bot: objectcache: optimize lock() and unlock() methods in SqlBagOStuff [core] - 10https://gerrit.wikimedia.org/r/519746 (https://phabricator.wikimedia.org/T113916) (owner: 10Aaron Schulz) [14:45:18] (03PS2) 10Robert Vogel: Add config definitions [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/520766 [14:45:39] (03PS5) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [14:47:56] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [14:48:38] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: AMC - mark AMC setting as "new" - https://phabricator.wikimedia.org/T225731 (10alexhollender) [14:49:17] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) I could cancel the rest of the search jobs, I think that would still produce quite a bit of database activity but maybe less than all the queue statu... [14:49:28] (03PS6) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [14:50:49] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [14:51:04] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: AMC - mark AMC setting as "new" - https://phabricator.wikimedia.org/T225731 (10alexhollender) >>! In T225731#5300666, @ovasileva wrote: > @alexhollender - let's get a new icon without text to limit translation worries updated [14:51:26] 10Discourse, 10Space: Difficulty in accessing the Guidelines page of the Space - https://phabricator.wikimedia.org/T227286 (10Elitre) [14:51:37] 10Discourse, 10Space: Difficulty in accessing the Guidelines page of the Space - https://phabricator.wikimedia.org/T227287 (10Elitre) [14:53:13] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) @Marostegui ok I found a way to slow down the queue: I lowered `phd.taskmasters` to 1 [14:53:31] (03CR) 10Daimona Eaytoy: "> Hi," [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [14:54:11] 10Phabricator, 10Operations: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) Now the graphs look better. Unfortunately, puppet will set the config back to 10 taskmasters unless we make a commit to {rOPUP} [14:56:33] (03CR) 10Niedzielski: [C: 03+2] Allow overriding text and CSS class for home menu entry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/519327 (https://phabricator.wikimedia.org/T223210) (owner: 10Kosta Harlan) [14:59:55] 10Phabricator, 10Operations, 10Patch-For-Review: Phabricator release/2019-07-03/1 from wmf/stable creating lag on codfw hosts - https://phabricator.wikimedia.org/T227251 (10mmodell) p:05Triage→03High [15:07:20] 10Discourse, 10Space: Difficulty in accessing the Guidelines page of the Space - https://phabricator.wikimedia.org/T227286 (10Aklapper) [15:07:20] 10Discourse, 10Space: Difficulty in accessing the Guidelines page of the Space - https://phabricator.wikimedia.org/T227287 (10Aklapper) [15:08:56] 10Phabricator, 10WMSE-Bug-Reporting-and-Translation-2019: Activity panel is shown three times in default dashboard on Phabricator frontpage - https://phabricator.wikimedia.org/T227254 (10Aklapper) [15:11:11] (03Merged) 10jenkins-bot: Allow overriding text and CSS class for home menu entry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/519327 (https://phabricator.wikimedia.org/T223210) (owner: 10Kosta Harlan) [15:15:05] (03CR) 10jenkins-bot: Allow overriding text and CSS class for home menu entry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/519327 (https://phabricator.wikimedia.org/T223210) (owner: 10Kosta Harlan) [15:15:59] (03PS15) 10D3r1ck01: Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 [15:16:22] (03CR) 10D3r1ck01: "This is attracting a lot of merge conflicts (as it touches so many files). I'm just from fixing some. Please could this be reviewed sooner" [core] - 10https://gerrit.wikimedia.org/r/518006 (owner: 10D3r1ck01) [15:17:45] (03CR) 10jerkins-bot: [V: 04-1] Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 (owner: 10D3r1ck01) [15:21:39] (03PS7) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [15:21:51] 10VideoCutTool, 10Google-Summer-of-Code (2019): GSoC19 Proposal : VideoCutTool to cut videos in Commons - https://phabricator.wikimedia.org/T220228 (10TheDJ) Just wondering if there has been progress here since the hackathon.. ? We got kinda bogged down back then in tool forge [15:22:50] (03PS16) 10D3r1ck01: Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 [15:23:33] (03CR) 10jerkins-bot: [V: 04-1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [15:23:53] (03PS3) 10D3r1ck01: objectcache: Hard deprecate `ObjectCache::getMainWANInstance()` [core] - 10https://gerrit.wikimedia.org/r/520422 [15:28:13] (03CR) 10Krinkle: "v1 allows "@" to be used in config, e.g. "MyConfigVar": true, and "@MyConfigVar": or "@note": "some text" nearby it." [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [15:30:41] 10VideoCutTool, 10Google-Summer-of-Code (2019): GSoC19 Proposal : VideoCutTool to cut videos in Commons - https://phabricator.wikimedia.org/T220228 (10Rogueassasin123) @TheDJ : yes, I am sure we will have a Beta roled out by Aug 7th. The Beta will allow the users to: (1) Rotate the video (2) Crop the Video... [15:31:39] 10phan-taint-check-plugin, 10Patch-For-Review: Release taint-check 2.0.0 - https://phabricator.wikimedia.org/T227171 (10Daimona) >>! In T227171#5306248, @Daimona wrote: > Now I'm going to investigate the issue in LogFormatters, to see if it can be resolved easily. Aside from that, I guess we can move on, mergi... [15:32:03] 10TimedMediaHandler, 10Wikimedia-Site-requests: Refresh metadata on very old midi uploads using the audio/mid mime type - https://phabricator.wikimedia.org/T226784 (10Urbanecm) @TheDJ:I assume that's because you don't have `transcode-reset` rights on jawiki. I've requeued the transcodes on jawiki. [15:34:35] (03CR) 10jerkins-bot: [V: 04-1] Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 (owner: 10D3r1ck01) [15:34:47] (03CR) 10jerkins-bot: [V: 04-1] Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 (owner: 10D3r1ck01) [15:38:31] (03PS17) 10D3r1ck01: Full migration of warning functions to use AtEase package methods [core] - 10https://gerrit.wikimedia.org/r/518006 [15:40:56] (03PS1) 10BPirkle: Display helpful message when populating content if revision sh1 is unpopulated [core] - 10https://gerrit.wikimedia.org/r/520779 (https://phabricator.wikimedia.org/T217831) [15:43:37] 10MediaWiki-extensions-Score, 10TimedMediaHandler: Formalize how TMH provides a player for Score-generated ogg/vorbis files - https://phabricator.wikimedia.org/T135501 (10Ebe123) [15:43:56] 10Wikimedia-Site-requests, 10Patch-For-Review: Disable Wikidata sitelinks in ProofreadPage namespaces - https://phabricator.wikimedia.org/T227201 (10matej_suchanek) a:03matej_suchanek [15:44:08] 10MediaWiki-extensions-Score, 10TimedMediaHandler-Player: File description info button is useless for Score - https://phabricator.wikimedia.org/T227195 (10Ebe123) Goes with {T135501}. A consideration for TMH with filesystem files. [15:44:54] (03Abandoned) 10BPirkle: Display helpful message when populating content if revision sh1 is unpopulated [core] - 10https://gerrit.wikimedia.org/r/520779 (https://phabricator.wikimedia.org/T217831) (owner: 10BPirkle) [15:49:38] (03PS1) 10Kosta Harlan: Move ExtensionJsonValidationTest to integration directory [core] - 10https://gerrit.wikimedia.org/r/520781 [15:54:56] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Special:Unconnectedpages displays pages connected with a Wikidata item - https://phabricator.wikimedia.org/T226900 (10matej_suchanek) Could be anything in T214746, T119738 or T76258. [16:01:18] (03CR) 10jerkins-bot: [V: 04-1] Move ExtensionJsonValidationTest to integration directory [core] - 10https://gerrit.wikimedia.org/r/520781 (owner: 10Kosta Harlan) [16:01:19] (03CR) 10jerkins-bot: [V: 04-1] Move ExtensionJsonValidationTest to integration directory [core] - 10https://gerrit.wikimedia.org/r/520781 (owner: 10Kosta Harlan) [16:02:15] 10VideoCutTool, 10Google-Summer-of-Code (2019): GSoC19 Proposal : VideoCutTool to cut videos in Commons - https://phabricator.wikimedia.org/T220228 (10Gopavasanth) Hello @TheDJ I'm so happy as you reached us back, Yes there is a lot's of progress since the Hackathon, Updates of this work can be found here:... [16:03:29] (03PS1) 10Krinkle: OutputPage: Load html5shiv without indirection of load.php [core] - 10https://gerrit.wikimedia.org/r/520783 (https://phabricator.wikimedia.org/T201483) [16:07:53] (03CR) 10Krinkle: "Also src="/w/resources/lib/html5shiv/html5shiv.js" is shorter than src="/w/load.php?modules=html5shiv&only=scripts&raw=1&sync=" [core] - 10https://gerrit.wikimedia.org/r/520783 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [16:12:21] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog: Inventory MobileFrontend/MinervaNeue browser tests - https://phabricator.wikimedia.org/T227073 (10phuedx) @Edtadros has started working on this [[ https://docs.google.com/spreadsheets/d/1aQuIG0xCm5wJXiYcav1Yq7vhT2mvUTYcVy4x5YB7JLo/ | here ]]. [16:12:35] 10VideoCutTool, 10Google-Summer-of-Code (2019): GSoC19 Proposal : VideoCutTool to cut videos in Commons - https://phabricator.wikimedia.org/T220228 (10maskaravivek) @Gopavasanth You can try posting about the issue on discourse if not already done. Someone might be able to help. :) https://discourse-mediawiki.... [16:19:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10TestMe: Aliases that are too long fail with wrong Error - https://phabricator.wikimedia.org/T222591 (10matej_suchanek) [16:19:35] (03PS1) 10D3r1ck01: Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 [16:19:40] (03CR) 10jerkins-bot: [V: 04-1] Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [16:20:40] (03PS2) 10D3r1ck01: Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 [16:21:43] (03CR) 10jerkins-bot: [V: 04-1] Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [16:23:27] (03PS3) 10D3r1ck01: Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 [16:31:41] 10CX-analytics, 10Product-Analytics, 10Language-Team (Language-2019-April-June): Measure the surviving translations by newcomers - https://phabricator.wikimedia.org/T194650 (10Neil_P._Quinn_WMF) >>! In T194650#5305709, @chelsyx wrote: > Thanks so much @Neil_P._Quinn_WMF ! Please let me know if you see any is... [16:34:15] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [16:37:28] (03PS1) 10Krinkle: resourceloader: Remove 'mw.legacy' placeholder object [core] - 10https://gerrit.wikimedia.org/r/520787 [16:40:39] (03PS2) 10Amire80: Remove "successfully" from specialmute-success and add a link title [core] - 10https://gerrit.wikimedia.org/r/520202 [16:42:00] (03PS1) 10Daimona Eaytoy: [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 [16:42:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 (owner: 10Daimona Eaytoy) [16:43:33] (03PS1) 10Paladox: Fix using MediaWikiServices [extensions/News] (REL1_33) - 10https://gerrit.wikimedia.org/r/520790 [16:44:41] (03PS4) 10Krinkle: resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:44:58] (03PS5) 10Krinkle: resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:45:08] (03CR) 10Krinkle: "minor name changes for added context on the server-side." [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:45:13] (03CR) 10Krinkle: [C: 03+1] resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:45:20] (03PS6) 10Krinkle: resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:46:49] 10phan-taint-check-plugin, 10Patch-For-Review: Release taint-check 2.0.0 - https://phabricator.wikimedia.org/T227171 (10Daimona) I can't see any easy solution that we can implement now. Moreover, it should come together with better handling of HtmlArmor (as a sort of follow-up of https://gerrit.wikimedia.org/r... [16:48:11] (03PS3) 10Krinkle: resourceloader: Set value for getStoreKey in server-side [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [16:49:25] (03CR) 10Krinkle: [C: 03+1] "Transfer size of JavaScript resources (js): - 132 B." [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [16:49:37] (03PS1) 10Paladox: Fix support for MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 [16:51:10] (03PS2) 10Paladox: Fix support for MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 [16:51:15] (03CR) 10Krinkle: [C: 03+1] "Transfer size of JavaScript resources (js):- 20 B" [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [16:51:34] (03PS3) 10Paladox: Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 [16:52:07] (03CR) 10Krinkle: [C: 03+2] Avoid double HTML escaping [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520680 (owner: 10Fomafix) [16:52:50] 10Readers-Web-Backlog, 10RelatedArticles, 10Wikimedia-Incident: Create a browser test to make sure that the related articles are shown on the beta cluster - https://phabricator.wikimedia.org/T225225 (10Jdlrobson) 05Open→03Invalid [16:52:59] (03CR) 10Krinkle: [C: 03+2] Simplify by using mw.util.getUrl [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 (owner: 10Fomafix) [16:53:51] (03CR) 10jerkins-bot: [V: 04-1] Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 (owner: 10Paladox) [16:55:47] 10MediaWiki-Language-converter, 10MediaWiki-extensions-Translate, 10Commons, 10Language-Team, 10Chinese-Sites: Deploy the Chinese public conversion group to the MediaWiki translation extension - https://phabricator.wikimedia.org/T225851 (10Taiwania_Justo) [16:55:49] (03PS3) 10MarcoAurelio: Translate special page names to Galician [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 [16:56:02] (03Merged) 10jenkins-bot: Avoid double HTML escaping [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520680 (owner: 10Fomafix) [16:56:26] (03CR) 10MarcoAurelio: "> Needs rebasing and updating ontop of Iaa6f6ae1c25f47ef43a0e6467474284d89a7a213" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 (owner: 10MarcoAurelio) [16:57:55] (03PS1) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [16:58:07] (03PS2) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [17:00:44] (03CR) 10Krinkle: [C: 03+2] "✨" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [17:01:42] (03CR) 10Krinkle: [C: 04-1] "Shall we pass the array of fields to select() then?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [17:02:02] (03CR) 10Reedy: [C: 04-1] Translate special page names to Galician (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 (owner: 10MarcoAurelio) [17:03:36] (03PS3) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [17:03:40] (03CR) 10Daimona Eaytoy: "> Shall we pass the array of fields to select() then?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [17:03:42] (03CR) 10Krinkle: [C: 04-1] "I've only done a very quick review, but overall like the direction. Needs a merge conflict resolution though. After that will re-review." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [17:03:52] (03Merged) 10jenkins-bot: Simplify by using mw.util.getUrl [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/520362 (owner: 10Fomafix) [17:04:08] (03PS4) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [17:04:48] (03CR) 10Krinkle: [C: 04-1] "Yeah, that's fine. We also use a private method sometimes that has a literal return, which is optimised to pretty much the same either way" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [17:06:04] (03CR) 10jerkins-bot: [V: 04-1] Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 (owner: 10Paladox) [17:06:17] (03PS4) 10MarcoAurelio: Translate special page names to Galician [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 [17:06:23] (03PS5) 10MarcoAurelio: Translate special page names to Galician [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 [17:06:35] (03CR) 10Krinkle: "The failures are from the AbuseFilterCachingParser." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) (owner: 10Daimona Eaytoy) [17:07:02] (03PS13) 10Daimona Eaytoy: Simplify action arrays [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 [17:07:40] (03CR) 10Daimona Eaytoy: "> I've only done a very quick review, but overall like the direction." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [17:11:07] (03PS4) 10Paladox: Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 [17:11:14] (03PS35) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [17:11:16] (03PS5) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [17:11:36] (03PS6) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 [17:11:43] (03CR) 10Daimona Eaytoy: "> Yeah, that's fine. We also use a private method sometimes that has" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [17:12:32] (03PS2) 10Fomafix: Simplify by using mw.util.getUrl [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/520372 [17:12:48] (03CR) 10jerkins-bot: [V: 04-1] Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 (owner: 10Paladox) [17:12:57] (03CR) 10Daimona Eaytoy: "> The failures are from the AbuseFilterCachingParser." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) (owner: 10Daimona Eaytoy) [17:14:24] (03Merged) 10jenkins-bot: Add `Daimona Eaytoy` to authors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [17:15:18] (03PS11) 10Daimona Eaytoy: Disallow consecutive comparisons [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) [17:19:36] (03CR) 10Fomafix: [C: 03+1] resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [17:19:38] (03CR) 10Fomafix: [C: 03+1] resourceloader: Set value for getStoreKey in server-side [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [17:19:43] Krinkle: re:your comment on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ArticleFeedbackv5/+/520356/ , that's...very interesting. Timeless' skin.json has a @NOTE annotation in a RL module block definition and it's been there since April 2017 and I don't recall CI ever complaining about it, so I figured it'd be OK to use in an extension as well :-/ I guess I'll just remove the @NOTE annotation in favor of a Phab ticket, but the [17:19:43] inconsistent behavior is certainly puzzling, I'd say [17:20:52] (03PS1) 10MSantos: Update service-runner [services/chromium-render] - 10https://gerrit.wikimedia.org/r/520794 [17:22:04] ashley: interesting, dunno what's making that tick. [17:22:15] (03PS8) 10Jack Phoenix: Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 [17:22:18] afaik the schema used is the same between them [17:22:25] skin.json is just an alternate name for extension.json [17:22:55] aye, that's what I figured as well [17:23:05] (03CR) 10jenkins-bot: Add `Daimona Eaytoy` to authors [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [17:27:30] (03CR) 10Sbisson: [C: 03+1] ResourceLoaderStartupModule: Add wgWikiID [core] - 10https://gerrit.wikimedia.org/r/520662 (owner: 10Catrope) [17:31:16] 10OOUI, 10Documentation: MenuSelectWidget width config - https://phabricator.wikimedia.org/T227275 (10matmarex) Indeed, well spotted! Looks like this was incorrectly copy-pasted from the documentation of OO.ui.mixin.ClippableElement.prototype.setIdealSize. [17:36:01] (03PS5) 10Paladox: Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 [17:36:04] (03Abandoned) 10Paladox: Test [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520792 (owner: 10Paladox) [17:37:46] (03CR) 10Paladox: [C: 03+1] Work around the removal of jquery.localize from MW core in 1.33...by copying it over [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520356 (owner: 10Jack Phoenix) [17:38:31] 10OOUI, 10phan: Fix param documentation of TabPanelLayout::__construct - https://phabricator.wikimedia.org/T227144 (10matmarex) I think the way we would really want to document it is as an optional positional parameter. Or in other words, it's valid to call `TabPanelLayout(string)` or `TabPanelLayout(string, a... [17:38:39] 10ArticleFeedbackv5, 10JavaScript, 10Technical-Debt: Update ArticleFeedbackv5 JS to not require deprecated jQuery things to be bundled into its ResourceLoader modules - https://phabricator.wikimedia.org/T227291 (10ashley) [17:41:31] (03PS1) 10Bartosz Dziewoński: PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout [core] - 10https://gerrit.wikimedia.org/r/520796 (https://phabricator.wikimedia.org/T227144) [17:45:27] (03PS1) 10Paladox: Fix loading resources [extensions/Tabs] (REL1_33) - 10https://gerrit.wikimedia.org/r/520797 [17:47:23] 10Research, 10Research-Archive: session_token changes when opening new tabs - https://phabricator.wikimedia.org/T220413 (10Miriam) 05Open→03Resolved Resolved over email [17:47:26] 10Research, 10Research-Archive, 10Patch-For-Review: Schema:CitationUsage improvements - https://phabricator.wikimedia.org/T199807 (10Miriam) [17:47:41] 10Research: Collect and analyze second round of data on citation usage - https://phabricator.wikimedia.org/T212225 (10Miriam) [17:48:24] 10Research: Collect and analyze second round of data on citation usage - https://phabricator.wikimedia.org/T212225 (10Miriam) First analysis of characterization of reading sessions from a citation interaction perspective: https://meta.wikimedia.org/wiki/Research:Characterizing_Wikipedia_Citation_Usage/Analyzing_... [17:48:36] 10Research: Collect and analyze second round of data on citation usage - https://phabricator.wikimedia.org/T212225 (10Miriam) 05Open→03Resolved [17:48:38] 10Research: Reader citation usage (quantitative) - https://phabricator.wikimedia.org/T212228 (10Miriam) [17:48:39] 10Research-Programs, 10Epic: [Objective 11.1.2] Research on citation/external link usage - https://phabricator.wikimedia.org/T171231 (10Miriam) [17:52:28] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of /srv/mediawiki/w/extensions/GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Paladox) [17:54:32] (03CR) 10MarcoAurelio: "Looking great on Beta Cluster Special:Version already! :)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/520723 (owner: 10MarcoAurelio) [17:57:32] (03CR) 10Reedy: [C: 03+2] Translate special page names to Galician [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 (owner: 10MarcoAurelio) [17:59:14] 10CheckUser: Error: 1406 Data too long for column 'cuc_comment' at row 1 - https://phabricator.wikimedia.org/T227293 (10Paladox) [18:00:56] (03Merged) 10jenkins-bot: Translate special page names to Galician [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520506 (owner: 10MarcoAurelio) [18:00:59] (03PS36) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [18:01:20] (03PS33) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [18:01:40] 10CheckUser: Checkuser does not truncate data (cuc_comment, cuc_agent) and that causes exceptions with strict mode - https://phabricator.wikimedia.org/T199323 (10Reedy) [18:01:42] 10CheckUser: Error: 1406 Data too long for column 'cuc_comment' at row 1 - https://phabricator.wikimedia.org/T227293 (10Reedy) [18:01:54] (03PS2) 10Daimona Eaytoy: [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 [18:01:58] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Reedy) [18:02:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 (owner: 10Daimona Eaytoy) [18:03:53] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Reedy) What version of MW? Of the extension? Noting that co... [18:03:55] (03PS86) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [18:04:52] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Paladox) We use MediaWiki 1.33 and the version of the extens... [18:07:54] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [18:09:03] (03PS3) 10Daimona Eaytoy: [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 [18:09:14] (03PS16) 10Reedy: Support for multiple keys, improved module form logic #2 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:09:16] (03PS11) 10Reedy: Revoke user's rights if not logged in over 2FA [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/513090 (owner: 10ItSpiderman) [18:09:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Better handling of HtmlArmor/LinkRenderer [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/520789 (owner: 10Daimona Eaytoy) [18:10:21] (03PS87) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [18:10:37] (03PS37) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [18:10:46] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [18:10:48] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [18:10:50] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [18:10:52] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [18:10:54] (03PS34) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [18:12:39] (03PS88) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [18:25:09] (03CR) 10Reedy: [C: 04-1] "This seems to break existing 2FA entries" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:29:36] (03CR) 10Reedy: [C: 04-1] "Yeah, confirmed. If I have 2FA enabled before this commit, and then bring this commit in, I just get "Verification failed."" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:30:36] 10Growth Design, 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10I18n: Homepage: mobile start preview word length issues - https://phabricator.wikimedia.org/T227109 (10Catrope) I'm not aware of a (good) way to do what you're asking for, I think we'd just have to do a... [18:30:47] (03CR) 10Reedy: [C: 04-1] Support for multiple keys, improved module form logic #2 (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:31:17] (03CR) 10Catrope: [C: 03+2] resourceloader: Remove 'mw.legacy' placeholder object [core] - 10https://gerrit.wikimedia.org/r/520787 (owner: 10Krinkle) [18:37:17] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Aklapper) > Hi, since upgrading to MW 1.33 we are seeing thi... [18:37:25] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech: Error from line 44 of GlobalPreferences/includes/Hooks.php: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T227292 (10Aklapper) [18:37:27] 10MediaWiki-extensions-GlobalPreferences: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T210449 (10Aklapper) [18:39:37] (03CR) 10Reedy: [C: 04-1] Support for multiple keys, improved module form logic #2 (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:41:01] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.11; 2019-06-26): Homepage: do not log HomepageVisit when handling tutorial visit POST requests - https://phabricator.wikimedia.org/T226208 (10Etonkovidova) 05Open→03Resolved [18:41:03] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Mobile: Mobile Homepage: instrumentation - https://phabricator.wikimedia.org/T222836 (10Etonkovidova) [18:44:14] 10MediaWiki-extensions-GlobalPreferences: Call to undefined method MediaWiki\Preferences\DefaultPreferencesFactory::setUser() - https://phabricator.wikimedia.org/T210449 (10Reedy) This doesn't seem wider spread... Literally no other reports I'm not saying it's invalid, but it seems very specific to this wiki (c... [18:45:43] (03Merged) 10jenkins-bot: resourceloader: Remove 'mw.legacy' placeholder object [core] - 10https://gerrit.wikimedia.org/r/520787 (owner: 10Krinkle) [18:46:03] (03PS2) 10Pwirth: [WIP] Upgrade to BS3 architecture [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/520757 [18:46:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrade to BS3 architecture [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/520757 (owner: 10Pwirth) [18:47:11] (03PS2) 10Aaron Schulz: rdbms: dependency inject domain aliases into LBFactory [core] - 10https://gerrit.wikimedia.org/r/520684 [18:47:48] (03CR) 10Reedy: [C: 04-1] "Relatedly to T172079 too..." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/510300 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [18:47:57] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [18:49:35] 10MediaWiki-extensions-OATHAuth, 10Continuous-Integration-Config, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10Patch-For-Review: Enable Phan and seccheck on WebAuthn extension - https://phabricator.wikimedia.org/T226737... [18:49:51] (03CR) 10DannyS712: "I see that the main build test failed, but looking through the error, it does not appear to be related to this change" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/520470 (https://phabricator.wikimedia.org/T226938) (owner: 10DannyS712) [18:50:16] (03CR) 10MarcoAurelio: [C: 03+2] Remove "successfully" from specialmute-success and add a link title [core] - 10https://gerrit.wikimedia.org/r/520202 (owner: 10Amire80) [18:53:34] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): Special:Manage_Two-factor_authentication looks odd - https://phabricator.wikimedia.org/T226053 (10Reedy) 05Open→03Resolved a:03ItSpiderman >... [18:53:39] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review: SO878 Step 1: Refactor OATHAuth ext... - https://phabricator.wikimedia.org/T218210 [18:55:27] (03PS2) 10Aaron Schulz: rdbms: fix typo and clean up some cruft in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/520681 [18:55:39] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): s/OATH Manage/Manage OATH/ - https://phabricator.wikimedia.org/T226057 (10Reedy) 05Open→03Resolved a:03Reedy This seems to have been solved... [18:55:50] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review: SO878 Step 1: Refactor OATHAuth ext... - https://phabricator.wikimedia.org/T218210 [18:56:18] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing): oathauth-ui-error-page-no-module need refining - https://phabricator.wikimedia.org/T226058 (10Reedy) [18:56:20] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Ready): SO878 Step 3: Finalize settings and user experience - https://phabricator.wikimedia.org/T218214 (10Reedy) [18:56:22] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review: SO878 Step 1: Refactor OATHAuth ext... - https://phabricator.wikimedia.org/T218210 [18:56:25] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10Documentation: Describe what different auth methods are - https://phabricator.wikimedia.org/T226056 (10Reedy) [18:56:27] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Ready): SO878 Step 3: Finalize settings and user experience - https://phabricator.wikimedia.org/T218214 (10Reedy) [18:56:30] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review: SO878 Step 1: Refactor OATHAuth ext... - https://phabricator.wikimedia.org/T218210 [18:57:20] (03CR) 10jenkins-bot: resourceloader: Remove 'mw.legacy' placeholder object [core] - 10https://gerrit.wikimedia.org/r/520787 (owner: 10Krinkle) [18:57:36] 10Wiki-Loves-Monuments (2018): Move WLM-SK lists to Wikidata - https://phabricator.wikimedia.org/T173007 (10Jetam2) Dear all perhaps we could try to revive this task. The newest lists are located on the [[ https://www.pamiatky.sk/sk/page/register-nkp-tabulkove-zoznamy | website here ]]. There are eight, sorted... [18:59:14] (03CR) 10Aaron Schulz: rdbms: clean up $groups logic in LoadBalancer and expand comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519304 (owner: 10Aaron Schulz) [19:00:34] (03CR) 10Reedy: "I wonder why gerrit isn't showing moving PetitionHooks as being a rename" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [19:00:39] 10MediaWiki-Special-pages, 10Epic, 10User-DannyS712: Special pages help links [Tracking] - https://phabricator.wikimedia.org/T226350 (10DannyS712) [19:02:25] (03CR) 10Reedy: Update Petition extension structure/code to match extensions standard (032 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [19:04:30] (03Merged) 10jenkins-bot: Remove "successfully" from specialmute-success and add a link title [core] - 10https://gerrit.wikimedia.org/r/520202 (owner: 10Amire80) [19:04:32] (03CR) 10Juan Osorio (Microsoft): "recheck" [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [19:08:06] 10MediaWiki-User-management, 10User-DannyS712: Add "help" link to Special:Unblock - https://phabricator.wikimedia.org/T227295 (10DannyS712) [19:08:35] (03PS1) 10DannyS712: Add "help" link to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/520801 (https://phabricator.wikimedia.org/T227295) [19:09:09] (03PS3) 10Reedy: Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:09:36] (03PS2) 10DannyS712: Add "help" link to Special:Unblock [core] - 10https://gerrit.wikimedia.org/r/520801 (https://phabricator.wikimedia.org/T227295) [19:09:48] (03CR) 10Krinkle: [C: 03+2] resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [19:09:50] (03CR) 10Krinkle: [C: 03+2] resourceloader: Set value for getStoreKey in server-side [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [19:10:09] (03CR) 10Reedy: [C: 03+1] "Are these ok to be merged whenever?" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:10:19] (03CR) 10Cicalese: "recheck" [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [19:11:07] 10MediaWiki-User-management, 10Patch-For-Review, 10User-DannyS712: Add "help" link to Special:Unblock - https://phabricator.wikimedia.org/T227295 (10DannyS712) a:03DannyS712 [19:11:19] 10Product-Analytics, 10VisualEditor (Current work): VE mobile default: post-deployment QA A/B test - https://phabricator.wikimedia.org/T221197 (10Neil_P._Quinn_WMF) [19:11:24] (03CR) 10Amire80: "> Are these ok to be merged whenever?" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:11:26] (03CR) 10Reedy: [C: 03+1] Split apihelp messages to a separate file [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/509572 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:11:32] (03CR) 10Reedy: [C: 03+1] Split apihelp messages to a separate file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/520743 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:11:36] (03CR) 10Reedy: [C: 03+1] Split apihelp messages to a separate file [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/509569 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:14:43] (03PS4) 10Krinkle: resourceloader: Only output ResourceLoaderDynamicStyles when needed [core] - 10https://gerrit.wikimedia.org/r/519312 (https://phabricator.wikimedia.org/T219342) [19:14:48] (03CR) 10jenkins-bot: Remove "successfully" from specialmute-success and add a link title [core] - 10https://gerrit.wikimedia.org/r/520202 (owner: 10Amire80) [19:16:37] (03CR) 10jerkins-bot: [V: 04-1] Adds a Share widget to the Section Headers [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [19:18:56] (03CR) 10Bartosz Dziewoński: [C: 03+2] Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:20:56] (03CR) 10Krinkle: "I wonder if we should change the value of wgDBname instead of compatibility, given that most certainly the only valid use of wgDBname is l" [core] - 10https://gerrit.wikimedia.org/r/520662 (owner: 10Catrope) [19:23:47] (03CR) 10Thiemo Kreuz (WMDE): "As far as I can see the issue described is indeed fixed with this change, and the regular expression becomes better overall. However, it c" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/515580 (https://phabricator.wikimedia.org/T224838) (owner: 10Seth) [19:24:12] (03CR) 10Pmiazga: [C: 03+2] Hygiene: move menu entries to subdirectory [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/520065 (https://phabricator.wikimedia.org/T214540) (owner: 10Niedzielski) [19:25:10] (03CR) 10Reedy: [C: 03+2] Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:25:10] 10MediaWiki-Internationalization, 10I18n: Gender specific display text for User namespace - https://phabricator.wikimedia.org/T19160 (10Verdy_p) I know this is old, but the idea of using GENDER (from the viewing user) to change the title of a namespace where every user is neutral ! Or may be this will just app... [19:25:13] (03Merged) 10jenkins-bot: resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [19:25:16] (03Merged) 10jenkins-bot: resourceloader: Set value for getStoreKey in server-side [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [19:25:33] (03CR) 10Reedy: [C: 03+2] Split apihelp messages to a separate file [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/509572 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:25:35] (03CR) 10Reedy: [C: 03+2] Split apihelp messages to a separate file [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/509569 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:25:37] (03CR) 10Reedy: [C: 03+2] Split apihelp messages to a separate file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/520743 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:26:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout [core] - 10https://gerrit.wikimedia.org/r/520796 (https://phabricator.wikimedia.org/T227144) (owner: 10Bartosz Dziewoński) [19:27:15] (03CR) 10D3r1ck01: "thanks for the review. 👍" (032 comments) [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [19:27:17] (03CR) 10Krinkle: [C: 03+2] Simplify by using mw.util.getUrl [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/520372 (owner: 10Fomafix) [19:27:45] (03PS4) 10D3r1ck01: Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 [19:28:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Use $this->getMsg instead of wfMessage [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520712 (owner: 10Fomafix) [19:28:31] (03CR) 10Krinkle: "flaky wdio test: 'Wikibase/repo/tests/selenium/specs/item.js'" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/520708 (owner: 10Fomafix) [19:28:35] (03CR) 10Krinkle: "recheck" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/520708 (owner: 10Fomafix) [19:28:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix support for ContribsPager changes done in MediaWiki 1.33 [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520791 (owner: 10Paladox) [19:30:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix param documentation of ProtectionForm::show (031 comment) [core] - 10https://gerrit.wikimedia.org/r/519759 (owner: 10Umherirrender) [19:30:49] (03Merged) 10jenkins-bot: Log editor switches to visualeditorfeatureuse [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/519530 (https://phabricator.wikimedia.org/T221191) (owner: 10DLynch) [19:30:51] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/520731 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:31:43] (03CR) 10Krinkle: [C: 03+2] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [19:31:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix type hints in objectcache related classes [core] - 10https://gerrit.wikimedia.org/r/520520 (owner: 10Umherirrender) [19:34:07] (03CR) 10D3r1ck01: "> I wonder why gerrit isn't showing moving PetitionHooks as being a rename" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [19:36:55] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Recurring-Donations: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585 (10aaron) Can this be closed now? [19:37:54] (03PS6) 10Aaron Schulz: rdbms: clean up $groups logic in LoadBalancer and expand comments [core] - 10https://gerrit.wikimedia.org/r/519304 [19:38:51] (03CR) 10jenkins-bot: resourceloader: Set value for getStoreKey in server-side [core] - 10https://gerrit.wikimedia.org/r/519745 (owner: 10Fomafix) [19:39:07] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/509572 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:39:09] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/509569 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:39:11] (03Merged) 10jenkins-bot: Split apihelp messages to a separate file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/520743 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:40:45] (03Merged) 10jenkins-bot: PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout [core] - 10https://gerrit.wikimedia.org/r/520796 (https://phabricator.wikimedia.org/T227144) (owner: 10Bartosz Dziewoński) [19:41:29] (03CR) 10jenkins-bot: Split apihelp messages to a separate file [extensions/Linter] - 10https://gerrit.wikimedia.org/r/520743 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [19:43:01] (03Merged) 10jenkins-bot: Simplify by using mw.util.getUrl [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/520372 (owner: 10Fomafix) [19:43:03] (03Merged) 10jenkins-bot: Use $this->getMsg instead of wfMessage [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/520712 (owner: 10Fomafix) [19:43:21] (03CR) 10Umherirrender: Fix param documentation of ProtectionForm::show (036 comments) [core] - 10https://gerrit.wikimedia.org/r/519759 (owner: 10Umherirrender) [19:44:28] (03Merged) 10jenkins-bot: Fix param documentation of ProtectionForm::show [core] - 10https://gerrit.wikimedia.org/r/519759 (owner: 10Umherirrender) [19:44:57] (03CR) 10jenkins-bot: Simplify by using mw.util.getUrl [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/520372 (owner: 10Fomafix) [19:45:30] (03Merged) 10jenkins-bot: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [19:47:13] (03PS3) 10Pmiazga: Add contributions link to toolbar on User pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518755 (https://phabricator.wikimedia.org/T224735) [19:47:45] (03Merged) 10jenkins-bot: Fix type hints in objectcache related classes [core] - 10https://gerrit.wikimedia.org/r/520520 (owner: 10Umherirrender) [19:47:55] (03CR) 10Catrope: [C: 03+2] Fix `cursor` on TagItemWidgets [core] - 10https://gerrit.wikimedia.org/r/517962 (owner: 10VolkerE) [19:48:51] (03CR) 10jenkins-bot: resourceloader: Set value for getVary in server-side [core] - 10https://gerrit.wikimedia.org/r/519627 (owner: 10Fomafix) [19:49:45] (03CR) 10jerkins-bot: [V: 04-1] rdbms: clean up $groups logic in LoadBalancer and expand comments [core] - 10https://gerrit.wikimedia.org/r/519304 (owner: 10Aaron Schulz) [19:52:21] (03PS12) 10Niedzielski: Hygiene: extract ToggleList to a reusable component [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518114 (https://phabricator.wikimedia.org/T214540) [19:52:23] (03PS6) 10Niedzielski: Hygiene: move menu entries to subdirectory [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/520065 (https://phabricator.wikimedia.org/T214540) [19:52:25] (03PS16) 10Niedzielski: New: add user menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/519126 (https://phabricator.wikimedia.org/T214540) [19:55:01] (03CR) 10jenkins-bot: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [19:56:11] (03PS76) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [19:56:50] (03PS2) 10Umherirrender: Fix types around ILoadBalancer and IResultWrapper [core] - 10https://gerrit.wikimedia.org/r/519762 [20:00:29] (03Merged) 10jenkins-bot: Fix `cursor` on TagItemWidgets [core] - 10https://gerrit.wikimedia.org/r/517962 (owner: 10VolkerE) [20:00:31] (03CR) 10jenkins-bot: PreferencesFormOOUI: Avoid Phan warning with weird signature of TabPanelLayout [core] - 10https://gerrit.wikimedia.org/r/520796 (https://phabricator.wikimedia.org/T227144) (owner: 10Bartosz Dziewoński) [20:03:34] (03PS1) 10Nray: Consolidate Page.js instance variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T224735) [20:04:38] (03PS2) 10Nray: Consolidate Page.js instance variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [20:07:45] 10WMSE-Wiki-Loves-2019 (Wiki Loves Monuments 2019): Review the selection of what ancient monuments are part of WLM - https://phabricator.wikimedia.org/T172248 (10Abbe98) As we now have a data field "Visible above ground" I would like to remove all items where this value is set to false, feels like a start and is... [20:10:07] (03CR) 10Reedy: [C: 03+2] "Not just gerrit, it's doing it locally too. I wonder if it's just because it's a small file and a few lines change. NBD :)" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [20:13:20] (03Merged) 10jenkins-bot: Update Petition extension structure/code to match extensions standard [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [20:13:53] (03CR) 10D3r1ck01: "> Not just gerrit, it's doing it locally too. I wonder if it's just because it's a small file and a few lines change. NBD :)" [extensions/Petition] - 10https://gerrit.wikimedia.org/r/520786 (owner: 10D3r1ck01) [20:16:20] 10MediaWiki-DjVu, 10Commons, 10Multimedia, 10ProofreadPage, and 2 others: Proofread Page extension on Wikisource is displaying wrong pages; purge on Commons file fails - https://phabricator.wikimedia.org/T215558 (10Ankry) @Peteforsyth, I quite often encounter this problem while uploading a new version of a... [20:17:07] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Recurring-Donations: "Uncommitted DB writes" errors are getting creepy - https://phabricator.wikimedia.org/T100585 (10awight) 05Open→03Resolved a:03awight I'd say we can just reopen it if this ever happens again, thanks! [20:17:19] (03CR) 10jenkins-bot: Fix param documentation of ProtectionForm::show [core] - 10https://gerrit.wikimedia.org/r/519759 (owner: 10Umherirrender) [20:18:42] (03PS3) 10Umherirrender: Adjust type hints in htmlform related classes [core] - 10https://gerrit.wikimedia.org/r/517736 [20:19:18] (03CR) 10Krinkle: Simplify action arrays (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [20:19:24] (03PS14) 10Krinkle: Simplify action arrays [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [20:19:43] (03CR) 10Krinkle: "Updated a similar pattern in a test, which seems appropriate." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [20:21:02] (03CR) 10Krinkle: [C: 04-1] "3 things I noticed:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/463266 (owner: 10Daimona Eaytoy) [20:22:35] (03CR) 10Reedy: [C: 04-1] "CR-1 until UploadWizard and CentralNotice are done so they don't spam the WMF logs :)" [core] - 10https://gerrit.wikimedia.org/r/520422 (owner: 10D3r1ck01) [20:23:02] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Patch-For-Review, 10Performance-Team (Radar): Drastically reduce the number of ResourceLoader modules that WikibaseClient registers - https://phabricator.wikimedia.org/T203696 (10Krinkle) [20:24:15] (03CR) 10Nray: [C: 03+2] "lgtm, I think Alex will want the color of the icon adjusted since all the other icons in the toolbar are `#54595d` except the contribution" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518755 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:25:19] (03CR) 10AndyRussG: "> CR-1 until UploadWizard and CentralNotice are done so they don't spam the WMF logs :)" [core] - 10https://gerrit.wikimedia.org/r/520422 (owner: 10D3r1ck01) [20:26:25] 10MediaWiki-Page-editing: Allow editing and moving to be done as an atomic operation - https://phabricator.wikimedia.org/T227119 (10Retro) I think there are 2 separate things here: - The specifics of the AFCH - The general usefulness of my proposed simulataneous move/edit action. If the AFCH issues are resolve... [20:26:58] (03PS2) 10Fomafix: Simplify by using mw.util.getUrl [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520360 [20:27:25] (03CR) 10jenkins-bot: Fix type hints in objectcache related classes [core] - 10https://gerrit.wikimedia.org/r/520520 (owner: 10Umherirrender) [20:27:51] 10MediaWiki-Page-editing: Allow editing and moving to be done as a simulataneous operation - https://phabricator.wikimedia.org/T227119 (10Retro) [20:29:42] (03CR) 10Krinkle: [C: 03+2] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [20:30:09] (03CR) 10D3r1ck01: "I did something for UW but had a funny ajax request failure. See: Ib3f29188c6b5bdf5a93974." [core] - 10https://gerrit.wikimedia.org/r/520422 (owner: 10D3r1ck01) [20:30:41] (03CR) 10jerkins-bot: [V: 04-1] Simplify by using mw.util.getUrl [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520360 (owner: 10Fomafix) [20:31:27] (03CR) 10Krinkle: [C: 03+2] Disallow consecutive comparisons [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) (owner: 10Daimona Eaytoy) [20:32:26] 10OOUI, 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10phan: Fix param documentation of TabPanelLayout::__construct - https://phabricator.wikimedia.org/T227144 (10Umherirrender) 05Open→03Resolved a:03MaxSem Thanks for the patch [20:33:51] (03CR) 10Nray: [C: 03+2] If the Overflow menu is visible, don't render user links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518313 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:33:54] (03PS1) 10Umherirrender: Call getMessage when outputting exceptions in sql.php [core] - 10https://gerrit.wikimedia.org/r/520805 [20:35:24] (03CR) 10Krinkle: [C: 03+2] Follow-up 9c9cfa2ec3d7: fix non-session entry point error [core] - 10https://gerrit.wikimedia.org/r/520658 (https://phabricator.wikimedia.org/T227233) (owner: 10Catrope) [20:36:19] (03CR) 10Krinkle: [C: 03+2] WikispeechHooks: Remove legacy hook behavior ("return true") [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/505336 (owner: 10D3r1ck01) [20:36:37] (03PS3) 10Fomafix: Simplify by using mw.util.getUrl [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520360 [20:37:20] (03CR) 10Krinkle: [C: 03+2] test: refactor/speed up release note file test [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/520464 (https://phabricator.wikimedia.org/T227067) (owner: 10Hashar) [20:37:30] (03CR) 10jenkins-bot: Fix `cursor` on TagItemWidgets [core] - 10https://gerrit.wikimedia.org/r/517962 (owner: 10VolkerE) [20:38:37] (03Merged) 10jenkins-bot: Add contributions link to toolbar on User pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518755 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:41:11] (03PS4) 10Krinkle: parser: Inline private callback in LinkHolderArray::replaceText [core] - 10https://gerrit.wikimedia.org/r/498734 (owner: 10Thiemo Kreuz (WMDE)) [20:42:16] 10Product-Analytics, 10VisualEditor (Current work): VE mobile default: post-deployment QA A/B test - https://phabricator.wikimedia.org/T221197 (10Neil_P._Quinn_WMF) [20:42:55] (03Merged) 10jenkins-bot: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [20:43:58] (03Merged) 10jenkins-bot: Disallow consecutive comparisons [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) (owner: 10Daimona Eaytoy) [20:44:09] 10Product-Analytics, 10VisualEditor (Current work): VE mobile default: post-deployment QA A/B test - https://phabricator.wikimedia.org/T221197 (10Neil_P._Quinn_WMF) [20:44:31] (03CR) 10jenkins-bot: Add contributions link to toolbar on User pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518755 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:47:02] (03CR) 10Reedy: [C: 03+2] Fix using MediaWikiServices [extensions/News] (REL1_33) - 10https://gerrit.wikimedia.org/r/520790 (owner: 10Paladox) [20:47:26] (03CR) 10Reedy: [C: 03+2] Fix loading resources [extensions/Tabs] (REL1_33) - 10https://gerrit.wikimedia.org/r/520797 (owner: 10Paladox) [20:48:28] (03PS11) 10Juan Osorio (Microsoft): Adds a Share widget to the Section Headers [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) [20:49:04] (03Merged) 10jenkins-bot: If the Overflow menu is visible, don't render user links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518313 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:49:06] (03Merged) 10jenkins-bot: WikispeechHooks: Remove legacy hook behavior ("return true") [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/505336 (owner: 10D3r1ck01) [20:49:20] (03CR) 10jerkins-bot: [V: 04-1] Follow-up 9c9cfa2ec3d7: fix non-session entry point error [core] - 10https://gerrit.wikimedia.org/r/520658 (https://phabricator.wikimedia.org/T227233) (owner: 10Catrope) [20:49:28] (03CR) 10Cicalese: "recheck" [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [20:53:35] (03Merged) 10jenkins-bot: test: refactor/speed up release note file test [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/520464 (https://phabricator.wikimedia.org/T227067) (owner: 10Hashar) [20:53:37] (03CR) 10jenkins-bot: If the Overflow menu is visible, don't render user links [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/518313 (https://phabricator.wikimedia.org/T224735) (owner: 10Pmiazga) [20:54:27] (03CR) 10jenkins-bot: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [20:55:04] (03Merged) 10jenkins-bot: Fix using MediaWikiServices [extensions/News] (REL1_33) - 10https://gerrit.wikimedia.org/r/520790 (owner: 10Paladox) [20:55:06] (03Merged) 10jenkins-bot: Fix loading resources [extensions/Tabs] (REL1_33) - 10https://gerrit.wikimedia.org/r/520797 (owner: 10Paladox) [20:56:41] (03CR) 10jenkins-bot: WikispeechHooks: Remove legacy hook behavior ("return true") [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/505336 (owner: 10D3r1ck01) [21:03:49] (03CR) 10jerkins-bot: [V: 04-1] Adds a Share widget to the Section Headers [core] - 10https://gerrit.wikimedia.org/r/513234 (https://phabricator.wikimedia.org/T18691) (owner: 10Juan Osorio (Microsoft)) [21:04:54] (03CR) 10jenkins-bot: Disallow consecutive comparisons [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498127 (https://phabricator.wikimedia.org/T218906) (owner: 10Daimona Eaytoy) [21:06:30] 10Discourse, 10Space (Jul-Sep-2019): Difficulty in accessing the Guidelines page of the Space - https://phabricator.wikimedia.org/T227287 (10Qgil) p:05Triage→03Low This is strange, but I can replicate the problem with Chrome and Firefox. Maybe it has something to do with https://meta.discourse.org/t/custo... [21:09:26] (03CR) 10jenkins-bot: test: refactor/speed up release note file test [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/520464 (https://phabricator.wikimedia.org/T227067) (owner: 10Hashar) [21:13:34] (03PS1) 10Reedy: Update symfony/* 3.4.27 => 3.4.29 [vendor] - 10https://gerrit.wikimedia.org/r/520806 [21:13:36] (03PS1) 10Reedy: Update guzzlehttp/psr7 1.5.2 => 1.6.1 and ralouphie/getallheaders 2.0.5 => 3.0.3 [vendor] - 10https://gerrit.wikimedia.org/r/520807 [21:18:32] 10Space (Jul-Sep-2019): One feed to pull all the announcements published by the Foundation - https://phabricator.wikimedia.org/T227204 (10Qgil) Yes, fully agreed. I'd say don't worry about the Distill process. We are already doing that internally. However, even when the process of distillation could be improved... [21:21:24] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.29x-N-Nanaimo-Bar): Make nanaimo bar icon for workboard - https://phabricator.wikimedia.org/T226419 (10schoenbaechler) DONE 💥 {F29681061} [21:21:54] 10MediaWiki-Installer, 10Performance-Team, 10Technical-Debt: Remove and parser functions from MW installer parser - https://phabricator.wikimedia.org/T227297 (10Krinkle) [21:32:13] (03PS1) 10Krinkle: installer: Fix Html::infoBox param docs and mark as internal [core] - 10https://gerrit.wikimedia.org/r/520808 (https://phabricator.wikimedia.org/T227297) [21:32:15] (03PS1) 10Krinkle: installer: Call getInfoBox() with raw wikitext, not transformed text [core] - 10https://gerrit.wikimedia.org/r/520809 (https://phabricator.wikimedia.org/T227297) [21:32:17] (03PS1) 10Krinkle: installer: Convert hack to raw message param [core] - 10https://gerrit.wikimedia.org/r/520810 (https://phabricator.wikimedia.org/T227297) [21:33:18] (03CR) 10Krinkle: "See T227297" [core] - 10https://gerrit.wikimedia.org/r/502041 (owner: 10Brian Wolff) [21:35:50] (03CR) 10Krinkle: [C: 04-1] "This adds a new feature to MW, but it is unclear who would be the steward/owner of this feature. The task has Editing-team tagged, but ple" [core] - 10https://gerrit.wikimedia.org/r/518399 (https://phabricator.wikimedia.org/T207577) (owner: 10DannyS712) [21:40:59] (03PS1) 10Aaron Schulz: Import the PSR logger classes in Message [core] - 10https://gerrit.wikimedia.org/r/520816 [21:41:02] (03PS1) 10Aaron Schulz: Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 [21:41:04] (03PS1) 10Aaron Schulz: Move callers away from Title::GAID_FOR_UPDATE [core] - 10https://gerrit.wikimedia.org/r/520818 [21:41:06] (03PS1) 10Aaron Schulz: Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 [21:43:52] 10MediaWiki-Page-editing, 10Editing-team, 10Patch-For-Review, 10User-DannyS712: Create a Special:NewSection page - https://phabricator.wikimedia.org/T207577 (10DannyS712) @Krinkle noted on the patch that: > This adds a new feature to MW, but it is unclear who would be the steward/owner of this feature. T... [21:51:06] (03PS3) 10Nray: Consolidate Page.js instance variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [21:55:39] (03CR) 10jerkins-bot: [V: 04-1] Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 (owner: 10Aaron Schulz) [21:55:50] (03CR) 10jerkins-bot: [V: 04-1] Move callers away from Title::GAID_FOR_UPDATE [core] - 10https://gerrit.wikimedia.org/r/520818 (owner: 10Aaron Schulz) [21:56:02] (03CR) 10jerkins-bot: [V: 04-1] Move callers away from Title::GAID_FOR_UPDATE [core] - 10https://gerrit.wikimedia.org/r/520818 (owner: 10Aaron Schulz) [21:56:19] (03CR) 10jerkins-bot: [V: 04-1] Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 (owner: 10Aaron Schulz) [21:57:19] (03CR) 10Aaron Schulz: Replace wfWiki() usage with WikiMap in some additional places (031 comment) [core] - 10https://gerrit.wikimedia.org/r/520704 (owner: 10Aaron Schulz) [21:57:41] (03CR) 10jerkins-bot: [V: 04-1] Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [21:58:50] (03PS2) 10Aaron Schulz: Replace wfWiki() usage with WikiMap in some additional places [core] - 10https://gerrit.wikimedia.org/r/520704 [21:58:58] (03CR) 10Jack Phoenix: "Tiny documentation-related nitpick inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/518399 (https://phabricator.wikimedia.org/T207577) (owner: 10DannyS712) [21:59:10] (03PS7) 10Aaron Schulz: Make RevisionStore and friends use DB domain IDs [core] - 10https://gerrit.wikimedia.org/r/469379 [22:00:36] (03CR) 10jerkins-bot: [V: 04-1] Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 (owner: 10Aaron Schulz) [22:01:13] (03PS1) 10Krinkle: installer: Avoid hack for 'config-sidebar' rendering [core] - 10https://gerrit.wikimedia.org/r/520820 (https://phabricator.wikimedia.org/T227297) [22:01:21] (03CR) 10jerkins-bot: [V: 04-1] Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [22:01:58] (03CR) 10Krinkle: [C: 03+2] rdbms: fix typo and clean up some cruft in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/520681 (owner: 10Aaron Schulz) [22:10:02] (03PS6) 10Aaron Schulz: Convert wfGetDB() calls to using getConnectionRef() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519547 [22:12:30] (03PS18) 10DannyS712: Create Special:NewSection special page [core] - 10https://gerrit.wikimedia.org/r/518399 (https://phabricator.wikimedia.org/T207577) [22:13:30] (03CR) 10Aaron Schulz: [C: 03+2] Fix types around ILoadBalancer and IResultWrapper [core] - 10https://gerrit.wikimedia.org/r/519762 (owner: 10Umherirrender) [22:15:49] 10MediaWiki-Database, 10Patch-For-Review, 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242 (10Krinkle) Effectively resolved by: * {eb603040de8dcc164128080ba669df0ea930faee} (and many commits before it in preparation, and after it to make... [22:15:57] 10MediaWiki-Database, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Daniel: DB handles obtained with DB_REPLICA should not allow writes - https://phabricator.wikimedia.org/T183242 (10Krinkle) [22:16:09] (03PS2) 10Aaron Schulz: Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 [22:16:18] (03PS3) 10Aaron Schulz: Remove unused methods and bogus method call in Title [core] - 10https://gerrit.wikimedia.org/r/520819 [22:17:51] (03CR) 10Gergő Tisza: [C: 03+1] "Looks good. Maybe worth increasing upload_max_filesize (2M by default) and post_max_size (8M by default) since djvus tend to be larger tha" [vagrant] - 10https://gerrit.wikimedia.org/r/517584 (owner: 10MaxSem) [22:22:16] (03PS8) 10Aaron Schulz: Make RevisionStore and friends use DB domain IDs [core] - 10https://gerrit.wikimedia.org/r/469379 [22:26:04] (03CR) 10Aaron Schulz: [C: 03+2] installer: Convert hack to raw message param [core] - 10https://gerrit.wikimedia.org/r/520810 (https://phabricator.wikimedia.org/T227297) (owner: 10Krinkle) [22:27:04] (03PS7) 10Aaron Schulz: rdbms: clean up $groups logic in LoadBalancer and expand comments [core] - 10https://gerrit.wikimedia.org/r/519304 [22:27:07] 10Trust-and-Safety: Reset the email for מעיין קאשי - https://phabricator.wikimedia.org/T227134 (10Urbanecm) Given it's an unprivileged account and a trusted user (in fact, a sysadmin) vouches for the user, I think you may be bold and process this request yourself. [22:27:56] (03PS2) 10Aaron Schulz: Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 [22:28:19] (03CR) 10DannyS712: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/518399 (https://phabricator.wikimedia.org/T207577) (owner: 10DannyS712) [22:29:19] 10MediaWiki-Email, 10MediaWiki-User-management, 10Anti-Harassment, 10User-DannyS712: not possible to set email when email blocked - https://phabricator.wikimedia.org/T225872 (10Urbanecm) Wasn't this just introduced as part of {T209794}? [22:30:43] (03Merged) 10jenkins-bot: rdbms: fix typo and clean up some cruft in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/520681 (owner: 10Aaron Schulz) [22:30:45] (03Merged) 10jenkins-bot: Fix types around ILoadBalancer and IResultWrapper [core] - 10https://gerrit.wikimedia.org/r/519762 (owner: 10Umherirrender) [22:31:12] 10MediaWiki-Email, 10MediaWiki-User-management, 10Anti-Harassment, 10User-DannyS712: not possible to set email when email blocked - https://phabricator.wikimedia.org/T225872 (10Urbanecm) See https://gerrit.wikimedia.org/r/c/mediawiki/core/+/514755 for the patch that introduced this. Affects only "email dis... [22:31:35] 10Phabricator: Add a Wishlist/ Enhancement task type - https://phabricator.wikimedia.org/T163106 (10Aklapper) [22:31:40] 10Phabricator, 10User-MModell: Add support for task types - https://phabricator.wikimedia.org/T93499 (10Aklapper) [22:31:49] 10Phabricator: Add a Wishlist/ Enhancement task type - https://phabricator.wikimedia.org/T163106 (10Aklapper) [22:31:53] 10Phabricator, 10User-MModell: Add support for task types - https://phabricator.wikimedia.org/T93499 (10Aklapper) [22:31:55] (03CR) 10Krinkle: [C: 03+2] Convert wfGetDB() calls to using getConnectionRef() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519547 (owner: 10Aaron Schulz) [22:32:06] 10Phabricator: Add a Wishlist/ Enhancement task type - https://phabricator.wikimedia.org/T163106 (10Aklapper) https://phabricator.wikimedia.org/T93499 introduced a "Feature request" task subtype. Hence closing as resolved. ([Someone™ shall document that](https://phabricator.wikimedia.org/T224417), though.) [22:33:53] (03CR) 10Jack Phoenix: [C: 03+2] Simplify by using mw.util.getUrl [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/520360 (owner: 10Fomafix) [22:36:36] 10Phabricator, 10Epic, 10Phabricator (Upstream), 10Upstream: [EPIC] Gather requirements from teams for Phab project management feature requests - https://phabricator.wikimedia.org/T105404 (10Aklapper) [22:39:42] 10Phabricator, 10Epic, 10Phabricator (Upstream), 10Upstream: [EPIC] Gather requirements from teams for Phab project management feature requests - https://phabricator.wikimedia.org/T105404 (10Aklapper) [22:41:32] 10Phabricator: Add fields to support bug specific information - https://phabricator.wikimedia.org/T92708 (10Aklapper) Could someone please explain what exactly is left in this task? (@Fjalapeno?) Nowadays we got [Forms](https://www.mediawiki.org/wiki/Phabricator/Forms) and task subtypes. If something is left, p... [22:41:50] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10Aklapper) [22:42:09] (03CR) 10jerkins-bot: [V: 04-1] Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [22:42:38] 10MediaWiki-Email, 10MediaWiki-User-management, 10Anti-Harassment, 10User-DannyS712: not possible to set email when email blocked - https://phabricator.wikimedia.org/T225872 (10DannyS712) The patched linked above added ` if ( $user->isBlockedFromEmailuser() ) { throw new UserBlockedError( $user->getBlock(... [22:44:00] (03CR) 10jerkins-bot: [V: 04-1] Let Title accept READ_LATEST in $flags fields of methods [core] - 10https://gerrit.wikimedia.org/r/520817 (owner: 10Aaron Schulz) [22:45:22] (03CR) 10jerkins-bot: [V: 04-1] Move callers away from Title::GAID_FOR_UPDATE [core] - 10https://gerrit.wikimedia.org/r/520818 (owner: 10Aaron Schulz) [22:45:54] (03Merged) 10jenkins-bot: Convert wfGetDB() calls to using getConnectionRef() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519547 (owner: 10Aaron Schulz) [22:49:19] (03PS4) 10Nray: Consolidate Page.js instance variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [22:49:21] (03CR) 10jenkins-bot: Fix types around ILoadBalancer and IResultWrapper [core] - 10https://gerrit.wikimedia.org/r/519762 (owner: 10Umherirrender) [22:53:16] (03PS5) 10Nray: Consolidate Page.js instance variables [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [22:54:46] (03CR) 10jenkins-bot: Convert wfGetDB() calls to using getConnectionRef() [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/519547 (owner: 10Aaron Schulz) [22:55:44] (03PS6) 10Nray: Consolidate Page.js instance variables and get rid of `this.options` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [22:57:03] 10MediaWiki-Email, 10MediaWiki-User-management, 10Anti-Harassment, 10Security, 10User-DannyS712: not possible to set email when email blocked - https://phabricator.wikimedia.org/T225872 (10Urbanecm) Tagging with #security, since this is de-facto request for reverting a security patch. [22:58:48] (03CR) 10jenkins-bot: rdbms: fix typo and clean up some cruft in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/520681 (owner: 10Aaron Schulz) [22:59:18] (03PS7) 10Nray: Consolidate Page.js instance variables and get rid of `this.options` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [22:59:46] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10MarcoAurelio) Triggers do seem like some sort of global Herald rules but limited to a specific column in a workboard. As such, Triggers should probably //not// be made avalaible for all users for [... [23:06:31] (03PS8) 10Nray: Consolidate Page.js instance variables and get rid of `this.options` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [23:06:41] 04(no projects): Enable convert-to-DR button for everyone on Wikimedia Commons - https://phabricator.wikimedia.org/T227301 (10DonTrung) [23:07:31] (03PS9) 10Nray: Consolidate Page.js instance variables and get rid of `this.options` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [23:07:58] 10Phabricator, 10Documentation: Document workboard column triggers - https://phabricator.wikimedia.org/T227300 (10MarcoAurelio) Tested the Triggers on T150807#5307526. The trigger seems to be executed under the person's account that moved the card to the column which has a trigger enabled, so it does not seem... [23:08:49] (03PS10) 10Nray: Consolidate Page.js instance variables and get rid of `this.options` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/520804 (https://phabricator.wikimedia.org/T193077) [23:10:53] 04(no projects): Enable convert-to-DR button for everyone on Wikimedia Commons - https://phabricator.wikimedia.org/T227301 (10DonTrung) Originally proposed by @Alexis_Jazz on May 25th (twenty-fifth), @Majora asked "Can't anyone with interface admin rights and a knowledge of javascript do this?" (as in enabling... [23:43:11] (03PS1) 10Paladox: Fix RandomSelection->render performance [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/520821 [23:46:08] (03PS2) 10Paladox: Fix RandomSelection->render performance [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/520821 [23:46:54] (03CR) 10jerkins-bot: [V: 04-1] Fix RandomSelection->render performance [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/520821 (owner: 10Paladox) [23:47:47] (03PS3) 10Paladox: Fix RandomSelection->render performance [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/520821 [23:48:23] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.13; 2019-07-09), 10Mobile: Homepage: mobile side menu copy changes - https://phabricator.wikimedia.org/T223210 (10Etonkovidova) |Before - `wmf.11`|After - betalabs |{F29681124}|{F29681126} **RTL** |Before - `wmf.11`|... [23:48:58] (03PS4) 10Paladox: Fix RandomSelection->render performance [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/520821