[00:11:45] (03Merged) 10jenkins-bot: Rewrite AbuseFilter::decodeGlobalName [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/488401 (owner: 10Daimona Eaytoy) [00:14:23] (03CR) 10jenkins-bot: Rewrite AbuseFilter::decodeGlobalName [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/488401 (owner: 10Daimona Eaytoy) [00:19:59] (03CR) 10jenkins-bot: Rewrite AbuseFilter::decodeGlobalName [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/488401 (owner: 10Daimona Eaytoy) [00:23:52] 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): History page filter revisions cannot be expanded on Minerva skin - https://phabricator.wikimedia.org/T223204 (10Edtadros) a:05Edtadros→03ovasileva === Test Result **Status:** ✅ PAS... [00:25:00] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Jdforrester-WMF) This seems to have had a ~20% speed improvement – picking two patches merged into MW-core eit... [00:26:21] 10MinervaNeue, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): History page filter revisions cannot be expanded on Minerva skin - https://phabricator.wikimedia.org/T223204 (10Edtadros) [00:34:01] (03PS8) 10Nray: Add wikidata link to overflow menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516447 (https://phabricator.wikimedia.org/T222630) [00:34:04] 10MediaWiki-General-or-Unknown, 10TechCom, 10TechCom-RFC, 10User-Daniel: Provide a reliable way to pass information between hook handlers, "hooked" objects - https://phabricator.wikimedia.org/T157402 (10Krinkle) See also T212482, which outlines a proposal based on an architecture direction presented at [Te... [00:34:26] 10MediaWiki-General-or-Unknown, 10TechCom, 10User-Daniel: Provide a reliable way to pass information between hook handlers, "hooked" objects - https://phabricator.wikimedia.org/T157402 (10Krinkle) [00:35:01] (03PS9) 10Nray: Add wikidata link to overflow menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516447 (https://phabricator.wikimedia.org/T222630) [00:35:22] 10MediaWiki-General-or-Unknown, 10TechCom, 10TechCom-RFC, 10User-Daniel: Provide a reliable way to pass information between hook handlers, "hooked" objects - https://phabricator.wikimedia.org/T157402 (10Krinkle) [00:37:10] 10CommRel-Design, 10International-Developer-Events: Visualization of Technical Events Ecosystem around Wikimania - https://phabricator.wikimedia.org/T224271 (10Rfarrand) (Ah! Sorry for not sending this last week - I wrote it all out but didnt submit. Thank goodness Phab saves answers... No worries at all about... [00:37:56] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , and 2 others: Homepage: homepage discovery for no-JS users - https://phabricator.wikimedia.org/T225318 (10Catrope) >>! In T225318#5243473, @MMiller_WMF wrote: > @Catrope told me that the sitenotice option is... [00:38:51] (03PS10) 10Nray: Add wikidata link to overflow menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516447 (https://phabricator.wikimedia.org/T222630) [00:42:01] 10Product-Analytics: Calculate and report contributors health metrics for June 2019 - https://phabricator.wikimedia.org/T225622 (10kzimmerman) [00:42:10] 10TechCom-RFC: RfC: Dismissable notices - https://phabricator.wikimedia.org/T385 (10Krinkle) 05Stalled→03Declined This seems out of scope for the RFC process as it describes problems that are: * already solved, * or; solvable with minor changes to the DismissableSiteNotice extension that do not affect the ov... [00:43:12] 10MediaWiki-Database, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Login, account creation, anything else that accesses global user throws DBReadOnlyRoleError in beta labs - https://phabricator.wikimedia.org/T225682 (10Catrope) 05Open→03Resolved [00:44:06] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 - https://phabricator.wikimedia.org/T225668 (10Catrope) It works fine for me on Android too: {F29497869} [00:44:15] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Land before Timeouts: CentralNotice tests failing due to deprecated ResourceLoader constructor - https://phabricator.wikimedia.org/T225688 (10AndyRussG) [00:46:04] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Land before Timeouts, 10Patch-For-Review, 10Security: CentralNotice banner preview: follow-up improvements - https://phabricator.wikimedia.org/T225101 (10AndyRussG) a:03AndyRussG [00:46:08] 10Community-Tech (Community-Tech-Kanban): [Timebox - 8 hours] Investigation: Watchlist Expiry - https://phabricator.wikimedia.org/T223174 (10Niharika) We discussed the investigation today in the engineering meeting and I was asked to share a guideline for what the product ought to do. The following is a **very r... [00:47:13] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 - https://phabricator.wikimedia.org/T225668 (10Catrope) >>! In T225668#5254814, @MMiller_WMF wrote: > @Catrope @SBisson @Etonko... [00:51:01] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , and 2 others: Homepage: homepage discovery for no-JS users - https://phabricator.wikimedia.org/T225318 (10Krinkle) >>! In T225318#5247164, @Cntlsn wrote: > [..] I tried disabling Js (Firefox 67) and couldn't... [00:52:42] (03CR) 10jerkins-bot: [V: 04-1] Add wikidata link to overflow menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516447 (https://phabricator.wikimedia.org/T222630) (owner: 10Nray) [01:03:37] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata, 10Wikidata-Campsite: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10Niharika) p:05Low→03Normal Raising the priority on this as it is a blocker for partial blocks... [01:15:35] (03PS1) 10Krinkle: DevelopmentSettings: Preserve non-default MainCacheType, simplify override [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) [01:17:38] (03CR) 10Krinkle: DevelopmentSettings: Preserve non-default MainCacheType, simplify override (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [01:18:05] (03CR) 10Krinkle: "check perf" [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [01:18:18] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [01:25:26] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Land before Timeouts: CentralNotice tests failing due to deprecated ResourceLoader constructor - https://phabricator.wikimedia.org/T225688 (10Krinkle) See also {c9318edc2dd531} The tests use strict mode and thus bail on warnin... [01:32:03] 10GrowthExperiments, 10GrowthExperiments- HelpModule, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10JTannerWMF) [01:33:15] (03CR) 10Kosta Harlan: [C: 03+1] "This looks better, yes. I'll wait for Amir to look at it too. Thanks Timo." [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [01:37:32] 10MediaWiki-User-management, 10Anti-Harassment: Work out how to track blocks with a cookie if there are multiple trackable blocks - https://phabricator.wikimedia.org/T225654 (10Niharika) [01:38:38] 10CX-out-of-beta, 10Language-Team (Language-2019-April-June), 10Regression, 10WorkType-Maintenance: CX2: Content Translation creates articles that have tags with cx-segment - https://phabricator.wikimedia.org/T144167 (10JTannerWMF) [01:45:01] 10MobileFrontend, 10Contributors-Team, 10Editing QA, 10Section Editing, and 5 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10Ryasmeen) [01:46:38] 10MobileFrontend, 10Contributors-Team, 10Section Editing, 10VisualEditor-MediaWiki, and 4 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10Ryasmeen) [01:50:59] (03PS11) 10Nray: Add wikidata link to overflow menu [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516447 (https://phabricator.wikimedia.org/T222630) [02:01:33] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) [02:01:55] 10OOUI, 10Patch-For-Review: Replace `em` based sizing in favor of `px` based where applicable - https://phabricator.wikimedia.org/T220671 (10Volker_E) [02:08:04] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Land before Timeouts: CentralNotice tests failing due to deprecated ResourceLoader constructor - https://phabricator.wikimedia.org/T225688 (10AndyRussG) @Krinkle Thanks!!! [02:15:28] 10CommRel-Design, 10Community comms and outreach, 10CommRel-Specialists-Support (Apr-Jun-2019): Communication rollout for Training of Trainers - https://phabricator.wikimedia.org/T222288 (10mcruzWMF) We have signoff on the [[ https://docs.google.com/document/d/1AdPgLoE1ML3Xk4QeBgasdajzdQN5O8IPw_cNaQM_YYY/edi... [02:21:03] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) >>! In T225629#5254487, @iamjessklein wrote: > thoughts/feedback are welcome either here or drawn on the [[ https://wikimedia.invisionapp.com/freehand/document/d3UL6oCs1 | free... [02:22:05] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) [03:28:06] (03PS3) 10Dan1wang: @ ("picked") operator (T223957) [wikipeg] - 10https://gerrit.wikimedia.org/r/511637 [03:44:23] 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Team 3), 10MW-1.33-release, 10Multi-Content-Revisions (Reactive): Update populateRevisionSha1.php to run over the content table - https://phabricator.wikimedia.org/T217829 (10BPirkle) The task descr... [03:44:34] (03PS1) 10BPirkle: Update populateRevisionSha1.php for MCR schema changes [core] - 10https://gerrit.wikimedia.org/r/516730 (https://phabricator.wikimedia.org/T217829) [04:00:59] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Land before Timeouts, 10Patch-For-Review: CentralNotice tests failing due to deprecated ResourceLoader constructor - https://phabricator.wikimedia.org/T225688 (10AndyRussG) >>! In T225688#5255672, @Krinkle wrote: > For your t... [04:21:57] (03PS1) 10Usmanmuhd: Throw appropriate error when wmAPI returns internal server error. [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/516732 (https://phabricator.wikimedia.org/T215222) [04:53:50] 10WikiApiary: 2016 MW cached data ? (Special pages>Maintenance reports) - https://phabricator.wikimedia.org/T225565 (10Dinoguy1000) >>the scripts just haven't been run on WikiApiary for a few years, probably because very few people are using the reports there. > That seems a bit of an odd argument to me in this... [06:19:51] (03CR) 10Ppchelko: [C: 03+1] Throw appropriate error when wmAPI returns internal server error. [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/516732 (https://phabricator.wikimedia.org/T215222) (owner: 10Usmanmuhd) [06:21:30] (03CR) 10Pwirth: [C: 03+2] Move `BSExtractFiles` maintenance script [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516630 (owner: 10Robert Vogel) [06:21:53] (03PS1) 10Pwirth: Move `BSExtractFiles` maintenance script [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/516734 [06:21:57] (03CR) 10Pwirth: [C: 03+2] Move `BSExtractFiles` maintenance script [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/516734 (owner: 10Pwirth) [06:22:57] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Carwash) Thanks for [[ https://twitter.com/salgo60/status/1138877659033874432 | your tweet ]] alerting me to this, Magnus! The majority of the photos of runestones in Alvin at the moment h... [06:23:48] (03CR) 10Pwirth: [C: 03+2] Improve search scoring [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/512676 (owner: 10ItSpiderman) [06:24:06] (03PS1) 10Pwirth: Improve search scoring [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516735 [06:24:09] (03CR) 10Pwirth: [C: 03+2] Improve search scoring [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516735 (owner: 10Pwirth) [06:26:22] (03Merged) 10jenkins-bot: Move `BSExtractFiles` maintenance script [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516630 (owner: 10Robert Vogel) [06:27:13] (03PS1) 10ItSpiderman: Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516736 [06:27:51] (03Merged) 10jenkins-bot: Move `BSExtractFiles` maintenance script [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/516734 (owner: 10Pwirth) [06:27:53] (03Merged) 10jenkins-bot: Improve search scoring [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/512676 (owner: 10ItSpiderman) [06:27:55] (03Merged) 10jenkins-bot: Improve search scoring [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516735 (owner: 10Pwirth) [06:31:29] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) Thanks feels like maybe we should group them at both places and try to have a consistency.... My unskilled guess is that its easy add identifiers in Alvin..... Search **[[ https:/... [06:36:43] (03PS1) 10ItSpiderman: Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/516737 [06:40:51] 10MediaWiki-Database, 10MediaWiki-extensions-OATHAuth, 10DBA: Schema change to oathauth_users - https://phabricator.wikimedia.org/T225643 (10Reedy) I’m not saying there won’t be another column (though I’d be surprised), but it was more blocked on some other issues with the code, I haven’t reviewed it recentl... [06:43:00] (03CR) 10Pwirth: [C: 04-1] Implement a SaferEdit EnvironmentChecker (031 comment) [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/514692 (owner: 10ItSpiderman) [06:43:40] 10ContentTranslation: Special:CXStats fails to load if there is no published translations - https://phabricator.wikimedia.org/T225620 (10Nikerabbit) Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/115b8c9ad4e44655bbdc8d1d0a4ebbe3965f51dc/includes/Translation.php#344 w... [06:44:35] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 2 others: MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID." - https://phabricator.wikimedia.org/T224605 (10noarave) @Niedz... [06:45:20] (03CR) 10Pwirth: [C: 03+2] Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/516737 (owner: 10ItSpiderman) [06:46:12] (03CR) 10Pwirth: [C: 03+2] Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516736 (owner: 10ItSpiderman) [06:48:15] (03Merged) 10jenkins-bot: Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/516737 (owner: 10ItSpiderman) [06:50:09] (03Merged) 10jenkins-bot: Make BlueSpice\Services just a pass-through for MediaWikiServices [extensions/BlueSpiceFoundation] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516736 (owner: 10ItSpiderman) [06:50:37] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515478 (owner: 10Pwirth) [06:50:43] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertLink] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515500 (owner: 10Pwirth) [06:51:07] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/513060 (owner: 10ItSpiderman) [06:51:09] (03CR) 10ArielGlenn: [C: 03+1] Clarify WikiRevision::downloadSource() and related code [core] - 10https://gerrit.wikimedia.org/r/516641 (owner: 10Lucas Werkmeister (WMDE)) [06:51:11] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [06:51:27] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515247 (owner: 10Mglaser) [06:51:54] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/515259 (owner: 10Libraryupgrader) [06:52:02] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/515267 (owner: 10Libraryupgrader) [06:52:07] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/515230 (owner: 10Libraryupgrader) [06:52:12] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/515215 (owner: 10Libraryupgrader) [06:54:25] (03CR) 10jerkins-bot: [V: 04-1] Fix dependencies [extensions/BlueSpiceInsertLink] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515500 (owner: 10Pwirth) [06:54:30] (03CR) 10jerkins-bot: [V: 04-1] Manual cherry-pick of "Enable Pasting of Text with embedded Links" [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/513060 (owner: 10ItSpiderman) [06:55:06] (03CR) 10jerkins-bot: [V: 04-1] Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [06:55:27] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies for security issues [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/515259 (owner: 10Libraryupgrader) [06:56:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies for security issues [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/515230 (owner: 10Libraryupgrader) [06:56:31] 10WikiApiary: 2016 MW cached data ? (Special pages>Maintenance reports) - https://phabricator.wikimedia.org/T225565 (10MvGulik) >(as far as I know) WikiApiary has never had a particularly thriving community Seems that way at the moment. Think that WikiApiary could do with some internal help/guides/hints that m... [06:57:57] (03CR) 10Pwirth: "check php" [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515478 (owner: 10Pwirth) [06:59:48] 10WMSE (IT): Switch crontab mailto to drift - https://phabricator.wikimedia.org/T225514 (10Sebastian_Berlin-WMSE) I changed `MAILTO` in ///etc/crontab// to drift@. Hopefully, this will send future emails the right way. [07:03:00] (03CR) 10Bmansurov: "OK, so we got the correct response code. Now is the time time investigate why this end point stopped working. Why is MediaWiki API throwin" (031 comment) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/516732 (https://phabricator.wikimedia.org/T215222) (owner: 10Usmanmuhd) [07:15:21] (03CR) 10ItSpiderman: [C: 03+2] Fix dependencies [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515247 (owner: 10Mglaser) [07:15:50] (03CR) 10Pwirth: [C: 03+2] "re-poke" [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515478 (owner: 10Pwirth) [07:16:48] (03CR) 10Pwirth: "check php" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/515267 (owner: 10Libraryupgrader) [07:16:50] (03CR) 10Fomafix: "It useful and a cache optimization to have a shared cache for modules that don't depend on a skin or on a language. To get a shared cache " [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [07:17:11] (03CR) 10Pwirth: "check php" [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/515215 (owner: 10Libraryupgrader) [07:19:12] 10Release Pipeline, 10Trending-Service, 10Patch-For-Review: Migrate trending-edits to k8s - https://phabricator.wikimedia.org/T225681 (10mobrovac) 05Open→03Invalid As of {T180384} the trending edits service is no longer a production service. [07:20:31] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Carwash) Exactly. At present it's unclear exactly at which "end" (Alvin or SRDB) the links will live, but the most likely scenario is this: Based on the runic signa that are already in Alv... [07:21:40] (03Merged) 10jenkins-bot: Fix dependencies [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515247 (owner: 10Mglaser) [07:21:52] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10ArielGlenn) p:05Triage→03High [07:22:44] (03PS3) 10Pwirth: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/514692 (owner: 10ItSpiderman) [07:23:23] (03PS3) 10Pwirth: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [07:23:43] (03PS8) 10Pwirth: [WIP] Table handling [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513597 (owner: 10ItSpiderman) [07:24:24] (03PS1) 10ItSpiderman: Add dependency to OOJSPlus [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516740 [07:24:31] (03CR) 10Pwirth: [C: 03+2] "re-poke" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/515267 (owner: 10Libraryupgrader) [07:24:38] (03CR) 10Pwirth: [C: 03+2] "re-poke" [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/515215 (owner: 10Libraryupgrader) [07:29:14] (03PS1) 10Aaron Schulz: rdbms: remove deprecated IDatabase::onTransactionIdle [core] - 10https://gerrit.wikimedia.org/r/516741 [07:30:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Table handling [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513597 (owner: 10ItSpiderman) [07:31:00] (03PS1) 10ItSpiderman: Remove unused messages [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516742 [07:35:27] 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10StevenCrossin) [07:39:13] (03CR) 10Pwirth: [C: 03+2] Remove unused messages [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516742 (owner: 10ItSpiderman) [07:39:20] (03PS1) 10Pwirth: Remove unused messages [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516743 [07:39:23] (03CR) 10Pwirth: [C: 03+2] Remove unused messages [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516743 (owner: 10Pwirth) [07:42:33] (03Merged) 10jenkins-bot: Fix dependencies [extensions/BlueSpiceCountThings] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515478 (owner: 10Pwirth) [07:45:27] (03CR) 10ItSpiderman: "recheck" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 (owner: 10ItSpiderman) [07:45:38] (03Merged) 10jenkins-bot: Remove unused messages [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516742 (owner: 10ItSpiderman) [07:46:12] (03Merged) 10jenkins-bot: Remove unused messages [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516743 (owner: 10Pwirth) [07:46:47] (03CR) 10Gergő Tisza: "> What's the use case for this as a public global service, versus it being constructed as an internal helper in EntryPoint?" [core] - 10https://gerrit.wikimedia.org/r/516577 (owner: 10Tim Starling) [07:47:12] (03CR) 10Pwirth: [C: 03+2] Add dependency to OOJSPlus [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516740 (owner: 10ItSpiderman) [07:47:44] (03PS4) 10ItSpiderman: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/514692 [07:48:23] (03Abandoned) 10ItSpiderman: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 (owner: 10ItSpiderman) [07:48:57] 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Kghbln) @StevenCrossin Please always also note the versions of PHP, MySQL, MW and UserMerge you are using. Otherwise is is pretty hard to spot the issue and why it occurs. [07:49:19] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Kghbln) [07:49:20] (03CR) 10Pwirth: [C: 03+2] Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/514692 (owner: 10ItSpiderman) [07:51:49] (03Restored) 10ItSpiderman: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 (owner: 10ItSpiderman) [07:52:00] (03PS2) 10ItSpiderman: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 [07:52:49] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata, 10Wikidata-Campsite: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10WMDE-leszek) @Niharika would you mind reminding us what is the planned timeline of the deployment... [07:53:26] (03Merged) 10jenkins-bot: Add dependency to OOJSPlus [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/516740 (owner: 10ItSpiderman) [07:54:08] (03PS3) 10ItSpiderman: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 [07:54:12] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10StevenCrossin) Ah, sorry about that, I mentioned this task to Sam, didn’t actually know where to find that info (or hadn’t actually logged a bug before!) [07:54:36] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertLink] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515500 (owner: 10Pwirth) [07:55:01] (03CR) 10Pwirth: [C: 03+2] Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 (owner: 10ItSpiderman) [07:55:13] (03Merged) 10jenkins-bot: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/514692 (owner: 10ItSpiderman) [07:55:14] (03CR) 10Usmanmuhd: ">" (031 comment) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/516732 (https://phabricator.wikimedia.org/T215222) (owner: 10Usmanmuhd) [07:55:47] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Kghbln) No worries. The info is on Special:Version. [07:56:36] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Samwilson) Thanks @StevenCrossin — I'll look into this soon I hope. We're using: MediaWiki 1.30.0 (5191b5a) PHP 5.6.33-0+deb8u1 (apache2handler) MariaD... [07:58:06] (03PS1) 10Pwirth: Fix dependencies [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/516744 [07:59:10] (03PS2) 10Pwirth: Fix dependencies [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/516744 [07:59:20] (03CR) 10DCausse: [C: 04-1] Fix param type of search terms in search related classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/515137 (owner: 10Umherirrender) [08:00:07] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Samwilson) Log entry is: > [Thu Jun 13 07:34:54.517823 2019] [:error] [...] PHP Notice: Undefined offset: 1 in /var/www/mediawiki/extensions/UserMerge/Me... [08:00:47] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Kghbln) @Kghbln Hmm, interesting that it does not work with your setup, have not checked the version of UserMerge though, however when using REL it works u... [08:01:33] (03Merged) 10jenkins-bot: Implement a SaferEdit EnvironmentChecker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516594 (owner: 10ItSpiderman) [08:01:59] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) The have * alvin-place * alvin-person * alvin-record Why not add * alvin-runestone or a more generic grouping.... Feels like Johannes Bureus needs to be part of the Alvin proje... [08:02:03] (03PS3) 10Pwirth: Fix version and dependencies [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/516744 [08:03:12] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/515230 (owner: 10Libraryupgrader) [08:03:23] (03PS1) 10ItSpiderman: Change SaferEdit Checker class name to be more descriptive [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516745 [08:04:51] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Incomplete template adaptation presented as missing - https://phabricator.wikimedia.org/T224437 (10Petar.petkovic) a:03Petar.petkovic [08:05:06] (03CR) 10ItSpiderman: [C: 03+2] Fix dependencies [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/515445 (owner: 10Pwirth) [08:05:13] (03CR) 10jerkins-bot: [V: 04-1] Fix version and dependencies [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/516744 (owner: 10Pwirth) [08:05:57] (03CR) 10ItSpiderman: [C: 03+2] Fix dependencies [extensions/BlueSpiceInsertLink] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515500 (owner: 10Pwirth) [08:06:55] (03CR) 10jerkins-bot: [V: 04-1] Change SaferEdit Checker class name to be more descriptive [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516745 (owner: 10ItSpiderman) [08:07:11] (03CR) 10jerkins-bot: [V: 04-1] build: Updating npm dependencies for security issues [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/515230 (owner: 10Libraryupgrader) [08:07:52] 10MediaWiki-extensions-UserMerge, 10Wikimedia Australia: UserMerge fails to work and returns database error. - https://phabricator.wikimedia.org/T225695 (10Samwilson) I've been meaning to upgrade the wiki anyway. Will do that and see how it goes on 1.32. [08:08:33] 10ContentTranslation: Special:CXStats fails to load if there is no published translations - https://phabricator.wikimedia.org/T225620 (10Petar.petkovic) >>! In T225620#5255813, @Nikerabbit wrote: > Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/ContentTranslation/+/115b8c9ad4e44655bbdc8d... [08:08:52] 10wikimedia.biterg.io: Consider disabling the IRC indexing on wikimedia.biterg.io - https://phabricator.wikimedia.org/T225697 (10Aklapper) p:05Triage→03Low [08:08:53] (03Merged) 10jenkins-bot: Fix dependencies [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/515445 (owner: 10Pwirth) [08:11:56] (03Merged) 10jenkins-bot: Fix dependencies [extensions/BlueSpiceInsertLink] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/515500 (owner: 10Pwirth) [08:12:49] 04(no projects): During upgrade "php update.php" fails (MW 1.32.2) - https://phabricator.wikimedia.org/T225699 (10Xpolish2xpolish) [08:13:37] (03PS4) 10Pwirth: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [08:14:35] (03CR) 10Reedy: [C: 04-1] "So, the DBAs require (rightly) that patches are merged into master (as a confirmation it's "complete"), and a config flag to be set to gua" (036 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/496451 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [08:15:28] 10MediaWiki-Installer, 10MediaWiki-User-management: During upgrade "php update.php" fails (MW 1.32.2) - https://phabricator.wikimedia.org/T225699 (10Reedy) [08:19:40] (03PS1) 10Pwirth: Fix dependencies [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/516746 [08:20:06] (03CR) 10Pwirth: [C: 03+2] Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [08:26:08] (03Merged) 10jenkins-bot: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/513627 (owner: 10Mglaser) [08:26:47] (03PS2) 10Pwirth: build: Updating npm dependencies for security issues [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/515230 (owner: 10Libraryupgrader) [08:29:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): on production enable bugfix for wbeditentity setting aliases to empty array - https://phabricator.wikimedia.org/T223303 (10Michael) Testing this during SWAT: # ensure that th... [08:30:17] (03PS1) 10ItSpiderman: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516747 [08:30:29] (03Abandoned) 10Pwirth: Fix version and dependencies [extensions/BlueSpiceSubPageTree] - 10https://gerrit.wikimedia.org/r/516744 (owner: 10Pwirth) [08:31:24] (03PS2) 10ItSpiderman: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516747 [08:32:43] 10MediaWiki-extensions-WikibaseClient, 10Maps, 10Wikidata: Maplink (via Wikidata) shows only empty window without map on la.wikipedia - https://phabricator.wikimedia.org/T225350 (10Pikne) [08:32:46] (03CR) 10ItSpiderman: [C: 03+2] Fix dependencies [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/516746 (owner: 10Pwirth) [08:35:34] (03CR) 10Pwirth: [C: 03+1] "awaiting i18n review" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516747 (owner: 10ItSpiderman) [08:36:00] 10ContentTranslation: Special:CXStats fails to load if there is no published translations - https://phabricator.wikimedia.org/T225620 (10Jpita) >>! In T225620#5255936, @Petar.petkovic wrote: >>>! In T225620#5255813, @Nikerabbit wrote: >> Could try replacing https://gerrit.wikimedia.org/g/mediawiki/extensions/Con... [08:37:04] (03PS1) 10ItSpiderman: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516748 [08:37:15] (03CR) 10Pwirth: [C: 03+2] Change SaferEdit Checker class name to be more descriptive [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516745 (owner: 10ItSpiderman) [08:37:19] (03CR) 10Pwirth: [V: 03+2 C: 03+2] Change SaferEdit Checker class name to be more descriptive [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516745 (owner: 10ItSpiderman) [08:37:44] 10MediaWiki-Revision-backend, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Contractor - Ready), 10MW-1.32-release, and 3 others: includes/Revision/RevisionStore.php: Main slot of revision (number) not found in database! - https://phabricator.wikimedia.org/T212428 (10Aklapper) Adding #mw-1.32-re... [08:39:04] 10MediaWiki-Installer, 10MediaWiki-User-management: During upgrade to 1.32.2 "php update.php" fails: "UserGroupMembership::insert() needs a positive user ID" - https://phabricator.wikimedia.org/T225699 (10Aklapper) [08:39:39] (03PS2) 10ItSpiderman: Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516748 [08:43:04] (03CR) 10jerkins-bot: [V: 04-1] Insert Media: Create a file link for files [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/516748 (owner: 10ItSpiderman) [08:45:38] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Patch-For-Review, 10User-DannyS712: Special:GlobalRenameRequest is missing a "help" link - https://phabricator.wikimedia.org/T225583 (10DannyS712) p:05Triage→03Low I can't seem to figure this one out - the build tests keep failing. If anyone else wa... [08:46:14] 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Performance-Team (Radar): [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages - https://phabricator.wikimedia.org/T220751 (10Peter) I've had a go today to first try to automate it, so we can find these kind of things in the f... [08:46:17] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: REST API Parameter Validation - https://phabricator.wikimedia.org/T223239 (10Tgr) >>! In T223239#5249878, @Ottomata wrote: > What is 'that' in this case? The lowercase und... [08:46:19] 10Timeless: Watchlist options looks bad in non-JavaScript interface - https://phabricator.wikimedia.org/T225412 (10putnik) It can be fixed with this code: ` .mw-input-with-label { display: inline-block; } ` But it is desirable to understand why it has `display: block` now. [08:47:13] 10MediaWiki-extensions-UrlShortener, 10Patch-For-Review, 10User-DannyS712: Special:UrlShortener should have a "help" link - https://phabricator.wikimedia.org/T224861 (10DannyS712) p:05Triage→03Low [08:50:16] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10fgiunchedi) a:03fgiunchedi I'll be looking into renewing this key [08:53:36] 10Shape Expressions: Add labels to Schemas on Special:AllPages - https://phabricator.wikimedia.org/T225700 (10Lea_Lacroix_WMDE) [08:54:23] 10Shape Expressions: Add EntitySchemas to the Query Service - https://phabricator.wikimedia.org/T225701 (10Lea_Lacroix_WMDE) [08:54:44] (03Merged) 10jenkins-bot: Fix dependencies [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/516746 (owner: 10Pwirth) [08:57:22] 10Shape Expressions: Add labels to Schemas on Special:AllPages - https://phabricator.wikimedia.org/T225700 (10Lydia_Pintscher) [09:07:12] 10MediaWiki-extensions-WikibaseClient, 10Maps, 10Wikidata: Maplink (via Wikidata) shows only empty window without map on la.wikipedia - https://phabricator.wikimedia.org/T225350 (10Lydia_Pintscher) Maybe @hoo or @Tpt have an idea? [09:10:03] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2019), 10Documentation: Enable UserFeedback Gadget on MediaWiki - https://phabricator.wikimedia.org/T225584 (10Wargo) Could you confirm it changed? [09:25:08] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10Esanders) > "X" in the title bar: In instances when a contributor lands back on the card after having made a change, do you think the "x" will lead people to hesitate, concerned that tap... [09:26:32] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [09:35:42] 10Wikimedia-Portals: Improve presentation of apps on portal - https://phabricator.wikimedia.org/T225648 (10schoenbaechler) [09:40:23] 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Performance-Team (Radar): [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages - https://phabricator.wikimedia.org/T220751 (10Peter) At least in theory you can tell the webdriver that you wanna have the control back asap the n... [09:41:09] 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Performance-Team (Radar): [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages - https://phabricator.wikimedia.org/T220751 (10Peter) a:05Peter→03nray Signing over to you Nick to answer the questions. [09:42:56] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team, 10Patch-For-Review: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10fgiunchedi) Ok this should be done now, the new... [09:43:37] 10MediaWiki-Configuration, 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review, 10User-zeljkofilipin: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis - https://phabricator.wikimedia.org/T224899 (10zeljkofilipin) >>! In T224899#5253379, @zeljkofilipin wrote... [09:46:40] 10MediaWiki-Configuration, 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review, 10User-zeljkofilipin: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis - https://phabricator.wikimedia.org/T224899 (10zeljkofilipin) So, the problem is that either `InitialiseSe... [09:46:43] 10Wikimedia-Portals: Improve presentation of apps on portal - https://phabricator.wikimedia.org/T225648 (10Charlotte) How about: Save your favorite articles to read offline, sync your reading lists across devices and customise your reading experience with the official Wikipedia app. I'm sure there's a better w... [09:46:49] 10MediaWiki-User-preferences, 10MW-1.32-release: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) [09:47:07] 10Wikimedia-Portals, 10Wikipedia-Android-App-Backlog: Improve presentation of apps on portal - https://phabricator.wikimedia.org/T225648 (10Charlotte) [09:48:01] 10MediaWiki-Configuration, 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review, 10User-zeljkofilipin: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis - https://phabricator.wikimedia.org/T224899 (10hashar) From https://logstash-beta.wmflabs.org/app/kibana... [09:48:17] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18): Expose PHP7/HHVM to NavTiming in a header, send with navtiming beacon so we can use it as a dimension - https://phabricator.wikimedia.org/T211906 (10Gilles) [09:48:38] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team, 10Patch-For-Review: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10fgiunchedi) Instructions at https://wikitech.wi... [09:48:41] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Add typography section to Android theme guidelines - https://phabricator.wikimedia.org/T222700 (10Charlotte) p:05Triage→03Normal [09:48:55] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Add typography section to Android theme guidelines - https://phabricator.wikimedia.org/T222700 (10Charlotte) [09:48:57] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Update “Android theme guidelines“ page - https://phabricator.wikimedia.org/T218102 (10Charlotte) [09:50:14] 10MediaWiki-User-preferences, 10OOUI, 10MW-1.32-release: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) Did you disable all extensions to test? Not blaming you, but the function is a bit bad at giving us a clue as to where it might be being called from... `lang=php... [09:50:34] 04(no projects): Failure to publish completed translation - https://phabricator.wikimedia.org/T225702 (10Arjunaraoc) [09:52:49] 10Library-Card-Platform: Migrate project to Docker - https://phabricator.wikimedia.org/T209835 (10Samwalton9) 05Open→03Resolved [09:53:16] 10Wikimedia-Portals, 10Wikipedia-Android-App-Backlog: Improve presentation of apps on portal - https://phabricator.wikimedia.org/T225648 (10schoenbaechler) [09:53:19] 10Library-Card-Platform: Update terms of use with data processing information - https://phabricator.wikimedia.org/T191889 (10Samwalton9) a:05Samwalton9→03None [09:54:49] 10MediaWiki-Configuration, 10Beta-Cluster-Infrastructure, 10Release-Engineering-Team, 10Patch-For-Review, 10User-zeljkofilipin: Fatal error Cannot redeclare wmfLabsSettings() on Beta cluster wikis - https://phabricator.wikimedia.org/T224899 (10hashar) Tldr: someone would need to find a stacktrace or ad... [09:56:51] 10Wikidata-Termbox-Iteration-17: License Overlay does not disappear after clicking publish - https://phabricator.wikimedia.org/T225703 (10Matthias_Geisler_WMDE) [09:56:58] 10Wikidata-Termbox-Iteration-17: License Overlay does not disappear after clicking publish - https://phabricator.wikimedia.org/T225703 (10Matthias_Geisler_WMDE) a:03Matthias_Geisler_WMDE [10:00:19] (03CR) 10Daniel Kinzler: "> This is both more correct conceptually (if the move-subpages" [core] - 10https://gerrit.wikimedia.org/r/516614 (https://phabricator.wikimedia.org/T225366) (owner: 10Gergő Tisza) [10:00:55] (03CR) 10Daniel Kinzler: [V: 03+1] "Verified manually on my laptop." [core] - 10https://gerrit.wikimedia.org/r/516614 (https://phabricator.wikimedia.org/T225366) (owner: 10Gergő Tisza) [10:01:22] (03CR) 10Daniel Kinzler: [V: 03+1 C: 03+2] Do move options checks before the move [core] - 10https://gerrit.wikimedia.org/r/516614 (https://phabricator.wikimedia.org/T225366) (owner: 10Gergő Tisza) [10:02:54] (03PS1) 10Hashar: (DO NOT SUBMIT) build: MWBot in verbose mode [core] - 10https://gerrit.wikimedia.org/r/516754 [10:03:17] (03CR) 10Hashar: [C: 04-2] (DO NOT SUBMIT) build: MWBot in verbose mode [core] - 10https://gerrit.wikimedia.org/r/516754 (owner: 10Hashar) [10:03:36] (03CR) 10Bmansurov: "> Patch Set 1:" (031 comment) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/516732 (https://phabricator.wikimedia.org/T215222) (owner: 10Usmanmuhd) [10:03:38] (03CR) 10Aaron Schulz: [C: 03+1] "LGTM. I might split out some private methods later (e.g. from cancelAtomic)." [core] - 10https://gerrit.wikimedia.org/r/514370 (owner: 10Anomie) [10:03:42] (03CR) 10Hashar: [C: 04-2] "Trying to get a bit more details from MWBot and see whether it might be unusually slow ;]" [core] - 10https://gerrit.wikimedia.org/r/516754 (owner: 10Hashar) [10:03:57] (03CR) 10D3r1ck01: "recheck, could be affected by T219440" [core] - 10https://gerrit.wikimedia.org/r/516667 (owner: 10D3r1ck01) [10:05:08] 10Library-Card-Platform: CSV download button server error for partners marked not available - https://phabricator.wikimedia.org/T225705 (10Samwalton9) [10:05:24] 10Library-Card-Platform: Improve FTP documentation to smooth common permission errors - https://phabricator.wikimedia.org/T209842 (10Samwalton9) p:05Triage→03Normal [10:05:26] 10Library-Card-Platform: Update TWLight documentation - https://phabricator.wikimedia.org/T209843 (10Samwalton9) p:05Triage→03Normal [10:05:31] 10Library-Card-Platform: Distribute djmail across the mx-out pool - https://phabricator.wikimedia.org/T213204 (10Samwalton9) p:05Triage→03Low [10:05:35] 10Library-Card-Platform: Track average number of accounts per user - https://phabricator.wikimedia.org/T224550 (10Samwalton9) p:05Triage→03Normal [10:05:40] 10Library-Card-Platform: CSV download button server error for partners marked not available - https://phabricator.wikimedia.org/T225705 (10Samwalton9) p:05Triage→03Low [10:07:05] (03CR) 10Daniel Kinzler: [C: 03+2] "@clarakosi: It's a little more clear to use Verified +1 to indicate that you tested (instead of Code-Review +1). But no big deal." [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/512467 (https://phabricator.wikimedia.org/T207977) (owner: 10Eranroz) [10:07:10] 10MediaWiki-Export-or-Import, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): improve sync process to wikitech-static - https://phabricator.wikimedia.org/T225621 (10ArielGlenn) [10:08:26] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Tweak gradient at bottom of cards (captions and descriptions) - https://phabricator.wikimedia.org/T224500 (10schoenbaechler) Hey @cooltey, do I understand correctly that both screenshots show the same gradient overlay in different situations... [10:08:58] (03CR) 10Daniel Kinzler: [C: 03+2] [wip]Using new buildPrevNextNavigation [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/516678 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:09:38] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Tweak gradient at bottom of cards (captions and descriptions) - https://phabricator.wikimedia.org/T224500 (10schoenbaechler) If yes, I think it looks fine like that! [10:10:22] (03PS3) 10Aaron Schulz: rdbms: implement strictor ownership of LoadBalancer by LBFactory [core] - 10https://gerrit.wikimedia.org/r/516044 [10:10:31] (03CR) 10Daniel Kinzler: [C: 03+2] Using new buildPrevNextNavigation [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/516655 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:12:12] 04(no projects): Failure to publish completed translation - https://phabricator.wikimedia.org/T225702 (10Arjunaraoc) Javascript console log is given below. Error: Attempting to save section 1 having no section state. load.php:2324:731 jQuery 2 forEach self-hosted:262 jQuery 3 self-... [10:12:31] (03CR) 10Daniel Kinzler: [C: 03+2] Using new buildPrevNextNavigation (032 comments) [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/514731 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:13:35] (03Merged) 10jenkins-bot: Do move options checks before the move [core] - 10https://gerrit.wikimedia.org/r/516614 (https://phabricator.wikimedia.org/T225366) (owner: 10Gergő Tisza) [10:15:48] 04(no projects): Failure to publish completed translation - https://phabricator.wikimedia.org/T225702 (10Arjunaraoc) {F29504999} Screenshot uploaded showing the failure in publishing [10:15:50] (03CR) 10jenkins-bot: Do move options checks before the move [core] - 10https://gerrit.wikimedia.org/r/516614 (https://phabricator.wikimedia.org/T225366) (owner: 10Gergő Tisza) [10:17:23] 10Library-Card-Platform: Migrate project to Docker - https://phabricator.wikimedia.org/T209835 (10Samwalton9) https://github.com/WikipediaLibrary/TWLight/pull/270 [10:17:44] 10Library-Card-Platform: Give advance renewal notice for partners with fixed account lengths - https://phabricator.wikimedia.org/T206511 (10Samwalton9) Docker is now integrated and django-cron is available. We can move ahead with adding a cron job for this. [10:18:35] 04(no projects): Failure to publish completed translation - https://phabricator.wikimedia.org/T225702 (10Arjunaraoc) {F29505114} Showing status of translation [10:21:55] (03PS1) 10Aaron Schulz: rdbms: improve exception handling in Database [core] - 10https://gerrit.wikimedia.org/r/516756 [10:23:21] 10MediaWiki-Recent-changes, 10Growth-Team: New pages on Special:RecentChanges: Sometimes pages deleted and recreated show the wrong old version - https://phabricator.wikimedia.org/T222838 (10Trizek-WMF) We have two possibilities: * create a tag to highlight history fusions or pages undeletions. Maybe somethin... [10:26:46] 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Document prerequisites and steps to have Growth team prototypes deployed on a wiki - https://phabricator.wikimedia.org/T220209 (10Trizek-WMF) >>! In T220209#5238361, @kostajh wrote: > @MMiller_WMF @Trizek-WMF just to note, the [phab template](https://... [10:31:04] (03Merged) 10jenkins-bot: Using new buildPrevNextNavigation [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/512467 (https://phabricator.wikimedia.org/T207977) (owner: 10Eranroz) [10:31:06] (03Merged) 10jenkins-bot: [wip]Using new buildPrevNextNavigation [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/516678 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:31:08] (03Merged) 10jenkins-bot: Using new buildPrevNextNavigation [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/516655 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:31:10] (03Merged) 10jenkins-bot: Using new buildPrevNextNavigation [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/514731 (https://phabricator.wikimedia.org/T207977) (owner: 10Clarakosi) [10:32:49] 10Desktop, 10Growth Design , 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: layout and UI details - https://phabricator.wikimedia.org/T218966 (10Cntlsn) [10:33:02] (03CR) 10jerkins-bot: [V: 04-1] rdbms: improve exception handling in Database [core] - 10https://gerrit.wikimedia.org/r/516756 (owner: 10Aaron Schulz) [10:35:49] (03PS1) 10Hashar: Isolate globals for ContentSecurityPolicy tests [core] - 10https://gerrit.wikimedia.org/r/516759 [10:36:44] (03CR) 10Hashar: "That fix tests on my local setup that had "$wgResourceBasePath = '/';"" [core] - 10https://gerrit.wikimedia.org/r/516759 (owner: 10Hashar) [10:51:45] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2019), 10Documentation: Enable UserFeedback Gadget on MediaWiki - https://phabricator.wikimedia.org/T225584 (10Tomybrz) >>! In T225584#5256051, @Wargo wrote: > Could you confirm it changed yeah working [10:56:57] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-April-June): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10santhosh) @diego I was processing the JSON files and trying to understand the values. {F29506077 size=full} In the above mapping, I e... [11:02:18] (03PS1) 10D3r1ck01: htmlform: Reveal method getOOUI() is called from when spitting deprecation notice [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) [11:07:09] (03PS2) 10D3r1ck01: htmlform: Reveal method getOOUI() is called from when spitting deprecation notice [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) [11:10:06] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review, 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Ladsgroup) >>! In T225496#5255602, @Jdforrester-WMF wrote: > This seems to have had a ~2... [11:12:59] (03PS3) 10D3r1ck01: htmlform: Reveal method getOOUI() is called from when spitting deprecation notice [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) [11:14:14] (03CR) 10Ladsgroup: [C: 04-1] "I don't know why or how but this patch seems to rollback to SqlCache which is not intentional. (From https://integration.wikimedia.org/ci/" [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [11:23:45] 10ISA: Match campaign directory page to mocks and fix Datatable plugin - https://phabricator.wikimedia.org/T225714 (10Seantime) [11:23:51] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Integrate template parameter alignments in Content Translation to improve automatic template support - https://phabricator.wikimedia.org/T224721 (10santhosh) After a brief analysis of the generated JSON mapping, this is what I am planning to do:... [11:26:23] (03PS4) 10D3r1ck01: htmlform: Reveal method getOOUI() is called from when spitting deprecation notice [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) [11:28:18] (03PS1) 10Tim Starling: Add wmerrors.error_script_file [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516763 [11:36:45] 10MediaWiki-User-preferences, 10OOUI, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Aklapper) [11:40:00] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) (owner: 10D3r1ck01) [11:40:22] 10MediaWiki-General-or-Unknown: The sidebar should have shortcuts - https://phabricator.wikimedia.org/T225715 (10jeblad) [11:44:58] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10Tkshamburg) Hi @fgiunchedi , thanks for creating the new key (now 10... [11:46:35] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Reference marked as missing but successfully adapted - https://phabricator.wikimedia.org/T225716 (10Pginer-WMF) [11:48:11] 10MediaWiki-Comment-backend, 10MediaWiki-User-management, 10Anti-Harassment, 10Chinese-Sites, 10Wikimedia-production-error: InvalidArgumentException from SpecialBlock.php: "$comment can not be null" - https://phabricator.wikimedia.org/T222170 (10Tchanders) @A2093064 The broken appearance of the page seem... [11:50:04] 10Wikidata wb_terms Trailblazing, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18): Remove fallback to master logic from resolver - https://phabricator.wikimedia.org/T225626 (10alaa_wmde) 05Open→03Resolved [11:58:27] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Meeksjd) I appear to be also running into this error. I have run both run populateRevisionSha1 and populateC... [12:01:22] 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Performance-Team (Radar): [Bug] Extreme latency due to JavaScript parsing on DOM-heavy pages - https://phabricator.wikimedia.org/T220751 (10Peter) One last thing: It's good to turn on screenshots, that makes easier to understand what happen... [12:01:22] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Reference marked as missing but successfully adapted - https://phabricator.wikimedia.org/T225716 (10Pginer-WMF) [12:05:08] 10CX-analytics, 10Language-Team (Language-2019-April-June): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Amire80) I'm trying to resolve it together with T209868#5232506. I need the data about published translations, deleted translations, and tr... [12:05:31] 10CX-analytics, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Extend CX2 translations graph to show also published translations that need review - https://phabricator.wikimedia.org/T209868 (10Amire80) Relevant update at T210138#5256469. [12:08:29] 10MediaWiki-Core-Testing, 10MediaWiki-JobQueue: HashRingTest::testHashRingKetamaMode takes 3+ seconds - https://phabricator.wikimedia.org/T225719 (10hashar) [12:11:05] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [12:22:54] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10fgiunchedi) >>! In T225601#5256399, @Tkshamburg wrote: > Hi @fgiunche... [12:32:36] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10Tkshamburg) Everything is fine now, "apt update" shows no errors now.... [12:33:59] 10Product-Analytics: Determine the pageview (and if possible, search impression) impact of automatic SERP translations - https://phabricator.wikimedia.org/T222154 (10JTannerWMF) Hey @chelsyx, how is this this coming along? [12:34:56] (03PS6) 10Esanders: Citation needed template handling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/477910 (https://phabricator.wikimedia.org/T211243) [12:41:10] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 - https://phabricator.wikimedia.org/T225668 (10Cntlsn) @Catrope yep! and happy to help with debugging. [12:54:58] (03PS7) 10Esanders: Citation needed template handling [extensions/Cite] - 10https://gerrit.wikimedia.org/r/477910 (https://phabricator.wikimedia.org/T211243) [12:56:09] 10QuickSurveys, 10Audiences-QA (RW-Test-Cases), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Surveys: Allow quicksurveys to target based on registration date - https://phabricator.wikimedia.org/T218304 (10pmiazga) @Isaac yes, you're correct. Looks like I mixed up... [12:57:43] (03PS1) 10Duncancrane: Fixed error when saving with | not in {{}} or [] [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 [12:58:41] 10Advanced Mobile Contributions, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Mobile, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Fix Special:RecentChanges dropdown widget on mobile - https://phabricator.wikimedia.org/T225499 (10Jdrewniak) @matmarex thanks for the insight. I... [12:59:07] (03PS1) 10Pmiazga: Noop: Fix incorrect documentation and test unit errors [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/516768 (https://phabricator.wikimedia.org/T218304) [13:00:05] (03CR) 10Duncancrane: "Would be grateful if you would review my fix for | outside of {{}} or [] causing error message. Many tanks" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [13:06:29] 10ContentTranslation: Special:CXStats fails to load if there is no published translations - https://phabricator.wikimedia.org/T225620 (10Nikerabbit) >>! In T225620#5255997, @Jpita wrote: > you can't "reset" the environment? One can do a fresh install by dropping the database. But on the other hand, at least my... [13:12:42] (03PS1) 10Aaron Schulz: Avoid use of deprecated Database::reportConnectionError() [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/516770 [13:12:48] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated Database::reportConnectionError() [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/516770 (owner: 10Aaron Schulz) [13:16:06] (03PS1) 10Madwarakshay: examples.php [extensions/examples] - 10https://gerrit.wikimedia.org/r/516772 [13:18:15] 10MediaWiki-Releasing, 10Operations, 10Parsoid, 10Release-Engineering-Team: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10fgiunchedi) 05Open→03Resolved No problem @Tkshamburg ! Thanks for... [13:19:20] (03PS1) 10Michael Große: Edit should be autopatrolled as usual [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/516773 (https://phabricator.wikimedia.org/T224495) [13:21:37] 10Product-Analytics: Calculate and report contributors health metrics for May 2019 - https://phabricator.wikimedia.org/T224711 (10Neil_P._Quinn_WMF) >>! In T224711#5254090, @kzimmerman wrote: > And roughly outlined the dates/use cases here: https://office.wikimedia.org/wiki/Product_Analytics/Monthly_Health_Metri... [13:23:37] (03PS1) 10Niedzielski: WIP: Revert "temporarily disabling failing browser tests for language selector" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 [13:23:53] 10MediaWiki-Internationalization, 10MediaWiki-extensions-General, 10Core Platform Team (Decoupling (CDP2)), 10Core Platform Team Kanban (Team 3), and 2 others: remove prev/next message dependency from Language - https://phabricator.wikimedia.org/T207977 (10Clarakosi) [13:23:55] 10MediaWiki-API, 10MediaWiki-Logging, 10MediaWiki-Page-deletion, 10Core Platform Team Kanban (Waiting for Review), and 2 others: PHP error: Undefined index: 6::ofield and 7::nfield (from DeleteLogFormatter.php) - https://phabricator.wikimedia.org/T224815 (10Anomie) 05Open→03Resolved a:03Anomie [13:26:42] (03CR) 10Se4598: [C: 03+1] Adding a defined check to overrideConfig method [core] - 10https://gerrit.wikimedia.org/r/512966 (https://phabricator.wikimedia.org/T224287) (owner: 10ValeryanM) [13:27:10] 10MediaWiki-Database, 10MediaWiki-extensions-OATHAuth, 10DBA: Schema change to oathauth_users - https://phabricator.wikimedia.org/T225643 (10jcrespo) Again, just to be clear, we don't require a feature flag (although it is usually nice to have), just that we wait for the code to be final (for some definition... [13:29:16] (03CR) 10Niedzielski: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (owner: 10Niedzielski) [13:31:15] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Reference marked as missing but successfully adapted - https://phabricator.wikimedia.org/T225716 (10Pginer-WMF) [13:31:17] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Tracking-Neverending: CX2: Support for References - https://phabricator.wikimedia.org/T200786 (10Pginer-WMF) [13:31:35] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Reference marked as missing but successfully adapted - https://phabricator.wikimedia.org/T225716 (10Pginer-WMF) p:05Triage→03Normal [13:32:43] 10Product-Analytics: Calculate and report contributors health metrics for May 2019 - https://phabricator.wikimedia.org/T224711 (10Neil_P._Quinn_WMF) 05Open→03Resolved [13:33:13] (03PS1) 10Madwarakshay: abc [extensions/examples] - 10https://gerrit.wikimedia.org/r/516775 [13:34:59] (03PS2) 10Michael Große: Edit should be autopatrolled as usual [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/516773 (https://phabricator.wikimedia.org/T224495) [13:36:45] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10SBisson) >>! In T216220#5251268, @MMiller_WMF wrote: >... [13:36:59] (03CR) 10Niedzielski: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (owner: 10Niedzielski) [13:39:42] 10ISA: Campaign page - https://phabricator.wikimedia.org/T221929 (10Eugene233) [13:39:44] 10ISA, 10Patch-For-Review: Add Export Campaign statistics feature - https://phabricator.wikimedia.org/T222303 (10Eugene233) 05Open→03Resolved Marking as resolved. [13:40:32] 04(no projects): APISite.fromDBName does not work for some wikis - https://phabricator.wikimedia.org/T225723 (10Xqt) [13:41:05] 10Product-Analytics, 10Growth-Team (Current Sprint): Growth: power calculations for experiments - https://phabricator.wikimedia.org/T201658 (10mpopov) Aw, you're very welcome, Morten! :D [13:41:07] 04(no projects): APISite.fromDBName does not work for some wikis - https://phabricator.wikimedia.org/T225723 (10Xqt) p:05Triage→03High [13:41:52] 04(no projects): APISite.fromDBName does not work for some wikis - https://phabricator.wikimedia.org/T225723 (10Xqt) [13:42:20] 04(no projects): APISite.fromDBName does not work for some wikis - https://phabricator.wikimedia.org/T225723 (10Xqt) [13:46:54] (03PS2) 10Krinkle: DevelopmentSettings: Preserve non-default MainCacheType, simplify override [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) [13:48:45] (03CR) 10Kosta Harlan: DevelopmentSettings: Preserve non-default MainCacheType, simplify override (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [13:50:35] (03CR) 10Krinkle: "From the Jenkins artefacts, the generated LocalSettings.php file contains, appended after DevelopmentSettings inclusion:" [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [13:51:57] (03PS1) 10DCausse: Remove CirrusSearchFulltextQueryBuilder[Complete] hooks [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/516777 (https://phabricator.wikimedia.org/T216429) [13:53:23] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: Add Redux to MobileFrontend - https://phabricator.wikimedia.org/T225460 (10Niedzielski) [13:53:39] 10CirrusSearch, 10Discovery-Search: Cleanup old Wikibase CirrusSearch config in wmf mediawiki-config - https://phabricator.wikimedia.org/T225724 (10dcausse) [13:53:40] (03CR) 10Niedzielski: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (owner: 10Niedzielski) [13:53:52] (03PS1) 10Matthias Mullie: Consistent beta wikidata urls, without www [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/516778 [13:54:02] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10alexhollender) @nray I didn't realize that wikidata items could show up on user pages. I'd say the pr... [13:55:28] 10CirrusSearch, 10Discovery-Search: Cleanup old Wikibase CirrusSearch config in wmf mediawiki-config - https://phabricator.wikimedia.org/T225724 (10dcausse) p:05Triage→03Normal [13:55:37] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Etonkovidova) [13:55:39] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage mobile: the icon image=message not displayed in 'Confirm your email' - https://phabricator.wikimedia.org/T225615 (10Etonkovidova) 05Open→03Resolved a:03Etonkovidova [13:56:19] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-April-June): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10diego) If I understood correctly, you are asking why two exacts strings are not having distance = 0; this is because there is not stri... [13:58:50] (03PS2) 10Pwirth: [WIP] Rework TemplateHelper and global template system for RL. ERM:15460 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/516616 [14:00:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Rework TemplateHelper and global template system for RL. ERM:15460 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/516616 (owner: 10Pwirth) [14:01:14] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10iamjessklein) im thinking about: >"X" in the title bar: In instances when a contributor lands back on the card after having made a change, do you think the "x" will lead people to hesit... [14:01:37] (03CR) 10Dbarratt: [C: 04-1] [WIP] Add Special:Mute page (039 comments) [core] - 10https://gerrit.wikimedia.org/r/511781 (https://phabricator.wikimedia.org/T218265) (owner: 10Dmaza) [14:08:01] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Kanban (Team 2): Security Review of RESTBagOStuff - https://phabricator.wikimedia.org/T221986 (10EvanProdromou) We had an email conversation with @sbassett about security review of this component. He reviewed @BPirkle 's patches on... [14:08:31] (03CR) 10Niedzielski: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (owner: 10Niedzielski) [14:09:06] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/516777 (https://phabricator.wikimedia.org/T216429) (owner: 10DCausse) [14:11:03] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) Thank you for explaining @esanders + @iamjessklein...all that you described in T225629#5256058 and T225629#5256664 sounds good to me. [14:11:06] (03PS3) 10Krinkle: DevelopmentSettings: Preserve non-default MainCacheType, simplify override [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) [14:11:08] (03PS1) 10Krinkle: installer: Detect APC for MainCacheType in CLI installer [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) [14:13:57] 10MediaWiki-Export-or-Import, 10wikitech.wikimedia.org, 10MW-1.31-release, 10Patch-For-Review, 10cloud-services-team (Kanban): importDump.php --uploads crashes on wikitech-static - https://phabricator.wikimedia.org/T206013 (10ArielGlenn) Found this. And it was silly. Just like Camelot. It's gotten a cop... [14:18:02] (03CR) 10Anomie: [C: 04-1] "> # Unit testing: we want to be able to mock the router in EntryPoint tests." [core] - 10https://gerrit.wikimedia.org/r/516577 (owner: 10Tim Starling) [14:18:34] (03PS4) 10Krinkle: DevelopmentSettings: Remove redundant CacheType overrides [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) [14:20:28] (03PS1) 10ArielGlenn: when getting file (img) properties, suppress whines that it's not xml [core] - 10https://gerrit.wikimedia.org/r/516787 (https://phabricator.wikimedia.org/T206013) [14:21:21] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-April-June): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10santhosh) I will clarify my question. We wanted to use a threshold score. Any mapping below that score wont be used. When `referimento`... [14:22:15] 10MediaWiki-Export-or-Import, 10wikitech.wikimedia.org, 10MW-1.31-release, 10Patch-For-Review, 10cloud-services-team (Kanban): importDump.php --uploads crashes on wikitech-static - https://phabricator.wikimedia.org/T206013 (10ArielGlenn) Testing was done using a tiny xml file, running: ` root@wikitech-st... [14:26:39] 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14): Don't offer email input in help panel when email address is already set - https://phabricator.wikimedia.org/T222846 (10Etonkovidova) 05Open→03Resolved I checked betalabs eventlogging (the most rece... [14:26:51] (03CR) 10Krinkle: "In case of HHVM, its "error_document500" is perhaps somewhat related to this [1][2]. I haven't tried to inspect $_SERVER there or the back" [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516763 (owner: 10Tim Starling) [14:28:02] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile, 10Patch-For-Review: Homepage: recent questions links on mobile go to desktop site - https://phabricator.wikimedia.org/T225660 (10SBisson) I'm not able to reproduce this on betalabs. @Etonkovidova if you reported this initially. Can y... [14:28:19] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile, 10Patch-For-Review: Homepage: link to "Guidelines for user pages" leads to desktop version - https://phabricator.wikimedia.org/T225661 (10SBisson) I'm not able to reproduce this on betalabs. @Etonko... [14:29:51] (03CR) 10Anomie: "A few preliminary notes. Apologies if I'm stating the obvious in some places." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/516059 (https://phabricator.wikimedia.org/T222224) (owner: 10Ladsgroup) [14:33:22] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: add sub-header text about user longevity to mobile homepage - https://phabricator.wikimedia.org/T225663 (10SBisson) Pinging @Jdlrobson, @Niedzielski, @pmiazga Is there a simple way to display the userpage "tagline" on Special:H... [14:35:16] (03CR) 10Krinkle: [C: 03+2] Noop: Fix incorrect documentation and test unit errors [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/516768 (https://phabricator.wikimedia.org/T218304) (owner: 10Pmiazga) [14:36:04] 10Library-Card-Platform: Add a new script or flag for reloading gunicorn or running collectstatic when required - https://phabricator.wikimedia.org/T209838 (10jsn.sherman) 05Open→03Resolved This was closed when we moved to docker. [14:36:41] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile: Homepage: start module layout on iOS Safari 10 and iOS Chrome 60.0.3112.89 - https://phabricator.wikimedia.org/T225668 (10SBisson) @Cntlsn It is possible to connect from Safari on your composer to Safar... [14:36:50] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools, 10Anti-Harassment (Lāmed - ל), 10Patch-For-Review: Special:CentralAuth should provide the same blocking information as Special:BlockList does - https://phabricator.wikimedia.org/T200938 (10dbarratt) a:05dbarrat... [14:37:12] (03CR) 10Kosta Harlan: [C: 03+2] DevelopmentSettings: Remove redundant CacheType overrides [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:37:22] (03CR) 10Kosta Harlan: [C: 03+2] installer: Detect APC for MainCacheType in CLI installer [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:37:40] 10Library-Card-Platform: Log access to personal data - https://phabricator.wikimedia.org/T200520 (10jsn.sherman) This is still an outstanding task post-dockerization [14:39:06] (03Merged) 10jenkins-bot: Noop: Fix incorrect documentation and test unit errors [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/516768 (https://phabricator.wikimedia.org/T218304) (owner: 10Pmiazga) [14:42:03] (03CR) 10jenkins-bot: Noop: Fix incorrect documentation and test unit errors [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/516768 (https://phabricator.wikimedia.org/T218304) (owner: 10Pmiazga) [14:43:31] 10MinervaNeue, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): History page filter revisions cannot be expanded on Minerva skin - https://phabricator.wikimedia.org/T223204 (10ovasileva) 05Open→03Resolved looks... [14:43:55] (03CR) 10Krinkle: [C: 04-1] rdbms: avoid LoadBalancer::getConnection waste when using $groups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [14:43:57] (03PS5) 10Pmiazga: Introduce new SimpleMenuElementWithIcon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/510125 (https://phabricator.wikimedia.org/T221792) [14:45:26] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Updates to user page treatment (apply for IP address and always show toolbar) - https://phabricator.wikimedia.org/T220114 (10ovasileva) looks good! @Jdrewniak - is this... [14:47:19] (03PS6) 10Pmiazga: Introduce new SingleMenuEntry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/510125 (https://phabricator.wikimedia.org/T221792) [14:47:41] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Mobile homepage not fully responsive in Czech - https://phabricator.wikimedia.org/T225346 (10SBisson) I can't reproduce that on my phone or Chrome in mobile mode with various resolutions. @Urbanecm can you still re... [14:49:57] 10Wikimedia-Site-requests: Slovene projects: Alphabetical order in categories (collation) - https://phabricator.wikimedia.org/T208984 (10Janezdrilc) I opened a discussion to get a community consensus. @matmarex, do "Ć" and "Đ" get its own heading after "C" and "D" in uca-sl (similar like in uca-hr)? [14:50:10] (03Merged) 10jenkins-bot: installer: Detect APC for MainCacheType in CLI installer [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:50:13] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Mobile homepage not fully responsive in Czech - https://phabricator.wikimedia.org/T225346 (10Urbanecm) Hi @Sbisson, I no longer can reproduce the issue. Seems something has changed, which has resolved this issue. [14:52:12] (03Merged) 10jenkins-bot: DevelopmentSettings: Remove redundant CacheType overrides [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:52:14] (03CR) 10jenkins-bot: installer: Detect APC for MainCacheType in CLI installer [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:53:18] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile MVP list - https://phabricator.wikimedia.org/T225676 (10SBisson) [14:53:20] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10SBisson) [14:53:22] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Mobile homepage not fully responsive in Czech - https://phabricator.wikimedia.org/T225346 (10SBisson) 05Open→03Resolved a:03SBisson Please re-open if you see it again. [14:54:01] (03CR) 10jenkins-bot: DevelopmentSettings: Remove redundant CacheType overrides [core] - 10https://gerrit.wikimedia.org/r/516728 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [14:54:30] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Updates to user page treatment (apply for IP address and always show toolbar) - https://phabricator.wikimedia.org/T220114 (10Jdrewniak) @ovasileva nope, it's available... [14:56:37] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Extend and rename MobileWebMainMenuClickTracking schema - https://phabricator.wikimedia.org/T220016 (10pmiazga) @MNeisler can we add the `required = false` to `Destination`? We want to track clicks on menu elements... [14:58:14] (03CR) 10jerkins-bot: [V: 04-1] Introduce new SingleMenuEntry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/510125 (https://phabricator.wikimedia.org/T221792) (owner: 10Pmiazga) [15:00:10] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Updates to user page treatment (apply for IP address and always show toolbar) - https://phabricator.wikimedia.org/T220114 (10ovasileva) 05Open→03Resolved >>! In T22... [15:03:48] 10MediaWiki-General-or-Unknown: Indentation of grouped entries at watchlist and recent changes got a bit weirdo - https://phabricator.wikimedia.org/T225727 (10jeblad) [15:05:22] 10QuickSurveys, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review, and 2 others: Allow quicksurveys to target based on registration date - https://phabricator.wikimedia.org/T218304 (10Isaac) Thanks @pmiazga ! [15:05:24] 10MediaWiki-General-or-Unknown: Indentation of grouped entries at watchlist and recent changes got a bit weirdo - https://phabricator.wikimedia.org/T225727 (10jeblad) [15:06:01] 10MediaWiki-Watchlist, 10OOUI, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Introduce alphabetic pager for Special:EditWatchlist - https://phabricator.wikimedia.org/T220245 (10Johan) @kostajh But it's not yet decided this will go into production? (If it is: do you know when?) [15:08:05] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10WolfgangFahl) Now the git repository is available but I do not have access rights to it. ` wf@io:/srv/www/mediawiki/code/extensions/OpenJsCad$ git push Username for 'https://gerrit.wikimedia.org': WolfgangF... [15:10:50] 10CX-analytics, 10Language-Team (Language-2019-April-June): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Nuria) We recommend you look at eventlogging data in hadoop, the mysql eventlogging hosts are to be deprecated probably next quarter. Also,... [15:11:17] 10ContentTranslation, 10Research, 10Language-Team (Language-2019-April-June): Parameters matching on Templates: ML Exploration - https://phabricator.wikimedia.org/T221211 (10diego) oh! I see, that number is distance, so 0 would be perfect match, 1 is not matching at all. I've already put a upper bound .45,... [15:16:01] 10Reference Previews: Deploy ReferencePreviews as beta feature on no- and nnwiki - https://phabricator.wikimedia.org/T224674 (10jeblad) [15:16:33] 10Library-Card-Platform: Ensure that logs are saved even when the environment is recreated - https://phabricator.wikimedia.org/T203685 (10jsn.sherman) still an issue post-dockerization [15:16:35] 10Reference Previews: Deploy ReferencePreviews as beta feature on no- and nnwiki - https://phabricator.wikimedia.org/T224674 (10jeblad) [15:18:33] 10Library-Card-Platform: Ensure that logs are saved even when the environment is recreated - https://phabricator.wikimedia.org/T203685 (10jsn.sherman) If we don't need to keep them around for a super long time, then we could just use an external event/log analytics service like https://timber.io/ or https://sent... [15:19:06] 10VisualEditor (Current work): Translate Edit Card UI strings - https://phabricator.wikimedia.org/T225568 (10ppelberg) [15:19:29] 10MediaWiki-User-login-and-signup: Option to "Use secure connection" appears on secure connection. - https://phabricator.wikimedia.org/T225728 (10LewisMCYoutube) [15:24:41] (03PS2) 10Niedzielski: Revert "temporarily disabling failing browser tests for language selector" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (https://phabricator.wikimedia.org/T224605) [15:27:31] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , and 2 others: Homepage: homepage discovery for no-JS users - https://phabricator.wikimedia.org/T225318 (10Cntlsn) Thanks @Krinkle for the clarification, and thanks @Catrope for explaining how this could actua... [15:28:19] 10MediaWiki-Releasing, 10Operations, 10Parsoid: signatures were invalid: EXPKEYSIG 90E9F83F22250DD7 MediaWiki releases repository - https://phabricator.wikimedia.org/T225601 (10greg) [15:28:40] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10Epic: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [15:28:46] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10Epic, 10Performance-Team (Radar): Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [15:29:34] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10Epic, 10Performance-Team (Radar): Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [15:29:53] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10Epic, 10Performance-Team (Radar): Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) [15:31:47] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Kanban (Team 2): Security Review of RESTBagOStuff - https://phabricator.wikimedia.org/T221986 (10EvanProdromou) This is an uninformed and inexpert analysis of potential security concerns with our upcoming session stack. I haven't lo... [15:33:22] 10Advanced Mobile Contributions: AMC - mark AMC setting as "new" - https://phabricator.wikimedia.org/T225731 (10ovasileva) [15:33:31] 10Advanced Mobile Contributions: AMC - mark AMC setting as "new" - https://phabricator.wikimedia.org/T225731 (10ovasileva) p:05Triage→03Normal [15:39:24] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.8; 2019-06-04), and 4 others: MinervaNeue wdio build fails with PHP error from Wikibase "Failed to map interlanguage prefix es to a global site ID." - https://phabricator.wikimedia.org/T224605 (10Niedzielski) 0... [15:39:26] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10Cntlsn) @SBisson > Mobile toasts can be closed by tappi... [15:43:18] 10Library-Card-Platform: Stop using assertions for determining editor eligibility - https://phabricator.wikimedia.org/T225732 (10Samwalton9) [15:44:03] 10CX-analytics, 10Language-Team (Language-2019-April-June): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Amire80) I'll be fine with whatever allows me to build a chart that shows the three things: # Published articles (from wikishared) # Article... [15:48:39] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Add caption CTA on article pages - https://phabricator.wikimedia.org/T224728 (10Sharvaniharan) a:03Sharvaniharan [15:58:34] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Tweak gradient at bottom of cards (captions and descriptions) - https://phabricator.wikimedia.org/T224500 (10cooltey) >>! In T224500#5256181, @schoenbaechler wrote: > Hey @cooltey, do I understand correctly that both screenshots show the sam... [16:00:54] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10schoenbaechler) [16:02:32] (03PS5) 10Anomie: rdbms: Add callback for atomic section cancellation [core] - 10https://gerrit.wikimedia.org/r/514370 [16:03:45] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: add sub-header text about user longevity to mobile homepage - https://phabricator.wikimedia.org/T225663 (10Niedzielski) @SBisson, I believe you can call [[ https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/72... [16:05:14] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10schoenbaechler) [16:06:31] (03PS3) 10Krinkle: ResourceLoader: Remove default lang and skin from request [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:06:58] (03PS4) 10Krinkle: resource;oader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:07:57] (03CR) 10Krinkle: [C: 03+2] "Alright. I've documented the concerns inline, because it is not safe as a general measure (especially given these are in cached HTML). But" [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:07:58] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10schoenbaechler) It should be more or less ready (for dev) now @Charlotte... [16:08:17] (03PS5) 10Krinkle: resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:08:36] (03CR) 10Krinkle: [C: 03+2] resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:10:50] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10Charlotte) @Dbrant - All yours, mate. [16:14:10] 10MediaWiki-Recent-changes, 10MobileFrontend, 10Growth-Team, 10Product-Analytics, 10Readers-Web-Backlog: [Hackday] Analyse user interactions with RecentChanges - https://phabricator.wikimedia.org/T223206 (10MNeisler) > How frequently do users use the "group" option either as a filter or as a user prefer... [16:20:18] (03PS1) 10Zfilipin: WIP test commiWIP test committ [core] - 10https://gerrit.wikimedia.org/r/516799 [16:20:30] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [16:22:37] (03Abandoned) 10Zfilipin: WIP test commiWIP test committ [core] - 10https://gerrit.wikimedia.org/r/516799 (owner: 10Zfilipin) [16:25:12] (03CR) 10Hashar: "Nice finding! I am all for having this backported to the release branches given it speeds up CI." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [16:27:10] 10MediaWiki-Core-Testing, 10Release-Engineering-Team, 10Code-Health, 10Continuous-Integration-Config, and 2 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Jdforrester-WMF) [16:29:36] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Jdforrester-WMF) How much further improvement are we expecting? Without before/after benchmarks it's hard to k... [16:33:09] 10MediaWiki-Recent-changes, 10MobileFrontend, 10Growth-Team, 10Product-Analytics, 10Readers-Web-Backlog: [Hackday] Analyse user interactions with RecentChanges - https://phabricator.wikimedia.org/T223206 (10MNeisler) [16:33:27] (03PS2) 10Hashar: (DO NOT SUBMIT) build: MWBot in verbose mode [core] - 10https://gerrit.wikimedia.org/r/516754 [16:33:47] 10MediaWiki-Recent-changes, 10MobileFrontend, 10Growth-Team, 10Product-Analytics, 10Readers-Web-Backlog: [Hackday] Analyse user interactions with RecentChanges - https://phabricator.wikimedia.org/T223206 (10MNeisler) [16:36:34] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) I think what we have below is great for our v1.0, save for two copy changes to the editable fields: - [ ] Change "Label" to "Display text" - [ ] Change "Link" to "Link target"... [16:39:14] 10Timeless, 10CSS, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): Regressions caused by Timeless-specific form styles removal and related changes - https://phabricator.wikimedia.org/T221345 (10putnik) @Isarra Please look at T225412. `display: block` broke the non-JavaScript interface. [16:39:59] (03CR) 10Krinkle: installer: Detect APC for MainCacheType in CLI installer (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516784 (https://phabricator.wikimedia.org/T225496) (owner: 10Krinkle) [16:43:53] 10Wikimedia-Hackathon-2019-Organization: Write a blog post about Wikimedia Hackathon 2019 in Prague on WMCZ blog - https://phabricator.wikimedia.org/T215398 (10Aklapper) Is this covered by https://blog.wikimedia.cz/2019/06/wikimedia-hackathon-2019-je-za-nami/ ? Or is there more to come? :) [16:49:14] 10MediaWiki-Internationalization, 10MediaWiki-extensions-General, 10Core Platform Team (Decoupling (CDP2)), 10Core Platform Team Kanban (Team 3), and 2 others: remove prev/next message dependency from Language - https://phabricator.wikimedia.org/T207977 (10daniel) @CCicalese_WMF Any ideas on who could do t... [16:53:23] 10Graphite: PHP statsd client doesn't support tagging metrics - https://phabricator.wikimedia.org/T225721 (10Ottomata) [16:53:38] (03CR) 10Hashar: [C: 04-2] "MWBot uses the 'request' module to do the http queries. I have added "NODE_DEBUG=request" to the CI entry point which dumps bunch of debug" [core] - 10https://gerrit.wikimedia.org/r/516754 (owner: 10Hashar) [16:53:41] 10Graphite: PHP statsd client doesn't support tagging metrics - https://phabricator.wikimedia.org/T225721 (10Ottomata) Removed Analytics tag; we don't maintain any statsd stuff. [16:54:31] 10MediaWiki-Recent-changes, 10MobileFrontend, 10Growth-Team, 10Product-Analytics, 10Readers-Web-Backlog: [Hackday] Analyse user interactions with RecentChanges - https://phabricator.wikimedia.org/T223206 (10MNeisler) > How many users have disabled javascript support? priority normal This is controlled b... [16:55:45] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10Aklapper) I'd say that not being able to `git push` might be expected behavior as things should go through the CI via Gerrit (and [better be reviewed by someone else](https://www.mediawiki.org/wiki/Gerrit/Pri... [16:58:08] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10WolfgangFahl) Thx for the hint. I still need more info to start working. How are the rights for extension git repositories managed? How do you get my initial code reviewed if i can't push it? [16:58:44] 10MediaWiki-Recent-changes, 10MobileFrontend, 10Growth-Team, 10Product-Analytics, 10Readers-Web-Backlog: [Hackday] Analyse user interactions with RecentChanges - https://phabricator.wikimedia.org/T223206 (10MNeisler) [17:02:49] 10MediaWiki-Search, 10Discovery-Search, 10OOUI: Load search suggestion for strings typed before initializing JavaScript - https://phabricator.wikimedia.org/T225589 (10EBernhardson) p:05Triage→03Normal [17:07:10] (03CR) 10Mholloway: "recheck" [services/wikifeeds] - 10https://gerrit.wikimedia.org/r/516680 (https://phabricator.wikimedia.org/T197009) (owner: 10Mholloway) [17:07:46] 10MediaWiki-Search, 10Discovery-Search (Current work): Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10EBernhardson) [17:08:35] 10GrowthExperiments-Homepage, 10Wikimedia-User-Group-Basque: Deploy User Home Page at Basque Wikipedia: Translating into Basque all documentation and messages - https://phabricator.wikimedia.org/T223684 (10Xabier.Armendaritz) Already translated into Basque: https://www.mediawiki.org/wiki/Growth/Communities/Ho... [17:10:33] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10Aklapper) You propose your change in Gerrit via `git review`, and then someone needs to +2 the change to get the change merged. Do https://www.mediawiki.org/wiki/Gerrit/Tutorial and https://www.mediawiki.org/... [17:11:32] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile, 10Patch-For-Review: Homepage: mobile header style - https://phabricator.wikimedia.org/T225666 (10SBisson) a:03SBisson [17:11:56] 10MediaWiki-Core-Testing, 10MediaWiki-JobQueue: HashRingTest::testHashRingKetamaMode takes 3+ seconds - https://phabricator.wikimedia.org/T225719 (10aaron) I assume the slow part would be $ketama_test( 1e5 ). It could probably use 1e4 if there is a speed problem. [17:14:09] 04(no projects): Failure to publish completed translation : "Error: Attempting to save section 1 having no section state" - https://phabricator.wikimedia.org/T225702 (10Aklapper) [17:14:29] (03CR) 10Aaron Schulz: rdbms: avoid LoadBalancer::getConnection waste when using $groups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [17:14:34] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , 10Mobile: Homepage: add link back to Homepage to Special:ConfirmEmail - https://phabricator.wikimedia.org/T225736 (10Cntlsn) [17:14:50] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: add sub-header text about user longevity to mobile homepage - https://phabricator.wikimedia.org/T225663 (10SBisson) @Niedzielski Thanks for the suggestion. I'm not sure adding `isSpecialHomepage()` to `SkinMinerva` is going to... [17:14:57] 10ContentTranslation: Failure to publish completed translation : "Error: Attempting to save section 1 having no section state" - https://phabricator.wikimedia.org/T225702 (10Aklapper) Thanks for reporting this! Assuming this task is about #ContentTranslation hence adding project tag so others can find this task,... [17:15:02] 10GrowthExperiments- HelpModule, 10GrowthExperiments- MentorshipModule, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, and 3 others: Homepage: "ask a question" dialog and overlay issues - https://phabricator.wikimedia.org/T225669 (10Cntlsn) [17:15:03] (03PS1) 10Aaron Schulz: rdbms: reorganize Database fields and constants [core] - 10https://gerrit.wikimedia.org/r/516806 [17:15:05] (03PS1) 10Aaron Schulz: rdbms: remove $opened field from Database for simplicity [core] - 10https://gerrit.wikimedia.org/r/516807 [17:15:07] (03PS1) 10Aaron Schulz: rdbms: combine trxLevel and trxShortId fields in Database [core] - 10https://gerrit.wikimedia.org/r/516808 [17:15:44] 10Product-Analytics, 10VisualEditor (Current work): VE mobile default: design A/B test - https://phabricator.wikimedia.org/T221195 (10DLynch) > One problem: if we store it in user_id, we will have to start purging that field after 90 days, whereas we currently do not. We should instead add an anonymous_user_to... [17:21:18] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10Mholloway) [17:21:41] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10nray) >>! In T222630#5256649, @alexhollender wrote: > @nray I didn't realize that wikidata items coul... [17:21:48] (03PS1) 10Krinkle: selenium: Skip another flaky Rollback test [core] - 10https://gerrit.wikimedia.org/r/516810 (https://phabricator.wikimedia.org/T220479) [17:22:06] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Collected “Suggested Edits” Design Feedback for `2.7.50282-alpha-2019-06-11` - https://phabricator.wikimedia.org/T225635 (10Mholloway) I noted the discussion about the description edit suggestions... [17:22:12] (03PS6) 10Krinkle: resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [17:22:48] 10Design, 10WMF-Design, 10Readers-Web-Backlog (Design): Mobile web donate link - https://phabricator.wikimedia.org/T219793 (10spatton) @alexhollender, great question re: how long and with whom - we'll talk about that. We'll be sure to communicate the plan back to your side to make sure we're all on board, an... [17:24:14] 10CirrusSearch, 10WMF-JobQueue, 10Discovery-Search (Current work), 10Wikimedia-production-error: Fatal error during CirrusSearch-LinksUpdate job (CirrusTitleJob) from JobQueueGroup->push - https://phabricator.wikimedia.org/T225200 (10dcausse) Checked few examples and there seem to be a mix of - LiquidThrea... [17:24:19] 10Library-Card-Platform: CSV download button server error for partners marked not available - https://phabricator.wikimedia.org/T225705 (10Samwalton9) a:03Samwalton9 https://github.com/WikipediaLibrary/TWLight/pull/273 [17:27:08] (03CR) 10jerkins-bot: [V: 04-1] rdbms: remove $opened field from Database for simplicity [core] - 10https://gerrit.wikimedia.org/r/516807 (owner: 10Aaron Schulz) [17:28:39] (03PS9) 10Krinkle: resourceloader: Deprecate ResourceLoaderContext::getConfig and ::getLogger [core] - 10https://gerrit.wikimedia.org/r/503133 (https://phabricator.wikimedia.org/T32956) [17:28:55] (03CR) 10Krinkle: "Codesearch finds 1 usage which this commit updates." [core] - 10https://gerrit.wikimedia.org/r/503133 (https://phabricator.wikimedia.org/T32956) (owner: 10Krinkle) [17:29:50] (03CR) 10jerkins-bot: [V: 04-1] rdbms: combine trxLevel and trxShortId fields in Database [core] - 10https://gerrit.wikimedia.org/r/516808 (owner: 10Aaron Schulz) [17:30:19] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata, 10Wikidata-Campsite: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10Niharika) >>! In T207893#5255918, @WMDE-leszek wrote: > @Niharika would you mind reminding us wha... [17:31:02] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [17:31:05] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956 (10Krinkle) [17:31:55] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956 (10Krinkle) [17:32:00] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956 (10Krinkle) [17:32:40] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team, 10patch-welcome: CSSMin library calls global function wfExpandUrl() - https://phabricator.wikimedia.org/T88914 (10Krinkle) [17:32:44] (03CR) 10Kosta Harlan: [C: 03+2] selenium: Skip another flaky Rollback test [core] - 10https://gerrit.wikimedia.org/r/516810 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [17:33:52] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt, 10good first bug: ResourceLoader should use context/config instead of global variables - https://phabricator.wikimedia.org/T36738 (10Krinkle) [17:34:00] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt, 10good first bug: ResourceLoader should use context/config instead of global variables - https://phabricator.wikimedia.org/T36738 (10Krinkle) [17:35:14] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Technical-Debt, 10good first bug: ResourceLoader should use context/config instead of global variables - https://phabricator.wikimedia.org/T36738 (10Krinkle) [17:35:51] 10MediaWiki-Search, 10Discovery-Search (Current work): Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10EBernhardson) Pulled a mysql 5.7.26 container, and indeed in boolean mode mysql doesn't like `+-`. Interestingly I tried with mariadb 10.3.15 and it emits the... [17:36:34] (03PS1) 10Kosta Harlan: Test: Increase max instances for WDIO [core] - 10https://gerrit.wikimedia.org/r/516812 [17:37:50] (03CR) 10Krinkle: [C: 04-1] "https://codesearch.wmflabs.org/search/?q=onTransactionIdle%5Cb&i=nope&files=&repos=" [core] - 10https://gerrit.wikimedia.org/r/516741 (owner: 10Aaron Schulz) [17:37:55] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , 10Mobile: Homepage: add link back to Homepage to Special:ConfirmEmail - https://phabricator.wikimedia.org/T225736 (10Cntlsn) [17:38:21] (03CR) 10Krinkle: [C: 03+2] rdbms: implement strictor ownership of LoadBalancer by LBFactory [core] - 10https://gerrit.wikimedia.org/r/516044 (owner: 10Aaron Schulz) [17:39:31] (03PS2) 10Krinkle: rdbms: reorganize Database fields and constants [core] - 10https://gerrit.wikimedia.org/r/516806 (owner: 10Aaron Schulz) [17:42:13] (03CR) 10jerkins-bot: [V: 04-1] Test: Increase max instances for WDIO [core] - 10https://gerrit.wikimedia.org/r/516812 (owner: 10Kosta Harlan) [17:43:13] 10MediaWiki-extensions-WikibaseClient, 10MobileFrontend, 10Readers-Web-Backlog, 10Wikidata, 10Technical-Debt: Article tagline should be set by a hook, not by code highly coupled with Wikibase - https://phabricator.wikimedia.org/T225529 (10pmiazga) [17:44:58] (03Merged) 10jenkins-bot: selenium: Skip another flaky Rollback test [core] - 10https://gerrit.wikimedia.org/r/516810 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [17:45:10] 10MediaWiki-Database, 10MediaWiki-extensions-OATHAuth, 10DBA: Schema change to oathauth_users - https://phabricator.wikimedia.org/T225643 (10Reedy) >>! In T225643#5256591, @jcrespo wrote: > Last question, is there a limit on the size or insertion rate of the blob column, either implicit or explicit? Not too... [17:45:34] (03CR) 10Krinkle: [C: 03+2] rdbms: reorganize Database fields and constants [core] - 10https://gerrit.wikimedia.org/r/516806 (owner: 10Aaron Schulz) [17:46:35] (03CR) 10Yaron Koren: "Sorry for the delay. Will this still work with template calls contained within template calls, like "{{a|{{b|c}}|d}}"? None of those pipes" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [17:46:39] (03CR) 10jenkins-bot: selenium: Skip another flaky Rollback test [core] - 10https://gerrit.wikimedia.org/r/516810 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [17:47:13] (03Merged) 10jenkins-bot: resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [17:48:37] 10Wikimedia-Takedown-Tools, 10Anti-Harassment (Lāmed - ל): Takedown tools: Datepicker picking wrong dates, submitting totally different figures - https://phabricator.wikimedia.org/T213490 (10Niharika) @jrbs Can you confirm if the datepicker works as expected now? [17:48:53] (03CR) 10jenkins-bot: resourceloader: Omit default 'lang' and 'skin' params from load.php urls [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [17:49:12] 10MediaWiki-Core-Testing, 10Release-Engineering-Team, 10Code-Health, 10Continuous-Integration-Config, and 2 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Mainframe98) >>! In T225730#5256852, @Krinkle wrote: > * Look at the PHPUnit "Test Report... [17:50:10] (03Merged) 10jenkins-bot: rdbms: implement strictor ownership of LoadBalancer by LBFactory [core] - 10https://gerrit.wikimedia.org/r/516044 (owner: 10Aaron Schulz) [17:50:41] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Etonkovidova) [17:50:43] 10GrowthExperiments-Homepage, 10GrowthExperiments-StartModule, 10Growth-Team (Current Sprint), 10Mobile, 10Patch-For-Review: Homepage: link to "Guidelines for user pages" leads to desktop version - https://phabricator.wikimedia.org/T225661 (10Etonkovidova) 05Open→03Invalid Checked in betalabs on iPho... [17:50:57] 10MediaWiki-Core-Testing, 10Release-Engineering-Team, 10Code-Health, 10Continuous-Integration-Config, and 2 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10kostajh) > splitting the unit and integration test runs into different jenkins votes, del... [17:53:14] (03CR) 10Reedy: "Actually flag might not be needed if we can coordinate with the DBA's" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/496451 (https://phabricator.wikimedia.org/T218210) (owner: 10ItSpiderman) [17:53:32] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile MVP list - https://phabricator.wikimedia.org/T225676 (10MMiller_WMF) [17:54:14] 10MediaWiki-Database, 10MediaWiki-extensions-OATHAuth, 10DBA: Schema change to oathauth_users - https://phabricator.wikimedia.org/T225643 (10Reedy) >>! In T225643#5257185, @Reedy wrote: >>>! In T225643#5256591, @jcrespo wrote: >> Again, just to be clear, we don't require a feature flag (although it is usuall... [17:54:34] (03CR) 10jenkins-bot: rdbms: implement strictor ownership of LoadBalancer by LBFactory [core] - 10https://gerrit.wikimedia.org/r/516044 (owner: 10Aaron Schulz) [17:55:53] (03PS14) 10Jforrester: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [17:57:06] (03CR) 10Jforrester: "PS14: Trivial rebase." [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [17:57:39] 10MediaWiki-Core-Testing, 10Release-Engineering-Team, 10Code-Health, 10Continuous-Integration-Config, and 2 others: Reduce runtime of MW shared gate Jenkins jobs to 5 min - https://phabricator.wikimedia.org/T225730 (10Krinkle) >>! In T225730#5257180, @Jdforrester-WMF wrote: > [..] doesn't have any specific... [17:57:46] (03Merged) 10jenkins-bot: rdbms: reorganize Database fields and constants [core] - 10https://gerrit.wikimedia.org/r/516806 (owner: 10Aaron Schulz) [17:58:26] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10MMiller_WMF) @SBisson @kostajh -- please hold off on th... [17:59:43] (03CR) 10jenkins-bot: rdbms: reorganize Database fields and constants [core] - 10https://gerrit.wikimedia.org/r/516806 (owner: 10Aaron Schulz) [18:00:15] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10SBisson) >>! In T216220#5257227, @MMiller_WMF wrote: >... [18:00:58] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth Design , and 2 others: Homepage: traffic from email confirmation success page - https://phabricator.wikimedia.org/T222848 (10Cntlsn) [18:01:01] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Patch-For-Review: Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10MMiller_WMF) @SBisson -- that should wait, too. If we... [18:03:59] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: traffic from email confirmation success page - https://phabricator.wikimedia.org/T222848 (10Cntlsn) a:05Cntlsn→03None @SBisson @kostajh I have updated the specificatio... [18:04:03] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: add sub-header text about user longevity to mobile homepage - https://phabricator.wikimedia.org/T225663 (10pmiazga) Currently there is no nice and clean way to do it. Adding `isSpecialHomePage()` is not best approach, Minerva s... [18:04:21] (03PS2) 10Krinkle: resourceloader: Change cache keys to use first segment for grouping by purpose [core] - 10https://gerrit.wikimedia.org/r/512946 [18:04:30] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10pmiazga) a:05nray→03pmiazga [18:05:17] (03CR) 10Krinkle: [C: 03+2] objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [18:06:09] (03Abandoned) 10Kosta Harlan: Test: Increase max instances for WDIO [core] - 10https://gerrit.wikimedia.org/r/516812 (owner: 10Kosta Harlan) [18:06:42] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:07:56] (03PS7) 10Shivanshbindal9: Make Notification count update without page reload [extensions/Echo] - 10https://gerrit.wikimedia.org/r/516285 (https://phabricator.wikimedia.org/T219222) [18:09:24] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:09:52] 10MediaWiki-Search, 10Discovery-Search: Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10EBernhardson) [18:10:20] (03CR) 10Shivanshbindal9: "Moved fetchNotifications() call in the click handler." (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/516285 (https://phabricator.wikimedia.org/T219222) (owner: 10Shivanshbindal9) [18:10:29] 10Sentry: Add JS error counts to graphite - https://phabricator.wikimedia.org/T522 (10Krinkle) This has been resolved for Minerva/MobileFrontend (T202026). We could probably generalise that by moving the simple mw.track -> statsv counter to WikimediaEvents instead so that we have it for other skins/desktop as w... [18:11:31] (03CR) 10Jdrewniak: [C: 03+2] Revert "temporarily disabling failing browser tests for language selector" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (https://phabricator.wikimedia.org/T224605) (owner: 10Niedzielski) [18:14:31] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10observability: Create Icinga check for navtiming.py service health - https://phabricator.wikimedia.org/T225739 (10Krinkle) [18:14:41] 10MediaWiki-extensions-ReplaceText: Update ReplaceText to use MovePage - https://phabricator.wikimedia.org/T225741 (10abi_) [18:15:32] 10Accessibility, 10MediaWiki-Interface: Allow defining keyboard shortcuts for custom entries in the sidebar - https://phabricator.wikimedia.org/T225715 (10Aklapper) [18:19:21] (03Merged) 10jenkins-bot: objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [18:19:59] 10MediaWiki-User-management, 10Anti-Harassment: Work out how to track blocks with a cookie if there are multiple trackable blocks - https://phabricator.wikimedia.org/T225654 (10Niharika) [18:21:06] 10MediaWiki-General-or-Unknown, 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Indentation of grouped entries at watchlist and recent changes got a bit weirdo - https://phabricator.wikimedia.org/T225727 (10Jdforrester-WMF) [18:21:13] (03CR) 10jenkins-bot: objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [18:21:14] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Indentation of grouped entries at watchlist and recent changes got a bit weirdo - https://phabricator.wikimedia.org/T225727 (10Jdforrester-WMF) [18:22:20] 10WikiApiary: CategoryTree - Babel categories. - https://phabricator.wikimedia.org/T225744 (10MvGulik) [18:22:48] (03PS6) 10Krinkle: Update ExternalStorage docs and function calls [core] - 10https://gerrit.wikimedia.org/r/482610 (owner: 10Daimona Eaytoy) [18:23:31] (03PS7) 10Krinkle: externalstore: Fix insert*() return docs and remove redundant checks [core] - 10https://gerrit.wikimedia.org/r/482610 (owner: 10Daimona Eaytoy) [18:23:34] (03CR) 10Krinkle: [C: 03+2] externalstore: Fix insert*() return docs and remove redundant checks [core] - 10https://gerrit.wikimedia.org/r/482610 (owner: 10Daimona Eaytoy) [18:23:54] (03Merged) 10jenkins-bot: Revert "temporarily disabling failing browser tests for language selector" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (https://phabricator.wikimedia.org/T224605) (owner: 10Niedzielski) [18:24:13] 10MediaWiki-General-or-Unknown, 10Dumps-Generation, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: Xml stubs dumps are running 5 to 15x slower than previously - https://phabricator.wikimedia.org/T220493 (10daniel) >>! In T220493#5241427, @ArielGlenn wrote: > Hmm, few... [18:25:56] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10WolfgangFahl) ` git review Your change was committed before the commit hook was installed. Amending the commit to add a gerrit change id. Username for 'https://gerrit.wikimedia.org': WolfgangFahl Password for... [18:27:52] 10MediaWiki-Search, 10Discovery-Search: Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10Reedy) On my dev wiki with `$wgDebugDumpSql` ` [DBQuery] SearchMySQL::minSearchLength [0.006s]: SHOW GLOBAL VARIABLES LIKE 'ft\_min\_word\_len' SearchMySQL::parseQuery: Woul... [18:28:32] (03PS1) 10Krinkle: resourceloader: Ignore coverage for getBaseModulesInternal() wrapper [core] - 10https://gerrit.wikimedia.org/r/516817 [18:28:38] (03CR) 10jenkins-bot: Revert "temporarily disabling failing browser tests for language selector" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516774 (https://phabricator.wikimedia.org/T224605) (owner: 10Niedzielski) [18:29:27] (03CR) 10Krinkle: [C: 03+2] PHPDoc: Fix non-carnonical order of elements in phpdoc [core] - 10https://gerrit.wikimedia.org/r/516667 (owner: 10D3r1ck01) [18:29:49] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10User-abi_: Extend message checker framework to support errors that prevent saving - https://phabricator.wikimedia.org/T204568 (10abi_) [18:30:59] (03PS15) 10Jforrester: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:31:21] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:31:29] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:31:36] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:34:43] (03Merged) 10jenkins-bot: externalstore: Fix insert*() return docs and remove redundant checks [core] - 10https://gerrit.wikimedia.org/r/482610 (owner: 10Daimona Eaytoy) [18:35:20] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [18:35:43] (03PS1) 10Krinkle: resourceloader: Remove redundant 'group' setting for StartupModule [core] - 10https://gerrit.wikimedia.org/r/516819 [18:36:20] (03CR) 10jenkins-bot: externalstore: Fix insert*() return docs and remove redundant checks [core] - 10https://gerrit.wikimedia.org/r/482610 (owner: 10Daimona Eaytoy) [18:38:39] 10MediaWiki-User-management, 10Anti-Harassment: Block list and log incorrectly report "cannot edit own talk page" for some blocks - https://phabricator.wikimedia.org/T224468 (10Niharika) [18:38:55] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/516821 (owner: 10L10n-bot) [18:39:03] 10Advanced Mobile Contributions: [AMC] update description in settings post-launch - https://phabricator.wikimedia.org/T225745 (10alexhollender) [18:40:43] (03Merged) 10jenkins-bot: PHPDoc: Fix non-carnonical order of elements in phpdoc [core] - 10https://gerrit.wikimedia.org/r/516667 (owner: 10D3r1ck01) [18:42:33] (03CR) 10jenkins-bot: PHPDoc: Fix non-carnonical order of elements in phpdoc [core] - 10https://gerrit.wikimedia.org/r/516667 (owner: 10D3r1ck01) [18:45:32] 10MediaWiki-General-or-Unknown, 10Dumps-Generation, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: Xml stubs dumps are running 5 to 15x slower than previously - https://phabricator.wikimedia.org/T220493 (10ArielGlenn) I've been a bit sandbagged this week which is why... [18:46:11] 10GrowthExperiments-Homepage: Homepage mobile: links from recent quesions land at the top of the help desk page - https://phabricator.wikimedia.org/T225746 (10Etonkovidova) [18:46:50] 10MediaWiki-Search, 10Discovery-Search: Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10EBernhardson) Interesting, wonder whats different: ` $ docker run --name some-mariadb -e MYSQL_ROOT_PASSWORD=password -d mariadb:10.3.15 a8a35ac96e5556b78a813df08eec9198e0ef6... [18:47:31] (03PS16) 10Jforrester: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [18:47:39] 10GrowthExperiments-Homepage: Homepage mobile: Help module recent quesions links direct to the top of help desk page - https://phabricator.wikimedia.org/T225746 (10Etonkovidova) [18:47:52] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile MVP list - https://phabricator.wikimedia.org/T225676 (10Etonkovidova) [18:47:54] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Etonkovidova) [18:47:56] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile, 10Patch-For-Review: Homepage: recent questions links on mobile go to desktop site - https://phabricator.wikimedia.org/T225660 (10Etonkovidova) 05Open→03Invalid Checked the links- all lead to mobile, not desktop. Filed {T225746} [18:50:29] (03PS1) 10Mholloway: Featured-image: Add structured data from Wikibase [services/wikifeeds] - 10https://gerrit.wikimedia.org/r/516827 [18:50:37] 10Advanced Mobile Contributions: [AMC] simplify setting name to "Advanced mode" - https://phabricator.wikimedia.org/T225747 (10alexhollender) [18:53:34] 10MediaWiki-User-management, 10Anti-Harassment: Fix block message for CompositeBlocks - https://phabricator.wikimedia.org/T225748 (10Tchanders) [18:53:36] (03PS2) 10HMonroy: Add logic to mark pages as reviewed when adding AfD tags [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/516563 (https://phabricator.wikimedia.org/T208685) [18:54:29] (03PS1) 10Jforrester: Bump PHP version requirement to 7.2.0+ [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) [18:55:36] 10Editing Design, 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10ppelberg) For v1.0 we will be shipping the version that is currently deployed to the prototype server (pictured below). We will revisit the changes discussed in this ticket as part of th... [18:55:39] 10MediaWiki-User-management, 10Anti-Harassment: Fix block message for CompositeBlocks - https://phabricator.wikimedia.org/T225748 (10Tchanders) [18:55:54] 10MediaWiki-User-management, 10Anti-Harassment: Fix block message for CompositeBlocks - https://phabricator.wikimedia.org/T225748 (10Niharika) [18:56:07] 10WMSE-Riksarkivet-TORA: Property Alvin P6821 created and need to be matched - https://phabricator.wikimedia.org/T225522 (10Salgo60) [18:56:41] 10MediaWiki-extensions-OAuth, 10GitHub-Mirrors, 10JavaScript: Fix passport-mediawiki-oauth - https://phabricator.wikimedia.org/T210771 (10nichtich) Just use the still existing repository location and do a new release at npm. I created a pull request at (03PS1) 10Krinkle: resourceloader: Use explicit class check instead of isRaw() for startup module [core] - 10https://gerrit.wikimedia.org/r/516830 (https://phabricator.wikimedia.org/T201483) [18:58:39] (03PS1) 10Krinkle: [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) [18:58:41] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Remove internal handling of 'raw' module - https://phabricator.wikimedia.org/T201483 (10Krinkle) a:03Krinkle [18:58:56] (03PS7) 10Aaron Schulz: rdbms: avoid LoadBalancer::getConnection waste when using $groups [core] - 10https://gerrit.wikimedia.org/r/508919 [18:59:48] (03CR) 10Krinkle: "Code search:" [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [18:59:54] 10MediaWiki-User-management, 10Anti-Harassment: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10Niharika) From the estimation meeting: - Add the block IDs - Make sure it looks fine on mobile - Show the expiry (last expiry from the blocks) - Show the reason... [19:00:14] 10MediaWiki-User-management, 10Anti-Harassment: Overlapping blocks may display incorrect block notice - https://phabricator.wikimedia.org/T212326 (10Niharika) [19:03:06] (03CR) 10Krinkle: "Would be nice to have php 7.3 passing before we drop php 7.0/7.1 support so that the release is compatible with more than 1 php version." [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:05:03] 10MediaWiki-User-management, 10Anti-Harassment: Fix block message for CompositeBlocks - https://phabricator.wikimedia.org/T225748 (10Niharika) p:05Triage→03Normal [19:05:12] 10MediaWiki-User-management, 10Anti-Harassment (Lāmed - ל): Fix block message for CompositeBlocks - https://phabricator.wikimedia.org/T225748 (10Niharika) [19:05:14] (03CR) 10Krinkle: [C: 04-1] rdbms: avoid LoadBalancer::getConnection waste when using $groups (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [19:05:18] (03CR) 10Jforrester: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:07:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:08:06] (03CR) 10jerkins-bot: [V: 04-1] Bump PHP version requirement to 7.2.0+ [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:10:01] (03PS8) 10Aaron Schulz: rdbms: avoid LoadBalancer::getConnection waste when using $groups [core] - 10https://gerrit.wikimedia.org/r/508919 [19:10:55] (03PS1) 10Tpt: Display properly previous/next page links for RTL languages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/516833 (https://phabricator.wikimedia.org/T225749) [19:11:58] (03CR) 10Duncancrane: "> Patch Set 1:" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [19:11:59] 10VisualEditor (Current work): Edit card v1.0 design tweaks - https://phabricator.wikimedia.org/T225629 (10iamjessklein) [19:13:53] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Use explicit class check instead of isRaw() for startup module [core] - 10https://gerrit.wikimedia.org/r/516830 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:14:38] (03CR) 10Clarakosi: [C: 03+1] "Great work changing the remaining uses of `Title::userCan()`! I had a quick question about `quickUserCan()` otherwise LGTM" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/513974 (https://phabricator.wikimedia.org/T220191) (owner: 10TK-999) [19:15:50] (03CR) 10Bartosz Dziewoński: [C: 03+2] Add missing dollar prefix to jQuery variable [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516673 (owner: 10Esanders) [19:16:51] (03CR) 10Reedy: [C: 04-1] ".travis.yml needs updating too (dropping 7.0 and 7.1), and postgres tests moving from 7.1 to 7.1" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:17:05] (03PS2) 10Aaron Schulz: rdbms: improve exception handling in Database [core] - 10https://gerrit.wikimedia.org/r/516756 [19:17:55] (03PS3) 10Aaron Schulz: rdbms: improve exception handling in Database [core] - 10https://gerrit.wikimedia.org/r/516756 [19:18:16] 10MediaWiki-Internationalization, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.34-release, and 2 others: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 - https://phabricator.wikimedia.org/T207100 (10Reedy) I'm not sure if Lego has any time to work on this based on... [19:18:19] (03PS2) 10Krinkle: resourceloader: Remove isRaw() support in startup module [core] - 10https://gerrit.wikimedia.org/r/516830 (https://phabricator.wikimedia.org/T201483) [19:18:21] (03PS2) 10Krinkle: [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) [19:18:23] (03PS1) 10Krinkle: OutputPage: Remove use of 'raw' module for html5shiv [core] - 10https://gerrit.wikimedia.org/r/516835 (https://phabricator.wikimedia.org/T201483) [19:18:30] :o [19:18:43] (03CR) 10Reedy: htmlform: Reveal method getOOUI() is called from when spitting deprecation notice (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516761 (https://phabricator.wikimedia.org/T225683) (owner: 10D3r1ck01) [19:19:05] 10MediaWiki-Internationalization, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10MW-1.34-release, and 2 others: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 - https://phabricator.wikimedia.org/T207100 (10Legoktm) a:05Legoktm→03None Sorry for cookie licking, I haven... [19:20:53] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Change cache keys to use first segment for grouping by purpose (031 comment) [core] - 10https://gerrit.wikimedia.org/r/512946 (owner: 10Krinkle) [19:21:15] 10MediaWiki-Internationalization, 10Language-Team, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), and 3 others: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 - https://phabricator.wikimedia.org/T207100 (10Reedy) Or maybe #language-team might be interested? [19:21:20] (03CR) 10TK-999: Migrate remaining usages of Title::userCan() to PermissionManager (031 comment) [core] - 10https://gerrit.wikimedia.org/r/513974 (https://phabricator.wikimedia.org/T220191) (owner: 10TK-999) [19:21:25] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:22:30] (03PS2) 10Jforrester: Bump PHP version requirement to 7.2.0+ [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) [19:22:49] (03PS2) 10Aaron Schulz: rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 [19:24:36] 10MediaWiki-extensions-Score, 10DataTypes, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Long score overlaps with statement box and edit button - https://phabricator.wikimedia.org/T218191 (10Ebe123) Sorry, I have been looking as to why the ca... [19:25:55] (03CR) 10Krinkle: [C: 04-1] "This needs to keep 'raw' => true in Resources.php until the OutputPage change has propagated through HTML caches. Otherwise, existing urls" [core] - 10https://gerrit.wikimedia.org/r/516835 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:26:47] (03CR) 10Krinkle: [C: 04-1] "TODO: Do the same for 'startup' (add 'raw' => true in ClientHtml for startupQuery) in this commit. Then in another commit (blocked on cach" [core] - 10https://gerrit.wikimedia.org/r/516835 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:26:53] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Deprecate ResourceLoaderContext::getConfig and ::getLogger [core] - 10https://gerrit.wikimedia.org/r/503133 (https://phabricator.wikimedia.org/T32956) (owner: 10Krinkle) [19:27:01] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata, 10Wikidata-Campsite: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10Lydia_Pintscher) p:05Normal→03High Hehe ok let's raise it then. @WMDE-leszek let's push for i... [19:28:06] (03PS1) 10Umherirrender: Remove unneeded returns from internal functions [core] - 10https://gerrit.wikimedia.org/r/516836 [19:28:27] 10MediaWiki-Search, 10Discovery-Search: Searching with hyphen can cause mysql query error - https://phabricator.wikimedia.org/T225517 (10Reedy) I'm just using the mariadb.org package for Ubuntu 19.04, stock config AFAIK, but possibly not currently what's distributed (as it's an old vm that's been upgraded thro... [19:29:34] 10wmerrors, 10Software-Licensing: wmerrors has no license information - https://phabricator.wikimedia.org/T224076 (10Catrope) >>! In T224076#5211547, @MaxSem wrote: > I'm good with Apache or MIT. Same. [19:30:38] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Beta app: app languages not showing in language menu on articles - https://phabricator.wikimedia.org/T225385 (10ABorbaWMF) Works for me on 2.7.50282-alpha-2019-06-11 [19:32:02] (03Merged) 10jenkins-bot: Add missing dollar prefix to jQuery variable [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516673 (owner: 10Esanders) [19:32:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:33:14] (03Merged) 10jenkins-bot: resourceloader: Change cache keys to use first segment for grouping by purpose [core] - 10https://gerrit.wikimedia.org/r/512946 (owner: 10Krinkle) [19:35:44] (03Abandoned) 10Aaron Schulz: Avoid use of deprecated Database::reportConnectionError() [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/516770 (owner: 10Aaron Schulz) [19:36:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:37:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [19:37:20] (03CR) 10jenkins-bot: resourceloader: Change cache keys to use first segment for grouping by purpose [core] - 10https://gerrit.wikimedia.org/r/512946 (owner: 10Krinkle) [19:38:01] (03CR) 10jerkins-bot: [V: 04-1] Bump PHP version requirement to 7.2.0+ [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:38:46] (03CR) 10jenkins-bot: Add missing dollar prefix to jQuery variable [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516673 (owner: 10Esanders) [19:39:39] (03CR) 10jerkins-bot: [V: 04-1] Bump PHP version requirement to 7.2.0+ [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [19:39:47] (03PS7) 10Pmiazga: Introduce new SingleMenuEntry [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/510125 (https://phabricator.wikimedia.org/T221792) [19:41:06] (03Merged) 10jenkins-bot: resourceloader: Deprecate ResourceLoaderContext::getConfig and ::getLogger [core] - 10https://gerrit.wikimedia.org/r/503133 (https://phabricator.wikimedia.org/T32956) (owner: 10Krinkle) [19:41:13] (03CR) 10Fomafix: "Ok. Thanks." [core] - 10https://gerrit.wikimedia.org/r/516308 (owner: 10Fomafix) [19:42:54] (03CR) 10jerkins-bot: [V: 04-1] rdbms: make temp table tracking in Database more robust [core] - 10https://gerrit.wikimedia.org/r/515440 (owner: 10Aaron Schulz) [19:42:57] (03CR) 10jerkins-bot: [V: 04-1] Remove unneeded returns from internal functions [core] - 10https://gerrit.wikimedia.org/r/516836 (owner: 10Umherirrender) [19:43:02] (03CR) 10jenkins-bot: resourceloader: Deprecate ResourceLoaderContext::getConfig and ::getLogger [core] - 10https://gerrit.wikimedia.org/r/503133 (https://phabricator.wikimedia.org/T32956) (owner: 10Krinkle) [19:43:10] (03PS1) 10Yaron Koren: Fix for "merging" into pages that have sub-templates [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/516839 [19:47:12] (03PS2) 10Yaron Koren: Fix for "merging" into pages that have sub-templates [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/516839 [19:47:44] (03CR) 10Krinkle: [C: 04-1] Clarify "filter" field in SpecialAbuseLog and ApiQueryAbuseLog (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/488930 (owner: 10Daimona Eaytoy) [19:48:13] (03PS10) 10Krinkle: Tweak methods related to global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/499883 (owner: 10Daimona Eaytoy) [19:52:21] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Can't open urls which do not have language code subdomain - https://phabricator.wikimedia.org/T225381 (10ABorbaWMF) Works for me on 2.7.50282-alpha-2019-06-11 [19:52:33] 10MediaWiki-extensions-DonationInterface, 10FR-Smashpig, 10FR-dlocal, 10Fundraising-Backlog, and 2 others: Add India-specific payment methods across our pipeline - https://phabricator.wikimedia.org/T224514 (10Ejegg) So far: Credit card- Visa - VI MasterCard - MC D... [19:52:40] (03CR) 10Yaron Koren: [C: 03+2] "I haven't tested it, but if it works, it sounds good to me!" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [19:52:57] (03CR) 10Yaron Koren: [C: 03+2] "(Meant to say: "if it works for you".)" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [19:53:05] (03CR) 10Yaron Koren: [C: 03+2] Fix for "merging" into pages that have sub-templates [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/516839 (owner: 10Yaron Koren) [19:53:24] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Kanban (Team 2): Performance testing of RESTBagOStuff - https://phabricator.wikimedia.org/T221987 (10EvanProdromou) So, one way we could do this is with [[ https://www.joedog.org/siege-home/ | siege ]] or something similar, hitting... [19:53:42] 10MediaWiki-extensions-DonationInterface, 10FR-Smashpig, 10FR-dlocal, 10Fundraising-Backlog, and 2 others: Add India-specific payment methods across our pipeline - https://phabricator.wikimedia.org/T224514 (10Ejegg) p:05Triage→03Normal [19:55:37] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: open user and user talk in reading mode from mobile - https://phabricator.wikimedia.org/T225665 (10SBisson) Do we want to change this only for mobile? Do we want the desktop tabs to open the editor (like regular redlinks)? [19:55:43] 10MediaWiki-extensions-DonationInterface, 10FR-Smashpig, 10FR-dlocal, 10Fundraising-Backlog, and 2 others: Add India-specific payment methods across our pipeline - https://phabricator.wikimedia.org/T224514 (10Ejegg) [19:55:45] 10MediaWiki-extensions-LDAPProvider: Does not login user to AD even if all credentials pass - https://phabricator.wikimedia.org/T225752 (10Maretodoric) [19:56:00] (03CR) 10Krinkle: Tweak methods related to global filters (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/499883 (owner: 10Daimona Eaytoy) [19:56:46] 10MediaWiki-extensions-HostStats: Default configuration parameter settings get merged with new settings - https://phabricator.wikimedia.org/T225753 (10Kghbln) [19:58:44] 10MediaWiki-extensions-HostStats: Default configuration parameter settings get merged with new settings - https://phabricator.wikimedia.org/T225753 (10Kghbln) @Legoktm You might be able to help here. The docu about [[ https://www.mediawiki.org/wiki/Manual:Extension.json/Schema#Merge_strategies | merge strategies... [19:58:48] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: open user and user talk in reading mode from mobile - https://phabricator.wikimedia.org/T225665 (10SBisson) a:03SBisson [20:00:11] (03CR) 10Krinkle: [C: 03+1] "LGTM. Needs a rebase conflict resolution, though." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 (owner: 10Daimona Eaytoy) [20:00:22] 10MediaWiki-Releasing, 10Operations, 10Parsoid: debian signing keyid E84AFDD2 has expired - https://phabricator.wikimedia.org/T141400 (10Kghbln) [20:00:40] (03Merged) 10jenkins-bot: Fixed error when saving with | not in {{}} or [] [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/516767 (owner: 10Duncancrane) [20:01:26] (03PS2) 10Pmiazga: Hygiene: Extract isAllowedPageAction into MinervaPermissions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/512306 (https://phabricator.wikimedia.org/T221792) [20:02:15] (03CR) 10Krinkle: [C: 03+2] rdbms: avoid LoadBalancer::getConnection waste when using $groups [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [20:03:47] (03Merged) 10jenkins-bot: Fix for "merging" into pages that have sub-templates [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/516839 (owner: 10Yaron Koren) [20:03:58] 10phan: Add phan stubs for php extensions redis and imagick - https://phabricator.wikimedia.org/T224893 (10Umherirrender) A stub for pcntl should be included, because windows user cannot install that extension. Also a stub for sockets extension is needed: > MSG_EOR (integer) > Not available on Windows platfor... [20:07:22] (03PS1) 10D3r1ck01: api: Fix type combatibility of method parameters to match callers' [core] - 10https://gerrit.wikimedia.org/r/516843 [20:08:12] 10Design, 10Editing Design, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VisualEditor loading indicator should feel more integrated into the mobile interface - https://phabricator.wikimedia.org/T1181 (10matmarex) [20:08:16] 10MW-1.34-notes (1.34.0-wmf.6; 2019-05-21), 10Patch-For-Review, 10VisualEditor (Current work): Toolbar in loading overlay should display sooner in sequencing - https://phabricator.wikimedia.org/T217784 (10matmarex) [20:08:51] 10OOUI, 10Browser-Support-Firefox, 10Patch-For-Review: Native controls shown for number inputs in Firefox - https://phabricator.wikimedia.org/T218977 (10Volker_E) Note: `moz-appearance: none` is not removing the steppers on Firefox/macOS. [20:10:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/516844 (owner: 10L10n-bot) [20:11:05] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: Extract isAllowedPageAction into MinervaPermissions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/512306 (https://phabricator.wikimedia.org/T221792) (owner: 10Pmiazga) [20:11:50] (03PS8) 10Krinkle: resourceloader: Skip modules with circular deps in tree optimiser [core] - 10https://gerrit.wikimedia.org/r/511942 (https://phabricator.wikimedia.org/T223402) [20:13:43] (03PS2) 10Krinkle: resourceloader: Migrate 'raw' modules to 'raw' requests [core] - 10https://gerrit.wikimedia.org/r/516835 (https://phabricator.wikimedia.org/T201483) [20:13:45] (03PS3) 10Krinkle: [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) [20:14:25] (03CR) 10Jforrester: [C: 03+2] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:15:43] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10matmarex) The warning is caused by SemanticMediaWiki, see here: T205956#4633005 T205956#4633514 [20:15:59] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/516747 (owner: 10ItSpiderman) [20:16:49] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: open user and user talk in reading mode from mobile - https://phabricator.wikimedia.org/T225665 (10MMiller_WMF) @SBisson -- yes we want this to be different on mobile and desktop, because that is the way it works now (without t... [20:20:55] (03Merged) 10jenkins-bot: rdbms: avoid LoadBalancer::getConnection waste when using $groups [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [20:20:57] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:21:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/516845 (owner: 10L10n-bot) [20:22:33] 10MediaWiki-API, 10Developer-Advocacy (Apr-Jun 2019), 10Documentation, 10Goal: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10srishakatux) [20:22:35] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2019), 10Documentation: Enable UserFeedback Gadget on MediaWiki - https://phabricator.wikimedia.org/T225584 (10srishakatux) 05Open→03Resolved Thank you very much @Wargo & @Tomybrz! It works :) [20:22:53] (03CR) 10jenkins-bot: rdbms: avoid LoadBalancer::getConnection waste when using $groups [core] - 10https://gerrit.wikimedia.org/r/508919 (owner: 10Aaron Schulz) [20:23:22] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/516843 (owner: 10D3r1ck01) [20:23:24] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) >>! In T225683#5257607, @matmarex wrote: > The warning is caused by SemanticMediaWiki, see here: T205956#4633005 T205956#4633514 Do we need/want to ba... [20:23:31] 10MediaWiki-HTMLForm, 10MediaWiki-Special-pages: HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow' - https://phabricator.wikimedia.org/T205956 (10Reedy) [20:23:33] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) [20:24:56] (03PS1) 10Krinkle: [WIP] RCFilters: Reduce startup overhead from 'config.json' computation [core] - 10https://gerrit.wikimedia.org/r/516850 (https://phabricator.wikimedia.org/T201574) [20:28:44] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Migrate 'raw' modules to 'raw' requests [core] - 10https://gerrit.wikimedia.org/r/516835 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [20:29:32] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Remove support for "raw" modules [core] - 10https://gerrit.wikimedia.org/r/516831 (https://phabricator.wikimedia.org/T201483) (owner: 10Krinkle) [20:32:20] 10Documentation: Improve resources for technical documentarians across Wikimedia projects - https://phabricator.wikimedia.org/T197006 (10Pavithraes) I'm interested in working on this task as a part of Google's Season of Docs 2019. I'd like to know if it would be acceptable to include it in my proposal. [20:32:42] (03PS17) 10Jforrester: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:33:01] (03CR) 10Jforrester: [C: 03+2] "Manual rebase." [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:34:54] (03PS10) 10Fomafix: Skin: Hard-deprecate escapeSearchLink() [core] - 10https://gerrit.wikimedia.org/r/511648 [20:39:22] (03CR) 10Fomafix: [WIP] RCFilters: Reduce startup overhead from 'config.json' computation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516850 (https://phabricator.wikimedia.org/T201574) (owner: 10Krinkle) [20:40:41] 10Accessibility, 10Developer-Advocacy: Fix button accessibility of emojis in User Feedback gadget - https://phabricator.wikimedia.org/T225226 (10srishakatux) 05Open→03Resolved (done) [20:41:26] 10Developer-Advocacy, 10International-Developer-Events: Re-think general hackathon summary - https://phabricator.wikimedia.org/T222005 (10srishakatux) a:05srishakatux→03None [20:44:51] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:46:28] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/516952 (owner: 10L10n-bot) [20:47:59] (03CR) 10Jforrester: [C: 03+2] "Manually checked." [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/516952 (owner: 10L10n-bot) [20:48:21] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:49:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/516920 (owner: 10L10n-bot) [20:49:38] 10Design, 10Editing Design, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): VisualEditor loading indicator should feel more integrated into the mobile interface - https://phabricator.wikimedia.org/T1181 (10matmarex) Ed reviewed and merged the changaes, and the ne... [20:49:43] (03CR) 10Jforrester: [C: 03+1] "Hmm," [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [20:51:22] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/516878 (owner: 10L10n-bot) [20:52:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/516925 (owner: 10L10n-bot) [20:52:15] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Improve component styling - https://phabricator.wikimedia.org/T225755 (10Niedzielski) [20:52:32] 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Document prerequisites and steps to have Growth team prototypes deployed on a wiki - https://phabricator.wikimedia.org/T220209 (10MMiller_WMF) @kostajh and @Trizek-WMF -- our plan is that if a community wants Growth features, they will get everything... [20:54:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/516853 (owner: 10L10n-bot) [20:56:59] (03PS18) 10TK-999: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) [20:58:16] (03PS9) 10Dmaza: [WIP] Add Special:Mute page [core] - 10https://gerrit.wikimedia.org/r/511781 (https://phabricator.wikimedia.org/T218265) [20:58:30] (03PS1) 10EBernhardson: [WIP] Support cirrus event logs via eventgate [search/glent] - 10https://gerrit.wikimedia.org/r/516954 [20:58:43] (03CR) 10Dmaza: [WIP] Add Special:Mute page (0314 comments) [core] - 10https://gerrit.wikimedia.org/r/511781 (https://phabricator.wikimedia.org/T218265) (owner: 10Dmaza) [20:58:43] 10MediaWiki-extensions-HostStats: Default configuration parameter settings get merged with new settings - https://phabricator.wikimedia.org/T225753 (10Legoktm) If we change extension.json to: `lang=json "config": { "HostStatsCommands": { "value": { "hostname": true, "df -h": true } } }, ` T... [21:00:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/516858 (owner: 10L10n-bot) [21:01:41] 10MediaWiki-Internationalization, 10Language-Team: Clean up languages/ directory in MediaWiki core (June 2019) - https://phabricator.wikimedia.org/T225756 (10Krinkle) [21:02:08] (03CR) 10MaxSem: "I'm tempted to just merge it and run away, whining happily." [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [21:02:20] (03PS1) 10Krinkle: [WIP] language: Move some language-related classes to includes/language/ [core] - 10https://gerrit.wikimedia.org/r/516955 (https://phabricator.wikimedia.org/T225756) [21:02:42] 10OOUI, 10Patch-For-Review: Replace `em` based sizing in favor of `px` based where applicable - https://phabricator.wikimedia.org/T220671 (10Volker_E) [21:03:20] James_F: Wanna switch travis/postgres from 7.1 to 7.2 separately just in case? [21:03:26] (or maybe we don't need it anymore?) [21:03:27] (03PS10) 10Dmaza: [WIP] Add Special:Mute page [core] - 10https://gerrit.wikimedia.org/r/511781 (https://phabricator.wikimedia.org/T218265) [21:03:29] (03CR) 10Jforrester: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/516829 (https://phabricator.wikimedia.org/T216165) (owner: 10Jforrester) [21:03:34] Krinkle: I did? [21:03:45] I mean in its own commit ahead of time [21:03:53] Oh! I could. [21:04:04] I'm mostly heads-down in CI docker land right now. [21:04:18] You write it, I'll merge it. :-) [21:04:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] language: Move some language-related classes to includes/language/ [core] - 10https://gerrit.wikimedia.org/r/516955 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [21:07:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/516878 (owner: 10L10n-bot) [21:08:34] 10Research: Gather experienced editor feedback beyond EnWiki - https://phabricator.wikimedia.org/T221422 (10Capt_Swing) @Elitre yes, we're looking for two kinds of CR support: - help with translating the instructions page and the call to action message - help posting the call to action message to the releva... [21:08:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/516877 (owner: 10L10n-bot) [21:10:35] (03PS1) 10Krinkle: build: Remove dbtype=postgres from Travis CI matrix [core] - 10https://gerrit.wikimedia.org/r/516956 [21:10:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/516881 (owner: 10L10n-bot) [21:10:40] 10GrowthExperiments- HomepageDiscovery, 10GrowthExperiments-Homepage, 10Desktop, 10Growth-Team (Current Sprint), 10Mobile: Homepage: traffic from email confirmation success page - https://phabricator.wikimedia.org/T222848 (10MMiller_WMF) [21:11:40] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile MVP list - https://phabricator.wikimedia.org/T225676 (10MMiller_WMF) [21:12:19] 10OOUI, 10Patch-For-Review: Replace `em` based sizing in favor of `px` based where applicable - https://phabricator.wikimedia.org/T220671 (10Volker_E) Note, the one very visible difference with the patch is the vertical slight alignment issues in buttons when user chooses a bigger font-size. We could use a lin... [21:12:28] 10GrowthExperiments, 10GrowthExperiments-Homepage, 10Epic, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile MVP list - https://phabricator.wikimedia.org/T225676 (10MMiller_WMF) [21:12:45] (03PS1) 10Foxtrott: Accept StubObject for MW Parser [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/516957 [21:13:41] (03CR) 10jerkins-bot: [V: 04-1] Accept StubObject for MW Parser [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/516957 (owner: 10Foxtrott) [21:13:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/516879 (owner: 10L10n-bot) [21:14:24] SMalyshev: here :-) [21:15:43] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile help module recent questions links to top of help desk - https://phabricator.wikimedia.org/T225746 (10MMiller_WMF) [21:16:28] (03PS2) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:18:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/516883 (owner: 10L10n-bot) [21:18:31] (03CR) 10Krinkle: Separate MediaWiki unit and integration tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:18:58] (03CR) 10Foxtrott: [V: 03+2 C: 03+2] Accept StubObject for MW Parser [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/516957 (owner: 10Foxtrott) [21:19:28] (03PS3) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:20:08] (03CR) 10Krinkle: "Perhaps a structure test would help to validate that /unit/ contains no tests with group Database, and no tests that extend MediaWikiTestC" [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:20:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/516894 (owner: 10L10n-bot) [21:21:06] (03CR) 10SBassett: [C: 03+1] "I don't think e:CodeReview is deployed/active on many wikis (mw.org?) and comment-posting is disabled anyways. Nevertheless, it'd be good" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513594 (https://phabricator.wikimedia.org/T225321) (owner: 10Umherirrender) [21:21:11] (03PS4) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:21:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/516886 (owner: 10L10n-bot) [21:22:13] (03PS5) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:22:15] (03CR) 10Krinkle: Separate MediaWiki unit and integration tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:23:01] (03CR) 10Kosta Harlan: "> Patch Set 18:" [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:23:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Genealogy] - 10https://gerrit.wikimedia.org/r/516898 (owner: 10L10n-bot) [21:26:54] (03CR) 10Jforrester: [C: 03+2] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:27:22] (03CR) 10Krinkle: Separate MediaWiki unit and integration tests (033 comments) [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:27:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/516901 (owner: 10L10n-bot) [21:27:56] (03CR) 10Jforrester: [C: 03+1] "Per Krinkle's comments." [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:29:18] (03PS1) 10Kghbln: Release version 2.0.0 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) [21:29:44] (03CR) 10Krinkle: [C: 03+2] Move escaping in postCommentForm closer to output (031 comment) [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513594 (https://phabricator.wikimedia.org/T225321) (owner: 10Umherirrender) [21:29:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/516900 (owner: 10L10n-bot) [21:30:16] (03CR) 10jerkins-bot: [V: 04-1] Release version 2.0.0 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [21:30:56] (03PS6) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:31:45] (03PS7) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:31:50] 10MediaWiki-extensions-CodeReview, 10Release-Engineering-Team, 10Security: Parameters to Special:Code allows to prefill the textarea for a comment reply with unsafe user input - https://phabricator.wikimedia.org/T225321 (10sbassett) p:05Triage→03Normal [21:32:19] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10matmarex) No need to backport anything. To clarify, this message used to be an exception; in T205956, it was changed to a warning, and is mostly harmless now... [21:33:07] (03CR) 10Kghbln: "@Legoktm Thanks a ton for your code suggestion which I have now committed here." [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [21:33:10] (03CR) 10Gergő Tisza: "Is the patch intentionally marked as WIP? Seems feature-complete to me." (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/515143 (https://phabricator.wikimedia.org/T142080) (owner: 10Anomie) [21:33:45] (03CR) 10Jforrester: [C: 03+2] build: Remove dbtype=postgres from Travis CI matrix [core] - 10https://gerrit.wikimedia.org/r/516956 (owner: 10Krinkle) [21:34:45] (03CR) 10Krinkle: "finished review. If it passes, ignore me, for sake of rebasing and smaller patches, but expect someone will follow-up on some of it soon-i" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:35:15] 10MediaWiki-Core-Testing, 10Code-Health: Create structure test for MediaWikiUnitTestCase usage - https://phabricator.wikimedia.org/T225758 (10Krinkle) [21:35:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Jade] - 10https://gerrit.wikimedia.org/r/516907 (owner: 10L10n-bot) [21:36:20] (03CR) 10Krinkle: [C: 03+2] Declare missing class properties [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513189 (owner: 10Umherirrender) [21:37:07] (03CR) 10Krinkle: [C: 04-1] "Would recommend against non-essential changes because the extension is expected to be decommissioned soon. Any non-critical changes only c" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513189 (owner: 10Umherirrender) [21:37:23] 10MediaWiki-extensions-HostStats, 10Patch-For-Review: Default configuration parameter settings get merged with new settings - https://phabricator.wikimedia.org/T225753 (10Kghbln) @Legoktm Thanks a lot for your explanation and advice!!! I authored a new version since this is breaking. [21:37:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/516902 (owner: 10L10n-bot) [21:38:01] (03Merged) 10jenkins-bot: Move escaping in postCommentForm closer to output [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513594 (https://phabricator.wikimedia.org/T225321) (owner: 10Umherirrender) [21:38:47] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Improve component styling for MobileFrontend - https://phabricator.wikimedia.org/T225755 (10Niedzielski) [21:38:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/516910 (owner: 10L10n-bot) [21:39:18] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Improve component styling in MobileFrontend - https://phabricator.wikimedia.org/T225755 (10Niedzielski) [21:40:37] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:42:49] (03CR) 10Legoktm: [C: 04-1] Release version 2.0.0 (031 comment) [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [21:43:01] (03CR) 10Jforrester: [C: 03+1] "check coverage" [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:44:12] (03CR) 10Jforrester: [C: 03+2] "check coverage" [core] - 10https://gerrit.wikimedia.org/r/516956 (owner: 10Krinkle) [21:44:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/516914 (owner: 10L10n-bot) [21:45:23] (03CR) 10SBassett: [C: 03+2] Fix testsuites for LogFormatter [core] - 10https://gerrit.wikimedia.org/r/513687 (owner: 10Rxy) [21:46:07] (03CR) 10Jforrester: "check coverage" [core] - 10https://gerrit.wikimedia.org/r/516955 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [21:46:25] (03CR) 10jerkins-bot: [V: 04-1] [WIP] language: Move some language-related classes to includes/language/ [core] - 10https://gerrit.wikimedia.org/r/516955 (https://phabricator.wikimedia.org/T225756) (owner: 10Krinkle) [21:47:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/516911 (owner: 10L10n-bot) [21:48:16] (03PS2) 10Kghbln: Release version 2.0.0 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) [21:49:09] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Spike: Identify requirements and solutions for sharing assets, variables, and styles in MobileFrontend - https://phabricator.wikimedia.org/T225759 (10Niedzielski) [21:49:19] 10MediaWiki-REST-API, 10TechCom-RFC, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: REST route handler extension interface RFC - https://phabricator.wikimedia.org/T221177 (10TK-999) Is https://phabricator.wikimedia.org/T221177#5219503 cons... [21:49:32] (03PS8) 10Julia.glen: Method 2 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/516663 [21:49:34] (03Merged) 10jenkins-bot: build: Remove dbtype=postgres from Travis CI matrix [core] - 10https://gerrit.wikimedia.org/r/516956 (owner: 10Krinkle) [21:50:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/516923 (owner: 10L10n-bot) [21:50:46] (03PS3) 10Kghbln: Release version 2.0.0 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) [21:51:21] (03CR) 10Kosta Harlan: [C: 03+2] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [21:51:23] (03CR) 10jenkins-bot: build: Remove dbtype=postgres from Travis CI matrix [core] - 10https://gerrit.wikimedia.org/r/516956 (owner: 10Krinkle) [21:53:01] (03CR) 10Kghbln: "Ok, now changed to the better - hopefully." (031 comment) [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [21:53:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/516919 (owner: 10L10n-bot) [21:54:50] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Patch-For-Review: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) I’m guessing it wasn’t reported upstream? [21:54:54] (03CR) 10Kghbln: "Cool, it appears that this is in fluff now." [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [21:54:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/516928 (owner: 10L10n-bot) [21:56:51] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Krinkle) >>! In T225496#5252365, @hashar wrote: > I am not quite sure how MediaWiki selects the caches its is... [21:56:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/516927 (owner: 10L10n-bot) [21:59:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/516940 (owner: 10L10n-bot) [21:59:52] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Spike: Identify requirements and solutions for sharing assets, variables, and styles in MobileFrontend - https://phabricator.wikimedia.org/T225759 (10nray) [22:01:45] 10MediaWiki-Core-Testing, 10MediaWiki-JobQueue: HashRingTest::testHashRingKetamaMode takes 3+ seconds - https://phabricator.wikimedia.org/T225719 (10hashar) p:05Triage→03Normal @aaron indeed the `$ketama_test( 1e5 )` is the culprit and lowering it down to 10000 get it down to half a second. Is there any... [22:01:52] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [22:01:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/516929 (owner: 10L10n-bot) [22:02:07] (03CR) 10jerkins-bot: [V: 04-1] Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [22:03:01] (03CR) 10Gergő Tisza: "> > # Giving the site admin control: if someone wants to replace or modify the Router (e.g. because they want it to use a different cachin" [core] - 10https://gerrit.wikimedia.org/r/516577 (owner: 10Tim Starling) [22:03:57] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Krinkle) >>! In T225496#5256985, @Jdforrester-WMF wrote: > How much further improvement are we expecting? With... [22:04:19] (03PS4) 10Kghbln: Release version 2.0.0 [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) [22:04:50] (03CR) 10Gergő Tisza: [C: 03+2] REST API initial commit [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [22:05:03] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: Componentize MobileFrontend - https://phabricator.wikimedia.org/T225447 (10Niedzielski) [22:05:16] 10MediaWiki-Core-Testing, 10Continuous-Integration-Config, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10User-Ladsgroup: Improve caching in CI tests - https://phabricator.wikimedia.org/T225496 (10Jdforrester-WMF) 05Open→03Resolved WFM. Thanks! [22:05:34] (03CR) 10Gergő Tisza: [C: 03+2] Expand ResponseFactory [core] - 10https://gerrit.wikimedia.org/r/514207 (https://phabricator.wikimedia.org/T223240) (owner: 10Tim Starling) [22:05:43] (03CR) 10Gergő Tisza: [C: 03+2] REST: Implement 405 responses [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [22:05:51] (03CR) 10Gergő Tisza: [C: 03+2] REST: tests for HelloHandler and HeaderContainer [core] - 10https://gerrit.wikimedia.org/r/513548 (owner: 10Tim Starling) [22:05:53] (03CR) 10Jforrester: [V: 03+2] "Let's not hold this back just because junit is having a bad day." [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [22:05:55] (03CR) 10Kghbln: "Since we are making a major release we could as well remove the deprecated entry point. Sysadmins have to deal with this extension anyways" [extensions/HostStats] - 10https://gerrit.wikimedia.org/r/516958 (https://phabricator.wikimedia.org/T225753) (owner: 10Kghbln) [22:06:45] 10CirrusSearch, 10Discovery-Search (Current work), 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18): CirrusSearch\SearcherTest::testSearchText PHPUnit tests take a while and runs for everyone - https://phabricator.wikimedia.org/T225184 (10hashar) Thank you @dcausse :] Discovery covered its part. The second part... [22:06:47] (03CR) 10Krinkle: [C: 03+2] Fix doc type of Installer::addInstallStep [core] - 10https://gerrit.wikimedia.org/r/516666 (owner: 10Umherirrender) [22:07:44] (03CR) 10Gergő Tisza: [C: 03+2] StringStream and PathMatcher tests [core] - 10https://gerrit.wikimedia.org/r/513951 (owner: 10Tim Starling) [22:07:56] (03CR) 10Krinkle: [C: 03+2] Clarify MediaWikiTestCase::getSchemaOverrides() [core] - 10https://gerrit.wikimedia.org/r/512694 (owner: 10Lucas Werkmeister (WMDE)) [22:08:18] (03CR) 10jenkins-bot: Separate MediaWiki unit and integration tests [core] - 10https://gerrit.wikimedia.org/r/513106 (https://phabricator.wikimedia.org/T89432) (owner: 10TK-999) [22:08:24] (03CR) 10Gergő Tisza: [C: 03+2] REST: Testable EntryPoint [core] - 10https://gerrit.wikimedia.org/r/516449 (owner: 10Tim Starling) [22:09:30] 10MediaWiki-User-preferences, 10MW-1.32-release, 10Upstream: Error in Preferences in debug mode - https://phabricator.wikimedia.org/T225683 (10Reedy) https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4091 [22:09:49] (03CR) 10Krinkle: [C: 03+2] "Confirmed all test classes are still in the Test Report afterwards." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/516542 (owner: 10Umherirrender) [22:09:49] 10MediaWiki-HTMLForm, 10MediaWiki-Special-pages, 10Upstream: HTMLInfoField.php: 'default' must be a FieldLayout or subclass when using 'rawrow' - https://phabricator.wikimedia.org/T205956 (10Reedy) FWIW, filed upstream at https://github.com/SemanticMediaWiki/SemanticMediaWiki/issues/4091 [22:09:53] (03CR) 10Gergő Tisza: [C: 03+2] REST: Rename attributes to path params [core] - 10https://gerrit.wikimedia.org/r/516450 (owner: 10Tim Starling) [22:11:04] (03PS2) 10Krinkle: Storage: Type against ILBFactory and ILoadBalancer in storage classes [core] - 10https://gerrit.wikimedia.org/r/515083 (owner: 10Umherirrender) [22:11:07] (03CR) 10Krinkle: [C: 03+2] Storage: Type against ILBFactory and ILoadBalancer in storage classes [core] - 10https://gerrit.wikimedia.org/r/515083 (owner: 10Umherirrender) [22:11:45] 10MediaWiki-extensions-CodeReview, 10Release-Engineering-Team, 10MW-1.34-notes (1.34.0-wmf.10; 2019-06-18), 10Security: Parameters to Special:Code allows to prefill the textarea for a comment reply with unsafe user input - https://phabricator.wikimedia.org/T225321 (10Reedy) 05Open→03Resolved a:03Umher... [22:13:01] (03CR) 10Krinkle: [C: 03+2] libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer() [core] - 10https://gerrit.wikimedia.org/r/512288 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:14:51] (03PS18) 10Krinkle: SpecialEmailUser: Remove validate/get target without sender specified [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [22:14:58] (03CR) 10Krinkle: [C: 03+2] SpecialEmailUser: Remove validate/get target without sender specified [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [22:15:06] (03PS10) 10Krinkle: libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer() [core] - 10https://gerrit.wikimedia.org/r/512288 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:15:21] (03PS2) 10Krinkle: Merge 'ext.pageTriage.models' into 'ext.pageTriage.util' [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/516245 (https://phabricator.wikimedia.org/T221269) [22:17:50] 10MediaWiki-Documentation, 10MediaWiki-REST-API, 10Documentation: Document the REST API on mediawiki.org - https://phabricator.wikimedia.org/T225761 (10Tgr) [22:18:25] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Services (watching): REST API Infrastructure in MediaWiki - https://phabricator.wikimedia.org/T221737 (10Tgr) [22:18:28] (03Merged) 10jenkins-bot: REST API initial commit [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [22:18:32] (03Merged) 10jenkins-bot: Expand ResponseFactory [core] - 10https://gerrit.wikimedia.org/r/514207 (https://phabricator.wikimedia.org/T223240) (owner: 10Tim Starling) [22:19:00] James_F: Well, Yaml sucks [22:19:13] And now I know how it feels [22:19:23] The Travis CI matrix now only tests 1 variant, php 7.0 [22:19:47] Can tell because https://travis-ci.org/wikimedia/mediawiki/builds now, after my commit, no longer links to in-between build overview pages [22:19:54] Ha. Whoops. [22:19:56] (03PS3) 10Krinkle: Merge module 'ext.pageTriage.models' into 'ext.pageTriage.util' [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/516245 (https://phabricator.wikimedia.org/T221269) [22:20:18] (03PS1) 10QChris: Add .gitreview [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/516965 [22:20:20] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [tools/phan/PerfCheckPlugin] - 10https://gerrit.wikimedia.org/r/516965 (owner: 10QChris) [22:20:21] fixing now [22:21:13] 10MediaWiki-REST-API, 10Librarization: Librarize the MediaWiki REST API framework - https://phabricator.wikimedia.org/T225762 (10Tgr) [22:21:45] (03CR) 10Smalyshev: [C: 03+1] "some nitpicks but lgtm" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/516637 (https://phabricator.wikimedia.org/T216429) (owner: 10DCausse) [22:22:32] (03PS1) 10Krinkle: build: Add missing dashes in .travis.yml (restore PHP 7.1/7.2 tests) [core] - 10https://gerrit.wikimedia.org/r/516966 [22:22:39] (03CR) 10Krinkle: "Done" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/516245 (https://phabricator.wikimedia.org/T221269) (owner: 10Krinkle) [22:22:41] James_F: ^ [22:23:10] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): REST API Handler Interface - https://phabricator.wikimedia.org/T219960 (10Tgr) [22:23:12] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Sample REST API Handler - https://phabricator.wikimedia.org/T219961 (10Tgr) 05Open→03Resolved This has been merged. [22:24:08] (03CR) 10Jforrester: [C: 03+2] "Dash mash bash smash." [core] - 10https://gerrit.wikimedia.org/r/516966 (owner: 10Krinkle) [22:24:38] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): REST API Handler Interface - https://phabricator.wikimedia.org/T219960 (10Tgr) Resolved now, I suppose? [22:25:28] (03CR) 10Krinkle: "Needs both, because HHVM-like-PHP5 doesn't. See API code for examples." [core] - 10https://gerrit.wikimedia.org/r/516756 (owner: 10Aaron Schulz) [22:25:32] (03CR) 10Krinkle: [C: 04-1] rdbms: improve exception handling in Database [core] - 10https://gerrit.wikimedia.org/r/516756 (owner: 10Aaron Schulz) [22:25:58] (03CR) 10Krinkle: [C: 04-1] "(surprised the tests passed, I guess we're not covering these failure cases?)" [core] - 10https://gerrit.wikimedia.org/r/516756 (owner: 10Aaron Schulz) [22:27:02] 10MediaWiki-REST-API, 10TechCom-RFC, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: REST route handler extension interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) >>! In T221177#5257809, @TK-999 wrote: > Is https://phabrica... [22:27:04] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Logged in admin user still shows as logged-out in menu, cannot edit semi-protected pages - https://phabricator.wikimedia.org/T225442 (10cooltey) @Charlotte I cannot reproduce it using my general account. If someone has... [22:27:50] (03CR) 10jenkins-bot: REST API initial commit [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [22:27:56] (03CR) 10Krinkle: [C: 04-1] rdbms: improve exception handling in Database (032 comments) [core] - 10https://gerrit.wikimedia.org/r/516756 (owner: 10Aaron Schulz) [22:28:40] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Spike: Identify requirements and solutions for sharing assets, LESS variables, and styles in MobileFrontend - https://phabricator.wikimedia.org/T225759 (10Niedzielski) [22:29:09] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Spike: Identify requirements and solutions for sharing assets, LESS variables, and styles in MobileFrontend - https://phabricator.wikimedia.org/T225759 (10Niedzielski) [22:29:20] (03CR) 10jenkins-bot: Expand ResponseFactory [core] - 10https://gerrit.wikimedia.org/r/514207 (https://phabricator.wikimedia.org/T223240) (owner: 10Tim Starling) [22:31:29] (03CR) 10jerkins-bot: [V: 04-1] REST: Implement 405 responses [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [22:31:31] (03CR) 10jerkins-bot: [V: 04-1] REST: tests for HelloHandler and HeaderContainer [core] - 10https://gerrit.wikimedia.org/r/513548 (owner: 10Tim Starling) [22:31:33] (03CR) 10jerkins-bot: [V: 04-1] StringStream::copyToStream() should adjust the offset [core] - 10https://gerrit.wikimedia.org/r/513950 (owner: 10Tim Starling) [22:31:35] (03CR) 10jerkins-bot: [V: 04-1] StringStream and PathMatcher tests [core] - 10https://gerrit.wikimedia.org/r/513951 (owner: 10Tim Starling) [22:31:37] (03CR) 10jerkins-bot: [V: 04-1] REST: HeaderContainer should start empty not null [core] - 10https://gerrit.wikimedia.org/r/516448 (owner: 10Tim Starling) [22:31:39] (03CR) 10jerkins-bot: [V: 04-1] REST: Testable EntryPoint [core] - 10https://gerrit.wikimedia.org/r/516449 (owner: 10Tim Starling) [22:31:41] (03CR) 10jerkins-bot: [V: 04-1] REST: Rename attributes to path params [core] - 10https://gerrit.wikimedia.org/r/516450 (owner: 10Tim Starling) [22:31:43] (03CR) 10jenkins-bot: Move escaping in postCommentForm closer to output [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/513594 (https://phabricator.wikimedia.org/T225321) (owner: 10Umherirrender) [22:33:56] (03PS1) 10TK-999: Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 [22:35:12] Sorry, the V-1s are my fault; ^^ probably fixes them. [22:35:29] (03CR) 10Jforrester: [C: 03+1] Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 (owner: 10TK-999) [22:37:28] (03CR) 10jerkins-bot: [V: 04-1] Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 (owner: 10TK-999) [22:39:22] (03CR) 10jerkins-bot: [V: 04-1] Fix doc type of Installer::addInstallStep [core] - 10https://gerrit.wikimedia.org/r/516666 (owner: 10Umherirrender) [22:42:31] 10Advanced Mobile Contributions, 10Epic, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] AMC Navigation - user menu - https://phabricator.wikimedia.org/T214540 (10Niedzielski) a:05Niedzielski→03None De-assigning from myself as I'm focused on planning at the mo... [22:43:06] (03CR) 10Gergő Tisza: [C: 03+2] "recheck, the error seems unrelated:" [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [22:43:22] tgr: I broke core, sorry. [22:43:27] 10WikiApiary: CategoryTree - Babel categories - https://phabricator.wikimedia.org/T225744 (10Reedy) [22:43:29] tgr: It's not fixed yet. [22:45:01] ah, OK, will just wait it out then [22:46:01] (03PS2) 10TK-999: Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 [22:47:55] James_F: Need any help? [22:48:10] 10docker-pkg: Make docker-pkg work on Macs again - https://phabricator.wikimedia.org/T225764 (10Jdforrester-WMF) [22:48:46] Reedy: Probably not? Just time for CI to actually run things and approve them. [22:48:50] (03CR) 10jerkins-bot: [V: 04-1] Clarify MediaWikiTestCase::getSchemaOverrides() [core] - 10https://gerrit.wikimedia.org/r/512694 (owner: 10Lucas Werkmeister (WMDE)) [22:48:55] Just cheking :) [22:49:10] Helpfully non-core patches pass fine because we don't check core's postgres support against them. [22:49:36] (03CR) 10jerkins-bot: [V: 04-1] Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 (owner: 10TK-999) [22:53:20] I could disable the postgres job for a few minutes whilst we fix it… [22:54:12] (03Merged) 10jenkins-bot: Remove hook UnitTestsList [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/516542 (owner: 10Umherirrender) [23:00:14] (03PS1) 10Legoktm: Revert "Separate MediaWiki unit and integration tests" [core] - 10https://gerrit.wikimedia.org/r/516971 [23:01:27] 10wmerrors, 10Software-Licensing: wmerrors has no license information - https://phabricator.wikimedia.org/T224076 (10tstarling) I think MIT is more compatible with upstream. It's what we used for LuaSandbox. [23:01:31] 10InternetArchiveBot: Detect 451 dead links as dead instead of alive - https://phabricator.wikimedia.org/T225765 (10KristofferR) [23:01:32] (03CR) 10Legoktm: [C: 03+2] Revert "Separate MediaWiki unit and integration tests" [core] - 10https://gerrit.wikimedia.org/r/516971 (owner: 10Legoktm) [23:02:27] 10InternetArchiveBot: Detect dead links (451 HTTP error) as dead instead of alive - https://phabricator.wikimedia.org/T225765 (10KristofferR) [23:02:48] (03CR) 10jerkins-bot: [V: 04-1] Storage: Type against ILBFactory and ILoadBalancer in storage classes [core] - 10https://gerrit.wikimedia.org/r/515083 (owner: 10Umherirrender) [23:04:28] (03PS3) 10TK-999: Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 [23:07:41] (03PS1) 10Tim Starling: MIT license [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516972 [23:08:14] (03CR) 10jerkins-bot: [V: 04-1] Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 (owner: 10TK-999) [23:08:49] (03CR) 10jerkins-bot: [V: 04-1] Reset the DB prefix between tests [core] - 10https://gerrit.wikimedia.org/r/516968 (owner: 10TK-999) [23:09:12] (03PS2) 10Jforrester: MIT license [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516972 (https://phabricator.wikimedia.org/T224076) (owner: 10Tim Starling) [23:12:02] (03CR) 10jerkins-bot: [V: 04-1] SpecialEmailUser: Remove validate/get target without sender specified [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [23:13:11] (03CR) 10MaxSem: [C: 03+1] MIT license [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516972 (https://phabricator.wikimedia.org/T224076) (owner: 10Tim Starling) [23:14:30] (03CR) 10jerkins-bot: [V: 04-1] build: Add missing dashes in .travis.yml (restore PHP 7.1/7.2 tests) [core] - 10https://gerrit.wikimedia.org/r/516966 (owner: 10Krinkle) [23:14:44] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/516966 (owner: 10Krinkle) [23:15:51] (03CR) 10jerkins-bot: [V: 04-1] REST: Implement 405 responses [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [23:15:53] (03CR) 10jerkins-bot: [V: 04-1] REST: tests for HelloHandler and HeaderContainer [core] - 10https://gerrit.wikimedia.org/r/513548 (owner: 10Tim Starling) [23:15:55] (03CR) 10jerkins-bot: [V: 04-1] StringStream::copyToStream() should adjust the offset [core] - 10https://gerrit.wikimedia.org/r/513950 (owner: 10Tim Starling) [23:15:57] (03CR) 10jerkins-bot: [V: 04-1] StringStream and PathMatcher tests [core] - 10https://gerrit.wikimedia.org/r/513951 (owner: 10Tim Starling) [23:15:59] (03CR) 10jerkins-bot: [V: 04-1] REST: HeaderContainer should start empty not null [core] - 10https://gerrit.wikimedia.org/r/516448 (owner: 10Tim Starling) [23:16:01] (03CR) 10jerkins-bot: [V: 04-1] REST: Testable EntryPoint [core] - 10https://gerrit.wikimedia.org/r/516449 (owner: 10Tim Starling) [23:16:03] (03CR) 10jerkins-bot: [V: 04-1] REST: Rename attributes to path params [core] - 10https://gerrit.wikimedia.org/r/516450 (owner: 10Tim Starling) [23:16:05] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [23:16:12] (03CR) 10Tim Starling: "> Patch Set 1:" [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516763 (owner: 10Tim Starling) [23:16:24] 10Documentation: Improve resources for technical documentarians across Wikimedia projects - https://phabricator.wikimedia.org/T197006 (10Aklapper) CC'ing @srishakatux ^ [23:16:41] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [23:17:19] 10Documentation: Improve resources for technical documentarians across Wikimedia projects - https://phabricator.wikimedia.org/T197006 (10Quiddity) Hi. I believe you're already working on https://www.mediawiki.org/wiki/User:Pavithraes/Sandbox/Technical_documentation_templates_and_suggestions (as a replacement for... [23:17:22] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/515083 (owner: 10Umherirrender) [23:17:27] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/512694 (owner: 10Lucas Werkmeister (WMDE)) [23:17:32] (03CR) 10Jforrester: [C: 03+2] "Re-triggering merge." [core] - 10https://gerrit.wikimedia.org/r/516666 (owner: 10Umherirrender) [23:17:43] (03PS2) 10Tim Starling: Add wmerrors.error_script_file [php/wmerrors] - 10https://gerrit.wikimedia.org/r/516763 (https://phabricator.wikimedia.org/T187147) [23:18:09] (03PS1) 10Reedy: Update monolog/monolog from 1.22.1 -> 1.24.0 [vendor] - 10https://gerrit.wikimedia.org/r/516973 [23:19:56] (03PS1) 10Reedy: Update monolog/monolog from 1.22.1 -> 1.24.0 [core] - 10https://gerrit.wikimedia.org/r/516974 [23:28:18] (03Merged) 10jenkins-bot: Revert "Separate MediaWiki unit and integration tests" [core] - 10https://gerrit.wikimedia.org/r/516971 (owner: 10Legoktm) [23:28:22] (03CR) 10jerkins-bot: [V: 04-1] build: Add missing dashes in .travis.yml (restore PHP 7.1/7.2 tests) [core] - 10https://gerrit.wikimedia.org/r/516966 (owner: 10Krinkle) [23:31:06] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: Option to "Use secure connection" appears on secure connection. - https://phabricator.wikimedia.org/T225728 (10Aklapper) The code seems to be in [`/includes/specialpage/LoginSignupSpecialPage.php`](https://phabricator.wikimedia.or... [23:31:12] (03CR) 10jenkins-bot: Revert "Separate MediaWiki unit and integration tests" [core] - 10https://gerrit.wikimedia.org/r/516971 (owner: 10Legoktm) [23:35:57] (03CR) 10Jforrester: [C: 03+2] "Bah, I got the ordering wrong. Third try!" [core] - 10https://gerrit.wikimedia.org/r/516966 (owner: 10Krinkle) [23:38:26] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup: Option to "Use secure connection" appears on secure connection. - https://phabricator.wikimedia.org/T225728 (10Reedy) What version of MediaWiki? What is `$wgSecureLogin` set to on your wiki? [23:40:10] (03CR) 10jerkins-bot: [V: 04-1] REST: Implement 405 responses [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [23:40:12] (03CR) 10jerkins-bot: [V: 04-1] REST: tests for HelloHandler and HeaderContainer [core] - 10https://gerrit.wikimedia.org/r/513548 (owner: 10Tim Starling) [23:40:14] (03CR) 10jerkins-bot: [V: 04-1] StringStream::copyToStream() should adjust the offset [core] - 10https://gerrit.wikimedia.org/r/513950 (owner: 10Tim Starling) [23:40:16] (03CR) 10jerkins-bot: [V: 04-1] StringStream and PathMatcher tests [core] - 10https://gerrit.wikimedia.org/r/513951 (owner: 10Tim Starling) [23:40:18] (03CR) 10jerkins-bot: [V: 04-1] REST: HeaderContainer should start empty not null [core] - 10https://gerrit.wikimedia.org/r/516448 (owner: 10Tim Starling) [23:40:20] (03CR) 10jerkins-bot: [V: 04-1] REST: Testable EntryPoint [core] - 10https://gerrit.wikimedia.org/r/516449 (owner: 10Tim Starling) [23:40:22] (03CR) 10jerkins-bot: [V: 04-1] REST: Rename attributes to path params [core] - 10https://gerrit.wikimedia.org/r/516450 (owner: 10Tim Starling) [23:40:23] * James_F sighs. [23:40:47] Bloody rollback test. [23:42:27] (03CR) 10Jforrester: [C: 03+2] "…" [core] - 10https://gerrit.wikimedia.org/r/513545 (owner: 10Tim Starling) [23:43:46] 10Repository-Admins: Create OpenJsCad MediaWiki extension - https://phabricator.wikimedia.org/T225532 (10MarkAHershberger) @WolfgangFahl while I agree that this could be simpler, I think part of the problem is the username is not correct. For instance, mine is "mah" but I log into the website with "MarkAHershbe... [23:47:39] (03PS2) 10Krinkle: [WIP] RCFilters: Reduce startup overhead from 'config.json' computation [core] - 10https://gerrit.wikimedia.org/r/516850 (https://phabricator.wikimedia.org/T201574) [23:47:55] (03CR) 10Krinkle: [WIP] RCFilters: Reduce startup overhead from 'config.json' computation (031 comment) [core] - 10https://gerrit.wikimedia.org/r/516850 (https://phabricator.wikimedia.org/T201574) (owner: 10Krinkle) [23:52:25] (03Merged) 10jenkins-bot: SpecialEmailUser: Remove validate/get target without sender specified [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [23:52:32] (03Merged) 10jenkins-bot: libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer() [core] - 10https://gerrit.wikimedia.org/r/512288 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:53:53] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Incomplete template adaptation presented as missing - https://phabricator.wikimedia.org/T224437 (10Petar.petkovic) I have uploaded the patch that should show missing template warning only when template is really missing. Pr... [23:57:39] (03CR) 10jenkins-bot: SpecialEmailUser: Remove validate/get target without sender specified [core] - 10https://gerrit.wikimedia.org/r/510133 (owner: 10D3r1ck01) [23:58:59] (03CR) 10jenkins-bot: libs: Remove unused deprecated BufferingStatsdDataFactory::getBuffer() [core] - 10https://gerrit.wikimedia.org/r/512288 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01)