[00:03:02] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/508670 (owner: 10Jforrester) [00:03:05] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Score] - 10https://gerrit.wikimedia.org/r/508642 (owner: 10Jforrester) [00:03:06] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/508649 (owner: 10Jforrester) [00:03:08] (03Merged) 10jenkins-bot: build: Replace jsonlint with eslint [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/508685 (owner: 10Jforrester) [00:03:12] 10MediaWiki-extensions-OATHAuth: OATHAuth disable 2fa doesn't properly check getLoginSecurityLevel() - https://phabricator.wikimedia.org/T222849 (10Tgr) 05Open→03Invalid SpecialDisableOATHForUser disables OAuth for other users. (Shame on someone for not documenting what the class does :) SpecialOATHDisable d... [00:03:18] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/508622 (owner: 10Jforrester) [00:04:23] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Score] - 10https://gerrit.wikimedia.org/r/508642 (owner: 10Jforrester) [00:05:20] (03CR) 10jenkins-bot: build: Replace jsonlint with eslint [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/508685 (owner: 10Jforrester) [00:05:59] (03CR) 10jenkins-bot: Remove 'wgCirrusSearchEnableSearchLogging' from startup JS export [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/508889 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [00:08:14] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/508649 (owner: 10Jforrester) [00:08:17] (03CR) 10Ephemeralwaves: WIP Test that checks for user mention alerts (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [00:09:42] 10Phabricator, 10Release-Engineering-Team (Kanban): Calendar shows "Unhandled exception error: Expected a single result!" - https://phabricator.wikimedia.org/T220241 (10mmodell) 05Open→03Resolved [00:09:47] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/508620 (owner: 10Jforrester) [00:09:59] 10Phabricator, 10Release-Engineering-Team (Kanban): Calendar shows "Unhandled exception error: Expected a single result!" - https://phabricator.wikimedia.org/T220241 (10mmodell) @RhinosF1 it's been deployed now. [00:10:43] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/508620 (owner: 10Jforrester) [00:13:24] (03CR) 10jenkins-bot: Remove redundant 'return true' from non-abortable hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508437 (owner: 10Krinkle) [00:14:11] (03PS1) 10Tombolano: Corrected coding style [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/508963 [00:15:30] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/508661 (owner: 10Jforrester) [00:16:57] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/508652 (owner: 10Jforrester) [00:16:59] (03Merged) 10jenkins-bot: build: Install eslint [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/508640 (owner: 10Jforrester) [00:17:01] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/508641 (owner: 10Jforrester) [00:18:55] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508684 (owner: 10Jforrester) [00:19:20] (03CR) 10jenkins-bot: build: Install eslint [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/508640 (owner: 10Jforrester) [00:19:56] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/508870 (owner: 10Jforrester) [00:20:01] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/508641 (owner: 10Jforrester) [00:21:50] (03PS1) 10Aaron Schulz: Fix stale client caching of history pages with $wgShowUpdateMarker enabled [core] - 10https://gerrit.wikimedia.org/r/508965 [00:22:55] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/508622 (owner: 10Jforrester) [00:24:29] (03CR) 10MaxSem: [C: 03+2] build: Install eslint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508683 (owner: 10Jforrester) [00:24:53] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/508652 (owner: 10Jforrester) [00:26:01] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/508659 (owner: 10Jforrester) [00:26:04] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/508870 (owner: 10Jforrester) [00:26:21] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/508658 (owner: 10Jforrester) [00:27:06] 10MediaWiki-ResourceLoader, 10Release-Engineering-Team, 10Scap, 10Patch-For-Review, and 2 others: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) - https://phabricator.wikimedia.org/T222539 (10thcipriani) >>! In T222539#5169146, @gerritbot wrote: > Change 508488 **merged**... [00:28:08] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/508870 (owner: 10Jforrester) [00:28:13] (03CR) 10MaxSem: [C: 03+2] build: Install eslint [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/508646 (owner: 10Jforrester) [00:29:33] (03Merged) 10jenkins-bot: build: Install eslint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508683 (owner: 10Jforrester) [00:30:59] (03CR) 10jenkins-bot: build: Install eslint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508683 (owner: 10Jforrester) [00:31:01] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508684 (owner: 10Jforrester) [00:32:03] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/XAnalytics] - 10https://gerrit.wikimedia.org/r/508684 (owner: 10Jforrester) [00:34:05] (03CR) 10jerkins-bot: [V: 04-1] Fix stale client caching of history pages with $wgShowUpdateMarker enabled [core] - 10https://gerrit.wikimedia.org/r/508965 (owner: 10Aaron Schulz) [00:34:30] (03CR) 10Yaron Koren: "Looks good! I just have two comments - one comment is in the code, and the other is that the commit message should not include "Added appr" (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [00:49:40] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/508659 (owner: 10Jforrester) [00:53:29] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/508658 (owner: 10Jforrester) [00:53:31] (03Merged) 10jenkins-bot: build: Install eslint [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/508646 (owner: 10Jforrester) [00:53:33] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/508647 (owner: 10Jforrester) [00:57:22] (03PS1) 10GeoffreyT2000: Remove title protection correctly for undeletions and imports [core] - 10https://gerrit.wikimedia.org/r/508967 (https://phabricator.wikimedia.org/T200088) [01:01:50] (03PS2) 10GeoffreyT2000: Remove title protection correctly for undeletions and imports [core] - 10https://gerrit.wikimedia.org/r/508967 (https://phabricator.wikimedia.org/T200088) [01:01:52] (03CR) 10Jforrester: [C: 03+2] "..." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/508648 (owner: 10Jforrester) [01:02:13] (03CR) 10Jforrester: [C: 03+2] "..." [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/508665 (owner: 10Jforrester) [01:05:44] (03CR) 10Jforrester: Rename CDN config variables to be generic, deprecating the old names (031 comment) [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [01:15:29] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/508648 (owner: 10Jforrester) [01:15:30] (03Merged) 10jenkins-bot: build: Install eslint [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/508665 (owner: 10Jforrester) [01:15:33] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/508666 (owner: 10Jforrester) [01:17:15] (03CR) 10jenkins-bot: build: Install eslint [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/508665 (owner: 10Jforrester) [01:17:37] (03CR) 10jerkins-bot: [V: 04-1] Remove title protection correctly for undeletions and imports [core] - 10https://gerrit.wikimedia.org/r/508967 (https://phabricator.wikimedia.org/T200088) (owner: 10GeoffreyT2000) [01:20:19] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/508648 (owner: 10Jforrester) [01:21:23] (03Abandoned) 10Jforrester: rdbms: add missing return value to LoadBalancer::waitForReplication() [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/504811 (owner: 10Paladox) [01:22:12] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/508666 (owner: 10Jforrester) [01:22:33] (03CR) 10Jforrester: [C: 03+2] "Nice idea." [core] - 10https://gerrit.wikimedia.org/r/508824 (owner: 10Zoranzoki21) [01:28:13] (03CR) 10Jforrester: [C: 03+1] Introduce MovePage::moveSubpages(IfAllowed) [core] - 10https://gerrit.wikimedia.org/r/504337 (owner: 10simetrical) [01:31:00] 10Graphs, 10Outreach-Programs-Projects: Support Vega 3.0 and Vega Lite 2.0 - https://phabricator.wikimedia.org/T165118 (10Xiaoyanghaitao) Hi, My name is Xin Chen, I'm the student who wants to participate in this project. I’m a master student majoring computer science at visualization group in Shandong Univers... [01:32:43] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/508638 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [01:32:46] (03CR) 10Jforrester: "This makes the "primary" version `__লুকানো_বিষয়শ্রেণী__` instead of `__লুকায়িতবিষয়শ্রেণী__`, but the task just says adding `_লুকানোবিষয়" [core] - 10https://gerrit.wikimedia.org/r/507488 (https://phabricator.wikimedia.org/T222126) (owner: 10Aftab) [01:32:54] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508634 (owner: 10Jforrester) [01:33:05] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/508645 (owner: 10Jforrester) [01:33:18] (03CR) 10MaxSem: [C: 03+2] build: Install eslint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508632 (owner: 10Jforrester) [01:33:30] (03CR) 10MaxSem: [C: 03+2] build: Install eslint [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/508629 (owner: 10Jforrester) [01:33:48] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/508630 (owner: 10Jforrester) [01:34:00] (03CR) 10MaxSem: [C: 03+2] build: Install eslint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508627 (owner: 10Jforrester) [01:34:14] (03CR) 10MaxSem: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508628 (owner: 10Jforrester) [01:37:04] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/500459 (owner: 10DCausse) [01:37:20] (03CR) 10Eevans: [WIP] Serve OpenAPI specification (032 comments) [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [01:37:58] (03PS4) 10Eevans: Serve OpenAPI specification [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) [01:37:58] (03CR) 10Jforrester: Fix logic in getDiffHistLinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/357206 (owner: 10Matěj Suchánek) [01:38:31] (03Merged) 10jenkins-bot: Make skins/README looks like extensions/README file [core] - 10https://gerrit.wikimedia.org/r/508824 (owner: 10Zoranzoki21) [01:38:46] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [01:39:48] 10Product-Analytics, 10VisualEditor (Current work): Instrument structured workflows and their non-stuctured counterparts in the mobile visual editor - https://phabricator.wikimedia.org/T222367 (10ppelberg) [01:40:06] 10Product-Analytics, 10VisualEditor (Current work): Instrument structured workflows and their non-stuctured counterparts in the mobile visual editor - https://phabricator.wikimedia.org/T222367 (10ppelberg) [01:40:31] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/507176 (https://phabricator.wikimedia.org/T221887) (owner: 10Pppery) [01:40:45] 10Product-Analytics, 10VisualEditor (Current work): Define event logging needs within the *existing* adding/modifying links + citations workflow - https://phabricator.wikimedia.org/T222395 (10ppelberg) [01:41:31] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Threshold to prevent publishing needs more precision - https://phabricator.wikimedia.org/T221930 (10Etonkovidova) Checked in `testwiki wmf.4` Some issues (1) >The threshold should consider the ini... [01:41:50] 10Product-Analytics, 10VisualEditor (Current work): Define event logging needs within the *existing* adding/modifying links + citations workflow - https://phabricator.wikimedia.org/T222395 (10ppelberg) Updating this task's description to include the defining the logging needs within the //existing// **citation... [01:42:09] (03CR) 10Jforrester: "Not entirely happy with having such a dirty copy, but that's what upstream has..." [core] - 10https://gerrit.wikimedia.org/r/506857 (owner: 10Jforrester) [01:45:42] (03CR) 10jenkins-bot: Make skins/README looks like extensions/README file [core] - 10https://gerrit.wikimedia.org/r/508824 (owner: 10Zoranzoki21) [01:46:13] (03CR) 10Jforrester: [C: 03+2] store: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [01:46:38] (03CR) 10Eevans: "@akosiaris, I'm curious what you think about the temptating of the specification here. It rubs me the wrong way, but seemed marginally be" [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [01:50:52] (03CR) 10Jforrester: [C: 03+2] Simplify by using ?: operator [core] - 10https://gerrit.wikimedia.org/r/503937 (owner: 10Fomafix) [01:54:29] (03CR) 10Jforrester: [C: 03+2] Hard deprecate Password::equals() [core] - 10https://gerrit.wikimedia.org/r/497098 (owner: 10MaxSem) [02:01:26] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/508638 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [02:01:28] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/508645 (owner: 10Jforrester) [02:01:30] (03Merged) 10jenkins-bot: build: Install eslint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508632 (owner: 10Jforrester) [02:02:30] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/508638 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [02:03:03] (03CR) 10Jforrester: [C: 03+1] "(Pending final decision on Phab, and rebase.)" [core] - 10https://gerrit.wikimedia.org/r/502667 (https://phabricator.wikimedia.org/T207750) (owner: 10Gergő Tisza) [02:04:43] (03CR) 10jenkins-bot: build: Install eslint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508632 (owner: 10Jforrester) [02:06:31] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508634 (owner: 10Jforrester) [02:06:33] (03Merged) 10jenkins-bot: build: Install eslint [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/508629 (owner: 10Jforrester) [02:06:35] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/PdfHandler] - 10https://gerrit.wikimedia.org/r/508630 (owner: 10Jforrester) [02:06:37] (03Merged) 10jenkins-bot: build: Install eslint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508627 (owner: 10Jforrester) [02:06:39] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508628 (owner: 10Jforrester) [02:06:41] (03Merged) 10jenkins-bot: store: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [02:07:41] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Poem] - 10https://gerrit.wikimedia.org/r/508634 (owner: 10Jforrester) [02:07:50] (03CR) 10jerkins-bot: [V: 04-1] Simplify by using ?: operator [core] - 10https://gerrit.wikimedia.org/r/503937 (owner: 10Fomafix) [02:08:06] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/508645 (owner: 10Jforrester) [02:09:46] (03Merged) 10jenkins-bot: Hard deprecate Password::equals() [core] - 10https://gerrit.wikimedia.org/r/497098 (owner: 10MaxSem) [02:10:17] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508628 (owner: 10Jforrester) [02:11:00] (03CR) 10Yaron Koren: [C: 03+2] Corrected coding style [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/508963 (owner: 10Tombolano) [02:12:22] (03CR) 10jenkins-bot: build: Install eslint [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508627 (owner: 10Jforrester) [02:14:19] (03CR) 10jenkins-bot: store: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [02:15:58] (03CR) 10jenkins-bot: Hard deprecate Password::equals() [core] - 10https://gerrit.wikimedia.org/r/497098 (owner: 10MaxSem) [02:47:45] (03CR) 10Aftab: "> This makes the "primary" version `__লুকানো_বিষয়শ্রেণী__` instead" [core] - 10https://gerrit.wikimedia.org/r/507488 (https://phabricator.wikimedia.org/T222126) (owner: 10Aftab) [02:50:36] (03CR) 10Aftab: "* Sorry i mean to say "or without underscore `__লুকানোবিষয়শ্রেণী__`"" [core] - 10https://gerrit.wikimedia.org/r/507488 (https://phabricator.wikimedia.org/T222126) (owner: 10Aftab) [03:00:58] 10MediaWiki-General-or-Unknown, 10Bengali-Sites, 10Patch-For-Review: Add another Bengali synonym for HIDDENCAT in MessagesBn.php - https://phabricator.wikimedia.org/T222126 (10Aftabuzzaman) [04:02:04] (03CR) 10Samwilson: "Looks good I think." (032 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [04:08:18] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Samwilson) This is ready to merge, but we've not done so yet... [04:14:10] (03PS1) 10Dan1wang: optimize and some formatting (T222856) [wikipeg] - 10https://gerrit.wikimedia.org/r/508971 [04:18:31] 10Anti-Harassment, 10Wikimedia-Site-requests: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Ammarpad) [04:44:26] (03PS1) 10Tim Starling: [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) [04:48:51] 10Graphs, 10Outreach-Programs-Projects: Support Vega 3.0+ and Vega Lite 2.0+ - https://phabricator.wikimedia.org/T165118 (10Yurik) [04:51:02] (03CR) 10jerkins-bot: [V: 04-1] [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [04:51:34] (03PS2) 10Tim Starling: [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) [04:51:59] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: improve error handling for questions that trigger abuse-filter - https://phabricator.wikimedia.org/T222204 (10Urbanecm) >>! In T222204#5168845, @MMiller_WMF wrot... [04:55:53] 10Product-Analytics, 10Reading-analysis: I would like to get aggregated hourly pageviews data from Benin to all wikipedias on 2018-04-28 UTC - https://phabricator.wikimedia.org/T222047 (10Zache) It seems that "//With the election results validated by the constitutional court, MPs are to be formally sworn in on... [04:59:18] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Define translatable namespaces for CX - https://phabricator.wikimedia.org/T198205 (10santhosh) @Petar.petkovic commented in this patch: > > > Presence of ':' in article title does not guarantee it is in non-main namespace.... [05:01:35] (03CR) 10jerkins-bot: [V: 04-1] [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [05:11:48] (03PS3) 10Tim Starling: [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) [05:26:47] (03CR) 10jerkins-bot: [V: 04-1] [WIP] REST API [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [05:30:47] 10Phabricator, 10Release-Engineering-Team (Kanban): Calendar shows "Unhandled exception error: Expected a single result!" - https://phabricator.wikimedia.org/T220241 (10RhinosF1) Thanks @mmodell [05:40:49] 10MediaWiki-History-and-Diffs: Internal error (ParameterTypeException) when diff certain history on zh.wiki - https://phabricator.wikimedia.org/T222857 (10fireattack) [05:41:28] 10MediaWiki-History-and-Diffs: Internal error (ParameterTypeException) when diff certain history on zh.wiki - https://phabricator.wikimedia.org/T222857 (10fireattack) [05:45:03] (03CR) 10Raimond Spekking: [C: 03+1] "i18n review" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/508769 (owner: 10DmitriyShevliakov) [05:49:35] 10MediaWiki-Cache, 10DBA, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) @aaron @Krinkle @jcrespo I would appreciate a review of ^ - it should be a quick one... [05:57:24] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222628 (10Erutuon) I am seeing what might be the same error on the English Wiktionar... [06:12:09] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10tstarling) I mentioned in TechCom that DB normalisation can sometimes cause performance problems with range queries. For example, if a page has a very large number of outbound links, and you want to pa... [06:12:36] 10MediaWiki-extensions-PagedTiffHandler, 10PHP 7.2 support, 10User-DannyS712, 10Wikimedia-production-error: Variable from InitialiseSettings can be undefined (corrupt opcache?) - https://phabricator.wikimedia.org/T218005 (10DannyS712) @Krinkle this task predates T221347 by a month - isn't that one the dupl... [06:15:53] (03PS47) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [06:16:37] (03CR) 10Tim Starling: "The phpcs failures will be addressed in the next commit, except for the ones about direct access to $_GET and $_POST. As I said in the tas" [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [06:21:36] 10MediaWiki-History-and-Diffs: Internal error (ParameterTypeException) when diff certain history on zh.wiki - https://phabricator.wikimedia.org/T222857 (10Shizhao) my test: [XNPGtQpAADgAAIu8KqEAAAAS] 2019-05-09 06:20:37: 类型“Wikimedia\Assert\ParameterAssertionException”的致命例外 [06:22:42] 10MediaWiki-History-and-Diffs, 10Chinese-Sites: Internal error (ParameterTypeException) when diff certain history on zh.wiki - https://phabricator.wikimedia.org/T222857 (10Shizhao) [06:53:30] (03PS1) 10Pboehm: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/508986 [06:53:56] (03PS1) 10Pboehm: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/508987 [07:07:26] 10CommRel-Specialists-Support (Apr-Jun-2019): Follow-up on paid translations for ASBS - https://phabricator.wikimedia.org/T222860 (10Elitre) [07:07:32] (03CR) 10Robert Vogel: [C: 03+2] Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/508987 (owner: 10Pboehm) [07:07:42] (03CR) 10Robert Vogel: [C: 03+2] Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/508986 (owner: 10Pboehm) [07:07:57] (03Merged) 10jenkins-bot: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/508987 (owner: 10Pboehm) [07:08:09] (03Merged) 10jenkins-bot: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/508986 (owner: 10Pboehm) [07:09:44] (03CR) 10jenkins-bot: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/508987 (owner: 10Pboehm) [07:12:10] (03CR) 10jenkins-bot: Header Tags for IE 11 Caching [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/508986 (owner: 10Pboehm) [07:39:17] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Create a UI for Translating captions on images (within the App Editor Tasks list) - https://phabricator.wikimedia.org/T207338 (10schoenbaechler) [07:40:27] 10Lingua Libre: Adding DEFAULTSORT on Wikimedia Commons - https://phabricator.wikimedia.org/T222816 (100x010C) In fact, the [[ https://commons.wikimedia.org/wiki/Template:Lingua_Libre_record | Template:Lingua Libre record ]] (which is used by all the files uploaded using Lingua Libre) already add the transcripti... [07:41:46] (03CR) 10Daimona Eaytoy: [C: 04-1] "Given that this is a pretty big change, IMHO we should wait, since it's not guaranteed that it'll work after the phan upgrade. My suggesti" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/462876 (https://phabricator.wikimedia.org/T203652) (owner: 10Brian Wolff) [07:46:38] (03CR) 10WMDE-leszek: "> Why didn't the new repo get added here when it was created, following the normal process?" [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [07:50:27] (03PS4) 10DmitriyShevliakov: Integration TagSearch [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/508769 [07:51:20] (03CR) 10Pwirth: [C: 03+2] Integration TagSearch [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/508769 (owner: 10DmitriyShevliakov) [07:51:51] (03Merged) 10jenkins-bot: Integration TagSearch [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/508769 (owner: 10DmitriyShevliakov) [07:56:30] (03PS1) 10Pwirth: Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508995 [07:56:40] (03CR) 10Pwirth: [C: 03+2] Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508995 (owner: 10Pwirth) [07:56:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [07:57:10] (03Merged) 10jenkins-bot: Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508995 (owner: 10Pwirth) [08:01:15] 10MediaWiki-History-and-Diffs, 10Chinese-Sites, 10Wikimedia-production-error: Internal error (ParameterTypeException) when diff certain history on zh.wiki - https://phabricator.wikimedia.org/T222857 (10Daimona) [08:02:08] 10MediaWiki-History-and-Diffs, 10Chinese-Sites, 10Wikimedia-production-error: ParameterTypeException when viewing diffs: Bad value for parameter $fragment: must be a string - https://phabricator.wikimedia.org/T222857 (10Daimona) [08:02:16] (03CR) 10DCausse: "lgtm, just a small suggestion to make this slightly more generic" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [08:03:43] 10MediaWiki-History-and-Diffs, 10Chinese-Sites, 10Wikimedia-production-error: ParameterTypeException when viewing diffs: Bad value for parameter $fragment: must be a string - https://phabricator.wikimedia.org/T222857 (10Daimona) p:05Triage→03High Seen 400 times in the last 24 hours, can't tell what the i... [08:16:42] 10MediaWiki-ResourceLoader, 10Release-Engineering-Team, 10Scap, 10Patch-For-Review, and 2 others: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) - https://phabricator.wikimedia.org/T222539 (10jeblad) Thanks to everyone! :D [08:23:13] (03CR) 10DCausse: [C: 03+2] "nice catch!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508865 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [08:33:19] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10bovender) Hi folks, if I may chime in here, it was my message to the wikitech-l mailing lis... [08:38:26] 10Readers-Web-Backlog, 10RelatedArticles: "article" icons need to be updated in Related Articles mobile view - https://phabricator.wikimedia.org/T222717 (10phuedx) [08:38:27] (03PS1) 10Pwirth: Fix missing comma. [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/509006 [08:45:04] (03CR) 10Phuedx: [C: 03+2] "Thanks!" [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/506520 (owner: 10Umherirrender) [08:45:12] (03Merged) 10jenkins-bot: Uniquely identify connections in connection pool [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508865 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [08:51:06] 10CX-analytics, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Extend CX2 translations graph to show also published translations that need review - https://phabricator.wikimedia.org/T209868 (10Amire80) I eventually decided to do this in mysql, and perhaps later move e... [08:52:34] (03PS3) 10Phuedx: Remove redundant wgQuickSurveysRequireHttps from JS startup data [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [08:55:12] (03Merged) 10jenkins-bot: Add phan [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/506520 (owner: 10Umherirrender) [08:55:55] (03CR) 10jenkins-bot: Add phan [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/506520 (owner: 10Umherirrender) [08:59:12] (03CR) 10jenkins-bot: Uniquely identify connections in connection pool [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508865 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [09:05:58] 10MediaWiki-Comment-backend, 10Anti-Harassment, 10Growth-Team, 10Notifications: Notification on invisible content in edit summary - https://phabricator.wikimedia.org/T220566 (10Scoopfinder) [09:07:41] (03CR) 10DCausse: Allow fallback methods to send search queries (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) (owner: 10DCausse) [09:15:35] 10MediaWiki-extensions-OATHAuth, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Contractor - Ready): SO878 Step 4: Bind permissions to 2FA - https://phabricator.wikimedia.org/T218215 (10Osnard) Meeting minutes from 2019-05-08: - Certain permiss... [09:17:15] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10daniel) Hi @bovender! Thank you for providing some context for this request. What you are t... [09:18:34] (03CR) 10Phuedx: [C: 03+1] "+1 because I agree in principle. I think that there's a little more follow up work that could be done here. Gimme a second." [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [09:24:58] (03CR) 10Phuedx: [C: 03+2] Remove redundant wgQuickSurveysRequireHttps from JS startup data [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [09:25:15] (03CR) 10Phuedx: [C: 03+2] "Ignore me…" [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [09:28:41] (03Merged) 10jenkins-bot: Remove redundant wgQuickSurveysRequireHttps from JS startup data [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [09:31:12] (03CR) 10jenkins-bot: Remove redundant wgQuickSurveysRequireHttps from JS startup data [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/508937 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [09:31:42] (03CR) 10Robert Vogel: [C: 03+2] Fix missing comma. [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/509006 (owner: 10Pwirth) [09:31:46] (03PS1) 10Robert Vogel: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/509020 [09:31:50] (03CR) 10Robert Vogel: [C: 03+2] Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/509020 (owner: 10Robert Vogel) [09:31:54] (03PS1) 10Robert Vogel: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/509021 [09:31:57] (03CR) 10Robert Vogel: [C: 03+2] Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/509021 (owner: 10Robert Vogel) [09:32:48] (03CR) 10Robert Vogel: [C: 03+2] Features buttons & User is not logged in [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 (owner: 10Robert Vogel) [09:32:58] (03PS1) 10Robert Vogel: Features buttons & User is not logged in [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/509022 [09:33:01] (03CR) 10Robert Vogel: [C: 03+2] Features buttons & User is not logged in [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/509022 (owner: 10Robert Vogel) [09:36:15] (03Merged) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/509006 (owner: 10Pwirth) [09:36:31] (03CR) 10DCausse: Cache QueryFixer (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [09:36:33] (03CR) 10Fomafix: [C: 04-1] Hide new brackets and divider of the edit section buttons (031 comment) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/508880 (owner: 10Fomafix) [09:37:04] (03Merged) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/509020 (owner: 10Robert Vogel) [09:37:06] (03CR) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/509006 (owner: 10Pwirth) [09:37:30] (03PS2) 10Fomafix: Hide new brackets and divider of the edit section buttons [skins/Timeless] - 10https://gerrit.wikimedia.org/r/508880 [09:37:32] (03PS1) 10Fomafix: Remove old style to hide brackets and divider of edit section buttons [skins/Timeless] - 10https://gerrit.wikimedia.org/r/509023 [09:37:48] (03CR) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31) - 10https://gerrit.wikimedia.org/r/509020 (owner: 10Robert Vogel) [09:38:23] 10MediaWiki-History-and-Diffs, 10Chinese-Sites, 10Wikimedia-production-error: ParameterTypeException when viewing diffs: Bad value for parameter $fragment: must be a string - https://phabricator.wikimedia.org/T222857 (10RazeSoldier) For my debug, when a revision comment contains `/* */`, the exception will... [09:39:49] (03Merged) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/509021 (owner: 10Robert Vogel) [09:40:37] (03Merged) 10jenkins-bot: Features buttons & User is not logged in [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 (owner: 10Robert Vogel) [09:40:39] (03Merged) 10jenkins-bot: Features buttons & User is not logged in [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/509022 (owner: 10Robert Vogel) [09:40:52] (03CR) 10jenkins-bot: Fix missing comma. [extensions/BlueSpiceCustomMenu] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/509021 (owner: 10Robert Vogel) [09:41:30] (03CR) 10jenkins-bot: Features buttons & User is not logged in [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/509022 (owner: 10Robert Vogel) [09:41:35] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Define translatable namespaces for CX - https://phabricator.wikimedia.org/T198205 (10Pginer-WMF) >>! In T198205#5169227, @santhosh wrote: > @pginer-WMF confirm. Ok so we are restricting the search to the main namespace when... [09:42:09] (03CR) 10jenkins-bot: Features buttons & User is not logged in [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 (owner: 10Robert Vogel) [09:49:11] (03CR) 10Daniel Kinzler: "> Might make sense to restore as stub calling the private method from here. (with hard deprecation iff the VE one is fixed first)." [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [09:51:22] 10MediaWiki-History-and-Diffs, 10Chinese-Sites, 10Wikimedia-production-error: ParameterTypeException when viewing diffs: Bad value for parameter $fragment: must be a string - https://phabricator.wikimedia.org/T222857 (10RazeSoldier) Linker::formatAutocomments() did not handle empty autocomment. [10:00:19] 10WMSE-Riksarkivet-TORA: Förbättra länkning Kulturnav/Digitaltmuseum - https://phabricator.wikimedia.org/T218561 (10Salgo60) I asked if we should meet in Gbg in April but no reaction [[ https://twitter.com/salgo60/status/1119921707538636800 | tweet ]] [10:01:12] (03PS4) 10D3r1ck01: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) [10:06:19] (03PS7) 10Fomafix: Use CSS instead of HTML to generate edit section buttons [core] - 10https://gerrit.wikimedia.org/r/508751 (https://phabricator.wikimedia.org/T175977) [10:07:24] (03CR) 10Awight: [C: 03+1] "This would be a good feature to cover with unit tests." (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/506148 (https://phabricator.wikimedia.org/T204010) (owner: 10Jkroll) [10:08:04] (03PS3) 10D3r1ck01: EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()` [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) [10:08:30] (03PS1) 10星耀晨曦: [DO NOT MERGE] Using debug T222857 [core] - 10https://gerrit.wikimedia.org/r/509028 [10:11:15] 10MediaWiki-API, 10Developer-Advocacy (Apr-Jun 2019), 10Documentation, 10Goal: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10Aklapper) [10:14:42] 10MediaWiki-extensions-NSFileRepo: Fix illegally reset of services outside of test environment - https://phabricator.wikimedia.org/T222868 (10Pwirth) [10:15:05] (03PS3) 10Pwirth: Remove illegally reset of services outside of test environment. T222868 [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/508808 [10:17:29] (03PS2) 10星耀晨曦: [DO NOT MERGE] Using debug T222857 [core] - 10https://gerrit.wikimedia.org/r/509028 [10:21:23] (03PS3) 10星耀晨曦: [DO NOT MERGE] Using debug T222857 [core] - 10https://gerrit.wikimedia.org/r/509028 [10:21:30] (03PS1) 10Daniel Kinzler: Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 [10:21:38] 10EasyTimeline: Year is truncated for last year in the band member timeline - https://phabricator.wikimedia.org/T222830 (10Aklapper) 05Open→03Invalid That's expected software behavior. Someone needs to increase the `right` value of the `PlotArea`. Feel free to edit the page. [10:21:57] (03CR) 10jerkins-bot: [V: 04-1] Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [10:21:59] (03CR) 10jerkins-bot: [V: 04-1] Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [10:22:01] (03CR) 10jerkins-bot: [V: 04-1] Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [10:23:20] (03CR) 10Daniel Kinzler: "recheck" [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [10:28:12] (03CR) 10Daniel Kinzler: "Fix is up, see If47a93878f87d69800e5f305404c22528dac5e94 and I9f40666a31bd4af50762c197c2ce5bf089a5e68c." [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [10:34:56] 10Phabricator: Specific existing project tag not found by Phabricator's project search - https://phabricator.wikimedia.org/T222870 (10Aklapper) [10:35:57] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Define translatable namespaces for CX - https://phabricator.wikimedia.org/T198205 (10santhosh) >>! In T198205#5169527, @Pginer-WMF wrote: >>>! In T198205#5169227, @santhosh wrote: >> @pginer-WMF confirm. > Ok so we are rest... [10:38:38] (03CR) 10jerkins-bot: [V: 04-1] Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [10:42:49] (03PS4) 10星耀晨曦: [DO NOT MERGE] Using debug T222857 [core] - 10https://gerrit.wikimedia.org/r/509028 [10:43:31] 10MediaWiki-General-or-Unknown, 10JavaScript, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Rivaldid) I'm still having issue in visualization, I get the console message of deprecation... [10:45:33] (03CR) 10VolkerE: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508950 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [10:46:54] (03CR) 10VolkerE: "@Jon Although the proposed styles are fixing all issue, the stylesheet doesn't get accepted in my personal test, being on reset-cleanup br" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508950 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [10:50:21] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Threshold to prevent publishing needs more precision - https://phabricator.wikimedia.org/T221930 (10Pginer-WMF) >>! In T221930#5169176, @Etonkovidova wrote: > Checked in `testwiki wmf.4` > > Some is... [10:51:35] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Define translatable namespaces for CX - https://phabricator.wikimedia.org/T198205 (10Pginer-WMF) Awesome, than I think the provided support is enough for the user needs. [10:52:44] 10MinervaNeue, 10Readers-Web-Backlog (Design): Watchlist illustration outdated - https://phabricator.wikimedia.org/T222871 (10Volker_E) [10:56:57] 10MinervaNeue, 10Readers-Web-Backlog (Design): Watchlist empty page doesn't have width limitation - https://phabricator.wikimedia.org/T222872 (10Volker_E) [10:57:25] (03CR) 10jerkins-bot: [V: 04-1] [DO NOT MERGE] Using debug T222857 [core] - 10https://gerrit.wikimedia.org/r/509028 (owner: 10星耀晨曦) [10:58:27] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Create a UI for Translating captions on images (within the App Editor Tasks list) - https://phabricator.wikimedia.org/T207338 (10schoenbaechler) [11:01:21] (03PS8) 10Pboehm: Enable Pasting of Text with embedded Links [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/500722 [11:01:26] 10Android-app-feature-Description-Editing, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Create a UI for Translating captions on images (within the App Editor Tasks list) - https://phabricator.wikimedia.org/T207338 (10schoenbaechler) [11:02:07] (03PS9) 10Pboehm: Enable Pasting of Text with embedded Links [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/500722 [11:04:55] (03CR) 10WMDE-leszek: Rename WikibaseSchema to EntitySchema (031 comment) [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:05:39] 10CirrusSearch, 10Discovery-Search, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: "missing replica" error messages in production logs - https://phabricator.wikimedia.org/T222819 (10Aklapper) [11:07:58] (03CR) 10Ladsgroup: Rename WikibaseSchema to EntitySchema (031 comment) [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:08:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review, and 2 others: Flaky test Wikibase\Repo SetAliasesTest::testUserCannotSetAliasesWhenTheyLackPermission [4h] - https://phabricator.wikimedia.org/T218378 (10WMDE-leszek) 05Open→03Resolved... [11:10:00] 04(no projects): Central modules need the user language to help users, admins and Lua coders in their languages - https://phabricator.wikimedia.org/T222704 (10Aklapper) @Rical: The previous comment is unreadable (you can use the "Preview" function below the comment field in the web UI). I already linked to http... [11:10:40] (03CR) 10Ladsgroup: [C: 04-1] Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:11:51] (03PS2) 10Ladsgroup: Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) [11:15:58] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Pginer-WMF) >>! In T219851#5167070, @Mimihitam wrote: > As a compromise, please set "copying the source content" as default, because the problems usually stem from new... [11:19:28] (03PS1) 10Thiemo Kreuz (WMDE): referencePreview: Replace `width: 0` with `display: none` [extensions/Popups] - 10https://gerrit.wikimedia.org/r/509038 [11:22:20] (03PS2) 10Daniel Kinzler: Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 [11:23:13] (03PS3) 10Daniel Kinzler: Restore ApiQueryUserInfo::getBlockInfo() as a stub. [core] - 10https://gerrit.wikimedia.org/r/509029 [11:25:13] (03CR) 10Daniel Kinzler: "Bill, do you have time to take over and follow up on Anomie's comments?" [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [11:29:24] 10Design, 10WMDE-Design, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: new constraint level for suggestions - https://phabricator.wikimedia.org/T204439 (10Lucas_Werkmeister_WMDE) [11:33:13] (03CR) 10VolkerE: [C: 03+2] Skip the flaking watchstar test [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508612 (https://phabricator.wikimedia.org/T222517) (owner: 10Jdlrobson) [11:35:55] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks good, but a second pair of eyes wouldn't hurt. Anomie, can you have a look?" [core] - 10https://gerrit.wikimedia.org/r/504337 (owner: 10simetrical) [11:36:49] (03PS1) 10Thiemo Kreuz (WMDE): referencePreview: No event bubbling on inner child elements [extensions/Popups] - 10https://gerrit.wikimedia.org/r/509041 (https://phabricator.wikimedia.org/T214693) [11:40:14] 10MediaWiki-Recent-changes, 10Growth-Team: RecentChanges get not actualized - https://phabricator.wikimedia.org/T222838 (10Aklapper) @Luke081515: I assume the screenshot is from https://de.wikipedia.org/wiki/Special:RecentChanges ? Which filters are set? How to get that view? Exact steps to reproduce welcome.... [11:44:01] (03CR) 10VolkerE: [C: 04-1] Extract default mediawiki-ui button styles into mixins (032 comments) [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [11:45:26] (03CR) 10VolkerE: [C: 04-1] Extract default mediawiki-ui button styles into mixins (032 comments) [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [11:48:56] (03CR) 10VolkerE: "We will have to re-introduce forms.less as identified in https://phabricator.wikimedia.org/T205341#5134218" [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494411 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [11:49:57] (03PS3) 10Jdrewniak: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) [11:50:22] (03CR) 10Jdrewniak: Extract default mediawiki.ui button styles into mixins (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [11:52:17] 10netbox, 10Patch-For-Review: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) I've updated the Server Lifecycle page, see the diff at: https://wikitech.wikimedia.org/w/index.php?title=Server_Lifecycle&type=revision&diff=1825673&oldid=1... [11:52:30] 10netbox, 10Patch-For-Review: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) [11:55:03] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+1] Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:55:05] 10Front-end-Standards-Group, 10MinervaNeue, 10Readers-Web-Backlog, 10CSS: [subtask] Remove `body` `line-height` from reset.less and ui.less - https://phabricator.wikimedia.org/T222877 (10Volker_E) [11:57:30] (03CR) 10WMDE-leszek: [C: 03+2] Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:57:34] 10netbox, 10Patch-For-Review: Netbox reports: add support for decommissioning state - https://phabricator.wikimedia.org/T222353 (10Volans) [11:59:10] (03CR) 10Ladsgroup: [V: 03+2] "(Needs manual merge similar to Ifc1e31bafee1273152a600cfb1c4a3b8f3257338, just take a look at patches against this repo)" [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [11:59:19] (03CR) 10Ladsgroup: [V: 03+2 C: 03+2] Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [12:00:07] (03CR) 10Ladsgroup: [V: 03+2 C: 03+2] "Merge conflict" [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [12:00:38] (03PS3) 10Ladsgroup: Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) [12:00:46] (03Merged) 10jenkins-bot: Skip the flaking watchstar test [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508612 (https://phabricator.wikimedia.org/T222517) (owner: 10Jdlrobson) [12:00:52] (03CR) 10VolkerE: [C: 04-1] "One more time… ;)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [12:01:04] (03CR) 10Ladsgroup: "PS3 is manual rebase only" [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [12:01:10] (03CR) 10Ladsgroup: [V: 03+2 C: 03+2] Rename WikibaseSchema to EntitySchema [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [12:03:20] 04(no projects): Template:Cite_web doesn't work in Citoid in Banjar Wikipedia - https://phabricator.wikimedia.org/T222878 (10cahyo.ramadhani) [12:04:34] (03CR) 10jenkins-bot: Skip the flaking watchstar test [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508612 (https://phabricator.wikimedia.org/T222517) (owner: 10Jdlrobson) [12:08:58] 10netbox, 10Patch-For-Review: Netbox reports: add support for decommissioning state - https://phabricator.wikimedia.org/T222353 (10Volans) 05Open→03Resolved All reports run, all seems good. [12:12:29] (03PS1) 10VolkerE: Remove unnecessary `line-height` definitions [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509045 (https://phabricator.wikimedia.org/T205341) [12:15:16] (03PS3) 10Krinkle: selenium: Asynchronous methods should be returned to browser.call() [core] - 10https://gerrit.wikimedia.org/r/508938 (https://phabricator.wikimedia.org/T220479) (owner: 10Jdlrobson) [12:15:28] (03CR) 10Krinkle: [C: 03+2] selenium: Asynchronous methods should be returned to browser.call() [core] - 10https://gerrit.wikimedia.org/r/508938 (https://phabricator.wikimedia.org/T220479) (owner: 10Jdlrobson) [12:16:46] (03CR) 10Krinkle: [C: 03+2] "(transferring from bookmark to public tag, follow-up: migrate existing alerts and dashboards, then remove old metric)" [core] - 10https://gerrit.wikimedia.org/r/486323 (owner: 10Addshore) [12:18:36] 10CX-out-of-beta, 10Language-Team (Language-2019-April-June): Update grey interlanguage links entry point popup - https://phabricator.wikimedia.org/T217827 (10santhosh) a:03santhosh [12:24:37] (03PS4) 10Jdrewniak: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) [12:31:01] (03CR) 10jerkins-bot: [V: 04-1] Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [12:31:03] (03PS2) 10Krinkle: selenium: Remove LoginPage.waitForScriptsToBeReady() method [core] - 10https://gerrit.wikimedia.org/r/508090 (https://phabricator.wikimedia.org/T220479) [12:31:14] (03CR) 10jerkins-bot: [V: 04-1] selenium: Remove LoginPage.waitForScriptsToBeReady() method [core] - 10https://gerrit.wikimedia.org/r/508090 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [12:31:23] (03CR) 10jerkins-bot: [V: 04-1] selenium: Remove LoginPage.waitForScriptsToBeReady() method [core] - 10https://gerrit.wikimedia.org/r/508090 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [12:31:50] (03CR) 10Nikhil-nk: "Please learn how to amend gerrit changesets, you don't need to create a new one every time. See https://www.mediawiki.org/wiki/Gerrit/Tuto" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/508963 (owner: 10Tombolano) [12:33:04] (03PS5) 10Alexandros Kosiaris: Serve OpenAPI specification [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [12:33:42] (03CR) 10Alexandros Kosiaris: [C: 03+1] Serve OpenAPI specification (031 comment) [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [12:33:44] (03Abandoned) 10Krinkle: selenium: Remove LoginPage.waitForScriptsToBeReady() method [core] - 10https://gerrit.wikimedia.org/r/508090 (https://phabricator.wikimedia.org/T220479) (owner: 10Krinkle) [12:34:04] (03CR) 10PipelineBot: "pipeline-dashboard: service-pipeline-test" [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [12:37:19] (03PS1) 10ItSpiderman: Fix resultsReady event triggering [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/509047 [12:39:07] (03CR) 10Krinkle: Restore ApiQueryUserInfo::getBlockInfo() as a stub. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [12:39:27] (03PS5) 10Jdrewniak: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) [12:42:47] (03Merged) 10jenkins-bot: selenium: Asynchronous methods should be returned to browser.call() [core] - 10https://gerrit.wikimedia.org/r/508938 (https://phabricator.wikimedia.org/T220479) (owner: 10Jdlrobson) [12:43:15] (03CR) 10Jdrewniak: [C: 03+2] Remove unnecessary `line-height` definitions [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509045 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [12:48:34] (03CR) 10VolkerE: [C: 04-1] "Last one…" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [12:49:27] (03CR) 10jenkins-bot: selenium: Asynchronous methods should be returned to browser.call() [core] - 10https://gerrit.wikimedia.org/r/508938 (https://phabricator.wikimedia.org/T220479) (owner: 10Jdlrobson) [12:50:09] (03PS6) 10Jdrewniak: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) [12:58:29] (03PS7) 10VolkerE: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [13:01:00] (03Merged) 10jenkins-bot: Remove unnecessary `line-height` definitions [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509045 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [13:06:24] (03CR) 10jenkins-bot: Remove unnecessary `line-height` definitions [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509045 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [13:06:55] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) For the records, I sent a heads-up announcement to `wikitech-l@` at https://lists.wikimedia.org/pipermail/wikitech-l/2019-May/092063.html and also pos... [13:07:09] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) [13:08:02] 10MinervaNeue, 10Readers-Web-Backlog, 10CSS: [subtask] Move list specific rules to 'ui.less'/'lists.less' - https://phabricator.wikimedia.org/T222881 (10Volker_E) [13:10:38] (03CR) 10DCausse: Prevent multilpe queries from running consecutively... (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [13:10:55] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Threshold to prevent publishing needs more precision - https://phabricator.wikimedia.org/T221930 (10Petar.petkovic) >>! In T221930#5169677, @Pginer-WMF wrote: > @Petar.petkovic do you think this is s... [13:11:33] (03PS7) 10DCausse: Allow fallback methods to send search queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) [13:11:35] (03PS4) 10DCausse: Add a way to configure fallback methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) [13:11:37] (03PS4) 10DCausse: Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 [13:11:39] (03PS4) 10DCausse: Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 [13:11:41] (03PS3) 10DCausse: Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 [13:11:43] (03PS3) 10DCausse: Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) [13:15:04] (03CR) 10Fomafix: "JavaScript gadgets like https://www.wikidata.org/wiki/MediaWiki:Gadget-NewSection.js must get updated after this change. To support cached" [core] - 10https://gerrit.wikimedia.org/r/508751 (https://phabricator.wikimedia.org/T175977) (owner: 10Fomafix) [13:16:27] (03CR) 10VolkerE: [C: 03+2] Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [13:16:30] (03CR) 10jerkins-bot: [V: 04-1] Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [13:16:32] (03CR) 10jerkins-bot: [V: 04-1] Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [13:17:39] (03CR) 10jerkins-bot: [V: 04-1] Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [13:20:01] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Article cannot be published without any visible sign other than console error - https://phabricator.wikimedia.org/T222882 (10Pginer-WMF) [13:20:43] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (101233thehongkonger) [13:20:59] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (101233thehongkonger) [13:21:31] 10MediaWiki-Page-editing, 10Community-Wishlist-Survey-2016, 10Tracking-Neverending: Edit conflicts (tracking) - https://phabricator.wikimedia.org/T72163 (10E_to_the_Pi_times_i) [13:21:32] (03PS4) 10DCausse: Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 [13:21:35] (03PS4) 10DCausse: Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) [13:23:03] (03PS1) 10VolkerE: Move list specific styles to lists.less [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509054 (https://phabricator.wikimedia.org/T205341) [13:25:33] (03CR) 10VolkerE: "Leaving the change to `nav ul` for a follow-up later. It's too risky now…" [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509054 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [13:26:00] (03CR) 10Fomafix: "https://www.wikidata.org/wiki/MediaWiki:Gadget-NewSection.js already generates with the old format and the new format an equal UI although" [core] - 10https://gerrit.wikimedia.org/r/508751 (https://phabricator.wikimedia.org/T175977) (owner: 10Fomafix) [13:28:20] 10MinervaNeue, 10CSS, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [subtask] Move form specific selectors to their own LESS file - https://phabricator.wikimedia.org/T217622 (10Volker_E) As mentioned on the main task, the original idea of moving the styles to a 'forms.less' was not completely wrong... [13:29:28] (03CR) 10Tombolano: "> Patch Set 1:" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/508963 (owner: 10Tombolano) [13:29:30] (03CR) 10Eevans: Serve OpenAPI specification (031 comment) [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [13:30:39] (03Merged) 10jenkins-bot: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [13:31:04] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [13:35:51] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions (for trial run purpose) at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10RazeSoldier) [13:35:58] 10Accessibility: Provide a common class for visually hiding the text - https://phabricator.wikimedia.org/T222883 (10stjn) [13:36:40] (03CR) 10jenkins-bot: Extract default mediawiki.ui button styles into mixins [core] - 10https://gerrit.wikimedia.org/r/508811 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [13:36:57] (03CR) 10Alexandros Kosiaris: Serve OpenAPI specification (031 comment) [services/kask] - 10https://gerrit.wikimedia.org/r/507397 (https://phabricator.wikimedia.org/T222227) (owner: 10Eevans) [13:39:18] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [13:42:28] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Article cannot be published without any visible sign other than console error - https://phabricator.wikimedia.org/T222882 (10Pginer-WMF) [13:42:55] (03CR) 10jerkins-bot: [V: 04-1] Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [13:47:33] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) (owner: 10DCausse) [13:47:42] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Article cannot be published without any visible sign other than console error - https://phabricator.wikimedia.org/T222882 (10Pginer-WMF) [13:48:00] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Article cannot be published without any visible sign other than console error - https://phabricator.wikimedia.org/T222882 (10Pginer-WMF) p:05Triage→03Normal [13:50:53] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Pginer-WMF) >>! In T219851#5166850, @williamsp wrote: > @Pginer-WMF : Thank you for creating a solutions for the second problem (T219851#5166329) by lowering the thresh... [13:53:01] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Prevent web crawler from indexing buttons in content - https://phabricator.wikimedia.org/T175977 (10stjn) Have you thought about accessibility implications of supplying essentially empty links to users? As long as we’re supporting Internet Explorer 11, [[ htt... [13:54:24] 10media-storage: Export replication metrics for swift container-sync - https://phabricator.wikimedia.org/T222887 (10fgiunchedi) [13:55:33] 10MediaWiki-Watchlist, 10Growth-Team, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Jonesey95) Thanks for the patch. Things are much better today, bu... [13:59:37] hi! the wikipedia-app on f-droid is pretty big, apparently because it includes libmapbox-gl.so with 4-6MB each four times for architectures x86,x86-64,arm64,arm7 [14:04:34] can this be reduced? i.e. why/how is mapbox used, is a useful wp app without it possible? and/or could the app be built with one architecture only? [14:04:34] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Paragraph alignment not working when paragraph becomes shorter - https://phabricator.wikimedia.org/T222888 (10Pginer-WMF) [14:07:58] (03PS1) 10VolkerE: Introduce 'forms.less' with styling most common UI form elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509062 (https://phabricator.wikimedia.org/T205341) [14:08:57] 10Front-end-Standards-Group, 10MinervaNeue, 10Readers-Web-Backlog, 10CSS: [subtask] Remove remaining 'reset.less - https://phabricator.wikimedia.org/T222889 (10Volker_E) [14:09:30] 10MinervaNeue, 10Readers-Web-Backlog, 10CSS: [subtask] Remove remaining 'reset.less' - https://phabricator.wikimedia.org/T222889 (10Volker_E) [14:11:34] (03PS1) 10Zoranzoki21: specialPageAliases: Order BlockList at correct place per alphabet [core] - 10https://gerrit.wikimedia.org/r/509063 [14:11:36] 10Accessibility, 10CSS: Provide a common class for visually hiding the text - https://phabricator.wikimedia.org/T222883 (10Aklapper) @stjn: Is this about MediaWiki core? Asking as there is no codebase project tag associated to this task. [14:13:50] 10Accessibility, 10CSS: Provide a common class for visually hiding the text - https://phabricator.wikimedia.org/T222883 (10stjn) Yes (is it #mediawiki-general-or-unknown that I should’ve put?). [14:14:28] 10InternetArchiveBot (v2.0): IABot job queue has been stuck for days - https://phabricator.wikimedia.org/T221971 (10Cirdan) [14:15:00] (03PS1) 10VolkerE: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) [14:16:50] 10Front-end-Standards-Group, 10MinervaNeue, 10Readers-Web-Backlog, 10CSS, 10Patch-For-Review: Split up reset.css rules to specific element selectors only where needed and remove file altogether - https://phabricator.wikimedia.org/T205341 (10Volker_E) @Jdlrobson I couldn't reproduce the button background... [14:23:00] (03CR) 10jerkins-bot: [V: 04-1] Introduce 'forms.less' with styling most common UI form elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509062 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [14:26:11] 10Accessibility, 10MediaWiki-General-or-Unknown, 10CSS: Provide a common class for visually hiding the text - https://phabricator.wikimedia.org/T222883 (10Aklapper) [14:26:38] (03PS1) 10Zoranzoki21: Updated special page name translations for Slovak language [core] - 10https://gerrit.wikimedia.org/r/509065 (https://phabricator.wikimedia.org/T222793) [14:27:51] (03PS2) 10Zoranzoki21: specialPageAliases: Order BlockList at correct place per alphabet [core] - 10https://gerrit.wikimedia.org/r/509063 [14:29:17] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:30:27] (03PS5) 10EBernhardson: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) [14:30:32] (03PS1) 10D3r1ck01: htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()` [core] - 10https://gerrit.wikimedia.org/r/509066 [14:30:59] 10CirrusSearch, 10Discovery-Search (Current work), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: "missing replica" error messages in production logs - https://phabricator.wikimedia.org/T222819 (10EBernhardson) [14:31:14] 10MinervaNeue, 10CSS, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [subtask] Move form specific selectors to their own LESS file - https://phabricator.wikimedia.org/T217622 (10Volker_E) Pls ignore above comment, I was on a page that didn't receive scrollbar and therefore moved around with scrollba... [14:34:24] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:34:44] (03PS1) 10D3r1ck01: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` [core] - 10https://gerrit.wikimedia.org/r/509067 [14:35:20] (03CR) 10Reedy: [C: 04-1] Updated special page name translations for Slovak language (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509065 (https://phabricator.wikimedia.org/T222793) (owner: 10Zoranzoki21) [14:36:16] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:36:54] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:37:29] (03PS2) 10D3r1ck01: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` [core] - 10https://gerrit.wikimedia.org/r/509067 [14:38:56] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Progress bar in the translation dashboard not representing accurately the percentage fo machine translation - https://phabricator.wikimedia.org/T222892 (10Pginer-WMF) [14:39:16] (03PS5) 10BPirkle: Add additional configuation parameters to RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/507207 (https://phabricator.wikimedia.org/T215533) [14:39:21] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Progress bar in the translation dashboard not representing accurately the percentage fo machine translation - https://phabricator.wikimedia.org/T222892 (10Pginer-WMF) p:05Triage→03Normal [14:39:52] (03PS6) 10EBernhardson: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) [14:39:53] 10MediaWiki-Internationalization, 10MediaWiki-extensions-General, 10I18n, 10Patch-For-Review, 10User-Zoranzoki21: Updated special page name translations for Slovak - https://phabricator.wikimedia.org/T222793 (10Zoranzoki21) mediawiki/core done.. Will do other extensions soon. [14:40:01] (03CR) 10Anomie: [C: 04-1] Restore ApiQueryUserInfo::getBlockInfo() as a stub. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [14:40:24] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:40:29] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Threshold to prevent publishing needs more precision - https://phabricator.wikimedia.org/T221930 (10Pginer-WMF) >>! In T221930#5169987, @Petar.petkovic wrote: > This is specific to how progress bar c... [14:41:45] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:42:32] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:43:07] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [14:43:38] (03PS1) 10D3r1ck01: SearchEngine: Followup on I623b39e7ec791a66c4cf40 [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) [14:44:17] (03CR) 10D3r1ck01: "@DCausse, I made a follow-up: Ib7c2b569959194e15." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/505269 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [14:44:39] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [14:46:03] (03PS2) 10Zoranzoki21: Updated special page name translations for Slovak language [core] - 10https://gerrit.wikimedia.org/r/509065 (https://phabricator.wikimedia.org/T222793) [14:46:08] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_Deleted_pages_are_added_to_archive_index" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [14:46:14] (03CR) 10BPirkle: Add additional configuation parameters to RESTBagOStuff (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507207 (https://phabricator.wikimedia.org/T215533) (owner: 10BPirkle) [14:46:36] (03CR) 10Zoranzoki21: Updated special page name translations for Slovak language (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509065 (https://phabricator.wikimedia.org/T222793) (owner: 10Zoranzoki21) [14:47:48] (03CR) 10DCausse: SearchEngine: Hard deprecate SearchEngine::transformSearchTerm() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/505269 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [14:52:06] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [14:52:21] (03CR) 10Raimond Spekking: [C: 03+2] specialPageAliases: Order BlockList at correct place per alphabet [core] - 10https://gerrit.wikimedia.org/r/509063 (owner: 10Zoranzoki21) [14:53:27] (03CR) 10jerkins-bot: [V: 04-1] Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [14:54:20] (03PS7) 10EBernhardson: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) [14:55:16] (03PS2) 10D3r1ck01: SearchEngine: Followup on I623b39e7ec791a66c4cf40 [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) [14:59:10] (03PS1) 10D3r1ck01: GlobalFunctions: Version for hard & soft deprecation must match [core] - 10https://gerrit.wikimedia.org/r/509069 [15:04:39] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_Deleted_pages_are_added_to_archive_index" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [15:07:21] (03Merged) 10jenkins-bot: specialPageAliases: Order BlockList at correct place per alphabet [core] - 10https://gerrit.wikimedia.org/r/509063 (owner: 10Zoranzoki21) [15:07:46] (03CR) 10jerkins-bot: [V: 04-1] Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [15:08:37] (03PS8) 10EBernhardson: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) [15:09:31] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [15:09:34] (03PS1) 10VolkerE: Remove unused 'sectionAnchor.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/509073 [15:12:46] Is there any kind of training installation of MediaWiki that is setup with dummy users, articles, categories, etc.? [15:13:51] 10Product-Analytics: Add revert rate to Suggested Edits report - https://phabricator.wikimedia.org/T222897 (10mpopov) [15:14:24] (03CR) 10jenkins-bot: specialPageAliases: Order BlockList at correct place per alphabet [core] - 10https://gerrit.wikimedia.org/r/509063 (owner: 10Zoranzoki21) [15:14:42] (03PS4) 10Umherirrender: Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [15:14:46] (03CR) 10Umherirrender: [C: 03+2] Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [15:14:56] 10Product-Analytics, 10SEO: Analyze results of sameAs A/B test - https://phabricator.wikimedia.org/T209891 (10mpopov) I am currently doing an analysis of how sameAs impacted other projects. [15:21:49] (03CR) 10Thcipriani: Rename WikibaseSchema to EntitySchema (031 comment) [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [15:22:05] (03PS1) 10D3r1ck01: page: Remove deprecated/unused `PageArchive::getTextFromRow()` [core] - 10https://gerrit.wikimedia.org/r/509077 [15:23:09] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [15:24:02] (03Abandoned) 10Aklapper: Changes in CargoMySQLsearch.php to supprt all MW versions. Added appropriate spacing and comments. Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504893 (owner: 10Ankita Mandal) [15:24:34] (03PS1) 10MIke Nicosia: message [extensions/examples] - 10https://gerrit.wikimedia.org/r/509078 [15:24:37] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/509078 (owner: 10MIke Nicosia) [15:25:11] (03CR) 10EBernhardson: [C: 03+2] Allow fallback methods to send search queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) (owner: 10DCausse) [15:26:13] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509069 (owner: 10D3r1ck01) [15:27:37] (03PS1) 10Ladsgroup: Fix I9a81b1e0ebb4c14f983d17a153183aeacc9e7858 [extensions] - 10https://gerrit.wikimedia.org/r/509079 (https://phabricator.wikimedia.org/T221946) [15:28:24] (03CR) 10Ladsgroup: [V: 03+2 C: 03+2] Fix I9a81b1e0ebb4c14f983d17a153183aeacc9e7858 [extensions] - 10https://gerrit.wikimedia.org/r/509079 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [15:29:30] (03CR) 10Aklapper: [C: 04-2] "Hi Mike. Congratulations to your patch in Wikimedia Gerrit." [extensions/examples] - 10https://gerrit.wikimedia.org/r/509078 (owner: 10MIke Nicosia) [15:31:18] (03PS1) 10MIke Nicosia: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/509081 [15:32:04] (03CR) 10DCausse: [C: 03+2] SearchEngine: Followup on I623b39e7ec791a66c4cf40 [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [15:34:02] (03CR) 10Umherirrender: "This fragments the parser cache and needs a feature flag to be disabled on (mosts) wmf wikis or it would increase the page load time for t" [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [15:34:29] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused `PageArchive::getTextFromRow()` [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [15:34:41] (03PS2) 10MIke Nicosia: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/509081 [15:37:46] (03CR) 10Ladsgroup: Rename WikibaseSchema to EntitySchema (031 comment) [extensions] - 10https://gerrit.wikimedia.org/r/508614 (https://phabricator.wikimedia.org/T221946) (owner: 10Ladsgroup) [15:39:12] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/509087 (owner: 10L10n-bot) [15:39:26] (03PS1) 10DLynch: schemaEditAttemptStep: discard loaded events when switching modes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/509088 (https://phabricator.wikimedia.org/T220697) [15:39:28] (03Merged) 10jenkins-bot: Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [15:39:51] (03PS1) 10D3r1ck01: Remove several deprecated unused methods from OutputPage & ParserOutput [core] - 10https://gerrit.wikimedia.org/r/509089 [15:40:32] (03PS4) 10Jforrester: Split API messages to a separate file [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/499292 (https://phabricator.wikimedia.org/T189982) (owner: 10Artrix) [15:40:38] (03PS1) 10VolkerE: Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 [15:41:13] (03CR) 10SBassett: "Ugh, this is breaking a lot of tests. Maybe this isn't quite as simple a hardening measure as I originally thought :/" [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [15:41:28] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) (owner: 10DCausse) [15:41:31] (03PS2) 10D3r1ck01: page: Remove deprecated/unused `PageArchive::getTextFromRow()` [core] - 10https://gerrit.wikimedia.org/r/509077 [15:41:53] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/509091 (owner: 10L10n-bot) [15:43:09] (03CR) 10SBassett: [C: 03+2] "So this should strictly stay on 2.x for now..." [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506083 (https://phabricator.wikimedia.org/T216974) (owner: 10Daimona Eaytoy) [15:45:14] (03Abandoned) 10Aklapper: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/509081 (owner: 10MIke Nicosia) [15:46:16] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10UI-Standardization, 10Growth-Team, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10matej_suchanek) [15:46:41] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10UI-Standardization, 10Growth-Team, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10matej_suchanek) [15:47:48] (03CR) 10jenkins-bot: Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [15:48:03] (03CR) 10Daimona Eaytoy: "> So this should strictly stay on 2.x for now..." [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506083 (https://phabricator.wikimedia.org/T216974) (owner: 10Daimona Eaytoy) [15:48:07] (03CR) 10DCausse: [C: 03+2] Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [15:48:09] (03PS4) 10Thiemo Kreuz (WMDE): Use addJsConfigVars instead of addInlineScript [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [15:48:14] 10MediaWiki-History-and-Diffs, 10UI-Standardization, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Evaluate collapsible form on HistoryAction (collapsed by default?) - https://phabricator.wikimedia.org/T220555 (10Volker_E) I think, @Amorymeltzer's concern is not... [15:48:26] (03CR) 10EBernhardson: [C: 03+2] Add a way to configure fallback methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) (owner: 10DCausse) [15:49:04] 10MediaWiki-Special-pages, 10UI-Standardization, 10OOUI, 10Patch-For-Review, and 2 others: OOUI in HTMLForm on Special:Pages – evaluate collapsible main forms - https://phabricator.wikimedia.org/T191868 (10Volker_E) [15:49:08] 10MediaWiki-History-and-Diffs, 10UI-Standardization, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Evaluate collapsible form on HistoryAction (collapsed by default?) - https://phabricator.wikimedia.org/T220555 (10Volker_E) 05Open→03Resolved [15:49:29] (03CR) 10EBernhardson: [C: 03+2] Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [15:49:56] (03CR) 10jerkins-bot: [V: 04-1] Use addJsConfigVars instead of addInlineScript [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [15:50:06] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team, 10Regression: Some dot-separators in recent changes and watchlist are missing surrounding whitespace - https://phabricator.wikimedia.org/T222903 (10Aklapper) [15:51:32] (03Merged) 10jenkins-bot: Allow fallback methods to send search queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) (owner: 10DCausse) [15:51:40] (03Merged) 10jenkins-bot: SearchEngine: Followup on I623b39e7ec791a66c4cf40 [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [15:53:23] 10MediaWiki-History-and-Diffs, 10UI-Standardization, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 2 others: Evaluate collapsible form on HistoryAction (collapsed by default?) - https://phabricator.wikimedia.org/T220555 (10Volker_E) [15:55:18] 10Accessibility, 10Design, 10MediaWiki-User-preferences: Accessibility settings/preferences - https://phabricator.wikimedia.org/T91201 (10Volker_E) a:05Volker_E→03None [15:56:47] (03PS1) 10MIke Nicosia: another change [extensions/examples] - 10https://gerrit.wikimedia.org/r/509096 [15:57:18] (03PS3) 10Umherirrender: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [15:57:22] (03CR) 10Umherirrender: [C: 03+2] Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [15:57:52] (03CR) 10SBassett: [C: 03+2] "Seems sane and fine as a workaround for now. Ideally we can fix phan-taint-check to better handle these edge cases in the future." [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 (owner: 10Daimona Eaytoy) [15:58:25] (03Abandoned) 10Aklapper: another change [extensions/examples] - 10https://gerrit.wikimedia.org/r/509096 (owner: 10MIke Nicosia) [15:59:23] (03CR) 10jenkins-bot: SearchEngine: Followup on I623b39e7ec791a66c4cf40 [core] - 10https://gerrit.wikimedia.org/r/509068 (https://phabricator.wikimedia.org/T221431) (owner: 10D3r1ck01) [16:00:22] (03CR) 10Daimona Eaytoy: "> Seems sane and fine as a workaround for now. Ideally we can fix" [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 (owner: 10Daimona Eaytoy) [16:00:46] (03PS2) 10Umherirrender: title: Remove misplaced documentation from TitleParser [core] - 10https://gerrit.wikimedia.org/r/508597 (owner: 10Thiemo Kreuz (WMDE)) [16:00:50] (03CR) 10Umherirrender: [C: 03+2] title: Remove misplaced documentation from TitleParser [core] - 10https://gerrit.wikimedia.org/r/508597 (owner: 10Thiemo Kreuz (WMDE)) [16:01:13] (03CR) 10Jforrester: [C: 03+2] "…" [core] - 10https://gerrit.wikimedia.org/r/503937 (owner: 10Fomafix) [16:01:15] 10MediaWiki-Parser, 10Security-Team, 10Patch-For-Review, 10User-notice: Ignore css in displaytitle when $wgRestrictDisplayTitle is enabled - https://phabricator.wikimedia.org/T221887 (10Jdforrester-WMF) > Individual WMF projects can certainly pick to enable or not enable lockdown. This is technically tru... [16:01:23] 10Accessibility, 10MediaWiki-Special-pages, 10UI-Standardization, 10OOUI, 10UI-Standardization-Kanban: Collapsible OOUI form state should be clearer exposed to screen readers - https://phabricator.wikimedia.org/T222904 (10Volker_E) [16:01:29] 10MediaWiki-Parser, 10Security-Team, 10Patch-For-Review, 10User-notice: Ignore css in displaytitle when $wgRestrictDisplayTitle is enabled - https://phabricator.wikimedia.org/T221887 (10Jdforrester-WMF) [16:01:34] (03CR) 10Jforrester: [C: 03+2] "OK, let's land this." [core] - 10https://gerrit.wikimedia.org/r/507488 (https://phabricator.wikimedia.org/T222126) (owner: 10Aftab) [16:02:14] (03Merged) 10jenkins-bot: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [16:02:21] 10MediaWiki-Special-pages, 10UI-Standardization, 10OOUI, 10Patch-For-Review, and 2 others: OOUI in HTMLForm on Special:Pages – evaluate collapsible main forms - https://phabricator.wikimedia.org/T191868 (10Volker_E) @Jdlrobson Just filed a follow-up subtask. [16:03:24] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Tgr) Phabricator comes with a wide array of tools, trying to cover everything that you would expect from a forge / communication hub / project management softwa... [16:05:35] 10MediaWiki-General-or-Unknown, 10JavaScript, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate jquery.throttle-debounce in favour of OO.ui.debounce/throttle - https://phabricator.wikimedia.org/T213426 (10Jdforrester-WMF) >>! In T213426#5169666, @Rivaldid wrote: > I'm still having issue in visua... [16:05:37] 10MediaWiki-Special-pages, 10UI-Standardization, 10Patch-For-Review, 10UI-Standardization-Kanban, 10User-Jdlrobson: OOUI in HTMLForm on Special:Pages – evaluate collapsible main forms - https://phabricator.wikimedia.org/T191868 (10Volker_E) [16:06:04] (03CR) 10jenkins-bot: Allow fallback methods to send search queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) (owner: 10DCausse) [16:06:32] (03CR) 10MIke Nicosia: "Hello, I am trying to learn to use Gerrit. I followed a tutorial I found here: https://www.tutorialspoint.com/gerrit/index.htm" [extensions/examples] - 10https://gerrit.wikimedia.org/r/509078 (owner: 10MIke Nicosia) [16:06:51] (03CR) 10Umherirrender: "I am not so familar with this replacements, so I would not merge this, but I have found two points I would change for cleaner code and bet" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01) [16:06:57] (03Abandoned) 10Krinkle: Add system message MediaWiki:Langcode [core] - 10https://gerrit.wikimedia.org/r/507328 (https://phabricator.wikimedia.org/T4085) (owner: 10Want) [16:07:30] (03CR) 10Matěj Suchánek: Fix logic in getDiffHistLinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/357206 (owner: 10Matěj Suchánek) [16:07:38] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10I18n, 10Patch-For-Review, 10Performance: Add a {{USERLANGUAGE}} magic word - https://phabricator.wikimedia.org/T4085 (10Krinkle) [16:08:05] (03PS2) 10Krinkle: Add a new {{USERLANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [16:08:47] (03CR) 10Jforrester: Fix logic in getDiffHistLinks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/357206 (owner: 10Matěj Suchánek) [16:09:24] (03CR) 10Krinkle: "I've removed an extra alias that isn't needed (also matching PAGELANGUAGE). It only exists for CONTENTLANG afaik for compatibility, not be" [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [16:09:51] (03Abandoned) 10MIke Nicosia: message [extensions/examples] - 10https://gerrit.wikimedia.org/r/509078 (owner: 10MIke Nicosia) [16:10:17] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10I18n, 10Patch-For-Review, 10Performance-Team (Radar): Add a {{USERLANGUAGE}} magic word - https://phabricator.wikimedia.org/T4085 (10Krinkle) [16:10:46] (03PS3) 10Aftab: Add another Bengali synonym for HIDDENCAT in MessagesBn.php [core] - 10https://gerrit.wikimedia.org/r/507488 (https://phabricator.wikimedia.org/T222126) [16:11:12] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 10Wikidata: Implement Lua alternative to {{int:Lang}} / wgUserLanguage - https://phabricator.wikimedia.org/T68051 (10Krinkle) [16:11:22] 10Accessibility, 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10MinervaNeue, and 2 others: Banner/CentralNotice should be child of `header` and not above it - https://phabricator.wikimedia.org/T205360 (10Volker_E) @Jseddon Small comment, without having access to Nirzar's original designs. T... [16:11:27] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10Parsing-Team, 10I18n, and 2 others: Add a {{USERLANGUAGE}} magic word - https://phabricator.wikimedia.org/T4085 (10Krinkle) 05Open→03Stalled Marking as stalled as this feature request should first be reviewed and approved by the Parsing Team and e... [16:11:37] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10Parsing-Team, 10I18n, and 2 others: Add a {{USERLANGUAGE}} magic word - https://phabricator.wikimedia.org/T4085 (10Krinkle) [16:13:01] (03Merged) 10jenkins-bot: Add a way to configure fallback methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) (owner: 10DCausse) [16:13:04] (03Merged) 10jenkins-bot: Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [16:13:06] (03Merged) 10jenkins-bot: Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [16:13:26] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Release-Engineering-Team (Kanban): Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Jdforrester-WMF) [16:13:30] (03CR) 10Krinkle: [C: 04-1] "Per https://phabricator.wikimedia.org/T209699#5042198 - not sure this is even the official source, and it's not a versioned url, which wou" [core] - 10https://gerrit.wikimedia.org/r/506856 (owner: 10Jforrester) [16:13:42] 10ContentTranslation: CX2: Restoring logic broken when article starts with empty paragraph - https://phabricator.wikimedia.org/T222905 (10Petar.petkovic) [16:14:01] (03CR) 10Krinkle: [C: 03+1] "LGTM. Will verify locally. Also, the file declaration is a bit verbose, might be possible to simplify with a wildcard or wholesale directo" [core] - 10https://gerrit.wikimedia.org/r/506855 (owner: 10Jforrester) [16:15:02] (03PS3) 10Ankita Mandal: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 [16:15:28] (03PS2) 10Krinkle: foreign-resources.yaml: Add jquery.i18n [core] - 10https://gerrit.wikimedia.org/r/506858 (owner: 10Jforrester) [16:15:35] (03CR) 10Krinkle: [C: 03+2] foreign-resources.yaml: Add jquery.i18n [core] - 10https://gerrit.wikimedia.org/r/506858 (owner: 10Jforrester) [16:17:11] (03Merged) 10jenkins-bot: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [16:17:14] 10MediaWiki-General-or-Unknown, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate then remove jquery.async module - https://phabricator.wikimedia.org/T209699 (10Krinkle) 05Stalled→03Open [16:18:06] 10ContentTranslation: CX2: Restoring logic broken when article starts with empty paragraph - https://phabricator.wikimedia.org/T222905 (10Petar.petkovic) @Pginer-WMF, the number of articles starting with an empty paragraph is not insignificant and publishing error described in T222882 will always happen when sec... [16:19:35] (03CR) 10Ankita Mandal: "Fixed the spacing in Line 131." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [16:19:53] 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2: Restoring logic broken when article starts with empty paragraph - https://phabricator.wikimedia.org/T222905 (10Pginer-WMF) p:05Triage→03High [16:21:25] 04(no projects): Score generation errors - https://phabricator.wikimedia.org/T222906 (10jayantanth) [16:22:33] 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2: Restoring logic broken when article starts with empty paragraph - https://phabricator.wikimedia.org/T222905 (10Pginer-WMF) >>! In T222905#5170600, @Petar.petkovic wrote: > @Pginer-WMF, the number of articles starting with an empty paragraph... [16:22:47] (03PS5) 10Thiemo Kreuz (WMDE): Use addJsConfigVars instead of addInlineScript [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:24:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Since there was no feedback since February, but the idea of the change is fine and the issues just styling issues, I went ahead and fixed " [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:25:20] (03Merged) 10jenkins-bot: title: Remove misplaced documentation from TitleParser [core] - 10https://gerrit.wikimedia.org/r/508597 (owner: 10Thiemo Kreuz (WMDE)) [16:25:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) 05Declined→03Open I think it's fine to have planning / "goal" tasks without clear implementation steps as long as they clearly spell out a problem to solve, which th... [16:25:26] (03Merged) 10jenkins-bot: Simplify by using ?: operator [core] - 10https://gerrit.wikimedia.org/r/503937 (owner: 10Fomafix) [16:26:05] (03CR) 10jenkins-bot: Limit the clusters archive index is written to [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508732 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [16:26:23] (03CR) 10Krinkle: [C: 03+1] Add additional configuation parameters to RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/507207 (https://phabricator.wikimedia.org/T215533) (owner: 10BPirkle) [16:26:33] (03CR) 10Krinkle: [C: 03+1] "LGTM. signing back over to Daniel." [core] - 10https://gerrit.wikimedia.org/r/507207 (https://phabricator.wikimedia.org/T215533) (owner: 10BPirkle) [16:27:14] (03PS1) 10D3r1ck01: Remove several deprecated (in 1.32) no longer used methods from core [core] - 10https://gerrit.wikimedia.org/r/509105 [16:27:35] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [16:27:37] (03CR) 10Krinkle: Use addJsConfigVars instead of addInlineScript (031 comment) [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:27:50] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509089 (owner: 10D3r1ck01) [16:28:04] (03PS5) 10Aaron Schulz: [WIP] Add a convenience method to purge file cache and CDN together [core] - 10https://gerrit.wikimedia.org/r/496695 [16:28:08] 10MediaWiki-General-or-Unknown, 10MediaWiki-Stakeholders-Group: increasing abuse of installations of Mediawiki application - https://phabricator.wikimedia.org/T222536 (10Tgr) [16:28:11] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:28:41] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Article cannot be published without any visible sign other than console error - https://phabricator.wikimedia.org/T222882 (10Petar.petkovic) Reports about this error used these articles: * Asuka Langley Soryu from en to id (T219851#5163519) * RK... [16:29:21] (03PS6) 10Aaron Schulz: [WIP] Add a convenience method to purge file cache and CDN together [core] - 10https://gerrit.wikimedia.org/r/496695 [16:30:11] (03PS1) 10Isarra: SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/509107 (https://phabricator.wikimedia.org/T214107) [16:30:21] (03PS2) 10D3r1ck01: Remove several deprecated (in 1.32) no longer used methods from core [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) [16:30:27] (03PS4) 10Umherirrender: Remove EducationProgram [extensions] - 10https://gerrit.wikimedia.org/r/495940 (https://phabricator.wikimedia.org/T214457) (owner: 10MacFan4000) [16:30:37] (03PS5) 10Umherirrender: Remove EducationProgram [extensions] - 10https://gerrit.wikimedia.org/r/495940 (https://phabricator.wikimedia.org/T214457) (owner: 10MacFan4000) [16:31:05] (03PS6) 10Umherirrender: Remove EducationProgram [extensions] - 10https://gerrit.wikimedia.org/r/495940 (https://phabricator.wikimedia.org/T214457) (owner: 10MacFan4000) [16:31:39] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10Cntlsn) @MMiller_WMF Here is my design proposal, while pageviews are not ready a mild notice icon will be shown. It will ha... [16:31:44] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] "When a patch set is commited to the submodule the rebase can stock here, I have removed the folder, rebased and readded it to get the reba" [extensions] - 10https://gerrit.wikimedia.org/r/495940 (https://phabricator.wikimedia.org/T214457) (owner: 10MacFan4000) [16:32:42] (03PS3) 10Umherirrender: Remove EditAccount [extensions] - 10https://gerrit.wikimedia.org/r/507378 (https://phabricator.wikimedia.org/T221494) (owner: 10MacFan4000) [16:32:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Use addJsConfigVars instead of addInlineScript (032 comments) [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:32:48] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Remove EditAccount [extensions] - 10https://gerrit.wikimedia.org/r/507378 (https://phabricator.wikimedia.org/T221494) (owner: 10MacFan4000) [16:33:07] (03CR) 10jerkins-bot: [V: 04-1] SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/509107 (https://phabricator.wikimedia.org/T214107) (owner: 10Isarra) [16:33:10] (03CR) 10jerkins-bot: [V: 04-1] SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/509107 (https://phabricator.wikimedia.org/T214107) (owner: 10Isarra) [16:33:51] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10Parsing-Team, 10I18n, and 2 others: Add a {{USERLANGUAGE}} magic word - https://phabricator.wikimedia.org/T4085 (10Dvorapa) > Change 507328 abandoned by Krinkle: Just an afterthought, that maybe the combination of both possibilities could be benefici... [16:35:29] (03PS6) 10Thiemo Kreuz (WMDE): Use addJsConfigVars instead of addInlineScript [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:35:44] (03CR) 10jenkins-bot: title: Remove misplaced documentation from TitleParser [core] - 10https://gerrit.wikimedia.org/r/508597 (owner: 10Thiemo Kreuz (WMDE)) [16:36:10] (03PS2) 10Umherirrender: htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()` [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [16:36:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I *believe* this is fine now. But I'm not entirely sure. Also it's basically an entirely different patch now, and I should not (self) merg" [extensions/Push] - 10https://gerrit.wikimedia.org/r/492443 (https://phabricator.wikimedia.org/T216434) (owner: 10B leelasai) [16:36:14] (03CR) 10Umherirrender: [C: 03+2] htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()` [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [16:37:29] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:37:48] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:38:17] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:40:49] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if per-request TTLs are needed - https://phabricator.wikimedia.org/T222907 (10EvanProdromou) [16:41:14] 10MediaWiki-General-or-Unknown: Integrate AbsenteeLandlord into core - https://phabricator.wikimedia.org/T173113 (10Tgr) Is there a reason core integration is a better option than bundling? (E.g. would it improve functionality somehow?) [16:41:21] (03CR) 10jenkins-bot: Simplify by using ?: operator [core] - 10https://gerrit.wikimedia.org/r/503937 (owner: 10Fomafix) [16:41:54] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:42:21] 10MediaWiki-extensions-EducationProgram, 10Cleanup, 10Patch-For-Review: Archive EducationProgram - https://phabricator.wikimedia.org/T214457 (10MacFan4000) [16:42:28] (03CR) 10Pmiazga: [V: 03+1 C: 03+2] Replace use of `MobileContext::singleton()` with MC service (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [16:42:32] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:42:38] (03CR) 10D3r1ck01: "> Patch Set 2: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [16:43:07] (03PS1) 10Fomafix: Parser: Cache value for magic variable 'directionmark' [core] - 10https://gerrit.wikimedia.org/r/509109 [16:43:15] (03Merged) 10jenkins-bot: foreign-resources.yaml: Add jquery.i18n [core] - 10https://gerrit.wikimedia.org/r/506858 (owner: 10Jforrester) [16:44:25] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [16:44:32] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10Patch-For-Review: Archive the EditAccount extension - https://phabricator.wikimedia.org/T221494 (10MacFan4000) [16:45:00] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if set-if-not-exists method is necessary for session storage - https://phabricator.wikimedia.org/T222908 (10EvanProdromou) [16:45:17] (03PS1) 10EBernhardson: Limit the clusters archive index is written to [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509110 (https://phabricator.wikimedia.org/T220625) [16:45:58] (03CR) 10jenkins-bot: Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [16:46:09] 10MediaWiki-Installer: Make the default setup more resistant to spam - https://phabricator.wikimedia.org/T59053 (10Tgr) [16:46:22] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation), 10patch-welcome: Deprecate and remove mediawiki.RegExp - https://phabricator.wikimedia.org/T218339 (10Krinkle) [16:46:27] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MediaWiki-Stakeholders-Group: Saner defaults for preventing spam - https://phabricator.wikimedia.org/T173055 (10Tgr) [16:46:30] (03PS1) 10EBernhardson: Uniquely identify connections in connection pool [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509111 (https://phabricator.wikimedia.org/T222819) [16:46:36] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation), 10patch-welcome: Deprecate and remove mediawiki.RegExp - https://phabricator.wikimedia.org/T218339 (10Krinkle) [16:46:54] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation), 10patch-welcome: Deprecate and remove mediawiki.RegExp - https://phabricator.wikimedia.org/T218339 (10Krinkle) p:05Triage→03Normal [16:49:42] (03CR) 10jenkins-bot: foreign-resources.yaml: Add jquery.i18n [core] - 10https://gerrit.wikimedia.org/r/506858 (owner: 10Jforrester) [16:50:43] 10CommRel-Design: Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10hdothiduc) @Aklapper, I added a link to create a task request with the pre-filled questions. @NSaad, I think this time I can edit the task. Some follow-up questions: Are these badges certi... [16:51:48] (03CR) 10Krinkle: [C: 03+1] "LGTM, still WIP, or good to go?" [core] - 10https://gerrit.wikimedia.org/r/496695 (owner: 10Aaron Schulz) [16:52:09] 10Security-Team-Review-Active: Security review - Wikibase Termbox Front End - https://phabricator.wikimedia.org/T216419 (10WMDE-leszek) Hi again @sbassett. Hoping this would be useful update for you, I'd like to report on some improvements and changes that have happened in the last couple of days. **Vulnerable... [16:52:10] (03PS2) 10Umherirrender: Remove type=skin from extension.json [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/506742 [16:52:13] (03CR) 10Umherirrender: [C: 03+2] Remove type=skin from extension.json [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/506742 (owner: 10Umherirrender) [16:52:39] (03Merged) 10jenkins-bot: htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()` [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [16:52:51] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Petar.petkovic) >>! In T219851#5166850, @williamsp wrote: > Beside that problem, do you already check my first problem (T219851#5163519)? No visible error or warning th... [16:53:31] 10CommRel-Design: Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10Aklapper) (Also note that the //certificate// part sounds related to {T173258}?) [16:54:17] (03CR) 10Pmiazga: "Most probably escapeWhiteSpace() was declared static as it doesn't use any of TableDiffFormatter properties. It's a helper method that all" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 (owner: 10D3r1ck01) [16:54:21] (03CR) 10Pmiazga: [C: 04-1] InlineDiffFormatter: Call `escapeWhiteSpace()` using `self::` not `$this` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 (owner: 10D3r1ck01) [16:55:07] (03CR) 10Umherirrender: Add Table Inspectors (031 comment) [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/492963 (owner: 10Pboehm) [16:55:38] (03CR) 10EBernhardson: [C: 03+2] Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [16:56:20] (03CR) 10D3r1ck01: "Okay, thanks @Thiemo & @Pmiazga. I'll revisit this again :) Moving back to WIP" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 (owner: 10D3r1ck01) [16:57:03] 10Security-Team: Onboarding James Fishback to Security Team as Privacy Engineer (April 15th) - https://phabricator.wikimedia.org/T220517 (10sbassett) [16:57:23] 10CommRel-Design, 10CommRel-Specialists-Support (Apr-Jun-2019): Design hackathon table signs - https://phabricator.wikimedia.org/T219622 (10hdothiduc) Sounds good! I will get to it tomorrow afternoon! Do you want two versions - one with a bigger photo and one with the size I have now, or is one version with a... [16:57:52] 10MobileFrontend: Cannot access user contributions/talk when following a red link to a user's page from old page version on mobile - https://phabricator.wikimedia.org/T222911 (10Cirdan) [16:58:20] (03CR) 10Jdlrobson: [C: 04-1] "Where is this necessary?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508950 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [16:59:08] (03CR) 10Jdlrobson: [C: 03+2] "Not seeing any use cases either" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/509073 (owner: 10VolkerE) [16:59:57] (03CR) 10EBernhardson: [C: 03+2] Add a new fallback method based on a simple index lookup (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [17:00:00] (03CR) 10jenkins-bot: Add a way to configure fallback methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) (owner: 10DCausse) [17:00:56] (03CR) 10Jdlrobson: [C: 04-1] "I think this is the wrong approach. The only rule we actually need is font-size. I'd rather not ship critical path CSS we don't need." [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509062 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:01:24] 10Reading-Admin: Suggest strong passwords - https://phabricator.wikimedia.org/T96781 (10Tgr) [17:01:30] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) [17:01:36] (03PS2) 10Jack Phoenix: SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/509107 (https://phabricator.wikimedia.org/T214107) (owner: 10Isarra) [17:02:46] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if set-if-not-exists method is necessary for session storage - https://phabricator.wikimedia.org/T222908 (10EvanProdromou) I'll check through our session-handling code to see if we ever use this type of cal... [17:03:23] (03Merged) 10jenkins-bot: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [17:03:31] (03Merged) 10jenkins-bot: Remove type=skin from extension.json [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/506742 (owner: 10Umherirrender) [17:03:51] (03CR) 10Jdlrobson: [C: 03+2] Move list specific styles to lists.less [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509054 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:03:57] 10netbox, 10Patch-For-Review: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) 05Open→03Resolved Earlier today I've also sent an email to the Ops list with all the details. Resolving for now, feel free to re-open if it needs any fo... [17:04:01] 10Dark-Mode: Test what Dark Mode looks like for logged-out users - https://phabricator.wikimedia.org/T222484 (10jmatazzoni) [17:04:13] (03CR) 10Jdlrobson: [C: 03+2] Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [17:04:24] (03CR) 10jenkins-bot: Make use of the PHP 7 ?? operator where it makes sense [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508619 (owner: 10Thiemo Kreuz (WMDE)) [17:04:26] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10User-D3r1ck01: [Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service - https://phabricator.wikimedia.org/T218244 (10D3r1ck01) [17:05:01] 10Dark-Mode: Engineering optimizes CSS prior to implementation - https://phabricator.wikimedia.org/T222393 (10jmatazzoni) [17:05:12] 10Discovery-Search, 10GeoData: Red error message when two #coordinates set a primary coordinate - https://phabricator.wikimedia.org/T159315 (10debt) Hey @Nemo_bis it looks like we were added to this ticket last week, and it looks like the issue is still happening. Is there a better solution for this that you'd... [17:05:41] (03CR) 10jenkins-bot: htmlform: Use `::isValidRange()` instead of deprecated `::isValidBlock()` [core] - 10https://gerrit.wikimedia.org/r/509066 (owner: 10D3r1ck01) [17:06:15] 10Discovery-Search, 10I18n: Russian characters not normalized to same form in search - https://phabricator.wikimedia.org/T222669 (10debt) @TJones this might be an interesting thing to look at! :) [17:06:20] (03CR) 10jenkins-bot: Remove type=skin from extension.json [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/506742 (owner: 10Umherirrender) [17:06:24] 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Ladsgroup) >>! In T210752#5168366, @Urbanecm wrote: > @Ladsgroup Thanks for your explanation. Shouldn't we reopen {T212881} then and/or fill a task... [17:07:45] (03CR) 10jerkins-bot: [V: 04-1] SpecialCreateCollaborationHub: Fix alignment of complex title input and totally redo entire page to work around it [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/509107 (https://phabricator.wikimedia.org/T214107) (owner: 10Isarra) [17:14:13] (03PS1) 10Jdlrobson: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) [17:15:13] (03CR) 10Jdlrobson: [C: 04-1] "I'd rather do this: https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/MinervaNeue/+/509115/ - why? Because, most of the CSS will be kept " [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509062 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:16:27] (03Merged) 10jenkins-bot: Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [17:16:29] (03PS1) 10Umherirrender: build: Add grunt-banana-checker [extensions/ContributionCredits] - 10https://gerrit.wikimedia.org/r/509117 [17:16:39] (03PS1) 10Umherirrender: build: Add grunt-banana-checker [extensions/CrawlableAllPages] - 10https://gerrit.wikimedia.org/r/509119 [17:16:59] (03PS2) 10Jdlrobson: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) [17:17:01] (03PS2) 10Jdlrobson: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:17:04] (03CR) 10Jdlrobson: [C: 03+2] Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:17:52] (03CR) 10Jdlrobson: [C: 03+2] "That's a good way to solve the problem :)" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [17:17:54] (03CR) 10jenkins-bot: Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [17:19:21] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-banana-checker [extensions/CrawlableAllPages] - 10https://gerrit.wikimedia.org/r/509119 (owner: 10Umherirrender) [17:19:34] 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review: Move config for disabling web login-success notifications to LoginNotify extension - https://phabricator.wikimedia.org/T220780 (10jmatazzoni) @Niharika can I assi... [17:21:01] 10MediaWiki-extensions-WikimediaMaintenance: Make addWiki.php modular - https://phabricator.wikimedia.org/T222913 (10Urbanecm) [17:21:57] 10MediaWiki-extensions-WikimediaMaintenance, 10Performance-Team, 10Patch-For-Review: addWiki.php broken creating ES tables - https://phabricator.wikimedia.org/T212881 (10Urbanecm) 05Resolved→03Open Per T210752#5167695. [17:22:22] 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Urbanecm) >>! In T210752#5170820, @Ladsgroup wrote: >>>! In T210752#5168366, @Urbanecm wrote: >> @Ladsgroup Thanks for your explanation. Shouldn't w... [17:22:30] 10Dark-Mode, 10Patch-For-Review: Create a 'Dark mode' beta preference - https://phabricator.wikimedia.org/T222295 (10jmatazzoni) [17:24:21] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint: Send Message to creator without needing to 'unreview'/'re-review' the article - https://phabricator.wikimedia.org/T207442 (10MBinder_WMF) @Niharika We might want to take this off the Sprint board until it's ready :) [17:24:34] (03Merged) 10jenkins-bot: Remove unused 'sectionAnchor.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/509073 (owner: 10VolkerE) [17:24:38] (03Merged) 10jenkins-bot: Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [17:24:42] (03Merged) 10jenkins-bot: Move list specific styles to lists.less [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509054 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:25:56] (03CR) 10Zfilipin: [C: 03+2] "Looks good! 🎉" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:28:27] (03PS1) 10D3r1ck01: Follow-up on Iee53988dcd46f5b20fcd33ffbfe4177cf99c6893 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/509124 (https://phabricator.wikimedia.org/T218244) [17:29:00] (03CR) 10jenkins-bot: Move list specific styles to lists.less [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509054 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:29:05] (03CR) 10jenkins-bot: Remove unused 'sectionAnchor.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/509073 (owner: 10VolkerE) [17:29:34] (03CR) 10D3r1ck01: "@Pmiazga, I think it's ready: I6682d31d12e1e446ef2d85, the follow up." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [17:31:12] (03CR) 10jerkins-bot: [V: 04-1] Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [17:32:04] (03Merged) 10jenkins-bot: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [17:34:02] (03CR) 10jenkins-bot: Prevent multiple queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [17:34:52] 10MediaWiki-Cache, 10Operations, 10serviceops, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 5 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10EvanProdromou) [17:35:05] (03CR) 10jenkins-bot: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [17:35:50] (03CR) 10jenkins-bot: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [17:35:54] (03CR) 10jerkins-bot: [V: 04-1] Follow-up on Iee53988dcd46f5b20fcd33ffbfe4177cf99c6893 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/509124 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [17:36:08] (03CR) 10Umherirrender: "No, I have no EventLogging set up" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/507649 (owner: 10Umherirrender) [17:36:16] 10MediaWiki-Cache, 10Operations, 10serviceops, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 5 others: Use a multi-dc aware store for ObjectCache's MainStash if needed. - https://phabricator.wikimedia.org/T212129 (10EvanProdromou) I moved this task so it's a direct chi... [17:37:10] (03PS2) 10D3r1ck01: Follow-up on Iee53988dcd46f5b20fcd33ffbfe4177cf99c6893 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/509124 (https://phabricator.wikimedia.org/T218244) [17:37:42] 10MediaWiki-Parser, 10Front-end-Standards-Group: Cannot access user contributions/talk when following a red link to a user's page from old page version on mobile - https://phabricator.wikimedia.org/T222911 (10Jdlrobson) @cirdan honestly I feel this is a problem with mediawiki core and red link behaviour. It se... [17:37:48] (03PS1) 10Umherirrender: Add phan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 [17:37:54] 10MediaWiki-Parser, 10Front-end-Standards-Group: Should red links to user pages link to "view" mode rather than "edit" mode? - https://phabricator.wikimedia.org/T222911 (10Jdlrobson) [17:38:02] (03CR) 10Umherirrender: "check experimental" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 (owner: 10Umherirrender) [17:38:21] (03PS3) 10BPirkle: Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [17:38:50] (03PS13) 10Julia.glen: Method1 [search/glent] - 10https://gerrit.wikimedia.org/r/507235 [17:38:52] (03CR) 10jerkins-bot: [V: 04-1] Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [17:39:17] (03CR) 10BPirkle: Fix logic in NamespaceInfo::getRestrictionLevels (033 comments) [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [17:41:59] (03Merged) 10jenkins-bot: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:42:08] 10MediaWiki-Parser, 10Front-end-Standards-Group: Should red links to user pages link to "view" mode rather than "edit" mode? - https://phabricator.wikimedia.org/T222911 (10Jdlrobson) [17:42:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Parser: Cache value for magic variable 'directionmark' (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509109 (owner: 10Fomafix) [17:43:50] 10MediaWiki-Parser, 10Front-end-Standards-Group: Should red links to user pages link to "view" mode rather than "edit" mode? - https://phabricator.wikimedia.org/T222911 (10Jdlrobson) [17:44:30] (03PS3) 10Jdlrobson: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) [17:44:33] (03CR) 10Jdlrobson: [C: 03+1] Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [17:44:37] (03PS3) 10Jdlrobson: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:45:14] 10MediaWiki-General-or-Unknown, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: mw.widgets.TitleWidget should not support interwiki links by default - https://phabricator.wikimedia.org/T222831 (10matmarex) 05Open→03Resolved a:03Esanders [17:46:24] (03PS2) 10Umherirrender: Use new SyntaxHighlight class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/507649 [17:46:42] (03CR) 10Umherirrender: "But I can look, how to set up and test" (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/507649 (owner: 10Umherirrender) [17:47:45] (03CR) 10Jdlrobson: [C: 03+1] Fix UI regressions with icons, inputs and p elements (035 comments) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [17:48:06] 10Security-Team-Review-Active: Security review - Wikibase Termbox Front End - https://phabricator.wikimedia.org/T216419 (10sbassett) @WMDE-leszek - sounds good and thanks for the update including the updated deployment timeline! I'll await the updated reports to review. And the `openapi-request-validator` leng... [17:48:17] (03CR) 10Bartosz Dziewoński: "Thank you for responding!" [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [17:48:57] (03PS2) 10Umherirrender: Add phan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 [17:49:09] (03PS3) 10Umherirrender: Add phan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 [17:49:16] (03CR) 10Jforrester: [C: 04-1] IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` (032 comments) [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [17:49:32] (03CR) 10Umherirrender: "check experimental" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 (owner: 10Umherirrender) [17:50:18] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Remove cache from ImageGateway - https://phabricator.wikimedia.org/T220558 (10Jdlrobson) p:05Normal→03High [17:50:34] 10MinervaNeue, 10CSS, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [subtask] Remove remaining 'reset.less' - https://phabricator.wikimedia.org/T222889 (10Jdlrobson) [17:50:34] (03CR) 10Jforrester: [C: 03+2] "No known uses in codesearch. Nice." [core] - 10https://gerrit.wikimedia.org/r/509089 (owner: 10D3r1ck01) [17:50:44] 10MinervaNeue, 10CSS, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [subtask] Move list specific rules to 'ui.less'/'lists.less' - https://phabricator.wikimedia.org/T222881 (10Jdlrobson) [17:51:05] 10Front-end-Standards-Group, 10MinervaNeue, 10CSS, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [subtask] Remove `body` `line-height` from reset.less and ui.less - https://phabricator.wikimedia.org/T222877 (10Jdlrobson) [17:51:12] (03PS3) 10D3r1ck01: Remove several deprecated (in 1.32) no longer used methods from core [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) [17:51:55] (03CR) 10VolkerE: "mw-ui-icon. I saw issues with the icon-only buttons moving around…" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508950 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:53:21] (03PS3) 10D3r1ck01: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` [core] - 10https://gerrit.wikimedia.org/r/509067 [17:53:51] (03CR) 10D3r1ck01: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` (032 comments) [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [17:53:59] (03CR) 10D3r1ck01: "Thank you" [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [17:54:21] (03CR) 10Jforrester: [C: 03+1] page: Remove deprecated/unused `PageArchive::getTextFromRow()` (033 comments) [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [17:55:43] (03CR) 10Jforrester: [C: 03+2] "Thank *you*. :-)" [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [17:56:05] (03CR) 10Zfilipin: WIP Test that checks for user mention alerts (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [17:56:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "It feels like this is a bit misplaced here. This is configuration, and should not contain (to much) code. I think it would be better if Ph" [tools/phan] - 10https://gerrit.wikimedia.org/r/501868 (owner: 10Umherirrender) [17:57:10] 10UniversalLanguageSelector: getFrequentLanguageList: expected behavior for 'redirected' languages - https://phabricator.wikimedia.org/T222790 (10Pablo-WMDE) @Nikerabbit Uncertain what is the correct process on getting clarification regarding ULS topics I'm taking the liberty to bring this ticket to your attenti... [17:57:56] (03CR) 10jenkins-bot: Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [17:58:12] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/509124 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [17:58:40] (03CR) 10VolkerE: [C: 04-1] Fix UI regressions with icons, inputs and p elements (035 comments) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [17:58:45] 10Core Platform Team Backlog, 10Core Platform Team (PHP7 (TEC4)), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10PHP 7.2 support, and 2 others: Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10herron) After further testing I'm seeing these messages are arriving t... [17:59:28] (03Abandoned) 10VolkerE: Introduce 'forms.less' with styling most common UI form elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509062 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [18:00:45] (03PS17) 10Jforrester: Rename CDN config variables to be generic, deprecating the old names [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) [18:00:51] (03CR) 10Jforrester: Rename CDN config variables to be generic, deprecating the old names (031 comment) [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [18:01:14] (03PS4) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:02:19] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:03:27] (03PS4) 10BPirkle: Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [18:03:31] (03CR) 10jenkins-bot: Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [18:04:03] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:04:41] (03CR) 10jerkins-bot: [V: 04-1] Remove several deprecated (in 1.32) no longer used methods from core [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:04:43] (03CR) 10jerkins-bot: [V: 04-1] Rename CDN config variables to be generic, deprecating the old names [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [18:04:47] (03CR) 10jerkins-bot: [V: 04-1] Rename CDN config variables to be generic, deprecating the old names [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [18:06:02] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [18:07:00] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:07:02] (03PS5) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:07:40] (03Abandoned) 10Jforrester: resources: Synchronise jquery.async.js with upstream's faulty whitespace [core] - 10https://gerrit.wikimedia.org/r/506857 (owner: 10Jforrester) [18:07:59] (03CR) 10Reedy: [C: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 (031 comment) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:08:05] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:08:07] 10Product-Analytics: Possible Q2 2019-20 support for SDoC - https://phabricator.wikimedia.org/T222914 (10kzimmerman) [18:08:50] (03CR) 10Anomie: Fix logic in NamespaceInfo::getRestrictionLevels (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [18:09:28] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) Google Chrome includes a password generator (and manager) these days that they prompt a user to use any time a password field with n... [18:10:37] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:10:48] (03PS2) 10Jforrester: resources: Drop jquery.async, deprecated since 1.33 [core] - 10https://gerrit.wikimedia.org/r/506856 (https://phabricator.wikimedia.org/T209699) [18:11:15] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/506856 (https://phabricator.wikimedia.org/T209699) (owner: 10Jforrester) [18:11:44] (03CR) 10Jforrester: "> Patch Set 1: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/506855 (owner: 10Jforrester) [18:12:14] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Release-Engineering-Team (Kanban): Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Jdforrester-WMF) [18:12:16] (03PS6) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:12:21] (03PS7) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (owner: 10Ankita Mandal) [18:12:36] 10ContentTranslation, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10VisualEditor (Current work): [CX2] Pressing backspace from the uneditable reference section takes user back in the tab - https://phabricator.wikimedia.org/T108013 (10Jdforrester-WMF) [18:13:12] (03CR) 10Jdlrobson: [C: 03+1] "Will fix EOL after feedback" (032 comments) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [18:13:14] (03PS8) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [18:13:31] 10Product-Analytics, 10Reading-analysis: [REQUEST] Sample of diff requests - https://phabricator.wikimedia.org/T221051 (10kzimmerman) Thanks for following up & closing this out, @ori! [18:13:36] (03CR) 10Jdlrobson: [C: 04-1] "code sniffer warnings" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508706 (owner: 10Pmiazga) [18:13:57] (03CR) 10Jdlrobson: [C: 04-1] "Please respond to Timo then feel free to ignore my -1" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508708 (owner: 10Pmiazga) [18:14:02] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [18:15:22] (03PS3) 10D3r1ck01: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 [18:15:24] (03CR) 10jerkins-bot: [V: 04-1] Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [18:15:46] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/509129 (owner: 10L10n-bot) [18:16:09] (03PS4) 10D3r1ck01: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 [18:16:14] (03PS33) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [18:16:16] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/507830 (owner: 10L10n-bot) [18:16:20] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/508344 (owner: 10L10n-bot) [18:16:26] (03Abandoned) 10Nikerabbit: Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/509091 (owner: 10L10n-bot) [18:16:34] (03CR) 10D3r1ck01: "thanks :), feedback applied" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [18:18:08] 10Testing-Initiative: Create onboarding generic engineering checklist that teams could adapt to their specific needs - https://phabricator.wikimedia.org/T112016 (10greg) 05Open→03Invalid Yup. [18:18:50] 10MediaWiki-extensions-OAuth, 10Developer-Advocacy, 10Discourse, 10VPS-Projects: Add OAuth 2.0 support to MediaWiki - https://phabricator.wikimedia.org/T125337 (10EvanProdromou) I think that T221161 is related. [18:19:33] (03Merged) 10jenkins-bot: Remove several deprecated unused methods from OutputPage & ParserOutput [core] - 10https://gerrit.wikimedia.org/r/509089 (owner: 10D3r1ck01) [18:19:41] (03Merged) 10jenkins-bot: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [18:19:53] (03CR) 10Nikerabbit: [V: 03+2] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/509129 (owner: 10L10n-bot) [18:22:28] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10cooltey) Hi @schoenbaechler > 02) Not sure if this belongs here (might has to do with T220532) but haven’t noti... [18:23:05] (03PS48) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [18:24:05] (03CR) 10VolkerE: [C: 04-1] Fix UI regressions with icons, inputs and p elements (034 comments) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [18:26:02] 10Wikipedia-Android-App-Backlog: reduce apk size - https://phabricator.wikimedia.org/T222915 (10azrdev) [18:26:13] (03CR) 10jenkins-bot: Remove several deprecated unused methods from OutputPage & ParserOutput [core] - 10https://gerrit.wikimedia.org/r/509089 (owner: 10D3r1ck01) [18:27:55] (03PS4) 10Umherirrender: Add phan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 [18:28:11] (03CR) 10Umherirrender: "check experimental" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 (owner: 10Umherirrender) [18:29:21] 10UniversalLanguageSelector: getFrequentLanguageList: expected behavior for 'redirected' languages - https://phabricator.wikimedia.org/T222790 (10Nikerabbit) It's tricky. On one hand we want to preserve the original language codes to not mess up expectations. On the other hand the current behavior is not wanted... [18:30:03] 10MobileFrontend, 10VisualEditor: Consider adding a button to let users edit the whole page in MobileFrontend - https://phabricator.wikimedia.org/T203151 (10JTannerWMF) We are going to work on this in the near future [18:31:04] 10Product-Analytics, 10Reading-analysis: I would like to get aggregated hourly pageviews data from Benin to all wikipedias on 2018-04-28 UTC - https://phabricator.wikimedia.org/T222047 (10kzimmerman) 05Open→03Declined @Zache I apologize for my delay. Due to the sensitive nature and use case of your request... [18:32:08] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [18:34:23] (03CR) 10jenkins-bot: IP: Hard deprecate `IP::isValidBlock()` in favor of `::isValidRange()` [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [18:34:59] (03PS4) 10Jforrester: Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:35:12] (03CR) 10jerkins-bot: [V: 04-1] Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:35:17] (03CR) 10jerkins-bot: [V: 04-1] Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:35:21] (03CR) 10jerkins-bot: [V: 04-1] Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:36:06] (03CR) 10Jforrester: [C: 03+2] "Most of these removals are unrelated from each other. I've re-written the RELEASE-NOTES to reflect the groupings that make sense. In futur" [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:36:37] (03CR) 10jerkins-bot: [V: 04-1] Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:36:57] (03PS5) 10Jforrester: Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:37:30] (03CR) 10Jforrester: [C: 03+2] Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:38:38] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [18:38:47] (03CR) 10D3r1ck01: "Okay perfect, thanks a lot" [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [18:39:00] (03CR) 10Jdlrobson: [C: 04-1] "needs updating now core change has landed" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [18:39:17] (03PS5) 10Umherirrender: Add phan [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 [18:39:24] (03CR) 10Umherirrender: "check experimental" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/509125 (owner: 10Umherirrender) [18:39:28] (03CR) 10Jdlrobson: [C: 03+1] "ignore... was looking at old patchset!" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [18:39:43] (03PS13) 10Jdlrobson: Adds AMC styles for action=history page [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [18:39:52] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [18:40:28] (03PS5) 10Jforrester: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [18:40:45] (03CR) 10Jforrester: [C: 03+2] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [18:41:13] (03CR) 10Jforrester: [C: 03+2] GlobalFunctions: Version for hard & soft deprecation must match [core] - 10https://gerrit.wikimedia.org/r/509069 (owner: 10D3r1ck01) [18:41:29] 10Design, 10Editing Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10JTannerWMF) The questions in this ticket will be resolved as a result of the prototype @iamjessklein is creating. [18:42:14] (03CR) 10Jdlrobson: [C: 04-1] Adds AMC styles for action=history page (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [18:42:32] 10Design, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Edit cards: re-think positioning of mobile contexts - https://phabricator.wikimedia.org/T204733 (10JTannerWMF) [18:45:09] (03PS1) 10Bmansurov: Add CTA [research/landing-page] - 10https://gerrit.wikimedia.org/r/509131 [18:45:21] (03PS3) 10Mglaser: Backport change label functionality [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/508760 [18:46:25] (03CR) 10jerkins-bot: [V: 04-1] Adds AMC styles for action=history page [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [18:47:12] (03PS5) 10BPirkle: Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [18:47:21] (03CR) 10Umherirrender: [C: 03+1] "I am not sure if that with the release notes is realy needed or accepted. Yes, it is annoyning, when not knowing when a patch set is merge" [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [18:47:54] (03CR) 10jerkins-bot: [V: 04-1] Backport change label functionality [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/508760 (owner: 10Mglaser) [18:48:12] (03PS4) 10D3r1ck01: EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()` [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) [18:48:30] (03PS2) 10Bmansurov: Add CTA [research/landing-page] - 10https://gerrit.wikimedia.org/r/509131 [18:48:49] (03CR) 10BPirkle: Fix logic in NamespaceInfo::getRestrictionLevels (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [18:48:53] (03PS3) 10Bmansurov: Add CTA [research/landing-page] - 10https://gerrit.wikimedia.org/r/509131 [18:49:32] (03CR) 10Bmansurov: [V: 03+2 C: 03+2] Add CTA [research/landing-page] - 10https://gerrit.wikimedia.org/r/509131 (owner: 10Bmansurov) [18:49:45] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if set-if-not-exists method is necessary for session storage - https://phabricator.wikimedia.org/T222908 (10Eevans) >>! In T222908#5170802, @EvanProdromou wrote: > I'll check through our session-handling co... [18:50:45] 10MobileFrontend, 10Editing Design, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10JTannerWMF) This will be resolved with T211255 [18:51:29] (03PS5) 10D3r1ck01: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) [18:51:40] 10Design, 10Editing Design, 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) [18:52:04] (03PS3) 10Umherirrender: Fix various phpstorm warnings [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/506853 (owner: 10Aaron Schulz) [18:52:06] 10MobileFrontend, 10Editing Design, 10MinervaNeue, 10VisualEditor, and 2 others: Consider changing mobile site header height (and overlay header height) from 3.35em (53.6px) to 3em (48px) - https://phabricator.wikimedia.org/T215426 (10JTannerWMF) @alexhollender are you adjusting this on read and edit mode... [18:52:07] (03CR) 10Umherirrender: [C: 03+1] Fix various phpstorm warnings [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/506853 (owner: 10Aaron Schulz) [18:52:13] 10Design, 10Editing Design, 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) [18:52:36] 10Design, 10Editing Design, 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) Edit: //Added questions raised in T204733 to this ticket's description so all open question... [18:53:29] 10Wikipedia-Android-App-Backlog: reduce apk size - https://phabricator.wikimedia.org/T222915 (10Dbrant) 05Open→03Invalid The app is configured to be built with ABI-splits, i.e. one APK per each ABI, which makes it roughly 10MB. It also builds a universal APK, which is 17MB. If F-Droid would like to distribut... [18:53:55] (03PS1) 10Fomafix: Remove brackets around new toctoggle [skins/Timeless] - 10https://gerrit.wikimedia.org/r/509133 [18:54:55] (03CR) 10Fomafix: "This change restored as Id4d42d8e71c559f1e83ac7c1ab055f62654c240e." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/392822 (owner: 10Fomafix) [18:56:03] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [18:56:48] 10MobileFrontend, 10Editing Design, 10VisualEditor: Decide on strategy for how many sub-levels to support in section editing - https://phabricator.wikimedia.org/T216162 (10JTannerWMF) There will need to be some Design and Product strategy forethought on this before implementation. [18:58:13] (03CR) 10jerkins-bot: [V: 04-1] Remove brackets around new toctoggle [skins/Timeless] - 10https://gerrit.wikimedia.org/r/509133 (owner: 10Fomafix) [19:00:40] 10Design, 10translatewiki.net: Welcome notice should use a different icon - https://phabricator.wikimedia.org/T209254 (10Nikerabbit) I guess I should do the change, as I need to upload the files to suitable location first. [19:02:17] (03CR) 10Jforrester: [C: 03+1] "Ha, tests." [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:03:42] (03CR) 10Umherirrender: Preload links via LinkBatch in WikitextContent::fillParserOutput() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [19:06:18] 10MediaWiki-extensions-Score, 10DataTypes, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: Long score overlaps with statement box and edit button - https://phabricator.wikimedia.org/T218191 (10Lokal_Profil) Dropping a note about {T67252} here which could possibly benefit from however... [19:06:20] (03PS2) 10Fomafix: Remove brackets around new toctoggle [skins/Timeless] - 10https://gerrit.wikimedia.org/r/509133 [19:07:12] (03Merged) 10jenkins-bot: Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:07:15] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:08:32] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if set-if-not-exists method is necessary for session storage - https://phabricator.wikimedia.org/T222908 (10Eevans) > This task is to check if this is needed now, or ever. I believe the answer to this is y... [19:08:35] (03PS6) 10D3r1ck01: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 [19:08:48] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:08:52] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:08:56] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:09:02] (03CR) 10D3r1ck01: "> Ha, tests." [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:09:12] (03Abandoned) 10MaxSem: WIP: add beta feature [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/508741 (https://phabricator.wikimedia.org/T222295) (owner: 10MaxSem) [19:10:19] (03CR) 10Jforrester: [C: 03+2] EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()` [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:10:21] (03PS9) 10Yaron Koren: Changes in CargoMySQLsearch.php to support all MW versions.Fix for T217529 [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [19:10:39] (03PS7) 10D3r1ck01: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 [19:10:52] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:10:56] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:11:00] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:11:44] (03Merged) 10jenkins-bot: GlobalFunctions: Version for hard & soft deprecation must match [core] - 10https://gerrit.wikimedia.org/r/509069 (owner: 10D3r1ck01) [19:12:04] 10Product-Analytics, 10VisualEditor (Current work): Instrument structured workflows and their non-stuctured counterparts in the mobile visual editor - https://phabricator.wikimedia.org/T222367 (10ppelberg) [19:12:28] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: addition to main page - https://phabricator.wikimedia.org/T222847 (10Catrope) We have three main options: - A: Put something in the "chrome" area of the page (the upside-down-L-shaped area along the top and left edge of the screen), which... [19:13:24] (03CR) 10jenkins-bot: Remove several methods, deprecated in 1.32 [core] - 10https://gerrit.wikimedia.org/r/509105 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:14:01] (03PS6) 10Jforrester: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:14:03] (03PS8) 10Jforrester: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:14:29] (03CR) 10jerkins-bot: [V: 04-1] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:14:38] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:14:44] (03CR) 10jerkins-bot: [V: 04-1] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:14:56] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:15:04] (03CR) 10jerkins-bot: [V: 04-1] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:15:08] 10wikidiff2: Update the php-wikidiff2 package - https://phabricator.wikimedia.org/T222896 (10ori) a:03WMDE-Fisch [19:15:09] (03CR) 10jerkins-bot: [V: 04-1] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:15:22] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: addition to main page - https://phabricator.wikimedia.org/T222847 (10Catrope) The "sitenotice" area mentioned in option B is where the Wiki Loves Earth banner is in this screenshot: {F28987522} The "content" area is everything below and t... [19:16:36] (03PS5) 10Jforrester: MWMessagePack: Deprecate MWMessagePack class [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [19:17:19] (03CR) 10Jforrester: [C: 04-1] "Needs hard-deprecating (in the static method, as there's nowhere else)." [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [19:17:21] (03CR) 10jerkins-bot: [V: 04-1] MWMessagePack: Deprecate MWMessagePack class [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [19:17:23] (03CR) 10jerkins-bot: [V: 04-1] MWMessagePack: Deprecate MWMessagePack class [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [19:17:46] 10MediaWiki-extensions-WikimediaMaintenance: Make addWiki.php modular - https://phabricator.wikimedia.org/T222913 (10Reedy) Who needs to use eval.php? Just comment out large blocks of the code, and re-run it... Aaron did some amount of this in https://github.com/wikimedia/mediawiki-extensions-WikimediaMaintena... [19:19:02] 10Core Platform Team (Session Management Service (CDP2)), 10Core Platform Team Backlog (Next): Determine if per-request TTLs are needed - https://phabricator.wikimedia.org/T222907 (10Eevans) FYI, I think CentralAuth needs a TTL different to that of regular sessions (IIRC, this was cited as a reason for exposin... [19:19:11] (03CR) 10jenkins-bot: GlobalFunctions: Version for hard & soft deprecation must match [core] - 10https://gerrit.wikimedia.org/r/509069 (owner: 10D3r1ck01) [19:20:29] (03PS3) 10Umherirrender: Always validate uploads over api [core] - 10https://gerrit.wikimedia.org/r/498984 (https://phabricator.wikimedia.org/T208539) [19:21:04] (03PS10) 10Yaron Koren: Fix CargoMySQLSearch to support earlier MW versions - fix for bbed4f2d590f [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [19:21:38] (03CR) 10Anomie: [C: 03+1] Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) (owner: 10simetrical) [19:22:40] 10Wikipedia-Android-App-Backlog: reduce apk size - https://phabricator.wikimedia.org/T222915 (10azrdev) Thanks for your reply! I now see https://gitlab.com/fdroid/fdroiddata/blob/46e5cce5/metadata/org.wikipedia.yml#L591 says "we disable gradle abi splits because using the universal apk is easier for us for now."... [19:22:58] (03Merged) 10jenkins-bot: EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()` [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:23:32] 10MediaWiki-extensions-WikimediaMaintenance: Make addWiki.php modular - https://phabricator.wikimedia.org/T222913 (10Urbanecm) The author of the comment I linked (@Ladsgroup) said he needed to use eval.php. [19:24:02] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10User-abi_, 10Wikimedia-production-error: ttmserver/ElasticSearchTTMServer.php: Call to a member function getAggregations() on null - https://phabricator.wikimedia.org/T219736 (10Umhe... [19:24:11] (03PS7) 10Jforrester: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:24:13] (03PS9) 10Jforrester: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:24:15] (03PS6) 10Jforrester: MWMessagePack: Deprecate MWMessagePack class [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [19:25:44] 10MediaWiki-extensions-WikimediaMaintenance: Make addWiki.php modular - https://phabricator.wikimedia.org/T222913 (10Ladsgroup) >>! In T222913#5171145, @Reedy wrote: > Who needs to use eval.php? > > Just comment out large blocks of the code, and re-run it... > > Aaron did some amount of this in https://github.... [19:26:21] (03CR) 10Yaron Koren: [C: 03+2] Fix CargoMySQLSearch to support earlier MW versions - fix for bbed4f2d590f [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [19:29:14] (03CR) 10jenkins-bot: EditPage: Remove `::safeUnicodeInput()` and `::safeUnicodeOutput()` [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [19:30:16] (03Merged) 10jenkins-bot: Fix CargoMySQLSearch to support earlier MW versions - fix for bbed4f2d590f [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [19:32:02] (03CR) 10jenkins-bot: Fix CargoMySQLSearch to support earlier MW versions - fix for bbed4f2d590f [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/504900 (https://phabricator.wikimedia.org/T217529) (owner: 10Ankita Mandal) [19:36:47] (03PS1) 10Umherirrender: Fix property filter for ApiQueryStashImageInfo::getPropertyNames [core] - 10https://gerrit.wikimedia.org/r/509137 [19:39:36] (03CR) 10Jforrester: [C: 03+2] page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [19:44:17] (03PS10) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:44:24] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:44:26] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:45:32] (03PS11) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:48:36] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:50:38] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:51:18] (03PS12) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:52:53] (03PS49) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [19:57:31] (03PS1) 10Umherirrender: Use a temp repo to handle api's imageinfo for uploadwarning or badfile [core] - 10https://gerrit.wikimedia.org/r/509139 (https://phabricator.wikimedia.org/T221812) [20:00:39] 04(no projects): Conduct guerrilla usability testing at Bay Area Wikisalon - https://phabricator.wikimedia.org/T222919 (10ppelberg) [20:02:54] 04(no projects): Conduct guerrilla usability testing at Bay Area Wikisalon - https://phabricator.wikimedia.org/T222919 (10ppelberg) [20:08:33] 10VisualEditor (Current work): An extra blank line added below when editing a paragraph - https://phabricator.wikimedia.org/T212812 (10matmarex) >>! In T212812#5165684, @matmarex wrote: > In this case the `` is intentional, from wikitext like `[[1823]]an`. But it ends up in the wrong place afte... [20:09:30] 10Security-Team: Onboarding James Fishback to Security Team as Privacy Engineer (April 15th) - https://phabricator.wikimedia.org/T220517 (10JFishback_WMF) [20:13:08] 10Security-Team: Onboarding James Fishback to Security Team as Privacy Engineer (April 15th) - https://phabricator.wikimedia.org/T220517 (10JFishback_WMF) [20:14:32] 10Property-P906: Define Libris and Tora as endpoints in Wikidata - https://phabricator.wikimedia.org/T200065 (10Salgo60) [20:14:37] 10WMSE-Riksarkivet-TORA: Define Libris XL as an endpoint in Wikidata - https://phabricator.wikimedia.org/T200067 (10Salgo60) 05Open→03Stalled LIBRIS XL activities are postponed [20:15:42] 10WMSE-Riksarkivet-TORA: Property proposal/Libris-URI - https://phabricator.wikimedia.org/T200708 (10Salgo60) [20:15:44] 10WMSE-Riksarkivet-TORA: Libris XL: is there an easy way of looking up the new identifier based on the old one - https://phabricator.wikimedia.org/T200710 (10Salgo60) 05Open→03Stalled LIBRIS XL activities are postponed [20:16:10] 10WMSE-Riksarkivet-TORA: Test Federated search Wikidata SPARQL with TORA sparql (LIBRIS) - https://phabricator.wikimedia.org/T199977 (10Salgo60) [20:16:12] 10Property-P906: Define Libris and Tora as endpoints in Wikidata - https://phabricator.wikimedia.org/T200065 (10Salgo60) 05Open→03Stalled LIBRIS XL activities are postponed [20:16:52] 10WMSE-Riksarkivet-TORA: Define Libris XL as an endpoint in Wikidata - https://phabricator.wikimedia.org/T200067 (10Salgo60) [20:16:54] 10WMSE-Riksarkivet-TORA: LIBRIS SPARQL in Wikidata - https://phabricator.wikimedia.org/T202122 (10Salgo60) 05Open→03Stalled LIBRIS XL activities are postponed [20:17:58] 10WMSE-Riksarkivet-TORA: Test Federated search Wikidata SPARQL with TORA sparql (LIBRIS) - https://phabricator.wikimedia.org/T199977 (10Salgo60) [20:18:01] 10WMSE-Riksarkivet-TORA: Test Federated search Wikidata LIBRIS XL - https://phabricator.wikimedia.org/T199998 (10Salgo60) 05Open→03Stalled LIBRIS XL activities are postponed [20:20:10] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: addition to main page - https://phabricator.wikimedia.org/T222847 (10Urbanecm) >>! In T222847#5171134, @Catrope wrote: > We have three main options: > - A: Put something in the "chrome" area of the page (the upside-down-L-shaped area along... [20:20:14] 10Uncyclomedia: Create a structured talkpage handler extension consistent with extant user talkpage expectations - https://phabricator.wikimedia.org/T220765 (10Isarra) The main feature is probably voting support. How many kinds of votes do uncyclopedians even do? Main ones that come to mind: * Tables with sepa... [20:21:43] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07): CX2: Make version 2 the only available - https://phabricator.wikimedia.org/T212646 (10Petar.petkovic) >>! In T212646#5165982, @Etonkovidova wrote: > Checking in `testwiki wmf.4` - the translation dra... [20:23:32] 10ContentTranslation, 10Language-Team (Language-2019-April-June): Progress bar in the translation dashboard not representing accurately the percentage of machine translation - https://phabricator.wikimedia.org/T222892 (10Petar.petkovic) [20:24:53] 10CirrusSearch, 10Discovery-Search, 10Wikimedia-production-error: extensions/CirrusSearch/includes/Sanity/Checker.php:369 Cannot fetch ids from index - https://phabricator.wikimedia.org/T222921 (10thcipriani) [20:26:16] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: discovery of homepage after account creation - https://phabricator.wikimedia.org/T222852 (10Catrope) [20:26:47] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: traffic from email confirmation success page - https://phabricator.wikimedia.org/T222848 (10Catrope) [20:27:13] (03PS4) 10Jdlrobson: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) [20:27:34] (03CR) 10Jdlrobson: [C: 03+1] "I think this is fine. Any other P problems is likely related to using `p` inappropriately anyhow" [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [20:28:47] (03CR) 10Daniel Kinzler: "Anomie's suggestion is nice, but purely cosmetic, and only relevant for deprecated code. If there are no strong feelings about this, I'd k" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [20:30:23] (03CR) 10Daniel Kinzler: "@Anomie All your suggestions seem cosmetic, what's the CR-1 for?" [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [20:30:33] (03CR) 10Jforrester: [C: 03+2] Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [20:30:58] (03PS5) 10VolkerE: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [20:34:35] (03PS7) 10D3r1ck01: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) [20:34:39] (03CR) 10Catrope: [C: 03+2] Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:35:49] (03CR) 10Catrope: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [20:36:07] (03PS6) 10Catrope: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:36:37] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:36:46] (03CR) 10Jforrester: [C: 03+1] MWMessagePack: Deprecate MWMessagePack class and its method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [20:38:27] (03PS8) 10D3r1ck01: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) [20:39:07] (03CR) 10D3r1ck01: "You're absolutely right, I've removed it and put in the commit message." [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [20:40:27] (03PS9) 10D3r1ck01: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) [20:41:01] 10MediaWiki-Documentation, 10TechCom-RFC (TechCom-Approved): RfC: Release notes automation - https://phabricator.wikimedia.org/T200392 (10mmodell) So how do we begin implementing this? It's a great idea and it seems like we just need to promote it? [20:47:35] 10MediaWiki-Documentation, 10TechCom-RFC (TechCom-Approved): RfC: Release notes automation - https://phabricator.wikimedia.org/T200392 (10Tgr) Does the bot exist already or would that have to be written first? [20:47:59] (03Merged) 10jenkins-bot: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [20:48:05] (03Merged) 10jenkins-bot: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [20:49:13] 10MediaWiki-History-and-Diffs: Treat diffs of first and last revisions the same - https://phabricator.wikimedia.org/T214985 (10Amorymeltzer) [20:50:41] 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: Don't offer email input in help panel when email address is already set - https://phabricator.wikimedia.org/T222846 (10Etonkovidova) Checked in betalabs - all works as exepcted.... [20:54:01] (03CR) 10jenkins-bot: Language: Remove deprecated initEncoding(), recodeForEdit() & recodeInput() [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [20:56:19] (03Merged) 10jenkins-bot: Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [20:58:36] 10Security-Team: Onboarding James Fishback to Security Team as Privacy Engineer (April 15th) - https://phabricator.wikimedia.org/T220517 (10JFishback_WMF) [20:59:18] (03CR) 10VolkerE: [C: 03+2] Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [20:59:22] (03CR) 10Catrope: [C: 03+2] ApiCoreThank: Replace deprecated Revision::* methods [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [20:59:25] (03CR) 10Catrope: [C: 03+2] Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:00:30] (03CR) 10jenkins-bot: Remove usage of deprecated Revision class in Echo [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:00:40] (03CR) 10jenkins-bot: page: Remove deprecated/unused methods in PageArchive class [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [21:03:45] (03CR) 10jerkins-bot: [V: 04-1] MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [21:05:08] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Personalized first day: allow users to complete the survey later - https://phabricator.wikimedia.org/T212021 (10MMiller_WMF) [21:05:44] (03PS3) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:07:36] (03CR) 10MGChecker: Convert PipeEscape to use extension registration (031 comment) [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/486043 (https://phabricator.wikimedia.org/T214470) (owner: 10Arasakumarars) [21:09:15] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Welcome survey: let communities administer survey questions - https://phabricator.wikimedia.org/T222924 (10MMiller_WMF) [21:09:32] (03CR) 10MGChecker: Convert PipeEscape to use extension registration (031 comment) [extensions/PipeEscape] - 10https://gerrit.wikimedia.org/r/486043 (https://phabricator.wikimedia.org/T214470) (owner: 10Arasakumarars) [21:10:17] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Welcome survey: let communities administer survey questions - https://phabricator.wikimedia.org/T222924 (10MMiller_WMF) a:05MMiller_WMF→03None [21:10:32] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10SDC General, 10Wikidata: Provide a way to curate and fetch titles (short descriptions) for media files - https://phabricator.wikimedia.org/T122381 (10Abit) I feel like SDC captions satisfies the use cases in the task description. Can we close this... [21:10:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Welcome survey: allow users to complete the survey later - https://phabricator.wikimedia.org/T212021 (10MMiller_WMF) [21:11:22] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Help panel: ping experienced editors to answer questions - https://phabricator.wikimedia.org/T211167 (10MMiller_WMF) [21:11:48] (03PS4) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:16:02] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019, 10good first bug: Homepage: help and mentorship modals should notify bad email format with error message - https://phabricator.wikimedia.org/T219372 (10Catrope) This also applies to the help panel, which shares (much of) t... [21:17:06] (03PS5) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:18:37] 10MediaWiki-Internationalization, 10Wikidata, 10I18n: Allow setting the UI to a language other than English for anonymous users - https://phabricator.wikimedia.org/T134592 (10Dvorapa) [21:24:06] (03Merged) 10jenkins-bot: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [21:24:09] (03Merged) 10jenkins-bot: ApiCoreThank: Replace deprecated Revision::* methods [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [21:24:12] (03Merged) 10jenkins-bot: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:24:41] (03PS10) 10D3r1ck01: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) [21:27:55] (03CR) 10jenkins-bot: Fix UI regressions with icons, inputs and p elements [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509115 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [21:28:23] (03CR) 10jenkins-bot: Migrate DiscussionParser::getEditExcerpt() to accept only RevisionRecord [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:28:34] (03CR) 10D3r1ck01: "> No known uses in codesearch. Nice." [core] - 10https://gerrit.wikimedia.org/r/509089 (owner: 10D3r1ck01) [21:29:00] (03CR) 10D3r1ck01: "> Thank *you*. :-)" [core] - 10https://gerrit.wikimedia.org/r/509067 (owner: 10D3r1ck01) [21:29:24] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/509069 (owner: 10D3r1ck01) [21:29:39] (03CR) 10D3r1ck01: "> Patch Set 4: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/508901 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [21:29:53] (03CR) 10D3r1ck01: "> Patch Set 7: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/507221 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [21:30:04] (03CR) 10D3r1ck01: "> Patch Set 35: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504589 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:30:18] (03CR) 10D3r1ck01: "> Patch Set 9: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/509077 (owner: 10D3r1ck01) [21:30:33] (03CR) 10D3r1ck01: "> Patch Set 6: Code-Review+2" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/504818 (owner: 10D3r1ck01) [21:30:40] (03CR) 10D3r1ck01: "> Patch Set 6: Code-Review+2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505311 (https://phabricator.wikimedia.org/T221163) (owner: 10D3r1ck01) [21:32:21] (03CR) 10jerkins-bot: [V: 04-1] Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) (owner: 10Kosta Harlan) [21:33:07] (03PS1) 10Catrope: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) [21:33:40] 10International-Developer-Events: Wikimedia Technical Conference 2019: Discussion - https://phabricator.wikimedia.org/T220212 (10Darenwelsh) For reference, the idea of a special interest group periodic meeting was mentioned in https://www.mediawiki.org/wiki/Wikimedia_Technical_Conference/2018/Session_notes/How_d... [21:35:23] 04(no projects): AutoWikiBrowser not logging in - https://phabricator.wikimedia.org/T222925 (10James_Pleasant) [21:35:24] (03PS2) 10Catrope: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) [21:35:50] (03PS2) 10Jdlrobson: Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [21:35:58] (03PS4) 10Jdlrobson: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [21:36:06] (03CR) 10jerkins-bot: [V: 04-1] Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [21:36:18] (03CR) 10Jdlrobson: [C: 03+2] Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [21:36:26] (03PS3) 10Jdlrobson: Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [21:36:36] (03CR) 10Jdlrobson: [C: 03+2] Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [21:36:51] (03PS1) 10Isarra: Convert to extension registration [extensions/LogoFunctions] - 10https://gerrit.wikimedia.org/r/509154 [21:37:16] (03CR) 10jerkins-bot: [V: 04-1] MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [21:38:32] (03CR) 10D3r1ck01: [C: 03+2] "Right!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [21:38:56] (03PS6) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:40:21] (03PS11) 10D3r1ck01: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) [21:41:51] (03CR) 10Kosta Harlan: "This change is ready for review." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) (owner: 10Kosta Harlan) [21:45:20] (03PS14) 10Julia.glen: Method1 [search/glent] - 10https://gerrit.wikimedia.org/r/507235 [21:45:41] (03CR) 10Anomie: "Overall, I like the architecture. The comments I have are mostly pretty minor." (0329 comments) [core] - 10https://gerrit.wikimedia.org/r/508972 (https://phabricator.wikimedia.org/T221177) (owner: 10Tim Starling) [21:46:10] (03PS1) 10Isarra: Move indicators up slightly [skins/Timeless] - 10https://gerrit.wikimedia.org/r/509155 [21:46:38] 10Technical Program Management: Share project page template for FY1819 Q2 with teams in Audiences - https://phabricator.wikimedia.org/T200564 (10MBinder_WMF) 05Open→03Resolved [21:46:49] 10Technical Program Management: Set expectations for planning team days during All Hands - https://phabricator.wikimedia.org/T202168 (10MBinder_WMF) 05Open→03Resolved [21:46:54] 10Technical Program Management: Set expectations for planning team days during All Hands - https://phabricator.wikimedia.org/T202168 (10MBinder_WMF) [21:46:56] 10Technical Program Management: Team days at All Hands - Editing and Growth - https://phabricator.wikimedia.org/T202170 (10MBinder_WMF) 05Open→03Resolved [21:47:18] 04(no projects): AutoWikiBrowser not logging in - https://phabricator.wikimedia.org/T222925 (10James_Pleasant) 05Open→03Resolved [21:47:20] 10MediaWiki-Search, 10Discovery-Search, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10MW-1.35-release, and 2 others: Actually (hard) deprecate SearchEngine::transformSearchTerm and remove - https://phabricator.wikimedia.org/T221431 (10D3r1ck01) [21:51:19] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint: Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10MusikAnimal) a:03MusikAnimal [21:51:49] (03PS7) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:53:42] (03CR) 10jerkins-bot: [V: 04-1] MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [21:54:25] (03PS8) 10Kosta Harlan: Introduce alphabetic pager for Special:EditWatchlist [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) [21:55:55] (03CR) 10Jforrester: "recheck; sorry for CI's gremlins" [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [21:56:00] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint: Enable page curation tools to be loaded on any page (optionally) - https://phabricator.wikimedia.org/T207485 (10MusikAnimal) a:05MusikAnimal→03None [21:57:10] (03CR) 10D3r1ck01: "> recheck; sorry for CI's gremlins" [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [21:58:03] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10SDC General, 10Wikidata: Provide a way to curate and fetch titles (short descriptions) for media files - https://phabricator.wikimedia.org/T122381 (10Tgr) 05Open→03Resolved a:03Abit Yay! (For those not familiar with SDC, see [[https://www.med... [22:00:09] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team: Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) [22:00:35] (03PS1) 10Aaron Schulz: Simplify CDN and file cache purge calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/509156 [22:00:36] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10MMiller_WMF) [22:00:38] 10Trust-and-Safety: Disable 2FA for SNN95 - https://phabricator.wikimedia.org/T219726 (10jrbs) 05Open→03Resolved a:03jrbs Apologies for slow update, this was done a few weeks ago. [22:00:41] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) [22:00:44] (03Merged) 10jenkins-bot: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [22:00:46] (03Merged) 10jenkins-bot: Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [22:00:48] (03Merged) 10jenkins-bot: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [22:00:53] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) a:03Cntlsn [22:01:07] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: use preferences for inputting email address - https://phabricator.wikimedia.org/T222926 (10MMiller_WMF) @Catrope -- please add any other information or specifications. [22:01:35] (03PS34) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [22:03:26] 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: Don't offer email input in help panel when email address is already set - https://phabricator.wikimedia.org/T222846 (10MMiller_WMF) 05Open→03Resolved @Etonkovidova -- your scr... [22:04:42] (03CR) 10Jforrester: [C: 03+1] "Eurgh, what a mess of a function. It would make more sense to have a generic "precision" argument (especially for different kinds of calen" [core] - 10https://gerrit.wikimedia.org/r/508069 (owner: 10Jack Phoenix) [22:04:47] (03CR) 10jenkins-bot: Remove emptied 'reset.less' and its skin dependency [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509064 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [22:04:55] 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: Don't offer email input in help panel when email address is already set - https://phabricator.wikimedia.org/T222846 (10MMiller_WMF) 05Resolved→03Open Actually, @Etonkovidova,... [22:05:02] (03CR) 10jenkins-bot: Fix fatal "Object of class CommentStoreComment could not be converted to string" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/509151 (https://phabricator.wikimedia.org/T221163) (owner: 10Catrope) [22:07:21] (03CR) 10jenkins-bot: Remove fixme comment on `html` `font-size` rule [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/509090 (owner: 10VolkerE) [22:12:43] (03PS6) 10D3r1ck01: logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 [22:13:33] (03CR) 10D3r1ck01: "thanks!" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01) [22:13:54] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [22:16:05] (03CR) 10Jforrester: [C: 03+1] "I think this idea. I think the expert Language Engineering team should probably check it over before merging, but certainly it gets a C+1 " [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/501820 (https://phabricator.wikimedia.org/T220247) (owner: 10Jack Phoenix) [22:18:20] (03CR) 10Jforrester: [C: 03+2] MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [22:21:04] (03CR) 10D3r1ck01: "> Patch Set 11: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [22:23:05] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [22:26:48] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: Homepage: recent questions stay archived even when revived - https://phabricator.wikimedia.org/T222124 (10Etonkovidova) @MMiller_WMF FYI Checked in betalabs - all works as expected. [22:28:35] 10New-Readers, 10Product-Analytics, 10Reading-analysis: % of content read by % of people - https://phabricator.wikimedia.org/T152437 (10kzimmerman) @atgo this is an old task that looks like it was resolved in 2017; can I close it? [22:28:48] (03PS1) 10D3r1ck01: Remove deprecated unused method `getModuleScripts()` [core] - 10https://gerrit.wikimedia.org/r/509159 (https://phabricator.wikimedia.org/T220656) [22:31:39] 10New-Readers, 10Product-Analytics, 10Reading-analysis: % of content read by % of people - https://phabricator.wikimedia.org/T152437 (10atgo) Yep! [22:31:41] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Technical-Debt (Deprecation), 10User-D3r1ck01: Is MWMessagePack unused and/or worth keeping around? - https://phabricator.wikimedia.org/T220313 (10Krinkle) [22:31:54] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Technical-Debt (Deprecation), 10User-D3r1ck01: Is MWMessagePack unused and/or worth keeping around? - https://phabricator.wikimedia.org/T220313 (10Krinkle) p:05Triage→03Normal [22:32:17] 04(no projects): Session: Introducing WikiLoop - https://phabricator.wikimedia.org/T222927 (10Xinbenlv) [22:32:44] (03CR) 10Krinkle: [C: 04-1] logging: Replace use of deprecated Linker::link() with LinkRenderer (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01) [22:33:27] (03Merged) 10jenkins-bot: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [22:34:36] (03PS1) 10D3r1ck01: User: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) [22:34:56] (03CR) 10jerkins-bot: [V: 04-1] User: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:35:00] (03PS2) 10D3r1ck01: Remove deprecated unused method `getModuleScripts()` [core] - 10https://gerrit.wikimedia.org/r/509159 (https://phabricator.wikimedia.org/T220656) [22:35:04] (03CR) 10jerkins-bot: [V: 04-1] User: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:35:08] (03CR) 10jerkins-bot: [V: 04-1] User: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:37:18] (03PS2) 10D3r1ck01: user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) [22:37:38] (03CR) 10jerkins-bot: [V: 04-1] user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:37:52] (03CR) 10jerkins-bot: [V: 04-1] user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:37:57] (03CR) 10jerkins-bot: [V: 04-1] user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [22:38:15] (03CR) 10Krinkle: Restore ApiQueryUserInfo::getBlockInfo() as a stub. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509029 (owner: 10Daniel Kinzler) [22:40:26] (03CR) 10jenkins-bot: MWMessagePack: Deprecate MWMessagePack class and its method [core] - 10https://gerrit.wikimedia.org/r/505428 (https://phabricator.wikimedia.org/T220313) (owner: 10D3r1ck01) [22:45:19] (03CR) 10Krinkle: [C: 03+2] "LGTM. From a quick scan it seems all of this is covered by the current code path already via the verifyUpload method. Nice!" [core] - 10https://gerrit.wikimedia.org/r/498984 (https://phabricator.wikimedia.org/T208539) (owner: 10Umherirrender) [22:46:49] 10MediaWiki-Uploading, 10Multimedia, 10Patch-For-Review, 10Wikimedia-production-error: Upload failed with fatal error: Call to load() on a non-object in UploadBase.php - https://phabricator.wikimedia.org/T208539 (10Krinkle) Thanks. I'm landing Umherirrender patch and will circle back to see if this rare is... [22:46:51] (03CR) 10D3r1ck01: "thanks @Krinkle, why did Jenkins even pass it?" (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 (owner: 10D3r1ck01) [22:46:57] (03PS7) 10D3r1ck01: logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 [22:49:12] (03CR) 10Krinkle: [C: 03+1] "Nice. that means we won't need a wmf-config update." [core] - 10https://gerrit.wikimedia.org/r/508489 (owner: 10Aaron Schulz) [22:49:57] (03PS2) 10Krinkle: Simplify CDN and file cache purge calls [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/509156 (owner: 10Aaron Schulz) [22:50:11] (03CR) 10Krinkle: [C: 03+1] "Adding Depends-On Ic453b189a40109a73a9426538608eea87a76befa given the array signature isn't supported yet in master." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/509156 (owner: 10Aaron Schulz) [22:50:30] 10New-Readers, 10Product-Analytics, 10Reading-analysis: % of content read by % of people - https://phabricator.wikimedia.org/T152437 (10kzimmerman) 05Open→03Resolved a:03kzimmerman [22:51:30] 10Google-Code-in-2018, 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Dcljr) >>! In T210752#5170869, @Urbanecm wrote: > > Done. Namely: {T222913} [22:53:32] 10ExtensionDistributor: Special:ExtensionDistributor displays an error - https://phabricator.wikimedia.org/T188692 (10IijimaYun) 05Resolved→03Open [22:54:00] 10ExtensionDistributor: Special:ExtensionDistributor displays an error - https://phabricator.wikimedia.org/T188692 (10IijimaYun) https://www.mediawiki.org/wiki/Special:ExtensionDistributor is broken again. [22:54:56] (03PS1) 10Reedy: Fix case mismatch [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/509163 [22:57:12] 04(no projects): Create project WTS2019 - https://phabricator.wikimedia.org/T222929 (10DanielleJWiki) [22:57:36] (03CR) 10Krinkle: Fix stale client caching of history pages with $wgShowUpdateMarker enabled (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508965 (owner: 10Aaron Schulz) [22:58:41] 04(no projects): Session: Introducing WikiLoop - https://phabricator.wikimedia.org/T222927 (10Xinbenlv) I would like to introduce our Project WikiLoop effort to Wikimedia Hackathon 2019 participants. [22:58:54] (03Merged) 10jenkins-bot: Always validate uploads over api [core] - 10https://gerrit.wikimedia.org/r/498984 (https://phabricator.wikimedia.org/T208539) (owner: 10Umherirrender) [22:58:58] 10ExtensionDistributor: Special:ExtensionDistributor displays an error - https://phabricator.wikimedia.org/T188692 (10D3r1ck01) 05Open→03Resolved Working again! [22:59:18] (03PS35) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:00:51] 10Wikimedia-Hackathon-2019: Session: Introducing WikiLoop, a Google's effort to contribute to open knowledge world - https://phabricator.wikimedia.org/T222927 (10Xinbenlv) [23:01:20] (03CR) 10EBernhardson: [C: 03+2] Uniquely identify connections in connection pool [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509111 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [23:01:22] (03CR) 10EBernhardson: [C: 03+2] Limit the clusters archive index is written to [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509110 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [23:01:32] 04(no projects): Create project Wiki goes Caribbean - https://phabricator.wikimedia.org/T222930 (10DanielleJWiki) [23:04:38] 10MediaWiki-General-or-Unknown, 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Technical-Debt (Deprecation), 10User-D3r1ck01: Is MWMessagePack unused and/or worth keeping around? - https://phabricator.wikimedia.org/T220313 (10D3r1ck01) p:05Normal→03Low This has been deprecated! @Legoktm, I'm not sure wh... [23:05:09] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509159 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:05:41] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:05:55] (03CR) 10jerkins-bot: [V: 04-1] user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:06:16] (03CR) 10jenkins-bot: Always validate uploads over api [core] - 10https://gerrit.wikimedia.org/r/498984 (https://phabricator.wikimedia.org/T208539) (owner: 10Umherirrender) [23:06:29] (03CR) 10Reedy: user: Remove deprecated and unused `getPasswordValidity()` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:08:19] (03PS1) 10Vedmaka Wakalaka: Support for PermissionManager [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/509165 [23:08:50] (03PS36) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:10:27] (03PS7) 10Aaron Schulz: Add small HtmlCacheUpdater service class to normalize purging code [core] - 10https://gerrit.wikimedia.org/r/496695 [23:10:45] (03PS3) 10D3r1ck01: user: Remove deprecated and unused `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) [23:11:41] (03CR) 10D3r1ck01: user: Remove deprecated and unused `getPasswordValidity()` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:13:28] (03PS1) 10Aaron Schulz: Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams() [core] - 10https://gerrit.wikimedia.org/r/509167 [23:13:53] (03PS4) 10D3r1ck01: user: Remove deprecated and unused method `getPasswordValidity()` [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) [23:14:16] (03PS37) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:17:28] (03CR) 10Krinkle: [C: 03+2] Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams() [core] - 10https://gerrit.wikimedia.org/r/509167 (owner: 10Aaron Schulz) [23:18:42] (03CR) 10jerkins-bot: [V: 04-1] Support for PermissionManager [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/509165 (owner: 10Vedmaka Wakalaka) [23:21:06] (03CR) 10Krinkle: [C: 03+2] Fix various phpstorm warnings [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/506853 (owner: 10Aaron Schulz) [23:23:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Performance-Team (Radar): Drastically reduce the number of ResourceLoader modules that WikibaseClient registers - https://phabricator.wikimedia.org/T203696 (10Krinkle) [23:27:55] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/509160 (https://phabricator.wikimedia.org/T220656) (owner: 10D3r1ck01) [23:30:07] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [23:30:45] (03Merged) 10jenkins-bot: Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams() [core] - 10https://gerrit.wikimedia.org/r/509167 (owner: 10Aaron Schulz) [23:30:47] (03Merged) 10jenkins-bot: Fix various phpstorm warnings [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/506853 (owner: 10Aaron Schulz) [23:31:46] wikimedia/mediawiki#24198 (master - fc0c162 jenkins-bot): The build has errored. - https://travis-ci.org/wikimedia/mediawiki/builds/530512046 [23:32:07] (03Merged) 10jenkins-bot: Uniquely identify connections in connection pool [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509111 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [23:32:55] (03Merged) 10jenkins-bot: Limit the clusters archive index is written to [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509110 (https://phabricator.wikimedia.org/T220625) (owner: 10EBernhardson) [23:34:06] (03PS38) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:35:42] (03CR) 10Krinkle: "Reviewed about half of the commit, will try to finish tomorrow. A few comments about documentation needs." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [23:37:45] (03CR) 10jenkins-bot: Remove unused EventRelayer code from ObjectCache::newWANCacheFromParams() [core] - 10https://gerrit.wikimedia.org/r/509167 (owner: 10Aaron Schulz) [23:38:42] (03CR) 10jenkins-bot: Fix various phpstorm warnings [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/506853 (owner: 10Aaron Schulz) [23:41:25] (03CR) 10Krinkle: "Also in light of T161647, we should consider a string format that doesn't rely on serialize(). This is is currently only for the Serialize" [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [23:42:11] (03CR) 10Krinkle: "Maybe we could require the caller to provide a string, and lift it to their responsibility. E.g. chunking would support string values only" [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [23:44:36] 10MediaWiki-Releasing, 10MW-1.33-release, 10Release-Engineering-Team (Kanban): Branch REL1_33 for MediaWiki and deployed extensions - https://phabricator.wikimedia.org/T220653 (10greg) p:05Triage→03High [23:46:40] (03CR) 10jenkins-bot: Uniquely identify connections in connection pool [extensions/CirrusSearch] (wmf/1.34.0-wmf.4) - 10https://gerrit.wikimedia.org/r/509111 (https://phabricator.wikimedia.org/T222819) (owner: 10EBernhardson) [23:49:20] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [23:51:46] 10MediaWiki-Database, 10MediaWiki-extensions-PageAssessments, 10Discovery-Search, 10GeoData, and 5 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10Krinkle) >>! In T221577#5163318, @aaron wrot... [23:55:04] 10CirrusSearch, 10Discovery-Search (Current work), 10MW-1.34-notes (1.34.0-wmf.5; 2019-05-14), 10Patch-For-Review: "missing replica" error messages in production logs - https://phabricator.wikimedia.org/T222819 (10EBernhardson) Fix was deployed at 16:47, saw a few `Missing replica , have <>` log mes... [23:57:00] (03PS1) 10Brennen Bearnes: Remove dev- prefix on images, tidy README & WMF key [releng/dev-images] - 10https://gerrit.wikimedia.org/r/509171