[00:05:33] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10jeblad) As I wrote as clarification, this also happen on enwiki, i follows the user langu... [00:46:59] 10MinervaNeue, 10Wikimedia-production-error (Shared Build Failure): Flaky failure related to skin Minerva selenium tests - https://phabricator.wikimedia.org/T222517 (10Jdlrobson) The token error is also happening in T221860.. it seems related to the number of tests and can only replicate in quibble so any help... [01:10:44] (03CR) 10Tim Starling: "Is there a related bug in Parsoid? It looks expensive." (031 comment) [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 (owner: 10C. Scott Ananian) [01:43:06] 10MobileFrontend: Special:MobileDiff compares the wrong revisions when clicking a multi-revision diff link - https://phabricator.wikimedia.org/T222562 (10Dinoguy1000) [01:45:22] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Wikimedia-production-error: ParameterAssertionException on page creation: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Julia) Comment: This problem does not affect all pages where the lowercase exists. F... [01:47:06] 10MobileFrontend: Special:MobileDiff compares the wrong revisions when clicking a multi-revision diff link - https://phabricator.wikimedia.org/T222562 (10Dinoguy1000) Just to confirm, this also happens on Wikipedia. Compare https://en.wikipedia.org/w/index.php?title=Pilot_Mound_Township,_Fillmore_County,_Minneso... [01:48:15] 10MobileFrontend: Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions - https://phabricator.wikimedia.org/T222562 (10Dinoguy1000) [02:15:10] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInsertTemplate] - 10https://gerrit.wikimedia.org/r/508151 [02:19:07] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/508152 [02:21:33] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceMultiUpload] - 10https://gerrit.wikimedia.org/r/508153 [02:29:45] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceNamespaceCSS] - 10https://gerrit.wikimedia.org/r/508154 [02:29:51] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508155 [02:30:38] (03CR) 10jerkins-bot: [V: 04-1] Upped version and requirements [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508155 (owner: 10Pwirth) [02:31:26] 10MediaWiki-Internationalization, 10UniversalLanguageSelector: "Other languages" section in side bar is empty on Special:RecentChanges of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10cahyo.ramadhani) I have started [[ https://min.wikipedia.org/wiki/Rundiang_MediaWiki:Recentchangestext |... [02:35:39] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePageAccess] - 10https://gerrit.wikimedia.org/r/508156 [02:35:42] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/508157 [02:36:03] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/508158 [02:36:16] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/508159 [02:37:06] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) Yeah, OK, putting the caching methods in the handler makes more sense, fair points on that. The antipattern I'd li... [02:41:15] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/508160 [02:55:22] (03PS1) 10Pwirth: Remove usage of deprecated global $wgContLang [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508161 [02:55:31] (03PS2) 10Pwirth: Remove usage of deprecated global $wgContLang [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508161 [02:56:47] (03PS2) 10Pwirth: Upped version and requirements [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508155 [02:58:12] (03CR) 10jerkins-bot: [V: 04-1] Remove usage of deprecated global $wgContLang [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508161 (owner: 10Pwirth) [03:06:36] 10Gadgets: Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Epine) [03:10:20] (03PS3) 10Pwirth: Remove usage of deprecated global $wgContLang [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/508161 [03:16:10] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 [03:16:12] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceQrCode] - 10https://gerrit.wikimedia.org/r/508163 [03:16:59] (03CR) 10jerkins-bot: [V: 04-1] Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 (owner: 10Pwirth) [03:37:15] 10Wikimedia-General-or-Unknown: Evaluate Riot as recommended IRC client - https://phabricator.wikimedia.org/T222458 (10Tgr) [04:30:44] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/508166 [05:10:37] (03CR) 10Pwirth: [C: 04-1] "You will need to merge the registered hooks, callbacks, configs etc. from the BlueSpiceTagSearch/extension.json into ./extension.json" (033 comments) [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/508120 (owner: 10DmitriyShevliakov) [05:13:48] (03CR) 10Pwirth: [C: 04-1] "This feature is planned for 3.1 so please use either the master or REL1_31_dev branch for the code review. Also please mark it in the des" [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/508120 (owner: 10DmitriyShevliakov) [05:26:46] 10MediaWiki-API, 10DBA, 10Patch-For-Review: Slow query "ApiQueryLogEvents::execute" after actor rollout - https://phabricator.wikimedia.org/T220999 (10Marostegui) a:03Anomie Closing this as resolved as this patch fixed it (same as T221511#5153193). There are also no more reports on Tendril [05:26:51] 10MediaWiki-API, 10DBA, 10Patch-For-Review: Slow query "ApiQueryLogEvents::execute" after actor rollout - https://phabricator.wikimedia.org/T220999 (10Marostegui) 05Open→03Resolved [05:26:55] 10MediaWiki-API, 10Pywikibot, 10Wikidata, 10Patch-For-Review, and 3 others: Travis test fails for wikidata:wikidata site - https://phabricator.wikimedia.org/T221543 (10Marostegui) [06:02:16] 10MediaWiki-extensions-Translate: Add support for fuzzy renames to Special:ManageMessageGroups - https://phabricator.wikimedia.org/T222566 (10abi_) [06:02:55] 10MediaWiki-extensions-Translate, 10User-abi_: Support renames in Special:ManageMessageGroups - https://phabricator.wikimedia.org/T196601 (10abi_) [06:02:57] 10MediaWiki-extensions-Translate: Add support for fuzzy renames to Special:ManageMessageGroups - https://phabricator.wikimedia.org/T222566 (10abi_) [06:03:11] 10MediaWiki-extensions-Translate, 10User-abi_: Add support for fuzzy renames to Special:ManageMessageGroups - https://phabricator.wikimedia.org/T222566 (10abi_) [06:18:14] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Performance-Team (Radar): Drastically reduce the number of ResourceLoader modules that CX creates - https://phabricator.wikimedia.org/T203695 (10santhosh) As of today we have 106 RL modules. So as part of this ticket we reduced 25 RL modules... [06:20:03] 10MediaWiki-Cache, 10DBA, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) I have reserved a window for Tuesday 14th of May to change the second parsercache ke... [06:26:59] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Wikimedia-production-error: ParameterAssertionException on page creation: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Mofvanes) It seems to only affect pages where there used to be an uppercase version,... [06:27:26] (03PS1) 10Pwirth: Remove usage of deprecated $wgParser [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508171 [06:27:47] (03PS2) 10Pwirth: Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 [06:27:59] (03CR) 10jerkins-bot: [V: 04-1] Remove usage of deprecated $wgParser [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508171 (owner: 10Pwirth) [06:28:28] (03CR) 10jerkins-bot: [V: 04-1] Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 (owner: 10Pwirth) [06:29:13] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Dvorapa) For me, today it seemed to be the mix of those two un... [06:29:15] (03PS2) 10Pwirth: Remove usage of deprecated $wgParser [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508171 [06:29:26] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 (owner: 10Pwirth) [06:29:56] (03CR) 10jerkins-bot: [V: 04-1] Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 (owner: 10Pwirth) [06:31:49] (03PS3) 10Pwirth: Upped version and requirements [extensions/BlueSpiceRSSFeeder] - 10https://gerrit.wikimedia.org/r/508162 [06:46:35] 10Security-Team-Review-Active, 10Wikimedia-Planet: Do a security audit of *.planet.wikimedia.org - https://phabricator.wikimedia.org/T207246 (10Bawolff) I think the main things we want to check: * Are things properly escaped, especially for any custom skin files * Is the allowed list of tags sane ** What are... [06:52:21] 10MediaWiki-extensions-Translate, 10User-abi_: Support renames in Special:ManageMessageGroups - https://phabricator.wikimedia.org/T196601 (10abi_) Hi @Pginer-WMF Need your inputs on this task. To summarize what we are doing here, We use the Special:ManageMessageGroups page to merge incoming message changes... [06:53:19] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team: Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Nikerabbit) It's not translatewiki.ne... [06:57:56] 10MediaWiki-extensions-Translate, 10User-abi_: Support renames in Special:ManageMessageGroups - https://phabricator.wikimedia.org/T196601 (10abi_) We've reduced the scope of this task and broken out //Adding support for fuzzy renames// to {T222566} [06:58:52] (03PS1) 10Duncancrane: Added additional information to composer.json [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508179 [07:01:07] (03CR) 10Duncancrane: "I've added some information to composer.json about the extension and its authors. Would be v. grateful if you might review for me. Many t" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508179 (owner: 10Duncancrane) [07:05:48] 04(no projects): Setup and document process for large key renames - https://phabricator.wikimedia.org/T222577 (10abi_) [07:06:45] (03PS5) 10simetrical: MovePage methods need to run safety checks [core] - 10https://gerrit.wikimedia.org/r/504336 [07:07:29] (03PS5) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [07:08:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/508181 (owner: 10L10n-bot) [07:09:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/508183 (owner: 10L10n-bot) [07:09:48] (03PS6) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [07:10:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/508185 (owner: 10L10n-bot) [07:11:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/508186 (owner: 10L10n-bot) [07:12:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/508187 (owner: 10L10n-bot) [07:12:23] (03PS5) 10simetrical: Don't pass Config to Parser(Factory) [core] - 10https://gerrit.wikimedia.org/r/503283 [07:13:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/508191 (owner: 10L10n-bot) [07:14:20] 10SiteMatrix: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category/te - https://phabricator.wikimedia.org/T222578 (10Arjunaraoc) [07:14:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/508193 (owner: 10L10n-bot) [07:15:18] 10SiteMatrix: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category/te - https://phabricator.wikimedia.org/T222578 (10Arjunaraoc) [07:15:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/508194 (owner: 10L10n-bot) [07:16:15] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Performance-Team (Radar): Drastically reduce the number of ResourceLoader modules that CX creates - https://phabricator.wikimedia.org/T203695 (10Nikerabbit) > CX1 code will be removed by end of this year More likely by end of the next year,... [07:16:18] 10Wikimedia-Site-requests: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category/te - https://phabricator.wikimedia.org/T222578 (10Arjunaraoc) [07:17:15] 10Wikimedia-Site-requests: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category/te - https://phabricator.wikimedia.org/T222578 (10Arjunaraoc) As Telugu language uses more bytes per character, may be an increase in site limit would help. [07:17:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/508192 (owner: 10L10n-bot) [07:17:43] 10Wikimedia-Site-requests: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category - https://phabricator.wikimedia.org/T222578 (10Arjunaraoc) [07:19:32] (03CR) 10simetrical: "I'll break that part into a separate change so it doesn't have to block landing, then." [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [07:20:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Comments] - 10https://gerrit.wikimedia.org/r/508202 (owner: 10L10n-bot) [07:21:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/508201 (owner: 10L10n-bot) [07:22:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/508203 (owner: 10L10n-bot) [07:24:25] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10I18n, 10Performance: Add a {{USERLANGUAGE}}/{{USERLANG}} magic word - https://phabricator.wikimedia.org/T4085 (10Dvorapa) [07:24:33] 10MediaWiki-extensions-Scribunto, 10Commons, 10I18n: Implement Lua alternative to {{int:Lang}} / wgUserLanguage - https://phabricator.wikimedia.org/T173207 (10Dvorapa) [07:24:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DeletePagesForGood] - 10https://gerrit.wikimedia.org/r/508206 (owner: 10L10n-bot) [07:25:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/508207 (owner: 10L10n-bot) [07:26:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FirstSteps] - 10https://gerrit.wikimedia.org/r/508212 (owner: 10L10n-bot) [07:27:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Form] - 10https://gerrit.wikimedia.org/r/508213 (owner: 10L10n-bot) [07:27:34] 10Growth-Team (Current Sprint): Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10Cntlsn) Hey @Urbanecm, thanks for your suggestion, it would definitely do the job! I was also thinking about adding a more visual aspect to it (since toolti... [07:27:39] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) Comparison of WebRequest and PSR-7 ServerRequestInterface: * PSR-7 provides getHeader() and getHeaderLine()... [07:28:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/508215 (owner: 10L10n-bot) [07:28:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/508216 (owner: 10L10n-bot) [07:29:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GoToShell] - 10https://gerrit.wikimedia.org/r/508217 (owner: 10L10n-bot) [07:30:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/508218 (owner: 10L10n-bot) [07:30:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508220 (owner: 10L10n-bot) [07:31:32] (03PS3) 10Nikerabbit: Make clicking on checkbox label toggle the checkbox [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/471233 [07:33:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/508222 (owner: 10L10n-bot) [07:34:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ImageTweaks] - 10https://gerrit.wikimedia.org/r/508223 (owner: 10L10n-bot) [07:35:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/InviteSignup] - 10https://gerrit.wikimedia.org/r/508224 (owner: 10L10n-bot) [07:37:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/508226 (owner: 10L10n-bot) [07:37:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/508227 (owner: 10L10n-bot) [07:38:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/508228 (owner: 10L10n-bot) [07:39:08] (03CR) 10Abijeet Patro: [C: 03+1] Make clicking on checkbox label toggle the checkbox [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/471233 (owner: 10Nikerabbit) [07:39:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/508229 (owner: 10L10n-bot) [07:40:17] (03PS3) 10simetrical: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 [07:40:19] (03PS1) 10simetrical: Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 [07:40:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MediaWikiChat] - 10https://gerrit.wikimedia.org/r/508232 (owner: 10L10n-bot) [07:41:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/508234 (owner: 10L10n-bot) [07:41:48] (03CR) 10simetrical: "No special motivation beyond the check being wrong. The link cache exists to store page existence and other info about pages from the data" [core] - 10https://gerrit.wikimedia.org/r/508106 (owner: 10simetrical) [07:42:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/508235 (owner: 10L10n-bot) [07:44:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/508236 (owner: 10L10n-bot) [07:46:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/508238 (owner: 10L10n-bot) [07:46:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/508240 (owner: 10L10n-bot) [07:48:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageSchemas] - 10https://gerrit.wikimedia.org/r/508241 (owner: 10L10n-bot) [07:49:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/508244 (owner: 10L10n-bot) [07:51:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/508182 (owner: 10L10n-bot) [07:52:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/508247 (owner: 10L10n-bot) [07:52:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SafeDelete] - 10https://gerrit.wikimedia.org/r/508249 (owner: 10L10n-bot) [07:53:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SimpleSecurity] - 10https://gerrit.wikimedia.org/r/508251 (owner: 10L10n-bot) [07:54:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/508250 (owner: 10L10n-bot) [07:55:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/508253 (owner: 10L10n-bot) [07:56:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/508254 (owner: 10L10n-bot) [07:57:53] 10MediaWiki-Docker: mediawiki docker image for 1.32.1 is missing - https://phabricator.wikimedia.org/T222580 (10Marc-Andre_Assbrock) [07:58:18] (03PS1) 10Agarwal.vishal: Added file to see how gerrit works [extensions/examples] - 10https://gerrit.wikimedia.org/r/508281 [07:58:20] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/508281 (owner: 10Agarwal.vishal) [07:58:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TEI] - 10https://gerrit.wikimedia.org/r/508256 (owner: 10L10n-bot) [07:59:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/508257 (owner: 10L10n-bot) [08:00:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/508259 (owner: 10L10n-bot) [08:02:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UnusedRedirects] - 10https://gerrit.wikimedia.org/r/508264 (owner: 10L10n-bot) [08:05:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/508267 (owner: 10L10n-bot) [08:08:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/508272 (owner: 10L10n-bot) [08:09:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/508196 (owner: 10L10n-bot) [08:09:08] 10Gadgets: Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Ammarpad) Works for me. {F28938269} Are you sure when you turned off the gadget you're not turning off with it? Because I know it's not part of the Editor extension. [08:09:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/intersection] - 10https://gerrit.wikimedia.org/r/508273 (owner: 10L10n-bot) [08:10:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/508274 (owner: 10L10n-bot) [08:10:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508199 (owner: 10L10n-bot) [08:12:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/508200 (owner: 10L10n-bot) [08:13:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508205 (owner: 10L10n-bot) [08:21:29] (03CR) 10simetrical: "Requesting review from Anomie as the original author of this code (and seemingly the only one who's touched it since)." [core] - 10https://gerrit.wikimedia.org/r/508279 (owner: 10simetrical) [08:21:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508210 (owner: 10L10n-bot) [08:23:06] (03CR) 10DCausse: "thank you!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [08:27:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/508214 (owner: 10L10n-bot) [08:29:04] (03CR) 10simetrical: Convert WatchedItem and friends to LinkTarget (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [08:32:06] (03CR) 10simetrical: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [08:33:07] 04(no projects): Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) [08:33:13] (03PS5) 10simetrical: Don't pass Config to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/503281 [08:33:15] (03PS4) 10simetrical: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 [08:33:17] (03PS8) 10simetrical: Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 [08:33:19] (03PS8) 10simetrical: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 [08:34:28] 04(no projects): Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) [08:35:44] 04(no projects): Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) [08:36:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508233 (owner: 10L10n-bot) [08:37:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [08:38:08] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, and 2 others: Add monolingual language codes qya, sjn - https://phabricator.wikimedia.org/T185194 (10Lea_Lacroix_WMDE) 05Open→03Resolved [08:38:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/508230 (owner: 10L10n-bot) [08:40:35] 10Quibble, 10Patch-For-Review: Quibble: deprecate and phase out EXT_DEPENDENCIES / SKIN_DEPENDENCIES - https://phabricator.wikimedia.org/T220199 (10hashar) [08:42:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/508237 (owner: 10L10n-bot) [08:44:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/508245 (owner: 10L10n-bot) [08:44:19] 04(no projects): What to work on Wikibase @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222583 (10Andrawaag) [08:45:55] 10MediaWiki-User-login-and-signup: Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) [08:46:29] (03CR) 10WMDE-Fisch: [C: 03+2] Improve rollback tests setup by extracting repeating logic to HistoryPage object [core] - 10https://gerrit.wikimedia.org/r/506623 (https://phabricator.wikimedia.org/T220479) (owner: 10Tonina Zhelyazkova) [08:46:33] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Shape Expressions @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222584 (10Andrawaag) [08:46:39] (03CR) 10DCausse: Add tokenizers for korean, japanese and chinese simplified (034 comments) [search/glent] - 10https://gerrit.wikimedia.org/r/507993 (owner: 10DCausse) [08:47:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508242 (owner: 10L10n-bot) [08:49:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/508248 (owner: 10L10n-bot) [08:50:51] (03PS2) 10DCausse: Add tokenizers for korean, japanese and chinese simplified [search/glent] - 10https://gerrit.wikimedia.org/r/507993 [08:51:56] 04(no projects): Call to undefined method SprintProjectProfilePanelEngine::buildNavigation() - when accessing "Burndown" - https://phabricator.wikimedia.org/T222586 (10Vlaza-servoy-com) [08:53:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/508255 (owner: 10L10n-bot) [08:53:34] (03CR) 10Michael Große: "recheck" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [08:53:54] (03CR) 10Michael Große: "recheck" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [08:56:17] (03CR) 10jerkins-bot: [V: 04-1] Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [08:56:28] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [08:57:44] (03PS30) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [08:57:57] 10Shape Expressions, 10Wikimedia-Hackathon-2019: In the Wikidata Integrator pull ShEx directly from . wikidata-shex.wmflabs.org - https://phabricator.wikimedia.org/T222587 (10Andrawaag) [08:59:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/508252 (owner: 10L10n-bot) [09:04:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/508266 (owner: 10L10n-bot) [09:04:36] (03PS1) 10simetrical: Log warning and show error on empty username [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) [09:05:07] 10MediaWiki-extensions-Translate: "Link to this message" in Special:Translate can produce a link with wrong language code - https://phabricator.wikimedia.org/T222588 (10Nikerabbit) [09:06:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/508263 (owner: 10L10n-bot) [09:06:30] (03PS15) 10simetrical: Convert filerepo to use LinkTarget [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) [09:07:39] (03PS10) 10simetrical: Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) [09:09:07] (03PS18) 10simetrical: Update GenderCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450452 [09:09:16] (03Merged) 10jenkins-bot: Improve rollback tests setup by extracting repeating logic to HistoryPage object [core] - 10https://gerrit.wikimedia.org/r/506623 (https://phabricator.wikimedia.org/T220479) (owner: 10Tonina Zhelyazkova) [09:09:19] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [09:09:33] (03Abandoned) 10simetrical: Reset all settings to default for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/451638 (owner: 10simetrical) [09:13:54] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Infer Schemas from Wikidata content - https://phabricator.wikimedia.org/T222589 (10Andrawaag) [09:15:08] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [09:15:41] (03CR) 10jenkins-bot: Improve rollback tests setup by extracting repeating logic to HistoryPage object [core] - 10https://gerrit.wikimedia.org/r/506623 (https://phabricator.wikimedia.org/T220479) (owner: 10Tonina Zhelyazkova) [09:18:43] RoanKattouw, when will the homepage experiment go live for newbies? https://wikitech.wikimedia.org/wiki/Deployments doesn't say anything useful [09:20:33] 10Quibble, 10Patch-For-Review, 10Tracking-Neverending: [tracking] Get quibble to run on all branches/php/database - https://phabricator.wikimedia.org/T192372 (10hashar) [09:20:34] (03CR) 10jerkins-bot: [V: 04-1] Log warning and show error on empty username [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) (owner: 10simetrical) [09:20:38] (03PS26) 10simetrical: Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 [09:20:43] 10MediaWiki-Core-Testing, 10MediaWiki-Parser, 10Quibble, 10Tidy, and 2 others: [REL1_30] Some parserTests fail on debian stretch using Tidy, because of a new version of libtidy - https://phabricator.wikimedia.org/T191771 (10hashar) 05Open→03Resolved a:03hashar I have migrated the container to use a D... [09:20:53] 10ConfirmEdit (CAPTCHA extension): ReCaptchaNoCaptcha displaying a
$1
message in the edit form - https://phabricator.wikimedia.org/T222590 (10Ciencia_Al_Poder) [09:22:10] (03CR) 10Raimond Spekking: [V: 03+2 C: 03+2] "false positive" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [09:23:14] 10Quibble, 10Patch-For-Review, 10Tracking-Neverending: [tracking] Get quibble to run on all branches/php/database - https://phabricator.wikimedia.org/T192372 (10hashar) 05Open→03Resolved a:03hashar That mostly got fixed. The intent of the task was to assist in migrating CI jobs to use #Quibble which ha... [09:23:35] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Ammarpad) >>! In T222527#5158368, @Reedy wrote: > It should've been updated on the 1st... 1st May? June? I am afraid, this is not clear >>! In T222527#5158388, @Reedy w... [09:27:47] (03PS2) 10simetrical: Log warning and show error on empty username [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) [09:27:49] (03PS1) 10PortalsBuilder: Assets build - 2019-05-06 09:24:07+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/508290 [09:27:53] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [09:28:50] (03CR) 10Daniel Kinzler: [C: 03+2] Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [09:31:31] (03CR) 10Zoranzoki21: [C: 03+1] "Looks good, anyone should merge this finally. We wait much time." [core] - 10https://gerrit.wikimedia.org/r/457894 (owner: 10Acamicamacaraca) [09:36:55] (03PS14) 10simetrical: Mass conversion to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450473 [09:37:21] (03Abandoned) 10simetrical: Factor Setup config initialization into function [core] - 10https://gerrit.wikimedia.org/r/451637 (owner: 10simetrical) [09:37:38] (03Abandoned) 10simetrical: Reformat DefaultSettings.php as array [core] - 10https://gerrit.wikimedia.org/r/451636 (owner: 10simetrical) [09:38:00] (03PS22) 10simetrical: Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 [09:38:03] (03PS7) 10simetrical: Update LinkCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/502455 [09:40:13] (03Abandoned) 10simetrical: Support PHPUnit 7.3 [core] - 10https://gerrit.wikimedia.org/r/464614 (https://phabricator.wikimedia.org/T204420) (owner: 10simetrical) [09:41:24] (03CR) 10Daniel Kinzler: [C: 03+2] Deprecate the Http class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [09:42:03] (03PS1) 10simetrical: Allow spaces in TitleValue constructor [core] - 10https://gerrit.wikimedia.org/r/508293 [09:42:07] (03CR) 10Daniel Kinzler: [C: 03+2] Update GenderCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450452 (owner: 10simetrical) [09:42:46] 04(no projects): 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) [09:43:00] 10Gadgets: Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Epine) @Ammarpad I am pretty sure that is not the case. Is there any way we can pinpoint this issue? Could it be one of the codes [[https://ckb.wikipedia.org/wiki/%D8%A8%DB%95%DA%A9%D8%A7%D8%B1%DA%BE%DB%8E%D9%86%DB%... [09:44:24] 04(no projects): 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) Hello, This error occured after when I changed my theme. And I also activated PHP7. Can you reset my settings? Thanks in advance. Kind Regards. [09:45:37] (03PS6) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [09:45:40] (03PS1) 10simetrical: Use RepoGroup service in MovePage [core] - 10https://gerrit.wikimedia.org/r/508294 [09:45:52] (03PS1) 10Dvorapa: Add a new {{USERLANGUAGE}} variable for use in wikitext [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) [09:46:56] (03PS4) 10Dvorapa: Add system message MediaWiki:Langcode [core] - 10https://gerrit.wikimedia.org/r/507328 (https://phabricator.wikimedia.org/T4085) (owner: 10Want) [09:47:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Makes sense for me. Namespaces should not become directories here." [core] - 10https://gerrit.wikimedia.org/r/508099 (owner: 10Krinkle) [09:48:01] (03CR) 10Daniel Kinzler: Convert WatchedItem and friends to LinkTarget (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [09:48:26] (03CR) 10Daniel Kinzler: [C: 03+1] "Just one nitpick left" [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [09:48:43] (03CR) 10Dvorapa: "See also another way to solve the {{int:Lang}} hack: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/507328/" [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [09:49:03] (03Abandoned) 10Santhosh: Add debug to logEvent method in php [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/502465 (owner: 10Santhosh) [09:49:15] (03CR) 10Dvorapa: "See also another way to solve the {{int:Lang}} hack: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/508295/" [core] - 10https://gerrit.wikimedia.org/r/507328 (https://phabricator.wikimedia.org/T4085) (owner: 10Want) [09:51:09] (03CR) 10Daniel Kinzler: [C: 03+2] Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [09:51:31] (03CR) 10Thiemo Kreuz (WMDE): "This patch probably does no harm, but it also does not make anything better, I'm afraid." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 (owner: 10D3r1ck01) [09:52:33] (03CR) 10Daniel Kinzler: "@simetrical, would you file a ticket for the bug in the namespace restrictions logic, and reference it here? I'm not sure I can describe t" [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [09:53:17] (03CR) 10simetrical: Convert WatchedItem and friends to LinkTarget (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [09:53:39] (03PS9) 10simetrical: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 [09:53:42] (03CR) 10Daniel Kinzler: [C: 03+2] Don't pass Config to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/503281 (owner: 10simetrical) [09:54:01] (03Merged) 10jenkins-bot: Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [09:54:03] (03CR) 10Dvorapa: "I wonder about the following things:" [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [09:54:36] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Pginer-WMF) >>! In T219851#5157593, @williamsp wrote: > Hi @Pginer-WMF. I just wrote my opinion feedback there. Sorry, for late response. Thanks for your reply, @willi... [09:57:49] (03CR) 10Daniel Kinzler: [C: 03+2] MovePage methods need to run safety checks [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [09:58:31] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I'm sorry, but I don't think this does make this code better." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508117 (owner: 10D3r1ck01) [09:58:37] (03CR) 10Daniel Kinzler: "would you file a ticket for the bug in the namespace restrictions logic, and reference it here? I'm not sure I can describe the issue corr" [core] - 10https://gerrit.wikimedia.org/r/508279 (owner: 10simetrical) [09:59:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] MobileContextTest: Fix PHPDoc canonical order for parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [09:59:28] 04(no projects): 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Ludoboardgame) Follow these steps- Scroll down to the bottom of the page, and click Save Changes. Open your website in your browser. If the 500 internal server error is gone, it was caused by a corrupte... [09:59:31] (03CR) 10Michael Große: "This change to the signature of interface methods broke[0] the EntitySchema codebases that _implements_ that interface in test, even if it" [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [09:59:33] (03CR) 10Daniel Kinzler: "> @simetrical, would you file a ticket for the bug in the namespace restrictions logic, and reference it here? I'm not sure I can describe" [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [09:59:53] 10Wikimedia-User-Group-Basque: Liburuzainak - Literatura Unibertsala - https://phabricator.wikimedia.org/T182807 (10Theklan) [09:59:57] 10Wikimedia-User-Group-Basque: Idazlezainak: irailak 28ko editatoia - https://phabricator.wikimedia.org/T204256 (10Theklan) 05Open→03Resolved [10:00:08] (03CR) 10Daniel Kinzler: [C: 03+2] 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [10:00:46] 10Wikimedia-User-Group-Basque: Euskal Zinemateka - https://phabricator.wikimedia.org/T186869 (10Theklan) 05Open→03Declined [10:00:51] (03CR) 10jenkins-bot: Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [10:01:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] TorExitNodes: Avoid deprecated use of ObjectCache::getMainStashInstance() (031 comment) [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/508114 (owner: 10D3r1ck01) [10:01:21] (03CR) 10Daniel Kinzler: [C: 03+2] Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [10:01:41] 10Wikimedia-User-Group-Basque: Tokikom - EWKE akordioa - https://phabricator.wikimedia.org/T222597 (10Theklan) [10:02:26] (03CR) 10Daniel Kinzler: [C: 03+2] "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/508106 (owner: 10simetrical) [10:03:13] 10Wikimedia-User-Group-Basque: Eusko Jaurlaritzaren ondarearen zerrenda eskuratzea - https://phabricator.wikimedia.org/T205007 (10Theklan) Berriro idatzio diot zerrenda eskatzeko. Ea aukerarik dagoen. [10:03:14] (03CR) 10Daniel Kinzler: [C: 03+2] "restore CR+2 after rebase" [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [10:03:44] 10MediaWiki-General-or-Unknown: NamespaceInfo::getRestrictionLevels() does not correctly handle namespace restrictions that require more than one permission - https://phabricator.wikimedia.org/T222598 (10Simetrical) [10:04:00] 10WMNO-General: Merch for IYIL 2019: before July - https://phabricator.wikimedia.org/T222599 (10WMNOastrid) [10:04:44] 10Wikimedia-User-Group-Basque: Sakanapedia - https://phabricator.wikimedia.org/T175705 (10Theklan) 05Stalled→03Invalid [10:05:49] (03PS5) 10simetrical: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 [10:05:50] (03PS2) 10simetrical: Fix logic in NamespaceInfo::getRestrictionLevels [core] - 10https://gerrit.wikimedia.org/r/508279 (https://phabricator.wikimedia.org/T222598) [10:06:04] 04(no projects): 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Aklapper) @Ludoboardgame: What you wrote makes no sense at all, sorry. Please refrain from such postings. [10:06:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] rcfeed: Replace usage of deprecated class RCFeedEngine (in comments) [core] - 10https://gerrit.wikimedia.org/r/505403 (owner: 10D3r1ck01) [10:09:10] 10Wikimedia-User-Group-Basque: Ricardo Baroja eskola - https://phabricator.wikimedia.org/T219566 (10Theklan) p:05Triage→03Normal [10:10:08] (03CR) 10DCausse: Add FallbackRunnerContext (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506406 (owner: 10DCausse) [10:11:51] (03PS1) 10Hoo man: Adapt ArrayRevisionLookup to RevisionLookup changes [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508297 (https://phabricator.wikimedia.org/T222596) [10:12:26] (03CR) 10Hoo man: [C: 03+2] "For the broken tests, please see T222596" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [10:12:36] 10WMNO-General: Pictures of staff with WMNO logo - https://phabricator.wikimedia.org/T221847 (10jhsoby-WMNO) 05Open→03Resolved [10:13:09] 04(no projects): 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Ludoboardgame) Actually, that Media-wiki has this problem solved if you visit, you will get the solution. [10:13:12] (03PS7) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [10:15:14] (03Merged) 10jenkins-bot: Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [10:15:18] (03CR) 10Jdrewniak: "recheck" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/508290 (owner: 10PortalsBuilder) [10:16:16] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Pginer-WMF) >>! In T219851#5158068, @Mimihitam wrote: > @Pginer-WMF the threshold is already working well. **The only final adjustment that needs to be made is that sou... [10:16:27] 04(no projects): increasing abuse of installations of Mediawiki application - https://phabricator.wikimedia.org/T222536 (10Billinghurst) [10:20:53] 10Core Platform Team (Decoupling (CDP2)), 10Core Platform Team Kanban (Doing), 10Patch-For-Review: Refactor the Http class to not use global state - https://phabricator.wikimedia.org/T214390 (10Simetrical) 05Open→03Resolved [10:22:52] 04(no projects): increasing abuse of installations of Mediawiki application - https://phabricator.wikimedia.org/T222536 (10Billinghurst) >>! In T222536#5158047, @Aklapper wrote: > By "wikimedia application", did you mean "MediaWiki"? > > Since T85327 in 1.27, https://www.mediawiki.org/wiki/Manual:Combating_spa... [10:26:50] (03PS1) 10simetrical: Add a bunch of MovePage tests [core] - 10https://gerrit.wikimedia.org/r/508299 [10:28:13] (03PS7) 10DCausse: Add FallbackRunnerContext [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506406 [10:28:15] (03PS8) 10DCausse: Add a way to track msearch requests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506689 (https://phabricator.wikimedia.org/T221621) [10:28:17] (03PS8) 10DCausse: Keep msearch keys and order in fixtures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506690 [10:28:19] (03PS5) 10DCausse: Allow fallback methods to send search queries [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507080 (https://phabricator.wikimedia.org/T221621) [10:28:21] (03PS2) 10DCausse: Add a way to configure fallback methods [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507392 (https://phabricator.wikimedia.org/T222152) [10:28:23] (03PS2) 10DCausse: Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 [10:28:25] (03PS2) 10DCausse: Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 [10:28:27] (03PS1) 10DCausse: Fix gen-autoload.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508300 [10:29:04] (03CR) 10Jdrewniak: [C: 03+2] Assets build - 2019-05-06 09:24:07+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/508290 (owner: 10PortalsBuilder) [10:29:20] 10WMNO-General: Intern Aleksander - https://phabricator.wikimedia.org/T221853 (10jhsoby-WMNO) 05Open→03Resolved [10:30:02] (03Merged) 10jenkins-bot: Assets build - 2019-05-06 09:24:07+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/508290 (owner: 10PortalsBuilder) [10:30:42] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Aklapper) @Ludoboardgame: No, wrong. Just because many different problems can lead to 503 errors does not mean that one solution for one problem would solve all other proble... [10:32:07] (03CR) 10jenkins-bot: Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [10:33:03] 10Wikimedia-Hackathon-2019: What to work on Wikibase @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222583 (10Aklapper) Assuming this is about #Wikimedia-Hackathon-2019. Please move accordingly on the workboard (is this a talk? a session? skill sharing?) and see https://www.mediawiki.org/wiki/Wi... [10:35:29] (03CR) 10Daniel Kinzler: [C: 04-1] "Some nitpicks remain." (037 comments) [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [10:35:37] 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Inactive extensions and skins in Diffusion / Github - https://phabricator.wikimedia.org/T180864 (10hashar) 05Open→03Resolved Seems that got resolved :) [10:36:45] (03CR) 10Daniel Kinzler: [C: 03+2] Use RepoGroup service in MovePage [core] - 10https://gerrit.wikimedia.org/r/508294 (owner: 10simetrical) [10:37:31] (03CR) 10Aklapper: [C: 04-2] "Hi, if you only want to play with Gerrit, please use http://gerrit-test.wmflabs.org/ instead of gerrit.wikimedia.org (and tell us how you " [extensions/examples] - 10https://gerrit.wikimedia.org/r/508281 (owner: 10Agarwal.vishal) [10:38:17] (03PS7) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [10:43:30] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) @Aklapper yes, It still remains, the 500 error. [10:44:02] (03CR) 10Luca Mauri: "> http://www.mediawiki.org/xml/sitelist-1.0/ would be updated in a" [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [10:44:47] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_weight_Pages_weights_are_updated_when_links_are_removed_from_their" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508300 (owner: 10DCausse) [10:45:19] (03Merged) 10jenkins-bot: Update GenderCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450452 (owner: 10simetrical) [10:47:01] (03CR) 10Daniel Kinzler: [C: 04-1] "The unit test is missing a case (or I'm confused). Looks good otherwise." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [10:50:01] (03CR) 10Michael Große: "recheck" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508297 (https://phabricator.wikimedia.org/T222596) (owner: 10Hoo man) [10:50:34] (03CR) 10Daniel Kinzler: [C: 03+2] Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [10:51:26] (03CR) 10Hashar: [C: 03+2] Add phan [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [10:51:27] 10Wikimedia-User-Group-Basque: UEU - Udako ikastaroak - https://phabricator.wikimedia.org/T181656 (10Theklan) [10:51:29] 10Wikimedia-User-Group-Basque: Udako ikastaroa - Curriculuma, generoa eta Wikipedia - https://phabricator.wikimedia.org/T185517 (10Theklan) 05Open→03Declined [10:51:38] (03Merged) 10jenkins-bot: Don't pass Config to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/503281 (owner: 10simetrical) [10:51:44] (03Merged) 10jenkins-bot: MovePage methods need to run safety checks [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [10:51:46] (03CR) 10jerkins-bot: [V: 04-1] MobileContextTest: Fix PHPDoc canonical order for parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [10:52:52] 10Wikimedia-User-Group-Basque: Scholia eta Inguma - https://phabricator.wikimedia.org/T222601 (10Theklan) [10:53:02] 10Wikimedia-User-Group-Basque: Scholia eta Inguma - https://phabricator.wikimedia.org/T222601 (10Theklan) p:05Triage→03High [10:53:08] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [10:53:22] (03CR) 10jenkins-bot: Update GenderCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450452 (owner: 10simetrical) [10:53:58] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): CX2: Additional details for too much unmodified content error - https://phabricator.wikimedia.org/T203377 (10Petar.petkovic) >>! In T203377#5154817, @Etonkovidova wrote: > Checked in enwiki (`wmf.3`)... [10:54:16] (03CR) 10simetrical: Introduce MovePageFactory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [10:54:48] (03CR) 10Daniel Kinzler: [C: 04-1] "@deprecated tags need to be changed to be since 1.34 now." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [10:55:00] (03PS7) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [10:55:40] (03PS2) 10simetrical: Use RepoGroup service in MovePage [core] - 10https://gerrit.wikimedia.org/r/508294 [10:57:10] (03PS2) 10simetrical: Add a bunch of MovePage tests [core] - 10https://gerrit.wikimedia.org/r/508299 [10:57:24] Please I need some help with handling issues with "...blocked by CORS policy: No 'Access-Control-Allow-Origin' header is present on the requested resource" from requests here https://www.mediawiki.org/wiki/Manual:CORS#Using_jQuery_methods [10:57:34] 10wb_terms - Tool Builders Migration: Overview of wb_terms redesign - https://phabricator.wikimedia.org/T221764 (10alaa_wmde) @Multichill I'm sorry I didn't address your exact query directly. To address this issue concretely, I created another task in the Backlog T222602 (subscribed you to it too). We will che... [10:59:02] (03PS8) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [10:59:09] (03PS8) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [10:59:11] (03PS3) 10simetrical: Use RepoGroup service in MovePage [core] - 10https://gerrit.wikimedia.org/r/508294 [10:59:35] (03PS3) 10simetrical: Add a bunch of MovePage tests [core] - 10https://gerrit.wikimedia.org/r/508299 [11:01:03] (03CR) 10Hashar: "I think that requires a rebase due to a merge conflict in RELEASE-NOTES-1.34" [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [11:01:47] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506406 (owner: 10DCausse) [11:06:09] (03CR) 10Michael Große: [C: 03+2] "Not sure why Jenkins/CI is not responding? o.O" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508297 (https://phabricator.wikimedia.org/T222596) (owner: 10Hoo man) [11:06:11] (03CR) 10jenkins-bot: Don't pass Config to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/503281 (owner: 10simetrical) [11:07:45] (03CR) 10Daniel Kinzler: [C: 04-1] Factors out permissions check from User into PermissionManager service (037 comments) [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [11:08:22] (03CR) 10Daniel Kinzler: [C: 04-1] "Note to self: checked new code in PermissionManager against old code in User, looks equivalent." [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [11:10:32] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdrewniak) @alexhollender re: radio button functionality & grey background: Yea... [11:12:57] (03CR) 10jenkins-bot: MovePage methods need to run safety checks [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [11:13:35] 10Wikidata-Termbox-Iteration-12 ✓, 10Wikidata-Termbox-Iteration-13, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review: Allow editing of fields - https://phabricator.wikimedia.org/T216987 (10Lea_WMDE) [11:13:39] 10Wikidata-Termbox-Iteration-13, 10Wikidata-Termbox-Iteration-14, 10Patch-For-Review: Cross domain api requests mobile beta - https://phabricator.wikimedia.org/T220995 (10Lea_WMDE) 05Open→03Resolved [11:14:53] (03CR) 10jerkins-bot: [V: 04-1] Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [11:14:55] (03CR) 10jerkins-bot: [V: 04-1] Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [11:16:05] (03PS1) 10simetrical: Fix some silly behavior of MovePage::isValidMove() [core] - 10https://gerrit.wikimedia.org/r/508306 [11:17:21] (03PS6) 10simetrical: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 [11:17:23] (03PS9) 10simetrical: Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 [11:17:25] (03PS10) 10simetrical: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 [11:19:50] 10MediaWiki-extensions-Page_Forms: Add button on a form to save and continue editing with Visual Editor - https://phabricator.wikimedia.org/T192570 (10Nicolas_NALLET) [11:24:03] (03CR) 10Daniel Kinzler: [C: 03+2] 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [11:24:47] (03CR) 10Daniel Kinzler: [C: 03+2] Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [11:26:18] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Shape Expressions @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222584 (10Aklapper) Is this a project, a session, or a skillshare? Feel free to clarify via the {nav name=Add Action... > Move on Workboard} dropdown. Thanks! [11:27:16] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Integrate SVG Translate with Content Translation - https://phabricator.wikimedia.org/T220440 (10Petar.petkovic) >>! In T220440#5158344, @Townie wrote: > @Petar.petkovic What do you think of these proposals? Which one would you go for first? First, SVG translate... [11:27:44] (03Merged) 10jenkins-bot: TorExitNodes: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/508114 (owner: 10D3r1ck01) [11:28:00] (03CR) 10Daniel Kinzler: [C: 03+2] "...and again..." [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [11:28:47] (03CR) 10jenkins-bot: TorExitNodes: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/508114 (owner: 10D3r1ck01) [11:33:04] (03CR) 10Daniel Kinzler: "I'll give this another pass after lunch. Perhaps it can go in today." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) (owner: 10simetrical) [11:35:43] 10Wikidata-Termbox-Iteration-14, 10Wikidata-Termbox-Iteration-15: /termbox query validation based on openapi.json - https://phabricator.wikimedia.org/T222435 (10WMDE-leszek) [11:35:59] 10Wikidata-Termbox-Iteration-13, 10Wikidata-Termbox-Iteration-14, 10Wikidata-Termbox-Iteration-15: Ensure test mutations only perform reactivity-friendly changes - https://phabricator.wikimedia.org/T220686 (10WMDE-leszek) [11:39:18] (03Merged) 10jenkins-bot: NS_MEDIA also always has page_id 0 [core] - 10https://gerrit.wikimedia.org/r/508106 (owner: 10simetrical) [11:41:31] (03PS8) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [11:41:40] (03CR) 10Fomafix: [C: 04-1] Add a new {{USERLANGUAGE}} variable for use in wikitext (034 comments) [core] - 10https://gerrit.wikimedia.org/r/508295 (https://phabricator.wikimedia.org/T4085) (owner: 10Dvorapa) [11:42:32] 10Design, 10WMDE-Design, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: new constraint level for suggestions - https://phabricator.wikimedia.org/T204439 (10noarave) Deployed in production [11:43:05] (03Merged) 10jenkins-bot: rcfeed: Replace usage of deprecated class RCFeedEngine (in comments) [core] - 10https://gerrit.wikimedia.org/r/505403 (owner: 10D3r1ck01) [11:43:07] (03CR) 10jerkins-bot: [V: 04-1] Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [11:43:17] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Notifications, 10Outreach-Programs-Projects, 10Community-Wishlist-Survey-2016: Notify users about deletion tags being added to pages they created - https://phabricator.wikimedia.org/T123866 (10Izno) [11:43:49] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Aklapper) This is unrelated to the #Gadgets PHP extension. See the project description of #Gadgets. [11:45:04] (03CR) 10jenkins-bot: NS_MEDIA also always has page_id 0 [core] - 10https://gerrit.wikimedia.org/r/508106 (owner: 10simetrical) [11:46:02] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019), 10Language-Team (Language-2019-April-June): Specialist support for Content Translation moving from beta to regular preferences in Catalan Wikipedia - https://phabricator.wikimedia.org/T214689 (10Pginer-WMF) >>! In T214689#5155884, @Elitre wr... [11:48:30] 10Wikidata-Termbox-Iteration-15: Timebox dev unhappy path collection [2h] - https://phabricator.wikimedia.org/T220701 (10WMDE-leszek) [11:52:08] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Infer Schemas from Wikidata content - https://phabricator.wikimedia.org/T222589 (10Aklapper) Is this a project, a session, or a skillshare? Feel free to clarify via the {nav name=Add Action... > Move on Workboard} dropdown. Thanks! [11:52:20] (03CR) 10D3r1ck01: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [11:52:28] 10Shape Expressions, 10Wikimedia-Hackathon-2019: In the Wikidata Integrator pull ShEx directly from . wikidata-shex.wmflabs.org - https://phabricator.wikimedia.org/T222587 (10Aklapper) Is this a project, a session, or a skillshare? Feel free to clarify via the {nav name=Add Action... > Move on Workboard} dropd... [11:52:56] (03CR) 10jenkins-bot: rcfeed: Replace usage of deprecated class RCFeedEngine (in comments) [core] - 10https://gerrit.wikimedia.org/r/505403 (owner: 10D3r1ck01) [11:53:44] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Wikimedia-Hackathon-2019: Help panel: provide ability to vary links by context - https://phabricator.wikimedia.org/T211117 (10Trizek-WMF) That task may need some design input. At the moment, not everyone understands that concept of namespaces and hav... [11:55:41] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Regression, 10Wikimedia-production-error: Cannot create some new pages on Wiktionary: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Aklapper) p:05Triage→03High [11:58:22] 10Discovery-Search (Current work): Capacity planning for elastic search - https://phabricator.wikimedia.org/T221121 (10Gehel) Executive summary: we should have enough capacity for next year. **hypothesis to validate:** elasticsearch clusters have enough capacity to support the load for the next year. As an esti... [12:00:41] (03PS1) 10Daimona Eaytoy: Remove the EXEC bits from Message::rawParams' parameters [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508312 [12:00:59] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Shape Expressions @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222584 (10Andrawaag) This a task to aggregate and keep track of plans and developments on ShEx at the hackathon [12:01:55] (03PS10) 10Daimona Eaytoy: Add a file with base config [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507101 [12:02:15] (03PS6) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [12:02:20] (03PS5) 10Daimona Eaytoy: Hack: exclude OOUI constructors from DoubleEscape reporting [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 [12:02:22] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Regression: [wmf.3 - regression] testwiki - placeholded image for cx-selected-source-page__image not displayed - https://phabricator.wikimedia.org/T222250 (10Petar.petkovic) [12:02:25] (03PS5) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [12:02:29] (03PS5) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [12:02:33] (03PS6) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [12:02:38] (03PS4) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [12:02:41] (03PS7) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [12:02:45] (03PS6) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [12:02:48] (03PS6) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [12:02:52] (03PS7) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [12:02:56] (03PS6) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [12:03:00] (03PS4) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [12:03:04] (03PS9) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [12:03:07] (03PS3) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [12:04:11] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Shape Expressions @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222584 (10Andrawaag) [12:04:13] 10Wikimedia-Hackathon-2019: Introduction to using Shape Expressions to monitor and improve Wikidata items - https://phabricator.wikimedia.org/T219730 (10Andrawaag) [12:07:06] (03CR) 10Daniel Kinzler: [C: 04-1] "Something went wrong in Job.php" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) (owner: 10simetrical) [12:07:57] (03CR) 10Hashar: [C: 03+2] Add phan [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/507574 (owner: 10Umherirrender) [12:09:58] 10MinervaNeue, 10Wikimedia-production-error: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10Urbanecm) p:05Triage→03Unbreak! Affects every pageview with minerva, see https://cs.wikipedia.org/w/index.php?title=Hlavn... [12:12:09] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10D3r1ck01) I think this is a dup of {T222407} and I also think it's been addressed. Thanks [12:12:44] 10Wikimedia-Site-requests: Imported Module from English, triggers category addition MediaWiki:Post-expand-template-inclusion-category - https://phabricator.wikimedia.org/T222578 (10Aklapper) The added category is `మూస చేర్పు సైజును అధిగమించిన పేజీలు` / `Pages where template include size is exceeded`. Looking a... [12:13:06] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10D3r1ck01) [12:13:11] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [12:13:21] 10Wikimedia-Site-requests: Module imported from en.wp triggers parser expansion size limit (MediaWiki:Post-expand-template-inclusion-category) on te.wp - https://phabricator.wikimedia.org/T222578 (10Aklapper) [12:13:23] 04(no projects): Visual editor inserts line break between table tags truncating the table - https://phabricator.wikimedia.org/T222607 (10Leonard2019) [12:13:27] 10Wikimedia-Hackathon-2019: Should Wikidata Integrator and Pywikibot merge? - https://phabricator.wikimedia.org/T222608 (10Andrawaag) [12:13:30] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia. - https://phabricator.wikimedia.org/T222594 (10D3r1ck01) Please if I'm wrong, reopen and unmerge. [12:14:09] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Ammarpad) 05Stalled→03Invalid I am not sure it belongs here at all. I asked another user to test and they reported it's working correctly. @Epine, I am not sure whether this is related to your common.js,... [12:15:10] 10MediaWiki-extensions-Renameuser, 10phan-taint-check-plugin: analyse and fix suppressed taint-check issue for Renameuser - https://phabricator.wikimedia.org/T211471 (10Daimona) I just checked and this will be fixed (without the need to suppress the issue) with taint-check 2.0 (still in dev). [12:15:42] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [12:16:48] 10MediaWiki-User-login-and-signup: Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10Aklapper) 05Open→03Stalled @ShakespeareFan00: Why was this reported here and not on https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProj... [12:18:16] 10MediaWiki-User-login-and-signup: Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) 05Stalled→03Invalid [12:18:53] 10phan-taint-check-plugin: make phan-taint-check handle array_map - https://phabricator.wikimedia.org/T204911 (10Daimona) [12:19:33] 10MediaWiki-User-login-and-signup: Changes to Logout UI, causing Wiki Break Enforcer script to loop/regenerate continuously. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) Closing as invalid, as you think it's a script error. if you'd like to provide an explanation of how the script SHOULD be... [12:19:39] 10WMSE-SMHI-2019: [Parent] Kustvattenförekomst infobox - https://phabricator.wikimedia.org/T220581 (10Jopparn) [12:20:20] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508300 (owner: 10DCausse) [12:20:45] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Jonesey95) This is a significant problem affecting some of the... [12:20:54] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Aklapper) On an unrelated note, * `mw.util.addCSS` is broken in https://ckb.wikipedia.org/wiki/MediaWiki:Gadget-RedirectMaker.js * `mw.util.addCSS` is undefined in https://en.wikipedia.org/wiki/User:Endo999/G... [12:21:26] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Aklapper) [12:23:08] 04(no projects): Visual editor inserts line break between table tags truncating the table - https://phabricator.wikimedia.org/T222607 (10Aklapper) [12:23:39] 10Design, 10WMDE-Design, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: new constraint level for suggestions - https://phabricator.wikimedia.org/T204439 (10Lea_Lacroix_WMDE) And [[ https://lists.wikimedia.org/pipermail/wikidata/2019-May/013026.html | announced ]]! Let's keep this task open for a... [12:26:38] 10MinervaNeue, 10Wikimedia-production-error: Cannot access any pages with Minerva skin: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10Aklapper) [12:28:02] 10WMSE-Library-Data-2018, 10Goal: Write blog posts for general audience - https://phabricator.wikimedia.org/T205388 (10Jopparn) [12:29:45] (03Merged) 10jenkins-bot: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [12:29:47] (03CR) 10jerkins-bot: [V: 04-1] Add phan [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [12:29:49] (03Merged) 10jenkins-bot: Adapt ArrayRevisionLookup to RevisionLookup changes [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508297 (https://phabricator.wikimedia.org/T222596) (owner: 10Hoo man) [12:29:58] (03PS10) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [12:30:33] (03PS4) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [12:32:22] (03Merged) 10jenkins-bot: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [12:34:08] (03CR) 10jenkins-bot: Adapt ArrayRevisionLookup to RevisionLookup changes [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508297 (https://phabricator.wikimedia.org/T222596) (owner: 10Hoo man) [12:38:19] (03PS2) 10DmitriyShevliakov: Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/508120 [12:38:47] (03CR) 10jerkins-bot: [V: 04-1] Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [12:38:49] (03CR) 10jerkins-bot: [V: 04-1] Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [12:38:52] (03CR) 10jenkins-bot: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [12:41:58] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team: Postmerge test failure investigation - https://phabricator.wikimedia.org/T209212 (10hashar) [12:43:38] 10MediaWiki-User-login-and-signup: Script, does not supply LogoutToken parameter when navigating to Special:UserLogout, leading to infinite attempts at enforcing a wiki-break logout.. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) [12:44:28] 10Phabricator, 10Release-Engineering-Team (Backlog): Getting Admin rights for Phabricator - https://phabricator.wikimedia.org/T221136 (10RazShuty) @Aklapper sorry for the super late reply just came back from a long vacation... I just enabled the 2fa for my Phab... and yes you are absolutely right about the und... [12:44:31] (03CR) 10jenkins-bot: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [12:45:39] (03CR) 10Michael Große: "recheck" [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [12:47:19] (03CR) 10D3r1ck01: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [12:47:50] (03CR) 10D3r1ck01: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [12:47:55] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [12:48:00] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) Hello @D3r1ck01 , I still have the 500 error: Request from 45.32.186.171 via cp1085 cp1085, Varnish XID 117176781 Error: 500, Internal S... [12:49:27] (03PS7) 10Pboehm: Enable Pasting of Text with embedded Links [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/500722 [12:49:57] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10D3r1ck01) See comment here: https://phabricator.wikimedia.org/T222407#5155689 [12:50:43] (03PS2) 10D3r1ck01: MobileContextTest: Fix PHPDoc canonical order for parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 [12:51:50] (03Merged) 10jenkins-bot: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [12:54:40] (03CR) 10Daniel Kinzler: "Bill, do you think you could take this over and resolve the remaining issues? It's not urgent, but if we do it later, it needs a ticket fo" [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [12:55:43] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) I can access English Wiki and I restored default in there, I still can't access Turkish Wiki. [12:56:36] (03Merged) 10jenkins-bot: Add phan [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/507574 (owner: 10Umherirrender) [12:57:45] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) 05duplicate→03Open [12:59:07] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10D3r1ck01) @Yetkilibirabiniz, what is your location right now, are you currently in Turkey? See: https://en.wikipedia.org/wiki/Block_of_Wikipedia_in_Turkey :... [12:59:59] (03CR) 10jenkins-bot: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [13:00:46] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Yetkilibirabiniz) 05Open→03Resolved a:03Yetkilibirabiniz No, it's not related. I found out that you can set global preferences on English Settings pag... [13:00:47] (03CR) 10jenkins-bot: Add phan [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/507574 (owner: 10Umherirrender) [13:02:26] 10MediaWiki-User-login-and-signup: Script, does not supply LogoutToken parameter when navigating to Special:UserLogout, leading to infinite attempts at enforcing a wiki-break logout.. - https://phabricator.wikimedia.org/T222582 (10ShakespeareFan00) And for reference the Special:UserLogout changes are related to... [13:04:23] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Epine) [[https://ckb.wikipedia.org/wiki/بەکارھێنەر:Épine/communicator.js|the issue was this]], in case it happens to anyone else on other wikis. [13:05:33] (03CR) 10Petar.petkovic: [C: 03+2] Make clicking on checkbox label toggle the checkbox [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/471233 (owner: 10Nikerabbit) [13:10:00] (03CR) 10Gehel: [C: 03+1] "LGTM (but someone who understand tokenization for those languages should also review)" (031 comment) [search/glent] - 10https://gerrit.wikimedia.org/r/507993 (owner: 10DCausse) [13:12:11] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: Deploy to target wikis in production - https://phabricator.wikimedia.org/T221266 (10SBisson) Consider SWATing https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/507956 before enabling the experi... [13:15:52] 10MediaWiki-User-login-and-signup: "WikiBreak_Enforcer" script on en.wp does not supply LogoutToken parameter - https://phabricator.wikimedia.org/T222582 (10Aklapper) [13:16:36] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Aklapper) This issue is the same issue as {T222407}. Please do not reopen. [13:16:45] 10MinervaNeue, 10Wikimedia-production-error: 500 error when trying to access TR Wikipedia with Minerva skin - https://phabricator.wikimedia.org/T222594 (10Aklapper) [13:16:51] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [13:17:07] (03Merged) 10jenkins-bot: Make clicking on checkbox label toggle the checkbox [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/471233 (owner: 10Nikerabbit) [13:18:01] (03CR) 10jenkins-bot: Make clicking on checkbox label toggle the checkbox [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/471233 (owner: 10Nikerabbit) [13:18:03] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Aklapper) @Epine: Glad that you found the reason. For future reference, problems with local user scripts or gadgets are not handled in Phabricator and should not be filed here. [13:23:38] 10Wikimedia-Site-requests: Requesting temporary lift of IP cap for WikiProject L&O Workshop Event - https://phabricator.wikimedia.org/T222611 (10Drarialshogren) [13:24:26] (03CR) 10Pboehm: "recheck" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/500722 (owner: 10Pboehm) [13:30:41] (03CR) 10Tjones: Add tokenizers for korean, japanese and chinese simplified (031 comment) [search/glent] - 10https://gerrit.wikimedia.org/r/507993 (owner: 10DCausse) [13:31:18] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10User-abi_: Translate error - unable to save translations on metawiki in one page just marked for translation - https://phabricator.wikimedia.org/T221119 (10Trijnstel) Same here. I did this: https://meta.wikimedia.org/w/index.php?... [13:32:03] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10User-abi_: Translate error - unable to save translations on metawiki in one page just marked for translation - https://phabricator.wikimedia.org/T221119 (10Zppix) Is there a fix foreseen in the future? [13:32:23] 10MinervaNeue, 10Wikimedia-production-error: Cannot access any pages with Minerva skin: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10pmiazga) a:03pmiazga [13:33:44] (03PS9) 10Jdrewniak: Adds AMC styles for action=history page [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) [13:34:10] 10MediaWiki-extensions-Scribunto, 10Commons, 10I18n: Implement Lua alternative to {{int:Lang}} / wgUserLanguage - https://phabricator.wikimedia.org/T173207 (10Anomie) [13:34:16] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 10Wikidata: Central modules need the user language to display errors and category names - https://phabricator.wikimedia.org/T68051 (10Anomie) [13:34:30] 10MinervaNeue, 10Wikimedia-production-error: Cannot access any pages with Minerva skin: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10pmiazga) it's duplicate of {T222407} [13:34:40] 10MediaWiki-Internationalization, 10MediaWiki-extensions-Scribunto, 10Wikidata: Implement Lua alternative to {{int:Lang}} / wgUserLanguage - https://phabricator.wikimedia.org/T68051 (10Anomie) [13:34:47] 04(no projects): Gadget issue on ckb wiki: refToolbar.js - https://phabricator.wikimedia.org/T222563 (10Epine) >>! In T222563#5159856, @Aklapper wrote: > @Epine: Glad that you found the reason. For future reference, problems with local user scripts or gadgets are not handled in Phabricator and should not be fil... [13:37:07] (03CR) 10Hoo man: [C: 03+2] Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [13:38:14] 10MinervaNeue, 10Wikimedia-production-error: Cannot access any pages with Minerva skin: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10pmiazga) @Urbanecm it affects only - mobile web users with AMC mode turned on -... [13:38:30] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdrewniak) @alexhollender > should we ditch the "Compare selected revisions" bu... [13:38:35] 10MinervaNeue, 10Wikimedia-production-error: Cannot access any pages with Minerva skin: BadMethodCallException after login: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222500 (10pmiazga) [13:38:41] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [13:39:21] 10Hashtags: Event stream may not be being parsed in precise timestamp order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) [13:40:31] (03PS1) 10D3r1ck01: Resources: ResourceLoaderJqueryMsgModuleMagicWords hook removed [core] - 10https://gerrit.wikimedia.org/r/508317 [13:42:52] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [13:44:11] (03Merged) 10jenkins-bot: Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [13:46:32] (03CR) 10jenkins-bot: Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [13:46:56] (03PS3) 10DmitriyShevliakov: Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/508120 [13:47:16] (03CR) 10Hashar: [C: 03+2] "Fails due to sqlite apparently:" [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [13:47:22] (03CR) 10Hashar: [C: 03+2] "recheck" [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [13:48:41] 10Hashtags: Event stream may not be being parsed in precise timestamp order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) Running the following script confirms that EventSource appears to parse the stream in almost whatever order it feels like: ` [13:48:48] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage mobile: conduct user testing of initial homepage mobile design and discoverability - https://phabricator.wikimedia.org/T222613 (10Cntlsn) [13:50:49] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [13:52:34] (03Merged) 10jenkins-bot: Add phan [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [13:53:10] 10Wikidata-Termbox-Iteration-15: Timebox dev unhappy path collection [2h] - https://phabricator.wikimedia.org/T220701 (10Tarrow) a:03Tarrow [13:53:35] (03CR) 10jenkins-bot: Add phan [extensions/ThrottleOverride] - 10https://gerrit.wikimedia.org/r/506881 (owner: 10Umherirrender) [13:54:41] 10MediaWiki-extensions-TEI: Make TEI HTML rendere emit Digital Publishing WAI-ARIA - https://phabricator.wikimedia.org/T221846 (10Tpt) Related guidelines: http://kb.daisy.org/publishing/docs/html/index.html [13:56:00] (03CR) 10BPirkle: "Sure, I'll take a closer look shortly" [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [13:58:19] 10MediaWiki-General-or-Unknown, 10PHP 7.1 support, 10PHP 7.2 support, 10Security: Remove uses of mcrypt from MediaWiki - https://phabricator.wikimedia.org/T210792 (10Krinkle) @Anomie Is there something here that should prevent WMF from rolling out PHP 7.2 to all users/servers given the current state of MW... [14:00:48] 10Hashtags: Event stream may not be being parsed in precise timestamp order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) Looking over a wider range of events starting from the 28th, EventSource appears to take a bunch of events between then and the 3rd May, before reverting back to the start and pr... [14:02:55] 10Gerrit-Privilege-Requests: Add abi to l10n-watchers group in Gerrit - https://phabricator.wikimedia.org/T222015 (10Nikerabbit) I am not sure I am allowed to do that per the new privilege policy. [14:04:20] 10Hashtags: Event stream may not be being parsed in precise timestamp order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) [14:05:32] 10Hashtags: Event stream may not be being parsed in precise timestamp order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) So I've traced this back to the EventStream itself - from the query at https://stream.wikimedia.org/v2/stream/recentchange?since=2019-04-28 it can be seen that a bunch of events... [14:06:23] (03PS4) 10Kghbln: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) [14:06:28] (03PS1) 10Pboehm: Fix IE Warnings attribut separation [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508325 [14:06:33] (03PS1) 10Pwirth: Add posibility to edit user image in preferences + various fixes. ERM:14912 [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/508326 [14:06:41] (03PS2) 10Pwirth: Add posibility to edit user image in preferences + various fixes. ERM:14912 [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/508326 [14:07:59] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-abi_, 10good first bug: Clearer checkbox meaning on Special:ManageMessageGroups - https://phabricator.wikimedia.org/T160606 (10abi_) Added the **import** button for source language also. This will import the changes, without marking translations... [14:09:01] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10I18n, 10Patch-For-Review, 10Performance: Add a {{USERLANGUAGE}}/{{USERLANG}} magic word - https://phabricator.wikimedia.org/T4085 (10Verdy_p) An we still lack the possibility of marking a specific page (with a margic syntax generating metadata, not... [14:09:02] (03PS5) 10Kghbln: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) [14:09:15] (03PS4) 10BPirkle: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) [14:10:25] 10Hashtags: Recentchanges EventStream is sending future data out of order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) [14:11:00] (03CR) 10Kghbln: "@DCausse Totally forgot this file. Not even sure if I was aware of it in the first place. O_o Anyways, done now!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [14:11:50] (03PS2) 10D3r1ck01: Resources: ResourceLoaderJqueryMsgModuleMagicWords hook removed [core] - 10https://gerrit.wikimedia.org/r/508317 [14:12:08] 10Hashtags: Recentchanges EventStream is sending historical data partially out of order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) [14:12:23] (03CR) 10D3r1ck01: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [14:12:56] 10Anti-Harassment, 10Wikimedia-Site-requests: Deploy partial blocks on Hungarian Wikipedia - https://phabricator.wikimedia.org/T222616 (10Bencemac) [14:13:00] 10Design, 10Cite, 10TCB-Team, 10WMDE-Design: Find a better way to highligth letters then bold - https://phabricator.wikimedia.org/T210281 (10Lea_WMDE) >>! In T210281#5142045, @Alsee wrote: > I was considering opening a discussion on EnWiki to remove the bolding from our backlinks, so the current feature wo... [14:13:59] 10CX-out-of-beta, 10Language-Team (Language-2019-April-June): Update grey interlanguage links entry point popup - https://phabricator.wikimedia.org/T217827 (10Pginer-WMF) [14:14:28] (03PS8) 10Daimona Eaytoy: Unbreak passByReference parameters handling [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506491 [14:14:41] (03PS5) 10Daimona Eaytoy: Make nodeIsString work again [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506864 [14:14:45] (03PS6) 10Daimona Eaytoy: Restore code bit for linking var to parentvar [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506866 [14:14:50] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip - https://phabricator.wikimedia.org/T216961 (10Jdrew... [14:14:50] (03PS7) 10Daimona Eaytoy: Transfer the taintedness from objects to props [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506869 [14:14:54] (03PS6) 10Daimona Eaytoy: Add checks for ClosureType [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506870 [14:14:58] (03PS4) 10Daimona Eaytoy: Fix global variable handling [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506906 [14:15:04] (03PS25) 10Daimona Eaytoy: Update integration tests [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506124 [14:15:11] (03PS6) 10Daimona Eaytoy: Set taintedness to NO_TAINT for class-string and callable-string [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506902 [14:15:17] (03PS5) 10Daimona Eaytoy: Take into account implicit BranchScopes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507015 [14:15:21] (03PS13) 10Daimona Eaytoy: Handle nested calls [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507065 [14:15:25] (03PS2) 10Daimona Eaytoy: Remove the EXEC bits from Message::rawParams' parameters [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508312 [14:15:31] (03PS11) 10Daimona Eaytoy: Add a file with base config [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507101 [14:15:35] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - https://phabricator.wikimedia.org/T181659 (10Theklan) [14:15:36] (03PS7) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [14:15:38] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - Tektonika - https://phabricator.wikimedia.org/T204058 (10Theklan) 05Open→03Resolved a:03Theklan Irakasleak ez ditu ondo baloratu ikasleek egindako lanak. Agian 3. mailan egokiago ikusten du horrelako zerbait egitea... [14:15:41] (03PS6) 10Daimona Eaytoy: Hack: exclude OOUI constructors from DoubleEscape reporting [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 [14:17:46] 10MediaWiki-Internationalization, 10Language-Team, 10Performance-Team, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 2 others: Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10Nikerabbit) Storing executable files in $wg... [14:17:51] (03PS6) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [14:18:20] (03PS1) 10Robert Vogel: Features buttons & User is not logged in [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 [14:18:54] (03CR) 10Robert Vogel: [C: 03+1] "Okay. Awainting L10N review." [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 (owner: 10Robert Vogel) [14:19:09] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [14:19:35] (03PS6) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [14:19:40] (03PS7) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [14:19:54] (03CR) 10Michael Große: [C: 03+2] Localisation updates from https://translatewiki.net. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [14:20:44] (03PS7) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [14:20:57] (03PS8) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [14:23:28] (03PS9) 10Daimona Eaytoy: Fix some FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [14:24:22] (03Abandoned) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 (owner: 10Daimona Eaytoy) [14:24:28] (03PS1) 10Pmiazga: Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508329 (https://phabricator.wikimedia.org/T222407) [14:25:49] (03PS10) 10Daimona Eaytoy: Fix some FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [14:25:51] (03PS5) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [14:27:18] (03PS6) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [14:27:20] (03PS8) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [14:27:24] (03PS7) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [14:27:29] (03PS7) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [14:27:34] (03PS8) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [14:27:38] (03PS7) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [14:27:42] (03PS5) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [14:27:46] (03PS11) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [14:27:50] (03PS5) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [14:29:29] (03CR) 10BPirkle: Force user id and actor id to 0 when loading from remote wikis (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [14:30:34] (03PS11) 10Daimona Eaytoy: Fix some FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [14:30:39] (03PS7) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [14:30:42] (03PS9) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [14:30:45] (03PS8) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [14:30:48] (03PS8) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [14:30:52] (03PS9) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [14:30:54] (03PS8) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [14:30:58] (03PS6) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [14:31:03] (03PS12) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [14:31:13] (03PS6) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [14:31:42] (03PS7) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [14:34:21] (03PS1) 10D3r1ck01: SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 [14:36:20] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508317 (owner: 10D3r1ck01) [14:41:13] (03CR) 10D3r1ck01: "@Thiemo, thank you and yeah, the improvement on this patch is not overly strong but was worth it right? :)" (031 comment) [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/505756 (owner: 10D3r1ck01) [14:48:08] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Test failure was:" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [14:51:28] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (032 comments) [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/508328 (owner: 10Robert Vogel) [14:52:04] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Tracking-Neverending: Pending global renames in need of sysadmin supervision (tracking) - https://phabricator.wikimedia.org/T169440 (101997kB) [14:52:35] (03CR) 10D3r1ck01: "@Thiemo, thanks a million for your review. The main reason for this change is for callers of this method for example;" [core] - 10https://gerrit.wikimedia.org/r/508117 (owner: 10D3r1ck01) [14:52:37] 10Discovery-Search (Current work): Capacity planning for elastic search - https://phabricator.wikimedia.org/T221121 (10Nuria) Excellent, can we document this findings on wikitech so they are easy to find? [14:53:13] 10MediaWiki-Core-Testing, 10Code-Health-Metrics, 10Epic: Split mediawiki tests into unit and integration tests - https://phabricator.wikimedia.org/T87781 (10zeljkofilipin) I do think this should be done, if that is your question. I'm not a PHP developer, so I would not be a lot of help. It's also hard for me... [14:55:41] 10MediaWiki-Core-Testing, 10Code-Health-Metrics, 10Epic: Split mediawiki tests into unit and integration tests - https://phabricator.wikimedia.org/T87781 (10TK-999) Yeah, that was my question, thanks! [14:56:24] (03CR) 10Daniel Kinzler: [C: 03+2] Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [14:58:03] 10Wikidata-Termbox-Iteration-15: Unable to remove last alias from entity - https://phabricator.wikimedia.org/T222624 (10Tarrow) [14:58:23] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Backlog (Next), 10PHP 7.2 support, 10Performance-Team (Radar): Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10Joe) So a couple things: - fatals now show up on logstash, via the php-fpm error log that we... [14:58:39] 10LDAP-Access-Requests: LDAP access to the nda group for sukhe - https://phabricator.wikimedia.org/T221990 (10MoritzMuehlenhoff) Move to cn=wmf, contractors with a wikimedia.org address should be part of cn=wmf, not cn=nda. [14:59:02] 10MediaWiki-Internationalization, 10MediaWiki-Parser, 10I18n, 10Patch-For-Review, 10Performance: Add a {{USERLANGUAGE}}/{{USERLANG}} magic word - https://phabricator.wikimedia.org/T4085 (10Verdy_p) I'm not convinced this is needed to parse the page, only to generate its content. But is this related to co... [15:01:15] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Ammarpad) [15:01:19] 10Anti-Harassment, 10Wikimedia-Site-requests: Deploy partial blocks on Hungarian Wikipedia - https://phabricator.wikimedia.org/T222616 (10Ammarpad) [15:02:09] 04(no projects): Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10NSaad) [15:02:46] (03PS66) 10Jforrester: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [15:04:24] 10Anti-Harassment: Deploy Partial Blocks to Telugu Wikipedia - https://phabricator.wikimedia.org/T222218 (10Niharika) [15:04:27] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Niharika) [15:05:28] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Niharika) [15:06:16] 10Anti-Harassment, 10Wikimedia-Site-requests: Deploy partial blocks on Hungarian Wikipedia - https://phabricator.wikimedia.org/T222616 (10Ammarpad) [15:07:17] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Gracefully handle remote logout and/or changing of credentials. - https://phabricator.wikimedia.org/T221889 (10Dbrant) a:03Dbrant [15:08:45] 10Discovery-Search (Current work): Capacity planning for elastic search - https://phabricator.wikimedia.org/T221121 (10EBernhardson) Did we also take into account codfw being smaller? If we recorded on 35 nodes in eqiad but only replayed from 30 nodes in codfw then we are replaying 86% of the actual traffic. Th... [15:11:56] 10MediaWiki-Authentication-and-authorization, 10Security, 10User-Ladsgroup: Turn logout link into a POST API call with refresh - https://phabricator.wikimedia.org/T222626 (10sbassett) [15:12:39] 10MediaWiki-Authentication-and-authorization, 10Security, 10User-Ladsgroup: Turn logout link into a POST API call with refresh - https://phabricator.wikimedia.org/T222626 (10sbassett) p:05Triage→03Normal [15:13:33] 10VisualEditor (Current work): Visual diffs not showing in mobile VE - https://phabricator.wikimedia.org/T222489 (10marcella) [15:14:08] 10TechCom, 10TechCom-RFC (TechCom-Approved): Establish Architecture Principles as a policy - https://phabricator.wikimedia.org/T220657 (10daniel) 05Open→03Resolved a:03daniel No further concerns were raised during the last call. This RFC, as amended per T220657#5147282, is now approved by TechCom, and b... [15:14:40] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:14:52] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Tracking-Neverending: Improve security for Special:Userlogin (tracking) - https://phabricator.wikimedia.org/T11816 (10sbassett) [15:14:58] 10Research: Isaac Reviews / Outreach work for May '19 - https://phabricator.wikimedia.org/T222175 (10Isaac) [15:15:00] 10MediaWiki-Authentication-and-authorization, 10Security, 10User-notice, 10Vuln-DoS: Use token when logging out - https://phabricator.wikimedia.org/T25227 (10sbassett) 05Open→03Resolved a:03sbassett @Framawiki, @Ladsgroup, @Reedy - split "Turn logout link into a POST API call with refresh" and moved... [15:16:39] 10MediaWiki-Authentication-and-authorization, 10Security, 10User-notice, 10Vuln-DoS: Use token when logging out - https://phabricator.wikimedia.org/T25227 (10Ladsgroup) Thanks! [15:17:37] 10MediaWiki-General-or-Unknown, 10MediaWiki-Stakeholders-Group: increasing abuse of installations of Mediawiki application - https://phabricator.wikimedia.org/T222536 (10Jdforrester-WMF) [15:20:16] (03CR) 10EBernhardson: [C: 03+2] "Thanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [15:21:10] (03Merged) 10jenkins-bot: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [15:22:15] (03PS4) 10Jdlrobson: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:22:28] 10VisualEditor (Current work): Abandon changes dialog is inconsistently shown after switching editors on mobile - https://phabricator.wikimedia.org/T222315 (10marcella) [15:23:15] 10Patch-For-Review, 10VisualEditor (Current work): Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10marcella) [15:23:36] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Reedy) >>! In T222527#5159218, @Ammarpad wrote: >>>! In T222527#5158368, @Reedy wrote: >> It should've been updated on the 1st... > > 1st May? June? I am afraid, this is... [15:24:05] (03CR) 10Jdlrobson: [C: 03+2] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:24:21] (03PS4) 10Brennen Bearnes: Add README and Dockerfile templates for base, php, and httpd images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) [15:24:42] 10Hashtags: Recentchanges EventStream is sending historical data partially out of order - https://phabricator.wikimedia.org/T222612 (10Ottomata) Yeah, that is what is happening: https://gist.github.com/ottomata/8d97edd19ef9e4a0383bc26c6c25aed7 Data from all sub-streams will be interleaved in an unpredictable w... [15:26:29] 10Accessibility, 10VisualEditor: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) [15:26:33] (03CR) 10Jforrester: "> Patch Set 3: Code-Review+2" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:28:06] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10Jdlrobson) Because of caching implications we... [15:28:33] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Introduction to using Shape Expressions to monitor and improve Wikidata items - https://phabricator.wikimedia.org/T219730 (10Andrawaag) [15:29:45] (03PS10) 10Jforrester: Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [15:29:54] 10Multi-Content-Revisions (Reactive): RevisionStore must not expose user IDs from a foreign wiki - https://phabricator.wikimedia.org/T222212 (10daniel) [15:30:02] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive), 10Patch-For-Review: Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) 05Open→03Resolved [15:30:07] 10Security-Team-Review-Active, 10Wikimedia-Planet: Do a security audit of *.planet.wikimedia.org - https://phabricator.wikimedia.org/T207246 (10sbassett) Re: privacy, the sites reference the standard [[ https://foundation.wikimedia.org/wiki/Privacy_policy | Wikimedia PP ]]. And while most resources seem to co... [15:30:14] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Introduction to using Shape Expressions to monitor and improve Wikidata items - https://phabricator.wikimedia.org/T219730 (10Reedy) [15:30:18] (03CR) 10Jforrester: [C: 03+2] "PS10: Manually rebase for RELEASE-NOTES-1.34. C+2 per Daniel." [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [15:30:47] 10MediaWiki-Release-Tools, 10Core Platform Team (Release Automation (TEC1)), 10Core Platform Team Kanban (Contractor - Ready), 10Epic: Ensure all repositories in Gerrit have been branched at the right time. - https://phabricator.wikimedia.org/T217963 (10MarkAHershberger) I have updated the docker instance... [15:30:50] (03PS11) 10Jforrester: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [15:32:17] 10VisualEditor (Current work): "Find" doesn't scroll the viewport - https://phabricator.wikimedia.org/T222247 (10marcella) Investigate as possible regression due to selection work. [15:32:35] 10Accessibility, 10VisualEditor: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) [15:32:41] (03CR) 10Krinkle: widgets: Create a PHP version of jquery.spinner (033 comments) [core] - 10https://gerrit.wikimedia.org/r/499450 (owner: 10Esanders) [15:33:14] 10MediaWiki-Release-Tools, 10Core Platform Team (Release Automation (TEC1)), 10Core Platform Team Kanban (Contractor - Ready), 10Epic: Produce and document interface for kicking off a branch and tarball production - https://phabricator.wikimedia.org/T217961 (10MarkAHershberger) Interface is likely to be at... [15:34:22] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdlrobson) >>! In T219895#5159492, @Jdrewniak wrote: > @alexhollender re: radio... [15:34:57] 10Wikidata-Termbox-Iteration-15: Timebox dev unhappy path collection [2h] - https://phabricator.wikimedia.org/T220701 (10Tarrow) New tickets created as children of the story. I think the priority should probably be: * lock save button from firing another save event until either clear success or failure (includi... [15:35:03] 10MediaWiki-Docker: mediawiki docker image for 1.32.1 is missing - https://phabricator.wikimedia.org/T222580 (10dbarratt) https://github.com/docker-library/official-images/pull/5856 [15:35:58] 10Wikidata-Termbox-Iteration-15: Timebox dev unhappy path collection [2h] - https://phabricator.wikimedia.org/T220701 (10Tarrow) I'd love some feedback. There is about 30mins of this timebox remaining given I spent some time chasing unrelated bugs. [15:36:17] 10MediaWiki-Release-Tools, 10Core Platform Team (Release Automation (TEC1)), 10Core Platform Team Kanban (Contractor - Ready), 10Epic: Test tarball extraction and verify diffs apply cleanly in Jenkins - https://phabricator.wikimedia.org/T217840 (10MarkAHershberger) I [[ https://github.com/hexmode/mw-releas... [15:37:56] (03CR) 10Daniel Kinzler: "Some nitpicks, but looks good otherwise." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) (owner: 10simetrical) [15:38:48] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10daniel) p:05Triage→03High Bumping to high, since this interferes with critical functionality a... [15:39:33] 10MediaWiki-Release-Tools, 10Core Platform Team (Release Automation (TEC1)), 10Core Platform Team Kanban (Contractor - Doing), 10Epic: Make release scripts initiatable via Jenkins - https://phabricator.wikimedia.org/T217839 (10MarkAHershberger) Since we won't be automating signing, this seems less importan... [15:41:54] 10MediaWiki-Watchlist, 10Growth-Team, 10Core Platform Team (Decoupling (CDP2)), 10Core Platform Team Kanban (Doing), and 2 others: Use UserIdentity in WatchedItem instead of User - https://phabricator.wikimedia.org/T207972 (10daniel) 05Open→03Resolved [15:42:26] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10User-abi_: Translate error - unable to save translations on metawiki in one page just marked for translation - https://phabricator.wikimedia.org/T221119 (10Nikerabbit) It's unclear what is the cause here. The symptoms are very cl... [15:42:35] (03PS3) 10Zfilipin: WIP Test that checks for user mention alerts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [15:43:46] 04(no projects): Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki - https://phabricator.wikimedia.org/T222628 (10Vort) [15:44:17] 10Accessibility, 10VisualEditor: Inserting language span tags breaks list formatting and therefore accessibility - https://phabricator.wikimedia.org/T221996 (10matmarex) (I couldn't reproduce either.) [15:44:28] (03CR) 10Jforrester: [C: 03+2] tests: Avoid namespace slashes in getNewTempFile() utility [core] - 10https://gerrit.wikimedia.org/r/508099 (owner: 10Krinkle) [15:45:27] (03Merged) 10jenkins-bot: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [15:45:28] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki - https://phabricator.wikimedia.org/T222628 (10Reedy) [15:46:02] 10International-Developer-Events, 10Wikimedia-Hackathon-2019, 10Wikimedia-Hackathon-2019-Organization, 10Developer-Advocacy (Apr-Jun 2019): Wikimedia Hackathon 2019 Mentoring Program - https://phabricator.wikimedia.org/T219498 (10Trizek-WMF) [15:46:11] 10MediaWiki-API, 10TextExtracts: API request for "extracts" on German Wikipedia Page is prefixed with "xx" - https://phabricator.wikimedia.org/T222619 (10Reedy) [15:46:23] (03CR) 10Daniel Kinzler: [C: 03+2] Update LinkCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/502455 (owner: 10simetrical) [15:47:10] 10VisualEditor (Current work): Create project page on MediaWiki - https://phabricator.wikimedia.org/T221867 (10marcella) [15:47:13] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:48:07] 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10Kghbln) 05Open→03Resolved a:03Kghbln [15:48:20] (03CR) 10Daniel Kinzler: [C: 03+2] Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 (owner: 10simetrical) [15:49:36] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki - https://phabricator.wikimedia.org/T222628 (10Daimona) `name=message Bad value for parameter $dbkey: should not be empty unless namespace is main and fragment is non-empty `... [15:50:19] 10CommRel-Specialists-Support (Apr-Jun-2019), 10Growth-Team (Current Sprint): Growth: develop relationship with a fourth wiki - https://phabricator.wikimedia.org/T214084 (10Trizek-WMF) I now have two contacts on Arabic Wikipedia. First meeting next week. [15:51:06] (03CR) 10Zfilipin: WIP Test that checks for user mention alerts (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [15:51:25] 10AbuseFilter: InvalidArgumentException when giving empty aflfilter in list=abuselog API - https://phabricator.wikimedia.org/T222531 (10Daimona) [15:51:35] 10AbuseFilter: InvalidArgumentException when giving empty aflfilter in list=abuselog API - https://phabricator.wikimedia.org/T222531 (10Daimona) [15:53:26] (03CR) 10Daniel Kinzler: "> Patch Set 11:" [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [15:54:14] 10CirrusSearch, 10Discovery-Search (Current work), 10Patch-For-Review: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10EBernhardson) [15:54:51] 10CommRel-Specialists-Support (Apr-Jun-2019), 10Growth-Team (Current Sprint): Wikimania Growth space at Wikimania 2019: find a volunteer co-leader - https://phabricator.wikimedia.org/T220988 (10Trizek-WMF) p:05High→03Normal Verena found someone. Meeting soon. [15:56:01] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Size improvements for Curation toolbar - https://phabricator.wikimedia.org/T207439 (10Niharika) @MusikAnimal Okay, let's go with changing the textarea to auto-resize to max 12 lines, like you said, for now.... [15:56:19] (03CR) 10jerkins-bot: [V: 04-1] Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [15:56:30] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Backlog (Next), 10PHP 7.2 support, 10Performance-Team (Radar): Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10Krinkle) >>! In T187147#5160223, @Joe wrote: > So a couple things: > > - fatals now show up... [15:56:37] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Size improvements for Curation toolbar - https://phabricator.wikimedia.org/T207439 (10Niharika) [15:57:31] (03PS2) 10D3r1ck01: SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 [15:57:35] (03CR) 10jerkins-bot: [V: 04-1] SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [15:58:08] (03CR) 10Etonkovidova: [C: 03+1] Test that checks for welcome notification [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494535 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [15:59:34] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, and 2 others: Page Curation toolbar: do not mark pages as 'reviewed' when adding CSD and PROD tags - https://phabricator.wikimedia.org/T208685 (10Niharika) This change will roll out to enwiki on May 9. [16:01:12] (03PS3) 10Jdlrobson: POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) [16:01:12] 10MediaWiki-extensions-CollaborationKit: CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed - https://phabricator.wikimedia.org/T214111 (10matmarex) [16:01:13] 10MediaWiki-extensions-CollaborationKit: CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed - https://phabricator.wikimedia.org/T214111 (10matmarex) [16:01:13] 10Hashtags: Recentchanges EventStream is sending historical data partially out of order - https://phabricator.wikimedia.org/T222612 (10Samwalton9) That makes a lot of sense - thanks for the explanation @Ottomata! [16:01:13] (03PS4) 10Jdlrobson: POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) [16:01:13] (03CR) 10jerkins-bot: [V: 04-1] POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) (owner: 10Jdlrobson) [16:01:14] (03CR) 10jerkins-bot: [V: 04-1] POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) (owner: 10Jdlrobson) [16:02:21] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Moved pages appear with the date of initial creation - https://phabricator.wikimedia.org/T38930 (10Niharika) [16:02:30] 10Discovery, 10Product-Analytics, 10Discovery-Analysis (Current work), 10Discovery-Search (Current work): Run analysis of WDQS internal and external traffic - https://phabricator.wikimedia.org/T179850 (10EBernhardson) [16:02:46] 10Discovery, 10Product-Analytics, 10Discovery-Analysis (Current work), 10Discovery-Search (Current work), 10Patch-For-Review: Analysis of testing on 18 wikis with > 1% of search traffic - https://phabricator.wikimedia.org/T176493 (10EBernhardson) [16:03:18] 10CirrusSearch, 10Discovery, 10Readers-Web-Backlog, 10Recommendation-API, and 4 others: CirrusSearch/includes/Elastica/PooledHttp.php:67 Timeout reached waiting for an available pooled curl connection! - https://phabricator.wikimedia.org/T170648 (10EBernhardson) [16:04:08] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10ovasileva) [16:04:14] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10ovasileva) p:05Triage→03Normal [16:04:29] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10ovasileva) [16:04:34] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - overflow menu - https://phabricator.wikimedia.org/T216418 (10ovasileva) [16:04:56] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - https://phabricator.wikimedia.org/T210655 (10ovasileva) [16:04:58] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Add wikidata item link to AMC overflow menu - https://phabricator.wikimedia.org/T222630 (10ovasileva) [16:05:31] (03CR) 10jerkins-bot: [V: 04-1] WIP Test that checks for user mention alerts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/507536 (https://phabricator.wikimedia.org/T217051) (owner: 10Ephemeralwaves) [16:05:39] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [16:07:12] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [16:07:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/508209 (owner: 10L10n-bot) [16:07:58] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Explore new ways to display content instead of showing placeholder images - https://phabricator.wikimedia.org/T218201 (10Sharvaniharan) a:03Sharvaniharan [16:13:49] 10German-Community-Wishlist-Main-Wishes: Gendered Categories (#3 2017) - https://phabricator.wikimedia.org/T222633 (10Lea_WMDE) [16:14:34] 10German-Community-Wishlist-Main-Wishes: Gendered Categories (#3 2017) - https://phabricator.wikimedia.org/T222633 (10Lea_WMDE) [16:14:50] (03CR) 10jerkins-bot: [V: 04-1] SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [16:17:24] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/508343 (owner: 10L10n-bot) [16:17:29] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/508344 (owner: 10L10n-bot) [16:18:26] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Cntlsn) Hello @Urbanecm, I would have a quick request for feedback about the mobile design for the newcomer homepage. As... [16:18:32] 10Discovery-Search (Current work): Capacity planning for elastic search - https://phabricator.wikimedia.org/T221121 (10Gehel) >>! In T221121#5160286, @EBernhardson wrote: > Did we also take into account codfw being smaller? If we recorded on 35 nodes in eqiad but only replayed from 30 nodes in codfw then we are... [16:19:31] 10Confirmation prompt for rollback action: Selenium failures for rollback with confirmation - https://phabricator.wikimedia.org/T222634 (10D3r1ck01) [16:20:16] 10Confirmation prompt for rollback action: Selenium failures for rollback with confirmation - https://phabricator.wikimedia.org/T222634 (10D3r1ck01) [16:20:18] 10Discovery-Search (Current work): Capacity planning for elastic search - https://phabricator.wikimedia.org/T221121 (10Gehel) >>! In T221121#5160176, @Nuria wrote: > Excellent, can we document this findings on wikitech so they are easy to find? Sure, I can copy the summary somewhere. Is it really easier to fin... [16:20:55] 10Confirmation prompt for rollback action: Selenium failures for rollback with confirmation - https://phabricator.wikimedia.org/T222634 (10D3r1ck01) [16:22:46] (03Merged) 10jenkins-bot: tests: Avoid namespace slashes in getNewTempFile() utility [core] - 10https://gerrit.wikimedia.org/r/508099 (owner: 10Krinkle) [16:22:51] (03CR) 10jerkins-bot: [V: 04-1] SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [16:23:50] 10Confirmation prompt for rollback action: Selenium failures for rollback with confirmation - https://phabricator.wikimedia.org/T222634 (10D3r1ck01) [16:24:09] (03CR) 10jenkins-bot: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [16:24:48] 10MediaWiki-extensions-CollaborationKit: CollaborationHub and List edit tabs should not say 'Edit source' when VE is installed - https://phabricator.wikimedia.org/T214111 (10Isarra) Given that this is caused specifically by VE, and is not an issue without VE, and cannot be resolved in CK because VE prevents it,... [16:25:27] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Ladsgroup) >>! In T222224#5156628, @Tgr wrote: > Yeah, sorry, WhatLinksHere is the other direction, this would affect the `links` / `images` / `templates` / `categories` APIs (and probably index.php's... [16:26:13] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Ladsgroup) [16:26:18] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Anomie) >>! In T221177#5158558, @Tgr wrote: > and a sufficiently motivated developer can always invoke code that's in a... [16:26:26] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate and remove support for 'object' key in wgResourceModules - https://phabricator.wikimedia.org/T222637 (10Krinkle) [16:26:40] (03CR) 10jerkins-bot: [V: 04-1] SearchEngine: Hard-deprecate PrefixSearch::titleSearch() [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [16:26:44] 10Confirmation prompt for rollback action: Selenium failures for rollback with confirmation - https://phabricator.wikimedia.org/T222634 (10D3r1ck01) p:05Triage→03Unbreak! This seems to be blocking merges and tests fail too for core and extensions? [16:28:10] 10MediaWiki-General-or-Unknown, 10ObjectFactory, 10Performance-Team (Radar): Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Krinkle) [16:32:39] (03CR) 10jenkins-bot: tests: Avoid namespace slashes in getNewTempFile() utility [core] - 10https://gerrit.wikimedia.org/r/508099 (owner: 10Krinkle) [16:33:10] (03CR) 10jenkins-bot: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [16:35:09] 10Discovery-Search, 10Epic: [Epic] Search platform - Hardware requests for 2019-2020 - https://phabricator.wikimedia.org/T221630 (10Gehel) [16:35:48] 10MediaWiki-API, 10TextExtracts: API request for "extracts" on specific German Wikipedia Page is prefixed with "xx\n" - https://phabricator.wikimedia.org/T222619 (10Aklapper) [16:36:30] 10Product-Analytics, 10Discovery-Analysis (Current work), 10Research ideas: descriptive metric: traffic distribution - https://phabricator.wikimedia.org/T190174 (10JKatzWMF) [16:37:52] 10MediaWiki-User-management, 10Anti-Harassment: Enable Partial Blocks on Japanese wikipedia - https://phabricator.wikimedia.org/T222640 (10Niharika) p:05Triage→03Normal [16:38:26] 10Security-Team-Review-Active: Security review - Wikibase Termbox Front End - https://phabricator.wikimedia.org/T216419 (10sbassett) @WMDE-leszek - I just wanted to check in and see if you or anyone else had any questions re: my responses above and if we have a better sense around the deployment timeline for thi... [16:39:58] 10MediaWiki-API, 10TextExtracts: API request for "extracts" on specific German Wikipedia Page is prefixed with "xx\n" - https://phabricator.wikimedia.org/T222619 (10Aklapper) 05Open→03Invalid > The actual article page doesn't seem to have any "xx" It has, so this is correct behavior. See the HTML source o... [16:41:48] 10Design, 10Community-Relations: Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10Aklapper) @NSaad: This seems to be a request for #Community-Relations hence adding project tag. (Please associate at least one project tag with tasks. This will allow others... [16:41:54] (03CR) 10Huji: [C: 03+1] "This looks like a reasonable refactoring of code to me. However, in what way does it fix the problem mentioned in T218511? I.e. I cannot s" [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) (owner: 10Aaron Schulz) [16:43:33] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Regression, 10Wikimedia-production-error: Cannot create some new pages on Wiktionary: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Aklapper) [16:43:47] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Regression, 10Wikimedia-production-error: Cannot create some new pages on Wiktionary: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Aklapper) [16:43:51] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Aklapper) [16:45:32] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222628 (10Aklapper) [16:45:49] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Internal error: "Wikimedia\Assert\ParameterAssertionException" in ruwiki: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222628 (10Aklapper) p:05Triage→03High [16:46:37] 10MediaWiki-extensions-Translate, 10User-abi_: "Link to this message" in Special:Translate can produce a link with wrong language code - https://phabricator.wikimedia.org/T222588 (10abi_) [16:47:34] Urbanecm: I just heard that it's planned for the 11am PDT SWAT window (in an hour and change) [16:47:46] thanks RoanKattouw [16:48:10] okay, I see it now, great :) [16:48:25] (03Merged) 10jenkins-bot: Update LinkCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/502455 (owner: 10simetrical) [16:48:27] (03CR) 10jerkins-bot: [V: 04-1] Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 (owner: 10simetrical) [16:49:01] 10MediaWiki-Internationalization, 10Language-Team, 10Performance-Team, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 2 others: Use disk-based LCStore by default in MediaWiki 1.34 - https://phabricator.wikimedia.org/T218207 (10Krinkle) >>! In T218207#5160048, @Nikerabbi... [16:53:06] 10MediaWiki-Installer, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MW-1.32-release, and 3 others: MediaWiki web installer do not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10Krinkle) [16:53:26] 10MediaWiki-Installer, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MW-1.32-release, and 2 others: MediaWiki web installer do not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10Krinkle) [16:53:36] 10MediaWiki-Installer, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MW-1.33-release, and 2 others: MediaWiki web installer do not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10Krinkle) [16:53:52] 10MediaWiki-Installer, 10Continuous-Integration-Infrastructure, 10Release-Engineering-Team, 10MW-1.33-release, 10Patch-For-Review: MediaWiki web installer do not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10Krinkle) [16:54:41] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10Mooeypoo) a:05Mooeypoo→03None The 'prevents' method is dealt with and had an email sent to wikitech-l. The "edit" right is now in `appliesToRight`, and should be d... [16:54:58] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::appliesToRight() - https://phabricator.wikimedia.org/T209002 (10Mooeypoo) [16:55:40] (03CR) 10jenkins-bot: Update LinkCache to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/502455 (owner: 10simetrical) [16:56:35] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary when creating page with uppercase letter and lowercase version exists - https://phabricator.wikimedia.org/T222529 (10Aklapper) [17:01:04] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10Dzahn) @Aklapper @mmodell The request has been app... [17:02:02] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10mmodell) @dzahn: it has a bunch of parameters :-/ [17:02:10] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Ammarpad) [17:02:13] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10Dzahn) a:03Aklapper Puppet ran on phab1001. If y... [17:02:40] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10mmodell) see T221112#5121800 [17:03:34] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10Dzahn) >>! In T221112#5160984, @mmodell wrote: > @... [17:03:50] 10MediaWiki-Installer, 10Continuous-Integration-Infrastructure, 10MW-1.33-release, 10Patch-For-Review: MediaWiki web installer do not show extension when their dependency is missing - https://phabricator.wikimedia.org/T220514 (10greg) [17:04:03] 10MediaWiki-Internationalization, 10MediaWiki-Search, 10Discovery-Search (Current work), 10I18n: Redirect in the search box for Arabic projects - https://phabricator.wikimedia.org/T117217 (10TJones) [17:05:17] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Ammarpad) [17:05:55] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10Jdlrobson) a:03pmiazga [17:06:16] 10Discovery-Search (Current work): Create archive indices and delete archive docs from general indices - https://phabricator.wikimedia.org/T222641 (10EBernhardson) [17:07:06] 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Post-inheritance cleanup - https://phabricator.wikimedia.org/T217220 (10Jdlrobson) a:03phuedx [17:08:11] 10Discovery-Search (Current work): Create archive indices and delete archive docs from general indices - https://phabricator.wikimedia.org/T222641 (10EBernhardson) Tested creating the archive index for testwiki, seems to have gone well. Unfortunately using the `forceSearchIndex.php` script is causing job runners... [17:13:00] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Urbanecm) Hi @Cntlsn, I think that's perfect! Thanks for sharing it with me! [17:16:33] 10VisualEditor (Current work): Visual diffs not showing in mobile VE - https://phabricator.wikimedia.org/T222489 (10matmarex) I can't reproduce on this page, but I ran into an exception when testing an unrelated thing on desktop: > TypeError: Failed to execute 'appendChild' on 'Node': parameter 1 is not of type... [17:18:49] 10VisualEditor (Current work): Visual diffs not showing in mobile VE - https://phabricator.wikimedia.org/T222489 (10matmarex) The section editing A/B test is still running, right? Maybe that's why we get different results. [17:18:54] (03CR) 10Niedzielski: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506129 (https://phabricator.wikimedia.org/T217814) (owner: 10Jdlrobson) [17:18:59] (03CR) 10Frankiebot: "This patch has dependencies. Please ask me again when it doesn't." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506129 (https://phabricator.wikimedia.org/T217814) (owner: 10Jdlrobson) [17:19:21] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [17:21:18] 10Security-Team-Review-Active: Security review - Wikibase Termbox Front End - https://phabricator.wikimedia.org/T216419 (10WMDE-leszek) Thanks a lot @sbassett, I was in the middle of writing the answer, when your comment popped in :) Thanks for the review. I find the idea of different framing of reviews, and ta... [17:21:49] (03PS7) 10Krinkle: tests: Use standard utilities for temporary file names [core] - 10https://gerrit.wikimedia.org/r/508096 [17:22:08] (03PS7) 10Krinkle: tests: Remove use of wfRandomString() for test fixtures [core] - 10https://gerrit.wikimedia.org/r/508097 [17:22:41] 10Wikimedia-Hackathon-2019, 10Developer-Advocacy (Apr-Jun 2019): Introduction to Phabricator - https://phabricator.wikimedia.org/T216261 (10Aklapper) >>! In T216261#5149301, @Rfarrand wrote: > @Aklapper Klara requested it Saturday so the group of Czech folks who will only be there foe Saturday can join. For t... [17:22:47] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary when creating page with uppercase letter and lowercase version exists - https://phabricator.wikimedia.org/T222529 (10BPirkle) a:03BPirkle I'll... [17:23:11] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException when rendering a log snippet and log_user_text is empty - https://phabricator.wikimedia.org/T222529 (10Tgr) a:05BPirkle→03None [17:23:32] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Patch-For-Review, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException when rendering a log snippet and log_user_text is empty - https://phabricator.wikimedia.org/T222529 (10Tgr) a:03BPirkle [17:27:07] (03CR) 10Isarra: [C: 03+1] "As far as I can tell this makes sense according to the other ones. And I'd certainly like to have this option in general..." [core] - 10https://gerrit.wikimedia.org/r/508069 (owner: 10Jack Phoenix) [17:30:12] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [17:30:20] (03Abandoned) 10Ladsgroup: Convert delete form to OOUI [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/330665 (https://phabricator.wikimedia.org/T153988) (owner: 10Ladsgroup) [17:30:36] 10VisualEditor (Current work): Visual diffs not showing in mobile VE - https://phabricator.wikimedia.org/T222489 (10matmarex) a:03matmarex [17:31:18] (03CR) 10Jforrester: "We shouldn't be adding jsonlint to any new repos, per my declaration at T220036. ;-)" [event-schemas] - 10https://gerrit.wikimedia.org/r/408742 (https://phabricator.wikimedia.org/T124319) (owner: 10Legoktm) [17:31:57] 10Wikimedia-General-or-Unknown: Drop use of the npm jsonlint module from all Wikimedia production repos - https://phabricator.wikimedia.org/T214772 (10Jdforrester-WMF) [17:32:17] 10Wikimedia-General-or-Unknown: Drop use of the npm jsonlint module from all Wikimedia production repos - https://phabricator.wikimedia.org/T214772 (10Jdforrester-WMF) Totally forgot about this when I made the dupe, but that's more developed so let's keep that one. [17:34:41] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) >>! In T221177#5160802, @Anomie wrote: > I am saying to avoid making it //easy// to do the wrong thing. AIUI we... [17:35:32] (03CR) 10Krinkle: Improve Community Main Menu element handling (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506842 (https://phabricator.wikimedia.org/T216152) (owner: 10Pmiazga) [17:41:52] 10MediaWiki-extensions-Linter, 10Parsoid-Linter: fostered should ignore tags - https://phabricator.wikimedia.org/T222643 (10Dvorapa) [17:42:10] 10Internet-Archive, 10Research: Hebrew Wikipedia data from citations with identifiers is empty - https://phabricator.wikimedia.org/T213873 (10bmansurov) a:03bmansurov [17:42:24] 10Patch-For-Review, 10VisualEditor (Current work): Visual diffs not showing in mobile VE (when visual section editing is disabled) - https://phabricator.wikimedia.org/T222489 (10matmarex) [17:43:03] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - add new links to main menu with click tracking - https://phabricator.wikimedia.org/T216152 (10Krinkle) >>! In T216152#5127810, @a... [17:45:36] (03CR) 10Jforrester: [C: 03+2] tests: Use standard utilities for temporary file names [core] - 10https://gerrit.wikimedia.org/r/508096 (owner: 10Krinkle) [17:46:15] (03CR) 10Jforrester: [C: 03+2] tests: Remove use of wfRandomString() for test fixtures [core] - 10https://gerrit.wikimedia.org/r/508097 (owner: 10Krinkle) [17:47:00] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508331 (owner: 10D3r1ck01) [17:47:48] (03CR) 10Krinkle: [C: 03+1] Consolidate duplicated unseen change logic and fix inconsistent code [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) (owner: 10Aaron Schulz) [17:47:55] 10InternetArchiveBot (v2.0): IABot 2.0beta14 removes intentional   from link title - https://phabricator.wikimedia.org/T222644 (10Cirdan) a:03Cyberpower678 [17:49:08] 10Internet-Archive, 10Research: Hebrew Wikipedia data from citations with identifiers is empty - https://phabricator.wikimedia.org/T213873 (10bmansurov) p:05Low→03Normal [17:49:53] RoanKattouw: https://phabricator.wikimedia.org/T218511 is currently marked External, but not on another team's workboard. Should it be? [17:50:08] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10Dbrant) [17:50:47] (03CR) 10Krinkle: [C: 04-1] "ping" [core] - 10https://gerrit.wikimedia.org/r/498984 (https://phabricator.wikimedia.org/T208539) (owner: 10Umherirrender) [17:51:08] Krinkle: It was probably meant to be on the perf board I guess [17:52:13] On the theory that this is fallout / a regression from Aaron's WatchedItemStorelast-seen patches [17:55:02] (03CR) 10Jeena Huneidi: [C: 03+2] "Just noting that images aren't being built yet." [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [17:56:20] (03PS7) 10EBernhardson: Allow per-cluster CirrusSearchMaxShardsPerCluster [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 [17:56:22] (03PS1) 10EBernhardson: Ignore ancient logging rows with log_page = null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) [17:57:55] (03Abandoned) 10Legoktm: Add jsonlint test to verify avro schemas are valid JSON [event-schemas] - 10https://gerrit.wikimedia.org/r/408742 (https://phabricator.wikimedia.org/T124319) (owner: 10Legoktm) [17:58:23] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Context menu (long press) has extremely light grey text with the dark and black themes - https://phabricator.wikimedia.org/T220218 (10Nicholas.tsg) @ABorbaWMF @Charlotte Testing on Wikipedia app 2.7.280-beta-2019-05-01, using this tablet: {F... [17:59:12] (03CR) 10Brennen Bearnes: [V: 03+2] Add README and Dockerfile templates for base, php, and httpd images [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [17:59:21] 10MediaWiki-Page-deletion, 10MediaWiki-Special-pages, 10User-Daimona, 10User-revi, 10Wikimedia-production-error: Unhandled internal error from page deletion during Special:MovePage (Fatal MWException) - https://phabricator.wikimedia.org/T217136 (10Krinkle) @EvanProdromou Does that mean CPT will fix soon... [18:01:17] RoanKattouw: thx, makes sense. Patch is up, but would it be okay for you(r team) to review (as with the original patch). [18:01:43] 10MediaWiki-Watchlist, 10Growth-Team, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 2 others: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Krinkle) [18:01:44] Krinkle: Thanks, will review after SWAT [18:02:01] (03CR) 10Catrope: [C: 03+2] Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508329 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [18:02:53] (03Merged) 10jenkins-bot: tests: Use standard utilities for temporary file names [core] - 10https://gerrit.wikimedia.org/r/508096 (owner: 10Krinkle) [18:04:28] (03Merged) 10jenkins-bot: tests: Remove use of wfRandomString() for test fixtures [core] - 10https://gerrit.wikimedia.org/r/508097 (owner: 10Krinkle) [18:04:56] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team: Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Catrope) For some reason, this partic... [18:06:14] (03CR) 10C. Scott Ananian: "> Is there a related bug in Parsoid? It looks expensive." [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 (owner: 10C. Scott Ananian) [18:08:05] (03CR) 10Krinkle: Add README and Dockerfile templates for base, php, and httpd images (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [18:08:43] 10Phabricator, 10Operations, 10Project-Admins, 10SRE-Access-Requests, and 2 others: Document how to convert projects into subprojects/milestones etc (sudo privileges for phab admins to run move_project script) - https://phabricator.wikimedia.org/T221112 (10Dzahn) >>! In T221112#5160991, @Dzahn wrote: >>>!... [18:09:09] (03CR) 10jenkins-bot: tests: Use standard utilities for temporary file names [core] - 10https://gerrit.wikimedia.org/r/508096 (owner: 10Krinkle) [18:09:26] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [18:09:27] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Improve article recommendation pipeline - https://phabricator.wikimedia.org/T218971 (10Usmanmuhd) Thanks a lot for selecting me! Looking forward to working on it. [18:11:06] (03CR) 10Brennen Bearnes: Add README and Dockerfile templates for base, php, and httpd images (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [18:11:56] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate and remove support for 'object' key in wgResourceModules - https://phabricator.wikimedia.org/T222637 (10Krinkle) [18:12:11] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate and remove support for 'object' key in wgResourceModules - https://phabricator.wikimedia.org/T222637 (10Krinkle) [18:13:25] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Developer-Wishlist (Next), 10Mobile: Logging out on a different device logs me out everywhere else - https://phabricator.wikimedia.org/T51890 (10Jdforrester-WMF) Agreed. [18:13:40] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Developer-Wishlist (Next), 10Mobile: Logging out on a different device logs me out everywhere else - https://phabricator.wikimedia.org/T51890 (10Jdforrester-WMF) [18:13:43] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Allow per-session log out - https://phabricator.wikimedia.org/T37220 (10Jdforrester-WMF) [18:14:09] (03CR) 10Krinkle: Introduce alphabetic pager for Special:EditWatchlist (032 comments) [core] - 10https://gerrit.wikimedia.org/r/505784 (https://phabricator.wikimedia.org/T220245) (owner: 10Kosta Harlan) [18:14:38] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team: Help panel: enable feedback on Help Desk responses - https://phabricator.wikimedia.org/T209332 (10MMiller_WMF) [18:15:00] (03PS1) 10EBernhardson: Remove Updater::archivePages $forceIndex parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 [18:15:18] 10MediaWiki-Database, 10WMF-JobQueue, 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error" - https://phabricator.wikimedia.org/T218692 (10Krinkle) Thanks @mobrovac, so next step here... [18:15:25] 10MediaWiki-Database, 10Performance-Team, 10WMF-JobQueue, 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error" - https://phabricator.wikimedia.org/T218692 (10Krinkle) [18:16:13] 10MediaWiki-Database, 10Performance-Team, 10WMF-JobQueue, 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error" - https://phabricator.wikimedia.org/T218692 (10Krinkle) The underlying... [18:17:45] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 3 others: Some ApiQueryImageInfo queries consistently fail with a fatal BadMethodCallException from LocalFile.php - https://phabricator.wikimedia.org/T221812 (10Krinkle) [18:17:48] (03PS1) 10Hashar: Commit #1 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/508376 [18:17:51] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [18:17:53] (03PS1) 10Zoranzoki21: Add space between quotes in bs-notifications-web-move-body message [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/508377 [18:17:58] 10Developer Productivity, 10dev-images, 10local-charts: Fully support Xdebug in dev-images PHP image(s) and local-charts - https://phabricator.wikimedia.org/T222647 (10brennen) [18:18:15] 10MediaWiki-extensions-ORES, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Fix oresBaseUrl config variable in frontend - https://phabricator.wikimedia.org/T219396 (10Ladsgroup) 05Open→03Resolved [18:18:16] (03PS2) 10Zoranzoki21: Add space between quotes in bs-notifications-web-move-body message [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/508377 [18:18:43] 10Developer Productivity, 10dev-images, 10local-charts: Fully support Xdebug in dev-images PHP image(s) and local-charts - https://phabricator.wikimedia.org/T222647 (10brennen) [18:19:30] (03CR) 10jenkins-bot: tests: Remove use of wfRandomString() for test fixtures [core] - 10https://gerrit.wikimedia.org/r/508097 (owner: 10Krinkle) [18:22:15] 10MediaWiki-extensions-Cargo: URLs are shown as strings (i.e., not linked) in tables - https://phabricator.wikimedia.org/T222649 (10Tombolano) [18:22:40] 10MediaWiki-extensions-Other, 10phan-taint-check-plugin: phan-taint-check false positive in Sudo extension - https://phabricator.wikimedia.org/T203882 (10Daimona) Well, I think the EXEC bits should be removed from Linker::link params, as nothing is output therein. Something similar happened for Message::rawPar... [18:25:24] (03Merged) 10jenkins-bot: Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508329 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [18:27:00] (03PS1) 10Hashar: Commit #2 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/508380 [18:27:53] 10MediaWiki-General-or-Unknown, 10MediaWiki-Stakeholders-Group: increasing abuse of installations of Mediawiki application - https://phabricator.wikimedia.org/T222536 (10CCicalese_WMF) Sorry for the delay in responding; I've been traveling. This does seem to be a good topic for the MediaWiki Stakeholders' Grou... [18:28:52] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Context menu (long press) has extremely light grey text with the dark and black themes - https://phabricator.wikimedia.org/T220218 (10ABorbaWMF) Looks good on 2.7.280-beta-2019-05-01 [18:29:25] (03CR) 10jenkins-bot: Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/508329 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [18:32:59] (03PS1) 10Hashar: Commit #3 [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/508381 [18:35:17] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Anomie) >>! In T221177#5161079, @Tgr wrote: > AIUI we want to do that by discouraging people from using `MediaWikiServi... [18:36:11] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 (owner: 10EBernhardson) [18:36:15] 10Growth-Team (Current Sprint): Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10MMiller_WMF) Thanks @Urbanecm. @Etonkovidova also suggested a tooltip on T222405. @Cntlsn -- do you think we should go ahead and just add a tooltip now, a... [18:37:10] 10MediaWiki-Vagrant, 10ContentTranslation, 10Patch-For-Review, 10User-abi_: ContentTranslation role broken in vagrant - https://phabricator.wikimedia.org/T222317 (10Nikerabbit) Was VE added as dependency for CX role? How did you do it? [18:39:47] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10User-abi_: Translate error - unable to save translations on metawiki in one page just marked for translation - https://phabricator.wikimedia.org/T221119 (10Urbanecm) @Trijnstel @Zppix @Wladek92 +1 and similar comments don't help.... [18:40:06] 10Wikimedia-Hackathon-2019: Create a way to easily import freely-licensed images from iNaturalist to Commons - https://phabricator.wikimedia.org/T222650 (10kaldari) [18:40:30] 10Wikimedia-Hackathon-2019: Create a way to easily import freely-licensed images from iNaturalist to Commons - https://phabricator.wikimedia.org/T222650 (10kaldari) [18:41:37] 10Wikimedia-Site-requests, 10Patch-For-Review: Add static.inaturalist.org to $wgCopyUploadsDomains for Commons - https://phabricator.wikimedia.org/T221154 (10kaldari) 05Open→03Resolved a:03kaldari [18:42:05] 10Wikimedia-Site-requests, 10Patch-For-Review: Add static.inaturalist.org to $wgCopyUploadsDomains for Commons - https://phabricator.wikimedia.org/T221154 (10kaldari) [18:42:08] 10Wikimedia-Hackathon-2019: Create a way to easily import freely-licensed images from iNaturalist to Commons - https://phabricator.wikimedia.org/T222650 (10kaldari) [18:44:23] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [18:45:25] (03CR) 10DCausse: [C: 03+2] Allow per-cluster CirrusSearchMaxShardsPerCluster [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [18:45:42] (03CR) 10DCausse: [C: 03+2] Ignore ancient logging rows with log_page = null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [18:46:39] (03CR) 10DCausse: [C: 03+2] Remove Updater::archivePages $forceIndex parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 (owner: 10EBernhardson) [18:49:35] (03CR) 10Daniel Kinzler: [C: 03+2] "*poke*" [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [18:51:14] 10CirrusSearch, 10Discovery-Search: Create a fallback method based on a generic index - https://phabricator.wikimedia.org/T222652 (10dcausse) [18:51:38] 10CirrusSearch, 10Discovery-Search (Current work): Create a fallback method based on a generic index - https://phabricator.wikimedia.org/T222652 (10dcausse) p:05Triage→03Normal [18:52:32] (03PS1) 10DCausse: Prevent multilpe queries from running consecutively... [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 [18:52:34] (03PS1) 10DCausse: Add a new fallback method based on a simple index lookup [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) [18:54:09] (03PS1) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [18:54:36] (03CR) 10Daniel Kinzler: [C: 04-1] "Should be updated to use ServiceOptions" [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [18:55:36] (03CR) 10Daniel Kinzler: [C: 04-1] "> Should be updated to use ServiceOptions" [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [18:55:38] 10InternetArchiveBot: The archive url doesn't show the required page - https://phabricator.wikimedia.org/T222532 (10Cirdan) 05Open→03Resolved a:05Cyberpower678→03Cirdan I removed the archive [[https://tools.wmflabs.org/iabot/index.php?page=manageurlsingle|using the management interface]]. You can also do... [18:55:48] (03CR) 10Daniel Kinzler: Don't pass Config to Parser(Factory) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [18:58:10] 10Google-Summer-of-Code (2019): Proposal: Improve the interface of Special:ViewData in the Cargo extension - https://phabricator.wikimedia.org/T218353 (10Prosper) Reading your proposal again. And i really must say, you are the right man for this project's success. I really wish you the best as you begin work soo... [18:58:49] 10InternetArchiveBot: IABot inserts "Archived copy" instead of actual title - https://phabricator.wikimedia.org/T222340 (10Cirdan) 05Open→03Invalid The bot inserts a generic title if there was no link text on the external link. This is intended, as [[https://en.wikipedia.org/wiki/Template:Cite_web|`title` is... [19:00:13] 10InternetArchiveBot: The arhive url dosn't show the requiered page - https://phabricator.wikimedia.org/T222055 (10Cirdan) [19:00:18] 10InternetArchiveBot: The archive url doesn't show the required page - https://phabricator.wikimedia.org/T222532 (10Cirdan) [19:00:52] (03CR) 10Daniel Kinzler: "Needs more tests, looks good otherwise." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [19:01:56] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Switch Hogan for Mustache - https://phabricator.wikimedia.org/T220620 (10alexhollender) Apologies for the delay her... [19:02:07] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Switch Hogan for Mustache - https://phabricator.wikimedia.org/T220620 (10alexhollender) [19:02:43] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508384 (https://phabricator.wikimedia.org/T222652) (owner: 10DCausse) [19:04:39] (03CR) 10MusikAnimal: "This change is ready for review." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507455 (https://phabricator.wikimedia.org/T207439) (owner: 10MusikAnimal) [19:05:15] 10InternetArchiveBot: want to undo false positive report - https://phabricator.wikimedia.org/T222528 (10Cirdan) 05Open→03Resolved a:05Cyberpower678→03Cirdan [[https://tools.wmflabs.org/iabot/index.php?page=manageurlsingle&url=http%3A%2F%2Fwww.milforddailynews.com%2Fopinion%2Fx1987843539|the management in... [19:05:37] 10MediaWiki-Cache, 10Operations, 10Patch-For-Review, 10Performance-Team (Radar), and 2 others: Mcrouter periodically reports soft TKOs for mc1029 (was mc1035, mc1022) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10aaron) a:05aaron→03None [19:06:00] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:06:04] (03CR) 10Jforrester: "When a patch gets stuck in the C+2 abyss, you don't need to remove your own C+2 to re-trigger, just post a comment (I traditionally use '…" [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [19:09:29] (03Merged) 10jenkins-bot: Allow per-cluster CirrusSearchMaxShardsPerCluster [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [19:10:57] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508383 (owner: 10DCausse) [19:13:32] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Size improvements for Curation toolbar - https://phabricator.wikimedia.org/T207439 (10MusikAnimal) > let's go with changing the textarea to auto-resize to max 12 lines, like you said, for now. Based on what... [19:18:46] (03CR) 10jerkins-bot: [V: 04-1] Ignore ancient logging rows with log_page = null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [19:18:48] (03CR) 10jerkins-bot: [V: 04-1] Remove Updater::archivePages $forceIndex parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 (owner: 10EBernhardson) [19:19:29] 10Product-Analytics: Formalize the concept of countable wikis - https://phabricator.wikimedia.org/T222655 (10Neil_P._Quinn_WMF) [19:23:53] (03CR) 10jenkins-bot: Allow per-cluster CirrusSearchMaxShardsPerCluster [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [19:26:30] (03CR) 10Catrope: [C: 03+2] Consolidate duplicated unseen change logic and fix inconsistent code [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) (owner: 10Aaron Schulz) [19:27:34] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Volker_E) @alexhollender I'm also wondering if there should be a `max-width` fo... [19:30:24] (03CR) 10Catrope: [C: 04-2] "Change 1c7c9bd did not remove this hook, it only moved it. It removed the class that the hook is named for, but renaming hooks is disrupti" [core] - 10https://gerrit.wikimedia.org/r/508317 (owner: 10D3r1ck01) [19:31:05] (03PS2) 10MusikAnimal: Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) [19:32:10] (03CR) 10D3r1ck01: "Thank you very much for your review Catrope. I got it!" [core] - 10https://gerrit.wikimedia.org/r/508317 (owner: 10D3r1ck01) [19:34:17] (03Merged) 10jenkins-bot: Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [19:34:17] (03Merged) 10jenkins-bot: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [19:34:23] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Apr-Jun 2019), 10Documentation, and 2 others: Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Jayprakash12345) a:03Jayprakash12345 I am sel... [19:34:25] (03Abandoned) 10D3r1ck01: Resources: ResourceLoaderJqueryMsgModuleMagicWords hook removed [core] - 10https://gerrit.wikimedia.org/r/508317 (owner: 10D3r1ck01) [19:40:45] (03CR) 10jenkins-bot: Move Title::getSubject/Talk/OtherPage to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [19:41:48] (03PS4) 10Esanders: Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 [19:42:13] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [19:43:09] (03CR) 10Aaron Schulz: "check php" [core] - 10https://gerrit.wikimedia.org/r/497537 (https://phabricator.wikimedia.org/T218456) (owner: 10Aaron Schulz) [19:43:15] (03PS1) 10Vedmaka Wakalaka: Replaces User::isWatched with WatchedItemStore::isWatched call [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508389 [19:43:36] (03PS31) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [19:44:46] (03PS3) 10BPirkle: Log warning and show error on empty username [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) (owner: 10simetrical) [19:45:05] (03CR) 10BPirkle: "> Patch Set 2:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) (owner: 10simetrical) [19:47:38] (03CR) 10jenkins-bot: Convert WatchedItem and friends to LinkTarget [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [19:47:41] (03PS1) 10Brennen Bearnes: Add .pipeline/blubber.yaml with dev variant for local-charts [core] - 10https://gerrit.wikimedia.org/r/508392 (https://phabricator.wikimedia.org/T218360) [19:50:43] 10Patch-For-Review, 10VisualEditor (Current work): Page notices hidden behind toolbar dialogs - https://phabricator.wikimedia.org/T222427 (10marcella) [19:52:44] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.34-release, 10Technical-Debt (Deprecation): Deprecate and remove support for 'object' key in wgResourceModules - https://phabricator.wikimedia.org/T222637 (10Krinkle) p:05Triage→03Low [19:53:00] 10MediaWiki-ResourceLoader, 10Fresnel, 10Performance-Team, 10Patch-For-Review: Measure time spent in rIC and $.ready with mw.loader.profiler. - https://phabricator.wikimedia.org/T221179 (10Krinkle) p:05Triage→03Normal [19:53:57] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team (Radar): Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10kchapman) [19:55:33] (03CR) 10jerkins-bot: [V: 04-1] Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [19:55:45] (03CR) 10jerkins-bot: [V: 04-1] Replaces User::isWatched with WatchedItemStore::isWatched call [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508389 (owner: 10Vedmaka Wakalaka) [19:56:44] 10MinervaNeue, 10Readers-Web-Backlog, 10Wikimedia-production-error (Shared Build Failure): Flaky failure related to skin Minerva selenium tests - https://phabricator.wikimedia.org/T222517 (10nray) [19:57:44] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Regression: Regression: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10nray) [19:58:38] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks good! Giving it a bit more time for others to have a look. I'll merge this tomorrow if nobody objects. Poke me if I forget." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508287 (https://phabricator.wikimedia.org/T222529) (owner: 10simetrical) [19:59:51] (03Merged) 10jenkins-bot: Consolidate duplicated unseen change logic and fix inconsistent code [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) (owner: 10Aaron Schulz) [20:00:27] (03CR) 10Daniel Kinzler: "> When a patch gets stuck in the C+2 abyss, you don't need to remove your own C+2 to re-trigger, just post a comment (I traditionally use " [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [20:01:04] 10MediaWiki-Database, 10Performance-Team, 10WMF-JobQueue, 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error" - https://phabricator.wikimedia.org/T218692 (10Krinkle) p:05Triage→... [20:01:33] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [20:02:06] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods: [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [20:02:08] (03CR) 10C. Scott Ananian: Rule reference variables should not be affected by failed rules (031 comment) [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 (owner: 10C. Scott Ananian) [20:02:45] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10VisualEditor (Current work): Visual diffs not showing in mobile VE (when visual section editing is disabled) - https://phabricator.wikimedia.org/T222489 (10matmarex) Looks like James is volunteering to backport the patch to production. Meanwhi... [20:04:37] 10MediaWiki-Interface, 10Performance-Team (Radar): MediaWiki should use ETags instead of Last-Modified and the Logged out cookie hack - https://phabricator.wikimedia.org/T33639 (10kchapman) [20:05:09] 10MediaWiki-User-login-and-signup, 10Performance-Team, 10Regression: LoggedOut cookie not set anymore - https://phabricator.wikimedia.org/T142542 (10Krinkle) [20:05:57] 10MobileFrontend, 10Readers-Web-Backlog: Special:MobileDiff doesn't correctly handle diff=0 if the diff would cover multiple revisions - https://phabricator.wikimedia.org/T222562 (10nray) [20:09:01] 10Patch-For-Review, 10VisualEditor (Current work): Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10matmarex) Hmm, true… I remember now that it never worked on desktop. Is it //supposed// to be disabled on non-RESTBase though, or just som... [20:10:54] (03CR) 10jenkins-bot: Consolidate duplicated unseen change logic and fix inconsistent code [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) (owner: 10Aaron Schulz) [20:17:58] 10Design, 10WMF-Design, 10Wikimedia-CentralNotice-Administration: Icon design for programmatic banners - https://phabricator.wikimedia.org/T218148 (10cmadeo) Hi @Jseddon + @spatton, sorry for the delay! Here's a first pass at the icons listed above, please let me know if you think these will work or if you'd... [20:18:13] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team (Radar): Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Krinkle) @Catrope We're watch... [20:19:32] 10MediaWiki-Database, 10Performance-Team, 10WMF-JobQueue, 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: read only on mediawiki generates "LoadBalancer.php: Cannot access the database: Unknown error" - https://phabricator.wikimedia.org/T218692 (10Krinkle) @Marostegui Do... [20:20:41] (03CR) 10Krinkle: [C: 04-1] "While it could be an issue on their side, the Wikibase/mw-selenium tests still fail with this patch applied per https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/497537 (https://phabricator.wikimedia.org/T218456) (owner: 10Aaron Schulz) [20:21:33] (03CR) 10Krinkle: [C: 04-1] "(I would recommend ignoring the issue from 'check php' for now, which seems to be a flaky test due to a unrelated timeout.)" [core] - 10https://gerrit.wikimedia.org/r/497537 (https://phabricator.wikimedia.org/T218456) (owner: 10Aaron Schulz) [20:22:17] 10InternetArchiveBot: False negative - https://phabricator.wikimedia.org/T222660 (10Mbch331) [20:25:46] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Make ImageGateway request a batch of image data for ImageCarousel's use - https://phabricator.wikimedia.org/T221813 (10nray) 05Open→03Declined Closing this ticket for reasons above. If anyone feels strongly that we should pursue this route feel f... [20:31:58] (03CR) 10Jdlrobson: [C: 03+2] Rename EditorOverlay to SourceEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [20:33:53] (03PS2) 10Jdlrobson: 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) [20:34:45] 10CommRel-Design: Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10Qgil) [20:34:50] (03PS15) 10Jdlrobson: Nearby is a dumb component with no need for inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/501445 (https://phabricator.wikimedia.org/T217814) [20:35:05] 10CommRel-Design: Design for badges for Wikimedia & Education online course - https://phabricator.wikimedia.org/T222625 (10Qgil) a:05mcruzWMF→03None [20:35:45] (03PS16) 10Jdlrobson: Nearby is a dumb component with no need for inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/501445 (https://phabricator.wikimedia.org/T217814) [20:35:47] (03PS9) 10Jdlrobson: Remove the Nearby component and use WatchstarPageList [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506129 (https://phabricator.wikimedia.org/T217814) [20:36:52] (03CR) 10jenkins-bot: MobileContextTest: Fix PHPDoc canonical order for parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [20:37:22] (03PS5) 10Jdlrobson: POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) [20:37:36] (03CR) 10jerkins-bot: [V: 04-1] POC: Minerva can be used without MobileFrontend [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/495305 (https://phabricator.wikimedia.org/T216537) (owner: 10Jdlrobson) [20:41:36] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) [20:42:44] (03CR) 10Krinkle: Subtitles served through API, with WebVTT conversion (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:43:42] (03CR) 10Krinkle: [C: 04-1] "Confirmed all CR and changes since PS 57 (my last review). LGTM, except for the "exception instead of fatal" which I don't quite understan" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:45:22] (03CR) 10Krinkle: [C: 03+1] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [20:49:00] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [core] - 10https://gerrit.wikimedia.org/r/508404 (https://phabricator.wikimedia.org/T220036) [20:50:13] (03PS1) 10Aaron Schulz: Remove var_dump() calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/508405 [20:50:39] (03PS3) 10Jdlrobson: Audit: Remove unnecessary browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) [20:50:54] (03CR) 10Jdlrobson: Audit: Remove unnecessary browser tests (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) (owner: 10Jdlrobson) [20:50:58] (03CR) 10jerkins-bot: [V: 04-1] Audit: Remove unnecessary browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) (owner: 10Jdlrobson) [20:51:07] (03CR) 10jerkins-bot: [V: 04-1] Audit: Remove unnecessary browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) (owner: 10Jdlrobson) [20:51:59] (03PS3) 10Jdlrobson: 🐛 Fix import paths in cucumber build [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506590 [20:52:03] (03CR) 10Jdlrobson: [C: 03+2] 🐛 Fix import paths in cucumber build [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506590 (owner: 10Jdlrobson) [20:52:10] (03PS4) 10Jdlrobson: Audit: Remove unnecessary browser tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) [20:52:16] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508407 (https://phabricator.wikimedia.org/T220036) [20:53:29] (03Merged) 10jenkins-bot: Rename EditorOverlay to SourceEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [20:56:17] (03CR) 10Hashar: "recheck" [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/508376 (owner: 10Hashar) [20:57:00] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/508409 (https://phabricator.wikimedia.org/T220036) [20:57:10] (03CR) 10jenkins-bot: Rename EditorOverlay to SourceEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [20:57:28] (03CR) 10Jdrewniak: [C: 03+2] 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) (owner: 10Jdlrobson) [20:58:19] (03CR) 10Brion VIBBER: "Ah indeed, an exception will also log won't it. I'll change to just forbid this for now." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:58:45] (03CR) 10Jdlrobson: [C: 04-1] "Strong recommendation! Let me know your thoughts." (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [20:59:02] (03CR) 10MusikAnimal: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [20:59:15] (03CR) 10Jdlrobson: [C: 03+2] Connect initMediaViewer to wikipage.content hook [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505268 (owner: 10Esanders) [20:59:24] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/3D] - 10https://gerrit.wikimedia.org/r/508413 (https://phabricator.wikimedia.org/T220036) [20:59:32] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n: Some strings were altered automatically, plural and grammar are broken - https://phabricator.wikimedia.org/T222505 (10cooltey) Hi @YaronSh and @Amire80 The Android XML does not support the wikitext format, which texts contain the double parenthe... [21:00:55] (03PS1) 10Isarra: Maybe not blindly run our postcache editmarker replacement parse on every getText ever [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508414 [21:03:27] (03CR) 10jerkins-bot: [V: 04-1] Maybe not blindly run our postcache editmarker replacement parse on every getText ever [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508414 (owner: 10Isarra) [21:03:39] (03CR) 10jerkins-bot: [V: 04-1] Maybe not blindly run our postcache editmarker replacement parse on every getText ever [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508414 (owner: 10Isarra) [21:03:48] 10MediaWiki-Vendor, 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog: DonationInterface Vendor repo double inclusions - https://phabricator.wikimedia.org/T159099 (10Ejegg) 05Open→03Resolved a:03Ejegg OK, we're now using composer-merge-plugin to pull extension dependencies in to paymentsw... [21:03:53] (03CR) 10Jdlrobson: [C: 04-1] "Doesn't seem to be running in CI:" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [21:07:48] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), and 2 others: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (1... [21:08:53] (03CR) 10Esanders: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [21:08:59] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [21:09:03] (03PS1) 10Jdrewniak: Adding mobile/desktop targets to mediawiki.action.history module [core] - 10https://gerrit.wikimedia.org/r/508415 (https://phabricator.wikimedia.org/T219895) [21:09:24] (03PS67) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:10:10] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/508409 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [21:10:49] (03CR) 10Brion VIBBER: "Oh PS67 will gracefully error out instead of throwing an exception if asked for a subtitle with a source page that only existed in vtt sou" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:11:28] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Dzahn) > Re "messaging problematic users in Phab itself": This is what notifications are for. Mentioning a user by @name or subscribing them will notify them.... [21:13:10] (03CR) 10jerkins-bot: [V: 04-1] Tag pages that were previously deleted and add filter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508385 (https://phabricator.wikimedia.org/T189929) (owner: 10MusikAnimal) [21:15:07] (03CR) 10EBernhardson: [C: 03+2] "re-apply +2, test failure was unrelated" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [21:15:49] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) >>! In T127640#5162133, Dzahn wrote: >> Re "messaging problematic users in Phab itself": > > This is what notifications are for. Mentioning a user b... [21:16:43] (03PS1) 10Ori.livneh: Add more benchmarks [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/508416 [21:17:10] (03Merged) 10jenkins-bot: 🐛 Fix import paths in cucumber build [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506590 (owner: 10Jdlrobson) [21:20:37] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n: Some strings were altered automatically, plural and grammar are broken - https://phabricator.wikimedia.org/T222505 (10Amire80) >>! In T222505#5161962, @cooltey wrote: > Hi @YaronSh and @Amire80 > > The Android XML does not support the wikitext f... [21:20:45] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Epic: Epic: CentralNotice Banner squence - https://phabricator.wikimedia.org/T144615 (10DStrine) 05Open→03Resolved [21:20:51] (03CR) 10jerkins-bot: [V: 04-1] 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) (owner: 10Jdlrobson) [21:21:05] (03CR) 10jenkins-bot: 🐛 Fix import paths in cucumber build [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506590 (owner: 10Jdlrobson) [21:21:20] (03PS1) 10Isarra: Add configuration variable to turn off all the content model stuff [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508417 (https://phabricator.wikimedia.org/T214126) [21:22:25] (03CR) 10Brion VIBBER: "Note there's also an oddity I noticed where if you provide a page in TimedText namespace with a non-supported extension it'll still get tr" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:23:41] (03CR) 10Jdlrobson: [C: 03+2] Adding mobile/desktop targets to mediawiki.action.history module [core] - 10https://gerrit.wikimedia.org/r/508415 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [21:24:06] (03PS3) 10Jdlrobson: 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) [21:24:10] (03CR) 10Jdlrobson: [C: 03+2] 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) (owner: 10Jdlrobson) [21:24:25] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [21:24:30] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10User-Urbanecm: Homepage: provide aliases for Special:Homepage (ko, cs, vi) - https://phabricator.wikimedia.org/T219284 (10Etonkovidova) 05Open→03Resolved Checked for `kowiki` and `cswiki`. Marking as 'Resol... [21:24:33] 10Shape Expressions: Extend support for wikidata in RDFShape to help wikidata validation - https://phabricator.wikimedia.org/T222662 (10Jelabra) [21:25:15] (03CR) 10jerkins-bot: [V: 04-1] Add configuration variable to turn off all the content model stuff [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508417 (https://phabricator.wikimedia.org/T214126) (owner: 10Isarra) [21:25:44] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Extend support for wikidata in RDFShape to help wikidata validation - https://phabricator.wikimedia.org/T222662 (10Jelabra) [21:25:49] (03CR) 10Isarra: "Currently done: disabling special pages" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508417 (https://phabricator.wikimedia.org/T214126) (owner: 10Isarra) [21:27:51] (03PS2) 10Vedmaka Wakalaka: Replaces User::isWatched with WatchedItemStore::isWatched call [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508389 [21:29:41] (03PS2) 10Isarra: Maybe not blindly run our postcache editmarker replacement parse on every getText ever [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/508414 [21:29:57] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Shape Expressions @ Wikimedia Hackathon 2019 - https://phabricator.wikimedia.org/T222584 (10Andrawaag) [21:30:02] 10Shape Expressions, 10Wikimedia-Hackathon-2019: Extend support for wikidata in RDFShape to help wikidata validation - https://phabricator.wikimedia.org/T222662 (10Andrawaag) [21:31:16] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n: Some strings were altered automatically, plural and grammar are broken - https://phabricator.wikimedia.org/T222505 (10cooltey) >>! In T222505#5162272, @Amire80 wrote: >>>! In T222505#5161962, @cooltey wrote: >> Hi @YaronSh and @Amire80 >> >> The... [21:31:19] 10Product-Analytics: Formalize the concept of countable wikis - https://phabricator.wikimedia.org/T222655 (10Erik_Zachte) IIRC the criterion was rather which wikis to exclude explicitly. Those were wikis which are not publicly editable or nor even readable. Example that comes to mind is the board wiki. One tim... [21:31:47] 10MediaWiki-extensions-CollaborationKit, 10Patch-For-Review: Add feature flags to CollaborationKit content models to enable/disable special rendering - https://phabricator.wikimedia.org/T214126 (10Isarra) Per the patch, I'm pretty sure this is beyond me. I tried. [21:36:07] 10MediaWiki-extensions-CollaborationKit: Add tests for editmarker output - https://phabricator.wikimedia.org/T222664 (10Isarra) [21:37:33] 10ISA: Commons API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10Eugene233) a:03Eugene233 [21:39:08] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10alexhollender) @Volker_E thanks so much for taking a clos... [21:41:33] (03CR) 10Jforrester: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/508409 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [21:42:43] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Volker_E) As long as it's a `12px` `em` equivalent, sure.... [21:45:24] (03PS32) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [21:45:57] (03Merged) 10jenkins-bot: Ignore ancient logging rows with log_page = null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [21:46:02] (03PS1) 10Aaron Schulz: Avoid use of deprecated Database::reportConnectionError() method [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/508421 [21:46:50] (03Merged) 10jenkins-bot: Remove Updater::archivePages $forceIndex parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 (owner: 10EBernhardson) [21:46:56] (03Merged) 10jenkins-bot: Adding mobile/desktop targets to mediawiki.action.history module [core] - 10https://gerrit.wikimedia.org/r/508415 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [21:47:07] (03PS2) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) [21:47:45] (03CR) 10jenkins-bot: 🚑 Restore the gray references icon color [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507714 (https://phabricator.wikimedia.org/T222314) (owner: 10Jdlrobson) [21:48:41] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) >>! In T221177#5161310, @Anomie wrote: > That doesn't solve the problem of someone deciding they want to inject th... [21:52:46] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10alexhollender) [21:52:50] (03PS1) 10Krinkle: localisation: Improve documentation around wgLocalisationCacheConf [core] - 10https://gerrit.wikimedia.org/r/508422 (https://phabricator.wikimedia.org/T218207) [21:52:52] (03PS1) 10Krinkle: localisation: Inject 'directory' option to LCStore classes [core] - 10https://gerrit.wikimedia.org/r/508423 (https://phabricator.wikimedia.org/T218207) [21:53:43] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: Regression: Citation icon in reference drawer changed from gray to white - https://phabricator.wikimedia.org/T222314 (10Jdlrobson) [21:54:02] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: Regression: Citation icon in reference drawer changed from gray to white - https://phabricator.wikimedia.org/T222314 (10Jdlrobson) a:03Edtadros [21:54:55] (03CR) 10jenkins-bot: Adding mobile/desktop targets to mediawiki.action.history module [core] - 10https://gerrit.wikimedia.org/r/508415 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [21:55:08] (03CR) 10jerkins-bot: [V: 04-1] localisation: Inject 'directory' option to LCStore classes [core] - 10https://gerrit.wikimedia.org/r/508423 (https://phabricator.wikimedia.org/T218207) (owner: 10Krinkle) [21:55:33] (03CR) 10jerkins-bot: [V: 04-1] localisation: Inject 'directory' option to LCStore classes [core] - 10https://gerrit.wikimedia.org/r/508423 (https://phabricator.wikimedia.org/T218207) (owner: 10Krinkle) [21:57:31] (03PS1) 10Jforrester: build: Install eslint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508424 [21:57:33] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508425 (https://phabricator.wikimedia.org/T220036) [21:58:07] 10CommRel-Design, 10CommRel-Specialists-Support (Apr-Jun-2019): Design hackathon table signs - https://phabricator.wikimedia.org/T219622 (10hdothiduc) Hi Rachel! [[ https://drive.google.com/open?id=1hGe8dUptt8-K1JZMtp4i26wMIRD8ChT6 | Here is a draft ]], I kept it simple, so you can basically print it with any... [21:58:14] (03CR) 10Krinkle: [C: 03+2] Avoid use of deprecated Database::reportConnectionError() method [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/508421 (owner: 10Aaron Schulz) [21:59:10] (03CR) 10Krinkle: [C: 03+2] Remove var_dump() calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/508405 (owner: 10Aaron Schulz) [21:59:29] 10LDAP-Access-Requests: LDAP access to the nda group for sukhe - https://phabricator.wikimedia.org/T221990 (10Dzahn) 05Open→03Resolved a:05Dzahn→03None >>! In T221990#5160228, @MoritzMuehlenhoff wrote: > Move to cn=wmf, contractors with a wikimedia.org address should be part of cn=wmf, not cn=nda. Ok, t... [21:59:40] 10LDAP-Access-Requests: LDAP access to the (nda) wmf group for sukhe - https://phabricator.wikimedia.org/T221990 (10Dzahn) [22:00:41] 10Patch-For-Review, 10VisualEditor (Current work): Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10Esanders) It is supposed to be disabled. I'm not sure what happens without the RESTBase stash, maybe a full doc dirty diff? [22:01:01] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) [22:01:16] 10MobileFrontend, 10MinervaNeue, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Review and refactor Minerva components - https://phabricator.wikimedia.org/T195482 (10pmiazga) [22:01:20] 10Readers-Web-Backlog, 10Epic: [EPIC] Talk about and improve our frontend code architecture - https://phabricator.wikimedia.org/T166905 (10pmiazga) [22:01:25] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Babel] - 10https://gerrit.wikimedia.org/r/508426 (https://phabricator.wikimedia.org/T220036) [22:01:28] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team, 10Developer-Wishlist (2017), and 2 others: Dismantle ResourceLoader's "targets" system - https://phabricator.wikimedia.org/T127268 (10pmiazga) [22:01:30] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) 05Open→03Resolved [22:01:35] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508425 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:01:41] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) LGTM [22:02:14] (03CR) 10jerkins-bot: [V: 04-1] build: Install eslint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508424 (owner: 10Jforrester) [22:02:23] (03PS1) 10Krinkle: frontend: Only export wgStableRevisionId/wgFlaggedRevsParams when needed [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/508427 (https://phabricator.wikimedia.org/T219342) [22:03:18] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/508428 (https://phabricator.wikimedia.org/T220036) [22:03:24] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) a:03matmarex [22:03:34] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [22:03:41] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Performance-Team (Radar): Reduce module registrations from PageTriage - https://phabricator.wikimedia.org/T221269 (10Krinkle) [22:03:54] (03PS1) 10Ori.livneh: Use a bitset+unordered_set to represent sets of integers [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/508429 [22:04:19] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [22:05:51] (03PS1) 10Krinkle: ext.pageTriage.toolbarStartup: Remove invalid return value [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508430 [22:07:58] (03CR) 10jenkins-bot: Ignore ancient logging rows with log_page = null [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508369 (https://phabricator.wikimedia.org/T222641) (owner: 10EBernhardson) [22:09:43] (03PS1) 10Jforrester: build: Install eslint [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/508431 [22:09:45] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/508432 (https://phabricator.wikimedia.org/T220036) [22:11:48] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10VisualEditor (Current work): Visual diffs not showing in mobile VE (when visual section editing is disabled) - https://phabricator.wikimedia.org/T222489 (10ppelberg) >>! In T222489#5161021, @matmarex wrote: > The mobile visual section editing... [22:12:32] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/508433 (https://phabricator.wikimedia.org/T220036) [22:14:01] (03PS1) 10Jdlrobson: Merge remote-tracking branch 'origin/master' into HEAD [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/508434 [22:14:22] (03PS2) 10Jdlrobson: Merge remote-tracking branch 'origin/master' into HEAD [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/508434 [22:15:05] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/508435 (https://phabricator.wikimedia.org/T220036) [22:16:01] (03PS1) 10Jdlrobson: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508436 (https://phabricator.wikimedia.org/T205341) [22:16:20] (03CR) 10Jdlrobson: [C: 03+2] "Bring reset-cleanup branch up to date." [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/508434 (owner: 10Jdlrobson) [22:16:34] 04(no projects): Allow analytics-admins to sudo as the new 'analytics' user + generalization of their sudo systemctl * capabilities - https://phabricator.wikimedia.org/T222368 (10Dzahn) 05Open→03Resolved This was in today's SRE meeting and got approval. I also see the changes are both merged. Resolved, ri... [22:16:51] 04(no projects): Allow analytics-admins to sudo as the new 'analytics' user + generalization of their sudo systemctl * capabilities - https://phabricator.wikimedia.org/T222368 (10Dzahn) [22:17:35] (03PS1) 10Krinkle: Remove redundant 'return true' from non-abortable hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508437 [22:17:46] (03PS32) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [22:17:48] (03PS33) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [22:17:50] (03CR) 10jerkins-bot: [V: 04-1] ext.pageTriage.toolbarStartup: Remove invalid return value [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508430 (owner: 10Krinkle) [22:17:54] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508438 (https://phabricator.wikimedia.org/T220036) [22:17:58] (03Abandoned) 10Jdlrobson: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508436 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [22:18:17] (03Restored) 10Jdlrobson: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508436 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [22:18:23] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Stop using jsonlint (as it's abandonware) and instead use eslint-plugin-json for the linting - https://phabricator.wikimedia.org/T220036 (10Jdforrester-WMF) [22:18:31] (03Abandoned) 10Jdlrobson: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508436 (https://phabricator.wikimedia.org/T205341) (owner: 10Jdlrobson) [22:19:00] (03Merged) 10jenkins-bot: Avoid use of deprecated Database::reportConnectionError() method [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/508421 (owner: 10Aaron Schulz) [22:19:02] (03Merged) 10jenkins-bot: Remove var_dump() calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/508405 (owner: 10Aaron Schulz) [22:19:44] (03PS5) 10Jdlrobson: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [22:20:13] (03CR) 10Jdlrobson: [C: 04-1] Move `p`, `pre` and `blockquote` styles to 'text.less' (031 comment) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [22:20:53] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Cite] - 10https://gerrit.wikimedia.org/r/508440 (https://phabricator.wikimedia.org/T220036) [22:21:00] (03CR) 10Jdlrobson: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:21:43] (03CR) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:22:21] (03CR) 10jenkins-bot: Avoid use of deprecated Database::reportConnectionError() method [extensions/MSSQLBackCompat] - 10https://gerrit.wikimedia.org/r/508421 (owner: 10Aaron Schulz) [22:22:25] (03CR) 10jenkins-bot: Remove Updater::archivePages $forceIndex parameter [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508375 (owner: 10EBernhardson) [22:22:55] (03PS2) 10Jforrester: build: Install eslint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508424 [22:22:57] (03CR) 10Jdlrobson: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508407 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:23:17] (03CR) 10jenkins-bot: Remove var_dump() calls [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/508405 (owner: 10Aaron Schulz) [22:23:19] (03PS2) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/508425 (https://phabricator.wikimedia.org/T220036) [22:24:01] (03PS3) 10Jdlrobson: Page: Allow optional $container for getThumbnails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505766 (owner: 10Esanders) [22:24:14] (03CR) 10jerkins-bot: [V: 04-1] Page: Allow optional $container for getThumbnails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505766 (owner: 10Esanders) [22:25:47] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team (Radar): Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Catrope) It turns out Message... [22:26:02] (03CR) 10Jdlrobson: [C: 03+2] Page: Allow optional $container for getThumbnails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505766 (owner: 10Esanders) [22:26:29] (03CR) 10Krinkle: [C: 04-1] "This seems to me like the abstraction layer should be elsewhere. There are already quite a number of abstraction layers on top of session " [core] - 10https://gerrit.wikimedia.org/r/506890 (https://phabricator.wikimedia.org/T149573) (owner: 10Gergő Tisza) [22:27:08] (03PS2) 10Jdlrobson: Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [22:27:24] (03CR) 10jerkins-bot: [V: 04-1] Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [22:27:40] (03PS1) 10Gergő Tisza: Fix Travis builds [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508442 (https://phabricator.wikimedia.org/T215859) [22:28:02] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/508443 [22:28:09] (03CR) 10Gergő Tisza: [C: 03+2] "Self-merge, CI unbreak." [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508442 (https://phabricator.wikimedia.org/T215859) (owner: 10Gergő Tisza) [22:28:20] (03PS4) 10Jdlrobson: Page: Allow optional $container for getThumbnails [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505766 (owner: 10Esanders) [22:28:22] (03PS3) 10Jdlrobson: Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [22:28:26] (03CR) 10jerkins-bot: [V: 04-1] Connect initMediaViewer to wikipage.content hook [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505268 (owner: 10Esanders) [22:28:53] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10Performance-Team, 10Patch-For-Review, 10good first bug: Add a configuration variable that allows Session Backend and Session manager share sessions across multiple wikis. - https://phabricator.wikimedia.org/T149573 (10Krinkle) [22:29:04] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10Performance-Team, 10Patch-For-Review, 10good first bug: Add a configuration variable that allows Session Backend and Session manager share sessions across multiple wikis. - https://phabricator.wikimedia.org/T149573 (10Krinkle) [22:29:57] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/508444 [22:30:23] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508438 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:30:37] (03Merged) 10jenkins-bot: Fix Travis builds [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508442 (https://phabricator.wikimedia.org/T215859) (owner: 10Gergő Tisza) [22:31:28] (03CR) 10Krinkle: store: Avoid deprecated use of ObjectCache::getMainStashInstance() (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [22:31:30] (03CR) 10Krinkle: [C: 04-1] store: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [22:31:40] (03CR) 10Krinkle: [C: 03+1] objectcache: Hard deprecate ObjectCache::getMainStashInstance() [core] - 10https://gerrit.wikimedia.org/r/508115 (owner: 10D3r1ck01) [22:31:51] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508445 [22:33:13] (03CR) 10Platonides: "How would you use it? If people needs to pass 'keyspaceIsGlobal' => true on ObjectCache creation, wouldn't setting both wikis to keyspace " [core] - 10https://gerrit.wikimedia.org/r/506890 (https://phabricator.wikimedia.org/T149573) (owner: 10Gergő Tisza) [22:33:25] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant 'return true' from non-abortable hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/508437 (owner: 10Krinkle) [22:33:45] (03CR) 10jenkins-bot: Fix Travis builds [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508442 (https://phabricator.wikimedia.org/T215859) (owner: 10Gergő Tisza) [22:35:33] 10VisualEditor (Current work): VE mobile default: identify wikis for trial - https://phabricator.wikimedia.org/T221188 (10ppelberg) [22:39:20] 10Wikipedia-Android-App-Backlog: Page bottom bar behavior and appearance - https://phabricator.wikimedia.org/T222478 (10cooltey) It was a design update in T220532 > Keep bottom bar always visible. Currently, the bottom toolbar is hidden once users are scrolling down, this leads to a situation in which the bottom... [22:39:29] (03PS2) 10Brennen Bearnes: Add .pipeline/blubber.yaml with dev variant for local-charts [core] - 10https://gerrit.wikimedia.org/r/508392 (https://phabricator.wikimedia.org/T218360) [22:40:13] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [22:41:39] (03CR) 10Brennen Bearnes: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508392 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [22:41:43] (03PS1) 10Jforrester: build: Install eslint [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/508447 [22:41:46] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/508448 [22:43:24] (03CR) 10Krinkle: [C: 04-1] Add additional configuation parameters to RESTBagOStuff (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507207 (https://phabricator.wikimedia.org/T215533) (owner: 10BPirkle) [22:43:33] (03PS34) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [22:43:37] (03CR) 10Gergő Tisza: "> This seems to me like the abstraction layer should be elsewhere. There are already quite a number of abstraction layers on top of sessio" [core] - 10https://gerrit.wikimedia.org/r/506890 (https://phabricator.wikimedia.org/T149573) (owner: 10Gergő Tisza) [22:44:07] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508450 (https://phabricator.wikimedia.org/T220036) [22:46:05] (03CR) 10Gergő Tisza: "> How would you use it? If people needs to pass 'keyspaceIsGlobal' => true on ObjectCache creation, wouldn't setting both wikis to keyspac" [core] - 10https://gerrit.wikimedia.org/r/506890 (https://phabricator.wikimedia.org/T149573) (owner: 10Gergő Tisza) [22:46:07] (03CR) 10jerkins-bot: [V: 04-1] Merge remote-tracking branch 'origin/master' into HEAD [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/508434 (owner: 10Jdlrobson) [22:46:28] (03Abandoned) 10Gergő Tisza: Add keyspaceIsGlobal flag to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/506890 (https://phabricator.wikimedia.org/T149573) (owner: 10Gergő Tisza) [22:47:09] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:47:20] (03PS1) 10Jdrewniak: Moving button mixin into separate mediawiki.mixins.buttons.less file [core] - 10https://gerrit.wikimedia.org/r/508451 (https://phabricator.wikimedia.org/T219895) [22:48:03] tgr: it should be documented, though [22:49:20] (03PS1) 10Jforrester: build: Install eslint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/508452 [22:49:22] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/508453 [22:49:36] (03CR) 10MaxSem: [C: 03+2] Add more benchmarks [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/508416 (owner: 10Ori.livneh) [22:50:39] (03Merged) 10jenkins-bot: Add more benchmarks [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/508416 (owner: 10Ori.livneh) [22:52:39] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508402 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [22:54:41] (03CR) 10Jdrewniak: "recheck" [core] - 10https://gerrit.wikimedia.org/r/508451 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [22:56:08] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Cache, 10Performance-Team, 10Patch-For-Review, 10good first bug: Add a configuration variable that allows Session Backend and Session manager share sessions across multiple wikis. - https://phabricator.wikimedia.org/T149573 (10Tgr) 05Open→03Res... [22:57:08] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Flow] - 10https://gerrit.wikimedia.org/r/508454 [22:57:32] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team (Radar): Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Catrope) Since the reason tha... [22:57:59] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend Special Pages), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdrewniak)... [22:59:39] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Performance-Team (Radar): Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Krinkle) Wow, nice catch! In... [22:59:41] (03CR) 10VolkerE: "Must have been removed in the branch rebase underneath due to the patch being moved out of it's original sequenced. Not easy to identify." [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [23:00:22] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Echo] - 10https://gerrit.wikimedia.org/r/508450 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:00:42] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/508455 [23:00:58] (03PS6) 10VolkerE: Address `p`, `pre` and `blockquote` styles in 'text.less' [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) [23:01:15] (03CR) 10VolkerE: Address `p`, `pre` and `blockquote` styles in 'text.less' (031 comment) [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [23:03:42] (03CR) 10jerkins-bot: [V: 04-1] Moving button mixin into separate mediawiki.mixins.buttons.less file [core] - 10https://gerrit.wikimedia.org/r/508451 (https://phabricator.wikimedia.org/T219895) (owner: 10Jdrewniak) [23:04:01] (03CR) 10Smalyshev: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508438 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:04:24] (03CR) 10Smalyshev: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508300 (owner: 10DCausse) [23:05:58] (03CR) 10Krinkle: [C: 03+2] Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [23:06:35] (03CR) 10Krinkle: [C: 04-1] "Update extension.json as well. Not sure why we have both..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/507238 (owner: 10Aaron Schulz) [23:06:51] (03PS1) 10Jforrester: build: Install eslint [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/508458 [23:06:54] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/508459 (https://phabricator.wikimedia.org/T220036) [23:07:10] (03CR) 10Krinkle: [C: 04-1] Remove wgCentralAuthUseSlaves setting which is no longer experimental (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/507238 (owner: 10Aaron Schulz) [23:11:40] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10matmarex) The above seemed to work great when I tested on desktop. On iOS it has some weird interaction with our scrolling hacks, and som... [23:13:25] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508407 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:14:22] (03PS1) 10Jforrester: build: Install eslint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508462 [23:14:24] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508463 [23:17:55] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508407 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:18:13] (03CR) 10jerkins-bot: [V: 04-1] build: Install eslint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508462 (owner: 10Jforrester) [23:18:49] (03CR) 10jerkins-bot: [V: 04-1] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508463 (owner: 10Jforrester) [23:18:54] (03PS1) 10Jforrester: build: Install eslint [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/508464 [23:19:37] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/508465 [23:21:46] 10Patch-For-Review, 10VisualEditor (Current work): Mobile switching with changes from WTE to VE fails on non-RESTBase setups - https://phabricator.wikimedia.org/T222312 (10matmarex) Hmm, well, would that be so terrible? I think the benefit of being able to switch editors would be greater than the drawback of d... [23:22:23] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/508466 [23:24:11] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Growth-Team, 10Performance-Team (Radar), 10Regression: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) - https://phabricator.wikimedia.org/T222539 (10Krinkle) [23:25:44] (03PS1) 10Jforrester: build: Install eslint [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/508467 [23:26:27] 10Discovery-Search: Russian characters not normalized to same form in search - https://phabricator.wikimedia.org/T222669 (10EBernhardson) [23:26:48] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/508468 [23:28:00] 10MediaWiki-extensions-CollaborationKit, 10Patch-For-Review: Add feature flags to CollaborationKit content models to enable/disable special rendering - https://phabricator.wikimedia.org/T214126 (10Isarra) Alternative approach: don't bother disabling the content models themselves. While the rendering is the mo... [23:33:25] (03PS1) 10Jforrester: build: Install eslint [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/508469 [23:33:27] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/508470 [23:34:43] (03CR) 10Bartosz Dziewoński: [C: 03+2] "Test failure should be fixed now via https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/508407" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [23:34:54] (03Merged) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508438 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:34:57] (03CR) 10jerkins-bot: [V: 04-1] Avoid various phpstorm warnings in MediaWikiServices due to "object" return hint [core] - 10https://gerrit.wikimedia.org/r/505621 (owner: 10Aaron Schulz) [23:35:46] 10MediaWiki-Recent-changes, 10MediaWiki-ResourceLoader, 10Growth-Team, 10Performance-Team (Radar), 10Regression: Scap deployments are not purging MessageBlobStore (was: Stale localized messages) - https://phabricator.wikimedia.org/T222539 (10Catrope) As I was talking this through with @Krinkle on IRC, he... [23:36:08] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Math] - 10https://gerrit.wikimedia.org/r/508471 [23:36:12] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [core] - 10https://gerrit.wikimedia.org/r/508404 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:36:42] (03PS2) 10Jforrester: build: Install eslint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508462 [23:36:53] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) >>! In T221177#5160802, @Anomie wrote: > Most are just to generate the right version when manually calling `... [23:36:55] (03PS2) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/508463 [23:37:14] (03CR) 10Bartosz Dziewoński: [C: 03+2] build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/Cite] - 10https://gerrit.wikimedia.org/r/508440 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:37:57] (03CR) 10Krinkle: "fixme" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [23:38:05] 10MediaWiki-ContentHandler: Special:ChangeContentModel should handle MWUnknownContentModelException - https://phabricator.wikimedia.org/T222670 (10Isarra) [23:39:14] Krinkle: thanks! wrt outputpate patch review [23:39:27] (03CR) 10Krinkle: ✅ Restore the user page test (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [23:39:53] Krinkle: of the ones here, which do you think is most urgent? https://phabricator.wikimedia.org/T222463 [23:40:04] also pls add any I may have missed [23:40:08] thx again! [23:40:56] AndyRussG: change 497644 is not important. The optimisations for startup module and page HTML matter most (the first three) of which one depends on the other. [23:41:32] Krinkle: ok gotcha [23:41:38] AndyRussG: The small fixes for that I can review with others (if alright with you). the main thing I'm blocked on is the switch to packageFiles which I'd like you/your-team to verify instead and also to make sure it makes sense to you how it works. [23:41:57] okok... apologies for the delay on all this! [23:42:15] (03CR) 10Bartosz Dziewoński: [C: 03+2] Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [23:42:17] thx for checking [23:42:24] (03CR) 10Bartosz Dziewoński: [C: 03+2] "PS4 seems to be a rebase. Per Jon's +2 on PS3." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505766 (owner: 10Esanders) [23:47:43] 10MediaWiki-ContentHandler, 10MediaWiki-Maintenance-scripts: Create maintenance script to remove a content model from a wiki, converting it to another one - https://phabricator.wikimedia.org/T222672 (10Isarra) [23:47:52] (03Abandoned) 10Krinkle: Replace wfWaitForSlaves() with not deprecated method [core] - 10https://gerrit.wikimedia.org/r/395148 (https://phabricator.wikimedia.org/T181673) (owner: 10Albert221) [23:49:22] (03CR) 10jenkins-bot: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508438 (https://phabricator.wikimedia.org/T220036) (owner: 10Jforrester) [23:51:46] (03CR) 10Krinkle: "MassMessageServerSideJob does not appear to take any 'title' param, although sendForceRenameNotification.php (CentralAuth) and sendMessage" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/505827 (owner: 10Krinkle) [23:52:22] (03CR) 10Krinkle: "@Tgr Does your concern still apply to this commit?" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/505827 (owner: 10Krinkle) [23:53:16] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Opening brace indent level should match that of preceding keyword - https://phabricator.wikimedia.org/T222673 (10Tgr) [23:53:28] (03PS7) 10Krinkle: Preload links via LinkBatch in WikitextContent::fillParserOutput() [core] - 10https://gerrit.wikimedia.org/r/496744 (owner: 10Aaron Schulz) [23:53:45] 10MediaWiki-ContentHandler: Support deletion of pages with unknown content models - https://phabricator.wikimedia.org/T222674 (10Isarra) [23:55:16] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10matmarex) On a closer look, my description of @aaron's pa... [23:57:47] (03PS1) 10Jforrester: build: Lint the rest of our JS, and make pass [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/508474 [23:57:49] (03PS1) 10Jforrester: build: Upgrade eslint-config-wikimedia 0.12.0, drop grunt-jsonlint [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/508475 [23:57:51] 10MediaWiki-Codesniffer, 10MediaWiki-General-or-Unknown: Opening brace indent level should match that of preceding keyword - https://phabricator.wikimedia.org/T222673 (10Tgr) [23:57:52] (03CR) 10Bartosz Dziewoński: [C: 03+1] "Thanks." [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [23:57:56] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Krinkle) There does not appear to be a description of a s... [23:58:00] 10MediaWiki-Categories, 10Performance-Team: Refactor Category::refreshCounts logic to a job and simplify - https://phabricator.wikimedia.org/T221795 (10Krinkle) [23:58:07] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Krinkle) [23:59:19] 10MediaWiki-Categories, 10Performance-Team: Refactor Category::refreshCounts logic to a job and simplify - https://phabricator.wikimedia.org/T221795 (10Krinkle) [23:59:35] 10Developer-Advocacy, 10patch-welcome: Gerrit newcomer bot sometimes stop working - https://phabricator.wikimedia.org/T221331 (10srishakatux) @Aklapper I am not sure if it makes sense to have a ticket around this issue on Phabricator. Basically, this issue needs expert help (someone who can speak both Python...