[01:05:14] 10Graphs, 10Mobile, 10Readers-Web-Backlog (Tracking): Graphs create img tags without width and height - https://phabricator.wikimedia.org/T216431 (10RobinLeicester) Awesome. I have incorporated it below the map on OSM Location map, so it will be there on any page needed. Its a fudge, but a pretty good one!... [01:21:37] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10Mooeypoo) To clarify -- the lazy-loading is for whatever JS interface we come up with to toggle, not to initial style loading. The style loading should happen in the backend/PHP... [02:02:39] 04(no projects): Language selector doesn't show in Recent Changes of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10cahyo.ramadhani) [02:03:04] 04(no projects): Language selector doesn't appear in Recent Changes of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10cahyo.ramadhani) [02:13:22] 04(no projects): Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10cahyo.ramadhani) [02:13:46] 04(no projects): Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10cahyo.ramadhani) [03:27:42] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Shizhao) >>! 在T221933#5155350中，@RazeSoldier写道： > 4. Disable $wgKartographerEnableMapFrame on zhwiki Why disable $wgKartographerEnableMapFrame? [03:31:07] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth, 10Developer-Wishlist (Next), 10Mobile: Logging out on a different device logs me out everywhere else - https://phabricator.wikimedia.org/T51890 (10Jdlrobson) I think T37220 is a duplicate of this? [03:31:35] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Allow per-session log out - https://phabricator.wikimedia.org/T37220 (10Jdlrobson) Duplicate of T51890? [03:54:31] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Hamishcn) >>! 在T221933#5157829中，@Shizhao写道： >>>! 在T221933#5155350中，@RazeSoldier写道： >> 4. Disable $wgKartographerEnableMapFrame on zhwiki > Why disab... [04:09:10] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Hamishcn) >>! 在T221933#5157829中，@Shizhao写道： >>>! 在T221933#5155350中，@RazeSoldier写道： >> 4. Disable $wgKartographerEnableMapFrame on zhwiki > Why disab... [04:38:07] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Ammarpad) [04:38:55] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Ammarpad) [04:40:50] 10MediaWiki-extensions-LanguageSelector: Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10Ammarpad) [05:12:55] 10InternetArchiveBot: want to undo false positive report - https://phabricator.wikimedia.org/T222528 (10Eastmain) [05:14:37] 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10A2093064) [05:17:25] 10InternetArchiveBot: would like to undo entire domain report - https://phabricator.wikimedia.org/T222530 (10Eastmain) [06:03:13] 10AbuseFilter: InvalidArgumentException when giving empty aflfilter in list=abuselog API - https://phabricator.wikimedia.org/T222531 (10A2093064) [06:51:49] (03PS8) 10simetrical: Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) [06:52:25] (03PS1) 10Luca Mauri: Introduction to the extension and link to homepage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/508102 (https://phabricator.wikimedia.org/T161248) [06:53:34] (03PS2) 10Luca Mauri: Introduction to the extension and link to homepage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/508102 (https://phabricator.wikimedia.org/T161248) [06:55:12] 10MediaWiki-Documentation, 10MediaWiki-extensions-OAuthAuthentication, 10Documentation, 10Patch-For-Review: Installation instructions of OAuthAuthentication are useless - https://phabricator.wikimedia.org/T161248 (10lucamauri) >>! In T161248#5157898, @gerritbot wrote: > Change 508102 had a related patch se... [06:55:58] 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Tgr) [06:57:06] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [07:05:30] (03CR) 10simetrical: Deprecate the Http class (033 comments) [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [07:27:40] (03PS9) 10simetrical: Deprecate the Http class [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) [07:37:55] 10MediaWiki-General-or-Unknown, 10Core Platform Team Backlog (Watching / External), 10Patch-For-Review, 10User-Daniel, 10User-thiemowmde: Hook handler functions should not require pass-by-reference unless documented in the hook signature - https://phabricator.wikimedia.org/T193951 (10Tgr) Yeah, the sprea... [07:49:36] (03CR) 10Gergő Tisza: "Seems to have caused T222529." [core] - 10https://gerrit.wikimedia.org/r/504001 (https://phabricator.wikimedia.org/T214318) (owner: 10simetrical) [08:06:11] (03PS4) 10simetrical: Don't pass Config to Parser(Factory) [core] - 10https://gerrit.wikimedia.org/r/503283 [08:06:33] (03CR) 10simetrical: Don't pass Config to Parser(Factory) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [08:10:51] (03PS4) 10simetrical: Don't pass Config to NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/503281 [08:10:53] (03PS2) 10simetrical: 100% test coverage for NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/507348 [08:13:10] (03CR) 10simetrical: "Look at these lines from the log:" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [08:22:40] (03PS1) 10D3r1ck01: ContentProviderFactoryTest: Remove unused vars in test suits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508104 [08:23:20] (03Abandoned) 10Jeroen De Dauw: Add wmde/clock [vendor] - 10https://gerrit.wikimedia.org/r/502983 (owner: 10Jeroen De Dauw) [08:25:42] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Allow per-session log out - https://phabricator.wikimedia.org/T37220 (10Ankit-Maity) >>! In T37220#5157831, @Jdlrobson wrote: > Duplicate of T51890? In that task you say that you cannot be lo... [08:27:47] (03PS1) 10D3r1ck01: MobileContextTest: Fix PHPDoc canonical order for parameter [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 [08:32:01] (03PS2) 10D3r1ck01: ContentProviderFactoryTest: Remove unused vars in test suits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508104 [08:33:21] (03PS3) 10D3r1ck01: ContentProviderFactoryTest: Remove unused vars in test suits [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508104 [08:37:03] (03PS5) 10Thiemo Kreuz (WMDE): Simplify some overly complicated regular expressions [core] - 10https://gerrit.wikimedia.org/r/499469 [08:37:39] (03PS1) 10simetrical: NS_MEDIA also always has page_id 0 [core] - 10https://gerrit.wikimedia.org/r/508106 [08:40:13] 10InternetArchiveBot: The arhive url dosn't show the requiered page - https://phabricator.wikimedia.org/T222532 (10Ascilto) [08:40:53] 10InternetArchiveBot: The arhive url dosn't show the requiered page - https://phabricator.wikimedia.org/T222532 (10Ascilto) Please don't replace the link http://www.polishund.se/index.php?option=com_content&view=article&id=73&Itemid=71 in any article on svwp. The archive url don't lead to the required page. Kind... [08:46:28] (03PS5) 10Thiemo Kreuz (WMDE): Use end() to get the last element in an array [core] - 10https://gerrit.wikimedia.org/r/499468 [08:47:34] 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Tgr) So the page is move+deleted, edit (also view/history) tries to show a move log snippet, and `LogEventsList::showLogExtract` explodes. Probably due to {b6e1e99}? https://e... [08:52:22] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508104 (owner: 10D3r1ck01) [08:52:38] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508105 (owner: 10D3r1ck01) [09:01:42] 10Developer-Advocacy, 10Core Platform Team Backlog (Watching / External): Evaluate and set up a test instance of FOSS persistent chat software as a companion to Q&A system for communication with third-party developers - https://phabricator.wikimedia.org/T184606 (10Tgr) The engineering community manager of Mozi... [09:04:49] (03CR) 10Jeroen De Dauw: [C: 03+1] Allow getting db connection from Database [core] - 10https://gerrit.wikimedia.org/r/501119 (https://phabricator.wikimedia.org/T220155) (owner: 10Alaa Sarhan) [09:22:06] 10MediaWiki-extensions-UrlShortener: Add new "button" for Wiki URL shortener in the menu in Wikipedia - https://phabricator.wikimedia.org/T222360 (10Shizhao) I coding a user script, see https://zh.wikipedia.org/wiki/User:Shizhao/shorturl.js [09:25:46] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Aklapper) [09:27:19] 10UniversalLanguageSelector: Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10Aklapper) (@Ammarpad: #Mediawiki-extensions-LanguageSelector is not installed on Wikimedia sites. See the project tag description.) [09:29:00] 10MediaWiki-Internationalization, 10MediaWiki-Recent-changes, 10Growth-Team: "Other languages" section in side bar is empty on Special:RecentChanges of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10Aklapper) [09:30:12] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10borogovia) It is requested to keep the config change on hold. Further discussion is needed on zhwiki before enabling the config change, as disabli... [09:30:27] 10MediaWiki-Internationalization, 10UniversalLanguageSelector: "Other languages" section in side bar is empty on Special:RecentChanges of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10Aklapper) Hmm, adding `&uselang=qqx` to the URL, the section shows `uls-plang-title-languages` so I assu... [09:38:52] 10UniversalLanguageSelector: Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10Amire80) a:03Amire80 This is already done at https://github.com/wikimedia/language-data/commit/0fa70d9beeb26cf883aeb099391a8cf32a1edb49 . For technical reasons it may take a bit... [09:38:56] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10RhinosF1) [09:39:16] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10RhinosF1) [09:40:03] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10RhinosF1) Update: Edit raw watchlist and blanking that also fails with same error [09:40:26] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Shizhao) 05Open→03Stalled peer @borogovia [09:41:47] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10RhinosF1) [09:41:49] (03PS3) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [09:41:54] 10UniversalLanguageSelector: Test major late 2018 language-data BCP 47 update - https://phabricator.wikimedia.org/T222534 (10Amire80) [09:42:44] (03CR) 10simetrical: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [09:42:52] 10UniversalLanguageSelector: Change the autonym of Javanese from "Basa Jawa" to "Jawa" - https://phabricator.wikimedia.org/T222524 (10Amire80) [09:42:56] 10UniversalLanguageSelector: Test major late 2018 language-data BCP 47 update - https://phabricator.wikimedia.org/T222534 (10Amire80) [09:42:58] 10ULS-CompactLinks, 10UniversalLanguageSelector, 10Wikimedia-Interwiki-links, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: Simple English not shown in “Languages” section of pages for interwiki linking - https://phabricator.wikimedia.org/T210840 (10Amire80) [09:46:52] (03CR) 10simetrical: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [09:46:55] (03CR) 10jerkins-bot: [V: 04-1] Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [09:47:53] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10Aklapper) Usually this only happened with many more watchlist entries, see T41510. Maybe this is instead somehow related to T220245? [09:52:14] 10Graphs, 10Mobile, 10Readers-Web-Backlog (Tracking): Graphs create img tags without width and height - https://phabricator.wikimedia.org/T216431 (10Jc86035) The reason that it works is that [[ https://en.wikipedia.org/wiki/Template:Graph:Chart/styles.css | Template:Graph:Chart/styles.css ]] contains a CSS f... [09:52:48] 10UniversalLanguageSelector: Test major late 2018 language-data BCP 47 update - https://phabricator.wikimedia.org/T222534 (10Amire80) [10:13:46] (03PS2) 10Daimona Eaytoy: [WIP] Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [10:14:43] (03PS29) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [10:33:03] (03PS10) 10Daimona Eaytoy: Handle nested calls [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507065 [10:38:40] 10Wikipedia-Requests-App: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Munja) [10:43:01] 04(no projects): increasing abuse of installations of wikimedia application - https://phabricator.wikimedia.org/T222536 (10Billinghurst) [11:04:18] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Wong128hk) @RazeSoldier It seems that it is not necessary to disable $wgKartographerEnableMapFrame if applying the English Wikipedia Model on Chines... [11:08:00] (03PS11) 10Daimona Eaytoy: Handle nested calls [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507065 [11:08:18] (03PS8) 10Daimona Eaytoy: Add a file with base config [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507101 [11:08:22] (03PS4) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [11:08:26] (03PS3) 10Daimona Eaytoy: Hack: exclude OOUI constructors from DoubleEscape reporting [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 [11:08:30] (03PS3) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [11:08:36] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10RazeSoldier) What is "the English Wikipedia Model"? enwiki set `$wgFlaggedRevsOverride=false` [11:08:44] (03PS3) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [11:09:09] (03PS4) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [11:09:17] (03PS2) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [11:09:26] (03PS5) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [11:09:30] (03PS4) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [11:09:37] (03PS4) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [11:09:41] (03PS5) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [11:09:45] (03PS4) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [11:09:58] (03PS2) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [11:10:06] (03PS3) 10Daimona Eaytoy: [WIP] Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [11:12:32] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) >>! In T221933#5158028, @RazeSoldier wrote: > What is "the English Wikipedia Model"? enwiki set `$wgFlaggedRevsOverride=false`, so unnecessa... [11:17:01] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Munja) >>! In T222535#5158021, @Ammarpad wrote: > Non-admins cannot change contentmodel of a page, that works as it should. Can you clarify on the error message seen by the admin who trie... [11:17:34] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) >>! In T221933#5158029, @KirkLU wrote: >>>! In T221933#5158028, @RazeSoldier wrote: >> What is "the English Wikipedia Model"? enwiki set `$w... [11:20:36] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10RazeSoldier) We can set `$wgFlaggedRevsOverride=false`, default `true`. [11:33:13] (03CR) 10simetrical: Convert filerepo to use LinkTarget (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) (owner: 10simetrical) [11:33:54] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) >>! In T221933#5158036, @RazeSoldier wrote: > We can set `$wgFlaggedRevsOverride=false`, default `true`. > > See T221933#5140456 and T22193... [11:34:06] (03PS14) 10simetrical: Convert filerepo to use LinkTarget [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) [11:37:06] (03PS11) 10simetrical: Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) [11:39:38] (03PS9) 10simetrical: Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 [11:39:40] (03PS10) 10simetrical: Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 [11:41:09] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10RazeSoldier) > So setting `$wgFlaggedRevsOverride=false` is necessary and fits in the need and agreement in zhwiki. Have a community consensus? [11:41:13] (03PS3) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [11:48:35] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) Yes, of course, we can find the consensus in the [[ https://zh.wikipedia.org/wiki/Wikipedia:%E4%BA%92%E5%8A%A9%E5%AE%A2%E6%A0%88/%E6%96%B9%E... [11:48:47] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Simetrical) So this is an actual bug -- until now, we were presumably creating a bogus link (to ).... [11:54:49] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) >>! In T221933#5158038, @RazeSoldier wrote: >> So setting `$wgFlaggedRevsOverride=false` is necessary and fits in the need and agreement in... [11:56:00] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Aklapper) Hi @Munja, thanks for taking the time to report this! Unfortunately this report lacks information. If you have time and can still reproduce the problem: Please [[ https://www.me... [11:56:06] (03PS4) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [11:56:44] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10Wong128hk) >>! In T221933#5158038, @RazeSoldier wrote: >> So setting `$wgFlaggedRevsOverride=false` is necessary and fits in the need and agreem... [11:59:08] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10KirkLU) >>! In T221933#5158044, @Wong128hk wrote: > > > > >>>! In T221933#5158038, @RazeSoldier wrote: >>> So setting `$wgFlaggedRevsOverride=fa... [12:02:28] 04(no projects): increasing abuse of installations of wikimedia application - https://phabricator.wikimedia.org/T222536 (10Aklapper) By "wikimedia application", did you mean "MediaWiki"? Since T85327 in 1.27, https://www.mediawiki.org/wiki/Manual:Combating_spam is linked right after installing MediaWiki. T1947... [12:05:40] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Zoranzoki21) I am administrator on Serbian Wikipedia and when I go at https://sr.wikipedia.org/wiki/Special:ChangeContentModel I get same message which @Munja provided at T222535#5158033.... [12:06:26] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-Hackathon-2019: Passwordless login (login with your smartphone) - https://phabricator.wikimedia.org/T220418 (10Frettie) Only for Android phone again? Security feature? Really? There is not only Android positive MediaWiki users ... Unfortunately Commo... [12:13:04] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Zoranzoki21) [12:13:46] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Ammarpad) >>! In T222535#5158033, @Munja wrote: > Here's the screenshot: https://bs.wikipedia.org/wiki/Datoteka:Aufzeichnen.JPG > > Translation: > There are some problems with your entry... [12:14:25] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Zoranzoki21) >>! In T222535#5158057, @Ammarpad wrote: >>>! In T222535#5158033, @Munja wrote: >> Here's the screenshot: https://bs.wikipedia.org/wiki/Datoteka:Aufzeichnen.JPG >> >> Transl... [12:23:28] 10MediaWiki-extensions-CSS: [CSS] Some CSS stripped by MediaWiki parser CSS sanitizer - https://phabricator.wikimedia.org/T37820 (10Izno) [12:23:48] (03PS4) 10Daimona Eaytoy: [WIP] Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [12:28:18] 10Wikimedia-Hackathon-2019-Organization: Fix the Prague Hackathon 2019 directions PDFs on Commons - https://phabricator.wikimedia.org/T220206 (10Frettie) https://commons.wikimedia.org/wiki/File:Hotel_to_venue_directions.pdf was deleted (maybe it will be small problem :) ) https://commons.wikimedia.org/wiki/File... [12:28:24] (03PS5) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [12:38:37] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Mimihitam) @Pginer-WMF the threshold is already working well. **The only final adjustment that needs to be made is that source version should become the default instead... [12:41:13] (03CR) 10Fomafix: "I thought on packageFiles with config. But now I realized that a central user ID depends on the user and can not be a generic module param" [core] - 10https://gerrit.wikimedia.org/r/500848 (owner: 10Jforrester) [13:07:56] 10ISA: Discuss whether to include 'mark as prominent' option when adding depicts statements - https://phabricator.wikimedia.org/T222537 (10NavinoEvans) [13:19:26] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist clearing fails with too many pages - https://phabricator.wikimedia.org/T222533 (10RhinosF1) @Aklapper Interestingly, my watchlist is now showing as empty. [13:38:21] 10Editing QA, 10Patch-For-Review, 10VisualEditor (Current work): [Regression] Cursor moves to the beginning of the article on mobile VE while adding manual citation - https://phabricator.wikimedia.org/T221291 (10Esanders) 3 is expected, it shows the citation is not finished yet. 1&2 should be filed as bugs. [14:10:56] (03CR) 10Yaron Koren: "This looks good to me... my only real comment is that this patch adds some unneeded changes, like extra tabs and an extra "c" in "necessar" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [14:16:21] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-Hackathon-2019: Passwordless login (login with your smartphone) - https://phabricator.wikimedia.org/T220418 (10Aklapper) >>! In T220418#5158053, @Frettie wrote: > Only for Android phone again? Security feature? Really? @Frettie: Yeah, really. No need f... [14:22:36] BaileyJM02/HelioWiki#1 (master - 5a17e70 Bailey Matthews): The build has errored. - https://travis-ci.com/BaileyJM02/HelioWiki/builds/110655541 [14:24:38] BaileyJM02/HelioWiki#1 (master - 5a17e70 Bailey Matthews): The build has errored. - https://travis-ci.com/BaileyJM02/HelioWiki/builds/110655541 [14:43:54] (03PS1) 10D3r1ck01: store: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 [14:44:09] 10MediaWiki-Watchlist, 10Growth-Team: Special:Watchlist takes a while to update when the watchlist is cleared - https://phabricator.wikimedia.org/T222533 (10RhinosF1) [14:51:20] (03PS1) 10D3r1ck01: TorExitNodes: Avoid deprecated use of ObjectCache::getMainStashInstance() [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/508114 [14:54:46] (03PS4) 10Duncancrane: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 [14:55:51] BaileyJM02/HelioWiki#2 (master - 10cfeac Bailey Matthews): The build has errored. - https://travis-ci.com/BaileyJM02/HelioWiki/builds/110656738 [14:55:52] (03PS1) 10D3r1ck01: objectcache: Hard deprecate ObjectCache::getMainStashInstance() [core] - 10https://gerrit.wikimedia.org/r/508115 [14:59:42] BaileyJM02/HelioWiki#2 (master - 10cfeac Bailey Matthews): The build has errored. - https://travis-ci.com/BaileyJM02/HelioWiki/builds/110656738 [15:01:14] (03PS5) 10Duncancrane: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 [15:02:03] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/508113 (owner: 10D3r1ck01) [15:03:53] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/508114 (owner: 10D3r1ck01) [15:04:40] (03PS6) 10Duncancrane: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 [15:08:00] (03CR) 10Duncancrane: "> Patch Set 3:" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [15:14:22] (03CR) 10Yaron Koren: [C: 03+2] "Yeah, it looks good now!" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [15:15:11] (03CR) 10jerkins-bot: [V: 04-1] Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [15:15:15] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508115 (owner: 10D3r1ck01) [15:23:13] (03PS1) 10D3r1ck01: objectcache: Default params should be on right side of non-default params [core] - 10https://gerrit.wikimedia.org/r/508117 [15:42:05] (03CR) 10Yaron Koren: [C: 03+2] "Looks like you need to add a comma before the new line added to extension.json. (Really, that change should be in a separate patch, but it" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [15:42:53] (03CR) 10jerkins-bot: [V: 04-1] Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [15:45:42] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10jeblad) [15:46:31] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508117 (owner: 10D3r1ck01) [15:48:10] (03PS1) 10D3r1ck01: Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 [16:09:22] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [16:16:33] 10MediaWiki-General-or-Unknown: ?uselang= URL parameter should persist until removed by the user - https://phabricator.wikimedia.org/T221881 (10Aklapper) [16:16:35] 10MediaWiki-Internationalization: ?uselang= parameter value must be used consistently within a page and its dynamic constituents. - https://phabricator.wikimedia.org/T31733 (10Aklapper) [16:17:06] 10MediaWiki-Stakeholders-Group: MWStake meet-up - https://phabricator.wikimedia.org/T194238 (10Aklapper) 05Open→03Resolved No reply, hence closing. [16:19:14] (03CR) 10Daniel Kinzler: [C: 03+2] Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [16:19:24] (03CR) 10Daniel Kinzler: [C: 03+2] Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [16:20:11] (03CR) 10simetrical: [C: 03+1] "Whoops -- thanks! Looks good to me other than the two nitpicks below." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [16:22:08] (03PS2) 10D3r1ck01: Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 [16:22:38] (03CR) 10D3r1ck01: Permissions: Declare the $nsInfo property and document it in constructor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [16:37:36] (03PS1) 10D3r1ck01: InlineDiffFormatter: Call `escapeWhiteSpace()` using `self::` not `$this` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 [16:37:51] (03CR) 10D3r1ck01: "Thanks for the review @Simetrical, mistake corrected." [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [16:38:28] (03PS1) 10DmitriyShevliakov: Integration TagSearch [extensions/BlueSpiceExtendedSearch] (REL1_31) - 10https://gerrit.wikimedia.org/r/508120 [16:42:23] (03Merged) 10jenkins-bot: Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [16:42:30] (03Merged) 10jenkins-bot: Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [16:48:15] 10Lingua Libre: Infom the speaker that (s)he already records a word - https://phabricator.wikimedia.org/T222541 (10Pamputt) [16:49:09] (03CR) 10jenkins-bot: Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [16:53:41] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10Aklapper) 05Open→03Stalled Cannot reproduce. Your link shows `Vis de nyeste endringene`, but it take... [16:53:47] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508119 (owner: 10D3r1ck01) [16:56:08] (03CR) 10jenkins-bot: Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [17:00:01] (03CR) 10jerkins-bot: [V: 04-1] Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [17:03:37] (03PS30) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [17:05:30] 10MediaWiki-extensions-TwnMainPage, 10Patch-For-Review, 10User-abi_: Logspam from TwnMainPage: Undefinex index: [group id] in multiple locations - https://phabricator.wikimedia.org/T220583 (10abi_) >>! In T220583#5151901, @Nikerabbit wrote: > It seems I had misdiagnosed the issue. By inspecting code, the cau... [17:06:22] (03PS7) 10Duncancrane: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 [17:06:25] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10jeblad) Actually, you did reproduce the bug. The sysmsg is `Vis nye endringer siden $1`, but the shown... [17:07:58] (03CR) 10Gergő Tisza: [C: 03+2] "Thanks!" [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/508102 (https://phabricator.wikimedia.org/T161248) (owner: 10Luca Mauri) [17:08:02] (03CR) 10Duncancrane: "> Patch Set 6:" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [17:08:13] (03CR) 10Yaron Koren: [C: 03+2] "(Sorry, meant composer.json.)" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [17:10:04] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10JJMC89) I don't think it should show those errors unless you press change without providing a title. [17:12:13] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Munja) >>! In T222535#5158199, @JJMC89 wrote: > I don't think it should show those errors unless you press change without providing a title. I did not change because I have not permissio... [17:12:37] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Munja) 05Open→03Resolved p:05Triage→03Lowest [17:13:15] (03Merged) 10jenkins-bot: Introduction to the extension and link to homepage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/508102 (https://phabricator.wikimedia.org/T161248) (owner: 10Luca Mauri) [17:13:17] (03CR) 10jerkins-bot: [V: 04-1] Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [17:14:01] (03CR) 10jenkins-bot: Introduction to the extension and link to homepage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/508102 (https://phabricator.wikimedia.org/T161248) (owner: 10Luca Mauri) [17:15:07] 10MediaWiki-Special-pages: ChangeContentModel on bs.Wikipedia // Sanitized CSS - https://phabricator.wikimedia.org/T222535 (10Zoranzoki21) 05Resolved→03Invalid p:05Lowest→03Triage Nothing changed in code so this task should be closed as invalid.. [17:15:28] 10MediaWiki-Special-pages: Special:ChangeContentModel shows errors before the form is submitted - https://phabricator.wikimedia.org/T222535 (10JJMC89) 05Invalid→03Open [17:16:15] 10MediaWiki-Special-pages: Special:ChangeContentModel shows errors before the form is submitted - https://phabricator.wikimedia.org/T222535 (10JJMC89) >>! In T222535#5158199, @JJMC89 wrote: > I don't think it should show those errors unless you press change without providing a title. I've repurposed this ticket... [17:22:59] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10jeblad) Tried to go to enwiki, which has the timestamp, and then change the English language to Norwegia... [17:24:26] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10isaacl) >>! In T218511#5107077, @IKhitron wrote: >>>! In T2185... [17:26:07] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) Well, there is a new bug now, see above. Maybe it co... [17:30:41] (03PS1) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [17:34:42] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-General-or-Unknown: Blocks should be an implementation detail of an abstract authorization system - https://phabricator.wikimedia.org/T212311 (10Izno) [17:49:09] (03PS1) 10Yaron Koren: Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 [17:51:08] (03CR) 10jerkins-bot: [V: 04-1] Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 (owner: 10Yaron Koren) [17:53:48] (03PS2) 10Yaron Koren: Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 [17:55:47] (03CR) 10jerkins-bot: [V: 04-1] Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 (owner: 10Yaron Koren) [17:57:03] (03CR) 10simetrical: [C: 03+1] Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [18:00:17] (03PS5) 10D3r1ck01: logging: Replace use of deprecated Linker::link() with LinkRenderer [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/504858 [18:06:08] 10Lingua Libre: Infom the speaker that (s)he already recorded a word - https://phabricator.wikimedia.org/T222541 (10Pamputt) [18:07:02] (03PS3) 10Yaron Koren: Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 [18:07:37] (03PS5) 10Daimona Eaytoy: Set taintedness to NO_TAINT for class-string and callable-string [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506902 [18:08:16] (03PS4) 10Daimona Eaytoy: Take into account implicit BranchScopes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507015 [18:08:29] (03PS12) 10Daimona Eaytoy: Handle nested calls [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507065 [18:08:33] (03PS9) 10Daimona Eaytoy: Add a file with base config [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507101 [18:08:37] (03PS5) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [18:08:40] (03PS4) 10Daimona Eaytoy: Hack: exclude OOUI constructors from DoubleEscape reporting [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 [18:08:43] (03PS4) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [18:08:47] (03PS4) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [18:08:51] (03PS5) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [18:08:55] (03PS3) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [18:08:59] (03PS6) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [18:09:03] (03PS5) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [18:09:14] (03PS5) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [18:09:17] (03PS6) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [18:09:20] (03PS5) 10Daimona Eaytoy: Further improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508082 [18:09:24] (03PS3) 10Daimona Eaytoy: Visit AST_EMPTY [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508085 [18:09:27] (03PS6) 10Daimona Eaytoy: Be smarter with reassignments of the same var [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508091 [18:09:32] (03PS2) 10Daimona Eaytoy: Add some unhandled node kinds [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/508124 [18:10:15] (03PS11) 10simetrical: Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 [18:10:28] (03CR) 10simetrical: "Seems like the new tests picked up a bug in Postgres support that was always around." [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [18:13:12] (03PS5) 10simetrical: Introduce MovePageFactory [core] - 10https://gerrit.wikimedia.org/r/507551 [18:13:28] (03CR) 10Yaron Koren: [C: 03+2] Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 (owner: 10Yaron Koren) [18:13:51] (03PS4) 10simetrical: Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 [18:13:55] (03CR) 10simetrical: Introduce MovePageFactory (035 comments) [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [18:24:42] (03Merged) 10jenkins-bot: Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 (owner: 10Yaron Koren) [18:32:56] (03PS8) 10Yaron Koren: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [18:33:00] (03PS9) 10Yaron Koren: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [18:34:44] 10MediaWiki-General-or-Unknown: Where should page move permissions go? - https://phabricator.wikimedia.org/T222545 (10Simetrical) [18:41:17] (03CR) 10Yaron Koren: [C: 03+2] Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [18:46:02] (03Merged) 10jenkins-bot: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [18:46:50] 10MediaWiki-Internationalization, 10UniversalLanguageSelector: "Other languages" section in side bar is empty on Special:RecentChanges of Minangkabau Wikipedia - https://phabricator.wikimedia.org/T222523 (10Amire80) Did it work recently? Special:RecentChanges and other special pages are actually not supposed... [18:49:15] (03PS2) 10Yaron Koren: Hook 'SkinEditSectionLinks' does now the HTML escaping [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/506959 (owner: 10Fomafix) [18:49:55] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10jeblad) [18:55:55] (03CR) 10Yaron Koren: "Wait... what happened to the code change? Or should this patch be abandoned?" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/506959 (owner: 10Fomafix) [18:56:00] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special page recent changes failes to use MediaWiki:Rcfilters-show-new-changes - https://phabricator.wikimedia.org/T222539 (10jeblad) @Nikerabbit Could this be an error due to the update being turned off for a short time? [18:56:09] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-notice: After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Stryn) I have seen pages on my watchlist marked as read even t... [19:02:21] (03CR) 10jenkins-bot: Fix for hooks that pass TitleValue instead of Title [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/508125 (owner: 10Yaron Koren) [19:03:06] (03CR) 10jenkins-bot: Fix for tables when used in PageForms. [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [19:03:59] 10MediaWiki-Special-pages: Special:ChangeContentModel shows errors before the form is submitted - https://phabricator.wikimedia.org/T222535 (10Ammarpad) >>! In T222535#5158228, @JJMC89 wrote: >>>! In T222535#5158199, @JJMC89 wrote: >> I don't think it should show those errors unless you press change without prov... [19:05:39] 10MediaWiki-Special-pages: Special:ChangeContentModel shows errors before the form is submitted - https://phabricator.wikimedia.org/T222535 (10Ammarpad) [19:05:52] (03CR) 10Daniel Kinzler: "What motivates this change? Is there a ticket for this?" [core] - 10https://gerrit.wikimedia.org/r/508106 (owner: 10simetrical) [19:07:17] (03CR) 10Daniel Kinzler: [C: 03+2] Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [19:08:08] 10MediaWiki-Documentation, 10MediaWiki-extensions-OAuthAuthentication, 10Documentation, 10Patch-For-Review: Installation instructions of OAuthAuthentication are useless - https://phabricator.wikimedia.org/T161248 (10lucamauri) 05Open→03Resolved As I haven't received any comments or complains and the mo... [19:09:18] (03CR) 10Daniel Kinzler: [C: 03+2] Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [19:12:52] (03CR) 10Daniel Kinzler: [C: 03+2] Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [19:15:20] (03PS1) 10Kghbln: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) [19:18:12] (03CR) 10Daniel Kinzler: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [19:18:30] (03PS2) 10Kghbln: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) [19:19:20] (03CR) 10Daniel Kinzler: [C: 04-1] "Issue with order of initialization needs investigation. Probably worth a ticket." [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [19:20:23] (03PS3) 10Kghbln: Extend and change docu for $wgCirrusSearchClusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) [19:22:45] (03Merged) 10jenkins-bot: Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [19:22:47] (03CR) 10jerkins-bot: [V: 04-1] Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [19:22:49] (03CR) 10Kghbln: "I am not sure if this is the right spot or if this should be added directly after the first paragraph. This is however my intuitively made" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [19:28:19] (03CR) 10jenkins-bot: Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [19:29:32] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/508129 (https://phabricator.wikimedia.org/T221547) (owner: 10Kghbln) [19:31:15] (03CR) 10jenkins-bot: Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [19:35:42] (03Merged) 10jenkins-bot: Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [19:39:51] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team: Special:RecentChanges on no.wp ignores localized MediaWiki:Rcfilters-show-new-changes message - https://phabricator.wikimedia.org/T222539 (10Aklapper) 05Stalled→03Open [19:39:57] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks good to me, but I'd really like more eyes on the new code for namespace protection checks." [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [19:41:20] (03CR) 10jenkins-bot: Permissions: Declare the $nsInfo property and document it in constructor [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [19:43:28] (03CR) 10Daniel Kinzler: [C: 03+2] "needs a manual rebase, probably because of a conflict in the release notes." [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [19:43:39] (03CR) 10jerkins-bot: [V: 04-1] Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [19:48:12] 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10Kghbln) @EBernhardson @debt Yesterday I successfully tested switching to a non-standard elasticsearch port and the configuration example works ou... [19:48:16] (03CR) 10D3r1ck01: "Thank you for reviewing and merging @Daniel!" [core] - 10https://gerrit.wikimedia.org/r/508118 (owner: 10D3r1ck01) [19:49:52] 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file - https://phabricator.wikimedia.org/T222516 (10lucamauri) >>! In T222516#5157689, @Reedy wrote: > I note we don't "replace" anything, but we do add to it. These things are in the wild, so n... [19:52:31] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10daniel) As a stop gap, I propose to have Linker::userToolLinks bail out early if the user name is empty, returning an empty string or an (HTM... [19:53:13] 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file - https://phabricator.wikimedia.org/T222516 (10lucamauri) @Reedy please allow me a question: why you made this task a //parent// of [[ https://phabricator.wikimedia.org/T221149 | T221149 ]]... [20:00:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/508131 (owner: 10L10n-bot) [20:01:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/508132 (owner: 10L10n-bot) [20:02:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Poncho] - 10https://gerrit.wikimedia.org/r/508134 (owner: 10L10n-bot) [20:02:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508133 (owner: 10L10n-bot) [20:03:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/508135 (owner: 10L10n-bot) [20:04:03] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-Hackathon-2019: Passwordless login (login with your smartphone) - https://phabricator.wikimedia.org/T220418 (10Frettie) >>! In T220418#5158105, @Aklapper wrote: >>>! In T220418#5158053, @Frettie wrote: >> Only for Android phone again? Security feature?... [20:04:12] (03Abandoned) 10Fomafix: Hook 'SkinEditSectionLinks' does now the HTML escaping [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/506959 (owner: 10Fomafix) [20:06:33] 10Operations-Software-Development: Cumin leading zeros in host grouping alter hostname - https://phabricator.wikimedia.org/T222480 (10Krenair) >>! In T222480#5157421, @Volans wrote: > Given the above I'm leaning to leave all as is on the Cumin side and just take advantage of the fix once it will be available ups... [20:07:27] 10Operations-Software-Development, 10Upstream: Cumin leading zeros in host grouping alter hostname - https://phabricator.wikimedia.org/T222480 (10Krenair) [20:21:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/508136 (owner: 10L10n-bot) [20:22:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AddPersonalUrls] - 10https://gerrit.wikimedia.org/r/508137 (owner: 10L10n-bot) [20:23:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/508138 (owner: 10L10n-bot) [20:23:58] 10MediaWiki-Stakeholders-Group: MWStake meet-up at 2018 Wikimedia Hackathon - https://phabricator.wikimedia.org/T194238 (10Tgr) [20:24:44] 04(no projects): My mathboot tool stopped working - https://phabricator.wikimedia.org/T222547 (10OlegAlexandrov) [20:26:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/508139 (owner: 10L10n-bot) [20:27:05] 10MediaWiki-Stakeholders-Group, 10Wikimedia-Hackathon-2019: Third-party MediaWiki user meet-up at 2019 Wikimedia Hackathon - https://phabricator.wikimedia.org/T222548 (10Tgr) [20:27:23] 10MediaWiki-Stakeholders-Group: MWStake meet-up at 2018 Wikimedia Hackathon - https://phabricator.wikimedia.org/T194238 (10Tgr) Current year: {T222548} [20:29:01] (03CR) 10Vedmaka Wakalaka: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [20:45:30] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Integrate SVG Translate with Content Translation - https://phabricator.wikimedia.org/T220440 (10Townie) @Petar.petkovic What do you think of these proposals? Which one would you go for first? [20:58:12] 10Wikimedia-General-or-Unknown, 10Patch-For-Review: Adapt http://www.mediawiki.org/xml/sitelist-1.0/ for the new XSD file - https://phabricator.wikimedia.org/T222516 (10Reedy) >>! In T222516#5158297, @lucamauri wrote: >>>! In T222516#5157689, @Reedy wrote: >> I note we don't "replace" anything, but we do add t... [21:01:44] 10InternetArchiveBot: The archive url doesn't show the required page - https://phabricator.wikimedia.org/T222532 (10Reedy) [21:05:28] 10MediaWiki-Logging, 10MediaWiki-Revision-backend, 10Wikimedia-production-error: Wikimedia\Assert\ParameterAssertionException on enwiktionary - https://phabricator.wikimedia.org/T222529 (10Tgr) So the [[https://en.wiktionary.org/wiki/Special:Contributions/Conversion_script|conversion script revisions]] have... [21:09:09] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Reedy) It should've been updated on the 1st... [21:17:16] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-OAuthAuthentication: oauthclient-php should not depend on curl - https://phabricator.wikimedia.org/T222550 (10Tgr) [21:17:32] 10MediaWiki-Documentation, 10MediaWiki-extensions-OAuthAuthentication, 10Documentation, 10Patch-For-Review: Installation instructions of OAuthAuthentication are useless - https://phabricator.wikimedia.org/T161248 (10Tgr) >>! In T161248#5091974, @lucamauri wrote: > When I first installed the extension, it k... [21:18:57] 10MediaWiki-General-or-Unknown, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Backlog (Later): Review dummy revisions (page moves, page protection) and whether they should increment edit count - https://phabricator.wikimedia.org/T201891 (10GeoffreyT2000) [21:19:03] 10MediaWiki-Special-pages, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Later), 10Patch-For-Review: Increment edit count for all page moves, not just Special:MovePage moves - https://phabricator.wikimedia.org/T195550 (10GeoffreyT2000) 05Open... [21:20:39] 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Update article count on hawiki - https://phabricator.wikimedia.org/T222527 (10Reedy) >I believe the stats are incorrect because whenever a page is moved the number goes down by one and never come back. Have observed so for a while. See {T195550} [21:21:10] 10MediaWiki-Documentation, 10MediaWiki-extensions-OAuthAuthentication, 10Documentation, 10Patch-For-Review: Installation instructions of OAuthAuthentication are useless - https://phabricator.wikimedia.org/T161248 (10Tgr) Thanks for fixing the docs, Luca! [21:23:57] (03PS1) 10Gergő Tisza: Note curl dependency in composer.json [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508140 (https://phabricator.wikimedia.org/T222550) [21:31:35] 10MediaWiki-extensions-UrlShortener: Add new "button" for Wiki URL shortener in the menu in Wikipedia - https://phabricator.wikimedia.org/T222360 (10Ladsgroup) The sidebar feature already exists, just needs to be rolled out by CPT. cc @Legoktm, @Fjalapeno and @CCicalese_WMF [21:32:57] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-Hackathon-2019: Passwordless login (login with your smartphone) - https://phabricator.wikimedia.org/T220418 (10Aklapper) I'm not sure what you want to imply by "this is a security feature" and what you mean by "free to develop". Feel free to elaborate i... [21:33:08] 10MediaWiki-Authentication-and-authorization, 10Patch-For-Review, 10Security, 10User-notice, 10Vuln-DoS: Use token when logging out - https://phabricator.wikimedia.org/T25227 (10Ladsgroup) >>! In T25227#5157476, @Reedy wrote: > This patch is still open atm I would be very happy to move this patch to anot... [21:39:21] (03PS1) 10D3r1ck01: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 [21:42:53] (03PS2) 10D3r1ck01: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 [21:45:53] (03CR) 10jerkins-bot: [V: 04-1] Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (owner: 10D3r1ck01) [21:46:08] (03CR) 10jerkins-bot: [V: 04-1] Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (owner: 10D3r1ck01) [21:48:57] 10Timeless, 10CSS, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): Regressions caused by Timeless-specific form styles removal and related changes - https://phabricator.wikimedia.org/T221345 (10ashley) 05Open→03Resolved a:03Isarra [21:53:22] (03PS7) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [21:54:23] (03CR) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [21:55:23] (03PS3) 10D3r1ck01: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 [21:55:31] (03CR) 10Vedmaka Wakalaka: "> Patch Set 6:" (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [21:55:33] (03CR) 10jerkins-bot: [V: 04-1] Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [21:57:29] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/508142 [21:59:42] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/508143 [22:00:46] (03CR) 10jerkins-bot: [V: 04-1] Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (owner: 10D3r1ck01) [22:01:07] (03PS8) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [22:03:50] (03CR) 10jerkins-bot: [V: 04-1] Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [22:06:46] (03PS9) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [22:07:37] (03PS31) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [22:17:52] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: impact module - https://phabricator.wikimedia.org/T216217 (10Etonkovidova) [22:17:56] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10Etonkovidova) 05Open→03Resolved Moving f... [22:20:01] (03PS27) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods usage [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [22:27:31] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceGroupManager] - 10https://gerrit.wikimedia.org/r/508144 [22:29:15] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceHideTitle] - 10https://gerrit.wikimedia.org/r/508145 [22:29:56] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods usage [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [22:32:00] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInsertMagic] - 10https://gerrit.wikimedia.org/r/508146 [22:32:14] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/508147 [22:32:30] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/508148 [22:32:43] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/508149 [22:33:04] (03PS4) 10D3r1ck01: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 [22:35:12] (03PS28) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods usage [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [22:44:44] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods usage [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [22:47:02] (03PS5) 10D3r1ck01: Replace use of `MobileContext::singleton()` with MC service [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) [22:49:37] (03PS29) 10Vedmaka Wakalaka: Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) [23:00:33] 10WMEE: Riigikogu liikmete pildid Wikimedia Commonsisse - https://phabricator.wikimedia.org/T222553 (10kruusamagi) [23:01:01] 10WMEE: Riigikogu liikmete pildid Wikimedia Commonsisse - https://phabricator.wikimedia.org/T222553 (10kruusamagi) p:05Triage→03Normal [23:01:14] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [23:02:20] (03CR) 10jerkins-bot: [V: 04-1] Deprecates Users isWatched, addWatch, and removeWatch methods [core] - 10https://gerrit.wikimedia.org/r/504043 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [23:04:04] 10WMEE: Postitus WMEE ajaveebi: Wikidata koolides (1-3) - https://phabricator.wikimedia.org/T222554 (10kruusamagi) [23:07:20] 10WMEE: Postitus WMEE ajaveebi: Keila piltidest - https://phabricator.wikimedia.org/T222555 (10kruusamagi) [23:08:40] 10WMEE: Postitus WMEE ajaveebi: Wikimedia Summit 2019 - https://phabricator.wikimedia.org/T222556 (10kruusamagi) [23:09:22] 10WMEE: Postitus WMEE ajaveebi: hariduskonverents 2019 - https://phabricator.wikimedia.org/T222557 (10kruusamagi) [23:09:47] (03CR) 10D3r1ck01: "Putting for first round of review. There are two usage of `MobileContext::singleton()` that when changed to the use of the MC service caus" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/508141 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [23:10:30] 10WMEE: Postitus WMEE ajaveebi: Commonsi piltide kasutamine - https://phabricator.wikimedia.org/T222558 (10kruusamagi) [23:19:10] (03PS1) 10Paladox: Correctly escape numerical options and improve SQL construction [extensions/WikiCategoryTagCloud] (REL1_32) - 10https://gerrit.wikimedia.org/r/508150 [23:19:40] (03CR) 10Samwilson: [C: 03+2] Note curl dependency in composer.json [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508140 (https://phabricator.wikimedia.org/T222550) (owner: 10Gergő Tisza) [23:20:23] (03Merged) 10jenkins-bot: Note curl dependency in composer.json [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508140 (https://phabricator.wikimedia.org/T222550) (owner: 10Gergő Tisza) [23:20:56] (03CR) 10jenkins-bot: Note curl dependency in composer.json [oauthclient-php] - 10https://gerrit.wikimedia.org/r/508140 (https://phabricator.wikimedia.org/T222550) (owner: 10Gergő Tisza) [23:39:44] (03CR) 10Samwilson: [C: 03+1] Correctly escape numerical options and improve SQL construction [extensions/WikiCategoryTagCloud] (REL1_32) - 10https://gerrit.wikimedia.org/r/508150 (owner: 10Paladox) [23:40:37] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Wikimedia-production-error: ParameterAssertionException on page creation: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10PeterBowman) As reported on enwiktionary ([[https://en.wiktionary.org/w/index.php?ti...