[00:05:17] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Design updates for bottom/top bars - https://phabricator.wikimedia.org/T220532 (10ABorbaWMF) Looks good to me on 2.7.280-beta-2019-05-01 [00:07:43] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): [Bug] “Editor tasks“ should be “Suggested edits“ - https://phabricator.wikimedia.org/T221926 (10ABorbaWMF) Looks good to me 2.7.280-beta-2019-05-01 [00:09:14] (03Merged) 10jenkins-bot: Fix display of nested reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [00:12:24] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): CX2: Additional details for too much unmodified content error - https://phabricator.wikimedia.org/T203377 (10Etonkovidova) [00:12:25] (03CR) 10jenkins-bot: Fix display of nested reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [00:17:11] 10MediaWiki-extension-requests, 10Commons: New extension: Image metadata parser functions - https://phabricator.wikimedia.org/T43498 (10Pppery) [00:19:02] 10MediaWiki-extensions-Scribunto: Scribunto should use OOUI - https://phabricator.wikimedia.org/T215045 (10Pppery) [00:24:27] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10WorkType-NewFunctionality: CX2: Show publish settings as a dialog with more detailed descriptions - https://phabricator.wikimedia.org/T197701 (10Petar.petkovic) >>! In T197701#5154797, @Etonkovid... [00:30:02] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): CX2: Additional details for too much unmodified content error - https://phabricator.wikimedia.org/T203377 (10Etonkovidova) Checked in enwiki ( `wmf.3`). @Petar.petkovic - my comments on the items th... [00:34:36] (03CR) 10Smalyshev: Allow per-cluster CirrusSearchMaxShardsPerCluster (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [00:34:51] (03CR) 10Smalyshev: [C: 03+1] Allow per-cluster CirrusSearchMaxShardsPerCluster [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [00:42:35] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10WorkType-NewFunctionality: CX2: Show publish settings as a dialog with more detailed descriptions - https://phabricator.wikimedia.org/T197701 (10Etonkovidova) @Petar.petkovic - you're right! Th... [00:50:55] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10cooltey) PR has been created. https://github.com/wikimedia/wikimedia-page-library/pull/189 [01:03:23] (03CR) 10Jforrester: [C: 03+2] "rechec" [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [01:28:33] (03CR) 10jerkins-bot: [V: 04-1] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [01:33:30] (03PS9) 10Jforrester: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [01:48:52] (03CR) 10Jforrester: [C: 03+2] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [01:58:46] 10Product-Analytics: [REQUEST] Re-run edit interface numbers, with more granularity - https://phabricator.wikimedia.org/T217052 (10Neil_P._Quinn_WMF) 05Open→03Declined On consideration, we don't think spending time to re-do this graph is worth the effort. The issues you've raised are definitely valid, but th... [02:02:45] (03PS1) 10BPirkle: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) [02:11:16] (03CR) 10jerkins-bot: [V: 04-1] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [02:15:51] 10Product-Analytics: Update movement metrics to use new and returning active editors - https://phabricator.wikimedia.org/T222412 (10Neil_P._Quinn_WMF) [02:16:00] 10Product-Analytics: Update movement metrics to use new and returning active editors - https://phabricator.wikimedia.org/T222412 (10Neil_P._Quinn_WMF) a:03Neil_P._Quinn_WMF [02:20:53] 10Product-Analytics, 10VisualEditor (Current work): Instrument structured workflows and their non-stuctured counterparts in the mobile visual editor - https://phabricator.wikimedia.org/T222367 (10Neil_P._Quinn_WMF) [02:32:19] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10alexhollender) Looking sweet. Here are screenshots of what I'm seeing: | | norm... [02:55:09] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10Tgr) [03:01:10] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10Tgr) [03:01:46] 10WikibaseMediaInfo, 10Wikimedia-production-error (Shared Build Failure): WikibaseMediaInfo test MultiLingualCaptionsTest fails - https://phabricator.wikimedia.org/T222416 (10Smalyshev) [03:02:09] 10WikibaseMediaInfo, 10Wikimedia-production-error (Shared Build Failure): WikibaseMediaInfo test MultiLingualCaptionsTest fails - https://phabricator.wikimedia.org/T222416 (10Smalyshev) [03:02:46] 10WikibaseMediaInfo, 10Wikimedia-production-error (Shared Build Failure): WikibaseMediaInfo test MultiLingualCaptionsTest fails - https://phabricator.wikimedia.org/T222416 (10Smalyshev) p:05Triage→03High [03:06:56] 10Security: Add Tgr to security@ - https://phabricator.wikimedia.org/T222417 (10Tgr) [03:29:18] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) >>! In T221177#5154635, @Tgr wrote: > That's the kind of thing you'd use a middleware for. > ... > Keeps the... [04:43:36] 10MediaWiki-Stakeholders-Group, 10User-Tgr, 10events: Organize WMF office mixer during EMWCon 2019 - https://phabricator.wikimedia.org/T211744 (10Tgr) [04:43:39] 10MediaWiki-Stakeholders-Group, 10User-Tgr, 10events: Organize WMF office mixer during EMWCon 2019 - https://phabricator.wikimedia.org/T211744 (10Tgr) 05Open→03Resolved Went well, I think. [05:07:47] 10MediaWiki-General-or-Unknown, 10User-DannyS712: Multiple wikipedia errors - https://phabricator.wikimedia.org/T222418 (10DannyS712) [05:09:37] 10MediaWiki-General-or-Unknown, 10User-DannyS712: Multiple wikipedia errors - https://phabricator.wikimedia.org/T222418 (10DannyS712) [05:10:47] 10MediaWiki-General-or-Unknown, 10User-DannyS712: Multiple wikipedia errors - https://phabricator.wikimedia.org/T222418 (10DannyS712) [05:12:22] 10MediaWiki-General-or-Unknown, 10User-DannyS712: Multiple wikipedia errors - https://phabricator.wikimedia.org/T222418 (10DannyS712) [05:17:09] 10MediaWiki-General-or-Unknown, 10User-DannyS712: Multiple wikipedia errors - https://phabricator.wikimedia.org/T222418 (10Samwilson) I was getting this just now (for watchlists and any search I did) for a couple of minutes, but it is working again now. > Request from [x] via cp1089 cp1089, Varnish XID 106705... [05:34:00] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) I've been reading PSR-7. We already have Guzzle's PSR-7 library as a core dependency, so we could use Guzzle... [05:52:44] 04(no projects): Wikidata links to Commons should appear in Special:WhatLinksHere - https://phabricator.wikimedia.org/T222420 (10Sascha) [06:01:37] (03PS1) 10Samwilson: Treat RfD pages as AfDs instead of redirects [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507913 (https://phabricator.wikimedia.org/T157046) [06:16:50] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [06:20:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Sascha) [06:20:40] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [06:40:43] 10MediaWiki-Vagrant, 10ContentTranslation, 10User-abi_: ContentTranslation role broken in vagrant - https://phabricator.wikimedia.org/T222317 (10abi_) a:03abi_ [06:42:45] 10MediaWiki-Vagrant, 10ContentTranslation, 10User-abi_: ContentTranslation role broken in vagrant - https://phabricator.wikimedia.org/T222317 (10abi_) p:05Triage→03Normal [06:48:49] (03PS3) 10Thiemo Kreuz (WMDE): Move Tidy functionality to TextTruncator [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497490 [06:48:51] (03PS3) 10Thiemo Kreuz (WMDE): Fix truncate code potentially removing whitespace from extract [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497566 [06:49:42] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I had to manually rebase the remaining two patches. No change was made. Restoring the previous +1." [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497566 (owner: 10Thiemo Kreuz (WMDE)) [06:58:28] 10ISA: Implement next-previous on participate page for image navigation - https://phabricator.wikimedia.org/T222421 (10Eugene233) [06:58:30] 10CommRel-Specialists-Support (Apr-Jun-2019): Support the final revision of the medium term plan - https://phabricator.wikimedia.org/T222286 (10Quiddity) p:05Triage→03High [07:36:13] 10MediaWiki-Interwiki, 10Wikidata, 10Wikisource: interwiki links to/from Multilingual Wikisource - https://phabricator.wikimedia.org/T138332 (10Ash_Crow) >>! In T138332#2623867, @Lydia_Pintscher wrote: > It is a blocking issue in so far that an item can only link to one page on a given wiki. If several langu... [07:37:46] (03CR) 10Daniel Kinzler: "needs tests" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [07:40:28] (03CR) 10Daniel Kinzler: Force user id and actor id to 0 when loading from remote wikis (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [07:47:35] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10schoenbaechler) Hey @cooltey, thanks for checking back: > If we remove the ToC scroller, should we also remove t... [07:48:57] (03PS3) 10Dvogel hallowelt: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 [07:53:59] (03CR) 10Pwirth: [C: 04-1] Fix scrolling to jumpmark if attribute 'href' is not starting with # (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [07:55:41] (03CR) 10Daniel Kinzler: Introduce MovePage::moveSubpages(IfAllowed) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504337 (owner: 10simetrical) [07:55:47] 10MediaWiki-extensions-Translate, 10User-Nikerabbit, 10User-abi_: Investigate ways to reduce the size of translate-groups cache key - https://phabricator.wikimedia.org/T213802 (10abi_) [08:13:47] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10daniel) All the old hooks have all objects passed by reference, simply because in the old da... [08:18:25] 10WMNO-General: Wikidata workshop for OsloMet - https://phabricator.wikimedia.org/T221932 (10WMNOaasapaaske) [08:20:10] (03CR) 10Fomafix: [C: 04-1] "You can rebase this change on top of https://gerrit.wikimedia.org/r/507278 and use ::linkKnown()." [core] - 10https://gerrit.wikimedia.org/r/501167 (owner: 10D3r1ck01) [08:20:55] (03CR) 10DCausse: "recheck" (033 comments) [search/glent] - 10https://gerrit.wikimedia.org/r/507235 (owner: 10Julia.glen) [08:25:48] (03CR) 10Daniel Kinzler: [C: 04-1] Hard-deprecate Title::moveTo and friends (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504338 (https://phabricator.wikimedia.org/T208775) (owner: 10simetrical) [08:29:07] (03CR) 10Hashar: [C: 04-1] "The messages in the those i18n files are intended for translation. If one need to retrieve the code consider using Language->getCode()." [core] - 10https://gerrit.wikimedia.org/r/507328 (owner: 10Want) [08:29:10] (03CR) 10Daniel Kinzler: MovePage methods need to run safety checks (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [08:30:06] (03CR) 10Pwirth: Fix scrolling to jumpmark if attribute 'href' is not starting with # (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [08:30:17] (03CR) 10Pwirth: Fix scrolling to jumpmark if attribute 'href' is not starting with # (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [08:37:30] (03PS2) 10AlexPinchuk: Add new input type `BS.form.field.NamespaceTag` [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/501576 (owner: 10Robert Vogel) [08:40:35] 10MediaWiki-Special-pages: Wikidata links to Commons should appear in Special:WhatLinksHere - https://phabricator.wikimedia.org/T222420 (10Ammarpad) [08:42:33] (03CR) 10Daniel Kinzler: [C: 04-1] Remove usage of Revision::GetQueryInfo() with 'text' flag (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/504797 (https://phabricator.wikimedia.org/T198342) (owner: 10BPirkle) [08:43:18] (03PS4) 10Dvogel hallowelt: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 [08:43:30] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10Trizek-WMF) Can we f... [08:44:31] (03Abandoned) 10Awight: [WIP] Clean up ORES roles [vagrant] - 10https://gerrit.wikimedia.org/r/407469 (owner: 10Awight) [08:44:43] (03Abandoned) 10Awight: [WIP] Changeprop rules for ORES precaching [vagrant] - 10https://gerrit.wikimedia.org/r/412918 (owner: 10Awight) [08:45:17] 10MediaWiki-Special-pages, 10Commons, 10Wikidata: Wikidata links to Commons should appear in Special:WhatLinksHere - https://phabricator.wikimedia.org/T222420 (10matej_suchanek) #globalusage was made for this: https://commons.wikimedia.org/wiki/Special:GlobalUsage/De-Luftballons.ogg. [08:45:21] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10Urbanecm) >>! In T22... [08:49:28] (03CR) 10Alaa Sarhan: "hmm abstracting clock is probably only gonna help you in testing some time-dependent cases." [vendor] - 10https://gerrit.wikimedia.org/r/502983 (owner: 10Jeroen De Dauw) [08:51:52] (03CR) 10AlexPinchuk: "recheck" [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/501576 (owner: 10Robert Vogel) [08:55:32] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - overflow menu - https://phabricator.wikimedia.org/T216418 (10ovasileva) @Edtadros - just wanted to note that in additio... [08:55:45] (03PS5) 10Dvogel hallowelt: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 [08:55:47] (03PS25) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [08:57:24] (03CR) 10Mglaser: "recheck" [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/501576 (owner: 10Robert Vogel) [09:01:07] (03CR) 10Pwirth: [C: 03+2] Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [09:01:13] (03PS1) 10Pwirth: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/507926 [09:01:17] (03CR) 10Pwirth: [C: 03+2] Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/507926 (owner: 10Pwirth) [09:01:24] (03PS1) 10Pwirth: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/507927 [09:01:27] (03CR) 10Pwirth: [C: 03+2] Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/507927 (owner: 10Pwirth) [09:02:01] (03PS11) 10AlexPinchuk: Features buttons & User is not logged in [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/506488 [09:02:58] 10MediaWiki-Configuration, 10Tracking-Neverending: Convert things to use Config classes instead of globals (tracking) - https://phabricator.wikimedia.org/T71084 (10D3r1ck01) [09:03:06] 10MediaWiki-Special-pages, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-D3r1ck01: Special:Version: Use Config instead of globals - https://phabricator.wikimedia.org/T72638 (10D3r1ck01) 05Open→03Resolved a:03D3r1ck01 [09:12:02] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist doesn't properly track my visits - https://phabricator.wikimedia.org/T222431 (10Bdijkstra) [09:12:25] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [09:12:34] (03PS1) 10Awight: Add a courtesy README [extensions] - 10https://gerrit.wikimedia.org/r/507928 [09:16:30] (03PS2) 10Awight: Add a courtesy README [extensions] - 10https://gerrit.wikimedia.org/r/507928 [09:20:33] (03PS1) 10Pmiazga: Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) [09:29:15] 10ISA: Retrieve existing image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [09:29:16] 10ISA: Participate campaign page - https://phabricator.wikimedia.org/T221927 (10NavinoEvans) [09:29:19] 10ISA: Retrieve existing image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [09:29:27] 10MediaWiki-Watchlist, 10Growth-Team: Watchlist doesn't properly track my visits - https://phabricator.wikimedia.org/T222431 (10matej_suchanek) [09:29:32] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10matej_suchanek) [09:30:57] 10ISA: Retrieve individual image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [09:31:32] 10Wikipedia-Android-App-Backlog: Cleaner look for tabs - https://phabricator.wikimedia.org/T222434 (10schoenbaechler) [09:33:45] 10MediaWiki-Special-pages, 10Commons, 10Wikidata: Wikidata links to Commons should appear in Special:WhatLinksHere - https://phabricator.wikimedia.org/T222420 (10Sascha) Hm... in the sidebar on Wikimedia Commons (see screenshot), would it perhaps make sense to replace the link to Special:WhatLinksHere by a l... [09:34:50] 10Wikimedia-Site-requests: Enable Page Previews as default on hewikivoyage - https://phabricator.wikimedia.org/T222017 (10Ammarpad) p:05Triage→03Normal [09:35:40] (03Merged) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [09:36:25] (03CR) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [09:36:33] 10Wikipedia-Android-App-Backlog: Cleaner look for tabs - https://phabricator.wikimedia.org/T222434 (10schoenbaechler) [09:38:48] (03CR) 10jerkins-bot: [V: 04-1] Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [09:38:50] 10Wikipedia-Android-App-Backlog: Cleaner look for tabs - https://phabricator.wikimedia.org/T222434 (10schoenbaechler) [09:40:46] (03Merged) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/507926 (owner: 10Pwirth) [09:40:48] (03Merged) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/507927 (owner: 10Pwirth) [09:42:00] (03CR) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/507926 (owner: 10Pwirth) [09:42:12] 10MediaWiki-Special-pages, 10Commons, 10Wikidata: Wikidata links to Commons should appear in Special:WhatLinksHere - https://phabricator.wikimedia.org/T222420 (10matej_suchanek) Even that doesn't seem necessary to me, the list is already available on every file page. {F28913681} [09:42:51] (03CR) 10jenkins-bot: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/507927 (owner: 10Pwirth) [09:43:27] 10Wikipedia-Android-App-Backlog: Cleaner look for tabs - https://phabricator.wikimedia.org/T222434 (10schoenbaechler) [09:44:34] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Enable Flagged Revisions at the Chinese Wikipedia - https://phabricator.wikimedia.org/T221933 (10RazeSoldier) Checking list: 1. Add zhwiki to flaggedrevs.dblist 2. Grant `movestable`, `autoreview` and `review` to sysop 3. Grant `autoreview` and... [09:44:52] (03PS1) 10Daimona Eaytoy: Restore TypedElementInterface typehints [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507934 [09:47:08] (03CR) 10Pmiazga: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [09:55:33] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) Looks like it's not ready for sign of... [09:56:29] (03CR) 10Pmiazga: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506340 (owner: 10Jdlrobson) [09:56:43] (03CR) 10jerkins-bot: [V: 04-1] 💥 Breaking change: Remove mediawiki.template.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506340 (owner: 10Jdlrobson) [09:56:45] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) > At six weeks, set to only admins can use. This is just in case someone needs something that's only in Conpherence. For the records (as this might cr... [10:01:50] (03CR) 10Mglaser: "recheck" [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/506488 (owner: 10AlexPinchuk) [10:05:26] 10Wikidata-Termbox-Iteration-14: /termbox query validation based on openapi.json - https://phabricator.wikimedia.org/T222435 (10Pablo-WMDE) [10:05:59] (03CR) 10jerkins-bot: [V: 04-1] Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [10:08:12] 10Code-Health, 10Developer-Advocacy (Apr-Jun 2019): Define questions for a potential code review survey among WMF tech/eng teams - https://phabricator.wikimedia.org/T211741 (10Aklapper) [10:08:17] 10CommRel-Specialists-Support (Apr-Jun-2019): Support the final revision of the medium term plan - https://phabricator.wikimedia.org/T222286 (10Qgil) Just an observation. I guess in addition to the MTP update there will be some kind of communication thanking volunteers for their feedback and summarizing the chan... [10:10:34] (03CR) 10Daniel Kinzler: [C: 04-1] "This looks mostly good, but it's trying to do too much. In particular, the changes to the Job classes should probably be in a separate pat" (0317 comments) [core] - 10https://gerrit.wikimedia.org/r/502510 (https://phabricator.wikimedia.org/T214319) (owner: 10simetrical) [10:19:09] 10WikibaseMediaInfo: Investigate possible MediaInfo test failures on 1.34.0-wmf4 PHP70 - https://phabricator.wikimedia.org/T222436 (10Tarrow) [10:20:22] 10MobileFrontend: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10Count_Count) [10:22:07] 10WikibaseMediaInfo: Investigate possible MediaInfo test failures on 1.34.0-wmf4 PHP70 - https://phabricator.wikimedia.org/T222436 (10Lucas_Werkmeister_WMDE) The most important line is probably this one: ` 01:07:59 [wfDebug] [debug] ApiUpload::performStash Stashing temporary file failed: UploadStashFileExceptio... [10:30:12] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "The failures are unrelated, as far as I can see." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [10:39:50] 10MobileFrontend, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): No way to reach the editable version of a page when viewing the most recent mobile diff - https://phabricator.wikimedia.org/T200969 (10Cirdan) [10:39:54] 10MobileFrontend: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10Cirdan) [10:42:06] (03PS1) 10Pwirth: Extend Renderer as RendererFactroy will provide Renderer instead of interfaces [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507937 [10:42:29] 10MobileFrontend, 10Advanced Mobile Contributions: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10Cirdan) [10:43:57] (03PS2) 10Pwirth: Extend Renderer as RendererFactroy will provide Renderer instead of interfaces [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507937 [10:44:12] (03PS1) 10Pwirth: Make Renderer easier extendable by using a static factory callback [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/507938 [10:44:33] (03PS2) 10Pwirth: Make Renderer easier extendable by using a static factory callback [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/507938 [10:44:48] 10MinervaNeue, 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Simplify URL to mw.Title heuristic to consume only Parsoid links - https://phabricator.wikimedia.org/T218741 (10Cirdan) [10:46:06] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10EventBus, 10Growth-Team, and 2 others: Edits to Flow pages result in a page-links-change event with no performer - https://phabricator.wikimedia.org/T216726 (10Cirdan) [10:47:20] 10Discovery-Search, 10GeoData: Red error message when two #coordinates set a primary coordinate - https://phabricator.wikimedia.org/T159315 (10Cirdan) [10:50:09] 10phan-taint-check-plugin: phan-taint-check should warn about unnecessary @suppress tags - https://phabricator.wikimedia.org/T203344 (10Daimona) I tried to do this as part of the plugin upgrade. However, phan has no way to filter unused suppressions. I think our best bet is to add the config option to phan. This... [10:52:08] 10CommRel-Specialists-Support (Apr-Jun-2019), 10Growth-Team (Current Sprint): Homepage: translations - https://phabricator.wikimedia.org/T220550 (10Trizek-WMF) We are now 93% done on vi. [10:52:25] (03PS3) 10Awight: Add a courtesy README [extensions] - 10https://gerrit.wikimedia.org/r/507928 [10:52:44] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Ladsgroup) >>! In T222224#5154478, @Tgr wrote: > > If we do that, how would namespace filters in things like Special:WhatLinksHere work? Wouldn't we end up having denormalize them in pretty much every... [10:53:51] 04(no projects): User links parentheses and separator broken on Mobile web - https://phabricator.wikimedia.org/T222439 (10Ammarpad) [10:54:04] (03CR) 10jerkins-bot: [V: 04-1] Harden Definitions::insertCommunityPortal() method [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507930 (https://phabricator.wikimedia.org/T222407) (owner: 10Pmiazga) [10:54:57] 10ISA: Create a Tool Page on Commons - https://phabricator.wikimedia.org/T222440 (10Anthere) [10:55:50] 10MobileFrontend: User links parentheses and separator broken on Mobile web - https://phabricator.wikimedia.org/T222439 (10Ammarpad) [10:57:17] (03PS1) 10Pboehm: Consolidate Extension Name [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/507941 [11:07:43] (03CR) 10Daniel Kinzler: [C: 03+2] Convert WatchedItem and friends to UserIdentity (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [11:07:57] (03CR) 10jerkins-bot: [V: 04-1] Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [11:10:44] (03CR) 10Daniel Kinzler: [C: 03+2] Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [11:14:30] (03CR) 10jerkins-bot: [V: 04-1] Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [11:14:32] (03CR) 10jerkins-bot: [V: 04-1] Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [11:14:58] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Mimihitam) @Pginer-WMF I've tried it again, and this time it works https://id.wikipedia.org/wiki/Joseph_Buttigieg So I suppose the threshold is now working well, and i... [11:16:21] (03CR) 10Daniel Kinzler: [C: 03+2] Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [11:16:34] (03CR) 10jerkins-bot: [V: 04-1] Convert WatchedItem and friends to UserIdentity [core] - 10https://gerrit.wikimedia.org/r/506897 (https://phabricator.wikimedia.org/T207972) (owner: 10simetrical) [11:16:36] (03CR) 10jerkins-bot: [V: 04-1] Don't require Title for getTimestampFromId [core] - 10https://gerrit.wikimedia.org/r/507023 (owner: 10simetrical) [11:16:38] (03CR) 10jerkins-bot: [V: 04-1] Move getPrevious/NextRevision logic out of Title [core] - 10https://gerrit.wikimedia.org/r/507028 (owner: 10simetrical) [11:17:10] (03CR) 10Daniel Kinzler: [C: 04-1] "needs unit tests" [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [11:23:41] (03CR) 10Daniel Kinzler: [C: 04-1] "The changes to WatchedItemStore look good, but the change in Job.php is scary. I'm afraid it's going to break Job classes in extensions." (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507082 (owner: 10simetrical) [11:30:03] 04(no projects): Project for Wikimedia Finland - https://phabricator.wikimedia.org/T222442 (10Susannaanas) [11:38:39] (03CR) 10Daniel Kinzler: [C: 03+2] Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [11:56:08] (03CR) 10Daniel Kinzler: Replaces $user->removeWatch with WatchedItemStore service removeWatch calls (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/506885 (https://phabricator.wikimedia.org/T208766) (owner: 10Vedmaka Wakalaka) [12:00:51] (03CR) 10jerkins-bot: [V: 04-1] Make RepoGroup a service instead of singleton [core] - 10https://gerrit.wikimedia.org/r/507554 (owner: 10simetrical) [12:03:25] 10Wikidata-Termbox-Iteration-14: Add x-monitor and x-amples to spec - https://phabricator.wikimedia.org/T222358 (10Tarrow) a:03Tarrow [12:27:38] 10GrowthExperiments-Homepage: Homepage: culture module - https://phabricator.wikimedia.org/T222446 (10Trizek-WMF) [12:28:08] 10GrowthExperiments-Homepage: Homepage: culture module - https://phabricator.wikimedia.org/T222446 (10Trizek-WMF) [12:28:10] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Trizek-WMF) [12:30:34] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10SBisson) a:03SBisson [12:37:39] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression, 10Wikimedia-production-error: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (10pmiazga) T... [12:38:34] (03PS1) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [12:38:42] (03CR) 10Hoo man: [C: 03+2] Change link tracking key [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507285 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [12:39:37] (03CR) 10Hoo man: [C: 03+2] Rename db table for id counter [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507286 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [12:40:06] (03CR) 10Hoo man: [C: 03+2] Rename ContentModel to EntitySchema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507287 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [12:42:16] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) So I did some testing, running seccheck on AbuseFilter with mwext-fast. The runtime was 103 seconds. Then I removed seccheck from phan's config, and got a runtime of 72 seconds, which should be our... [12:46:35] (03PS2) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [12:48:48] (03PS3) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [12:50:19] 04(no projects): Copyvio wmflabs.org tool is down - https://phabricator.wikimedia.org/T222447 (10CASSIOPEIA) [12:55:49] (03PS6) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [12:57:19] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking-Neverending: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10Lea_Lacroix_WMDE) [12:58:01] (03CR) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [13:02:19] (03PS4) 10Fomafix: HTML escape parameter 'text' of hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/506958 [13:02:21] (03PS3) 10Fomafix: Remove parameter 'options' from hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/507278 [13:02:53] (03CR) 10Hoo man: [V: 03+2 C: 03+2] Change link tracking key [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507285 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:03:01] (03PS21) 10Fomafix: Replace use of deprecated methods in Linker and SkinFactory classes [core] - 10https://gerrit.wikimedia.org/r/501167 (owner: 10D3r1ck01) [13:03:03] (03CR) 10Hoo man: [V: 03+2 C: 03+2] Rename db table for id counter [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507286 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:03:14] (03CR) 10Hoo man: [V: 03+2 C: 03+2] Rename ContentModel to EntitySchema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507287 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:03:49] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) p:05Normal→03High [13:04:18] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) p:05High→03Unbreak! [13:06:10] (03CR) 10Hoo man: [C: 03+2] Rename html classes and ids to entityschema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507288 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:16:24] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) @Aklapper @Malyacko have SVG version of your drawing? can you share? [13:24:50] 10MediaWiki-Codesniffer: Add sniff to require trailing commas in multiline arrays - https://phabricator.wikimedia.org/T222042 (10thiemowmde) I just found a relevant use-case where I intentionally do **not** want an array to have a dangling comma, not even when it spans multiple lines: `lang=php /** * @return Re... [13:25:39] (03CR) 10Fomafix: [C: 03+1] "Now Jenkins don't fail." [core] - 10https://gerrit.wikimedia.org/r/501167 (owner: 10D3r1ck01) [13:25:43] (03CR) 10D3r1ck01: "Thank you Fomafix for your efforts on this patch. I appreciate." [core] - 10https://gerrit.wikimedia.org/r/501167 (owner: 10D3r1ck01) [13:27:30] (03CR) 10Hoo man: [V: 03+2 C: 03+2] Rename html classes and ids to entityschema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507288 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:27:57] (03CR) 10Hoo man: [V: 03+2] Rename configuration variables [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507289 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:28:03] (03CR) 10Hoo man: [V: 03+2] Actually rename the extension to EntitySchema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507290 (https://phabricator.wikimedia.org/T221947) (owner: 10Michael Große) [13:28:33] 10Wikidocumentaries: Landing page loading time - https://phabricator.wikimedia.org/T222450 (10Susannaanas) [13:31:08] (03PS1) 10Anysite: fix case when deleting the last translation in set. Add check in MultiLanguageManager\Hooks\SkinBuildSidebar::process to skip fatal error when translation set is damaged [extensions/MultiLanguageManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/507961 [13:32:11] 10Wikidocumentaries: Language tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [13:32:50] 10MediaWiki-Codesniffer: Add sniff to require trailing commas in multiline arrays - https://phabricator.wikimedia.org/T222042 (10Lucas_Werkmeister_WMDE) Hm, I think this might be down to personal preference… I know that when I write data providers for tests, I always use a trailing comma in the arguments arrays.... [13:36:40] 10Wikidocumentaries: A link in an article should not change UI language when clicked - https://phabricator.wikimedia.org/T222451 (10Susannaanas) [13:39:45] 10Wikidocumentaries: Create a dynamic language menu - https://phabricator.wikimedia.org/T222453 (10Susannaanas) [13:45:35] (03PS1) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [13:45:57] (03PS1) 10Esanders: Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) [13:47:18] 10WikibaseMediaInfo, 10Wikimedia-production-error (Shared Build Failure): WikibaseMediaInfo test MultiLingualCaptionsTest fails - https://phabricator.wikimedia.org/T222416 (10Cparle) @Jdforrester-WMF any idea why this might be happening? Permissions in `/tmp`? [13:48:00] (03PS4) 10Daimona Eaytoy: Various code quality improvements [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507952 [13:48:27] (03PS2) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [14:03:20] 10Growth-Team (Current Sprint): Document prerequisites and steps to have Growth team prototypes deployed on a wiki - https://phabricator.wikimedia.org/T220209 (10Trizek-WMF) [14:07:27] 10Readers-Community-Engagement, 10CommRel-Specialists-Support (Apr-Jun-2019): Community relations support for advanced mobile contributions, Q4 - https://phabricator.wikimedia.org/T220492 (10Elitre) [14:07:54] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2019-April-June), 10User-abi_: MessageGroupStats only displayed for the priority language list even if prevent translation to other languages not set - https://phabricator.wikimedia.org/T221498 (10abi_) [14:09:49] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019), 10Language-Team (Language-2019-April-June): Specialist support for Content Translation moving from beta to regular preferences in Catalan Wikipedia - https://phabricator.wikimedia.org/T214689 (10Elitre) @Pginer-WMF Any action items left for... [14:10:25] (03PS1) 10ItSpiderman: [WIP] Implement color picker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/507967 [14:13:27] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Implement color picker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/507967 (owner: 10ItSpiderman) [14:21:03] 10MediaWiki-Database, 10Proposal: Librarize MediaWiki database layer and drop official support for non-MySQL engines - https://phabricator.wikimedia.org/T158929 (10Lucas_Werkmeister_WMDE) > port non-MySQL `Database` subclasses into external libraries (RfC: Moving database abstractions out of MediaWiki core) I... [14:26:12] (03PS1) 10Pwirth: Replace deprecated getID and remove detach from entity cache ... [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/507969 [14:26:35] (03PS2) 10Pwirth: Replace deprecated getID and remove detach from entity cache ... [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/507969 [14:35:00] (03PS1) 10Duncancrane: Fix for tables when used in PageForms [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 [14:36:17] (03PS6) 10Pboehm: Enable Pasting of Text with embedded Links [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/500722 [14:40:20] 10Editing QA, 10VisualEditor (Current work): [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10Esanders) [14:40:51] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Anomie) >>! In T221177#5154489, @tstarling wrote: > By the way, it would be possible to have Handler::setRequest() and... [14:41:09] (03CR) 10Esanders: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [14:41:16] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [14:41:18] (03CR) 10Duncancrane: "Would you mind reviewing fro me - many thanks" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507970 (owner: 10Duncancrane) [14:42:36] (03Abandoned) 10Duncancrane: Fix headers at end of text area breaking editor [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507769 (owner: 10Duncancrane) [14:47:14] (03PS2) 10SBassett: Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) [14:48:21] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [14:48:23] 10Wikidocumentaries: A link in an article should not change UI language when clicked - https://phabricator.wikimedia.org/T222451 (10Susannaanas) [14:49:14] (03CR) 10SBassett: "recheck" [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [14:49:32] (03PS8) 10AlexPinchuk: [WiP] Allow a page template to be used on multiple namespaces [extensions/BlueSpicePageTemplates] (REL1_31) - 10https://gerrit.wikimedia.org/r/501577 (owner: 10Robert Vogel) [14:49:40] (03CR) 10Nikerabbit: "wgExtensionMessagesFiles is still used for magic words and special page aliases." [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/502471 (owner: 10simetrical) [14:51:43] (03CR) 10BPirkle: "I still need to add tests" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [14:52:01] (03PS2) 10BPirkle: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) [14:52:43] (03CR) 10Reedy: Add permission check for user is permitted to view the log type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [14:54:43] 10Wikidocumentaries: A topic with Saami diacritics and with Wikimedia Commons redirected image breaks layout - https://phabricator.wikimedia.org/T222454 (10Susannaanas) [14:56:29] (03PS3) 10SBassett: Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) [14:57:44] (03CR) 10SBassett: Add permission check for user is permitted to view the log type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [14:57:46] (03CR) 10Fomafix: [C: 04-1] Modify "importSites.php" to import "LanguageCode" as well (033 comments) [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [15:00:00] (03CR) 10SBassett: "Ah, mediawiki-phpunit-coverage-patch-docker wants us to write a test for this" [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [15:00:06] 10wb_terms - Tool Builders Migration: Overview of wb_terms redesign - https://phabricator.wikimedia.org/T221764 (10alaa_wmde) @Multichill We understand this requires some work from tool builders. We unfortunately were forced to face this situation as the current table design has reached its performance limits.... [15:00:32] 10MinervaNeue (Tracking), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar), 10Spike: Consolidate server and client templates - https://phabricator.wikimedia.org/T210866 (10Jdlrobson) [15:00:39] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10Jdlrobson) [15:02:24] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10Jdlrobson) I misunderstood that task (still do... [15:04:59] (03PS4) 10Luca Mauri: Modify "importSites.php" to import "LanguageCode" as well [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) [15:07:00] (03CR) 10Reedy: [C: 04-1] "Shouldn't this be done in sitelist-1.1.xsd or similar? As otherwise, you're changing a published specification/schema..." [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [15:07:05] 10MinervaNeue (Tracking), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar), 10Spike: Consolidate server and client templates - https://phabricator.wikimedia.org/T210866 (10Jdlrobson) I must confess I don't understand this task as written. Given Hogan is now gone ca... [15:08:17] (03CR) 10Reedy: [C: 04-1] "And presumably the exporter also needs updating?" [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [15:08:48] (03CR) 10Mglaser: "recheck" [extensions/BlueSpicePageTemplates] (REL1_31) - 10https://gerrit.wikimedia.org/r/501577 (owner: 10Robert Vogel) [15:14:46] (03CR) 10Reedy: Add permission check for user is permitted to view the log type (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [15:15:03] (03CR) 10jerkins-bot: [V: 04-1] Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [15:16:37] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10kostajh) [15:16:39] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [15:21:49] 10Wikidata-Termbox-Iteration-13, 10Wikidata-Termbox-Iteration-14: Ensure test mutations only perform reactivity-friendly changes - https://phabricator.wikimedia.org/T220686 (10Pablo-WMDE) Looked into the "complicated test helper specifically for mutations" which through a [[ https://developer.mozilla.org/en-US... [15:26:25] 10Wikidata-Termbox-Iteration-14: /termbox query validation based on openapi.json - https://phabricator.wikimedia.org/T222435 (10Pablo-WMDE) a:03Pablo-WMDE [15:27:06] (03PS5) 10Esanders: Make JSON styling available on mobile [core] - 10https://gerrit.wikimedia.org/r/503367 [15:28:52] (03CR) 10Luca Mauri: "> Shouldn't this be done in sitelist-1.1.xsd or similar? As" [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [15:29:33] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Superyetkin) p:05Low→03High The patch does not seem t... [15:30:28] (03PS1) 10Esanders: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 [15:31:50] (03CR) 10Luca Mauri: "> And presumably the exporter also needs updating?" [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [15:32:00] (03CR) 10Esanders: "Styles moved to I50a2203adb66e634f9d995225075dc29a34ab4dd" [core] - 10https://gerrit.wikimedia.org/r/503367 (owner: 10Esanders) [15:37:24] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [15:37:38] (03PS1) 10Abijeet Patro: Fix error caused due to renamed contenttranslation sql file [vagrant] - 10https://gerrit.wikimedia.org/r/507980 (https://phabricator.wikimedia.org/T222317) [15:37:50] (03PS3) 10BPirkle: Force user id and actor id to 0 when loading from remote wikis [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) [15:39:03] 10MediaWiki-Vagrant, 10ContentTranslation, 10Patch-For-Review, 10User-abi_: ContentTranslation role broken in vagrant - https://phabricator.wikimedia.org/T222317 (10abi_) I was able to fix the error encountered by but have encountered other failures when enabling the content translation role. Attached [[ h... [15:40:23] (03PS1) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [15:42:17] (03PS2) 10Esanders: Rename EditorOverlay to SourceEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [15:44:49] (03CR) 10Esanders: "ping" [core] - 10https://gerrit.wikimedia.org/r/499450 (owner: 10Esanders) [15:47:06] (03CR) 10Samwilson: "recheck" [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [15:55:41] 10Wikimedia-General-or-Unknown: Evaluate Matrix.org / Riot as recommended IRC client - https://phabricator.wikimedia.org/T222458 (10Tgr) [15:56:46] 10Wikimedia-General-or-Unknown: Evaluate Matrix.org / Riot as recommended IRC client - https://phabricator.wikimedia.org/T222458 (10Tgr) [15:57:33] (03CR) 10Samwilson: [C: 03+1] "check php" [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [15:57:35] (03CR) 10BPirkle: "Tests for User::newFromAnyId() added in patch set 3. I should probably add tests for RevisionStore as well, but starting just with User::n" [core] - 10https://gerrit.wikimedia.org/r/507908 (https://phabricator.wikimedia.org/T222381) (owner: 10BPirkle) [16:01:00] (03CR) 10jerkins-bot: [V: 04-1] Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [16:04:16] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Aklapper) p:05Unbreak!→03High @Petrb: There is no non-bitmap version as it's taken from a PNG source, sorry. Not UBN by definition (we'd also manage to survive without). [16:06:31] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Aklapper) p:05High→03Low @Superyetkin: Please do not... [16:09:53] 10MobileFrontend: User links parentheses and separator broken on Mobile web - https://phabricator.wikimedia.org/T222439 (10Aklapper) [16:09:56] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Aklapper) [16:10:12] 10Anti-Harassment, 10TechCom, 10Technical-Debt: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) [16:13:55] (03PS1) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [16:16:30] 04(no projects): cp2009 down and mgmt console not reachable - https://phabricator.wikimedia.org/T222459 (10Dzahn) [16:16:34] (03PS5) 10Tchanders: Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) [16:16:52] 10MediaWiki-API, 10MediaWiki-Special-pages, 10Anti-Harassment, 10Core Platform Team, and 2 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) [16:18:10] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [16:20:41] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10sbassett) Yeah, that seems fairly quick to me. Obviously there are efficiency concerns here since this needs to run in CI, but 30 seconds doesn't seem so terrible imo. Of course if we ever try to get this... [16:20:50] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10sbassett) p:05Triage→03Normal [16:23:27] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Daimona) Well, core is definitely slower... We can try running it on different extensions, but looking at previous runs it seems like AF has more or less the same runtime as other extensions (or maybe slight... [16:24:34] (03PS3) 10Jdlrobson: Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [16:24:45] (03CR) 10Jdlrobson: [C: 03+2] Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [16:26:46] (03PS2) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [16:27:09] (03PS2) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [16:27:30] 10MobileFrontend, 10Advanced Mobile Contributions, 10Regression: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10Jdlrobson) p:05Triage→03High [16:27:35] 10MinervaNeue (Tracking), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar), 10Spike: Consolidate server and client templates - https://phabricator.wikimedia.org/T210866 (10Niedzielski) 05Open→03Declined [16:27:43] 10MobileFrontend, 10Advanced Mobile Contributions, 10Regression: Regression: SpecialMobileDiff does not display proper text for version link in German Wikipedia since 1.34.0-wmf.3 - https://phabricator.wikimedia.org/T222437 (10Jdlrobson) [16:29:00] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) OK I will try to turn this into some SVG, each level has same wall layout (almost same) so it's more or less making that one grid and then it's just different labels. Hopefuly this... [16:33:33] 04(no projects): ParameterAssertionException on page creation - https://phabricator.wikimedia.org/T222462 (10PeterBowman) [16:33:59] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (10AndyRussG) [16:34:16] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [16:34:22] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint It Came From Out of Scope: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (10AndyRussG) [16:34:41] (03CR) 10Michael Große: [V: 03+2] Rename ID field label and placeholder [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) (owner: 10Noa wmde) [16:35:46] (03PS2) 10Jforrester: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [16:36:32] (03CR) 10Jforrester: [C: 03+2] Make JSON styling available on mobile [core] - 10https://gerrit.wikimedia.org/r/503367 (owner: 10Esanders) [16:37:35] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10Anomie) Doing some archaeology, * Only the `$summary` parameter in PageContentSave is docum... [16:37:40] 10WikibaseMediaInfo, 10Wikimedia-production-error (Shared Build Failure): WikibaseMediaInfo test MultiLingualCaptionsTest fails - https://phabricator.wikimedia.org/T222416 (10Jdforrester-WMF) Possibly a permissions issue, yes. It's happening in the gate job but not the test job, which is confusing; possibly th... [16:37:44] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint It Came From Out of Scope: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (10DStrine) a:03AndyRussG [16:41:03] (03CR) 10jerkins-bot: [V: 04-1] Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [16:41:37] (03CR) 10Anomie: [C: 04-1] "This seems to be the same thing as the "int:lang hack" used on Commons. Rather than officially condoning that, it would probably be better" [core] - 10https://gerrit.wikimedia.org/r/507328 (owner: 10Want) [16:41:44] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [16:44:11] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Wikimedia-production-error: ParameterAssertionException on page creation: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10Aklapper) [16:44:32] (03PS3) 10Jforrester: JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [16:44:44] 10MediaWiki-API, 10MediaWiki-Page-deletion: Bulk API undeletion results in database query error - https://phabricator.wikimedia.org/T222402 (10Anomie) I don't think this is likely to be an issue in the API itself, but instead in the deletion code used by the API (and the normal web deletion action as well). Al... [16:45:03] 10Research-2017-18-Q4: Analyze readers' engagement in countries affected by Singapore Data Center's switch - https://phabricator.wikimedia.org/T222078 (10Miriam) Thanks @Chelsyx ! Yes the questions are somehow similar -- how performance impacts engagement -- and we want perform a robust analysis 1 year after sw... [16:45:26] 10Research-2017-18-Q4: Analyze readers' engagement in countries affected by Singapore Data Center's switch - https://phabricator.wikimedia.org/T222078 (10Miriam) [16:46:19] (03CR) 10jerkins-bot: [V: 04-1] Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [16:47:44] stephanebisson, is there a task to watch regarding the investigation you mentioned at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/507988? Or is it just off-gerrit-and-phabricator type of investigation? :) [16:48:20] Urbanecm: if I can't fix it in 5 minutes there will be a task. Will CC you. [16:48:28] ok, thanks stephanebisson [16:49:19] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [16:50:52] (03CR) 10Anomie: "I have to wonder why we *want* to enforce that in the first place." [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [16:52:35] (03CR) 10Tchanders: Allow partially blocked users to use Thanks (033 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [16:52:41] (03CR) 10Tchanders: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [16:53:01] 10ExternalGuidance, 10Product-Analytics: Figure out the topic of articles translated automatically by external translation service - https://phabricator.wikimedia.org/T219660 (10Isaac) > There seems to be less STEM related language switch on wiki. My guess is that those articles are not available in the local... [16:53:12] 10Wikimedia-General-or-Unknown: Evaluate Matrix.org / Riot as recommended IRC client - https://phabricator.wikimedia.org/T222458 (10Tgr) [16:55:40] 10LDAP-Access-Requests: LDAP access to the nda group for sukhe - https://phabricator.wikimedia.org/T221990 (10Dzahn) a:05elukey→03Dzahn [16:57:04] 10LDAP-Access-Requests: LDAP access to the nda group for sukhe - https://phabricator.wikimedia.org/T221990 (10Dzahn) p:05Triage→03Low [16:58:19] (03PS1) 10DCausse: Add tokenizers for korean, japanese and chinese simplified [search/glent] - 10https://gerrit.wikimedia.org/r/507993 [16:58:42] 10Design, 10MinervaNeue, 10Readers-Web-Backlog: Build sticky header navigation in beta - https://phabricator.wikimedia.org/T197718 (10ovasileva) [16:58:47] 10Design, 10Analytics, 10MinervaNeue, 10Product-Analytics, and 2 others: [Spike ??hrs] Sticky header instrumentation - https://phabricator.wikimedia.org/T199157 (10ovasileva) 05Open→03Stalled p:05Normal→03Low dropping as low until the project is scheduled [16:59:46] (03CR) 10jerkins-bot: [V: 04-1] JSON content: Fix table margins [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/507979 (owner: 10Esanders) [17:00:15] (03Merged) 10jenkins-bot: Make JSON styling available on mobile [core] - 10https://gerrit.wikimedia.org/r/503367 (owner: 10Esanders) [17:00:39] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) [17:00:54] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) p:05Triage→03High [17:01:43] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [17:02:54] (03PS8) 10MusikAnimal: Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) [17:03:37] (03CR) 10Anomie: [C: 04-1] Move ApiQueryUserInfo::getBlockInfo() to ApiBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [17:03:49] 10Product-Analytics, 10Readers-Web-Backlog: Examine clickthrough ratios for different page elements of action=history pages - https://phabricator.wikimedia.org/T214935 (10ovasileva) a:03ovasileva [17:03:53] (03CR) 10Anomie: [C: 04-1] "Other than the name, the code looks good to me." [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [17:05:08] (03CR) 10VolkerE: [C: 03+2] HTMLForm: Improve method interface for collapsible forms [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [17:06:51] (03CR) 10jenkins-bot: Make JSON styling available on mobile [core] - 10https://gerrit.wikimedia.org/r/503367 (owner: 10Esanders) [17:07:08] (03CR) 10jerkins-bot: [V: 04-1] Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [17:08:13] 10Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Patch-For-Review: Use consistent 'search' icon across products - https://phabricator.wikimedia.org/T213580 (10Volker_E) [17:08:20] (03CR) 10jerkins-bot: [V: 04-1] Allow partially blocked users to use Thanks [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/506706 (https://phabricator.wikimedia.org/T221371) (owner: 10Tchanders) [17:08:24] (03PS9) 10MusikAnimal: Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) [17:08:26] 10Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization: Use consistent 'search' icon across products - https://phabricator.wikimedia.org/T213580 (10Volker_E) [17:08:36] 10WMF-Communications, 10SEO: Google still shows old logo for Wikimedia Foundation - https://phabricator.wikimedia.org/T222467 (10Pcoombe) [17:09:10] 10WMF-Communications, 10SEO: Google still shows old logo for Wikimedia Foundation - https://phabricator.wikimedia.org/T222467 (10Pcoombe) [17:09:16] 10WMF-Communications, 10Wikimedia-Site-requests: Update instances of Wikimedia Foundation logo - https://phabricator.wikimedia.org/T144254 (10Pcoombe) [17:09:25] (03PS3) 10Daimona Eaytoy: Handle pre/post-increment/decrement operators [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507962 [17:09:54] (03PS3) 10Daimona Eaytoy: Handle closures [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507981 [17:10:20] (03PS3) 10Daimona Eaytoy: Handle closure vars [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507986 [17:13:47] 10Growth-Team (Current Sprint): Homepage: design for indicating that the user should check back for pageviews - https://phabricator.wikimedia.org/T216220 (10Urbanecm) An idea I got from a community member today: what about a message "Page views data isn't available now, it should be available within 24 hours" on... [17:14:44] (03PS4) 10VolkerE: Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) [17:15:28] (03CR) 10VolkerE: "Blockquote browser default margin nullified in PS4." [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:15:34] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) Apparently fixed in the library but not yet released: https://github.com/JakubOnderka/PHP-Parallel-Lint/is... [17:15:42] (03CR) 10jerkins-bot: [V: 04-1] Move `p`, `pre` and `blockquote` styles to 'text.less' [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [17:17:13] 10MediaWiki-API, 10MediaWiki-Page-deletion: Bulk API undeletion results in database query error - https://phabricator.wikimedia.org/T222402 (10Amorymeltzer) @Anomie It's done in parallel, but the issue here arises specifically with `undelete`, not with `delete`, even though both are handled in the same way. T... [17:19:06] 10MediaWiki-Categories, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Superyetkin) @Aklapper, I think the applied patch having... [17:19:54] (03PS4) 10Jforrester: Add a courtesy README [extensions] - 10https://gerrit.wikimedia.org/r/507928 (owner: 10Awight) [17:20:07] (03CR) 10Jforrester: [V: 03+2 C: 03+2] "Good enough as a start." [extensions] - 10https://gerrit.wikimedia.org/r/507928 (owner: 10Awight) [17:22:47] (03Merged) 10jenkins-bot: HTMLForm: Improve method interface for collapsible forms [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [17:24:26] (03PS63) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [17:28:11] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [17:28:40] (03CR) 10jenkins-bot: HTMLForm: Improve method interface for collapsible forms [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [17:29:50] 10MediaWiki-General-or-Unknown, 10ObjectFactory: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Tgr) [17:29:52] 10MediaWiki-API, 10MediaWiki-Special-pages, 10Anti-Harassment, 10Core Platform Team, and 2 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10Tgr) [17:30:03] (03CR) 10Jforrester: Subtitles served through API, with WebVTT conversion (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [17:31:27] 10MediaWiki-API, 10MediaWiki-ServiceContainer, 10MediaWiki-Special-pages, 10Anti-Harassment, and 3 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10Tgr) Ideally, we'd avoid injecting the container, as that's g... [17:31:55] 10Outreachy (Round 18): Proposal: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki, Outreachy 18. - https://phabricator.wikimedia.org/T218015 (10Nikitrain) [17:37:21] 10Wikimedia-General-or-Unknown: Evaluate Matrix.org / Riot as recommended IRC client - https://phabricator.wikimedia.org/T222458 (10MarkAHershberger) Related: [[ http://exple.tive.org/blarg/2019/04/26/synchronous-text/ | Mozilla is dumping IRC ]]. [17:41:07] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) 05Resolved→03Open The patch failed to merge because of a MobileFrontend selenium test ` 13:34:06 1)... [17:42:48] 10MediaWiki-ServiceContainer, 10ObjectFactory: ObjectFactory should allow using services - https://phabricator.wikimedia.org/T222410 (10Anomie) I doubt the cases where anything else is wanting to use ObjectFactory would really be suited to just pulling "a service" out of the container, as such code could as we... [17:44:19] 04(no projects): Fatal exception (ParameterAssertionException) thrown when visiting a non-existent page on the English Wiktionary - https://phabricator.wikimedia.org/T222468 (10PiRSquared17) [17:44:35] 10MobileFrontend, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: Regression: Edit summary has no border - https://phabricator.wikimedia.org/T221624 (10nray) @alexhollender I've been trying to consolidate some o... [17:44:48] 10MobileFrontend: MobileFrontend selenium test: "User: Check user page is editable" blocking merges on GrowthExperiments extension - https://phabricator.wikimedia.org/T222469 (10SBisson) [17:46:04] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Decide which elements need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) a:03alexhollender [17:46:09] (03PS64) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [17:46:27] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Decide which elements need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10MusikAnimal) > Embedded (mapframe) maps are reversed. I added kartographer maps as an exclusion with https://en.wikipedia.org/wiki/Special:Diff/8... [17:46:51] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [17:49:00] 04(no projects): Fatal exception (ParameterAssertionException) thrown when visiting a non-existent page on the English Wiktionary - https://phabricator.wikimedia.org/T222468 (10PiRSquared17) Probably a dupe of T222462. [17:52:28] (03CR) 10Nray: ">" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507202 (https://phabricator.wikimedia.org/T221624) (owner: 10Nray) [17:52:46] 04(no projects): Fatal exception (ParameterAssertionException) thrown when visiting a non-existent page on the English Wiktionary - https://phabricator.wikimedia.org/T222468 (10PiRSquared17) [17:52:52] 10MediaWiki-Database, 10MediaWiki-Page-editing, 10Wikimedia-production-error: ParameterAssertionException on page creation: "Bad value for parameter $dbkey: should not be empty" - https://phabricator.wikimedia.org/T222462 (10PiRSquared17) [17:54:08] (03PS1) 10Sbisson: Disable test blocking merges on GrowthExperiments repo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507998 (https://phabricator.wikimedia.org/T222469) [17:55:31] 04(no projects): DarkMode: Create a mechanism to activate dark mode within the extension - https://phabricator.wikimedia.org/T222470 (10Mooeypoo) [17:58:58] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) In T222111#5156425, @MusikAnimal wrote: >> Embedded (mapframe) maps are reversed. > > I added kartographer maps as an exclusi... [17:59:29] (03CR) 10Jforrester: [C: 03+1] Don't show anon editor warning after switching [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507963 (https://phabricator.wikimedia.org/T221855) (owner: 10Esanders) [18:00:18] (03CR) 10Jforrester: [C: 03+2] "Broken patch now reverted." [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [18:02:54] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10MusikAnimal) >>! In T222111#5156457, @jmatazzoni wrote: > I don't know if we can do anything, but I do see one issue: if I'm in Dark Mode... [18:06:29] (03CR) 10Jforrester: [C: 03+1] "I plan to merge this after the cut on Tuesday unless someone objects." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [18:10:28] 10WMF-Communications, 10SEO: Google still shows old logo for Wikimedia Foundation - https://phabricator.wikimedia.org/T222467 (10Varnent) @Pcoombe @Dzahn - would love to get this fixed - but not sure how. I do not see a spot to set it in Search Console - and in there it shows the correct image. But if you have... [18:11:11] 10codfw-rollout: Add redundancy to IRC and RCStream services - https://phabricator.wikimedia.org/T128592 (10Krenair) @Krinkle I don't see how running this active-active would be complicated. Set up a second VM somewhere, tell MW to send all changes there as well, add an extra A record to irc.wikimedia.org for it? [18:11:55] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) Hi @alexhollender, I've been thinking of this as something you were working on, but just realized I didn't assign it to you.... [18:12:24] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [18:12:36] 10codfw-rollout: Add redundancy to IRC and RCStream services - https://phabricator.wikimedia.org/T128592 (10Krenair) [18:14:58] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) I've removed the issue below from the Description. I'm just making a note here to record that this was an issue, but that we'v... [18:15:30] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [18:16:48] 10Design, 10WMF-Design, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 3 others: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable - https://phabricator.wikimedia.org/T150377 (10alexhollender) [18:20:20] 10WMF-Communications, 10SEO: Google still shows old logo for Wikimedia Foundation - https://phabricator.wikimedia.org/T222467 (10Varnent) I have submitted an additional request via their submit feedback tool. Will post here if I hear back. [18:20:48] 10WMF-Communications, 10SEO: Google still shows old logo for Wikimedia Foundation - https://phabricator.wikimedia.org/T222467 (10Varnent) a:03Varnent [18:21:33] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-CentralAuth: Allow per-session log out - https://phabricator.wikimedia.org/T37220 (10Ankit-Maity) We should have a currently logged-in panel in the Preferences section that allow us to logout sessions from... [18:22:02] 10Design, 10WMF-Design, 10MinervaNeue, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 3 others: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable - https://phabricator.wikimedia.org/T150377 (10alexhollender) The alignment of the refer... [18:23:11] (03Merged) 10jenkins-bot: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [18:23:30] 10DC-Ops, 10decommission: reclaim to spares pool: restbase2007.codfw.wmnet, restbase2008.codfw.wmnet - https://phabricator.wikimedia.org/T221134 (10Papaul) a:05Papaul→03RobH @Robh same for this as well https://librenms.wikimedia.org/alerts [18:28:53] (03CR) 10jenkins-bot: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [18:29:51] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) In T222111#5151567, @jmatazzoni wrote: > I'm moving this report down to the discussions area because a) I don't know who repo... [18:35:30] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [18:37:01] 10DC-Ops, 10decommission: reclaim to spares pool: restbase2007.codfw.wmnet, restbase2008.codfw.wmnet - https://phabricator.wikimedia.org/T221134 (10Papaul) a:05RobH→03Papaul [18:38:32] 04(no projects): {"Accept": "application/ld+json"} causes 500 errors for LDF pages - https://phabricator.wikimedia.org/T222471 (10Lexie_23Kr) [18:40:27] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) @alexhollender, I added this back into the Description, since now I see the flash more clearly—especially for the black and wh... [18:42:13] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Investigate elements that MAY need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [18:42:33] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: GrowthExperiments phan job fails on JsonSerializable - https://phabricator.wikimedia.org/T222465 (10SBisson) 05Open→03Resolved Now it's merged. [18:47:34] 10Research-2017-18-Q4: Analyze readers' engagement in countries affected by Singapore Data Center's switch - https://phabricator.wikimedia.org/T222078 (10BBlack) @Miriam - sorry for the slowness! 2-letter ISO country codes, showing the actual UTC turn-up timestamps from DNS repo history, plus a few notes: * 20... [18:52:27] (03PS1) 10C. Scott Ananian: Correctly analyse accessed rule variables in the presence of grammar cycles [wikipeg] - 10https://gerrit.wikimedia.org/r/508004 [18:52:57] (03CR) 10jerkins-bot: [V: 04-1] Correctly analyse accessed rule variables in the presence of grammar cycles [wikipeg] - 10https://gerrit.wikimedia.org/r/508004 (owner: 10C. Scott Ananian) [19:02:35] (03PS1) 10Aaron Schulz: Add UserOptionsUpdateJob class [core] - 10https://gerrit.wikimedia.org/r/508005 [19:04:03] (03CR) 10Dvorapa: "> This seems to be the same thing as the "int:lang hack" used on" [core] - 10https://gerrit.wikimedia.org/r/507328 (owner: 10Want) [19:11:21] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint It Came From Out of Scope: CentralNotice: Review incoming patches 2019-05 - https://phabricator.wikimedia.org/T222463 (10AndyRussG) [19:11:24] (03CR) 10Aaron Schulz: [C: 03+2] Avoid/Replace usage of deprecated `wfMemcKey()` function [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [19:12:11] (03CR) 10Jforrester: [WIP] Add a convenience method to purge file cache and CDN together (031 comment) [core] - 10https://gerrit.wikimedia.org/r/496695 (owner: 10Aaron Schulz) [19:15:02] 10DC-Ops, 10decommission: reclaim to spares pool: restbase2007.codfw.wmnet, restbase2008.codfw.wmnet - https://phabricator.wikimedia.org/T221134 (10Papaul) ` papaul@asw-c-codfw# run show interfaces ge-1/0/2 descriptions Interface Admin Link Description ge-1/0/2 down down DISABLED [19:16:52] (03CR) 10Kosta Harlan: [C: 03+2] Disable test blocking merges on GrowthExperiments repo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507998 (https://phabricator.wikimedia.org/T222469) (owner: 10Sbisson) [19:20:54] (03PS1) 10Aaron Schulz: rdbms: fix some phpstorm warnings database classes [core] - 10https://gerrit.wikimedia.org/r/508010 [19:22:41] 10MediaWiki-Database, 10MediaWiki-Watchlist, 10MediaWiki-extensions-PageAssessments, 10Community-Tech, and 8 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10aaron) >>! In T221577#5154583, @Jd... [19:24:54] 10MediaWiki-Database, 10Librarization, 10Proposal: Librarize MediaWiki database layer and drop official support for non-MySQL engines - https://phabricator.wikimedia.org/T158929 (10Tgr) >>! In T158929#5155898, @Lucas_Werkmeister_WMDE wrote: > I would propose to go further, and move all of `libs/rdbms/` I th... [19:27:28] (03Merged) 10jenkins-bot: Avoid/Replace usage of deprecated `wfMemcKey()` function [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [19:32:31] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Tgr) Yeah, sorry, WhatLinksHere is the other direction, this would affect the `links` / `images` / `templates` / `categories` APIs (and probably index.php's `action=info` and edit previews). I guess al... [19:33:10] (03CR) 10jenkins-bot: Avoid/Replace usage of deprecated `wfMemcKey()` function [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [19:33:29] (03Merged) 10jenkins-bot: Disable test blocking merges on GrowthExperiments repo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507998 (https://phabricator.wikimedia.org/T222469) (owner: 10Sbisson) [19:36:18] (03PS16) 10Jforrester: Rename CDN config variables to be generic, deprecating the old names [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) [19:36:33] (03CR) 10Jforrester: "PS16: Rebased to 1.34.x." [core] - 10https://gerrit.wikimedia.org/r/387877 (https://phabricator.wikimedia.org/T104148) (owner: 10Jforrester) [19:36:39] (03CR) 10jenkins-bot: Disable test blocking merges on GrowthExperiments repo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507998 (https://phabricator.wikimedia.org/T222469) (owner: 10Sbisson) [19:36:45] (03CR) 10jerkins-bot: [V: 04-1] rdbms: fix some phpstorm warnings database classes [core] - 10https://gerrit.wikimedia.org/r/508010 (owner: 10Aaron Schulz) [19:37:07] (03Abandoned) 10Jforrester: Title: Deprecate ->purgeSquid() in favour of ->purgeCdn() [core] - 10https://gerrit.wikimedia.org/r/496831 (owner: 10Jforrester) [19:39:23] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Size improvements for Curation toolbar - https://phabricator.wikimedia.org/T207439 (10MusikAnimal) >>! In T207439#5151534, @Niharika wrote: > @MusikAnimal Is there a reason we don't want to allow the textare... [19:41:05] (03PS7) 10Jforrester: Update wikimedia/at-ease from 1.2.0 to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/489933 (owner: 10Reedy) [19:41:07] (03PS3) 10Jforrester: Drop wf(Suppress|Restore)Warnings, deprecated in 1.26 [core] - 10https://gerrit.wikimedia.org/r/491455 [19:41:09] (03CR) 10Subramanya Sastry: "https://gerrit.wikimedia.org/r/c/mediawiki/services/parsoid/+/507966 is the patch in question that triggered this." [wikipeg] - 10https://gerrit.wikimedia.org/r/508004 (owner: 10C. Scott Ananian) [19:41:31] (03CR) 10jerkins-bot: [V: 04-1] Update wikimedia/at-ease from 1.2.0 to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/489933 (owner: 10Reedy) [19:41:37] (03CR) 10jerkins-bot: [V: 04-1] Drop wf(Suppress|Restore)Warnings, deprecated in 1.26 [core] - 10https://gerrit.wikimedia.org/r/491455 (owner: 10Jforrester) [19:41:44] (03CR) 10jerkins-bot: [V: 04-1] Update wikimedia/at-ease from 1.2.0 to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/489933 (owner: 10Reedy) [19:41:48] (03CR) 10jerkins-bot: [V: 04-1] Update wikimedia/at-ease from 1.2.0 to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/489933 (owner: 10Reedy) [19:41:56] (03CR) 10jerkins-bot: [V: 04-1] Drop wf(Suppress|Restore)Warnings, deprecated in 1.26 [core] - 10https://gerrit.wikimedia.org/r/491455 (owner: 10Jforrester) [19:42:01] (03CR) 10jerkins-bot: [V: 04-1] Drop wf(Suppress|Restore)Warnings, deprecated in 1.26 [core] - 10https://gerrit.wikimedia.org/r/491455 (owner: 10Jforrester) [19:43:06] (03PS7) 10Jforrester: mediawiki.user: Export central user ID and add getCentralId() method [core] - 10https://gerrit.wikimedia.org/r/500848 [19:49:33] (03CR) 10MaxSem: [C: 03+2] Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [19:50:58] 10MediaWiki-General-or-Unknown, 10Core Platform Team Backlog (Watching / External), 10Patch-For-Review, 10User-Daniel, 10User-thiemowmde: Hook handler functions should not require pass-by-reference unless documented in the hook signature - https://phabricator.wikimedia.org/T193951 (10Tgr) PHP 5.6 introdu... [19:51:56] (03CR) 10MaxSem: [C: 03+2] Move Tidy functionality to TextTruncator [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497490 (owner: 10Thiemo Kreuz (WMDE)) [19:52:59] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10aaron) After struggling to reproduce anything, I saw T222431 mentioned the old non-default watchlist... [19:53:19] 10Readers-Web-Backlog, 10Technical-Debt: Minerva Selenium ReferenceDrawer test failing - https://phabricator.wikimedia.org/T222475 (10nray) [19:53:48] 10MinervaNeue, 10Readers-Web-Backlog, 10Technical-Debt: Minerva Selenium ReferenceDrawer test failing - https://phabricator.wikimedia.org/T222475 (10nray) [19:55:01] (03CR) 10MaxSem: [C: 03+2] rdbms: Document varargs for IDatabase::buildLike [core] - 10https://gerrit.wikimedia.org/r/439303 (https://phabricator.wikimedia.org/T191668) (owner: 10Umherirrender) [19:57:04] (03PS1) 10Nray: Update Minerva Selenium ReferenceDrawer selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508016 (https://phabricator.wikimedia.org/T222475) [19:58:06] 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Minerva Selenium ReferenceDrawer test failing - https://phabricator.wikimedia.org/T222475 (10nray) [19:58:15] 10MediaWiki-Core-Testing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Upgrade webdriverio to version 5 - https://phabricator.wikimedia.org/T213268 (10Jdforrester-WMF) [19:58:21] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) Unfortunately, a lot of people in two wikipedias are complaining, with js, including myself. [19:59:35] (03PS2) 10Pmiazga: 💥 Breaking change: Remove mediawiki.template.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506340 (owner: 10Jdlrobson) [19:59:47] (03CR) 10Smalyshev: [C: 03+1] Remove SearchContext from ResultsType signature [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506405 (owner: 10DCausse) [20:00:15] (03CR) 10Pmiazga: "Patch set 2 is just a rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506340 (owner: 10Jdlrobson) [20:00:41] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) @Jdlrobson what about {29b3629d8b960... [20:00:43] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/508018 (owner: 10L10n-bot) [20:00:51] 10MediaWiki-General-or-Unknown, 10ObjectFactory: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Anomie) Collecting the various different mechanisms into a more usable list: # An array with the following keys: * 'factory': (callable) Code that create... [20:01:08] 10Wikipedia-Android-App-Backlog: [Bug] Error in Article table display in dark mode - https://phabricator.wikimedia.org/T222476 (10Sharvaniharan) [20:02:23] (03Merged) 10jenkins-bot: Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [20:04:17] (03CR) 10jenkins-bot: Initial draft for DarkMode extension [extensions/DarkMode] - 10https://gerrit.wikimedia.org/r/506933 (https://phabricator.wikimedia.org/T221877) (owner: 10MusikAnimal) [20:04:42] (03CR) 10Jforrester: [C: 03+2] "Manually verified. uploaded-href-attribute-svg is escaped before display; a raw "" is also used in the English message." [core] - 10https://gerrit.wikimedia.org/r/508018 (owner: 10L10n-bot) [20:04:59] (03CR) 10Esanders: [C: 03+1] Rename EditorOverlay to SourceEditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507718 (owner: 10Bartosz Dziewoński) [20:05:18] (03Merged) 10jenkins-bot: Move Tidy functionality to TextTruncator [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497490 (owner: 10Thiemo Kreuz (WMDE)) [20:05:54] (03CR) 10Tjones: "Looks good for the first draft except for the (human) parsing error in the Korean char filter." (032 comments) [search/glent] - 10https://gerrit.wikimedia.org/r/507993 (owner: 10DCausse) [20:07:20] (03CR) 10jenkins-bot: Move Tidy functionality to TextTruncator [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497490 (owner: 10Thiemo Kreuz (WMDE)) [20:08:37] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10Tgr) 05Open→03Invalid >>! In T222413#5155155, @daniel wrote: > It would be great if we c... [20:08:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Mask] - 10https://gerrit.wikimedia.org/r/508021 (owner: 10L10n-bot) [20:09:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/Vector] - 10https://gerrit.wikimedia.org/r/508022 (owner: 10L10n-bot) [20:09:55] 10MediaWiki-Documentation, 10MediaWiki-Page-editing, 10MediaWiki-Revision-backend, 10Multi-Content-Revisions: PageContentSave does not allow modification of parameters - https://phabricator.wikimedia.org/T222413 (10Tgr) ...or the infobox part of the wiki page, anyway. Thanks for digging through the history. [20:10:10] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10jmatazzoni) @alexhollender talking to @Mooeypoo again, she has revised her opinion about whether a popup/menu or toggle switch is a good way to go. We are now back to a strong... [20:14:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508020 (owner: 10L10n-bot) [20:15:19] 10MediaWiki-API, 10MediaWiki-ServiceContainer, 10MediaWiki-Special-pages, 10Anti-Harassment, and 3 others: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dmaza) I think that supporting the definition to be either a... [20:15:31] 10MediaWiki-Documentation, 10Tool-extjsonuploader: Parse MediaWiki hook documentation from hooks.txt and upload it to MediaWiki.org - https://phabricator.wikimedia.org/T222477 (10Tgr) [20:16:03] (03CR) 10jerkins-bot: [V: 04-1] 💥 Breaking change: Remove mediawiki.template.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506340 (owner: 10Jdlrobson) [20:16:48] 10MediaWiki-General-or-Unknown, 10Documentation: replace 537 subpages of Manual:Hooks/ with generated doc - https://phabricator.wikimedia.org/T93043 (10Tgr) >>! In T93043#1338762, @Tgr wrote: > Just talked about this with @bd808 recently. hooks.txt could be migrated to YAML; that's still readable (arguable mor... [20:17:26] 10Wikipedia-Android-App-Backlog: Page bottom bar behavior and appearance - https://phabricator.wikimedia.org/T222478 (10Sharvaniharan) [20:17:35] (03CR) 10Nray: [C: 04-1] "i think i changed one too many things" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508016 (https://phabricator.wikimedia.org/T222475) (owner: 10Nray) [20:18:21] 10MediaWiki-Documentation: Display autogenerated extension information in Template:Extension - https://phabricator.wikimedia.org/T222479 (10Tgr) [20:18:32] 10MediaWiki-Documentation, 10Tool-extjsonuploader: Display autogenerated extension information in Template:Extension - https://phabricator.wikimedia.org/T222479 (10Tgr) [20:20:05] (03CR) 10Smalyshev: Add FallbackRunnerContext (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506406 (owner: 10DCausse) [20:21:13] 10MediaWiki-General-or-Unknown, 10Core Platform Team Backlog (Watching / External), 10Patch-For-Review, 10User-Daniel, 10User-thiemowmde: Hook handler functions should not require pass-by-reference unless documented in the hook signature - https://phabricator.wikimedia.org/T193951 (10Anomie) HHVM raises... [20:24:11] (03PS1) 10Aaron Schulz: Consolidate duplicated unseen change logic and fix inconsistent code [core] - 10https://gerrit.wikimedia.org/r/508033 (https://phabricator.wikimedia.org/T218511) [20:24:45] 10LDAP-Access-Requests: LDAP access to the nda group for sukhe - https://phabricator.wikimedia.org/T221990 (10Dzahn) @MoritzMuehlenhoff What makes the most sense, move from nda to wmf, adjust the check in the script, or ..? [20:26:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/508024 (owner: 10L10n-bot) [20:26:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/508027 (owner: 10L10n-bot) [20:27:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/508028 (owner: 10L10n-bot) [20:28:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/508030 (owner: 10L10n-bot) [20:29:03] (03CR) 10Nray: "i think this works" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508016 (https://phabricator.wikimedia.org/T222475) (owner: 10Nray) [20:29:39] (03PS2) 10Smalyshev: Add chronology_id field [event-schemas] - 10https://gerrit.wikimedia.org/r/504826 (https://phabricator.wikimedia.org/T212550) [20:29:59] (03CR) 10Pmiazga: [C: 03+2] "Tested, LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/499577 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [20:31:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/508029 (owner: 10L10n-bot) [20:38:43] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: MobileFrontend selenium test: "User: Check user page is editable" blocking merges on GrowthExperiments extension - https://phabricator.wikimedia.org/T222469 (10kostajh) [20:43:44] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) {F28919904} I created this basic SVG shape, some stairs are missing though. I will expand it with text labels tomorrow for each level. I hope it will do, but it's a SVG so it can... [20:44:40] 10Operations-Software-Development: Cumin can't handle targetting deployment-logstash2.deployment-prep.eqiad.wmflabs alongside other deployment-logstash hosts - https://phabricator.wikimedia.org/T222480 (10Krenair) [20:46:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Discovery-Search (Current work), 10User-Smalyshev: Special:Search doesn't use labels and descriptions for suggestions but just the item ID - https://phabricator.wikimedia.org/T55652 (10Smalyshev) [20:46:52] 10Wikimedia-Hackathon-2019-Organization: Create map of venue / floors for wiki - https://phabricator.wikimedia.org/T220690 (10Petrb) here is code: https://github.com/benapetr/wikimedia-hackathon2019/blob/master/ntk_shape.svg [20:48:45] (03Merged) 10jenkins-bot: specials: Use MobileFrontend.Context service where need be [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/499577 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [20:52:50] (03CR) 10jenkins-bot: specials: Use MobileFrontend.Context service where need be [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/499577 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [20:53:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/508018 (owner: 10L10n-bot) [20:54:30] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: MobileFrontend selenium test: "User: Check user page is editable" blocking merges on GrowthExperiments extension - https://phabricator.wikimedia.org/T222469 (10Jdlrobson) [20:54:32] 10MobileFrontend, 10Release-Engineering-Team, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), and 4 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10Jdlrobson) [20:55:07] (03CR) 10D3r1ck01: "> Tested, LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/499577 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [20:55:46] 10MobileFrontend, 10Release-Engineering-Team, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), and 4 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10Jdlrobson) @zfilipin there seems to be a ser... [21:05:35] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10User-D3r1ck01: [Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service - https://phabricator.wikimedia.org/T218244 (10D3r1ck01) [21:06:31] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10User-D3r1ck01: [Tracking] Migrate MobileContext::singleton() to a MobileFrontend.Context service - https://phabricator.wikimedia.org/T218244 (10D3r1ck01) [21:07:10] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Emailability - https://phabricator.wikimedia.org/T215626 (10MMiller_WMF) [21:09:50] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Make ImageGateway request a batch of image data for ImageCarousel's use - https://phabricator.wikimedia.org/T221813 (10nray) I'm moving this back to needs analysis because @Jdrewniak found an article with 2,429 images that this approach might not han... [21:14:48] 10Design, 10Editing Design, 10VisualEditor-MediaWiki-Mobile, 10Epic, 10VisualEditor (Current work): Edit cards: wireframe user flow for new and edited links - https://phabricator.wikimedia.org/T220385 (10ppelberg) Looking good, @iamjessklein. ###High level - **Do you think it's necessary to show the co... [21:15:14] (03PS1) 10C. Scott Ananian: Rule reference variables should not be affected by failed rules [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 [21:15:45] (03CR) 10jerkins-bot: [V: 04-1] Rule reference variables should not be affected by failed rules [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 (owner: 10C. Scott Ananian) [21:15:47] (03PS26) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [21:16:49] (03CR) 10Alexia: [C: 03+1] "This has been deployed and tested on Gamepedia without issue." [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/507585 (owner: 10Mischanix) [21:17:05] (03CR) 10Alexia: [C: 03+1] Update extension version to 3.5.1 [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/507586 (owner: 10Mischanix) [21:23:59] (03CR) 10Gehel: "Minor comment inline" (032 comments) [search/glent] - 10https://gerrit.wikimedia.org/r/507993 (owner: 10DCausse) [21:27:13] 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Minerva Selenium ReferenceDrawer tests failing - https://phabricator.wikimedia.org/T222475 (10nray) [21:30:50] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [21:32:26] (03PS65) 10Jforrester: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [21:37:07] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:03Samwilson [21:39:43] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:05Samwilson→03None [21:40:02] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, 10Patch-For-Review: Redirects with RfD tags should display in the feed under 'Nominated for deletion' - https://phabricator.wikimedia.org/T157046 (10Niharika) a:03Samwilson [21:53:53] 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10User-Ryasmeen, 10Verified, 10VisualEditor (Current work): Non-latin URL fragments don't reliably get scrolled to - https://phabricator.wikimedia.org/T220513 (10ppelberg) 05Open→03Resolved [21:55:30] (03PS2) 10C. Scott Ananian: Correctly analyse accessed rule variables in the presence of grammar cycles [wikipeg] - 10https://gerrit.wikimedia.org/r/508004 [21:55:32] (03PS2) 10C. Scott Ananian: Rule reference variables should not be affected by failed rules [wikipeg] - 10https://gerrit.wikimedia.org/r/508037 [21:55:39] 04(no projects): Odd/Incomplete results when searching in saved articles - https://phabricator.wikimedia.org/T222486 (10ABorbaWMF) [21:57:15] (03CR) 10Jforrester: [C: 03+1] "PS65: Escaped an API i18n message, and switched out a use of dieUsage with dieWithError, per Anomie (thanks!)." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [22:07:02] (03PS1) 10Aaron Schulz: Optimize WikiMap::getWikiFromUrl() for the common local wiki case [core] - 10https://gerrit.wikimedia.org/r/508042 [22:10:23] 10MediaWiki-Database, 10Librarization, 10Proposal: Librarize MediaWiki database layer and drop official support for non-MySQL engines - https://phabricator.wikimedia.org/T158929 (10aaron) Yes, even Oracle can go under /libs once the foreign key mess is dealt with. Things like BagOStuff would have to be done... [22:10:25] 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10brennen) [22:10:59] 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10brennen) [22:12:54] 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10Jdforrester-WMF) Sub-task of T222237 conceptually? [22:14:28] 10codfw-rollout: Add redundancy to IRC and RCStream services - https://phabricator.wikimedia.org/T128592 (10Krenair) (That being said, if this were done today it'd probably make more sense to do the stretch/buster migration work *first* and start the new VM with that, instead of creating a new jessie VM that'd j... [22:15:50] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [22:15:57] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [22:17:13] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [22:17:17] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [22:17:18] 10Developer Productivity, 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10brennen) [22:17:37] 10Developer Productivity, 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10brennen) Yeah, that seems correct. [22:18:38] 10Developer Productivity, 10local-charts: Handle multiversion in local-charts MediaWiki deployment - https://phabricator.wikimedia.org/T222488 (10brennen) [22:19:57] (03PS1) 10Examknow: Adding files [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/508047 [22:20:20] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10cooltey) I see. Will do that. Thanks Robin! [22:22:01] (03CR) 10jerkins-bot: [V: 04-1] Optimize WikiMap::getWikiFromUrl() for the common local wiki case [core] - 10https://gerrit.wikimedia.org/r/508042 (owner: 10Aaron Schulz) [22:23:03] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: CAS update failed on user_touched. The version of the user to be saved is older than the current version. - https://phabricator.wikimedia.org/T222195 (10Etonkovidova) 05Open→03Reso... [22:23:04] (03PS2) 10Examknow: Adding files [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/508047 [22:29:59] (03PS3) 10Examknow: Adding files [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/508047 [22:30:02] 10MediaWiki-extensions-WikibaseRepository, 10Discovery-Search, 10Wikidata, 10patch-welcome: OpenSearch API for Wikidata returns no results - https://phabricator.wikimedia.org/T53172 (10Smalyshev) p:05Low→03Lowest [22:30:49] 10Discovery, 10Discovery-Search: Include WikibaseCirrusSearch into CirrusSearch tests - https://phabricator.wikimedia.org/T221135 (10Smalyshev) p:05Triage→03Normal [22:33:59] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [22:34:45] (03PS3) 10Aaron Schulz: [WIP] Add a convenience method to purge file cache and CDN together [core] - 10https://gerrit.wikimedia.org/r/496695 [22:35:27] 10Wikimedia-Hackathon-2019: Introduction to local development using kubernetes - https://phabricator.wikimedia.org/T222490 (10jeena) [22:41:20] 10ISA: API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10NavinoEvans) [22:41:23] (03PS27) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [22:41:55] 10ISA: API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10NavinoEvans) [22:41:57] 10ISA: Retrieve individual image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [22:45:36] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10alexhollender) @jmatazzoni @Mooeypoo "dark mode toggle - B.pdf" is a mockup of what we discussed in the meeting yesterday. My initial concern is that it is a new, non-standard in... [22:45:40] 10ISA: API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10NavinoEvans) [22:48:39] (03PS4) 10Examknow: Adding files [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/508047 [22:50:13] (03CR) 10Examknow: "Please review all code and make improvements in security and ease of and use stay tuned for more updates. — David Schultz (Examknow)" [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/508047 (owner: 10Examknow) [22:55:39] 10ISA: API call to get Structured data for image file - https://phabricator.wikimedia.org/T222493 (10NavinoEvans) [22:55:59] 10ISA: Retrieve individual image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [22:56:01] 10ISA: API call to get Structured data for image file - https://phabricator.wikimedia.org/T222493 (10NavinoEvans) [22:57:00] (03CR) 10Nray: ">" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507202 (https://phabricator.wikimedia.org/T221624) (owner: 10Nray) [22:59:43] (03PS4) 10Aaron Schulz: [WIP] Add a convenience method to purge file cache and CDN together [core] - 10https://gerrit.wikimedia.org/r/496695 [23:08:51] 10ISA: API call to get labels for Wikidata IDs used in depicts statements - https://phabricator.wikimedia.org/T222495 (10NavinoEvans) [23:12:27] 10Product-Analytics: [REQUEST] En Wiki pageviews by topic. Rough cut. - https://phabricator.wikimedia.org/T221891 (10chelsyx) In this analysis, I use the [ORES draft topic model](https://www.mediawiki.org/wiki/Talk:ORES/Draft_topic) to get the topics of articles viewed on English Wikipedia in March 2019. The to... [23:12:42] 10MediaWiki-Page-derived-data, 10MediaWiki-Parser, 10Performance-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Avoid extra parse/save delay for users with non-canonical parser options - https://phabricator.wikimedia.org/T216306 (10aaron) 05Open→03Resolved Confirmed via xhgui;... [23:13:57] 10ISA: Commons API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10NavinoEvans) [23:16:25] (03CR) 10Aaron Schulz: [C: 03+2] Mock IDatabase::class instead of DatabaseMysqli::class [core] - 10https://gerrit.wikimedia.org/r/507602 (owner: 10Umherirrender) [23:18:27] 10ISA: Retrieve individual image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [23:19:18] 10ISA: Retrieve individual image data to populate Participate page - https://phabricator.wikimedia.org/T222433 (10NavinoEvans) [23:19:20] 10ISA: API call to get labels for Wikidata IDs used in depicts statements - https://phabricator.wikimedia.org/T222495 (10NavinoEvans) [23:19:45] 10ISA: Commons API call to get Structured data for image file - https://phabricator.wikimedia.org/T222493 (10NavinoEvans) [23:20:10] 10ISA: Wikidata API call to get labels for Wikidata IDs used in depicts statements - https://phabricator.wikimedia.org/T222495 (10NavinoEvans) [23:20:33] 10ISA: Commons API call to get Unstructured data for image file - https://phabricator.wikimedia.org/T222492 (10NavinoEvans) [23:21:39] 10Operations-Software-Development: Cumin can't handle targetting deployment-logstash2.deployment-prep.eqiad.wmflabs alongside other deployment-logstash hosts - https://phabricator.wikimedia.org/T222480 (10Volans) p:05Triage→03Normal Indeed, that's weird and not expected. It seems a bug in ClusterShell's Node... [23:22:01] (03PS28) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:23:13] 10MediaWiki-Database, 10Librarization, 10Proposal: Librarize MediaWiki database layer and drop official support for non-MySQL engines - https://phabricator.wikimedia.org/T158929 (10Tgr) Note that the need for this (but not for librarizing the RDBMS component in general) would probably be obviated by {T191231... [23:23:39] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbie... - https://phabricator.wikimedia.org/T222206 [23:26:14] 10Anti-Harassment, 10Wikimedia-Site-requests, 10Bengali-Sites: Deploy Partial Blocks to Bengali Wikipedia - https://phabricator.wikimedia.org/T222258 (10Aftabuzzaman) [23:35:24] (03CR) 10Jdlrobson: [C: 03+2] Update Minerva Selenium ReferenceDrawer selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508016 (https://phabricator.wikimedia.org/T222475) (owner: 10Nray) [23:35:42] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10cooltey) Since we are going to remove the `peek` behavior from the ToC scroller, the `EventLogging` schema should... [23:36:16] (03Merged) 10jenkins-bot: Mock IDatabase::class instead of DatabaseMysqli::class [core] - 10https://gerrit.wikimedia.org/r/507602 (owner: 10Umherirrender) [23:36:44] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10Mooeypoo) Ooh, those look really nice, I think they work better than a popup (and as mentioned, we will have a much easier time making them accessible; the menus tend to be probl... [23:38:06] 10MediaWiki-extensions-GlobalPreferences: Make Meta's global preferences include everything - https://phabricator.wikimedia.org/T221655 (10Niharika) [23:39:43] (03CR) 10jerkins-bot: [V: 04-1] rdbms: Document varargs for IDatabase::buildLike [core] - 10https://gerrit.wikimedia.org/r/439303 (https://phabricator.wikimedia.org/T191668) (owner: 10Umherirrender) [23:43:22] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10Mooeypoo) One more thing, sorry for the flood here, but we might need to lazy-load the CSS styles. If we do, there **might** be a few milliseconds (potentially a little more to s... [23:43:52] (03CR) 10jenkins-bot: Mock IDatabase::class instead of DatabaseMysqli::class [core] - 10https://gerrit.wikimedia.org/r/507602 (owner: 10Umherirrender) [23:45:03] 10Product-Analytics: [REQUEST] En Wiki pageviews by topic. Rough cut. - https://phabricator.wikimedia.org/T221891 (10JKatzWMF) @chelsyx I don't know what wonderful deed I did to deserve the insights derived here. This is gold. Thank you. It actually upends some previous 3rd party data I had been using about... [23:58:56] (03Merged) 10jenkins-bot: Update Minerva Selenium ReferenceDrawer selector [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/508016 (https://phabricator.wikimedia.org/T222475) (owner: 10Nray)