[00:00:00] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Switch Hogan for Mustache - https://phabricator.wikimedia.org/T220620 (10alexhollender) @Jdlrobson I think we've di... [00:22:15] (03Merged) 10jenkins-bot: build: Upgrade grunt from 1.0.3 to 1.0.4 [core] - 10https://gerrit.wikimedia.org/r/507490 (owner: 10Jforrester) [00:22:21] (03Merged) 10jenkins-bot: build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/507491 (owner: 10Jforrester) [00:24:46] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Switch Hogan for Mustache - https://phabricator.wikimedia.org/T220620 (10Jdlrobson) >>! In T220620#5151605, @alexho... [00:25:02] (03CR) 10jenkins-bot: build: Upgrade grunt from 1.0.3 to 1.0.4 [core] - 10https://gerrit.wikimedia.org/r/507490 (owner: 10Jforrester) [00:27:40] (03CR) 10jenkins-bot: build: Upgrade grunt-banana-checker from 0.6.0 to 0.7.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/507491 (owner: 10Jforrester) [00:27:47] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [00:27:51] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: widescreen homepage is stretched - https://phabricator.wikimedia.org/T222003 (10Etonkovidova) 05Open→03Resolved Full-screen on 25-inch monitor {F28894530} [00:43:05] (03CR) 10Jforrester: [C: 03+1] Separate right for password reset [core] - 10https://gerrit.wikimedia.org/r/506552 (owner: 10Gergő Tisza) [00:44:11] (03CR) 10Jforrester: [C: 03+1] 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [00:51:21] 10MediaWiki-User-management, 10User-Zoranzoki21: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Zoranzoki21) a:03Zoranzoki21 Let me try :) [01:06:29] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [01:07:05] (03CR) 10Jforrester: "Pinging Krinkle given the page payload improvement for most readers." [core] - 10https://gerrit.wikimedia.org/r/507067 (owner: 10Fomafix) [01:10:52] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 3: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/506695 (https://phabricator.wikimedia.org/T176526) (owner: 10D3r1ck01) [01:21:49] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) I went through a few iterations on the API in the last couple of days. Here's my current favourite. First th... [01:35:40] (03PS1) 10Zoranzoki21: Disable a user session and log them out when blocking [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) [01:36:55] 10MediaWiki-User-management, 10Patch-For-Review, 10User-Zoranzoki21: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Zoranzoki21) >>! In T222281#5151702, @gerritbot wrote: > Change 507732 had a related patch set uploaded (by Zoranzoki21; owne... [01:37:46] (03PS2) 10Zoranzoki21: Disable a user session and log them out when blocking [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) [01:48:33] (03PS3) 10Zoranzoki21: Disable a user session and log them out when blocking [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) [01:59:38] (03CR) 10jerkins-bot: [V: 04-1] Disable a user session and log them out when blocking [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) (owner: 10Zoranzoki21) [02:00:42] (03CR) 10Dmaza: [C: 04-1] "I think that this new feature should be behind a flag and/or as another option for the admin to check when creating the block." [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) (owner: 10Zoranzoki21) [02:03:10] (03CR) 10Zoranzoki21: "> I think that this new feature should be behind a flag and/or as" [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) (owner: 10Zoranzoki21) [02:03:33] (03CR) 10Kosta Harlan: Add README and Dockerfile templates for base, php, and httpd images (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [02:04:51] 10MediaWiki-User-management, 10Patch-For-Review, 10User-Zoranzoki21: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10dmaza) Copying over the "in-patch" comment for better discussion ` I think that this new feature should be behind a flag and... [02:05:18] 10MediaWiki-User-management, 10Anti-Harassment, 10Patch-For-Review, 10User-Zoranzoki21: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10dmaza) [02:15:46] (03Abandoned) 10Zoranzoki21: Disable a user session and log them out when blocking [core] - 10https://gerrit.wikimedia.org/r/507732 (https://phabricator.wikimedia.org/T222281) (owner: 10Zoranzoki21) [02:16:12] 10MediaWiki-User-management, 10Anti-Harassment: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Zoranzoki21) a:05Zoranzoki21→03None [02:18:22] (03PS1) 10Jforrester: IndexContent: Use MediaWikiServices rather than wgParser [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507735 [02:18:24] (03PS1) 10Jforrester: build: Upgrade mediawiki-codersniffer from 24.0.0 to 25.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507736 [02:23:28] 10AbuseFilter, 10I18n: Reword some Abusefilter strings to use "image" instead of "file" - https://phabricator.wikimedia.org/T132026 (10DannyS712) Since this seems to have been abandoned, I can work on this, but should I? If so, what should "file" be changed to? [02:42:41] 10MediaWiki-User-management, 10Anti-Harassment: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10Reedy) >>! In T222281#5151753, @dmaza wrote: > Copying over the "in-patch" comment for better discussion > > ` > I think that this new feature shou... [02:56:13] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Use thumb.php for impact image thumbnails - https://phabricator.wikimedia.org/T222223 (10Etonkovidova) 05Open→03Resolved Example from... [02:56:16] 10MediaWiki-Database: MySQLMasterPos should support Percona-style GTIDs - https://phabricator.wikimedia.org/T222304 (10MarkAHershberger) 05Open→03Invalid This error shows up when you don't have GTIDs set up yet. [03:25:09] 10Design, 10Community-Tech, 10Dark-Mode: Design UI for turning dark mode on and off - https://phabricator.wikimedia.org/T221809 (10alexhollender) Initial sketch below. I'm happy to put this in Invision/freehand to allow for more direct comments if that's helpful. {F28895331} [03:49:51] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: If a talk page containing a question is deleted, it causes fatal error for all newbies - https://phabricator.wikimedia.org/T222206 (10Urbanecm) Ehm, in my point of view, not... [04:00:42] 04(no projects): [extlink] parsing - link cannot contain language variant or extension tags - https://phabricator.wikimedia.org/T222328 (10Dan1wang) [04:07:50] (03CR) 10Tpt: [C: 03+2] IndexContent: Use MediaWikiServices rather than wgParser [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507735 (owner: 10Jforrester) [04:07:54] (03CR) 10Tpt: [C: 03+2] build: Upgrade mediawiki-codersniffer from 24.0.0 to 25.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507736 (owner: 10Jforrester) [04:13:50] (03Merged) 10jenkins-bot: IndexContent: Use MediaWikiServices rather than wgParser [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507735 (owner: 10Jforrester) [04:13:52] (03Merged) 10jenkins-bot: build: Upgrade mediawiki-codersniffer from 24.0.0 to 25.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507736 (owner: 10Jforrester) [04:15:53] (03CR) 10jenkins-bot: IndexContent: Use MediaWikiServices rather than wgParser [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507735 (owner: 10Jforrester) [04:18:13] (03CR) 10jenkins-bot: build: Upgrade mediawiki-codersniffer from 24.0.0 to 25.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/507736 (owner: 10Jforrester) [04:23:17] 10ContentTranslation, 10Wikimedia-Site-requests, 10Bengali-Sites, 10Language-Team (Language-2019-April-June): Deploy of Content Translation Extension on bn.wikibooks - https://phabricator.wikimedia.org/T222092 (10Shahadat) [04:29:37] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, 10Patch-For-Review: Page Curation toolbar: do not mark pages as 'reviewed' when adding CSD and PROD tags - https://phabricator.wikimedia.org/T208685 (10Insertcleverphrasehere) Awesome work folks. [04:30:34] 10MediaWiki-extensions-PageCuration, 10Community-Tech, 10Growth-Team, 10Community-Tech-Sprint, and 2 others: Allow filtering by no citations in page curation - https://phabricator.wikimedia.org/T169120 (10Insertcleverphrasehere) Awesome work folks! [04:31:55] (03CR) 10Samwilson: [C: 03+1] Don't mark pages as patrolled when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507721 (https://phabricator.wikimedia.org/T208685) (owner: 10MusikAnimal) [05:07:15] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Fomafix) [05:07:20] (03CR) 10Fomafix: "I reported this as T222329." [core] - 10https://gerrit.wikimedia.org/r/504473 (https://phabricator.wikimedia.org/T163142) (owner: 10Jforrester) [05:10:42] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Fomafix) [05:53:07] 10MediaWiki-extensions-TwnMainPage, 10User-abi_: Logspam from TwnMainPage: Undefinex index: [group id] in multiple locations - https://phabricator.wikimedia.org/T220583 (10Nikerabbit) It seems I had misdiagnosed the issue. By inspecting code, the cause seems to be coming from https://github.com/wikimedia/media... [06:28:42] 10WMSE-Library-Data-2018, 10Goal: Write Final Report - https://phabricator.wikimedia.org/T205399 (10Alicia_Fagerving_WMSE) There's no required template. [[ https://docs.google.com/document/d/1dBw9yzRnEaGb3IhaHPpMXnYXwA0NlYizDFU2MSzyAls/ | Link to working file ]]. [06:30:19] 04(no projects): Wikidata search dropdown is blank when there's an exact name match - https://phabricator.wikimedia.org/T222333 (10Tagishsimon) [06:41:18] 04(no projects): Wikidata search dropdown is blank when there's an exact name match - https://phabricator.wikimedia.org/T222333 (10Tagishsimon) And the clear risk with this issue is that if one enters a search term that should get a match ... for instance - Judith Schwarz - and places a reliance on the dropdown... [06:58:13] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [07:00:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Performance, 10User-Smalyshev: Find a solution for SpecialEntitiesWithoutPage (EntitiesWithoutTermFinder) - https://phabricator.wikimedia.org/T194144 (10Smalyshev) p:05Triage→03Normal [07:00:59] 10MediaWiki-Internationalization, 10I18n, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10User-DannyS712: [[MediaWiki:Log-action-filter-newusers-byemail/en]] contains "e-mail" instead of "email" - https://phabricator.wikimedia.org/T220871 (10DannyS712) 05Open→03Resolved See https://... [07:03:40] 10MediaWiki-extensions-Other, 10I18n, 10Patch-For-Review, 10User-DannyS712: [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail" - https://phabricator.wikimedia.org/T220870 (10DannyS712) 05Open→03Resolved [07:05:01] 10MobileFrontend, 10Readers-Web-Backlog, 10I18n, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 3 others: Replace "Wikipedia" with "{{int:Sitetitle}}" in [[MediaWiki:Mobile-frontend-nearby-info-description]] - https://phabricator.wikimedia.org/T219721 (10DannyS712) 05Open→03Resolved See https://www.me... [07:11:05] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) I'd prefer something more DI-friendly. Handlers (or handler factories) should be constructed by MediaWikiServices... [07:11:13] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10User-DannyS712: New Pages Feed: Add filter option to hide pages created by the viewer - https://phabricator.wikimedia.org/T215742 (10DannyS712) [07:12:12] (03PS1) 10Dvogel hallowelt: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 [07:13:09] (03CR) 10Tim Eulitz: [C: 03+1] Improve rollback tests setup by extracting repeating logic to HistoryPage object (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506623 (https://phabricator.wikimedia.org/T220479) (owner: 10Tonina Zhelyazkova) [07:13:45] (03CR) 10Gergő Tisza: [C: 04-1] "The reason we hard-deprecate is to see if there are production uses :) Often you can see it from just doing a code search, but not in a ca" [core] - 10https://gerrit.wikimedia.org/r/506695 (https://phabricator.wikimedia.org/T176526) (owner: 10D3r1ck01) [07:14:44] 10CommRel-Specialists-Support (Apr-Jun-2019): Support the final revision of the medium term plan - https://phabricator.wikimedia.org/T222286 (10Qgil) [07:16:42] 10CommRel-Specialists-Support (Apr-Jun-2019): Support the final revision of the medium term plan - https://phabricator.wikimedia.org/T222286 (10Qgil) [07:18:24] 10CommRel-Specialists-Support (Apr-Jun-2019): Write blog post on the Wikimedia Summit ToT - https://phabricator.wikimedia.org/T222288 (10Qgil) [07:22:41] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07): CX2: Make version 2 the only available - https://phabricator.wikimedia.org/T212646 (10Petar.petkovic) [07:23:55] (03PS2) 10Pwirth: Upped version and requirements [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/504837 [07:26:18] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [07:26:42] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-Nikerabbit, 10User-abi_: Investigate ways to reduce the size of translate-groups cache key - https://phabricator.wikimedia.org/T213802 (10abi_) Hi @elukey, Niklas has raised some valid arguments regarding my current implementation, as such we are... [07:29:08] (03PS2) 10Dvogel hallowelt: Fix scrolling to jumpmark if attribute 'href' is not starting with # [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 [07:29:57] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [07:30:28] (03PS20) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [07:38:41] (03CR) 10Daniel Kinzler: [C: 03+1] "Looks good at a glance" (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/504797 (https://phabricator.wikimedia.org/T198342) (owner: 10BPirkle) [07:42:23] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [07:42:38] 10UniversalLanguageSelector, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Wikimedia-production-error: UniversalLanguageSelector: CAS update failed on user_touched. The version of the user to be saved is older than the current version. - https://phabricator.wikimedia.org/T222300 (10Petar.petkovic) [07:44:38] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Regression: [wmf.3 - regression] testwiki - placeholded image for cx-selected-source-page__image not displayed - https://phabricator.wikimedia.org/T222250 (10Petar.petkovic) [07:49:39] 10InternetArchiveBot: IABot inserts "Archived copy" instead of actual title - https://phabricator.wikimedia.org/T222340 (10Jonesey95) [07:52:54] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [07:53:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code el-cy - https://phabricator.wikimedia.org/T198674 (10Lea_Lacroix_WMDE) 05Open→03Resolved \o/ [07:53:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [07:53:22] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code syc - https://phabricator.wikimedia.org/T164580 (10Lea_Lacroix_WMDE) 05Open→03Resolved \o/ [07:53:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [07:53:41] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Add monolingual language code abq (Abaza) - https://phabricator.wikimedia.org/T155367 (10Lea_Lacroix_WMDE) 05Open→03Resolved \o/ [07:54:00] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Lea_Lacroix_WMDE) [07:54:07] (03CR) 10Mglaser: "recheck" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/485198 (owner: 10Robert Vogel) [07:54:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, and 3 others: Add monolingual language code hbo (Biblical Hebrew) - https://phabricator.wikimedia.org/T155368 (10Lea_Lacroix_WMDE) 05Open→03Resolved a:03Lea_Lacroix_WMDE [07:56:03] 10Design, 10WMDE-Design, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: new constraint level for suggestions - https://phabricator.wikimedia.org/T204439 (10Lea_Lacroix_WMDE) I guess I can't test it in prod today, since it's not activated, so I'll test on Monday once it's enabled :) [07:56:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Desintegrate AutoAuth [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/485198 (owner: 10Robert Vogel) [07:58:00] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:00:35] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:01:50] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:03:57] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10schoenbaechler) [08:05:15] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:05:50] (03CR) 10Pwirth: [V: 03+2 C: 03+2] "@Umherirrender: Unfortunately we can not backport the commit you mentioned to REL1_31, as there are changes to the public methods" [extensions/BlueSpiceInsertLink] (REL1_31) - 10https://gerrit.wikimedia.org/r/505747 (owner: 10Pwirth) [08:06:13] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10jcrespo) +1 to add namespace to the "title" table. Advantages: * This will reduce space on page, *links and others, increasing caching opportunities and reducing write size Disadvantages: * Prediction... [08:08:44] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:10:57] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:13:55] 10Wikidata-Termbox-Iteration-14: Research end user effect of using one rollback approach or the other - https://phabricator.wikimedia.org/T222167 (10Pablo-WMDE) a:05Pablo-WMDE→03Tarrow [08:19:25] 10Wikidocumentaries: Small front end modifications - https://phabricator.wikimedia.org/T212579 (10Susannaanas) [08:20:02] 10Wikidocumentaries: Create justified view for the Images section - https://phabricator.wikimedia.org/T210096 (10Susannaanas) 05Open→03Resolved [08:20:04] 10Wikidocumentaries: User interface modifications - https://phabricator.wikimedia.org/T210229 (10Susannaanas) [08:20:42] 10Wikidocumentaries: Language fallback for content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:20:44] 10Wikidocumentaries: Create a fallback header for a topic without image - https://phabricator.wikimedia.org/T210316 (10Susannaanas) 05Open→03Resolved [08:22:37] 10Wikidocumentaries: Tasks overview May 2019 - https://phabricator.wikimedia.org/T222334 (10Susannaanas) [08:27:39] (03PS2) 10Pwirth: Clearify reqirements [skins/BlueSpiceCalumma] (REL1_31_dev) - 10https://gerrit.wikimedia.org/r/504835 [08:32:22] 10MediaWiki-extensions-UrlShortener: Add protocol before shortened URLs, both at Meta and the Wikidata Query Engine - https://phabricator.wikimedia.org/T222146 (10Ammarpad) >>! In T222146#5149507, @CASSIOPEIA wrote: > Hi Ammarpad, I meant to add a "button ( Wiki URL)" " (like "Cite" / "Link") on the menu bar on... [08:37:42] (03PS17) 10simetrical: Don't pass Config to service constructors [core] - 10https://gerrit.wikimedia.org/r/502818 [08:37:44] (03PS6) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 [08:38:43] (03PS12) 10Aaron Schulz: Make DeferredUpdates enqueue jobs to finish failed updates [core] - 10https://gerrit.wikimedia.org/r/497537 (https://phabricator.wikimedia.org/T218456) [08:40:36] (03CR) 10jerkins-bot: [V: 04-1] Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [08:44:11] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10schoenbaechler) [08:49:06] 10DC-Ops, 10observability: Setup graphs for power usage readings in Grafana - https://phabricator.wikimedia.org/T214183 (10fgiunchedi) I've started a new dashboard with per-pdu data here: https://grafana.wikimedia.org/d/cq0ZowkZz/pdus whereas per-site data is https://grafana.wikimedia.org/d/000000397/site-powe... [08:49:31] 10ContentTranslation, 10Wikimedia-Site-requests, 10Bengali-Sites: Deploy of Content Translation Extension on bn.wikibooks - https://phabricator.wikimedia.org/T222092 (10Arrbee) 05Open→03Declined a:05KartikMistry→03None Hello @Shahadat, Content Translation is not really usable for Wikibooks now, hence... [08:51:50] (03PS1) 10Noa wmde: Rename ID field placeholder from Schema ID to EntitySchema ID [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) [08:52:28] (03CR) 10Noa wmde: "This change is ready for review." [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) (owner: 10Noa wmde) [08:59:51] 10wb_terms - Tool Builders Migration: Overview of wb_terms redesign - https://phabricator.wikimedia.org/T221764 (10Lucas_Werkmeister_WMDE) @Multichill I think this SPARQL query is more or less equivalent? (Except for the filtering out of “onbekend”, which I added as a bonus.) `lang=sparql SELECT ?itemDescriptio... [09:01:53] (03CR) 10Lucas Werkmeister (WMDE): [C: 03+2] Rename ID field placeholder from Schema ID to EntitySchema ID [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) (owner: 10Noa wmde) [09:19:08] 10Operations-Software-Development, 10Patch-For-Review: Cumin: allow running as non-root - https://phabricator.wikimedia.org/T218440 (10Volans) I've replied to the CR. [09:20:34] 10ISA: Restructure campaign participate page based on new mock-up - https://phabricator.wikimedia.org/T222348 (10Eugene233) [09:23:21] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/506690 (owner: 10DCausse) [09:24:10] (03PS7) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 [09:25:35] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Michael, 10patch-welcome: Wikibase diffs for datetime display the property label on a separate line - https://phabricator.wikimedia.org/T87021 (10Lucas_Werkmeister_WMDE) 05Open→03Resolved a:03Michael I believe this was resolved by {T220772... [09:34:04] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve navigation model - https://phabricator.wikimedia.org/T222056 (10schoenbaechler) Hey @Dbrant, was just using the dev version. I’m excited since it looks very good so far! I have some early feedback. --- 01) An indicator that display... [09:34:45] 10Wikidata-Termbox-Iteration-14: Research end user effect of using one rollback approach or the other - https://phabricator.wikimedia.org/T222167 (10Tarrow) Attempting to research with the following plan: Using the standard android SDK With a nexus 4 (google flagship phone from 2012) with and android API v22 (th... [09:39:37] 10Wikidata-Termbox-Iteration-14: Research end user effect of using one rollback approach or the other - https://phabricator.wikimedia.org/T222167 (10Tarrow) I was unable to determine any difference with Q64. Gifs of each codebase are attached. In each test the page was loaded completely and then refreshed enteri... [09:39:46] 10Wikidata-Termbox-Iteration-14: Research end user effect of using one rollback approach or the other - https://phabricator.wikimedia.org/T222167 (10Tarrow) I was unable to determine any difference with Q64. Gifs of each codebase are attached. In each test the page was loaded completely and then refreshed enteri... [09:40:21] 10Wikidata-Termbox-Iteration-14: Expose/Find exposed character limit config - https://phabricator.wikimedia.org/T222162 (10Matthias_Geisler_WMDE) a:03Matthias_Geisler_WMDE [09:49:16] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Regression: Regression: Citation icon in reference drawer changed from gray to white - https://phabricator.wikimedia.org/T222314 (10Aklapper) [09:53:07] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): PageActions Menu should use Builder pattern and reuse existing Menu elements - https://phabricator.wikimedia.org/T221792 (10ovasileva) [09:54:03] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Aklapper) [09:56:31] 10wb_terms - Tool Builders Migration: Overview of wb_terms redesign - https://phabricator.wikimedia.org/T221764 (10Multichill) That's assuming that this query is stand alone. It's combining the results with another SQL database (the mix'n'match one). I'm quite unhappy about you guys changing tables again and dr... [09:56:49] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Aklapper) [09:56:53] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Aklapper) Tentatively setting T220728 as parent task. Please feel free to correct me. [09:57:13] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Extend and rename MobileWebMainMenuClickTracking schema - https://phabricator.wikimedia.org/T220016 (10ovasileva) [09:59:27] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: "Your Recent Questions" - https://phabricator.wikimedia.org/T218841 (10Cntlsn) > (1) (actually for @Cntlsn) >>Mockups for this capability are visible here, sh... [10:01:01] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10TheDJ) >>! In T221177#5150416, @Anomie wrote: > So they're typed, but typed via regex rather than predefined keywords.... [10:06:40] 10Wikidata-Termbox-Iteration-14: Research end user effect of using one rollback approach or the other - https://phabricator.wikimedia.org/T222167 (10Tarrow) Also noticed no difference with Earth - Q2 [10:06:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Michael: Wikibase diffs for datetime display the property label on a separate line - https://phabricator.wikimedia.org/T87021 (10Ammarpad) [10:10:03] 10Anti-Harassment, 10Wikimedia-Site-requests, 10Bengali-Sites: Deploy Partial Blocks to Bengali Wikipedia - https://phabricator.wikimedia.org/T222258 (10Ammarpad) [10:11:15] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) {F28898796} 9:57, 10:09 bold, 9:59, 11:09 unbold. [10:11:18] 10MinervaNeue (Tracking), 10Readers-Web-Backlog (Design): [Tracking] Issues with current revision view - https://phabricator.wikimedia.org/T201552 (10ovasileva) [10:11:21] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Design): Allow users to reach the current version of a page directly from mobile diff - https://phabricator.wikimedia.org/T200804 (10ovasileva) [10:11:23] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Goal: [GOAL] Advanced mobile contributions - https://phabricator.wikimedia.org/T198313 (10ovasileva) [10:11:27] 10MobileFrontend, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): No way to reach the editable version of a page when viewing the most recent mobile diff - https://phabricator.wikimedia.org/T200969 (10ovasileva) 0... [10:13:09] 10netbox: Upgrade to v2.5.12 - https://phabricator.wikimedia.org/T222351 (10Volans) [10:16:33] 10netbox: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) [10:16:40] 10netbox: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) p:05Triage→03Normal [10:18:20] 10netbox: Netbos reports: add support for decommissioning state - https://phabricator.wikimedia.org/T222353 (10Volans) [10:18:28] 10netbox: Netbos reports: add support for decommissioning state - https://phabricator.wikimedia.org/T222353 (10Volans) p:05Triage→03Normal [10:19:46] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10TheDJ) >>! In T221177#5151701, @tstarling wrote: > This allows many route handlers to be defined in a single file. Usin... [10:20:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Sascha) [10:22:48] 10netbox: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) [10:25:42] (03CR) 10Awight: [C: 03+1] "Ah, the joys of an untyped language..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507329 (owner: 10WMDE-Fisch) [10:33:48] 10Operations-Software-Development, 10netbox, 10Patch-For-Review: Figure out how to make Netbox Reports actionable / alertable - https://phabricator.wikimedia.org/T215378 (10Volans) [10:41:18] 10Dumps-Generation, 10Patch-For-Review: adds/changes dumps are much slower now - https://phabricator.wikimedia.org/T221515 (10ArielGlenn) In order to keep wikis in the next run to start before the same wiki in the previous run has finished, I added a sleep after each wiki, so that things run faster but not too... [10:41:41] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) {F28899232} Same page, three daily entries (using Watchlist Manager gadget to remove pages... [10:44:49] 04(no projects): Wikidata search dropdown is blank when there's an exact name match - https://phabricator.wikimedia.org/T222333 (10Fnielsen) There seems to be another issue with the Wikidata.org/w/api.php?action=wbsearchentities: T222347. In the case of T222333 the result is just empty, while T222347 returns st... [10:45:54] 10MediaWiki-extensions-Cargo: Cargo and PostgreSQL: schema problems and code issues - https://phabricator.wikimedia.org/T222357 (10IijimaYun) [11:02:00] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) >>! In T221177#5152457, @TheDJ wrote: > Mostly yes. But I think that it's mixing response and handler for in... [11:04:45] 10Wikidata-Termbox-Iteration-14: Add x-amples and x-monitor and x-amples to spec - https://phabricator.wikimedia.org/T222358 (10Tarrow) [11:07:15] 10MediaWiki-extensions-Cargo, 10PostgreSQL: Cargo and PostgreSQL: schema problems and code issues - https://phabricator.wikimedia.org/T222357 (10Aklapper) [11:28:39] 04(no projects): Add new "button" for Wiki URL shortener in the menu in Wikipedia - https://phabricator.wikimedia.org/T222360 (10CASSIOPEIA) [11:29:01] 10MediaWiki-extensions-UrlShortener: Add protocol before shortened URLs, both at Meta and the Wikidata Query Engine - https://phabricator.wikimedia.org/T222146 (10CASSIOPEIA) Ok thanks Ammarpad. [11:30:19] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10TheDJ) >>! In T221177#5152650, @tstarling wrote: > The reason it's not a response property is because it exists only fo... [11:35:10] (03CR) 10Pwirth: [C: 04-1] Fix scrolling to jumpmark if attribute 'href' is not starting with # (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/507739 (owner: 10Dvogel hallowelt) [11:36:14] (03PS1) 10Duncancrane: Fix headers at end of text area breaking editor [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507769 [11:36:17] 10MediaWiki-Vagrant, 10ContentTranslation: ContentTranslation role broken in vagrant - https://phabricator.wikimedia.org/T222317 (10Petar.petkovic) >>! In T222317#5151582, @TheSandDoctor wrote: > I was the one who notified @Reedy of this error. I would be very interested in a fix and am happy to provide more o... [11:38:45] (03CR) 10Duncancrane: "Would you be able to review? Many thanks" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/507769 (owner: 10Duncancrane) [11:39:10] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdrewniak) Just a note on the radio buttons. That effect on iOS is actually due... [11:49:47] (03PS2) 10Michael Große: Change link tracking key [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507285 (https://phabricator.wikimedia.org/T221947) [11:49:49] (03PS2) 10Michael Große: Rename db table for id counter [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507286 (https://phabricator.wikimedia.org/T221947) [11:49:51] (03PS2) 10Michael Große: Rename ContentModel to EntitySchema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507287 (https://phabricator.wikimedia.org/T221947) [11:49:53] (03PS2) 10Michael Große: Rename html classes and ids to entityschema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507288 (https://phabricator.wikimedia.org/T221947) [11:49:55] (03PS2) 10Michael Große: Rename configuration variables [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507289 (https://phabricator.wikimedia.org/T221947) [11:49:57] (03PS2) 10Michael Große: Actually rename the extension to EntitySchema [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507290 (https://phabricator.wikimedia.org/T221947) [11:54:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I think this patch can be merged as it is. But maybe you have an idea, or somebody else is able to improve the patch before we merge it?" (031 comment) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/507558 (owner: 10D3r1ck01) [12:13:46] (03CR) 10Nikerabbit: [C: 04-1] "I don't see a good reason to split the deletions to a separate commit. Raymond can perform renames so that we don't need to involve transl" [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [12:15:04] 10MediaWiki-extensions-UrlShortener: Add new "button" for Wiki URL shortener in the menu in Wikipedia - https://phabricator.wikimedia.org/T222360 (10Aklapper) Adding project tag, so someone could find this task. [12:18:43] 10MediaWiki-General-or-Unknown, 10CSS, 10I18n, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Update shared.css ordered list rules - https://phabricator.wikimedia.org/T222222 (10Nikerabbit) Care should be used when adding new languages to this list. Some language communities don't actual... [12:19:21] 10MediaWiki-General-or-Unknown, 10CSS, 10I18n, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07): Update shared.css ordered list rules - https://phabricator.wikimedia.org/T222222 (10Nikerabbit) [12:19:42] (03PS6) 10Daimona Eaytoy: Transfer the taintedness from objects to props [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506869 [12:19:54] (03PS5) 10Daimona Eaytoy: Add checks for ClosureType [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506870 [12:20:15] (03PS3) 10Daimona Eaytoy: Fix global variable handling [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506906 [12:20:20] (03PS24) 10Daimona Eaytoy: Update integration tests [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506124 [12:20:25] (03PS4) 10Daimona Eaytoy: Set taintedness to NO_TAINT for class-string and callable-string [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/506902 [12:20:27] (03PS3) 10Daimona Eaytoy: Take into account implicit BranchScopes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507015 [12:20:29] (03PS9) 10Daimona Eaytoy: Handle nested calls [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507065 [12:20:49] (03PS7) 10Daimona Eaytoy: Add a file with base config [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507101 [12:22:29] (03PS2) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [12:22:34] (03PS3) 10Daimona Eaytoy: Update readme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507617 [12:22:40] (03PS2) 10Daimona Eaytoy: Hack: exclude OOUI constructors from DoubleEscape reporting [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507619 [12:33:45] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10Cntlsn) > Users will access their homepage by opening the side menu and tapping their username in the list. @MMiller_WMF... [12:35:04] 10Wikidata-Termbox-Iteration-14: Add x-monitor and x-amples to spec - https://phabricator.wikimedia.org/T222358 (10Tarrow) [12:37:08] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/507776 [12:38:56] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/507777 [12:39:02] 10phan-taint-check-plugin, 10Patch-For-Review: Update phan-taint-check-plugin to a newer phan (1.3.2) - https://phabricator.wikimedia.org/T216974 (10Daimona) I checked the OOUI thingy and yes, it's a false positive due to annotations. Actually, it's the same issue mentioned by @bawolff in the commit message of... [12:39:35] (03CR) 10jerkins-bot: [V: 04-1] Upped version and requirements [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/507777 (owner: 10Pwirth) [12:41:14] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/507777 (owner: 10Pwirth) [12:42:15] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10Continuous-Integration-Config, 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Fundraising should fall back to non master - https://phabricator.wikimedia.org/T199130 (10hashar) 05Open→03Resolved Assuming it is fixed properly... [12:47:39] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceAuthors] - 10https://gerrit.wikimedia.org/r/507781 [12:49:01] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/507782 [12:55:14] (03PS3) 10Esanders: Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) [12:55:16] (03PS6) 10Esanders: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 [12:55:54] (03CR) 10Shivanshbindal9: "On deleting tray.svg and bell.svg the tray and bell icon from the header also disappears as they are used in /modules/nojs/mw.echo.badge.l" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/504404 (https://phabricator.wikimedia.org/T139779) (owner: 10Kosta Harlan) [13:00:50] (03CR) 10jerkins-bot: [V: 04-1] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [13:01:14] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [13:01:16] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceCategoryManager] - 10https://gerrit.wikimedia.org/r/507784 [13:01:18] (03PS3) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 [13:01:21] (03CR) 10Hashar: "check php" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [13:02:46] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/507785 [13:03:57] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/507786 [13:04:34] 10Editing Design, 10VisualEditor (Current work): Create guerrilla usability test kit - https://phabricator.wikimedia.org/T221326 (10iamjessklein) I'm drafting this in my [[ https://www.mediawiki.org/wiki/User:JKlein_(WMF)/guerilla-user-testing#Sandbox_wiki_pages | sandbox ]] @Aklapper I'm writing this for t... [13:06:24] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/507788 [13:06:26] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10daniel) >>! In T221177#5152090, @Tgr wrote: > I'd prefer something more DI-friendly. Handlers (or handler factories) sh... [13:07:34] (03CR) 10jerkins-bot: [V: 04-1] Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [13:12:53] (03CR) 10Daniel Kinzler: Don't pass Config to service constructors (031 comment) [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [13:17:16] (03CR) 10Daniel Kinzler: [C: 03+2] Don't pass Config to service constructors [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [13:19:30] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10SBisson) >>! In T215983#5152801, @Cntlsn wrote: >> Users will access their homepage by opening the side menu and tapping... [13:20:31] (03PS8) 10Jdrewniak: Adds AMC styles for action=history page [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/505769 (https://phabricator.wikimedia.org/T219895) [13:22:51] (03CR) 10simetrical: "This now blocks ServiceOptions. It would be nice to get that landed, because I have a bunch of other patches now that depend on it." [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [13:25:58] (03CR) 10Reedy: "Rather than doing the back compat, you can just bump the `"requires": { "MediaWiki": ">= 1.32.0" }` in extension.json to >= 1.34..." [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [13:26:33] (03CR) 10Daniel Kinzler: [C: 04-1] "The new code in rebuildLocalisationCache.php doesn't look right, see comment inline." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [13:28:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Move files to match class name [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/506538 (owner: 10Umherirrender) [13:28:28] 10ISA: Restructure campaign participate page based on new mock-up - https://phabricator.wikimedia.org/T222348 (10Eugene233) a:03Eugene233 [13:31:54] (03CR) 10Daniel Kinzler: [C: 03+2] "> Patch Set 3:" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [13:33:10] (03Merged) 10jenkins-bot: Move files to match class name [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/506538 (owner: 10Umherirrender) [13:33:57] (03CR) 10jenkins-bot: Move files to match class name [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/506538 (owner: 10Umherirrender) [13:34:25] (03PS1) 10Esanders: Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 [13:35:25] 10WMSE-Riksarkivet-TORA: WikidataCon 2019: We need a better model communicating quality/relevance of sources in Wikidata / Provenance - https://phabricator.wikimedia.org/T222142 (10Salgo60) [13:39:13] 10MediaWiki-extensions-WebDAV, 10Patch-For-Review: WebDAV master is broken on PHP7.* CI: Use of undefined constant WEBDAV_AUTH_TOKEN - https://phabricator.wikimedia.org/T220888 (10hashar) [13:39:55] (03CR) 10Daniel Kinzler: "FILE: /workspace/src/includes/Permissions/PermissionManager.php" [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [13:47:01] 10BetaFeatures: [BetaFeatures] sql/create_counts.sql : Error: 1071 Specified key was too long; max key length is 767 bytes - https://phabricator.wikimedia.org/T193533 (10hashar) [13:47:41] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Regression: Regression: Citation icon in reference drawer changed from gray to white - https://phabricator.wikimedia.org/T222314 (10ovasileva) p:05Triage→03Normal [13:48:57] (03Merged) 10jenkins-bot: Support DefaultPreferencesFactory::$options [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [13:50:49] (03CR) 10jenkins-bot: Support DefaultPreferencesFactory::$options [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [13:50:53] (03CR) 10jerkins-bot: [V: 04-1] Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [13:51:24] 10Wikimedia-Logstash: Periodic logging failure reported by swift - https://phabricator.wikimedia.org/T222365 (10fgiunchedi) [13:51:48] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Reviewing this is surprisingly simple: The tests all still succeed. So this can't be wrong. If it would be, a test would try to execute co" [core] - 10https://gerrit.wikimedia.org/r/507602 (owner: 10Umherirrender) [13:52:55] (03CR) 10Jdrewniak: Fix display of nested reference drawers (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [13:53:01] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve navigation model - https://phabricator.wikimedia.org/T222056 (10Dbrant) > 01) An indicator that displays “0“ so prominently in the interface can lead to confusion Ha, good catch! I totally forgot to think about the case of zero tabs... [13:53:05] (03Merged) 10jenkins-bot: Don't pass Config to service constructors [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [13:55:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Mock IDatabase::class instead of Database::class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [13:55:37] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/507795 [13:56:35] (03CR) 10jenkins-bot: Don't pass Config to service constructors [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [13:56:57] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/507796 [13:58:50] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/507797 [14:01:24] (03PS5) 10Pwirth: Upped version and clearify reqirements [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/504597 [14:03:43] (03CR) 10Hashar: [V: 03+2 C: 03+1] Dummy merged commit with a change [test/gerrit-ping] - 10https://gerrit.wikimedia.org/r/458903 (owner: 10Hashar) [14:03:59] (03PS1) 10Rosalie Perside (WMDE): Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) [14:06:18] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Misconfigured -- Unsupported OS/browser/version/device combo - https://phabricator.wikimedia.org/T214389 (10zeljkofilipin) a:05zeljkofilipin→03None [14:08:33] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/507800 [14:08:58] 10MobileFrontend, 10Release-Engineering-Team, 10Browser-Tests, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), and 4 others: AssertionError: false === true at thereShouldBeALinkToCreateMyUserPage on wmf-quibble PHP jobs - https://phabricator.wikimedia.org/T221860 (10zeljkofilipin) [14:10:25] 10MediaWiki-Core-Testing: Upgrade MW core from karma 3.x to 4.x - https://phabricator.wikimedia.org/T222293 (10zeljkofilipin) [14:11:51] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10Milimetric) For the record, and speaking just for the Analytics Engineering team, our team's mission is creating and maintaining a plat... [14:13:06] 10Multi-Content-Revisions (Reactive): RevisionStore must not expose user IDs from a foreign wiki - https://phabricator.wikimedia.org/T222212 (10daniel) I'll file subtasks for the immediate solution (force ID to 0) and the full solution (not clear yet). [14:13:10] (03PS2) 10Noa wmde: Rename ID field label and placeholder [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) [14:18:12] 10MediaWiki-API, 10Analytics, 10Core Platform Team, 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10EvanProdromou) a:05Tgr→03EvanProdromou I'm going to take over this ticket until I figure out what's... [14:19:17] 10media-storage: Test swift object server deployment with one disk per tcp port - https://phabricator.wikimedia.org/T222366 (10fgiunchedi) [14:19:24] 10MediaWiki-API, 10Analytics, 10Core Platform Team (Modern Event Platform (TEC2)), 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10EvanProdromou) [14:21:31] (03CR) 10Noa wmde: [C: 03+1] Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [14:24:15] (03PS1) 10D3r1ck01: installer: Avoid creating multiple RequestContext object instances [core] - 10https://gerrit.wikimedia.org/r/507806 [14:25:26] (03PS1) 10D3r1ck01: Avoid/Replace usage of deprecated `wfMemcKey()` function [core] - 10https://gerrit.wikimedia.org/r/507807 [14:25:56] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10kaldari) @Milimetric - Thanks for explaining that and thanks for your help on this. I'm glad we have a Product Analytics team now and h... [14:26:52] (03PS2) 10D3r1ck01: installer: Avoid creating multiple RequestContext object instances [core] - 10https://gerrit.wikimedia.org/r/507806 [14:27:32] 10MediaWiki-API, 10Analytics, 10Core Platform Team (Modern Event Platform (TEC2)), 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10Milimetric) @EvanProdromou I'm not sure about the details, but you'll wan... [14:27:38] (03PS2) 10D3r1ck01: Avoid/Replace usage of deprecated `wfMemcKey()` function [core] - 10https://gerrit.wikimedia.org/r/507807 [14:30:06] 10Security: Query percentage of English Wikipedia admins without 2FA - https://phabricator.wikimedia.org/T157500 (10Milimetric) 05Open→03Resolved a:03Milimetric don't see why not [14:33:42] 10MediaWiki-Database, 10MediaWiki-extensions-CentralAuth, 10Core Platform Team Backlog, 10Performance-Team, and 2 others: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki') - https://phabricator.wikimedia.org/T212284 (10daniel) "Error: 2006 MySQL server has gone away (10.6... [14:34:48] 10MediaWiki-Database, 10MediaWiki-extensions-CentralAuth, 10Core Platform Team Backlog, 10Performance-Team, and 2 others: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki') - https://phabricator.wikimedia.org/T212284 (10daniel) hm, maybe @anomie as an idea what might be ca... [14:36:02] (03PS8) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 [14:36:09] (03CR) 10simetrical: "> Patch Set 3:" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [14:36:48] (03CR) 10simetrical: "\o/ Thanks!" [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [14:38:10] 10MediaWiki-Database, 10MediaWiki-extensions-CentralAuth, 10Performance-Team, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 3 others: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki') - https://phabricator.wikimedia.org/T212284 (10WDor... [14:44:19] 10MediaWiki-Database, 10MediaWiki-Logging, 10DBA, 10Operations, and 5 others: Special:Log on commons -- entire web request took longer than 60 seconds and timed out - https://phabricator.wikimedia.org/T221458 (10WDoranWMF) 05Open→03Resolved a:03WDoranWMF [14:44:32] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: modify Schema:HelpPanel to accept events from Special:Homepage mentorship and help modules - https://phabricator.wikimedia.org/T219387 (10Etonkovidova) [14:44:35] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [14:44:37] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: no "enter-question-text" event recorded - https://phabricator.wikimedia.org/T222239 (10Etonkovidova) 05Open→03Resolved Checked in testwiki - `enter-questio... [14:44:49] 04(no projects): Allow analytics-admins to sudo as the new 'analytics' user + generalization of their sudo systemctl * capabilities - https://phabricator.wikimedia.org/T222368 (10elukey) p:05Triage→03Normal [14:45:20] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:45:22] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [14:47:07] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [14:47:14] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:47:44] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:47:52] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:48:05] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) And I saw a first case of completely read page, marked as unread. [14:48:08] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:48:14] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:48:19] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:48:33] 10Product-Analytics: Analyze impact of mobile visual editor structured workflows - https://phabricator.wikimedia.org/T221728 (10ppelberg) [14:48:51] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/507806 (owner: 10D3r1ck01) [14:49:22] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [14:53:29] (03PS7) 10Tchanders: Fix Block::newLoad for IPv6 range blocks [core] - 10https://gerrit.wikimedia.org/r/495410 (https://phabricator.wikimedia.org/T222246) [14:56:51] 10StructuredDataOnCommons: Use OO.ui.alert instead of system alert when pressing "cancel" - https://phabricator.wikimedia.org/T222370 (10Esanders) [14:58:57] 10MediaWiki-API, 10Editing QA, 10VisualEditor (Current work): VisualEditor, MobileFrontend, and other tools using action=edit do not auto-block IP addresses - https://phabricator.wikimedia.org/T216245 (10EvanProdromou) I think we are done with this ticket. Tag us again if there are problems. [15:00:55] 10MediaWiki-Database, 10Core Platform Team Kanban (Done with CPT), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Performance: Possible full scan query ApiQueryUserContribs::execute for revision_actor_temp table on commonswiki - https://phabricator.wikimedia.org/T221511 (10EvanProdromou... [15:04:33] 10ISA: Implement simple initial version of category contents retrieval - https://phabricator.wikimedia.org/T222231 (10NavinoEvans) [15:05:26] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve navigation model - https://phabricator.wikimedia.org/T222056 (10schoenbaechler) @Dbrant > Are we sure we want to hide the button if there is one (1) tab? How will the user get to the page they're currently reading? My newest update... [15:06:10] (03PS4) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [15:07:32] (03CR) 10Daniel Kinzler: [C: 04-1] Make LocalisationCache a service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [15:09:49] 10ISA: Create campaign page - https://phabricator.wikimedia.org/T221925 (10Eugene233) [15:09:54] 10ISA, 10Patch-For-Review: verify current user to be able to create new campaign - https://phabricator.wikimedia.org/T222185 (10Eugene233) 05Open→03Resolved [15:09:56] 10ISA: Create campaign page - https://phabricator.wikimedia.org/T221925 (10Eugene233) [15:09:59] 10ISA, 10Patch-For-Review: Restructure campaign-create view using new mockup design - https://phabricator.wikimedia.org/T222139 (10Eugene233) 05Open→03Resolved [15:10:06] 10ISA: Participate campaign page - https://phabricator.wikimedia.org/T221927 (10Eugene233) [15:10:09] 10ISA, 10Patch-For-Review: Restructure campaign participate page based on new mock-up - https://phabricator.wikimedia.org/T222348 (10Eugene233) 05Open→03Resolved [15:13:06] (03PS8) 10Tchanders: Fix Block::newLoad for IPv6 range blocks [core] - 10https://gerrit.wikimedia.org/r/495410 (https://phabricator.wikimedia.org/T222246) [15:13:22] 10Wikidata-Termbox-Iteration-14: Add x-monitor and x-amples to spec - https://phabricator.wikimedia.org/T222358 (10Tarrow) In the absence of more information it make sense to just wire up just _info and turn off monitoring for other endpoints since we have no idea what to put because the expected response depend... [15:13:43] 10Wikidata-Termbox-Iteration-14: Add x-monitor and x-amples to spec - https://phabricator.wikimedia.org/T222358 (10Tarrow) [15:16:10] (03CR) 10Daniel Kinzler: Don't pass Config to Parser(Factory) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [15:16:29] (03PS4) 10Umherirrender: Mock IDatabase::class instead of Database::class [core] - 10https://gerrit.wikimedia.org/r/507599 [15:16:33] (03CR) 10Umherirrender: Mock IDatabase::class instead of Database::class (032 comments) [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [15:16:46] (03CR) 10simetrical: Make LocalisationCache a service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [15:18:17] (03CR) 10Daniel Kinzler: Don't pass Config to Parser(Factory) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [15:20:11] (03CR) 10simetrical: Don't pass Config to Parser(Factory) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [15:22:02] (03PS1) 10DCausse: Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 [15:22:04] (03PS1) 10DCausse: Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 [15:25:51] (03CR) 10Daniel Kinzler: "Good to merge, one suggestion left. Let me know whether you want to adopt it or leave the code as it is." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [15:26:04] 04(no projects): Many watchlist preferences only affect non-Javascript interface (but this is not indicated in UI) - https://phabricator.wikimedia.org/T222371 (10halfeatenscone) [15:27:13] (03PS8) 10Ladsgroup: Turn logout link into a POST API call with refresh [core] - 10https://gerrit.wikimedia.org/r/506386 (https://phabricator.wikimedia.org/T25227) [15:28:34] (03CR) 10Ladsgroup: "I turned it to a trait. I don't know if I did it correctly or not. Let me know if it's wrong." [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [15:29:29] (03PS5) 10Thiemo Kreuz (WMDE): Mock IDatabase::class instead of Database::class [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [15:29:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Mock IDatabase::class instead of Database::class [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [15:29:50] (03CR) 10VolkerE: [C: 04-1] "I think I've said this before in a different topic, what happened to `.mw-ui-input` styles, are they still loaden?" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/507202 (https://phabricator.wikimedia.org/T221624) (owner: 10Nray) [15:30:15] (03CR) 10jerkins-bot: [V: 04-1] Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [15:30:46] (03CR) 10jerkins-bot: [V: 04-1] Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [15:30:58] (03CR) 10Ladsgroup: "I moved the code to a dedicated module that gets loaded when the user clicks on the logout link, that way we can avoid loading lots of dep" [core] - 10https://gerrit.wikimedia.org/r/506386 (https://phabricator.wikimedia.org/T25227) (owner: 10Ladsgroup) [15:31:33] 10MediaWiki-User-preferences: Many watchlist preferences only affect non-Javascript interface (but this is not indicated in UI) - https://phabricator.wikimedia.org/T222371 (10Mainframe98) [15:32:12] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10thcipriani) p:05Triage→03Unbreak! >>! In T222329#5152446, @Aklapper wrote: > Tentatively setting T220728 as parent task. Please feel free to correct me. Setting as... [15:32:20] (03CR) 10Daniel Kinzler: "I'm not sure this is a good idea. It makes it impossible to test any backwards-compatibility code that is based on checking the version nu" [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [15:32:40] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10daniel) I'm not sure this is a good idea. It makes it impossible to test any backwar... [15:33:35] (03PS9) 10Ladsgroup: Turn logout link into a POST API call with refresh [core] - 10https://gerrit.wikimedia.org/r/506386 (https://phabricator.wikimedia.org/T25227) [15:33:48] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Mimihitam) @Pginer-WMF I tried to translate with my own words without using any machine translation, and CT still won't let me publish it. **Your feature is so buggy, p... [15:33:50] (03CR) 10Daniel Kinzler: Don't pass Config to Parser(Factory) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/503283 (owner: 10simetrical) [15:34:59] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [15:36:28] (03CR) 10Jforrester: "> Patch Set 9:" [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [15:37:14] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10Jdforrester-WMF) >>! In T212738#5153287, @daniel wrote: > I'm not sure this is a goo... [15:38:39] (03PS10) 10Ladsgroup: Turn logout link into a POST API call with refresh [core] - 10https://gerrit.wikimedia.org/r/506386 (https://phabricator.wikimedia.org/T25227) [15:40:59] (03CR) 10Bartosz Dziewoński: HTMLForm: Improve method interface for collapsible forms (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [15:41:46] (03CR) 10Bartosz Dziewoński: "I can’t update the patch right now, feel free to amend if you feel strongly about it." [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [15:42:24] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10Nuria) @kaldari I get that you are frustrated but I find the hostility of your reply unwarranted, I made the very same point than @Mil... [15:43:25] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [15:44:44] (03CR) 10Daniel Kinzler: "> Patch Set 4:" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [15:44:44] (03CR) 10Daniel Kinzler: Deprecate the Http class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [15:46:14] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve navigation model - https://phabricator.wikimedia.org/T222056 (10schoenbaechler) @Dbrant, just noticed a minor thing. All links from the Explore feed now open in a new tab. Can we limit that behavior to the first tab only if there’s n... [15:46:32] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Volker_E) Seems to be caused by patch for T220204. [15:51:00] 10Readers-Web-Backlog, 10Epic, 10Performance-Team (Radar): [Bug] A large amount of our errors are occurring in iOS Safari - https://phabricator.wikimedia.org/T214451 (10Jdlrobson) Merged into logging infrastructure task, as there's little we can do to identify and fix these bugs without the stack trace. [15:51:08] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team: Many watchlist preferences only affect non-Javascript interface (but this is not indicated in UI) - https://phabricator.wikimedia.org/T222371 (10kostajh) [15:51:19] 10Growth-Team (Current Sprint): Homepage: features to aid discovery - https://phabricator.wikimedia.org/T220552 (10MMiller_WMF) [15:54:03] (03Merged) 10jenkins-bot: Mock IDatabase::class instead of Database::class [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [15:54:45] (03CR) 10Daniel Kinzler: "Added some thoughts. None of them are blockers. If you prefer, I'll merge this as it is." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504012 (https://phabricator.wikimedia.org/T214390) (owner: 10simetrical) [15:55:05] 10Growth-Team (Current Sprint): Homepage: features to aid discovery - https://phabricator.wikimedia.org/T220552 (10MMiller_WMF) Next step: I will think through these and prioritize which ones would be good to try out first. [15:57:44] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 10Parsing-Team, 10Parsoid-Read-Views, and 11 others: Use Parsoid HTML for all page views - https://phabricator.wikimedia.org/T55784 (10Jdlrobson) [15:57:49] (03CR) 10jenkins-bot: Mock IDatabase::class instead of Database::class [core] - 10https://gerrit.wikimedia.org/r/507599 (owner: 10Umherirrender) [15:58:24] 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Jdforrester-WMF) p:05Unbreak!→03High >>! In T222329#5153284, @thcipriani wrote: >>>! In T222329#5152446, @Aklapper wrote: >> Tentatively setting T220728 as parent ta... [15:58:55] 10MediaWiki-Search, 10Discovery-Search, 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Jdforrester-WMF) [15:59:04] 10RelatedArticles, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), and 2 others: Remove "mediawiki.template.muhogan" from RelatedArticles - https://phabricator.wikimedia.org/T219846 (10pmiazga) I'll sign off this task [15:59:10] 10MediaWiki-Search, 10Discovery-Search, 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Jdforrester-WMF) [15:59:19] 10RelatedArticles, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Remove "mediawiki.template.muhogan" from... - https://phabricator.wikimedia.org/T219846 [15:59:39] (03CR) 10Daniel Kinzler: "Your fix sounds sensible, but I'd want more eyes on it before merging it..." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507348 (owner: 10simetrical) [16:00:40] 10MobileFrontend, 10VisualEditor, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Tracking): AbuseFilter warnings and errors are handled badly by the editor - https://phabricator.wikimedia.org/T202460 (10Jdlrobson) [16:00:53] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Design recommendations for “Add/translate descriptions“ - https://phabricator.wikimedia.org/T219651 (10Sharvaniharan) @schoenbaechler Thank you... Just one more clarification: what is the color attribute for... [16:01:11] 10Operations-Software-Development, 10Patch-For-Review: Cumin: allow running as non-root - https://phabricator.wikimedia.org/T218440 (10TheAnarcat) oh i hadn't noticed tests had failed... fixed that and the other comment, hopefully we're all done here. [16:01:13] 10WMSE-Riksarkivet-TORA: WikidataCon 2019: We need a better model communicating quality/relevance of sources in Wikidata / Provenance - https://phabricator.wikimedia.org/T222142 (10Salgo60) [16:01:52] (03CR) 10Daniel Kinzler: "Changes look good except for the new-incorrect @since tag. Reviewing the changes you made to the tests is tough, though." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503281 (owner: 10simetrical) [16:02:36] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Remove the lazy load references beta feature - https://phabricator.wikimedia.org/T222373 (10Jdlrobson) [16:02:44] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Remove the lazy load references beta feature - https://phabricator.wikimedia.org/T222373 (10Jdlrobson) [16:02:55] 10Readers-Web-Backlog, 10Reading-Admin, 10Epic, 10Goal, 10Patch-For-Review: [GOAL] Lazy load references in mobile skin - https://phabricator.wikimedia.org/T123328 (10Jdlrobson) [16:03:09] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Remove the lazy load references beta feature - https://phabricator.wikimedia.org/T222373 (10Jdlrobson) [16:03:43] 10MobileFrontend, 10Readers-Web-Backlog, 10Technical-Debt: Remove the lazy load references beta feature - https://phabricator.wikimedia.org/T222373 (10Jdlrobson) To discuss at team offsite. [16:03:51] (03PS1) 10Luca Mauri: Modify "importSites.php" to import "LanguageCode" as well [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) [16:03:53] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) (owner: 10Luca Mauri) [16:07:05] (03CR) 10Jforrester: [C: 04-1] "> Patch Set 1: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:07:57] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): [EPIC] Deprecate the MobileView API - https://phabricator.wikimedia.org/T186627 (10Jdlrobson) [16:08:05] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: [EPIC] Complete the refactor of the MobileFormatter class - https://phabricator.wikimedia.org/T186823 (10Jdlrobson) [16:08:15] (03PS9) 10Tchanders: Fix Block::newLoad for IPv6 range blocks [core] - 10https://gerrit.wikimedia.org/r/495410 (https://phabricator.wikimedia.org/T222246) [16:08:21] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Tracking): [EPIC] Deprecate the MobileView API - https://phabricator.wikimedia.org/T186627 (10Jdlrobson) [16:08:28] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Tracking), 10Technical-Debt: [EPIC] Complete the refactor of the MobileFormatter class - https://phabricator.wikimedia.org/T186823 (10Jdlrobson) [16:08:36] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [16:08:41] 10New-Readers, 10Epic, 10Readers-Web-Backlog (Tracking): [EPIC] Provide a way to download articles in PDF on the mobile website - https://phabricator.wikimedia.org/T163472 (10Jdlrobson) [16:08:58] 10International-Developer-Events, 10Wikimedia-Hackathon-2019, 10Wikimedia-Hackathon-2019-Organization, 10Developer-Advocacy (Apr-Jun 2019): Wikimedia Hackathon 2019 volunteer group: Photos - https://phabricator.wikimedia.org/T219199 (10Ckoerner) I have a draft of the email I'll send to interested photograp... [16:09:07] 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10SEO: [Epic] [SEO] Enable Schema.org Article linked data for all main namespace pages - https://phabricator.wikimedia.org/T209306 (10Jdlrobson) [16:10:00] 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10SEO: [Epic] [SEO] Enable Schema.org Article linked data for all main namespace pages - https://phabricator.wikimedia.org/T209306 (10Jdlrobson) [16:10:03] 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10SEO: Remove A/B test and launch to 100% - https://phabricator.wikimedia.org/T209377 (10Jdlrobson) [16:10:56] (03CR) 10Brennen Bearnes: Add README and Dockerfile templates for base, php, and httpd images (031 comment) [releng/dev-images] - 10https://gerrit.wikimedia.org/r/502931 (https://phabricator.wikimedia.org/T218360) (owner: 10Brennen Bearnes) [16:13:00] (03PS2) 10Luca Mauri: Modify "importSites.php" to import "LanguageCode" as well [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) [16:13:20] 10Mobile: commons.wikipedia.org urls redirect to the app instead of Commons - https://phabricator.wikimedia.org/T222374 (10Sadads) [16:14:08] 10MediaWiki-Search, 10Discovery-Search, 10OOUI, 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Esanders) Exposed by OOUI, but is a downstream issue. [16:15:12] (03CR) 10Daniel Kinzler: [C: 04-1] "Intent and approach look good. Some minor problems discussed inline." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [16:17:13] (03PS1) 10Esanders: SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) [16:19:22] (03CR) 10Daniel Kinzler: "Can the method be hard-deprecated as well?" [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [16:20:01] 10Gadgets: HotCat loses categories doing multiple redirecting - https://phabricator.wikimedia.org/T222376 (10SJu) [16:22:05] 10Mobile: commons.wikipedia.org urls redirect to the app instead of Commons - https://phabricator.wikimedia.org/T222374 (10Aklapper) @Sadads: Please provide clearer steps to reproduce the problem which leave less room for interpretation and allow someone else to reproduce. [16:22:56] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10daniel) >>! In T212738#5153292, @Jdforrester-WMF wrote: > Right now altering $wgVers... [16:23:29] (03CR) 10D3r1ck01: "> Can the method be hard-deprecated as well?" [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [16:24:30] (03CR) 10Daniel Kinzler: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [16:26:26] (03CR) 10D3r1ck01: "> *sigh* yea." [core] - 10https://gerrit.wikimedia.org/r/507807 (owner: 10D3r1ck01) [16:27:53] (03PS21) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [16:28:08] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10kaldari) @Nuria, @Milimetric - Crap, I didn't mean to sound hostile. I love the Analytics Engineering team! Y'all are literally the sma... [16:28:08] (03PS2) 10Esanders: SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) [16:28:22] 10Mathe für Nicht-Freaks: Artikel Nebenklassen: Protokoll in Artikelplan abbilden von Redaktionssitzung 21.03 - https://phabricator.wikimedia.org/T219614 (10ZornschesLemma) a:05GruenerBogen→03GregorAlexandru [16:28:48] 10Mathe für Nicht-Freaks: Artikel Faktorraum: Protokoll im Artikelplan abbilden von Redaktionssitzung 28.03 - https://phabricator.wikimedia.org/T219616 (10ZornschesLemma) a:05GregorAlexandru→03GruenerBogen [16:29:57] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/507829 (owner: 10L10n-bot) [16:30:59] 04(no projects): Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Whatamidoing-WMF) [16:31:55] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/507830 (owner: 10L10n-bot) [16:33:42] 10MediaWiki-Database, 10MediaWiki-extensions-CentralAuth, 10Performance-Team, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 3 others: Fatal db error "Could not select database 'centralauth'" (sometimes also 'metawiki') - https://phabricator.wikimedia.org/T212284 (10Anom... [16:35:10] (03PS2) 10Jforrester: i18n: Drop number_of_watching_users_pageview, unused since wgPageShowWatchingUsers was dropped [core] - 10https://gerrit.wikimedia.org/r/507496 [16:35:13] (03PS2) 10Jforrester: i18n: Drop img-auth-nologinnWL, unused AFAICT [core] - 10https://gerrit.wikimedia.org/r/507497 [16:35:15] (03PS2) 10Jforrester: i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 [16:35:17] (03PS1) 10Jforrester: API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 [16:36:04] (03Abandoned) 10Jforrester: i18n: Rename number_of_watching_users_RCview for case compliance [core] - 10https://gerrit.wikimedia.org/r/507495 (owner: 10Jforrester) [16:36:07] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [16:36:13] (03Abandoned) 10Jforrester: i18n: Rename rcfilters-filtergroup-lastRevision for case compliance [core] - 10https://gerrit.wikimedia.org/r/507494 (owner: 10Jforrester) [16:36:21] (03Abandoned) 10Jforrester: i18n: Rename rcfilters-filtergroup-userExpLevel for case compliance [core] - 10https://gerrit.wikimedia.org/r/507493 (owner: 10Jforrester) [16:36:33] (03Abandoned) 10Jforrester: i18n: Rename allmessagesnotsupportedDB for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507492 (owner: 10Jforrester) [16:37:03] (03CR) 10Jforrester: [C: 04-1] "This is a breaking change for API creators, and not a lovely one. :-(" [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [16:38:56] 10MediaWiki-User-management, 10Core Platform Team: Decide how to represent the identity of users from another wiki. - https://phabricator.wikimedia.org/T222380 (10daniel) [16:39:14] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10brion) Extension code that's dependent on specific interfaces should probably featur... [16:39:16] 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) [16:39:38] 10Multi-Content-Revisions (Reactive): RevisionStore must not expose user IDs from a foreign wiki - https://phabricator.wikimedia.org/T222212 (10daniel) [16:39:45] 04(no projects): Offer different time limits when blocking a user and their IP address - https://phabricator.wikimedia.org/T222382 (10Pigsonthewing) [16:39:55] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Design recommendations for “Add/translate descriptions“ - https://phabricator.wikimedia.org/T219651 (10Sharvaniharan) And after the description is added, in the landscape mode, do we see pencil image instead... [16:40:33] 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) [16:41:01] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) [16:41:18] (03CR) 10jerkins-bot: [V: 04-1] i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:41:24] (03CR) 10Niedzielski: [C: 03+2] 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [16:41:27] (03CR) 10jerkins-bot: [V: 04-1] i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:41:39] (03CR) 10jerkins-bot: [V: 04-1] i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:41:44] (03CR) 10simetrical: Make LocalisationCache a service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [16:42:20] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) [16:42:37] (03CR) 10jerkins-bot: [V: 04-1] API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [16:42:45] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) @BPirkle do you think you could take this on? [16:42:50] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [16:42:59] (03CR) 10jerkins-bot: [V: 04-1] API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [16:43:02] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceEditNotifyConnector] - 10https://gerrit.wikimedia.org/r/507836 [16:43:04] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10daniel) p:05Triage→03High Bumping to high, since this has the potential to cause subtle data... [16:43:27] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10Jdforrester-WMF) >>! In T212738#5153464, @daniel wrote: >>>! In T212738#5153292, @Jd... [16:43:39] 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: layout and UI details - https://phabricator.wikimedia.org/T218966 (10Etonkovidova) [16:43:44] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: drop shadow on start module should disappear when all complete - https://phabricator.wikimedia.org/T222123 (10Etonkovidova) 05... [16:44:00] 10Multi-Content-Revisions (Reactive): RevisionStore must not expose user IDs from a foreign wiki - https://phabricator.wikimedia.org/T222212 (10daniel) >>! In T222212#5148049, @Tgr wrote: > What //should// it expose, though? I filed {T222380} to answer this question. Let's continue the discussion there. [16:44:40] (03PS3) 10Jforrester: i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 [16:44:42] (03PS2) 10Jforrester: API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 [16:46:02] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceEmoticons] - 10https://gerrit.wikimedia.org/r/507837 [16:46:30] 10Multi-Content-Revisions (Reactive): RevisionStore must not expose user IDs from a foreign wiki - https://phabricator.wikimedia.org/T222212 (10daniel) >>! In T222212#5149489, @Simetrical wrote: > I think it's best to not allow constructing RevisionStores on foreign repos until we have a clear-cut use-case. We... [16:47:50] 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: layout and UI details - https://phabricator.wikimedia.org/T218966 (10SBisson) [16:47:55] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: drop shadow on start module should disappear when all complete - https://phabricator.wikimedia.org/T222123 (10SBisson) 05Resol... [16:49:06] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Reactive): Force user ID to 0 when reading revisions from another wiki's database - https://phabricator.wikimedia.org/T222381 (10BPirkle) a:05daniel→03BPirkle Sure. As this is prioritized as high, I'll transition to it sh... [16:49:08] 10Wikidata-Termbox-Iteration-13, 10Wikidata-Termbox-Iteration-14: Ensure test mutations only perform reactivity-friendly changes - https://phabricator.wikimedia.org/T220686 (10Pablo-WMDE) a:03Pablo-WMDE Will look into it a short bit and dismiss it if I also fail to make a suggestion. [16:50:21] (03CR) 10jerkins-bot: [V: 04-1] i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:51:19] (03CR) 10jerkins-bot: [V: 04-1] i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:51:25] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: modify Schema:HelpPanel to accept events from Special:Homepage mentorship and help modules - https://phabricator.wikimedia.org/T219387 (10Etonkovidova) [16:51:29] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: missing "link-click" for mentorship module - https://phabricator.wikimedia.org/T222241 (10Etonkovidova) 05Open→03Resolved Checked in testwiki (`wmf.3`). `... [16:51:56] (03PS2) 10Pwirth: Upped version and requirements [extensions/BlueSpiceEditNotifyConnector] - 10https://gerrit.wikimedia.org/r/507836 [16:52:04] 10ContentTranslation: Remove Machine Translation from Content Translation on Indonesian Wikipedia - https://phabricator.wikimedia.org/T219851 (10Pginer-WMF) >>! In T219851#5153289, @Mimihitam wrote: > @Pginer-WMF I tried to translate with my own words without using any machine translation, and CT still won't let... [16:52:16] 10GrowthExperiments-Help panel, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review, 10Security: Edits using Help pane can bypass sysop-issued blocks - https://phabricator.wikimedia.org/T222014 (10Etonkovidova) 05Open→03Resolved Checked for site-wide blocked... [16:52:31] (03CR) 10jerkins-bot: [V: 04-1] API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [16:53:08] 10MediaWiki-User-management: Offer different time limits when blocking a user and their IP address - https://phabricator.wikimedia.org/T222382 (10Krenair) [16:53:52] (03CR) 10Raimond Spekking: [C: 03+1] "@James: I will rename on translatewiki.net after merge." [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [16:54:10] 10Research: Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Krenair) [16:57:06] (03PS4) 10Jforrester: i18n: Rename 11 messages for case-compliance [core] - 10https://gerrit.wikimedia.org/r/507498 [16:57:08] (03PS3) 10Jforrester: API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 [17:00:13] (03CR) 10Jforrester: "> Patch Set 3: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/507498 (owner: 10Jforrester) [17:00:50] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [17:03:01] (03CR) 10jerkins-bot: [V: 04-1] 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [17:04:16] (03CR) 10jerkins-bot: [V: 04-1] API: Require that parameter documentation i18n keys are lowercase [core] - 10https://gerrit.wikimedia.org/r/507833 (owner: 10Jforrester) [17:06:23] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - add new links to main menu with click tracking - https://phabricator.wikimedia.org/T216152 (10pmiazga) a:03pmiazga [17:07:36] (03PS4) 10Jforrester: Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [17:08:22] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip - https://phabricator.wikimedia.org/T216961 (10Jdrewniak) a:03Jdrewniak [17:08:22] (03CR) 10Jforrester: [C: 03+1] Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [17:08:31] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - overflow menu - https://phabricator.wikimedia.org/T216418 (10Jdlrobson) a:03Niedzielski Stephen to add! [17:08:38] (03PS7) 10Jforrester: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [17:08:42] (03PS2) 10Pmiazga: Improve Community Main Menu element handling [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506842 (https://phabricator.wikimedia.org/T216152) [17:09:03] (03PS2) 10Jforrester: Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [17:09:49] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - add new links to main menu with click tracking - https://phabricator.wikimedia.org/T216152 (10pmiazga) a:05pmiazga→03None [17:10:04] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): PageActions Menu should use Builder pattern and reuse existing Menu elements - https://phabricator.wikimedia.org/T221792 (10pmiazga) a:03pmiazga [17:10:30] (03PS22) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [17:12:40] 10CirrusSearch, 10Discovery-Search (Current work), 10Wikimedia-production-error: Received cirrusSearchElasticaWrite job for an unwritable cluster cloudelastic. - https://phabricator.wikimedia.org/T222307 (10debt) a:03EBernhardson This might have been a temporary error as we were deploying CloudElastic...bu... [17:13:27] 10MediaWiki-Core-Testing, 10MediaWiki-extensions-MultimediaViewer, 10MobileFrontend, 10Multimedia, and 9 others: Audit tests/selenium/LocalSettings.php file aiming at possibly deprecating the feature - https://phabricator.wikimedia.org/T199939 (10Jdlrobson) [17:14:06] (03PS1) 10Pwirth: Upped version and requirements [extensions/BlueSpiceExtendedFilelist] - 10https://gerrit.wikimedia.org/r/507842 [17:14:35] (03PS16) 10MSantos: Add module and vagrant role for Proton [vagrant] - 10https://gerrit.wikimedia.org/r/488737 (https://phabricator.wikimedia.org/T213367) (owner: 10Gergő Tisza) [17:15:19] 10MediaWiki-Search, 10Discovery-Search: Searches with hyphens yield a database query error - https://phabricator.wikimedia.org/T221560 (10debt) This is related to Mediawiki core...and not our production search. [17:16:07] 10CirrusSearch, 10Discovery-Search: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10debt) feel free to close this, @Kghbln, if the above tip works. [17:16:27] (03CR) 10MSantos: [C: 03+2] "Rebasing and recreating the vagrant locally made it work. LGTM." [vagrant] - 10https://gerrit.wikimedia.org/r/488737 (https://phabricator.wikimedia.org/T213367) (owner: 10Gergő Tisza) [17:17:28] (03Merged) 10jenkins-bot: Add module and vagrant role for Proton [vagrant] - 10https://gerrit.wikimedia.org/r/488737 (https://phabricator.wikimedia.org/T213367) (owner: 10Gergő Tisza) [17:18:11] 10CirrusSearch, 10Discovery-Search: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10Kghbln) Hey, yeah, sorry for not immediately responding. Actually I wanted to test this already. Will do so soon and create a pull for the docu. [17:19:59] (03CR) 10jenkins-bot: Add module and vagrant role for Proton [vagrant] - 10https://gerrit.wikimedia.org/r/488737 (https://phabricator.wikimedia.org/T213367) (owner: 10Gergő Tisza) [17:22:38] (03CR) 10jerkins-bot: [V: 04-1] Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [17:22:57] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10bearND) The page library code has not been updated to work with the references output. It still assumes MW API content structure, whereas the PCS references ou... [17:25:01] 10MediaWiki-User-management, 10Core Platform Team: Decide how to represent the identity of users from another wiki. - https://phabricator.wikimedia.org/T222380 (10daniel) [17:26:11] (03CR) 10jerkins-bot: [V: 04-1] Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [17:27:23] 10MediaWiki-User-management, 10Core Platform Team: Decide how to represent the identity of users from another wiki. - https://phabricator.wikimedia.org/T222380 (10Tgr) If we do something that requires major changes, it would be nice to be forward-looking and not limit this to user accounts on the same wiki far... [17:28:04] (03CR) 10jerkins-bot: [V: 04-1] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [17:28:48] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10bearND) > Should we getting the id from id="cite_ref-RuddAvengers4_11-0" or href="#cite_note-RuddAvengers4-11"? When you respond to a click to a reference you... [17:31:15] 10MediaWiki-Vagrant, 10Proton, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Add MediaWiki-Vagrant role for Proton - https://phabricator.wikimedia.org/T213367 (10Tgr) 05Open→03Resolved [17:35:19] (03CR) 10Daniel Kinzler: "The new methods in PermissionManager still need unit tests, right?" [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [17:35:37] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) Now I can see that the original issue continues. Listen, the problem is at all in this task... [17:38:08] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10Nuria) @kaldari Thank you for providing context! Really!.Let's be in closer touch for other things you think you need so we can help yo... [17:38:26] (03CR) 10Jdlrobson: [C: 03+2] Improve Community Main Menu element handling [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506842 (https://phabricator.wikimedia.org/T216152) (owner: 10Pmiazga) [17:38:51] (03PS4) 10Jdlrobson: 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) [17:38:55] (03CR) 10Jdlrobson: [C: 03+2] 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [17:38:58] 10MediaWiki-Configuration, 10MediaWiki-General-or-Unknown, 10MW-1.33-release, 10Patch-For-Review, 10Technical-Debt (Deprecation): Deprecate $wgVersion and move to a constant - https://phabricator.wikimedia.org/T212738 (10daniel) Ok, you convinced me. Testing is not an issue (or rather, having a variable... [17:39:48] 10MediaWiki-Database, 10PostgreSQL: MediaWiki Resource Loader, upsert(), and PostgreSQL: deadlock issues - https://phabricator.wikimedia.org/T222385 (10IijimaYun) [17:40:21] (03CR) 10Daniel Kinzler: "After discussion on the phab ticket, my concerns regarding testing have been addressed. I have no objections to moving to a constant." [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [17:42:43] 10Gadgets: HotCat loses categories doing multiple redirecting - https://phabricator.wikimedia.org/T222376 (10Aklapper) @SJu: Is this really related to the #Gadgets PHP extension? Or to HotCat itself? [17:47:24] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10IKhitron) And now I can see a page with no bold edits at all, but with edits I never read. [17:47:38] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10cooltey) Thanks for the responses, @bearND > Are you using the page library for this task? Yes, I would like to keep the method of collecting references gro... [17:47:38] (03PS5) 10Jforrester: Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [17:48:08] 10MediaWiki-Revision-deletion, 10Performance, 10Security: Unable to perform revision deletion on Commons - https://phabricator.wikimedia.org/T222324 (10sbassett) 05Open→03Resolved [17:48:28] (03PS4) 10Jdlrobson: ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) [17:49:27] (03PS1) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [17:49:31] (03CR) 10Hoo man: [C: 03+2] Cleared out the "Edit" text on Schema edit page [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507799 (https://phabricator.wikimedia.org/T222259) (owner: 10Rosalie Perside (WMDE)) [17:50:00] (03PS2) 10Daimona Eaytoy: Fix a few FIXMEs [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507848 [17:50:02] (03PS1) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [17:51:13] (03CR) 10Vedmaka Wakalaka: "> Patch Set 22:" [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [17:51:26] 10Operations-Software-Development, 10Patch-For-Review: Cumin: allow running as non-root - https://phabricator.wikimedia.org/T218440 (10Volans) 05Open→03Resolved p:05Triage→03Normal a:03Volans Patch has been merged into master and will be part of the next Cumin release. [17:55:05] 10netbox: Server Lifecycle: re-arrage statuses including a decommissioning one - https://phabricator.wikimedia.org/T222352 (10Volans) Here a draft proposal for the introduction of the new decomissioning state in Netbox and our Lifecycle. Current definition: | Server Lifecycle | Netbox | Racked | Power | | req... [17:55:31] (03PS1) 10Jforrester: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) [17:56:13] 10MediaWiki-Revision-deletion, 10Patch-For-Review, 10Performance, 10Security: Unable to perform revision deletion on Commons - https://phabricator.wikimedia.org/T222324 (10Jdforrester-WMF) Thank you! [17:57:17] (03PS1) 10SBassett: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) [17:57:40] (03CR) 10Jforrester: [C: 03+2] SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) (owner: 10Esanders) [17:57:44] (03CR) 10Daniel Kinzler: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [17:58:33] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [17:59:24] (03CR) 10Jforrester: [C: 03+2] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [17:59:38] (03CR) 10Daniel Kinzler: "please add unit tests for the new methods" [core] - 10https://gerrit.wikimedia.org/r/507081 (owner: 10simetrical) [18:00:51] (03CR) 10jerkins-bot: [V: 04-1] ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [18:01:19] (03CR) 10DCausse: Allow per-cluster CirrusSearchMaxShardsPerCluster (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507349 (owner: 10EBernhardson) [18:01:34] (03CR) 10Jforrester: "Happy to land this immediately after the SWAT." [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [18:01:42] (03CR) 10SBassett: "This is the "cherry-pick" to 1.34.0-wmf.3 since we didn't keep the sec patch in the patches dir." [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [18:01:51] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Anomie) >>! In T221177#5151430, @Tgr wrote: > Re: pagination, for Wikimedia scale it tends to be surprisingly involved;... [18:05:46] (03Merged) 10jenkins-bot: Improve Community Main Menu element handling [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506842 (https://phabricator.wikimedia.org/T216152) (owner: 10Pmiazga) [18:05:51] (03Merged) 10jenkins-bot: 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [18:07:38] (03PS10) 10Jforrester: Provide MW_VERSION and deprecate fake global $wgVersion [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [18:09:02] (03PS1) 10Daimona Eaytoy: Fix another fixme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [18:09:15] (03PS8) 10Jforrester: generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [18:09:24] (03PS3) 10Jforrester: Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [18:09:59] (03PS2) 10Daimona Eaytoy: Improve caused-by lines [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507849 [18:10:14] (03CR) 10jenkins-bot: 💥 Breaking change: Remove deprecated methods/modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/505786 (https://phabricator.wikimedia.org/T217220) (owner: 10Jdlrobson) [18:10:39] (03CR) 10jenkins-bot: Improve Community Main Menu element handling [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506842 (https://phabricator.wikimedia.org/T216152) (owner: 10Pmiazga) [18:11:01] (03PS2) 10Daimona Eaytoy: Fix another fixme [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [18:11:21] 10Gadgets: HotCat loses categories doing multiple redirecting - https://phabricator.wikimedia.org/T222376 (10SJu) @Aklapper: HotCat itself is available in "Gadgets" bookmark of preference settings. I don't know whether the tag is confusing and means something else. Tag "HotCat" is not available. [18:11:47] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [18:13:17] lol wikibase [18:17:46] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [18:18:14] (03CR) 10Anomie: [C: 03+1] Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [18:19:34] (03PS9) 10simetrical: Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 [18:19:36] (03PS1) 10simetrical: Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/507856 [18:19:57] (03CR) 10jerkins-bot: [V: 04-1] SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) (owner: 10Esanders) [18:20:21] (03CR) 10Anomie: "recheck Seems like a flaky selenium test" [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [18:21:41] 10MediaWiki-User-management, 10Anti-Harassment: Only show the feedback link on Special:Block to users who can access the page - https://phabricator.wikimedia.org/T220642 (10Niharika) p:05Triage→03Normal [18:23:11] (03CR) 10jerkins-bot: [V: 04-1] Provide MW_VERSION and deprecate fake global $wgVersion [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [18:24:11] 10ISA: Implement simple initial version of category contents retrieval - https://phabricator.wikimedia.org/T222231 (10Eugene233) a:03Eugene233 [18:24:16] 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [18:25:23] (03CR) 10simetrical: MovePage methods need to run safety checks (031 comment) [core] - 10https://gerrit.wikimedia.org/r/504336 (owner: 10simetrical) [18:25:56] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) [18:25:58] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - overflow menu - https://phabricator.wikimedia.org/T216418 (10Niedzielski) [18:26:01] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) [18:26:03] 10MediaWiki-API, 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: ApiQueryBlocks should not be aware of the container - https://phabricator.wikimedia.org/T221722 (10dbarratt) [18:26:05] 10Advanced Mobile Contributions, 10Epic, 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - overflow menu - https://phabricator.wikimedia.org/T216418 (10Niedzielski) a:05Niedzielski→03Edtadros [18:26:45] (03CR) 10jerkins-bot: [V: 04-1] generatePhpCharToUpperMappings.php: Write output directly to json file [core] - 10https://gerrit.wikimedia.org/r/502804 (owner: 10Esanders) [18:26:59] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: Create a mechanism for SpecialPages and API modules to have dependencies injected into them - https://phabricator.wikimedia.org/T222388 (10dbarratt) [18:27:02] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: SpecialBlock should not be aware of the container - https://phabricator.wikimedia.org/T221383 (10dbarratt) [18:27:51] 10Operations-Software-Development, 10Patch-For-Review: Cumin: allow running as non-root - https://phabricator.wikimedia.org/T218440 (10TheAnarcat) whoohoo! thanks! [18:29:34] (03CR) 10jerkins-bot: [V: 04-1] Update phpCharToUpper.json based on current differences [core] - 10https://gerrit.wikimedia.org/r/507793 (owner: 10Esanders) [18:31:39] (03CR) 10jerkins-bot: [V: 04-1] Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [18:31:41] (03CR) 10jerkins-bot: [V: 04-1] Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/507856 (owner: 10simetrical) [18:32:42] 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): AMC Navigation - add new links to main menu with click tracking - https://phabricator.wikimedia.org/T216152 (10Jdlrobson) a:03Edtadros [18:36:41] (03CR) 10jerkins-bot: [V: 04-1] Make LocalisationCache a service [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [18:37:13] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [18:37:31] 10Discovery-Search, 10Chinese-Sites, 10Epic: [EPIC-ish][Milestone 2] Implement NLP Search Suggestion Method 2 for CJK languages - https://phabricator.wikimedia.org/T212891 (10TJones) **Korean Tokenization** @Julia.glen & @dcausse: Here are my suggested changes from current production `text` analyzer for Kor... [18:38:52] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: Deploy to target wikis in production - https://phabricator.wikimedia.org/T221266 (10kostajh) Experiment is planned to start on Monday. [18:39:54] 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: Deploy to target wikis in production - https://phabricator.wikimedia.org/T221266 (10kostajh) [18:42:42] (03CR) 10jerkins-bot: [V: 04-1] Split some Language methods to LanguageNameUtils [core] - 10https://gerrit.wikimedia.org/r/507856 (owner: 10simetrical) [18:42:44] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: start module - https://phabricator.wikimedia.org/T217105 (10Etonkovidova) [18:43:31] (03CR) 10Jforrester: [C: 03+2] "Re-try now that I've fixed T222389." [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [18:43:39] 10MediaWiki-Email, 10Anti-Harassment, 10Growth-Team, 10Notifications: Mute: Add links to the Tools menu on user pages to mute/unmute user - https://phabricator.wikimedia.org/T218270 (10Niharika) [18:43:40] (03CR) 10Jdrewniak: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [18:43:42] (03CR) 10Jforrester: [C: 03+2] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [18:43:45] (03CR) 10Jforrester: [C: 03+2] "Re-try now that I've fixed T222389." [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) (owner: 10Esanders) [18:44:17] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/481950 (https://phabricator.wikimedia.org/T212738) (owner: 10Brion VIBBER) [18:44:35] check check check one two three [18:45:05] * James_F grins. [18:47:02] 10MediaWiki-Email, 10Anti-Harassment, 10Growth-Team, 10Notifications: Mute: Add links to the Tools menu on user pages to mute/unmute user - https://phabricator.wikimedia.org/T218270 (10Niharika) [18:49:13] 10Product-Analytics, 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10Neil_P._Quinn_WMF) [18:51:18] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Epic: [EPIC] Growth: Newcomer homepage - https://phabricator.wikimedia.org/T213990 (10Etonkovidova) [18:51:27] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: start module - https://phabricator.wikimedia.org/T217105 (10Etonkovidova) 05Open→03Resolved Re-checked the specs that were marked with the exclamation poin... [18:51:28] (03CR) 10Jforrester: [C: 03+2] Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [18:52:22] (03CR) 10Gergő Tisza: "TBH I don't think this kind of patch is a good use of either the author's or the reviewers' time. It doesn't really improve anything (it's" [core] - 10https://gerrit.wikimedia.org/r/507806 (owner: 10D3r1ck01) [18:52:23] brion: Also, ping re. https://gerrit.wikimedia.org/r/c/mediawiki/extensions/TimedMediaHandler/+/232214 and then maybe we can merge just after the cut on Tuesday? :-) [18:53:39] sounds good if no remaining objections after i commit the adjustments :D [18:53:49] * James_F grins. [18:54:00] That's what post-merge tyre-kicking in Beta Cluster is for. ;-) [18:54:06] worst case is we back it out yeah :D [18:54:17] that's why it's the smaller change first ;) [18:54:27] * James_F nods. [18:54:28] then soon we can start killing kaltura [18:55:20] 10Anti-Harassment: Allow user to mute notifications from Special:Mute page - https://phabricator.wikimedia.org/T220163 (10Niharika) [18:56:44] 10MediaWiki-API, 10Pywikibot, 10Wikidata, 10Patch-For-Review, and 3 others: Travis test fails for wikidata:wikidata site - https://phabricator.wikimedia.org/T221543 (10Xqt) 05Open→03Resolved a:03Xqt [18:56:46] (03CR) 10jerkins-bot: [V: 04-1] ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [18:56:52] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: drop shadow on start module should disappear when all complete - https://phabricator.wikimedia.org/T222123 (10Etonkovidova) Now... [18:59:08] (03PS5) 10Jdlrobson: ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) [19:00:30] (03PS6) 10Jdlrobson: ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) [19:01:54] (03PS3) 10Daimona Eaytoy: Fix other fixmes [tools/phan/SecurityCheckPlugin] (2.x) - 10https://gerrit.wikimedia.org/r/507854 [19:02:00] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [19:03:44] (03PS5) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase [core] - 10https://gerrit.wikimedia.org/r/506945 [19:04:00] (03CR) 10jerkins-bot: [V: 04-1] ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [19:04:04] (03CR) 10Jforrester: [C: 03+2] "Eurgh, flaking rollback test is still plaguing us?" [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [19:04:06] (03CR) 10Ladsgroup: Move ApiQueryUserInfo::getBlockInfo() to ApiBase (033 comments) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [19:08:40] 10MediaWiki-Email, 10Anti-Harassment, 10Growth-Team, 10Notifications: Mute: Add links to the Tools menu on user pages to mute/unmute user - https://phabricator.wikimedia.org/T218270 (10dbarratt) I think I prefer //Mute options// now that I think about it. :P [19:08:48] (03Merged) 10jenkins-bot: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [19:08:56] (03Merged) 10jenkins-bot: SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) (owner: 10Esanders) [19:12:31] (03CR) 10jenkins-bot: SearchInputWidget: Replace pushPending hack [core] - 10https://gerrit.wikimedia.org/r/507823 (https://phabricator.wikimedia.org/T222329) (owner: 10Esanders) [19:15:16] (03CR) 10jenkins-bot: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] - 10https://gerrit.wikimedia.org/r/507850 (https://phabricator.wikimedia.org/T222324) (owner: 10Jforrester) [19:16:14] 10Gadgets: HotCat loses categories doing multiple redirecting - https://phabricator.wikimedia.org/T222376 (10Aklapper) 05Open→03Invalid Hi @SJu, on-wiki content like gadgets are local features and managed independently on each wiki and not in Phabricator if there is no dedicated project tag for a specific ga... [19:16:21] 04(no projects): HotCat loses categories doing multiple redirecting - https://phabricator.wikimedia.org/T222376 (10Aklapper) [19:16:59] (03PS1) 10Jforrester: SearchInputWidget: Replace pushPending hack [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507863 (https://phabricator.wikimedia.org/T222329) [19:17:01] (03CR) 10Jforrester: [C: 03+2] SearchInputWidget: Replace pushPending hack [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507863 (https://phabricator.wikimedia.org/T222329) (owner: 10Jforrester) [19:19:50] 10MediaWiki-Database: Redesign querycache* tables - https://phabricator.wikimedia.org/T221449 (10Ladsgroup) >>! In T221449#5150357, @Anomie wrote: > It would be much better to use the table you proposed in {T222224} to replace `qc_namespace` and `qc_title` rather than trying to repurpose `qc_value`. > > With th... [19:22:46] (03Merged) 10jenkins-bot: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [19:23:26] 10GrowthExperiments-Help panel, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint): Homepage: recent questions asked in same minute are indistinguishable - https://phabricator.wikimedia.org/T222125 (10kostajh) a:03kostajh [19:27:34] (03Abandoned) 10D3r1ck01: installer: Avoid creating multiple RequestContext object instances [core] - 10https://gerrit.wikimedia.org/r/507806 (owner: 10D3r1ck01) [19:27:58] (03CR) 10Tjones: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [19:28:10] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Ladsgroup) - I'm convinced to use namespace. I can change the RFC to reflect the new schema. The only thing that bothers me is `title_title` column. Can we bikeshed a little for a better name? like `ti... [19:28:27] (03CR) 10jenkins-bot: SECURITY: LogPager: Don't STRAIGHT_JOIN when using log_search [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507851 (https://phabricator.wikimedia.org/T222324) (owner: 10SBassett) [19:28:38] (03CR) 10Tjones: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [19:29:50] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [19:29:59] (03CR) 10Sbisson: [C: 03+2] Proactively delete echo_event rows when they become orphaned [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505829 (https://phabricator.wikimedia.org/T221262) (owner: 10Catrope) [19:34:25] (03Merged) 10jenkins-bot: Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [19:34:50] (03CR) 10jerkins-bot: [V: 04-1] Cache QueryFixer [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507815 (owner: 10DCausse) [19:35:14] (03CR) 10Ppchelko: [C: 03+1] Add 1.0.0 versions of schemas using new draft-07 schema conventions [event-schemas] - 10https://gerrit.wikimedia.org/r/506158 (https://phabricator.wikimedia.org/T211248) (owner: 10Ottomata) [19:35:37] (03CR) 10Ottomata: "Ok, I've modified EventGate to support this" [event-schemas] - 10https://gerrit.wikimedia.org/r/506158 (https://phabricator.wikimedia.org/T211248) (owner: 10Ottomata) [19:35:45] (03CR) 10Ottomata: [C: 03+2] Add 1.0.0 versions of schemas using new draft-07 schema conventions [event-schemas] - 10https://gerrit.wikimedia.org/r/506158 (https://phabricator.wikimedia.org/T211248) (owner: 10Ottomata) [19:35:52] (03Merged) 10jenkins-bot: SearchInputWidget: Replace pushPending hack [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507863 (https://phabricator.wikimedia.org/T222329) (owner: 10Jforrester) [19:35:55] (03CR) 10jerkins-bot: [V: 04-1] Disable phrase suggest if something was handled by a prior method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/507816 (owner: 10DCausse) [19:37:44] 10RelatedArticles, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Remove "mediawiki.template.muhogan" from... - https://phabricator.wikimedia.org/T219846 [19:37:56] (03CR) 10jenkins-bot: Make generatePhpCharToUpperMappings.php a proper maintenance script [core] - 10https://gerrit.wikimedia.org/r/502800 (https://phabricator.wikimedia.org/T219279) (owner: 10Esanders) [19:38:14] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) [19:38:16] 10RelatedArticles, 10Audiences-QA (RW-Test-Cases), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Remove "mediawiki.template.muhogan" from... - https://phabricator.wikimedia.org/T219846 [19:38:36] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): [EPIC] Migrate MobileFrontend templates from hogan to inlined mustache templates - https://phabricator.wikimedia.org/T94086 (10pmiazga) [19:38:39] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar): Swap Hogan for Mustache - https://phabricator.wikimedia.org/T219845 (10pmiazga) 05Stalled→03Open [19:39:19] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10jcrespo) > How does it sound? Looks great. A couple of petitions: * Let's spend some extra time on the planning, as many iterations as we need so implementation is later as fast as possible * for WMF... [19:39:31] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar): Swap Hogan for Mustache - https://phabricator.wikimedia.org/T219845 (10pmiazga) {T219846} is now resolved. [19:39:40] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar): Swap Hogan for Mustache - https://phabricator.wikimedia.org/T219845 (10pmiazga) [19:41:57] 10MediaWiki-Search, 10Discovery-Search, 10OOUI, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Regression: Special:Search generates "TypeError: this.pushPending is not a function" - https://phabricator.wikimedia.org/T222329 (10Jdforrester-WMF) 05Open→03Resolved a:03Esanders Now deployed. [19:42:18] (03CR) 10Daniel Kinzler: "> Fatal error: Stack overflow in /workspace/src/includes/libs/services/ServiceContainer.php on line 414" [core] - 10https://gerrit.wikimedia.org/r/507579 (owner: 10simetrical) [19:43:24] (03CR) 10jenkins-bot: SearchInputWidget: Replace pushPending hack [core] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507863 (https://phabricator.wikimedia.org/T222329) (owner: 10Jforrester) [19:43:29] (03PS1) 10Tchanders: Remove call to deprecated User::isBlocked from test [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/507866 [19:44:17] 10International-Developer-Events, 10Wikimania-Hackathon-2019: Wikimania Hackathon Focus Area: Technical Equity for underserved communities - https://phabricator.wikimedia.org/T221394 (10Rfarrand) @srishakatux & @Bmueller: Hello, we will be opening general registration for wikimania sometime between May 13-15.... [19:44:43] (03CR) 10Daniel Kinzler: [C: 04-1] "The CR-1 is for the @todo in PermissionManager.php" [core] - 10https://gerrit.wikimedia.org/r/507551 (owner: 10simetrical) [19:45:51] (03Merged) 10jenkins-bot: Proactively delete echo_event rows when they become orphaned [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505829 (https://phabricator.wikimedia.org/T221262) (owner: 10Catrope) [19:46:34] (03CR) 10MaxSem: [C: 03+2] Don't mark pages as patrolled when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507721 (https://phabricator.wikimedia.org/T208685) (owner: 10MusikAnimal) [19:47:37] 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Kanban (Doing): Baseline implementation of Phester test runner - https://phabricator.wikimedia.org/T221088 (10daniel) [19:47:43] 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Ryasmeen) This hasn't been backported yet? [19:49:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking-Neverending: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Sascha) [19:50:06] (03CR) 10jenkins-bot: Proactively delete echo_event rows when they become orphaned [extensions/Echo] - 10https://gerrit.wikimedia.org/r/505829 (https://phabricator.wikimedia.org/T221262) (owner: 10Catrope) [19:52:16] 10Product-Analytics, 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [19:52:35] (03CR) 10Daimona Eaytoy: [C: 04-1] "The test can be worked around, but there's a call in the actual code. Hard to find with codesearch due to variable method, but that's it.." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/507866 (owner: 10Tchanders) [19:53:34] (03CR) 10Jdrewniak: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [19:55:42] (03PS1) 10Jforrester: [NEEDS REGENERATION] Call EditorGateway#setContent immediately when switching from VE [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) [19:57:00] (03CR) 10Jforrester: "Someone whose local environment is running node 6.11.0 will need to regenerate this, as I can't." [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [19:57:42] 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Jdforrester-WMF) [19:58:01] 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Jdforrester-WMF) p:05High→03Unbreak! [20:00:48] (03Merged) 10jenkins-bot: Don't mark pages as patrolled when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507721 (https://phabricator.wikimedia.org/T208685) (owner: 10MusikAnimal) [20:01:16] (03PS1) 10SBassett: Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) [20:04:40] (03CR) 10jenkins-bot: Don't mark pages as patrolled when tagging for deletion [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/507721 (https://phabricator.wikimedia.org/T208685) (owner: 10MusikAnimal) [20:04:45] 10Product-Analytics: What percentage of articles created by autoconfirmed users are deleted? What percentage by non-autoconfirmed? - https://phabricator.wikimedia.org/T166269 (10Milimetric) I didn't take much offense, no apologies necessary :) I was just making sure things are clear and all. And obviously I ve... [20:05:07] 10MobileFrontend, 10Readers-Web-Backlog (Tracking), 10Verified, 10VisualEditor (Current work): Non-latin URL fragments don't reliably get scrolled to - https://phabricator.wikimedia.org/T220513 (10Ryasmeen) This is now fixed! \o/ [20:05:11] (03CR) 10jerkins-bot: [V: 04-1] Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [20:06:27] (03CR) 10jerkins-bot: [V: 04-1] Add permission check for user is permitted to view the log type [core] - 10https://gerrit.wikimedia.org/r/507870 (https://phabricator.wikimedia.org/T222038) (owner: 10SBassett) [20:10:12] 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): Vanishing symbols in RC (of zhwiki, enwiki) - https://phabricator.wikimedia.org/T222394 (10DWYoungDLS) [20:15:57] (03CR) 10Jdrewniak: [C: 03+2] ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [20:26:34] 10Product-Analytics, 10VisualEditor (Current work): Define event logging needs within the existing adding/modifying links workflow - https://phabricator.wikimedia.org/T222395 (10ppelberg) [20:27:22] 10Product-Analytics, 10VisualEditor (Current work): Define event logging needs within the *existing* adding/modifying links workflow - https://phabricator.wikimedia.org/T222395 (10ppelberg) [20:28:38] 10Product-Analytics, 10VisualEditor (Current work): Define event logging needs within the *revised* adding/modifying links workflow - https://phabricator.wikimedia.org/T222396 (10ppelberg) [20:30:38] 10MobileFrontend, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10thcipriani) > Someone... [20:32:03] (03Merged) 10jenkins-bot: ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [20:34:42] 10Product-Analytics, 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) Today, @DLynch, @Neil_P._Quinn_WMF and I met to talk about instrumenting the //revised// and //existing// adding/modifying linking and citation flows. **Discussed**: - It's difficult t... [20:35:07] (03CR) 10jenkins-bot: ✅ Restore the user page test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506583 (https://phabricator.wikimedia.org/T221860) (owner: 10Jdlrobson) [20:35:19] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Integrate with References endpoint - https://phabricator.wikimedia.org/T221665 (10bearND) > Maybe I will create a PR on wikimedia-page-library of making a new method of getting references collection. Sounds like a good idea to me. We could... [20:35:53] (03PS2) 10Niedzielski: Call EditorGateway#setContent immediately when switching from VE [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [20:36:11] 10Wikimedia-Hackathon-2019: Advanced search syntax for newbies - https://phabricator.wikimedia.org/T216740 (10TJones) Currently scheduled for 14:00 on Friday at one of the hacking tables (TDB). [20:36:49] 10MobileFrontend, 10VisualEditor-MediaWiki-Mobile, 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (10Niedzielski) I've reb... [20:36:51] 10Product-Analytics, 10VisualEditor (Current work): Instrumentation - https://phabricator.wikimedia.org/T222367 (10ppelberg) [20:37:37] 10Product-Analytics: Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Neil_P._Quinn_WMF) [20:37:58] 10MediaWiki-Parser, 10MediaWiki-REST-API, 10Growth-Team, 10Parsoid-PHP, and 4 others: Parsoid REST API in PHP - https://phabricator.wikimedia.org/T221158 (10ssastry) [20:38:37] 10MediaWiki-Special-pages, 10Readers-Web-Backlog, 10IPv6, 10MobileFrontend (MobileFrontend Special Pages): On mobile, IPv6 user contributions do not show when lowercase - https://phabricator.wikimedia.org/T212698 (10Jdlrobson) [20:38:51] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): MFA: Add TopicTitleList component - https://phabricator.wikimedia.org/T173534 (10Jdlrobson) [20:39:26] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Remove cache from ImageGateway - https://phabricator.wikimedia.org/T220558 (10Jdlrobson) p:05Triage→03Normal [20:39:53] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Remove cache from ImageGateway - https://phabricator.wikimedia.org/T220558 (10Jdlrobson) An estimation would be good since there is a patchset for this issue. [20:39:55] Hi kostajh, quick question, do we want this to be possible? I mean, should a mentee be its own mentor? [20:40:08] 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10MobileFrontend (MobileFrontend and MinervaNeue architecture): Extract $skinOptions from SkinMinerva class - https://phabricator.wikimedia.org/T221012 (10Jdlrobson) [20:40:37] Urbanecm: only if you're able to mentor that mentee successfully [20:40:39] 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Hindi-Sites, and 2 others: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias - https://phabricator.wikimedia.org/T206497 (10Jdlrobson) [20:40:51] kostajh, I don't get that [20:41:03] 10MediaWiki-User-management, 10Anti-Harassment: Add a way to disable a users session and log them out when blocking - https://phabricator.wikimedia.org/T222281 (10dmaza) > i did say feature flag originally ;) You did, sorry I missed it :) [20:41:05] Urbanecm: just kidding. Yes, we should exclude mentor assignment to yourself [20:41:43] I think we all saw that in QA but didn't do anything about it as our focus was on new users who are not going to be on the mentors list [20:42:02] But we may as well fix it [20:42:10] 10CirrusSearch, 10Discovery-Search: Elastica\Exception\Connection\HttpException: Malformed URL - https://phabricator.wikimedia.org/T221547 (10debt) Cool! :) [20:42:16] (03PS2) 10Jdrewniak: Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) [20:42:22] (03PS2) 10Jdrewniak: Fix display of nested reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) [20:42:27] kostajh, I was thinking about experienced wikipedians trying the homepage out [20:42:31] 10MediaWiki-Parser, 10MediaWiki-REST-API, 10Growth-Team, 10Parsoid-PHP, and 4 others: Parsoid REST API in PHP - https://phabricator.wikimedia.org/T221158 (10ssastry) #StructuredDiscussions folks: note that since you don't talk with #RESTBase, you will need to update your code and config to use the new Pars... [20:42:37] (03CR) 10jerkins-bot: [V: 04-1] Fix display of nested reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [20:42:38] and exp. wikipedians can be on the list [20:42:50] yep [20:42:55] Urbanecm: I'll file a task [20:43:02] thanks kostajh [20:43:05] and I'll try to fix that [20:43:10] it's a good #easy task for me :) [20:44:08] 10MediaWiki-Parser, 10MediaWiki-REST-API, 10Growth-Team, 10Parsoid-PHP, and 3 others: Parsoid REST API routes in MediaWiki - https://phabricator.wikimedia.org/T221738 (10ssastry) [20:46:28] (03PS11) 10Jdlrobson: specials: Use MobileFrontend.Context service where need be [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/499577 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [20:48:00] (03CR) 10Pmiazga: Audit: Remove unnecessary browser tests (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) (owner: 10Jdlrobson) [20:49:40] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10GrowthExperiments-Homepage, 10good first bug: Users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10kostajh) [20:49:43] (03CR) 10Jdlrobson: [C: 04-1] "See Ps3 comments" [skins/MinervaNeue] (reset-cleanup) - 10https://gerrit.wikimedia.org/r/494414 (https://phabricator.wikimedia.org/T205341) (owner: 10VolkerE) [20:50:01] Urbanecm: cool, that would be great! [20:51:11] (03CR) 10Hoo man: [C: 03+2] Rename ID field label and placeholder [extensions/EntitySchema] - 10https://gerrit.wikimedia.org/r/507747 (https://phabricator.wikimedia.org/T221943) (owner: 10Noa wmde) [20:53:22] 10Wikimedia-Hackathon-2019: Advanced search syntax for newbies - https://phabricator.wikimedia.org/T216740 (10TJones) [20:54:22] 10Product-Analytics: Create an Oozie job to report completion of each month's mediawiki_history snapshot - https://phabricator.wikimedia.org/T188097 (10Neil_P._Quinn_WMF) [20:55:28] (03CR) 10Jdlrobson: [C: 03+2] Consistently mention the @license in all files [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/506185 (owner: 10Thiemo Kreuz (WMDE)) [20:55:30] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Aklapper) p:05Triage→03High [20:56:17] (03CR) 10Pmiazga: Audit: Remove unnecessary browser tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506591 (https://phabricator.wikimedia.org/T177260) (owner: 10Jdlrobson) [20:56:43] (03PS2) 10Tchanders: Remove call to deprecated User::isBlocked [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/507866 [20:56:45] (03CR) 10Jdlrobson: [C: 03+2] Extract unrelated static code from ExtractFormatter [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497489 (owner: 10Thiemo Kreuz (WMDE)) [20:57:32] 10ExternalGuidance, 10Product-Analytics: Figure out the topic of articles translated automatically by external translation service - https://phabricator.wikimedia.org/T219660 (10chelsyx) @Isaac Thanks for pointing out my mistake! I've updated my report and T219660#5139254 . Comparing with your analysis, my ta... [20:57:38] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10Aklapper) * Re T127640#2116945: "less intimidating than IRC" has become moot as we use Zulip for GSoC and Outreachy participants. * Re "messaging problematic us... [20:57:52] 10CirrusSearch, 10Discovery-Search (Current work), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Wikimedia-production-error: Job runner request timeouts in Elastica\Task - https://phabricator.wikimedia.org/T219234 (10debt) 05Open→03Resolved Nice! [20:59:54] 10CirrusSearch, 10Discovery-Search (Current work), 10Patch-For-Review: Elasticsearch 6: the classic similarity is deprecated - https://phabricator.wikimedia.org/T219268 (10debt) [20:59:57] 10CirrusSearch, 10Discovery-Search (Current work): Reindex space less languages wikis to use BM25 - https://phabricator.wikimedia.org/T219533 (10debt) 05Open→03Resolved [21:00:00] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Technical-Debt: [EPIC] Divide MobileFrontend component concerns - https://phabricator.wikimedia.org/T221022 (10Jdlrobson) p:05Triage→03Normal [21:00:03] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog: [EPIC] Monitor complex pages rendering time on mobile web - https://phabricator.wikimedia.org/T222163 (10Jdlrobson) p:05Triage→03Low [21:00:11] kostajh, okay, so here it is :) [21:00:21] 10Readers-Web-Backlog: Update various MediaWiki pages from "Reading web" to "Readers web" - https://phabricator.wikimedia.org/T222236 (10Jdlrobson) p:05Triage→03Low [21:00:23] two questions [21:00:36] (03Merged) 10jenkins-bot: Consistently mention the @license in all files [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/506185 (owner: 10Thiemo Kreuz (WMDE)) [21:00:56] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/507877 [21:00:59] (03CR) 10Ejegg: [C: 03+2] Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/507877 (owner: 10Ejegg) [21:01:02] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: widescreen homepage is stretched - https://phabricator.wikimedia.org/T222003 (10MMiller_WMF) This looks good in production on Czech Wikipedia. [21:01:10] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: BetaOptInPanel should use ES6 classes NOT mfExtend - https://phabricator.wikimedia.org/T220847 (10Jdlrobson) [21:01:16] 1) is there an simplier way to force Mentor::selectMentor to run for my user (after deleting the preference) than disable homepage, save preferenes, enable it again and save prefs again? [21:01:16] (03CR) 10Tchanders: Remove call to deprecated User::isBlocked (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/507866 (owner: 10Tchanders) [21:01:37] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: BetaOptInPanel should use ES6 classes NOT mfExtend - https://phabricator.wikimedia.org/T220847 (10Jdlrobson) p:05Triage→03High [21:01:38] 2) when selectMentor returns false, fatal is displayed. Is that desired? [21:01:41] kostajh, ^^ [21:01:50] 1) no, not currently [21:02:19] 2) sure, we should catch that. The assumption is that the mentors list is configured properly but it would be good to guard against it not being so [21:02:31] Urbanecm: could you reference the phab task, per https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines ? [21:02:39] (03CR) 10jenkins-bot: Consistently mention the @license in all files [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/506185 (owner: 10Thiemo Kreuz (WMDE)) [21:02:40] sure, but I don't know it's number :) [21:02:51] Urbanecm: T222400 [21:02:52] T222400: Users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 [21:02:56] thank you [21:03:33] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10GrowthExperiments-Homepage, 10Patch-For-Review, and 2 others: Users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10Urbanecm) a:03Urbanecm [21:03:41] kostajh, done [21:03:59] (03Merged) 10jenkins-bot: Extract unrelated static code from ExtractFormatter [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497489 (owner: 10Thiemo Kreuz (WMDE)) [21:04:14] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10kostajh) [21:04:30] 10Phabricator, 10Developer-Advocacy (Apr-Jun 2019): Re-evaluate our use of Phabricator Conpherence chat - https://phabricator.wikimedia.org/T127640 (10greg) >>! In T127640#5154388, @Aklapper wrote: > Looking at the list of active channels, the only both valid and active use case currently seems to be https://p... [21:05:08] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog, 10Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdlrobson) @Jdrewniak [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/... [21:05:10] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10MMiller_WMF) @ovasileva, @Cntlsn, @alexhollender, and I have a time to talk about whether we want to do this from a desig... [21:05:57] (03CR) 10jenkins-bot: Extract unrelated static code from ExtractFormatter [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/497489 (owner: 10Thiemo Kreuz (WMDE)) [21:06:05] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Mobile: Homepage: mobile version - https://phabricator.wikimedia.org/T215983 (10kostajh) > @JTannerWMF is going to schedule time with Growth engineers and @Jdlrobson to talk about technical guidance on... [21:06:29] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog, 10Regression: Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdlrobson) [21:06:34] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10Patch-For-Review: Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10MMiller_WMF) [21:06:42] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10MMiller_WMF) [21:06:46] btw, kostajh, does the "I want a mentor" checkbox from the Welcome Survey have to do anything with homepage mentor? [21:06:51] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10Patch-For-Review, and 2 others: Homepage: users on mentors list who use Special:Homepage should not be assigned themselves as mentors - https://phabricator.wikimedia.org/T222400 (10MMiller_WMF) [21:07:26] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar): Swap Hogan for Mustache - https://phabricator.wikimedia.org/T219845 (10Jdlrobson) [21:07:30] 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Switch Hogan for Mustache - https://phabricator.wikimedia.org/T220620 (10Jdlrobson) [21:08:55] 04(no projects): Bulk API undeletion results in database query error - https://phabricator.wikimedia.org/T222402 (10Amorymeltzer) [21:10:37] Urbanecm: not yet. Different experiment groups. But in the coming months we hope to start connecting the dots between welcome survey and what you see on the homepage [21:10:56] okay, thanks kostajh [21:11:02] now let's make jenkins happy with my patch... [21:11:49] (03CR) 10Daniel Kinzler: Move ApiQueryUserInfo::getBlockInfo() to ApiBase (031 comment) [core] - 10https://gerrit.wikimedia.org/r/506945 (owner: 10Ladsgroup) [21:13:19] 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: layout and UI details - https://phabricator.wikimedia.org/T218966 (10MMiller_WMF) [21:13:25] 10MediaWiki-extensions-GrowthExperiments, 10GrowthExperiments-Homepage, 10Growth-Team (Current Sprint), 10MW-1.34-notes (1.34.0-wmf.4; 2019-05-07), 10Patch-For-Review: Homepage: drop shadow on start module should disappear when all complete - https://phabricator.wikimedia.org/T222123 (10MMiller_WMF) 05O... [21:14:13] 10MediaWiki-API: Bulk API undeletion results in database query error - https://phabricator.wikimedia.org/T222402 (10Reedy) [21:14:47] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog, 10Regression: Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdrewniak) @Jdlrobson it could. We would just have to pull out t... [21:15:23] kostajh, btw, what does the dashes mean here: https://ctrlv.cz/mtgL? [21:15:26] it's the impact module btw [21:15:49] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/507877 (owner: 10Ejegg) [21:16:01] 10MediaWiki-API: Bulk API undeletion results in database query error - https://phabricator.wikimedia.org/T222402 (10Reedy) [21:18:49] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/507877 (owner: 10Ejegg) [21:18:57] 10MediaWiki-Database, 10TechCom-RFC: Normalizing *links tables - https://phabricator.wikimedia.org/T222224 (10Tgr) >>! In T222224#5152193, @jcrespo wrote: > +1 to add namespace to the "title" table. If we do that, how would namespace filters in things like Special:WhatLinksHere work? Wouldn't we end up having... [21:19:27] Urbanecm: it means we don't have pageviews data [21:19:44] Okay. Do you know why? [21:20:24] no. If stephanebisson is around, he might know [21:21:18] ok, thanks [21:25:35] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Wikimedia-production-error: CAS update failed on user_touched. The version of the user to be saved is older than the current version. - https://phabricator.wikimedia.org/T222195 (10kostajh) [21:28:16] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10daniel) >>! In T221177#5153831, @Anomie wrote: > The generic solution is, IMO, to point out that the static method poin... [21:28:25] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10tstarling) OK, let's use ObjectFactory. With ObjectFactory it doesn't really make sense to pass $config to the handler... [21:28:28] (03PS1) 10Isarra: Redo cat with only black and white and lose png version [skins/Timeless] - 10https://gerrit.wikimedia.org/r/507887 [21:28:46] kostajh, hmm, T222403 looks quite interesting [21:28:46] T222403: Same start and end date is converted to end=start - 1 day - https://phabricator.wikimedia.org/T222403 [21:28:52] unsure if it's the cause of the missing data [21:28:55] interesting to have a look at for sure [21:29:28] Urbanecm: gotta run now, but thanks for filing that. [21:29:33] yw [21:30:11] (03CR) 10Jdlrobson: [C: 03+1] HTMLForm: Improve method interface for collapsible forms (032 comments) [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [21:30:27] (03PS4) 10Jdlrobson: HTMLForm: Improve method interface for collapsible forms [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [21:33:33] (03PS5) 10Jdlrobson: HTMLForm: Improve method interface for collapsible forms [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [21:35:07] (03CR) 10Jforrester: [C: 03+2] Call EditorGateway#setContent immediately when switching from VE [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [21:35:10] (03CR) 10Jforrester: [C: 03+2] "Thanks." [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [21:37:35] 04(no projects): Tasks requiring Blazegraph reload - https://phabricator.wikimedia.org/T222404 (10Smalyshev) [21:37:55] 04(no projects): Tasks requiring Blazegraph reload - https://phabricator.wikimedia.org/T222404 (10Smalyshev) p:05Triage→03Normal [21:39:36] (03CR) 10Jdlrobson: [C: 03+1] "Feel free to +2 (including self merge) if my changes are okay!" [core] - 10https://gerrit.wikimedia.org/r/504221 (owner: 10Bartosz Dziewoński) [21:42:47] (03PS1) 10QChris: Add .gitreview [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/507889 [21:42:49] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [extensions/WebAuthn] - 10https://gerrit.wikimedia.org/r/507889 (owner: 10QChris) [21:45:30] 10Design, 10Community-Tech, 10Dark-Mode, 10Epic: Decide which elements need special handling in the Dark Mode css - https://phabricator.wikimedia.org/T222111 (10jmatazzoni) [21:49:05] (03PS1) 10QChris: Add .gitreview [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/507892 [21:49:07] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [extensions/UnblockMe] - 10https://gerrit.wikimedia.org/r/507892 (owner: 10QChris) [22:01:15] 10MediaWiki-Email, 10Anti-Harassment, 10Growth-Team, 10Notifications: Mute: Add links to the Tools menu on user pages to mute/unmute user - https://phabricator.wikimedia.org/T218270 (10Niharika) >>! In T218270#5154006, @dbarratt wrote: > I think I prefer //Mute options// now that I think about it. :P That... [22:01:18] 10MediaWiki-Email, 10Anti-Harassment, 10Growth-Team, 10Notifications: Mute: Add links to the Tools menu on user pages to mute/unmute user - https://phabricator.wikimedia.org/T218270 (10Niharika) [22:03:58] (03CR) 10Jforrester: [C: 03+2] docs/kss/package.json: Update Gerrit /r/p/ link to /r/ [core] - 10https://gerrit.wikimedia.org/r/507223 (https://phabricator.wikimedia.org/T218844) (owner: 10Zoranzoki21) [22:05:06] (03PS13) 10Aaron Schulz: Make DeferredUpdates enqueue jobs to finish failed updates [core] - 10https://gerrit.wikimedia.org/r/497537 (https://phabricator.wikimedia.org/T218456) [22:05:42] (03Merged) 10jenkins-bot: Call EditorGateway#setContent immediately when switching from VE [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [22:05:51] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Niharika) >>! In T218626#5148424, @Zoranzoki21 wrote: > Hi @Niharika, > I started RfC on srwiki related to this. Is this ready to be deployed there too after end of RfC? Yes, we can depl... [22:06:20] (03CR) 10Jforrester: "recheck" [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/506959 (owner: 10Fomafix) [22:07:58] (03CR) 10Daimona Eaytoy: "Thanks! I'll take a closer look tomorrow, but I think it's fine. I'd also like to determine whether this change could create problems like" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/507866 (owner: 10Tchanders) [22:08:00] 10MediaWiki-History-and-Diffs, 10UI-Standardization, 10Advanced Mobile Contributions, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), and 3 others: Convert HistoryAction.php to use OOUI and MW's new DateInputWidget - https://phabricator.wikimedia.org/T107069 (10Jdlrobson) @Volker_E is this done? If not, what i... [22:08:19] (03CR) 10Jforrester: [C: 03+2] Remove parameter 'options' from hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/507278 (owner: 10Fomafix) [22:08:22] (03CR) 10Jforrester: [C: 03+2] HTML escape parameter 'text' of hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/506958 (owner: 10Fomafix) [22:08:51] (03CR) 10jenkins-bot: Call EditorGateway#setContent immediately when switching from VE [extensions/MobileFrontend] (wmf/1.34.0-wmf.3) - 10https://gerrit.wikimedia.org/r/507869 (https://phabricator.wikimedia.org/T222229) (owner: 10Jforrester) [22:08:56] (03CR) 10jerkins-bot: [V: 04-1] Hook 'SkinEditSectionLinks' does now the HTML escaping [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/506959 (owner: 10Fomafix) [22:12:32] 10MediaWiki-Database, 10MediaWiki-Watchlist, 10MediaWiki-extensions-PageAssessments, 10Community-Tech, and 8 others: Wikimedia\Rdbms\LBFactory::getEmptyTransactionTicket: GeoData\Hooks::doLinksUpdate does not have outer scope - https://phabricator.wikimedia.org/T221577 (10Jdforrester-WMF) Is it worth back-... [22:12:52] (03PS11) 10Julia.glen: Method1 WIP [search/glent] - 10https://gerrit.wikimedia.org/r/507235 [22:14:13] 10MobileFrontend, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10User-Ryasmeen, 10VisualEditor (Current work): [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on so... - https://phabricator.wikimedia.org/T222229 [22:15:04] (03CR) 10Urbanecm: [C: 04-1] "Technically, works. However, if we decide to have a message like this, it should be faked and not actually included in *.json files. The s" [core] - 10https://gerrit.wikimedia.org/r/507328 (owner: 10Want) [22:17:23] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10MMiller_WMF) [22:17:47] 10MobileFrontend, 10VisualEditor-MediaWiki-Mobile, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10User-Ryasmeen, and 2 others: [Regression wmf.3] Cannot save edit after switching to the source editor from mobile VE if no other edits are made on source editor mode - https://phabricator.wikimedia.org/T222229 (... [22:18:32] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: null pageviews should not be a link - https://phabricator.wikimedia.org/T222405 (10MMiller_WMF) [22:25:41] 10MediaWiki-Watchlist, 10Growth-Team, 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30): After opening a diff, entry on Special:Watchlist sometimes stays unread (bold) - https://phabricator.wikimedia.org/T218511 (10Dvorapa) Before sometimes some links stayed bold. Now also some links in my watchlist are unseen, but... [22:28:37] (03CR) 10jerkins-bot: [V: 04-1] docs/kss/package.json: Update Gerrit /r/p/ link to /r/ [core] - 10https://gerrit.wikimedia.org/r/507223 (https://phabricator.wikimedia.org/T218844) (owner: 10Zoranzoki21) [22:32:55] (03CR) 10jerkins-bot: [V: 04-1] HTML escape parameter 'text' of hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/506958 (owner: 10Fomafix) [22:32:57] (03CR) 10jerkins-bot: [V: 04-1] Remove parameter 'options' from hook 'SkinEditSectionLinks' [core] - 10https://gerrit.wikimedia.org/r/507278 (owner: 10Fomafix) [22:34:19] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) >>! In T221177#5152457, @TheDJ wrote: > Not just for that, groups can also have middleware for instance prefix(/ad... [22:38:26] (03PS13) 10Jeena Huneidi: sshfs: add a script for generating and install ssh keys [releng/local-charts] - 10https://gerrit.wikimedia.org/r/497013 (https://phabricator.wikimedia.org/T218364) (owner: 10Brennen Bearnes) [22:47:15] 10Product-Analytics: Add a moderation health metric to our board metrics - https://phabricator.wikimedia.org/T194902 (10Neil_P._Quinn_WMF) [22:49:17] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Tracking-Neverending: CX2: Support for References - https://phabricator.wikimedia.org/T200786 (10Etonkovidova) [22:49:20] 10ContentTranslation, 10Language-Team (Language-2019-April-June): References list is checked for MT abuse - https://phabricator.wikimedia.org/T219468 (10Etonkovidova) 05Open→03Resolved [22:49:25] (03PS14) 10Jeena Huneidi: sshfs: add a script for generating and install ssh keys [releng/local-charts] - 10https://gerrit.wikimedia.org/r/497013 (https://phabricator.wikimedia.org/T218364) (owner: 10Brennen Bearnes) [22:56:02] 10Product-Analytics: Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Neil_P._Quinn_WMF) Okay, I've discussed this with @kzimmerman and we agree it make sense to work on this. However, I'm going to timebox thi... [22:56:34] 10Product-Analytics: Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Neil_P._Quinn_WMF) a:03Neil_P._Quinn_WMF [22:56:44] 10Product-Analytics: Please tell me how many edits/contributions a typical (current) active user has made, across all projects - https://phabricator.wikimedia.org/T222379 (10Neil_P._Quinn_WMF) [22:57:19] (03PS15) 10Jeena Huneidi: sshfs: add a script for generating and install ssh keys [releng/local-charts] - 10https://gerrit.wikimedia.org/r/497013 (https://phabricator.wikimedia.org/T218364) (owner: 10Brennen Bearnes) [23:00:18] (03CR) 10Jforrester: [C: 03+2] "…" [core] - 10https://gerrit.wikimedia.org/r/507223 (https://phabricator.wikimedia.org/T218844) (owner: 10Zoranzoki21) [23:00:27] (03PS7) 10Aaron Schulz: Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) [23:02:27] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Zoranzoki21) >>! In T218626#5154560, @Niharika wrote: >>>! In T218626#5148424, @Zoranzoki21 wrote: >> Hi @Niharika, >> I started RfC on srwiki related to this. Is this ready to be deploye... [23:04:10] (03PS23) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:04:50] (03CR) 10Aaron Schulz: "Heh, 1d2c770a9e0a427085e52e7e535eadc032ee1faf already did the JS aspect for different reasons." [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [23:06:59] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Dictionary only intermittently works - https://phabricator.wikimedia.org/T221464 (10ABorbaWMF) Looks good to me on 2.7.280-beta-2019-05-01 The vast majority of the words I tested had definitions. I found a few words th... [23:07:56] 10Wikimedia-production-error: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (10Jdlrobson) [23:08:39] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression, 10Wikimedia-production-error: [1.34.0-wmf.3] Regression: Definitions.php: Call to a member function exists() on a non-object (null) - https://phabricator.wikimedia.org/T222407 (10Jdlrobson) p:05Triage→03High... [23:11:16] 10Android-app-feature-Navigation, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): Improve TOC - https://phabricator.wikimedia.org/T213133 (10cooltey) a:03cooltey Hi @schoenbaechler If we remove the ToC scroller, should we also remove the ToC onboardin... [23:13:41] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdlrobson) [23:13:44] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdlrobson) Gi... [23:13:57] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdlrobson) [23:13:59] 10MediaWiki-Recent-changes, 10Growth-Team, 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4), 10Regression: [subtask] Regression: In the mobile version of Special:RecentChanges, "(diff | hist)" is shown as "diffhist" - https://phabricator.wikimedia.org/T222394 (10Jdlrobson) [23:14:01] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.28x-M-Mochi): "Next" button cut off when editing - https://phabricator.wikimedia.org/T219692 (10ABorbaWMF) Looks good to me on 2.7.280-beta-2019-05-01 I tested the larger and largest sizes and the next button is present. [23:14:38] 10Advanced Mobile Contributions, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q4): Style the history page for AMC users - https://phabricator.wikimedia.org/T219895 (10Jdlrobson) [23:15:17] (03PS3) 10Jdlrobson: Fix display of nested reference drawers [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [23:19:58] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [23:22:22] 10ContentTranslation: [wmf.3 - regression] Un-translated Reference section still counted as unmodified text if unmodified text warning was triggered - https://phabricator.wikimedia.org/T222408 (10Etonkovidova) [23:23:07] 10ContentTranslation: [wmf.3 - regression] Un-translated Reference section still counted as unmodified text if unmodified text warning was triggered - https://phabricator.wikimedia.org/T222408 (10Etonkovidova) [23:25:04] (03PS24) 10Vedmaka Wakalaka: Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) [23:25:15] (03Merged) 10jenkins-bot: docs/kss/package.json: Update Gerrit /r/p/ link to /r/ [core] - 10https://gerrit.wikimedia.org/r/507223 (https://phabricator.wikimedia.org/T218844) (owner: 10Zoranzoki21) [23:28:13] (03CR) 10jenkins-bot: docs/kss/package.json: Update Gerrit /r/p/ link to /r/ [core] - 10https://gerrit.wikimedia.org/r/507223 (https://phabricator.wikimedia.org/T218844) (owner: 10Zoranzoki21) [23:28:43] (03CR) 10Vedmaka Wakalaka: "> Patch Set 29:" [core] - 10https://gerrit.wikimedia.org/r/495832 (https://phabricator.wikimedia.org/T208768) (owner: 10Vedmaka Wakalaka) [23:34:08] (03PS3) 10Luca Mauri: Modify "importSites.php" to import "LanguageCode" as well [core] - 10https://gerrit.wikimedia.org/r/507821 (https://phabricator.wikimedia.org/T221149) [23:34:41] (03CR) 10Jdlrobson: [C: 03+2] Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [23:34:56] (03CR) 10Jdlrobson: [C: 03+2] Fix display of nested reference drawers (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/506424 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [23:35:25] 10MediaWiki-General-or-Unknown, 10ObjectFactory: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Tgr) [23:36:53] 10MediaWiki-REST-API, 10Core Platform Team (Parsoid REST API in PHP (CDP2)), 10Core Platform Team Kanban (Doing): Route Handler Interface RFC - https://phabricator.wikimedia.org/T221177 (10Tgr) >>! In T221177#5154635, @Tgr wrote: > I want to standardize how object creation is specified in static declaration... [23:40:06] 10MediaWiki-General-or-Unknown, 10ObjectFactory: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Tgr) [23:40:07] (03CR) 10jerkins-bot: [V: 04-1] Factors out permissions check from User into PermissionManager service [core] - 10https://gerrit.wikimedia.org/r/502484 (https://phabricator.wikimedia.org/T218558) (owner: 10Vedmaka Wakalaka) [23:42:02] 10Design, 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2: Show translation issues - https://phabricator.wikimedia.org/T189488 (10Etonkovidova) [23:42:05] 10ContentTranslation, 10Language-Team (Language-2019-April-June): CX2: Communicate that publishing is only allowed to experienced editors - https://phabricator.wikimedia.org/T192144 (10Etonkovidova) 05Open→03Resolved The limitation on publishing in `enwiki` is applied only to article namespace. Since it's... [23:50:30] 10MediaWiki-General-or-Unknown, 10ObjectFactory: Standardize declarative object construction in MediaWiki - https://phabricator.wikimedia.org/T222409 (10Tgr) See also: {T222410} [23:53:30] 10MediaWiki-General-or-Unknown, 10Performance: Make action=credits faster - https://phabricator.wikimedia.org/T49722 (10ToBeFree) [23:56:10] 10MediaWiki-General-or-Unknown, 10Performance: Make action=credits faster - https://phabricator.wikimedia.org/T49722 (10ToBeFree) [23:56:12] 10MediaWiki-General-or-Unknown, 10Performance: Cache action=credits results - https://phabricator.wikimedia.org/T49723 (10ToBeFree) [23:56:53] 10MediaWiki-General-or-Unknown, 10Performance: Make action=credits faster - https://phabricator.wikimedia.org/T49722 (10ToBeFree) [23:57:48] (03CR) 10jerkins-bot: [V: 04-1] Adds a light-blue variant to the external link icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/506425 (https://phabricator.wikimedia.org/T216961) (owner: 10Jdrewniak) [23:58:47] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10MW-1.34-notes (1.34.0-wmf.3; 2019-04-30), 10WorkType-NewFunctionality: CX2: Show publish settings as a dialog with more detailed descriptions - https://phabricator.wikimedia.org/T197701 (10Etonkovidova) The radio buttons look different in...