[00:00:12] (03CR) 10Catrope: "Follow-up patch that should work: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/503538" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/499582 (https://phabricator.wikimedia.org/T219444) (owner: 10Jforrester) [00:00:38] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Regression testing for Edit Action Feed release - https://phabricator.wikimedia.org/T217858 (10ABorbaWMF) Looks good to us on 2.7.278-beta-2019-04-05 https://docs.google.com/spreadsheets/d/12u8T3HgaUX2nMVtYsSohM_nJNJIhX0mE5YdYrnBmLXs/ed... [00:03:33] (03Merged) 10jenkins-bot: Revert "Restore #mw-history-search id on history action fieldset" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503528 (owner: 10Jforrester) [00:03:56] (03CR) 10Krinkle: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:04:14] (03Merged) 10jenkins-bot: Revert "HistoryAction: Fix double-escaping" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503529 (owner: 10Jforrester) [00:04:20] (03Merged) 10jenkins-bot: Revert "Make HistoryAction form use OOUI" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503530 (owner: 10Jforrester) [00:04:27] (03Merged) 10jenkins-bot: Remove bogus field references in DerivedPageDataUpdater [core] - 10https://gerrit.wikimedia.org/r/503534 (owner: 10Aaron Schulz) [00:06:33] (03CR) 10jenkins-bot: parser: Fix return type for methods and match phpdoc comments [core] - 10https://gerrit.wikimedia.org/r/498870 (owner: 10D3r1ck01) [00:06:47] (03CR) 10jerkins-bot: [V: 04-1] Disable web notifications for login-success [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/503465 (https://phabricator.wikimedia.org/T220780) (owner: 10Catrope) [00:09:25] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Support for early community input on proposed mobile interventions - https://phabricator.wikimedia.org/T206549 (10ppelberg) >>! In T206549#5106055, @Whatamidoing-WMF wrote: > I think we're creating a new set of asks for the Toolbar Im... [00:10:45] (03CR) 10jenkins-bot: Revert "Restore #mw-history-search id on history action fieldset" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503528 (owner: 10Jforrester) [00:15:01] 10ContentTranslation: Google Translate adds extra spaces for templates - https://phabricator.wikimedia.org/T220864 (10Etonkovidova) [00:15:20] (03Merged) 10jenkins-bot: build: Add 'npm rum doc' command to unbreak repo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/503515 (owner: 10Jforrester) [00:15:39] 10CX-cxserver, 10Language-Team (Language-2019-April-June): MT error while translating the big reflist section - https://phabricator.wikimedia.org/T208386 (10Etonkovidova) 05Open→03Resolved [00:17:00] (03CR) 10jenkins-bot: build: Add 'npm rum doc' command to unbreak repo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/503515 (owner: 10Jforrester) [00:19:26] (03CR) 10Krinkle: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:19:28] (03CR) 10Krinkle: [C: 03+1] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:21:06] (03PS2) 10Aaron Schulz: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) [00:21:28] (03CR) 10jenkins-bot: Revert "HistoryAction: Fix double-escaping" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503529 (owner: 10Jforrester) [00:22:34] (03PS8) 10Krinkle: Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:22:37] (03CR) 10Krinkle: [C: 03+2] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:22:45] (03CR) 10jerkins-bot: [V: 04-1] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:22:47] (03CR) 10jerkins-bot: [V: 04-1] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:22:50] (03CR) 10jerkins-bot: [V: 04-1] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:22:52] (03CR) 10jerkins-bot: [V: 04-1] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [00:23:26] (03PS1) 10Krinkle: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/503540 (https://phabricator.wikimedia.org/T220854) [00:23:32] (03CR) 10Krinkle: [C: 03+2] Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/503540 (https://phabricator.wikimedia.org/T220854) (owner: 10Krinkle) [00:24:22] (03CR) 10jenkins-bot: Remove bogus field references in DerivedPageDataUpdater [core] - 10https://gerrit.wikimedia.org/r/503534 (owner: 10Aaron Schulz) [00:27:39] 10MediaWiki-Parser, 10Performance-Team: "Preview mode" parser output gets re-used for page views (affects addWarning and REVISIONID processing) - https://phabricator.wikimedia.org/T220854 (10Krinkle) 05Open→03Resolved p:05High→03Unbreak! a:03aaron [00:27:44] (03CR) 10jenkins-bot: Revert "Make HistoryAction form use OOUI" [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503530 (owner: 10Jforrester) [00:27:46] (03CR) 10Krinkle: [C: 03+2] "Confirmed on mwdebug1002." [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:34:08] (03Merged) 10jenkins-bot: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/503540 (https://phabricator.wikimedia.org/T220854) (owner: 10Krinkle) [00:39:53] (03CR) 10jenkins-bot: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] (wmf/1.33.0-wmf.25) - 10https://gerrit.wikimedia.org/r/503540 (https://phabricator.wikimedia.org/T220854) (owner: 10Krinkle) [00:43:31] (03Merged) 10jenkins-bot: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:46:38] (03CR) 10jenkins-bot: Add vary-revision-exist flag to handle {{REVISIONID}} and parser cache [core] - 10https://gerrit.wikimedia.org/r/503537 (https://phabricator.wikimedia.org/T220854) (owner: 10Aaron Schulz) [00:48:54] (03PS1) 10Catrope: Add maintenance script to recompute notification counts [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503541 (https://phabricator.wikimedia.org/T220762) [00:50:56] (03CR) 10Catrope: "recheck" [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/503465 (https://phabricator.wikimedia.org/T220780) (owner: 10Catrope) [00:59:37] (03CR) 10Dbarratt: Rename BlockRestriction -> BlockRestrictionStore and wire it up as a service (035 comments) [core] - 10https://gerrit.wikimedia.org/r/503098 (https://phabricator.wikimedia.org/T219684) (owner: 10Dmaza) [01:00:14] (03PS2) 10Catrope: AttributeManager: Check notify type availability before notifying [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503519 [01:12:01] 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Homepage: "Your Recent Questions" - https://phabricator.wikimedia.org/T218841 (10MMiller_WMF) [01:12:20] 10MediaWiki-extensions-GrowthExperiments, 10Wikimedia-Hackathon-2019, 10Growth-Team (Current Sprint): Homepage: "Your Recent Questions" - https://phabricator.wikimedia.org/T218841 (10MMiller_WMF) I just updated the link in the description to more modern mockups showing the feature. [01:20:05] (03CR) 10Dbarratt: "It looks really good so far! I'm excited!" (0316 comments) [core] - 10https://gerrit.wikimedia.org/r/502820 (https://phabricator.wikimedia.org/T219441) (owner: 10Tchanders) [01:21:19] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10ppelberg) Goodness @deryckchan – I'm sorry for the multi-month delay! This conversation re-emerging now – by way of @Whatamidoing-WMF... [01:21:50] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10ppelberg) a:05Whatamidoing-WMF→03ppelberg [01:23:54] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: Remove `hasLoadError` instance variable/logic from Overlay/OverlayManager - https://phabricator.wikimedia.org/T220869 (10nray) [01:26:35] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10ppelberg) 05Resolved→03Open [01:26:43] (03PS1) 10Nray: Remove hasLoadError logic from Overlay/OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503545 (https://phabricator.wikimedia.org/T220869) [01:27:59] 10I18n: [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail" - https://phabricator.wikimedia.org/T220870 (10Shirayuki) [01:39:27] (03PS4) 10MaxSem: Hard deprecate Password::equals() [core] - 10https://gerrit.wikimedia.org/r/497098 [01:40:16] 10Quibble, 10Patch-For-Review: Run Parsoid service in quibble - https://phabricator.wikimedia.org/T218534 (10Krinkle) [01:42:59] (03PS2) 10Nray: Remove hasLoadError logic from Overlay/OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503545 (https://phabricator.wikimedia.org/T220869) [01:44:11] (03PS3) 10Nray: Remove `hasLoadError` instance variable/logic from Overlay/OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503545 (https://phabricator.wikimedia.org/T220869) [01:44:47] 10I18n: [[MediaWiki:Log-action-filter-newusers-byemail/en]] contains "e-mail" instead of "email" - https://phabricator.wikimedia.org/T220871 (10Shirayuki) [01:46:15] (03PS2) 10Nray: Remove `hideOnExitClick` from Overlay.js prototype [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503531 (https://phabricator.wikimedia.org/T220863) [01:46:17] (03PS2) 10Nray: Remove `Overlay.EVENT_EXIT` from Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503535 (https://phabricator.wikimedia.org/T220865) [01:46:19] (03PS4) 10Nray: Remove `hasLoadError` instance variable/logic from Overlay/OverlayManager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503545 (https://phabricator.wikimedia.org/T220869) [01:46:20] 10MediaWiki-Internationalization, 10I18n: [[MediaWiki:Log-action-filter-newusers-byemail/en]] contains "e-mail" instead of "email" - https://phabricator.wikimedia.org/T220871 (10Reedy) [01:46:51] 10MediaWiki-extensions-Other, 10I18n: [[MediaWiki:Editaccount-usage/en]] etc. contain "e-mail" instead of "email" - https://phabricator.wikimedia.org/T220870 (10Shirayuki) [01:46:57] 10MediaWiki-extensions-Other, 10I18n: [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail" - https://phabricator.wikimedia.org/T220870 (10Reedy) [01:49:29] 10MediaWiki-Maintenance-scripts: update.php leaves unopenable UIDGenerator lock file - https://phabricator.wikimedia.org/T55791 (10Jidanni) Suddenly on my wiki after the latest upgrade: This is left sitting around after running update.php: /tmp/mw-UIDGenerator-UID-nodeid And this is left sitting around each da... [01:59:06] (03CR) 10MaxSem: [C: 03+2] Disable web notifications for login-success [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/503465 (https://phabricator.wikimedia.org/T220780) (owner: 10Catrope) [01:59:37] (03CR) 10jerkins-bot: [V: 04-1] Remove `Overlay.EVENT_EXIT` from Overlay.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503535 (https://phabricator.wikimedia.org/T220865) (owner: 10Nray) [02:03:35] (03CR) 10Gergő Tisza: "> We could also more simply have this script generate composer.json" [vendor] - 10https://gerrit.wikimedia.org/r/503148 (https://phabricator.wikimedia.org/T220720) (owner: 10Gergő Tisza) [02:07:37] (03Merged) 10jenkins-bot: Disable web notifications for login-success [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/503465 (https://phabricator.wikimedia.org/T220780) (owner: 10Catrope) [02:10:03] (03CR) 10jenkins-bot: Disable web notifications for login-success [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/503465 (https://phabricator.wikimedia.org/T220780) (owner: 10Catrope) [02:17:51] 10MediaWiki-extensions-Other, 10I18n: [[MediaWiki:Right-delete-usersubpages/en]] should not start with "Can" - https://phabricator.wikimedia.org/T220285 (10Shirayuki) [02:20:58] (03PS1) 10DannyS712: Change "e-mail" to "email" in Log-action-filter-newusers-byemail/en [core] - 10https://gerrit.wikimedia.org/r/503547 (https://phabricator.wikimedia.org/T220871) [02:21:38] 10MediaWiki-Internationalization, 10I18n, 10Patch-For-Review, 10User-DannyS712: [[MediaWiki:Log-action-filter-newusers-byemail/en]] contains "e-mail" instead of "email" - https://phabricator.wikimedia.org/T220871 (10DannyS712) a:03DannyS712 [02:22:52] (03PS2) 10DannyS712: Change "e-mail" to "email" in Log-action-filter-newusers-byemail/en [core] - 10https://gerrit.wikimedia.org/r/503547 (https://phabricator.wikimedia.org/T220871) [02:23:15] 10MediaWiki-File-management, 10Commons, 10Multimedia: After nominating a file on Wikipedia for deletion, the page sections show a duplicate of themselves - https://phabricator.wikimedia.org/T220825 (10Tgr) The Commons templates on the other hand are not shown, so it seems as if the local description page was... [02:42:02] (03CR) 10MaxSem: [C: 03+2] "It's not a regression, core has changed some time ago, breaking a bunch of extensions in the same way as this one." [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503517 (owner: 10Jforrester) [03:16:37] 10BlueSpice, 10I18n, 10good first bug: [[MediaWiki:Right-dashboards-viewspecialpage-userdashboard/en]] consistency issue - https://phabricator.wikimedia.org/T220286 (10Shirayuki) [03:28:50] (03PS1) 10Isarra: Use newfangled permissionmanager stuff and more consistently check for appropriate permissions on collaborationhubs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/503548 (https://phabricator.wikimedia.org/T159016) [03:32:56] (03CR) 10jerkins-bot: [V: 04-1] Use newfangled permissionmanager stuff and more consistently check for appropriate permissions on collaborationhubs [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/503548 (https://phabricator.wikimedia.org/T159016) (owner: 10Isarra) [03:33:08] (03PS1) 10Aaron Schulz: Improve comments of outputVariesOnRevisionMetaData() [core] - 10https://gerrit.wikimedia.org/r/503549 [03:33:19] (03PS3) 10Isarra: Add messages for editing list items so it doesn't just reuse the add item ones [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/503523 (https://phabricator.wikimedia.org/T167939) [03:35:16] (03CR) 10Isarra: "Note: i18n is screwed up a bit more than just what jenkins is reporting (missing comma); also accidentally merged two patches together in " [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/503548 (https://phabricator.wikimedia.org/T159016) (owner: 10Isarra) [03:37:59] 10MediaWiki-extensions-CollaborationKit: CollaborationHubContent: Don't show manage hub, add feature buttons if users lack the edit right - https://phabricator.wikimedia.org/T159017 (10Isarra) This is a caching problem. We need to separate the caching for these... cases. [03:41:07] (03PS3) 10MaxSem: Get rid of *Obj() functions [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/499712 [03:50:05] (03PS1) 10Krinkle: title: Allow passing MessageLocalizer to newMainPage() [core] - 10https://gerrit.wikimedia.org/r/503550 [04:03:03] (03CR) 10Krinkle: [C: 03+2] Improve comments of outputVariesOnRevisionMetaData() [core] - 10https://gerrit.wikimedia.org/r/503549 (owner: 10Aaron Schulz) [04:04:32] (03CR) 10Krinkle: Get rid of *Obj() functions (031 comment) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/499712 (owner: 10MaxSem) [04:18:38] (03Merged) 10jenkins-bot: Improve comments of outputVariesOnRevisionMetaData() [core] - 10https://gerrit.wikimedia.org/r/503549 (owner: 10Aaron Schulz) [04:20:18] 10MediaWiki-Special-pages: Bulgarian Wikinews shows 66 content pages on Special:Statistics though there are more pages - https://phabricator.wikimedia.org/T220299 (10Ammarpad) 05Open→03Invalid Thank you too. [04:21:35] (03CR) 10jenkins-bot: Improve comments of outputVariesOnRevisionMetaData() [core] - 10https://gerrit.wikimedia.org/r/503549 (owner: 10Aaron Schulz) [04:35:28] (03PS4) 10MaxSem: Get rid of *Obj() functions [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/499712 [04:35:32] (03PS1) 10MaxSem: Make everything that doesn't need to be public private [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503552 [04:37:35] 10MinervaNeue, 10Readers-Web-Backlog (Design): It should be possible to view source on protected pages in Minerva - https://phabricator.wikimedia.org/T208827 (10Ammarpad) Have known this issue for a while. The workaround is to click and hold the lock icon until menu appears. Then choose to open the page in a n... [04:40:34] (03CR) 10MaxSem: Get rid of *Obj() functions (031 comment) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/499712 (owner: 10MaxSem) [04:41:09] (03PS1) 10Aaron Schulz: Fix edit stashing "outside edit" check for private IPs [core] - 10https://gerrit.wikimedia.org/r/503553 [04:41:12] Krenair: ^ [04:41:22] *Krinkle [04:49:00] (03CR) 10Aaron Schulz: Add UserOptionsUpdateJob class and use it for namespaces at SpecialSearch (031 comment) [core] - 10https://gerrit.wikimedia.org/r/499985 (https://phabricator.wikimedia.org/T92357) (owner: 10Aaron Schulz) [04:52:42] (03CR) 10jerkins-bot: [V: 04-1] Fix edit stashing "outside edit" check for private IPs [core] - 10https://gerrit.wikimedia.org/r/503553 (owner: 10Aaron Schulz) [04:55:34] 10Wikimedia-General-or-Unknown: Bulgarian Wikinews shows 66 content pages on Special:Statistics though there are more pages - https://phabricator.wikimedia.org/T220299 (10Peachey88) [05:00:41] (03CR) 10jerkins-bot: [V: 04-1] Make everything that doesn't need to be public private [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503552 (owner: 10MaxSem) [05:04:32] (03PS2) 10Aaron Schulz: Fix edit stashing "outside edit" check for private IPs [core] - 10https://gerrit.wikimedia.org/r/503553 [05:26:21] (03PS2) 10MaxSem: ParserFunctions class: make everything that doesn't need to be public private [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503552 [05:26:23] (03PS1) 10MaxSem: ParserFunctions class: tweak function declarations [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503554 [05:26:27] (03PS1) 10MaxSem: Remove function existence check [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503555 [05:34:55] 10MediaWiki-extensions-Other, 10I18n, 10User-DannyS712: [[MediaWiki:Editaccount-usage/en]] etc. use "email" instead of "e-mail" - https://phabricator.wikimedia.org/T220870 (10DannyS712) a:03DannyS712 [05:36:26] (03PS1) 10DannyS712: Changa "e-mail" to "email" in messages [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/503556 (https://phabricator.wikimedia.org/T220870) [05:43:23] (03PS2) 10DannyS712: Changa "e-mail" to "email" in messages [extensions/EditAccount] - 10https://gerrit.wikimedia.org/r/503556 (https://phabricator.wikimedia.org/T220870) [06:18:08] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Build statistics toolset to support WM-HU editor retention grant - https://phabricator.wikimedia.org/T220714 (10Hsync7) [06:22:30] (03PS1) 10DannyS712: Replace "Wikipedia" with "{{int:Sitetitle}}" in [[MediaWiki:Mobile-frontend-nearby-info-description]] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503557 (https://phabricator.wikimedia.org/T219721) [06:24:09] (03PS2) 10DannyS712: Replace "Wikipedia" with "{{int:Sitetitle}}" in [[MediaWiki:Mobile-frontend-nearby-info-description]] [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503557 (https://phabricator.wikimedia.org/T219721) [06:32:27] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Build statistics toolset to support WM-HU editor retention grant - https://phabricator.wikimedia.org/T220714 (10Hsync7) [06:53:49] 10Hashtags: Review and improve project test coverage - https://phabricator.wikimedia.org/T216614 (10ParthS007) @Samwalton9 I have updated the [Pull Request](https://github.com/Samwalton9/hashtags/pull/21). Codecov is showing coverage now. Please review 😃 Thanks [06:59:26] 10Internet-Archive, 10InternetArchiveBot: Thai bangkaew dog svwp - https://phabricator.wikimedia.org/T220872 (10Ascilto) [07:00:03] 10Internet-Archive, 10InternetArchiveBot: Thai bangkaew dog svwp - https://phabricator.wikimedia.org/T220873 (10Ascilto) [07:01:04] 10Internet-Archive, 10InternetArchiveBot: Thai bangkaew dog svwp - https://phabricator.wikimedia.org/T220873 (10Ascilto) The link https://web.archive.org/web/20081121002424/http://www.tbdca.org/BreedHistory.htm does not qo to the required page. Don't replace the dead link in the article with this link again. [07:13:30] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Umherirrender) >>! In T220779#5108357, @Jdforrester-WMF wrote: >> Structure tests should be enable after fixing the extensions and not produce som... [07:15:31] (03CR) 10Umherirrender: "Yes, but hhvm works, I have no idea which dependency is missing for php7" [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/503287 (owner: 10Umherirrender) [07:26:35] (03PS9) 10Gilles: Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) [07:28:42] (03PS10) 10Gilles: Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) [07:42:22] 10ContentTranslation, 10Language-Team (Language-2019-April-June), 10Patch-For-Review: CX2: Improve the approach used for adding translations to the "unreviewed content" tracking category - https://phabricator.wikimedia.org/T217653 (10Petar.petkovic) a:03Petar.petkovic [08:07:40] (03CR) 10MaxSem: [C: 04-1] "No need to support older MW." [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502971 (owner: 10simetrical) [08:08:23] (03CR) 10MaxSem: [C: 04-1] "No need to support older MW." [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/502987 (owner: 10simetrical) [08:13:03] (03CR) 10Aaron Schulz: [C: 03+2] Third argument to unpack() requires PHP 7.1 [core] - 10https://gerrit.wikimedia.org/r/502779 (owner: 10simetrical) [08:19:00] (03PS55) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [08:19:09] (03PS67) 10Daimona Eaytoy: Add tests for global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) [08:20:27] (03PS17) 10Daimona Eaytoy: Don't run filters with null title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) [08:24:46] (03Merged) 10jenkins-bot: Third argument to unpack() requires PHP 7.1 [core] - 10https://gerrit.wikimedia.org/r/502779 (owner: 10simetrical) [08:30:13] (03CR) 10jenkins-bot: Third argument to unpack() requires PHP 7.1 [core] - 10https://gerrit.wikimedia.org/r/502779 (owner: 10simetrical) [08:34:37] (03CR) 10jerkins-bot: [V: 04-1] Don't run filters with null title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [08:43:49] (03CR) 10MaxSem: "I don't like this pattern of every service receiving an array of options. First, you would have to remember to update the list when you're" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [08:46:57] (03CR) 10MaxSem: "Also, I like how Config throws exceptions on missing key, it's really hard to miss these - unlike missing array index warnings." [core] - 10https://gerrit.wikimedia.org/r/502818 (owner: 10simetrical) [08:59:00] (03PS1) 10Daimona Eaytoy: Use base implementation for MySqlBase::buildStringCast [core] - 10https://gerrit.wikimedia.org/r/503560 [09:00:01] (03Abandoned) 10Daimona Eaytoy: Add a wrapper for changing case of binary fields [core] - 10https://gerrit.wikimedia.org/r/474172 (owner: 10Daimona Eaytoy) [09:01:36] 10AbuseFilter: Special:AbuseLog throws when viewing details or examining (BadMethodCallException) - https://phabricator.wikimedia.org/T220874 (10seth) [09:02:33] 10AbuseFilter: Special:AbuseLog throws when viewing details or examining (BadMethodCallException) - https://phabricator.wikimedia.org/T220874 (10Daimona) [09:02:50] 10AbuseFilter: Special:AbuseLog throws when viewing details or examining (BadMethodCallException) - https://phabricator.wikimedia.org/T220874 (10Daimona) Alas, yes, it's the same. [09:04:23] (03PS6) 10Daimona Eaytoy: Add a wrapper for REGEX operator [core] - 10https://gerrit.wikimedia.org/r/460870 [09:09:28] 10MediaWiki-Configuration, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review, 10good first bug: ExtensionProcessor should prevent duplicate definitions for ResourceModuleSkinStyles - https://phabricator.wikimedia.org/T167331 (10D3r1ck01) Thanks a lot! The current state of the patch handl... [09:13:59] (03PS7) 10Daimona Eaytoy: Add a wrapper for REGEX operator [core] - 10https://gerrit.wikimedia.org/r/460870 [09:18:59] 10MediaWiki-extensions-UrlShortener, 10Wikimedia-Site-requests, 10Security: Increase the max length of URL to be shortened - https://phabricator.wikimedia.org/T220703 (10Framawiki) [09:25:43] (03CR) 10jerkins-bot: [V: 04-1] Add a wrapper for REGEX operator [core] - 10https://gerrit.wikimedia.org/r/460870 (owner: 10Daimona Eaytoy) [09:35:32] (03PS1) 10Daimona Eaytoy: Make patterns searching compatible with Postgres and SQLite [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503562 (https://phabricator.wikimedia.org/T193068) [09:36:10] 10AbuseFilter, 10Patch-For-Review, 10PostgreSQL, 10SQLite: Add support for SQLite and postgre when searching patterns - https://phabricator.wikimedia.org/T193068 (10Daimona) a:03Daimona Patch above + its dependencies and that's it. [09:37:11] (03PS8) 10Daimona Eaytoy: Add a wrapper for REGEX operator [core] - 10https://gerrit.wikimedia.org/r/460870 [09:37:17] (03CR) 10jerkins-bot: [V: 04-1] Make patterns searching compatible with Postgres and SQLite [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503562 (https://phabricator.wikimedia.org/T193068) (owner: 10Daimona Eaytoy) [09:37:19] (03CR) 10jerkins-bot: [V: 04-1] Make patterns searching compatible with Postgres and SQLite [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503562 (https://phabricator.wikimedia.org/T193068) (owner: 10Daimona Eaytoy) [09:38:40] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/503563 [09:39:11] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/503564 [09:39:25] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/503565 [09:39:39] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/503566 [09:42:22] (03PS8) 10D3r1ck01: registration: Avoid duplicate definitions for ResourceModuleSkinStyles [core] - 10https://gerrit.wikimedia.org/r/503379 (https://phabricator.wikimedia.org/T167331) [09:46:42] 10MediaWiki-extensions-UrlShortener: It is possible to create circular redirects in UrlShortener - https://phabricator.wikimedia.org/T115802 (10Framawiki) 05Open→03Invalid Looks already solved: entering https://w.wiki/ in https://meta.wikimedia.org/wiki/Special:UrlShortener?uselang=en shows `URLs to domain w... [09:47:31] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/503567 [09:47:49] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/503568 [09:48:00] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/503569 [09:48:18] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/503570 [09:48:47] (03PS1) 10Umherirrender: Add missing action- messages [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/503571 [09:48:55] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/503568 (owner: 10Umherirrender) [09:49:02] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/503572 [09:49:27] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503573 [09:50:32] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/503574 [09:50:43] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/503575 [09:50:58] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/503576 [09:51:13] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpiceUsageTracker] - 10https://gerrit.wikimedia.org/r/503577 [09:51:29] (03PS1) 10Umherirrender: Add missing action- messages [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/503578 [09:51:39] 10MediaWiki-extensions-UrlShortener: It is possible to create circular redirects in UrlShortener - https://phabricator.wikimedia.org/T115802 (10Framawiki) 05Invalid→03Open Oh, as said in task desc it is possible to play with Special:UrlRedirector that is not blocked. For example, https://w.wiki/wE redirects... [09:51:43] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/503579 [09:51:47] 10Security: Problem with login Gerrit - https://phabricator.wikimedia.org/T220867 (10Aklapper) [09:52:28] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/503580 [09:52:55] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/503581 [09:53:08] (03PS1) 10Umherirrender: Add missing action- messages [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/503582 [09:53:23] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/503580 (owner: 10Umherirrender) [09:53:25] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Comments] - 10https://gerrit.wikimedia.org/r/503583 [09:54:20] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/Comments] - 10https://gerrit.wikimedia.org/r/503583 (owner: 10Umherirrender) [09:55:00] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/503584 [09:55:15] (03PS1) 10Umherirrender: Add missing action- messages [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/503585 [09:55:32] (03PS1) 10Umherirrender: Add missing action- messages [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/503586 [09:55:43] (03PS1) 10Umherirrender: Add missing action- messages [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/503587 [09:55:54] (03PS1) 10Umherirrender: Add missing action- messages [extensions/DeleteUserPages] - 10https://gerrit.wikimedia.org/r/503588 [09:56:05] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/503589 [09:56:43] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/503590 [09:56:58] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/503591 [09:57:14] (03PS1) 10Umherirrender: Add missing action- messages [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/503592 [09:57:27] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/503593 [09:57:42] (03PS1) 10Umherirrender: Add missing action- messages [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/503594 [09:57:54] (03PS1) 10Umherirrender: Add missing action- messages [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/503595 [09:58:08] (03PS1) 10Umherirrender: Add missing action- messages [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/503596 [09:58:19] (03PS1) 10Umherirrender: Add missing action- messages [extensions/GoToShell] - 10https://gerrit.wikimedia.org/r/503597 [09:58:30] (03PS1) 10Umherirrender: Add missing action- messages [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/503598 [09:58:50] (03PS1) 10Umherirrender: Add missing action- messages [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/503599 [09:59:35] (03PS1) 10Umherirrender: Add missing action- messages [extensions/LdapGroups] - 10https://gerrit.wikimedia.org/r/503600 [09:59:49] (03PS1) 10Umherirrender: Add missing action- messages [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/503601 [10:00:02] (03PS1) 10Umherirrender: Add missing action- messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/503602 [10:02:27] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/503603 [10:02:44] (03PS1) 10Umherirrender: Add missing action- message keys [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/503604 [10:02:55] (03PS1) 10Umherirrender: Add missing action- messages [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/503605 [10:03:08] (03PS1) 10Umherirrender: Add missing action- messages [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/503606 [10:03:32] (03PS1) 10Umherirrender: Add missing action- messages [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/503607 [10:03:44] (03PS1) 10Umherirrender: Add missing action- messages [extensions/NoBogusUserpages] - 10https://gerrit.wikimedia.org/r/503608 [10:03:56] (03PS1) 10Umherirrender: Add missing action- messages [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/503609 [10:04:11] (03PS1) 10Umherirrender: Add missing action- messages [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/503610 [10:04:23] (03PS1) 10Umherirrender: Add missing action- messages [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/503611 [10:04:38] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/503612 [10:04:51] (03PS1) 10Umherirrender: Add missing action- messages [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/503613 [10:05:10] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Poll] - 10https://gerrit.wikimedia.org/r/503614 [10:05:39] (03PS1) 10Umherirrender: Add missing action- messages [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/503615 [10:05:59] (03PS1) 10Umherirrender: Add missing action- messages [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/503616 [10:06:42] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/503617 [10:08:10] (03PS1) 10Umherirrender: Add missing action- messages [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/503618 [10:08:22] (03PS1) 10Umherirrender: Add missing action- messages [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/503619 [10:08:34] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/503620 [10:08:46] (03PS1) 10Umherirrender: Add missing action- messages [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/503621 [10:09:02] (03PS1) 10Umherirrender: Add missing action- messages [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 [10:09:31] (03PS1) 10Umherirrender: Add missing action- messages [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 [10:10:49] (03PS1) 10Umherirrender: Add missing action- messages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/503625 [10:11:03] (03PS1) 10Umherirrender: Add missing action- messages [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503626 [10:11:14] (03PS1) 10Umherirrender: Add missing action- messages [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/503627 [10:11:26] (03PS1) 10Umherirrender: Add missing action- messages [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/503628 [10:11:39] (03PS1) 10Umherirrender: Add missing action- messages [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/503629 [10:11:54] (03PS1) 10Umherirrender: Add missing action- messages [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/503630 [10:12:08] (03PS1) 10Umherirrender: Add missing action- messages [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 [10:12:32] (03PS1) 10Umherirrender: Add missing action- messages [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/503632 [10:12:44] (03PS1) 10Umherirrender: Add missing action- messages [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/503633 [10:12:57] (03PS1) 10Umherirrender: Add missing action- messages [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/503634 [10:13:08] (03PS1) 10Umherirrender: Add missing action- messages [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/503635 [10:13:19] (03PS1) 10Umherirrender: Add missing action- messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/503636 [10:13:31] (03PS1) 10Umherirrender: Add missing action- messages [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/503637 [10:13:53] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/503632 (owner: 10Umherirrender) [10:13:57] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 (owner: 10Umherirrender) [10:16:02] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Umherirrender) I have uploaded some patch sets - https://gerrit.wikimedia.org/r/#/q/branch:master+topic:action-message [10:16:38] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 (owner: 10Umherirrender) [10:16:47] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Support for early community input on proposed mobile interventions - https://phabricator.wikimedia.org/T206549 (10Elitre) Thanks both. [10:20:45] (03CR) 10Jayprakash12345: Add missing action- messages (031 comment) [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 (owner: 10Umherirrender) [10:22:17] (03PS3) 10Umherirrender: Add mediawiki/mediawiki-codesniffer [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/503437 [10:22:27] (03CR) 10Umherirrender: "Depending needed to pass test" [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/503437 (owner: 10Umherirrender) [10:23:34] (03PS3) 10Umherirrender: Use valid license identifier [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503477 [10:23:42] (03PS2) 10Umherirrender: Add missing {} to if statements [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503521 [10:29:37] (03PS1) 10Umherirrender: Remove default value from database field aft_comment [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/503640 [10:31:48] (03CR) 10jerkins-bot: [V: 04-1] Remove default value from database field aft_comment [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/503640 (owner: 10Umherirrender) [10:32:53] (03CR) 10Umherirrender: "recheck" [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 (owner: 10Umherirrender) [10:33:11] (03CR) 10Umherirrender: "recheck" [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 (owner: 10Umherirrender) [10:35:28] 10Security-Team, 10CommRel-Specialists-Support (Jan-Mar-2019): Changing /wiki/Security and wiki/MediaWiki security reference content - https://phabricator.wikimedia.org/T217435 (10Elitre) @Quiddity @CKoerner_WMF does any of you own this? [10:37:05] (03PS2) 10Umherirrender: Add missing action- messages [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 [10:37:18] (03CR) 10Umherirrender: Add missing action- messages (031 comment) [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 (owner: 10Umherirrender) [10:41:48] (03CR) 10Daimona Eaytoy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503562 (https://phabricator.wikimedia.org/T193068) (owner: 10Daimona Eaytoy) [10:43:02] (03CR) 10Umherirrender: "The database failure is handled in I9256376e104c412f42c9b0f3d1a6452140bf5e53" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/503568 (owner: 10Umherirrender) [10:46:17] (03CR) 10Jayprakash12345: [C: 03+2] Add missing action- messages [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 (owner: 10Umherirrender) [10:46:32] 10Wikimedia-Takedown-Tools: Set up / identify Salesforce database for takedown tools - https://phabricator.wikimedia.org/T169543 (10JanWMF) Thank you both. Yes, this is still desirable because both Legal and Trust and Safety will continue to use SalesForce for such purposes as we go into the organization's mediu... [10:50:18] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019): Specialist support for Content Translation to start a conversation about English Wikipedia limitations on the tool - https://phabricator.wikimedia.org/T217129 (10Elitre) [10:50:32] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019): Specialist support for Content Translation enabling machine translation in Italian and German Wikipedias - https://phabricator.wikimedia.org/T214713 (10Elitre) [10:50:38] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 (owner: 10Umherirrender) [10:51:32] (03CR) 10jenkins-bot: Add missing action- messages [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/503622 (owner: 10Umherirrender) [10:51:33] 10Challenge, 10Social-Tools: Challenge extension is using zero date in own schema and failing in strict mode - https://phabricator.wikimedia.org/T220877 (10Umherirrender) [10:51:47] (03CR) 10Umherirrender: "Created T220877 for the database failure" [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/503580 (owner: 10Umherirrender) [10:51:57] 10Comments, 10Social-Tools: Comments extension is using zero date in own schema and failing in strict mode - https://phabricator.wikimedia.org/T220878 (10Umherirrender) [10:52:05] (03CR) 10Umherirrender: "Created T220878 for the database failure" [extensions/Comments] - 10https://gerrit.wikimedia.org/r/503583 (owner: 10Umherirrender) [10:52:20] 10Social-Tools, 10VoteNY: VoteNY extension is using zero date in own schema and failing in strict mode - https://phabricator.wikimedia.org/T220879 (10Umherirrender) [10:52:27] (03PS35) 10Fomafix: Linker: Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [10:52:29] (03CR) 10Umherirrender: "Created T220879 for the database failure" [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/503632 (owner: 10Umherirrender) [10:59:53] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503641 [11:02:08] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503641 (owner: 10Umherirrender) [11:07:09] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10Elitre) Another task where it doesn't seem straightforward how to evaluate Sherry's contribution. (Besides, it's been reopened and re... [11:10:00] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019): Specialist support for Content Translation enabling machine translation in Italian and German Wikipedias - https://phabricator.wikimedia.org/T214713 (10Elitre) p:05Triage→03Normal [11:12:09] 10ContentTranslation, 10CommRel-Specialists-Support (Apr-Jun-2019), 10Language-Team (Language-2019-April-June): Specialist support for Content Translation moving from beta to regular preferences in Catalan Wikipedia - https://phabricator.wikimedia.org/T214689 (10Elitre) p:05Triage→03Low (Since I am not h... [11:15:42] (03PS1) 10Umherirrender: Add right-message for existing action-message [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 [11:18:37] (03CR) 10jerkins-bot: [V: 04-1] Add right-message for existing action-message [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 (owner: 10Umherirrender) [11:20:18] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 (owner: 10Umherirrender) [11:23:17] (03CR) 10jerkins-bot: [V: 04-1] Add right-message for existing action-message [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 (owner: 10Umherirrender) [12:04:50] (03CR) 10Daimona Eaytoy: [V: 03+2] "As above" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [12:27:23] 10TWLCon-2019-India: Publish the report with metrics - https://phabricator.wikimedia.org/T213395 (10KCVelaga) 05Open→03Stalled [12:27:35] 10TWLCon-2019-India: Analyse and summarise the results - https://phabricator.wikimedia.org/T213394 (10KCVelaga) 05Open→03Stalled [12:28:42] 10TWLCon-2019-India: Discuss (with experts) and finalise the survey - https://phabricator.wikimedia.org/T213391 (10KCVelaga) [12:28:44] 10TWLCon-2019-India: Publish the report with metrics - https://phabricator.wikimedia.org/T213395 (10KCVelaga) [12:29:02] 10TWLCon-2019-India: CH Kannada - https://phabricator.wikimedia.org/T213612 (10KCVelaga) 05Open→03Resolved [12:29:12] 10Hindi-Sites, 10TWLCon-2019-India: CH Hindi - https://phabricator.wikimedia.org/T213610 (10KCVelaga) 05Open→03Resolved [12:29:39] 10TWLCon-2019-India: Using invetaire - https://phabricator.wikimedia.org/T213396 (10KCVelaga) 05Open→03Invalid [12:29:48] 10TWLCon-2019-India: Promotion (librarians) - https://phabricator.wikimedia.org/T213388 (10KCVelaga) 05Open→03Invalid [12:30:05] 10TWLCon-2019-India: CH Gujarati - https://phabricator.wikimedia.org/T213611 (10KCVelaga) 05Open→03Invalid [12:30:14] 10TWLCon-2019-India: CH Marathi - https://phabricator.wikimedia.org/T213609 (10KCVelaga) 05Open→03Invalid [12:30:18] 10TWLCon-2019-India: CH Punjabi - https://phabricator.wikimedia.org/T213608 (10KCVelaga) 05Open→03Invalid [12:30:20] 10TWLCon-2019-India: CH Telugu - https://phabricator.wikimedia.org/T213607 (10KCVelaga) 05Open→03Invalid [12:30:26] 10TWLCon-2019-India: Initiate community discussion - https://phabricator.wikimedia.org/T213385 (10KCVelaga) 05Open→03Invalid [12:30:32] 10TWLCon-2019-India: Complete set-up - https://phabricator.wikimedia.org/T213386 (10KCVelaga) 05Open→03Invalid [12:30:39] 10TWLCon-2019-India: Promotion (Wikimedia) - https://phabricator.wikimedia.org/T213387 (10KCVelaga) 05Open→03Invalid [12:30:47] 10TWLCon-2019-India: Analyse and summarise the results - https://phabricator.wikimedia.org/T213394 (10KCVelaga) 05Stalled→03Invalid [12:30:55] 10TWLCon-2019-India: Start the survey - https://phabricator.wikimedia.org/T213393 (10KCVelaga) 05Open→03Invalid [12:30:59] 10TWLCon-2019-India: List out channels for promotion - https://phabricator.wikimedia.org/T213392 (10KCVelaga) 05Open→03Invalid [12:31:05] 10TWLCon-2019-India: Discuss (with experts) and finalise the survey - https://phabricator.wikimedia.org/T213391 (10KCVelaga) 05Open→03Invalid [12:31:12] 10TWLCon-2019-India: Discussion with GIPE - https://phabricator.wikimedia.org/T213390 (10KCVelaga) 05Open→03Invalid [12:31:16] 10TWLCon-2019-India: Design a draft survey - https://phabricator.wikimedia.org/T213389 (10KCVelaga) 05Open→03Invalid [13:12:16] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/503563 (owner: 10Umherirrender) [13:12:32] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/503566 (owner: 10Umherirrender) [13:12:47] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/503564 (owner: 10Umherirrender) [13:12:59] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/503565 (owner: 10Umherirrender) [13:13:11] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/503567 (owner: 10Umherirrender) [13:18:31] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/503563 (owner: 10Umherirrender) [13:18:33] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/503566 (owner: 10Umherirrender) [13:19:19] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AdManager] - 10https://gerrit.wikimedia.org/r/503563 (owner: 10Umherirrender) [13:19:35] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/503569 (owner: 10Umherirrender) [13:19:36] 10Wikimedia-Site-requests: en.wikiversity VisualEditor Changing Active Namespaces - https://phabricator.wikimedia.org/T220881 (10Dave_Braunschweig) [13:19:43] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/503564 (owner: 10Umherirrender) [13:19:45] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/503565 (owner: 10Umherirrender) [13:19:47] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/503567 (owner: 10Umherirrender) [13:19:49] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/503570 (owner: 10Umherirrender) [13:20:01] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AnonPrivacy] - 10https://gerrit.wikimedia.org/r/503566 (owner: 10Umherirrender) [13:20:03] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/503571 (owner: 10Umherirrender) [13:20:14] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/503572 (owner: 10Umherirrender) [13:20:37] (03CR) 10Reedy: [C: 03+2] Add missing action- messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503573 (owner: 10Umherirrender) [13:20:44] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/503564 (owner: 10Umherirrender) [13:21:29] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/503565 (owner: 10Umherirrender) [13:22:06] (03PS1) 10Ammarpad: Add two new messages for maintenance window [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/503644 (https://phabricator.wikimedia.org/T220610) [13:22:13] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/503567 (owner: 10Umherirrender) [13:23:45] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/503569 (owner: 10Umherirrender) [13:24:36] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ArticleToCategory2] - 10https://gerrit.wikimedia.org/r/503569 (owner: 10Umherirrender) [13:25:29] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/503570 (owner: 10Umherirrender) [13:25:57] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/503571 (owner: 10Umherirrender) [13:25:59] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/503572 (owner: 10Umherirrender) [13:26:01] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503573 (owner: 10Umherirrender) [13:26:23] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AuthorProtect] - 10https://gerrit.wikimedia.org/r/503570 (owner: 10Umherirrender) [13:27:13] (03CR) 10jenkins-bot: Add missing action- messages [extensions/AutoProxyBlock] - 10https://gerrit.wikimedia.org/r/503571 (owner: 10Umherirrender) [13:27:59] (03CR) 10jenkins-bot: Add missing action- messages [extensions/BibManager] - 10https://gerrit.wikimedia.org/r/503572 (owner: 10Umherirrender) [13:28:52] (03CR) 10jenkins-bot: Add missing action- messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/503573 (owner: 10Umherirrender) [13:29:02] 10Security-Team, 10CommRel-Specialists-Support (Jan-Mar-2019): Changing /wiki/Security and wiki/MediaWiki security reference content - https://phabricator.wikimedia.org/T217435 (10Aklapper) >>! In T217435#5105302, @chasemp wrote: > But if... > > `Report wrong software behavior or a feature proposal` makes it... [13:49:49] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/503474 (owner: 10Umherirrender) [13:49:55] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/503505 (owner: 10Umherirrender) [13:50:35] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/503505 (owner: 10Umherirrender) [13:50:40] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/503506 (owner: 10Umherirrender) [13:50:45] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpicePageVersion] - 10https://gerrit.wikimedia.org/r/503507 (owner: 10Umherirrender) [13:50:49] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/503508 (owner: 10Umherirrender) [13:50:53] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/503510 (owner: 10Umherirrender) [13:50:57] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/503511 (owner: 10Umherirrender) [13:51:47] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503641 (owner: 10Umherirrender) [13:52:39] (03CR) 10Umherirrender: "recheck" [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 (owner: 10Umherirrender) [13:55:38] (03CR) 10jerkins-bot: [V: 04-1] Add right-message for existing action-message [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503642 (owner: 10Umherirrender) [13:58:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 25.0.0 [extensions/BlueSpicePrivacy] - 10https://gerrit.wikimedia.org/r/503641 (owner: 10Umherirrender) [14:13:31] (03CR) 10Esanders: [C: 03+2] linting: Start enforcing a basic CSS class naming rule (with lots of opt-outs) [core] - 10https://gerrit.wikimedia.org/r/503408 (owner: 10Jforrester) [14:20:14] (03CR) 10Esanders: [C: 04-1] "Need to change eslint config for the module." [extensions/Score] - 10https://gerrit.wikimedia.org/r/502849 (owner: 10Krinkle) [14:32:55] (03PS2) 10Esanders: JsonContent: Add missing prefix to selector [core] - 10https://gerrit.wikimedia.org/r/503489 [14:32:57] (03PS2) 10Esanders: Rename un-prefixed rcfilters selectors [core] - 10https://gerrit.wikimedia.org/r/503490 (https://phabricator.wikimedia.org/T220852) [14:34:06] (03CR) 10Esanders: [C: 03+1] Bundle data values for mw.config with the JS module that needs it [extensions/Score] - 10https://gerrit.wikimedia.org/r/503102 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [14:35:41] (03CR) 10Esanders: [C: 03+1] Bundle data values for mw.config with the JS module that needs it (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/503102 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [14:37:04] (03Merged) 10jenkins-bot: linting: Start enforcing a basic CSS class naming rule (with lots of opt-outs) [core] - 10https://gerrit.wikimedia.org/r/503408 (owner: 10Jforrester) [14:40:15] (03CR) 10jenkins-bot: linting: Start enforcing a basic CSS class naming rule (with lots of opt-outs) [core] - 10https://gerrit.wikimedia.org/r/503408 (owner: 10Jforrester) [14:49:05] (03PS21) 10Legoktm: registration: Allow to require environment abilities [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [14:59:52] 10MediaWiki-extensions-PropertySuggester, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Property suggestions for qualifiers and references are bad when adding new statements - https://phabricator.wikimedia.org/T102324 (10Envlh) Hello, @thiemowmde Are you still working on this issue? [15:17:05] (03PS8) 10Daimona Eaytoy: Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 [15:17:17] (03PS9) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [15:17:30] (03PS9) 10Daimona Eaytoy: Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 [15:17:32] (03CR) 10jerkins-bot: [V: 04-1] Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 (owner: 10Daimona Eaytoy) [15:17:34] (03CR) 10jerkins-bot: [V: 04-1] Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 (owner: 10Daimona Eaytoy) [15:18:46] (03PS22) 10Legoktm: registration: Allow to require environment abilities [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [15:20:30] (03PS1) 10Legoktm: Require the ability to shell out in extension.json [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 [15:21:11] (03CR) 10Legoktm: [C: 03+1] "PS22: Made some changes, if those look good to you I'll +2." [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [15:22:16] (03CR) 10jerkins-bot: [V: 04-1] Require the ability to shell out in extension.json [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 (owner: 10Legoktm) [15:29:41] (03PS1) 10Tpt: Adds a maintenance script to change a namespace ID [core] - 10https://gerrit.wikimedia.org/r/503647 [15:31:32] 10MediaWiki-extensions-DeletePagesForGood, 10Multi-Content-Revisions: Update the DeletePagesForGood extension for MCR - https://phabricator.wikimedia.org/T220884 (10GeoffreyT2000) [15:31:58] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-LdapAuthentication, 10wikitech.wikimedia.org, 10Patch-For-Review: Ldap auth extension vs. ldap vs. username Case - https://phabricator.wikimedia.org/T165795 (10bd808) >>! In T165795#5094500, @chasemp wrote: > * Our real point of concern h... [15:33:11] 10MediaWiki-Special-pages, 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Xaosflux) [15:35:41] 10MediaWiki-Configuration, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: ExtensionProcessor should prevent duplicate definitions for ResourceModuleSkinStyles - https://phabricator.wikimedia.org/T167331 (10Krinkle) [15:36:29] (03CR) 10jerkins-bot: [V: 04-1] Adds a maintenance script to change a namespace ID [core] - 10https://gerrit.wikimedia.org/r/503647 (owner: 10Tpt) [15:36:44] 10MediaWiki-Configuration, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: ExtensionProcessor should prevent duplicate definitions for ResourceModuleSkinStyles - https://phabricator.wikimedia.org/T167331 (10Krinkle) a:03D3r1ck01 [15:37:03] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Xaosflux) [15:39:21] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Mainframe98) [15:39:34] 10MediaWiki-Special-pages, 10CheckUser: CU and special pages are not properly displaying parenthesis around user links - https://phabricator.wikimedia.org/T220767 (10Mainframe98) [15:41:34] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Xaosflux) The following separators appear to be missing throughout the output: word-separator parentheses pipe-separator [15:41:37] (03PS34) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [15:42:23] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Xaosflux) [15:43:08] 10MediaWiki-Special-pages, 10CheckUser: CU and special pages are not properly displaying parenthesis around user links - https://phabricator.wikimedia.org/T220767 (10Xaosflux) Notes from T220885 The following separators appear to be missing throughout the output: word-separator parentheses pipe-separator [15:43:37] 10MediaWiki-Special-pages, 10CheckUser: CU and special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Xaosflux) [15:44:00] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Adithyak1997) I actually don't know how this works. But please do check if this can be solved by comparing with the Recent Change... [15:44:10] 10MediaWiki-Special-pages, 10CheckUser, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: CU and special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Xaosflux) [15:45:29] 10ContentTranslation, 10Patch-For-Review: Use OOUI dialog for CX suggestions - https://phabricator.wikimedia.org/T185900 (10Esanders) https://gerrit.wikimedia.org/r/503649 increases the padding slightly in dialog mode: |Before|After |{F28641948}|{F28641944} [15:48:02] 10MediaWiki-extensions-DeletePagesForGood, 10Multi-Content-Revisions: Update the DeletePagesForGood extension for MCR - https://phabricator.wikimedia.org/T220884 (10GeoffreyT2000) [15:57:01] 10MediaWiki-Special-pages, 10CheckUser, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: CU and special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Xaosflux) As was noted in T220885 some special pages (e.g. ht... [16:24:16] (03PS2) 10Tpt: Adds a maintenance script to change a namespace ID [core] - 10https://gerrit.wikimedia.org/r/503647 [16:24:42] 10MediaWiki-extensions-GraphQL, 10Patch-For-Review: Add Revision & User objects to Page - https://phabricator.wikimedia.org/T216888 (10dbarratt) 05Open→03Resolved [16:28:37] (03CR) 10Jack Phoenix: "Is the new message actually used anywhere, though? StaffPowers is quite literally basically one single hook; depending on the conditions, " [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/503628 (owner: 10Umherirrender) [16:29:08] 10MediaWiki-extensions-WikimediaIncubator, 10Patch-For-Review, 10Wikimedia-production-error: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported) - https://phabricator.wikimedia.org/T220623 (10Krinkle) [16:29:56] 10MediaWiki-extensions-WikimediaIncubator, 10Patch-For-Review, 10Wikimedia-production-error: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported) - https://phabricator.wikimedia.org/T220623 (10Krinkle) @Umherirrender Line number now included. [16:30:28] (03PS1) 10Daimona Eaytoy: Increase code coverage a bit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503654 (https://phabricator.wikimedia.org/T201193) [16:31:23] (03CR) 10Jack Phoenix: "Per my comments on the StaffPowers patch (https://gerrit.wikimedia.org/r/503628), not sure if this is needed here, although StaffEdits is " [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/503627 (owner: 10Umherirrender) [16:32:16] 10MediaWiki-extensions-WikimediaIncubator, 10Wikimedia-production-error: Unable to view certain pages on incubator.wikimedia.org (Fatal error: operator not supported) - https://phabricator.wikimedia.org/T220623 (10Ebe123) [16:36:08] (03CR) 10Krinkle: [C: 03+2] Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [16:36:44] (03CR) 10jerkins-bot: [V: 04-1] Adds a maintenance script to change a namespace ID [core] - 10https://gerrit.wikimedia.org/r/503647 (owner: 10Tpt) [16:39:46] 10MediaWiki-Special-pages, 10CheckUser, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10Regression: Some special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Ammarpad) [16:40:07] (03CR) 10Jack Phoenix: "Basically when either of the wikiforum-* user rights is required but the user doesn't have it, we either show nothing (in the case of some" [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/503636 (owner: 10Umherirrender) [16:45:00] (03CR) 10Krinkle: [C: 03+2] Increase code coverage a bit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503654 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [16:48:57] (03CR) 10Jack Phoenix: "For normal UI purposes, if the user lacks the 'voteny' user right, clicking on the "vote" link (in the case of the green voting box, e.g. " [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/503632 (owner: 10Umherirrender) [16:50:43] (03Merged) 10jenkins-bot: Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [16:53:49] (03CR) 10jenkins-bot: Reporting API and Feature Policy reporting support [core] - 10https://gerrit.wikimedia.org/r/494959 (https://phabricator.wikimedia.org/T209572) (owner: 10Gilles) [16:57:12] 10MediaWiki-Page-editing, 10VisualEditor, 10VisualEditor-MediaWiki: Expose WikiPage.php's replaceSectionAtRev function through the API - https://phabricator.wikimedia.org/T117715 (10Esanders) The parent patch works around this for the VE use case by calling the method from within a VE API call. I agree this... [16:57:34] 10MediaWiki-Page-editing, 10VisualEditor, 10VisualEditor-MediaWiki: Expose WikiPage.php's replaceSectionAtRev function through the API - https://phabricator.wikimedia.org/T117715 (10Esanders) p:05Normal→03Low [17:02:34] (03Merged) 10jenkins-bot: Increase code coverage a bit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503654 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:07:09] (03CR) 10jenkins-bot: Increase code coverage a bit [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503654 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:07:23] 10MediaWiki-Special-pages, 10Regression: Special:ListUsers is missing value separators - https://phabricator.wikimedia.org/T220885 (10Aklapper) [17:09:12] 10MediaWiki-extensions-DeletePagesForGood: Update the DeletePagesForGood extension for MCR - https://phabricator.wikimedia.org/T220884 (10Aklapper) No code changes in #multi-content-revisions needed, hence removing tag. [17:17:13] (03PS1) 10Daimona Eaytoy: Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) [17:22:44] (03CR) 10jerkins-bot: [V: 04-1] Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:26:00] 10MediaWiki-extensions-PropertySuggester, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: [Bug] Property suggestions for qualifiers and references are bad when adding new statements - https://phabricator.wikimedia.org/T102324 (10matej_suchanek) Maybe this has been done with T102324#3474167 and it can... [17:26:11] (03PS2) 10Daimona Eaytoy: Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) [17:28:43] (03CR) 10Jforrester: [C: 03+2] Disable notification emails for article-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503538 (https://phabricator.wikimedia.org/T219444) (owner: 10Catrope) [17:30:38] (03CR) 10Jforrester: [C: 03+2] Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [17:33:01] 10MediaWiki-Special-pages, 10CheckUser, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.33-release, 10Regression: Some special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Mainframe98) [17:38:01] (03CR) 10Krinkle: [C: 03+2] Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:42:51] 10MediaWiki-extensions-UrlShortener: UrlShortener-shortened URLs require two redirects to dereference - https://phabricator.wikimedia.org/T108607 (10Jc86035) I believe the original issue might have been fixed. ` $ wget --max-redirect=0 "https://w.wiki/w" --2019-04-14 01:42:21-- https://w.wiki/w Resolving w.wi... [17:43:38] (03Merged) 10jenkins-bot: Disable notification emails for article-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503538 (https://phabricator.wikimedia.org/T219444) (owner: 10Catrope) [17:43:40] (03CR) 10jerkins-bot: [V: 04-1] Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [17:47:54] (03CR) 10jenkins-bot: Disable notification emails for article-linked [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503538 (https://phabricator.wikimedia.org/T219444) (owner: 10Catrope) [17:50:43] (03PS2) 10D3r1ck01: specials: Remove unnecessary fully qualified namespaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503080 [17:50:56] (03PS2) 10D3r1ck01: MobileFormatter: Remove unused variable left after refactor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503093 [17:50:58] (03Merged) 10jenkins-bot: Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:51:11] (03PS2) 10D3r1ck01: Fix case mismatch for method getPrefixedDBKey() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503078 [17:51:24] (03PS2) 10D3r1ck01: api: Fix case mismatch in function name getFragmentForUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503075 [17:54:10] (03CR) 10D3r1ck01: [C: 03+2] Add phan to the Sparkpost repo [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/503115 (owner: 10D3r1ck01) [17:54:24] (03PS7) 10D3r1ck01: parser: Remove deprecated Parser class attribute $mUniqPrefix [core] - 10https://gerrit.wikimedia.org/r/502003 [17:54:29] (03PS15) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) [17:54:36] (03PS3) 10D3r1ck01: DevelopmentSettings: Remove unused globals & declare $wgSQLMode [core] - 10https://gerrit.wikimedia.org/r/502825 [17:54:38] (03PS2) 10D3r1ck01: RemoteSchema: Replace use of deprecated wfGetCache() function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/500194 [17:54:54] (03PS11) 10D3r1ck01: Switch DjVuHandler to new execution framework [core] - 10https://gerrit.wikimedia.org/r/487374 (https://phabricator.wikimedia.org/T182743) [17:55:03] (03PS4) 10D3r1ck01: SpecialUserrights: Improve ::userCanChangeRights() method logic [core] - 10https://gerrit.wikimedia.org/r/498639 (https://phabricator.wikimedia.org/T37674) [17:55:08] (03PS7) 10D3r1ck01: includes: Replace use of deprecated `global $wgPaser` with services [core] - 10https://gerrit.wikimedia.org/r/495679 [17:55:11] (03PS8) 10D3r1ck01: Rearrange files into sub-specific directories [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 [17:56:27] (03CR) 10jenkins-bot: Tweak coverage part 2 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/503658 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [17:57:04] (03Abandoned) 10D3r1ck01: linker: Move normalizeTarget() code from Linker to LinkRenderer [core] - 10https://gerrit.wikimedia.org/r/499465 (owner: 10D3r1ck01) [17:58:30] (03Abandoned) 10D3r1ck01: Begin avoiding use of deprecated methods wf[*]Warnings() [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/483732 (owner: 10D3r1ck01) [17:58:50] (03Abandoned) 10D3r1ck01: Fix history pop-state on Special:ExtensionDistributor [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/471329 (https://phabricator.wikimedia.org/T154400) (owner: 10D3r1ck01) [18:01:30] (03Merged) 10jenkins-bot: Add phan to the Sparkpost repo [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/503115 (owner: 10D3r1ck01) [18:02:18] (03CR) 10jenkins-bot: Add phan to the Sparkpost repo [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/503115 (owner: 10D3r1ck01) [18:03:20] 10MediaWiki-extensions-UrlShortener, 10Patch-For-Review: Equivalent URLs are not canonicalized and deduplicated - https://phabricator.wikimedia.org/T108602 (10Jc86035) For the record, the information in T108602#2112942 no longer appears to be accurate, although the extension does now normalize such URLs as a r... [18:03:28] (03PS1) 10D3r1ck01: installer: Remove TODO per discussion in Ia9f0cd7d0117f67d2017e [core] - 10https://gerrit.wikimedia.org/r/503663 [18:03:53] (03Abandoned) 10D3r1ck01: installer: Rename class property from $parent to $installer [core] - 10https://gerrit.wikimedia.org/r/500370 (owner: 10D3r1ck01) [18:05:41] 10ExtensionDistributor: History popstate not always handled (back broken) on Special:ExtensionDistributor - https://phabricator.wikimedia.org/T154400 (10D3r1ck01) [18:09:42] (03PS11) 10D3r1ck01: languages: Hard deprecate Language::getExtraUserToggles() method [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) [18:13:49] (03PS1) 10Framawiki: Fix readme syntax tags [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/503665 [18:14:24] (03PS5) 10Krinkle: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:14:47] 10UI-Standardization, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10OOUI (OOUI-0.31.3), 10UI-Standardization-Kanban: Add 'error' icon to 'alerts' icon pack - https://phabricator.wikimedia.org/T219826 (10Ladsgroup) Can this be also added in commons? [18:15:34] (03CR) 10Krinkle: [C: 03+2] Fix readme syntax tags [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/503665 (owner: 10Framawiki) [18:19:21] (03PS2) 10D3r1ck01: diff: Wrap condition around brackets for more readability [core] - 10https://gerrit.wikimedia.org/r/498753 [18:20:21] (03PS6) 10Krinkle: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:20:23] (03Merged) 10jenkins-bot: Fix readme syntax tags [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/503665 (owner: 10Framawiki) [18:20:30] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/503663 (owner: 10D3r1ck01) [18:21:28] (03CR) 10Krinkle: [C: 03+2] "I've moved the new line to makeModuleResponse where the concatenation of different modules happens. This way it applies to all forms of mo" [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:22:29] (03CR) 10D3r1ck01: diff: Wrap condition around brackets for more readability (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498753 (owner: 10D3r1ck01) [18:26:01] (03CR) 10D3r1ck01: "> Are you ready for the challenge yet...? ;-)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473483 (https://phabricator.wikimedia.org/T209477) (owner: 10D3r1ck01) [18:26:20] (03Abandoned) 10D3r1ck01: Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [18:26:47] (03PS14) 10Daimona Eaytoy: Restore (temporarily?) unit tests for CachingParser and fix it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) [18:30:03] (03PS1) 10Raimond Spekking: Add same languages used by Wikidata [extensions/cldr] - 10https://gerrit.wikimedia.org/r/503666 [18:37:57] (03CR) 10Krinkle: [C: 04-1] "This moves further way from PSR-4, not closer." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 (owner: 10D3r1ck01) [18:38:17] (03CR) 10Krinkle: [C: 03+2] specials: Remove unnecessary fully qualified namespaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503080 (owner: 10D3r1ck01) [18:38:21] 10MediaWiki-User-preferences, 10Browser-Support-Microsoft-Edge: Can't save preferences using microsoft edge - https://phabricator.wikimedia.org/T220706 (10YonaB) additional information: It happen in all wikipedias when the preferce language is hebrew (I checked it in en-wiki and ro-wiki). In ro-wiki, I don't h... [18:39:22] (03Merged) 10jenkins-bot: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:40:28] (03CR) 10Krinkle: [C: 03+2] "Sometimes an unused variable can still have meaning. For example, if it holds a scoped destructor callback. Or if the value assigned to it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503093 (owner: 10D3r1ck01) [18:42:47] (03CR) 10D3r1ck01: "> Unless the maintainers of MassMessage want to introduce extra namespaces, there should not be extra directories." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 (owner: 10D3r1ck01) [18:42:54] (03Abandoned) 10D3r1ck01: Rearrange files into sub-specific directories [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 (owner: 10D3r1ck01) [18:42:56] (03CR) 10jenkins-bot: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:45:58] (03CR) 10Krinkle: [C: 04-1] specials: Avoid the use of global variables in Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [18:46:28] (03CR) 10Krinkle: [C: 03+2] Fix case mismatch for method getPrefixedDBKey() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503078 (owner: 10D3r1ck01) [18:47:10] (03CR) 10Krinkle: [C: 03+2] "In PHP it works both ways (it was not broken), method names are case-insensitive. But, for clarity it is recommended that they match. Whic" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503078 (owner: 10D3r1ck01) [18:47:26] (03CR) 10Krinkle: [C: 03+2] RemoteSchema: Replace use of deprecated wfGetCache() function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/500194 (owner: 10D3r1ck01) [18:47:44] (03CR) 10Krinkle: "(attribute to Thiemo)" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/500194 (owner: 10D3r1ck01) [18:47:55] (03PS3) 10Jforrester: build: Update eslint-config-wikimedia from 0.9.0 to 0.11.0 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/503491 [18:48:09] (03CR) 10Krinkle: [C: 03+2] api: Fix case mismatch in function name getFragmentForUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503075 (owner: 10D3r1ck01) [18:48:15] (03CR) 10Jforrester: build: Update eslint-config-wikimedia from 0.9.0 to 0.11.0 (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/503491 (owner: 10Jforrester) [18:48:27] (03CR) 10Krinkle: [C: 03+2] installer: Remove TODO per discussion in Ia9f0cd7d0117f67d2017e [core] - 10https://gerrit.wikimedia.org/r/503663 (owner: 10D3r1ck01) [18:49:04] (03CR) 10Jforrester: [C: 03+2] "Fine." [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503517 (owner: 10Jforrester) [18:49:36] (03PS3) 10Jforrester: Avoid using $wgContLang [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/501151 (owner: 10MaxSem) [18:49:40] (03PS4) 10Jforrester: Avoid using $wgContLang [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/501151 (owner: 10MaxSem) [18:54:33] (03CR) 10jerkins-bot: [V: 04-1] Add same languages used by Wikidata [extensions/cldr] - 10https://gerrit.wikimedia.org/r/503666 (owner: 10Raimond Spekking) [18:55:22] (03CR) 10jenkins-bot: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:55:26] (03Merged) 10jenkins-bot: specials: Remove unnecessary fully qualified namespaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503080 (owner: 10D3r1ck01) [18:56:12] (03CR) 10jenkins-bot: Fix readme syntax tags [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/503665 (owner: 10Framawiki) [18:56:46] (03CR) 10jerkins-bot: [V: 04-1] Add same languages used by Wikidata [extensions/cldr] - 10https://gerrit.wikimedia.org/r/503666 (owner: 10Raimond Spekking) [18:57:42] (03Merged) 10jenkins-bot: MobileFormatter: Remove unused variable left after refactor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503093 (owner: 10D3r1ck01) [18:58:09] (03CR) 10jenkins-bot: resourceloader: Add newline after 'mw.loader.implement()' in debug mode [core] - 10https://gerrit.wikimedia.org/r/501995 (owner: 10Fomafix) [18:58:12] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/503579 (owner: 10Umherirrender) [18:58:23] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/503582 (owner: 10Umherirrender) [18:58:29] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/503584 (owner: 10Umherirrender) [18:58:36] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/503585 (owner: 10Umherirrender) [18:59:13] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/503586 (owner: 10Umherirrender) [18:59:19] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/503587 (owner: 10Umherirrender) [18:59:24] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/DeleteUserPages] - 10https://gerrit.wikimedia.org/r/503588 (owner: 10Umherirrender) [18:59:28] (03CR) 10Krinkle: "Can you show an example of how you would use this method in combination with LOWER?" [core] - 10https://gerrit.wikimedia.org/r/503560 (owner: 10Daimona Eaytoy) [18:59:30] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/503589 (owner: 10Umherirrender) [18:59:36] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/503590 (owner: 10Umherirrender) [18:59:46] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/503591 (owner: 10Umherirrender) [18:59:53] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/503592 (owner: 10Umherirrender) [18:59:58] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/503593 (owner: 10Umherirrender) [19:00:07] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/503601 (owner: 10Umherirrender) [19:00:53] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/503581 (owner: 10Umherirrender) [19:00:56] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/GoToShell] - 10https://gerrit.wikimedia.org/r/503597 (owner: 10Umherirrender) [19:01:04] (03CR) 10Daimona Eaytoy: "> Can you show an example of how you would use this method in" [core] - 10https://gerrit.wikimedia.org/r/503560 (owner: 10Daimona Eaytoy) [19:01:06] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/503594 (owner: 10Umherirrender) [19:01:07] (03CR) 10Krinkle: Add a wrapper for REGEX operator (031 comment) [core] - 10https://gerrit.wikimedia.org/r/460870 (owner: 10Daimona Eaytoy) [19:01:10] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/503596 (owner: 10Umherirrender) [19:01:16] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/503595 (owner: 10Umherirrender) [19:01:27] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/503599 (owner: 10Umherirrender) [19:01:29] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/LdapGroups] - 10https://gerrit.wikimedia.org/r/503600 (owner: 10Umherirrender) [19:01:35] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/503602 (owner: 10Umherirrender) [19:01:41] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/503605 (owner: 10Umherirrender) [19:01:48] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/503603 (owner: 10Umherirrender) [19:01:55] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/503606 (owner: 10Umherirrender) [19:02:29] (03CR) 10Krinkle: [C: 03+1] "Leaving for Aaron to approve as interim approach until HHVM support is removed." [core] - 10https://gerrit.wikimedia.org/r/439303 (https://phabricator.wikimedia.org/T191668) (owner: 10Umherirrender) [19:02:47] 10MediaWiki-Database, 10Performance-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Define varargs in \IDatabase::buildLike() in a way phan can understand it - https://phabricator.wikimedia.org/T191668 (10Krinkle) p:05Triage→03High [19:02:53] (03CR) 10Jforrester: [C: 03+2] Add missing action- message keys (031 comment) [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/503604 (owner: 10Umherirrender) [19:02:57] 10MediaWiki-Database, 10Performance-Team, 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Define varargs in \IDatabase::buildLike() in a way phan can understand it - https://phabricator.wikimedia.org/T191668 (10Krinkle) [19:03:00] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/503598 (owner: 10Umherirrender) [19:03:07] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/503607 (owner: 10Umherirrender) [19:03:22] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/NoBogusUserpages] - 10https://gerrit.wikimedia.org/r/503608 (owner: 10Umherirrender) [19:03:30] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/503609 (owner: 10Umherirrender) [19:03:41] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/503610 (owner: 10Umherirrender) [19:03:46] (03PS16) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) [19:04:05] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/503611 (owner: 10Umherirrender) [19:04:07] (03Merged) 10jenkins-bot: Fix case mismatch for method getPrefixedDBKey() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503078 (owner: 10D3r1ck01) [19:04:09] (03Merged) 10jenkins-bot: RemoteSchema: Replace use of deprecated wfGetCache() function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/500194 (owner: 10D3r1ck01) [19:04:11] (03Merged) 10jenkins-bot: api: Fix case mismatch in function name getFragmentForUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503075 (owner: 10D3r1ck01) [19:04:13] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/503612 (owner: 10Umherirrender) [19:04:28] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/503613 (owner: 10Umherirrender) [19:04:35] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Poll] - 10https://gerrit.wikimedia.org/r/503614 (owner: 10Umherirrender) [19:04:41] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/503615 (owner: 10Umherirrender) [19:04:47] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/503616 (owner: 10Umherirrender) [19:05:06] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/503617 (owner: 10Umherirrender) [19:05:18] (03CR) 10Krinkle: Bundle data values for mw.config with the JS module that needs it (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/503102 (https://phabricator.wikimedia.org/T219342) (owner: 10Krinkle) [19:06:06] (03Merged) 10jenkins-bot: installer: Remove TODO per discussion in Ia9f0cd7d0117f67d2017e [core] - 10https://gerrit.wikimedia.org/r/503663 (owner: 10D3r1ck01) [19:06:08] (03Merged) 10jenkins-bot: tests: Remove newlines from tests to make pass(?!) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503517 (owner: 10Jforrester) [19:06:10] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503470 (owner: 10Jforrester) [19:06:15] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/503579 (owner: 10Umherirrender) [19:06:17] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/503582 (owner: 10Umherirrender) [19:06:20] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/503584 (owner: 10Umherirrender) [19:06:22] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/503585 (owner: 10Umherirrender) [19:06:24] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/503586 (owner: 10Umherirrender) [19:06:27] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/503587 (owner: 10Umherirrender) [19:07:50] (03CR) 10MGChecker: [C: 03+1] "Looks fine to me!" [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [19:09:24] (03CR) 10MGChecker: [C: 03+1] "Additionally to backporting this to REL1_33, should we backport this to REL1_32 as well, where the other platform requirements have been i" [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [19:10:43] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/DeleteUserPages] - 10https://gerrit.wikimedia.org/r/503588 (owner: 10Umherirrender) [19:11:38] (03PS9) 10Daimona Eaytoy: Add a wrapper for REGEX operator [core] - 10https://gerrit.wikimedia.org/r/460870 [19:12:09] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/503589 (owner: 10Umherirrender) [19:12:11] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/503590 (owner: 10Umherirrender) [19:12:18] (03CR) 10Daimona Eaytoy: Add a wrapper for REGEX operator (031 comment) [core] - 10https://gerrit.wikimedia.org/r/460870 (owner: 10Daimona Eaytoy) [19:15:54] (03CR) 10Daimona Eaytoy: [C: 04-1] "Cover tags missing." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [19:17:04] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/503591 (owner: 10Umherirrender) [19:17:06] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/503592 (owner: 10Umherirrender) [19:17:08] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/503593 (owner: 10Umherirrender) [19:17:10] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/503601 (owner: 10Umherirrender) [19:17:12] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/503581 (owner: 10Umherirrender) [19:17:14] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/GoToShell] - 10https://gerrit.wikimedia.org/r/503597 (owner: 10Umherirrender) [19:18:13] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/503594 (owner: 10Umherirrender) [19:18:15] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/503596 (owner: 10Umherirrender) [19:18:50] (03CR) 10Jforrester: "recheck" [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 (owner: 10Legoktm) [19:19:02] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/503595 (owner: 10Umherirrender) [19:20:58] (03CR) 10jerkins-bot: [V: 04-1] Require the ability to shell out in extension.json [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 (owner: 10Legoktm) [19:21:32] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/503599 (owner: 10Umherirrender) [19:21:34] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/LdapGroups] - 10https://gerrit.wikimedia.org/r/503600 (owner: 10Umherirrender) [19:21:36] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/503602 (owner: 10Umherirrender) [19:21:38] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/503605 (owner: 10Umherirrender) [19:21:40] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/503603 (owner: 10Umherirrender) [19:21:42] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/503606 (owner: 10Umherirrender) [19:21:44] (03Merged) 10jenkins-bot: Add missing action- message keys [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/503604 (owner: 10Umherirrender) [19:21:46] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/503598 (owner: 10Umherirrender) [19:21:48] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/503607 (owner: 10Umherirrender) [19:21:54] 10MediaWiki-extensions-WebDAV, 10PHP 7.0 support: WebDAV master is broken on PHP7.* CI - https://phabricator.wikimedia.org/T220888 (10Jdforrester-WMF) [19:22:04] (03CR) 10Jforrester: "Filed as T220888." [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/503287 (owner: 10Umherirrender) [19:22:07] (03CR) 10jenkins-bot: installer: Remove TODO per discussion in Ia9f0cd7d0117f67d2017e [core] - 10https://gerrit.wikimedia.org/r/503663 (owner: 10D3r1ck01) [19:22:52] (03CR) 10jenkins-bot: MobileFormatter: Remove unused variable left after refactor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503093 (owner: 10D3r1ck01) [19:22:59] 10MobileFrontend, 10Readers-Web-Backlog: User watchlist talk tab should show pages from all talk namespaces - https://phabricator.wikimedia.org/T220889 (10Niedzielski) [19:23:26] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Beta navtiming pipeline broken - https://phabricator.wikimedia.org/T220890 (10Gilles) [19:23:34] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Beta navtiming pipeline broken - https://phabricator.wikimedia.org/T220890 (10Gilles) p:05Triage→03Normal [19:24:51] (03CR) 10jenkins-bot: Add missing action- messages [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/503582 (owner: 10Umherirrender) [19:25:12] (03PS1) 10Jforrester: build: Relax MediaWiki.Usage.DeprecatedGlobalVariables.Deprecated$wgParser for now [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503667 [19:25:17] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Beta navtiming pipeline broken - https://phabricator.wikimedia.org/T220890 (10Gilles) [19:25:33] (03PS2) 10Jforrester: Require the ability to shell out in extension.json [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 (owner: 10Legoktm) [19:25:42] (03CR) 10D3r1ck01: "You're absolutely right @Krinkle! I'm trying to keep an eye on such cases." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503093 (owner: 10D3r1ck01) [19:25:47] (03CR) 10jenkins-bot: Add missing action- messages [extensions/DataTransfer] - 10https://gerrit.wikimedia.org/r/503585 (owner: 10Umherirrender) [19:26:08] (03CR) 10D3r1ck01: "True! :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [19:26:30] (03CR) 10jenkins-bot: Add missing action- messages [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/503586 (owner: 10Umherirrender) [19:26:50] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/NoBogusUserpages] - 10https://gerrit.wikimedia.org/r/503608 (owner: 10Umherirrender) [19:27:31] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/503584 (owner: 10Umherirrender) [19:28:23] (03CR) 10jenkins-bot: Add missing action- messages [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/503587 (owner: 10Umherirrender) [19:28:48] (03PS2) 10Jforrester: Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [19:29:11] (03CR) 10jenkins-bot: Add missing action- messages [extensions/DeleteUserPages] - 10https://gerrit.wikimedia.org/r/503588 (owner: 10Umherirrender) [19:29:30] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/503609 (owner: 10Umherirrender) [19:29:32] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/OfflineImportLexicon] - 10https://gerrit.wikimedia.org/r/503610 (owner: 10Umherirrender) [19:29:34] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/503611 (owner: 10Umherirrender) [19:29:53] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Duplicator] - 10https://gerrit.wikimedia.org/r/503590 (owner: 10Umherirrender) [19:30:07] 10OABot, 10WikiCite: Find ways to integrate/improve OABot with WikiCite efforts - https://phabricator.wikimedia.org/T194813 (10Nemo_bis) > As a lower hanging fruit, we can also "run OAbot on Wikidata", which would basically mean importing the ids to publication items. Just the IDs or also the URLs to reposito... [19:30:32] (03CR) 10Jforrester: [C: 04-1] JsonContent: Add missing prefix to selector (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503489 (owner: 10Esanders) [19:30:44] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Diagnosis] - 10https://gerrit.wikimedia.org/r/503589 (owner: 10Umherirrender) [19:31:37] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Farmer] - 10https://gerrit.wikimedia.org/r/503591 (owner: 10Umherirrender) [19:32:13] 10OABot: Allow custom filtering for future suggestions - https://phabricator.wikimedia.org/T166959 (10Nemo_bis) 05Open→03Declined T173169 would be good enough. [19:32:16] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/503612 (owner: 10Umherirrender) [19:32:23] (03CR) 10jenkins-bot: Add missing action- messages [extensions/FilterListUsers] - 10https://gerrit.wikimedia.org/r/503592 (owner: 10Umherirrender) [19:33:25] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/503593 (owner: 10Umherirrender) [19:34:03] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/503613 (owner: 10Umherirrender) [19:34:05] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/Poll] - 10https://gerrit.wikimedia.org/r/503614 (owner: 10Umherirrender) [19:34:07] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/503615 (owner: 10Umherirrender) [19:34:19] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ChangeUserPasswords] - 10https://gerrit.wikimedia.org/r/503581 (owner: 10Umherirrender) [19:35:05] (03CR) 10jenkins-bot: Add missing action- messages [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/503594 (owner: 10Umherirrender) [19:35:52] (03CR) 10jenkins-bot: Add missing action- messages [extensions/googleAnalytics] - 10https://gerrit.wikimedia.org/r/503595 (owner: 10Umherirrender) [19:36:31] (03CR) 10jerkins-bot: [V: 04-1] Add missing action- messages [extensions/PureWikiDeletion] - 10https://gerrit.wikimedia.org/r/503616 (owner: 10Umherirrender) [19:36:33] (03CR) 10jenkins-bot: Add missing action- messages [extensions/LastUserLogin] - 10https://gerrit.wikimedia.org/r/503599 (owner: 10Umherirrender) [19:37:04] (03CR) 10Jforrester: [C: 03+2] Require the ability to shell out in extension.json [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/503646 (owner: 10Legoktm) [19:37:06] (03CR) 10Jforrester: [C: 03+2] registration: Allow to require environment abilities [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [19:37:23] (03CR) 10jenkins-bot: Add missing action- messages [extensions/LdapGroups] - 10https://gerrit.wikimedia.org/r/503600 (owner: 10Umherirrender) [19:38:08] (03CR) 10jenkins-bot: Add missing action- messages [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/503602 (owner: 10Umherirrender) [19:38:32] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/503617 (owner: 10Umherirrender) [19:38:58] (03CR) 10jenkins-bot: Add missing action- messages [extensions/MediaWikiAuth] - 10https://gerrit.wikimedia.org/r/503605 (owner: 10Umherirrender) [19:39:08] (03CR) 10jenkins-bot: specials: Remove unnecessary fully qualified namespaces [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503080 (owner: 10D3r1ck01) [19:39:19] 10Library-Card-Platform: Reject with reason - https://phabricator.wikimedia.org/T220891 (10Nikkimaria) [19:39:29] 10Library-Card-Platform: Reject with reason - https://phabricator.wikimedia.org/T220891 (10Nikkimaria) p:05Triage→03Lowest [19:39:50] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Maintenance] - 10https://gerrit.wikimedia.org/r/503603 (owner: 10Umherirrender) [19:40:35] (03CR) 10jenkins-bot: Add missing action- messages [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/503606 (owner: 10Umherirrender) [19:40:51] (03CR) 10Jforrester: "> Patch Set 1:" [vendor] - 10https://gerrit.wikimedia.org/r/503148 (https://phabricator.wikimedia.org/T220720) (owner: 10Gergő Tisza) [19:41:27] (03CR) 10jenkins-bot: Add missing action- message keys [extensions/MarkAsHelpful] - 10https://gerrit.wikimedia.org/r/503604 (owner: 10Umherirrender) [19:42:17] (03CR) 10jenkins-bot: Add missing action- messages [extensions/NewSignupPage] - 10https://gerrit.wikimedia.org/r/503607 (owner: 10Umherirrender) [19:43:04] (03CR) 10jenkins-bot: Add missing action- messages [extensions/HAWelcome] - 10https://gerrit.wikimedia.org/r/503598 (owner: 10Umherirrender) [19:43:20] (03CR) 10jenkins-bot: RemoteSchema: Replace use of deprecated wfGetCache() function [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/500194 (owner: 10D3r1ck01) [19:43:54] (03CR) 10jenkins-bot: Add missing action- messages [extensions/NoBogusUserpages] - 10https://gerrit.wikimedia.org/r/503608 (owner: 10Umherirrender) [19:44:38] (03CR) 10jenkins-bot: Add missing action- messages [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/503609 (owner: 10Umherirrender) [19:45:21] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Patroller] - 10https://gerrit.wikimedia.org/r/503612 (owner: 10Umherirrender) [19:46:23] (03CR) 10jenkins-bot: Fix case mismatch for method getPrefixedDBKey() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503078 (owner: 10D3r1ck01) [19:46:28] (03CR) 10jenkins-bot: Add missing action- messages [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/503613 (owner: 10Umherirrender) [19:47:08] (03CR) 10jenkins-bot: Add missing action- messages [extensions/PrivateDomains] - 10https://gerrit.wikimedia.org/r/503615 (owner: 10Umherirrender) [19:48:06] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Push] - 10https://gerrit.wikimedia.org/r/503617 (owner: 10Umherirrender) [19:48:28] (03CR) 10jenkins-bot: tests: Remove newlines from tests to make pass(?!) [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503517 (owner: 10Jforrester) [19:51:21] (03CR) 10jenkins-bot: api: Fix case mismatch in function name getFragmentForUrl() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503075 (owner: 10D3r1ck01) [19:52:18] (03CR) 10D3r1ck01: [C: 04-1] Remove function existence check (031 comment) [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/503555 (owner: 10MaxSem) [19:52:53] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/503579 (owner: 10Umherirrender) [19:53:02] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Isarra) I recommend double-checking before merging these extension changes, as these tests don't make any sense in quite a few cases - for anythin... [19:54:09] (03Merged) 10jenkins-bot: registration: Allow to require environment abilities [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [19:54:13] (03CR) 10Jforrester: [C: 03+2] Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [19:54:53] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia from 0.8.1 to 0.11.0 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/503470 (owner: 10Jforrester) [19:55:43] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/503621 (owner: 10Umherirrender) [19:55:47] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/503618 (owner: 10Umherirrender) [19:55:53] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/503619 (owner: 10Umherirrender) [19:55:58] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/503620 (owner: 10Umherirrender) [19:56:02] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/503625 (owner: 10Umherirrender) [19:56:07] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503626 (owner: 10Umherirrender) [19:56:13] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/503630 (owner: 10Umherirrender) [19:56:18] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/503629 (owner: 10Umherirrender) [19:56:23] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/503637 (owner: 10Umherirrender) [19:56:37] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/503633 (owner: 10Umherirrender) [19:56:42] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/503635 (owner: 10Umherirrender) [19:56:47] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/503634 (owner: 10Umherirrender) [19:56:48] James_F: Stop! A lot of those definitely should not be merged! [19:56:52] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 (owner: 10Umherirrender) [19:57:00] James_F: Please! [19:57:16] (03CR) 10jenkins-bot: registration: Allow to require environment abilities [core] - 10https://gerrit.wikimedia.org/r/467094 (https://phabricator.wikimedia.org/T212472) (owner: 10MGChecker) [19:58:02] (03CR) 10Jforrester: [C: 03+1] "> Patch Set 1:" [extensions/StaffPowers] - 10https://gerrit.wikimedia.org/r/503628 (owner: 10Umherirrender) [19:58:14] (03CR) 10Jforrester: [C: 03+1] "Per my comments there." [extensions/StaffEdits] - 10https://gerrit.wikimedia.org/r/503627 (owner: 10Umherirrender) [19:58:19] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Isarra) This came up in MediaWikiAuth because there we have a permission that all it does is return early and not keep checking other things if th... [19:58:21] (03PS1) 10MGChecker: registration: Allow to require environment abilities [core] (REL1_33) - 10https://gerrit.wikimedia.org/r/503668 (https://phabricator.wikimedia.org/T212472) [19:58:36] (03CR) 10Jforrester: [C: 03+1] Add missing action- messages [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/503636 (owner: 10Umherirrender) [19:58:38] (03Merged) 10jenkins-bot: Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [19:58:45] (03CR) 10Jforrester: [C: 03+2] Add missing action- messages [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 (owner: 10Umherirrender) [19:59:31] (03CR) 10jenkins-bot: Sort generated data tables by file name [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498765 (owner: 10MaxSem) [19:59:39] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/503621 (owner: 10Umherirrender) [20:00:31] Isarra: You want me to not fix repos, and leave them broken so that they don't work? [20:00:39] (03CR) 10jenkins-bot: Add missing action- messages [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/503621 (owner: 10Umherirrender) [20:01:24] James_F: Yes. The test is broken. [20:02:23] You are just going to waste translators' time on actions that do not exist in the first place. Many of these extensions are adding rights that do not have actions associated with them. [20:02:53] 10MediaWiki-Core-Testing, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Isarra) So, uh, we'll probably need to revert a bunch of these changes, and make the test itself a lot smarter, since we need there to even be an... [20:03:13] Isarra: Eh. I disagree, mildly. [20:03:27] With what, exactly? [20:03:50] You. [20:04:04] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/503618 (owner: 10Umherirrender) [20:04:06] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/503619 (owner: 10Umherirrender) [20:04:14] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/503620 (owner: 10Umherirrender) [20:04:15] James_F: With what, exactly, that I am saying, do you disagree with? [20:04:16] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/503625 (owner: 10Umherirrender) [20:04:25] I think the change is reasonable, and the "waste of translators' time" is negligible given it's a copy-and-paste that will automatically be provided on TWN. [20:04:44] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503626 (owner: 10Umherirrender) [20:04:46] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/503630 (owner: 10Umherirrender) [20:05:02] (03CR) 10jenkins-bot: Add missing action- messages [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/503618 (owner: 10Umherirrender) [20:05:30] yes, you *can* add a bunch of unused and will-never-be-used messages, but what's the point? [20:05:54] (03CR) 10jenkins-bot: Add missing action- messages [extensions/QuizTabulate] - 10https://gerrit.wikimedia.org/r/503619 (owner: 10Umherirrender) [20:05:57] 10MediaWiki-Configuration, 10MW-1.33-notes, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16), 10Patch-For-Review: extension.json should be able to express dependency of platform abilities - https://phabricator.wikimedia.org/T212472 (10MGChecker) [20:06:03] furthermore I expect TWN to care since they care enough to explicitly *not* support entire _extensions_ that lack qqq; I'd know, I've had that discussion with them a few times in the past [20:06:22] I don't see how that's relevant? [20:06:28] James_F: We are adding action messages for actions that do not exist. How is that reasonable? [20:06:46] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ReassignEdits] - 10https://gerrit.wikimedia.org/r/503620 (owner: 10Umherirrender) [20:06:52] Obviously if an extension author doesn't care about translators even enough to write qqq messages, pushing translators to translate it is unreasonable. [20:07:36] that's a very fascinating assumption you're making there [20:07:46] (03CR) 10jenkins-bot: Add missing action- messages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/503625 (owner: 10Umherirrender) [20:07:56] And now you're proposing that extension authors shouldn't care about them in the other direction, and just add extra unused messages? [20:08:02] Writing a qqq file takes a few minutes for someone familiar with the code. I've done it dozens of times. [20:08:37] I imagine that extension authors care more about CI passing their code than a currently-extraneous message they can ignore. [20:08:41] Yes, the qqq is important. So is not having extra unused messages. [20:08:49] (03CR) 10jenkins-bot: Add missing action- messages [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503626 (owner: 10Umherirrender) [20:08:54] Clearly, we disagree. [20:09:34] (03CR) 10jenkins-bot: Add missing action- messages [extensions/UIFeedback] - 10https://gerrit.wikimedia.org/r/503630 (owner: 10Umherirrender) [20:09:38] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/503629 (owner: 10Umherirrender) [20:09:40] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/503637 (owner: 10Umherirrender) [20:09:42] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/503633 (owner: 10Umherirrender) [20:09:58] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/503635 (owner: 10Umherirrender) [20:10:00] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/503634 (owner: 10Umherirrender) [20:10:02] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 (owner: 10Umherirrender) [20:10:04] (03Merged) 10jenkins-bot: Add missing action- messages [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 (owner: 10Umherirrender) [20:10:22] James_F: Please don't merge changes without even checking if the code in question merits them. That is not helpful. [20:10:29] (03CR) 10jenkins-bot: Add missing action- messages [extensions/StalkerLog] - 10https://gerrit.wikimedia.org/r/503629 (owner: 10Umherirrender) [20:11:09] What, exactly, do you think unbreaking the repo is if not "merit"? [20:11:12] (03CR) 10jenkins-bot: Add missing action- messages [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/503633 (owner: 10Umherirrender) [20:11:42] If you mean "please check if this extension as currently written and presumably configured can't ever trigger this edge case", I think that's an unreasonable request, but I understand your concern. [20:11:52] Not when the problem is that the test is checking for the wrong things. It is a bad test. [20:11:54] (03CR) 10jenkins-bot: Add missing action- messages [extensions/Widgets] - 10https://gerrit.wikimedia.org/r/503635 (owner: 10Umherirrender) [20:12:48] (03CR) 10jenkins-bot: Add missing action- messages [extensions/ShowRealUsernames] - 10https://gerrit.wikimedia.org/r/503624 (owner: 10Umherirrender) [20:13:39] (03CR) 10jenkins-bot: Add missing action- messages [extensions/WebChat] - 10https://gerrit.wikimedia.org/r/503634 (owner: 10Umherirrender) [20:14:31] (03CR) 10jenkins-bot: Add missing action- messages [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/503631 (owner: 10Umherirrender) [20:26:32] outside core user rights can and in many cases *do* exist without the corresponding action-* message, for the action-* message is primarily (AFAIK) used by the code in SpecialPage#checkPermissions which extensions can use when constructing a restricted special page; but special page extensions are hardly the only kind of extensions which exist. as I wrote in a few of the patchsets (for StaffPowers, StaffEdits, VoteNY at least), it seems [20:26:32] highly unlikely if not outright impossible for anything to cause a broken i18n string to be displayed to the end-user, because these extensions are not SpecialPages and thus they do error handling differently. and that is perfectly fine and acceptable. *maybe* for core it makes sense to have an actually enforcing test but extensions should be able to decide this on a case-by-case basis [20:30:20] ashley: You might want to put this on the associated task and look into reverting/making the test itself more specific. [20:31:02] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Nemo_bis) [20:31:05] right, will do [20:32:18] ...because if we can't actually fix the test, we'll probably just be better off without it. Which is dumb, because where we actually want it, it WOULD be useful to have it check for us... [20:37:24] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Nemo_bis) Adding a few dozens "extra" messages is not a problem in itself, assuming the text makes sense and the documentation is clear... [20:43:04] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Patch-For-Review: Alert on group1 canary wikis navtiming report rate - https://phabricator.wikimedia.org/T220807 (10Gilles) Navtiming processor change deployed and tested on beta, moving onto production deployment. [20:45:06] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Patch-For-Review: Alert on group1 canary wikis navtiming report rate - https://phabricator.wikimedia.org/T220807 (10Gilles) Updated production navtiming processor. [20:47:07] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Reedy) >>! In T220779#5109117, @Isarra wrote: > This came up in MediaWikiAuth because there we have a permission that all it does is ret... [20:48:01] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Patch-For-Review: Alert on group1 canary wikis navtiming report rate - https://phabricator.wikimedia.org/T220807 (10Gilles) The data is coming into graphite for the groups, I'll make the alert on Monday once we have a couple of days of data to sh... [20:48:48] (03CR) 10Aaron Schulz: [C: 03+2] Improve test mockery and avoid deprecated RLContext::getConfig [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/503149 (owner: 10Krinkle) [20:51:49] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Isarra) The issue is the test //doesn't// make sense - it should only be checking for the action message if there is an associated actio... [20:54:57] 10MobileFrontend, 10Contributors-Team, 10Section Editing, 10VisualEditor-MediaWiki, and 3 others: Allow switching between editors with changes on mobile - https://phabricator.wikimedia.org/T128422 (10Esanders) [21:02:35] 10MediaWiki-User-preferences, 10Wikimania-Hackathon-2018: Add an option to allow users to configure which language Special:MyLanguage links them to - https://phabricator.wikimedia.org/T200008 (10Aklapper) @Zenith4237: This issue has been assigned to you a while ago. Could you please share a status update? Are... [21:03:39] (03Merged) 10jenkins-bot: Improve test mockery and avoid deprecated RLContext::getConfig [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/503149 (owner: 10Krinkle) [21:05:14] 10Wikimania-Hackathon-2018: Hackathon Technology Dept Focus Area - https://phabricator.wikimedia.org/T198572 (10Aklapper) @debt: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks still needed to create? If there is nothing left to do here, please feel free to resolve this task via... [21:05:20] (03CR) 10jenkins-bot: Improve test mockery and avoid deprecated RLContext::getConfig [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/503149 (owner: 10Krinkle) [21:07:27] 10Wikimania-Hackathon-2018: Wikimedia Design Style Guide – what was, what is and what will be. And why you should care today… (Hackathon 2018) - https://phabricator.wikimedia.org/T194817 (10Aklapper) @Volker_E: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks still needed to crea... [21:10:06] 10Wikimania-Hackathon-2018: Catalog help content in many wikis - https://phabricator.wikimedia.org/T199799 (10Aklapper) @MMiller_WMF: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks / documentation still needed to create or link to? If there is nothing left to do here, please fe... [21:11:11] 10Wikimania-Hackathon-2018: Videowiki - Video version of Wikipedia - https://phabricator.wikimedia.org/T199997 (10Aklapper) 05Open→03Resolved a:03Rogueassasin123 [21:11:29] 10Wikimedia-SVG-rendering: SVG image is rendered as black image - https://phabricator.wikimedia.org/T158496 (10JoKalliauer) 05duplicate→03Resolved [21:11:37] 10Wikimania-Hackathon-2018: Session: Doing cool things with Wiki Content (Parsoid power) - https://phabricator.wikimedia.org/T199245 (10Aklapper) @cscott: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks / documentation still needed to create or link to? If there is nothing left... [21:11:42] 10Wikimania-Hackathon-2018: Session: Languages, Scripts and Variants: LanguageConverter - https://phabricator.wikimedia.org/T199238 (10Aklapper) @cscott: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks / documentation still needed to create or link to? If there is nothing left t... [21:12:14] 10International-Developer-Events, 10Wikimania-Hackathon-2018: Language Focus Area: Overview and meetup - https://phabricator.wikimedia.org/T199626 (10Aklapper) @Amire80: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks / documentation still needed to create or link to? If there... [21:12:29] (03CR) 10Aaron Schulz: [C: 04-1] "I'd suggest just always using the master here (for these jobs). That seems simpler and doesn't involve more boolean parameters." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/503404 (https://phabricator.wikimedia.org/T204894) (owner: 10Sbisson) [21:12:43] 10Wikimania-Hackathon-2018: Session: ScienceSource scripting for focus list additions - https://phabricator.wikimedia.org/T199329 (10Aklapper) @charles_matthews: Anything left to do in this #wikimania-hackathon-2018 task / any follow-up tasks / documentation still needed to create or link to? If there is nothin... [21:15:33] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Keynote on Platform Principles - https://phabricator.wikimedia.org/T206087 (10Aklapper) 05Open→03Resolved Assuming this took place hence resolving this #wikimedia-technical-conference-2018 task. (Please feel free to correct.) [21:15:43] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 - Opening - https://phabricator.wikimedia.org/T206052 (10Aklapper) @debt: Anything left to do in this #wikimedia-technical-conference-2018 task / any follow-up tasks / documentation still needed to create or link to? If there is nothing... [21:16:33] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 - Fireside chat with Victoria Coleman, Toby Negrin, Erik Moeller - https://phabricator.wikimedia.org/T206054 (10Aklapper) 05Open→03Resolved Assuming this took place hence resolving this #Wikimedia-Technical-Conference-2018 task. (Plea... [21:17:10] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Report backs and closing - https://phabricator.wikimedia.org/T207348 (10Aklapper) Anything left to do in this #wikimedia-technical-conference-2018 task / any follow-up tasks / documentation still needed to create or link to? If... [21:20:28] (03PS3) 10Esanders: Allow a data promise to be passed to wikitext editor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/500981 (https://phabricator.wikimedia.org/T128422) [21:20:30] (03PS1) 10Esanders: Allow wikitext content to be passed to VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503670 (https://phabricator.wikimedia.org/T117716) [21:26:07] (03PS3) 10Esanders: JsonContent: Add missing prefix to selector [core] - 10https://gerrit.wikimedia.org/r/503489 [21:26:09] (03PS3) 10Esanders: Rename un-prefixed rcfilters selectors [core] - 10https://gerrit.wikimedia.org/r/503490 (https://phabricator.wikimedia.org/T220852) [21:26:51] (03PS4) 10Esanders: Rename un-prefixed rcfilters selectors [core] - 10https://gerrit.wikimedia.org/r/503490 (https://phabricator.wikimedia.org/T220852) [21:29:35] 10Security-Team, 10CommRel-Specialists-Support (Jan-Mar-2019): Changing /wiki/Security and wiki/MediaWiki security reference content - https://phabricator.wikimedia.org/T217435 (10Quiddity) >>! In T217435#5108721, @Elitre wrote: > @Quiddity @CKoerner_WMF does any of you own this? Nope, Chase owns this, we're... [21:34:54] (03CR) 10jerkins-bot: [V: 04-1] Allow wikitext content to be passed to VisualEditor [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/503670 (https://phabricator.wikimedia.org/T117716) (owner: 10Esanders) [21:37:43] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Anti-Harassment, 10Stewards-and-global-tools, 10Patch-For-Review: Special:CentralAuth should provide the same blocking information as Special:BlockList does - https://phabricator.wikimedia.org/T200938 (10Trijnstel) >>! In T200938#5094768,... [21:39:07] (03CR) 10jerkins-bot: [V: 04-1] JsonContent: Add missing prefix to selector [core] - 10https://gerrit.wikimedia.org/r/503489 (owner: 10Esanders) [21:40:47] (03CR) 10jerkins-bot: [V: 04-1] Rename un-prefixed rcfilters selectors [core] - 10https://gerrit.wikimedia.org/r/503490 (https://phabricator.wikimedia.org/T220852) (owner: 10Esanders) [21:41:24] (03CR) 10jerkins-bot: [V: 04-1] Rename un-prefixed rcfilters selectors [core] - 10https://gerrit.wikimedia.org/r/503490 (https://phabricator.wikimedia.org/T220852) (owner: 10Esanders) [21:46:41] (03PS1) 10TheDJ: Hightlight match tag with different capitalization [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/503671 (https://phabricator.wikimedia.org/T179321) [21:47:05] 10MediaWiki-extensions-CodeMirror, 10Community-Tech (2015-2017), 10Patch-For-Review: Capitalizing a matching tag makes CodeMirror not recognize it - https://phabricator.wikimedia.org/T179321 (10TheDJ) a:03TheDJ [21:48:15] (03PS2) 10TheDJ: Highlight match end tag with different capitalization [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/503671 (https://phabricator.wikimedia.org/T179321) [21:54:55] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Tgr) Actions are a fuzzy concept in MediaWiki (see e.g. {T212345}). In one sense, and action is something that has an Action subclass an... [21:55:40] 10MediaWiki-extensions-CodeMirror: Incorrect syntax highlighting for: [https://example.com - https://phabricator.wikimedia.org/T185072 (10TheDJ) This is similar to {T185070} [22:07:05] (03PS1) 10QChris: Add .gitreview [extensions/WebDAVClientIntegration] - 10https://gerrit.wikimedia.org/r/503676 [22:07:07] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [extensions/WebDAVClientIntegration] - 10https://gerrit.wikimedia.org/r/503676 (owner: 10QChris) [22:11:18] (03PS1) 10QChris: Add .gitreview [extensions/WebDAVMinorSave] - 10https://gerrit.wikimedia.org/r/503677 [22:11:20] (03CR) 10QChris: [V: 03+2 C: 03+2] Add .gitreview [extensions/WebDAVMinorSave] - 10https://gerrit.wikimedia.org/r/503677 (owner: 10QChris) [22:16:51] 10MediaWiki-User-preferences, 10Browser-Support-Microsoft-Edge: Can't save preferences using microsoft edge - https://phabricator.wikimedia.org/T220706 (10Kipod) another user have copied the whole content of her console: ` JQMIGRATE: Migrate is installed with logging active, version 3.0.1 This page is usi... [22:25:31] 10MediaWiki-extensions-Score, 10Patch-For-Review: markup playback bar overlaps the staff - https://phabricator.wikimedia.org/T216305 (10Krinkle) The overlap appears be due to an overflow caused by the TimedMediaHandler player. The player is exceeding its own height and aligns to the bottom, causing the... [22:28:33] (03CR) 10Krinkle: [C: 03+2] "Would be nicer in a stylesheet, but there isn't currently one that loads as a page stylesheet (there is ext.score.popup but that is for ja" [extensions/Score] - 10https://gerrit.wikimedia.org/r/495882 (https://phabricator.wikimedia.org/T216305) (owner: 10Ebe123) [22:32:51] (03Merged) 10jenkins-bot: Add bottom margin to score images [extensions/Score] - 10https://gerrit.wikimedia.org/r/495882 (https://phabricator.wikimedia.org/T216305) (owner: 10Ebe123) [22:33:53] (03CR) 10jenkins-bot: Add bottom margin to score images [extensions/Score] - 10https://gerrit.wikimedia.org/r/495882 (https://phabricator.wikimedia.org/T216305) (owner: 10Ebe123) [22:37:02] 10MediaWiki-Export-or-Import, 10MediaWiki-History-and-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629 (10Tgr) Is this a duplicate of {T9240} (which is now fixed)? [22:37:14] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10ashley) Outside core user rights can and in many cases **do** exist without the corresponding `action-*` message, for the `action-*` mes... [22:43:07] 10MediaWiki-History-and-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994 (10Tgr) This task is a bit unfocused. Most of the discussion is about blame maps so maybe merge into {T2639}? [22:55:36] 10TechCom, 10TechCom-RFC: Establish Architecture Principles as a policy - https://phabricator.wikimedia.org/T220657 (10Tgr) >>! In T220657#5107914, @thiemowmde wrote: > I feel this needs to be a "SHOULD". There are certainly situations where it is not possible to "avoid" wikitext entirely. What situations are... [22:57:07] (03PS1) 10Krinkle: HistoryAction: Consider 'feed=' and 'feed=0' as invalid feed actions [core] - 10https://gerrit.wikimedia.org/r/503678 [22:57:09] (03PS1) 10Krinkle: changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 [22:57:39] (03PS2) 10Krinkle: changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 [22:59:12] 10Wikimedia-Site-requests, 10Patch-For-Review: en.wikiversity VisualEditor Changing Active Namespaces - https://phabricator.wikimedia.org/T220881 (10Zoranzoki21) a:05Zoranzoki21→03DannyS712 >>! In T220881#5109254, @DannyS712 wrote: >>>! In T220881#5109252, @Zoranzoki21 wrote: >> @DannyS712 No problem, if y... [22:59:17] 10TechCom, 10TechCom-RFC: Establish Architecture Principles as a policy - https://phabricator.wikimedia.org/T220657 (10Tgr) It would be useful to add something about who is expected to know / enforce the policy. This is a pretty heavy technical document; throwing it at new contributors is a good way of making... [23:01:54] 10MediaWiki-extensions-CodeMirror: CodeMirror: HTML comment before first pipe in template ends template highlighting - https://phabricator.wikimedia.org/T188305 (10TheDJ) This is due to the block ` if ( haveAte && stream.sol() ) { // @todo error message state.nTemplate--; state.tokenize = state.st... [23:03:23] 10MediaWiki-Core-Testing, 10I18n, 10MW-1.34-notes (1.34.0-wmf.1; 2019-04-16): Add test to check existence of action- messages - https://phabricator.wikimedia.org/T220779 (10Isarra) Another problem is if we pre-create these messages when they're not needed, if we do wind up needing them later, this will almos... [23:04:58] (03PS1) 10Krinkle: changes: Remove unused code from ChangesFeed.php [core] - 10https://gerrit.wikimedia.org/r/503681 [23:05:31] (03CR) 10Krinkle: "If indeed no longer needed, will add rel-notes and inform Wikitech-l per Deprecation policy." [core] - 10https://gerrit.wikimedia.org/r/503681 (owner: 10Krinkle) [23:08:00] 10MediaWiki-API, 10MediaWiki-History-and-Diffs: API for listing authors of an article - https://phabricator.wikimedia.org/T220893 (10Tgr) [23:10:50] 10MediaWiki-API, 10MediaWiki-History-and-Diffs: API for listing authors of an article - https://phabricator.wikimedia.org/T220893 (10Tgr) I imagine this would require a (page, actor) index on revision. `action=credit` is disabled on Wikimedia projects because without such an index `WikiPage::getContributors()`... [23:11:06] 10MediaWiki-API, 10MediaWiki-History-and-Diffs: API for listing authors of an article - https://phabricator.wikimedia.org/T220893 (10Tgr) [23:12:19] (03CR) 10Reedy: changes: Remove unused code from ChangesFeed.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503681 (owner: 10Krinkle) [23:12:55] 10MediaWiki-History-and-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994 (10Tgr) See also {T220893} which would accomplish this task as stated in the description (but not really stated the purpose of determining the princi... [23:13:00] (03PS2) 10Krinkle: changes: Remove unused code from ChangesFeed.php [core] - 10https://gerrit.wikimedia.org/r/503681 [23:16:32] (03CR) 10Reedy: [C: 03+2] HistoryAction: Consider 'feed=' and 'feed=0' as invalid feed actions [core] - 10https://gerrit.wikimedia.org/r/503678 (owner: 10Krinkle) [23:16:35] (03CR) 10Reedy: [C: 03+2] changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:19:31] (03CR) 10Reedy: [C: 04-1] changes: Split Feed.php into a class per file (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:20:36] (03PS3) 10Aaron Schulz: Refactor edit stashing into a PageEditStash service [core] - 10https://gerrit.wikimedia.org/r/503553 [23:22:26] (03PS1) 10Reedy: Remove ApiMessage from Generic.Files.OneObjectStructurePerFile.MultipleFound [core] - 10https://gerrit.wikimedia.org/r/503683 [23:23:56] (03CR) 10Gergő Tisza: "Pinning exact versions in the extension is actively harmful IMO as it goes against semver principles, increases the chance of bogus requir" [vendor] - 10https://gerrit.wikimedia.org/r/503148 (https://phabricator.wikimedia.org/T220720) (owner: 10Gergő Tisza) [23:26:27] (03PS3) 10TheDJ: Highlight match end tag with different capitalization [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/503671 (https://phabricator.wikimedia.org/T179321) [23:27:24] (03PS4) 10Aaron Schulz: Refactor edit stashing into a PageEditStash service [core] - 10https://gerrit.wikimedia.org/r/503553 [23:28:10] (03PS1) 10Reedy: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api [core] - 10https://gerrit.wikimedia.org/r/503684 [23:29:12] (03PS3) 10Reedy: changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:29:29] (03CR) 10Reedy: [C: 04-2] "Stop the merge..." [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:32:11] (03CR) 10Krinkle: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503684 (owner: 10Reedy) [23:32:32] (03Merged) 10jenkins-bot: HistoryAction: Consider 'feed=' and 'feed=0' as invalid feed actions [core] - 10https://gerrit.wikimedia.org/r/503678 (owner: 10Krinkle) [23:32:43] (03CR) 10Reedy: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503684 (owner: 10Reedy) [23:32:45] (03CR) 10Krinkle: "What happened?" [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:33:28] (03CR) 10Reedy: [C: 04-2] "It was still sitting in gate and submit, so just wanted to make sure it didn't submit PS2" [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:34:05] (03CR) 10Reedy: [C: 03+2] changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:34:22] (03PS2) 10Reedy: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api [core] - 10https://gerrit.wikimedia.org/r/503684 [23:35:31] (03CR) 10Krinkle: [C: 03+2] Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api [core] - 10https://gerrit.wikimedia.org/r/503684 (owner: 10Reedy) [23:35:33] (03CR) 10Krinkle: [C: 03+2] Remove ApiMessage from Generic.Files.OneObjectStructurePerFile.MultipleFound [core] - 10https://gerrit.wikimedia.org/r/503683 (owner: 10Reedy) [23:36:06] (03CR) 10jenkins-bot: HistoryAction: Consider 'feed=' and 'feed=0' as invalid feed actions [core] - 10https://gerrit.wikimedia.org/r/503678 (owner: 10Krinkle) [23:36:23] (03PS3) 10Krinkle: Split ApiImport.php to have one class in one file [core] - 10https://gerrit.wikimedia.org/r/501896 (owner: 10Zoranzoki21) [23:36:45] (03CR) 10Krinkle: [C: 03+1] "Retained file-level copyright annotation." [core] - 10https://gerrit.wikimedia.org/r/501896 (owner: 10Zoranzoki21) [23:37:58] 10MediaWiki-Special-pages, 10CheckUser, 10MW-1.33-notes (1.33.0-wmf.25; 2019-04-09), 10MW-1.33-release, 10Regression: Some special pages are not properly displaying parenthesis and other seperators around user links - https://phabricator.wikimedia.org/T220767 (10Xaosflux) Notes from enwiki discussion: @... [23:38:34] (03PS4) 10Zoranzoki21: Split ApiImport.php to have one class in one file [core] - 10https://gerrit.wikimedia.org/r/501896 [23:40:27] (03CR) 10jerkins-bot: [V: 04-1] Refactor edit stashing into a PageEditStash service [core] - 10https://gerrit.wikimedia.org/r/503553 (owner: 10Aaron Schulz) [23:41:02] (03CR) 10Reedy: "Seemingly caused T220767" [core] - 10https://gerrit.wikimedia.org/r/499364 (https://phabricator.wikimedia.org/T219348) (owner: 10Jdlrobson) [23:43:26] (03PS1) 10Aaron Schulz: parser: use "-" for revision ID for non-preview edit filter parse during save [core] - 10https://gerrit.wikimedia.org/r/503685 [23:43:30] Krinkle: ^ bingo? [23:44:24] AaronSchulz: Aha, makes sense indeed. [23:44:54] AaronSchulz: which graph do you see the regression on though? [23:44:59] (03PS1) 10Zoranzoki21: Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) [23:45:03] or does it not show on edit-stash dashboard? [23:45:24] (03PS5) 10Aaron Schulz: Refactor edit stashing into a PageEditStash service [core] - 10https://gerrit.wikimedia.org/r/503553 [23:45:57] Krinkle: the old code did that to [23:45:59] (03CR) 10jerkins-bot: [V: 04-1] Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) (owner: 10Zoranzoki21) [23:46:19] not sure if it was from mcr or older [23:46:35] AaronSchulz: ok, so the regression has been going for longer than just this past week [23:46:53] AaronSchulz: Would this be observable from a parser test? I guess not, right? [23:47:12] For the bug we fixed yesterday though, that'd be nice to have a test for if feasible. [23:47:37] (03PS2) 10Zoranzoki21: Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) [23:49:49] (03Merged) 10jenkins-bot: changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:49:54] (03Merged) 10jenkins-bot: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api [core] - 10https://gerrit.wikimedia.org/r/503684 (owner: 10Reedy) [23:49:56] (03CR) 10jerkins-bot: [V: 04-1] Remove ApiMessage from Generic.Files.OneObjectStructurePerFile.MultipleFound [core] - 10https://gerrit.wikimedia.org/r/503683 (owner: 10Reedy) [23:49:58] (03CR) 10jerkins-bot: [V: 04-1] Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) (owner: 10Zoranzoki21) [23:50:09] (03CR) 10Krinkle: [C: 03+1] parser: use "-" for revision ID for non-preview edit filter parse during save [core] - 10https://gerrit.wikimedia.org/r/503685 (owner: 10Aaron Schulz) [23:51:12] (03PS3) 10Zoranzoki21: Convert OnlineStatusBar to use extension registration [extensions/OnlineStatusBar] - 10https://gerrit.wikimedia.org/r/503686 (https://phabricator.wikimedia.org/T220014) [23:51:33] (03PS2) 10Reedy: Remove ApiMessage from Generic.Files.OneObjectStructurePerFile.MultipleFound [core] - 10https://gerrit.wikimedia.org/r/503683 [23:53:36] (03CR) 10jenkins-bot: changes: Split Feed.php into a class per file [core] - 10https://gerrit.wikimedia.org/r/503679 (owner: 10Krinkle) [23:54:37] (03CR) 10Krinkle: "Nice :)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/503553 (owner: 10Aaron Schulz) [23:55:58] (03CR) 10Krinkle: "A few early nits. Will review more thoroughly later. Don't expect much on the specific logic as it should be the same as before for the pu" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503553 (owner: 10Aaron Schulz) [23:56:38] (03CR) 10jenkins-bot: Fix a couple of Generic.Files.OneObjectStructurePerFile.MultipleFound in api [core] - 10https://gerrit.wikimedia.org/r/503684 (owner: 10Reedy) [23:56:42] (03CR) 10Krinkle: [C: 03+2] Remove ApiMessage from Generic.Files.OneObjectStructurePerFile.MultipleFound [core] - 10https://gerrit.wikimedia.org/r/503683 (owner: 10Reedy) [23:56:59] Krinkle: actually, it is recent, since it would only reparse if it guessed wrongly. It was/is still setting the speculative rev ID callback. [23:57:14] that might explain T220470 [23:57:14] T220470: Investigate backend save timing regression starting at 2019-04-08 19:15:00 - https://phabricator.wikimedia.org/T220470 [23:57:27] (03PS1) 10Zoranzoki21: Convert SpellingDictionary to use extension registration [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503687 [23:57:48] it would make it a little worse rather than better since it would go from 1-2 parses to always 2 parses. The fix should make it always 1. [23:58:58] (03CR) 10Zoranzoki21: [C: 04-1] Convert SpellingDictionary to use extension registration (031 comment) [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503687 (owner: 10Zoranzoki21) [23:59:04] (03CR) 10Aaron Schulz: Refactor edit stashing into a PageEditStash service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/503553 (owner: 10Aaron Schulz) [23:59:09] (03PS2) 10Zoranzoki21: Convert SpellingDictionary to use extension registration [extensions/SpellingDictionary] - 10https://gerrit.wikimedia.org/r/503687 (https://phabricator.wikimedia.org/T220015) [23:59:54] on enwiki, most guesses were probably misses, so it was moderately worse rather than massively so