[00:03:05] (03CR) 10jerkins-bot: [V: 04-1] Move maintenance script into separate folder [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 (owner: 10Umherirrender) [00:10:05] 10MediaWiki-Export-or-Import, 10MediaWiki-HTMLForm, 10UI-Standardization: Convert Special:Import to OOUI - https://phabricator.wikimedia.org/T108792 (10Volker_E) [00:11:39] 10MediaWiki-Uploading, 10UI-Standardization, 10Multimedia, 10Patch-For-Review: Convert Special:Upload to OOUI - https://phabricator.wikimedia.org/T213040 (10Volker_E) p:05Triage→03Normal [00:18:28] (03PS4) 10Esanders: SpecialPreferences: Use real OOUI PHP layouts [core] - 10https://gerrit.wikimedia.org/r/498406 [00:22:59] (03CR) 10Esanders: [C: 04-1] "We should merge then use the upstream commit" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/459533 (owner: 10Bartosz Dziewoński) [00:25:36] 10MediaWiki-jQuery-Tablesorter, 10Patch-For-Review, 10Performance: Table changes width after tablesorter initialises - https://phabricator.wikimedia.org/T218781 (10Esanders) I think a solution that results in FOUC in <10% of cases is better than one that results in a FOUC in 100% of cases. [00:32:56] (03CR) 10jerkins-bot: [V: 04-1] SpecialPreferences: Use real OOUI PHP layouts [core] - 10https://gerrit.wikimedia.org/r/498406 (owner: 10Esanders) [00:36:40] (03PS2) 10Esanders: TableSorter: Fix pre-JS selector to match wikitext-generated sortable tables [core] - 10https://gerrit.wikimedia.org/r/497769 (https://phabricator.wikimedia.org/T218781) [00:37:47] (03CR) 10MaxSem: "See https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/wikihiero/+/498303/" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 (owner: 10Umherirrender) [00:38:34] 10MediaWiki-jQuery-Tablesorter, 10Patch-For-Review, 10Performance: Table changes width after tablesorter initialises - https://phabricator.wikimedia.org/T218781 (10Esanders) Amended the selector to be limited to the first row. This will remove the icon from the H1/H2 second row headers in the first example,... [00:54:30] (03PS1) 10Isarra: Add a very stupid resume 'from' for the downloads themselves [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498687 [01:04:24] (03PS6) 10Legoktm: Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 [01:04:26] (03PS3) 10Legoktm: Fix PhanPluginDuplicateConditional* errors (#1) [core] - 10https://gerrit.wikimedia.org/r/498288 [01:04:28] (03PS3) 10Legoktm: Fix/suppress misc phan errors (#2) [core] - 10https://gerrit.wikimedia.org/r/498289 [01:04:30] (03PS3) 10Legoktm: Fix PhanUndeclaredType* errors (#3) [core] - 10https://gerrit.wikimedia.org/r/498290 [01:04:32] (03PS2) 10Legoktm: Fix/suppress misc phan errors (#4) [core] - 10https://gerrit.wikimedia.org/r/498305 [01:04:34] (03PS3) 10Legoktm: Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 [01:04:36] (03PS1) 10Legoktm: API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 [01:04:38] (03PS1) 10Legoktm: session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 [01:04:40] (03PS1) 10Legoktm: rdbms: Clean up MssqlBlob constructor [core] - 10https://gerrit.wikimedia.org/r/498690 [01:05:17] oh dang it's going to all fail [01:05:18] sigh [01:06:49] (03PS2) 10Legoktm: API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 [01:06:50] (03PS2) 10Legoktm: session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 [01:06:52] (03PS7) 10Legoktm: Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 [01:06:55] (03PS4) 10Legoktm: Fix PhanPluginDuplicateConditional* errors (#1) [core] - 10https://gerrit.wikimedia.org/r/498288 [01:06:57] (03PS4) 10Legoktm: Fix/suppress misc phan errors (#2) [core] - 10https://gerrit.wikimedia.org/r/498289 [01:06:59] (03PS4) 10Legoktm: Fix PhanUndeclaredType* errors (#3) [core] - 10https://gerrit.wikimedia.org/r/498290 [01:07:01] (03PS3) 10Legoktm: Fix/suppress misc phan errors (#4) [core] - 10https://gerrit.wikimedia.org/r/498305 [01:07:03] (03PS2) 10Legoktm: rdbms: Clean up MssqlBlob constructor [core] - 10https://gerrit.wikimedia.org/r/498690 [01:07:05] (03PS4) 10Legoktm: Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 [01:11:58] (03CR) 10MaxSem: [C: 03+2] API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 (owner: 10Legoktm) [01:12:59] (03CR) 10MaxSem: [C: 03+2] session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 (owner: 10Legoktm) [01:16:50] (03PS5) 10Legoktm: Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 [01:23:48] 10CommRel-Specialists-Support (Jan-Mar-2019), 10Growth-Team (Current Sprint): Welcome survey: investigate Vietnamese abandonment rate - https://phabricator.wikimedia.org/T216668 (10Urbanecm) >>! In T216668#4990732, @Trizek-WMF wrote: > @Tuanminh01 reports [[ https://vi.wikipedia.org/w/index.php?title=%C4%90%E1... [01:27:51] 10Graphs, 10Mobile, 10Readers-Web-Backlog (Tracking): Graphs create img tags without width and height - https://phabricator.wikimedia.org/T216431 (10RobinLeicester) Is there any progress on this? It blanks out all lazy-loaded maps dependent on 'Graph:street map with marks', as well as other graph images. I t... [01:39:56] (03CR) 10jerkins-bot: [V: 04-1] Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [01:40:07] (03CR) 10jerkins-bot: [V: 04-1] Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [01:40:09] (03CR) 10jerkins-bot: [V: 04-1] Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [01:40:43] (03CR) 10jerkins-bot: [V: 04-1] API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 (owner: 10Legoktm) [01:40:48] (03CR) 10jerkins-bot: [V: 04-1] session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 (owner: 10Legoktm) [01:41:34] eh [01:41:44] I'm disabling that crap [01:49:09] Also, my git pull hangs again [01:50:03] Fucking Windoze [01:50:55] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) [01:51:12] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) ===__Test Result... [01:53:30] (03PS1) 10MaxSem: Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) [01:53:36] legoktm: ^ [01:55:18] (03CR) 10Legoktm: [C: 03+2] Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [01:55:20] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#2) [core] - 10https://gerrit.wikimedia.org/r/498289 (owner: 10Legoktm) [01:59:39] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) [02:00:56] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 (owner: 10Legoktm) [02:09:16] (03Merged) 10jenkins-bot: Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [02:09:47] (03CR) 10MaxSem: [C: 03+2] API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 (owner: 10Legoktm) [02:10:04] (03CR) 10MaxSem: [C: 03+2] "recheck" [core] - 10https://gerrit.wikimedia.org/r/498689 (owner: 10Legoktm) [02:10:26] (03CR) 10MaxSem: [C: 03+2] Upgrade to newer phan (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [02:17:56] \o/ [02:18:11] soooo many errors to fix now :( [02:18:14] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) [02:23:03] (03Merged) 10jenkins-bot: API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 (owner: 10Legoktm) [02:23:37] 10Nostalgia: Nostalgia wiki shouldn't use the new style Special:UserLogin - https://phabricator.wikimedia.org/T67342 (10MaxSem) 05Open→03Declined Nostalgia is a skin, not all-encompassing interface for MediaWiki. Login pages are not part of skins, so while it's understandable to want look & feel of 18 years... [02:24:10] (03PS1) 10MaxSem: Fix deprecation warnings [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/498693 [02:25:10] (03Merged) 10jenkins-bot: session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 (owner: 10Legoktm) [02:25:19] (03Merged) 10jenkins-bot: Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [02:26:58] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#2) [core] - 10https://gerrit.wikimedia.org/r/498289 (owner: 10Legoktm) [02:27:45] (03CR) 10jerkins-bot: [V: 04-1] Fix deprecation warnings [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/498693 (owner: 10MaxSem) [02:28:19] (03CR) 10Legoktm: "This is going to be stuck until Change-Id: I590fd269525cb61c672d1dbb172a01cfc6d4f08f in codesniffer is merged + released." [core] - 10https://gerrit.wikimedia.org/r/498289 (owner: 10Legoktm) [02:30:06] (03CR) 10Legoktm: [C: 03+2] Add PLURAL for files message [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/486487 (owner: 10Samwilson) [02:30:29] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#2) [core] - 10https://gerrit.wikimedia.org/r/498289 (owner: 10Legoktm) [02:32:20] (03CR) 10MaxSem: [C: 03+2] Fix PhanPluginDuplicateConditional* errors (#1) [core] - 10https://gerrit.wikimedia.org/r/498288 (owner: 10Legoktm) [02:32:44] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) [02:34:22] (03CR) 10MaxSem: "Lol, Phan and PHPCS are fighting." [core] - 10https://gerrit.wikimedia.org/r/498289 (owner: 10Legoktm) [02:34:44] (03Merged) 10jenkins-bot: Add PLURAL for files message [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/486487 (owner: 10Samwilson) [02:40:12] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC: add history link to actions menu - https://phabricator.wikimedia.org/T213352 (10Edtadros) a:05Edtadros→... [02:41:35] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 (owner: 10Legoktm) [02:43:23] (03CR) 10jerkins-bot: [V: 04-1] Fix/suppress misc phan errors (#5) [core] - 10https://gerrit.wikimedia.org/r/498310 (owner: 10Legoktm) [02:43:40] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias - https://phabricator.wikimedia.org/T217643 (10Edtadros) [02:47:30] (03Merged) 10jenkins-bot: Fix PhanPluginDuplicateConditional* errors (#1) [core] - 10https://gerrit.wikimedia.org/r/498288 (owner: 10Legoktm) [02:47:35] (03CR) 10jenkins-bot: Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [02:47:49] (03CR) 10jenkins-bot: Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [02:48:07] (03CR) 10jenkins-bot: Disable flapping MessageCacheTest::testLoadFromDB_fetchLatestRevision() [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [02:49:21] (03CR) 10jenkins-bot: API: Fix missing return in ApiResult::addContentValue() [core] - 10https://gerrit.wikimedia.org/r/498688 (owner: 10Legoktm) [02:50:30] (03CR) 10jenkins-bot: session: Fix missing return in SessionBackend::resetId() [core] - 10https://gerrit.wikimedia.org/r/498689 (owner: 10Legoktm) [02:51:46] (03CR) 10jenkins-bot: Upgrade to newer phan [core] - 10https://gerrit.wikimedia.org/r/498269 (owner: 10Legoktm) [02:52:56] (03CR) 10jenkins-bot: Fix PhanPluginDuplicateConditional* errors (#1) [core] - 10https://gerrit.wikimedia.org/r/498288 (owner: 10Legoktm) [02:59:28] (03PS1) 10Isarra: Add some checks to make sure we're not RANDOMLY GETTING LOGGED OUT [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 [03:09:22] (03PS1) 10Aaron Schulz: Fix overzealous prefix check in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/498695 [03:09:27] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Add talk button to AMC main page - https://phabricator.wikimedia.org/T216514 (10Edtadros) ===__Test Results: Pr... [03:09:50] MaxSem: https://gerrit.wikimedia.org/r/498695 [03:11:06] (03CR) 10MaxSem: [C: 03+2] Fix overzealous prefix check in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/498695 (owner: 10Aaron Schulz) [03:18:15] 10LDAP-Access-Requests: Add legoktm to gerritadmin LDAP group (restoring previously held access) - https://phabricator.wikimedia.org/T219086 (10Legoktm) [03:19:54] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Add talk button to AMC main page - https://phabricator.wikimedia.org/T216514 (10Edtadros) @ovasileva I only tes... [03:22:42] 10MediaWiki-Gerrit-Group-Requests: +2 in mediawiki/* for WMDE engineers - https://phabricator.wikimedia.org/T218135 (10Legoktm) Thanks @daniel. So I created a `wmde-mediawiki` group (https://gerrit.wikimedia.org/r/admin/groups/1597) with everyone listed except for Jeroen. But... due to recent permissions shuffle... [03:25:54] (03Merged) 10jenkins-bot: Fix overzealous prefix check in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/498695 (owner: 10Aaron Schulz) [03:28:24] (03CR) 10jenkins-bot: Fix overzealous prefix check in MWLBFactory [core] - 10https://gerrit.wikimedia.org/r/498695 (owner: 10Aaron Schulz) [03:39:54] 10MediaWiki-Codesniffer, 10MediaWiki-Documentation, 10Documentation, 10Patch-For-Review, 10Upstream: Doxygen doesn't handle `@inheritDoc` by default, only `@inheritdoc` - https://phabricator.wikimedia.org/T219001 (10Legoktm) Filed an issue upstream for #3: https://github.com/doxygen/doxygen/issues/6900 [03:40:13] 10MediaWiki-Documentation, 10Documentation, 10Upstream: Doxygen method docs are not inherited (only when abstract classes are involved?) - https://phabricator.wikimedia.org/T152478 (10Legoktm) [03:40:27] 10UI-Standardization, 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), and 3 others: AMC page/talk toggle v1: Talk tab at the top of page for AMC users - https://phabricator.wikimedia.org/T212216 (10Edtadros) [03:45:37] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias - https://phabricator.wikimedia.org/T217643 (10Edtadros) [03:54:15] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Build AMC opt-in toggle - https://phabricator.wikimedia.org/T211197 (10Edtadros) [03:55:17] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Build AMC opt-in toggle - https://phabricator.wikimedia.org/T211197 (10Edtadros) [03:55:49] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Build AMC opt-in toggle - https://phabricator.wikimedia.org/T211197 (10Edtadros) [04:00:25] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias - https://phabricator.wikimedia.org/T217643 (10Edtadros) ==AMC: add history link to actions menu T213352 == QA Results : Product... [04:13:04] 10Advanced Mobile Contributions, 10Audiences-QA (RW-Test-Cases), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Add talk button to AMC main page - https://phabricator.wikimedia.org/T216514 (10Edtadros) [04:13:43] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias - https://phabricator.wikimedia.org/T217643 (10Edtadros) ==Add talk button to AMC main page T216514 == QA Results: Production | *... [04:14:37] 10Advanced Mobile Contributions, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy AMC pt 1 to Arabic, Indonesian, and Spanish Wikipedias - https://phabricator.wikimedia.org/T217643 (10Edtadros) [04:38:54] (03PS5) 10Nikitrain: HISTORY: Add MediaWiki 1.11 post-release change notes [core] - 10https://gerrit.wikimedia.org/r/497821 [04:39:36] (03PS3) 10Nikitrain: HISTORY: Add MediaWiki 1.19 post-release change notes [core] - 10https://gerrit.wikimedia.org/r/498527 [04:40:18] (03PS2) 10Nikitrain: HISTORY: Add MediaWiki 1.18 post-release change notes [core] - 10https://gerrit.wikimedia.org/r/498526 [04:40:42] (03PS3) 10Nikitrain: HISTORY: Add MediaWiki 1.12 post-release change notes [core] - 10https://gerrit.wikimedia.org/r/498010 [05:01:49] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Batoulkh12) @Mansi29ag hi .. thank u for ur reply yes i edit the parameter but i dont know what i should put in the 'to' parameter .. i put (to :all)... [05:14:36] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Supida_h) @Batoulkh12 ` 'to'` is the language that English article get translated to. Like in the example, `'from':'en', 'to':'es'` Is to find data... [05:24:23] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Batoulkh12) @Supida_h hi thank u for ur help yes i know that 'to ' is the target language and i used it( from :en to :ar ) to get the articles trans... [05:49:48] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Mansi29ag) @Batoulkh12 I don't know that you can get this information from the api. But this : https://en.wikipedia.org/wiki/Special:ContentTranslatio... [05:59:53] 10Outreachy (Round 18): Proposal: Improving documentation of ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T218487 (10Eisheeta) [06:03:59] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Muraran) Hello Issac, Thank you for your reply. However JSON is new for me. I am not sure what you mean. I am still fighting with JSON .... Thanks fo... [06:16:30] (03PS2) 10Isarra: Add some checks to make sure we're not RANDOMLY GETTING LOGGED OUT [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 [06:17:32] (03CR) 10Isarra: "...what is coding style. I have lost my mind and cannot think." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 (owner: 10Isarra) [07:15:49] 10MediaWiki-JobQueue: JobQueue not working with certain config ($wgLocalDatabases set to the default value of an empty array()) - https://phabricator.wikimedia.org/T193832 (10aaron) 05duplicate→03Open Code should always handle the current wiki (e.g. wfWikiId/$wgDBname) case and not require it to be set in $w... [07:33:07] 10MediaWiki-Database, 10MW-1.33-notes (1.33.0-wmf.23; 2019-03-26), 10Patch-For-Review: LoadBalancer.php uses $wgDBname even though $wgDBservers is defined - https://phabricator.wikimedia.org/T215850 (10aaron) You can even just omit the dbname from $wgDBservers. That is also a cleaner config for wiki farms. T... [07:40:49] (03PS3) 10Aaron Schulz: objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 [07:40:51] (03PS10) 10Aaron Schulz: objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 (https://phabricator.wikimedia.org/T204742) [07:45:34] 10MediaWiki-JobQueue: JobQueue not working with certain config ($wgLocalDatabases set to the default value of an empty array()) - https://phabricator.wikimedia.org/T193832 (10Peachey88) [07:58:39] (03CR) 10MaxSem: [C: 03+2] Correctly escape numerical options and improve SQL construction [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/490511 (owner: 10Samwilson) [08:02:15] (03Merged) 10jenkins-bot: Correctly escape numerical options and improve SQL construction [extensions/WikiCategoryTagCloud] - 10https://gerrit.wikimedia.org/r/490511 (owner: 10Samwilson) [08:03:57] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Quantitative Exploration of Content Translation Tools - https://phabricator.wikimedia.org/T218004 (10Trishla08) @Issac hi! I am an Outreachy applicant and have been working on the quantitative analysis task. I'd really like for someone to look at my w... [08:21:47] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Batoulkh12) kindly may somebody help me how can i get the entire information for the translated articles , i need the category , readers , article e... [08:23:45] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Better understand impact of content translation tools - https://phabricator.wikimedia.org/T217699 (10Batoulkh12) >>! In T217699#5051449, @Mansi29ag wrote: > @Batoulkh12 I don't know that you can get this information from the api. But this : https://en... [08:31:32] 10WMSE-Riksarkivet-TORA: Jämföra Wikidata <-> Kulturnav - https://phabricator.wikimedia.org/T218644 (10Salgo60) [08:35:23] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [08:43:44] 10MediaWiki-Cache, 10MediaWiki-Core-Testing, 10Patch-For-Review: Flaky test MessageCacheTest::testLoadFromDB_fetchLatestRevision - https://phabricator.wikimedia.org/T219042 (10D3r1ck01) p:05Triage→03Low [08:44:34] (03CR) 10D3r1ck01: "Thank you @MaxSem!" [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [08:44:57] (03CR) 10D3r1ck01: "And @Lego for landing :)" [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [08:46:49] (03CR) 10D3r1ck01: [C: 03+2] "Has been disabled: I93ed4d088691bfc50ae, repoking Jenkins." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [08:49:23] (03PS1) 10Umherirrender: Update tests to match parser changes [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498701 (https://phabricator.wikimedia.org/T208070) [08:50:03] (03PS2) 10Umherirrender: Move maintenance script into separate folder [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 [08:50:26] (03CR) 10Umherirrender: "I have fixed the parser tests in a own patch set to link to the bug - If7afd42f7ddd8beb96ec528e6c117b41f21a4939" [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 (owner: 10Umherirrender) [08:51:05] (03CR) 10D3r1ck01: [C: 03+1] Add instanceof checks when a specific implementation is needed (031 comment) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/498222 (owner: 10Legoktm) [08:51:16] (03CR) 10D3r1ck01: [C: 03+2] Add instanceof checks when a specific implementation is needed [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/498222 (owner: 10Legoktm) [08:58:09] (03CR) 10D3r1ck01: [C: 03+1] "Nice!" [core] - 10https://gerrit.wikimedia.org/r/498690 (owner: 10Legoktm) [08:58:17] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated LinkCache::singleton() method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [09:03:03] (03CR) 10D3r1ck01: [C: 03+2] Move file to match class name (032 comments) [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/498679 (owner: 10Umherirrender) [09:07:23] (03Merged) 10jenkins-bot: Move file to match class name [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/498679 (owner: 10Umherirrender) [09:09:28] (03CR) 10jenkins-bot: Move file to match class name [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/498679 (owner: 10Umherirrender) [09:19:37] 10Library-Card-Platform, 10good first bug: Improve user experience for closed partnerships - https://phabricator.wikimedia.org/T212767 (10Shivanshbindal9) Hi @Samwalton9, I will like to work on this. Can you please tell me where to start from ? Thanks :) [09:34:51] 10WMSE-Riksarkivet-TORA: Jämföra Wikidata <-> Kulturnav - https://phabricator.wikimedia.org/T218644 (10Salgo60) Jämför hur WIkidata en hobby släktforskningsite jmf 20 miljoner profiler varje vecka med ca. 200 regler * Wikipedia [[ https://sv.wikipedia.org/wiki/Margareta_Eriksdotter_(Leijonhufvud) | Margareta Er... [09:37:17] (03PS5) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [09:43:46] (03CR) 10Fomafix: "The root cause is the Firefox config parameter" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/421349 (https://phabricator.wikimedia.org/T177509) (owner: 10Niharika29) [09:57:38] (03PS58) 10Daimona Eaytoy: [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) [09:58:31] (03PS5) 10Daimona Eaytoy: Add the abuse_filter_stats table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) [09:59:24] 10MediaWiki-Page-editing, 10Wikimedia-General-or-Unknown: Fawiki article cannot be edited: "Service Temporarily Unavailable" timeout upon saving at API execution limit (200 seconds) - https://phabricator.wikimedia.org/T212830 (10Daimona) @Huji Actually, another idea came to mind. You may use `new_html` and che... [10:00:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Add delimiters to preg_match (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/496611 (owner: 10Umherirrender) [10:01:10] (03PS59) 10Daimona Eaytoy: [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) [10:05:14] (03CR) 10Daimona Eaytoy: [C: 04-1] "(Copying unaddressed comments, +something new)" (038 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [10:06:31] (03CR) 10Daimona Eaytoy: [C: 04-1] ">" (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [10:12:01] (03PS3) 10Umherirrender: Rename tests/phan/stubs in dir list to new location [tools/phan] - 10https://gerrit.wikimedia.org/r/497130 [10:12:26] (03CR) 10Umherirrender: Rename tests/phan/stubs in dir list to new location (031 comment) [tools/phan] - 10https://gerrit.wikimedia.org/r/497130 (owner: 10Umherirrender) [10:17:05] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [10:24:20] 10MediaWiki-extensions-OpenStackManager, 10Cloud-VPS, 10LDAP, 10cloud-services-team (Kanban): cn=proxyagent,ou=profile,dc=wikimedia,dc=org should probably not allow unindexed searches - https://phabricator.wikimedia.org/T73130 (10GTirloni) [10:26:19] 10MediaWiki-extensions-OpenStackManager, 10Cloud-VPS, 10cloud-services-team (Kanban): novainstances API: 'niregion' parameter should be optional and/or discoverable - https://phabricator.wikimedia.org/T94514 (10GTirloni) [10:29:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [10:48:28] 10LDAP, 10Patch-For-Review: Put our ldap servers behind LVS - https://phabricator.wikimedia.org/T218133 (10GTirloni) [10:52:31] (03PS3) 10Alaa Sarhan: shorten score line width on wikidata [extensions/Score] - 10https://gerrit.wikimedia.org/r/498094 (https://phabricator.wikimedia.org/T218191) [10:55:41] 10UniversalLanguageSelector: A Glagolitic web font is needed - https://phabricator.wikimedia.org/T52899 (10Vladis13) Glagolitic is in the font 'Menaion', it requested in T219065. [10:57:29] 10Outreachy (Round 18): Proposal: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki, Outreachy 18. - https://phabricator.wikimedia.org/T218015 (10Nikitrain) [11:03:04] (03PS1) 10Thiemo Kreuz (WMDE): Fix broken error message with Message::newFromSpecifier() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498705 [11:03:43] 10Design, 10Toolforge, 10cloud-services-team (Kanban), 10good first bug: Make Toolforge main page mobile-friendly - https://phabricator.wikimedia.org/T194943 (10GTirloni) [11:04:19] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the list() syntax where it makes sense [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498706 [11:05:30] (03PS1) 10Thiemo Kreuz (WMDE): Remove unused parameter from method call [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498707 [11:13:00] 10AbuseFilter: Runtime profiling shouldn't include time taken to parse wikitext - https://phabricator.wikimedia.org/T219092 (10Daimona) [11:16:20] (03PS1) 10Thiemo Kreuz (WMDE): Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 [11:19:26] (03PS1) 10Thiemo Kreuz (WMDE): Add inline SplFileInfo type hints to iterators [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498709 [11:22:01] (03PS1) 10Thiemo Kreuz (WMDE): Fix broken check for if ( count() ) with no comparison [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498710 [11:24:16] (03PS1) 10Thiemo Kreuz (WMDE): Make use of shorter syntax features where possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498711 [11:25:49] 10LDAP-Access-Requests: Add legoktm to gerritadmin LDAP group (restoring previously held access) - https://phabricator.wikimedia.org/T219086 (10MarcoAurelio) +1. You shouldn't have been removed in the first place though. [11:25:50] (03PS1) 10Thiemo Kreuz (WMDE): Do not document constants as variables [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498712 [11:27:01] (03PS1) 10Thiemo Kreuz (WMDE): Make use of WebRequest::getCheck() where possible [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498713 [11:28:28] 10Outreachy (Round 18): Proposal: Improving documentation of ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T218487 (10Eisheeta) [11:29:38] 10Outreachy (Round 18): Proposal: Improving documentation of ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T218487 (10Eisheeta) [11:33:37] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498710 (owner: 10Thiemo Kreuz (WMDE)) [11:42:57] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498709 (owner: 10Thiemo Kreuz (WMDE)) [11:47:03] (03PS1) 10ArielGlenn: make xml abstracts, stubs and page log dumps work again [core] - 10https://gerrit.wikimedia.org/r/498716 (https://phabricator.wikimedia.org/T174031) [11:52:31] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_geo_Coordinate_proximity_boost, clean_highlighting_api_insource_regex_ins" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [12:03:13] 10MediaWiki-extensions-OpenStackManager, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Developer account creation without OpenStackManager - https://phabricator.wikimedia.org/T196171 (10GTirloni) [12:03:23] 10MediaWiki-extensions-OpenStackManager, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Review (and remove?) use of 'shell user' right on wikitech - https://phabricator.wikimedia.org/T196466 (10GTirloni) [12:04:57] 10MediaWiki-extensions-OATHAuth, 10Striker, 10wikitech.wikimedia.org, 10cloud-services-team (Kanban): Wikitech 2FA does not appear to allow recovery with scratch codes - https://phabricator.wikimedia.org/T204682 (10GTirloni) [12:09:57] 10Phabricator, 10Security-Team, 10Striker, 10Patch-For-Review, 10cloud-services-team (Kanban): Unable to mirror repository from git.legoktm.com into diffusion - https://phabricator.wikimedia.org/T143969 (10GTirloni) [12:10:32] 10MediaWiki-extensions-OpenStackManager, 10Striker, 10cloud-services-team (Kanban): Prevent empty service groups - https://phabricator.wikimedia.org/T120022 (10GTirloni) [12:11:51] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498713 (owner: 10Thiemo Kreuz (WMDE)) [12:16:48] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [12:17:56] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [12:21:04] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498711 (owner: 10Thiemo Kreuz (WMDE)) [12:26:23] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [12:30:25] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498712 (owner: 10Thiemo Kreuz (WMDE)) [12:37:23] (03PS6) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [12:41:25] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [12:43:48] (03PS6) 10Daimona Eaytoy: Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 [12:49:46] (03PS18) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [12:50:30] (03PS15) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [12:53:22] (03PS15) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [12:54:55] 10Outreachy (Round 18): Outreachy Round 18 Proposal: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T218516 (10srishakatux) @Areefa I've read your proposal, and it looks good to me. Totally optional: you could include in your propos... [12:55:44] (03PS14) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [12:56:08] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [12:56:22] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [12:56:42] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:00:04] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:00:06] (03PS29) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [13:00:16] (03PS25) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [13:00:22] (03PS23) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [13:00:27] (03PS23) 10Daimona Eaytoy: Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 [13:01:15] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 2 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (101997kB) @Daimona Should we close this? That patch has been merged and looks like... [13:02:09] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:08:39] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 2 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10MarcoAurelio) https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilte... [13:12:20] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 2 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Daimona) @1997kB: @MarcoAurelio is correct. If what you said is actually true, i... [13:14:07] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:14:09] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:14:22] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:14:42] 10MediaWiki-Recent-changes, 10Growth-Team: List recent changes to pages marked as part of a WikiProject - https://phabricator.wikimedia.org/T219073 (10Sophivorus) Sure, [[ https://es.wikipedia.org/wiki/Wikiproyecto:Filosof%C3%ADa/demo | here is a demo ]]! This request has little/nothing to do with displaying... [13:15:14] (03PS73) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [13:17:46] (03PS15) 10Daimona Eaytoy: Don't run filters with null title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) [13:19:14] (03PS7) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [13:19:21] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [13:19:23] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [13:19:25] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [13:19:27] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [13:19:29] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [13:19:31] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [13:20:57] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 2 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (101997kB) Mistakenly checked that earlier gerrit link and thought it's no more hap... [13:22:56] 10MediaWiki-extensions-CentralAuth, 10AbuseFilter, 10GlobalRename, 10Stewards-and-global-tools, and 2 others: Do not block page moves with AbuseFilter on LocalRenameJob page moves - https://phabricator.wikimedia.org/T212082 (10Daimona) @1997kB Heh, no problem :) @Legoktm Could you please take a look at htt... [13:24:00] 10MediaWiki-Recent-changes, 10Growth-Team: List recent changes to pages marked as part of a WikiProject - https://phabricator.wikimedia.org/T219073 (10Sophivorus) [13:25:47] 10MediaWiki-Recent-changes, 10Growth-Team: List recent changes to pages marked as part of a WikiProject - https://phabricator.wikimedia.org/T219073 (10Sophivorus) [13:29:55] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Growth-Team, 10Stewards-and-global-tools, and 2 others: When a page move is triggered by RenameUserJob, page should be moved anyways even if it is a Flow board - https://phabricator.wikimedia.org/T150572 (101997kB) Don't know how frequent this needs hap... [13:32:37] (03CR) 10jerkins-bot: [V: 04-1] Don't run filters with null title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [13:33:09] (03CR) 10Daimona Eaytoy: [V: 03+2] "Per commit message" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464119 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [13:34:57] (03PS7) 10Daimona Eaytoy: Remove log_ids meta-variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482418 [13:37:34] (03PS19) 10Daimona Eaytoy: [WIP] Add a maintenance script to clean afl_var_dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482499 (https://phabricator.wikimedia.org/T213006) [13:37:47] (03PS16) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [13:37:53] (03PS16) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [13:37:58] (03PS15) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [13:42:58] (03PS30) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [13:43:19] (03PS26) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [13:43:32] (03PS24) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [13:43:39] (03PS24) 10Daimona Eaytoy: Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 [13:44:13] 10WMSE-Riksarkivet-TORA: SKBL <-> KARP Svenskt kvinnobiografiskt lexikon - https://phabricator.wikimedia.org/T218782 (10Salgo60) [13:49:52] (03PS74) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [13:50:32] (03PS13) 10Daimona Eaytoy: Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 [13:53:28] (03PS24) 10Daimona Eaytoy: Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 [13:55:41] (03PS29) 10Daimona Eaytoy: [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 [13:57:13] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [13:57:54] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [13:58:13] (03PS1) 10Thiemo Kreuz (WMDE): api: Add missing limit to explode() of "continue" parameters [core] - 10https://gerrit.wikimedia.org/r/498717 [13:59:39] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [14:02:04] (03PS1) 10Thiemo Kreuz (WMDE): api: Remove possibly expensive explode() with 1 element only [core] - 10https://gerrit.wikimedia.org/r/498718 [14:03:26] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [14:03:55] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [14:04:34] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [14:05:04] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [14:06:27] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the list() feature where it makes sense [core] - 10https://gerrit.wikimedia.org/r/498719 [14:07:44] (03PS1) 10Thiemo Kreuz (WMDE): Update some minor type hints [core] - 10https://gerrit.wikimedia.org/r/498720 [14:08:23] 10MediaWiki-Recent-changes, 10Growth-Team: List recent changes to pages marked as part of a WikiProject - https://phabricator.wikimedia.org/T219073 (10Aklapper) How do you add talk pages to a category without adding the corresponding content page also to the category? [14:09:22] 10MediaWiki-extensions-Cargo, 10Patch-For-Review: Cargo: Dynamic tables - |order by= property ignored & UNIQ-QINU with |details fields= property - https://phabricator.wikimedia.org/T218066 (10Madrigal84) @Nikhil-nk I have followed these instructions but still get the same UNIQ-QINU error: //no html - specif... [14:10:01] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_update_Deleted_pages_are_removed_from_the_index" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [14:11:32] (03PS17) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [14:16:08] (03CR) 10Huji: [C: 03+2] Remove $wgAbuseFilterProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486279 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [14:16:42] (03CR) 10Huji: [C: 03+2] Remove $wgAbuseFilterRuntimeProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486469 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [14:20:23] (03PS31) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [14:20:31] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [14:20:33] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [14:20:35] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [14:20:37] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [14:20:39] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [14:20:41] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [14:20:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [14:20:45] (03PS27) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [14:20:47] (03PS25) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [14:20:49] (03PS25) 10Daimona Eaytoy: Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 [14:22:32] (03PS75) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [14:22:33] (03PS14) 10Daimona Eaytoy: Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 [14:22:48] (03PS30) 10Daimona Eaytoy: [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 [14:23:00] (03PS25) 10Daimona Eaytoy: Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 [14:24:12] (03CR) 10D3r1ck01: "> Note this breaks compatibility with all older versions of the CentralAuth extension." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/498451 (owner: 10D3r1ck01) [14:25:37] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [14:28:31] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [14:28:37] (03Merged) 10jenkins-bot: Remove $wgAbuseFilterProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486279 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [14:29:21] (03Merged) 10jenkins-bot: Remove $wgAbuseFilterRuntimeProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486469 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [14:31:25] 10AbuseFilter, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable wgAbuseFilterNotificationsPrivate on commons.wikimedia.org - https://phabricator.wikimedia.org/T218527 (10Daimona) @MusikAnimal I'll take care of it. [[https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=1820910&oldid=1820882|... [14:34:57] 10MediaWiki-Recent-changes, 10Growth-Team: List recent changes to pages marked as part of a WikiProject - https://phabricator.wikimedia.org/T219073 (10Sophivorus) I'm not sure I understand your question. Adding a talk page to a category does not cause or imply that the content page will be added too. [14:35:00] (03CR) 10D3r1ck01: "Thanks for your reviews @Pmiazga, I've made the revision to the patch!" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/496236 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [14:35:28] (03PS9) 10D3r1ck01: api: Start using MediaWikiServices for MobileContext class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/496236 (https://phabricator.wikimedia.org/T218244) [14:36:13] (03CR) 10D3r1ck01: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [14:38:25] (03PS32) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [14:38:32] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [14:38:34] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [14:38:36] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [14:38:38] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [14:38:40] (03CR) 10jerkins-bot: [V: 04-1] Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 (owner: 10Daimona Eaytoy) [14:38:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [14:38:44] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [14:38:46] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [14:38:48] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [14:38:50] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [14:38:53] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [14:38:54] (03CR) 10jerkins-bot: [V: 04-1] Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 (owner: 10Daimona Eaytoy) [14:38:56] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [14:38:59] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [14:39:01] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [14:40:11] (03PS18) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [14:40:22] (03PS17) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [14:42:29] (03PS16) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [14:42:45] (03PS28) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [14:42:51] (03PS26) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [14:42:56] (03PS26) 10Daimona Eaytoy: Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 [14:44:42] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "\o/" [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498659 (owner: 10Isarra) [14:45:02] (03PS76) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [14:45:24] (03PS15) 10Daimona Eaytoy: Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 [14:45:29] (03PS26) 10Daimona Eaytoy: Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 [14:45:45] (03PS31) 10Daimona Eaytoy: [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 [14:46:03] (03CR) 10Daimona Eaytoy: [C: 04-2] "Not yet." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:01:37] (03CR) 10jerkins-bot: [V: 04-1] api: Start using MediaWikiServices for MobileContext class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/496236 (https://phabricator.wikimedia.org/T218244) (owner: 10D3r1ck01) [15:03:46] (03PS33) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [15:03:54] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [15:03:56] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [15:03:58] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [15:04:00] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [15:04:02] (03CR) 10jerkins-bot: [V: 04-1] Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 (owner: 10Daimona Eaytoy) [15:04:04] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [15:04:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [15:04:08] (03CR) 10jerkins-bot: [V: 04-1] Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 (owner: 10Daimona Eaytoy) [15:04:10] (03CR) 10jerkins-bot: [V: 04-1] Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 (owner: 10Daimona Eaytoy) [15:04:12] (03CR) 10jerkins-bot: [V: 04-1] Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 (owner: 10Daimona Eaytoy) [15:04:14] (03CR) 10jerkins-bot: [V: 04-1] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [15:04:16] (03CR) 10jerkins-bot: [V: 04-1] Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 (owner: 10Daimona Eaytoy) [15:04:18] (03CR) 10jerkins-bot: [V: 04-1] Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 (owner: 10Daimona Eaytoy) [15:04:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 (owner: 10Daimona Eaytoy) [15:04:32] (03PS29) 10Daimona Eaytoy: Enforce saving of full abuse_filter row in cache [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486726 [15:04:40] (03PS27) 10Daimona Eaytoy: Rename the filterAction hook and add a parameter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486802 [15:04:45] (03PS27) 10Daimona Eaytoy: Deprecate the AbuseFilter-filterAction hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486804 [15:07:00] (03PS10) 10D3r1ck01: api: Start using MediaWikiServices for MobileContext class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/496236 (https://phabricator.wikimedia.org/T218244) [15:07:05] (03PS77) 10Daimona Eaytoy: Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [15:07:24] (03PS32) 10Daimona Eaytoy: [WIP] Add a new class representing single filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/480069 [15:07:35] (03PS16) 10Daimona Eaytoy: Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 [15:07:43] (03PS27) 10Daimona Eaytoy: Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 [15:07:59] (03CR) 10Jack Phoenix: [C: 04-1] "tl,dr: check quote style, in most cases you don't really want/need double quotes now that you've actually *removed* \n's from the messages" (0310 comments) [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498663 (owner: 10Isarra) [15:08:37] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "Hey, if it works, it works." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498687 (owner: 10Isarra) [15:09:03] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:09:40] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "Madness indeed." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 (owner: 10Isarra) [15:09:57] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated LinkCache::singleton() method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [15:10:26] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:10:59] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:13:18] (03PS19) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [15:23:42] (03PS5) 10Esanders: SpecialPreferences: Use real OOUI PHP layouts [core] - 10https://gerrit.wikimedia.org/r/498406 [15:24:58] (03CR) 10Arlolra: [C: 03+2] Update tests to match parser changes [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498701 (https://phabricator.wikimedia.org/T208070) (owner: 10Umherirrender) [15:29:48] (03Merged) 10jenkins-bot: Update tests to match parser changes [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498701 (https://phabricator.wikimedia.org/T208070) (owner: 10Umherirrender) [15:40:13] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [15:47:13] (03CR) 10Zoranzoki21: [C: 03+1] "You should click on Submit option :)" [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498659 (owner: 10Isarra) [15:58:51] (03CR) 10D3r1ck01: "When I check the `verifyMetaData()` header, it expects 2 arguments; $meta and a reference to an $error array. But the actual call passes 3" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498707 (owner: 10Thiemo Kreuz (WMDE)) [16:04:32] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aashuli) [16:16:40] (03PS20) 10Daimona Eaytoy: Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) [16:17:15] (03PS18) 10Daimona Eaytoy: Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) [16:17:56] 10Phabricator, 10Mail: "Wikimedia Foundation mail couldn't verify phabricator.wikimedia.org actually sent this message (and not a spammer)" in GMail - https://phabricator.wikimedia.org/T144381 (10Aklapper) 05Open→03Resolved >>! In T144381#4995774, @Aklapper wrote: > SPF recently got fixed in T216714; wonde... [16:18:33] (03PS17) 10Daimona Eaytoy: Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) [16:18:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Aklapper) 05Stalled→03Declined Unfortunately closing this report as no further information has been... [16:19:23] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Tracking: GIF Issues (tracking) - https://phabricator.wikimedia.org/T18456 (10Aklapper) [16:19:26] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10TestMe: Black color is always taken as transparent when downsampling GIF images using GD - https://phabricator.wikimedia.org/T26855 (10Aklapper) 05Open→03Stalled >>! In T26855#4995606, @Aklapper wrote: > Anyone knows if this is still a problem? If... [16:21:02] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Need-volunteer: [minor] Recent Changes/Watchlist: Enabled "Set as default" option pushes "Create default filter" button to a new line - https://phabricator.wikimedia.org/T217304 (10Aklapper) @Rachealnamaara: Hi, is there anyt... [16:24:57] (03PS13) 10Daimona Eaytoy: Store per-filter profiling in a single key [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489443 (https://phabricator.wikimedia.org/T53294) [16:31:09] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [16:35:07] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [16:35:43] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [16:35:53] (03CR) 10jenkins-bot: Remove $wgAbuseFilterProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486279 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [16:41:27] (03CR) 10jenkins-bot: Remove $wgAbuseFilterRuntimeProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486469 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [16:44:08] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] "Let's just merge this now..." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/497085 (owner: 10Isarra) [16:49:53] (03PS11) 10Daimona Eaytoy: Move per-filter matches profiling to per-filter data [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489445 (https://phabricator.wikimedia.org/T53294) [16:53:06] (03PS12) 10Daimona Eaytoy: Move per-filter matches profiling to per-filter data [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489445 (https://phabricator.wikimedia.org/T53294) [16:53:23] (03PS8) 10Daimona Eaytoy: Hide profiling for disabled filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489646 [16:54:31] 10Security: Query percentage of English Wikipedia admins without 2FA - https://phabricator.wikimedia.org/T157500 (10Krenair) It's been a couple of years since the query was ran in this task, might be nice to know what the latest figures are. [16:55:45] 10Google-Summer-of-Code (2019): GSoC 2019 Proposal: Improve article recommendation pipeline - https://phabricator.wikimedia.org/T218971 (10Usmanmuhd) [16:56:52] 10MediaWiki-extensions-Cargo, 10Patch-For-Review: Cargo: Dynamic tables - |order by= property ignored & UNIQ-QINU with |details fields= property - https://phabricator.wikimedia.org/T218066 (10Nikhil-nk) That note was for nested cargo queries, but your CONCAT field seemed like a template call. Or, are you using... [17:00:07] (03PS11) 10Daimona Eaytoy: Use milliseconds for time profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489453 [17:06:14] 10MediaWiki-Page-editing: Provide "add new section" link at the bottom of (discussion) pages - https://phabricator.wikimedia.org/T7642 (10Piramidion) Is there a way to place the link before the "edit" link? Because if I simply change the **.after** values to **.before**, the link is created correctly, but for so... [17:17:03] 10Outreachy (Round 18): Proposal: Add leaderboard based on user's edits using Commons Android App - https://phabricator.wikimedia.org/T219101 (10NahidFatma) [17:18:12] (03PS65) 10Daimona Eaytoy: Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [17:25:02] (03PS66) 10Daimona Eaytoy: Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [17:28:11] (03CR) 10jerkins-bot: [V: 04-1] Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [17:37:10] (03PS67) 10Daimona Eaytoy: Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [17:39:10] 10Outreachy (Round 18): Proposal: Add leaderboard based on user's edits using Commons Android App - https://phabricator.wikimedia.org/T219101 (10NahidFatma) [17:40:37] (03CR) 10jerkins-bot: [V: 04-1] Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [17:41:26] 10ContentTranslation, 10Research, 10Outreachy (Round 18): Quantitative Exploration of Content Translation Tools - https://phabricator.wikimedia.org/T218004 (10AggNisha) @Isaac I was trying to get a particular page's information on Hindi Wikipedia when all I have is its translation id (when converted from Eng... [17:46:43] (03PS3) 10Fomafix: Avoid href="#" on elements [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/497082 [17:54:32] 10MediaWiki-Documentation, 10Documentation, 10Need-volunteer: Move Help:Preferences from Meta to Mediawiki.org, update it and mark it for translation - https://phabricator.wikimedia.org/T181379 (10Areefa) @Trizek-WMF I compared the Help:Preferences documentation with my Preferences page. I created an updated... [18:00:52] 10MediaWiki-extensions-Cargo, 10Patch-For-Review: Cargo: Dynamic tables - |order by= property ignored & UNIQ-QINU with |details fields= property - https://phabricator.wikimedia.org/T218066 (10Madrigal84) @Nikhil-nk It is a template call to a template that runs a cargo-query. Is there a better way to run the... [18:01:00] (03CR) 10jerkins-bot: [V: 04-1] Add updateVarDumps to update.php and handle new code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482500 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:01:11] (03CR) 10jerkins-bot: [V: 04-1] Change afl_var_dump to be a foreign key to text.old_id [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482513 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:03:15] (03PS1) 10Daimona Eaytoy: Reset all filter profiling data at once [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498725 [18:04:38] (03PS2) 10Isarra: Use Maintenance::fatalError() instead of ::error() and consistentify usage [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498663 [18:04:43] (03PS6) 10Daimona Eaytoy: Add the abuse_filter_stats table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) [18:05:41] (03CR) 10jerkins-bot: [V: 04-1] Drop back-compat code [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482518 (https://phabricator.wikimedia.org/T213006) (owner: 10Daimona Eaytoy) [18:06:05] (03CR) 10Isarra: "...should I have removed the \ns? It seemed more consistent, but..." [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498663 (owner: 10Isarra) [18:15:23] (03CR) 10jerkins-bot: [V: 04-1] Reset all filter profiling data at once [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498725 (owner: 10Daimona Eaytoy) [18:17:38] (03CR) 10Isarra: [C: 03+2] Fix styles for .mw-body.dt and .mw-body.dl [skins/Timeless] - 10https://gerrit.wikimedia.org/r/477333 (https://phabricator.wikimedia.org/T211044) (owner: 10Paladox) [18:19:18] (03CR) 10jerkins-bot: [V: 04-1] Add the abuse_filter_stats table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [18:21:54] (03Merged) 10jenkins-bot: Fix styles for .mw-body.dt and .mw-body.dl [skins/Timeless] - 10https://gerrit.wikimedia.org/r/477333 (https://phabricator.wikimedia.org/T211044) (owner: 10Paladox) [18:24:02] (03PS2) 10Daimona Eaytoy: Reset all filter profiling data at once [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/498725 [18:24:11] (03CR) 10jerkins-bot: [V: 04-1] Add the abuse_filter_stats table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [18:24:21] (03PS7) 10Daimona Eaytoy: Add the abuse_filter_stats table [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) [18:32:12] 04(no projects): Adding an assignment template via the WikiEdu dashboard can place it inside other template code - https://phabricator.wikimedia.org/T219102 (10Purplewowies) [18:32:40] 10MediaWiki-extensions-Cargo, 10Patch-For-Review: Cargo: Dynamic tables - |order by= property ignored & UNIQ-QINU with |details fields= property - https://phabricator.wikimedia.org/T218066 (10Nikhil-nk) I directly include the query in CONCAT function. I don't know if it's the best way or not, but it works for... [18:47:20] (03PS60) 10Daimona Eaytoy: [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) [18:48:43] (03CR) 10Daimona Eaytoy: [C: 04-1] "> >" (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489186 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [18:57:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [18:58:06] (03CR) 10jerkins-bot: [V: 04-1] Merge global profiling keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [18:58:56] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Use Maintenance::fatalError() instead of ::error() and consistentify usage [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498663 (owner: 10Isarra) [19:02:48] (03PS2) 10Isarra: Add a very stupid resume 'from' for the downloads themselves [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498687 [19:03:06] (03CR) 10Isarra: [V: 03+2] Add a very stupid resume 'from' for the downloads themselves [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498687 (owner: 10Isarra) [19:04:52] (03CR) 10Isarra: [C: 03+2] OOUI fixes for dark MonoBook themes (Dark & Stellarbook) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/494824 (owner: 10Jack Phoenix) [19:05:38] (03PS2) 10Isarra: Do require_once of maintenance/Maintenance.php directly; no ini_set stuff [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498659 [19:05:58] 10MediaWiki-Documentation, 10Documentation, 10Need-volunteer: Move Help:Preferences from Meta to Mediawiki.org, update it and mark it for translation - https://phabricator.wikimedia.org/T181379 (10Aklapper) Thanks for working on this. There are a few red links on your page on mediawiki.org. These red links n... [19:06:02] (03PS3) 10Isarra: Add some checks to make sure we're not RANDOMLY GETTING LOGGED OUT [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 [19:08:18] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Do require_once of maintenance/Maintenance.php directly; no ini_set stuff [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498659 (owner: 10Isarra) [19:08:24] (03CR) 10Jack Phoenix: [V: 03+2 C: 03+2] Add some checks to make sure we're not RANDOMLY GETTING LOGGED OUT [tools/grabbers] - 10https://gerrit.wikimedia.org/r/498694 (owner: 10Isarra) [19:08:26] (03CR) 10Daimona Eaytoy: [C: 04-1] "TODO:" (036 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [19:08:36] (03Merged) 10jenkins-bot: OOUI fixes for dark MonoBook themes (Dark & Stellarbook) [extensions/Theme] - 10https://gerrit.wikimedia.org/r/494824 (owner: 10Jack Phoenix) [19:13:11] (03CR) 10Isarra: [C: 03+2] Fix the accessibility ("jump to") links [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/494357 (owner: 10Jack Phoenix) [19:14:43] (03CR) 10MarcoAurelio: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498213 (owner: 10MaxSem) [19:17:25] (03Merged) 10jenkins-bot: Fix the accessibility ("jump to") links [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/494357 (owner: 10Jack Phoenix) [19:27:13] (03CR) 10MaxSem: Make use of the list() feature where it makes sense (032 comments) [core] - 10https://gerrit.wikimedia.org/r/498719 (owner: 10Thiemo Kreuz (WMDE)) [19:32:00] (03CR) 10MaxSem: Update some minor type hints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498720 (owner: 10Thiemo Kreuz (WMDE)) [19:33:11] (03CR) 10MaxSem: [C: 03+2] Do not document constants as variables [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498712 (owner: 10Thiemo Kreuz (WMDE)) [19:33:57] (03CR) 10Legoktm: Rename tests/phan/stubs in dir list to new location (031 comment) [tools/phan] - 10https://gerrit.wikimedia.org/r/497130 (owner: 10Umherirrender) [19:35:00] (03PS61) 10Daimona Eaytoy: [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) [19:36:30] (03CR) 10Legoktm: Make the XML dump schema version configurable. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/479712 (https://phabricator.wikimedia.org/T174031) (owner: 10Daniel Kinzler) [19:38:56] (03CR) 10MaxSem: "@Bawolff, any ideas why is seccheck complaining about an escaped() message?" [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/498693 (owner: 10MaxSem) [19:42:29] (03PS4) 10Umherirrender: Rename tests/phan/stubs in dir list to new location [tools/phan] - 10https://gerrit.wikimedia.org/r/497130 [19:43:23] (03CR) 10Umherirrender: Rename tests/phan/stubs in dir list to new location (031 comment) [tools/phan] - 10https://gerrit.wikimedia.org/r/497130 (owner: 10Umherirrender) [19:44:06] 10Wiki-Loves-Monuments-Database: Upgrade heritage to Strech - https://phabricator.wikimedia.org/T216364 (10JeanFred) I hit the datetime thing in the Python for wikiloves as well. I did the following steps on heritage: * `rm -rf .venv venv` * `webservice --backend=kubernetes python2 shell` * `./bin/build-python.... [19:45:25] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [19:47:45] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move slow filters data to dedicated log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429381 (https://phabricator.wikimedia.org/T179604) (owner: 10Daimona Eaytoy) [19:47:50] (03Merged) 10jenkins-bot: Do not document constants as variables [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498712 (owner: 10Thiemo Kreuz (WMDE)) [19:49:17] (03CR) 10Reedy: [C: 04-1] "Lines need wrapping to a similar length to the other lines in the file (I think jenkins might validate that these days, so going to see wh" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/497821 (owner: 10Nikitrain) [19:49:21] (03CR) 10Reedy: [C: 04-1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/497821 (owner: 10Nikitrain) [19:49:32] 10WMEE: Üldkoosoleku kohta otsustamine ja päevakorda kokku panemine - https://phabricator.wikimedia.org/T216644 (10reosarevok) 05Open→03Resolved [19:50:16] (03CR) 10MaxSem: [C: 03+2] Typo: lenght [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498213 (owner: 10MaxSem) [19:50:30] OMG MAXSEM JUST SELF MERGED CODE [19:50:55] JOIN THE REBELLION [19:51:02] I ALREADY AM PART OF IT [19:51:33] 10WMEE: Üldkoosoleku ruumi broneerimine - https://phabricator.wikimedia.org/T219104 (10reosarevok) [19:52:00] 10WMEE: Üldkoosoleku ruumi broneerimine - https://phabricator.wikimedia.org/T219104 (10reosarevok) p:05Triage→03High [19:57:23] (03CR) 10MaxSem: [C: 03+2] Avoid use of deprecated LinkCache::singleton() method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [19:59:18] (03CR) 10Thiemo Kreuz (WMDE): Update some minor type hints (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498720 (owner: 10Thiemo Kreuz (WMDE)) [19:59:58] (03CR) 10jenkins-bot: Do not document constants as variables [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498712 (owner: 10Thiemo Kreuz (WMDE)) [20:02:45] (03Merged) 10jenkins-bot: Typo: lenght [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498213 (owner: 10MaxSem) [20:05:44] (03CR) 10MaxSem: Add a new class for methods related to running filters (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [20:07:10] (03CR) 10Reedy: [C: 04-1] "Apparently not, let me fix that" [core] - 10https://gerrit.wikimedia.org/r/497821 (owner: 10Nikitrain) [20:07:24] (03CR) 10jenkins-bot: Typo: lenght [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498213 (owner: 10MaxSem) [20:08:59] (03CR) 10jerkins-bot: [V: 04-1] Avoid use of deprecated LinkCache::singleton() method [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498632 (owner: 10D3r1ck01) [20:09:17] (03PS1) 10Reedy: Check line length of HISTORY [core] - 10https://gerrit.wikimedia.org/r/498730 [20:11:05] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [20:13:33] (03PS2) 10Thiemo Kreuz (WMDE): Make use of the list() feature where it makes sense [core] - 10https://gerrit.wikimedia.org/r/498719 [20:14:19] (03PS1) 10Reedy: Use foreach for readability [core] - 10https://gerrit.wikimedia.org/r/498732 [20:14:50] (03CR) 10Thiemo Kreuz (WMDE): Make use of the list() feature where it makes sense (032 comments) [core] - 10https://gerrit.wikimedia.org/r/498719 (owner: 10Thiemo Kreuz (WMDE)) [20:15:33] (03CR) 10MaxSem: [C: 03+2] "Meh, I'll rebase on top of this." [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 (owner: 10Umherirrender) [20:17:05] (03PS4) 10Umherirrender: build: Update eslint-config-wikimedia to 0.11.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/496349 (owner: 10Esanders) [20:17:08] (03CR) 10Umherirrender: [V: 03+2] build: Update eslint-config-wikimedia to 0.11.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/496349 (owner: 10Esanders) [20:17:20] (03PS3) 10Umherirrender: Add stylelint prefix rules [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/496350 (owner: 10Esanders) [20:17:23] (03CR) 10Umherirrender: [V: 03+2] Add stylelint prefix rules [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/496350 (owner: 10Esanders) [20:20:20] 10Wiki-Loves-Monuments-Database: Upgrade heritage to Strech - https://phabricator.wikimedia.org/T216364 (10Lokal_Profil) Ah. Since I just renamed the old venv i missed the `.venv`. [20:20:21] 10Wiki-Loves-Monuments-Database: Upgrade heritage to Strech - https://phabricator.wikimedia.org/T216364 (10Lokal_Profil) Did this also make the statistics bit work? [20:20:21] (03CR) 10Daniel Kinzler: "I hate the way our maintenance scripts work :/" [core] - 10https://gerrit.wikimedia.org/r/498716 (https://phabricator.wikimedia.org/T174031) (owner: 10ArielGlenn) [20:20:22] (03PS2) 10Umherirrender: build: Add mediawiki/mediawiki-codesniffer [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453930 (owner: 10Legoktm) [20:20:22] (03PS2) 10Umherirrender: Escape messages used in HTMLForm field options [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453929 (owner: 10Legoktm) [20:20:22] (03CR) 10Umherirrender: [C: 03+2] Escape messages used in HTMLForm field options [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453929 (owner: 10Legoktm) [20:20:22] (03CR) 10Umherirrender: "updated to latest" [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453930 (owner: 10Legoktm) [20:20:51] (03Merged) 10jenkins-bot: Move maintenance script into separate folder [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498685 (owner: 10Umherirrender) [20:20:53] (03Merged) 10jenkins-bot: Escape messages used in HTMLForm field options [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453929 (owner: 10Legoktm) [20:21:26] (03CR) 10MaxSem: [C: 03+2] Make use of the list() feature where it makes sense (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498719 (owner: 10Thiemo Kreuz (WMDE)) [20:21:52] (03PS3) 10Umherirrender: build: Add mediawiki/mediawiki-codesniffer [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453930 (owner: 10Legoktm) [20:21:56] (03CR) 10Umherirrender: [C: 03+2] build: Add mediawiki/mediawiki-codesniffer [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453930 (owner: 10Legoktm) [20:22:25] (03PS2) 10Umherirrender: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453931 (owner: 10Legoktm) [20:22:31] (03CR) 10Umherirrender: [C: 03+2] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453931 (owner: 10Legoktm) [20:22:39] (03CR) 10Daniel Kinzler: [C: 03+2] make xml abstracts, stubs and page log dumps work again [core] - 10https://gerrit.wikimedia.org/r/498716 (https://phabricator.wikimedia.org/T174031) (owner: 10ArielGlenn) [20:22:46] (03PS2) 10Umherirrender: Autofixing Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453932 (owner: 10Legoktm) [20:22:49] (03CR) 10Umherirrender: [C: 03+2] Autofixing Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453932 (owner: 10Legoktm) [20:23:05] (03PS2) 10Umherirrender: Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453933 (owner: 10Legoktm) [20:23:09] (03CR) 10Umherirrender: [C: 03+2] Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453933 (owner: 10Legoktm) [20:23:29] (03PS2) 10Umherirrender: Autofixing MediaWiki.WhiteSpace.* errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453934 (owner: 10Legoktm) [20:23:32] (03CR) 10Umherirrender: [C: 03+2] Autofixing MediaWiki.WhiteSpace.* errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453934 (owner: 10Legoktm) [20:23:43] (03PS1) 10Thiemo Kreuz (WMDE): parser: Inline private callback in LinkHolderArray::replaceText [core] - 10https://gerrit.wikimedia.org/r/498734 [20:24:15] (03CR) 10Daniel Kinzler: "> Patch Set 8:" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/479712 (https://phabricator.wikimedia.org/T174031) (owner: 10Daniel Kinzler) [20:25:17] (03CR) 10jerkins-bot: [V: 04-1] Check line length of HISTORY [core] - 10https://gerrit.wikimedia.org/r/498730 (owner: 10Reedy) [20:26:12] (03PS3) 10Umherirrender: Autofixing MediaWiki.WhiteSpace.* errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453934 (owner: 10Legoktm) [20:26:24] (03CR) 10Umherirrender: [C: 03+2] Autofixing MediaWiki.WhiteSpace.* errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453934 (owner: 10Legoktm) [20:27:11] (03PS4) 10MaxSem: Fix all PHPCS exceptions [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 [20:29:54] 10MediaWiki-User-management, 10Anti-Harassment: [Epic] Partial block rollout - https://phabricator.wikimedia.org/T218626 (10Niharika) [20:29:56] (03CR) 10MarcoAurelio: "Finally \o/" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/498213 (owner: 10MaxSem) [20:30:00] 10Anti-Harassment (Vav — ו), 10Patch-For-Review: Enable Partial Blocks on Beta: Commons, Wikisource, etc. - https://phabricator.wikimedia.org/T217278 (10Niharika) 05Open→03Resolved a:03Niharika Thanks @dom_walden and @SPoore. [20:30:18] 10Anti-Harassment (Vav — ו), 10Patch-For-Review: Enable Partial Blocks on Beta: Commons, Wikisource, etc. - https://phabricator.wikimedia.org/T217278 (10Niharika) a:05Niharika→03None [20:34:47] (03CR) 10Daimona Eaytoy: Add a new class for methods related to running filters (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 (owner: 10Daimona Eaytoy) [20:36:25] (03Merged) 10jenkins-bot: Make use of the list() feature where it makes sense [core] - 10https://gerrit.wikimedia.org/r/498719 (owner: 10Thiemo Kreuz (WMDE)) [20:36:28] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-codesniffer [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453930 (owner: 10Legoktm) [20:36:30] (03Merged) 10jenkins-bot: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453931 (owner: 10Legoktm) [20:36:33] (03PS2) 10Reedy: [WIP] Check line length of HISTORY [core] - 10https://gerrit.wikimedia.org/r/498730 [20:37:00] (03Merged) 10jenkins-bot: make xml abstracts, stubs and page log dumps work again [core] - 10https://gerrit.wikimedia.org/r/498716 (https://phabricator.wikimedia.org/T174031) (owner: 10ArielGlenn) [20:37:03] (03Merged) 10jenkins-bot: Autofixing Generic.Functions.FunctionCallArgumentSpacing.SpaceBeforeComma errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453932 (owner: 10Legoktm) [20:37:05] (03Merged) 10jenkins-bot: Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword.ParenthesesAroundKeywords errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453933 (owner: 10Legoktm) [20:37:07] (03Merged) 10jenkins-bot: Autofixing MediaWiki.WhiteSpace.* errors [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/453934 (owner: 10Legoktm) [20:37:09] (03CR) 10MaxSem: [C: 03+2] Use foreach for readability [core] - 10https://gerrit.wikimedia.org/r/498732 (owner: 10Reedy) [20:39:09] (03CR) 10jenkins-bot: Make use of the list() feature where it makes sense [core] - 10https://gerrit.wikimedia.org/r/498719 (owner: 10Thiemo Kreuz (WMDE)) [20:39:31] (03CR) 10Umherirrender: Fix all PHPCS exceptions (033 comments) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 (owner: 10MaxSem) [20:41:07] 10PHP 7.2 support: Fatal error « MWException » on frwiki page "Castelnaudary" - https://phabricator.wikimedia.org/T219105 (10Tractopelle-jaune) [20:41:36] (03CR) 10jenkins-bot: make xml abstracts, stubs and page log dumps work again [core] - 10https://gerrit.wikimedia.org/r/498716 (https://phabricator.wikimedia.org/T174031) (owner: 10ArielGlenn) [20:42:53] 10PHP 7.2 support, 10Wikimedia-production-error: Fatal error « MWException » on frwiki page "Castelnaudary" - https://phabricator.wikimedia.org/T219105 (10Reedy) [20:43:11] (03PS5) 10MaxSem: Fix all PHPCS exceptions [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 [20:43:14] (03CR) 10MaxSem: Fix all PHPCS exceptions (033 comments) [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 (owner: 10MaxSem) [20:44:36] 10MediaWiki-Parser, 10PHP 7.2 support, 10Wikimedia-production-error: Fatal error « MWException » on frwiki page "Castelnaudary" - https://phabricator.wikimedia.org/T219105 (10Reedy) [20:48:52] (03PS1) 10Krinkle: resources: Make manageForeignResources a regular maint script [core] - 10https://gerrit.wikimedia.org/r/498735 [20:48:54] (03PS1) 10Krinkle: resources: Improve foreign-resources docs and error messages [core] - 10https://gerrit.wikimedia.org/r/498736 [20:48:56] (03PS1) 10Krinkle: resources: Add caching for faster runs and offline use [core] - 10https://gerrit.wikimedia.org/r/498737 (https://phabricator.wikimedia.org/T203694) [20:51:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Check line length of HISTORY [core] - 10https://gerrit.wikimedia.org/r/498730 (owner: 10Reedy) [20:55:57] (03CR) 10jerkins-bot: [V: 04-1] resources: Make manageForeignResources a regular maint script [core] - 10https://gerrit.wikimedia.org/r/498735 (owner: 10Krinkle) [20:56:54] (03Merged) 10jenkins-bot: Use foreach for readability [core] - 10https://gerrit.wikimedia.org/r/498732 (owner: 10Reedy) [20:56:58] (03CR) 10Krinkle: [C: 03+1] parser: Inline private callback in LinkHolderArray::replaceText (031 comment) [core] - 10https://gerrit.wikimedia.org/r/498734 (owner: 10Thiemo Kreuz (WMDE)) [20:57:47] (03PS1) 10Reedy: Fix off by 1 error when displaying the number of a line with an error [core] - 10https://gerrit.wikimedia.org/r/498738 [20:57:58] (03PS2) 10Krinkle: resources: Make manageForeignResources a regular maint script [core] - 10https://gerrit.wikimedia.org/r/498735 [20:58:00] (03PS2) 10Krinkle: resources: Improve foreign-resources docs and error messages [core] - 10https://gerrit.wikimedia.org/r/498736 [20:58:02] (03PS2) 10Krinkle: resources: Add caching for faster runs and offline use [core] - 10https://gerrit.wikimedia.org/r/498737 (https://phabricator.wikimedia.org/T203694) [20:59:34] (03CR) 10jenkins-bot: Use foreach for readability [core] - 10https://gerrit.wikimedia.org/r/498732 (owner: 10Reedy) [20:59:46] (03CR) 10MaxSem: [C: 03+2] Fix off by 1 error when displaying the number of a line with an error [core] - 10https://gerrit.wikimedia.org/r/498738 (owner: 10Reedy) [21:01:09] (03CR) 10Umherirrender: [C: 03+2] Fix all PHPCS exceptions [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 (owner: 10MaxSem) [21:05:32] (03CR) 10Krinkle: [C: 03+1] Fix/suppress misc phan errors (#5) (032 comments) [core] - 10https://gerrit.wikimedia.org/r/498310 (owner: 10Legoktm) [21:06:48] (03CR) 10Umherirrender: "You could accept Ice642fb7026c6091d9c0c62186d31e76c21a4777 instead of this or is there a reason to do it as well?" [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498705 (owner: 10Thiemo Kreuz (WMDE)) [21:07:50] (03CR) 10Umherirrender: [C: 03+1] Remove dependency on $wgContLang [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/498298 (owner: 10MaxSem) [21:08:05] (03PS1) 10Krinkle: Allow +2'ers to set owner (not just the patch owner). [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/498739 [21:08:33] 10MediaWiki-Parser, 10PHP 7.2 support, 10Wikimedia-production-error: Preprocessor_DOM::preprocessToObj: generated node count limit exceeded - https://phabricator.wikimedia.org/T219105 (10Reedy) [21:09:02] (03CR) 10Krinkle: [V: 03+2 C: 03+2] Allow +2'ers to set owner (not just the patch owner). [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/498739 (owner: 10Krinkle) [21:09:10] (03CR) 10Krinkle: [V: 03+2] Allow +2'ers to set owner (not just the patch owner). [core] (refs/meta/config) - 10https://gerrit.wikimedia.org/r/498739 (owner: 10Krinkle) [21:09:12] (03CR) 10Umherirrender: [C: 03+2] Make use of the list() syntax where it makes sense [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498706 (owner: 10Thiemo Kreuz (WMDE)) [21:10:51] > PHPCS is enabled on 418/853 (49%) repositories. [21:10:54] so close... [21:11:10] Enabled and all the rules disabled no count :P [21:11:57] https://tools.wmflabs.org/phpcs/ [21:13:05] something seems to have gone wrong with https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MiniInvite/+/488622 [21:13:49] (03PS2) 10Umherirrender: Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:13:53] (03CR) 10Umherirrender: [C: 03+2] Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:14:00] (03Merged) 10jenkins-bot: Fix off by 1 error when displaying the number of a line with an error [core] - 10https://gerrit.wikimedia.org/r/498738 (owner: 10Reedy) [21:14:03] (03Merged) 10jenkins-bot: Fix all PHPCS exceptions [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/498303 (owner: 10MaxSem) [21:14:42] (03Merged) 10jenkins-bot: Make use of the list() syntax where it makes sense [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498706 (owner: 10Thiemo Kreuz (WMDE)) [21:15:20] oh, I see why [21:15:48] (03PS8) 10Umherirrender: Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 [21:16:42] (03CR) 10jenkins-bot: Fix off by 1 error when displaying the number of a line with an error [core] - 10https://gerrit.wikimedia.org/r/498738 (owner: 10Reedy) [21:21:06] 10Security-Team, 10CommRel-Specialists-Support (Jan-Mar-2019): Changing /wiki/Security and wiki/MediaWiki security reference content - https://phabricator.wikimedia.org/T217435 (10Aklapper) >>! In T217435#5033481, @chasemp wrote: > 2: I'll get in touch with @Aklapper as he's working on some homepage stuff it s... [21:21:58] (03CR) 10Krinkle: [C: 03+1] "Pending approval from Aaron" [core] - 10https://gerrit.wikimedia.org/r/498644 (https://phabricator.wikimedia.org/T196185) (owner: 10D3r1ck01) [21:27:01] (03CR) 10jerkins-bot: [V: 04-1] Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:27:13] (03CR) 10Umherirrender: [C: 03+1] Fix PhanUndeclaredType* errors (#3) [core] - 10https://gerrit.wikimedia.org/r/498290 (owner: 10Legoktm) [21:28:18] (03CR) 10Umherirrender: [C: 03+2] Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:29:27] (03CR) 10Krinkle: [C: 04-1] "Looks like this was previously broken. As such, it'd make sense to either repair or remove." [core] - 10https://gerrit.wikimedia.org/r/498690 (owner: 10Legoktm) [21:38:21] (03CR) 10Krinkle: [C: 03+1] "Comment-only." [core] - 10https://gerrit.wikimedia.org/r/498305 (owner: 10Legoktm) [21:39:47] (03CR) 10Krinkle: [C: 03+2] objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [21:40:10] (03Merged) 10jenkins-bot: Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:41:30] (03PS1) 10Thiemo Kreuz (WMDE): Use the ?? feature instead of isset() where it makes sense [core] - 10https://gerrit.wikimedia.org/r/498741 [21:42:36] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Urbanecm) a:05rafidaslam→03None Unassigning Rafid, nothing left to them. [21:44:08] (03CR) 10Thiemo Kreuz (WMDE): Remove unused parameter from method call (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498707 (owner: 10Thiemo Kreuz (WMDE)) [21:45:04] (03PS1) 10Umherirrender: Rename PoolCounter_Stub to PoolCounterNull [core] - 10https://gerrit.wikimedia.org/r/498742 [21:45:19] (03CR) 10Umherirrender: "Not used outside: https://codesearch.wmflabs.org/search/?q=PoolCounter_Stub&i=fosho&files=&repos=" [core] - 10https://gerrit.wikimedia.org/r/498742 (owner: 10Umherirrender) [21:45:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Improve array handling in PagedTiffHandler::doThumbError [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/485230 (owner: 10Umherirrender) [21:51:11] (03Merged) 10jenkins-bot: Improve array handling in PagedTiffHandler::doThumbError [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/485230 (owner: 10Umherirrender) [21:52:35] (03CR) 10jerkins-bot: [V: 04-1] objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [21:52:41] (03CR) 10jenkins-bot: Remove some not needed empty lines from the code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/498708 (owner: 10Thiemo Kreuz (WMDE)) [21:53:01] 10MediaWiki-extensions-WikimediaMaintenance, 10Performance-Team, 10Patch-For-Review: addWiki.php broken creating ES tables - https://phabricator.wikimedia.org/T212881 (10Urbanecm) @Reedy There are several wikis pending, is it possible to try to create them now? [21:56:46] (03PS2) 10Umherirrender: Fix broken error message with Message::newFromSpecifier() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498705 (owner: 10Thiemo Kreuz (WMDE)) [21:56:53] (03Abandoned) 10Umherirrender: Fix broken error message with Message::newFromSpecifier() [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498705 (owner: 10Thiemo Kreuz (WMDE)) [21:56:59] (03PS2) 10Umherirrender: Remove unused parameter from method call [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498707 (owner: 10Thiemo Kreuz (WMDE)) [21:57:04] (03Abandoned) 10Umherirrender: Remove unused parameter from method call [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498707 (owner: 10Thiemo Kreuz (WMDE)) [21:57:42] 10CheckUser: Search bar for check rationale in CheckUser log - https://phabricator.wikimedia.org/T219106 (10BU_Rob13) [21:58:45] (03CR) 10Umherirrender: Add delimiters to preg_match (031 comment) [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/496611 (owner: 10Umherirrender) [21:58:47] (03PS1) 10Foxtrott: Revert "Update MediaWiki namespaced AtEase global functions" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/498743 [22:01:17] (03CR) 10Thiemo Kreuz (WMDE): "Sorry for the confusion. I found these changes in my local changes, but forgot where they came from." [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/498705 (owner: 10Thiemo Kreuz (WMDE)) [22:16:42] (03CR) 10Foxtrott: [V: 03+2 C: 03+2] Revert "Update MediaWiki namespaced AtEase global functions" [extensions/Lingo] - 10https://gerrit.wikimedia.org/r/498743 (owner: 10Foxtrott) [22:28:24] 10MediaWiki-Cache, 10MediaWiki-Core-Testing, 10Patch-For-Review: Flaky test MessageCacheTest::testLoadFromDB_fetchLatestRevision - https://phabricator.wikimedia.org/T219042 (10daniel) Hmmm.... I don't see a reason for this to be flaky. If it fails, something is actually wrong. Disabling the test is likely to... [22:29:20] 10MediaWiki-Cache, 10MediaWiki-Core-Testing, 10Patch-For-Review: Flaky test MessageCacheTest::testLoadFromDB_fetchLatestRevision - https://phabricator.wikimedia.org/T219042 (10daniel) p:05Low→03High bumped to high - if this test is "sometimes" failing, it's likely that T218918 is still happening in prod... [22:30:23] (03CR) 10Daniel Kinzler: "Finding the reason this fails would be better than ignoring the test. I can't think of a reason for this to fail randomly, unless somethin" [core] - 10https://gerrit.wikimedia.org/r/498692 (https://phabricator.wikimedia.org/T219042) (owner: 10MaxSem) [22:38:26] 10CirrusSearch, 10Discovery, 10Discovery-Search: Cross-wiki search tokenizer is better than local search one - https://phabricator.wikimedia.org/T219108 (10Pols12) [22:46:14] (03CR) 10Krinkle: [C: 03+2] "/srv/phan/vendor/symfony/console/Terminal.php:127 [2] proc_open(): fork failed - Cannot allocate memory (Phan 1.2.6 crashed when parsing/a" [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [22:46:34] (03CR) 10Krinkle: [C: 03+2] "Let's try that again.." [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [23:00:53] (03CR) 10jerkins-bot: [V: 04-1] objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [23:03:07] (03PS1) 10D3r1ck01: block: Use correct function wfGetDB() as defined [core] - 10https://gerrit.wikimedia.org/r/498747 [23:05:33] (03PS1) 10D3r1ck01: block: Use the isset( ..., ..., [...] ) construct with && [core] - 10https://gerrit.wikimedia.org/r/498749 [23:06:56] (03PS2) 10D3r1ck01: block: Use correct function wfGetDB() as defined [core] - 10https://gerrit.wikimedia.org/r/498747 [23:17:11] (03PS1) 10D3r1ck01: db: Use variable function/callbacks instead of call_user_func() [core] - 10https://gerrit.wikimedia.org/r/498750 [23:17:18] (03PS2) 10D3r1ck01: db: Use variable functions/callbacks instead of call_user_func() [core] - 10https://gerrit.wikimedia.org/r/498750 [23:17:45] (03PS3) 10D3r1ck01: db: Use variable functions/callbacks instead of call_user_func() [core] - 10https://gerrit.wikimedia.org/r/498750 [23:21:21] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/498749 (owner: 10D3r1ck01) [23:23:01] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/498747 (owner: 10D3r1ck01) [23:26:43] 10MediaWiki-extensions-Lingo: When using parsing API, Lingo Glossary terms in page content will break certain parameters - https://phabricator.wikimedia.org/T219109 (10Msftwikipmey) [23:28:48] 10MediaWiki-extensions-Lingo: When using parsing API, Lingo Glossary terms in page content will break certain parameters - https://phabricator.wikimedia.org/T219109 (10Msftwikipmey) [23:29:35] 10MediaWiki-extensions-Lingo: When using parsing API, Lingo Glossary terms in page content will break certain parameters - https://phabricator.wikimedia.org/T219109 (10Msftwikipmey) [23:30:06] (03PS1) 10D3r1ck01: db: Drop child methods as they're same as parent methods [core] - 10https://gerrit.wikimedia.org/r/498751 [23:33:02] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/498750 (owner: 10D3r1ck01) [23:38:18] uhoh [23:40:31] why is it OOMing [23:41:43] (03CR) 10Legoktm: [C: 03+2] "..." [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [23:45:11] sigh [23:45:20] I monitored it very closely, so it passed of course [23:46:11] (03PS1) 10D3r1ck01: rdbms: Drop unused constructor property and default method arg [core] - 10https://gerrit.wikimedia.org/r/498752 [23:46:29] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/498751 (owner: 10D3r1ck01) [23:47:35] (03CR) 10D3r1ck01: [C: 03+1] "recheck" [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/498061 (https://phabricator.wikimedia.org/T123943) (owner: 10Jeropbrendawm) [23:47:54] (03CR) 10D3r1ck01: [C: 03+1] "recheck" [extensions/Contributors] - 10https://gerrit.wikimedia.org/r/498026 (https://phabricator.wikimedia.org/T123943) (owner: 10Jeropbrendawm) [23:48:17] (03CR) 10D3r1ck01: "recheck" [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/498335 (https://phabricator.wikimedia.org/T123943) (owner: 10Nikitrain) [23:51:38] (03CR) 10jerkins-bot: [V: 04-1] Add license information [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/498335 (https://phabricator.wikimedia.org/T123943) (owner: 10Nikitrain) [23:56:04] (03Merged) 10jenkins-bot: objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz) [23:57:13] (03PS1) 10D3r1ck01: diff: Wrap condition around brackets for more readability [core] - 10https://gerrit.wikimedia.org/r/498753 [23:59:36] (03CR) 10jenkins-bot: objectcache: remove BagOStuff::mergeViaLock() and update RESTBagOStuff [core] - 10https://gerrit.wikimedia.org/r/497828 (owner: 10Aaron Schulz)