[00:00:39] (03CR) 10Nray: WIP: Refactor ImageOverlay into an Overlay with a ImageCarousel (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493630 (https://phabricator.wikimedia.org/T216198) (owner: 10Nray) [00:01:18] (03CR) 10Aaron Schulz: [C: 03+2] objectcache: Use constant for $ttl param default in WANObjectCache::set() [core] - 10https://gerrit.wikimedia.org/r/316371 (owner: 10AndyRussG) [00:02:10] (03PS7) 10Jdlrobson: Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:02:14] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10Etonkovidova) Open questions: {F28351408} (1) There are two reference in the discussion above to the label "Ask Help Desk" and "Ask the Help... [00:02:43] (03CR) 10Jdlrobson: [C: 03+2] Correctly redirect to the section after mobile wikitext section edit (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:03:20] (03PS1) 10Aaron Schulz: Use HTTP method as hint for the locking mode of sqlite [core] - 10https://gerrit.wikimedia.org/r/495413 (https://phabricator.wikimedia.org/T93097) [00:04:23] (03PS14) 10Jdlrobson: EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) [00:09:14] (03CR) 10jerkins-bot: [V: 04-1] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:11:16] (03CR) 10jerkins-bot: [V: 04-1] EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [00:11:18] (03PS8) 10Jdlrobson: Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:11:25] (03CR) 10Jdlrobson: [C: 03+2] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:13:07] (03PS2) 10Tchanders: Fix Block::newLoad for IPv6 range blocks [core] - 10https://gerrit.wikimedia.org/r/495410 [00:15:05] (03Merged) 10jenkins-bot: objectcache: Use constant for $ttl param default in WANObjectCache::set() [core] - 10https://gerrit.wikimedia.org/r/316371 (owner: 10AndyRussG) [00:17:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review, 10Performance-Team (Radar): Drastically reduce the number of ResourceLoader modules that WikibaseClient registers - https://phabricator.wikimedia.org/T203696 (10Krinkle) p:05Triage→03Nor... [00:17:31] (03CR) 10jenkins-bot: objectcache: Use constant for $ttl param default in WANObjectCache::set() [core] - 10https://gerrit.wikimedia.org/r/316371 (owner: 10AndyRussG) [00:20:20] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/495144 (https://phabricator.wikimedia.org/T214080) (owner: 10Ottomata) [00:20:52] (03CR) 10Nray: "I'm noticing weird behavior when you:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [00:22:19] (03CR) 10Nray: [C: 04-1] "All of the Filter overlay headings are centered for me which I don't notice on production" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [00:22:59] (03CR) 10jerkins-bot: [V: 04-1] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:23:58] (03CR) 10Gergő Tisza: [C: 03+2] Optimize ID attribute search, if the DOM implementation has indexed it [libs/Zest] - 10https://gerrit.wikimedia.org/r/494560 (owner: 10C. Scott Ananian) [00:24:20] (03Merged) 10jenkins-bot: Optimize ID attribute search, if the DOM implementation has indexed it [libs/Zest] - 10https://gerrit.wikimedia.org/r/494560 (owner: 10C. Scott Ananian) [00:24:41] (03CR) 10jenkins-bot: Optimize ID attribute search, if the DOM implementation has indexed it [libs/Zest] - 10https://gerrit.wikimedia.org/r/494560 (owner: 10C. Scott Ananian) [00:25:48] (03PS3) 10Aaron Schulz: Make addIdentifierQuotes part of IDatabase [core] - 10https://gerrit.wikimedia.org/r/491035 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:27:27] (03CR) 10Aaron Schulz: [C: 03+2] "I suppose if we already expose IDatabase::query( $rawSQL ) we may as well do this" [core] - 10https://gerrit.wikimedia.org/r/491035 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:28:14] (03CR) 10Nray: "> All of the Filter overlay headings are centered for me which I" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [00:29:05] (03CR) 10Gergő Tisza: [C: 03+2] Optimize class attribute search using XPath [libs/Zest] - 10https://gerrit.wikimedia.org/r/494562 (owner: 10C. Scott Ananian) [00:29:07] (03PS1) 10Catrope: Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 [00:29:27] (03Merged) 10jenkins-bot: Optimize class attribute search using XPath [libs/Zest] - 10https://gerrit.wikimedia.org/r/494562 (owner: 10C. Scott Ananian) [00:29:48] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/495279 (https://phabricator.wikimedia.org/T217809) (owner: 10EBernhardson) [00:29:50] (03CR) 10jenkins-bot: Optimize class attribute search using XPath [libs/Zest] - 10https://gerrit.wikimedia.org/r/494562 (owner: 10C. Scott Ananian) [00:31:29] (03CR) 10Nray: "> > All of the Filter overlay headings are centered for me which I" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [00:33:14] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Wikimedia-production-error (Shared Build Failure): Failing test 'ext.navigationTiming#emitCpuBenchmark' - https://phabricator.wikimedia.org/T215714 (10Krinkle) [00:33:43] (03CR) 10jerkins-bot: [V: 04-1] Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 (owner: 10Catrope) [00:37:28] (03CR) 10jerkins-bot: [V: 04-1] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [00:37:59] (03CR) 10jerkins-bot: [V: 04-1] Factor out base-url attribute transformation into static methods [extensions/Flow] - 10https://gerrit.wikimedia.org/r/495415 (owner: 10Catrope) [00:39:35] (03PS10) 10Bartosz Dziewoński: Implement and use a tri-state checkbox for "select all" checkboxes [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/459533 [00:39:50] (03CR) 10Bartosz Dziewoński: "Would anyone be able to review this?" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/459533 (owner: 10Bartosz Dziewoński) [00:41:09] (03Merged) 10jenkins-bot: Make addIdentifierQuotes part of IDatabase [core] - 10https://gerrit.wikimedia.org/r/491035 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:43:28] (03CR) 10jenkins-bot: Make addIdentifierQuotes part of IDatabase [core] - 10https://gerrit.wikimedia.org/r/491035 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:46:29] 10MediaWiki-DjVu, 10Multimedia, 10Wikimedia-production-error: /usr/bin/djvudump command fails with "Unexpected End Of File." - https://phabricator.wikimedia.org/T217939 (10Krinkle) [00:49:23] 10TechCom, 10TechCom-RFC, 10Performance-Team (Radar): RFC: MediaWiki 2018 extension interfaces - https://phabricator.wikimedia.org/T212482 (10Krinkle) [00:49:41] 10TechCom, 10TechCom-RFC, 10Performance-Team (Radar): RFC: MediaWiki 2018 extension interfaces - https://phabricator.wikimedia.org/T212482 (10Krinkle) [01:04:32] (03PS10) 10Bartosz Dziewoński: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) [01:05:12] (03CR) 10Bartosz Dziewoński: "Rebased. It was failing because somebody else bumped maxEntrypointSize, which we also have to bump." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:05:59] (03PS11) 10Bartosz Dziewoński: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) [01:09:53] (03CR) 10Bartosz Dziewoński: VE: New loading screen design (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486408 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [01:11:08] (03CR) 10Bartosz Dziewoński: "> Patch Set 44: Code-Review+1" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486408 (https://phabricator.wikimedia.org/T210630) (owner: 10Bartosz Dziewoński) [01:12:05] (03PS8) 10Jdlrobson: Create the overlay for filters using composition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) [01:12:26] (03CR) 10Jdlrobson: "all fixed" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:12:56] (03CR) 10Jdlrobson: "See changes in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/495140/7..8/src/mobile.notifications.overlay/mobil" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:14:06] (03PS9) 10Jdlrobson: Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [01:14:15] (03CR) 10Jdlrobson: [C: 03+2] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [01:14:35] (03PS3) 10Jdlrobson: Remove some avoidable inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495260 (https://phabricator.wikimedia.org/T217296) [01:14:44] (03PS2) 10Jdlrobson: Hygiene: Drop some unnecessary usages of `this.` [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495269 (https://phabricator.wikimedia.org/T217296) [01:14:49] (03PS2) 10Jdlrobson: Use promisedView pattern for dealing with async wrapperWidget [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495270 (https://phabricator.wikimedia.org/T217296) [01:14:54] (03PS2) 10Jdlrobson: Remove loading checks [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495271 (https://phabricator.wikimedia.org/T217296) [01:15:00] (03PS2) 10Jdlrobson: All events handlers are not part of the prototype [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495272 (https://phabricator.wikimedia.org/T217296) [01:16:39] (03CR) 10jerkins-bot: [V: 04-1] Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:17:51] (03PS3) 10Bartosz Dziewoński: Switch to outside list style for ordered lists too (second try) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/494374 (https://phabricator.wikimedia.org/T150377) [01:24:05] (03PS1) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 [01:24:07] (03PS1) 10Aaron Schulz: installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) [01:24:25] (03CR) 10Bartosz Dziewoński: "Somebody has bumped it again while I was looking the other way. I don't want to have to update this constantly but I also don't want to ha" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:26:47] (03CR) 10Jdlrobson: [C: 03+2] "most painful merge ever lol" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [01:27:24] 10ContentTranslation, 10Editing QA, 10Regression, 10VisualEditor (Current work): Keyboard shortcuts open link inspector in read-only mode - https://phabricator.wikimedia.org/T217880 (10matmarex) [01:27:34] (03CR) 10Jdlrobson: "The problem is a lot of patches are being merged within a short period of time touching similar code so we've been experiencing more frict" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:27:38] 10ContentTranslation, 10Editing QA, 10Patch-For-Review, 10Regression, 10VisualEditor (Current work): [wmf.20-regression] CX2: Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10matmarex) [01:27:40] (03CR) 10Jdlrobson: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:27:52] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [01:27:55] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:27:57] (03CR) 10Frankiebot: [C: 04-1] "I cannot rebase this manually." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:27:59] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [01:28:05] (03CR) 10Jdlrobson: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493756 (owner: 10Jdlrobson) [01:28:12] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493756 (owner: 10Jdlrobson) [01:28:25] (03PS5) 10Frankiebot: Editor and VisualEditor use onBeforeExit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493756 (owner: 10Jdlrobson) [01:28:27] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [01:28:29] (03CR) 10Frankiebot: "I have rebased your patch for you against current master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493756 (owner: 10Jdlrobson) [01:29:11] (03CR) 10jerkins-bot: [V: 04-1] installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) (owner: 10Aaron Schulz) [01:29:13] (03CR) 10Jdlrobson: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:29:30] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:29:45] (03PS9) 10Frankiebot: Create the overlay for filters using composition [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:29:47] (03CR) 10Frankiebot: "I have rebased your patch for you against current master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495140 (https://phabricator.wikimedia.org/T217296) (owner: 10Jdlrobson) [01:29:48] 10Design, 10WMF-Design, 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), and 4 others: Use 'outside' instead of 'Inside' for list-style in Mobile version so that long line bullet list items are more scannable - https://phabricator.wikimedia.org/T150377 (10matmarex) [01:30:33] (03CR) 10jerkins-bot: [V: 04-1] installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) (owner: 10Aaron Schulz) [01:30:45] (03PS12) 10Jdlrobson: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:31:18] (03CR) 10jenkins-bot: Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [01:31:35] (03PS1) 10Aaron Schulz: Make insertLinks() avoid waiting on replication for no reason [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/495420 [01:32:44] (03CR) 10Krinkle: Make insertLinks() avoid waiting on replication for no reason (031 comment) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/495420 (owner: 10Aaron Schulz) [01:33:30] (03PS1) 10Aaron Schulz: Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495421 [01:33:32] (03CR) 10Jdlrobson: "I've also bumped the values in package.json and webpack.config.js much higher to give editing a little more flexibility in changes in this" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:33:43] (03CR) 10Jdlrobson: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [01:33:47] (03CR) 10Frankiebot: "This patch has dependencies. Please ask me again when it doesn't." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [01:33:57] (03CR) 10Krinkle: jobqueue: allow direct server configuration arrays to JobQueueDB (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [01:36:47] (03PS1) 10Aaron Schulz: Make HTMLCacheUpdateJob avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495422 [01:38:53] (03PS4) 10Jdlrobson: Remove some avoidable inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495260 (https://phabricator.wikimedia.org/T217296) [01:39:24] (03CR) 10Jdlrobson: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493624 (https://phabricator.wikimedia.org/T217102) (owner: 10Jdlrobson) [01:39:39] (03CR) 10Frankiebot: "This patch has dependencies. Please ask me again when it doesn't." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493624 (https://phabricator.wikimedia.org/T217102) (owner: 10Jdlrobson) [01:39:48] (03CR) 10Bartosz Dziewoński: [C: 03+2] "(feel free to rebase or do whatever it takes for the change to get merged)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [01:40:07] (03CR) 10jerkins-bot: [V: 04-1] Correctly redirect to the section after mobile wikitext section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493313 (owner: 10Bartosz Dziewoński) [01:40:35] (03CR) 10Krinkle: [C: 04-1] "Nice catch. I see two things there:" [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [01:40:37] (03CR) 10jerkins-bot: [V: 04-1] EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [01:44:05] (03PS15) 10Jdlrobson: EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) [01:44:08] (03CR) 10Jdlrobson: [C: 03+2] "per bartosz" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [01:44:10] (03CR) 10Bartosz Dziewoński: [C: 03+1] Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:02] (03PS13) 10Jdlrobson: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:05] (03CR) 10Jdlrobson: [C: 03+2] Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:47:18] (03PS30) 10Jdlrobson: Replace TalkSectionAddOverlay with factory function and new component [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493624 (https://phabricator.wikimedia.org/T217102) [01:48:29] (03PS2) 10Aaron Schulz: Make insertLinks() avoid waiting on replication for no reason [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/495420 [01:50:06] (03PS2) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 [01:51:44] 10Core Platform Team, 10TemplateStyles, 10css-sanitizer, 10Core Platform Team Backlog (Later), 10Patch-For-Review: Decide which non-standard CSS properties to support in TemplateStyles - https://phabricator.wikimedia.org/T162379 (10Tgr) Apparently there's a [[https://compat.spec.whatwg.org/|Compatiblity... [01:52:41] (03PS1) 10MaxSem: SVGMetadataExtractorTest: remove method existence test [core] - 10https://gerrit.wikimedia.org/r/495423 [01:53:01] (03CR) 10Krinkle: [C: 03+2] Make insertLinks() avoid waiting on replication for no reason [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/495420 (owner: 10Aaron Schulz) [01:53:05] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [01:53:15] (03PS2) 10Aaron Schulz: Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495421 [01:53:42] (03PS2) 10Aaron Schulz: Make HTMLCacheUpdateJob avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495422 [01:54:40] (03CR) 10Krinkle: [C: 03+2] Make HTMLCacheUpdateJob avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495422 (owner: 10Aaron Schulz) [01:54:51] (03CR) 10Krinkle: [C: 03+2] Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495421 (owner: 10Aaron Schulz) [01:55:56] (03Merged) 10jenkins-bot: EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [02:00:28] (03CR) 10jenkins-bot: EditorOverlay anonymous warning buttons are appended [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482383 (https://phabricator.wikimedia.org/T149909) (owner: 10Jdlrobson) [02:01:14] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.21; 2019-03-12), 10Patch-For-Review: NewPagesFeed not working when sorted oldest first - https://phabricator.wikimedia.org/T216674 (10Etonkovidova) 05Open→03Resolved The patch fixed the problem with that pa... [02:05:05] (03Merged) 10jenkins-bot: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [02:05:10] (03PS3) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 [02:05:12] (03Merged) 10jenkins-bot: Make insertLinks() avoid waiting on replication for no reason [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/495420 (owner: 10Aaron Schulz) [02:08:42] (03CR) 10jenkins-bot: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [02:08:46] (03CR) 10Gergő Tisza: "> But, that'll require changes to the extension." [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [02:14:10] (03Merged) 10jenkins-bot: Make HTMLCacheUpdateJob avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495422 (owner: 10Aaron Schulz) [02:16:24] (03CR) 10jenkins-bot: Make HTMLCacheUpdateJob avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495422 (owner: 10Aaron Schulz) [02:16:37] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [02:18:22] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Visual changes to add descriptions - https://phabricator.wikimedia.org/T217169 (10cooltey) Hi @schoenbaechler, could you please provide the SVG file of the icon in the snackbar (the little circle one), thanks! https://app.zeplin.io/proj... [02:18:57] (03CR) 10Krinkle: [C: 04-1] "distinction between preview and normal render is not affected. That is an incredibly popular use case, and we're continuing to accommodate" [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [02:19:52] 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Verified, 10VisualEditor (Current work): Can’t scroll to bottom of link dialog on iOS mobile VE while keyboard is open - https://phabricator.wikimedia.org/T215604 (10ppelberg) @ryasmeen, do the steps below look like the right ones to take to test whether the scr... [02:20:54] (03PS4) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 [02:25:30] (03Merged) 10jenkins-bot: Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495421 (owner: 10Aaron Schulz) [02:27:40] (03CR) 10jenkins-bot: Make PurgeJobUtils::invalidatePages avoid waiting on replication for no reason [core] - 10https://gerrit.wikimedia.org/r/495421 (owner: 10Aaron Schulz) [02:29:07] (03PS2) 10Aaron Schulz: installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) [02:29:34] (03PS3) 10Aaron Schulz: installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) [02:40:02] (03CR) 10Gergő Tisza: [C: 03+2] Fix corner cases with fast-path matching of unusual tag/class names [libs/Zest] - 10https://gerrit.wikimedia.org/r/494775 (owner: 10C. Scott Ananian) [02:40:35] (03Merged) 10jenkins-bot: Fix corner cases with fast-path matching of unusual tag/class names [libs/Zest] - 10https://gerrit.wikimedia.org/r/494775 (owner: 10C. Scott Ananian) [02:40:58] (03CR) 10jenkins-bot: Fix corner cases with fast-path matching of unusual tag/class names [libs/Zest] - 10https://gerrit.wikimedia.org/r/494775 (owner: 10C. Scott Ananian) [02:46:10] (03PS4) 10Aaron Schulz: installer: make sqlite installer move the job queue to another DB [core] - 10https://gerrit.wikimedia.org/r/495418 (https://phabricator.wikimedia.org/T93097) [02:54:04] 10MinervaNeue, 10Readers-Web-Backlog: Track share button usage - https://phabricator.wikimedia.org/T207280 (10Tbayer) >>! In T207280#4701474, @phuedx wrote: ... > > Relatedly, we could query the `wmf.webrequest` table for requests with a specific query parameter rather than include the code that I wrote in T2... [02:57:01] (03CR) 10Krinkle: jobqueue: allow direct server configuration arrays to JobQueueDB (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [03:03:30] (03CR) 10Gergő Tisza: [C: 03+2] Factor out `getElementsById` helper [libs/Zest] - 10https://gerrit.wikimedia.org/r/494783 (owner: 10C. Scott Ananian) [03:03:52] (03Merged) 10jenkins-bot: Factor out `getElementsById` helper [libs/Zest] - 10https://gerrit.wikimedia.org/r/494783 (owner: 10C. Scott Ananian) [03:04:11] (03CR) 10jenkins-bot: Factor out `getElementsById` helper [libs/Zest] - 10https://gerrit.wikimedia.org/r/494783 (owner: 10C. Scott Ananian) [03:07:16] (03PS1) 10MaxSem: Don't use deprecated MWCryptRand::generate() [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/495425 [03:13:08] (03PS1) 10MaxSem: Installer: Fix an obsolete comment [core] - 10https://gerrit.wikimedia.org/r/495426 [03:15:00] 10MediaWiki-extensions-Score, 10Beta-Cluster-Infrastructure, 10VisualEditor: Getting "Internal Error" on my sandbox on Beta cluster - https://phabricator.wikimedia.org/T217706 (10Krenair) page currently can be read fine, version at the time this was posted (https://en.wikipedia.beta.wmflabs.org/w/index.php?t... [03:17:47] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:20:47] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:21:25] 10MinervaNeue, 10Readers-Web-Backlog: Track share button usage - https://phabricator.wikimedia.org/T207280 (10Tbayer) I started to draft a schema at https://meta.wikimedia.org/wiki/Schema:MobileWebShareButton , per the discussion at T181195#4982077 ff. It is partly modeled after the [[https://meta.wikimedia.or... [03:22:22] (03CR) 10Krinkle: [C: 03+2] Don't use deprecated MWCryptRand::generate() [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/495425 (owner: 10MaxSem) [03:22:33] (03CR) 10Krinkle: [C: 03+2] Installer: Fix an obsolete comment [core] - 10https://gerrit.wikimedia.org/r/495426 (owner: 10MaxSem) [03:23:14] (03CR) 10Krinkle: [C: 03+2] Remove $wgMediaInTargetLanguage [core] - 10https://gerrit.wikimedia.org/r/495409 (https://phabricator.wikimedia.org/T205040) (owner: 10MaxSem) [03:23:29] Thanks Krinkle =) [03:23:32] (03CR) 10Krinkle: [C: 03+2] SVGMetadataExtractorTest: remove method existence test [core] - 10https://gerrit.wikimedia.org/r/495423 (owner: 10MaxSem) [03:23:35] yw :) [03:24:07] (03PS1) 10Krinkle: mediawiki.cookie: Move file to its own directory [core] - 10https://gerrit.wikimedia.org/r/495427 [03:24:09] (03PS1) 10Krinkle: mediawiki.cookie: Export config via packageFiles [core] - 10https://gerrit.wikimedia.org/r/495428 [03:24:49] (03Merged) 10jenkins-bot: Don't use deprecated MWCryptRand::generate() [extensions/GoogleAuthenticator] - 10https://gerrit.wikimedia.org/r/495425 (owner: 10MaxSem) [03:26:11] (03CR) 10Alex Monk: "T217942" [core] - 10https://gerrit.wikimedia.org/r/416198 (https://phabricator.wikimedia.org/T188801) (owner: 10Aaron Schulz) [03:26:16] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:32:15] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.cookie: Export config via packageFiles [core] - 10https://gerrit.wikimedia.org/r/495428 (owner: 10Krinkle) [03:37:01] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:39:16] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:40:33] (03PS5) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB [core] - 10https://gerrit.wikimedia.org/r/495417 [03:41:15] (03CR) 10Aaron Schulz: jobqueue: allow direct server configuration arrays to JobQueueDB (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495417 (owner: 10Aaron Schulz) [03:41:38] (03PS2) 10Krinkle: mediawiki.cookie: Export config via packageFiles [core] - 10https://gerrit.wikimedia.org/r/495428 [03:42:02] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [03:42:26] (03Merged) 10jenkins-bot: Remove $wgMediaInTargetLanguage [core] - 10https://gerrit.wikimedia.org/r/495409 (https://phabricator.wikimedia.org/T205040) (owner: 10MaxSem) [03:43:47] (03Merged) 10jenkins-bot: Installer: Fix an obsolete comment [core] - 10https://gerrit.wikimedia.org/r/495426 (owner: 10MaxSem) [03:43:53] (03Merged) 10jenkins-bot: SVGMetadataExtractorTest: remove method existence test [core] - 10https://gerrit.wikimedia.org/r/495423 (owner: 10MaxSem) [03:45:40] (03CR) 10jenkins-bot: Remove $wgMediaInTargetLanguage [core] - 10https://gerrit.wikimedia.org/r/495409 (https://phabricator.wikimedia.org/T205040) (owner: 10MaxSem) [03:46:55] (03CR) 10jenkins-bot: Installer: Fix an obsolete comment [core] - 10https://gerrit.wikimedia.org/r/495426 (owner: 10MaxSem) [03:48:21] (03CR) 10jenkins-bot: SVGMetadataExtractorTest: remove method existence test [core] - 10https://gerrit.wikimedia.org/r/495423 (owner: 10MaxSem) [03:48:50] 10MediaWiki-JobQueue, 10MediaWiki-Watchlist, 10Growth-Team, 10Beta-Cluster-reproducible: Argument 2 passed to WatchedItemStore::__construct() must be an instance of JobQueueGroup, instance of HashBagOStuff given, called in /srv/mediawiki/php-master/includes/Service... - https://phabricator.wikimedia.org/T217942 [04:04:29] (03CR) 10Gergő Tisza: Fix comma combinator (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/494823 (owner: 10C. Scott Ananian) [04:04:32] (03CR) 10Gergő Tisza: [C: 03+2] Fix comma combinator [libs/Zest] - 10https://gerrit.wikimedia.org/r/494823 (owner: 10C. Scott Ananian) [04:04:54] (03Merged) 10jenkins-bot: Fix comma combinator [libs/Zest] - 10https://gerrit.wikimedia.org/r/494823 (owner: 10C. Scott Ananian) [04:05:13] (03CR) 10jenkins-bot: Fix comma combinator [libs/Zest] - 10https://gerrit.wikimedia.org/r/494823 (owner: 10C. Scott Ananian) [04:07:48] (03CR) 10Gergő Tisza: [C: 03+1] Add test cases for DOM loading; workaround wrong root document nodeType (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/494978 (owner: 10C. Scott Ananian) [04:12:40] (03CR) 10Gergő Tisza: [C: 04-1] Add standard library bootstrap files (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:36:56] (03CR) 10Legoktm: Add standard library bootstrap files (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:37:44] (03PS2) 10Aaron Schulz: [WIP] objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 [04:38:21] (03PS3) 10Aaron Schulz: [WIP] objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 [04:46:09] (03CR) 10Aaron Schulz: [C: 03+2] mediawiki.cookie: Move file to its own directory [core] - 10https://gerrit.wikimedia.org/r/495427 (owner: 10Krinkle) [04:46:44] (03PS3) 10Aaron Schulz: mediawiki.cookie: Export config via packageFiles [core] - 10https://gerrit.wikimedia.org/r/495428 (owner: 10Krinkle) [04:51:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 (owner: 10Aaron Schulz) [04:58:13] (03CR) 10Gergő Tisza: [C: 04-1] Add standard library bootstrap files (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:58:43] (03CR) 10Gergő Tisza: [C: 03+2] Add standard library bootstrap files [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:59:05] (03Merged) 10jenkins-bot: Add standard library bootstrap files [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:59:25] (03CR) 10jenkins-bot: Add standard library bootstrap files [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [04:59:36] (03PS1) 10Gergő Tisza: Use testing-access-wrapper [libs/Zest] - 10https://gerrit.wikimedia.org/r/495430 [04:59:38] (03PS1) 10Gergő Tisza: Normalize class in xpath-based matching [libs/Zest] - 10https://gerrit.wikimedia.org/r/495431 [05:01:11] (03CR) 10Legoktm: [C: 03+2] Use testing-access-wrapper [libs/Zest] - 10https://gerrit.wikimedia.org/r/495430 (owner: 10Gergő Tisza) [05:01:33] (03Merged) 10jenkins-bot: Use testing-access-wrapper [libs/Zest] - 10https://gerrit.wikimedia.org/r/495430 (owner: 10Gergő Tisza) [05:01:52] (03CR) 10jenkins-bot: Use testing-access-wrapper [libs/Zest] - 10https://gerrit.wikimedia.org/r/495430 (owner: 10Gergő Tisza) [05:06:24] (03Merged) 10jenkins-bot: mediawiki.cookie: Move file to its own directory [core] - 10https://gerrit.wikimedia.org/r/495427 (owner: 10Krinkle) [05:08:05] 10MediaWiki-extensions-Cargo, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10Prosper) [05:08:35] (03CR) 10jenkins-bot: mediawiki.cookie: Move file to its own directory [core] - 10https://gerrit.wikimedia.org/r/495427 (owner: 10Krinkle) [05:09:00] (03PS1) 10Krinkle: resourceloader: Minor optimisation in variable declarations [core] - 10https://gerrit.wikimedia.org/r/495432 [05:09:02] (03PS1) 10Krinkle: resourceloader: Reduce size of ES5 StringSet fallback [core] - 10https://gerrit.wikimedia.org/r/495433 [05:09:04] (03PS1) 10Krinkle: resourceloader: Remove redundant var-freeing in addScript() [core] - 10https://gerrit.wikimedia.org/r/495434 [05:11:37] 10MediaWiki-extensions-Cargo, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10Prosper) I'm trying to submit a patch for this and i keep getting a Gerrit fatal error: >remote: Unauthorized fatal: Authentication failed for 'https://gerrit.wikimedia... [05:15:41] (03PS2) 10Krinkle: resourceloader: Minor optimisation in variable declarations [core] - 10https://gerrit.wikimedia.org/r/495432 [05:15:43] (03PS2) 10Krinkle: resourceloader: Reduce size of ES5 StringSet fallback [core] - 10https://gerrit.wikimedia.org/r/495433 [05:15:45] (03PS2) 10Krinkle: resourceloader: Remove redundant var-freeing in addScript() [core] - 10https://gerrit.wikimedia.org/r/495434 [05:15:58] (03CR) 10Krinkle: "fresnel: - 12 B" [core] - 10https://gerrit.wikimedia.org/r/495432 (owner: 10Krinkle) [05:19:47] (03CR) 10Krinkle: Add standard library bootstrap files (031 comment) [libs/Zest] - 10https://gerrit.wikimedia.org/r/495294 (owner: 10Legoktm) [05:22:18] (03PS1) 10MaxSem: Use Wikimedia\ObjectFactory instead of b/c alias [vagrant] - 10https://gerrit.wikimedia.org/r/495436 [05:27:28] (03CR) 10Krinkle: "fresnel: - 15 B" [core] - 10https://gerrit.wikimedia.org/r/495433 (owner: 10Krinkle) [05:27:55] (03CR) 10Krinkle: "fresnel: - 12 B" [core] - 10https://gerrit.wikimedia.org/r/495434 (owner: 10Krinkle) [05:46:13] (03CR) 10MaxSem: [C: 03+2] Avoid use of func_get_args() [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/495320 (owner: 10Legoktm) [05:49:28] (03Merged) 10jenkins-bot: Avoid use of func_get_args() [extensions/Calendar] - 10https://gerrit.wikimedia.org/r/495320 (owner: 10Legoktm) [05:53:01] 10MediaWiki-extensions-Cargo, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10MaxSem) You should use an ssh URL for checking out code instead of https. Run something like `git remote set-url gerrit ssh://@gerrit.wikimedia.org:29418/... [05:55:04] (03Abandoned) 10MaxSem: Use Wikimedia\ObjectFactory instead of b/c alias [vagrant] - 10https://gerrit.wikimedia.org/r/495436 (owner: 10MaxSem) [06:02:00] 10MediaWiki-extensions-Cargo, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10Prosper) I ran the command now and still got an error: > fatal: No such remote 'gerrit' [06:28:52] (03PS1) 10FR30799386: Changed escaped() to parse() [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/495438 (https://phabricator.wikimedia.org/T209937) [06:29:45] 10MediaWiki-extensions-Cargo, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10MaxSem) Then replace `gerrit` in that command with `origin`. [06:33:54] (03PS1) 10Prosper Opara: Add PHPDocs to CargoViewData functions [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/495439 (https://phabricator.wikimedia.org/T184342) [06:42:10] 10MediaWiki-extensions-Cargo, 10Patch-For-Review, 10Security: Cargo Extension : Add missing PHPdoc to the function - https://phabricator.wikimedia.org/T184342 (10Prosper) >>! In T184342#5012604, @MaxSem wrote: > Then replace `gerrit` in that command with `origin`. Thanks alot @MaxSem I just saw your follow-... [06:44:57] (03PS5) 10Jeena Huneidi: Adds a chart for running restbase. This includes config for it to talk to parsoid. Some some changes were made to mediawiki and parsoid service charts to better compartmentalize them so they can run without the umbrella chart. [releng/local-charts] - 10https://gerrit.wikimedia.org/r/493766 [06:45:28] 10MinervaNeue, 10Readers-Web-Backlog: Track share button usage - https://phabricator.wikimedia.org/T207280 (10Tbayer) [06:58:58] 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Readers-Web-Backlog (Design): Add a share button to the mobile site (starting by enabling in beta) - https://phabricator.wikimedia.org/T181195 (10Tbayer) I have updated T207280 with more concrete proposals on instrumentation and metrics based on the ab... [07:00:04] (03CR) 10MaxSem: "Thanks for your contribution and please don't take my review as nitpicking." (037 comments) [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/495439 (https://phabricator.wikimedia.org/T184342) (owner: 10Prosper Opara) [07:22:37] 10InternetArchiveBot (v2.0): IABot places archive template within dead link template if reference only contains a bare URL - https://phabricator.wikimedia.org/T217905 (10Cirdan) I fixed about a hundred occurences after IABot ran for 12 hours and I will continue to do so on a regular basis until this bug has been... [07:35:04] 10Wikimedia-Site-requests: Wikimedia-Site-requests: LMU Edit-a-thon - https://phabricator.wikimedia.org/T217929 (10Ammarpad) p:05Triage→03Normal a:03Ammarpad [07:37:06] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aashuli) @Didicodes Thanks you!! [07:40:20] 10Wiktionary, 10Tracking: Wiktionnaire / fr.wiktionary bugs (tracking) - https://phabricator.wikimedia.org/T76447 (10Pamputt) [07:40:27] 10MobileFrontend, 10Readers-Web-Backlog: Revaluate the mobile tagline descriptions for Wikipedia projects - https://phabricator.wikimedia.org/T214678 (10eranroz) @ovasileva can you please update here: 1. What is the justification for having descriptions (at tagline) in Wikipedia articles? (aren't they duplica... [07:44:08] 10MediaWiki-Parser: Backticks for code samples (as in Markdown) - https://phabricator.wikimedia.org/T217944 (10Qzekrom) [07:49:19] 10WMEE Awareness: TÜ karjääripäevadel esindus - https://phabricator.wikimedia.org/T215437 (10reosarevok) 05Open→03Resolved [07:54:30] (03PS4) 10Aaron Schulz: [WIP] objectcache: add object segmentation support to BagOStuff [core] - 10https://gerrit.wikimedia.org/r/495321 [07:57:32] (03CR) 10D3r1ck01: "Apart from those, I think it looks good. Also, I may have missed something so leaving this for FR." (033 comments) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 (owner: 10Zoranzoki21) [08:01:05] (03PS1) 10Umherirrender: Remove unneeded argument from JsonSchemaContentHandler::__construct [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/495441 [08:02:46] (03PS2) 10Umherirrender: Rename hook class to contain word "Hooks" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 [08:02:56] (03CR) 10Umherirrender: "Rebased" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 (owner: 10Umherirrender) [08:04:39] (03CR) 10jerkins-bot: [V: 04-1] Rename hook class to contain word "Hooks" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 (owner: 10Umherirrender) [08:06:31] 10WMEE GLAM Program 2019: P6216 (copyright) maalidele - https://phabricator.wikimedia.org/T214893 (10reosarevok) [08:06:44] 10WMEE GLAM Program 2019: MuISi isikute sünni/surmakuupäevade viitamine ja parandamine - https://phabricator.wikimedia.org/T210149 (10reosarevok) [08:07:01] (03CR) 10Umherirrender: Moved some files in includes/ and specials/ (031 comment) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 (owner: 10Zoranzoki21) [08:07:08] 10WMEE 101+: Artiklite kirjutamise nõustamine ja toetamine - https://phabricator.wikimedia.org/T216027 (10reosarevok) [08:07:23] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Raimond Valgre nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210165 (10reosarevok) [08:07:28] 10WMEE GLAM Program 2019: Teosed vajavad P276 (asukoht) - https://phabricator.wikimedia.org/T204679 (10reosarevok) [08:07:47] 10WMEE GLAM Program 2019: ELNET ID Wikidata bot - https://phabricator.wikimedia.org/T214568 (10reosarevok) [08:07:59] 10WMEE GLAM Program 2019: lemmikmaali valimise rakendus - https://phabricator.wikimedia.org/T209848 (10reosarevok) [08:08:18] 10WMEE GLAM Program 2019: kunstiõppe äpp: "kas tunned kunstnikku" - https://phabricator.wikimedia.org/T209846 (10reosarevok) [08:08:33] 10WMEE GLAM Program 2019: Wikidata Eesti maalide sissekannete kirjeldamine - https://phabricator.wikimedia.org/T204677 (10reosarevok) [08:08:42] 10WMEE GLAM Program 2019: Nikolai Triigi ja Konrad Mägi teoste pilte Commonsisse - https://phabricator.wikimedia.org/T204672 (10reosarevok) [08:08:57] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve pillide pilte saamiseks - https://phabricator.wikimedia.org/T210166 (10reosarevok) [08:09:17] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Rudolf Tobiase nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210158 (10reosarevok) [08:09:25] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Konstantin Türnpu nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210160 (10reosarevok) [08:09:33] (03PS3) 10Umherirrender: Rename hook class to contain word "Hooks" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 [08:09:34] 10WMEE GLAM Program 2019: Eesti Teatri- ja Muusikamuuseum: palve Miina Härma nootide ja käsikirjade saamiseks - https://phabricator.wikimedia.org/T210157 (10reosarevok) [08:09:46] (03CR) 10Umherirrender: "Fixed rebase" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 (owner: 10Umherirrender) [08:10:23] (03PS4) 10Umherirrender: Rename hook class to contain word "Hooks" [extensions/Insider] - 10https://gerrit.wikimedia.org/r/495292 [08:14:15] 10WMEE GLAM Program 2019: Bot to retrieve both metadata and images from Muis - https://phabricator.wikimedia.org/T215488 (10reosarevok) [08:17:19] 10MinervaNeue, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Hebrew Wikipedia problem with tables and captions in Minerva - https://phabricator.wikimedia.org/T215467 (10eranroz) Add some documentation in https://www.mediawiki.org/w/index.php?title=Recommendations_for_mobile_friendly_arti... [08:23:08] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Remove redundant var-freeing in addScript() [core] - 10https://gerrit.wikimedia.org/r/495434 (owner: 10Krinkle) [08:27:48] (03PS1) 10Umherirrender: build: Add grunt-banana-checker [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/495442 [08:30:59] 10Wiki Science Competition 2019: Wiki Science Competition meeting at Wikimedia Summit 2019 - https://phabricator.wikimedia.org/T217946 (10reosarevok) [08:31:15] (03CR) 10Aaron Schulz: "So the new file is 84410 bytes and the old one was 84397 bytes, right?" [core] - 10https://gerrit.wikimedia.org/r/495432 (owner: 10Krinkle) [08:40:30] 10WMSE-Riksarkivet-TORA: RAÄ - https://phabricator.wikimedia.org/T217947 (10Salgo60) [08:40:55] 10WMSE-Riksarkivet-TORA: RAÄ GET URL raa_number - https://phabricator.wikimedia.org/T217947 (10Salgo60) [08:41:08] (03PS2) 10Samwilson: Add sparkline charts to each log entry [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/483995 [08:41:14] (03CR) 10jerkins-bot: [V: 04-1] Add sparkline charts to each log entry [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/483995 (owner: 10Samwilson) [08:42:12] 10WMSE-Riksarkivet-TORA: RAÄ GET URL raa_number - https://phabricator.wikimedia.org/T217947 (10Salgo60) [08:42:40] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/NamespaceSidebar] - 10https://gerrit.wikimedia.org/r/495444 [08:45:32] (03PS3) 10Samwilson: Add sparkline charts to each log entry [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/483995 [08:46:23] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) [08:47:01] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) [08:48:13] (03CR) 10Samwilson: "This change is ready for review." [extensions/MissedPages] - 10https://gerrit.wikimedia.org/r/483995 (owner: 10Samwilson) [08:52:53] (03PS8) 10TheDJ: Changed "savearticle" message to "publishchanges" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/495003 (https://phabricator.wikimedia.org/T188532) (owner: 10FR30799386) [08:54:49] (03CR) 10TheDJ: "recheck" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/495003 (https://phabricator.wikimedia.org/T188532) (owner: 10FR30799386) [09:04:22] 10Design, 10MediaWiki-Special-pages, 10Patch-For-Review: Special:Contributions lists namespaces by index number, which is not intuitive - https://phabricator.wikimedia.org/T146418 (10D3r1ck01) [09:04:41] 10ExtensionDistributor, 10Patch-For-Review: History popstate not always handled (back broken) on Special:ExtensionDistributor - https://phabricator.wikimedia.org/T154400 (10D3r1ck01) [09:05:35] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10D3r1ck01) [09:07:32] (03CR) 10TheDJ: [C: 03+2] Changed "savearticle" message to "publishchanges" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/495003 (https://phabricator.wikimedia.org/T188532) (owner: 10FR30799386) [09:08:14] 10MediaWiki-Parser: Support backticks (`) for code samples (as in Markdown) - https://phabricator.wikimedia.org/T217944 (10Aklapper) [09:08:56] (03CR) 10Aaron Schulz: [C: 03+2] resourceloader: Reduce size of ES5 StringSet fallback [core] - 10https://gerrit.wikimedia.org/r/495433 (owner: 10Krinkle) [09:10:41] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) Added a comment on a page with more links in [[ https://de.wikipedia.org/wiki/Diskussion:Liste_der_Gro%C3%9Fsteingr%C3%A4ber_in_Schweden | de:Wikipedia ]] {F28353080,width=800} [09:13:27] (03Merged) 10jenkins-bot: Changed "savearticle" message to "publishchanges" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/495003 (https://phabricator.wikimedia.org/T188532) (owner: 10FR30799386) [09:23:08] 10MediaWiki-extensions-CentralAuth, 10good first bug: Language::formatNum prints HTML entity when within a tooltip - https://phabricator.wikimedia.org/T217734 (10matej_suchanek) a:03matej_suchanek This seems to be easy to fix. [09:23:18] (03PS1) 10Matěj Suchánek: Do not parse HTML title attribute [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/495445 (https://phabricator.wikimedia.org/T217734) [09:40:02] 10Wikimedia-General-or-Unknown, 10WorkType-Maintenance: "Nearby" feature does not work when language is Georgian and some other languages - https://phabricator.wikimedia.org/T89703 (10Tacsipacsi) >>! In T89703#1732782, @Aschroet wrote: > With the great help of hywiki user ԱշոտՏՆՂ the problem has been solved fo... [09:43:14] 10WMSE-Riksarkivet-TORA: Testa Länkar kulturarvsdata - https://phabricator.wikimedia.org/T217879 (10Salgo60) [09:46:06] 10WMSE-Riksarkivet-TORA: Testa Länkar kulturarvsdata - https://phabricator.wikimedia.org/T217879 (10Salgo60) [09:51:51] 10WMSE-Riksarkivet-TORA: Testa Länkar kulturarvsdata - https://phabricator.wikimedia.org/T217879 (10Salgo60) [09:54:31] (03Abandoned) 10D3r1ck01: db: Use MediaWikiServices to get value of $wgDBprefix not global [core] - 10https://gerrit.wikimedia.org/r/490115 (owner: 10D3r1ck01) [10:02:28] 10Android-app-Bugs, 10TemplateStyles, 10Wikipedia-Android-App-Backlog, 10Chinese-Sites: Templatestyles can't work in app? - https://phabricator.wikimedia.org/T204099 (10Tacsipacsi) 05Open→03Invalid Mobile app doesn’t use Minerva skin, so `body.skin-minerva` doesn’t match it. (The rules not specifically... [10:27:22] 10Security-Team, 10TechCom, 10TechCom-RFC, 10Security: Proposal for partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10eranroz) This is summary of the above discussion as far as I understand # Core requirements There is more or less agreement about the requir... [10:29:25] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10User-Zoranzoki21: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Meno25) >>! In T217507#4996242, @Zoranzoki21 wrote: >>>! In T217507#4996241, @Meno25 wrote: >>>>! In T2... [10:32:16] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: TemplateStyles doesn’t work in Android app under certain conditions - https://phabricator.wikimedia.org/T217949 (10Tacsipacsi) [10:34:00] 10Wikimedia-Site-requests, 10Community-consensus-needed: Use the "Timeless" skin by default on frwiktionary - https://phabricator.wikimedia.org/T217883 (10Noe) >>! In T217883#5011529, @Krenair wrote: Not sure I'd say it's the base identity of Wiktionary/Wikipedia, but I can understand concerns about it being d... [10:38:20] 10MediaWiki-Parser: Support backticks (`) for code samples (as in Markdown) - https://phabricator.wikimedia.org/T217944 (10Dinoguy1000) [10:41:57] 10Phabricator: Open tasks are not shown on a project workboard when they are in a hidden column - https://phabricator.wikimedia.org/T202878 (10Aklapper) Alright, `SELECT p.name FROM phabricator_project.project_column c JOIN phabricator_project.project p WHERE p.phid = c.projectPHID AND p.status != 100 AND c.stat... [10:42:55] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Nikitrain) [10:48:38] 10Wikimedia-Site-requests, 10Community-consensus-needed: Use the "Timeless" skin by default on frwiktionary - https://phabricator.wikimedia.org/T217883 (10Noe) >>! In T217883#5011516, @Isarra wrote: > I've just been avoiding this entire thing because it scares me (sorry), but if we do such a change, we do prob... [10:56:59] (03CR) 10Tpt: [C: 03+2] Move file LabeledSectionTransclusion to match filename [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495308 (owner: 10Umherirrender) [11:00:06] (03Merged) 10jenkins-bot: Move file LabeledSectionTransclusion to match filename [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495308 (owner: 10Umherirrender) [11:01:37] 10WMSE-Riksarkivet-TORA: Match Wikidata <-> Anbytaforum items using Open Refine - https://phabricator.wikimedia.org/T217548 (10Salgo60) {F28353511} file received from Nina Next step OpenRefine [11:05:33] 10Wikimedia-Site-requests: Reevaluate wgAccountCreationThrottle for hewikis - https://phabricator.wikimedia.org/T217950 (10eranroz) [11:06:29] 10MediaWiki-User-management, 10Anti-Harassment: Add block cookie for browser-based API edits (including VisualEditor & MobileFrontend) - https://phabricator.wikimedia.org/T196575 (10MER-C) FYI: T216245 [11:43:03] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) [11:44:14] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) [11:45:07] 10WMSE-Riksarkivet-TORA: RAÄ GET URL objektid - https://phabricator.wikimedia.org/T217947 (10Salgo60) [11:47:06] (03CR) 10Fomafix: [C: 03+2] Do not parse HTML title attribute [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/495445 (https://phabricator.wikimedia.org/T217734) (owner: 10Matěj Suchánek) [11:54:46] 10Wikimedia-General-or-Unknown, 10Security: Remove $wgApiFrameOptions = 'SAMEORIGIN' override for enwiki (English Wikipedia) - https://phabricator.wikimedia.org/T131183 (10eranroz) (just so it while reviewing the configuration) Do we really need it these days? [11:54:50] (03Merged) 10jenkins-bot: Do not parse HTML title attribute [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/495445 (https://phabricator.wikimedia.org/T217734) (owner: 10Matěj Suchánek) [11:57:17] (03CR) 10jenkins-bot: Do not parse HTML title attribute [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/495445 (https://phabricator.wikimedia.org/T217734) (owner: 10Matěj Suchánek) [12:09:08] 10InternetArchiveBot: Add job number to edit summary, not just user name - https://phabricator.wikimedia.org/T203301 (10Cirdan) [12:20:43] 10Wikimedia-Site-requests: Reevaluate wgAccountCreationThrottle for hewikis - https://phabricator.wikimedia.org/T217950 (10Aklapper) Has this been announced / discussed in the hewiki communities? (Not sure if needed though, just asking.) [12:27:33] (03PS2) 10Umherirrender: Change ResultWrapper to IResultWrapper [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/491010 [12:29:45] (03PS1) 10Umherirrender: Remove suppress of PhanRedefineFunctionInternal [core] - 10https://gerrit.wikimedia.org/r/495448 [12:29:53] 10MediaWiki-Recent-changes, 10Growth-Team: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10matej_suchanek) 05Open→03Resolved a:03Magnus [12:30:28] (03PS2) 10Umherirrender: Remove suppress of PhanRedefineFunctionInternal [core] - 10https://gerrit.wikimedia.org/r/495448 [12:37:41] (03CR) 10Umherirrender: [C: 03+2] Move images in resources directory [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493886 (owner: 10Zoranzoki21) [12:39:11] (03Abandoned) 10Umherirrender: Don't globally backlist PhanRedefineFunctionInternal [core] - 10https://gerrit.wikimedia.org/r/389286 (owner: 10MaxSem) [12:42:43] (03PS6) 10Umherirrender: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [12:42:47] (03CR) 10Umherirrender: [C: 03+2] Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [12:44:41] (03Abandoned) 10Umherirrender: Update phan-taint-check-plugin to 1.5.1 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/482085 (owner: 10Paladox) [12:45:36] 10ContentTranslation, 10Editing QA, 10Regression, 10VisualEditor (Current work): [wmf.20-regression] CX2: Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10Petar.petkovic) [12:46:24] (03PS2) 10Umherirrender: Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_32) - 10https://gerrit.wikimedia.org/r/482087 (owner: 10Paladox) [12:46:33] (03CR) 10Umherirrender: [C: 03+2] Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_32) - 10https://gerrit.wikimedia.org/r/482087 (owner: 10Paladox) [12:47:24] (03PS3) 10Umherirrender: Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [12:47:34] (03CR) 10Umherirrender: [C: 03+2] Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [12:48:45] (03Merged) 10jenkins-bot: Move images in resources directory [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493886 (owner: 10Zoranzoki21) [12:51:02] (03CR) 10Umherirrender: [C: 04-1] Upgrade ReplaceText extension to use newer phan (031 comment) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/494185 (https://phabricator.wikimedia.org/T216938) (owner: 10Laasya sree) [12:55:28] (03Merged) 10jenkins-bot: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [12:55:30] (03Merged) 10jenkins-bot: Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_32) - 10https://gerrit.wikimedia.org/r/482087 (owner: 10Paladox) [12:55:32] (03CR) 10jerkins-bot: [V: 04-1] Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [12:58:01] (03CR) 10jenkins-bot: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [12:58:03] (03CR) 10Umherirrender: [C: 03+1] Fix documentation errors reported by Phan (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 (owner: 10Daimona Eaytoy) [12:58:12] 10MediaWiki-General-or-Unknown, 10Wikidata: Page protection header on Page infromation of a deleted item has an empty table - https://phabricator.wikimedia.org/T217951 (10matej_suchanek) [12:58:28] 10MediaWiki-General-or-Unknown, 10Wikidata: Page protection header on Page infromation of a deleted item has an empty table - https://phabricator.wikimedia.org/T217951 (10matej_suchanek) p:05Triage→03Low [13:03:01] 10OOUI, 10Regression: Toolbar button is 1px too short - https://phabricator.wikimedia.org/T217952 (10Esanders) [13:04:20] (03CR) 10Umherirrender: "REL1_31 is using 1.2.0 of that plugin, it seems it needs more backports to work, but I cannot see what patch set. Maybe there are not part" [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [13:07:14] 10OOUI, 10Regression: Toolbar button is 1px too short - https://phabricator.wikimedia.org/T217952 (10Esanders) Bisect blames https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/490502/ (@Volker_E) [13:09:06] (03CR) 10Umherirrender: [C: 04-1] "It seems phan want you to init some variable before the loop to be sure there are defined after the loop" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493887 (https://phabricator.wikimedia.org/T216921) (owner: 10Zoranzoki21) [13:09:43] (03PS1) 10Fomafix: GlobalFunctions: Document the usage of wfUrlencode( null ) [core] - 10https://gerrit.wikimedia.org/r/495449 [13:11:37] (03PS6) 10Umherirrender: Moving hooks to their own class [extensions/Variables] - 10https://gerrit.wikimedia.org/r/461262 (https://phabricator.wikimedia.org/T202421) (owner: 10MGChecker) [13:12:01] (03PS7) 10Umherirrender: Moving hooks to their own class [extensions/Variables] - 10https://gerrit.wikimedia.org/r/461262 (https://phabricator.wikimedia.org/T202421) (owner: 10MGChecker) [13:12:05] (03CR) 10Umherirrender: [C: 03+2] Moving hooks to their own class [extensions/Variables] - 10https://gerrit.wikimedia.org/r/461262 (https://phabricator.wikimedia.org/T202421) (owner: 10MGChecker) [13:12:16] 10Design, 10WMDE-Design, 10Wikidata: add title attribute to add qualifier and add reference links in a statement - https://phabricator.wikimedia.org/T139359 (10matej_suchanek) [13:12:21] 10Design, 10WMDE-Design, 10Wikidata: Provide in-context help or hints to users - https://phabricator.wikimedia.org/T139356 (10matej_suchanek) [13:12:49] 10Design, 10MediaWiki-extensions-WikibaseRepository, 10WMDE-Design, 10Wikidata: consistent use of input placeholders in wikibase item view UI – - https://phabricator.wikimedia.org/T137780 (10matej_suchanek) [13:12:54] 10Design, 10WMDE-Design, 10Wikidata: [Epic] Collection of actionable UX Bugs on Wikidata - https://phabricator.wikimedia.org/T147837 (10matej_suchanek) [13:12:59] 10Design, 10WMDE-Design, 10Wikidata: [Solution] Value checking and saving: Error messages, no silent fails - https://phabricator.wikimedia.org/T138748 (10matej_suchanek) [13:14:29] (03PS5) 10Laasya sree: Upgrade ReplaceText extension to use newer phan [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/494185 (https://phabricator.wikimedia.org/T216938) [13:15:29] (03Merged) 10jenkins-bot: Moving hooks to their own class [extensions/Variables] - 10https://gerrit.wikimedia.org/r/461262 (https://phabricator.wikimedia.org/T202421) (owner: 10MGChecker) [13:16:36] (03CR) 10Umherirrender: [C: 03+2] Bring back jquery.appear [extensions/ArticleFeedbackv5] (REL1_31) - 10https://gerrit.wikimedia.org/r/494791 (https://phabricator.wikimedia.org/T159058) (owner: 10Reedy) [13:16:58] (03Merged) 10jenkins-bot: Bring back jquery.appear [extensions/ArticleFeedbackv5] (REL1_31) - 10https://gerrit.wikimedia.org/r/494791 (https://phabricator.wikimedia.org/T159058) (owner: 10Reedy) [13:17:08] (03CR) 10Umherirrender: [C: 03+2] Bring back jquery.appear [extensions/ArticleFeedbackv5] (REL1_32) - 10https://gerrit.wikimedia.org/r/494790 (https://phabricator.wikimedia.org/T159058) (owner: 10Reedy) [13:17:35] 10SpamBlacklist, 10phan: Upgrade SpamBlacklist extension to use newer phan - https://phabricator.wikimedia.org/T216942 (10Daimona) 05Open→03Resolved [13:17:40] (03Merged) 10jenkins-bot: Bring back jquery.appear [extensions/ArticleFeedbackv5] (REL1_32) - 10https://gerrit.wikimedia.org/r/494790 (https://phabricator.wikimedia.org/T159058) (owner: 10Reedy) [13:18:04] (03PS3) 10Umherirrender: Fix incorrect usage in RenameUserJob [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482084 (https://phabricator.wikimedia.org/T198285) (owner: 10Paladox) [13:18:09] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Fix incorrect usage in RenameUserJob [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482084 (https://phabricator.wikimedia.org/T198285) (owner: 10Paladox) [13:18:27] (03PS4) 10Umherirrender: Fix incorrect usage in RenameUserJob [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482084 (https://phabricator.wikimedia.org/T198285) (owner: 10Paladox) [13:18:32] (03CR) 10Umherirrender: [V: 03+2 C: 03+2] Fix incorrect usage in RenameUserJob [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482084 (https://phabricator.wikimedia.org/T198285) (owner: 10Paladox) [13:18:46] (03PS4) 10Umherirrender: Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [13:20:00] (03CR) 10Umherirrender: [C: 03+2] Update for the actor table change [extensions/UserMerge] (REL1_31) - 10https://gerrit.wikimedia.org/r/482110 (https://phabricator.wikimedia.org/T167246) (owner: 10Paladox) [13:21:10] (03CR) 10jerkins-bot: [V: 04-1] Suppress issue from phan-taint-check-plugin [extensions/Renameuser] (REL1_31) - 10https://gerrit.wikimedia.org/r/482088 (owner: 10Paladox) [13:21:43] (03CR) 10Umherirrender: "Why this needs backporting? A extra parameter which is not used does not break anything" [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/467981 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [13:22:38] (03Merged) 10jenkins-bot: Update for the actor table change [extensions/UserMerge] (REL1_31) - 10https://gerrit.wikimedia.org/r/482110 (https://phabricator.wikimedia.org/T167246) (owner: 10Paladox) [13:24:02] (03PS1) 10D3r1ck01: mw-config: Code augmentation in wfInstallerMain function [core] - 10https://gerrit.wikimedia.org/r/495450 [13:24:07] (03CR) 10jenkins-bot: Update for the actor table change [extensions/UserMerge] (REL1_31) - 10https://gerrit.wikimedia.org/r/482110 (https://phabricator.wikimedia.org/T167246) (owner: 10Paladox) [13:25:12] (03CR) 10Daimona Eaytoy: Fix documentation errors reported by Phan (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 (owner: 10Daimona Eaytoy) [13:31:30] (03PS1) 10D3r1ck01: mw-config: Use RequestContext class to get a WebRequest [core] - 10https://gerrit.wikimedia.org/r/495453 [13:34:51] (03CR) 10jerkins-bot: [V: 04-1] mw-config: Code augmentation in wfInstallerMain function [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [13:38:23] (03CR) 10D3r1ck01: "Flaky Flow: 1) Flow\Tests\Api\ApiFlowModerateTopicTest::testModerateLockedTopic" [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [13:38:34] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [13:39:43] (03CR) 10Gopavasanth: "Please follow Umherirrender comments in PS:4" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/494185 (https://phabricator.wikimedia.org/T216938) (owner: 10Laasya sree) [13:40:11] (03CR) 10Gopavasanth: [C: 04-1] "> Please follow Umherirrender comments in PS:4" [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/494185 (https://phabricator.wikimedia.org/T216938) (owner: 10Laasya sree) [13:45:41] 10MediaWiki-Recent-changes, 10Growth-Team: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10alanajjar) >>! In T217141#5007597, @Magnus wrote: > Fixed Listeria. > Don't know anything about ASammourBot. Thanks [13:51:36] (03CR) 10Daimona Eaytoy: "> Why this needs backporting? A extra parameter which is not used" [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/467981 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [13:53:23] 10Wikimedia-Site-requests: Reevaluate wgAccountCreationThrottle for hewikis - https://phabricator.wikimedia.org/T217950 (10eranroz) no [13:56:37] 10MediaWiki-Recent-changes, 10Growth-Team: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10matej_suchanek) >>! In T217141#5007331, @alanajjar wrote: > @matej_suchanek so should I open another task for this?! Firstly, get... [14:01:25] 10MediaWiki-Recent-changes, 10Growth-Team: ‏ListeriaBot appear in recent changes although human (not bot) filter is active in arwiki - https://phabricator.wikimedia.org/T217141 (10alanajjar) > Also please do not misuse "Edit comment" feature for interaction. Just comment on the task. !!!! [14:02:01] 10MobileFrontend, 10Readers-Web-Backlog: Revaluate the mobile tagline descriptions for Wikipedia projects - https://phabricator.wikimedia.org/T214678 (10eranroz) [14:02:09] 10MobileFrontend, 10Readers-Web-Backlog, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Unplanned-Sprint-Work: Turn tagline wikidata descriptions off in enwiki - https://phabricator.wikimedia.org/T161805 (10eranroz) [14:04:16] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikisource: no.wikisource language issue - https://phabricator.wikimedia.org/T62097 (10matej_suchanek) [14:04:34] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-management: Allow admin/account creator's to approve automatic account creation in case of blocks - https://phabricator.wikimedia.org/T211215 (101997kB) [14:06:39] (03CR) 10Umherirrender: "When nothing is broken, than it should not be backported." [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/467981 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [14:08:41] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [14:08:51] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [14:14:20] 04(no projects): MediaWiki 1.32.0 installed on host A cannot authenticate to MySQL on host B with password - https://phabricator.wikimedia.org/T217953 (10mhoran) [14:26:01] (03CR) 10Anomie: "Maybe you're going about this the wrong way." [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [14:34:12] 10MediaWiki-API, 10DBA, 10Performance: list=logevents slow for users with last log action long time ago - https://phabricator.wikimedia.org/T71222 (10Anomie) The query with IGNORE INDEX should be deployed next week with 1.33.0-wmf.21. I'll leave it to DBAs to decide whether to close this or keep it open for... [14:41:25] 10MediaWiki-Database: MediaWiki 1.32.0 installed on host A cannot authenticate to MySQL on host B with password - https://phabricator.wikimedia.org/T217953 (10Reedy) [14:57:11] 10MediaWiki-Page-editing, 10MediaWiki-extensions-FlaggedRevs, 10JavaScript, 10Patch-For-Review, and 2 others: PendingChanges is still using MediaWiki:Savearticle, sometimes, in at least the 2010 WikiEditor - https://phabricator.wikimedia.org/T188532 (10TheDJ) 05Open→03Resolved a:03Force_Radical [14:57:24] 10MediaWiki-Page-editing, 10MediaWiki-extensions-FlaggedRevs, 10JavaScript, 10User-TheDJ, 10good first bug: PendingChanges is still using MediaWiki:Savearticle, sometimes, in at least the 2010 WikiEditor - https://phabricator.wikimedia.org/T188532 (10TheDJ) [15:26:27] 10MediaWiki-Maintenance-scripts: rebuildLanguage.php notices - https://phabricator.wikimedia.org/T37904 (10D3r1ck01) 05Open→03Resolved In REL1_23, this script exist under the path `maintenance/language/` but seems to have been removed in REL1_25. Please reopen in case this is still an issue. Thanks! [15:26:53] 10MediaWiki-ResourceLoader, 10Librarization, 10Performance-Team: Make ResourceLoader a standalone library - https://phabricator.wikimedia.org/T32956 (10Krinkle) [15:28:44] 10MediaWiki-extensions-CommentStreams: Avoid global button:hover CSS - https://phabricator.wikimedia.org/T217955 (10planetenxin) [15:42:02] 10MediaWiki-Decoupling, 10MediaWiki-Internationalization, 10Core Platform Team Kanban, 10Core Platform Team (Code Health (TEC13)), 10Patch-For-Review: remove prev/next message dependency from Language - https://phabricator.wikimedia.org/T207977 (10eranroz) >>! In T207977#4997897, @BPirkle wrote: > Deprec... [15:42:52] (03PS2) 10Krinkle: installer: Get WebRequest in mw-config via RequestContext [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [15:43:25] 10WMEE: Jaanuari MTÜ Teataja kirjutamine - https://phabricator.wikimedia.org/T214833 (10Lmk2K18) 05Stalled→03Invalid [15:44:34] (03CR) 10Krinkle: [C: 03+2] "In the Installer various things don't work the way they normally do because the wiki hasn't been installed yet at this point. Hence, it's " [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [15:47:59] 10Core Platform Team (Extension Management (TEC13)): Extension Concept: Multi-Page Transclusion - https://phabricator.wikimedia.org/T217956 (10Wattahay) [15:49:29] (03CR) 10D3r1ck01: "> Patch Set 2: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [15:49:53] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10AakankshaShastri_1) Hi @srishaka... [15:50:37] 10Core Platform Team (Extension Management (TEC13)): Extension Concept: Category Thread - https://phabricator.wikimedia.org/T217956 (10Wattahay) [15:51:11] 10Core Platform Team (Extension Management (TEC13)): Extension Concept: Category Thread - https://phabricator.wikimedia.org/T217956 (10Wattahay) [15:53:42] (03PS1) 10TheDJ: Conditionally load syntaxhighlighting lib [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/495455 (https://phabricator.wikimedia.org/T209824) [15:53:53] (03CR) 10Subramanya Sastry: "> Patch Set 11:" [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [15:55:56] (03CR) 10jerkins-bot: [V: 04-1] Conditionally load syntaxhighlighting lib [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/495455 (https://phabricator.wikimedia.org/T209824) (owner: 10TheDJ) [15:58:04] (03Merged) 10jenkins-bot: installer: Get WebRequest in mw-config via RequestContext [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [16:00:17] (03CR) 10jenkins-bot: installer: Get WebRequest in mw-config via RequestContext [core] - 10https://gerrit.wikimedia.org/r/495453 (owner: 10D3r1ck01) [16:02:17] (03PS1) 10Mainframe98: Fix the order of the parameters for htmlform-title-badnamespace [core] - 10https://gerrit.wikimedia.org/r/495456 [16:08:46] (03PS3) 10TheDJ: Re-apply "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478744 (https://phabricator.wikimedia.org/T33780) (owner: 10Esanders) [16:13:59] 10MediaWiki-Maintenance-scripts: resetUserEmail.php gives no output on success - https://phabricator.wikimedia.org/T196708 (10D3r1ck01) 05Open→03Resolved [16:24:18] 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10VisualEditor (Current work): Citation logging splits events by citation type - https://phabricator.wikimedia.org/T216248 (10Esanders) Verified that we are now only seeing 'cite' in the feature column. [16:27:43] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aklapper) @AakankshaShastri_1: Hi... [16:30:19] 10MediaWiki-extension-requests: Extension Concept: Category Thread - https://phabricator.wikimedia.org/T217956 (10Aklapper) Hi @Wattahay, thanks for taking the time to report this and welcome to Wikimedia Phabricator! This sounds like a request that someone should write some extension (please correct me if I'm... [16:35:46] 10Technical-Debt, 10VisualEditor (Current work): Add functional test coverage for link inspector and others - https://phabricator.wikimedia.org/T217957 (10Esanders) [16:36:05] 10Technical-Debt, 10VisualEditor (Current work): Add functional test coverage for link inspector and others - https://phabricator.wikimedia.org/T217957 (10Esanders) Patch: https://gerrit.wikimedia.org/r/#/c/VisualEditor/VisualEditor/+/495276/ [16:36:33] 10Technical-Debt, 10VisualEditor (Current work): Add functional test coverage for link inspector and others - https://phabricator.wikimedia.org/T217957 (10Esanders) [16:37:32] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Ssomansh) @Aklapper Are we expected to create the actual tables or graphs too or just the back end part of getting th... [16:37:47] 10Technical-Debt, 10VisualEditor (Current work): Add functional test coverage for link inspector and others - https://phabricator.wikimedia.org/T217957 (10Esanders) Coverage after patch: {F28355780,size=full} [16:43:39] (03PS2) 10D3r1ck01: installer: Code augmentation in wfInstallerMain function [core] - 10https://gerrit.wikimedia.org/r/495450 [16:44:46] (03CR) 10D3r1ck01: "PS2 is a manual rebase." [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [16:47:24] 10Hashtags, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2019): Create a subpage for statistics and charts related to a hashtag search - https://phabricator.wikimedia.org/T186706 (10Aklapper) @Ssomansh: I don't know. I do not mentor this task, hence not sure why you ask me specifically. :) My under... [16:47:51] (03CR) 10Eranroz: "What kind of unittest would we like for such method? that it returns the correct msg? any example of similar unitest?" [core] - 10https://gerrit.wikimedia.org/r/469667 (owner: 10Eranroz) [16:48:24] 10MediaWiki-Parser: Support backticks (`) for code samples (as in Markdown) - https://phabricator.wikimedia.org/T217944 (10Qzekrom) [16:52:42] 10MediaWiki-Parser: localurl discards section id - https://phabricator.wikimedia.org/T26343 (10Kezamac34) [16:53:02] 10Language-strategy, 10Wikimedia-General-or-Unknown, 10Category, 10Community-Tech (2015-2017), and 3 others: Central Global Repository for Templates, Lua modules, and Gadgets - https://phabricator.wikimedia.org/T121470 (10Kezamac34) [17:01:02] (03PS1) 10Jack Phoenix: Fix up some type hints to prevent E_WARNINGs on MW 1.32+ [extensions/GlobalUserrights] - 10https://gerrit.wikimedia.org/r/495459 [17:01:31] (03PS1) 10C. Scott Ananian: Provide an option to suppress namespace for HTML elements [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/495460 (https://phabricator.wikimedia.org/T217708) [17:01:33] 10MediaWiki-Release-Tools, 10Epic: Make release scripts initiatable via Jenkins - https://phabricator.wikimedia.org/T217839 (10MarkAHershberger) [17:02:23] (03CR) 10jerkins-bot: [V: 04-1] Provide an option to suppress namespace for HTML elements [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/495460 (https://phabricator.wikimedia.org/T217708) (owner: 10C. Scott Ananian) [17:02:28] 10MediaWiki-Release-Tools, 10Epic: Test tarball extraction and verify diffs apply cleanly in Jenkins - https://phabricator.wikimedia.org/T217840 (10MarkAHershberger) [17:08:46] 10MediaWiki-Parser: localurl discards section id - https://phabricator.wikimedia.org/T26343 (10Aklapper) 05duplicate→03Resolved [17:11:41] 10MediaWiki-Parser: localurl discards section id - https://phabricator.wikimedia.org/T26343 (10Aklapper) 05Resolved→03Open [17:14:55] 10MediaWiki-Release-Tools, 10Epic: Release notes changelog automation for tarball - https://phabricator.wikimedia.org/T217958 (10MarkAHershberger) [17:18:34] (03CR) 10Krinkle: installer: Code augmentation in wfInstallerMain function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [17:20:35] (03PS2) 10C. Scott Ananian: Provide an option to suppress namespace for HTML elements [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/495460 (https://phabricator.wikimedia.org/T217708) [17:20:37] (03PS1) 10C. Scott Ananian: Remove debugging code from TreeBuilder::adoptionAgency [libs/RemexHtml] - 10https://gerrit.wikimedia.org/r/495461 (https://phabricator.wikimedia.org/T212543) [17:21:01] 10MediaWiki-Release-Tools, 10Epic: Tarball signing automation - https://phabricator.wikimedia.org/T217959 (10MarkAHershberger) [17:23:11] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10AakankshaShastri_1) Hey, Thank y... [17:23:54] 10MediaWiki-Release-Tools, 10Epic: Tarball upload automation - https://phabricator.wikimedia.org/T217960 (10MarkAHershberger) [17:26:12] 10MediaWiki-Release-Tools, 10Epic: Produce and document interface for kicking off a branch and tarbal production - https://phabricator.wikimedia.org/T217961 (10MarkAHershberger) [17:27:59] 04(no projects): Bug: {{NUMBEROFARTICLES}} is decreasing when moving pages in Main/Article namespace (kowiki) - https://phabricator.wikimedia.org/T217962 (10Ykhwong) [17:28:22] 04(no projects): Bug: {{NUMBEROFARTICLES}} is decreasing when moving pages in Main/Article namespace (kowiki) - https://phabricator.wikimedia.org/T217962 (10Ykhwong) [17:29:42] Hey quick question [17:29:46] How do I change my name on phab [17:29:53] 10MediaWiki-Release-Tools, 10Epic: Ensure all repositories in Gerrit have been branched at the right time. - https://phabricator.wikimedia.org/T217963 (10MarkAHershberger) [17:30:24] 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): Add functional test coverage for link inspector and others - https://phabricator.wikimedia.org/T217957 (10Esanders) After 2nd patch: {F28356012,size=full} [17:31:12] (03CR) 10Fomafix: installer: Code augmentation in wfInstallerMain function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495450 (owner: 10D3r1ck01) [17:35:45] Praxidicae: https://www.mediawiki.org/wiki/Phabricator/Help#Troubleshooting [17:37:52] 10MediaWiki-Release-Tools, 10Epic: Bot to upgrade the different bits of mw.o for tarball releases - https://phabricator.wikimedia.org/T217964 (10MarkAHershberger) [17:38:22] 04(no projects): Bug: {{NUMBEROFARTICLES}} is decreasing when moving pages in Main/Article namespace (kowiki) - https://phabricator.wikimedia.org/T217962 (10Aklapper) [17:38:24] 10MediaWiki-Special-pages: Moving a page lowers the number of articles on Special:Statistics - https://phabricator.wikimedia.org/T212706 (10Aklapper) [17:39:21] andre__: o/ [17:39:59] shreyasminocha, hey hey! [17:43:46] (03PS1) 10FR30799386: Change mouseleaver to mouseleave [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/495463 [17:48:50] (03PS3) 10Zoranzoki21: Moved some files in includes/ and specials/ [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 [17:58:11] 10MediaWiki-Documentation, 10MediaWiki-Maintenance-scripts, 10Documentation: Document maintenance script emptyUserGroup.php on MediaWiki - https://phabricator.wikimedia.org/T213408 (10Eisheeta) @Aklapper Thank you so much for your help! I'll try it and get back to you soon about it. [18:06:57] (03PS7) 10Florianschmidtwelzow: Change path to $IP when using extension-dir too [core] - 10https://gerrit.wikimedia.org/r/399219 [18:19:29] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlighting gets confused when producing table syntax in template - https://phabricator.wikimedia.org/T217965 (10diralik) [18:24:01] 10MediaWiki-extensions-Scribunto, 10CodeEditor: Make CodeEditor available in modules that are subpages of a user page - https://phabricator.wikimedia.org/T217508 (10nyemini) Well, I checked it a bit and discovered that the decision whether a page is lua is in the scribunto extension in /includes/common/Hooks.p... [18:25:00] (03Abandoned) 10FR30799386: Change mouseleaver to mouseleave [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/495463 (owner: 10FR30799386) [18:48:59] (03PS1) 10Aaron Schulz: Make SpecialCiteThisPage use setInterfaceMessage() option for parse() calls [extensions/CiteThisPage] - 10https://gerrit.wikimedia.org/r/495466 [18:49:17] 04(no projects): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Didicodes) [18:51:00] (03PS12) 10Aaron Schulz: Disable expensive {{REVISIONID}} magic word in miser mode [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) [18:53:19] 04(no projects): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Didicodes) [18:56:34] (03CR) 10Aaron Schulz: "I proposed something similar at https://phabricator.wikimedia.org/T137900 and some people didn't like that either. It was one of my first " [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [18:58:08] 04(no projects): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Didicodes) [19:07:10] 04(no projects): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Didicodes) [19:07:47] 10Outreachy (Round 18): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Aklapper) [19:09:04] (03Abandoned) 10Zoranzoki21: Upgrade ImageMap extension to use newer phan [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493887 (https://phabricator.wikimedia.org/T216921) (owner: 10Zoranzoki21) [19:09:31] 10ImageMap, 10phan: Upgrade ImageMap extension to use newer phan - https://phabricator.wikimedia.org/T216921 (10Zoranzoki21) a:05Zoranzoki21→03None [19:15:57] (03PS3) 10Zoranzoki21: Convert HTTP links to HTTPS for mediawiki.org [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495258 (https://phabricator.wikimedia.org/T189687) [19:16:45] (03PS4) 10Zoranzoki21: Moved some files in includes/ directory [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 [19:16:54] (03PS4) 10Zoranzoki21: Convert HTTP links to HTTPS for mediawiki.org [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495258 (https://phabricator.wikimedia.org/T189687) [19:28:52] 10Accessibility, 10OOUI, 10Patch-For-Review: DropdownWidget misses required ARIA child roles and attributes - https://phabricator.wikimedia.org/T212186 (10Volker_E) Just coming from A11yCampBay, this is a nice resource, basically repeating `combobox` being the more appropriate role https://gerardkcohen.githu... [19:44:18] (03CR) 10Umherirrender: [C: 03+2] Moved some files in includes/ directory [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 (owner: 10Zoranzoki21) [19:44:59] (03CR) 10Umherirrender: [C: 03+2] Convert HTTP links to HTTPS for mediawiki.org [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495258 (https://phabricator.wikimedia.org/T189687) (owner: 10Zoranzoki21) [19:45:02] (03Merged) 10jenkins-bot: Moved some files in includes/ directory [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495254 (owner: 10Zoranzoki21) [19:45:41] (03Merged) 10jenkins-bot: Convert HTTP links to HTTPS for mediawiki.org [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/495258 (https://phabricator.wikimedia.org/T189687) (owner: 10Zoranzoki21) [19:46:59] 10Wikimedia-General-or-Unknown: Smartly suggest app users to upload a missing photo on Commons via UploadWizard - https://phabricator.wikimedia.org/T143884 (10Aklapper) p:05Normal→03Triage [19:49:02] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aklapper) @AakankshaShastri_1: Se... [19:50:05] (03CR) 10Umherirrender: "I would suggest to create new message-keys and not using RawMessages to have full i18n of api errors" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 (owner: 10Jack Phoenix) [19:50:27] (03CR) 10Dmaza: [C: 03+2] Block: Explicit convert Message to string [core] - 10https://gerrit.wikimedia.org/r/494064 (owner: 10Fomafix) [19:59:23] (03PS14) 10Dmaza: Add password policy setting `suggestChangeOnLogin` [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) [19:59:36] (03CR) 10Dmaza: Add password policy setting `suggestChangeOnLogin` (031 comment) [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [20:04:22] (03PS5) 10Daniel Kinzler: Make LinksDeletionUpdate a subclass of LinksUpdate [core] - 10https://gerrit.wikimedia.org/r/494557 (https://phabricator.wikimedia.org/T216249) [20:08:26] (03Merged) 10jenkins-bot: Block: Explicit convert Message to string [core] - 10https://gerrit.wikimedia.org/r/494064 (owner: 10Fomafix) [20:09:58] (03CR) 10Tchanders: [C: 03+1] Add password policy setting `suggestChangeOnLogin` [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [20:10:43] (03CR) 10jenkins-bot: Block: Explicit convert Message to string [core] - 10https://gerrit.wikimedia.org/r/494064 (owner: 10Fomafix) [20:17:38] (03CR) 10Daniel Kinzler: Make LinksDeletionUpdate a subclass of LinksUpdate (035 comments) [core] - 10https://gerrit.wikimedia.org/r/494557 (https://phabricator.wikimedia.org/T216249) (owner: 10Daniel Kinzler) [20:17:40] (03PS2) 10Umherirrender: Autofixing MediaWiki.Commenting.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492586 (owner: 10Legoktm) [20:18:21] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.Commenting.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492586 (owner: 10Legoktm) [20:19:14] (03CR) 10Krinkle: "Yeah, the idea with limiting {{REVISIONID}} is to make the transition easier for users, as opposed to requiring adoption of something new." [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [20:19:28] (03PS3) 10Umherirrender: Autofixing MediaWiki.Commenting.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492586 (owner: 10Legoktm) [20:22:45] (03CR) 10Umherirrender: [C: 03+2] "Rebased" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492586 (owner: 10Legoktm) [20:23:27] (03Merged) 10jenkins-bot: Autofixing MediaWiki.Commenting.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492586 (owner: 10Legoktm) [20:27:38] (03PS1) 10Aaron Schulz: Add sanity check to notifyUpdatesForRevision() for $oldRev [core] - 10https://gerrit.wikimedia.org/r/495468 [20:39:01] 10Outreachy (Round 18): Improving ~20 documentation pages to help the users of the MediaWiki have a smoother experience when learning how to use our APIs - Outreachy 18 - https://phabricator.wikimedia.org/T217966 (10Didicodes) [20:40:45] 10MediaWiki-extensions-Scribunto, 10Performance: Lua memory profiling support - https://phabricator.wikimedia.org/T188492 (10jberkel) A year has passed, and this bug hasn't even been triaged. The memory problems on the English Wiktionary are still there, and ugly workarounds are needed to get some pages to ren... [20:41:41] (03CR) 10Tchanders: [C: 03+2] NamespaceMultiselectWidget: Allow filtering by namespace ID or label [core] - 10https://gerrit.wikimedia.org/r/493351 (https://phabricator.wikimedia.org/T216078) (owner: 10Mooeypoo) [20:42:32] (03PS2) 10Umherirrender: Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492588 (owner: 10Legoktm) [20:43:27] (03CR) 10Umherirrender: [C: 03+2] "Rebased" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492588 (owner: 10Legoktm) [20:44:54] 10MediaWiki-extensions-Scribunto, 10Performance: Lua memory profiling support - https://phabricator.wikimedia.org/T188492 (10Reedy) >A year has passed, and this bug hasn't even been triaged. Many bugs get fixed without ever being triaged [20:58:31] (03PS2) 10Umherirrender: Autofixing MediaWiki.WhiteSpace.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492590 (owner: 10Legoktm) [20:59:27] (03CR) 10Umherirrender: [C: 03+2] "Rebased" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492590 (owner: 10Legoktm) [20:59:55] (03Merged) 10jenkins-bot: NamespaceMultiselectWidget: Allow filtering by namespace ID or label [core] - 10https://gerrit.wikimedia.org/r/493351 (https://phabricator.wikimedia.org/T216078) (owner: 10Mooeypoo) [20:59:58] (03Merged) 10jenkins-bot: Autofixing MediaWiki.ExtraCharacters.ParenthesesAroundKeyword errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492588 (owner: 10Legoktm) [21:00:20] (03Merged) 10jenkins-bot: Autofixing MediaWiki.WhiteSpace.* errors [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/492590 (owner: 10Legoktm) [21:02:06] (03CR) 10jenkins-bot: NamespaceMultiselectWidget: Allow filtering by namespace ID or label [core] - 10https://gerrit.wikimedia.org/r/493351 (https://phabricator.wikimedia.org/T216078) (owner: 10Mooeypoo) [21:07:52] (03CR) 10Aaron Schulz: "Well, once you are replacing things with PREVIEWMODE, it probably isn't too much extra work to swap the conditional. It's used on many pag" [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [21:09:10] (03PS1) 10Umherirrender: Add phan [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 [21:09:29] (03CR) 10Umherirrender: "check experimental" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 (owner: 10Umherirrender) [21:10:11] (03CR) 10jerkins-bot: [V: 04-1] Add phan [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 (owner: 10Umherirrender) [21:10:43] (03CR) 10jerkins-bot: [V: 04-1] Add phan [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 (owner: 10Umherirrender) [21:13:31] (03PS2) 10Umherirrender: Add phan [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 [21:13:51] (03CR) 10Umherirrender: "check experimental" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/495469 (owner: 10Umherirrender) [21:21:00] 10MobileFrontend, 10Operations, 10TechCom, 10Traffic, 10Readers-Web-Backlog (Tracking): Remove .m. subdomain, serve mobile and desktop variants through the same URL - https://phabricator.wikimedia.org/T214998 (10Krinkle) >>! In T214998#5007578, @Tbayer wrote: >>>! In T214998#5005391, @Krinkle wrote: >> I... [21:24:40] (03PS1) 10Legoktm: Avoid use of func_get_args() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/495472 [21:33:13] 10Repository-Ownership-Requests: Provide access to iOS engineers for iOS group - https://phabricator.wikimedia.org/T217866 (10Legoktm) Typically groups that grant ownership have membership controlled by Gerrit administrators. If there is a need for a more rapid process, we can probably figure something out. >>!... [21:49:42] 10MediaWiki-General-or-Unknown, 10TechCom-RFC: Make clean script path the default canonical url for the Main Page - https://phabricator.wikimedia.org/T216791 (10Krinkle) @Anomie I don't think the decision of whether MW will have such an option would require an RFC. That seems trivial to decide on between +2'er... [21:50:22] 10MediaWiki-General-or-Unknown, 10TechCom-RFC: Make clean script path the default canonical url for the Main Page - https://phabricator.wikimedia.org/T216791 (10Krinkle) [21:54:17] (03PS4) 10Jack Phoenix: Replace dieUsage()/dieUsageMsg() with dieWithError() in the API modules [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483920 [21:59:37] 10MediaWiki-Installer, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10Patch-For-Review, 10TechCom-RFC (TechCom-Approved): Support running MediaWiki without 'curl' PHP extension - https://phabricator.wikimedia.org/T137926 (10Krinkle) [22:06:12] (03PS1) 10Jack Phoenix: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/495476 [22:06:28] 10MediaWiki-Installer, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10TechCom-RFC (TechCom-Approved): Support running MediaWiki without 'curl' PHP extension - https://phabricator.wikimedia.org/T137926 (10Krinkle) Now that things work without cURL, including... [22:06:31] 10MediaWiki-Installer, 10Core Platform Team (Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10TechCom-RFC (TechCom-Approved): Support running MediaWiki without 'curl' PHP extension - https://phabricator.wikimedia.org/T137926 (10Krinkle) [22:06:36] (03Abandoned) 10Jack Phoenix: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CodeReview [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/495476 (owner: 10Jack Phoenix) [22:15:23] (03PS1) 10Krinkle: installer: Remove redundant $key variable [core] - 10https://gerrit.wikimedia.org/r/495477 [22:20:25] (03CR) 10Krinkle: "Is this still an issue? Or have other mechanisms evolved since solved the underlying need?" [core] - 10https://gerrit.wikimedia.org/r/324202 (owner: 10Jack Phoenix) [22:25:26] (03PS5) 10Jack Phoenix: Don't allow write actions when the DB is locked [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/242726 (https://phabricator.wikimedia.org/T28431) [22:26:43] (03CR) 10D3r1ck01: "Sweet!" [core] - 10https://gerrit.wikimedia.org/r/495477 (owner: 10Krinkle) [22:26:49] (03CR) 10D3r1ck01: [C: 03+2] installer: Remove redundant $key variable [core] - 10https://gerrit.wikimedia.org/r/495477 (owner: 10Krinkle) [22:30:11] (03CR) 10Jack Phoenix: "@Krinkle: Thanks for the CR, very nice catch! Indeed, my patch was merely preventing the "(un)link" link from showing up in the UI when th" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/242726 (https://phabricator.wikimedia.org/T28431) (owner: 10Jack Phoenix) [22:33:36] (03CR) 10Krinkle: "We normally don't call wfReadOnly() for showing interface elements, given it requires non-trivial database interaction to determine read-o" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/242726 (https://phabricator.wikimedia.org/T28431) (owner: 10Jack Phoenix) [22:36:16] (03CR) 10Jack Phoenix: "@Krinkle: As far as I'm aware, there aren't any other mechanisms. That being said, I'd love to be proven wrong. :) To test out the issue t" [core] - 10https://gerrit.wikimedia.org/r/324202 (owner: 10Jack Phoenix) [22:39:03] (03Merged) 10jenkins-bot: installer: Remove redundant $key variable [core] - 10https://gerrit.wikimedia.org/r/495477 (owner: 10Krinkle) [22:41:19] (03CR) 10jenkins-bot: installer: Remove redundant $key variable [core] - 10https://gerrit.wikimedia.org/r/495477 (owner: 10Krinkle) [22:41:25] (03PS1) 10D3r1ck01: maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 [22:42:01] (03CR) 10Krinkle: [C: 04-1] "The new(er) mechanism is the concept of a system block (such as used by MW for proxyblocker, dnsbl, etc.) and the GlobalBlocking extension" [core] - 10https://gerrit.wikimedia.org/r/324202 (owner: 10Jack Phoenix) [22:42:55] (03CR) 10Krinkle: [C: 04-1] [WIP] Use mw.util to get the element ID for skin-agnosticness (031 comment) [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/393080 (https://phabricator.wikimedia.org/T181242) (owner: 10Jack Phoenix) [22:43:41] 10MediaWiki-Categories: Use {{DISPLAYTITLE}} as link label on category pages - https://phabricator.wikimedia.org/T19212 (10Krinkle) [22:55:39] 10WMSE-Riksarkivet-TORA: RAÄ Fornsök GET URL objektid RAÄnummer - https://phabricator.wikimedia.org/T217947 (10Salgo60) [23:04:38] 10Repository-Ownership-Requests: Provide access to iOS engineers for iOS group - https://phabricator.wikimedia.org/T217866 (10NHarateh_WMF) @Legoktm the Gerrit username for Natalia is nharateh@wikimedia.org (that's me). Thanks! [23:06:26] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:09:22] 10MediaWiki-extensions-Variables: Split ExtVariables into multiple classes - https://phabricator.wikimedia.org/T202421 (10MGChecker) [23:19:10] 10MediaWiki-Categories: Use display title of category in page footer (reflecting lower-intial per DISPLAYTITLE) - https://phabricator.wikimedia.org/T18350 (10Krinkle) [23:30:30] (03CR) 10Krinkle: [C: 03+2] maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:31:04] (03CR) 10Krinkle: maintenance: Replace deprecated global $wgParser with getParser() service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:31:16] (03CR) 10Krinkle: "sorry about that, didn't see it at first." [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:32:43] (03PS1) 10D3r1ck01: i18n: Reword Save to Publish buttons for mobile view sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495480 (https://phabricator.wikimedia.org/T191104) [23:33:00] (03PS3) 10Krinkle: Modernization for MW 1.32+ [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/483926 (owner: 10Jack Phoenix) [23:33:02] (03CR) 10Krinkle: [C: 03+1] Modernization for MW 1.32+ [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/483926 (owner: 10Jack Phoenix) [23:33:20] (03CR) 10Krinkle: [C: 03+2] Slight modernization & cleanup [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/483934 (owner: 10Jack Phoenix) [23:34:22] (03CR) 10Krinkle: Don't use deprecated methods; now requires MW 1.32+ (031 comment) [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/483774 (owner: 10Jack Phoenix) [23:34:24] (03CR) 10Krinkle: [C: 03+2] Don't use deprecated methods; now requires MW 1.32+ [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/483774 (owner: 10Jack Phoenix) [23:36:01] (03PS2) 10D3r1ck01: maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 [23:36:16] (03CR) 10Krinkle: [C: 03+2] Fix the accessibility ("jump to") links [skins/Dusk] - 10https://gerrit.wikimedia.org/r/494358 (owner: 10Jack Phoenix) [23:36:24] (03CR) 10D3r1ck01: maintenance: Replace deprecated global $wgParser with getParser() service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:37:00] (03CR) 10D3r1ck01: "> sorry about that, didn't see it at first." [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:37:05] (03CR) 10Krinkle: Fix the accessibility ("jump to") links (031 comment) [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/494357 (owner: 10Jack Phoenix) [23:37:39] (03CR) 10Krinkle: [C: 03+2] maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:37:57] (03CR) 10Krinkle: [C: 03+2] Fix the accessibility ("jump to") links [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/494360 (owner: 10Jack Phoenix) [23:38:09] (03CR) 10Krinkle: [C: 03+2] Fix the accessibility ("jump to") links [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/494359 (owner: 10Jack Phoenix) [23:38:18] (03CR) 10jerkins-bot: [V: 04-1] i18n: Reword Save to Publish buttons for mobile view sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495480 (https://phabricator.wikimedia.org/T191104) (owner: 10D3r1ck01) [23:39:54] (03CR) 10Krinkle: [C: 03+2] Basic cleanup and whatnot [skins/Splash] - 10https://gerrit.wikimedia.org/r/494380 (owner: 10Jack Phoenix) [23:40:25] (03CR) 10Krinkle: [C: 03+2] Fix JS notice/warning: Use of the "edit" token is deprecated. Use "csrf" instead. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/494662 (owner: 10Jack Phoenix) [23:41:16] (03Merged) 10jenkins-bot: Slight modernization & cleanup [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/483934 (owner: 10Jack Phoenix) [23:41:18] (03Merged) 10jenkins-bot: Don't use deprecated methods; now requires MW 1.32+ [extensions/RefreshSpecial] - 10https://gerrit.wikimedia.org/r/483774 (owner: 10Jack Phoenix) [23:41:20] (03Merged) 10jenkins-bot: Fix the accessibility ("jump to") links [skins/Dusk] - 10https://gerrit.wikimedia.org/r/494358 (owner: 10Jack Phoenix) [23:42:35] 10MobileFrontend, 10Readers-Web-Backlog: MobileFormatterTest::testT137375 is risky (does not perform any assertions) - https://phabricator.wikimedia.org/T191710 (10D3r1ck01) Maybe I'm missing something but does this still occur? ` └─ $ ▶ php ../../tests/phpunit/phpunit.php tests/phpunit/MobileFormatterTest.php... [23:43:27] (03CR) 10D3r1ck01: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495480 (https://phabricator.wikimedia.org/T191104) (owner: 10D3r1ck01) [23:48:53] (03CR) 10jerkins-bot: [V: 04-1] i18n: Reword Save to Publish buttons for mobile view sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495480 (https://phabricator.wikimedia.org/T191104) (owner: 10D3r1ck01) [23:56:23] (03Merged) 10jenkins-bot: maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:56:25] (03Merged) 10jenkins-bot: Fix the accessibility ("jump to") links [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/494360 (owner: 10Jack Phoenix) [23:56:27] (03Merged) 10jenkins-bot: Fix the accessibility ("jump to") links [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/494359 (owner: 10Jack Phoenix) [23:56:29] (03Merged) 10jenkins-bot: Basic cleanup and whatnot [skins/Splash] - 10https://gerrit.wikimedia.org/r/494380 (owner: 10Jack Phoenix) [23:56:31] (03Merged) 10jenkins-bot: Don't use OutputPage#addModuleScripts for loading a CSS-only module that is already loaded w/ addModuleStyles() [skins/Splash] - 10https://gerrit.wikimedia.org/r/494381 (owner: 10Jack Phoenix) [23:56:33] (03Merged) 10jenkins-bot: Fix JS notice/warning: Use of the "edit" token is deprecated. Use "csrf" instead. [extensions/VoteNY] - 10https://gerrit.wikimedia.org/r/494662 (owner: 10Jack Phoenix) [23:58:39] (03CR) 10jenkins-bot: maintenance: Replace deprecated global $wgParser with getParser() service [core] - 10https://gerrit.wikimedia.org/r/495478 (owner: 10D3r1ck01) [23:59:19] (03PS2) 10D3r1ck01: i18n: Reword Save to Publish buttons for mobile view sites [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/495480 (https://phabricator.wikimedia.org/T191104)