[00:05:03] (03CR) 10Brian Wolff: "> Can it go in IMaintainableDatabase instead?" [core] - 10https://gerrit.wikimedia.org/r/491035 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:15:44] (03Merged) 10jenkins-bot: Various fixes to make phan-taint-check happier [core] - 10https://gerrit.wikimedia.org/r/491041 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:15:50] (03Merged) 10jenkins-bot: Add method scope visibility [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [00:18:12] (03CR) 10jenkins-bot: Various fixes to make phan-taint-check happier [core] - 10https://gerrit.wikimedia.org/r/491041 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [00:27:33] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [00:40:09] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/493979 [00:41:48] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 [00:45:25] (03PS1) 10Base: Fixing several links to wmfwiki through wikimediafoundation.org [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/493981 [00:45:55] 10MediaWiki-ContentHandler, 10MassMessage: Users without 'editcontentmodel' user right cannot create MassMessage delivery lists - https://phabricator.wikimedia.org/T92795 (10Xaosflux) [00:45:59] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [00:47:07] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/Cite] - 10https://gerrit.wikimedia.org/r/493983 [00:48:25] (03PS2) 10Base: Fixing several links to wmfwiki through wikimediafoundation.org [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/493981 [00:49:48] (03PS2) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/Cite] - 10https://gerrit.wikimedia.org/r/493983 [00:51:31] 10Wikimedia-Wikimania-Scholarships, 10Patch-For-Review: Update form privacy link - https://phabricator.wikimedia.org/T217327 (10Base) Oh, I created https://gerrit.wikimedia.org/r/#/c/wikimedia/wikimania-scholarships/r/493981/ unware of this one. It contains another link fix but does not contain the editorial fix. [00:52:20] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [00:52:48] (03CR) 10Reedy: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/Cite] - 10https://gerrit.wikimedia.org/r/493983 (owner: 10Umherirrender) [00:53:05] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/493979 (owner: 10Umherirrender) [00:53:21] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [00:55:38] 10Wikimedia-Site-requests: add editcontentmodel access to the templateeditor group on testwiki - https://phabricator.wikimedia.org/T217499 (10Xaosflux) [00:56:28] 10Wikimedia-Site-requests: add editcontentmodel access to the templateeditor group on testwiki - https://phabricator.wikimedia.org/T217499 (10Xaosflux) [00:56:36] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493984 [00:56:53] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [00:58:21] 10Wikimedia-Site-requests: add editcontentmodel access to the templateeditor group on testwiki - https://phabricator.wikimedia.org/T217499 (10Xaosflux) [00:59:47] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493984 (owner: 10Umherirrender) [01:02:18] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/493985 [01:03:07] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Cite] - 10https://gerrit.wikimedia.org/r/493983 (owner: 10Umherirrender) [01:03:09] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/493979 (owner: 10Umherirrender) [01:05:14] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/493979 (owner: 10Umherirrender) [01:05:19] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/493986 [01:05:44] (03PS1) 10Umherirrender: Remove compat code for version 1.27 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493987 [01:05:46] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493988 [01:06:06] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/493989 [01:06:21] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [01:06:42] (03CR) 10Reedy: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/493986 (owner: 10Umherirrender) [01:06:48] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493990 [01:07:25] (03PS1) 10Umherirrender: Remove compat code for version 1.27 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493991 [01:07:27] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493992 [01:07:46] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493988 (owner: 10Umherirrender) [01:08:03] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/493989 (owner: 10Umherirrender) [01:09:03] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493992 (owner: 10Umherirrender) [01:09:21] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493990 (owner: 10Umherirrender) [01:09:40] (03CR) 10Reedy: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/493985 (owner: 10Umherirrender) [01:09:58] (03CR) 10Reedy: [C: 03+2] Remove compat code for version 1.27 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493991 (owner: 10Umherirrender) [01:10:14] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [01:13:11] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493984 (owner: 10Umherirrender) [01:13:13] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/493986 (owner: 10Umherirrender) [01:13:15] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/493989 (owner: 10Umherirrender) [01:13:41] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/493993 [01:14:42] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493988 [01:14:45] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493990 (owner: 10Umherirrender) [01:14:47] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/493985 (owner: 10Umherirrender) [01:14:49] (03Merged) 10jenkins-bot: Remove compat code for version 1.27 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493991 (owner: 10Umherirrender) [01:14:51] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/493992 (owner: 10Umherirrender) [01:14:53] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493988 (owner: 10Umherirrender) [01:15:42] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493984 (owner: 10Umherirrender) [01:18:03] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/493986 (owner: 10Umherirrender) [01:18:18] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493988 (owner: 10Umherirrender) [01:18:53] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493990 (owner: 10Umherirrender) [01:21:10] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [01:21:26] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/493985 (owner: 10Umherirrender) [01:22:09] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493994 [01:22:55] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493995 [01:23:38] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/493996 [01:25:58] (03PS1) 10Krinkle: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 [01:26:35] (03PS2) 10Krinkle: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) [01:27:21] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/493996 (owner: 10Umherirrender) [01:27:57] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [01:29:07] (03CR) 10Krinkle: [C: 04-1] maintenance: Fixes to code for improvements (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [01:30:44] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493998 [01:30:47] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493999 [01:33:36] (03CR) 10jerkins-bot: [V: 04-1] resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [01:35:15] (03PS3) 10Krinkle: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 [01:36:12] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/494000 [01:36:20] (03PS1) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/494001 [01:36:27] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [01:40:21] (03PS3) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [01:43:42] 10SpamBlacklist: Make the spam whitelist its own slot - https://phabricator.wikimedia.org/T203157 (10Izno) If we wanted still to whitelist an entire domain on a particular Wikipedia (as opposed to the blacklist currently at Meta), that should still be at the MediaWiki version of the page. [01:44:42] (03PS4) 10Krinkle: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) [01:44:46] (03PS1) 10Krinkle: resources: Remove 'jquery.mockjax' module [core] - 10https://gerrit.wikimedia.org/r/494003 (https://phabricator.wikimedia.org/T202154) [01:44:58] (03CR) 10Krinkle: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/494000 (owner: 10Umherirrender) [01:45:25] (03CR) 10Krinkle: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/494001 (owner: 10Umherirrender) [01:47:05] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/493737 [01:54:58] (03PS1) 10Krinkle: resources: Remove deprecated 'jquery.hidpi' module [core] - 10https://gerrit.wikimedia.org/r/494004 (https://phabricator.wikimedia.org/T202154) [01:55:51] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [01:56:23] (03CR) 10Umherirrender: "recheck" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/493996 (owner: 10Umherirrender) [02:00:08] (03PS1) 10Krinkle: build: Add names to Fresnel scenarios [core] - 10https://gerrit.wikimedia.org/r/494005 [02:01:09] 10MediaWiki-extensions-Scribunto: Provide a loadJsonData with same characteristics as loadData - https://phabricator.wikimedia.org/T217500 (10Izno) [02:01:16] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/494000 (owner: 10Umherirrender) [02:01:18] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/494001 (owner: 10Umherirrender) [02:04:30] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/494001 (owner: 10Umherirrender) [02:04:55] (03PS5) 10Krinkle: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) [02:05:17] (03CR) 10Krinkle: [C: 03+2] Use ::class for class name resolution [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/493996 (owner: 10Umherirrender) [02:10:48] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/493996 (owner: 10Umherirrender) [02:11:03] (03CR) 10Krinkle: "Failure from patch check is expected on this commit, given the before/after is null here, as there is no correction between the keys. This" [core] - 10https://gerrit.wikimedia.org/r/494005 (owner: 10Krinkle) [02:11:16] (03PS2) 10Krinkle: resources: Remove 'jquery.mockjax' module [core] - 10https://gerrit.wikimedia.org/r/494003 (https://phabricator.wikimedia.org/T202154) [02:11:25] (03PS2) 10Krinkle: resources: Remove deprecated 'jquery.hidpi' module [core] - 10https://gerrit.wikimedia.org/r/494004 (https://phabricator.wikimedia.org/T202154) [02:24:49] (03CR) 10Legoktm: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493998 (owner: 10Umherirrender) [02:25:03] (03CR) 10Legoktm: [C: 03+2] Use ::class for class name resolution [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493999 (owner: 10Umherirrender) [02:28:48] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493998 (owner: 10Umherirrender) [02:29:13] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493999 (owner: 10Umherirrender) [02:31:24] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493998 (owner: 10Umherirrender) [02:33:44] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493999 (owner: 10Umherirrender) [02:42:31] (03CR) 10Krinkle: [C: 03+1] "Neat hack. The dash still passes indeed." [core] - 10https://gerrit.wikimedia.org/r/294774 (https://phabricator.wikimedia.org/T137900) (owner: 10Aaron Schulz) [02:45:02] (03CR) 10Krinkle: [C: 04-1] "From Jenkins:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493611 (owner: 10Aaron Schulz) [03:13:00] 10MediaWiki-Interface, 10MediaWiki-Internationalization, 10I18n: MediaWiki:Talkpageheader message does not handle language fallbacks - https://phabricator.wikimedia.org/T217357 (10A2093064) @Yurik If there is a default message from translatewiki.net, it (eg. `MediaWiki:Talkpageheader/xx`) will fallback to de... [03:18:21] 10MediaWiki-Interface, 10MediaWiki-Internationalization, 10I18n: MediaWiki:Talkpageheader message does not handle language fallbacks - https://phabricator.wikimedia.org/T217357 (10Yurik) @A2093064 The `talkpageheader` message is set to a `"-"` by default - see [[ https://github.com/wikimedia/mediawiki/blob/9... [03:49:34] 10MediaWiki-Interface, 10MediaWiki-Internationalization, 10I18n: MediaWiki:Talkpageheader message does not handle language fallbacks - https://phabricator.wikimedia.org/T217357 (10A2093064) @Yurik This defines that this message exists and is empty by default (like [[ https://translatewiki.net/wiki/MediaWiki:... [04:00:30] (03CR) 10VolkerE: [C: 03+2] resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [04:00:53] (03CR) 10Krinkle: [C: 03+2] build: Add names to Fresnel scenarios [core] - 10https://gerrit.wikimedia.org/r/494005 (owner: 10Krinkle) [04:09:23] (03CR) 10Krinkle: [C: 03+2] includes: Improve on code for consistency, efficiency and maintainability [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/493962 (owner: 10D3r1ck01) [04:15:54] (03Merged) 10jenkins-bot: build: Add names to Fresnel scenarios [core] - 10https://gerrit.wikimedia.org/r/494005 (owner: 10Krinkle) [04:15:59] (03Merged) 10jenkins-bot: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [04:18:23] (03CR) 10jenkins-bot: resources: Remove 'jquery.xmldom' module [core] - 10https://gerrit.wikimedia.org/r/493997 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [04:19:58] (03CR) 10jenkins-bot: build: Add names to Fresnel scenarios [core] - 10https://gerrit.wikimedia.org/r/494005 (owner: 10Krinkle) [04:22:11] (03Merged) 10jenkins-bot: includes: Improve on code for consistency, efficiency and maintainability [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/493962 (owner: 10D3r1ck01) [04:24:29] (03CR) 10jenkins-bot: includes: Improve on code for consistency, efficiency and maintainability [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/493962 (owner: 10D3r1ck01) [04:59:13] 10Product-Analytics: Aggregate and save the Google Translate Pageview count temporarily - https://phabricator.wikimedia.org/T215093 (10chelsyx) >>! In T215093#4953181, @Tbayer wrote: > Will it be possible later to backfill/update/extend either [[https://wikitech.wikimedia.org/wiki/Analytics/Data_Lake/Traffic/Vir... [05:00:07] 10Product-Analytics: Aggregate and save the Google Translate Pageview count temporarily - https://phabricator.wikimedia.org/T215093 (10chelsyx) [05:06:43] 10Product-Analytics: Aggregate and save the Google Translate Pageview count temporarily - https://phabricator.wikimedia.org/T215093 (10chelsyx) @dr0ptp4kt About the difference between `home_language` and `to_language`, I did some investigation and found that `home_language` controls the translation engine langua... [05:32:44] 10Design, 10MediaWiki-Interface, 10TechCom-RFC, 10Readers-Web-Backlog (Design): RFC: Section headings should have a clickable anchor - https://phabricator.wikimedia.org/T18691 (10Quiddity) >>! In T18691#4994518, @osorio-juan-microsoft wrote: > I like the idea of the share button, even though it adds an ext... [05:51:20] 10Hashtags: Fix worker timeout issues on production - https://phabricator.wikimedia.org/T209359 (10AdityaJ) @Samwalton9 Shall I go ahead and restrict the search for #flickr2commons for now? [05:54:22] 10Wikimedia-Site-requests: add editcontentmodel access to the templateeditor group on testwiki - https://phabricator.wikimedia.org/T217499 (10Ammarpad) a:03Ammarpad [05:55:00] (03CR) 10Legoktm: "> Patch Set 1:" [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [05:55:16] 10Wikimedia-Site-requests: add editcontentmodel access to the templateeditor group on testwiki - https://phabricator.wikimedia.org/T217499 (10Ammarpad) p:05Triage→03Normal [05:55:22] 10Chinese-Sites: The ICON position in banner of Chinese Wikivoyage, does not automatically convert to traditional or simplified Chinese text. - https://phabricator.wikimedia.org/T217501 (10Yuriy_kosygin) [05:57:26] 10Chinese-Sites: The ICON position in banner of Chinese Wikivoyage, does not automatically convert to traditional or simplified Chinese text. - https://phabricator.wikimedia.org/T217501 (10Yuriy_kosygin) [05:59:44] 10Chinese-Sites: The ICON position in banner of Chinese Wikivoyage, does not automatically convert to traditional or simplified Chinese text. - https://phabricator.wikimedia.org/T217501 (10Yuriy_kosygin) add @zhuyifei1999, @A2093064 [06:03:55] 10Outreachy (Round 18): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T217439 (10Ujjwalagrawal17) [06:22:56] 10Outreach-Programs-Projects, 10Outreachy (Round 18): Add leaderboard based on user's edits using Commons Android app - https://phabricator.wikimedia.org/T217439 (10Ujjwalagrawal17) [06:28:48] 10Hashtags: Allow wildcard project searches - https://phabricator.wikimedia.org/T216400 (10AdityaJ) @Samwalton9 I would like to work on this but have a small doubt here. Can a user enter multiple * in the project field or will a user be allowed to enter any regex string? Also can a * be present anywhere in the s... [07:14:13] (03CR) 10Legoktm: "> Patch Set 1:" [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [07:24:24] 10MediaWiki-extensions-Translate, 10User-Nikerabbit, 10User-abi_, 10Wikimedia-production-error: Fatal error on Special:Translate for certain 'language' values - https://phabricator.wikimedia.org/T204833 (10abi_) a:03abi_ [07:41:18] 10MediaWiki-API: API: how to get the page-size from query-langlinks - https://phabricator.wikimedia.org/T217387 (10Sh60) thank you for this, but when I enter your URL https://de.wikipedia.org//w/api.php?action=query&format=json&prop=langlinks|revision&llprop=langname|url|autonym&rvprop=size it gives me no resul... [08:40:25] (03CR) 10Daimona Eaytoy: "Thanks! Out of curiosity, will this be added as a phpcs rule?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [08:43:10] (03CR) 10Daimona Eaytoy: "> > Patch Set 1:" [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [08:48:16] (03PS3) 10Fomafix: Remove deprecated Language::markNoConversion [core] - 10https://gerrit.wikimedia.org/r/493790 [09:07:02] (03PS1) 10Raimond Spekking: Prefix message with skin name to avoid key conflict [skins/Anisa] - 10https://gerrit.wikimedia.org/r/494012 [09:10:04] Hi I'm interested in refactoring in PHP. Even have simple site http://phprefactor.com/ [09:10:08] I was thinking about making blog posts or videos about refactoring MediaWiki. [09:10:16] What do you think? [09:10:24] Yesterday I just have made first refactoring. Please review this https://gerrit.wikimedia.org/r/c/mediawiki/core/+/493835 [09:19:42] slk500: Outcome 3 / Output 3.4 of https://www.mediawiki.org/wiki/Wikimedia_Technology/Annual_Plans/FY2019/TEC13:_Code_Health/Goals says "Reduce Technical Debt" so to me it sounds like something that's welcome. :) [09:19:59] There are a lot of potential tasks at https://phabricator.wikimedia.org/tag/technical-debt/ [09:20:14] Just wondering how much capacity there is to review contributed patches...as usual :-/ [09:25:21] so review is bottleneck [09:29:45] right know just need the first 'kick' -> review to boost my enthusiasm ;) [09:37:13] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Gopavasanth) [09:40:48] (03PS1) 10Fomafix: Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/494013 [09:41:19] (03PS1) 10D3r1ck01: jobs: Fix method name from getID() as defined in SecurePoll_Entity [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494014 [09:41:43] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Doc_James) Excited to see this being worked on. A critical functionality for our movement. [09:43:26] (03CR) 10Zoranzoki21: [C: 04-1] "I think we shouldn't do this." [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [09:46:33] (03CR) 10Zoranzoki21: [C: 03+1] Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/494013 (owner: 10Fomafix) [09:47:48] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Gopavasanth) [09:54:51] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Aklapper) To understand correctly: This is basically * https://superuser.com/questions/1228698/how-do-i-split-a-long-video-into-multiple-shorter-videos-efficiently * https://stackoverflow.com/questions/56... [09:54:58] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Gopavasanth) [09:58:36] (03CR) 10Umherirrender: "I am working at a phan plugin" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [10:01:53] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494014 (owner: 10D3r1ck01) [10:02:04] (03CR) 10Umherirrender: "Maybe a plugin which implements SuppressionCapability could suppress the unused issues when there are for the security plugin." [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [10:04:24] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Rogueassasin123) @Aklapper: Yes, that's about right :) [10:07:27] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Henwilwal) Hi I have run the selects against the Wiki database (table names are prefixed with 'argos'). my... [10:30:34] (03CR) 10Daimona Eaytoy: "> I am working at a phan plugin" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493980 (owner: 10Umherirrender) [10:34:46] (03CR) 10Gergő Tisza: [C: 03+2] jobs: Fix method name from getID() as defined in SecurePoll_Entity [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494014 (owner: 10D3r1ck01) [10:38:33] (03Merged) 10jenkins-bot: jobs: Fix method name from getID() as defined in SecurePoll_Entity [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494014 (owner: 10D3r1ck01) [10:45:29] (03CR) 10Daimona Eaytoy: "Filed https://github.com/phan/phan/issues/2515 upstream." [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [10:49:13] 10MediaWiki-Vendor, 10Wikidata, 10Wikidata-Campsite, 10wikidata-tech-focus: Wikidata vendor versions updates (Feb 2019) - https://phabricator.wikimedia.org/T215853 (10Lydia_Pintscher) All subtasks are resolved. Can this be closed? [10:53:03] (03CR) 10Daimona Eaytoy: [C: 03+1] Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [10:54:44] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Daimona) While I know the CI revert is temporary, I'd like to point out that CheckUser is currently bro... [10:59:37] (03PS9) 10MarcoAurelio: Split api.* messages to a separate folder [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/489481 (https://phabricator.wikimedia.org/T214983) [11:04:20] 10InternetArchiveBot (v2.0): Parameter mappings disappeared - https://phabricator.wikimedia.org/T211723 (10Cirdan) p:05Triage→03High @Cyberpower678 I tried to add a configuration for Internetquelle, but I fear everything has disappeared again, despite the interface claiming everything went alright: {F283184... [11:08:46] (03CR) 10Umherirrender: [C: 03+2] Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/494013 (owner: 10Fomafix) [11:09:34] (03Merged) 10jenkins-bot: Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/494013 (owner: 10Fomafix) [11:14:46] 10ContentTranslation, 10Language-Team (Language-2019-January-March): CX2: Invite Arabic Wikipedia to try version 2 - https://phabricator.wikimedia.org/T211571 (10alanajjar) >If you can share your impressions on the reviewed content, that would be very useful. If we take a look on [[https://ar.wikipedia.org/w/... [11:22:51] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review+2" [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494014 (owner: 10D3r1ck01) [11:34:47] 10WMSE-Riksarkivet-TORA: Arkivkopia make something with them and Wikidata?!?! - https://phabricator.wikimedia.org/T217404 (10Salgo60) [11:38:22] (03CR) 10Mainframe98: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/493373 (https://phabricator.wikimedia.org/T217315) (owner: 10Mainframe98) [11:41:49] 10Google-Summer-of-Code (2019): Tool to cut videos in Commons - https://phabricator.wikimedia.org/T217503 (10Framawiki) [[ https://github.com/toolforge/video2commons | Video2Commons code ]] can be useful. [11:52:29] (03CR) 10D3r1ck01: [C: 03+1] "I think this is good (virtual +2). But let someone that is comfortable with the pager module or its maintainer land this :)" [core] - 10https://gerrit.wikimedia.org/r/482039 (owner: 10Umherirrender) [11:57:59] (03CR) 10D3r1ck01: "LGTM! Waiting for a signal from @Thiemo as regards the comment. Maybe it should be done in another patch?" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/493391 (owner: 10Thiemo Kreuz (WMDE)) [12:16:32] 10MassMessage, 10Chinese-Sites: Massmessage list "add page" field not working - https://phabricator.wikimedia.org/T217240 (10A2093064) 05Open→03Resolved a:03Legoktm It works now. [12:27:56] (03PS1) 10D3r1ck01: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 [12:35:49] (03CR) 10MarcoAurelio: "Was this tested? Thanks." [extensions/WhiteSpace] - 10https://gerrit.wikimedia.org/r/493168 (https://phabricator.wikimedia.org/T216476) (owner: 10Sumanth699) [12:40:36] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) [12:41:02] (03CR) 10Jayprakash12345: [C: 03+1] "Yeah, I gave +1 after testing. It is removing white spaces as expected." [extensions/WhiteSpace] - 10https://gerrit.wikimedia.org/r/493168 (https://phabricator.wikimedia.org/T216476) (owner: 10Sumanth699) [12:43:57] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) Hello! I want to work on this issue. I'm a new contributor. I've already assigned myself to on... [12:55:22] 10MediaWiki-File-management, 10MediaWiki-History-and-Diffs, 10MediaWiki-Logging, 10Commons, and 2 others: File revert counts as 'overwrite', not 'revert' - https://phabricator.wikimedia.org/T60209 (10MGChecker) 05Open→03Resolved [12:57:13] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) >>! In T201491#4996195, @Olena23 wrote: > Hello! I want to work on this issue. I'm a new c... [13:07:25] (03Abandoned) 10FR30799386: Remove pagetriage link from toolbar after click [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492452 (https://phabricator.wikimedia.org/T158513) (owner: 10FR30799386) [13:09:23] 10crosswatch: Crosswatch gives a server-error after login: "No watchlist could be retrieved" - https://phabricator.wikimedia.org/T144083 (10OriHoch) crosswatch uses an oauth consumer key for login, all docs seem to point to this page to request a key, but it is not available (I'm getting unauthorized on that pag... [13:18:10] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Meno25) [13:23:25] (03CR) 10Fomafix: [C: 04-1] "The call" [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [13:23:55] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) @Zoranzoki21 thank you for the explanation. Is this Gerrit tutorial only used for Gerrit proje... [13:28:17] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) >>! In T201491#4996222, @Olena23 wrote: > @Zoranzoki21 thank you for the explanation. Is t... [13:32:38] (03CR) 10Umherirrender: Update PHPDoc types in several maintenance scripts and related (032 comments) [core] - 10https://gerrit.wikimedia.org/r/493391 (owner: 10Thiemo Kreuz (WMDE)) [13:34:02] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10User-Zoranzoki21: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Zoranzoki21) a:03Zoranzoki21 So we should remove ns 104? [13:43:25] 10MediaWiki-extensions-Scribunto, 10CodeEditor: CodeEditor on lua subpages - https://phabricator.wikimedia.org/T217508 (10nyemini) maybe scribunto is related too. [13:45:43] (03PS2) 10D3r1ck01: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 [13:46:18] (03CR) 10D3r1ck01: "You're very correct. Thank you. How did I miss that? :(" [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [13:46:50] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Umherirrender) In case of `table_name.*` the `table_name` could be the table alias and not the name of... [13:47:49] (03PS3) 10D3r1ck01: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 [13:49:39] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10User-Zoranzoki21: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Meno25) >>! In T217507#4996235, @Zoranzoki21 wrote: > So we should remove ns 104? Yes, please. [13:50:26] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10User-Zoranzoki21: FlaggedRevs still treats a removed namespace as if it still exists (arwiki) - https://phabricator.wikimedia.org/T217507 (10Zoranzoki21) >>! In T217507#4996241, @Meno25 wrote: >>>! In T217507#4996235, @Zoranzoki21 wrote: >> So... [13:54:32] (03PS4) 10D3r1ck01: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 [13:55:36] (03PS1) 10Fomafix: Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 [13:56:14] (03CR) 10Umherirrender: [C: 03+2] build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/493737 (owner: 10Umherirrender) [13:56:33] (03CR) 10Fomafix: "For the wrong documentation I created Ib6d844ddfe5bd6ccd72b887a63d9ad476c8d196f. I found several more errors." [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [13:56:43] (03CR) 10Umherirrender: [C: 03+2] build: Add phpcbf to composer fix [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/493735 (owner: 10Umherirrender) [13:57:40] 10Toolforge-standards-committee: Adoption request for crosswatch - https://phabricator.wikimedia.org/T217509 (10OriHoch) [13:59:35] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 24.0.0 [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/493737 (owner: 10Umherirrender) [14:01:04] (03Merged) 10jenkins-bot: build: Add phpcbf to composer fix [extensions/BlueSpiceContextMenu] - 10https://gerrit.wikimedia.org/r/493735 (owner: 10Umherirrender) [14:01:13] (03CR) 10D3r1ck01: "Wow :), turns out that patch brought some light :) Nice!" [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:01:43] (03PS3) 10Umherirrender: Use RecentChange::getAttribute instead of property access [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/483843 [14:04:06] 10Social-Tools, 10SocialProfile, 10Patch-For-Review: SocialProfile Database Error - https://phabricator.wikimedia.org/T217423 (10ashley) >>! In T217423#4995007, @TheROFL98 wrote: > It appears it's now giving me a new error. Thanks for testing and letting me know -- I was hoping that it'd just work as I copi... [14:04:49] (03CR) 10D3r1ck01: [C: 03+2] "Thank you!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:05:43] (03PS5) 10D3r1ck01: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 [14:06:14] (03PS2) 10Umherirrender: build: Add grunt-banana-checker [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493804 [14:06:17] (03CR) 10Umherirrender: [C: 03+2] build: Add grunt-banana-checker [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493804 (owner: 10Umherirrender) [14:07:50] (03CR) 10Fomafix: [C: 03+2] "Tested with the webinstaller." [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [14:07:52] (03CR) 10D3r1ck01: [C: 04-2] "Ops, hit the +2 by mistake, blocking it now as the patch may likely fail. I'll remove after blocking the merge." [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:07:57] (03CR) 10jerkins-bot: [V: 04-1] Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:09:47] (03PS2) 10D3r1ck01: Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:10:54] (03CR) 10D3r1ck01: "This should be good to go now, sorry about the -2. Will wait for Jenkins to vote this before I merge." [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:11:10] (03Merged) 10jenkins-bot: build: Add grunt-banana-checker [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493804 (owner: 10Umherirrender) [14:11:13] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [14:11:32] (03CR) 10D3r1ck01: "> Tested with the webinstaller." [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [14:11:34] 10MediaWiki-Vendor, 10Wikidata, 10Wikidata-Campsite, 10wikidata-tech-focus: Wikidata vendor versions updates (Feb 2019) - https://phabricator.wikimedia.org/T215853 (10Reedy) 05Open→03Stalled >>! In T215853#4996141, @Lydia_Pintscher wrote: > All subtasks are resolved. Can this be closed? Nope. @Addshor... [14:11:57] 10ContentTranslation: CX2: Inspecting the link in the source column shows a link to the target wiki - https://phabricator.wikimedia.org/T217511 (10Amire80) [14:12:17] 10ContentTranslation: CX2: Inspecting the link in the source column shows a link to the target wiki - https://phabricator.wikimedia.org/T217511 (10Amire80) [14:12:20] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): CX2: Show link card for source links - https://phabricator.wikimedia.org/T197075 (10Amire80) [14:13:14] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) [14:14:21] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494023 [14:15:01] (03PS1) 10Umherirrender: Remove test script wfTest.php [extensions/Math] - 10https://gerrit.wikimedia.org/r/494024 [14:15:20] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/494025 [14:15:54] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/494026 [14:16:32] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/494027 [14:16:58] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): CX2: Show link card for source links - https://phabricator.wikimedia.org/T197075 (10Amire80) >>! In T197075#4995003, @Etonkovidova wrote: > Presently it's not possible to add just a link from a s... [14:17:04] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/494028 [14:17:21] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493995 (owner: 10Umherirrender) [14:17:47] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494029 [14:20:00] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) @Olena23 Good start! [14:20:12] (03Merged) 10jenkins-bot: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [14:20:23] (03CR) 10D3r1ck01: "And others too." (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [14:21:57] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/493993 (owner: 10Umherirrender) [14:22:08] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493995 (owner: 10Umherirrender) [14:22:31] (03CR) 10jenkins-bot: installer: Replace the use of global $wgParser with services [core] - 10https://gerrit.wikimedia.org/r/494020 (owner: 10D3r1ck01) [14:23:44] (03PS4) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [14:24:46] (03CR) 10D3r1ck01: [C: 03+2] Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:25:30] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/493993 (owner: 10Umherirrender) [14:27:03] (03PS5) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [14:27:08] (03CR) 10Umherirrender: Use ::class for class name resolution (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [14:29:41] (03CR) 10D3r1ck01: Use ::class for class name resolution (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [14:30:02] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/494025 (owner: 10Umherirrender) [14:31:37] 10MediaWiki-API: API: how to get the page-size from query-langlinks - https://phabricator.wikimedia.org/T217387 (10Reedy) You still need to give it a list of page(s) https://de.wikipedia.org//w/api.php?action=query&format=json&prop=langlinks|revision&llprop=langname|url|autonym&rvprop=size&titles=Paris [14:31:44] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494023 (owner: 10Umherirrender) [14:32:04] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/494027 (owner: 10Umherirrender) [14:32:24] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-Nikerabbit, 10User-abi_, 10good first bug: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511 (10abi_) [14:33:03] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/494026 (owner: 10Umherirrender) [14:33:43] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/494028 (owner: 10Umherirrender) [14:35:44] (03CR) 10D3r1ck01: [C: 03+2] Use ::class for class name resolution [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494029 (owner: 10Umherirrender) [14:36:57] (03Merged) 10jenkins-bot: Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:37:20] (03PS2) 10Reedy: Added missing disableoathforuser message [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/492436 (https://phabricator.wikimedia.org/T216411) (owner: 10MNavya) [14:39:18] (03CR) 10jenkins-bot: Fix usage of MediaWikiServices in comments and documentation [core] - 10https://gerrit.wikimedia.org/r/494021 (owner: 10Fomafix) [14:40:52] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Daimona) @Umherirrender Your patch for echo is definitely good, and fine for now. I'm trying to see if... [14:43:51] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [14:44:31] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/494025 (owner: 10Umherirrender) [14:44:36] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494023 (owner: 10Umherirrender) [14:44:38] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/494027 (owner: 10Umherirrender) [14:44:40] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/494026 (owner: 10Umherirrender) [14:44:42] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Sentry] - 10https://gerrit.wikimedia.org/r/494028 (owner: 10Umherirrender) [14:48:08] (03PS6) 10Umherirrender: Use ::class for class name resolution [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 [14:48:15] (03CR) 10Umherirrender: Use ::class for class name resolution (035 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [14:48:28] (03PS1) 10Reedy: PoolCounterWorkViaCallback has existed since MW 1.22 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494032 [14:48:55] 10Hashtags: Allow wildcard project searches - https://phabricator.wikimedia.org/T216400 (10lalit97) Hello @Samwalton9 I've created a PR for this issue https://github.com/Samwalton9/hashtags/pull/15 [14:49:37] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/494025 (owner: 10Umherirrender) [14:51:36] (03PS1) 10Reedy: ChangeTags has existed for many MW versions [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/494033 [14:51:49] (03CR) 10Isarra: "This is intentional. It's the same message because it's the same usage; it's just that only a few skins implement it currently, so it's no" [skins/Anisa] - 10https://gerrit.wikimedia.org/r/494012 (owner: 10Raimond Spekking) [14:53:25] (03CR) 10jerkins-bot: [V: 04-1] ChangeTags has existed for many MW versions [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/494033 (owner: 10Reedy) [14:53:52] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494023 (owner: 10Umherirrender) [14:54:11] (03PS2) 10Reedy: ChangeTags has existed for many MW versions [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/494033 [14:54:29] (03PS1) 10Reedy: ActorMigration exists because of MW requirement in extension.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494034 [14:55:02] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-Nikerabbit, 10User-abi_, 10Wikimedia-production-error: Fatal error on Special:Translate for certain 'language' values - https://phabricator.wikimedia.org/T204833 (10abi_) Was able to reproduce this issue in Local. As you can probably tell, the... [14:55:34] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 [14:57:21] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-Nikerabbit, 10User-abi_, 10good first bug: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511 (10abi_) Patch for review: https://gerrit.wikimedia... [14:58:12] (03PS1) 10Umherirrender: [PoC] Add ClassNameResolutionPlugin [tools/phan] - 10https://gerrit.wikimedia.org/r/494036 (https://phabricator.wikimedia.org/T188144) [14:58:46] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494029 (owner: 10Umherirrender) [15:03:13] (03CR) 10Umherirrender: "All patch sets under https://gerrit.wikimedia.org/r/#/q/owner:Umherirrender+branch:master+topic:class for march 2019 are detected by this " [tools/phan] - 10https://gerrit.wikimedia.org/r/494036 (https://phabricator.wikimedia.org/T188144) (owner: 10Umherirrender) [15:03:20] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [15:05:14] anybody wanna review some API patches? [15:27:08] (03CR) 10Daimona Eaytoy: [C: 04-1] "I just found out this new problem, so let's be safe... BTW, I'll test again once parent is merged, although given the last tests I'm very " (032 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) (owner: 10Matěj Suchánek) [15:27:20] (03CR) 10Umherirrender: [C: 03+2] ChangeTags has existed for many MW versions [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/494033 (owner: 10Reedy) [15:28:39] (03PS1) 10Daimona Eaytoy: [WIP] Add table prefix when using 'table_name.*' in SELECT [core] - 10https://gerrit.wikimedia.org/r/494040 (https://phabricator.wikimedia.org/T217487) [15:28:54] (03CR) 10Umherirrender: [C: 04-1] Use ExtensionRegistry rather than class_exists (031 comment) [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 (owner: 10Reedy) [15:29:58] (03PS2) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 [15:30:44] (03CR) 10Umherirrender: [C: 03+2] PoolCounterWorkViaCallback has existed since MW 1.22 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494032 (owner: 10Reedy) [15:31:28] (03Merged) 10jenkins-bot: ChangeTags has existed for many MW versions [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/494033 (owner: 10Reedy) [15:32:32] (03PS2) 10Daimona Eaytoy: [WIP] Add table prefix when using 'table_name.*' in SELECT [core] - 10https://gerrit.wikimedia.org/r/494040 (https://phabricator.wikimedia.org/T217487) [15:41:21] 10crosswatch: Crosswatch gives a server-error after login: "No watchlist could be retrieved" - https://phabricator.wikimedia.org/T144083 (10Dvorapa) >>! In T144083#4996209, @OriHoch wrote: > crosswatch uses an oauth consumer key for login, all docs seem to point to this page to request a key, but it is not avail... [15:43:20] (03CR) 10Umherirrender: [C: 03+2] ActorMigration exists because of MW requirement in extension.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494034 (owner: 10Reedy) [15:43:32] (03Merged) 10jenkins-bot: PoolCounterWorkViaCallback has existed since MW 1.22 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/494032 (owner: 10Reedy) [15:47:25] (03Merged) 10jenkins-bot: ActorMigration exists because of MW requirement in extension.json [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494034 (owner: 10Reedy) [15:47:38] (03PS3) 10Umherirrender: Remove non-functional maintenance script testDiscussionParser.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492503 [15:50:32] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review: Deploy maplink for geocoordinate statements on production - https://phabricator.wikimedia.org/T217442 (10Lydia_Pintscher) Fine from my side :) [15:51:12] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), 10Patch-For-Review: Display mapframe for geocoordinate statements on client - https://phabricator.wikimedia.org/T210926 (10Lydia_Pintscher) FYI @Lea_Lacroix_WMDE [15:58:50] 10MediaWiki-Debug-Logger, 10Deployments, 10Performance-Team, 10User-Tgr: Capture PHP warnings with stacktraces in MediaWiki and save to logstash - https://phabricator.wikimedia.org/T45086 (10Krinkle) a:03Krinkle [16:01:23] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Ciencia_Al_Poder) The debug log should be used to capture the events when you get the error. The error for y... [16:01:40] (03PS2) 10Umherirrender: Declare class properties for JsonTreeRef class [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/487448 [16:01:47] (03CR) 10Umherirrender: "Rebased" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/487448 (owner: 10Umherirrender) [16:02:48] (03PS3) 10Umherirrender: Use ExtensionRegistry rather than class_exists [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 (owner: 10Reedy) [16:02:52] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 (owner: 10Reedy) [16:05:54] 10MediaWiki-Configuration, 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Patch-For-Review: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php - https://phabricator.wikimedia.org/T217125 (10Ammarpad) [16:06:37] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/494035 (owner: 10Reedy) [16:08:16] 10MediaWiki-Configuration, 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Patch-For-Review: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php - https://phabricator.wikimedia.org/T217125 (10Ammarpad) This makes changes that need prior approval, and the OP has been bloc... [16:08:50] (03CR) 10Ammarpad: [C: 04-1] "Per phab ticket. No approval for this." [core] - 10https://gerrit.wikimedia.org/r/492987 (https://phabricator.wikimedia.org/T217125) (owner: 10Setian) [16:12:13] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DBReplication logs are too verbose - https://phabricator.wikimedia.org/T160833 (10Krinkle) p:05Triage→03Low [16:13:09] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: DBReplication logs are too verbose - https://phabricator.wikimedia.org/T160833 (10Krinkle) @aaron We've tuned a few of these recently, but the link from Jaime still shows 5K entries in the last hour which suggests perhaps this one could... [16:13:47] 10MediaWiki-Database, 10Performance-Team, 10Wikimedia-production-error: Reduce verbosity of DBReplication logs from non-debug requests - https://phabricator.wikimedia.org/T160833 (10Krinkle) [16:14:58] (03CR) 10Umherirrender: Move most PHP files to includes/ (033 comments) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [16:15:04] 10Patch-For-Review, 10Readers-Web-Backlog (Design): Add night mode to Minerva - https://phabricator.wikimedia.org/T206094 (10Esanders) Hack to fix logo on desktop site: `lang=javascript $('#p-logo').clone().addClass('mw-no-invert').insertAfter('#p-logo').css({position:'absolute',top:'0',height:'113px',overflow... [16:16:16] (03CR) 10D3r1ck01: [C: 03+1] "Leaving for FR" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493982 (owner: 10Umherirrender) [16:16:56] (03CR) 10Reedy: Move most PHP files to includes/ (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [16:34:26] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) @Zoranzoki21 Thank you! It's my first experience with open source. I'll continue soon :) [16:36:33] 10Design, 10WMDE-Design, 10Wikibase-Quality-Constraints, 10Wikidata, and 2 others: new constraint level for suggestions - https://phabricator.wikimedia.org/T204439 (10Lydia_Pintscher) \o/ Are you both happy with it now? [16:40:51] (03CR) 10MGChecker: [C: 04-1] "These things have been declined by WMF many times over." [core] - 10https://gerrit.wikimedia.org/r/492987 (https://phabricator.wikimedia.org/T217125) (owner: 10Setian) [16:43:05] 04(no projects): Improve transparency in MediaWiki - https://phabricator.wikimedia.org/T217127 (10MGChecker) [16:43:14] 10MediaWiki-Configuration, 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Patch-For-Review: Set $wgGroupPermissions['*']['deletedhistory'] = true; in DefaultSettings.php - https://phabricator.wikimedia.org/T217125 (10MGChecker) 05Open→03Declined Making deleted content of whatever kind availa... [16:48:15] (03PS6) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [16:48:52] (03PS7) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [16:50:20] (03PS8) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [16:57:22] (03PS2) 10Umherirrender: maintenance: Remove unused code from several maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/493387 (owner: 10Thiemo Kreuz (WMDE)) [16:57:28] (03CR) 10Umherirrender: [C: 03+2] maintenance: Remove unused code from several maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/493387 (owner: 10Thiemo Kreuz (WMDE)) [16:57:38] 10MediaWiki-extensions-OAuth, 10Technical-Debt: Replace OAuth.php with something we can bring in via vendor - https://phabricator.wikimedia.org/T217515 (10Reedy) [16:57:41] 10MediaWiki-extensions-OAuth, 10Technical-Debt: Replace OAuth.php with something we can bring in via composer - https://phabricator.wikimedia.org/T217515 (10Reedy) p:05Triage→03Low [16:59:07] (03PS9) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [16:59:23] (03CR) 10Reedy: "PS9 tries removing " [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [17:01:45] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [17:01:47] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [17:05:07] (03PS10) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [17:07:43] 04(no projects): Page Forms: Checkboxes labels in multiple-instance templates are not clickable - https://phabricator.wikimedia.org/T217516 (10Yaron_Koren) [17:08:56] 10MediaWiki-extensions-Page_Forms: Page Forms: Checkboxes labels in multiple-instance templates are not clickable - https://phabricator.wikimedia.org/T217516 (10Reedy) [17:12:04] (03Merged) 10jenkins-bot: maintenance: Remove unused code from several maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/493387 (owner: 10Thiemo Kreuz (WMDE)) [17:12:12] 10MediaWiki-extensions-Page_Forms: Page Forms: Checkboxes should be farther apart - https://phabricator.wikimedia.org/T217517 (10Yaron_Koren) [17:12:34] (03PS11) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [17:13:03] 10MediaWiki-extensions-Page_Forms: Page Forms: Fix "tree" input type for Foreground skin - https://phabricator.wikimedia.org/T217518 (10Yaron_Koren) [17:14:28] (03CR) 10jenkins-bot: maintenance: Remove unused code from several maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/493387 (owner: 10Thiemo Kreuz (WMDE)) [17:14:51] 10MediaWiki-extensions-Page_Forms, 10Google-Summer-of-Code (2019): Page Forms: add an editable calendar interface - https://phabricator.wikimedia.org/T213759 (10Yaron_Koren) [17:16:02] (03CR) 10Reedy: [C: 03+2] Remove non-functional maintenance script testDiscussionParser.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492503 (owner: 10Umherirrender) [17:17:21] (03CR) 10Reedy: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493994 (owner: 10Umherirrender) [17:20:27] (03PS4) 10Reedy: Declare class properties [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489411 (owner: 10Umherirrender) [17:20:32] (03CR) 10Reedy: [C: 03+2] Declare class properties [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489411 (owner: 10Umherirrender) [17:22:02] (03CR) 10Zoranzoki21: [C: 04-1] "I no support this too" [core] - 10https://gerrit.wikimedia.org/r/492987 (https://phabricator.wikimedia.org/T217125) (owner: 10Setian) [17:24:45] (03PS1) 10Esanders: eslint: Update eslint-config-wikimedia 0.11.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494046 [17:26:48] (03Merged) 10jenkins-bot: Remove non-functional maintenance script testDiscussionParser.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492503 (owner: 10Umherirrender) [17:28:27] 10MediaWiki-extensions-Page_Forms: Page Forms: Checkboxes should be farther apart - https://phabricator.wikimedia.org/T217517 (10Gopavasanth) a:03Gopavasanth [17:29:22] (03CR) 10Umherirrender: [C: 04-2] "For discussion and further improvements only" [tools/phan] - 10https://gerrit.wikimedia.org/r/494036 (https://phabricator.wikimedia.org/T188144) (owner: 10Umherirrender) [17:30:08] 10Design, 10Wikidata: Make a more direct link from a Wikibase sitelink edit error to merging - https://phabricator.wikimedia.org/T189388 (10matej_suchanek) 05Open→03Resolved a:03matej_suchanek Apparently, we had a [[ https://www.wikidata.org/w/index.php?title=MediaWiki:Wikibase-validator-sitelink-conflic... [17:30:18] (03CR) 10jenkins-bot: Remove non-functional maintenance script testDiscussionParser.php [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492503 (owner: 10Umherirrender) [17:30:20] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493994 (owner: 10Umherirrender) [17:30:22] (03Merged) 10jenkins-bot: Declare class properties [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489411 (owner: 10Umherirrender) [17:30:34] (03PS2) 10Thiemo Kreuz (WMDE): Update PHPDoc types in several maintenance scripts and related [core] - 10https://gerrit.wikimedia.org/r/493391 [17:31:13] (03CR) 10Thiemo Kreuz (WMDE): Update PHPDoc types in several maintenance scripts and related (032 comments) [core] - 10https://gerrit.wikimedia.org/r/493391 (owner: 10Thiemo Kreuz (WMDE)) [17:31:32] (03PS2) 10Reedy: Remove unused class properties from InfoPage [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489417 (owner: 10Umherirrender) [17:32:17] 10MediaWiki-User-login-and-signup: Single user login (SUL) only works with Wikipedia and Wikimedia Commons (and then only in a one-way direction) - https://phabricator.wikimedia.org/T217519 (10Soluvo) [17:32:36] (03CR) 10Reedy: [C: 03+2] Remove unused class properties from InfoPage [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489417 (owner: 10Umherirrender) [17:32:40] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493994 (owner: 10Umherirrender) [17:34:53] (03Merged) 10jenkins-bot: Remove unused class properties from InfoPage [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/489417 (owner: 10Umherirrender) [17:38:32] (03PS3) 10Reedy: Move PHP files to includes/ [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 [17:40:16] (03PS4) 10Reedy: Move PHP files to includes/ [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 [17:42:25] 10MediaWiki-extensions-CentralAuth: Single user login (SUL) only works with Wikipedia and Wikimedia Commons (and then only in a one-way direction) - https://phabricator.wikimedia.org/T217519 (10Reedy) [17:43:11] (03CR) 10Reedy: "Woo progress" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 (owner: 10Reedy) [17:44:35] 10InternetArchiveBot: Feature suggestion for when websites serve custom 404 pages - https://phabricator.wikimedia.org/T213787 (10The_Editor.s_Apprentice) What would the cause of the signifcant cost be? [17:45:18] (03PS2) 10Reedy: Remove compat code for version 1.27 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493987 (owner: 10Umherirrender) [17:45:24] (03CR) 10Reedy: [C: 03+2] Remove compat code for version 1.27 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493987 (owner: 10Umherirrender) [17:45:36] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Henwilwal) Hi Sorry for posting incomplete information. I have now a debug log from trying to upload a new... [17:48:33] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team (Radar): Organise module files in directories based on their module name - https://phabricator.wikimedia.org/T193826 (10Krinkle) [17:48:42] (03PS1) 10Krinkle: mediawiki.cldr: Move file to its own directory [core] - 10https://gerrit.wikimedia.org/r/494047 (https://phabricator.wikimedia.org/T193826) [17:49:07] (03Merged) 10jenkins-bot: Remove compat code for version 1.27 [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/493987 (owner: 10Umherirrender) [17:52:13] is there a way to nuke notifications? no matter how many times i'm pressing "mark as read" i'm still sitting at well over 100 :( [17:53:39] (03PS5) 10Reedy: Add method scope visibility [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472705 (owner: 10Umherirrender) [17:54:14] 10MediaWiki-Release-Tools, 10Wikibugs: Send gerrit activity on production branches (wmf/.+-wmf.+) to #wikimedia-operations, not #wikimedia-dev - https://phabricator.wikimedia.org/T208960 (10Krinkle) [17:56:58] (03CR) 10Physikerwelt: [C: 04-2] "If the script is incompatible to the new API this can should be fixable. The purpose of this script is to generate test cases. One might d" [extensions/Math] - 10https://gerrit.wikimedia.org/r/494024 (owner: 10Umherirrender) [17:57:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug: Add sje,smj, sjk, sia and sjt as languages for monolingual properties - https://phabricator.wikimedia.org/T217521 (10Mbch331) [17:59:28] (03PS5) 10Reedy: Move specialpage redirects related classes to own files [core] - 10https://gerrit.wikimedia.org/r/489278 (owner: 10Umherirrender) [17:59:32] (03CR) 10Reedy: [C: 03+2] Move specialpage redirects related classes to own files [core] - 10https://gerrit.wikimedia.org/r/489278 (owner: 10Umherirrender) [18:02:54] (03PS2) 10Reedy: Use Maintenance::setBatchSize in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492505 (owner: 10Umherirrender) [18:03:00] (03CR) 10Reedy: [C: 03+2] Use Maintenance::setBatchSize in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492505 (owner: 10Umherirrender) [18:03:38] 10MediaWiki-Interface, 10MediaWiki-Internationalization, 10I18n: MediaWiki:Talkpageheader message does not handle language fallbacks - https://phabricator.wikimedia.org/T217357 (10Yurik) @A2093064 I think a much more intuitive behavior would be to use the "root" page, e.g. `MediaWiki:talkpageheader` as a fal... [18:06:35] 10MediaWiki-ResourceLoader, 10Performance-Team: Consider hiding (handled) warning about localStorage in mw.loader - https://phabricator.wikimedia.org/T195647 (10Krinkle) [18:07:15] (03CR) 10VolkerE: [C: 03+2] resources: Remove 'jquery.mockjax' module [core] - 10https://gerrit.wikimedia.org/r/494003 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [18:08:21] (03PS1) 10Daimona Eaytoy: Make Special:AbuseFilter sortable by filter name [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/494048 (https://phabricator.wikimedia.org/T217520) [18:09:05] (03PS6) 10Reedy: Migrate from Title::moveTo to MovePage::move [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/492488 (owner: 10Umherirrender) [18:09:15] (03CR) 10Reedy: [C: 03+2] Migrate from Title::moveTo to MovePage::move [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/492488 (owner: 10Umherirrender) [18:12:25] (03Merged) 10jenkins-bot: Move specialpage redirects related classes to own files [core] - 10https://gerrit.wikimedia.org/r/489278 (owner: 10Umherirrender) [18:12:27] (03Merged) 10jenkins-bot: Use Maintenance::setBatchSize in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492505 (owner: 10Umherirrender) [18:13:12] 04(no projects): Notifications won't go away - https://phabricator.wikimedia.org/T217522 (10Chrissymad) [18:13:14] (03PS1) 10Krinkle: resourceloader: Remove warning for handled localStorage error [core] - 10https://gerrit.wikimedia.org/r/494049 (https://phabricator.wikimedia.org/T195647) [18:13:25] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Consider hiding (handled) warning about localStorage in mw.loader - https://phabricator.wikimedia.org/T195647 (10Krinkle) a:03Krinkle [18:14:40] (03CR) 10jenkins-bot: Use Maintenance::setBatchSize in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492505 (owner: 10Umherirrender) [18:14:54] (03CR) 10jenkins-bot: Move specialpage redirects related classes to own files [core] - 10https://gerrit.wikimedia.org/r/489278 (owner: 10Umherirrender) [18:15:52] (03CR) 10Daimona Eaytoy: "> Filed https://github.com/phan/phan/issues/2515 upstream." [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [18:16:06] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Performance-Team (Radar): Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views - https://phabricator.wikimedia.org/T186062 (10Krinkle) [18:16:12] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team, 10Readers-Web-Backlog (Tracking): Per-module data exports from the server-side in ResourceLoader (e.g. configuration) - https://phabricator.wikimedia.org/T210035 (10Krinkle) 05Open→03Resolved a:03Catrope Roan and I decided o... [18:18:20] (03Merged) 10jenkins-bot: resources: Remove 'jquery.mockjax' module [core] - 10https://gerrit.wikimedia.org/r/494003 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [18:18:22] (03Merged) 10jenkins-bot: Migrate from Title::moveTo to MovePage::move [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/492488 (owner: 10Umherirrender) [18:19:14] (03PS1) 10Krinkle: Remove use of deprecated addModuleScripts() [extensions/3D] - 10https://gerrit.wikimedia.org/r/494053 (https://phabricator.wikimedia.org/T188689) [18:19:20] (03CR) 10Reedy: [C: 04-1] "Commit summary doesn't make any sense" (034 comments) [extensions/Push] - 10https://gerrit.wikimedia.org/r/481028 (owner: 10Karima Rafes) [18:20:41] (03CR) 10Reedy: [C: 04-1] "Why are you just appending api.php everywhere?" (031 comment) [extensions/Push] - 10https://gerrit.wikimedia.org/r/481527 (owner: 10Karima Rafes) [18:22:26] (03CR) 10Reedy: "Those commits are not in a state to be merged" [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [18:24:36] (03CR) 10jenkins-bot: resources: Remove 'jquery.mockjax' module [core] - 10https://gerrit.wikimedia.org/r/494003 (https://phabricator.wikimedia.org/T202154) (owner: 10Krinkle) [18:26:15] (03PS1) 10Olena23: fix typos occurd->occurred [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/494054 [18:26:17] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/494054 (owner: 10Olena23) [18:32:23] (03PS1) 10Krinkle: Remove references to deprecated 'modulescripts' [extensions/Collection] - 10https://gerrit.wikimedia.org/r/494057 (https://phabricator.wikimedia.org/T188689) [18:33:45] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) @Zoranzoki21 using Gerrit and git rebase was rather confusing. I hope, it's only confusing for... [18:34:14] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) [18:34:44] (03PS1) 10Krinkle: Remove use of deprecated addModuleScripts() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/494058 (https://phabricator.wikimedia.org/T188689) [18:36:25] (03CR) 10Zoranzoki21: [C: 03+1] "Patch looks good. Commit message should be improved so it should looks like this:" [extensions/ExtJSBase] - 10https://gerrit.wikimedia.org/r/494054 (owner: 10Olena23) [18:37:04] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) >>! In T201491#4996390, @Olena23 wrote: > @Zoranzoki21 Thank you! It's my first experience... [18:38:14] (03CR) 10Umherirrender: [C: 04-2] [PoC] Add ClassNameResolutionPlugin (034 comments) [tools/phan] - 10https://gerrit.wikimedia.org/r/494036 (https://phabricator.wikimedia.org/T188144) (owner: 10Umherirrender) [18:40:16] (03CR) 10Zoranzoki21: [C: 04-1] "> Those commits are not in a state to be merged" [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [18:41:11] (03PS3) 10Daimona Eaytoy: [WIP] Add table prefix when using 'table_name.*' in SELECT [core] - 10https://gerrit.wikimedia.org/r/494040 (https://phabricator.wikimedia.org/T217487) [18:45:10] (03PS1) 10Olena23: Please enter the commit message for #your changes. Lines starting fixed typos [extensions/PhpTagsSPARQL] - 10https://gerrit.wikimedia.org/r/494060 [18:48:32] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) @Olena23 Oh, I forgot.. Please read https://www.mediawiki.org/wiki/Gerrit/Commit_message_g... [18:51:47] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add table prefix when using 'table_name.*' in SELECT [core] - 10https://gerrit.wikimedia.org/r/494040 (https://phabricator.wikimedia.org/T217487) (owner: 10Daimona Eaytoy) [18:52:36] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) @Zoranzoki21 thank you! I read the guidlines and edited the commit messages [18:53:29] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) [18:57:24] 10TechCom-RFC: RFC: Skin templating - https://phabricator.wikimedia.org/T217158 (10Skizzerz) Unless anyone has any lingering concerns or questions they'd like addressed before the RFC is submitted for TechCom perusal, I'm going to be moving this RFC along to the next step of the process in a few days (requesting... [19:01:48] (03PS1) 10Olena23: Fix typo [extensions/Wigo3] - 10https://gerrit.wikimedia.org/r/494061 (https://phabricator.wikimedia.org/T201491) [19:03:02] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Need-volunteer, and 2 others: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Olena23) [19:15:30] 10MediaWiki-Core-Testing: PHPUnit: "Logs generated by test case" output repeats the line from PHPUnitCommand - https://phabricator.wikimedia.org/T217489 (10Krinkle) Here's an example of similar repetition, local to one component. ` $ php phpunit.php includes/resourceloader/ Using PHP 7.2.15 PHPUnit 6.5.14 by Se... [19:19:56] (03PS1) 10Krinkle: resourceloader: Remove addModuleScripts, and deprecate getModuleScripts. [core] - 10https://gerrit.wikimedia.org/r/494063 (https://phabricator.wikimedia.org/T188689) [19:20:19] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.33-release, 10Patch-For-Review, 10Performance-Team-notice: Finalise addModuleStyles() and addModuleScripts() legacy behaviours - https://phabricator.wikimedia.org/T188689 (10Krinkle) a:03Krinkle [19:20:26] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.33-release, 10Patch-For-Review, 10Performance-Team-notice: Finalise addModuleStyles() and addModuleScripts() legacy behaviours - https://phabricator.wikimedia.org/T188689 (10Krinkle) 05Stalled→03Open [19:27:24] (03PS4) 10Paladox: Fix styles for .mw-body.dt and .mw-body.dl [skins/Timeless] - 10https://gerrit.wikimedia.org/r/477333 (https://phabricator.wikimedia.org/T211044) [19:33:54] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Diksha11b) Hi, I am a sophomore-y... [19:35:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10good first bug: Add sje, smj, sjk, sia and sjt as languages for monolingual properties - https://phabricator.wikimedia.org/T217521 (10Reedy) [19:35:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed: Add sje, smj, sjk, sia and sjt as languages for monolingual properties - https://phabricator.wikimedia.org/T217521 (10Reedy) [19:41:37] (03PS1) 10Fomafix: Explicit convert Message to HTML escaped string with ->escaped() [core] - 10https://gerrit.wikimedia.org/r/494064 [19:44:34] (03PS4) 10Daimona Eaytoy: [WIP] Add table prefix when using 'table_name.*' in SELECT [core] - 10https://gerrit.wikimedia.org/r/494040 (https://phabricator.wikimedia.org/T217487) [19:52:42] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team (Radar): Concept: Reduce CSS styles for embedded icons by shipping the SVGs in one request and the PNGs in another for noscript users only - https://phabricator.wikimedia.org/T187266 (10Krinkle) 05Open→03Declined In 2010, we deci... [19:58:46] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561 (10Krinkle) [20:04:41] 10Wikimedia-Site-requests: Restrict local uploads to commons for MediaWiki.org - https://phabricator.wikimedia.org/T217523 (10Leaderboard) [20:05:08] (03CR) 10Aaron Schulz: objectcache: optimize WAN cache key updates during HOLDOFF_TTL (031 comment) [core] - 10https://gerrit.wikimedia.org/r/493148 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [20:09:04] 10Wikimedia-Site-requests: Restrict local uploads to commons for MediaWiki.org - https://phabricator.wikimedia.org/T217523 (10Leaderboard) p:05Triage→03Normal [20:13:01] (03PS1) 10D3r1ck01: Status: Code improvements for the Status class [core] - 10https://gerrit.wikimedia.org/r/494066 [20:13:37] (03PS1) 10Legoktm: Use variadic params to fix phan error [extensions/Babel] - 10https://gerrit.wikimedia.org/r/494067 [20:25:29] 10InternetArchiveBot: Feature suggestion for when websites serve custom 404 pages - https://phabricator.wikimedia.org/T213787 (10Cyberpower678) >>! In T213787#4996478, @The_Editor.s_Apprentice wrote: > What would the cause of the signifcant cost be? Custom 404s, can come in some many varieties and flavors that... [20:26:25] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/494066 (owner: 10D3r1ck01) [20:29:25] (03CR) 10Reedy: Status: Code improvements for the Status class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/494066 (owner: 10D3r1ck01) [20:31:01] (03CR) 10Fomafix: Status: Code improvements for the Status class (033 comments) [core] - 10https://gerrit.wikimedia.org/r/494066 (owner: 10D3r1ck01) [20:31:03] 10Wikimedia-Site-requests: Restrict local uploads to commons for MediaWiki.org - https://phabricator.wikimedia.org/T217523 (10Dcljr) [20:31:46] (03CR) 10Daimona Eaytoy: [C: 03+1] Use variadic params to fix phan error [extensions/Babel] - 10https://gerrit.wikimedia.org/r/494067 (owner: 10Legoktm) [20:33:18] 10Wikimedia-Site-requests: Restrict local uploads to commons for MediaWiki.org - https://phabricator.wikimedia.org/T217523 (10Dcljr) (For future reference, @Leaderboard, you shouldn't rely solely on the task title to communicate what is being requested, since the title can be changed at any time. I took the libe... [20:36:30] (03PS2) 10D3r1ck01: Status: Code improvements for the Status class [core] - 10https://gerrit.wikimedia.org/r/494066 [20:36:41] (03CR) 10D3r1ck01: "Thanks @Reedy. Also, @Fomafix, I've applied your feedback :)" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/494066 (owner: 10D3r1ck01) [20:37:45] 10MediaWiki-extensions-OAuth, 10Technical-Debt: Replace OAuth.php with something we can bring in via composer - https://phabricator.wikimedia.org/T217515 (10Tgr) A couple people have made a GitHub fork and restlyed the code to look more modern. I think the nicest was https://github.com/nicokaiser/php-oauth. No... [20:49:46] 10MediaWiki-Cache, 10Operations, 10MW-1.33-notes (1.33.0-wmf.18; 2019-02-19), 10Patch-For-Review, and 3 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10aaron) getWithSetCallback() should not internally... [20:51:11] 10MediaWiki-extensions-Translate: TranslateMetadata::get does full table scans unnecessarily - https://phabricator.wikimedia.org/T138619 (10aaron) How many rows are typically needed in such a request? What about the number of TranslateMetadata::get calls too? [20:55:31] 10MediaWiki-extensions-CentralAuth: Single user login (SUL) only works with Wikipedia and Wikimedia Commons (and then only in a one-way direction) - https://phabricator.wikimedia.org/T217519 (10Aklapper) Hi, please see and follow https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems and report back h... [20:58:17] 10MediaWiki-extensions-Translate, 10Patch-For-Review, 10User-Nikerabbit, 10User-abi_, 10good first bug: Status "proofreading" does not make sense for the source language in Special:(Language|MessageGroup)Stats - https://phabricator.wikimedia.org/T160511 (10Aklapper) >>! In T160511#4996329, @abi_ wrote: >... [21:03:28] 04(no projects): Special:ActiveUsers - https://phabricator.wikimedia.org/T217525 (10Marshallsumter) [21:04:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/494069 (owner: 10L10n-bot) [21:08:36] 10MediaWiki-Special-pages: Special:ActiveUsers seems to be truncated - https://phabricator.wikimedia.org/T217525 (10Reedy) a:05Marshallsumter→03None [21:08:59] (03CR) 10Jack Phoenix: [C: 03+2] Make footer link generation more consistent with other skins (e.g. MonoBook, Vector, etc.) [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/492693 (owner: 10Jack Phoenix) [21:09:03] (03CR) 10Jack Phoenix: [C: 03+2] Add OOjs UI overrides (adapted from Vector) to fix the "Group" menu drop-down on Special:ListUsers and probably many other thingies also usi [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/493097 (owner: 10Jack Phoenix) [21:12:37] (03Merged) 10jenkins-bot: Make footer link generation more consistent with other skins (e.g. MonoBook, Vector, etc.) [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/492693 (owner: 10Jack Phoenix) [21:12:39] (03Merged) 10jenkins-bot: Add OOjs UI overrides (adapted from Vector) to fix the "Group" menu drop-down on Special:ListUsers and probably many other thingies also using OO [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/493097 (owner: 10Jack Phoenix) [21:16:56] (03PS1) 10Jack Phoenix: Don't show the "did you know" section if Template:Didyouknow doesn't exist on the wiki [skins/Nimbus] - 10https://gerrit.wikimedia.org/r/494073 [21:24:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/494083 (owner: 10L10n-bot) [21:24:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/494120 (owner: 10L10n-bot) [21:25:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/494079 (owner: 10L10n-bot) [21:31:53] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561 (10Fomafix) [21:32:40] 10MediaWiki-ResourceLoader, 10Performance-Team: Implement a CSS preprocessor for direction flipping based on the content direction - https://phabricator.wikimedia.org/T89561 (10Fomafix) It is intended to have `.mw-editsection` in the user interface part and in the content part. [21:33:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/494103 (owner: 10L10n-bot) [21:35:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/494102 (owner: 10L10n-bot) [21:37:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/494111 (owner: 10L10n-bot) [21:42:19] 10MediaWiki-Special-pages: Special:ActiveUsers seems to be truncated - https://phabricator.wikimedia.org/T217525 (10Aklapper) Confirming. When I go to https://en.wikiversity.org/wiki/Special:ActiveUsers it starts with User:SelfieCity [21:46:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/494098 (owner: 10L10n-bot) [21:46:31] 10MediaWiki-Special-pages: Special:ActiveUsers seems to be truncated - https://phabricator.wikimedia.org/T217525 (10Reedy) Any idea when it broke? CC'ing @Anomie and @tstarling as {T199044} looks to be the last major or relevant change that might've caused issues [21:46:40] (03CR) 10Reedy: "Possibly caused T217525" [core] - 10https://gerrit.wikimedia.org/r/444666 (https://phabricator.wikimedia.org/T199044) (owner: 10Anomie) [21:48:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/494114 (owner: 10L10n-bot) [21:48:47] (03CR) 10Reedy: [C: 04-1] "recheck" [extensions/Push] - 10https://gerrit.wikimedia.org/r/481028 (owner: 10Karima Rafes) [21:48:56] (03CR) 10Reedy: "recheck" [extensions/Push] - 10https://gerrit.wikimedia.org/r/492696 (owner: 10Karima Rafes) [21:49:30] (03CR) 10jerkins-bot: [V: 04-1] - Fix errors when the url for API is not correct. [extensions/Push] - 10https://gerrit.wikimedia.org/r/481028 (owner: 10Karima Rafes) [21:49:35] (03CR) 10jerkins-bot: [V: 04-1] Update for the version 1.32 - remove deprecated warnings about wgScriptPath - replace obsolete function dieUsage => dieWithError - replace obsolete hook UnknownAction => MediaWikiPerformAction [extensions/Push] - 10https://gerrit.wikimedia.org/r/492696 (owner: 10Karima Rafes) [21:51:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/494110 (owner: 10L10n-bot) [21:54:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/494118 (owner: 10L10n-bot) [21:56:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/494117 (owner: 10L10n-bot) [21:58:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/494125 (owner: 10L10n-bot) [22:01:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/494123 (owner: 10L10n-bot) [22:06:43] (03PS3) 10BPirkle: Avoid using stale data for revision visibility and actor data [core] - 10https://gerrit.wikimedia.org/r/493326 (https://phabricator.wikimedia.org/T216159) [22:07:14] 10MediaWiki-API: API: how to get the page-size from query-langlinks - https://phabricator.wikimedia.org/T217387 (10Sh60) After adding an "s" to revision it works, but it only gives me 1 size, probably of the first language: revisions 0 size 155165 But I need the sizes of all of the language pages... [22:10:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/timeline] - 10https://gerrit.wikimedia.org/r/494142 (owner: 10L10n-bot) [22:19:39] (03CR) 10BPirkle: "Added first draft of actual fix, adjusted commit message accordingly" [core] - 10https://gerrit.wikimedia.org/r/493326 (https://phabricator.wikimedia.org/T216159) (owner: 10BPirkle) [22:40:46] 10ContentTranslation, 10Patch-For-Review, 10VisualEditor (Current work): CX2: Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10Esanders) [23:20:44] (03CR) 10Lewis Cawte: [C: 03+2] Remove unwanted PLURAL: from the user-stats-* messages shown on social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493810 (owner: 10Jack Phoenix) [23:23:52] (03Merged) 10jenkins-bot: Remove unwanted PLURAL: from the user-stats-* messages shown on social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493810 (owner: 10Jack Phoenix) [23:37:25] 10ContentTranslation, 10Language-Team (Language-2019-January-March): CX2: Communicate that publishing is only allowed to experienced editors - https://phabricator.wikimedia.org/T192144 (10Petar.petkovic) [23:44:45] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10Regression: Buttons misaligned in "New translation" dialog - https://phabricator.wikimedia.org/T217011 (10Petar.petkovic) >>! In T217011#4994279, @Etonkovidova wrote: > Resolved in cx2-testing - added to the list of bugs to check after de... [23:46:58] 10Research: Interface text for Reader Demographics Quicksurvey - https://phabricator.wikimedia.org/T217049 (10Isaac) [23:47:43] 10Research: Interface text for Reader Demographics Quicksurvey - https://phabricator.wikimedia.org/T217049 (10Isaac) @Capt_Swing privacy statement uploaded, so whenever you get a chance, the pages can be created. Thanks!! [23:59:00] 10Research: Interface text for Reader Demographics Quicksurvey - https://phabricator.wikimedia.org/T217049 (10Capt_Swing) @Isaac done! [23:59:51] (03PS5) 10BryanDavis: Update application privacy statement link [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/493410 (https://phabricator.wikimedia.org/T217327) (owner: 10Ammarpad)