[00:05:56] 10MediaWiki-Interface, 10Browser-Support-Apple-Safari: Text size in "personal links bar" on desktop sometimes inconsistent - https://phabricator.wikimedia.org/T217292 (10matmarex) No idea why the font size would be inconsistent between page loads. The font size adjustment is a feature specific to mobile WebKit... [00:06:44] 10MediaWiki-extensions-GrowthExperiments, 10MobileFrontend, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.17; 2019-02-12), and 2 others: Help Panel: Integrate as overlay in MobileFrontend - https://phabricator.wikimedia.org/T215430 (10Jdlrobson) I've been deep in the overlay world today and y... [00:07:17] 10PageImages, 10Need-volunteer, 10Readers-Web-Backlog (Tracking): PageImages' og:image interferes with the one defined by OpenGraphMeta - https://phabricator.wikimedia.org/T217307 (10Jdlrobson) This sounds sensible and non-controversial to me! [00:08:59] (03PS3) 10Nray: WIP: Refactor ImageOverlay into an Overlay with a ImageCarousel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493630 (https://phabricator.wikimedia.org/T216198) [00:09:15] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor ImageOverlay into an Overlay with a ImageCarousel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493630 (https://phabricator.wikimedia.org/T216198) (owner: 10Nray) [00:09:42] 10MediaWiki-Interface, 10Browser-Support-Apple-Safari: Text size in "personal links bar" on desktop sometimes inconsistent - https://phabricator.wikimedia.org/T217292 (10matmarex) It is possible to disable the font size adjustment using `-webkit-text-size-adjust`: * https://stackoverflow.com/questions/3226001/... [00:09:56] (03PS4) 10Nray: WIP: Refactor ImageOverlay into an Overlay with a ImageCarousel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493630 (https://phabricator.wikimedia.org/T216198) [00:10:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: Refactor ImageOverlay into an Overlay with a ImageCarousel [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493630 (https://phabricator.wikimedia.org/T216198) (owner: 10Nray) [00:17:03] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): Gallery context item not shown in CX - https://phabricator.wikimedia.org/T217081 (10Etonkovidova) 05Open→03Resolved Checked in `wmf.19` - the Gallery item are displayed and available for edit... [00:22:05] 10MediaWiki-Cache, 10Operations, 10Performance-Team, 10Patch-For-Review, 10User-Elukey: Consider removing the last traces of nutcracker in Mediawiki configs - https://phabricator.wikimedia.org/T214275 (10aaron) a:05aaron→03None [00:26:22] 04(no projects): RCFilters Guided Tour still visible on certain languages - https://phabricator.wikimedia.org/T217451 (10Volker_E) [00:27:02] 10MediaWiki-Recent-changes, 10Growth-Team: RCFilters Guided Tour still visible on certain languages - https://phabricator.wikimedia.org/T217451 (10Volker_E) [00:29:43] (03CR) 10Tchanders: "> > The only reason there is a special-case for the default policy is so it is impartial unless otherwise specified when it comes to skipL" [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [00:51:08] 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Verified, 10VisualEditor (Current work): Create a read-only mode for Visual Editor that allows inspection - https://phabricator.wikimedia.org/T210142 (10matmarex) >>! In T210142#4993685, @Pginer-WMF wrote: > I found a related issue about the inspection leading t... [00:51:39] (03PS1) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [00:53:56] (03PS1) 10Jack Phoenix: Use CommentStore instead of directly reading recentchanges.rc_comment to avoid a DB error in MW 1.33+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493772 (https://phabricator.wikimedia.org/T217423) [00:54:29] 10Product-Analytics: Analyse Android notifications release - https://phabricator.wikimedia.org/T213458 (10Catrope) Apologies for the lack of documentation in echo.sql. [[https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Echo/+/493771|This patch]] adds documentation for all tables and fields. [00:54:46] (03PS2) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [00:55:20] (03CR) 10Dbarratt: "> If we had 'suggestChangeOnLogin', but it behaved like 'forceChange' (i.e. show the message if 'suggestChangeOnLogin' is true for at leas" [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [01:00:09] 10Social-Tools, 10SocialProfile, 10Patch-For-Review: SocialProfile Database Error - https://phabricator.wikimedia.org/T217423 (10ashley) @TheROFL98 Thank you for taking the time to report this. As per [[https://www.mediawiki.org/wiki/Social_tools/MediaWiki_compatibility|social tools' compatibility policy]],... [01:01:32] (03CR) 10Bartosz Dziewoński: Prevent editor fixed header from being scrolled out of view by touch keyboard (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:04:29] (03CR) 10Dbarratt: "I realize that:" [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [01:05:36] (03PS1) 10Catrope: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 [01:06:29] 10ContentTranslation: [cx2-testing] Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10Etonkovidova) [01:06:42] 10MediaWiki-Cache, 10MediaWiki-Parser, 10Regression, 10User-Elukey, 10Wikimedia-production-error: Unable to store parser output in StashEdit (Memcached error: ITEM TOO BIG) - https://phabricator.wikimedia.org/T204742 (10aaron) I'd like the limit to be bumped to around $wgMaxArticleSize after upgrade (2MB... [01:17:05] (03PS8) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [01:18:43] 10ContentTranslation: CX2: Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10Etonkovidova) [01:18:46] 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Readers-Web-Backlog (Design): Add a share button to the mobile site (starting by enabling in beta) - https://phabricator.wikimedia.org/T181195 (10Tbayer) >>! In T181195#4804640, @pmiazga wrote: >> can we instrument it in a way so that we can find out i... [01:20:08] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [01:23:21] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): CX2: Show link card for source links - https://phabricator.wikimedia.org/T197075 (10Etonkovidova) 'View' button does not work in cx2-testing - filed as {T217454}. @Pginer-WMF please review the... [01:24:26] 10Social-Tools, 10SocialProfile, 10Patch-For-Review: SocialProfile Database Error - https://phabricator.wikimedia.org/T217423 (10TheROFL98) It appears it's now giving me a new error. ` [574140f4f18921f47a1b9566] /w/index.php?title=User:Therofl98 InvalidArgumentException from line 336 of /var/www/html/wiki/... [01:25:34] 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Readers-Web-Backlog (Design): Add a share button to the mobile site (starting by enabling in beta) - https://phabricator.wikimedia.org/T181195 (10Tbayer) >>! In T181195#4982077, @alexhollender wrote: > @pmiazga here is a first stab at filling out the B... [01:29:07] (03PS7) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [01:29:10] (03PS6) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [01:29:34] 10ContentTranslation: CX2: Link card: "View" button does not open link inspector - https://phabricator.wikimedia.org/T217454 (10Etonkovidova) [01:29:37] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26): CX2: Show link card for source links - https://phabricator.wikimedia.org/T197075 (10Etonkovidova) [01:29:41] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:29:53] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:31:03] 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Readers-Web-Backlog (Design): Add a share button to the mobile site (starting by enabling in beta) - https://phabricator.wikimedia.org/T181195 (10Tbayer) It seems that the Web Share API also support a "text" field to accompany the shared link. Do we wa... [01:31:13] (03CR) 10Bartosz Dziewoński: "It isn't clear to me what is the purpose of this. Adding tags to things is already possible by using the 'RecentChange_save' hook (there a" [core] - 10https://gerrit.wikimedia.org/r/493464 (https://phabricator.wikimedia.org/T215675) (owner: 10Pmiazga) [01:31:48] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:32:12] (03PS3) 10Catrope: Add documentation comments to the SQL schema [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493771 [01:32:15] (03PS9) 10Catrope: Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) [01:32:18] (03PS8) 10Catrope: Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) [01:32:21] (03PS7) 10Catrope: Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) [01:33:29] (03PS8) 10Gergő Tisza: Show password policy flags on Special:PasswordPolicies [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) [01:34:39] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_display_hash [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306849 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:36:09] (03CR) 10jerkins-bot: [V: 04-1] Remove notification_bundle_base [extensions/Echo] - 10https://gerrit.wikimedia.org/r/306846 (https://phabricator.wikimedia.org/T143763) (owner: 10Catrope) [01:36:20] (03CR) 10jerkins-bot: [V: 04-1] Migrate and remove event_page_namespace and event_page_title [extensions/Echo] - 10https://gerrit.wikimedia.org/r/293039 (https://phabricator.wikimedia.org/T136427) (owner: 10Catrope) [01:37:03] 10MinervaNeue, 10Readers-Web-Backlog: Track share button usage - https://phabricator.wikimedia.org/T207280 (10Tbayer) (Update: we discussed this earlier this week and decided that a simple EventLogging schema would be useful. I'm going to create one, but there are still some relevant questions open in the othe... [01:40:32] (03CR) 10Bartosz Dziewoński: "Is there an extension or some other example with which I could test this?" [core] - 10https://gerrit.wikimedia.org/r/493373 (https://phabricator.wikimedia.org/T217315) (owner: 10Mainframe98) [01:45:53] (03PS6) 10Bartosz Dziewoński: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) [01:46:10] (03CR) 10jerkins-bot: [V: 04-1] Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:15] (03CR) 10Bartosz Dziewoński: "Fixed ESLint failures." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:20] (03CR) 10Bartosz Dziewoński: "rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:37] (03CR) 10Frankiebot: "message received master!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:46:49] (03CR) 10Frankiebot: [C: 04-1] "I cannot rebase this manually." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:51:06] (03PS7) 10Bartosz Dziewoński: Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) [01:51:41] (03CR) 10Bartosz Dziewoński: "PS7: Fixed merge conflict (a real one this time)." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [01:55:48] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team: Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10MMiller_WMF) [01:56:11] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10MMiller_WMF) [01:57:07] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Homepage: mentorship module - https://phabricator.wikimedia.org/T216631 (10MMiller_WMF) I have updated the specifications on this task based on our team discussion from 2019-02-27. This is ready to be worked on, and @Cntlsn will be able... [02:00:51] (03CR) 10jerkins-bot: [V: 04-1] Prevent editor fixed header from being scrolled out of view by touch keyboard [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [02:06:42] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add sepia theme - https://phabricator.wikimedia.org/T194327 (10cooltey) Hi @schoenbaechler, I've create a patch of fixing most of them, except the following thing: > Oh, one additional thing I just noticed. Can we u... [02:09:15] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Homepage: help module - https://phabricator.wikimedia.org/T215986 (10MMiller_WMF) @kostajh -- I just finished writing up specifications in T216631 for the mentorship module, and I think we can use a lot of the same... [02:10:32] (03CR) 10Brian Wolff: [C: 03+2] Add isset() to shut up an E_NOTICE [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/493689 (owner: 10Jack Phoenix) [02:11:03] 04(no projects): Logs for renaming usernames on Arabic language or with simular letters should show firstly number of change - https://phabricator.wikimedia.org/T217456 (10Zoranzoki21) [02:11:20] 10MediaWiki-extensions-Renameuser: Logs for renaming usernames on Arabic language or with simular letters should show firstly number of change - https://phabricator.wikimedia.org/T217456 (10Zoranzoki21) [02:13:36] (03Merged) 10jenkins-bot: Add isset() to shut up an E_NOTICE [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/493689 (owner: 10Jack Phoenix) [02:17:26] (03CR) 10Brian Wolff: "I'm not sure, but maybe you need to make sure anyone who contributed between then and now is ok with the different license. (Looks like th" [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/493475 (owner: 10Jack Phoenix) [02:21:17] (03CR) 10Brian Wolff: [C: 03+2] Follow-up to cac8eee474ef30cfbe0da44cb6642dc824a33b9b, document that MW 1.33+ is now explicitly required [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/493671 (owner: 10Jack Phoenix) [02:22:09] (03CR) 10Brian Wolff: [C: 03+2] Fix dumb bug causing fatals and probably the extension to not function as intended [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/493690 (owner: 10Jack Phoenix) [02:23:11] (03CR) 10Brian Wolff: [C: 03+2] Avoid using deprecated (in MW 1.32) global $wgContLang, require MW 1.32+ [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/486113 (owner: 10Jack Phoenix) [02:24:11] (03Merged) 10jenkins-bot: Follow-up to cac8eee474ef30cfbe0da44cb6642dc824a33b9b, document that MW 1.33+ is now explicitly required [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/493671 (owner: 10Jack Phoenix) [02:25:36] (03Merged) 10jenkins-bot: Fix dumb bug causing fatals and probably the extension to not function as intended [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/493690 (owner: 10Jack Phoenix) [02:26:53] (03Merged) 10jenkins-bot: Avoid using deprecated (in MW 1.32) global $wgContLang, require MW 1.32+ [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/486113 (owner: 10Jack Phoenix) [02:29:05] (03CR) 10Gergő Tisza: "@covers does not make any sense for structure tests, which either do not cover any PHP lines, or cover lines which cannot be determined at" [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) (owner: 10Gergő Tisza) [02:30:42] (03PS1) 10Aaron Schulz: Make ApiStashEdit use a separate key for the parser output due to size [core] - 10https://gerrit.wikimedia.org/r/493775 (https://phabricator.wikimedia.org/T204742) [02:32:16] 10MediaWiki-extensions-Renameuser, 10Patch-For-Review, 10phan: Upgrade Renameuser extension to use newer phan - https://phabricator.wikimedia.org/T216937 (10Zoranzoki21) 05Open→03Resolved a:03matej_suchanek Thanks @matej_suchanek! [02:41:05] (03PS1) 10Zoranzoki21: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) [02:41:24] (03PS2) 10Zoranzoki21: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) [02:41:39] (03CR) 10jerkins-bot: [V: 04-1] Make ApiStashEdit use a separate key for the parser output due to size [core] - 10https://gerrit.wikimedia.org/r/493775 (https://phabricator.wikimedia.org/T204742) (owner: 10Aaron Schulz) [02:51:26] (03CR) 10jerkins-bot: [V: 04-1] Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [02:56:49] (03CR) 10Gergő Tisza: [C: 04-1] "These are the natural preferences for the password policy config IMO:" [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [02:59:33] (03CR) 10Gergő Tisza: [C: 04-1] "TL;DR (sorry that ended up way longer than it had business to be), what Dbarratt said, but someone from Security should be asked for a san" [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [03:00:13] 10MediaWiki-extensions-Translate: TranslateMetadata::get does full table scans unnecessarily - https://phabricator.wikimedia.org/T138619 (10aaron) Some interesting query data: `SELECT tmd_key, COUNT(*) AS n, AVG(CHAR_LENGTH(tmd_value)) AS ave, SUM(CHAR_LENGTH(tmd_value)) AS total FROM translate_metadata GROUP B... [03:01:22] (03CR) 10Gergő Tisza: "Eh, let's do one thing per patch, instead." [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) (owner: 10Gergő Tisza) [03:02:54] (03PS9) 10Gergő Tisza: Show password policy flags on Special:PasswordPolicies [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) [03:09:59] (03PS1) 10Gergő Tisza: Exempt structure tests from @covers checks [core] - 10https://gerrit.wikimedia.org/r/493777 [03:12:30] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Patch-Needs-Improvement: 'Potential Issues' flagged in Page Curation Toolbar Page Info flyout - https://phabricator.wikimedia.org/T207847 (10Force_Radical) I have made the changes to the patch. [03:23:04] (03CR) 10Aaron Schulz: [C: 03+2] NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [03:25:43] (03CR) 10Gergő Tisza: [C: 03+2] "Per Reedy." [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) (owner: 10Gergő Tisza) [03:43:52] (03Merged) 10jenkins-bot: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [03:48:43] (03CR) 10jenkins-bot: NotificationDeleteJob: Remove unused variable $targetMapper [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493773 (owner: 10Catrope) [03:49:44] (03PS2) 10Jack Phoenix: Use CommentStore instead of directly reading recentchanges.rc_comment to avoid a DB error in MW 1.33+ [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493772 (https://phabricator.wikimedia.org/T217423) [03:51:10] (03Merged) 10jenkins-bot: Show password policy flags on Special:PasswordPolicies [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) (owner: 10Gergő Tisza) [03:53:28] (03CR) 10jenkins-bot: Show password policy flags on Special:PasswordPolicies [core] - 10https://gerrit.wikimedia.org/r/485482 (https://phabricator.wikimedia.org/T118774) (owner: 10Gergő Tisza) [04:03:28] 10MediaWiki-extensions-Renameuser: Logs for renaming usernames on Arabic language or with simular letters should show firstly number of change - https://phabricator.wikimedia.org/T217456 (10alanajjar) Yes need like a {{space}} [04:19:05] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10notnotparas) [04:37:10] 10ExternalGuidance, 10Patch-For-Review: Tag is not added when new page is created through External Guidance - https://phabricator.wikimedia.org/T216123 (10chelsyx) Hi @Pginer-WMF , I think we also need [tags](https://en.wikipedia.org/wiki/Special:Tags) when users edit an existing page in their local language,... [04:52:07] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Sumanth699) [05:22:14] 10Design, 10MediaWiki-Interface, 10TechCom-RFC, 10Readers-Web-Backlog (Design): RFC: Section headings should have a clickable anchor - https://phabricator.wikimedia.org/T18691 (10Msftwikipmey) >>! In T18691#4994519, @dbarratt wrote: > Is it? Perhaps we should run a test on a high-traffic wiki and see which... [05:55:18] 10MediaWiki-extensions-Renameuser, 10I18n: Logs for renaming users with username in Arabic script et al should show first number of change - https://phabricator.wikimedia.org/T217456 (10Aklapper) [06:29:28] 10MediaWiki-extensions-Renameuser, 10I18n: Logs for renaming users with username in Arabic script at al should show first number of change - https://phabricator.wikimedia.org/T217456 (10Zoranzoki21) [06:29:48] 10MediaWiki-extensions-Renameuser, 10I18n: Logs for renaming users with username in Arabic script should show first number of change - https://phabricator.wikimedia.org/T217456 (10Zoranzoki21) [07:12:48] 10MediaWiki-Interface, 10Browser-Support-Apple-Safari: Text size in "personal links bar" on desktop sometimes inconsistent - https://phabricator.wikimedia.org/T217292 (10RhinosF1) >>! In T217292#4994897, @matmarex wrote: > It is possible to disable the font size adjustment using `-webkit-text-size-adjust`: > *... [07:26:45] 10GeoData, 10Discovery-Search (Current work), 10Patch-For-Review, 10phan: Upgrade GeoData extension to use newer phan - https://phabricator.wikimedia.org/T216920 (10Legoktm) 05Resolved→03Open phan isn't actually passing, good catch by @Zoranzoki21. [07:58:40] 10Community-Relations: 15min read-only on some wikis for network maintenance on 2019-03-19 - https://phabricator.wikimedia.org/T217441 (10Aklapper) [08:06:46] 10FormWizard: Write QUnit test for makeSelectFileWidget - https://phabricator.wikimedia.org/T217459 (10Eugene233) [08:07:52] 10FormWizard: Write QUnit test for makeDropdownInputWidget - https://phabricator.wikimedia.org/T217460 (10Eugene233) [08:09:13] 10FormWizard: Write QUnit test for makeNumberInputWidget - https://phabricator.wikimedia.org/T217461 (10Eugene233) [08:10:19] 04(no projects): Media viewer produces buggy images only in chrome - https://phabricator.wikimedia.org/T216754 (10Aklapper) 05Stalled→03Declined Unfortunately closing this report as no further information has been provided. @Bhavanatwr: After you have provided the information asked for and if this still ha... [08:11:04] 10FormWizard: Write QUnit test for makeRadioSelectInputWidget - https://phabricator.wikimedia.org/T217462 (10Eugene233) [08:12:34] 10MediaWiki-extensions-Scribunto, 10I18n, 10Serbian-Sites: Documentation pages on sr.wikipedia should support multiple prefixes (/doc, /док, /dok) - https://phabricator.wikimedia.org/T212951 (10Aklapper) [08:12:51] 10FormWizard: Write QUnit test for makeComboBoxInputWidget - https://phabricator.wikimedia.org/T217463 (10Eugene233) [08:14:14] 10MediaWiki-extensions-Scribunto, 10I18n, 10Serbian-Sites: Documentation pages on sr.wikipedia should support multiple prefixes (/doc, /док, /dok) - https://phabricator.wikimedia.org/T212951 (10Aklapper) >>! In T212951#4899970, @Obsuser wrote: > Could you resolve that? I guess it's simple for you... @Obsuse... [08:14:50] 10FormWizard: Write QUnit test for makeMultilineText - https://phabricator.wikimedia.org/T217464 (10Eugene233) [08:20:02] 10FormWizard: Write QUnit test for makeCheckboxMultiselect - https://phabricator.wikimedia.org/T217465 (10Eugene233) [08:21:07] 10FormWizard: Write QUnit test for makeLabelText - https://phabricator.wikimedia.org/T217466 (10Eugene233) [08:22:33] 10FormWizard: Write QUnit test for createFieldSet - https://phabricator.wikimedia.org/T217467 (10Eugene233) [08:26:16] 10FormWizard: Write QUnit test for AddPanelElementsToPanel - https://phabricator.wikimedia.org/T217468 (10Eugene233) [08:29:59] 10FormWizard: Write QUnit test for makeStack - https://phabricator.wikimedia.org/T217469 (10Eugene233) [08:31:50] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [08:34:49] (03PS6) 10D3r1ck01: Rearrange files into sub-specific directories [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 [08:34:52] (03PS1) 10D3r1ck01: Code improvements for files in includes/ root directory [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493780 [08:35:50] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [08:36:59] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [08:37:14] (03PS1) 10D3r1ck01: Code improvements for includes/ **only** directory [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 [08:38:51] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [08:41:14] 10CommRel-Specialists-Support (Jan-Mar-2019): 15min read-only on some wikis for network maintenance on 2019-03-19 - https://phabricator.wikimedia.org/T217441 (10Qgil) [08:41:18] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [08:41:41] (03CR) 10jerkins-bot: [V: 04-1] Code improvements for files in includes/ root directory [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493780 (owner: 10D3r1ck01) [08:42:49] (03CR) 10jerkins-bot: [V: 04-1] Code improvements for files in includes/ root directory [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493780 (owner: 10D3r1ck01) [08:45:20] 10Wikimedia-Site-requests: Change the favicon of the german mobile de.m.wiktionary.org site - https://phabricator.wikimedia.org/T202902 (10Ammarpad) @Formatierer. On both mobile domain (de.m.wiktionary.org) and desktop version (de.wiktionary.org), the favicon is [[https://de.wiktionary.org/favicon.icon]]. It can... [08:45:48] 10WMSE-Riksarkivet-TORA: Connect WD Churches and church documentation at RAÄ/LIBRIS - https://phabricator.wikimedia.org/T215603 (10Salgo60) [08:49:29] 10WMSE-Riksarkivet-TORA: Connect WD Churches and church documentation at RAÄ/LIBRIS - https://phabricator.wikimedia.org/T215603 (10Salgo60) [08:57:55] (03PS2) 10D3r1ck01: Code improvements for files in includes/ root directory [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493780 [09:00:18] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [09:07:22] 10Phabricator, 10importbots: Add user description for phabricator import bots - https://phabricator.wikimedia.org/T208976 (10mmodell) 05Open→03Resolved a:03mmodell [09:11:23] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487828 (owner: 10D3r1ck01) [09:14:31] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/493780 (owner: 10D3r1ck01) [09:21:26] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493781 (owner: 10D3r1ck01) [09:28:53] (03PS1) 10Daimona Eaytoy: Fix documentation errors reported by Phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 [09:28:57] (03Abandoned) 10Daimona Eaytoy: [DNM] Phan testing [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493454 (owner: 10Daimona Eaytoy) [09:30:47] (03PS4) 10Daimona Eaytoy: [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [09:34:35] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [09:36:23] 10WMSE-Riksarkivet-TORA: Open Street Map indoor Maps of Riddarholm church - https://phabricator.wikimedia.org/T217470 (10Salgo60) [09:42:35] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [09:48:39] (03PS2) 10Daimona Eaytoy: Fix documentation errors reported by Phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 [10:11:29] 10OOUI, 10Documentation, 10phan: OOUI docblocks trip Phan analysis - https://phabricator.wikimedia.org/T217471 (10Daimona) [10:19:20] 04(no projects): Heavy load on all machines of toolforge -- jobs do not start - https://phabricator.wikimedia.org/T217472 (10Wurgl) [10:21:07] 10MediaWiki-Special-pages: Suggestions of input field on Special:Categories strips leading "Category:" from category name - https://phabricator.wikimedia.org/T212276 (10Fomafix) [10:23:20] (03CR) 10Daimona Eaytoy: Upgrade StopForumSpam to use newer version of phan (032 comments) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/492762 (https://phabricator.wikimedia.org/T216943) (owner: 10Zoranzoki21) [10:23:55] 10MediaWiki-extensions-StopForumSpam, 10Patch-For-Review, 10User-Zoranzoki21, 10phan: Upgrade StopForumSpam extension to use newer phan - https://phabricator.wikimedia.org/T216943 (10Daimona) >>! In T216943#4983672, @Zoranzoki21 wrote: > I am not sure how I can fix: (Answered on gerrit.) [10:26:55] 10MediaWiki-Special-pages: Suggestions of input field on Special:Categories strips leading "Category:" from category name - https://phabricator.wikimedia.org/T212276 (10Fomafix) [10:27:00] (03CR) 10Daimona Eaytoy: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [10:35:37] (03PS1) 10Jack Phoenix: Add some comments to make it easier to grep where certain useractivity-* i18n messages are used [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493785 [10:40:09] (03CR) 10Jack Phoenix: [C: 03+2] Add some comments to make it easier to grep where certain useractivity-* i18n messages are used [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493785 (owner: 10Jack Phoenix) [10:43:17] (03Merged) 10jenkins-bot: Add some comments to make it easier to grep where certain useractivity-* i18n messages are used [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493785 (owner: 10Jack Phoenix) [10:45:59] 04(no projects): Heavy load on all machines of toolforge -- jobs do not start - https://phabricator.wikimedia.org/T217472 (10Wurgl) p:05Triage→03Unbreak! [10:46:42] (03PS1) 10Jack Phoenix: Make UserSystemMessages' types a bit less magical and more readable by adding some constants [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493786 [10:56:16] (03PS1) 10Jack Phoenix: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PollNY [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/493787 [10:56:18] (03PS1) 10Jack Phoenix: Fix a bunch of "A non-numeric value encountered" E_WARNINGs [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/493788 [10:56:58] (03Abandoned) 10Jack Phoenix: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PollNY [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/493787 (owner: 10Jack Phoenix) [10:59:17] (03PS2) 10Jack Phoenix: Fix a bunch of "A non-numeric value encountered" E_WARNINGs [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/493788 [11:02:59] (03CR) 10Raimond Spekking: [C: 03+2] Add missing right-newsticker and fix i18n json files [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493736 (owner: 10Umherirrender) [11:04:53] 10MediaWiki-API, 10MediaWiki-Language-converter, 10MediaWiki-Parser, 10Patch-For-Review: api.php?uselang=sr shows language converter syntax in the HTML - https://phabricator.wikimedia.org/T208145 (10Fomafix) [11:07:39] (03Merged) 10jenkins-bot: Add missing right-newsticker and fix i18n json files [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493736 (owner: 10Umherirrender) [11:09:41] (03PS1) 10Kghbln: Allows to add subsections to special pages groups on special page "Specialpages" [core] - 10https://gerrit.wikimedia.org/r/493789 (https://phabricator.wikimedia.org/T216467) [11:16:40] (03PS1) 10Fomafix: Remove deprecated Language::markNoConversion [core] - 10https://gerrit.wikimedia.org/r/493790 [11:27:51] (03PS1) 10Jack Phoenix: Absolutely atrocious "fix" for the parsing of tags on Special:UserActivity [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493791 [11:32:58] (03PS1) 10Fomafix: Load styles module 'ext.quiz.styles' via addModuleStyles() [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/493792 [11:48:06] (03CR) 10Martineznovo: [C: 04-1] "Ugh, that's horrible, but a quick fix" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493791 (owner: 10Jack Phoenix) [11:48:24] (03CR) 10Martineznovo: [C: 03+1] "Sorry, wanted to +1" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493791 (owner: 10Jack Phoenix) [11:50:31] (03PS1) 10Tpt: Adds support of categories to index pages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493793 (https://phabricator.wikimedia.org/T145746) [11:52:35] 10MediaWiki-API, 10MediaWiki-Uploading, 10Multimedia: Special:Upload fails on ":w:" as destination filename - https://phabricator.wikimedia.org/T185904 (10Fomafix) [11:54:07] 10MediaWiki-Parser: Single quotes in selflinks activates italic/bold - https://phabricator.wikimedia.org/T180342 (10Fomafix) [11:54:21] (03CR) 10Tchanders: "Just to clarify, Dbarratt, Gergő Tisza and I appear to be suggesting the same thing." [core] - 10https://gerrit.wikimedia.org/r/491686 (https://phabricator.wikimedia.org/T211621) (owner: 10Dmaza) [11:56:50] (03PS1) 10Daimona Eaytoy: Add RegexChecker and UnusedSuppression plugins [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) [11:58:27] 10MediaWiki-Codesniffer, 10PHP 7.0 support, 10Patch-For-Review: Report PREG_REPLACE_EVAL as deprecated in codesniffer - https://phabricator.wikimedia.org/T191676 (10Daimona) a:03Daimona [11:59:04] (03PS2) 10Fomafix: Remove deprecated Language::markNoConversion [core] - 10https://gerrit.wikimedia.org/r/493790 [12:00:08] (03CR) 10Raimond Spekking: "i18n review" (034 comments) [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/399772 (owner: 10tosfos) [12:05:23] (03PS1) 10Daimona Eaytoy: Upgrade Phan to 1.2.6 [tools/phan] - 10https://gerrit.wikimedia.org/r/493795 [12:05:54] (03CR) 10Daimona Eaytoy: [C: 04-1] "Waiting for the release, probably next week." [tools/phan] - 10https://gerrit.wikimedia.org/r/493795 (owner: 10Daimona Eaytoy) [12:20:40] (03PS5) 10Daimona Eaytoy: [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [12:23:37] (03CR) 10Daimona Eaytoy: [C: 04-1] "T217471 for the remaining OOUI-related warnings." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [12:28:59] (03PS1) 10Daimona Eaytoy: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) [12:29:36] (03PS2) 10Daimona Eaytoy: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) [12:30:05] 10SpamBlacklist, 10Patch-For-Review, 10phan: Upgrade SpamBlacklist extension to use newer phan - https://phabricator.wikimedia.org/T216942 (10Daimona) a:03Daimona [12:31:15] (03CR) 10Raimond Spekking: build: Add grunt-banana-checker (031 comment) [extensions/FilterSpecialPages] - 10https://gerrit.wikimedia.org/r/492022 (owner: 10Umherirrender) [12:33:46] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [12:38:38] (03PS3) 10Daimona Eaytoy: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) [12:42:26] 10MediaWiki-extensions-Renameuser, 10I18n, 10RTL: Logs for renaming users with username in Arabic script should show first number of change - https://phabricator.wikimedia.org/T217456 (10Reedy) [12:43:20] (03PS1) 10Daimona Eaytoy: Migrate to new Phan [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493799 (https://phabricator.wikimedia.org/T216944) [12:43:36] 10SyntaxHighlight, 10Patch-For-Review, 10phan: Upgrade SyntaxHighlight_GeSHi extension to use newer phan - https://phabricator.wikimedia.org/T216944 (10Daimona) a:03Daimona [12:46:04] (03PS1) 10Daimona Eaytoy: Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) [12:46:22] 10MediaWiki-extensions-Babel, 10Patch-For-Review, 10phan: Upgrade Babel extension to use newer phan - https://phabricator.wikimedia.org/T216907 (10Daimona) a:03Daimona [12:51:06] (03PS2) 10Daimona Eaytoy: Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) [12:56:56] (03PS3) 10Daimona Eaytoy: Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) [12:57:07] (03PS1) 10MarcoAurelio: Add .gitreview [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493803 [12:57:42] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Add .gitreview [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493803 (owner: 10MarcoAurelio) [12:57:46] (03PS3) 10Daimona Eaytoy: Fix faulty query in normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493738 (https://phabricator.wikimedia.org/T209565) [12:57:53] 04(no projects): 2FA reset for account 1997kB - https://phabricator.wikimedia.org/T217476 (101997kB) [12:58:24] 10Trust-and-Safety: 2FA reset for account 1997kB - https://phabricator.wikimedia.org/T217476 (101997kB) [12:58:28] (03PS1) 10Umherirrender: build: Add grunt-banana-checker [extensions/NewsTicker] - 10https://gerrit.wikimedia.org/r/493804 [12:59:11] 10Trust-and-Safety: 2FA reset for account 1997kB - https://phabricator.wikimedia.org/T217476 (10Aklapper) Could you please also send an email (to ca at wikimedia dot org) from your registered email address of your wiki account, in order to confirm? Please also include the URL of this ticket in your email. Thanks... [13:14:36] (03CR) 10Krinkle: [C: 03+2] Migrate to new Phan [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493799 (https://phabricator.wikimedia.org/T216944) (owner: 10Daimona Eaytoy) [13:16:57] (03PS1) 10Daimona Eaytoy: Add phan [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 [13:18:03] (03PS1) 10Daimona Eaytoy: Add phan [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 [13:19:04] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [13:19:08] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (owner: 10Daimona Eaytoy) [13:20:36] (03Merged) 10jenkins-bot: Migrate to new Phan [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/493799 (https://phabricator.wikimedia.org/T216944) (owner: 10Daimona Eaytoy) [13:21:15] 10SyntaxHighlight, 10phan: Upgrade SyntaxHighlight_GeSHi extension to use newer phan - https://phabricator.wikimedia.org/T216944 (10Daimona) 05Open→03Resolved [13:28:09] (03PS2) 10Daimona Eaytoy: Add phan [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 [13:28:22] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [13:32:30] (03PS2) 10Daimona Eaytoy: Add phan [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 [13:32:46] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (owner: 10Daimona Eaytoy) [13:39:43] (03CR) 10Daimona Eaytoy: [C: 04-1] "Several things left to fix, waiting for Ib70c64d047a7717e09860e87f3a2d817c0ef533e." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [13:39:52] (03CR) 10Daimona Eaytoy: [C: 04-1] "Many things left to fix, waiting for Ib70c64d047a7717e09860e87f3a2d817c0ef533e." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (owner: 10Daimona Eaytoy) [13:40:54] (03PS1) 10Fomafix: Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/493809 [13:46:33] (03PS3) 10Zoranzoki21: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) [13:46:39] (03PS1) 10Jack Phoenix: Remove unwanted PLURAL: from the user-stats-* messages shown on social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/493810 [13:46:41] (03CR) 10Zoranzoki21: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [13:47:39] (03CR) 10Zoranzoki21: "Number of task?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [13:47:51] (03CR) 10Zoranzoki21: "Number of task?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (owner: 10Daimona Eaytoy) [13:48:18] (03CR) 10Jack Phoenix: [C: 03+2] Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/493809 (owner: 10Fomafix) [13:48:45] (03CR) 10jerkins-bot: [V: 04-1] Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [13:49:24] (03CR) 10Daimona Eaytoy: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [13:51:06] (03PS3) 10Daimona Eaytoy: Add phan [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (https://phabricator.wikimedia.org/T189371) [13:51:35] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Number of task?" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [13:52:01] 10MediaWiki-extensions-CentralAuth, 10MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10Patch-For-Review: phan and taint/sec for CentralAuth - https://phabricator.wikimedia.org/T189371 (10Daimona) a:03Daimona [13:52:44] (03Merged) 10jenkins-bot: Remove unnecessary defined( 'MEDIAWIKI' ) check [extensions/MultiUpload] - 10https://gerrit.wikimedia.org/r/493809 (owner: 10Fomafix) [14:06:30] (03CR) 10Daimona Eaytoy: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [14:07:08] (03CR) 10Daimona Eaytoy: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [14:10:37] 10MediaWiki-Page-editing, 10JavaScript: Preview shows wikitext instead of page title on test.wikipedia.org - https://phabricator.wikimedia.org/T105214 (10Fomafix) https://test.wikipedia.org/wiki/MediaWiki:Editing got deleted so it is no longer reproducible on this project. [14:11:22] 10Wikimedia-Site-requests: Change the favicon of the german mobile de.m.wiktionary.org site - https://phabricator.wikimedia.org/T202902 (10Formatierer) Well, it seems to be more complicated and confusing than i thought. 1. https://de.wiktionary.org/favicon.ico and https://de.wiktionary.org/apple-touch-icon.png... [14:15:19] 10MediaWiki-Page-editing, 10JavaScript: Preview shows wikitext instead of page title on test.wikipedia.org - https://phabricator.wikimedia.org/T105214 (10Fomafix) [14:21:36] (03CR) 10Fomafix: [C: 04-1] API: Better handle binary page props (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478035 (https://phabricator.wikimedia.org/T210548) (owner: 10Anomie) [14:36:48] (03CR) 10Umherirrender: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [14:38:34] (03CR) 10Daimona Eaytoy: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [14:43:07] 10Research, 10Article-Recommendation, 10Google-Summer-of-Code (2019): 'morelike' recommendation API: Bulk import data to MySQL in chunks - https://phabricator.wikimedia.org/T211980 (10Usmanmuhd) `mysql-python` package used is python3 incompatible. Maybe I can try my hand at updating it? [14:51:29] 10MediaWiki-extensions-Renameuser, 10I18n, 10RTL: Logs for renaming users with username in Arabic script should show first number of change - https://phabricator.wikimedia.org/T217456 (10Huji) @Zoranzoki21 can you give me a link to that log? I am wondering if adding a `` tag could fix this, and want to... [14:54:09] (03PS6) 10D3r1ck01: languages: Hard deprecate Language::getExtraUserToggles() method [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) [14:54:54] (03PS6) 10D3r1ck01: Switch DjVuHandler to new execution framework [core] - 10https://gerrit.wikimedia.org/r/487374 (https://phabricator.wikimedia.org/T182743) [14:55:10] (03PS6) 10D3r1ck01: Improve PHPUnit tests for SpecialExternalGuidanceTest::class [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 [14:55:34] (03PS10) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) [15:01:05] (03CR) 10Umherirrender: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 (031 comment) [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [15:02:57] (03CR) 10Umherirrender: [C: 03+1] Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) (owner: 10Daimona Eaytoy) [15:05:01] 10MediaWiki-extensions-Renameuser, 10I18n, 10RTL: Logs for renaming users with username in Arabic script should show first number of change - https://phabricator.wikimedia.org/T217456 (10Zoranzoki21) @Huji I made screenshot of recent changes on #translatewiki.net https://translatewiki.net/w/i.php?hidebots=1&... [15:08:01] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-deletion: Overhaul the undelete feature with a "pagearchive" table - https://phabricator.wikimedia.org/T206587 (10GeoffreyT2000) [15:09:06] (03CR) 10Umherirrender: [C: 03+1] Migrate to new Phan (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:09:28] (03CR) 10Esanders: [C: 03+1] "VE part looks fine" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/490697 (https://phabricator.wikimedia.org/T211490) (owner: 10Bartosz Dziewoński) [15:12:46] (03CR) 10Daimona Eaytoy: Migrate to new Phan (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:15:59] (03CR) 10Umherirrender: Upgrade StopForumSpam to use newer version of phan (031 comment) [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/492762 (https://phabricator.wikimedia.org/T216943) (owner: 10Zoranzoki21) [15:29:32] (03PS2) 10Daimona Eaytoy: Remove useless SpecialAbuseLog::getNotDeletedCond [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/489373 [15:38:03] (03PS4) 10Umherirrender: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:38:12] (03CR) 10Umherirrender: "Playing with config 'globals_type_map'" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:39:08] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493811 [15:39:17] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493812 [15:44:02] (03CR) 10Daimona Eaytoy: "> Playing with config 'globals_type_map'" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:47:29] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:50:51] (03PS1) 10D3r1ck01: Title: Code improvements around efficiency, consistency and maintainability [core] - 10https://gerrit.wikimedia.org/r/493813 [15:53:21] (03PS5) 10Umherirrender: Migrate to new Phan [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:53:33] (03CR) 10Umherirrender: [C: 03+1] "Okay, I have restored Patch Set 3" [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/493797 (https://phabricator.wikimedia.org/T216942) (owner: 10Daimona Eaytoy) [15:54:46] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/493814 [16:00:38] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/493815 [16:01:11] (03PS1) 10D3r1ck01: SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 [16:01:55] (03CR) 10jerkins-bot: [V: 04-1] SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:03:02] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/493813 (owner: 10D3r1ck01) [16:03:46] (03PS2) 10D3r1ck01: SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 [16:05:56] (03CR) 10jerkins-bot: [V: 04-1] SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:07:55] 10Trust-and-Safety, 10Wikimedia-Site-requests: 2FA reset for CentralAuth account 1997kB - https://phabricator.wikimedia.org/T217476 (10Framawiki) [16:10:21] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/493817 [16:15:31] (03PS1) 10D3r1ck01: SPHooks: Improve code for more maintaibility and efficiency [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 [16:16:10] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10User-Urbanecm: Help panel: improve links in Czech help panel - https://phabricator.wikimedia.org/T217391 (10Urbanecm) >>! In T217391's description, @MMiller_WMF wrote: > We also see that Korean's second most popular link is a quick tutorial, which li... [16:16:49] (03PS2) 10D3r1ck01: SPHooks: Improve code for more maintaibility and efficiency [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 [16:19:28] 10InternetArchiveBot (v2.0): IABot Management Interface shows Undefined Index error when trying to edit template definitions - https://phabricator.wikimedia.org/T217483 (10Cirdan) a:03Cyberpower678 [16:21:43] (03PS3) 10D3r1ck01: SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 [16:22:17] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 (owner: 10D3r1ck01) [16:22:20] (03CR) 10D3r1ck01: [C: 03+2] SPHooks: Improve code for more maintaibility and efficiency [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 (owner: 10D3r1ck01) [16:24:11] (03CR) 10jerkins-bot: [V: 04-1] SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:25:39] (03PS4) 10D3r1ck01: SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 [16:26:59] (03Merged) 10jenkins-bot: SPHooks: Improve code for more maintaibility and efficiency [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 (owner: 10D3r1ck01) [16:28:58] (03CR) 10jenkins-bot: SPHooks: Improve code for more maintaibility and efficiency [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/493818 (owner: 10D3r1ck01) [16:29:44] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:29:48] (03CR) 10D3r1ck01: [C: 03+2] SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:34:24] (03Merged) 10jenkins-bot: SPHooks: Minor code improvements to the SPHooks class [extensions/SparkPost] - 10https://gerrit.wikimedia.org/r/493816 (owner: 10D3r1ck01) [16:44:17] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493819 [16:44:46] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493820 [16:45:57] 10MediaWiki-History-and-Diffs, 10Project-Admins: Split #MediaWiki-History-or-Diffs - https://phabricator.wikimedia.org/T209651 (10Aklapper) A belated (sorry!) +1 on the idea, but wondering who to go through 261 open (or 987 in total) existing tickets. :-/ [16:46:22] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 [16:46:23] (03PS1) 10D3r1ck01: maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 [16:47:06] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 [16:47:09] (03CR) 10Krinkle: [C: 03+1] Convert caching to WANObjectCache [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493514 (owner: 10Aaron Schulz) [16:47:19] (03CR) 10Fomafix: [C: 04-1] specials: Avoid the use of global variables in Special:Version (033 comments) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [16:48:28] (03CR) 10Krinkle: objectcache: optimize WAN cache key updates during HOLDOFF_TTL (031 comment) [core] - 10https://gerrit.wikimedia.org/r/493148 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [16:48:42] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/493824 [16:49:14] (03CR) 10D3r1ck01: [C: 03+2] "Legacy hook behavior can be removed for a later patch. This LGTM!" (033 comments) [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/493817 (owner: 10Umherirrender) [16:49:21] (03CR) 10jerkins-bot: [V: 04-1] maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [16:50:04] (03CR) 10Reedy: Use ::class for class name resolution (031 comment) [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493819 (owner: 10Umherirrender) [16:51:01] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/493826 [16:51:18] (03CR) 10Krinkle: [C: 04-1] "I agree with Thiemo, although for different reasons. This is changing behaviour for use cases not intended or covered by the current needs" [core] - 10https://gerrit.wikimedia.org/r/485478 (owner: 10Gergő Tisza) [16:52:42] (03PS2) 10D3r1ck01: maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 [16:52:44] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/493826 (owner: 10Umherirrender) [16:52:55] (03CR) 10Krinkle: [C: 04-1] Improve PHPUnit tests for SpecialExternalGuidanceTest::class (031 comment) [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 (owner: 10D3r1ck01) [16:54:40] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Tracking: GIF Issues (tracking) - https://phabricator.wikimedia.org/T18456 (10Aklapper) [16:54:46] 10MediaWiki-File-management, 10Commons, 10Multimedia: Large GIF animations create errors - https://phabricator.wikimedia.org/T25063 (10Aklapper) 05Open→03Resolved Going through the examples mentioned in this ticket, * http://commons.wikimedia.org/wiki/File:Penrose_triangle_(animation).gif is correctly an... [16:55:18] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GettingStarted] - 10https://gerrit.wikimedia.org/r/493817 (owner: 10Umherirrender) [16:57:54] 10OOUI, 10Documentation, 10phan: OOUI docblocks trip Phan analysis - https://phabricator.wikimedia.org/T217471 (10Daimona) p:05Triage→03High Triaging as high because any extension using OOUI will be affected while switching to the new Phan. [16:58:13] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493812 (owner: 10Umherirrender) [16:58:23] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/493814 (owner: 10Umherirrender) [16:58:40] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493820 (owner: 10Umherirrender) [16:59:11] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/493826 (owner: 10Umherirrender) [16:59:54] (03CR) 10D3r1ck01: "Thanks a lot! :)" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [16:59:58] (03PS11) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) [17:00:06] (03CR) 10Reedy: "Looks like both of these should really be swapped out for ext-foo in composer.json" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 (owner: 10Umherirrender) [17:00:12] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 (owner: 10Umherirrender) [17:00:57] (03PS7) 10D3r1ck01: Improve PHPUnit tests for SpecialExternalGuidanceTest::class [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 [17:01:11] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/493826 (owner: 10Umherirrender) [17:01:31] (03CR) 10D3r1ck01: "thanks a lot for catching that!" (031 comment) [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 (owner: 10D3r1ck01) [17:01:51] (03CR) 10Bartosz Dziewoński: [C: 03+2] Bring back jquery.appear [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/493635 (https://phabricator.wikimedia.org/T159058) (owner: 10Jack Phoenix) [17:02:14] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/493814 (owner: 10Umherirrender) [17:03:02] (03PS1) 10Krinkle: logging: Remove 'null' return from ManualLogEntry::getTags() [core] - 10https://gerrit.wikimedia.org/r/493827 [17:03:12] 10MediaWiki-extensions-GWToolset, 10Commons, 10Multimedia, 10Technical-Debt: Remove checks for PHP modules that core already requires - https://phabricator.wikimedia.org/T217484 (10Reedy) [17:03:16] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10TestMe: Black color is always taken as transparent when downsampling GIF images using GD - https://phabricator.wikimedia.org/T26855 (10Aklapper) Anyone knows if this is still a problem? If it is, can you please provide clear steps to reproduce the pro... [17:03:39] 10MediaWiki-extensions-GWToolset, 10Commons, 10Multimedia, 10Technical-Debt, 10good first bug: Remove checks for PHP modules that core already requires - https://phabricator.wikimedia.org/T217484 (10Reedy) [17:03:47] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/493815 (owner: 10Umherirrender) [17:03:51] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/493814 (owner: 10Umherirrender) [17:04:51] (03CR) 10Reedy: Use ::class for class name resolution (031 comment) [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493811 (owner: 10Umherirrender) [17:05:51] (03CR) 10Fomafix: [C: 04-1] specials: Avoid the use of global variables in Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [17:06:23] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/493824 (owner: 10Umherirrender) [17:06:27] (03CR) 10jerkins-bot: [V: 04-1] maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [17:07:15] (03CR) 10Fomafix: specials: Avoid the use of global variables in Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [17:07:36] (03CR) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [17:07:59] (03CR) 10Reedy: [C: 03+2] Fix json indent in extension.json [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/493734 (owner: 10Umherirrender) [17:08:15] (03CR) 10D3r1ck01: specials: Avoid the use of global variables in Special:Version (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [17:09:09] (03PS2) 10Reedy: Move class CLDRParser to own file [extensions/cldr] - 10https://gerrit.wikimedia.org/r/487919 (owner: 10Umherirrender) [17:09:15] (03CR) 10Reedy: [C: 03+2] Move class CLDRParser to own file [extensions/cldr] - 10https://gerrit.wikimedia.org/r/487919 (owner: 10Umherirrender) [17:11:02] 10MediaWiki-General-or-Unknown, 10CSS: Weird CSS tooltip behaviour on iOS devices - https://phabricator.wikimedia.org/T212610 (10Aklapper) >>! In T212610#4845450, @XanonymusX wrote: > Where can I see the JS that is currently used in the mobile version of Wikipedia / Testwiki? @XanonymusX: Use your web browser... [17:11:06] (03PS1) 10Reedy: Remove a couple of pointless temp variables before returns [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493828 [17:12:51] (03PS3) 10Reedy: Move class VipsCommand and VipsConvolution to own files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/478410 (owner: 10Umherirrender) [17:13:08] (03CR) 10Reedy: [C: 03+2] Move class VipsCommand and VipsConvolution to own files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/478410 (owner: 10Umherirrender) [17:14:53] 10Phabricator, 10Performance: /maniphest/report/project/ : Maximum execution time of 10 seconds exceeded - https://phabricator.wikimedia.org/T125357 (10Aklapper) [17:14:56] 10Phabricator, 10Operations, 10serviceops, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External): Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Aklapper) [17:15:02] (03CR) 10jerkins-bot: [V: 04-1] logging: Remove 'null' return from ManualLogEntry::getTags() [core] - 10https://gerrit.wikimedia.org/r/493827 (owner: 10Krinkle) [17:15:13] (03CR) 10Umherirrender: "Thanks for T217484" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 (owner: 10Umherirrender) [17:16:20] (03PS3) 10D3r1ck01: maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 [17:17:40] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Aklapper) a:05Setian→03None [17:20:44] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Adarshpatel509) Hi @srishak... [17:21:51] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493820 (owner: 10Umherirrender) [17:21:53] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 (owner: 10Umherirrender) [17:21:56] (03Merged) 10jenkins-bot: Bring back jquery.appear [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/493635 (https://phabricator.wikimedia.org/T159058) (owner: 10Jack Phoenix) [17:21:58] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/493815 (owner: 10Umherirrender) [17:22:00] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/493824 (owner: 10Umherirrender) [17:22:06] (03Merged) 10jenkins-bot: Fix json indent in extension.json [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/493734 (owner: 10Umherirrender) [17:22:06] (03Merged) 10jenkins-bot: Move class CLDRParser to own file [extensions/cldr] - 10https://gerrit.wikimedia.org/r/487919 (owner: 10Umherirrender) [17:22:08] (03Merged) 10jenkins-bot: Move class VipsCommand and VipsConvolution to own files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/478410 (owner: 10Umherirrender) [17:22:20] (03CR) 10Fomafix: specials: Avoid the use of global variables in Special:Version (032 comments) [core] - 10https://gerrit.wikimedia.org/r/487057 (https://phabricator.wikimedia.org/T72638) (owner: 10D3r1ck01) [17:23:23] 10Wikimedia-Site-requests: Change the favicon of the german mobile de.m.wiktionary.org site - https://phabricator.wikimedia.org/T202902 (10Ammarpad) a:03Ammarpad Yes, that's true. >>! In T202902#4995483, @Formatierer wrote: > Well, it seems to be more complicated and confusing than i thought. > > 1. https://... [17:24:39] (03PS1) 10Reedy: Update extension PHP structure [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 [17:24:49] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493820 (owner: 10Umherirrender) [17:26:18] (03CR) 10Reedy: Use ::class for class name resolution (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 (owner: 10Umherirrender) [17:27:06] (03CR) 10jerkins-bot: [V: 04-1] maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [17:28:44] (03PS4) 10Ammarpad: Update application privacy statement link [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/493410 (https://phabricator.wikimedia.org/T217327) [17:28:51] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Aklapper) 05Open→03Stalled @Oshwah: Please provide a specific and not user generated MediaWiki page... [17:29:31] (03PS3) 10Reedy: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [17:29:35] (03CR) 10Reedy: [C: 03+2] Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [17:29:43] (03CR) 10Ammarpad: "> The correct URL is https://foundation.wikimedia.org/wiki/Wikimania_2019_Application_Form_Privacy_Statement" [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/493410 (https://phabricator.wikimedia.org/T217327) (owner: 10Ammarpad) [17:30:04] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/493821 (owner: 10Umherirrender) [17:30:06] 10OABot: Cannot start oabot: ImportError: liblua5.1.so.0 (due to migration from Trusty to Stretch) - https://phabricator.wikimedia.org/T215789 (10Aklapper) [17:30:14] (03CR) 10Reedy: [C: 03+2] Pass string as field to IDatabase::selectRowCount [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493744 (owner: 10Umherirrender) [17:31:22] (03PS2) 10Krinkle: logging: Remove 'null' return from ManualLogEntry::getTags() [core] - 10https://gerrit.wikimedia.org/r/493827 [17:33:09] (03CR) 10jenkins-bot: Move class CLDRParser to own file [extensions/cldr] - 10https://gerrit.wikimedia.org/r/487919 (owner: 10Umherirrender) [17:33:37] (03PS3) 10Krinkle: logging: Remove 'null' return from ManualLogEntry::getTags() [core] - 10https://gerrit.wikimedia.org/r/493827 [17:34:39] (03CR) 10jenkins-bot: Fix json indent in extension.json [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/493734 (owner: 10Umherirrender) [17:34:52] (03CR) 10Krinkle: [C: 03+2] "Agree with Reedy, but going ahead with this commit as-is." [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493819 (owner: 10Umherirrender) [17:35:23] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Adarshpatel509) [17:35:53] 10MediaWiki-Language-converter, 10Wikidata, 10Wikidata-Page-Banner, 10Chinese-Sites, and 5 others: [Spike] Title and TOC not converted for Wikidata page banner language variants - https://phabricator.wikimedia.org/T114734 (10zhuyifei1999) 05Open→03Resolved No longer reproduceable. TOC stays not convert... [17:35:56] (03CR) 10Krinkle: [C: 03+2] Document null param type [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/493750 (owner: 10Umherirrender) [17:35:58] (03PS4) 10D3r1ck01: maintenance: Fixes to code for improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 [17:39:14] (03CR) 10Reedy: [C: 03+2] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/493733 (owner: 10Umherirrender) [17:43:34] (03PS1) 10Reedy: WikiMap is going to exist, has for a looong time [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493830 [17:43:36] (03PS1) 10Reedy: Drop .class from GlobalBlocking class [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493831 [17:45:38] 10Wikimedia-Site-requests: Throttle Exception for Cell WikiGap event Maastricht - https://phabricator.wikimedia.org/T217485 (10Ciell) [17:47:03] (03PS3) 10Reedy: Declare class properties in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492506 (owner: 10Umherirrender) [17:47:09] (03CR) 10Reedy: [C: 03+2] Declare class properties in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492506 (owner: 10Umherirrender) [17:47:51] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Adarshpatel509) [17:49:10] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/493822 (owner: 10D3r1ck01) [17:49:35] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Adarshpatel509) [17:50:10] (03Merged) 10jenkins-bot: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [17:50:14] (03Merged) 10jenkins-bot: Pass string as field to IDatabase::selectRowCount [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493744 (owner: 10Umherirrender) [17:50:16] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493812 (owner: 10Umherirrender) [17:50:20] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493819 (owner: 10Umherirrender) [17:50:22] (03Merged) 10jenkins-bot: Document null param type [extensions/DynamicSidebar] - 10https://gerrit.wikimedia.org/r/493750 (owner: 10Umherirrender) [17:50:23] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Google-Summer-of-Code (2019): Develop code samples in Javascript and PHP to demonstrate the use of MediaWiki Action API modules - https://phabricator.wikimedia.org/T215681 (10Adarshpatel509) [17:50:26] (03Merged) 10jenkins-bot: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/WebDAV] - 10https://gerrit.wikimedia.org/r/493733 (owner: 10Umherirrender) [17:51:05] (03CR) 10Umherirrender: [C: 03+2] WikiMap is going to exist, has for a looong time [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493830 (owner: 10Reedy) [17:53:00] (03Merged) 10jenkins-bot: Declare class properties in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492506 (owner: 10Umherirrender) [17:54:06] (03CR) 10jenkins-bot: Pass string as field to IDatabase::selectRowCount [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493744 (owner: 10Umherirrender) [17:54:14] (03CR) 10Umherirrender: "You can remove MediaWiki.Files.ClassMatchesFilename.NotMatch from .phpcs.xml" [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493831 (owner: 10Reedy) [17:54:16] (03Merged) 10jenkins-bot: WikiMap is going to exist, has for a looong time [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493830 (owner: 10Reedy) [17:54:39] (03PS2) 10Reedy: Drop .class from GlobalBlocking class [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493831 [17:55:05] (03CR) 10Umherirrender: [C: 03+2] Remove a couple of pointless temp variables before returns [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493828 (owner: 10Reedy) [17:55:18] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493811 (owner: 10Umherirrender) [17:55:28] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 (owner: 10Umherirrender) [17:56:03] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 (owner: 10Umherirrender) [17:58:41] 10MediaWiki-History-and-Diffs, 10MediaWiki-Page-deletion: Overhaul the undelete feature with a "pagearchive" table - https://phabricator.wikimedia.org/T206587 (10Anthony_Appleyard) Many of the history-merge requests that I get are not suitable for Special:MergeHistory , but are done quicker (or only) by the ol... [18:01:29] (03CR) 10jenkins-bot: Pass string as field to IDatabase::selectField and ::selectRowCount [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493758 (owner: 10Umherirrender) [18:01:41] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Restore usage of 'local wiki' field - https://phabricator.wikimedia.org/T217099 (10Framawiki) As I understand from [[ https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/1b1f2fdc4658517bdf38a6349b34c3cef109b27c/includes/specials/SpecialGlobalRe... [18:01:44] 10Wikimedia-Site-requests: Change the favicon of the german mobile de.m.wiktionary.org site - https://phabricator.wikimedia.org/T202902 (10Ammarpad) p:05Triage→03Normal [18:02:43] (03CR) 10Umherirrender: "I have not tested, but I would assume MediaWiki.Files.ClassMatchesFilename.NotMatch in .phpcs.xml is obsolete and should be removed" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 (owner: 10Reedy) [18:02:52] (03CR) 10Umherirrender: [C: 03+2] Drop .class from GlobalBlocking class [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493831 (owner: 10Reedy) [18:03:34] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493832 [18:04:46] 10WMF-Legal, 10Wikimedia-Blog, 10Software-Licensing: Publish Wikimedia's WordPress blog theme in Git - https://phabricator.wikimedia.org/T95129 (10Framawiki) Email sent today to legal@ with a link to that task. [18:05:33] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493833 [18:06:36] (03PS1) 10D3r1ck01: BabelAutoCreate: Remove unused variable from closure and more [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493834 [18:09:35] (03PS2) 10Reedy: Update extension PHP structure [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 [18:09:40] (03CR) 10Reedy: "Let's find out :)" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 (owner: 10Reedy) [18:10:24] (03PS1) 10Slk500: Refactor: ApiBase->getTitleFromTitleOrPageId() [core] - 10https://gerrit.wikimedia.org/r/493835 [18:10:29] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [core] - 10https://gerrit.wikimedia.org/r/493835 (owner: 10Slk500) [18:12:55] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/493812 (owner: 10Umherirrender) [18:13:27] (03CR) 10Daimona Eaytoy: [C: 04-1] Remove afl_filter entirely (033 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/488482 (owner: 10Daimona Eaytoy) [18:14:10] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/493839 [18:14:40] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493840 [18:14:56] (03Merged) 10jenkins-bot: Remove a couple of pointless temp variables before returns [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493828 (owner: 10Reedy) [18:14:58] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493811 (owner: 10Umherirrender) [18:15:03] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 (owner: 10Umherirrender) [18:15:05] (03Merged) 10jenkins-bot: Drop .class from GlobalBlocking class [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/493831 (owner: 10Reedy) [18:15:07] (03CR) 10jenkins-bot: Declare class properties in maintenance scripts [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492506 (owner: 10Umherirrender) [18:15:16] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10E.imene) help!!! I am an outreac... [18:15:57] (03CR) 10Umherirrender: [C: 03+2] "Looks good ;-)" [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 (owner: 10Reedy) [18:16:49] (03CR) 10jenkins-bot: Remove a couple of pointless temp variables before returns [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493828 (owner: 10Reedy) [18:17:57] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493842 [18:18:59] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/493844 [18:19:13] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution (031 comment) [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493842 (owner: 10Umherirrender) [18:19:36] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/493844 (owner: 10Umherirrender) [18:19:53] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493823 (owner: 10Umherirrender) [18:21:41] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493834 (owner: 10D3r1ck01) [18:22:23] (03Merged) 10jenkins-bot: Update extension PHP structure [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/493829 (owner: 10Reedy) [18:23:06] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493842 (owner: 10Umherirrender) [18:23:28] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/493844 (owner: 10Umherirrender) [18:24:54] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493842 (owner: 10Umherirrender) [18:25:28] (03CR) 10Daimona Eaytoy: [C: 04-1] "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (https://phabricator.wikimedia.org/T189371) (owner: 10Daimona Eaytoy) [18:27:16] (03PS1) 10Reedy: Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 [18:27:49] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/493844 (owner: 10Umherirrender) [18:28:56] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 [18:29:19] (03PS2) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 [18:32:15] (03CR) 10jerkins-bot: [V: 04-1] Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [18:33:14] (03CR) 10Daimona Eaytoy: [C: 04-1] "check experimental" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [18:33:24] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [18:33:56] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aklapper) @E.imene: Hi and welcom... [18:34:21] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [18:34:40] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/493847 [18:36:30] (03CR) 10Daimona Eaytoy: [C: 04-1] "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493806 (https://phabricator.wikimedia.org/T189371) (owner: 10Daimona Eaytoy) [18:37:24] (03PS1) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [18:38:17] (03CR) 10jerkins-bot: [V: 04-1] Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [18:39:29] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493849 [18:39:46] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493850 [18:40:24] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10E.imene) @Aklapper sorry still di... [18:40:38] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Score] - 10https://gerrit.wikimedia.org/r/493851 [18:40:51] (03PS3) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 [18:41:22] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [18:42:09] (03PS2) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [18:42:27] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493852 [18:43:20] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/493839 (owner: 10Umherirrender) [18:43:22] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/493853 [18:44:41] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/493847 (owner: 10Umherirrender) [18:45:01] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493852 (owner: 10Umherirrender) [18:45:20] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/493853 (owner: 10Umherirrender) [18:45:55] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [18:48:00] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) [18:48:03] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [18:48:35] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/493839 (owner: 10Umherirrender) [18:48:39] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/ShortUrl] - 10https://gerrit.wikimedia.org/r/493847 (owner: 10Umherirrender) [18:50:36] (03PS1) 10Umherirrender: Remove compat check for version 1.27 [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493854 [18:52:20] (03CR) 10Reedy: [C: 03+2] "Heh, extension.json has "MediaWiki": ">= 1.28.1"" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493854 (owner: 10Umherirrender) [18:52:31] (03PS3) 10Daimona Eaytoy: Add phan [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 [18:55:17] (03PS2) 10Reedy: Move FauxResponse class to own file [core] - 10https://gerrit.wikimedia.org/r/490908 (owner: 10Umherirrender) [18:55:21] (03CR) 10Reedy: [C: 03+2] Move FauxResponse class to own file [core] - 10https://gerrit.wikimedia.org/r/490908 (owner: 10Umherirrender) [18:56:35] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: error in provider, thumb info not found - https://phabricator.wikimedia.org/T216233 (10Aklapper) 05Open→03Declined Unfortunately closing this report as no further information has been provided. @Tw2019: After you have provided the information asked fo... [19:00:26] 10Developer-Advocacy (Oct-Dec 2018): Organize a developer workshop for university students in India at the end of 2018 or beginning of 2019 - https://phabricator.wikimedia.org/T183187 (10Aklapper) @srishakatux: As I look at the calendar, any updates? Should this be updated, or declined, or the milestone tag chan... [19:01:08] 10Google-Code-in-2018, 10Outreach-Programs-Projects, 10Developer-Advocacy (Oct-Dec 2018): [GCI] Review and improve a MediaWiki Action API documentation page on mediawiki.org - https://phabricator.wikimedia.org/T206275 (10Aklapper) @srishakatux: As this is under Oct-Dec2018, any updates? Should this be declined? [19:01:29] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [19:01:35] 10Developer-Advocacy, 10International-Developer-Events: Investigate workflow to identify recently active new volunteer technical contributors in Gerrit (to potentially invite them to upcoming Hackathons) - https://phabricator.wikimedia.org/T189496 (10Aklapper) [19:04:30] (03CR) 10Aaron Schulz: objectcache: optimize WAN cache key updates during HOLDOFF_TTL (031 comment) [core] - 10https://gerrit.wikimedia.org/r/493148 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [19:04:34] 10Developer-Advocacy, 10TechCom-RFC (TechCom-Approved): RFC: Update to Gerrit privilege policy - https://phabricator.wikimedia.org/T216295 (10Aklapper) Will this also touch / update {T199385} and/or supersede {T200322}? [19:05:06] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493852 (owner: 10Umherirrender) [19:05:08] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/493853 (owner: 10Umherirrender) [19:05:10] (03Merged) 10jenkins-bot: Remove compat check for version 1.27 [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493854 (owner: 10Umherirrender) [19:06:37] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/cldr] - 10https://gerrit.wikimedia.org/r/493852 (owner: 10Umherirrender) [19:10:25] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493856 [19:10:31] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493840 (owner: 10Umherirrender) [19:11:37] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493860 [19:16:13] (03Merged) 10jenkins-bot: Move FauxResponse class to own file [core] - 10https://gerrit.wikimedia.org/r/490908 (owner: 10Umherirrender) [19:17:44] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493840 (owner: 10Umherirrender) [19:18:12] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 [19:18:31] (03CR) 10jenkins-bot: Move FauxResponse class to own file [core] - 10https://gerrit.wikimedia.org/r/490908 (owner: 10Umherirrender) [19:18:54] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/Score] - 10https://gerrit.wikimedia.org/r/493865 [19:18:56] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Score] - 10https://gerrit.wikimedia.org/r/493851 (owner: 10Umherirrender) [19:19:31] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493840 (owner: 10Umherirrender) [19:21:32] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493850 (owner: 10Umherirrender) [19:22:01] (03PS1) 10Reedy: Add extension.json dependancy on Math to MatchCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 [19:24:39] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Restore usage of 'local wiki' field - https://phabricator.wikimedia.org/T217099 (10MarcoAurelio) >>! In T217099#4995657, @Framawiki wrote: > As I understand from [[ https://github.com/wikimedia/mediawiki-extensions-CentralAuth/blob/1b1f2fdc4658517bdf38a6349b3... [19:26:41] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Score] - 10https://gerrit.wikimedia.org/r/493851 (owner: 10Umherirrender) [19:27:36] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 [19:27:39] (03PS1) 10Reedy: Move PHP files to includes/ [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 [19:27:47] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493860 (owner: 10Umherirrender) [19:29:59] (03CR) 10jerkins-bot: [V: 04-1] Move PHP files to includes/ [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 (owner: 10Reedy) [19:30:36] (03PS2) 10Reedy: Move PHP files to includes/ [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493868 [19:31:56] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493850 (owner: 10Umherirrender) [19:31:58] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493860 (owner: 10Umherirrender) [19:32:50] (03CR) 10Reedy: Use ::class for class name resolution (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [19:33:51] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493850 (owner: 10Umherirrender) [19:37:38] (03CR) 10Legoktm: [C: 03+2] "Awesome." [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [19:40:38] (03CR) 10Legoktm: Fix documentation errors reported by Phan (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 (owner: 10Daimona Eaytoy) [19:44:27] (03PS1) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493871 [19:44:38] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493849 (owner: 10Umherirrender) [19:46:26] (03CR) 10jerkins-bot: [V: 04-1] Add extension.json dependancy on Math to MatchCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 (owner: 10Reedy) [19:47:04] (03PS2) 10Reedy: Add extension.json dependancy on Math to MatchCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 [19:48:10] 10MediaWiki-Core-Testing: PHPUnit: "Logs generated by test case" output repeats the line from PHPUnitCommand - https://phabricator.wikimedia.org/T217489 (10Krinkle) [19:48:39] (03CR) 10Krinkle: "See T217487." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [19:48:53] (03CR) 10Krinkle: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493871 (owner: 10Reedy) [19:49:47] 10MediaWiki-Uploading, 10Commons, 10Multimedia, 10UploadWizard: Errors while uploading images - https://phabricator.wikimedia.org/T211693 (10Aklapper) 05Stalled→03Declined Unfortunately closing this report as no further information has been provided. @IM3847: After you have provided the information as... [19:51:19] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, 10Release-Engineering-Team: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) p:05Triage→03High [19:52:30] (03Abandoned) 10Aklapper: added [extensions/examples] - 10https://gerrit.wikimedia.org/r/493372 (owner: 10Veerendratholeti) [19:53:49] 10Phabricator, 10Mail, 10Operations: DomainKeys Identified Mail (DKIM) for phabricator.wikimedia.org - https://phabricator.wikimedia.org/T116805 (10Aklapper) >>! In T116805#4965322, @Niedzielski wrote: > This is only a single datapoint but I noticed a Phab comment email notification from gerritbot was mistak... [19:54:54] 10Phabricator, 10Mail: "Wikimedia Foundation mail couldn't verify phabricator.wikimedia.org actually sent this message (and not a spammer)" in GMail - https://phabricator.wikimedia.org/T144381 (10Aklapper) SPF recently got fixed in T216714; wondering if folks still experience this? [19:58:24] (03Merged) 10jenkins-bot: Add phan [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [19:58:28] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493849 (owner: 10Umherirrender) [19:58:30] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493871 (owner: 10Reedy) [19:59:45] 10MediaWiki-extensions-CentralAuth, 10GlobalRename: Restore usage of 'local wiki' field - https://phabricator.wikimedia.org/T217099 (10Nihlus) Probably more accurate to say "home wiki" given that is what is used in the requests themselves. I don't believe it tracks where the request actually came from, but I c... [20:00:46] (03PS4) 10Legoktm: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [20:01:49] 10MediaWiki-extensions-InputBox, 10User-Zoranzoki21, 10phan: Upgrade InputBox extension to use newer phan - https://phabricator.wikimedia.org/T216922 (10Zoranzoki21) a:03Zoranzoki21 [20:03:00] (03PS1) 10Zoranzoki21: Upgrade InputBox extension to use newer phan [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/493877 (https://phabricator.wikimedia.org/T216922) [20:06:05] (03CR) 10Legoktm: [C: 03+2] "php-mysqli is now included in the docker image used to run phan, so it finds the constant properly." [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [20:06:33] (03CR) 10jenkins-bot: Add phan [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/493805 (owner: 10Daimona Eaytoy) [20:08:31] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493871 (owner: 10Reedy) [20:09:47] (03CR) 10Legoktm: "recheck" [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/493877 (https://phabricator.wikimedia.org/T216922) (owner: 10Zoranzoki21) [20:11:44] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493849 (owner: 10Umherirrender) [20:12:04] (03CR) 10Legoktm: [C: 03+2] Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) (owner: 10Daimona Eaytoy) [20:12:13] (03CR) 10Daimona Eaytoy: Fix documentation errors reported by Phan (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493782 (owner: 10Daimona Eaytoy) [20:13:01] (03CR) 10Legoktm: [C: 03+2] Upgrade InputBox extension to use newer phan [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/493877 (https://phabricator.wikimedia.org/T216922) (owner: 10Zoranzoki21) [20:15:30] (03PS2) 10Reedy: Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:15:40] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:17:34] (03Merged) 10jenkins-bot: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [20:17:38] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:18:01] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:19:52] (03CR) 10jenkins-bot: Bump version of mediawiki/mediawiki-phan-config to 0.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/493776 (https://phabricator.wikimedia.org/T216920) (owner: 10Zoranzoki21) [20:21:26] (03PS3) 10Reedy: Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:21:29] 10GeoData, 10Discovery-Search (Current work), 10Patch-For-Review, 10phan: Upgrade GeoData extension to use newer phan - https://phabricator.wikimedia.org/T216920 (10Zoranzoki21) 05Open→03Resolved Looks good now, reclosing as resolved :) [20:21:41] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:23:35] Reedy: https://gerrit.wikimedia.org/r/493875 [20:24:13] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, 10Release-Engineering-Team: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Umherirrender) https://gerrit.wikimedia.org/r/#/c/integration/config/+/493808/4/zuul/pa... [20:25:25] Krinkle: I can't merge it :) [20:25:39] (03PS1) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [20:25:55] Reedy: Ha, touché [20:26:44] Reedy: I think now you can. [20:27:18] "I'm not going to self merge, so I'll grant someone else rights so they can merge it for you" [20:27:31] sounds like a plan! [20:27:56] lol [20:27:59] :D [20:28:16] It was missing ldap/wmf. [20:28:19] relatedly, I have a bunch of API-related patches against a bunch of extensions (that I primarily maintain), who wants to review and hopefully merge 'em? :] [20:29:29] (03CR) 10Reedy: [C: 03+1] "Patch is definitely useful, will revert the problematic CI patch in the meantime though" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:30:01] ENOMEM, great. [20:31:19] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:31:54] (03CR) 10Reedy: [C: 03+1] "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:32:44] (03Merged) 10jenkins-bot: Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) (owner: 10Daimona Eaytoy) [20:33:20] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:34:25] (03PS2) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [20:34:29] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Reedy) p:05High→03Normal [20:36:38] (03CR) 10Krinkle: Improve PHPUnit tests for SpecialExternalGuidanceTest::class (032 comments) [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 (owner: 10D3r1ck01) [20:37:00] (03CR) 10jenkins-bot: Migrate to new Phan [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493800 (https://phabricator.wikimedia.org/T216907) (owner: 10Daimona Eaytoy) [20:38:19] (03Merged) 10jenkins-bot: Upgrade InputBox extension to use newer phan [extensions/InputBox] - 10https://gerrit.wikimedia.org/r/493877 (https://phabricator.wikimedia.org/T216922) (owner: 10Zoranzoki21) [20:38:21] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:38:23] (03CR) 10Krinkle: [C: 03+2] BabelAutoCreate: Remove unused variable from closure and more [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493834 (owner: 10D3r1ck01) [20:39:47] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [20:39:50] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [20:39:53] (03CR) 10Reedy: "recheck" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [20:40:37] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493864 (owner: 10Umherirrender) [20:40:54] 10MediaWiki-extensions-InputBox, 10Patch-For-Review, 10User-Zoranzoki21, 10phan: Upgrade InputBox extension to use newer phan - https://phabricator.wikimedia.org/T216922 (10Zoranzoki21) 05Open→03Resolved [20:41:53] (03CR) 10Umherirrender: Use ExtensionRegistry rather than class_exists (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/493865 (owner: 10Reedy) [20:42:19] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [20:42:33] (03PS2) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/Score] - 10https://gerrit.wikimedia.org/r/493865 [20:42:36] (03CR) 10Umherirrender: Use ExtensionRegistry rather than class_exists (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 (owner: 10Reedy) [20:43:15] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493856 (owner: 10Reedy) [20:43:54] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493833 (owner: 10Reedy) [20:44:21] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493832 (owner: 10Reedy) [20:44:52] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [20:46:22] (03CR) 10Krinkle: objectcache: optimize WAN cache key updates during HOLDOFF_TTL (031 comment) [core] - 10https://gerrit.wikimedia.org/r/493148 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [20:46:26] (03PS3) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [20:46:36] (03PS1) 10MarcoAurelio: Testing replication on a renamed repo. [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493882 [20:46:57] (03PS2) 10MarcoAurelio: Testing replication on a renamed repo. [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493882 [20:47:03] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Testing replication on a renamed repo. [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493882 (owner: 10MarcoAurelio) [20:48:10] (03PS1) 10MarcoAurelio: Revert "Testing replication on a renamed repo." [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493883 [20:48:20] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Revert "Testing replication on a renamed repo." [wikimedia/github-community-health-defaults] - 10https://gerrit.wikimedia.org/r/493883 (owner: 10MarcoAurelio) [20:48:56] 04(no projects): Wikimedia-Site-requests - https://phabricator.wikimedia.org/T217492 (10Marswrae) [20:49:12] (03CR) 10jerkins-bot: [V: 04-1] Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [20:49:16] (03Merged) 10jenkins-bot: BabelAutoCreate: Remove unused variable from closure and more [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493834 (owner: 10D3r1ck01) [20:49:20] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493856 (owner: 10Reedy) [20:50:05] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Reedy) [20:51:28] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Zoranzoki21) @Marswrae > The list of wikis you wish to allow account creation on > sorry, I don't know what this means It means list of wikis where you want to create accounts. [20:51:33] (03PS4) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [20:51:45] (03CR) 10Legoktm: "+1 to RegexChecker, but how will UnusedSuppression work with our phan-taint-check-plugin?" [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [20:51:54] (03CR) 10jenkins-bot: BabelAutoCreate: Remove unused variable from closure and more [extensions/Babel] - 10https://gerrit.wikimedia.org/r/493834 (owner: 10D3r1ck01) [20:53:15] 10MediaWiki-Core-Testing, 10PHP 7.0 support, 10Patch-For-Review, 10phan: Report PREG_REPLACE_EVAL as deprecated in codesniffer - https://phabricator.wikimedia.org/T191676 (10Legoktm) [20:54:00] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/493856 (owner: 10Reedy) [20:55:20] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Marswrae) [20:59:15] (03CR) 10Jkroll: [C: 03+1] Fix matching of moved lines in some cases (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/493258 (https://phabricator.wikimedia.org/T215293) (owner: 10Jkroll) [20:59:18] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Daimona) Thanks for the prompt fix! I'm sorry for the inconvenience, although IMHO it's been useful to... [20:59:35] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Zoranzoki21) @Marswrae No creating new wikis. I meant on existing wikis. And we need list of wikis where you will make contributions.. [21:00:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/493884 (owner: 10L10n-bot) [21:00:38] (03CR) 10Jkroll: [C: 03+1] ">" (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/493258 (https://phabricator.wikimedia.org/T215293) (owner: 10Jkroll) [21:02:26] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [21:02:47] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493833 (owner: 10Reedy) [21:02:49] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Campaigns] - 10https://gerrit.wikimedia.org/r/493832 (owner: 10Reedy) [21:03:26] (03CR) 10Daimona Eaytoy: "> +1 to RegexChecker, but how will UnusedSuppression work with our" [tools/phan] - 10https://gerrit.wikimedia.org/r/493794 (https://phabricator.wikimedia.org/T191676) (owner: 10Daimona Eaytoy) [21:04:14] 10MediaWiki-extensions-Babel, 10phan: Upgrade Babel extension to use newer phan - https://phabricator.wikimedia.org/T216907 (10Daimona) 05Open→03Resolved [21:05:33] (03PS3) 10Umherirrender: Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) [21:06:24] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [21:06:27] 10MediaWiki-extensions-OAuth, 10MediaWiki-extensions-UserMerge, 10Growth-Team, 10Notifications, and 2 others: OAuth tests failing with Echo/UserMerge issues - https://phabricator.wikimedia.org/T217487 (10Umherirrender) >>! In T217487#4995844, @Daimona wrote: > Thanks for the prompt fix! I'm sorry for the i... [21:07:42] (03PS1) 10Zoranzoki21: Move images in resources directory [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493886 [21:09:29] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/493833 (owner: 10Reedy) [21:10:47] (03PS1) 10Zoranzoki21: Upgrade ImageMap extension to use newer phan [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493887 (https://phabricator.wikimedia.org/T216921) [21:11:23] (03CR) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493846 (owner: 10Reedy) [21:14:33] (03PS1) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 [21:17:07] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:17:23] (03CR) 10jerkins-bot: [V: 04-1] Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 (owner: 10Umherirrender) [21:21:08] (03CR) 10jerkins-bot: [V: 04-1] Upgrade ImageMap extension to use newer phan [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/493887 (https://phabricator.wikimedia.org/T216921) (owner: 10Zoranzoki21) [21:21:58] (03PS3) 10Umherirrender: Add extension.json dependency on Math to MathCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 (owner: 10Reedy) [21:22:02] (03CR) 10Umherirrender: [C: 03+2] Add extension.json dependency on Math to MathCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 (owner: 10Reedy) [21:23:14] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Marswrae) [21:24:47] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Marswrae) [21:25:30] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Zoranzoki21) @Marswrae We no need list of articles which you will edit. Ok, as I understand you, you will work only on English Wikipedia? [21:27:38] 04(no projects): Insert project title here - https://phabricator.wikimedia.org/T217493 (10priyanshu_varshney) [21:28:33] (03PS2) 10MarcoAurelio: Add current username to centralauth-login-error-locked for {{GENDER: [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/491245 (owner: 10Brian Wolff) [21:30:53] (03PS3) 10MarcoAurelio: Add current username to centralauth-login-error-locked for {{GENDER: [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/491245 (owner: 10Brian Wolff) [21:33:04] (03PS2) 10Umherirrender: Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [21:33:07] (03CR) 10Umherirrender: [C: 03+2] Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [21:33:33] 04(no projects): Insert project title here - https://phabricator.wikimedia.org/T217493 (10Zoranzoki21) This is for? [21:34:13] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/Score] - 10https://gerrit.wikimedia.org/r/493865 (owner: 10Reedy) [21:36:50] 10Wikimedia-Site-requests: Throttle request for UMN_Women_in_STEM_Edit-a-Thon - https://phabricator.wikimedia.org/T217492 (10Marswrae) Only working in English [21:40:05] (03PS2) 10Umherirrender: Use explicit columns and avoid SELECT * [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493888 [21:40:42] (03Merged) 10jenkins-bot: Add extension.json dependency on Math to MathCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 (owner: 10Reedy) [21:40:46] (03Merged) 10jenkins-bot: Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [21:40:48] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/Score] - 10https://gerrit.wikimedia.org/r/493865 (owner: 10Reedy) [21:42:44] (03CR) 10jenkins-bot: Add extension.json dependency on Math to MathCaptcha [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/493866 (owner: 10Reedy) [21:44:30] (03CR) 10jenkins-bot: Remove PHP entry point [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493845 (owner: 10Reedy) [21:46:28] (03PS5) 10Reedy: Move most PHP files to includes/ [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 [21:46:35] (03CR) 10Reedy: "Rebased" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493848 (owner: 10Reedy) [21:48:57] 04(no projects): Insert project title here - https://phabricator.wikimedia.org/T217493 (10Aklapper) @Zoranzoki21: It's either for Outreachy or Google Summer of Code, I guess. :) @priyanshu_varshney: Could you click "Edit Task" and enter an actual task summary please, plus clarify? Thanks. [21:57:30] (03CR) 10Reedy: "LGTM, but want to leave it for an Echo maintainer (CC'd Roan)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [21:57:33] (03CR) 10Reedy: [C: 03+1] Fix UserMerge integration for use with table prefix [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493880 (https://phabricator.wikimedia.org/T217487) (owner: 10Umherirrender) [22:01:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/493899 (owner: 10L10n-bot) [22:06:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/493933 (owner: 10L10n-bot) [22:07:59] (03CR) 10Brian Wolff: "I don't think it is a requirement, but it would be nice if the log included what version the file was reverted to, presumably identified b" [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [22:12:53] 04(no projects): Insert project title here - https://phabricator.wikimedia.org/T217493 (10priyanshu_varshney) @Aklapper @Zoranzoki21 Yes, It is for Google Summer of Code. Actually, I am still working on it and it will definitely take much time. I thought that it will be my private page for the time being. I... [22:13:39] 04(no projects): Improve the interface of Special:ViewData in the Cargo extension - https://phabricator.wikimedia.org/T217493 (10priyanshu_varshney) [22:15:57] 10Google-Summer-of-Code (2019): Improve the interface of Special:ViewData in the Cargo extension - https://phabricator.wikimedia.org/T217493 (10priyanshu_varshney) [22:16:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/493915 (owner: 10L10n-bot) [22:19:06] (03CR) 10Krinkle: [C: 03+2] "Extension is marked unmaintained. The de facto default for mw extensions is not to maintain this kind of file, and as such, the collective" [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [22:19:12] (03CR) 10jerkins-bot: [V: 04-1] Remove RELEASE-NOTES [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [22:19:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/493914 (owner: 10L10n-bot) [22:20:17] (03CR) 10Umherirrender: [C: 04-1] Use ExtensionRegistry rather than class_exists [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 (owner: 10Reedy) [22:20:52] (03PS2) 10Reedy: Use ExtensionRegistry rather than class_exists [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 [22:21:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/493918 (owner: 10L10n-bot) [22:22:42] (03CR) 10Krinkle: [C: 04-1] SpecialMultiLock: Fix phan-taint-check-plugin errors [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/459408 (https://phabricator.wikimedia.org/T189227) (owner: 10Legoktm) [22:23:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/493917 (owner: 10L10n-bot) [22:24:31] (03PS2) 10Krinkle: [WIP] Configure phan-taint-check-plugin [core] - 10https://gerrit.wikimedia.org/r/462543 (owner: 10Legoktm) [22:27:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493920 (owner: 10L10n-bot) [22:33:19] (03CR) 10Umherirrender: [C: 03+2] Use ExtensionRegistry rather than class_exists [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 (owner: 10Reedy) [22:34:38] (03CR) 10Krinkle: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/462543 (owner: 10Legoktm) [22:34:49] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/493961 [22:35:58] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/493961 (owner: 10Umherirrender) [22:36:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/493923 (owner: 10L10n-bot) [22:37:46] (03Merged) 10jenkins-bot: Use ExtensionRegistry rather than class_exists [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/493867 (owner: 10Reedy) [22:37:53] (03PS1) 10D3r1ck01: includes: Improve on code for consistency, efficiency and maintainability [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/493962 [22:38:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/493930 (owner: 10L10n-bot) [22:39:09] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/493961 (owner: 10Umherirrender) [22:39:44] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493964 [22:40:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/493929 (owner: 10L10n-bot) [22:40:35] (03CR) 10Krinkle: "Hm.. I guess it's not in the experimental line anymore." [core] - 10https://gerrit.wikimedia.org/r/462543 (owner: 10Legoktm) [22:40:37] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/462543 (owner: 10Legoktm) [22:41:12] (03Abandoned) 10Krinkle: [DNM] jenkins testing [core] - 10https://gerrit.wikimedia.org/r/449662 (owner: 10Legoktm) [22:42:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/493935 (owner: 10L10n-bot) [22:42:34] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 [22:43:17] (03PS4) 10Brian Wolff: Add separate log action for file reverts [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [22:43:48] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 [22:44:56] (03PS8) 10D3r1ck01: Improve PHPUnit tests for SpecialExternalGuidanceTest::class [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 [22:45:13] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [22:45:22] (03CR) 10D3r1ck01: "Thanks and that makes a lot of sense." (032 comments) [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/490827 (owner: 10D3r1ck01) [22:45:33] (03PS1) 10Umherirrender: Remove class_exists for own class from maintenance script [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493969 [22:45:35] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493970 [22:45:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/493932 (owner: 10L10n-bot) [22:46:10] (03PS6) 10Krinkle: Add method scope visibility [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [22:46:31] (03CR) 10Krinkle: [C: 03+2] Add method scope visibility [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [22:46:47] (03PS1) 10Umherirrender: Use ::class for class name resolution [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/493973 [22:47:14] (03CR) 10Krinkle: [C: 03+1] "(Needs rebase, various things have changed in the repo)" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/469832 (owner: 10Legoktm) [22:47:29] (03PS2) 10Krinkle: Declare class properties [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/486879 (owner: 10Umherirrender) [22:47:31] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/493961 (owner: 10Umherirrender) [22:48:08] (03CR) 10Krinkle: [C: 03+2] Declare class properties [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/486879 (owner: 10Umherirrender) [22:48:46] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/493962 (owner: 10D3r1ck01) [22:49:27] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [22:51:18] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 [22:51:21] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [22:52:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/493936 (owner: 10L10n-bot) [22:54:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/493938 (owner: 10L10n-bot) [22:55:12] (03CR) 10jerkins-bot: [V: 04-1] Add method scope visibility [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [22:55:48] (03CR) 10Krinkle: [C: 04-1] "I don't understand the addition to hooks.txt." [core] - 10https://gerrit.wikimedia.org/r/486724 (owner: 10Umherirrender) [22:57:43] (03PS2) 10Krinkle: DWIM in CategoryManager [extensions/Linter] - 10https://gerrit.wikimedia.org/r/491553 (owner: 10Legoktm) [22:57:46] (03CR) 10Krinkle: [C: 03+2] DWIM in CategoryManager [extensions/Linter] - 10https://gerrit.wikimedia.org/r/491553 (owner: 10Legoktm) [22:58:24] (03PS6) 10Krinkle: Add @var to Pager classes [core] - 10https://gerrit.wikimedia.org/r/482039 (owner: 10Umherirrender) [22:58:26] (03CR) 10Brian Wolff: [C: 03+1] "> I don't think it is a requirement, but it would be nice if the log included what version the file was reverted to, presumably identified" [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [22:59:19] (03PS2) 10Krinkle: validateRegistrationFile: Accept glob patterns [core] - 10https://gerrit.wikimedia.org/r/492431 (owner: 10Legoktm) [22:59:23] (03CR) 10Krinkle: [C: 03+2] validateRegistrationFile: Accept glob patterns [core] - 10https://gerrit.wikimedia.org/r/492431 (owner: 10Legoktm) [23:00:51] (03CR) 10Krinkle: [C: 03+2] Construct OpenStackNovaUser always with username [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/492479 (owner: 10Umherirrender) [23:01:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/493937 (owner: 10L10n-bot) [23:04:03] (03Merged) 10jenkins-bot: Declare class properties [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/486879 (owner: 10Umherirrender) [23:04:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/493942 (owner: 10L10n-bot) [23:04:22] (03Merged) 10jenkins-bot: DWIM in CategoryManager [extensions/Linter] - 10https://gerrit.wikimedia.org/r/491553 (owner: 10Legoktm) [23:09:30] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493964 (owner: 10Umherirrender) [23:10:23] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/493973 (owner: 10Umherirrender) [23:14:31] (03CR) 10Reedy: Use ::class for class name resolution (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 (owner: 10Umherirrender) [23:16:34] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493970 (owner: 10Umherirrender) [23:16:44] 10Mathe für Nicht-Freaks: Todos im Artikel "Algebra" abarbeiten - https://phabricator.wikimedia.org/T209617 (10ZornschesLemma) a:03Kulla [23:17:45] (03CR) 10Reedy: [C: 03+2] Remove class_exists for own class from maintenance script [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493969 (owner: 10Umherirrender) [23:19:21] (03PS2) 10Umherirrender: Use ::class for class name resolution [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 [23:20:04] (03Merged) 10jenkins-bot: validateRegistrationFile: Accept glob patterns [core] - 10https://gerrit.wikimedia.org/r/492431 (owner: 10Legoktm) [23:20:06] (03Merged) 10jenkins-bot: Construct OpenStackNovaUser always with username [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/492479 (owner: 10Umherirrender) [23:20:56] (03PS1) 10Umherirrender: Remove compat code for OOUI\ButtonInputWidget [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493974 [23:21:43] (03CR) 10Umherirrender: Use ::class for class name resolution (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 (owner: 10Umherirrender) [23:22:05] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493964 (owner: 10Umherirrender) [23:22:07] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/493973 (owner: 10Umherirrender) [23:22:09] (03CR) 10Reedy: [C: 03+2] Remove compat code for OOUI\ButtonInputWidget [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493974 (owner: 10Umherirrender) [23:22:13] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 (owner: 10Umherirrender) [23:22:33] (03CR) 10jenkins-bot: validateRegistrationFile: Accept glob patterns [core] - 10https://gerrit.wikimedia.org/r/492431 (owner: 10Legoktm) [23:23:04] (03CR) 10jenkins-bot: DWIM in CategoryManager [extensions/Linter] - 10https://gerrit.wikimedia.org/r/491553 (owner: 10Legoktm) [23:24:00] (03Merged) 10jenkins-bot: Remove class_exists for own class from maintenance script [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493969 (owner: 10Umherirrender) [23:24:03] (03CR) 10jerkins-bot: [V: 04-1] Use ::class for class name resolution [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493970 (owner: 10Umherirrender) [23:25:09] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/493964 (owner: 10Umherirrender) [23:25:45] (03CR) 10Reedy: [C: 03+2] "recheck" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493970 (owner: 10Umherirrender) [23:29:04] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493966 (owner: 10Umherirrender) [23:29:11] (03CR) 10Brian Wolff: [C: 03+2] "> My local test wiki is having some issues related to the comment schema change, before merging i want to test on an unbroken install." [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [23:29:48] (03CR) 10Brian Wolff: [C: 03+2] "One thing to note, is this could effect some antivandalism bots who won't recognize the new log format when it appears on the irc recent c" [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [23:31:08] (03CR) 10Reedy: [C: 03+2] Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [23:32:47] (03Merged) 10jenkins-bot: Remove compat code for OOUI\ButtonInputWidget [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/493974 (owner: 10Umherirrender) [23:32:49] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/493970 (owner: 10Umherirrender) [23:35:52] (03PS2) 10Brian Wolff: Various fixes to make phan-taint-check happier [core] - 10https://gerrit.wikimedia.org/r/491041 (https://phabricator.wikimedia.org/T216348) [23:45:54] 10MediaWiki-extensions-DonationInterface: Can we bump DonationInterface's required MW version? - https://phabricator.wikimedia.org/T217498 (10Reedy) [23:46:15] 10MediaWiki-extensions-DonationInterface, 10Fundraising-Backlog, 10fundraising-tech-ops: Can we bump DonationInterface's required MW version? - https://phabricator.wikimedia.org/T217498 (10Reedy) [23:48:52] (03Merged) 10jenkins-bot: Add separate log action for file reverts [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [23:49:28] (03PS3) 10Umherirrender: Various fixes to make phan-taint-check happier [core] - 10https://gerrit.wikimedia.org/r/491041 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [23:49:33] (03CR) 10Umherirrender: [C: 03+2] Various fixes to make phan-taint-check happier [core] - 10https://gerrit.wikimedia.org/r/491041 (https://phabricator.wikimedia.org/T216348) (owner: 10Brian Wolff) [23:51:08] (03CR) 10jenkins-bot: Add separate log action for file reverts [core] - 10https://gerrit.wikimedia.org/r/463819 (https://phabricator.wikimedia.org/T60209) (owner: 10MGChecker) [23:52:11] (03Merged) 10jenkins-bot: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender) [23:55:12] (03CR) 10Umherirrender: [C: 03+2] "Resubmit" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [23:55:19] (03CR) 10Reedy: "recheck" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/472703 (owner: 10Umherirrender) [23:58:04] (03CR) 10jenkins-bot: Use ::class for class name resolution [extensions/Flow] - 10https://gerrit.wikimedia.org/r/493967 (owner: 10Umherirrender)