[00:01:32] (03Merged) 10jenkins-bot: Removed hooked functions' retvals (not needed since MW 1.22+), call $parser->getOutput() only once and store the result in a variable [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/492515 (owner: 10Jack Phoenix) [00:01:44] (03CR) 10MaxSem: [C: 03+2] Remove comments literally documenting unit tests being unit tests [core] - 10https://gerrit.wikimedia.org/r/491489 (owner: 10Thiemo Kreuz (WMDE)) [00:19:58] (03Merged) 10jenkins-bot: Remove comments literally documenting unit tests being unit tests [core] - 10https://gerrit.wikimedia.org/r/491489 (owner: 10Thiemo Kreuz (WMDE)) [00:21:10] (03CR) 10Krinkle: [C: 04-1] Document type for class properties in ResourceLoaderImageModule (032 comments) [core] - 10https://gerrit.wikimedia.org/r/492502 (owner: 10Umherirrender) [00:22:07] (03CR) 10jenkins-bot: Remove comments literally documenting unit tests being unit tests [core] - 10https://gerrit.wikimedia.org/r/491489 (owner: 10Thiemo Kreuz (WMDE)) [00:25:59] (03CR) 10Krinkle: "The reason this feature was proposed for deprecation is because it is not defined for any language. As such, even if it is used (internall" [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) (owner: 10D3r1ck01) [00:26:20] (03CR) 10Krinkle: [C: 03+2] Upgrade moment from 2.19.3 to 2.24.0 [core] - 10https://gerrit.wikimedia.org/r/485992 (https://phabricator.wikimedia.org/T191339) (owner: 10Jforrester) [00:27:51] 10InternetArchiveBot: Convert all Archive Today domains to .TODAY - https://phabricator.wikimedia.org/T213002 (10Green_Cardamom) Closing unnecessary [00:28:01] 10InternetArchiveBot: Convert all Archive Today domains to .TODAY - https://phabricator.wikimedia.org/T213002 (10Green_Cardamom) 05Open→03Invalid [00:29:38] 10TemplateStyles: Add 'width: -webkit-fill-available' to allowed syntax for TemplateStyles - https://phabricator.wikimedia.org/T216897 (10Tgr) [00:29:40] 10Core Platform Team, 10TemplateStyles, 10css-sanitizer, 10Core Platform Team Backlog (Later), 10Patch-For-Review: Decide which non-standard CSS properties to support in TemplateStyles - https://phabricator.wikimedia.org/T162379 (10Tgr) [00:34:36] 10InternetArchiveBot: Feature: Cosmetic Edit function - https://phabricator.wikimedia.org/T210956 (10Green_Cardamom) Cosmetic function: Convert archive.is/fo/il to archive.today This is not necessary to function, but could be one day, and the site prefers we use .today Idea is chip away at conversion now to m... [00:38:38] (03Merged) 10jenkins-bot: Upgrade moment from 2.19.3 to 2.24.0 [core] - 10https://gerrit.wikimedia.org/r/485992 (https://phabricator.wikimedia.org/T191339) (owner: 10Jforrester) [00:40:56] (03CR) 10jenkins-bot: Upgrade moment from 2.19.3 to 2.24.0 [core] - 10https://gerrit.wikimedia.org/r/485992 (https://phabricator.wikimedia.org/T191339) (owner: 10Jforrester) [01:05:13] 10MediaWiki-Interwiki: Integrate interwiki titles into LinkCache - https://phabricator.wikimedia.org/T216873 (10Setian) Legoktm, I took a look at your 2014 patch here: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/177960/5/includes/cache/LinkCache.php I notice it made changes to the following: - LinkCache... [01:15:24] 10MonoBook: HotCat breaks on update from MW1.31.1 to 1.32.0 in skin Monobook - https://phabricator.wikimedia.org/T216891 (10Tenbergen) @Aklapper: I think it is related to Monobook because it works in Vector. I usually have vector disabled on this wiki, but enabled it just to test. Config change to vector, works.... [01:18:26] (03PS11) 10Evad37: Add support for loading script URLs, similar to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) [01:20:59] (03CR) 10Krinkle: "Per T212460, consider writing an array-returning PHP file instead." [css-sanitizer] - 10https://gerrit.wikimedia.org/r/436338 (https://phabricator.wikimedia.org/T162379) (owner: 10Anomie) [01:23:46] (03CR) 10Krinkle: WIP: Support vendor prefixes (031 comment) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/436338 (https://phabricator.wikimedia.org/T162379) (owner: 10Anomie) [01:31:38] (03CR) 10jerkins-bot: [V: 04-1] Add support for loading script URLs, similar to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [01:43:31] (03PS12) 10Evad37: Add support for loading script URLs, similar to mw.loader.using [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) [01:58:12] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Add support for URLs to mw.loader.using - https://phabricator.wikimedia.org/T27962 (10Evad37) Update: Per discussion on gerrit, the latest patch sets add a new mw.loader.usingScript(), rather than adding functionality for a separate use case... [02:30:13] (03PS13) 10Krinkle: resourceloader: Add getScript() method for loading scripts with callback [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [02:33:02] (03CR) 10Krinkle: "Made a few changes:" [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [02:36:29] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Add getScript() method for loading scripts with callback [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [02:38:54] (03CR) 10Krinkle: resourceloader: Add getScript() method for loading scripts with callback (035 comments) [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [02:42:34] (03PS14) 10Krinkle: resourceloader: Add getScript() method for loading scripts with callback [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [02:54:49] (03CR) 10tosfos: "recheck" [extensions/CollapsibleSections] - 10https://gerrit.wikimedia.org/r/492394 (owner: 10tosfos) [03:43:03] (03PS4) 10Mholloway: Add support for storing and serving task suggestions [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/492337 [03:45:04] (03PS5) 10Mholloway: Add support for storing and serving task suggestions [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/492337 [03:55:15] 10MediaWiki-General-or-Unknown: Error message for trying to move a page to an illegal title displays twice - https://phabricator.wikimedia.org/T216899 (10Pppery) [03:57:23] 10MediaWiki-General-or-Unknown: Error message for trying to move a page to an illegal title displays twice - https://phabricator.wikimedia.org/T216899 (10Pppery) Strangely, this doesn't trigger when moving a page to a title that is just protected against creation. [03:58:16] 10MediaWiki-General-or-Unknown: Error message for trying to move a page to an illegal title displays twice - https://phabricator.wikimedia.org/T216899 (10Pppery) [04:15:04] 10MediaWiki-ContentHandler, 10MediaWiki-Special-pages: Message when moving pages in content models that don't support redirects is wrong. - https://phabricator.wikimedia.org/T216900 (10Pppery) [04:15:29] 10MediaWiki-ContentHandler, 10MediaWiki-Special-pages: Message when moving pages in content models that don't support redirects is wrong. - https://phabricator.wikimedia.org/T216900 (10Pppery) [04:16:00] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Error message for trying to move a page to an illegal title displays twice - https://phabricator.wikimedia.org/T216899 (10Pppery) [04:25:48] (03CR) 10Legoktm: Ensure $IP is an absolute path for compatibility with newer Phan (031 comment) [tools/phan] - 10https://gerrit.wikimedia.org/r/485244 (owner: 10Legoktm) [04:25:52] (03PS2) 10Legoktm: Don't start paths with "./" [tools/phan] - 10https://gerrit.wikimedia.org/r/485244 [04:25:54] (03PS1) 10Legoktm: Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 [04:25:57] (03CR) 10jerkins-bot: [V: 04-1] Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:26:26] (03PS3) 10Legoktm: Don't start paths with "./" [tools/phan] - 10https://gerrit.wikimedia.org/r/485244 [04:26:28] (03PS2) 10Legoktm: Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 [04:26:32] (03CR) 10jerkins-bot: [V: 04-1] Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:41:09] (03CR) 10Legoktm: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:41:15] (03CR) 10jerkins-bot: [V: 04-1] Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:42:43] (03CR) 10Legoktm: [C: 03+2] "self-merging so I can release a new version for new phan." [tools/phan] - 10https://gerrit.wikimedia.org/r/485244 (owner: 10Legoktm) [04:43:39] (03Merged) 10jenkins-bot: Don't start paths with "./" [tools/phan] - 10https://gerrit.wikimedia.org/r/485244 (owner: 10Legoktm) [04:44:40] (03Abandoned) 10Legoktm: Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:44:42] (03Restored) 10Legoktm: Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:44:47] (03CR) 10Legoktm: "recheck" [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:46:00] (03CR) 10Legoktm: [C: 03+2] "One more self-merge to release a new version for new phan..." [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:46:29] (03Merged) 10jenkins-bot: Add phan version to composer.json [tools/phan] - 10https://gerrit.wikimedia.org/r/492521 (owner: 10Legoktm) [04:47:27] (03PS1) 10Legoktm: Release 0.4.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/492522 [04:47:38] (03CR) 10Legoktm: [C: 03+2] Release 0.4.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/492522 (owner: 10Legoktm) [04:48:06] (03Merged) 10jenkins-bot: Release 0.4.0 [tools/phan] - 10https://gerrit.wikimedia.org/r/492522 (owner: 10Legoktm) [04:58:34] (03PS1) 10Legoktm: [WIP] Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 [05:01:24] slight possibility CI/phan will break, stay tuned [05:03:39] (03PS2) 10Legoktm: [WIP] Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 [05:05:54] (03PS3) 10Legoktm: Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 [05:06:11] (03PS1) 10Legoktm: [DNM] jenkins testing [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492525 [05:08:58] (03CR) 10jerkins-bot: [V: 04-1] [DNM] jenkins testing [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492525 (owner: 10Legoktm) [05:11:39] (03PS1) 10Mholloway: Add maintenance script to populate entity_description_exists table [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/492526 [05:12:38] 10MediaWiki-extensions-General: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Legoktm) [05:16:07] 10MediaWiki-extensions-General: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Legoktm) [05:24:18] 10MediaWiki-ContentHandler, 10MediaWiki-Redirects, 10MediaWiki-Special-pages: Message when moving pages in content models that don't support redirects is wrong. - https://phabricator.wikimedia.org/T216900 (10Pppery) [05:29:51] (03PS1) 10Legoktm: Fix caching in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492527 [05:29:53] (03PS1) 10Legoktm: Fix parameter order in doc comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492528 [05:29:55] (03PS1) 10Legoktm: Add missing use statement [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492529 [05:29:57] (03PS1) 10Legoktm: [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 [05:35:29] (03Abandoned) 10Legoktm: [DNM] jenkins testing [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492525 (owner: 10Legoktm) [05:36:26] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Manvigupta7) Hi @srishakatux. I a... [05:41:15] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (owner: 10Legoktm) [05:44:46] (03PS1) 10Legoktm: Migrate to new phan [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492531 [05:46:40] 10MediaWiki-extensions-General: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Legoktm) [05:52:09] (03PS27) 10Mholloway: Add API meta module ApiQueryWikimediaEditorTasks [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/487603 [05:52:11] (03PS9) 10Mholloway: Add counter for in-app description edits [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490903 [05:52:13] (03PS10) 10Mholloway: Implement counter delays [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490922 [05:54:08] (03CR) 10jerkins-bot: [V: 04-1] Implement counter delays [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490922 (owner: 10Mholloway) [05:54:33] (03CR) 10jerkins-bot: [V: 04-1] Add API meta module ApiQueryWikimediaEditorTasks [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/487603 (owner: 10Mholloway) [05:55:21] (03CR) 10Mholloway: "A few minor substantive changes here:" [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/487603 (owner: 10Mholloway) [05:55:23] (03CR) 10jerkins-bot: [V: 04-1] Add counter for in-app description edits [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490903 (owner: 10Mholloway) [05:58:10] (03PS11) 10Mholloway: Implement counter delays [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490922 [06:04:56] (03PS28) 10Mholloway: Add API meta module ApiQueryWikimediaEditorTasks [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/487603 [06:04:58] (03PS10) 10Mholloway: Add counter for in-app description edits [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490903 [06:05:00] (03PS12) 10Mholloway: Implement counter delays [extensions/WikimediaEditorTasks] - 10https://gerrit.wikimedia.org/r/490922 [06:25:37] 10MediaWiki-extensions-General, 10good first bug: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Zoranzoki21) I think to this can be tagged with #good_first_bug because should be easy [06:27:58] (03PS1) 10Sau226: Replace mitchellh with hashicorp [vagrant] - 10https://gerrit.wikimedia.org/r/492532 [06:33:38] 10MediaWiki-ContentHandler, 10MediaWiki-Redirects, 10MediaWiki-Special-pages: Message when moving pages in content models that don't support redirects is wrong. - https://phabricator.wikimedia.org/T216900 (10DannyS712) Another type is pages with the content model "MassMessageListContent". [06:35:08] (03PS2) 10Sau226: Replace mitchellh with hashicorp [vagrant] - 10https://gerrit.wikimedia.org/r/492532 [06:36:11] (03PS1) 10Zoranzoki21: Migrate to newer phan [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216901) [06:37:51] (03PS2) 10Zoranzoki21: Migrate to newer phan [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216901) [06:53:28] (03PS2) 10Legoktm: Migrate to new phan [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492531 [06:53:54] (03PS4) 10Legoktm: Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 [06:54:12] (03PS2) 10Legoktm: [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 [06:56:57] 10MediaWiki-extensions-General, 10Patch-For-Review, 10good first bug: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Zoranzoki21) @Legoktm I think you should include this bug in commit messages of your patches? [07:03:10] 10WMSE-Riksarkivet-TORA: RAÄ Fornreg WGS84 i URL --> visa den delen - https://phabricator.wikimedia.org/T214401 (10Salgo60) [07:04:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (owner: 10Legoktm) [07:13:34] 10MediaWiki-extensions-General, 10Patch-For-Review, 10good first bug: Migrate extensions and skins to phan 1.2.4 - https://phabricator.wikimedia.org/T216901 (10Legoktm) 05Open→03Invalid I'm actually going to file individual bugs for each repo to make this easier to keep track of. >>! In T216901#4978625,... [07:19:02] (03CR) 10MaxSem: [C: 03+2] Add missing use statement [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492529 (owner: 10Legoktm) [07:19:21] (03CR) 10MaxSem: [C: 03+2] Fix parameter order in doc comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492528 (owner: 10Legoktm) [07:21:35] 10Wikimedia-SVG-rendering: Santali font issues in SVG rendering - https://phabricator.wikimedia.org/T216892 (10ASHWANI) {F28272930} While translating an image in inkspace app the words used were clearly visible but after uploading the picture in commons the words are not recognisable ,it appears as above. Wherea... [07:22:48] 10MediaWiki-Core-Testing, 103D, 10Multimedia: Upgrade 3D extension to use newer phan - https://phabricator.wikimedia.org/T216903 (10Legoktm) [07:22:50] 10MediaWiki-Core-Testing, 10AbuseFilter: Upgrade AbuseFilter extension to use newer phan - https://phabricator.wikimedia.org/T216904 (10Legoktm) [07:22:53] 10MediaWiki-Core-Testing, 10DynamicPageList (third-party): Upgrade ArticleCreationWorkflow extension to use newer phan - https://phabricator.wikimedia.org/T216906 (10Legoktm) [07:22:55] 10MediaWiki-Core-Testing, 10AntiSpoof: Upgrade AntiSpoof extension to use newer phan - https://phabricator.wikimedia.org/T216905 (10Legoktm) [07:22:58] 10MediaWiki-Core-Testing, 10Language-Team: Upgrade Babel extension to use newer phan - https://phabricator.wikimedia.org/T216907 (10Legoktm) [07:22:59] 10MediaWiki-Core-Testing, 10MediaWiki-extensions-CategoryTree: Upgrade CategoryTree extension to use newer phan - https://phabricator.wikimedia.org/T216908 (10Legoktm) [07:23:01] 10MediaWiki-Core-Testing, 10DynamicPageList (third-party): Upgrade CentralLogging extension to use newer phan - https://phabricator.wikimedia.org/T216909 (10Legoktm) [07:23:03] 10MediaWiki-Core-Testing, 10CirrusSearch, 10Discovery-Search: Upgrade CirrusSearch extension to use newer phan - https://phabricator.wikimedia.org/T216910 (10Legoktm) [07:23:06] well crap [07:23:33] phab search is a disaster. [07:24:33] 10AbuseFilter, 10phan: Upgrade AbuseFilter extension to use newer phan - https://phabricator.wikimedia.org/T216904 (10Legoktm) [07:24:41] 10MediaWiki-Core-Testing, 10MediaWiki-extensions-ArticleCreationWorkflow: Upgrade ArticleCreationWorkflow extension to use newer phan - https://phabricator.wikimedia.org/T216906 (10Legoktm) [07:24:52] 10MediaWiki-extensions-ArticleCreationWorkflow, 10phan: Upgrade ArticleCreationWorkflow extension to use newer phan - https://phabricator.wikimedia.org/T216906 (10Legoktm) [07:24:57] 10AntiSpoof, 10phan: Upgrade AntiSpoof extension to use newer phan - https://phabricator.wikimedia.org/T216905 (10Legoktm) [07:25:23] 10MediaWiki-extensions-Babel, 10phan: Upgrade Babel extension to use newer phan - https://phabricator.wikimedia.org/T216907 (10Legoktm) [07:25:37] 10MediaWiki-extensions-CategoryTree, 10phan: Upgrade CategoryTree extension to use newer phan - https://phabricator.wikimedia.org/T216908 (10Legoktm) [07:25:59] 10MediaWiki-extensions-Other, 10phan: Upgrade CentralLogging extension to use newer phan - https://phabricator.wikimedia.org/T216909 (10Legoktm) [07:26:10] 10CirrusSearch, 10Discovery-Search, 10phan: Upgrade CirrusSearch extension to use newer phan - https://phabricator.wikimedia.org/T216910 (10Legoktm) [07:29:09] 10MediaWiki-extensions-Other, 10phan: Upgrade EUCopyrightCampaign extension to use newer phan - https://phabricator.wikimedia.org/T216915 (10Legoktm) [07:29:11] 10MediaWiki-extensions-Other, 10phan: Upgrade ElectronPdfService extension to use newer phan - https://phabricator.wikimedia.org/T216916 (10Legoktm) [07:29:14] 10MediaWiki-extensions-Other, 10phan: Upgrade FileExporter extension to use newer phan - https://phabricator.wikimedia.org/T216917 (10Legoktm) [07:29:16] 10MediaWiki-extensions-Other, 10phan: Upgrade FileImporter extension to use newer phan - https://phabricator.wikimedia.org/T216918 (10Legoktm) [07:29:18] 10Discovery-Search, 10GeoData, 10phan: Upgrade GeoData extension to use newer phan - https://phabricator.wikimedia.org/T216920 (10Legoktm) [07:29:20] 10Gadgets, 10phan: Upgrade Gadgets extension to use newer phan - https://phabricator.wikimedia.org/T216919 (10Legoktm) [07:29:22] 10ImageMap, 10phan: Upgrade ImageMap extension to use newer phan - https://phabricator.wikimedia.org/T216921 (10Legoktm) [07:29:24] 10MediaWiki-extensions-InputBox, 10phan: Upgrade InputBox extension to use newer phan - https://phabricator.wikimedia.org/T216922 (10Legoktm) [07:29:26] 10MediaWiki-extensions-Interwiki, 10phan: Upgrade Interwiki extension to use newer phan - https://phabricator.wikimedia.org/T216923 (10Legoktm) [07:29:28] 10MediaWiki-extensions-InterwikiSorting, 10phan: Upgrade InterwikiSorting extension to use newer phan - https://phabricator.wikimedia.org/T216924 (10Legoktm) [07:29:30] 10MediaWiki-extensions-LocalisationUpdate, 10phan: Upgrade LocalisationUpdate extension to use newer phan - https://phabricator.wikimedia.org/T216925 (10Legoktm) [07:29:32] 10MassMessage, 10phan: Upgrade MassMessage extension to use newer phan - https://phabricator.wikimedia.org/T216927 (10Legoktm) [07:29:34] 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10phan: Upgrade LoginNotify extension to use newer phan - https://phabricator.wikimedia.org/T216926 (10Legoktm) [07:29:36] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10phan: Upgrade MultimediaViewer extension to use newer phan - https://phabricator.wikimedia.org/T216928 (10Legoktm) [07:29:40] 10MediaWiki-extensions-Nuke, 10phan: Upgrade Nuke extension to use newer phan - https://phabricator.wikimedia.org/T216929 (10Legoktm) [07:29:41] 10MediaWiki-extensions-Other, 10phan: Upgrade NukeDPL extension to use newer phan - https://phabricator.wikimedia.org/T216930 (10Legoktm) [07:29:44] 10MediaWiki-extensions-OATHAuth, 10phan: Upgrade OATHAuth extension to use newer phan - https://phabricator.wikimedia.org/T216931 (10Legoktm) [07:29:45] 10MediaWiki-extensions-Other, 10phan: Upgrade PageTriage extension to use newer phan - https://phabricator.wikimedia.org/T216932 (10Legoktm) [07:29:48] 10MediaWiki-extensions-ParserFunctions, 10phan: Upgrade ParserFunctions extension to use newer phan - https://phabricator.wikimedia.org/T216933 (10Legoktm) [07:29:50] 10MediaWiki-extensions-Other, 10phan: Upgrade ParserMigration extension to use newer phan - https://phabricator.wikimedia.org/T216934 (10Legoktm) [07:29:53] 10MediaWiki-extensions-PdfHandler, 10phan: Upgrade PdfHandler extension to use newer phan - https://phabricator.wikimedia.org/T216935 (10Legoktm) [07:29:54] 10MediaWiki-extensions-Poem, 10phan: Upgrade Poem extension to use newer phan - https://phabricator.wikimedia.org/T216936 (10Legoktm) [07:29:56] 10MediaWiki-extensions-Renameuser, 10phan: Upgrade Renameuser extension to use newer phan - https://phabricator.wikimedia.org/T216937 (10Legoktm) [07:29:58] 10MediaWiki-extensions-ReplaceText, 10phan: Upgrade ReplaceText extension to use newer phan - https://phabricator.wikimedia.org/T216938 (10Legoktm) [07:30:00] 10MediaWiki-extensions-Other, 10phan: Upgrade RevisionSlider extension to use newer phan - https://phabricator.wikimedia.org/T216939 (10Legoktm) [07:30:02] 10MediaWiki-extensions-SecurePoll, 10phan: Upgrade SecurePoll extension to use newer phan - https://phabricator.wikimedia.org/T216941 (10Legoktm) [07:30:04] 10MediaWiki-extensions-Scribunto, 10phan: Upgrade Scribunto extension to use newer phan - https://phabricator.wikimedia.org/T216940 (10Legoktm) [07:30:06] 10SpamBlacklist, 10phan: Upgrade SpamBlacklist extension to use newer phan - https://phabricator.wikimedia.org/T216942 (10Legoktm) [07:30:09] 10MediaWiki-extensions-StopForumSpam, 10phan: Upgrade StopForumSpam extension to use newer phan - https://phabricator.wikimedia.org/T216943 (10Legoktm) [07:30:11] 10MediaWiki-extensions-Other, 10phan: Upgrade SyntaxHighlight_GeSHi extension to use newer phan - https://phabricator.wikimedia.org/T216944 (10Legoktm) [07:30:14] 10TitleBlacklist, 10phan: Upgrade TitleBlacklist extension to use newer phan - https://phabricator.wikimedia.org/T216946 (10Legoktm) [07:30:16] 10MediaWiki-extensions-TorBlock, 10phan: Upgrade TorBlock extension to use newer phan - https://phabricator.wikimedia.org/T216947 (10Legoktm) [07:30:32] 10MediaWiki-extensions-Other, 10phan: Upgrade TwoColConflict extension to use newer phan - https://phabricator.wikimedia.org/T216948 (10Legoktm) [07:30:34] 10MediaWiki-extensions-UserMerge, 10phan: Upgrade UserMerge extension to use newer phan - https://phabricator.wikimedia.org/T216949 (10Legoktm) [07:30:36] 10MediaWiki-extensions-Variables, 10phan: Upgrade Variables extension to use newer phan - https://phabricator.wikimedia.org/T216950 (10Legoktm) [07:30:46] 10fixcopyright.wikimedia.org, 10phan: Upgrade EUCopyrightCampaign extension to use newer phan - https://phabricator.wikimedia.org/T216915 (10Legoktm) [07:30:53] 10Electron-PDFs, 10phan: Upgrade ElectronPdfService extension to use newer phan - https://phabricator.wikimedia.org/T216916 (10Legoktm) [07:31:57] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10phan: Upgrade PageTriage extension to use newer phan - https://phabricator.wikimedia.org/T216932 (10Legoktm) [07:32:14] 10SyntaxHighlight, 10phan: Upgrade SyntaxHighlight_GeSHi extension to use newer phan - https://phabricator.wikimedia.org/T216944 (10Legoktm) [07:34:34] (03PS3) 10Legoktm: Migrate to newer phan [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216903) (owner: 10Zoranzoki21) [07:41:47] (03PS4) 10Legoktm: Migrate to newer phan [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216903) (owner: 10Zoranzoki21) [07:42:10] (03CR) 10Legoktm: [C: 03+2] "Nice work" [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216903) (owner: 10Zoranzoki21) [07:42:36] (03PS3) 10Legoktm: [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) [07:42:50] (03PS3) 10Legoktm: Migrate to new phan [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492531 (https://phabricator.wikimedia.org/T216927) [07:43:01] (03PS5) 10Legoktm: Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 (https://phabricator.wikimedia.org/T216934) [07:46:44] (03Merged) 10jenkins-bot: Migrate to newer phan [extensions/3D] - 10https://gerrit.wikimedia.org/r/492533 (https://phabricator.wikimedia.org/T216903) (owner: 10Zoranzoki21) [07:50:40] 10WMSE-Riksarkivet-TORA: Nobel data for 2017 is missing - https://phabricator.wikimedia.org/T202034 (10Salgo60) 2019 feb 24: Looks like the linked data at is not well maintained Query: [[ http://tinyurl.com/yab3t5v2 | Map ]] Peace prizewinner 2011 http://data.nobelprize.org/page/laureate/870 {F28273059,widt... [07:51:35] Could Jenkins-bot be prodded to run on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/492474 [07:52:24] For some weird reason it doesn't seem to do so automatically like other patches [07:52:57] 10MediaWiki-Cache, 10Operations, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, and 3 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10elukey) I missed the fact that the last patch mer... [07:56:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Migrate to new phan [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [08:02:45] (03PS1) 10Legoktm: Fix JS exception when adding a new target on non-crosswiki wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492535 [08:07:03] (03CR) 10Legoktm: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492474 (https://phabricator.wikimedia.org/T207847) (owner: 10FR30799386) [08:08:11] (03PS15) 10Evad37: resourceloader: Add getScript() method for loading scripts with callback [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) [08:08:57] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10phan: Upgrade ParserMigration extension to use newer phan - https://phabricator.wikimedia.org/T216934 (10Legoktm) a:03Legoktm [08:09:01] 10MassMessage, 10Patch-For-Review, 10phan: Upgrade MassMessage extension to use newer phan - https://phabricator.wikimedia.org/T216927 (10Legoktm) a:03Legoktm [08:25:17] 10MediaWiki-extensions-LiquidThreads: LQT: Keep talk refactoring possible - https://phabricator.wikimedia.org/T31711 (10Nemo_bis) p:05Lowest→03Normal [08:29:45] 10AbuseFilter, 10Patch-For-Review, 10phan: Upgrade AbuseFilter extension to use newer phan - https://phabricator.wikimedia.org/T216904 (10Daimona) Yes please! I tried this version of phan (or a similar one) on CodeClimate some time ago and it rocks! [08:33:23] 10MediaWiki-extensions-LiquidThreads: Special:NewMessages is incorrectly showing log-in only data - https://phabricator.wikimedia.org/T42089 (10Nemo_bis) p:05Lowest→03High [08:33:32] (03CR) 10Daimona Eaytoy: "I spotted this via CodeClimate and fixed it in I5f4603627c61cf1b93859fe6bcd952eac8e82359 together with another couple of fixes a few month" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492527 (owner: 10Legoktm) [08:34:48] 10MediaWiki-extensions-LiquidThreads: Categories should list threads, not summaries - https://phabricator.wikimedia.org/T40352 (10Nemo_bis) [08:36:10] 10MediaWiki-extensions-LiquidThreads: LQT: "Mark as read" should not lose list position - https://phabricator.wikimedia.org/T28891 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:36:47] 10MediaWiki-extensions-LiquidThreads: Per-page configurable date-based thread limit - https://phabricator.wikimedia.org/T27054 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:37:05] 10MediaWiki-extensions-LiquidThreads: Protecting LiquidThreads talk pages - https://phabricator.wikimedia.org/T26814 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:37:25] (03CR) 10Daimona Eaytoy: [C: 04-1] "In case the 2 false positives haven't been fixed upstream, there's I49ec6a1264b767cefea55df66ef3b02d4f443b57." (034 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [08:37:39] 10MediaWiki-extensions-LiquidThreads: Same category shown multiple times at talk page bottom - https://phabricator.wikimedia.org/T26110 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:38:01] 10MediaWiki-extensions-LiquidThreads: Allow users to set LiquidThreads thread paging limit with preferences or view options - https://phabricator.wikimedia.org/T23690 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:38:18] 10MediaWiki-extensions-LiquidThreads: No way to do RC patrolling (no "mark as patrolled" link on thread replies) - https://phabricator.wikimedia.org/T40804 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:38:40] 10Design, 10MediaWiki-extensions-LiquidThreads: Repeat "Mark as read" at end of each thread on Special:NewMessages - https://phabricator.wikimedia.org/T28831 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:39:02] 10MediaWiki-extensions-LiquidThreads: Add parameters preloadtitle, editintro and preloadsummary to LiquidThreads - https://phabricator.wikimedia.org/T27441 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:40:30] 10Accessibility, 10MediaWiki-extensions-LiquidThreads: Tabbing from LQT editor's summary/textarea fields should not go to the search box in Vector skin - https://phabricator.wikimedia.org/T48336 (10Nemo_bis) p:05Lowest→03High Restore information removed with now-invalid rationale; also increase priority du... [08:40:41] 10MediaWiki-extensions-LiquidThreads: Add a $wg variable to disable signature editing on new post/reply/etc. - https://phabricator.wikimedia.org/T26135 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:41:04] 10MediaWiki-extensions-LiquidThreads, 10Performance: Out of memory error in LiquidThreads when viewing some LQT talk pages - https://phabricator.wikimedia.org/T30025 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:41:11] 10MediaWiki-extensions-LiquidThreads: Specifying oldid breaks display of threads copying the oldid's message over all the others - https://phabricator.wikimedia.org/T38978 (10Nemo_bis) p:05Lowest→03Normal Restore information removed with now-invalid rationale. [08:47:08] (03CR) 10MaxSem: [C: 03+2] Fix caching in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492527 (owner: 10Legoktm) [08:53:19] (03CR) 10Fomafix: resourceloader: Add getScript() method for loading scripts with callback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [09:06:23] (03CR) 10Daimona Eaytoy: [C: 04-1] "I can try to fix these errors today, although either I don't understand it, or some of them seem to be false positives. See for instance t" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [09:08:46] (03Merged) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492527 (owner: 10Legoktm) [09:08:48] (03Merged) 10jenkins-bot: Fix parameter order in doc comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492528 (owner: 10Legoktm) [09:08:50] (03Merged) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492529 (owner: 10Legoktm) [09:13:17] (03CR) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492527 (owner: 10Legoktm) [09:14:17] (03PS4) 10Daimona Eaytoy: Reduce the amount of returns [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/474702 [09:14:29] (03CR) 10Thiemo Kreuz (WMDE): "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/491489 (owner: 10Thiemo Kreuz (WMDE)) [09:15:10] 10WMSE-Riksarkivet-TORA: Connect WD Churches and church documentation at RAÄ/LIBRIS - https://phabricator.wikimedia.org/T215603 (10Salgo60) [09:19:39] (03CR) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492529 (owner: 10Legoktm) [09:24:13] (03CR) 10jenkins-bot: Fix parameter order in doc comment [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492528 (owner: 10Legoktm) [09:24:19] (03CR) 10jerkins-bot: [V: 04-1] Reduce the amount of returns [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/474702 (owner: 10Daimona Eaytoy) [09:32:34] (03PS1) 10Fomafix: Avoid new global window.mwTestFooJsCounter in qunit tests [core] - 10https://gerrit.wikimedia.org/r/492536 [09:38:13] (03PS1) 10Thiemo Kreuz (WMDE): Mark public methods with the "public" keyword [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/492537 [09:44:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Community-consensus-needed, 10Need-volunteer, 10good first bug: Add monolingual language code tlb - https://phabricator.wikimedia.org/T216798 (10GerardM) No problem having a monolingual code for tlb Tobelo https://www.ethnologue.com/15/show_languag... [09:52:18] Could somebody prod Jenkins-bot on this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/492452 [10:10:29] 10WikiApiary: Wikiapiary: Database server down - https://phabricator.wikimedia.org/T216349 (10Tgr) Dumped the data in recovery level 3 using `sudo mysqldump --add-drop-database --create-options --single-transaction --databases ...` (single transaction is needed to avoid an `1449: "The user specified as a definer... [10:11:01] 10WMSE-Riksarkivet-TORA: SWEPUB Sparql Wikidata - https://phabricator.wikimedia.org/T216820 (10Salgo60) @Abbe98 ok do you have a link stating CC-0 of the meta data? I guess that is what we need... to start the process of setting up a SPARQL federation in WIkidata ===Todo list as I see it [] get a page stating... [10:33:06] (03CR) 10Evad37: "I think attaching to the existing global `mw` rather than the window object should fix it" [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [10:36:41] (03PS16) 10Evad37: resourceloader: Add getScript() method for loading scripts with callback [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) [10:42:34] 10WikiApiary: Wikiapiary: Database server down - https://phabricator.wikimedia.org/T216349 (10Ciencia_Al_Poder) I've done some edits and it seems to work fine. Many thanks! I've found a little glitch, however, and I'm not sure if it's something related to the outage. [[https://wikiapiary.com/wiki/San_Andreas_Mu... [11:09:28] 10Hashtags: Run a one-off task to retrieve edits between August and September 2018 - https://phabricator.wikimedia.org/T216610 (10AdityaJ) > We could do a one-off task to retrieve data from the revision table for this period of time @Samwalton9 Could you please tell me what is 'revision table'? If I am not wron... [11:30:57] (03CR) 10MarcoAurelio: [C: 03+2] Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 (https://phabricator.wikimedia.org/T216934) (owner: 10Legoktm) [11:32:48] Could anybody prod jenkins-bot to run on this patch https://gerrit.wikimedia.org/r/c/mediawiki/extensions/PageTriage/+/492452 [11:33:50] (03Merged) 10jenkins-bot: Migrate to newer phan [extensions/ParserMigration] - 10https://gerrit.wikimedia.org/r/492523 (https://phabricator.wikimedia.org/T216934) (owner: 10Legoktm) [11:34:34] (03CR) 10Daimona Eaytoy: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/474702 (owner: 10Daimona Eaytoy) [11:37:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10good first bug: Add monolingual language code tlb - https://phabricator.wikimedia.org/T216798 (10Mbch331) a:03Mbch331 [11:42:22] FR30799386|activ: sure, just a sec [11:42:54] (03CR) 10Shreyasminocha: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/492452 (https://phabricator.wikimedia.org/T158513) (owner: 10FR30799386) [11:47:43] FR30799386|activ: looks like it was verified :) [11:50:21] 10MediaWiki-extensions-Other, 10phan: Upgrade ParserMigration extension to use newer phan - https://phabricator.wikimedia.org/T216934 (10MarcoAurelio) 05Open→03Resolved [11:53:24] :) [11:56:30] BTW, how long does it take to get a code review ? [11:56:42] Like is 24 hours normal ? [12:03:25] it depends on who/how-many reviewers the project has, but yeah 24 hours is normal [12:04:06] as you might be aware, many people who work on WM projects are just volunteers rather than full-time employees [12:05:58] I didn't mean it in that way...... [12:07:29] neither did i :) sorry if it came off that way [12:08:34] :) [12:26:03] (03CR) 10Ebrahim: "Thank you @Jforrester" [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [12:35:36] 10Editing QA, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review, 10VisualEditor (Current work): Create a read-only mode for Visual Editor that allows inspection - https://phabricator.wikimedia.org/T210142 (10Esanders) For testing, you can enter this in to the console: `ve.init.target.surface.... [13:09:32] 10Wikimedia-SVG-rendering: Santali font issues in SVG rendering - https://phabricator.wikimedia.org/T216892 (10Aklapper) For future reference, please provide 1) steps to reproduce including links; 2) expected outcome; 3) actual outcome, when reporting problems - thanks! The SVG file itself at https://upload.wik... [13:10:24] 10Wikimedia-SVG-rendering: Santali font shown as square boxes in thumbnail version of a specific SVG file - https://phabricator.wikimedia.org/T216892 (10Aklapper) [13:25:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Replaced rawParams() with plaintextParams() (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492437 (https://phabricator.wikimedia.org/T216390) (owner: 10Naga sai sravanth) [13:29:52] (03Merged) 10jenkins-bot: Replaced rawParams() with plaintextParams() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492437 (https://phabricator.wikimedia.org/T216390) (owner: 10Naga sai sravanth) [13:31:35] (03CR) 10jenkins-bot: Replaced rawParams() with plaintextParams() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492437 (https://phabricator.wikimedia.org/T216390) (owner: 10Naga sai sravanth) [13:55:26] 10MediaWiki-Logging, 10MediaWiki-Page-protection: Page protection log shows the main page of the Finnish-language Wikinews as nonexistent - https://phabricator.wikimedia.org/T215504 (10Ejs-80) The link to the Wikiuutiset:Etusivu (aka the main page) appears as red also in the deletion log if you select ”Page un... [13:55:41] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10Mini-MWT at VVIT (Feb 2019): [Extension:GrowthExperiments] Use plaintextParams() instead of rawParams() - https://phabricator.wikimedia.org/T216363 (10Jayprakash12345) 05Open→03Resolved https://gerrit.wikimedia.org/r/#/c/492437/ [13:55:46] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Security, 10good first bug: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213 (10Jayprakash12345) [13:57:43] 10MediaWiki-Database, 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10wikidata-tech-focus: Wikibase does not support database table prefix - https://phabricator.wikimedia.org/T206966 (10lucamauri) I just setup my own Wikibase installation using two instance... [13:59:19] 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Security, 10good first bug: [Clonable] replace wfMessage()->rawParams() with wfMessage()->plaintextParams() where applicable - https://phabricator.wikimedia.org/T182213 (10Jayprakash12345) [13:59:23] 10TitleBlacklist, 10Mini-MWT at VVIT (Feb 2019), 10good first bug: [Extension:TitleBlacklist] Use plaintextParams directly instead of using rawParams() - https://phabricator.wikimedia.org/T216360 (10Jayprakash12345) 05Open→03Resolved a:03Setian [14:01:33] 10MediaWiki-extensions-HostStats, 10Mini-MWT at VVIT (Feb 2019): [Extension:HostStats] Remove the usage of global variable $wgUser, $wgOut - https://phabricator.wikimedia.org/T216395 (10Jayprakash12345) 05Open→03Resolved [14:02:37] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Mini-MWT at VVIT (Feb 2019): [Extension:GrowthExperiments] Use plaintextParams() instead of rawParams() - https://phabricator.wikimedia.org/T216363 (10Jayprakash12345) [14:02:39] (03PS2) 10D3r1ck01: languages: Deprecate Language::getExtraUserToggles() [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) [14:02:50] 10MediaWiki-extensions-Other, 10Mini-MWT at VVIT (Feb 2019), 10Patch-For-Review: [Extension:LastUserLogin] Remove the usage of global variable $wgUser, $wgRequest, $wgOut, $wgLang - https://phabricator.wikimedia.org/T216390 (10Jayprakash12345) [14:05:56] (03PS3) 10D3r1ck01: languages: Hard deprecate Language::getExtraUserToggles() method [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) [14:07:19] (03CR) 10D3r1ck01: "Thanks @Krinkle, done!" [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) (owner: 10D3r1ck01) [14:14:04] (03CR) 10D3r1ck01: [C: 03+2] "LGTM! Thanks :)" (031 comment) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/492537 (owner: 10Thiemo Kreuz (WMDE)) [14:18:21] (03Merged) 10jenkins-bot: Mark public methods with the "public" keyword [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/492537 (owner: 10Thiemo Kreuz (WMDE)) [14:40:30] (03CR) 10Krinkle: languages: Hard deprecate Language::getExtraUserToggles() method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) (owner: 10D3r1ck01) [14:48:28] (03PS4) 10D3r1ck01: languages: Hard deprecate Language::getExtraUserToggles() method [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) [14:48:34] (03CR) 10D3r1ck01: "Thanks for the extra feedback. Done!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/492487 (https://phabricator.wikimedia.org/T62260) (owner: 10D3r1ck01) [14:56:16] (03PS1) 10Daimona Eaytoy: Add new method: AbuseFilterVariableHolder::newFromArray [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492543 [14:57:40] (03PS11) 10Daimona Eaytoy: Save profiling data and vars in cache when running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487163 [15:00:10] (03PS1) 10Paladox: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 [15:01:17] (03PS1) 10Paladox: Add missing use statement [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 [15:01:59] (03CR) 10Daimona Eaytoy: [C: 03+2] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 (owner: 10Paladox) [15:02:16] (03CR) 10Daimona Eaytoy: [C: 03+2] Add missing use statement [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 (owner: 10Paladox) [15:06:28] (03PS5) 10Daimona Eaytoy: Slightly improve the form for suppressing AbuseLog entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486058 [15:06:34] (03PS17) 10Daimona Eaytoy: Overhaul the interface for hiding AbuseLog entries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/467774 (https://phabricator.wikimedia.org/T144096) [15:06:54] (03CR) 10Paladox: "@Daimona Eaytoy this will need force merging (tests failing with unrelated errors)" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 (owner: 10Paladox) [15:07:05] (03CR) 10Paladox: "@Daimona Eaytoy this will need force merging (tests failing with unrelated errors)" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 (owner: 10Paladox) [15:07:07] (03CR) 10jerkins-bot: [V: 04-1] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 (owner: 10Paladox) [15:08:19] (03CR) 10jerkins-bot: [V: 04-1] Add missing use statement [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 (owner: 10Paladox) [15:08:40] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "> @Daimona Eaytoy this will need force merging (tests failing with" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 (owner: 10Paladox) [15:09:18] (03CR) 10Daimona Eaytoy: [V: 03+2 C: 03+2] "T189560" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 (owner: 10Paladox) [15:09:45] 10Mathe für Nicht-Freaks: Abschnitt "Wurzel komplexer Zahlen" - https://phabricator.wikimedia.org/T210185 (10Kulla) a:05LeRubikscube→03None [15:10:05] 10Mathe für Nicht-Freaks: Abschnitt "Exponentielle Polardarstellung" - https://phabricator.wikimedia.org/T210184 (10Kulla) [15:11:04] 10MediaWiki-General-or-Unknown: wikimedia/equivset missing from mw 1.32 - https://phabricator.wikimedia.org/T216954 (10Paladox) [15:12:48] (03CR) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492544 (owner: 10Paladox) [15:14:52] (03PS10) 10Daimona Eaytoy: Rearrange config to provide better experience [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/468696 (https://phabricator.wikimedia.org/T191740) [15:15:23] (03CR) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/492545 (owner: 10Paladox) [15:17:11] 10MediaWiki-General-or-Unknown: wikimedia/equivset missing from mw 1.32 - https://phabricator.wikimedia.org/T216954 (10Daimona) [15:17:31] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Krinkle) The page link is indeed red and represents the title at the time. But, does the "diff" link work? [15:28:36] (03CR) 10Daimona Eaytoy: [C: 04-1] "> I can try to fix these errors today, although either I don't" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/492530 (https://phabricator.wikimedia.org/T216904) (owner: 10Legoktm) [15:38:33] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team, 10Shape Expressions, 10Wikidata: [Story] Add newly created Schemas to user’s watchlist according to setting - https://phabricator.wikimedia.org/T213725 (10Lydia_Pintscher) [15:51:24] 04(no projects): Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10matej_suchanek) [15:52:21] 10MediaWiki-Search, 10Discovery-Search, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10matej_suchanek) [15:57:53] 10MediaWiki-Search, 10Discovery-Search, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10Daimona) As can be easily understood by "WMFTimeoutException", this happens upon reaching the timeout of 60 seconds. No... [15:58:14] 10MediaWiki-Search, 10Discovery-Search, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10Aklapper) Cannot reproduce the problem with the given URL. Instead I get an error message properly displayed: `Při hledá... [16:01:40] 10MediaWiki-Search, 10Discovery-Search, 10PHP 7.2 support, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10Daimona) >>! In T216959#4979113, @Aklapper wrote: > Cannot reproduce the problem with the given URL... [16:01:47] 10MediaWiki-Search, 10Discovery-Search, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10Daimona) [16:05:51] 10MediaWiki-Search, 10Discovery-Search, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10matej_suchanek) >>! In T216959#4979113, @Aklapper wrote: > Cannot reproduce the problem with the given URL. Instead I ge... [16:11:35] 10MediaWiki-Search, 10Discovery-Search, 10PHP 7.2 support, 10Regression, 10Vuln-Infoleak: Search exceptions handling prints response information on the screen - https://phabricator.wikimedia.org/T216959 (10Daimona) Soooo... I tried again and managed to reproduce it. The first obstacle I found is that som... [16:14:28] (03CR) 10Krinkle: specials: Cleanup and fix PHPDoc comments (032 comments) [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [16:15:06] (03CR) 10Krinkle: specials: Cleanup and fix PHPDoc comments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [16:15:16] (03CR) 10Krinkle: [C: 04-1] "One nit, then good to go!" [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [16:22:03] 10MobileFrontend: In mobile view, if a reference contains a link, the link may be misformatted - https://phabricator.wikimedia.org/T216961 (10pajz) [16:25:05] 10MobileFrontend: In mobile view, if a reference contains a link, the link may be positioned improperly in the footnote tooltip - https://phabricator.wikimedia.org/T216961 (10pajz) [16:27:14] (03PS1) 10Zoranzoki21: Upgrade TitleBlacklist extension to use newer version of phan [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/492547 (https://phabricator.wikimedia.org/T216946) [16:28:11] 10InternetArchiveBot: Remove |4= from {{cite}} templates - https://phabricator.wikimedia.org/T216962 (10Green_Cardamom) a:03Cyberpower678 [16:28:22] (03PS2) 10Zoranzoki21: Upgrade TitleBlacklist extension to use newer version of phan [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/492547 (https://phabricator.wikimedia.org/T216946) [16:31:23] 10Wikimedia-Site-requests: Change the favicon of the german mobile de.m.wiktionary.org site - https://phabricator.wikimedia.org/T202902 (10Formatierer) If there is still not clear what to do, we want the apple-touch-icon.png, which is used on mobile devices, look the same as favicon.ico, which is used on desktop... [16:34:09] (03PS1) 10Fomafix: Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 [16:36:00] (03PS1) 10Zoranzoki21: Upgrade Poem extension to use newer phan [extensions/Poem] - 10https://gerrit.wikimedia.org/r/492549 (https://phabricator.wikimedia.org/T216936) [16:36:22] 10MediaWiki-extensions-Poem, 10Patch-For-Review, 10User-Zoranzoki21, 10phan: Upgrade Poem extension to use newer phan - https://phabricator.wikimedia.org/T216936 (10Zoranzoki21) a:03Zoranzoki21 [16:36:27] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Setian) >>! In T215696#4979023, @Krinkle wrote: > The page link is indeed red and represents the title at the time. > > But, does the "diff"... [16:36:42] (03CR) 10jerkins-bot: [V: 04-1] Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 (owner: 10Fomafix) [16:37:16] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/492470 (https://phabricator.wikimedia.org/T215696) (owner: 10Setian) [16:37:47] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Zoranzoki21) a:03Setian [16:38:29] (03CR) 10jerkins-bot: [V: 04-1] Upgrade TitleBlacklist extension to use newer version of phan [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/492547 (https://phabricator.wikimedia.org/T216946) (owner: 10Zoranzoki21) [16:44:56] (03PS1) 10Matěj Suchánek: Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) [16:45:27] (03PS2) 10Fomafix: Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 [16:48:39] (03CR) 10jerkins-bot: [V: 04-1] Update past recentchanges entries when user moves a page [core] - 10https://gerrit.wikimedia.org/r/492470 (https://phabricator.wikimedia.org/T215696) (owner: 10Setian) [16:48:42] (03CR) 10jerkins-bot: [V: 04-1] Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 (owner: 10Fomafix) [16:48:56] (03PS3) 10Tpt: Tracks entity usage when filling the other project sidebar [extensions/Wikisource] - 10https://gerrit.wikimedia.org/r/485486 (https://phabricator.wikimedia.org/T180303) [16:54:52] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) (owner: 10Matěj Suchánek) [17:01:36] (03PS2) 10Matěj Suchánek: Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) [17:01:54] 10MediaWiki-Interwiki: Integrate interwiki titles into LinkCache - https://phabricator.wikimedia.org/T216873 (10Setian) There's going to be a need for cross-wiki invalidation of caches, right, when pages are deleted, etc.? How are we going to make that happen? [17:03:12] (03CR) 10Daimona Eaytoy: "Some other minor comments, but aside from these I think we're ready." (037 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) (owner: 10Matěj Suchánek) [17:04:55] (03PS1) 10Matěj Suchánek: Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) [17:06:44] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:07:18] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:11:38] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) (owner: 10Matěj Suchánek) [17:12:00] (03PS3) 10D3r1ck01: specials: Cleanup and fix PHPDoc comments [core] - 10https://gerrit.wikimedia.org/r/492477 [17:12:23] (03CR) 10jerkins-bot: [V: 04-1] Tracks entity usage when filling the other project sidebar [extensions/Wikisource] - 10https://gerrit.wikimedia.org/r/485486 (https://phabricator.wikimedia.org/T180303) (owner: 10Tpt) [17:14:12] 10MediaWiki-Internationalization, 10CirrusSearch, 10Discovery-Search, 10Patch-For-Review: Deduplicate I18N messages between Wikibase and WikibaseCirrusSearch - https://phabricator.wikimedia.org/T216839 (10Nikerabbit) How about putting the duplicated messages in WikibaseCirrusSearch to another i18n file tha... [17:15:26] (03PS2) 10Matěj Suchánek: Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) [17:15:49] (03PS3) 10Matěj Suchánek: Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) [17:17:14] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:18:21] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:26:23] (03PS3) 10Matěj Suchánek: Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) [17:28:03] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:28:42] (03CR) 10jerkins-bot: [V: 04-1] Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [17:37:15] 10MediaWiki-extensions-CleanChanges: Dates on last modifications are doubled - https://phabricator.wikimedia.org/T183646 (10Kghbln) I now ran into this after upgrading from REL1_27 to REL1_31: **Setup** - MediaWiki 1.31.1 (9ea0a46) 17:34, 18. Feb. 2019 - PHP 7.0.33-0+deb9u1 (apache2handler) - MariaDB 10.1.37... [17:46:18] (03PS4) 10Matěj Suchánek: Migrate to new phan [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) [17:50:29] (03PS33) 10Matěj Suchánek: Use actor table in AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) [17:51:32] (03CR) 10Matěj Suchánek: Use actor table in AbuseFilter (035 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) (owner: 10Matěj Suchánek) [17:55:59] (03CR) 10Krinkle: [C: 04-1] "I'm not sure, but I suspect this would result in N (e.g. N = 100 items on a page) database queries one by one to check if a revision exist" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492386 (owner: 10Matěj Suchánek) [17:57:25] (03CR) 10Krinkle: "We may want to make sure that we do not offer and track two ways of thanking the same user action. E.g. the null revision for a page move " [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492387 (https://phabricator.wikimedia.org/T213660) (owner: 10Matěj Suchánek) [18:01:31] (03CR) 10Daimona Eaytoy: [C: 03+1] "Virtual +2" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) (owner: 10Matěj Suchánek) [18:04:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] specials: Cleanup and fix PHPDoc comments [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [18:05:42] 10InternetArchiveBot: Remove |4= from {{cite}} templates - https://phabricator.wikimedia.org/T216962 (10Cyberpower678) That's not the bug he meant on my talk page. It destroyed embedded wikilinks. Empty parameters are usually from double pipes. [18:08:22] (03CR) 10Thiemo Kreuz (WMDE): "Thanks a lot for the quick review and merge!" (031 comment) [extensions/DynamicPageList] - 10https://gerrit.wikimedia.org/r/492537 (owner: 10Thiemo Kreuz (WMDE)) [18:12:17] 10MediaWiki-extensions-GettingStarted, 10Growth-Team, 10Mobile-Content-Service, 10WikimediaEditorTasks, and 2 others: Create a new endpoint which returns articles in need of a description - https://phabricator.wikimedia.org/T206504 (10Mholloway) [18:13:35] (03Abandoned) 10Thiemo Kreuz (WMDE): [DNM] Notes and demonstration on how to add new preview types [extensions/Popups] - 10https://gerrit.wikimedia.org/r/434168 (owner: 10Thiemo Kreuz (WMDE)) [18:17:39] (03Merged) 10jenkins-bot: specials: Cleanup and fix PHPDoc comments [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [18:18:32] 10MediaWiki-Internationalization, 10VisualEditor, 10VisualEditor-Media: Consider autopopulating images from commons category from wikidata instead of searching for page title when opening insert media tool - https://phabricator.wikimedia.org/T216963 (10Mvolz) [18:19:02] (03PS3) 10Fomafix: Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 [18:20:07] (03CR) 10jenkins-bot: specials: Cleanup and fix PHPDoc comments [core] - 10https://gerrit.wikimedia.org/r/492477 (owner: 10D3r1ck01) [18:20:43] 10MonoBook: HotCat breaks on update from MW1.31.1 to 1.32.0 in skin Monobook - https://phabricator.wikimedia.org/T216891 (10Tenbergen) 05Open→03Resolved a:03Tenbergen @Ashley: You are right, my update process was wrong and retained old extensions for those that come with mediawiki. Once I replaced Gadget w... [18:20:46] (03CR) 10Fomafix: Tests for MediaWiki CodeMirror syntax highlighting (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/419513 (https://phabricator.wikimedia.org/T169592) (owner: 10MusikAnimal) [18:27:04] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10phan: Add phan to GrowthExperiments - https://phabricator.wikimedia.org/T216964 (10kostajh) [18:27:05] (03PS1) 10Reedy: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 [18:27:08] (03CR) 10Reedy: [C: 03+2] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 (owner: 10Reedy) [18:27:11] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team, 10phan: Add phan to GrowthExperiments - https://phabricator.wikimedia.org/T216964 (10kostajh) a:03kostajh [18:27:15] (03PS1) 10Reedy: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492554 [18:27:18] (03CR) 10Reedy: [C: 03+2] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492554 (owner: 10Reedy) [18:29:49] (03CR) 10jerkins-bot: [V: 04-1] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 (owner: 10Reedy) [18:30:01] (03CR) 10jerkins-bot: [V: 04-1] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 (owner: 10Reedy) [18:31:35] (03PS1) 10Reedy: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492555 [18:31:50] (03CR) 10Reedy: [C: 03+2] Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492555 (owner: 10Reedy) [18:32:52] (03Merged) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492554 (owner: 10Reedy) [18:33:49] (03PS1) 10Kosta Harlan: Enable phan [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) [18:33:57] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Known vendor related issues" [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 (owner: 10Reedy) [18:34:36] (03CR) 10Kosta Harlan: "check experimental" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [18:34:59] (03PS1) 10Reedy: Add missing use statement [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492557 [18:35:06] (03PS1) 10Reedy: Add missing use statement [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492558 [18:35:24] (03CR) 10Reedy: [C: 03+2] Add missing use statement [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492557 (owner: 10Reedy) [18:35:29] (03CR) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492554 (owner: 10Reedy) [18:35:31] (03CR) 10Reedy: [C: 03+2] Add missing use statement [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492558 (owner: 10Reedy) [18:35:33] (03Merged) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492555 (owner: 10Reedy) [18:36:22] (03PS1) 10Reedy: Add missing use statement [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492559 [18:36:47] (03CR) 10Reedy: [C: 03+2] Add missing use statement [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492559 (owner: 10Reedy) [18:37:26] (03CR) 10jerkins-bot: [V: 04-1] Add missing use statement [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492557 (owner: 10Reedy) [18:37:28] (03CR) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492553 (owner: 10Reedy) [18:37:49] (03CR) 10Reedy: [V: 03+2 C: 03+2] "Known vendor failures" [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492557 (owner: 10Reedy) [18:39:04] (03CR) 10jenkins-bot: Fix caching in AFComputedVariable [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492555 (owner: 10Reedy) [18:39:26] (03CR) 10Reedy: [C: 03+2] Fixup whitespace and indenting [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/491236 (owner: 10Reedy) [18:39:28] (03Merged) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492558 (owner: 10Reedy) [18:39:49] (03Merged) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492559 (owner: 10Reedy) [18:40:52] (03CR) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/492557 (owner: 10Reedy) [18:42:30] (03Merged) 10jenkins-bot: Fixup whitespace and indenting [extensions/ImportUsers] - 10https://gerrit.wikimedia.org/r/491236 (owner: 10Reedy) [18:42:43] (03CR) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_27) - 10https://gerrit.wikimedia.org/r/492559 (owner: 10Reedy) [18:43:09] (03PS2) 10Kosta Harlan: Enable phan [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) [18:44:30] (03CR) 10jenkins-bot: Add missing use statement [extensions/AbuseFilter] (REL1_30) - 10https://gerrit.wikimedia.org/r/492558 (owner: 10Reedy) [18:45:28] (03PS4) 10Fomafix: Make Special:JavaScriptTest pass on Webkit and on Firefox [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 [18:45:30] (03PS1) 10Fomafix: Make Special:JavaScriptTest pass with and without extension Cite [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492560 [18:46:12] 10MediaWiki-extensions-General, 10HHVM, 10I18n, 10PHP 7.2 support, 10Patch-For-Review: Define varargs in \IContextSource::msg() in a way phan can understand it - https://phabricator.wikimedia.org/T191666 (10kostajh) Not sure if these were the right tags to add, but bumping this since I just encountered t... [18:52:17] (03CR) 10jerkins-bot: [V: 04-1] Make Special:JavaScriptTest pass with and without extension Cite [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492560 (owner: 10Fomafix) [18:53:06] (03PS3) 10Kosta Harlan: Enable phan [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) [18:56:33] (03CR) 10Matěj Suchánek: "> Patch Set 1: Code-Review-1" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492386 (owner: 10Matěj Suchánek) [18:56:36] (03CR) 10Matěj Suchánek: "> Patch Set 1:" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492387 (https://phabricator.wikimedia.org/T213660) (owner: 10Matěj Suchánek) [19:01:21] (03CR) 10Kosta Harlan: "check experimental" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [19:02:54] (03PS2) 10Fomafix: Make Special:JavaScriptTest pass with and without extension Cite [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492560 [19:09:10] (03PS1) 10MarcoAurelio: Remove CollapsibleHeadings [extensions] - 10https://gerrit.wikimedia.org/r/492562 [19:09:49] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Remove CollapsibleHeadings [extensions] - 10https://gerrit.wikimedia.org/r/492562 (owner: 10MarcoAurelio) [19:13:17] (03CR) 10Krinkle: Make Special:JavaScriptTest pass on Webkit and on Firefox (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 (owner: 10Fomafix) [19:13:35] (03CR) 10Krinkle: [C: 03+1] Make Special:JavaScriptTest pass with and without extension Cite [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492560 (owner: 10Fomafix) [19:13:38] (03CR) 10Kosta Harlan: "AFAICT, the build will fail until I081717e619fb51c6af88f4f82740d218baf0fe73 is merged, as that will set MinervaNeue as a dependency. The a" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [19:13:42] (03PS1) 10MarcoAurelio: Register new extensions [extensions] - 10https://gerrit.wikimedia.org/r/492563 [19:14:12] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] Register new extensions [extensions] - 10https://gerrit.wikimedia.org/r/492563 (owner: 10MarcoAurelio) [19:17:30] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Krinkle) And after this change, that would still be the case, right? So that seems to be working as expected. [19:21:43] 10MediaWiki-extensions-TorBlock, 10phan: Upgrade TorBlock extension to use newer phan - https://phabricator.wikimedia.org/T216947 (10MarcoAurelio) I'll try this one. [19:22:42] (03CR) 10Legoktm: [C: 04-1] Upgrade TitleBlacklist extension to use newer version of phan (031 comment) [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/492547 (https://phabricator.wikimedia.org/T216946) (owner: 10Zoranzoki21) [19:23:51] (03CR) 10Legoktm: [C: 03+2] Upgrade Poem extension to use newer phan [extensions/Poem] - 10https://gerrit.wikimedia.org/r/492549 (https://phabricator.wikimedia.org/T216936) (owner: 10Zoranzoki21) [19:24:42] (03CR) 10Legoktm: [C: 03+2] "Nice :)" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) (owner: 10Matěj Suchánek) [19:26:08] 10MediaWiki-Recent-changes, 10Growth-Team, 10Patch-For-Review: RecentChanges should update entries when user move a page - https://phabricator.wikimedia.org/T215696 (10Setian) >>! In T215696#4979249, @Krinkle wrote: > And after this change, that would still be the case, right? That seems to be working as exp... [19:26:10] (03CR) 10Legoktm: Migrate to new phan (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [19:27:21] 04(no projects): HotCat breaks on update from MW1.31.1 to 1.32.0 in skin Monobook - https://phabricator.wikimedia.org/T216891 (10Aklapper) 05Resolved→03Invalid Setting status to invalid as there was no error in the code. [19:28:01] (03CR) 10Fomafix: Make Special:JavaScriptTest pass on Webkit and on Firefox (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 (owner: 10Fomafix) [19:29:56] (03PS1) 10MarcoAurelio: WIP: Use newer version of Phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 [19:32:46] (03CR) 10MarcoAurelio: "This depends on AbuseFilter, so it won't pass until AbuseFilter is migrated afaics." [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (owner: 10MarcoAurelio) [19:33:45] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use newer version of Phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (owner: 10MarcoAurelio) [19:34:30] (03Merged) 10jenkins-bot: Upgrade Poem extension to use newer phan [extensions/Poem] - 10https://gerrit.wikimedia.org/r/492549 (https://phabricator.wikimedia.org/T216936) (owner: 10Zoranzoki21) [19:35:31] 10Wikipedia-Android-App-Backlog, 10WorkType-NewFunctionality: Add feature to highlight text - https://phabricator.wikimedia.org/T70272 (10Dbrant) [19:35:37] (03PS2) 10MarcoAurelio: WIP: Use newer version of Phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 [19:37:38] (03CR) 10Krinkle: "Yep, that would resemble the way changes link links are exposed for regular edits and page creations already, which also uses LinksUpdate," [core] - 10https://gerrit.wikimedia.org/r/491532 (https://phabricator.wikimedia.org/T216249) (owner: 10Bmansurov) [19:39:55] 10MediaWiki-extensions-TorBlock, 10phan: Upgrade TorBlock extension to use newer phan - https://phabricator.wikimedia.org/T216947 (10MarcoAurelio) `includes/TorExitNodes.php:199 PhanTypeArraySuspicious Suspicious array access to ?mixed|?string` [19:40:12] (03CR) 10jerkins-bot: [V: 04-1] WIP: Use newer version of Phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (owner: 10MarcoAurelio) [19:40:33] (03CR) 10MarcoAurelio: "includes/TorExitNodes.php:199 PhanTypeArraySuspicious Suspicious array access to ?mixed|?string" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (owner: 10MarcoAurelio) [19:42:04] (03Merged) 10jenkins-bot: Migrate to new phan [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/492550 (https://phabricator.wikimedia.org/T216945) (owner: 10Matěj Suchánek) [19:42:22] (03CR) 10Matěj Suchánek: Migrate to new phan (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/492552 (https://phabricator.wikimedia.org/T216949) (owner: 10Matěj Suchánek) [19:43:14] (03PS3) 10MarcoAurelio: WIP: Upgrade TorBlock to use a newer version of phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (https://phabricator.wikimedia.org/T216947) [19:46:18] 10WikiApiary: Wikiapiary: Database server down - https://phabricator.wikimedia.org/T216349 (10Tgr) Yeah the job queue is stalled. Redis is up and I can't find any trace of a related cronjob or service so I'm not sure how it was configured in the first place. (Also the puppet service is stopped. Is that intention... [19:46:45] (03CR) 10jerkins-bot: [V: 04-1] WIP: Upgrade TorBlock to use a newer version of phan [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (https://phabricator.wikimedia.org/T216947) (owner: 10MarcoAurelio) [19:47:03] (03CR) 10Krinkle: Make JSMinPlus allow reserved words as property name (ES5) (033 comments) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [19:56:13] 10MediaWiki-extensions-TranslationNotifications, 10Growth-Team, 10Notifications: Deliver notification using Echo where available - https://phabricator.wikimedia.org/T48310 (10Nikerabbit) There hasn't been any work done on this task, so yes. [19:57:27] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: JSMinPlus (user script validator) should allow reserved words in dot notation (ES5) - https://phabricator.wikimedia.org/T215280 (10Krinkle) @Ebraminio We have indeed, unfortunately, two parsers/minifiers currently. We use JavaScriptMinifier... [19:59:19] (03CR) 10Krinkle: "A few inline comments, but overall looks good to me. Note that this is an external library that we do not currently maintain ourselves. As" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [20:04:10] (03CR) 10Thiemo Kreuz (WMDE): Remove call of undeclared methods in Special:MergeAccount (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492509 (owner: 10Umherirrender) [20:06:06] (03CR) 10Daniel Kinzler: "> What would you pass instead? $title and $parserOutput and $revision and $addedLinks and $removedLinks and $addedExternalLinks and $remov" [core] - 10https://gerrit.wikimedia.org/r/491532 (https://phabricator.wikimedia.org/T216249) (owner: 10Bmansurov) [20:07:06] (03CR) 10Daniel Kinzler: "> Is the conclusion to introduce hooks to LinksDeletionUpdate?" [core] - 10https://gerrit.wikimedia.org/r/491532 (https://phabricator.wikimedia.org/T216249) (owner: 10Bmansurov) [20:13:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I understand the motivation and support it. But I think this trivial change would, as it is now, leave the code in a more confusing state " (034 comments) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/492507 (owner: 10Umherirrender) [20:25:54] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Oh wow. This is a bit crazy and can only be reviewed by following all these codepaths. Even then I'm not entirely sure. But after reading " (033 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/492501 (owner: 10Umherirrender) [20:28:34] 10Mathe für Nicht-Freaks: Wie beweist man Mengengleichungen? - https://phabricator.wikimedia.org/T216966 (10Kulla) [20:31:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Makes sense for me. But I would like somebody else to merge this, preferably one of the main authors of this extension (somebody who is fa" (031 comment) [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/492480 (https://phabricator.wikimedia.org/T201745) (owner: 10Umherirrender) [20:36:52] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Ifygal3) Hello @srishakatux , I a... [20:37:10] 10MediaWiki-extensions-Poem, 10Patch-For-Review, 10User-Zoranzoki21, 10phan: Upgrade Poem extension to use newer phan - https://phabricator.wikimedia.org/T216936 (10Legoktm) 05Open→03Resolved [20:44:12] (03CR) 10Daimona Eaytoy: "That line reads $ip[0], and $ip is a string. This works in PHP but it's not the right way to do it. substr, for instance, would be more ap" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (https://phabricator.wikimedia.org/T216947) (owner: 10MarcoAurelio) [20:45:21] 10Mathe für Nicht-Freaks: Noether-Theorem(Laura) - https://phabricator.wikimedia.org/T216059 (10Modronomiesatz) [20:52:28] (03CR) 10Wctaiwan: [C: 03+2] Fix JS exception when adding a new target on non-crosswiki wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492535 (owner: 10Legoktm) [20:56:21] (03CR) 10Legoktm: "> Patch Set 3:" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (https://phabricator.wikimedia.org/T216947) (owner: 10MarcoAurelio) [20:56:29] (03Merged) 10jenkins-bot: Fix JS exception when adding a new target on non-crosswiki wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492535 (owner: 10Legoktm) [20:58:57] (03CR) 10jenkins-bot: Fix JS exception when adding a new target on non-crosswiki wikis [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/492535 (owner: 10Legoktm) [21:06:06] 10MediaWiki-API: Iwbacklinks returns pageid as string instead of int - https://phabricator.wikimedia.org/T216968 (10RobinHood70) [21:06:20] (03CR) 10Legoktm: [C: 03+2] Don't use deprecated (in MW 1.32) SpecialPageFactory functions (031 comment) [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483777 (owner: 10Jack Phoenix) [21:07:00] (03Merged) 10jenkins-bot: Don't use deprecated (in MW 1.32) SpecialPageFactory functions [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/483777 (owner: 10Jack Phoenix) [21:09:18] (03CR) 10Krinkle: resourceloader: Add getScript() method for loading scripts with callback (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [21:09:23] (03CR) 10Krinkle: "One more thing (sorry)" [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [21:09:48] 10MediaWiki-API: Iwbacklinks returns pageid as string instead of int - https://phabricator.wikimedia.org/T216968 (10RobinHood70) [21:10:55] (03CR) 10Krinkle: "recheck" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [21:13:51] (03CR) 10Daimona Eaytoy: "> > Patch Set 3:" [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/492564 (https://phabricator.wikimedia.org/T216947) (owner: 10MarcoAurelio) [21:16:25] 10MediaWiki-API, 10Outreach-Programs-Projects, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, and 2 others: Outreachy Round 18: Documentation improvements to the ~20 top 70 most viewed MediaWiki Action API pages on-wiki - https://phabricator.wikimedia.org/T215682 (10Aklapper) Please read T215682#497... [21:19:59] (03CR) 10Kosta Harlan: "check experimental" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [21:20:32] (03CR) 10Kosta Harlan: "> Patch Set 3:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [21:23:42] (03CR) 10Krinkle: Enable phan (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [21:23:45] (03CR) 10Krinkle: [C: 03+1] Enable phan [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [21:27:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/492566 (owner: 10L10n-bot) [21:27:49] (03CR) 10Krinkle: Make Special:JavaScriptTest pass on Webkit and on Firefox (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/492548 (owner: 10Fomafix) [21:29:34] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/492574 (owner: 10L10n-bot) [21:30:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/492571 (owner: 10L10n-bot) [21:35:06] 10Language-Team, 10UniversalLanguageSelector, 10Performance-Team (Radar): Languages sidebar portlet visibly changes label (otherlanguages > uls-plang-title-languages) - https://phabricator.wikimedia.org/T163740 (10Krinkle) The message used for this is `otherlanguages`. MediaWiki allows extensions to replace... [21:44:46] (03PS1) 10Setian: Return the page_id in list=iwbacklinks as an int rather than string [core] - 10https://gerrit.wikimedia.org/r/492575 (https://phabricator.wikimedia.org/T216968) [21:50:10] 10MediaWiki-Special-pages, 10UI-Standardization, 10Regression: Namespace no longer automatically detected on Special:PrefixIndex - https://phabricator.wikimedia.org/T196115 (10Krinkle) >>! In T196115#4978136, @D3r1ck01 wrote: > In addition, the search request by @GeoffreyT2000 (https://en.wikipedia.org/wiki/... [21:53:27] (03PS2) 10Ebrahim: resourceloader: Make JSMinPlus allow reserved words as property name (ES5) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) [21:57:05] (03CR) 10Ebrahim: "Done I guess. PTAL" [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [22:14:11] (03PS3) 10Ebrahim: resourceloader: Make JSMinPlus allow reserved words as property name (ES5) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) [22:18:34] (03CR) 10Kosta Harlan: Enable phan (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/492556 (https://phabricator.wikimedia.org/T216964) (owner: 10Kosta Harlan) [22:23:41] 10MediaWiki-API: API inconsistently uses int casting methods - https://phabricator.wikimedia.org/T216969 (10Reedy) [22:28:35] (03CR) 10Krinkle: [C: 03+2] resourceloader: Make JSMinPlus allow reserved words as property name (ES5) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [22:34:18] 10MediaWiki-Codesniffer: Replace casting functions with direct casting - https://phabricator.wikimedia.org/T216971 (10Reedy) [22:37:45] 10Wikimedia-Site-requests: Formatting issue I am unable to delete after having properly reformatted the same information - https://phabricator.wikimedia.org/T216972 (10Lindsruss108) [22:40:02] 10MediaWiki-Categories, 10Wikimedia-maintenance-script-run: Number of category members (PAGESINCATEGORY) is inaccurate for large categories - https://phabricator.wikimedia.org/T18036 (10Roy17) >>! In T18036#3735700, @matmarex wrote: > No, there isn't (other than removing all pages from it, but please don't do... [22:48:06] 10Wikimedia-Site-requests: Formatting issue I am unable to delete after having properly reformatted the same information - https://phabricator.wikimedia.org/T216972 (10Reedy) 05Open→03Resolved a:03Reedy The text was written as if it was supposed to be in the table, but it's not using table formatting Remo... [22:49:30] (03Merged) 10jenkins-bot: resourceloader: Make JSMinPlus allow reserved words as property name (ES5) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [22:51:36] (03CR) 10jenkins-bot: resourceloader: Make JSMinPlus allow reserved words as property name (ES5) [core] - 10https://gerrit.wikimedia.org/r/491883 (https://phabricator.wikimedia.org/T215280) (owner: 10Ebrahim) [22:54:40] 10MediaWiki-Codesniffer: Replace casting functions with direct casting - https://phabricator.wikimedia.org/T216971 (10Reedy) [23:38:39] (03CR) 10MaxSem: "check" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/492575 (https://phabricator.wikimedia.org/T216968) (owner: 10Setian) [23:38:41] 10CommRel-Specialists-Support (Jan-Mar-2019), 10VisualEditor (Current work): Identify target wikis for mobile editing improvements - https://phabricator.wikimedia.org/T206550 (10deryckchan) @ppelberg / @Whatamidoing-WMF : Sorry for the British understatement. By "fine" and "alright" in (1) VE-Gboard interactio... [23:42:36] (03CR) 10MaxSem: [C: 03+2] Error: Call to a member function doLogout() on boolean [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/492480 (https://phabricator.wikimedia.org/T201745) (owner: 10Umherirrender) [23:45:53] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.33-notes (1.33.0-wmf.19; 2019-02-26), 10Patch-For-Review: JSMinPlus (user script validator) should allow reserved words in dot notation (ES5) - https://phabricator.wikimedia.org/T215280 (10Ebraminio) Now it makes sense. Thanks! [23:49:12] (03Merged) 10jenkins-bot: Error: Call to a member function doLogout() on boolean [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/492480 (https://phabricator.wikimedia.org/T201745) (owner: 10Umherirrender)