[00:15:02] 10MediaWiki-extensions-NewestPages, 10User-Jayprakash12345: [Extension:NewestPages] Remove the usage of $wgContLang - https://phabricator.wikimedia.org/T215113 (10Jayprakash12345) [00:16:05] (03PS1) 10Jayprakash12345: Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) [00:25:03] 10Repository-Admins: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T215112 (10MGChecker) While I'm not involved in deciding this, I would appreciate you doing actual code contributions first. The commits you linked here are still more on the trivial side of things. [00:26:19] 10Repository-Admins: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T215112 (10Zoranzoki21) [00:27:56] (03PS2) 10Legoktm: Revert "Unbreak Pbkdf2PasswordTest" [core] - 10https://gerrit.wikimedia.org/r/487513 [00:28:36] (03CR) 10Legoktm: "Rebased on dropping PHPUnit 4 support first." [core] - 10https://gerrit.wikimedia.org/r/487513 (owner: 10Legoktm) [00:29:50] 10Repository-Admins: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T215112 (10Zoranzoki21) (removed the smiley from description because I would not to it sound like some kind of provocation that is not the point) >>! In T215112#4922923, @MGChecker wrote: > While I'm not involved in decid... [00:34:17] (03CR) 10jerkins-bot: [V: 04-1] Revert "Unbreak Pbkdf2PasswordTest" [core] - 10https://gerrit.wikimedia.org/r/487513 (owner: 10Legoktm) [00:35:10] (03CR) 10jerkins-bot: [V: 04-1] Revert "Unbreak Pbkdf2PasswordTest" [core] - 10https://gerrit.wikimedia.org/r/487513 (owner: 10Legoktm) [01:23:14] (03PS1) 10Zoranzoki21: Removal of using pr_user field from schema [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/487621 (https://phabricator.wikimedia.org/T199377) [01:29:16] (03PS2) 10Zoranzoki21: Removal of using pr_user field from schema [extensions/PageBlock] - 10https://gerrit.wikimedia.org/r/487621 (https://phabricator.wikimedia.org/T199377) [01:41:11] 10MediaWiki-Database, 10Schema-change: remove obsolete database field rc_new - https://phabricator.wikimedia.org/T36320 (10Zoranzoki21) Status of this? I think this can be dropped. [01:54:13] 10MediaWiki-Cache, 10Operations, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, and 3 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10aaron) Also note that even the old LRU algorithm... [01:57:05] 10MediaWiki-User-preferences, 10MediaWiki-extensions-General, 10good first bug: Remove uses of 'cols' and 'rows' preferences from extensions - https://phabricator.wikimedia.org/T155153 (10Zoranzoki21) I can't find this in extensions. Should this be closed as resolved? [02:14:39] (03PS1) 10Aaron Schulz: objectcache: avoid duplicate set() calls with lockTSE when no value is in cache [core] - 10https://gerrit.wikimedia.org/r/487622 (https://phabricator.wikimedia.org/T203786) [02:18:07] (03PS2) 10Aaron Schulz: objectcache: avoid duplicate set() calls with lockTSE when no value is in cache [core] - 10https://gerrit.wikimedia.org/r/487622 (https://phabricator.wikimedia.org/T203786) [02:18:35] 10Repository-Admins: +2 for Zoranzoki21 in mediawiki/* - https://phabricator.wikimedia.org/T215112 (10Krenair) 05Open→03Declined I have to agree, adding a few comments with @covers does not come close to the generally expected requirements for this. To answer your question about what would qualify as an actu... [02:20:53] (03CR) 10Aaron Schulz: "I'll get around to amending it." [core] - 10https://gerrit.wikimedia.org/r/466980 (https://phabricator.wikimedia.org/T206288) (owner: 10Aaron Schulz) [03:01:29] 10MediaWiki-User-management, 10Anti-Harassment (Bet — ב): Create technical plan for merging overlapping blocks - https://phabricator.wikimedia.org/T211238 (10Tchanders) Here's a summary of what we've discussed so far. **Overview** By "overlapping blocks", we mean when multiple, independent blocks apply to a... [04:07:12] 10MediaWiki-extensions-Other, 10Continuous-Integration-Config, 10Patch-For-Review, 10Reading-Infrastructure-Team-Backlog (Kanban): Basic CI checks for mediawiki/extension/AuthenticatedKeyValueStore - https://phabricator.wikimedia.org/T214417 (10Liuxinyu970226) [04:20:25] 10MediaWiki-Cache, 10Operations, 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10Patch-For-Review, and 3 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10elukey) >>! In T203786#4922942, @aaron wrote: > A... [04:59:38] 10Gadgets, 10Gadgets-2.0: Get community feedback on Gadgets 2.0 before migrating - https://phabricator.wikimedia.org/T125582 (10Pppery) [05:07:33] (03CR) 10Legoktm: [C: 04-1] "> Patch Set 4:" [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/483813 (owner: 10Thiemo Kreuz (WMDE)) [05:09:28] (03PS3) 10Legoktm: Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:09:40] (03PS4) 10Legoktm: Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:09:46] (03CR) 10Legoktm: [C: 03+2] "<3" [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:24:51] (03CR) 10jerkins-bot: [V: 04-1] Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:25:08] (03CR) 10jerkins-bot: [V: 04-1] Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:34:30] 04(no projects): Providing WebP images directly on the web page - https://phabricator.wikimedia.org/T215114 (10Great_Brightstar) [05:43:20] (03PS1) 10Legoktm: FormatJson: Improve parse() error code handling and tests [core] - 10https://gerrit.wikimedia.org/r/487625 [05:43:22] (03PS1) 10Legoktm: Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 [05:53:18] (03CR) 10Legoktm: Add some missing @covers tags (034 comments) [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [05:53:49] (03PS3) 10Legoktm: Add some missing @covers tags [core] - 10https://gerrit.wikimedia.org/r/487117 [05:53:51] (03PS5) 10Legoktm: Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [05:57:38] (03CR) 10jerkins-bot: [V: 04-1] FormatJson: Improve parse() error code handling and tests [core] - 10https://gerrit.wikimedia.org/r/487625 (owner: 10Legoktm) [05:59:38] (03CR) 10jerkins-bot: [V: 04-1] Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 (owner: 10Legoktm) [06:07:34] (03PS2) 10Legoktm: Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 [06:07:36] (03PS2) 10Legoktm: [WIP] FormatJson: Improve parse() error code handling and tests [core] - 10https://gerrit.wikimedia.org/r/487625 [06:23:39] (03CR) 10jerkins-bot: [V: 04-1] [WIP] FormatJson: Improve parse() error code handling and tests [core] - 10https://gerrit.wikimedia.org/r/487625 (owner: 10Legoktm) [07:27:47] (03CR) 10Fomafix: [C: 04-1] "Add in extension.json" [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) (owner: 10Jayprakash12345) [07:48:55] 10MediaWiki-User-preferences, 10MediaWiki-extensions-Linter: User preferences: Check raw signature for linter errors - https://phabricator.wikimedia.org/T140606 (10Jonesey95) It would be great to have this feature request addressed. People are still able to add high-priority Linter errors to talk pages with ev... [08:28:57] 10MediaWiki-Search, 10MediaWiki-Special-pages, 10Discovery-Search: Don't focus on search input when displaying search results in Special:Search - https://phabricator.wikimedia.org/T215117 (10Lejonel) [08:35:25] (03PS2) 10Jayprakash12345: Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) [08:46:52] (03CR) 10Fomafix: [C: 04-1] Remove the usage of $wgContLang (031 comment) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) (owner: 10Jayprakash12345) [08:55:00] (03PS3) 10Jayprakash12345: Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) [08:56:37] (03PS1) 10MaxSem: Fix usage of deprecated Password::equals() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/487628 [09:09:23] (03CR) 10Fomafix: [C: 03+1] Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) (owner: 10Jayprakash12345) [09:11:37] (03PS1) 10MaxSem: Fix usage of deprecated Password::equals() [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/487629 [09:21:47] (03CR) 10Fomafix: [C: 03+2] Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) (owner: 10Jayprakash12345) [09:25:28] (03Merged) 10jenkins-bot: Remove the usage of $wgContLang [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487620 (https://phabricator.wikimedia.org/T215113) (owner: 10Jayprakash12345) [09:29:30] 10Wikimedia-production-error: 惡性循環 - https://phabricator.wikimedia.org/T215118 (10Raphael) [09:32:27] 10phpunit-patch-coverage: Separate test coverage "increased" from "stayed the same" - https://phabricator.wikimedia.org/T203199 (10Legoktm) 05Open→03Stalled This is a limitation in the current setup that jenkins/zuul can only communicate a binary state. So "stayed the same" has to go in either decreased or i... [09:32:36] 10phpunit-patch-coverage: phpunit-patch-coverage fails if a file was renamed - https://phabricator.wikimedia.org/T202470 (10Legoktm) a:03Legoktm [09:34:57] 04(no projects): Xiplus - https://phabricator.wikimedia.org/T215119 (10Raphael) [09:35:10] 10Security: trash - https://phabricator.wikimedia.org/T215118 (10MaxSem) 05Open→03Invalid [09:36:05] (03PS1) 10Fomafix: Rename class name and file name [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487631 [09:36:48] 04(no projects): Xiplus - https://phabricator.wikimedia.org/T215119 (10Raphael) 以保護維護之名義行為惡性破壞封鎖他人編輯權限 應該刪除此工具 [09:40:55] 10phpunit-patch-coverage: PHPUnit entry point 'PHPUnit_TextUI_Command' not found during mediawiki-phpunit-coverage-patch job - https://phabricator.wikimedia.org/T196323 (10Legoktm) 05Open→03Declined The only reason I can think of this happening is some screwup when installing composer dependencies...in any c... [09:45:55] (03CR) 10MaxSem: [C: 03+2] Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 (owner: 10Legoktm) [09:47:25] (03PS1) 10Legoktm: Require HHVM or PHP 7.0+ [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487632 [09:47:27] (03PS1) 10Legoktm: Validate @covers tags [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 [09:47:29] (03PS1) 10Legoktm: Don't highlight stderr specially [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487634 [09:47:31] (03PS1) 10Legoktm: Properly handle renamed files [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487635 (https://phabricator.wikimedia.org/T202470) [09:48:05] (03CR) 10jerkins-bot: [V: 04-1] Validate @covers tags [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 (owner: 10Legoktm) [09:48:27] (03CR) 10MaxSem: [C: 03+2] Require HHVM or PHP 7.0+ [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487632 (owner: 10Legoktm) [09:48:56] (03Merged) 10jenkins-bot: Require HHVM or PHP 7.0+ [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487632 (owner: 10Legoktm) [09:49:25] (03CR) 10jenkins-bot: Require HHVM or PHP 7.0+ [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487632 (owner: 10Legoktm) [09:49:27] (03CR) 10Legoktm: "recheck" [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 (owner: 10Legoktm) [09:54:03] (03PS1) 10Fomafix: Add method scope to all functions [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487637 [09:55:47] (03CR) 10Legoktm: [C: 03+2] Validate @covers tags [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 (owner: 10Legoktm) [09:55:49] (03CR) 10Legoktm: [C: 03+2] Don't highlight stderr specially [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487634 (owner: 10Legoktm) [09:56:22] (03Merged) 10jenkins-bot: Validate @covers tags [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 (owner: 10Legoktm) [09:56:25] (03Merged) 10jenkins-bot: Don't highlight stderr specially [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487634 (owner: 10Legoktm) [09:56:47] (03CR) 10jenkins-bot: Validate @covers tags [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487633 (owner: 10Legoktm) [09:57:01] (03CR) 10jenkins-bot: Don't highlight stderr specially [tools/phpunit-patch-coverage] - 10https://gerrit.wikimedia.org/r/487634 (owner: 10Legoktm) [10:01:15] (03Merged) 10jenkins-bot: Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 (owner: 10Legoktm) [10:02:33] 10MediaWiki-General-or-Unknown, 10Pywikibot: touch.py made changes in page, without flag in RecentCHanges - https://phabricator.wikimedia.org/T112480 (10Xqt) [10:05:15] (03CR) 10jenkins-bot: Finish FormatJson::encode() test coverage [core] - 10https://gerrit.wikimedia.org/r/487626 (owner: 10Legoktm) [10:07:36] (03PS1) 10Fomafix: Move class="allpagesredirect" from to
  • [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487638 [10:14:13] 10MediaWiki-extensions-NewestPages, 10User-Jayprakash12345: [Extension:NewestPages] Remove the usage of $wgContLang - https://phabricator.wikimedia.org/T215113 (10Jayprakash12345) 05Open→03Resolved p:05Triage→03Normal [10:19:06] (03PS1) 10Fomafix: Remove unnecessary call by reference [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487639 [10:35:43] (03PS2) 10Fomafix: Remove unnecessary call by reference [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487639 [10:47:09] (03PS1) 10Fomafix: Use $this->including() instead of $this->mIncluding [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487640 [11:21:56] (03CR) 10Fomafix: [C: 04-1] Replace some Linker::linkKnown usages with LinkRenderer (031 comment) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/448509 (https://phabricator.wikimedia.org/T103970) (owner: 10Jayprakash12345) [11:22:55] (03PS1) 10Matěj Suchánek: Don't use GROUP BY in getNewPages [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/487641 (https://phabricator.wikimedia.org/T212690) [11:29:46] (03PS2) 10Matěj Suchánek: Don't use GROUP BY in getNewPages [extensions/Nuke] - 10https://gerrit.wikimedia.org/r/487641 (https://phabricator.wikimedia.org/T212690) [11:31:02] (03PS1) 10Fomafix: Get config from getConfig() instead of global variable [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 [11:58:24] 10Google-Summer-of-Code (2019): Improving recommender system for wiki media - https://phabricator.wikimedia.org/T214421 (10Chaitanya) can someone guide me what should I do next? [12:00:25] (03PS1) 10Fomafix: Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 [12:01:27] (03CR) 10jerkins-bot: [V: 04-1] Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 (owner: 10Fomafix) [12:02:55] (03PS2) 10Fomafix: Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 [12:05:35] 10MediaWiki-Change-tagging, 10MediaWiki-Special-pages, 10Growth-Team, 10Need-volunteer: Add a drop-down list for the tags in Special:Newpages - https://phabricator.wikimedia.org/T27909 (10matej_suchanek) [12:12:14] (03PS1) 10Rxy: Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) [12:13:54] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:14:25] (03PS1) 10Fomafix: Fix @license tag [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487646 [12:14:34] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:18:53] (03PS1) 10Matěj Suchánek: Prevent undesired toggling on Special:NewPages [core] - 10https://gerrit.wikimedia.org/r/487647 (https://phabricator.wikimedia.org/T211549) [12:19:17] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Regression: Toggle links on Special:NewPages use wrong namespace - https://phabricator.wikimedia.org/T211549 (10matej_suchanek) a:03matej_suchanek [12:25:25] (03PS2) 10Rxy: Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) [12:27:33] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:30:14] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:41:59] (03PS3) 10Rxy: Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) [12:43:50] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:44:27] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:47:24] (03PS4) 10Rxy: Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) [12:49:19] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:49:53] (03CR) 10jerkins-bot: [V: 04-1] Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [12:50:46] (03PS2) 10Jayprakash12345: Replace some Linker::linkKnown usages with LinkRenderer [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/448509 (https://phabricator.wikimedia.org/T103970) [12:51:38] 10MediaWiki-Special-pages: Special:NewPage: Use an HTMLMultiSelectField instead of text links for filters - https://phabricator.wikimedia.org/T200659 (10matej_suchanek) [12:53:50] 10MediaWiki-Special-pages, 10Security: Add .mw-numlink class to numlinks at Special:Whatlinkshere - https://phabricator.wikimedia.org/T184432 (10matej_suchanek) [13:07:16] 10MediaWiki-Search, 10Discovery-Search: Don't focus on search input when displaying search results in Special:Search - https://phabricator.wikimedia.org/T215117 (10Liuxinyu970226) [13:08:03] (03PS5) 10Rxy: Split a methods between logic and output [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) [13:08:07] 10MediaWiki-Search, 10Discovery-Search: Don't focus on search input when displaying search results in Special:Search - https://phabricator.wikimedia.org/T215117 (10Liuxinyu970226) No need to add this tag if there's already a project that focus on specific special pages. [13:20:16] (03CR) 10Fomafix: [C: 03+2] Replace some Linker::linkKnown usages with LinkRenderer [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/448509 (https://phabricator.wikimedia.org/T103970) (owner: 10Jayprakash12345) [13:23:56] (03Merged) 10jenkins-bot: Replace some Linker::linkKnown usages with LinkRenderer [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/448509 (https://phabricator.wikimedia.org/T103970) (owner: 10Jayprakash12345) [13:25:20] (03PS2) 10Fomafix: Rename class name and file name [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487631 [13:27:02] (03PS2) 10Fomafix: Add method scope to all functions [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487637 [13:28:44] 10OOUI, 10Epic: Stop depending on jQuery in OOUI - https://phabricator.wikimedia.org/T215084 (10Izno) Is this {T49145}? [13:32:42] (03PS2) 10Fomafix: Move class="allpagesredirect" from to
  • [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487638 [13:36:35] (03PS3) 10Fomafix: Remove unnecessary call by reference [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487639 [13:39:05] (03PS2) 10Fomafix: Use $this->including() instead of $this->mIncluding [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487640 [13:40:09] (03PS2) 10Fomafix: Get config from getConfig() instead of global variable [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 [13:43:51] 10MediaWiki-General-or-Unknown, 10MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Need-volunteer, 10Patch-For-Review, 10Technical-Debt: Replace Linker::link() usage with LinkRenderer in XX extension (clonable) - https://phabricator.wikimedia.org/T149346 (10Jayprakash12345) [13:43:53] 10MediaWiki-extensions-NewestPages, 10Technical-Debt, 10User-Jayprakash12345: Replace some Linker::linkKnown usages with LinkRenderer - https://phabricator.wikimedia.org/T103970 (10Jayprakash12345) 05Open→03Resolved p:05High→03Normal [13:44:04] (03PS3) 10Fomafix: Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 [13:45:30] 10TWLCon-2019-India: 1lib1ref in Pune - https://phabricator.wikimedia.org/T213379 (10KCVelaga) 05Open→03Resolved [13:45:38] (03PS2) 10Fomafix: Fix @license tag [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487646 [13:45:47] 10TWLCon-2019-India: 1lib1ref in Kolkata - https://phabricator.wikimedia.org/T213376 (10KCVelaga) 05Declined→03Resolved [13:55:43] 10MediaWiki-extensions-IndexFunction, 10User-Zoranzoki21: Convert IndexFunction to use extension registration - https://phabricator.wikimedia.org/T204216 (10Jayprakash12345) Zoran, Hi are you working on this task? [13:59:33] 04(no projects): Expose actor IDs via the API - https://phabricator.wikimedia.org/T215121 (10LucasWerkmeister) [13:59:48] 10MediaWiki-API: Expose actor IDs via the API - https://phabricator.wikimedia.org/T215121 (10LucasWerkmeister) [14:08:18] 10MediaWiki-API: Expose actor IDs via the API - https://phabricator.wikimedia.org/T215121 (10LucasWerkmeister) [14:10:38] (03PS1) 10Jayprakash12345: Flash message when user passing empty value [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/487651 (https://phabricator.wikimedia.org/T192243) [14:11:07] 10MediaWiki-extensions-IndexFunction, 10Patch-For-Review, 10User-Jayprakash12345: Show warn when pass empty value in Special:Index - https://phabricator.wikimedia.org/T192243 (10Jayprakash12345) p:05Triage→03Normal a:03Jayprakash12345 [14:16:22] (03PS2) 10Jayprakash12345: Remove unnecessary hidden field from HTMLForm [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/473066 (https://phabricator.wikimedia.org/T209302) [14:22:25] 10Wikimedia-Site-requests: Change logo for 6 months of atj.wp to celebrate 1000 articles - https://phabricator.wikimedia.org/T215122 (10Benoit_Rochon) [14:24:09] (03PS1) 10Jayprakash12345: Remove unnecessary global, hidden field and setAction from HTMLForm [extensions/IndexFunction] - 10https://gerrit.wikimedia.org/r/487653 (https://phabricator.wikimedia.org/T209302) [14:36:08] 10MediaWiki-extensions-Other, 10User-Jayprakash12345: Remove setMethod( 'post' ) from HTMLForm Object - https://phabricator.wikimedia.org/T215123 (10Jayprakash12345) [14:43:16] (03PS1) 10Jayprakash12345: Remove setMethod( 'post' ) from HTMLForm Object [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/487654 (https://phabricator.wikimedia.org/T215123) [14:50:09] (03Abandoned) 10Daimona Eaytoy: Add missing PostgreSQL updater for af_group [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/23933 (owner: 10Tim Landscheidt) [14:50:27] (03PS1) 10Jayprakash12345: Remove setMethod( 'post' ) from HTMLForm Object [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/487655 (https://phabricator.wikimedia.org/T215123) [14:55:26] (03CR) 10Umherirrender: [C: 03+2] Rename class name and file name [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487631 (owner: 10Fomafix) [14:56:37] (03CR) 10Umherirrender: [C: 03+2] Add method scope to all functions [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487637 (owner: 10Fomafix) [14:57:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Hm, I wasn't aware this syntax can *change* with plugins. This indeed doesn't sound good. Tanks for letting us know! Since what I care abo" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/487486 (https://phabricator.wikimedia.org/T214970) (owner: 10Thiemo Kreuz (WMDE)) [14:59:14] (03Merged) 10jenkins-bot: Rename class name and file name [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487631 (owner: 10Fomafix) [15:00:18] (03Merged) 10jenkins-bot: Add method scope to all functions [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487637 (owner: 10Fomafix) [15:02:50] (03CR) 10Umherirrender: [C: 03+2] Remove unnecessary call by reference [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487639 (owner: 10Fomafix) [15:02:55] (03PS1) 10Daimona Eaytoy: Make the filter field on ViewHistory of "int" type [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487656 [15:06:19] (03CR) 10Umherirrender: [C: 03+2] Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 (owner: 10Fomafix) [15:06:39] (03Merged) 10jenkins-bot: Remove unnecessary call by reference [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487639 (owner: 10Fomafix) [15:10:05] (03Merged) 10jenkins-bot: Remove phpcs exclude rules and fix the code [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487643 (owner: 10Fomafix) [15:14:34] (03CR) 10Umherirrender: "It seems that the license in extension.json was misattributed on migration to new registration, because the old php entry point and the cu" (031 comment) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487646 (owner: 10Fomafix) [15:15:14] (03PS3) 10Umherirrender: Use $this->including() instead of $this->mIncluding [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487640 (owner: 10Fomafix) [15:15:18] (03CR) 10Umherirrender: [C: 03+2] Use $this->including() instead of $this->mIncluding [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487640 (owner: 10Fomafix) [15:16:00] (03CR) 10Umherirrender: "Such links should already have 'mw-redirect', but removing could be a breaking change." [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487638 (owner: 10Fomafix) [15:16:29] (03CR) 10Umherirrender: [C: 03+1] Get config from getConfig() instead of global variable [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 (owner: 10Fomafix) [15:16:54] (03CR) 10Umherirrender: [C: 03+2] Remove "return true" on hook handler functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/487613 (owner: 10Fomafix) [15:17:36] (03CR) 10Umherirrender: Fix @param tags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487171 (owner: 10Fomafix) [15:19:19] (03CR) 10Umherirrender: [C: 03+1] Add some missing @covers tags [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [15:19:21] (03Merged) 10jenkins-bot: Use $this->including() instead of $this->mIncluding [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487640 (owner: 10Fomafix) [15:21:07] (03Merged) 10jenkins-bot: Remove "return true" on hook handler functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/487613 (owner: 10Fomafix) [15:31:47] (03PS3) 10Fomafix: Get config from getConfig() instead of global variable [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 [15:36:00] (03CR) 10Fomafix: "> Such links should already have 'mw-redirect', but removing could be" [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487638 (owner: 10Fomafix) [15:47:58] sjoerddeafwezige: your constant nick changing is disruptive [15:49:20] (03PS2) 10Fomafix: Fix @param tags [core] - 10https://gerrit.wikimedia.org/r/487171 [15:49:22] (03CR) 10Fomafix: Fix @param tags (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487171 (owner: 10Fomafix) [16:22:49] Hi, can anyone merge https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/487583/ please [16:26:57] Nikerabbit: fixed now [16:59:02] (03CR) 10Umherirrender: [C: 03+2] Fix @param tags [core] - 10https://gerrit.wikimedia.org/r/487171 (owner: 10Fomafix) [17:11:40] (03PS1) 10Fomafix: Title: Add null to @return type for getSubpage [core] - 10https://gerrit.wikimedia.org/r/487659 [17:16:03] (03Merged) 10jenkins-bot: Fix @param tags [core] - 10https://gerrit.wikimedia.org/r/487171 (owner: 10Fomafix) [17:18:18] (03CR) 10jenkins-bot: Fix @param tags [core] - 10https://gerrit.wikimedia.org/r/487171 (owner: 10Fomafix) [17:40:50] (03CR) 10D3r1ck01: [C: 03+2] "Thanks for the patch @Fomafix :). I agree and cases are:" [core] - 10https://gerrit.wikimedia.org/r/487659 (owner: 10Fomafix) [17:54:25] (03CR) 10D3r1ck01: [C: 03+2] "Per https://codesearch.wmflabs.org/extensions/?q=global%20%5C%24wgNewestPagesLimit&i=nope&files=&repos=, that was the only occurrence, tha" [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 (owner: 10Fomafix) [17:55:15] (03Merged) 10jenkins-bot: Title: Add null to @return type for getSubpage [core] - 10https://gerrit.wikimedia.org/r/487659 (owner: 10Fomafix) [17:57:33] (03CR) 10jenkins-bot: Title: Add null to @return type for getSubpage [core] - 10https://gerrit.wikimedia.org/r/487659 (owner: 10Fomafix) [17:58:10] (03Merged) 10jenkins-bot: Get config from getConfig() instead of global variable [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487642 (owner: 10Fomafix) [18:03:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Avoid hard coding namespaces, use SRO(::) with class (::class) (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [18:13:28] (03PS3) 10Fomafix: Fix @license tag [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487646 [18:13:43] (03CR) 10Fomafix: Fix @license tag (031 comment) [extensions/NewestPages] - 10https://gerrit.wikimedia.org/r/487646 (owner: 10Fomafix) [18:13:54] (03CR) 10Thiemo Kreuz (WMDE): "As far as I can see, the placement of all this code was intentional. All "static" stuff came first, before the non-static stuff. I can see" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/487570 (owner: 10D3r1ck01) [18:17:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "Thanks for the changes." [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [18:17:43] (03CR) 10Huji: [C: 04-1] Split a methods between logic and output (032 comments) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487644 (https://phabricator.wikimedia.org/T213668) (owner: 10Rxy) [18:18:19] (03PS1) 10Esanders: build: Update eslint-config-wikimedia to 0.10.1 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/487660 [18:20:37] (03CR) 10D3r1ck01: "PS8 applies changes appropriately :), thanks!" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [18:21:02] (03PS8) 10D3r1ck01: Avoid hard coding namespaces, use the ::class constant instead [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 [18:22:31] (03CR) 10jerkins-bot: [V: 04-1] Avoid hard coding namespaces, use the ::class constant instead [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [18:22:59] (03PS9) 10D3r1ck01: Avoid hard coding namespaces, use the ::class constant instead [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 [18:23:39] (03CR) 10D3r1ck01: "PS9 fixes a missing space before closing "]" which is a violation of CC, thanks Jenkins :)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [18:31:55] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Anomie) How about "Greyscale with Alpha" images? https://commons.wikimedia.org/wiki/File:Quillette.png seems to still be ge... [18:48:49] 10MediaWiki-extensions-OAuth, 10User-revi: PHP warning when disabling an OAuth aaplication - https://phabricator.wikimedia.org/T215126 (10revi) [18:50:15] 10MediaWiki-User-management, 10User-revi: Block calendar displays expiry in DMY format in Korean - https://phabricator.wikimedia.org/T205318 (10revi) One thing I noticed in the screenshot is that even the format how we display DMY is also broken. 월 should be behind the M in DMY, not in front of D as it current... [18:56:14] 10MediaWiki-extensions-Babel: Error with dv-0 box display - https://phabricator.wikimedia.org/T215127 (10Epok) [19:14:01] 10MediaWiki-extensions-Babel: Error with dv-0 box display - https://phabricator.wikimedia.org/T215127 (10Epok) 05Open→03Resolved [19:18:10] (03CR) 10Legoktm: "> Patch Set 3: Code-Review+1" [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [19:19:24] 10Internet-Archive, 10video2commons: Video2Commons fails on a particular video: "ERROR: Signature extraction failed" - https://phabricator.wikimedia.org/T215128 (10AlexisJazz) [19:39:49] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Anomie) Also it seems to do the white background with RGB and greyscale images using the tRNS chunk rather than a full alph... [19:42:39] (03CR) 10Umherirrender: Avoid hard coding namespaces, use the ::class constant instead (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [19:43:20] 10MediaWiki-Codesniffer: Assignment to a class variable in an anonymous class incorrectly triggers MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn - https://phabricator.wikimedia.org/T215129 (10Mainframe98) [19:43:46] 10MediaWiki-Codesniffer: Assignment to a class variable in an anonymous class incorrectly triggers MediaWiki.Usage.AssignmentInReturn.AssignmentInReturn - https://phabricator.wikimedia.org/T215129 (10Mainframe98) p:05Triage→03Normal [19:43:50] (03CR) 10Umherirrender: "You should use the array or the string version along the patch set. Not only in one place." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [19:49:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "3200 files with backslash:" [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [19:50:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] Avoid hard coding namespaces, use the ::class constant instead (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [20:10:58] (03CR) 10Umherirrender: [C: 03+2] "Sounds like an easy job for an autofix sniff, if needed, feel free to open a task to standardized the covers tag" [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [20:24:24] (03PS10) 10D3r1ck01: Avoid hard coding namespaces, use the ::class constant instead [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 [20:24:41] (03CR) 10D3r1ck01: "Thanks @Umherirrender and @Thiemo. I've applied changes :)" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/487577 (owner: 10D3r1ck01) [20:28:48] (03Merged) 10jenkins-bot: Add some missing @covers tags [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [20:28:53] (03Merged) 10jenkins-bot: Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [20:31:08] (03CR) 10jenkins-bot: Add some missing @covers tags [core] - 10https://gerrit.wikimedia.org/r/487117 (owner: 10Legoktm) [20:32:33] (03CR) 10jenkins-bot: Add @coversNothing for left over tests and enable sniff [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [20:36:45] (03CR) 10Umherirrender: "Yah, one important excluded sniff is now enabled ;-)" [core] - 10https://gerrit.wikimedia.org/r/487525 (owner: 10Umherirrender) [20:40:48] (03CR) 10Umherirrender: [C: 03+1] IP addresses should be shown LTR (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487332 (https://phabricator.wikimedia.org/T215005) (owner: 10Huji) [20:43:54] 10MediaWiki-extensions-OAuth, 10User-revi: PHP warning when disabling an OAuth aaplication - https://phabricator.wikimedia.org/T215126 (10Tgr) Have you enabled the PHP7 beta feature? [20:44:12] (03CR) 10Huji: IP addresses should be shown LTR (031 comment) [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/487332 (https://phabricator.wikimedia.org/T215005) (owner: 10Huji) [20:44:24] 10MediaWiki-extensions-OAuth, 10User-revi: PHP warning when disabling an OAuth application - https://phabricator.wikimedia.org/T215126 (10Tgr) [20:45:26] 10MediaWiki-extensions-OAuth, 10User-revi: PHP warning when disabling an OAuth application - https://phabricator.wikimedia.org/T215126 (10revi) >>! In T215126#4923474, @Tgr wrote: > Have you enabled the PHP7 beta feature? Yes, forgot to mention that. Didn't test without PHP7 off. [20:50:04] 10MediaWiki-General-or-Unknown, 10Pywikibot: touch.py made changes in page, without flag in RecentCHanges - https://phabricator.wikimedia.org/T112480 (10Dvorapa) @Xqt as a MediaWiki issue we should probably leave this openned [20:50:55] (03CR) 10Gilles: "If you redirect users to xx.m.wikipedia.org, they are using the mobile site, even if they're on a desktop computer. ResourceLoader doesn't" [extensions/ExternalGuidance] - 10https://gerrit.wikimedia.org/r/486472 (https://phabricator.wikimedia.org/T214170) (owner: 10Gilles) [20:56:31] 10MediaWiki-File-management, 10Commons, 10Multimedia: PNG thumbnail looks significantly blurrier than JPG thumbnail - https://phabricator.wikimedia.org/T192744 (10Gilles) Sure, it's very simple to implement. But you're going to end up with a lot of terrible-looking maps and diagrams... I don't think that's a... [20:57:29] 10MediaWiki-General-or-Unknown, 10I18n: The "right-purge" message needs to be updated since it always require confirmation - https://phabricator.wikimedia.org/T215131 (10Ciencia_Al_Poder) [20:59:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/487664 (owner: 10L10n-bot) [21:00:02] 10MediaWiki-General-or-Unknown, 10I18n: The "right-purge" message needs to be updated since it always require confirmation - https://phabricator.wikimedia.org/T215131 (10Ciencia_Al_Poder) [21:00:07] 10MediaWiki-API, 10Patch-For-Review, 10Performance: Require POST in ?action=purge - https://phabricator.wikimedia.org/T135170 (10Ciencia_Al_Poder) [21:03:21] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) Thanks for the test files, the fix looks straightforward at a glance. [21:09:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/487669 (owner: 10L10n-bot) [21:14:51] 10MediaWiki-Email, 10Growth-Team, 10Notifications, 10PHP 7.2 support, and 2 others: PHP warning when disabling an OAuth application - https://phabricator.wikimedia.org/T215126 (10Tgr) The full error is ` ErrorException /usr/share/php/Mail/mimePart.php:314 PHP Warning: count(): Parameter must be an array or... [21:21:51] (03PS1) 10Gilles: Create role for ExternalGuidance extension [vagrant] - 10https://gerrit.wikimedia.org/r/487671 (https://phabricator.wikimedia.org/T214170) [21:22:41] (03CR) 10jerkins-bot: [V: 04-1] Create role for ExternalGuidance extension [vagrant] - 10https://gerrit.wikimedia.org/r/487671 (https://phabricator.wikimedia.org/T214170) (owner: 10Gilles) [21:23:35] (03PS2) 10Gilles: Create role for ExternalGuidance extension [vagrant] - 10https://gerrit.wikimedia.org/r/487671 (https://phabricator.wikimedia.org/T214170) [21:33:28] 10MediaWiki-Email, 10Growth-Team, 10Notifications, 10PHP 7.2 support, and 2 others: PHP warning when disabling an OAuth application - https://phabricator.wikimedia.org/T215126 (10Tgr) I enabled PHP7 on beta, and @-mentioned a test user. The email goes out, there is no error (I tried both HTML and plain tex... [21:46:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/487680 (owner: 10L10n-bot) [21:48:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/487678 (owner: 10L10n-bot) [21:49:54] (03CR) 10Krinkle: [C: 03+2] objectcache: avoid duplicate set() calls with lockTSE when no value is in cache [core] - 10https://gerrit.wikimedia.org/r/487622 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [21:50:03] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/487703 (owner: 10L10n-bot) [21:56:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/487698 (owner: 10L10n-bot) [22:01:40] 10QuickSurveys, 10Research, 10Readers-Web-Backlog (Tracking), 10Surveys: Let me choose whether to present a microsurvey to logged-in or logged-out editors - https://phabricator.wikimedia.org/T186737 (10Capt_Swing) @phuedx @bmansurov thanks. My take: It would be helpful to be able to exclude ALL logged in e... [22:04:47] (03Merged) 10jenkins-bot: objectcache: avoid duplicate set() calls with lockTSE when no value is in cache [core] - 10https://gerrit.wikimedia.org/r/487622 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [22:06:49] (03CR) 10jenkins-bot: objectcache: avoid duplicate set() calls with lockTSE when no value is in cache [core] - 10https://gerrit.wikimedia.org/r/487622 (https://phabricator.wikimedia.org/T203786) (owner: 10Aaron Schulz) [22:09:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/487703 (owner: 10L10n-bot) [22:11:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/487704 (owner: 10L10n-bot) [22:13:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/487710 (owner: 10L10n-bot) [22:14:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/487708 (owner: 10L10n-bot) [22:16:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/487713 (owner: 10L10n-bot) [22:23:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/487718 (owner: 10L10n-bot) [22:25:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/487719 (owner: 10L10n-bot) [22:28:25] 10MediaWiki-extensions-Other, 10User-Jayprakash12345: [Extension:UserGroups] $ is not defined - https://phabricator.wikimedia.org/T215133 (10Jayprakash12345) [22:28:59] (03PS1) 10Jayprakash12345: Use Script File instead of makeInlineScript [extensions/UserGroups] - 10https://gerrit.wikimedia.org/r/487784 (https://phabricator.wikimedia.org/T215133) [22:30:10] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Jayprakash12345: [Extension:UserGroups] $ is not defined - https://phabricator.wikimedia.org/T215133 (10Jayprakash12345) p:05Triage→03High Currently, Extension is broken. [22:31:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/487726 (owner: 10L10n-bot) [22:34:58] (03CR) 10Krinkle: Transpiling (allow safe ES6 usage in src folder) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482386 (https://phabricator.wikimedia.org/T202746) (owner: 10Jdlrobson) [22:35:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/487729 (owner: 10L10n-bot) [22:37:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/487727 (owner: 10L10n-bot) [22:39:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/487734 (owner: 10L10n-bot) [22:43:25] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: can't view the immages - https://phabricator.wikimedia.org/T215134 (10TheBossResik) [22:44:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/487744 (owner: 10L10n-bot) [22:46:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/487735 (owner: 10L10n-bot) [22:48:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/487745 (owner: 10L10n-bot) [22:50:33] (03CR) 10Krinkle: Transpiling (allow safe ES6 usage in src folder) (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482386 (https://phabricator.wikimedia.org/T202746) (owner: 10Jdlrobson) [22:50:42] (03CR) 10Krinkle: Add support for script URLs to mw.loader.using (031 comment) [core] - 10https://gerrit.wikimedia.org/r/487566 (https://phabricator.wikimedia.org/T27962) (owner: 10Evad37) [22:51:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/487742 (owner: 10L10n-bot) [22:53:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/487751 (owner: 10L10n-bot) [22:56:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/487748 (owner: 10L10n-bot) [22:58:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/487757 (owner: 10L10n-bot) [23:00:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/487754 (owner: 10L10n-bot) [23:16:07] (03PS5) 10Jayprakash12345: Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) [23:20:39] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) (owner: 10Jayprakash12345) [23:22:09] (03PS6) 10Jayprakash12345: Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) [23:26:39] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) (owner: 10Jayprakash12345) [23:31:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/487768 (owner: 10L10n-bot) [23:51:39] (03PS6) 10Jayprakash12345: Convert Special:WatchSubpages to OOUI [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/427190 (https://phabricator.wikimedia.org/T192398) [23:52:23] (03CR) 10jerkins-bot: [V: 04-1] Convert Special:WatchSubpages to OOUI [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/427190 (https://phabricator.wikimedia.org/T192398) (owner: 10Jayprakash12345) [23:54:18] (03PS7) 10Jayprakash12345: Convert Special:WatchSubpages to OOUI [extensions/WatchSubpages] - 10https://gerrit.wikimedia.org/r/427190 (https://phabricator.wikimedia.org/T192398)