[00:00:17] (03Abandoned) 10Jdlrobson: Correct the default drop down option in Special:AllMessages [core] - 10https://gerrit.wikimedia.org/r/484311 (https://phabricator.wikimedia.org/T213479) (owner: 10Jdlrobson) [00:01:16] 04(no projects): WMF staff hackathon expectations reading - https://phabricator.wikimedia.org/T214535 (10Rfarrand) [00:01:23] 10MobileFrontend, 10Design (RW-Design-Debt), 10Mobile, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10good first bug: Special:MobileLanguages tweaks (label and margin) - https://phabricator.wikimedia.org/T191562 (10Jdlrobson) [00:03:39] (03CR) 10Jforrester: [C: 03+2] build: Update 'stylelint-config-wikimedia' to v0.5.0 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/486191 (owner: 10VolkerE) [00:04:08] (03PS3) 10Krinkle: Replace 'TablePager' class exclusively by `mw-datatable` [core] - 10https://gerrit.wikimedia.org/r/485516 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [00:04:26] (03CR) 10Mooeypoo: [C: 03+2] "Third time's the charm..." [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) (owner: 10Dbarratt) [00:04:39] (03PS4) 10Krinkle: Replace 'TablePager' class exclusively by `mw-datatable` [core] - 10https://gerrit.wikimedia.org/r/485516 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [00:07:49] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10UI-Standardization-Kanban: mw-datatable/TablePager tables need to be visually updated and aligned to wikitable - https://phabricator.wikimedia.org/T214208 (10Volker_E) [00:10:17] (03CR) 10jerkins-bot: [V: 04-1] build: Use headless Chrome and Firefox for QUnit testing [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [00:10:55] (03CR) 10Thcipriani: [C: 03+2] "SWAT" [extensions/MobileFrontend] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/486146 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:11:00] (03CR) 10Thcipriani: [C: 03+2] "SWAT" [extensions/MobileFrontend] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486147 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:13:52] (03CR) 10Krinkle: Replace sorting classes with better naming convention (031 comment) [core] - 10https://gerrit.wikimedia.org/r/485356 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [00:13:56] (03CR) 10Jforrester: build: Use headless Chrome and Firefox for QUnit testing (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [00:14:27] (03CR) 10Thcipriani: "recheck" [skins/MinervaNeue] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486148 (owner: 10Jdlrobson) [00:15:04] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486148 (owner: 10Jdlrobson) [00:15:26] (03Merged) 10jenkins-bot: Replace extension icons with standard OOUI icons [extensions/Math] - 10https://gerrit.wikimedia.org/r/486175 (https://phabricator.wikimedia.org/T195480) (owner: 10VolkerE) [00:15:28] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/486191 (owner: 10VolkerE) [00:18:15] (03CR) 10Jdlrobson: "Anything else needed here?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485972 (https://phabricator.wikimedia.org/T211691) (owner: 10Jdlrobson) [00:18:20] 10MediaWiki-extensions-Translate, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Wikimedia-production-error: PHP Fatal Error: Argument 2 passed to TranslateHooks::onPageContentLanguage() must be an instance of Language, StubUserLang given - https://phabricator.wikimedia.org/T214517 (10Jdforrester-WMF) 05Ope... [00:19:33] (03CR) 10jenkins-bot: Replace extension icons with standard OOUI icons [extensions/Math] - 10https://gerrit.wikimedia.org/r/486175 (https://phabricator.wikimedia.org/T195480) (owner: 10VolkerE) [00:19:43] (03CR) 10Dbarratt: [C: 04-1] "I think we should just clone the object to prevent mutation." [core] - 10https://gerrit.wikimedia.org/r/486157 (https://phabricator.wikimedia.org/T210739) (owner: 10Anomie) [00:19:50] (03PS3) 10Krinkle: build: Use headless Chrome and Firefox for QUnit testing [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) [00:21:11] (03CR) 10Krinkle: "Seems to fail due to yet another thing writing to HOME:/nonexistent. In this case, Chromium tries to use ~/.pki/nssdb for some kind of SSL" [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [00:21:13] (03CR) 10Krinkle: "So.. I guess we'll have to save this for when we switch over and then quickly merge it. We can't have both working.." [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [00:21:38] (03PS1) 10Bartosz Dziewoński: VE: Load HTML in parallel with modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) [00:23:06] (03Merged) 10jenkins-bot: Add tests to ensure that NamespaceRestrictions are returned from Block APIs. [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) (owner: 10Dbarratt) [00:23:08] (03CR) 10Bartosz Dziewoński: "In fact, it was not squashed. I submitted it now as a separate change: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFronten" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472461 (https://phabricator.wikimedia.org/T209052) (owner: 10Esanders) [00:23:29] (03CR) 10Bartosz Dziewoński: "This is identical to https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/472461 (except for a rebase)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [00:24:53] (03CR) 10Thcipriani: [C: 03+2] "SWAT" [skins/MinervaNeue] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486148 (owner: 10Jdlrobson) [00:24:55] (03Merged) 10jenkins-bot: Explicitly pass in parseHTML [extensions/MobileFrontend] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/486146 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:25:25] (03CR) 10jenkins-bot: Add tests to ensure that NamespaceRestrictions are returned from Block APIs. [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) (owner: 10Dbarratt) [00:25:59] (03Merged) 10jenkins-bot: Explicitly pass in parseHTML [extensions/MobileFrontend] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486147 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:26:14] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [EPIC] AMC Navigation - changes to main menu - https://phabricator.wikimedia.org/T214537 (10ovasileva) p:05Triage→03High [00:27:24] (03CR) 10jerkins-bot: [V: 04-1] build: Use headless Chrome and Firefox for QUnit testing [core] - 10https://gerrit.wikimedia.org/r/486188 (https://phabricator.wikimedia.org/T211784) (owner: 10Krinkle) [00:27:39] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Since this removes the loader.loadModule() call, which shows a loading overlay, there is now no feedback to the user that anything is happ" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [00:28:27] 10MediaWiki-Parser, 10Parsoid: MediaWiki shouldn't assign section ids during tokenization, but instead only when headings are generated - https://phabricator.wikimedia.org/T214538 (10cscott) [00:28:40] (03CR) 10jenkins-bot: Explicitly pass in parseHTML [extensions/MobileFrontend] (wmf/1.33.0-wmf.13) - 10https://gerrit.wikimedia.org/r/486146 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:31:50] (03CR) 10jenkins-bot: Explicitly pass in parseHTML [extensions/MobileFrontend] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486147 (https://phabricator.wikimedia.org/T214451) (owner: 10Jdlrobson) [00:32:52] (03PS2) 10Bartosz Dziewoński: VE: Load HTML in parallel with modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) [00:33:32] (03CR) 10jerkins-bot: [V: 04-1] Overhaul Blockautopromote action [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445986 (https://phabricator.wikimedia.org/T49412) (owner: 10Daimona Eaytoy) [00:33:40] (03CR) 10Bartosz Dziewoński: [C: 03+1] "PS2 restores a loading overlay. Ed, can you +2 if my changes look okay?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [00:33:50] (03Merged) 10jenkins-bot: Restore banners to Wikivoyage project [skins/MinervaNeue] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486148 (owner: 10Jdlrobson) [00:40:11] (03CR) 10jenkins-bot: Restore banners to Wikivoyage project [skins/MinervaNeue] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486148 (owner: 10Jdlrobson) [00:40:26] 10Readers-Web-Backlog: Mobile page issues banner: CSS/styling cleanup - https://phabricator.wikimedia.org/T214526 (10ovasileva) p:05Triage→03Normal [00:43:20] 10MediaWiki-User-management, 10Anti-Harassment (Bet — ב), 10Patch-For-Review: Add tests for NamespaceRestriction enforcement - https://phabricator.wikimedia.org/T204988 (10dbarratt) [00:43:26] 10MediaWiki-User-management, 10Anti-Harassment (Bet — ב), 10Patch-For-Review: Update Block APIs to list namespace blocks - https://phabricator.wikimedia.org/T204989 (10dbarratt) 05Open→03Resolved [00:44:02] 10MediaWiki-extensions-UserMerge, 10Code-Stewardship-Reviews, 10Stewards-and-global-tools: UserMerge: Code Stewardship Review - https://phabricator.wikimedia.org/T204747 (10Jrbranaa) My key takeaway from this discuss is that although we could address the issues/shortcomings of this extension as it is today,... [00:45:07] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: instrumentation - https://phabricator.wikimedia.org/T206719 (10MMiller_WMF) [00:45:11] 10Product-Analytics, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), 10Patch-For-Review: Help panel: Develop Schema - https://phabricator.wikimedia.org/T209982 (10MMiller_WMF) 05Open→03Resolved [00:45:22] 10Readers-Web-Backlog, 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review: [Bug] A large amount of our errors are occurring in iOS Safari - https://phabricator.wikimedia.org/T214451 (10Krinkle) Please beware that passing in `document` as context for `parseHTML` disables the security gu... [00:46:22] 10Readers-Web-Backlog, 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Performance-Team (Radar): [Bug] A large amount of our errors are occurring in iOS Safari - https://phabricator.wikimedia.org/T214451 (10Krinkle) [00:46:24] (03PS4) 10VolkerE: Convert Special:Interwiki to use OOUI [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/288816 (https://phabricator.wikimedia.org/T135332) (owner: 10Sethakill) [00:47:01] (03CR) 10jerkins-bot: [V: 04-1] VE: Load HTML in parallel with modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [00:47:32] (03CR) 10VolkerE: "PS 4 rebased, re-added ids, maxlength, tabindex, size attributes from status quo." [extensions/Interwiki] - 10https://gerrit.wikimedia.org/r/288816 (https://phabricator.wikimedia.org/T135332) (owner: 10Sethakill) [00:57:41] (03CR) 10VolkerE: Replace sorting classes with better naming convention (031 comment) [core] - 10https://gerrit.wikimedia.org/r/485356 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [01:00:04] 10Readers-Web-Backlog, 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Performance-Team (Radar): [Bug] A large amount of our errors are occurring in iOS Safari - https://phabricator.wikimedia.org/T214451 (10Jdlrobson) >Please beware that passing in document as context for parseHTML disables the secu... [01:00:52] 10Advanced Mobile Contributions, 10Epic: [EPIC] AMC Navigation - user menu - https://phabricator.wikimedia.org/T214540 (10ovasileva) p:05Triage→03Normal [01:01:44] (03PS2) 10Aaron Schulz: rdbms: make safeWaitForMasterPos() return false on master connection failure [core] - 10https://gerrit.wikimedia.org/r/486140 [01:02:19] 10MediaWiki-extensions-CodeReview, 10Code-Stewardship-Reviews: CodeReview extension: Code stewardship review - https://phabricator.wikimedia.org/T205482 (10Jrbranaa) If I interpret this correctly, the reason we are looking to undeploy/sunset this extension is because it is no longer actively used for code revi... [01:02:51] 10Advanced Mobile Contributions, 10Epic: [EPIC] AMC Navigation - user menu - https://phabricator.wikimedia.org/T214540 (10ovasileva) [01:03:30] (03PS3) 10Cooltey: [HOLD] Build my contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485346 (https://phabricator.wikimedia.org/T207339) [01:04:27] (03CR) 10jerkins-bot: [V: 04-1] [HOLD] Build my contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485346 (https://phabricator.wikimedia.org/T207339) (owner: 10Cooltey) [01:05:15] 10Design, 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), and 3 others: Bring VE extension icons to OOUI packs and further align them - https://phabricator.wikimedia.org/T195480 (10Volker_E) [01:06:14] (03CR) 10Jdlrobson: [C: 03+2] "Did a wget before and after the change on pages with site banners and wikidata page banners. No difference in the HTML between the two" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:06:38] (03CR) 10Jdlrobson: [C: 03+2] template: Avoid raw HTML parameter for jump link labels [skins/Vector] - 10https://gerrit.wikimedia.org/r/486002 (owner: 10Krinkle) [01:08:29] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [EPIC] AMC Navigation - changes to main menu - https://phabricator.wikimedia.org/T214537 (10ovasileva) [01:10:46] (03Merged) 10jenkins-bot: Start extracting rendering from PHP into Mustache [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:11:08] (03Merged) 10jenkins-bot: template: Remove is_callable check for getIndicators() [skins/Vector] - 10https://gerrit.wikimedia.org/r/486001 (owner: 10Krinkle) [01:11:11] (03Merged) 10jenkins-bot: template: Avoid raw HTML parameter for jump link labels [skins/Vector] - 10https://gerrit.wikimedia.org/r/486002 (owner: 10Krinkle) [01:11:55] (03CR) 10VolkerE: [C: 03+1] "Exciting!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:12:16] (03CR) 10Krinkle: "@James There's a number of client-side only cases where Mustache added undesirable overhead. I haven't personally looked into that, but it" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [01:15:08] 10MediaWiki-General-or-Unknown, 10MediaWiki-Interface, 10Performance-Team, 10Core Platform Team Backlog (Watching / External), 10Epic: Prepare MediaWiki for API-driven frontend - https://phabricator.wikimedia.org/T140664 (10Jdlrobson) [01:20:35] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add a place for users to view a count of all their App Editor Task Contributions - https://phabricator.wikimedia.org/T207339 (10cooltey) I see. Thanks @Charlotte and @schoenbaechler [01:21:04] (03PS3) 10Jdlrobson: OverlayManager: Emit overlay hide events after using #replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485975 (https://phabricator.wikimedia.org/T209714) (owner: 10Bartosz Dziewoński) [01:21:06] (03PS3) 10VolkerE: Replace sorting classes with better naming convention [core] - 10https://gerrit.wikimedia.org/r/485356 (https://phabricator.wikimedia.org/T214218) [01:22:25] 10MediaWiki-Cache, 10MediaWiki Language Extension Bundle, 10Operations, 10Language-Team (Language-2019-January-March), and 5 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10Etonkovidova) @Nikerabbit t... [01:26:53] (03CR) 10Jdlrobson: [C: 03+2] "Only the editor makes use of replaceCurrent and this behaviour is much better than it is in master." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485975 (https://phabricator.wikimedia.org/T209714) (owner: 10Bartosz Dziewoński) [01:29:19] (03CR) 10Jdlrobson: [C: 03+2] "I never liked this hack. I'm glad to see the back of it :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486136 (https://phabricator.wikimedia.org/T168815) (owner: 10Bartosz Dziewoński) [01:29:29] (03PS3) 10Jdlrobson: Redirect after mobile section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484518 (https://phabricator.wikimedia.org/T213120) (owner: 10Esanders) [01:29:53] (03CR) 10Jdlrobson: [C: 03+2] "where did my +2 go.. :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485975 (https://phabricator.wikimedia.org/T209714) (owner: 10Bartosz Dziewoński) [01:35:36] 10Page-Issue-Warnings, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy page issues to enwiki and all remaining projects - https://phabricator.wikimedia.org/T210554 (10ovasileva) Seeing some weirdness on wikivoyage: {F28009746} [01:36:17] 10Design, 10UI-Standardization, 10WMF-Design, 10Tracking, 10UI-Standardization-Kanban: Design shortcomings of WikimediaUI widgets overview (M101) (tracking) - https://phabricator.wikimedia.org/T136371 (10iamjessklein) We should update the Sketch files to include a set of responsive web layouts of the Wik... [01:37:34] (03CR) 10jerkins-bot: [V: 04-1] Redirect after mobile section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484518 (https://phabricator.wikimedia.org/T213120) (owner: 10Esanders) [01:39:18] (03PS2) 10EBernhardson: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 [01:39:20] (03PS2) 10EBernhardson: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 [01:39:22] (03PS1) 10EBernhardson: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 [01:39:26] (03PS1) 10EBernhardson: Create a phpunit mocks directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486197 [01:39:50] (03CR) 10Jdlrobson: [C: 04-1] "Pulled this down and gave it a test and realised it does not actually fix the issue. I am still seeing the scrollbars on Minerva when used" [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/468330 (https://phabricator.wikimedia.org/T213818) (owner: 10Thiemo Kreuz (WMDE)) [01:42:46] (03CR) 10Krinkle: Replace sorting classes with better naming convention (031 comment) [core] - 10https://gerrit.wikimedia.org/r/485356 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [01:43:30] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [01:44:25] (03CR) 10jerkins-bot: [V: 04-1] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [01:44:42] (03CR) 10jerkins-bot: [V: 04-1] Create a phpunit mocks directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486197 (owner: 10EBernhardson) [01:44:44] (03CR) 10Aaron Schulz: "It's not super clear when it's best to return false or error out. I wasn't sure myself. I think master connection failure is bad enough to" [core] - 10https://gerrit.wikimedia.org/r/486140 (owner: 10Aaron Schulz) [01:44:57] (03CR) 10VolkerE: Replace sorting classes with better naming convention (031 comment) [core] - 10https://gerrit.wikimedia.org/r/485356 (https://phabricator.wikimedia.org/T214218) (owner: 10VolkerE) [01:45:36] (03CR) 10Aaron Schulz: rdbms: make safeWaitForMasterPos() return false on master connection failure (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486140 (owner: 10Aaron Schulz) [01:46:30] 10MediaWiki-Interface, 10OOUI (OOjs-UI-0.20.1): Allow skins to use different, custom OOUI themes - https://phabricator.wikimedia.org/T100896 (10Lorentz21) Theme I created: https://github.com/femiwiki/oojs-ui/tree/femiwiki/src/themes/femiwiki and skin I am working on: https://github.com/femiwiki/skin/tree/ooui.... [01:46:46] (03Merged) 10jenkins-bot: mobile.editor: Make edit link always open lead section (0), never first section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486136 (https://phabricator.wikimedia.org/T168815) (owner: 10Bartosz Dziewoński) [01:47:17] (03Merged) 10jenkins-bot: OverlayManager: Emit overlay hide events after using #replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485975 (https://phabricator.wikimedia.org/T209714) (owner: 10Bartosz Dziewoński) [01:49:24] (03PS2) 10EBernhardson: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 [01:49:28] (03Abandoned) 10EBernhardson: Create a phpunit mocks directory [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486197 (owner: 10EBernhardson) [01:50:30] (03PS3) 10EBernhardson: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 [01:50:32] (03PS3) 10EBernhardson: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 [01:52:18] (03CR) 10jenkins-bot: mobile.editor: Make edit link always open lead section (0), never first section [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486136 (https://phabricator.wikimedia.org/T168815) (owner: 10Bartosz Dziewoński) [01:52:54] (03CR) 10jerkins-bot: [V: 04-1] Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [01:53:26] (03CR) 10jenkins-bot: OverlayManager: Emit overlay hide events after using #replaceCurrent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485975 (https://phabricator.wikimedia.org/T209714) (owner: 10Bartosz Dziewoński) [01:54:07] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [01:54:52] (03PS4) 10EBernhardson: Php version improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 [01:55:18] (03CR) 10jerkins-bot: [V: 04-1] Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [01:55:20] (03CR) 10jerkins-bot: [V: 04-1] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [01:55:24] 10MediaWiki-General-or-Unknown: Title::loadFromRow() should return a new instance of Title - https://phabricator.wikimedia.org/T214546 (10dbarratt) [01:55:57] (03CR) 10EBernhardson: Php version improvements (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 (owner: 10EBernhardson) [01:56:25] 10MediaWiki-Special-pages, 10Anti-Harassment, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), and 4 others: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10dbarratt) I created a new iss... [01:56:44] 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-ORES, 10Continuous-Integration-Infrastructure, 10Performance-Team, and 5 others: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7 - https://phabricator.wikimedia.org/T213944 (10Krinkle) 05Open→03Resolved a... [01:57:37] (03PS3) 10EBernhardson: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 [02:01:27] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [02:02:13] (03CR) 10jerkins-bot: [V: 04-1] Php version improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 (owner: 10EBernhardson) [02:05:47] 10Product-Analytics, 10Growth-Team (Current Sprint): Personalized first day: determine the survey's effect on editor activation rate - https://phabricator.wikimedia.org/T212799 (10MMiller_WMF) Thanks, @nettrom_WMF. I think this is exactly what we needed. I added some section headings and an infobox to the pa... [02:06:28] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), and 2 others: Regression: Page history divider is too narrow - https://phabricator.wikimedia.org/T210745 (10Jdlrobson) [02:07:00] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), and 2 others: Regression: Page history divider is too narrow - https://phabricator.wikimedia.org/T210745 (10Jdlrobson) a:03Edtadros [02:07:41] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Create AMC edit tag - https://phabricator.wikimedia.org/T212959 (10Jdlrobson) a:03Edtadros [02:08:48] 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): [EPIC] Reduce the amount of modules in MobileFrontend - https://phabricator.wikimedia.org/T207787 (10Jdlr... [02:09:30] 10Epic, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): [EPIC] Reduce the amount of modules in MobileFrontend - https://phabricator.wikimedia.org/T207787 (10Jdlrobson) [02:09:34] 10Product-Analytics, 10Growth-Team (Current Sprint): Personalized first day: determine the survey's effect on editor activation rate - https://phabricator.wikimedia.org/T212799 (10MMiller_WMF) 05Open→03Resolved [02:09:52] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [02:10:43] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10Regression: [Regression] Menu panel has black background when another drawer is first opened - https://phabricator.wikimedia.org/T211691 (10Jdlrobson) a:05... [02:12:33] 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), and 2 others: [Spike, 8hrs] Discuss OO.EventEmitter usage for Views - https://phabricator.wikimedia.org/T211724 (10... [02:14:30] (03PS1) 10VolkerE: HTMLForm OOUI: Reduce distance between flatlist label and widgets [core] - 10https://gerrit.wikimedia.org/r/486198 [02:18:37] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [02:20:13] (03CR) 10Krinkle: "check experimental" [event-schemas] - 10https://gerrit.wikimedia.org/r/477938 (owner: 10Ppchelko) [02:21:15] (03CR) 10Krinkle: "check experimental" [event-schemas] - 10https://gerrit.wikimedia.org/r/477805 (https://phabricator.wikimedia.org/T206815) (owner: 10Ottomata) [02:21:33] (03CR) 10jenkins-bot: error event 0.0.3, test/event 0.0.2 [event-schemas] - 10https://gerrit.wikimedia.org/r/477805 (https://phabricator.wikimedia.org/T206815) (owner: 10Ottomata) [02:21:57] (03PS8) 10EBernhardson: Print logs generated during unit test when test fails [core] - 10https://gerrit.wikimedia.org/r/485341 [02:22:12] (03CR) 10EBernhardson: Print logs generated during unit test when test fails (037 comments) [core] - 10https://gerrit.wikimedia.org/r/485341 (owner: 10EBernhardson) [02:22:15] (03CR) 10jerkins-bot: [V: 04-1] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [02:22:52] (03PS4) 10EBernhardson: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 [02:23:02] (03PS4) 10EBernhardson: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 [02:26:12] (03CR) 10jerkins-bot: [V: 04-1] Php version improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 (owner: 10EBernhardson) [02:27:40] (03PS1) 10Krinkle: build: Remove unused package.json properties [event-schemas] - 10https://gerrit.wikimedia.org/r/486199 [02:27:51] (03PS1) 10MaxSem: Use MapCacheLRU::getWithSetCallback() [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/486200 (https://phabricator.wikimedia.org/T204781) [02:27:54] (03PS1) 10MaxSem: Tweaks for array operations in non-arrays errors [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/486201 [02:29:08] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [02:31:07] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [02:31:39] (03CR) 10jerkins-bot: [V: 04-1] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [02:34:32] (03PS1) 10Krinkle: test: Fix broken topics.exist test [event-schemas] - 10https://gerrit.wikimedia.org/r/486202 [02:34:47] 10Technical-Tool-Request: Vocabulary assistant for Simple Wikipedia, based on Upgoer Text Editors - https://phabricator.wikimedia.org/T135321 (10Quiddity) [02:35:14] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.33-notes (1.33.0-wmf.12; 2019-01-08), and 2 others: [BUG] GlobalPreferencesFactory emits "PHP Error: in_array() expects parameter 2 to be an array or collection" - https://phabricator.wikimedia.org/T204781 (10MaxSem... [02:35:17] (03CR) 10Krinkle: "check experimental" [event-schemas] - 10https://gerrit.wikimedia.org/r/486202 (owner: 10Krinkle) [02:36:50] (03CR) 10jerkins-bot: [V: 04-1] Print logs generated during unit test when test fails [core] - 10https://gerrit.wikimedia.org/r/485341 (owner: 10EBernhardson) [02:37:57] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 (owner: 10EBernhardson) [02:39:00] (03PS3) 10VolkerE: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) [02:39:27] (03CR) 10VolkerE: "@Krinkle Better?" [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [02:40:20] (03CR) 10Krinkle: "FYI - might be known already, the development settings used in CI log to a directory by default, collected by Jenkins." [core] - 10https://gerrit.wikimedia.org/r/485341 (owner: 10EBernhardson) [02:41:07] (03CR) 10Krinkle: "I think you forgot a 'git add ./something' ;-)" [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [02:44:05] (03PS4) 10VolkerE: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) [02:49:43] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [02:55:28] (03CR) 10jerkins-bot: [V: 04-1] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [03:02:55] (03PS5) 10EBernhardson: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 [03:04:58] (03Abandoned) 10EBernhardson: Php version improvements [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/484592 (owner: 10EBernhardson) [03:05:28] (03CR) 10EBernhardson: "Right, but that reports the logs of 15k+ tests. The point of this here is to capture the logs for the tests that fail, and report them sep" [core] - 10https://gerrit.wikimedia.org/r/485341 (owner: 10EBernhardson) [03:07:55] (03PS5) 10VolkerE: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) [03:17:13] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [03:20:39] (03PS1) 10MaxSem: Password: replace equals() with verify() [core] - 10https://gerrit.wikimedia.org/r/486205 [03:20:41] (03PS1) 10MaxSem: WIP: Add support for Argon2 password hashing [core] - 10https://gerrit.wikimedia.org/r/486206 [03:25:49] (03CR) 10Jdlrobson: [C: 03+1] Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [03:27:39] 10MediaWiki-Templates: Method of generating a list of headings for a page - https://phabricator.wikimedia.org/T214464 (10AlexisJazz) [03:36:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add support for Argon2 password hashing [core] - 10https://gerrit.wikimedia.org/r/486206 (owner: 10MaxSem) [03:37:47] (03PS6) 10VolkerE: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) [03:38:38] (03CR) 10Krinkle: [C: 03+2] Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [03:50:55] 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10alexhollender) [03:55:45] (03Merged) 10jenkins-bot: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [03:59:02] (03CR) 10jenkins-bot: Special:AllMessages: Visually hide repeating text [core] - 10https://gerrit.wikimedia.org/r/472920 (https://phabricator.wikimedia.org/T209253) (owner: 10VolkerE) [04:05:10] 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10alexhollender) [04:05:32] 10Readers-Web-Backlog: Reduce height of mobile page issues banner - https://phabricator.wikimedia.org/T214549 (10alexhollender) p:05Triage→03Normal [04:16:14] 10Readers-Web-Backlog: Learn more white flash when opening navigation menu - https://phabricator.wikimedia.org/T214550 (10alexhollender) p:05Triage→03Normal [04:21:19] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC page/talk toggle v1: Talk tab at the top of page for AMC users - https://phabricator.wikimedia.org/T212216 (10alexhollender) @Jdlrobson ready... [04:30:03] (03CR) 10BPirkle: "> Patch Set 6: Code-Review+1" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [04:46:01] 10Accessibility, 10MediaWiki-Special-pages, 10UI-Standardization, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review: Visually hide redundant legend on special pages - https://phabricator.wikimedia.org/T209253 (10Volker_E) p:05Triage→03Normal [04:56:10] 10TimedMediaHandler, 10TimedMediaHandler-TimedText, 10Regression: Text on multiple lines is not shown for video subtitles - https://phabricator.wikimedia.org/T200145 (10Opencooper) It's been half a year since this was opened and multi-line subtitles are still broken. Any chance this could be made higher prio... [04:59:31] (03PS2) 10VolkerE: Use system font stack as sans-serif choice [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/484976 (https://phabricator.wikimedia.org/T175877) [05:12:15] 10Product-Analytics, 10Tor: Estimate the rate of pageviews made using Tor - https://phabricator.wikimedia.org/T214449 (10Tbayer) @faidon pointed out that one might also be able to use the [[https://www.maxmind.com/en/solutions/geoip2-enterprise-product-suite/anonymous-ip-database|data MaxMind offers about this... [05:17:02] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: 'Wiki' spelling in Urdu is wrong on some projects - https://phabricator.wikimedia.org/T214290 (10Tulsi_Bhagat) Scheduled to be deployed during [[https://wikitech.wikimedia.org/w/index.php?diff=1814457|European Mid-day SWAT]] o... [05:33:59] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:34:38] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:35:27] 04(no projects): Four revisions that were modified using revision deletion did not create any admin RD logs... - https://phabricator.wikimedia.org/T214551 (10Oshwah) [05:35:46] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:35:53] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:36:28] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:36:41] 04(no projects): DerivedPageDataUpdater emits "PHP Notice: Undefined index: 1" from LinksUpdate.php - https://phabricator.wikimedia.org/T204756 (10Krinkle) [05:39:48] 04(no projects): Four revisions that were modified using revision deletion did not create any admin RD logs... - https://phabricator.wikimedia.org/T214551 (10Oshwah) Please note that since creating this phab ticket, [[Dunkin']] was moved back to its original title, [[Dunkin' Donuts]]. [05:48:04] 10MediaWiki-Revision-deletion: Four revisions that were modified using revision deletion did not create any admin RD logs... - https://phabricator.wikimedia.org/T214551 (10Ammarpad) [05:50:54] (03PS7) 10Krinkle: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [05:52:21] (03CR) 10Krinkle: "Sorry for that rabbit hole, should've known that. Yeah, that's a debate for another day. As far as I'm concerned, it's totally find to add" [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [05:55:45] (03CR) 10Krinkle: "Spotted a regression that for some reason Jenkins isn't failing the build over, PHPUnit is meant to fail on PHP warnings:" [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [05:56:16] 10MediaWiki-Revision-deletion: RevisionDeletion log does not move to new title after page move. - https://phabricator.wikimedia.org/T214551 (10Ammarpad) [05:56:18] (03PS8) 10Krinkle: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:01:25] 10MediaWiki-Core-Tests, 10Continuous-Integration-Config, 10Wikimedia-production-error (Shared Build Failure): Jenkins build for MediaWiki should fail when "PHP Warning" is emitted - https://phabricator.wikimedia.org/T214552 (10Krinkle) [06:06:07] (03CR) 10Krinkle: [C: 03+2] Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:06:33] (03CR) 10Krinkle: [C: 03+2] "It still didn't pick up the coverage, dunno why. Oh well." [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:08:30] (03CR) 10Krinkle: [C: 03+2] "Ah, it doesn't pick it up because it isn't even running this test:" [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:09:14] (03PS9) 10Krinkle: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:09:46] 10MediaWiki-Revision-deletion: RevisionDeletion log does not move to new title after page move. - https://phabricator.wikimedia.org/T214551 (10Ammarpad) @Oshwah, If I understand correctly, the logs //were there//, only that they were //not moved to the new title// after a page move. [06:22:05] (03CR) 10Krinkle: rdbms: make safeWaitForMasterPos() return false on master connection failure (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486140 (owner: 10Aaron Schulz) [06:22:35] (03CR) 10Krinkle: [C: 03+2] "@Bill patch-coverage wasn't able to find the test suite due to the class name typo. Fixed now :)" [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [06:28:12] 10MediaWiki-Core-Tests, 10Continuous-Integration-Config, 10Wikimedia-production-error (Shared Build Failure): Jenkins build for MediaWiki should fail when "PHP Warning" is emitted - https://phabricator.wikimedia.org/T214552 (10Legoktm) The warning comes before the "PHPUnit 6.5.13" line, which I think means i... [06:28:59] (03CR) 10MaxSem: [C: 03+2] test: Fix broken topics.exist test [event-schemas] - 10https://gerrit.wikimedia.org/r/486202 (owner: 10Krinkle) [06:29:19] 10MediaWiki-Debug-Logger, 10Operations, 10Performance-Team: Set up request profiling for PHP 7 - https://phabricator.wikimedia.org/T206152 (10Krinkle) [06:29:21] (03Merged) 10jenkins-bot: test: Fix broken topics.exist test [event-schemas] - 10https://gerrit.wikimedia.org/r/486202 (owner: 10Krinkle) [06:29:59] 10MediaWiki-Debug-Logger, 10Operations, 10Performance-Team: Set up request profiling for PHP 7 - https://phabricator.wikimedia.org/T206152 (10Krinkle) With it 3545a906d6b1 deployed (by @tstarling). I'll try this again tomorrow. [06:30:08] (03CR) 10MaxSem: [C: 03+2] build: Remove unused package.json properties [event-schemas] - 10https://gerrit.wikimedia.org/r/486199 (owner: 10Krinkle) [06:30:30] (03Merged) 10jenkins-bot: build: Remove unused package.json properties [event-schemas] - 10https://gerrit.wikimedia.org/r/486199 (owner: 10Krinkle) [06:37:40] (03CR) 10jerkins-bot: [V: 04-1] Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [07:19:32] 10MediaWiki-Special-pages: MediaWiki:Passwordpolicies-policy-blockattacker not defined - https://phabricator.wikimedia.org/T214554 (10Ammarpad) [07:21:20] 10Shape Expressions, 10Patch-For-Review: Nuke GitHub Repo - https://phabricator.wikimedia.org/T214295 (10Tarrow) 05Open→03Resolved a:03Tarrow Github Nuked [07:21:31] 10MediaWiki-Cache, 10MediaWiki Language Extension Bundle, 10Operations, 10Language-Team (Language-2019-January-March), and 5 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10elukey) @Etonkovidova hi! I... [07:22:46] 10Design, 10UI-Standardization, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10UI-Standardization-Kanban: Update font stack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877 (10Volker_E) a:05Nirzar→03Volker_E [07:23:01] 10MediaWiki-Email, 10Growth-Team, 10Thanks: Include a link in the email to the profile of the person who thanked me for a page creation - https://phabricator.wikimedia.org/T214485 (10orschiro) @Ammarpad thanks! That's what I am going to do next time. Still would be nice if a link was directly provided by... [07:23:40] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10Volker_E) [07:23:43] 10UI-Standardization, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10UI-Standardization-Kanban: UI consistency issues of Variation C - https://phabricator.wikimedia.org/T212479 (10Volker_E) 05Open→03Resolved [07:35:53] 10Library-Card-Platform: Fix partner application graph ranges and labels - https://phabricator.wikimedia.org/T171159 (10AVasanth_WMF) https://github.com/WikipediaLibrary/TWLight/pull/216 [07:41:38] 10MediaWiki-ResourceLoader, 10Performance-Team: Official text for load.php - https://phabricator.wikimedia.org/T214555 (10Sunpriat) [07:43:42] 10MediaWiki-ResourceLoader, 10Performance-Team: Official text for load.php - https://phabricator.wikimedia.org/T214555 (10Sunpriat) [07:45:04] 10MediaWiki-ResourceLoader, 10Performance-Team: Official text for load.php - https://phabricator.wikimedia.org/T214555 (10Legoktm) 05Open→03Declined It's part of {T22281}. [07:50:01] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: MediaWiki needs more easter eggs - https://phabricator.wikimedia.org/T22281 (10Sunpriat) That request is not closed. I disagree with the closure while that request is open.This is visible to many. This is not a joke. [07:51:42] 10TimedMediaHandler, 10TimedMediaHandler-TimedText, 10Regression: Text on multiple lines is not shown for video subtitles - https://phabricator.wikimedia.org/T200145 (10TheDJ) > It's been half a year since this was opened and multi-line subtitles are still broken. Any chance this could be made higher priorit... [07:56:34] 10Accessibility, 10SDC General, 10Wikidata: Images (on articles, on file/category pages, and in the media viewer) should default to use their structured data caption as alt text when available - https://phabricator.wikimedia.org/T213585 (10Abbe98) I'm very aware of the fact that Captions isn't ideal for alt... [08:08:05] 04(no projects): Promote GNU LibreJS compliance - https://phabricator.wikimedia.org/T107144 (10Sunpriat) {F28012461} [08:08:34] 10MediaWiki-General-or-Unknown: Title::loadFromRow() should return a new instance of Title - https://phabricator.wikimedia.org/T214546 (10daniel) I think that would make the problem worse. Either all of the factory methods in Title should return the cached instance, or none of them should. This is why mutable "... [08:10:37] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: MediaWiki needs more easter eggs - https://phabricator.wikimedia.org/T22281 (10Reedy) >>! In T22281#4904867, @Sunpriat wrote: > This request is not closed. I do not agree with the closure T214555 while this request is open. This is visible to many. T... [08:16:12] (03CR) 10Thiemo Kreuz (WMDE): "Can you provide a screenshot please? I was fixed for me in all browsers I tested it with." [extensions/ImageMap] - 10https://gerrit.wikimedia.org/r/468330 (https://phabricator.wikimedia.org/T213818) (owner: 10Thiemo Kreuz (WMDE)) [08:20:44] (03CR) 10Thiemo Kreuz (WMDE): Document Uri.js constructor and methods throwing Errors (032 comments) [core] - 10https://gerrit.wikimedia.org/r/486160 (owner: 10Thiemo Kreuz (WMDE)) [08:20:52] (03PS2) 10Thiemo Kreuz (WMDE): Document Uri.js constructor and methods throwing Errors [core] - 10https://gerrit.wikimedia.org/r/486160 [08:22:03] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: MediaWiki needs more easter eggs - https://phabricator.wikimedia.org/T22281 (10Legoktm) >>! In T22281#4904867, @Sunpriat wrote: > This is visible to many. The text you complained about on T214555 should never be seen by normal users unless they inte... [08:22:36] (03PS3) 10Thiemo Kreuz (WMDE): Document Uri.js constructor and methods throwing Errors [core] - 10https://gerrit.wikimedia.org/r/486160 [08:32:01] 04(no projects): deployment-prometheus01 - https://phabricator.wikimedia.org/T214558 (10dcausse) [08:33:04] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I'm afraid I did not explained well enough why I believe the code is broken. Short version:" (033 comments) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/468682 (https://phabricator.wikimedia.org/T203531) (owner: 10MGChecker) [08:39:31] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10Patch-For-Review, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Marostegui) [08:40:26] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2019), 10Epic: Community Relations support for the help panel project - https://phabricator.wikimedia.org/T213547 (10Trizek-WMF) [08:42:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Makes a lot of sense! Thank you very much, especially for the carefully crafted and very helpful commit message!" [core] - 10https://gerrit.wikimedia.org/r/483994 (owner: 10Purdeaandrei) [08:43:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Fix typo "occured" instead of "occurred" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/485841 (https://phabricator.wikimedia.org/T214373) (owner: 10Zppix) [08:48:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I like these additions very much. I make use of "the" very much myself. But I'm not a native speaker, and I'm actually not sure if this is" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/486129 (owner: 10Zppix) [08:49:34] 10ContentTranslation, 10Language-Team (Language-2019-January-March): CX2: Should not transform named HTML entites into numeric HTML entities - https://phabricator.wikimedia.org/T213275 (10santhosh) a:03santhosh [08:54:55] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2019), 10Epic: Community Relations support for the help panel project - https://phabricator.wikimedia.org/T213547 (10Trizek-WMF) [08:57:37] (03Merged) 10jenkins-bot: Make sure database update succeeds from older database versions too. [core] - 10https://gerrit.wikimedia.org/r/483994 (owner: 10Purdeaandrei) [08:57:39] (03Merged) 10jenkins-bot: Fix typo "occured" instead of "occurred" [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/485841 (https://phabricator.wikimedia.org/T214373) (owner: 10Zppix) [08:57:50] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10Patch-For-Review, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Marostegui) [08:58:25] (03PS1) 10Daimona Eaytoy: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 [08:58:51] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10Patch-For-Review, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Marostegui) s2 eqiad progress [] labsdb1011 [] labsdb1010 [] labsdb1009 [] dbstore1004 [] dbstore1002 [] db1125 [] db1122... [08:59:02] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10Patch-For-Review, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Marostegui) [09:01:09] (03CR) 10jenkins-bot: Make sure database update succeeds from older database versions too. [core] - 10https://gerrit.wikimedia.org/r/483994 (owner: 10Purdeaandrei) [09:02:11] (03CR) 10Thiemo Kreuz (WMDE): ext.ores.highlighter: Fix minor memory alloc (032 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/485139 (owner: 10Krinkle) [09:03:01] (03PS2) 10Daimona Eaytoy: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 [09:03:58] (03PS3) 10Daimona Eaytoy: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 [09:04:33] 10UI-Standardization, 10Social-Tools, 10SocialProfile: SocialProfile: Convert UserProfile special page forms to OOUI + HTMLForm - https://phabricator.wikimedia.org/T152312 (10Gopavasanth) [09:04:37] 10UI-Standardization, 10Social-Tools, 10SocialProfile, 10Patch-For-Review: SocialProfile: Convert Special:EditProfile to OOUI + HTMLForm - https://phabricator.wikimedia.org/T152334 (10Gopavasanth) 05Open→03Resolved As per the Change-Id: I831e84538ff6c65f2621cbb788a117483bac4ac5 [09:05:15] 10UI-Standardization, 10Social-Tools, 10SocialProfile: SocialProfile: Convert Special:EditProfile to OOUI + HTMLForm - https://phabricator.wikimedia.org/T152334 (10Gopavasanth) [09:06:09] (03CR) 10Daimona Eaytoy: [C: 04-1] ">" (036 comments) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/429464 (owner: 10Daimona Eaytoy) [09:11:25] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile: History links on mobile Special:RecentChanges link to article page instead of Special:History - https://phabricator.wikimedia.org/T214531 (10Jdrewniak) p:05Triage→03Normal [09:14:13] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Removing unneded globals (031 comment) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/478445 (owner: 10Lokal Profil) [09:15:26] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile: History links on mobile Special:RecentChanges link to article page instead of Special:History - https://phabricator.wikimedia.org/T214531 (10Jdrewniak) Thanks for the bug report. We currently don't officially support the Recent Changes page on mobi... [09:16:26] 10MediaWiki-Database, 10DBA, 10Core Platform Team Backlog (Watching / External), 10Performance-Team (Radar), 10Wikimedia-Incident: Fix mediawiki heartbeat model, change pt-heartbeat model to not use super-user, avoid SPOF and switch automatically to the real mast... - https://phabricator.wikimedia.org/T172497 [09:16:38] (03PS17) 10Daimona Eaytoy: Overhaul Blockautopromote action [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445986 (https://phabricator.wikimedia.org/T49412) [09:16:55] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Swap array keys to avoid unindexed key access [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/485232 (owner: 10Umherirrender) [09:17:54] 10MobileFrontend, 10Advanced Mobile Contributions, 10Mobile: History links on mobile Special:RecentChanges link to article page instead of Special:History - https://phabricator.wikimedia.org/T214531 (10Jdrewniak) [09:17:56] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 3 others: Enable new RC on mobile - https://phabricator.wikimedia.org/T178194 (10Jdrewniak) [09:19:19] (03Merged) 10jenkins-bot: Removing unneded globals [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/478445 (owner: 10Lokal Profil) [09:19:59] 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Technical-Debt: Store (including Parsoid version number) for HTML Flow content - https://phabricator.wikimedia.org/T209114 (10kostajh) a:03kostajh [09:20:51] (03Merged) 10jenkins-bot: Swap array keys to avoid unindexed key access [extensions/PagedTiffHandler] - 10https://gerrit.wikimedia.org/r/485232 (owner: 10Umherirrender) [09:21:04] 10Wikidocumentaries: Linking - https://phabricator.wikimedia.org/T212765 (10Susannaanas) [09:22:05] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Extract pageIssues.js view code - https://phabricator.wikimedia.org/T212376 (10Jdrewniak) [09:25:59] 10Wikidocumentaries: Docker maintenance - https://phabricator.wikimedia.org/T214564 (10Susannaanas) [09:29:45] 10Wikidocumentaries: MediaWiki tasks - https://phabricator.wikimedia.org/T210230 (10Susannaanas) [09:29:47] 10Wikidocumentaries: Architecture - https://phabricator.wikimedia.org/T212770 (10Susannaanas) [09:30:20] (03PS1) 10WMDE-Fisch: Enable reference popups by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486230 [09:30:36] 04(no projects): Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Oshwah) [09:32:15] 10Wikidocumentaries: User account tasks - https://phabricator.wikimedia.org/T197969 (10Susannaanas) [09:35:28] 10Wikidocumentaries: Storing user profiles - https://phabricator.wikimedia.org/T213224 (10Susannaanas) [09:36:37] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10Jdrewniak) [09:36:48] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10Jdrewniak) p:05Triage→03Normal [09:37:10] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Reduce height of mobile page issues banner - https://phabricator.wikimedia.org/T214549 (10Jdrewniak) [09:37:37] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Learn more white flash when opening navigation menu - https://phabricator.wikimedia.org/T214550 (10Jdrewniak) [09:38:10] 10Wikidocumentaries: Bugs and tasks in links - https://phabricator.wikimedia.org/T213457 (10Susannaanas) [09:38:51] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Mobile page issues banner: CSS/styling cleanup - https://phabricator.wikimedia.org/T214526 (10Jdrewniak) [09:39:41] 10Wikidocumentaries: Create a sitemap for Wikidocumentaries topics - https://phabricator.wikimedia.org/T209609 (10Susannaanas) [09:40:30] 10Wikidocumentaries: Create a sitemap for Wikidocumentaries topics - https://phabricator.wikimedia.org/T209609 (10Susannaanas) a:03TuukkaH [09:41:36] 10MediaWiki-Parser, 10Parsoid, 10TemplateStyles: TemplateStyles breaks a paragraph if a file is inserted inline - https://phabricator.wikimedia.org/T208901 (10Great_Brightstar) I found a workaround for this. you can make use of tag surrounding tag to inject the TemplateStyles. In... [09:41:53] 10Wikidocumentaries: Linking - https://phabricator.wikimedia.org/T212765 (10Susannaanas) [09:43:34] (03PS3) 10Fomafix: Add typehints to function parameters [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/479973 [09:45:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Enable reference popups by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486230 (owner: 10WMDE-Fisch) [09:46:18] (03CR) 10D3r1ck01: Removing unneded globals (031 comment) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/478445 (owner: 10Lokal Profil) [09:55:38] 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10RESTBase, 10Readers-Web-Backlog (Tracking): Content of unaccepted pending revisions show up in RESTBase APIs - https://phabricator.wikimedia.org/T209936 (10Username_Needed) [09:56:30] (03PS18) 10Daimona Eaytoy: Add new complete unit tests for most variables [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/473456 (https://phabricator.wikimedia.org/T201193) [10:08:57] 10WMEE Content: Omadus "ELNET ID" Wikidatasse - https://phabricator.wikimedia.org/T210154 (10reosarevok) 05Open→03Resolved https://www.wikidata.org/wiki/Property:P6394 [10:10:46] 10WMEE IT projects: ELNET ID Wikidata bot - https://phabricator.wikimedia.org/T214568 (10reosarevok) [10:11:08] 10WMEE IT projects: ELNET ID Wikidata bot - https://phabricator.wikimedia.org/T214568 (10reosarevok) p:05Triage→03Normal [10:11:28] (03PS1) 10Daimona Eaytoy: Start making APFData members private [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486239 [10:13:05] (03CR) 10Fomafix: [C: 04-1] Add client side click to undo on thank (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [10:14:26] (03PS8) 10Daimona Eaytoy: Add doc for every class member [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/472458 [10:14:38] (03PS1) 10Pboehm: Circumvent apparent LDAP binding for unknown users [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/486240 [10:19:04] (03PS9) 10Daimona Eaytoy: Restore (temporarily?) unit tests for CachingParser and fix it [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454557 (https://phabricator.wikimedia.org/T201193) [10:25:35] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10Patch-For-Review: CX2: Should not transform named HTML entites into numeric HTML entities - https://phabricator.wikimedia.org/T213275 (10santhosh) p:05Triage→03Normal [10:28:58] 04(no projects): Change Username - https://phabricator.wikimedia.org/T213945 (10Aklapper) 05Stalled→03Declined Unfortunately closing this report as no further information has been provided. @Baloch007: After you have provided the information asked for and if this still happens, please set the status of thi... [10:30:47] 04(no projects): WMF staff hackathon expectations reading - https://phabricator.wikimedia.org/T214535 (10Aklapper) @Rfarrand: Any context / project tag, please? :) [10:31:41] 10WMEE IT projects: ELNET ID Wikidata bot - https://phabricator.wikimedia.org/T214568 (10reosarevok) https://github.com/notconfusing/WikidataVIAFbot/pull/1 - vaatame, kas sobib [10:32:45] (03PS1) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) [10:33:19] (03PS2) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) [10:34:32] (03PS1) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [10:37:00] (03PS26) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [10:37:28] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01) p:05Triage→03Normal a:03D3r1ck01 [10:40:49] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [10:42:08] (03PS1) 10Thiemo Kreuz (WMDE): Rewrite title module to preserve all link's #fragments [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) [10:44:10] (03PS3) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) [10:44:31] (03CR) 10Thiemo Kreuz (WMDE): Rewrite title module to preserve all link's #fragments (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [10:45:20] (03PS4) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) [10:47:09] (03CR) 10Pmiazga: Feature management should be aware of user modes (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484729 (https://phabricator.wikimedia.org/T211197) (owner: 10Pmiazga) [10:47:11] 10MediaWiki-Database, 10DBA, 10Core Platform Team Backlog (Watching / External), 10Performance-Team (Radar), 10Wikimedia-Incident: Fix mediawiki heartbeat model, change pt-heartbeat model to not use super-user, avoid SPOF and switch automatically to the real mast... - https://phabricator.wikimedia.org/T172497 [10:48:39] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [10:49:07] (03PS5) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) [10:50:11] 10MediaWiki-Database, 10DBA, 10Core Platform Team Backlog (Watching / External), 10Performance-Team (Radar), 10Wikimedia-Incident: Fix mediawiki heartbeat model, change pt-heartbeat model to not use super-user, avoid SPOF and switch automatically to the real mast... - https://phabricator.wikimedia.org/T172497 [10:53:04] (03PS2) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [10:54:35] (03PS27) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [10:55:39] 10MediaWiki-General-or-Unknown: Article Names do not allow changes - https://phabricator.wikimedia.org/T214433 (10hashar) 05Open→03Invalid Sorry there is no information to handle this bug report. [10:55:59] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Pictures don't seem to be working properly for any of the entries - https://phabricator.wikimedia.org/T214574 (10Raifu_for_Lifu) 05Open→03Invalid Thanks for reporting this, however Wikimedia cannot do anything about problems on other websites. Please r... [10:56:50] (03CR) 10DCausse: [C: 03+2] MIME: Re-classify DjVu files as OFFICE, like PDFs, and not as BITMAP [core] - 10https://gerrit.wikimedia.org/r/482067 (https://phabricator.wikimedia.org/T212852) (owner: 10Jforrester) [11:01:19] 04(no projects): Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Thryduulf) Noting that the behaviour is (unsurprisingly) the same in Chromium and that the workaround of replacing the ? in the url with %3f exists... [11:04:57] 10Wikimedia-Site-requests, 10Patch-For-Review: Create AUTHOR namespace in Sanskrit Wikisource - https://phabricator.wikimedia.org/T214553 (10Aklapper) (Removing #Wikisource tag: [Do not report language specific tasks under this project](https://phabricator.wikimedia.org/project/profile/1117/).) [11:09:41] (03PS3) 10DCausse: Add phrase suggest fixtures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 [11:09:43] (03PS11) 10DCausse: Refactor phrase suggest [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/482872 (https://phabricator.wikimedia.org/T213098) [11:09:45] (03PS10) 10DCausse: Remove deprecated code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/483138 [11:10:16] 10MediaWiki-Special-pages, 10Wikimedia-production-error: Fatal MWNamespace exception on Special:Contributions when given namespace is a negative number - https://phabricator.wikimedia.org/T150324 (10hashar) Seems calls to `MWNamespace::isMethodValidFor()` usually originate from `QueryPage::reallyDoQuery()` (wh... [11:10:25] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [11:10:53] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [11:11:23] (03Merged) 10jenkins-bot: MIME: Re-classify DjVu files as OFFICE, like PDFs, and not as BITMAP [core] - 10https://gerrit.wikimedia.org/r/482067 (https://phabricator.wikimedia.org/T212852) (owner: 10Jforrester) [11:11:51] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) [11:11:56] (03PS3) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [11:12:43] (03PS28) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [11:13:45] (03CR) 10jenkins-bot: MIME: Re-classify DjVu files as OFFICE, like PDFs, and not as BITMAP [core] - 10https://gerrit.wikimedia.org/r/482067 (https://phabricator.wikimedia.org/T212852) (owner: 10Jforrester) [11:21:04] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 (owner: 10DCausse) [11:23:13] (03CR) 10D3r1ck01: "I must be making some mistake as coverage has not increased :(" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [11:23:41] (03CR) 10D3r1ck01: "This line is still not being executed despite the fact that $msgObj is null." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [11:25:44] 04(no projects): Promote GNU LibreJS compliance - https://phabricator.wikimedia.org/T107144 (10Aklapper) @Sunpriat: Attaching random images without any comment to tasks which have been closed for years is not helpful. Please do not do that. [11:25:48] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) Changelog: - Added missing more icon to F28013717 (@Cooltey) - Updated... [11:26:09] 10Discovery-Search (Current work): Review Manually re-built Hebmorph plugin - https://phabricator.wikimedia.org/T214439 (10dcausse) Thanks! [11:26:21] 10Discovery-Search (Current work): Review Manually re-built Hebmorph plugin - https://phabricator.wikimedia.org/T214439 (10dcausse) p:05Triage→03Normal [11:27:12] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [11:27:30] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) [11:30:12] (03CR) 10Cindy-the-browser-test-bot: [C: 03+1] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/482872 (https://phabricator.wikimedia.org/T213098) (owner: 10DCausse) [11:31:35] (03CR) 10DCausse: [C: 03+2] "re-apply Stas' +2" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 (owner: 10DCausse) [11:33:42] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) = Design | {F28013731} | {F28013738} 👉 **[Link to screens on Zeplin](https://app.z... [11:34:32] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [11:35:07] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [11:36:24] 10Readers-Web-Backlog, 10Performance-Team (Radar): Update ReadingDepth instrumentation to avoid deprecated schema module (blocks loads event) - https://phabricator.wikimedia.org/T214444 (10phuedx) This should only involve changing https://github.com/wikimedia/mediawiki-extensions-WikimediaEvents/blob/db66eac96... [11:37:18] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Show lists + list items in same list based on search term - https://phabricator.wikimedia.org/T214505 (10schoenbaechler) [11:37:42] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [11:38:27] (03CR) 10D3r1ck01: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [11:40:06] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Contextual actions for list item - https://phabricator.wikimedia.org/T214506 (10schoenbaechler) [11:41:39] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) [11:42:12] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Contextual actions for list item - https://phabricator.wikimedia.org/T214506 (10schoenbaechler) [11:42:19] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Show lists + list items in same list based on search term - https://phabricator.wikimedia.org/T214505 (10schoenbaechler) [11:42:44] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [11:44:47] 10MediaWiki-Special-pages, 10I18n: MediaWiki:Passwordpolicies-policy-blockattacker not defined - https://phabricator.wikimedia.org/T214554 (10Peachey88) [11:45:42] 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-ORES, 10Continuous-Integration-Infrastructure, 10Performance-Team, and 5 others: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7 - https://phabricator.wikimedia.org/T213944 (10zeljkofilipin) 05Resolved→03O... [11:46:03] (03Merged) 10jenkins-bot: Add phrase suggest fixtures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 (owner: 10DCausse) [11:46:42] (03PS1) 10ItSpiderman: Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/486265 [11:49:06] 10Phabricator: Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10Sebastian_Berlin-WMSE) [11:52:20] 10Discovery, 10Discovery-Search (Current work), 10Patch-For-Review: Add Nori (Korean) configuration to AnalysisConfigBuilder - https://phabricator.wikimedia.org/T206874 (10dcausse) a test package with the korean analyzer is available here: https://people.wikimedia.org/~dcausse/wmf-elasticsearch-search-plugin... [11:52:39] 10Discovery, 10Discovery-Search (Current work): Add Nori (Korean) configuration to AnalysisConfigBuilder - https://phabricator.wikimedia.org/T206874 (10dcausse) [11:54:02] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) [11:55:01] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [11:58:34] (03CR) 10jenkins-bot: Add phrase suggest fixtures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 (owner: 10DCausse) [11:59:55] (03PS1) 10Daimona Eaytoy: Add help links for throttle groups [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486268 [12:00:05] (03CR) 10jenkins-bot: Add phrase suggest fixtures [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/485225 (owner: 10DCausse) [12:02:16] 10MediaWiki-extensions-Newsletter, 10MediaWiki-extensions-ORES, 10Continuous-Integration-Infrastructure, 10Performance-Team, and 5 others: Jenkins jobs for npm-test fail on project with deps on node-gyp which requires python2.7 - https://phabricator.wikimedia.org/T213944 (10zeljkofilipin) ` integration/con... [12:08:12] (03CR) 10MarcoAurelio: "This change is ready for review." [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/485904 (https://phabricator.wikimedia.org/T189982) (owner: 10MarcoAurelio) [12:09:08] 10Design, 10CX-mobile, 10Epic: Design the translation experience on mobile - https://phabricator.wikimedia.org/T132900 (10Pginer-WMF) In [[ https://www.mediawiki.org/wiki/Topic:Usny1iyw28emf442 | a recent conversation ]] a user with experience using the current Content Translation on a mobile device shared t... [12:13:21] 10MediaWiki-Special-pages, 10I18n: MediaWiki:Passwordpolicies-policy-blockattacker not defined - https://phabricator.wikimedia.org/T214554 (10MarcoAurelio) [12:14:20] (03CR) 10DCausse: [C: 03+2] "re-apply +2" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/482872 (https://phabricator.wikimedia.org/T213098) (owner: 10DCausse) [12:14:33] (03Abandoned) 10MarcoAurelio: Add 'massmessage-optout-category' as tracking category [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/485681 (https://phabricator.wikimedia.org/T213911) (owner: 10MarcoAurelio) [12:14:58] (03CR) 10jerkins-bot: [V: 04-1] Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 (owner: 10Daimona Eaytoy) [12:18:36] (03CR) 10Robert Vogel: [C: 03+2] Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/486265 (owner: 10ItSpiderman) [12:18:42] (03PS1) 10Robert Vogel: Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/486272 [12:18:45] (03CR) 10Robert Vogel: [C: 03+2] Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/486272 (owner: 10Robert Vogel) [12:18:49] 10MassMessage, 10WorkType-NewFunctionality: Add a behaviour switch to exclude MassMessage from some pages - https://phabricator.wikimedia.org/T214580 (10MarcoAurelio) [12:19:18] (03PS1) 10Drishya Ramesh: Fixed typo [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/486274 [12:24:23] (03PS1) 10Reedy: Add message for "BlockAttacker" password policy [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/486275 (https://phabricator.wikimedia.org/T208097) [12:25:11] (03Abandoned) 10Reedy: Add message for "BlockAttacker" password policy [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/486275 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [12:25:36] (03PS1) 10MarcoAurelio: [AuthenticatedKeyValueStore] Register new extension repository [extensions] - 10https://gerrit.wikimedia.org/r/486276 [12:25:38] (03PS1) 10Reedy: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) [12:26:03] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] [AuthenticatedKeyValueStore] Register new extension repository [extensions] - 10https://gerrit.wikimedia.org/r/486276 (owner: 10MarcoAurelio) [12:27:33] (03PS4) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [12:28:17] (03PS29) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [12:29:24] (03PS2) 10Drishya Ramesh: Fixed typo [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/486274 [12:29:55] (03CR) 10Gopavasanth: [C: 03+1] Fixed typo [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/486274 (owner: 10Drishya Ramesh) [12:31:15] (03Merged) 10jenkins-bot: Refactor phrase suggest [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/482872 (https://phabricator.wikimedia.org/T213098) (owner: 10DCausse) [12:32:33] (03PS2) 10Reedy: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) [12:33:17] (03CR) 10WMDE-Fisch: [C: 03+2] "Dependency is merged." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486230 (owner: 10WMDE-Fisch) [12:37:09] (03PS1) 10Daimona Eaytoy: Remove $wgAbuseFilterProfiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486279 (https://phabricator.wikimedia.org/T191039) [12:37:42] (03CR) 10Daimona Eaytoy: [C: 04-1] "Let's wait for a couple of weeks to see how it goes in production." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486279 (https://phabricator.wikimedia.org/T191039) (owner: 10Daimona Eaytoy) [12:39:12] (03CR) 10MarcoAurelio: [C: 03+1] "Looks good to me. But I'd prefer another pair of eyes to doublecheck :)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [12:39:40] (03Merged) 10jenkins-bot: Remove deprecated code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/483138 (owner: 10DCausse) [12:39:42] (03Merged) 10jenkins-bot: Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/486265 (owner: 10ItSpiderman) [12:39:44] (03Merged) 10jenkins-bot: Add base hook handler for NewRevisionFromEditComplete [extensions/BlueSpiceFoundation] (REL1_31) - 10https://gerrit.wikimedia.org/r/486272 (owner: 10Robert Vogel) [12:39:46] (03Merged) 10jenkins-bot: Enable reference popups by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486230 (owner: 10WMDE-Fisch) [12:39:56] 10ContentTranslation, 10Language-Team (Language-2019-January-March): CX2: Cite web template cannot be transferred to Turkish - https://phabricator.wikimedia.org/T214581 (10Pginer-WMF) p:05Triage→03Normal [12:42:50] (03PS6) 10WMDE-Fisch: Add browser tests for reference previews [extensions/Popups] - 10https://gerrit.wikimedia.org/r/485694 (https://phabricator.wikimedia.org/T213415) [12:42:53] 10Google-Summer-of-Code (2019): Improving recommender system for wiki media - https://phabricator.wikimedia.org/T214421 (10Aklapper) Ah, thanks a lot! :) [12:43:35] (03CR) 10jenkins-bot: Refactor phrase suggest [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/482872 (https://phabricator.wikimedia.org/T213098) (owner: 10DCausse) [12:43:58] 10Discovery-Search, 10GeoData: API search request with geosearch generator does not return coordinates of pages - https://phabricator.wikimedia.org/T214528 (10Aklapper) [12:46:55] (03CR) 10Hashar: "I gotta investigate the code and figure what mime.info/mime.types are for :/" [core] - 10https://gerrit.wikimedia.org/r/481649 (https://phabricator.wikimedia.org/T35515) (owner: 10Hashar) [12:47:24] 10Library-Card-Platform: Add a link to translatewiki - https://phabricator.wikimedia.org/T213469 (10AVasanth_WMF) 05Open→03Resolved [12:47:39] (03CR) 10Phuedx: "See inline for some minor comments." (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484729 (https://phabricator.wikimedia.org/T211197) (owner: 10Pmiazga) [12:49:04] (03PS1) 10Pboehm: Add title Attributes to Links [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/486281 [12:49:27] (03CR) 10Aklapper: [C: 04-1] "Thanks a lot for your patch! I do not think that we should fix typos of content copied from external code repositories. This should be fix" [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/486274 (owner: 10Drishya Ramesh) [12:50:33] (03CR) 10jerkins-bot: [V: 04-1] Add title Attributes to Links [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/486281 (owner: 10Pboehm) [12:51:30] (03CR) 10WMDE-Fisch: [C: 03+2] Add browser tests for reference previews [extensions/Popups] - 10https://gerrit.wikimedia.org/r/485694 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [12:56:33] (03Merged) 10jenkins-bot: Add browser tests for reference previews [extensions/Popups] - 10https://gerrit.wikimedia.org/r/485694 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [12:59:10] (03CR) 10Hashar: "Seems the root logic is guessMimeType, which first call doGuessMimeType. That inspects the file to figure out the type and my patch make i" [core] - 10https://gerrit.wikimedia.org/r/481649 (https://phabricator.wikimedia.org/T35515) (owner: 10Hashar) [13:07:12] 10MediaWiki-Uploading, 10Multimedia, 10Patch-For-Review, 10Release-Engineering-Team (Kanban): .odb file recognized as application/acad (first type entry in our list) - https://phabricator.wikimedia.org/T35515 (10hashar) The mime type issue for base/database got mentioned at https://lists.oasis-open.org/arc... [13:07:23] (03CR) 10jenkins-bot: Enable reference popups by default [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486230 (owner: 10WMDE-Fisch) [13:07:25] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10Regression: [Regression] Menu panel has black background when another drawer is first opened - https://phabricator.wikimedia.org/T211691 (10Jdrewniak) I don... [13:08:43] (03PS1) 10Daimona Eaytoy: Save slow filters data without checking wgAbuseFilterRuntimeProfile [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486284 (https://phabricator.wikimedia.org/T191039) [13:09:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [13:11:18] (03PS6) 10Thiemo Kreuz (WMDE): MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [13:12:36] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: 'Wiki' spelling in Urdu is wrong on some projects - https://phabricator.wikimedia.org/T214290 (10zeljkofilipin) ` zfilipin@mwmaint1002:~$ mwscript namespaceDupes.php urwikibooks --fix 0 pages to fix, 0 were resolvable. 0 link... [13:12:46] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: 'Wiki' spelling in Urdu is wrong on some projects - https://phabricator.wikimedia.org/T214290 (10zeljkofilipin) ` zfilipin@mwmaint1002:~$ mwscript namespaceDupes.php urwikiquote --fix 0 pages to fix, 0 were resolvable. 0 link... [13:13:20] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: 'Wiki' spelling in Urdu is wrong on some projects - https://phabricator.wikimedia.org/T214290 (10zeljkofilipin) ` zfilipin@mwmaint1002:~$ mwscript namespaceDupes.php urwiktionary --fix 0 pages to fix, 0 were resolvable. 0 lin... [13:13:41] (03CR) 10Bartosz Dziewoński: [C: 03+2] Document Uri.js constructor and methods throwing Errors [core] - 10https://gerrit.wikimedia.org/r/486160 (owner: 10Thiemo Kreuz (WMDE)) [13:13:47] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Design updates to Settings page & AMC opt-in toggle - https://phabricator.wikimedia.org/T214195 (10Jdrewniak) a:03Jdrewniak [13:13:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I realized this test will fail on systems that don't default to English, because the "and" message is not requested in a specific language" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [13:16:06] (03CR) 10D3r1ck01: "Thanks @Thiemo :)" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [13:19:25] (03CR) 10jenkins-bot: Remove deprecated code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/483138 (owner: 10DCausse) [13:21:50] (03CR) 10jenkins-bot: Add browser tests for reference previews [extensions/Popups] - 10https://gerrit.wikimedia.org/r/485694 (https://phabricator.wikimedia.org/T213415) (owner: 10WMDE-Fisch) [13:27:11] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Wikimedia-maintenance-script-run: 'Wiki' spelling in Urdu is wrong on some projects - https://phabricator.wikimedia.org/T214290 (10Tulsi_Bhagat) 05Open→03Resolved [13:27:47] (03Merged) 10jenkins-bot: Document Uri.js constructor and methods throwing Errors [core] - 10https://gerrit.wikimedia.org/r/486160 (owner: 10Thiemo Kreuz (WMDE)) [13:35:41] (03PS1) 10Sbisson: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486288 (https://phabricator.wikimedia.org/T213356) [13:37:07] 10ContentTranslation, 10Language-Team (Language-2019-January-March): ContentTranslation substitutes some templates in the references - https://phabricator.wikimedia.org/T198911 (10Pginer-WMF) A possibly related issue was mentioned [[ https://www.mediawiki.org/wiki/Topic:Usnvya07u807qtjd | in this comment ]] wh... [13:39:24] 10Library-Card-Platform, 10good first bug: Don't show negative numbers for accounts available - https://phabricator.wikimedia.org/T211022 (10Samwalton9) For coordinators and superusers, display the actual negative number after 0 in brackets or something? [13:41:07] 10ContentTranslation, 10Language-Team (Language-2019-January-March): CX2: Extra spaces are added when using Google Translate - https://phabricator.wikimedia.org/T213694 (10Pginer-WMF) p:05Triage→03Normal [13:41:35] (03CR) 10jenkins-bot: Document Uri.js constructor and methods throwing Errors [core] - 10https://gerrit.wikimedia.org/r/486160 (owner: 10Thiemo Kreuz (WMDE)) [13:41:49] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10Samwalton9) a:03AVasanth_WMF [13:49:30] (03PS1) 10Thiemo Kreuz (WMDE): Open all links in a reference preview's content in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) [13:51:28] (03PS1) 10Sbisson: Help panel: add ellipsis to search results excerpts [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486290 (https://phabricator.wikimedia.org/T209301) [13:51:42] (03PS4) 10Zppix: Clean up the grammar of i18n/en.json [core] - 10https://gerrit.wikimedia.org/r/486129 [13:52:50] (03CR) 10Zppix: "Thiemo Thanks for catching those, those totally went over my head." [core] - 10https://gerrit.wikimedia.org/r/486129 (owner: 10Zppix) [13:52:54] (03PS2) 10Thiemo Kreuz (WMDE): Open all links in a reference preview's content in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) [13:53:29] (03PS3) 10Thiemo Kreuz (WMDE): Add QUnit tests for all new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) [13:56:08] 10Access-Policy, 10Legalpad, 10WMF-Legal: Confidentiality agreement in farsi (fa): add to Legalpad - https://phabricator.wikimedia.org/T142907 (10MarcoAurelio) 05Open→03Declined Boldly declining because the text of the agreement was updated on November 2018 with a new version. [13:56:30] (03PS4) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) [13:58:29] 10Access-Policy, 10Trust-and-Safety: Hide outdated Confidentiality Agreement versions - https://phabricator.wikimedia.org/T214583 (10MarcoAurelio) [14:01:22] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01) [14:04:58] 10Library-Card-Platform, 10Tracking: Update documentation on creating partners - https://phabricator.wikimedia.org/T214584 (10Samwalton9) p:05Triage→03Normal [14:07:45] (03CR) 10DCausse: [C: 03+2] Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [14:07:59] (03CR) 10jerkins-bot: [V: 04-1] Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [14:12:32] 10MediaWiki-Database: Add support for truncating tables - https://phabricator.wikimedia.org/T191622 (10Mainframe98) This functionality already exists to a certain degree in MediaWiki, in `MediaWikiTestCase::truncateTable`. [14:15:16] 04(no projects): New page protection option: remind me when this page protection is about to/has expired - https://phabricator.wikimedia.org/T214585 (10MER-C) [14:19:27] 10Access-Policy, 10Trust-and-Safety: Hide outdated Confidentiality Agreement versions - https://phabricator.wikimedia.org/T214583 (10Aklapper) Where are these NDAs located? Impossible to hide something without knowing where it is... [14:20:56] (03PS1) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) [14:21:06] (03PS1) 10D3r1ck01: Remove irrelevant trailing forward slash from comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 [14:21:25] 10MediaWiki-Page-protection: New page protection option: remind me when this page protection is about to/has expired - https://phabricator.wikimedia.org/T214585 (10Reedy) [14:21:35] (03PS2) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) [14:21:53] 10MediaWiki-Page-protection: New page protection option: remind me when this page protection is about to/has expired - https://phabricator.wikimedia.org/T214585 (10Reedy) [14:22:11] (03PS8) 10Andrew Bogott: Get rid of v1 designate API stuff [openstack/horizon/wmf-proxy-dashboard] - 10https://gerrit.wikimedia.org/r/471205 (owner: 10Alex Monk) [14:22:43] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Get rid of v1 designate API stuff [openstack/horizon/wmf-proxy-dashboard] - 10https://gerrit.wikimedia.org/r/471205 (owner: 10Alex Monk) [14:23:17] 10MediaWiki-Page-protection: New page protection option: remind me when this page protection is about to/has expired - https://phabricator.wikimedia.org/T214585 (10Reedy) 05Open→03Stalled [14:23:37] (03CR) 10D3r1ck01: Remove irrelevant trailing forward slash from comment (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [14:23:49] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [14:23:54] 10MediaWiki-User-management, 10Growth-Team, 10Notifications: New block option: Notify me when this block is about to expire or has expired - https://phabricator.wikimedia.org/T189391 (10MER-C) [14:24:12] (03PS1) 10Andrew Bogott: Get rid of v1 designate API stuff [openstack/horizon/wmf-proxy-dashboard] (ocata) - 10https://gerrit.wikimedia.org/r/486295 [14:24:50] (03PS2) 10Andrew Bogott: Get rid of v1 designate API stuff [openstack/horizon/wmf-proxy-dashboard] (ocata) - 10https://gerrit.wikimedia.org/r/486295 [14:25:18] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Get rid of v1 designate API stuff [openstack/horizon/wmf-proxy-dashboard] (ocata) - 10https://gerrit.wikimedia.org/r/486295 (owner: 10Andrew Bogott) [14:26:19] (03PS1) 10Andrew Bogott: Update wmf-proxy-dashboard submodule [openstack/horizon/deploy] (ocata) - 10https://gerrit.wikimedia.org/r/486296 [14:26:21] (03CR) 10Kosta Harlan: [C: 03+2] Help panel: add ellipsis to search results excerpts [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486290 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [14:26:47] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] Update wmf-proxy-dashboard submodule [openstack/horizon/deploy] (ocata) - 10https://gerrit.wikimedia.org/r/486296 (owner: 10Andrew Bogott) [14:26:50] 10Phabricator, 10Release-Engineering-Team: Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10Aklapper) Thanks for reporting this. Indeed, those queries are listed on top of "Global Saved Queries" on https://phabricator.wikimedia.org/maniphest/query/edit/ I have changed the de... [14:27:18] (03CR) 10jerkins-bot: [V: 04-1] Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [14:27:26] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Reedy) [14:27:40] (03CR) 10Kosta Harlan: [C: 03+2] Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486288 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [14:32:20] (03PS1) 10Thiemo Kreuz (WMDE): Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) [14:32:46] (03Merged) 10jenkins-bot: Help panel: add ellipsis to search results excerpts [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486290 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [14:32:48] (03Merged) 10jenkins-bot: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486288 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [14:34:01] (03CR) 10Gopavasanth: "> Thanks a lot for your patch! I do not think that we should fix" [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/486274 (owner: 10Drishya Ramesh) [14:34:51] (03PS3) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) [14:35:09] (03CR) 10jenkins-bot: Help panel: add ellipsis to search results excerpts [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486290 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [14:35:42] (03PS4) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) [14:36:00] (03PS2) 10Thiemo Kreuz (WMDE): Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) [14:36:52] 10MediaWiki-User-management, 10Anti-Harassment: Explore alternatives to browser fingerprinting for anti-abuse efforts - https://phabricator.wikimedia.org/T213875 (10MER-C) Anti-abuse will always require a defence in depth approach - to limit the scope to just the stickiness of the banhammer is mistaken. The fl... [14:37:30] (03CR) 10jenkins-bot: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486288 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [14:37:36] 10MediaWiki-General-or-Unknown, 10Technical-Debt: Remove use of `@access`, `@protected` and `@private` on public methods in MediaWiki - https://phabricator.wikimedia.org/T7176 (10D3r1ck01) Occurrences in MW Core seen by CS: https://codesearch.wmflabs.org/core/?q=%5C%40private&i=nope&files=&repos= [14:37:52] 10MediaWiki-General-or-Unknown: Title::loadFromRow() should return a new instance of Title - https://phabricator.wikimedia.org/T214546 (10Anomie) `Title->loadFromRow()` is a loading method, it absolutely //shouldn't// return a new instance. Code that wants a new instance should use `Title::newFromRow()`. Whethe... [14:38:41] (03CR) 10Andrew Bogott: [V: 03+2 C: 03+2] "This is deployed and looks good. Thank you!" [openstack/horizon/wmf-proxy-dashboard] - 10https://gerrit.wikimedia.org/r/471205 (owner: 10Alex Monk) [14:38:58] 10MediaWiki-extensions-WikibaseRepository, 10Outreach-Programs-Projects, 10Wikidata, 10Epic, 10Tracking: [Epic] Adding new datatypes to Wikidata (tracking) - https://phabricator.wikimedia.org/T91505 (10Lydia_Pintscher) [14:39:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Allow non-entity pages to be moved out of an entity namespace. - https://phabricator.wikimedia.org/T139877 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten any attention in a long time. [14:41:02] 10MediaWiki-Database, 10MediaWiki-Installer, 10MSSQL: Installation of MW 1.31.0 fails on MS SQL server - https://phabricator.wikimedia.org/T202637 (10MarkAHershberger) RobertGoff writes: > I'd run tables.sql manually, but I'm not sure how to substitute the > /*_*/ (looks like schema name?) and /*i*/ (someth... [14:41:04] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - Mikroorganismoen Biodibertsitatea - https://phabricator.wikimedia.org/T205638 (10Theklan) [14:41:31] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: [EPIC] AMC Navigation - changes to main menu - https://phabricator.wikimedia.org/T214537 (10alexhollender) Noting T206354, in case there's an opportunity to do these in conjunction. [14:41:56] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - Mikroorganismoen Biodibertsitatea - https://phabricator.wikimedia.org/T205638 (10Theklan) Gaur elkartu naiz eta mintegietan zerbait egiteko aukera ikusi dute. Oraintxe bidali diet egin daitezkeen artikuluen zerrenda bat.... [14:42:13] (03CR) 10Cicalese: [C: 04-1] "Please fix the coding style issues that are flagged, then I will +2." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/481669 (owner: 10Nischayn22) [14:43:07] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - Biologiako kontzeptuak eta metodoak - https://phabricator.wikimedia.org/T205413 (10Theklan) Ikasleei aukeran eskainiko die Wikipediako artikulua edo beste praktika bat. Bidali zizkidan gai guztien artean aukeratu beharko... [14:43:14] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Performance: Allow changeDispatcher to run with different configuration for different groups of wikis - https://phabricator.wikimedia.org/T173216 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten an... [14:43:23] (03CR) 10Cicalese: "What is the status of this patch?" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/466851 (owner: 10Nischayn22) [14:44:50] (03CR) 10Cicalese: "Is this still necessary, or does https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CommentStreams/+/466851 eliminate the need for it?" [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/465572 (owner: 10Nischayn22) [14:45:14] 10MediaWiki-Special-pages, 10Anti-Harassment, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), and 4 others: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Johan) Do you have a rough id... [14:45:57] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Include revision ID and timestamp for each entity in the JSON dump. - https://phabricator.wikimedia.org/T146273 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten any attention in a long time. [14:46:08] 10Wikimedia-User-Group-Basque: EHU - Gipuzkoako Campusa - HEFA - Ezagutzaren teoria - https://phabricator.wikimedia.org/T214587 (10Theklan) p:05Triage→03Normal [14:46:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikibase-Internal-Serialization, 10Wikidata: Remove getStatementDeserializer from internal-serialization's DeserializerFactory, from WikibaseRepo, and ChangeFactory. - https://phabricator.wikimedia.org/T128618 (10Lydia_Pintscher) 05Open→03Invalid Closing this... [14:46:51] (03CR) 10Anomie: "One drawback to this approach versus I0041a856 is that this will have Action::factory() use stale data, for example it'll use the content " [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [14:46:53] (03CR) 10Anomie: "> I think we should just clone the object to prevent mutation." [core] - 10https://gerrit.wikimedia.org/r/486157 (https://phabricator.wikimedia.org/T210739) (owner: 10Anomie) [14:47:15] (03PS1) 10Thiemo Kreuz (WMDE): Update PHPDocs and strict typing for array parameters [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 [14:47:27] 10Wikimedia-User-Group-Basque: EHU - Gipuzkoako Campusa - HEFA - Filosofiaren oinarrizko gaiak - https://phabricator.wikimedia.org/T214588 (10Theklan) p:05Triage→03Normal [14:47:47] (03CR) 10Dbarratt: "> Patch Set 1:" [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [14:48:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking: Quantity datatype (tracking) - https://phabricator.wikimedia.org/T56318 (10Lydia_Pintscher) [14:48:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Do not apply rounding when formatting Quantities (unless unit conversion was applied) - https://phabricator.wikimedia.org/T117457 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten any attention in a lon... [14:48:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Welcome to the codebase I'm currently paid for! ;-)" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [14:49:21] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Use correct term language when creating items from the client - https://phabricator.wikimedia.org/T137536 (10Lydia_Pintscher) p:05High→03Normal [14:50:08] 10Wikimedia-User-Group-Basque: EHU - Gipuzkoako Campusa - Kimika Fakultatea - Biologia orokorra - https://phabricator.wikimedia.org/T214590 (10Theklan) p:05Triage→03Normal [14:50:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking: Include incoming redirects in JSON representation of entities (tracking) - https://phabricator.wikimedia.org/T98039 (10Lydia_Pintscher) [14:50:42] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] Optionally include incoming redirects in the output of wbgetentities - https://phabricator.wikimedia.org/T98317 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten any attention in a lo... [14:52:53] (03PS1) 10Sbisson: Special:WelcomeSuvey Vietnamese alias (updated) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486302 (https://phabricator.wikimedia.org/T213356) [14:53:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Restore convenience functions for setting labels, descriptions, and aliases. - https://phabricator.wikimedia.org/T66873 (10Lydia_Pintscher) 05Open→03Invalid Closing this to remove tasks from the board that havn't gotten any attention in a long time. [14:53:24] 10MediaWiki-Special-pages, 10Anti-Harassment, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), and 4 others: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Anomie) First one of the two... [14:54:15] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Clean up the grammar of i18n/en.json (033 comments) [core] - 10https://gerrit.wikimedia.org/r/486129 (owner: 10Zppix) [14:54:17] (03Merged) 10jenkins-bot: Remove irrelevant trailing forward slash from comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [14:57:06] (03CR) 10jenkins-bot: Remove irrelevant trailing forward slash from comment [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [14:57:07] 10Dumps-Generation, 10Patch-For-Review: Produce multistream dumps in parallel - https://phabricator.wikimedia.org/T213912 (10ArielGlenn) The fix has been deployed and I am manually running updates for all big wikis now except for commons and wikidata; these will need to wait until their runs complete. [14:57:50] 10Access-Policy, 10Legalpad, 10WMF-Legal: Confidentiality agreement in farsi (fa): add to Legalpad - https://phabricator.wikimedia.org/T142907 (10Huji) Would you like me to translate the new version? [14:59:22] (03CR) 10Kosta Harlan: [C: 03+2] Special:WelcomeSuvey Vietnamese alias (updated) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486302 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [15:00:16] (03PS1) 10Kosta Harlan: WIP: Save full HTML documents, load only body in VE mode [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486303 (https://phabricator.wikimedia.org/T209114) [15:03:52] (03Merged) 10jenkins-bot: Special:WelcomeSuvey Vietnamese alias (updated) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486302 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [15:04:36] (03PS1) 10Kosta Harlan: WIP: Store full HTML documents for Flow content [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486304 (https://phabricator.wikimedia.org/T209114) [15:05:14] 10Access-Policy, 10Trust-and-Safety: Hide outdated Confidentiality Agreement versions - https://phabricator.wikimedia.org/T214583 (10MarcoAurelio) They are a bunch of them. They are {L4} and its translations, and {L32} and their translations. Do you want me to list them all? The new ones are {L47} and {L45} a... [15:05:35] (03Abandoned) 10Zfilipin: Test: notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/471910 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [15:06:26] (03CR) 10jenkins-bot: Special:WelcomeSuvey Vietnamese alias (updated) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/486302 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [15:07:56] 10CommRel-Specialists-Support (Jan-Mar-2019), 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review: Personalized first day: activate for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T213356 (10Trizek-WMF) a:05Trizek-WMF→03MMiller_WMF Now, we have e... [15:08:30] 10MediaWiki-Codesniffer, 10good first bug: MediaWiki Codesniffer not catching irrelevant characters after PHPDoc return types - https://phabricator.wikimedia.org/T214591 (10D3r1ck01) [15:10:56] (03CR) 10D3r1ck01: "... and thanks for the warm welcome :)" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486294 (owner: 10D3r1ck01) [15:11:42] 10Access-Policy, 10Legalpad, 10WMF-Legal: Confidentiality agreement in farsi (fa): add to Legalpad - https://phabricator.wikimedia.org/T142907 (10MarcoAurelio) I'd ask the people in charge of #acl_access-policy-approvers if they're willing to post a translation this time first. [15:13:07] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/484712 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [15:14:24] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+1] "I don't know about the coverage. I think there is something wrong with the job that says "test coverage increased (or stayed the same)". L" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [15:14:54] (03PS4) 10EBernhardson: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 [15:17:46] (03CR) 10D3r1ck01: [C: 03+1] "> By the way, feel free to +2 this now if you are fine with the changes I made." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [15:18:19] 10StructuredDiscussions, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Technical-Debt: Store (including Parsoid version number) for HTML Flow content - https://phabricator.wikimedia.org/T209114 (10kostajh) I've created two WIP patches for this which use different approaches, see above. In sh... [15:19:22] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: Deleted contributions link should be red if user has no deleted contribs - https://phabricator.wikimedia.org/T19380 (10D3r1ck01) Truth is, this link no longer exist on the said special page, see: https://www.mediawiki.org/wiki/Special:Contributions/L... [15:24:59] (03CR) 10jerkins-bot: [V: 04-1] smoke.js: Add a test that performs smoke tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/484712 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [15:25:52] (03CR) 10Niedzielski: [C: 04-1] Add QUnit tests for most new reference preview code (034 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [15:29:06] (03PS1) 10Niedzielski: Hygiene: rename NPM test:node to test:unit [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486307 [15:32:13] (03CR) 10D3r1ck01: [C: 03+1] "LGTM!" (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [15:33:15] (03PS1) 10Niedzielski: Hygiene: move imports above constants [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486309 [15:34:50] (03CR) 10D3r1ck01: [C: 03+1] Update PHPDocs and strict typing for array parameters (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [15:35:28] (03CR) 10DCausse: [C: 03+2] Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [15:36:45] (03CR) 10DCausse: [C: 03+2] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [15:36:55] (03CR) 10jerkins-bot: [V: 04-1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [15:37:23] (03CR) 10Dbarratt: [C: 04-1] "Upon some further thought, I think both approaches introduce an edge case which could break things in the future." [core] - 10https://gerrit.wikimedia.org/r/486157 (https://phabricator.wikimedia.org/T210739) (owner: 10Anomie) [15:41:55] (03CR) 10Niedzielski: [C: 04-1] Add QUnit test for reference preview renderer (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [15:42:03] (03CR) 10Melos: [C: 03+1] Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 (owner: 10Daimona Eaytoy) [15:43:15] (03CR) 10Niedzielski: [C: 04-1] Add QUnit test for reference preview renderer (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [15:43:28] (03CR) 10ValeryanM: "> Patch Set 7:" [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/482701 (https://phabricator.wikimedia.org/T213113) (owner: 10ValeryanM) [15:45:31] 10MediaWiki-General-or-Unknown, 10Technical-Debt: Cleanup Math-related code from core - https://phabricator.wikimedia.org/T43299 (10D3r1ck01) 05Open→03Resolved a:03D3r1ck01 Per https://codesearch.wmflabs.org/core/?q=LanguageConverter%5C%3A%5C%3AarmourMath&i=nope&files=&repos= for example, it has been rem... [15:46:04] (03PS6) 10EBernhardson: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 [15:46:10] (03PS5) 10EBernhardson: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 [15:46:37] (03CR) 10EBernhardson: [C: 03+2] "re-apply +2" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [15:46:40] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/484712 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [15:47:58] 10AbuseFilter: afl_log_id is never written to - https://phabricator.wikimedia.org/T214592 (10matej_suchanek) [15:50:00] (03Merged) 10jenkins-bot: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [15:51:47] (03CR) 10Thiemo Kreuz (WMDE): Update PHPDocs and strict typing for array parameters (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [15:52:41] (03CR) 10D3r1ck01: [C: 03+1] Update PHPDocs and strict typing for array parameters (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [15:57:04] 10MediaWiki-Vagrant, 10Analytics: Kafka in mw vagrant: kafka_broker.keystore.jks has expired - https://phabricator.wikimedia.org/T214593 (10dcausse) [15:57:40] (03CR) 10jerkins-bot: [V: 04-1] smoke.js: Add a test that performs smoke tests for Echo notifications [extensions/Echo] - 10https://gerrit.wikimedia.org/r/484712 (https://phabricator.wikimedia.org/T204068) (owner: 10Ephemeralwaves) [15:57:43] 10MediaWiki-Vagrant, 10Analytics: Kafka in mw vagrant: kafka_broker.keystore.jks has expired - https://phabricator.wikimedia.org/T214593 (10dcausse) [16:01:36] (03Merged) 10jenkins-bot: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [16:02:06] 10monitoring: node-exporter collector.diskstats.ignored-devices underescaped - https://phabricator.wikimedia.org/T214594 (10fgiunchedi) [16:02:19] (03CR) 10jenkins-bot: Add a phpunit mocks dir [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486196 (owner: 10EBernhardson) [16:05:04] 10Gadgets: Enable Gadgets tab in preferences of atj.wp - https://phabricator.wikimedia.org/T214595 (10Benoit_Rochon) [16:06:39] 10Anti-Harassment (Bet — ב): Update beta partial block config to match production - https://phabricator.wikimedia.org/T214596 (10dbarratt) [16:07:06] (03PS1) 10Dbrant: Follow-up to find text while editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 [16:07:13] (03CR) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [16:08:08] (03CR) 10jerkins-bot: [V: 04-1] Follow-up to find text while editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 (owner: 10Dbrant) [16:09:09] (03CR) 10Melos: [C: 03+1] Remove the hacky 'context' variable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/482415 (owner: 10Daimona Eaytoy) [16:10:55] (03CR) 10Tjones: "Looks good. Some minor copyediting in the comments." (034 comments) [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) (owner: 10EBernhardson) [16:11:01] (03CR) 10jenkins-bot: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [16:11:43] 10Anti-Harassment (Bet — ב): Update beta partial block config to match production - https://phabricator.wikimedia.org/T214596 (10dbarratt) @TBolliger there is no testwiki or itwiki on the beta cluster ([[ https://deployment.wikimedia.beta.wmflabs.org/wiki/Special:SiteMatrix | full list ]]), so how about we enabl... [16:13:35] 10FormWizard, 10I18n, 10Patch-For-Review: Text requesting for sub-page name needs to be localized - https://phabricator.wikimedia.org/T213347 (10D3r1ck01) [16:14:10] (03CR) 10jenkins-bot: Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [16:15:34] (03CR) 10Niedzielski: [C: 03+1] "+2 pending dependencies." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [16:16:15] (03CR) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code (034 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [16:16:56] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): [UX-Debt] Allow users to search for articles across all reading lists - https://phabricator.wikimedia.org/T188333 (10schoenbaechler) [16:18:37] 10Anti-Harassment (Bet — ב), 10Patch-For-Review: Update beta partial block config to match production - https://phabricator.wikimedia.org/T214596 (10dbarratt) Put on the schedule to SWAT https://wikitech.wikimedia.org/wiki/Deployments#deploycal-item-20190124T1900 [16:19:05] (03CR) 10Tjones: [C: 03+1] Remove HttpAccept language detection method [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486172 (owner: 10EBernhardson) [16:20:27] (03PS1) 10Zfilipin: WIP A test commit, please ignore [extensions/Echo] - 10https://gerrit.wikimedia.org/r/486315 [16:21:51] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add activity for lists that contain X article + blue link - https://phabricator.wikimedia.org/T214504 (10schoenbaechler) [16:22:04] (03PS5) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) [16:22:54] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Show lists + list items in same list based on search term - https://phabricator.wikimedia.org/T214505 (10schoenbaechler) [16:23:36] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Contextual actions for list item - https://phabricator.wikimedia.org/T214506 (10schoenbaechler) [16:25:32] 10Product-Analytics: Update Audiences page and Key Product Metrics deck with December 2018 Readers data - https://phabricator.wikimedia.org/T211841 (10mpopov) [16:25:36] 10Product-Analytics: Update Audiences page and Key Product Metrics deck with December 2018 Readers data - https://phabricator.wikimedia.org/T211841 (10mpopov) Done [16:25:39] (03PS2) 10Zfilipin: WIP A test commit, please ignore [extensions/Echo] - 10https://gerrit.wikimedia.org/r/486315 [16:32:59] (03CR) 10Niedzielski: [C: 04-1] Add QUnit tests for most new reference preview code (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [16:35:31] (03CR) 10Niedzielski: [C: 03+1] "Good to go pending dependencies." (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [16:40:11] (03PS6) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) [16:40:27] (03CR) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [16:41:27] (03CR) 10Daimona Eaytoy: [C: 04-1] "Let's wait for T191039 (if no problems arise), so that this will be easier to write." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/201104 (https://phabricator.wikimedia.org/T53294) (owner: 10Dragons flight) [16:43:17] (03PS1) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 [16:44:22] (03CR) 10jerkins-bot: [V: 04-1] Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [16:45:07] 10Advanced Mobile Contributions, 10Mobile, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Tracking): History links on mobile Special:RecentChanges link to article page instead of Special:History - https://phabricator.wikimedia.org/T214531 (10Jdlrobson) [16:46:50] (03PS2) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 [16:46:53] (03CR) 10SBassett: Add message for "BlockAttacker" password policy (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [16:47:42] (03CR) 10jerkins-bot: [V: 04-1] Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [16:47:55] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Investigate data discrepancy in banner data for Steward elections campaign - https://phabricator.wikimedia.org/T214600 (10AndyRussG) [16:48:11] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Investigate discrepancy in banner data for Steward elections campaign - https://phabricator.wikimedia.org/T214600 (10AndyRussG) [16:49:42] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Investigate discrepancy in banner data for Steward elections campaign - https://phabricator.wikimedia.org/T214600 (10AndyRussG) [16:50:17] (03PS3) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 [16:51:13] (03CR) 10jerkins-bot: [V: 04-1] Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [16:52:45] (03PS4) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 [16:53:50] (03CR) 10jerkins-bot: [V: 04-1] Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [16:55:09] (03CR) 10EBernhardson: Add jupyter notebooks for wbsearchentities analysis (034 comments) [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) (owner: 10EBernhardson) [16:55:14] (03PS3) 10EBernhardson: Add jupyter notebooks for wbsearchentities analysis [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) [16:55:41] 04(no projects): Labeled section transclusion incompatible with translate extension - https://phabricator.wikimedia.org/T214602 (10Aymatth2) [16:57:07] (03PS5) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 [16:57:42] 04(no projects): Labeled section transclusion incompatible with translate extension - https://phabricator.wikimedia.org/T214602 (10Aymatth2) [16:57:58] (03CR) 10jerkins-bot: [V: 04-1] Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [16:58:53] (03PS1) 10Addshore: stats: pcache, splti metric by page content model [core] - 10https://gerrit.wikimedia.org/r/486323 [16:59:14] (03PS1) 10Thiemo Kreuz (WMDE): Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 [17:01:48] (03CR) 10DCausse: [C: 03+2] Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [17:02:23] (03CR) 10Tjones: [C: 03+1] Add jupyter notebooks for wbsearchentities analysis (031 comment) [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) (owner: 10EBernhardson) [17:02:52] 10MediaWiki-extensions-LabeledSectionTransclusion, 10MediaWiki-extensions-Translate: Labeled section transclusion incompatible with translate extension - https://phabricator.wikimedia.org/T214602 (10Reedy) [17:02:58] (03PS3) 10Reedy: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) [17:03:49] 10ContentTranslation: Indic numercial not translated in ContentTranslation - https://phabricator.wikimedia.org/T214228 (10Pginer-WMF) 05Open→03Declined Content translation integrates [[ https://www.mediawiki.org/wiki/Content_translation/Machine_Translation | external translation services ]]. User corrections... [17:03:53] (03PS2) 10Addshore: stats: pcache, split metric by page content model [core] - 10https://gerrit.wikimedia.org/r/486323 [17:04:25] (03CR) 10SBassett: [C: 03+1] "LGTM" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [17:04:33] (03PS1) 10D3r1ck01: specialpage: Fix login crash caused by unknown language via ?uselang [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) [17:06:03] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [17:07:11] 10MobileFrontend, 10ImageMap, 10Readers-Web-Backlog, 10Need-volunteer, and 2 others: Misplaced (i) icon on all skins, causing scrollbars on MobileFrontend - https://phabricator.wikimedia.org/T213818 (10Jdlrobson) What I'm seeing: {F28017115} HTML markup shows new line height is there from your patch: {F28... [17:08:10] 10Growth-Team, 10CommRel-Specialists-Support (Jan-Mar-2019): Community Relations support for engagement emails - https://phabricator.wikimedia.org/T214216 (10Elitre) [17:09:24] 10CommRel-Specialists-Support (Jan-Mar-2019): CRS support for proposed system typefaces changes - https://phabricator.wikimedia.org/T214518 (10Elitre) [17:10:21] 10Community-Relations: Make a magic, self-labeling feedback button - https://phabricator.wikimedia.org/T214081 (10Elitre) And you're asking us for it? :D [17:11:39] (03CR) 10DCausse: [C: 03+2] Add jupyter notebooks for wbsearchentities analysis [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) (owner: 10EBernhardson) [17:11:54] 10CommRel-Specialists-Support (Jan-Mar-2019): Support Security team in getting word out about recent cryptomalware threat - https://phabricator.wikimedia.org/T213964 (10CKoerner_WMF) 05Open→03Resolved Message was posted by security to wikimedia-l, wikitech-l, and wikitech-ambassadors mailing lists. https://... [17:13:02] (03Merged) 10jenkins-bot: Add jupyter notebooks for wbsearchentities analysis [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/486159 (https://phabricator.wikimedia.org/T208917) (owner: 10EBernhardson) [17:13:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I do support the idea, but I think the patch is not finished yet. See my inline comments." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [17:15:42] (03PS13) 10Jdlrobson: Add client side click to undo on thank [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) [17:16:28] (03Merged) 10jenkins-bot: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [17:16:53] (03CR) 10Jdlrobson: "I've added a few people here as this task has been open for 4 or so years and this patch soon will be have waiting for a year and I know i" (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [17:17:07] 10ContentTranslation: CX2: Should not add at the beginning of image descriptions inside a gallery tag - https://phabricator.wikimedia.org/T213419 (10Pginer-WMF) p:05Triage→03Normal [17:17:21] 10ContentTranslation: CX2: Doesn't handle correctly ISBN, should not put nowiki tags around them - https://phabricator.wikimedia.org/T213255 (10Pginer-WMF) p:05Triage→03Normal [17:21:18] 10Security-Team: Onboarding David Sharpe to Security Team as Information Security Analyst - https://phabricator.wikimedia.org/T213742 (10RobH) [17:21:30] (03CR) 10Niedzielski: [C: 04-1] Rewrite title module to preserve all link's #fragments (035 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [17:26:13] (03PS1) 10EBernhardson: Merge remote-tracking branch 'origin/master' into HEAD [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486331 [17:27:32] 04(no projects): Audit /etc/apt directories - https://phabricator.wikimedia.org/T214605 (10jbond) [17:28:56] 10monitoring: node-exporter collector.diskstats.ignored-devices underescaped - https://phabricator.wikimedia.org/T214594 (10colewhite) @fgiunchedi found that systemd likely the likely culprit: https://github.com/systemd/systemd/issues/10659 https://github.com/systemd/systemd/pull/11427 The fix appears to be in... [17:29:11] (03CR) 10Niedzielski: [C: 04-1] Add QUnit tests for most new reference preview code (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [17:29:52] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Regression: Wikidata descriptions are always printed as "1" for tagline - https://phabricator.wikimedia.org/T214606 (10Jdlrobson) [17:29:59] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Regression: Wikidata descriptions are always printed as "1" for tagline - https://phabricator.wikimedia.org/T214606 (10Jdlrobson) p:05Triage→03High [17:30:10] 10MinervaNeue, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10Regression: Regression: Wikidata descriptions are always printed as "1" for tagline - https://phabricator.wikimedia.org/T214606 (10Jdlrobson) [17:30:31] (03CR) 10jenkins-bot: Remove old Elastica compat code [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/486173 (owner: 10EBernhardson) [17:31:47] (03PS2) 10D3r1ck01: specialpage: Fix login crash caused by unknown language via ?uselang [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) [17:32:26] 10MediaWiki-User-management, 10Anti-Harassment: Clear the invalid inputs from the Page input field when switching the block type (if they are distinguishable before submission) - https://phabricator.wikimedia.org/T208559 (10TBolliger) 05Open→03Declined [17:32:27] (03CR) 10D3r1ck01: "Yeah, you're on point! Tested and it still works just fine! :) Thanks!" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [17:33:37] (03CR) 10Isarra: "This seems woefully premature. The skinning backend lacks any of the consistency I would have expected to see before we do any such meanin" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [17:33:47] (03CR) 10D3r1ck01: specialpage: Fix login crash caused by unknown language via ?uselang (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [17:34:00] 10MediaWiki-Vagrant, 10Analytics: Kafka in mw vagrant: kafka_broker.keystore.jks has expired - https://phabricator.wikimedia.org/T214593 (10fdans) @Ottomata any ideas here? [17:34:23] 10MediaWiki-User-login-and-signup, 10I18n, 10Patch-For-Review, 10Wikimedia-production-error: Invalid language code on Special:UserLogin leads to internal error - https://phabricator.wikimedia.org/T198054 (10D3r1ck01) p:05Triage→03Normal a:03D3r1ck01 [17:35:35] 04(no projects): Summary header vanishes when a file doesn't have any captions entered - https://phabricator.wikimedia.org/T214607 (10AlexisJazz) [17:36:27] (03CR) 10D3r1ck01: "Seems I deviated a bit from the expected behavior saying "Expected behavior: Ignore the invalid language code or show an explicit error me" [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [17:36:45] 10MediaWiki-API, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Goal: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10Martyav) [17:37:09] (03CR) 10Niedzielski: [C: 04-1] "Great hygiene patch. One comment inline." (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [17:37:28] 10Contributors-Analysis, 10Product-Analytics, 10VisualEditor (Current work): Mobile visual editor not logging EditAttemptStep abort actions - https://phabricator.wikimedia.org/T214533 (10DLynch) a:03DLynch [17:38:03] 10MediaWiki-User-login-and-signup, 10I18n, 10Patch-For-Review, 10User-D3r1ck01, 10Wikimedia-production-error: Invalid language code on Special:UserLogin leads to internal error - https://phabricator.wikimedia.org/T198054 (10D3r1ck01) [17:39:00] (03CR) 10D3r1ck01: "Okay, this can be finally reviewed for now, will continue working on this class in the future." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/477130 (owner: 10D3r1ck01) [17:43:16] (03PS1) 10Sbisson: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486333 (https://phabricator.wikimedia.org/T213356) [17:43:55] (03PS2) 10Sbisson: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486333 (https://phabricator.wikimedia.org/T213356) [17:45:23] (03CR) 10Niedzielski: [C: 04-1] Open all links in a reference preview's content in new tabs (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [17:46:19] (03CR) 10Niedzielski: Do not capitalize wikidata descriptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486102 (https://phabricator.wikimedia.org/T131013) (owner: 10Jdlrobson) [17:46:22] (03CR) 10Niedzielski: [C: 03+2] Do not capitalize wikidata descriptions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486102 (https://phabricator.wikimedia.org/T131013) (owner: 10Jdlrobson) [17:49:20] (03CR) 10Niedzielski: [C: 03+2] Update PHPDocs and strict typing for array parameters [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [17:49:54] (03PS9) 10Jdlrobson: Talk tabs in AMC mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) [17:52:13] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): AMC page/talk toggle v1: Talk tab at the top of page for AMC users - https://phabricator.wikimedia.org/T212216 (10Jdlrobson) @alexhollender I've... [17:53:58] 10Developer-Advocacy: WMF staff hackathon expectations reading - https://phabricator.wikimedia.org/T214535 (10Quiddity) [17:54:43] (03PS1) 10Thiemo Kreuz (WMDE): Add default OOUI reference icon to all reference popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486336 (https://phabricator.wikimedia.org/T213907) [17:56:04] (03CR) 10Jdlrobson: [C: 03+2] MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [17:56:37] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] Hygiene: move imports above constants [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486309 (owner: 10Niedzielski) [17:56:57] 10Anti-Harassment: QA & document user_talk logic for partial blocks (after namespace blocks release) - https://phabricator.wikimedia.org/T212807 (10TBolliger) [17:58:00] (03PS4) 10Esanders: Redirect after mobile section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484518 (https://phabricator.wikimedia.org/T213120) [17:58:16] 10Developer-Advocacy, 10Documentation: WMF staff hackathon expectations reading - https://phabricator.wikimedia.org/T214535 (10bd808) +1 to idea. I'd be glad to help out with brain storming and drafting. [17:59:40] (03CR) 10Niedzielski: [C: 03+2] Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [17:59:44] (03CR) 10jerkins-bot: [V: 04-1] Talk tabs in AMC mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) (owner: 10Jdlrobson) [17:59:52] (03PS2) 10Thiemo Kreuz (WMDE): Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 [17:59:54] (03PS7) 10Esanders: build: Update devDependencies [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477695 [17:59:56] (03PS6) 10Esanders: eslint: Remove exception for computed-property-spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477697 [17:59:58] (03PS5) 10Esanders: build: Update eslint-config-wikimedia to 0.10.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483308 [18:00:00] (03CR) 10Thiemo Kreuz (WMDE): Replace rare {!…} and {?…} JSDoc syntax (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [18:00:06] (03CR) 10Niedzielski: [C: 03+2] Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:00:48] (03CR) 10Niedzielski: [C: 03+2] Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [18:00:50] (03Merged) 10jenkins-bot: Update PHPDocs and strict typing for array parameters [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [18:01:10] (03CR) 10Niedzielski: [C: 03+2] Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [18:01:55] (03Abandoned) 10Dbrant: Test. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486320 (owner: 10Dbrant) [18:02:18] (03PS1) 10Dbrant: Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 [18:03:05] (03CR) 10jenkins-bot: Update PHPDocs and strict typing for array parameters [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486300 (owner: 10Thiemo Kreuz (WMDE)) [18:03:22] (03CR) 10jerkins-bot: [V: 04-1] Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 (owner: 10Dbrant) [18:04:03] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): [EPIC] Improve page issues - https://phabricator.wikimedia.org/T159262 (10Jdlrobson) a:03ovasileva Once T200794 and T210554 are resolved, I think we can sign this off? [18:04:23] (03CR) 10Thiemo Kreuz (WMDE): Open all links in a reference preview's content in new tabs (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [18:04:27] (03PS3) 10Thiemo Kreuz (WMDE): Open all links in a reference preview's content in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) [18:05:29] (03CR) 10jerkins-bot: [V: 04-1] Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [18:05:51] (03CR) 10jerkins-bot: [V: 04-1] Redirect after mobile section edit [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484518 (https://phabricator.wikimedia.org/T213120) (owner: 10Esanders) [18:05:59] (03PS2) 10Dbrant: Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 [18:07:13] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (10AndyRussG) I've set up a test banner with a JS error on the beta cluster. Banner content visible in the Beta-Clu... [18:07:20] 10Discovery-Search: Alerts for mjolnir daemons - https://phabricator.wikimedia.org/T214494 (10EBernhardson) p:05Triage→03Normal [18:07:23] 10Discovery-Search, 10GeoData: API search request with geosearch generator does not return coordinates of pages - https://phabricator.wikimedia.org/T214528 (10EBjune) p:05Triage→03Normal Search will take a look at this issue shortly. [18:07:29] 10Developer-Advocacy, 10International-Developer-Events, 10Documentation: WMF staff hackathon expectations reading - https://phabricator.wikimedia.org/T214535 (10Rfarrand) p:05Triage→03Normal [18:08:27] 10MediaWiki-Maintenance-scripts, 10Discovery-Search, 10Core Platform Team Backlog (Watching / External), 10Multi-Content-Revisions (Reactive): updateSearchIndex.php fails with Error: 1100 Table 'slots' was not locked with LOCK TABLES - https://phabricator.wikimedia.org/T214062 (10EBjune) p:05Triage→03No... [18:08:50] 10Research, 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22): Citation Usage instrumentation issues - https://phabricator.wikimedia.org/T212937 (10RyanSteinberg) @Lauren.maggio and I just discussed citation_identifier_label. Using a more comprehensive list of identifiers from [[... [18:09:41] (03CR) 10jerkins-bot: [V: 04-1] Open all links in a reference preview's content in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486289 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [18:10:05] (03Merged) 10jenkins-bot: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [18:10:08] (03Merged) 10jenkins-bot: Hygiene: move imports above constants [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486309 (owner: 10Niedzielski) [18:10:10] (03CR) 10jerkins-bot: [V: 04-1] Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:10:13] (03CR) 10jerkins-bot: [V: 04-1] Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [18:12:27] (03CR) 10jenkins-bot: Hygiene: move imports above constants [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486309 (owner: 10Niedzielski) [18:14:03] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review: Help panel: enable searching help articles - https://phabricator.wikimedia.org/T209301 (10Etonkovidova) Ellipses have been added: {F28017814} The search is identical to - the screenshots are from betalabs with... [18:15:08] 10Research, 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review: Citation Usage instrumentation issues - https://phabricator.wikimedia.org/T212937 (10bmansurov) @EBernhardson would you please review https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikim... [18:15:29] (03CR) 10jenkins-bot: MobileFrontend.skin.hooks: Cover getPluralLicenseInfo with NULL $msgObj [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [18:16:55] 10Anti-Harassment (Bet — ב), 10Patch-For-Review: Update beta partial block config to match production - https://phabricator.wikimedia.org/T214596 (10dbarratt) 05Open→03Resolved [18:18:03] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Build AMC opt-in toggle - https://phabricator.wikimedia.org/T211197 (10Jdlrobson) [18:18:10] (03PS11) 10Jack Phoenix: [WIP][DNM] Merge the Theme extension into core [core] - 10https://gerrit.wikimedia.org/r/465451 (https://phabricator.wikimedia.org/T122924) [18:18:58] (03CR) 10Thiemo Kreuz (WMDE): Rewrite title module to preserve all link's #fragments (033 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:23:19] 10Repository-Ownership-Requests: Requesting repository ownership for /mediawiki/extensions/OdbcDatabase - https://phabricator.wikimedia.org/T214618 (10Siacali) [18:24:29] (03CR) 10Sharvaniharan: [C: 03+2] Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 (owner: 10Dbrant) [18:24:47] (03CR) 10MarcoAurelio: [C: 03+2] Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [18:25:26] 10MediaWiki-Codesniffer, 10good first bug: MediaWiki Codesniffer not catching irrelevant characters after PHPDoc return types - https://phabricator.wikimedia.org/T214591 (10Umherirrender) It is looking for punctations (regex class `\p{P}` which include \ when looking at https://www.fileformat.info/info/unicode... [18:29:38] (03Merged) 10jenkins-bot: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [18:30:11] (03PS1) 10Thiemo Kreuz (WMDE): Move default "Footnote" title from gateway to renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486342 (https://phabricator.wikimedia.org/T213907) [18:33:04] (03CR) 10Jforrester: [C: 03+2] HTMLForm OOUI: Reduce distance between flatlist label and widgets [core] - 10https://gerrit.wikimedia.org/r/486198 (owner: 10VolkerE) [18:35:03] (03CR) 10D3r1ck01: "@Thiemo, your prediction came to pass and it was true. See https://doc.wikimedia.org/cover-extensions/MobileFrontend/MobileFrontend.skin.h" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486248 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [18:35:22] (03PS1) 10Pmiazga: If wikidatadata description exists, set it as tagline [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486343 (https://phabricator.wikimedia.org/T214606) [18:35:55] 10Community-Relations: Make a magic, self-labeling feedback button - https://phabricator.wikimedia.org/T214081 (10Quiddity) a:03Quiddity Me, I offered to help genericize the existing template to make it easier to re-adapt in the future. I asked Sherry to file a task so that I could remember later without havin... [18:35:59] (03PS7) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) [18:36:21] 10Community-Relations: Make a magic, self-labeling feedback button - https://phabricator.wikimedia.org/T214081 (10Quiddity) p:05Triage→03Low [18:36:40] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Manually rebased. Confirmed that no changes have been made. Restoring the previous +2." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:37:05] (03CR) 10Jdlrobson: [C: 03+2] If wikidatadata description exists, set it as tagline [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486343 (https://phabricator.wikimedia.org/T214606) (owner: 10Pmiazga) [18:37:14] 10Dumps-Generation, 10Patch-For-Review: Produce multistream dumps in parallel - https://phabricator.wikimedia.org/T213912 (10ArielGlenn) The manual reruns are complete except for commons and wikidata. [18:37:54] 10Wikimedia-Site-requests: Enable Gadgets tab in preferences of atj.wp - https://phabricator.wikimedia.org/T214595 (10Umherirrender) 05Open→03Invalid p:05Triage→03Normal According to https://atj.wikipedia.org/wiki/Kotakahi:Version the extension is installed. According to https://atj.wikipedia.org/wiki/K... [18:39:10] (03Merged) 10jenkins-bot: Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 (owner: 10Dbrant) [18:39:35] (03PS2) 10Dbrant: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [18:40:01] (03CR) 10Anomie: "English grammar can be hard and weird, because English is hard and weird. Even native speakers have trouble sometimes." (038 comments) [core] - 10https://gerrit.wikimedia.org/r/486129 (owner: 10Zppix) [18:40:28] (03CR) 10Sharvaniharan: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485332 (owner: 10Sharvaniharan) [18:40:32] (03PS2) 10Dbrant: Modernize handling of errors from the API. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485238 [18:40:41] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10Regression: [Regression] Menu panel has black background when another drawer is first opened - https://phabricator.wikimedia.org/T211691 (10Jdlrobson) a:05... [18:40:48] (03Abandoned) 10Jdlrobson: Make Drawer's contract clearer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485972 (https://phabricator.wikimedia.org/T211691) (owner: 10Jdlrobson) [18:40:57] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban): Document the process for tagging, signing and preparing a tarball release. - https://phabricator.wikimedia.org/T211655 (10mmodell) [18:40:59] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [18:41:07] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban): Document the process for tagging, signing and preparing a tarball release. - https://phabricator.wikimedia.org/T211655 (10mmodell) 05Open→03Resolved [18:41:09] 10MediaWiki-Releasing, 10MW-1.32-notes, 10MW-1.32-release, 10Release-Engineering-Team (Kanban), 10User-MacFan4000: Release MW 1.32 - https://phabricator.wikimedia.org/T207529 (10mmodell) [18:41:11] 10MediaWiki-Releasing, 10Release-Engineering-Team, 10Security: Streamline/automate MW tarball security release process - https://phabricator.wikimedia.org/T156445 (10mmodell) [18:41:26] 04(no projects): Audit /etc/apt directories - https://phabricator.wikimedia.org/T214605 (10Aklapper) Hi @jbond. Could you please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task so others can find this task when searching in the corresponding... [18:41:28] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10Regression: [Regression] Menu panel has black background when another drawer is first opened - https://phabricator.wikimedia.org/T211691 (10Jdlrobson) I cha... [18:41:37] (03PS4) 10Sharvaniharan: Clean-up invoke source logic : DescriptionEditActivity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485332 [18:41:58] (03CR) 10jenkins-bot: Update SDK license. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486337 (owner: 10Dbrant) [18:43:21] 10Wikimedia-Site-requests: Enable Gadgets tab in preferences of atj.wp - https://phabricator.wikimedia.org/T214595 (10Aklapper) @Benoit_Rochon: For future reference, please follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when requesting config changes on websites. Thanks! :) [18:43:24] 10MassMessage, 10WorkType-NewFunctionality: Add a behaviour switch to exclude MassMessage from some pages - https://phabricator.wikimedia.org/T214580 (10Umherirrender) "The MassMessage extension allows a user to send a message to a list of pages via special page Special:MassMessage" Just do not subscribe, whe... [18:43:30] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (10Jdlrobson) As Timo predicted, I am not seeing any impact on any other JS on mobile or desktop. [18:43:55] (03PS2) 10Thiemo Kreuz (WMDE): Rewrite title module to preserve all link's #fragments [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) [18:44:05] (03CR) 10jerkins-bot: [V: 04-1] Rewrite title module to preserve all link's #fragments [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:44:08] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10Patch-For-Review: CX2: Outputs unnecessary self-closing nowiki and div tags inside ref tags - https://phabricator.wikimedia.org/T213256 (10Framawiki) If other samples are wanted, you can see the ones corrected on frwiki https://quarry.wmf... [18:44:31] 10Access-Policy, 10Legalpad, 10Trust-and-Safety: Hide outdated Confidentiality Agreement versions - https://phabricator.wikimedia.org/T214583 (10Aklapper) Thanks, so this is about content in Phabricator and not in any other system. [18:47:39] 10MassMessage, 10WorkType-NewFunctionality: Add a behaviour switch to exclude MassMessage from some pages - https://phabricator.wikimedia.org/T214580 (10MarcoAurelio) @Umherirrender The extension allows (since the very beggining iirc) adding a category to the pages (`massmessage-optout-category`: Category: Opt... [18:48:27] 10Access-Policy, 10Legalpad, 10Trust-and-Safety: Hide outdated Confidentiality Agreement versions - https://phabricator.wikimedia.org/T214583 (10MarcoAurelio) Yup, that is. #access-policy NDAs are all Phabricator Legalpad documents. [18:49:19] (03PS9) 10Dbrant: Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [18:49:26] (03CR) 10Thiemo Kreuz (WMDE): Add QUnit tests for most new reference preview code (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:49:45] (03PS2) 10Dbrant: Refine the find in page action provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485131 (owner: 10Cooltey) [18:49:58] (03PS2) 10Dbrant: Follow-up to find text while editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 [18:50:00] 10Discovery-Search (Current work): NLP contractor set up and access - https://phabricator.wikimedia.org/T212885 (10TJones) [18:51:04] (03Merged) 10jenkins-bot: HTMLForm OOUI: Reduce distance between flatlist label and widgets [core] - 10https://gerrit.wikimedia.org/r/486198 (owner: 10VolkerE) [18:51:06] (03Merged) 10jenkins-bot: Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:51:09] (03Merged) 10jenkins-bot: If wikidatadata description exists, set it as tagline [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486343 (https://phabricator.wikimedia.org/T214606) (owner: 10Pmiazga) [18:51:32] (03PS2) 10Dbrant: Wikitext keyboard overlay: initial buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 [18:51:34] (03CR) 10VolkerE: [C: 04-1] Add client side click to undo on thank (037 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [18:52:44] (03CR) 10VolkerE: [C: 04-1] Add client side click to undo on thank (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [18:53:16] (03CR) 10jenkins-bot: Add QUnit tests for most new reference preview code [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486137 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [18:53:18] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10Umherirrender) MediaWiki is encoding the ? to %3F when using it in forms. When visiting https://en.wiki... [18:53:44] (03CR) 10jenkins-bot: HTMLForm OOUI: Reduce distance between flatlist label and widgets [core] - 10https://gerrit.wikimedia.org/r/486198 (owner: 10VolkerE) [18:53:58] (03CR) 10VolkerE: [C: 04-1] "Side-note: stylelint needs to be added as follow-up" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/442749 (https://phabricator.wikimedia.org/T63737) (owner: 10Jdlrobson) [18:54:33] 10Discovery-Search (Current work): NLP contractor set up and access - https://phabricator.wikimedia.org/T212885 (10TJones) [18:55:23] (03CR) 10Jdlrobson: [C: 03+2] "I'm sorry, but I don't share your concerns here. A few comments inline." [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [18:55:37] 10Phabricator, 10Release-Engineering-Team: Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10greg) Oops, those are mine. I wonder if I can convert them to non-global? Their mostly just used on my own personal dashboard.... [18:55:41] (03PS3) 10Cooltey: Fix: using the normalized title for the featured article widget [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485327 [18:56:29] (03CR) 10jenkins-bot: If wikidatadata description exists, set it as tagline [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486343 (https://phabricator.wikimedia.org/T214606) (owner: 10Pmiazga) [18:57:50] 10MediaWiki-Parser, 10Parsoid, 10TemplateStyles: TemplateStyles breaks a paragraph if a file is inserted inline - https://phabricator.wikimedia.org/T208901 (10Anomie) >>! In T208901#4905116, @Great_Brightstar wrote: > With this indicator the TemplateStyles loaded only once, but not affect any paragraphs. It... [19:00:43] (03CR) 10Jforrester: [C: 03+2] Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486258 (owner: 10Daimona Eaytoy) [19:00:43] (03CR) 10Jforrester: [C: 03+2] Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486333 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [19:03:19] (03CR) 10EBernhardson: [C: 03+2] Merge remote-tracking branch 'origin/master' into HEAD [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486331 (owner: 10EBernhardson) [19:05:45] (03CR) 10Dbrant: [C: 03+2] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:06:33] (03CR) 10Reedy: "Honestly don't think it's worth running scap just for this! :)" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [19:06:47] (03CR) 10Jforrester: [C: 03+2] Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 (owner: 10Daimona Eaytoy) [19:07:13] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:08:20] (03CR) 10Jforrester: "> Patch Set 3:" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/486277 (https://phabricator.wikimedia.org/T208097) (owner: 10Reedy) [19:08:35] (03PS1) 10Jforrester: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486347 (https://phabricator.wikimedia.org/T208097) [19:09:35] 10MassMessage, 10WorkType-NewFunctionality: Add a behaviour switch to exclude MassMessage from some pages - https://phabricator.wikimedia.org/T214580 (10Umherirrender) Okay, that information was missing for me in the task description. So you want change the way the addition of the category to pages is managed... [19:09:39] 04(no projects): Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Skalman) [19:09:45] (03PS1) 10MarcoAurelio: [CollapsibleHeadings] Register extension [extensions] - 10https://gerrit.wikimedia.org/r/486348 [19:10:10] (03CR) 10MarcoAurelio: [V: 03+2 C: 03+2] [CollapsibleHeadings] Register extension [extensions] - 10https://gerrit.wikimedia.org/r/486348 (owner: 10MarcoAurelio) [19:11:01] (03PS1) 10Jdlrobson: skins.minerva.editor is never loaded [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486349 (https://phabricator.wikimedia.org/T213340) [19:11:54] 10MediaWiki-Decoupling: Title should not use Action - https://phabricator.wikimedia.org/T214626 (10Tgr) [19:12:48] (03CR) 10Anomie: Password: replace equals() with verify() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486205 (owner: 10MaxSem) [19:13:35] (03CR) 10EBernhardson: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/450059 (owner: 10DCausse) [19:14:22] 10MassMessage, 10WorkType-NewFunctionality: Add a behaviour switch to exclude MassMessage from some pages - https://phabricator.wikimedia.org/T214580 (10MarcoAurelio) [19:14:50] 10Google-Summer-of-Code (2019): Improving recommender system for wiki media - https://phabricator.wikimedia.org/T214421 (10srishakatux) @Chaitanya Thanks for creating the task here! I think what might be helpful if you could refine your idea a bit more, share how it would be similar to SuggestBot / Recommender S... [19:15:25] (03Merged) 10jenkins-bot: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486258 (owner: 10Daimona Eaytoy) [19:15:27] (03Merged) 10jenkins-bot: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486333 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [19:16:57] 10Product-Analytics: Data QA for Wikidata descriptions editing eventlogging on iOS app - https://phabricator.wikimedia.org/T214627 (10chelsyx) [19:17:05] (03CR) 10jerkins-bot: [V: 04-1] Introduce a new way to identify namespaces [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/450059 (owner: 10DCausse) [19:17:07] (03PS3) 10Dbrant: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:17:21] 10Product-Analytics: Data QA for Wikidata descriptions editing eventlogging on iOS app - https://phabricator.wikimedia.org/T214627 (10chelsyx) [19:17:42] (03CR) 10Jforrester: [C: 03+2] Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486347 (https://phabricator.wikimedia.org/T208097) (owner: 10Jforrester) [19:17:47] (03CR) 10jenkins-bot: Special:WelcomeSurvey Vietnamese alias [extensions/GrowthExperiments] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486333 (https://phabricator.wikimedia.org/T213356) (owner: 10Sbisson) [19:18:52] (03CR) 10Sharvaniharan: [C: 03+2] Fix: using the normalized title for the featured article widget [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485327 (owner: 10Cooltey) [19:20:06] (03PS3) 10Dbrant: Wikitext keyboard overlay: initial buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 [19:20:22] (03CR) 10Dbrant: [C: 03+2] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:20:52] (03CR) 10Dbrant: Wikitext keyboard overlay: initial buttons. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 (owner: 10Dbrant) [19:21:16] (03CR) 10jenkins-bot: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486258 (owner: 10Daimona Eaytoy) [19:21:34] (03PS4) 10Cooltey: [HOLD] Build my contributions page [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485346 (https://phabricator.wikimedia.org/T207339) [19:21:36] (03Merged) 10jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486331 (owner: 10EBernhardson) [19:21:38] (03Merged) 10jenkins-bot: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 (owner: 10Daimona Eaytoy) [19:22:43] (03Merged) 10jenkins-bot: Add message for "BlockAttacker" password policy [extensions/WikimediaMessages] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486347 (https://phabricator.wikimedia.org/T208097) (owner: 10Jforrester) [19:25:58] 10Research, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22): Citation Usage instrumentation issues - https://phabricator.wikimedia.org/T212937 (10bmansurov) 05Open→03Resolved Thanks, everyone, who helped move this task along. [19:27:16] 04(no projects): jenkins-bot operations-puppet-catalog-compiler-test ( 'check experimental') can report SUCCESS when compiling actually failed - https://phabricator.wikimedia.org/T214629 (10Dzahn) [19:28:13] 04(no projects): jenkins-bot puppet-compiler-test may report SUCCESS though compiling failed - https://phabricator.wikimedia.org/T214629 (10Dzahn) [19:29:35] 10MediaWiki-Cache, 10MediaWiki Language Extension Bundle, 10Operations, 10Language-Team (Language-2019-January-March), and 5 others: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10Etonkovidova) Thanks, @eluke... [19:33:12] (03Merged) 10jenkins-bot: Fix: using the normalized title for the featured article widget [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485327 (owner: 10Cooltey) [19:34:07] (03CR) 10jenkins-bot: Merge remote-tracking branch 'origin/master' into HEAD [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486331 (owner: 10EBernhardson) [19:35:44] (03CR) 10jenkins-bot: Fix: using the normalized title for the featured article widget [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485327 (owner: 10Cooltey) [19:40:56] (03CR) 10jenkins-bot: Optionally pass the filter ID to checkConditions for error reporting [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486224 (owner: 10Daimona Eaytoy) [19:42:06] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:42:53] 10Discovery-Search (Current work): NLP contractor set up and access - https://phabricator.wikimedia.org/T212885 (10Nuria) Added subtask with what i think is needed to start requesting NDA, I think @TJones needs to do a bit of work to explain project (documentation might exist on meta) [19:43:02] 10Editing Design , 10VisualEditor (Current work): Build Section Editing Prototype - https://phabricator.wikimedia.org/T213429 (10iamjessklein) Based on @Esanders feedback, I would recommend that we tweak the prototype by changing the "Sections" title to an actual page title. {F28020628} The "Edit All" button... [19:43:24] (03CR) 10Dbrant: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:43:28] (03CR) 10Dbrant: [C: 03+2] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:45:53] 10Discovery-Search (Current work): NLP contractor set up and access - https://phabricator.wikimedia.org/T212885 (10TJones) [19:47:41] (03PS1) 10EBernhardson: Handle string result from Response::getFullError [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486351 [19:47:43] (03PS1) 10EBernhardson: es6: {index}/_aliases -> {index}/_alias [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486352 [19:48:07] (03CR) 10Cooltey: [C: 03+2] Wikitext keyboard overlay: initial buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 (owner: 10Dbrant) [19:50:08] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10AVasanth_WMF) 05Open→03Resolved [19:50:21] 10Library-Card-Platform: Fix partner application graph ranges and labels - https://phabricator.wikimedia.org/T171159 (10AVasanth_WMF) 05Open→03Resolved [19:51:00] 10wikimediafoundation.org: Foundation site Board of Trustees page is information-free - https://phabricator.wikimedia.org/T210026 (10Aklapper) This seems to have been silently fixed? [19:51:22] (03CR) 10jerkins-bot: [V: 04-1] es6: {index}/_aliases -> {index}/_alias [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486352 (owner: 10EBernhardson) [19:51:43] (03PS1) 10EBernhardson: Elastica Ids query changed constructor args [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486354 [19:54:02] (03CR) 10Dbrant: [C: 03+2] Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [19:54:51] (03CR) 10jerkins-bot: [V: 04-1] Elastica Ids query changed constructor args [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486354 (owner: 10EBernhardson) [19:54:53] 10Phabricator, 10Release-Engineering-Team (Backlog): Change default search query for tasks - https://phabricator.wikimedia.org/T214579 (10greg) p:05Triage→03Low [19:55:29] (03CR) 10Pastakhov: "Thank you Bill. Sorry, I was hard busy..." [extensions/PhpTags] - 10https://gerrit.wikimedia.org/r/473072 (https://phabricator.wikimedia.org/T188585) (owner: 10BPirkle) [19:56:35] 10MediaWiki-General-or-Unknown: Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Framawiki) By doing your step-by-step procedure I have a "Cette page demande de confirmer sa fermeture ; des données saisies pourraient ne pas être enregistrées."/"This pa... [19:57:29] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [19:57:32] (03PS5) 10Thiemo Kreuz (WMDE): Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) [19:57:45] (03PS3) 10Thiemo Kreuz (WMDE): Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) [19:58:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Poking Jenkins." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [19:58:13] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Poking Jenkins." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [20:01:00] (03PS3) 10Thiemo Kreuz (WMDE): Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 [20:01:39] (03Abandoned) 10EBernhardson: Elastica Ids query changed constructor args [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486354 (owner: 10EBernhardson) [20:01:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 03+2] "Manually rebased. Confirmed that no changes have been made. Restoring the previous +2." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [20:02:47] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Operations, and 3 others: ForeignAPIRepo wrongly returns non-protocol-relative URLs for original "thumbs" - https://phabricator.wikimedia.org/T50133 (10Tacsipacsi) [20:02:51] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10good first bug: Make $wgUseInstantCommons protocol relative - https://phabricator.wikimedia.org/T34219 (10Tacsipacsi) [20:03:25] 10Wikimedia-Site-requests: Tests should detect colons in namespace names dict - https://phabricator.wikimedia.org/T214632 (10Framawiki) [20:03:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "I actually missed the fact the title module is already nicely covered by tests. I will add test cases for the new features." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486252 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [20:03:41] (03PS2) 10EBernhardson: es6: {index}/_aliases -> {index}/_alias [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486352 [20:04:18] (03Merged) 10jenkins-bot: Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [20:04:23] (03Merged) 10jenkins-bot: Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [20:06:42] (03CR) 10jenkins-bot: Add QUnit test for reference preview renderer [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486293 (https://phabricator.wikimedia.org/T213415) (owner: 10Thiemo Kreuz (WMDE)) [20:07:19] 10MediaWiki-Page-editing: Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Aklapper) [20:07:27] (03Merged) 10jenkins-bot: Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [20:08:44] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01... [20:08:48] (03CR) 10jenkins-bot: Add test for opening reference preview links in new tabs [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486297 (https://phabricator.wikimedia.org/T213908) (owner: 10Thiemo Kreuz (WMDE)) [20:09:00] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01... [20:09:05] (03CR) 10Gergő Tisza: [C: 03+2] "> One drawback to this approach versus I0041a856 is that this will have Action::factory() use stale data, for example it'll use the conten" [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [20:09:59] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10User-D3r1ck01: PHPUnit: Cover NULL cases for getPluralLicenseInfo() in MobileFrontendSkinHooks class - https://phabricator.wikimedia.org/T209765 (10D3r1ck01) [20:10:56] (03CR) 10jenkins-bot: Replace rare {!…} and {?…} JSDoc syntax [extensions/Popups] - 10https://gerrit.wikimedia.org/r/486325 (owner: 10Thiemo Kreuz (WMDE)) [20:11:37] (03Merged) 10jenkins-bot: Wikitext keyboard overlay: initial buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 (owner: 10Dbrant) [20:11:39] (03CR) 10jerkins-bot: [V: 04-1] Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:12:00] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, boolean_operato" [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486352 (owner: 10EBernhardson) [20:13:07] (03CR) 10Dbrant: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [20:13:10] (03CR) 10Dbrant: [C: 03+2] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [20:14:00] (03CR) 10Dbrant: "@Cooltey pls rebase and i'll merge." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:14:22] 10MediaWiki-extension-requests, 10MediaWiki-extensions-SparkPost, 10User-D3r1ck01: [Extension Request] Build a SparkPost Email Delivery extension for MediaWiki - https://phabricator.wikimedia.org/T212847 (10D3r1ck01) p:05Triage→03Low [20:14:48] (03CR) 10jenkins-bot: Wikitext keyboard overlay: initial buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485041 (owner: 10Dbrant) [20:16:40] 10MediaWiki-General-or-Unknown: Title::loadFromRow() should return a new instance of Title - https://phabricator.wikimedia.org/T214546 (10Tgr) WikiPage and Title are both sort of value objects for the page table, which predictably causes a mess. At least one of them should be killed or detached from row-level da... [20:17:00] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Performance-Team (Radar): Investigate impact and protection from errors in banners JS - https://phabricator.wikimedia.org/T214410 (10AndyRussG) >>! In T214410#4906690, @Jdlrobson wrote: > As Timo predicted, I am not seeing any impact on any other... [20:17:46] 10MediaWiki-extensions-Babel: User categories creation should be able to use templates - https://phabricator.wikimedia.org/T211665 (10Epok) [20:18:37] (03PS10) 10Cooltey: Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) [20:19:13] (03CR) 10Cooltey: "> @Cooltey pls rebase and i'll merge." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:19:25] (03PS3) 10Cooltey: Refine the find in page action provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485131 [20:19:45] (03PS17) 10Dbrant: [SORT OF WIP] Extended keyboard overlay buttons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) [20:19:54] 10CommRel-Specialists-Support (Jan-Mar-2019): Community Relations support for proposed system typefaces changes - https://phabricator.wikimedia.org/T214518 (10CKoerner_WMF) [20:19:57] (03PS1) 10D3r1ck01: Add missing `@return` PHPDoc to __sleep() function [core] - 10https://gerrit.wikimedia.org/r/486359 [20:21:55] (03CR) 10Dbrant: [C: 03+2] Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:23:08] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/486359 (owner: 10D3r1ck01) [20:23:44] (03PS3) 10Dbrant: Follow-up to find text while editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 [20:24:05] (03Merged) 10jenkins-bot: Clone the Title object to prevent mutations. [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [20:24:36] 10MediaWiki-General-or-Unknown, 10MediaWiki-Special-pages: Pages that autofill the username of an account get cut off with usernames that contain '?' within it - https://phabricator.wikimedia.org/T214565 (10matmarex) The '?' must be parsed as a separator for parameters, rather than as part of the page title:... [20:26:09] (03CR) 10Brian Wolff: [C: 03+2] Add missing `@return` PHPDoc to __sleep() function [core] - 10https://gerrit.wikimedia.org/r/486359 (owner: 10D3r1ck01) [20:26:37] (03CR) 10jenkins-bot: Clone the Title object to prevent mutations. [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [20:28:10] (03CR) 10Fomafix: "The exception from T198054 happens when the parameter `uselang` contains an invalid language code on the POST request. The steps to reprod" [core] - 10https://gerrit.wikimedia.org/r/486327 (https://phabricator.wikimedia.org/T198054) (owner: 10D3r1ck01) [20:28:58] (03CR) 10jerkins-bot: [V: 04-1] Refine the find in page action provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485131 (owner: 10Cooltey) [20:29:24] 10Growth-Team: WelcomeSurvey: Links at the bottom of sidebar are invisible without scrolling - https://phabricator.wikimedia.org/T214634 (10Urbanecm) [20:31:01] 10MediaWiki-General-or-Unknown: Title::getFragmentForURL can throw an error - https://phabricator.wikimedia.org/T214635 (10MarkAHershberger) [20:32:32] (03PS1) 10Gergő Tisza: Clone the Title object to prevent mutations. [core] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486369 (https://phabricator.wikimedia.org/T210739) [20:33:05] 10MediaWiki-General-or-Unknown: Title::getFragmentForURL can throw an error - https://phabricator.wikimedia.org/T214635 (10MarkAHershberger) 05Open→03Resolved [20:34:22] (03PS2) 10Esanders: build: Update eslint-config-wikimedia to 0.10.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/485120 [20:35:40] (03CR) 10Framawiki: "\o/" [core] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486369 (https://phabricator.wikimedia.org/T210739) (owner: 10Gergő Tisza) [20:36:43] 10MediaWiki-Page-editing: Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Skalman) @Framawiki, I'll clarify: The problem exists on mobile Safari. Firefox works as expected. [20:37:02] (03PS1) 10Dbrant: Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 [20:37:43] (03PS18) 10Niedzielski: Hygiene: reduce jQuery in lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) [20:37:45] (03PS16) 10Niedzielski: Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) [20:37:47] (03PS12) 10Niedzielski: Hygiene: move lazy image loader placeholder query [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484305 (https://phabricator.wikimedia.org/T211724) [20:37:49] (03PS9) 10Niedzielski: Hygiene: remove Skin "changed" event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484576 (https://phabricator.wikimedia.org/T211724) [20:37:51] (03PS8) 10Niedzielski: Hygiene: isolate lazy image load state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484748 (https://phabricator.wikimedia.org/T211724) [20:37:53] (03PS7) 10Niedzielski: Hygiene: separate lazy references loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484767 (https://phabricator.wikimedia.org/T211724) [20:37:55] (03PS5) 10Niedzielski: Hygiene: make lazyImageLoader jQuery usage consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485122 (https://phabricator.wikimedia.org/T211724) [20:37:57] (03PS1) 10Niedzielski: Hygiene: add tests to lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486372 (https://phabricator.wikimedia.org/T211724) [20:37:59] (03PS11) 10Niedzielski: Hygiene: revise lazyImageLoader.loadImages() API [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483516 (https://phabricator.wikimedia.org/T211724) [20:38:01] (03PS10) 10Niedzielski: Update: use lazyImageLoader to query placeholders [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/484306 (https://phabricator.wikimedia.org/T211724) [20:38:44] (03CR) 10Niedzielski: "Tests are up in I721ee4b695790b433d953d6a041ea89f36625e51." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [20:38:59] (03Abandoned) 10Niedzielski: POC: Hygiene: replace section-toggled events [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/485956 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [20:39:02] (03Abandoned) 10Niedzielski: POC: Hygiene: replace section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485957 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [20:40:00] (03CR) 10Gergő Tisza: "> Patch Set 1: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/486178 (https://phabricator.wikimedia.org/T210739) (owner: 10Dbarratt) [20:40:35] (03Merged) 10jenkins-bot: Add missing `@return` PHPDoc to __sleep() function [core] - 10https://gerrit.wikimedia.org/r/486359 (owner: 10D3r1ck01) [20:41:01] 10MediaWiki-General-or-Unknown: Title::getFragmentForURL can throw an error - https://phabricator.wikimedia.org/T214635 (10MarkAHershberger) 05Resolved→03Open Dupe of T204800 [20:41:26] 10MediaWiki-Page-editing, 10Browser-Support-Apple-Safari: Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Framawiki) Ok, thanks for the detail. The link you provided (https://sv.wiktionary.org/w/index.php?title=Diskussion:asdf&action=edit) is to the... [20:41:43] (03PS1) 10EBernhardson: super_detect_noop: noop op type -> none [search/extra] - 10https://gerrit.wikimedia.org/r/486373 [20:41:44] 10MediaWiki-General-or-Unknown: Title::getFragmentForURL can throw an error - https://phabricator.wikimedia.org/T214635 (10MarkAHershberger) [20:41:47] 10MediaWiki-General-or-Unknown, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Waiting for Review), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), and 2 others: Unable to view Special:DoubleRedirects on tt... - https://phabricator.wikimedia.org/T204800 [20:41:59] (03Merged) 10jenkins-bot: Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:43:09] (03PS4) 10Cooltey: Refine the find in page action provider [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485131 [20:43:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485602 (owner: 10L10n-bot) [20:45:05] 10MediaWiki-Revision-deletion: RevisionDeletion log does not move to new title after page move. - https://phabricator.wikimedia.org/T214551 (10Oshwah) @Ammarpad - Correct. [20:45:35] (03CR) 10jenkins-bot: Add "find text" function when editing [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/483890 (https://phabricator.wikimedia.org/T89202) (owner: 10Cooltey) [20:45:38] (03CR) 10jenkins-bot: Add missing `@return` PHPDoc to __sleep() function [core] - 10https://gerrit.wikimedia.org/r/486359 (owner: 10D3r1ck01) [20:47:03] 10Page-Issue-Warnings, 10Readers-Web-Backlog: "Learn more" white flash when opening navigation menu - https://phabricator.wikimedia.org/T214550 (10Jdlrobson) I cannot reproduce this on production. Are you sure the problem is still present? [20:47:57] 10Phabricator, 10Operations, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External): Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) >>! In T190568#4903583, @mmodell wrote: > https://wikitech.wikimedia.org/wiki/Phabricator/Meeting_Notes/2019... [20:48:02] (03PS1) 10Jdlrobson: mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) [20:48:45] (03PS1) 10Esanders: Remove education popups hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486377 [20:49:27] (03PS1) 10Daimona Eaytoy: Fix MWException from AbuseFilterView [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486378 [20:49:39] 10Phabricator, 10Operations, 10serviceops, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External): Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Paladox) "* 429 Too Many Requests" someone will want to whitelist deploy1001 ip so it's not hit by... [20:49:43] 10Phabricator, 10Operations, 10serviceops, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External): Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) [20:49:49] (03PS1) 10Daimona Eaytoy: Fix MWException from AbuseFilterView [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486379 [20:51:18] (03PS1) 10EBernhardson: Remove max_determined_states BC [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486380 [20:51:29] (03CR) 1020after4: [C: 04-2] Fix MWException from AbuseFilterView [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486379 (owner: 10Daimona Eaytoy) [20:51:38] (03CR) 1020after4: [C: 03+2] Fix MWException from AbuseFilterView [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486379 (owner: 10Daimona Eaytoy) [20:55:29] (03CR) 10jerkins-bot: [V: 04-1] Follow-up to find text while editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 (owner: 10Dbrant) [20:55:37] 10Wikimedia-Site-requests: Tests should detect colons in wgExtraNamespaces - https://phabricator.wikimedia.org/T214632 (10Framawiki) [20:56:11] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 (owner: 10Dbrant) [20:58:40] 10Phabricator, 10Operations, 10serviceops, 10Patch-For-Review, 10Release-Engineering-Team (Watching / External): Reimage both phab1001 and phab2001 to stretch - https://phabricator.wikimedia.org/T190568 (10Dzahn) [21:01:53] 10Product-Analytics: YoY mobile edit rates in mobile-heavy wiki segment - https://phabricator.wikimedia.org/T214134 (10JKatzWMF) @nettrom_WMF @kzimmerman this is exactly what I needed. No more, no less and on time. Thanks! [21:02:30] (03CR) 10Daimona Eaytoy: [C: 03+2] "(Already backported)" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486378 (owner: 10Daimona Eaytoy) [21:02:40] (03CR) 10jerkins-bot: [V: 04-1] mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) (owner: 10Jdlrobson) [21:04:16] (03PS19) 10Niedzielski: Hygiene: reduce jQuery in lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) [21:04:18] (03PS17) 10Niedzielski: Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) [21:04:20] (03PS13) 10Niedzielski: Hygiene: move lazy image loader placeholder query [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484305 (https://phabricator.wikimedia.org/T211724) [21:04:22] (03PS10) 10Niedzielski: Hygiene: remove Skin "changed" event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484576 (https://phabricator.wikimedia.org/T211724) [21:04:24] (03PS9) 10Niedzielski: Hygiene: isolate lazy image load state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484748 (https://phabricator.wikimedia.org/T211724) [21:04:26] (03PS8) 10Niedzielski: Hygiene: separate lazy references loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484767 (https://phabricator.wikimedia.org/T211724) [21:04:28] (03PS6) 10Niedzielski: Hygiene: make lazyImageLoader jQuery usage consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485122 (https://phabricator.wikimedia.org/T211724) [21:04:30] (03PS2) 10Niedzielski: Hygiene: add tests to lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486372 (https://phabricator.wikimedia.org/T211724) [21:05:08] (03CR) 10Niedzielski: Hygiene: reduce jQuery in lazyImageLoader (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:05:43] (03CR) 10Dbrant: [C: 04-1] Clean-up invoke source logic : DescriptionEditActivity (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/485332 (owner: 10Sharvaniharan) [21:06:54] (03PS18) 10Niedzielski: Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) [21:06:55] 10Product-Analytics: Android navigation refresh - understand impact on user engagement metrics - https://phabricator.wikimedia.org/T211366 (10mpopov) >>! In T211366#4900240, @JKatzWMF wrote: > @charlotte @mpopov > > # i saw in the ticket about the bug that hundreds of duplicate events were being sent. > #... [21:06:56] (03PS14) 10Niedzielski: Hygiene: move lazy image loader placeholder query [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484305 (https://phabricator.wikimedia.org/T211724) [21:06:58] (03PS11) 10Niedzielski: Hygiene: remove Skin "changed" event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484576 (https://phabricator.wikimedia.org/T211724) [21:07:00] (03PS10) 10Niedzielski: Hygiene: isolate lazy image load state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484748 (https://phabricator.wikimedia.org/T211724) [21:07:02] (03PS9) 10Niedzielski: Hygiene: separate lazy references loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484767 (https://phabricator.wikimedia.org/T211724) [21:07:04] (03PS7) 10Niedzielski: Hygiene: make lazyImageLoader jQuery usage consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485122 (https://phabricator.wikimedia.org/T211724) [21:07:06] (03PS3) 10Niedzielski: Hygiene: add tests to lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486372 (https://phabricator.wikimedia.org/T211724) [21:07:08] (03CR) 10Niedzielski: Hygiene: consolidate section-toggled events (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:08:35] (03Merged) 10jenkins-bot: Fix MWException from AbuseFilterView [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486379 (owner: 10Daimona Eaytoy) [21:11:08] (03PS2) 10Jdlrobson: mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) [21:11:46] (03PS3) 10Jdlrobson: mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) [21:13:46] (03PS1) 10EBernhardson: Various es6 compat issues [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486383 [21:14:06] 10MediaWiki-Page-editing, 10Browser-Support-Apple-Safari: Leaving page when editing doesn't show warning (mobile Safari) - https://phabricator.wikimedia.org/T214625 (10Skalman) Yes, that's correct: I'm using Safari on Iphone. I explicitly chose the desktop version of the site. (I feel like I'm repeating mysel... [21:15:05] (03CR) 10Krinkle: "LGTM, but will want to do a full search on Grafana to make sure we find all existing uses first, also to help inform if the current nestin" [core] - 10https://gerrit.wikimedia.org/r/486323 (owner: 10Addshore) [21:15:38] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Design): Reduce height of mobile page issues banner - https://phabricator.wikimedia.org/T214549 (10Jdlrobson) 1) I'm seeing 8px of space at the bottom of https://en.m.wikipedia.org/wiki/Sergei_Yudin_(surgeon) due to the bottom padding (not 14px so not sure if this... [21:16:09] (03CR) 10Addshore: "We could leave the old metric names reporting for a "transition period", removing them in a future branch / patch / week" [core] - 10https://gerrit.wikimedia.org/r/486323 (owner: 10Addshore) [21:16:39] (03CR) 10jenkins-bot: Fix MWException from AbuseFilterView [extensions/AbuseFilter] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486379 (owner: 10Daimona Eaytoy) [21:18:20] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: reduce jQuery in lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:18:56] (03Merged) 10jenkins-bot: Fix MWException from AbuseFilterView [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486378 (owner: 10Daimona Eaytoy) [21:19:30] 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Editor code is packaged in 2 modules - https://phabricator.wikimedia.org/T214200 (10Niedzielski) a:05Niedzielski... [21:19:46] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Design): Reduce height of mobile page issues banner and offset of learn more - https://phabricator.wikimedia.org/T214549 (10Jdlrobson) [21:20:09] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Design): Reduce height of mobile page issues banner and offset of learn more - https://phabricator.wikimedia.org/T214549 (10Jdlrobson) Problem 2: To clarify would we be making these change for all pages? [21:20:43] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Design): Reduce height of mobile page issues banner and offset of learn more - https://phabricator.wikimedia.org/T214549 (10Jdlrobson) [21:20:45] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10Jdlrobson) [21:20:47] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Fix offset of "Learn more" link - https://phabricator.wikimedia.org/T214548 (10Jdlrobson) While analysing this I noticed that changes here impact T214549 so I've merged these 2 tasks so we can think of them together. [21:20:52] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:21:10] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Epic: [EPIC} Mobile page issues banner: CSS/styling cleanup - https://phabricator.wikimedia.org/T214526 (10Jdlrobson) [21:21:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/486384 (owner: 10L10n-bot) [21:23:10] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: AMC feature flag can be superseded by a development query parameter - https://phabricator.wikimedia.org/T212800 (10Jdlrobson) p:05Normal→03Low Marking as low until we have a pressing need. Adding such a flag would complicate our configuration code and... [21:23:28] (03PS20) 10Niedzielski: Hygiene: reduce jQuery in lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) [21:23:30] (03PS19) 10Niedzielski: Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) [21:23:32] (03PS15) 10Niedzielski: Hygiene: move lazy image loader placeholder query [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484305 (https://phabricator.wikimedia.org/T211724) [21:23:34] (03PS12) 10Niedzielski: Hygiene: remove Skin "changed" event [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484576 (https://phabricator.wikimedia.org/T211724) [21:23:36] (03PS11) 10Niedzielski: Hygiene: isolate lazy image load state [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484748 (https://phabricator.wikimedia.org/T211724) [21:23:38] (03PS10) 10Niedzielski: Hygiene: separate lazy references loading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484767 (https://phabricator.wikimedia.org/T211724) [21:23:40] (03PS8) 10Niedzielski: Hygiene: make lazyImageLoader jQuery usage consistent [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485122 (https://phabricator.wikimedia.org/T211724) [21:23:42] (03PS4) 10Niedzielski: Hygiene: add tests to lazyImageLoader [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486372 (https://phabricator.wikimedia.org/T211724) [21:23:44] (03CR) 10jenkins-bot: Fix MWException from AbuseFilterView [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486378 (owner: 10Daimona Eaytoy) [21:24:49] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: consolidate section-toggled events [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483601 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:25:19] (03CR) 10jerkins-bot: [V: 04-1] Various es6 compat issues [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486383 (owner: 10EBernhardson) [21:26:34] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Technical-Debt: [subtask] Extract beta / stable mode code from MobileContext to new file - https://phabricator.wikimedia.org/T212802 (10Jdlrobson) Chatting through this with Piotr tomorrow (hopefully!) [21:27:03] (03CR) 10jerkins-bot: [V: 04-1] mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) (owner: 10Jdlrobson) [21:27:54] 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Editor code is packaged in 2 modules - https://phabricator.wikimedia.org/T214200 (10Jdlrobson) @Stephen see https:... [21:28:35] (03CR) 10Niedzielski: Update: use lazyImageLoader to query placeholders (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/484306 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [21:28:58] 10MobileFrontend, 10MinervaNeue: Page underneath the overlay flashes for 1 frame when switching between loading overlay and real overlay - https://phabricator.wikimedia.org/T214641 (10matmarex) [21:29:24] (03PS5) 10Krinkle: http: Add type hints to parameters in some methods [core] - 10https://gerrit.wikimedia.org/r/480540 (owner: 10D3r1ck01) [21:31:14] (03CR) 10Krinkle: [C: 03+2] Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [21:31:58] 10MediaWiki-Vagrant, 10Proton, 10Reading-Infrastructure-Team-Backlog (Kanban): Add MediaWiki-Vagrant role for Proton - https://phabricator.wikimedia.org/T213367 (10Tgr) a:03Tgr [21:32:15] 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Editor code is packaged in 2 modules - https://phabricator.wikimedia.org/T214200 (10Niedzielski) @jdlrobson, shoul... [21:32:30] (03PS10) 10Krinkle: http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [21:32:52] (03CR) 10Krinkle: [C: 03+2] "Failed because Wikibase extends the class and also needed its signature fixed." [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [21:33:09] (03CR) 10Krinkle: [C: 03+2] http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [21:33:45] (03PS1) 10Bartosz Dziewoński: Add #loadModuleAndGetOverlay: a nicer way to use LoadingOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486385 (https://phabricator.wikimedia.org/T201687) [21:33:51] (03PS1) 10Bartosz Dziewoński: Improve loading screens by using #loadModuleAndGetOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486386 (https://phabricator.wikimedia.org/T201687) [21:34:03] (03PS1) 10Bartosz Dziewoński: Improve loading screens by using #loadModuleAndGetOverlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486387 (https://phabricator.wikimedia.org/T201687) [21:34:12] (03CR) 10Jforrester: [C: 03+2] Remove education popups hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486377 (owner: 10Esanders) [21:34:57] (03PS6) 10Krinkle: http: Add type hints to parameters in some methods [core] - 10https://gerrit.wikimedia.org/r/480540 (owner: 10D3r1ck01) [21:35:09] (03PS1) 10Bartosz Dziewoński: LoadingOverlay: Set translucency using rgba() color instead of opacity [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486388 (https://phabricator.wikimedia.org/T201687) [21:35:19] (03Abandoned) 10Krinkle: http: Add type hints to parameters in some methods [core] - 10https://gerrit.wikimedia.org/r/480540 (owner: 10D3r1ck01) [21:35:43] 10MobileFrontend, 10MinervaNeue, 10Patch-For-Review: Page underneath the overlay flashes for 1 frame when switching between loading overlay and real overlay - https://phabricator.wikimedia.org/T214641 (10matmarex) a:03matmarex [21:36:33] (03CR) 10D3r1ck01: "Oh, no problem! Thanks!" [core] - 10https://gerrit.wikimedia.org/r/480540 (owner: 10D3r1ck01) [21:40:49] 10AbuseFilter: Short circuit breaks with multiple operations - https://phabricator.wikimedia.org/T214642 (10Daimona) [21:40:53] (03CR) 10Isarra: "One of the main problems with MediaWiki skins and skin-whatever compatibility currently is the wild inconsistency between the skins themse" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:41:01] (03PS2) 10MaxSem: Password: replace equals() with verify() [core] - 10https://gerrit.wikimedia.org/r/486205 [21:41:03] (03PS2) 10MaxSem: WIP: Add support for Argon2 password hashing [core] - 10https://gerrit.wikimedia.org/r/486206 [21:41:50] (03CR) 10MaxSem: Password: replace equals() with verify() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/486205 (owner: 10MaxSem) [21:42:28] 10MediaWiki-extensions-Translate, 10Fundraising-Backlog, 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review, 10Technical-Debt: Support custom permissions for a subset of translatable pages - https://phabricator.wikimedia.org/T213943 (10awight) [21:42:47] (03CR) 10Cooltey: [C: 03+2] Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 (owner: 10Dbrant) [21:44:09] (03CR) 10Krinkle: "@Isarra There will be no DOM changes. There will be no interface changes to Skin or SkinTemplate. MW core remains compatible. Vector outpu" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:44:37] 10AbuseFilter: Syntax check should be consistent with actual parsing - https://phabricator.wikimedia.org/T214643 (10Daimona) [21:45:59] 10Patch-For-Review, 10Readers-Web-Backlog (Design): [Bug] Async loading code if failing occludes the page and disables interactivity - https://phabricator.wikimedia.org/T201687 (10matmarex) I investigated this since it was one of the issues we faced in work on VisualEditor overlay: {T210630} Note that this im... [21:46:09] (03PS2) 10Urbanecm: Resize to 100x100 and optimize avatars [All-Avatars] - 10https://gerrit.wikimedia.org/r/465777 (owner: 10Dereckson) [21:47:02] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Create AMC edit tag - https://phabricator.wikimedia.org/T212959 (10ovasileva) [21:47:08] (03CR) 10Bartosz Dziewoński: "I only carefully tested the talk overlay, I need to set up the other ones for testing locally" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486387 (https://phabricator.wikimedia.org/T201687) (owner: 10Bartosz Dziewoński) [21:47:13] (03CR) 10Isarra: "@Krinkle: That's good, but doesn't change anything with regards to the complexity concerns." [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:50:02] (03PS2) 10Bartosz Dziewoński: LoadingOverlay: Set translucency using rgba() color instead of opacity [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486388 (https://phabricator.wikimedia.org/T201687) [21:50:33] (03CR) 10Isarra: "I didn't find any related tickets for this specifically - can you direct me to that?" [skins/Vector] - 10https://gerrit.wikimedia.org/r/485998 (https://phabricator.wikimedia.org/T140664) (owner: 10Krinkle) [21:50:59] (03PS3) 10Urbanecm: Resize to 100x100 and optimize avatars [All-Avatars] - 10https://gerrit.wikimedia.org/r/465777 (owner: 10Dereckson) [21:51:45] (03CR) 10jerkins-bot: [V: 04-1] http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [21:52:19] 10Event Metrics: Implement new informational fields on the Event Settings page (so the data can appear on Event Summary screen) - https://phabricator.wikimedia.org/T209130 (10jmatazzoni) [21:54:34] 10Growth-Team: Personalized first day: links at the bottom of sidebar are invisible without scrolling - https://phabricator.wikimedia.org/T214634 (10MMiller_WMF) [21:54:59] 10Growth-Team, 10Epic: [EPIC] Growth: Welcome survey - https://phabricator.wikimedia.org/T206365 (10MMiller_WMF) [21:55:01] 10Growth-Team: Personalized first day: links at the bottom of sidebar are invisible without scrolling - https://phabricator.wikimedia.org/T214634 (10MMiller_WMF) [21:55:07] 10Growth-Team: Welcome survey: links at the bottom of sidebar are invisible without scrolling - https://phabricator.wikimedia.org/T214634 (10MMiller_WMF) [21:55:59] 10Page-Issue-Warnings, 10Readers-Web-Backlog: "Learn more" white flash when opening navigation menu - https://phabricator.wikimedia.org/T214550 (10alexhollender) >I cannot reproduce this on production. Are you sure the problem is still present? I captured that video yesterday, and am still seeing it. What devi... [21:56:01] (03CR) 10jerkins-bot: [V: 04-1] Add #loadModuleAndGetOverlay: a nicer way to use LoadingOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486385 (https://phabricator.wikimedia.org/T201687) (owner: 10Bartosz Dziewoński) [21:56:46] (03Merged) 10jenkins-bot: Remove education popups hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486377 (owner: 10Esanders) [21:56:52] (03CR) 10jerkins-bot: [V: 04-1] Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 (owner: 10Dbrant) [21:59:15] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add support for Argon2 password hashing [core] - 10https://gerrit.wikimedia.org/r/486206 (owner: 10MaxSem) [21:59:27] (03CR) 10Samwilson: [C: 03+2] "Sorry, I totally thought I'd +2'd this the other day." [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/482701 (https://phabricator.wikimedia.org/T213113) (owner: 10ValeryanM) [22:00:47] (03CR) 10Dbrant: [C: 03+2] Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 (owner: 10Dbrant) [22:00:51] (03CR) 10jerkins-bot: [V: 04-1] http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:02:32] (03CR) 10jenkins-bot: Remove education popups hack [extensions/Flow] - 10https://gerrit.wikimedia.org/r/486377 (owner: 10Esanders) [22:02:36] 10MobileFrontend, 10Readers-Web-Backlog: Drawers should be removed from DOM after close - https://phabricator.wikimedia.org/T214045 (10Jdlrobson) [22:03:03] (03CR) 10Cooltey: [C: 04-1] "Excellent! It simplified!" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486313 (owner: 10Dbrant) [22:03:48] 10Event Metrics: Implement new informational fields on the Event Settings page (so the data can appear on Event Summary screen) - https://phabricator.wikimedia.org/T209130 (10jmatazzoni) [22:03:50] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add support for Argon2 password hashing [core] - 10https://gerrit.wikimedia.org/r/486206 (owner: 10MaxSem) [22:04:12] (03CR) 10jerkins-bot: [V: 04-1] Improve loading screens by using #loadModuleAndGetOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486386 (https://phabricator.wikimedia.org/T201687) (owner: 10Bartosz Dziewoński) [22:04:19] (03PS3) 10Bartosz Dziewoński: VE: Load HTML in parallel with modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) [22:04:22] (03Merged) 10jenkins-bot: Adding a button to quickly handle uploading the good files in a list. [extensions/MsUpload] - 10https://gerrit.wikimedia.org/r/482701 (https://phabricator.wikimedia.org/T213113) (owner: 10ValeryanM) [22:04:43] (03CR) 10jerkins-bot: [V: 04-1] LoadingOverlay: Set translucency using rgba() color instead of opacity [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486388 (https://phabricator.wikimedia.org/T201687) (owner: 10Bartosz Dziewoński) [22:04:57] (03CR) 10Krinkle: "As of PHP 7.2 it is allowed for the subclass to have a superset of the parent (per LSP). Unfortunately, that's not good enough for this." [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:05:14] (03PS11) 10Krinkle: http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:05:17] (03CR) 10Krinkle: [C: 03+2] http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:07:09] (03CR) 10Bartosz Dziewoński: "(I rewrote some of the code to match what I want to do in T214641 and T210630)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [22:07:16] 10MediaWiki-extensions-MsUpload, 10Patch-For-Review: Add a method to upload only good files when a mix of good and conflicting files are in the list. - https://phabricator.wikimedia.org/T213113 (10Samwilson) 05Open→03Resolved Merged. Thanks @Valeryan_M! Keep up the good work. [22:07:55] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Design): Reduce height of mobile page issues banner and offset of learn more - https://phabricator.wikimedia.org/T214549 (10alexhollender) @Jdlrobson >1. Is that what's being asked for? Yes, that looks super close. I'm still measuring it as 1px off. On my machine... [22:07:57] (03Abandoned) 10Anomie: Title: Load page from master in checkUserBlock() when appropriate [core] - 10https://gerrit.wikimedia.org/r/486157 (https://phabricator.wikimedia.org/T210739) (owner: 10Anomie) [22:09:38] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): [EPIC] Re-define the contract for drawers in MobileFrontend - https://phabricator.wikimedia.org/T214647 (10Jdlrobson) [22:10:22] 10MobileFrontend, 10Readers-Web-Backlog: Drawers should be removed from DOM after close - https://phabricator.wikimedia.org/T214045 (10Jdlrobson) [22:10:24] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): [EPIC] Re-define the contract for drawers in MobileFrontend - https://phabricator.wikimedia.org/T214647 (10Jdlrobson) [22:10:50] 10MobileFrontend, 10Readers-Web-Backlog: Drawers should be removed from DOM after close - https://phabricator.wikimedia.org/T214045 (10Jdlrobson) [22:13:58] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Every Drawer has a shield for catching clicks - https://phabricator.wikimedia.org/T214049 (10Jdlrobson) [22:14:02] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): [EPIC] Re-define the contract for drawers in MobileFrontend - https://phabricator.wikimedia.org/T214647 (10Jdlrobson) [22:14:04] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Every Drawer has a shield for catching clicks - https://phabricator.wikimedia.org/T214049 (10Jdlrobson) [22:14:38] 10Readers-Web-Backlog, 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): [EPIC] Re-define the contract for drawers in MobileFrontend - https://phabricator.wikimedia.org/T214647 (10Jdlrobson) [22:15:22] (03Merged) 10jenkins-bot: Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 (owner: 10Dbrant) [22:16:16] 10MobileFrontend, 10Readers-Web-Backlog: Drawers should be removed from DOM after close - https://phabricator.wikimedia.org/T214045 (10Jdlrobson) p:05Triage→03Normal [22:16:56] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Show lists + list items in same list based on search term - https://phabricator.wikimedia.org/T214505 (10cooltey) a:03cooltey [22:17:23] 10MobileFrontend, 10MinervaNeue, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3), 10User-Jdlrobson: [EPIC] Speed up unit test execution and increase code coverage - https://phabricator.wikimedia.org/T195478 (10Jdlrobson) [22:17:25] 10MW-1.33-notes (1.33.0-wmf.13; 2019-01-15), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): MFA: Drawers and Overlays should not auto-append it self to the body ele... - https://phabricator.wikimedia.org/T209129 [22:17:53] (03CR) 10jenkins-bot: Follow-up to widget HTML title. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/486371 (owner: 10Dbrant) [22:18:05] 10AbuseFilter: Short circuit breaks with multiple operations - https://phabricator.wikimedia.org/T214642 (10Daimona) p:05Triage→03High Found the cause. It is more or less what I said above. The parser enters in short-circuit with the first condition, and gets to the "<". After that, it finds the 3 and gets i... [22:18:25] (03CR) 10jerkins-bot: [V: 04-1] VE: Load HTML in parallel with modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486193 (https://phabricator.wikimedia.org/T209052) (owner: 10Bartosz Dziewoński) [22:18:28] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review, 10Performance-Team (Radar), 10Wikimedia-production-error: Spike of DBTransactionSizeError exceptions from /w/api.php from Special:Watchlist - https://phabricator.wikimedia.org/T207941 (10Etonkovidova) 05Open... [22:23:11] (03Merged) 10jenkins-bot: http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:25:02] 10MediaWiki-Authentication-and-authorization, 10Security: Support Sodium in MediaWiki session encryption - https://phabricator.wikimedia.org/T214445 (10Tgr) >>! In T214445#4902370, @Anomie wrote: > * The EncryptedPassword class in core. We should probably support Sodium there, keeping in mind that depending o... [22:25:31] (03PS1) 10Jdlrobson: If wikidatadata description exists, set it as tagline [extensions/MobileFrontend] (wmf/1.33.0-wmf.14) - 10https://gerrit.wikimedia.org/r/486392 (https://phabricator.wikimedia.org/T214606) [22:25:43] (03CR) 10jenkins-bot: http: Support callback functions in GuzzleHttpRequest [core] - 10https://gerrit.wikimedia.org/r/481954 (https://phabricator.wikimedia.org/T212175) (owner: 10BPirkle) [22:28:52] 10Page-Issue-Warnings, 10Readers-Web-Backlog: "Learn more" white flash when opening navigation menu - https://phabricator.wikimedia.org/T214550 (10Jdlrobson) Okay, I see it now, but only on Android - not desktop Chrome. Blink and you miss it! [22:28:59] 10MediaWiki-API, 10Developer-Advocacy (Jan-Mar 2019), 10Documentation, 10Goal: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10Martyav) [22:29:47] 10MediaWiki-Authentication-and-authorization, 10Security: Support Sodium in MediaWiki session encryption - https://phabricator.wikimedia.org/T214445 (10Tgr) [22:30:30] (03PS1) 10Daimona Eaytoy: Fix shortcircuit for consecutive operations [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486393 (https://phabricator.wikimedia.org/T212642) [22:35:26] 10MediaWiki-extensions-Quiz, 10HHVM: Quiz extension incompatibility with HHVM: RuntimeException: Requested template, Quiz, is not callable - https://phabricator.wikimedia.org/T212642 (10Daimona) Ack, mistyped. [22:35:41] (03PS2) 10Daimona Eaytoy: Fix shortcircuit for consecutive operations [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486393 (https://phabricator.wikimedia.org/T214642) [22:35:55] 10AbuseFilter, 10Patch-For-Review: Short circuit breaks with multiple operations - https://phabricator.wikimedia.org/T214642 (10Daimona) a:03Daimona [22:35:58] 10Dumps-Generation, 10Patch-For-Review: Produce multistream dumps in parallel - https://phabricator.wikimedia.org/T213912 (10ArielGlenn) commonswiki and enwiki fixupsare running now; only wikidata left, which will be taken care of at the end of its current run. [22:36:04] 10Page-Issue-Warnings, 10Readers-Web-Backlog: "Learn more" z-index is placed above the transparent-shield leading to a white flash during slide in animation - https://phabricator.wikimedia.org/T214550 (10Jdlrobson) [22:36:58] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10Patch-For-Review: Help panel: enable searching help articles - https://phabricator.wikimedia.org/T209301 (10MMiller_WMF) @RHo @Etonkovidova @SBisson -- @Etonkovidova, thank you for the thorough testing you did. You found some su... [22:37:41] (03CR) 10Mholloway: "I'm making updates in a new WikimediaEditorTasks repo and will update there when it's created in Gerrit. The counts table will include th" [extensions/ConfigurableCounters] - 10https://gerrit.wikimedia.org/r/483647 (owner: 10Mholloway) [22:40:09] 10Growth-Team (Current Sprint): Help panel: instrumentation for search - https://phabricator.wikimedia.org/T211166 (10MMiller_WMF) Update: we have asked for privacy advice on whether a simple approach to instrumentation would work, before we even have that conversation with the Search team. If the simple approa... [22:42:03] 10MobileFrontend, 10MinervaNeue, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): [EPIC] None of our View's should exhibit 2 levels of inheritance - https://phabricator.wikimedia.org/T212465 (10Jdlrobson) [22:42:33] (03CR) 10Jdlrobson: [C: 04-1] "Can I ask that you hold off on this change and maybe we can talk about it in person next week / or a future hangout post-all hands (if you" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486385 (https://phabricator.wikimedia.org/T201687) (owner: 10Bartosz Dziewoński) [22:43:39] (03PS31) 10Daimona Eaytoy: Show user set variables in log details [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420757 (https://phabricator.wikimedia.org/T170504) [22:44:24] (03PS4) 10Jdlrobson: mobile.editor module merged into mobile.init [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486375 (https://phabricator.wikimedia.org/T213340) [22:44:45] 10MediaWiki-extensions-General, 10VPS-project-libraryupgrader: Resort composer.json scripts.fix so minus-x fix comes before phpcbf - https://phabricator.wikimedia.org/T214652 (10Legoktm) [22:45:39] (03PS12) 10Daimona Eaytoy: Make uploads testable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445325 (https://phabricator.wikimedia.org/T170249) [22:49:06] (03PS7) 10Jdlrobson: Transpiling (allow safe ES6 usage in src folder) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/482386 (https://phabricator.wikimedia.org/T202746) [22:49:08] (03PS4) 10Jdlrobson: Templates inside JS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485090 [22:49:10] (03PS9) 10Jdlrobson: New component: Add TopicTitleList component [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/469537 [22:49:12] (03PS6) 10Jdlrobson: New component: PromisedView component [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/471333 [22:49:14] (03PS8) 10Jdlrobson: A simplified TalkOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/471334 [22:51:15] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MinervaNeue (Tracking), 10Reading-Web-Local-Wiki-Issues, 10Regression: User styles for .hlist clash with ones in core and should be scoped - https://phabricator.wikimedia.org/T213239 (10Izno) > * [[https://en.wikipedia.org/w/index.php?title=MediaWiki:Common... [22:52:51] 10wikimediafoundation.org: Foundation site Board of Trustees page is information-free - https://phabricator.wikimedia.org/T210026 (10awight) 05Open→03Resolved a:03awight [22:53:20] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - Actions menu (primary actions) - https://phabricator.wikimedia.org/T210659 (10ovasileva) [22:53:30] (03PS20) 10Daimona Eaytoy: Add tests for storing and loading the variables dump [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/481524 (https://phabricator.wikimedia.org/T201193) [22:53:37] (03PS30) 10Daimona Eaytoy: Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) [22:53:43] (03PS29) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [22:53:48] (03PS40) 10Daimona Eaytoy: Add tests for global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) [22:54:35] (03PS5) 10Daimona Eaytoy: Move conditions-related stuff inside AbuseFilterParser [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/486249 [22:57:06] (03CR) 10jerkins-bot: [V: 04-1] Templates inside JS [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/485090 (owner: 10Jdlrobson) [22:57:08] (03CR) 10jerkins-bot: [V: 04-1] New component: Add TopicTitleList component [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/469537 (owner: 10Jdlrobson) [22:57:31] (03CR) 10jerkins-bot: [V: 04-1] New component: PromisedView component [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/471333 (owner: 10Jdlrobson) [22:58:15] (03CR) 10jerkins-bot: [V: 04-1] A simplified TalkOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/471334 (owner: 10Jdlrobson) [22:59:31] 10Event Metrics: [8 hours] Add support for categories without participants - https://phabricator.wikimedia.org/T205734 (10jmatazzoni) I'm moving this to Freezer. [22:59:48] (03PS30) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [23:01:24] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MinervaNeue (Tracking), 10Reading-Web-Local-Wiki-Issues, 10Regression: User styles for .hlist clash with ones in core and should be scoped - https://phabricator.wikimedia.org/T213239 (10Jdlrobson) > Uhhhhhhhh pretty sure .hlist was introduced by the editor... [23:05:49] (03CR) 10Jdlrobson: [C: 03+2] "Nice. It's really cool to see where the global selector is being used so explicitly" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483308 (owner: 10Esanders) [23:09:31] 10OOUI, 10Release: Road to OOUI v1.0.0 - https://phabricator.wikimedia.org/T213334 (10Jdforrester-WMF) [23:09:53] (03CR) 10Jdlrobson: [C: 03+2] "The commit message is still severely lacking. I suspect this bump is uneventful given all it seems to do is remove the need for $.proxy bu" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477695 (owner: 10Esanders) [23:14:03] (03CR) 10Jdlrobson: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) (owner: 10Jdlrobson) [23:15:09] 10MediaWiki-User-management, 10Anti-Harassment: Explore alternatives to browser fingerprinting for anti-abuse efforts - https://phabricator.wikimedia.org/T213875 (10TBolliger) Thank you @MER-C. I completely forgot about T196575 — what an obvious first step! [23:16:12] 10MW-1.33-notes (1.33.0-wmf.16; 2019-02-05), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Editor code is packaged in 2 modules - https://phabricator.wikimedia.org/T214200 (10Jdlrobson) >>! In T214200#4907... [23:18:39] 10Wikimedia-Hackathon-2018: Stats tool for Wikimedia events outcomes - https://phabricator.wikimedia.org/T193443 (10jmatazzoni) [23:19:08] (03PS1) 10Isarra: Target desktop only for ULS mobile styles, as the ULS styles themselves do [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/486400 [23:19:10] (03Merged) 10jenkins-bot: build: Update devDependencies [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477695 (owner: 10Esanders) [23:19:12] (03Merged) 10jenkins-bot: eslint: Remove exception for computed-property-spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477697 (owner: 10Esanders) [23:19:14] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483308 (owner: 10Esanders) [23:19:16] 10CommRel-Specialists-Support (Jan-Mar-2019), 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review: Personalized first day: activate for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T213356 (10Etonkovidova) Checked in `viwiki` (wmf.14) - the links (i... [23:19:58] (03CR) 10Jdlrobson: [C: 03+2] Target desktop only for ULS mobile styles, as the ULS styles themselves do [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/486400 (owner: 10Isarra) [23:22:39] (03PS10) 10Jdlrobson: Talk tabs in AMC mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) [23:23:06] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: Page underneath the overlay flashes for 1 frame when switching between loading overlay and real overlay - https://phabricator.wikimedia.org/T214641 (10Jdlrobson) > Page underneath the overlay flashes for 1 frame when switching betw... [23:24:27] (03Merged) 10jenkins-bot: Target desktop only for ULS mobile styles, as the ULS styles themselves do [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/486400 (owner: 10Isarra) [23:26:02] (03CR) 10jenkins-bot: build: Update devDependencies [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477695 (owner: 10Esanders) [23:26:20] (03CR) 10jenkins-bot: eslint: Remove exception for computed-property-spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477697 (owner: 10Esanders) [23:26:22] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.10.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483308 (owner: 10Esanders) [23:29:01] (03CR) 10jerkins-bot: [V: 04-1] Talk tabs in AMC mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) (owner: 10Jdlrobson) [23:32:57] 10CommRel-Specialists-Support (Jan-Mar-2019), 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review: Personalized first day: activate for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T213356 (10MMiller_WMF) [23:33:30] 10Growth-Team, 10Epic: [EPIC] Growth: Welcome survey - https://phabricator.wikimedia.org/T206365 (10MMiller_WMF) [23:33:37] 10CommRel-Specialists-Support (Jan-Mar-2019), 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.14; 2019-01-22), 10Patch-For-Review: Personalized first day: activate for Vietnamese Wikipedia - https://phabricator.wikimedia.org/T213356 (10MMiller_WMF) 05Open→03Resolved This is complete. @nett... [23:34:38] 10MediaWiki-General-or-Unknown, 10TechCom-RFC, 10Reading-Infrastructure-Team-Backlog (Kanban): RfC: OpenGraph descriptions in wiki pages - https://phabricator.wikimedia.org/T213505 (10Tgr) [23:35:36] (03PS2) 10EBernhardson: Various es6 compat issues [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486383 [23:37:33] 10MediaWiki-General-or-Unknown, 10New-Readers, 10Reading-Infrastructure-Team-Backlog, 10Core Platform Team Backlog (Watching / External), and 3 others: Add hover-card like summary (og:description) to open graph meta data printing plain summary - https://phabricator.wikimedia.org/T142090 (10Tgr) RfC publish... [23:38:47] (03CR) 10jerkins-bot: [V: 04-1] Various es6 compat issues [extensions/CirrusSearch] (es6) - 10https://gerrit.wikimedia.org/r/486383 (owner: 10EBernhardson) [23:40:38] 10MediaWiki-General-or-Unknown, 10TechCom-RFC, 10Reading-Infrastructure-Team-Backlog (Kanban): RfC: OpenGraph descriptions in wiki pages - https://phabricator.wikimedia.org/T213505 (10Tgr) [23:41:45] (03PS1) 10Jdrewniak: Adjust heading padding for special pages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/486402 (https://phabricator.wikimedia.org/T214195) [23:42:14] 10Page-Issue-Warnings, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy page issues to enwiki and all remaining projects - https://phabricator.wikimedia.org/T210554 (10ovasileva) | wiki | screenshot | status | notes | enwiki | {F2802916... [23:44:46] (03PS11) 10Jdlrobson: Talk tabs in AMC mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/483637 (https://phabricator.wikimedia.org/T212216) [23:45:29] (03PS1) 10Jdrewniak: Remove tagline from Special:MobileOptions page [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486403 (https://phabricator.wikimedia.org/T214195) [23:46:57] (03PS1) 10Aaron Schulz: Make addWiki better handle second runs in case of errors [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/486406 (https://phabricator.wikimedia.org/T212881) [23:49:04] 10Readers-Web-Backlog: Page issues broken on wikivoyage - https://phabricator.wikimedia.org/T214653 (10ovasileva) p:05Triage→03Normal [23:50:35] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): [EPIC] Improve page issues - https://phabricator.wikimedia.org/T159262 (10ovasileva) [23:50:43] 10Page-Issue-Warnings, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy page issues to enwiki and all remaining projects - https://phabricator.wikimedia.org/T210554 (10ovasileva) 05Open→03Resolved Opened {T214653] to track wikivoyage... [23:50:54] 10Page-Issue-Warnings, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q3): Deploy page issues to enwiki and all remaining projects - https://phabricator.wikimedia.org/T210554 (10ovasileva) [23:54:34] (03CR) 10Jdlrobson: "I don't have too much to add." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/484729 (https://phabricator.wikimedia.org/T211197) (owner: 10Pmiazga) [23:56:22] 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Page issues broken on wikivoyage - https://phabricator.wikimedia.org/T214653 (10Jdlrobson) I would recommend making the community aware of these specific issues on https://en.wikivoyage.org/wiki/Template_talk:Ambox Is that something you could l... [23:57:04] 10LDAP-Access-Requests: Add [WIKITECH_ACCOUNT_USERNAME] to `wmf` LDAF group - https://phabricator.wikimedia.org/T214654 (10egardner) [23:58:12] (03CR) 10Jdlrobson: [C: 03+1] "+2 pending review of https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileFrontend/+/486372 which adds unit tests." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/483515 (https://phabricator.wikimedia.org/T211724) (owner: 10Niedzielski) [23:58:54] 10Core Platform Team, 10Wikimedia-Site-requests: Some wikis set confirmed permissions that later get overwritten with autoconfirmed - https://phabricator.wikimedia.org/T214655 (10MaxSem) [23:59:36] (03CR) 10Jdlrobson: [C: 03+1] "Will test shortly but looks good to me" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/486403 (https://phabricator.wikimedia.org/T214195) (owner: 10Jdrewniak)