[00:03:01] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (... [00:03:51] 10MobileFrontend, 10Readers-Web-Backlog: Enable placing the infobox at the first empty line also for drafts? - https://phabricator.wikimedia.org/T211063 (10Krinkle) Hi, I'd like to expand some of the local wiki context, their use case as I understood it. When editors draft articles or experiment in their san... [00:05:19] 10Epic, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Reduce the amount of modules in MobileFrontend - https://phabricator.wikimedia.org/T207787 (10Jdlrobson) [00:05:21] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Jdlrobson) [00:05:23] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (... [00:11:50] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Proposal, 10Readers-Web-Backlog (Tracking), 10User-Jdlrobson: Make jQuery an optional dependency in Minerva - https://phabricator.wikimedia.org/T200868 (10Jdlrobson) [00:12:38] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Proposal, 10Readers-Web-Backlog (Tracking), 10User-Jdlrobson: Make jQuery an optional dependency in Minerva - https://phabricator.wikimedia.org/T200868 (10Jdlrobson) > Perhaps these would be better tracked as separate tasks, or maybe we can bring together... [00:23:08] 10MediaWiki-Interface: Mediawiki:Anonnotice does not hide Mediawiki:Sitenotice anymore - https://phabricator.wikimedia.org/T211659 (10Krinkle) Looking at the code, I see the following: * If the user is logged-in: ** Consider Sitenotice, used if it is not blank or disabled. * Else - if the user is anonymous: **... [00:23:10] 10MobileFrontend, 10Readers-Web-Backlog: It should be possible to turn lead paragraph - https://phabricator.wikimedia.org/T211063 (10Jdlrobson) [00:23:12] 10address-knowledge-gaps, 10Epic: Output 2.1: An improved task recommendation API - https://phabricator.wikimedia.org/T203041 (10leila) [00:23:45] 10Research, 10Patch-For-Review: Build API to surface 'morelike' article recommendations for missing articles - https://phabricator.wikimedia.org/T201192 (10leila) [00:23:51] 10MediaWiki-Interface: Mediawiki:Anonnotice does not hide Mediawiki:Sitenotice anymore - https://phabricator.wikimedia.org/T211659 (10Krinkle) a:03Krinkle [00:23:53] 10address-knowledge-gaps, 10Epic: Output 2.1: An improved task recommendation API - https://phabricator.wikimedia.org/T203041 (10leila) [00:23:58] 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: It should be possible to turn lead paragraph - https://phabricator.wikimedia.org/T211063 (10Jdlrobson) p:05Triage>03Normal Certainly possible but a volunteer patch will likely make this happen quicker! [00:29:43] 10MediaWiki-User-login-and-signup, 10Mobile, 10Readers-Web-Backlog (Design): mediawiki.special.userlogin.signup.js does not define the mobile target so doesn't show issues before submission - https://phabricator.wikimedia.org/T211439 (10Jdlrobson) [00:33:23] 10MediaWiki-User-login-and-signup, 10Mobile, 10Readers-Web-Backlog (Design): Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target) - https://phabricator.wikimedia.org/T211439 (10Jdlrobson) [00:33:46] 10MediaWiki-User-login-and-signup, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile: Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target) - https://phabricator.wikimedia.org/T211439 (10Jdlrobson) p:05Triage>03Low MobileFrontend shows t... [00:35:31] 10MediaWiki-Special-pages: Toggle links on Special:NewPages use wrong namespace - https://phabricator.wikimedia.org/T211549 (10Aklapper) CC'ing Florian as per last sentence [00:38:37] 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer: It should be possible to turn lead paragraph on in other namespaces - https://phabricator.wikimedia.org/T211063 (10Jdlrobson) [00:50:43] 10Product-Analytics, 10Growth-Team (Current Sprint): Personalized first day: initial reporting - https://phabricator.wikimedia.org/T210899 (10nettrom_WMF) [00:57:30] 10MediaWiki-Page-deletion, 10Operations, 10MW-1.32-release, 10Performance-Team (Radar): Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 (10Krinkle) [00:59:30] 10Wikipedia-Android-App-Backlog: As a user, I want to be able to turn off "recent searches" - https://phabricator.wikimedia.org/T211740 (10LGoto) [01:02:34] 10MediaWiki-User-login-and-signup, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile: Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target) - https://phabricator.wikimedia.org/T211439 (10Jdlrobson) p:05Low>03Triage [01:03:32] (03PS6) 10Cooltey: [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) [01:08:31] (03CR) 10Brian Wolff: [C: 04-1] Link log entries to Special:Log on ApiFeedWatchlist (031 comment) [core] - 10https://gerrit.wikimedia.org/r/479132 (https://phabricator.wikimedia.org/T210920) (owner: 10LukBukkit) [01:12:19] (03CR) 10Gergő Tisza: [C: 032] Have BotPassword::login() call AuthManagerLoginAuthenticateAudit [core] - 10https://gerrit.wikimedia.org/r/479039 (https://phabricator.wikimedia.org/T194338) (owner: 10Anomie) [01:16:27] 10MediaWiki-User-login-and-signup, 10MinervaNeue, 10Mobile, 10Readers-Web-Backlog (Design): Login page doesn't show issues before submission (mediawiki.special.userlogin.signup.js does not define the mobile target) - https://phabricator.wikimedia.org/T211439 (10Jdlrobson) [01:18:22] 10Developer-Advocacy (Oct-Dec 2018): Define questions for a potential code review survey among WMF tech/eng teams - https://phabricator.wikimedia.org/T211741 (10Aklapper) p:05Triage>03Normal [01:18:22] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt (RW-Tech-Debt): Remove OO.EventEmitter functionality from View.js - https://phabricator.wikimedia.org/T211724 (10Jdlrobson) I'm wondering if we should go a step further and get rid of OO.EventEmitter altog... [01:18:47] 10LDAP-Access-Requests: LDAP access to the wmf group for Megan Neisler - https://phabricator.wikimedia.org/T211742 (10MNeisler) [01:22:20] (03CR) 10Jdlrobson: Remove usage of global event emitter from MF (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477684 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [01:25:52] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10Jdl... [01:27:26] (03PS4) 10Jdlrobson: pageIssuesOverlay is a factory function that returns an Overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475576 (https://phabricator.wikimedia.org/T209647) [01:27:47] (03CR) 10Jdlrobson: [C: 032] eslint: Remove exception for computed-property-spacing [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477697 (owner: 10Esanders) [01:29:46] (03Merged) 10jenkins-bot: Have BotPassword::login() call AuthManagerLoginAuthenticateAudit [core] - 10https://gerrit.wikimedia.org/r/479039 (https://phabricator.wikimedia.org/T194338) (owner: 10Anomie) [01:30:22] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Generate entries for deletions and restores in page histories - https://phabricator.wikimedia.org/T72239 (10GeoffreyT2000) Another disadvantage I forgot to list above is that if one first restores only the first n deleted revisions, and then restores the... [01:30:24] (03CR) 10Jdlrobson: [C: 04-1] Fix dependencies on core module 'mediawiki.user' (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 (owner: 10Fomafix) [01:31:33] (03PS2) 10Jdlrobson: Refactor pageIssues.js into smaller functions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477993 (https://phabricator.wikimedia.org/T211257) (owner: 10Jdrewniak) [01:32:05] (03CR) 10Jdlrobson: [C: 04-1] "I like the approach here. task queued for estimation. eslint issues need fixing." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477993 (https://phabricator.wikimedia.org/T211257) (owner: 10Jdrewniak) [01:32:14] (03CR) 10jenkins-bot: Have BotPassword::login() call AuthManagerLoginAuthenticateAudit [core] - 10https://gerrit.wikimedia.org/r/479039 (https://phabricator.wikimedia.org/T194338) (owner: 10Anomie) [01:35:16] 10Growth-Team: Help panel: consider enabling email notifications for mentions by default (at least for new users) on cswiki and kowiki - https://phabricator.wikimedia.org/T211711 (10MMiller_WMF) @Catrope -- I just looked at the defaults for newly created accounts in Korean and Czech (by opening the preferences o... [01:39:35] (03CR) 10jerkins-bot: [V: 04-1] Refactor pageIssues.js into smaller functions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477993 (https://phabricator.wikimedia.org/T211257) (owner: 10Jdrewniak) [01:40:14] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10Jdl... [01:41:24] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike 16hrs] Investigate opt-in audience and instrumentation - https://phabricator.wikimedia.org/T211195 (10Tbayer) @pmiazga and I discussed various aspects of this today, he is going to write up some t... [01:57:16] (03PS2) 10Tim Starling: API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo [core] - 10https://gerrit.wikimedia.org/r/477280 (https://phabricator.wikimedia.org/T210937) (owner: 10Anomie) [01:57:23] (03CR) 10Tim Starling: [C: 032] API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo [core] - 10https://gerrit.wikimedia.org/r/477280 (https://phabricator.wikimedia.org/T210937) (owner: 10Anomie) [01:59:52] 10OOUI, 10Patch-For-Review, 10Performance: Replace jQuery functions with native equivalents - https://phabricator.wikimedia.org/T207418 (10Volker_E) >>! In T207418#4811538, @Jdforrester-WMF wrote: > Done in 434432324ff0ffd12718a90d9a7943eb5155f145 ish, right? >>! In T207418#4811600, @Esanders wrote: > I agr... [02:11:01] (03Merged) 10jenkins-bot: API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo [core] - 10https://gerrit.wikimedia.org/r/477280 (https://phabricator.wikimedia.org/T210937) (owner: 10Anomie) [02:13:38] (03CR) 10jenkins-bot: API: Use parenthesized join in ApiQueryBase::showHiddenUsersAddBlockInfo [core] - 10https://gerrit.wikimedia.org/r/477280 (https://phabricator.wikimedia.org/T210937) (owner: 10Anomie) [02:14:37] 10MediaWiki-Uploading, 10Commons, 10Multimedia, 10UploadWizard: Errors while uploading images - https://phabricator.wikimedia.org/T211693 (10IM3847) I'm using Safari browser from Apple. This issue doesn't show up every time I upload images, but one it shows up, I should wait at least 12hrs to upload images... [02:16:57] (03PS9) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) [02:17:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [02:17:06] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [02:29:07] (03PS8) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [02:29:40] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10MMiller_WMF) @SBisson @RHo @Etonkovidova -- thank you for making this turn out great! I have a few questions and issues fro... [02:29:44] (03CR) 10Tim Starling: [C: 032] Scribunto_LuaError: Make ->getMessage() return UTF-8 text [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479033 (https://phabricator.wikimedia.org/T208689) (owner: 10Anomie) [02:32:04] (03CR) 10Tim Starling: [C: 032] ApiScribuntoConsole: Use 'text' type for text fields [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479025 (owner: 10Anomie) [02:37:39] (03Merged) 10jenkins-bot: Scribunto_LuaError: Make ->getMessage() return UTF-8 text [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479033 (https://phabricator.wikimedia.org/T208689) (owner: 10Anomie) [02:39:51] (03Merged) 10jenkins-bot: ApiScribuntoConsole: Use 'text' type for text fields [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479025 (owner: 10Anomie) [02:41:35] (03PS9) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [02:42:06] 10MediaWiki-Stakeholders-Group: Investigate the idea of a non-WM focused event for Mediawiki users - https://phabricator.wikimedia.org/T100220 (10Tgr) Close this as resolved, given that EMWCon has become a yearly event, and fairly successful? Or are there other groups of non-Wikimedia-focused MediaWiki users who... [02:45:45] (03CR) 10jenkins-bot: Scribunto_LuaError: Make ->getMessage() return UTF-8 text [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479033 (https://phabricator.wikimedia.org/T208689) (owner: 10Anomie) [02:46:44] (03PS10) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [02:53:45] (03CR) 10jenkins-bot: ApiScribuntoConsole: Use 'text' type for text fields [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479025 (owner: 10Anomie) [03:05:24] (03PS11) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [03:11:12] (03PS1) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 [03:22:01] 10MediaWiki-extensions-CentralNotice, 10Fr-CentralNotice-translations, 10Fundraising-Backlog, 10Trust-and-Safety, and 2 others: CentralNotice provides a means for non interface-admins to bypass new CSS/JS restrictions - https://phabricator.wikimedia.org/T202244 (10Ejegg) [03:22:06] (03PS12) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [03:24:40] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.0 support: Confirm that post-send functions work fine with mediawiki under PHP 7 - https://phabricator.wikimedia.org/T209981 (10BPirkle) Further testing on production via the fatal-errors.php script from T210567 shows that timeo... [03:26:11] (03PS1) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] (REL1_31) - 10https://gerrit.wikimedia.org/r/479152 [03:27:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] (REL1_31) - 10https://gerrit.wikimedia.org/r/479152 (owner: 10MR70) [03:29:26] 10MinervaNeue: VE summary on mobile does neither receive mediawiki.ui appearance nor inherit font-size - https://phabricator.wikimedia.org/T211743 (10Volker_E) [03:30:20] 10MediaWiki-Stakeholders-Group, 10events: Organize WMF office mixer during EMWCon 2019 - https://phabricator.wikimedia.org/T211744 (10Tgr) [03:30:45] Hello, I have found some time these days, I'm happy to learn and contribute to mediawiki projects if available any? So can someone provide me any Mediawiki phabricator ticket to contribute? [03:34:20] hi Gopa! [03:34:27] Welcome! :) [03:34:27] Hello Volker_E [03:34:35] have you already read through https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [03:35:01] a good way to start is to look at https://phabricator.wikimedia.org/tag/goodfirstbug/ [03:35:11] and pick one of those [03:35:56] Yeah I have went to that, previously I have contributed to Season of Revision Slider project https://phabricator.wikimedia.org/project/profile/3498/ So I 'm searching in the similar way [03:38:00] That was the very great experience to me, working in the team for two months, I have learned many things there ;-) [03:40:32] Gopa: good to hear that. I think it always makes best sense to look for technological challenges you feel comfortable tackling and become more and more familiar with a certain codebase from there [03:41:22] (03Abandoned) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] (REL1_31) - 10https://gerrit.wikimedia.org/r/479152 (owner: 10MR70) [03:42:46] Volker_E: Umm I'm a bit familier with JS and also I'm ready to learn myself with any other technology too [03:43:02] Hey Gopa! [03:43:15] Hello Ebe123 [03:45:01] Gopa: If you know about JS and you want to look into improving JS code you could think about updating eslint-config-wikimedia in certain extensions https://www.mediawiki.org/wiki/User:Legoktm/ci [03:45:29] it's rather simple, but useful for many folks [03:46:21] Volker_E: Ohk, I will have a look into it once [03:46:47] Gopa: like it's done for example here: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/CheckUser/+/478383/ [03:48:09] * Gopa Going through the gerrit [03:50:42] Hey Ebe123 I think you have something to discuss ? [03:50:58] ? [03:51:55] I can't think of anything... [03:52:59] Ebe123: Oohk Cool :) [03:55:43] Volker_E: I will look into that also If you have any other interesting projects please let me know :) [04:02:14] to be more specific, I'm looking to work on any particular Mediawiki extension, that may require something like fixing bugs, adding any new features. [04:08:19] hello [04:08:32] Hello Siyam [04:09:13] I was having problem cloning git....can you help [04:09:43] Siyam Sure what was the problem [04:10:49] when I was trying to colne...i got error that-- remote hung up unexpectedly [04:12:20] Aaa that also occurs if you dont have proper internet access, Can you recheck your internet access again ? [04:13:02] i have [04:13:46] can you give me the git clone command??? [04:13:55] are you sure? also can you provide me with traceback ? [04:14:31] Siyam: you can check through here https://www.mediawiki.org/wiki/Gerrit/Tutorial#Download_code_using_Git [04:14:36] what is traceback??? [04:15:37] I mean problem you faced or error you got during clonning through git. [04:16:12] wait a min [04:18:12] 10MediaWiki-Redirects, 10MediaWiki-User-login-and-signup: When logging into Wikipedia, Mediawiki redirects one to the previous webpage but without the HTML anchor tag - https://phabricator.wikimedia.org/T200027 (10Tgr) Fixing this would involve detecting when the user clicks on a login link, stashing the fragm... [04:20:42] (03PS5) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [04:22:36] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 [04:30:45] i face this https://tools.wmflabs.org/paste/view/ce19dbf0 [04:30:52] Hiranyagarbha (the cosmic egg).He is more prominently mentioned in the post-Vedic Hindu epics and the mythologies in the Puranas. In the epics, he is conflated with Purusha. [04:41:54] hey [04:47:23] Siyam: I think this may helps you https://stackoverflow.com/questions/38618885/error-rpc-failed-curl-transfer-closed-with-outstanding-read-data-remaining [04:48:26] Hello Siyam [04:48:36] hey [04:48:53] Did the G drive work? [04:49:56] Someone remove nelsonhb? [04:50:05] *kick [04:50:23] (03CR) 10Krinkle: [C: 04-1] "This is one of the errors from the Jenkins log:" [core] - 10https://gerrit.wikimedia.org/r/478995 (https://phabricator.wikimedia.org/T92992) (owner: 10D3r1ck01) [04:52:54] what will I do with the gdrive??? [04:54:12] (03CR) 10Krinkle: "minor fixme, regarding adding a public API." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/470181 (owner: 10Bartosz Dziewoński) [05:00:45] wait my friend will add me when they see it [05:03:59] i have downloaded the file....but what should i do now with the file [05:13:29] (03PS6) 10Dmaza: Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [05:14:29] (03CR) 10jerkins-bot: [V: 04-1] Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [05:14:37] (03PS7) 10Dmaza: Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [05:15:25] (03PS10) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) [05:16:02] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [05:16:48] (03CR) 10jerkins-bot: [V: 04-1] Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [05:16:50] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [05:17:26] hey [05:17:26] (03CR) 10jerkins-bot: [V: 04-1] Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [05:17:55] The succession of these flame emperors, from Shennong, the first Yan Emperor, until the time of the last Yan Emperor's defeat by the Yellow [05:17:55] Emperor, may have been some 500 years. [05:19:49] <_shreyasminocha> Such spam [05:25:05] hello [05:30:13] hlo [05:39:58] 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Kanban (Waiting for Review), 10Wikimedia-production-error: PHP Error "Undefined index: 1 in AbuseFilter.php on line 928" - https://phabricator.wikimedia.org/T203535 (10Krinkle) Recent trace:... [05:41:18] Siyam: hi [05:41:56] someone really needs to kick/ban nelsonhb [05:50:34] hey shreyas are you there??? [05:52:24] 10ContentTranslation: Design review for CX2 - https://phabricator.wikimedia.org/T166578 (10Etonkovidova) [05:52:27] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13): CX2: Warning about article having changed too much - https://phabricator.wikimedia.org/T168287 (10Etonkovidova) 05Open>03Resolved Checked in wmf.8 (testwiki): All looks according to the s... [05:54:18] 10CX-template-improvements, 10WorkType-NewFunctionality: Fix issues found during user research on template translation prototypes and design reviews - https://phabricator.wikimedia.org/T146760 (10Etonkovidova) [05:54:20] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10WorkType-Maintenance: Open link to diff in a new page for the warning when the source page has been updated - https://phabricator.wikimedia.org/T146761 (10Etonkovidova) 05Open... [05:56:43] (03PS2) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [05:58:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [05:58:25] Siyam: yes [05:58:59] i have downloaded the gdrive file [05:59:03] what next?? [05:59:04] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [05:59:22] have you put the files in their correct place? [05:59:28] and with the correct name? [06:03:21] Siyam: ^ [06:03:47] where should i put it? [06:04:47] i don't remember the path by-heart. have a look in the instructions? [06:05:44] (03PS3) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [06:06:02] i want to know....do i need to create a folder??? [06:06:14] in my windows?? [06:06:49] no [06:07:01] then?? [06:07:06] the part beginning with /static is relative to mediawiki-config [06:07:23] so there'll be a `static` folder in mediawiki-config [06:07:23] where is mediawiki-config [06:07:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [06:07:35] you just downloaded it, didn't you Siyam? [06:07:45] yes [06:07:52] from gdrive [06:07:55] yes [06:08:06] so within that, there'll be a `static` folder [06:08:22] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [06:08:26] within that look for the other folders as the path in the task described [06:08:30] yes found it [06:08:30] describes* [06:08:50] have you found the last folder of the path? [06:08:54] wait..i will be back [06:09:18] k [06:09:24] 10MediaWiki-extensions-FlaggedRevs, 10DBA, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Drop FlaggedRevs tables in database for srwikinews - https://phabricator.wikimedia.org/T209761 (10Marostegui) Thanks @reedy! ` root@cumin1001:~# for i in flaggedtemplates flaggedpage_config flaggedimages flaggedpage_p... [06:14:59] i have moved all the logos in the directory..what next?? [06:15:08] (03PS4) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/479151 (https://phabricator.wikimedia.org/T204347) [06:15:30] please confirm that they're all named correctly Siyam [06:15:44] yes...they are [06:16:19] nice. now you have to add a "remote" to your git repository [06:16:30] how [06:16:52] this way git will know where the files on your computer belong and you'll be able to "sync" your local files with the "real" versions [06:17:08] open the mediawiki-config directory in your terminal [06:17:52] by cd command?? [06:18:10] yep [06:18:13] :) [06:18:18] wait [06:18:42] (03PS2) 10Fomafix: Fix dependencies on core modules for mw.user [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 [06:25:46] hey [06:26:06] i am on the directory [06:26:50] yes [06:27:09] now add a remote using the git remote command [06:27:54] git remote add origin [06:28:01] (03Abandoned) 10MR70: [WIP] Show duration of query recent changes in checkuser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/464472 (https://phabricator.wikimedia.org/T204347) (owner: 10MR70) [06:28:31] oh [06:28:34] wait [06:29:39] https://tools.wmflabs.org/paste/view/ed85ba98 is it the ssh url??? [06:30:09] everything after `git clone` and before `--depth` [06:31:32] oh [06:33:08] it says remote origin already exists [06:33:30] run git remote -v [06:33:40] and upload the output to a paste pls? [06:35:41] https://tools.wmflabs.org/paste/view/f06ad9d2 [06:36:01] um, no [06:36:16] run `git remote -v` and upload what that outputs to a paste [06:37:04] "when i run `git remote -v`, i get https://tools.wmflab.org/paste/view/" that way [06:37:12] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [06:41:32] i get ssh://takidelfin@gerrit.wikimedia.org:29418/operations/mediawiki-config (push) [06:42:30] then run the git add command again except do git set-url instead [06:43:53] 10Language-Team: [Proposed]Localising template parameter gadget - https://phabricator.wikimedia.org/T211746 (10MuhammadShuaib) [06:43:58] i cant understand [06:44:06] please give me the command [06:44:58] git set-url origin [06:46:23] 10Language-Team: [Proposed]Localising template parameter gadget - https://phabricator.wikimedia.org/T211746 (10MuhammadShuaib) [06:47:54] shouldn't take too long [06:48:00] it says set-url is not a git command [06:48:26] oops :P [06:48:29] git remote set-url [06:48:34] sorry [06:48:59] okay [06:49:10] now? [06:49:27] now git add the files, git commit [06:49:39] how [06:49:42] hopefully you remember these steps from your getting started with gerrit task? [06:50:02] if not, let me know [06:50:09] no [06:50:39] :| okay. first run `git status` [06:50:46] should tell you which files have changed [06:51:06] then [06:51:27] run `git add [06:51:29] ` [06:51:56] should i include ` [06:52:07] no [06:52:41] `` aka backticks are like formatted text. they usually just signify code. [06:56:02] Siyam: there's a shortcut to adding each file separately, but i'm making you type them out for understanding's sake [06:56:06] progress? [06:56:47] wait [06:57:10] i think its done [06:57:12] next? [06:57:59] run git status again to verify that it's done [06:58:14] i have already done it [06:58:31] does it speak of any "untracked files"? [06:58:39] (03PS1) 10Pwirth: Merge branch 'master' into REL1_31 [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/479161 [06:58:44] no [06:58:56] good. so all your new files are now in something called the "staging area" [06:59:11] ok [06:59:29] when we run `git commit`, all the changes in the staging area are "committed" [06:59:55] so run `git commit` [07:00:04] and tell me what happens next [07:00:51] (03PS3) 10Fomafix: Fix dependencies on core modules for mw.user and mw.util [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 [07:01:53] (03PS2) 10Pwirth: [Test] Fix REL1_31 branch of this repo [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/479161 [07:03:37] https://tools.wmflabs.org/paste/view/631e37e4 [07:04:00] do as it says [07:04:28] use the same email address as the one you used for gerrit [07:06:16] let me know when you're done [07:06:46] done [07:07:05] great, now try to commit again [07:07:16] tried [07:07:32] what's wrong now? [07:07:44] NO Wrong [07:08:24] then? [07:08:34] what do you mean by "tried"? [07:09:08] https://tools.wmflabs.org/paste/view/2b2b5e0e [07:09:31] that is something known as vim [07:09:39] let's introduce you to vim [07:09:49] first of all, quit vim and open it again [07:09:53] press escape [07:10:01] type `:q`, press enter [07:10:10] you should have your command prompt back now [07:10:38] how to quit vim [07:10:43] 10Language-Team: [Proposed]Localising template parameter gadget - https://phabricator.wikimedia.org/T211746 (10eranroz) This is interesting idea and I think this may be very useful for adopting templates between wikis. As far as I know, for translating template there are different approachs: 1. English code + l... [07:10:50] should i close command prompt [07:10:57] 12:39 < shreyasminocha> press escape [07:10:57] 12:40 < shreyasminocha> type `:q`, press enter [07:10:57] 12:40 < shreyasminocha> you should have your command prompt back now [07:11:41] including `? [07:11:58] no. assume no unless mentioned explicitly [07:12:26] not working [07:12:55] :( what does it say? [07:13:28] C:/mediawiki-config/.git/COMMIT_EDITMSG[+] [unix] (13:05 12/12/2018) 6,1 Top E37: No write since last change (add ! to override)C:/mediawiki-config/.git/COMMIT_EDITMSG[+] [unix] (13:05 12/12/2018) [07:13:42] (03CR) 10Robert Vogel: [C: 032] [Test] Fix REL1_31 branch of this repo [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/479161 (owner: 10Pwirth) [07:14:30] yeah. it says "add ! to override". so press escape again, type `:q!`, press enter. [07:15:38] yeah [07:15:41] it worked [07:15:50] what now [07:16:59] run git commit again. then do *exactly* as i say [07:17:32] press the `i` key *exactly* once. don't worry if nothing shows up [07:17:35] (03Merged) 10jenkins-bot: [Test] Fix REL1_31 branch of this repo [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/479161 (owner: 10Pwirth) [07:17:44] (this will move you into "insert mode") [07:18:14] next, you have to type a commit message [07:18:22] what message [07:18:35] for example, i used "Add HD logos for 3 projects" for my commit [07:18:44] you can use something similar [07:18:58] type on the line your cursor is on. don't switch lines. [07:19:21] your commit message should begin with a capital letter and *not* end with a period. also, it should be shorter than 50 characters [07:19:36] have you typed a commit message? [07:19:54] no [07:19:58] please do [07:20:14] it says add is not a command [07:20:52] ~sigh~ looks like you're either in the command prompt or in the wrong vim mode [07:21:06] this should not be happening siyam [07:21:44] (03PS2) 10Pwirth: Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478881 (owner: 10Robert Vogel) [07:21:48] does the screen look like your ordinary command prompt or is it different? [07:21:54] better still, send me a screenshot [07:22:21] how to send screenshot [07:22:36] imgur.com maybe [07:26:01] https://imgur.com/a/C3Nr0DA [07:26:07] (03PS9) 10Pwirth: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [07:26:27] run git commit and send me a screenshot again [07:26:34] without doing anything else [07:26:46] just git commit, enter :) [07:28:36] https://imgur.com/a/N8wmqjD [07:29:13] nice! now typing 'i', do you see the words "INSERT MODE" at the bottom? [07:29:30] press "i" just once [07:29:55] yes [07:30:03] its insert [07:30:31] alright. Now you may type the words "Add HD..." [07:30:37] just type. no enter or anything. [07:30:44] you're basically in a text editor at this point. [07:31:20] then [07:31:49] i'd suggest the following too: [07:32:38] press enter twice (would leave a blank line of course), and on three separate (continuous) lines, type the name of each project you added logos for [07:32:48] so it'd looks like this: [07:32:57] Add HD logos for 3 projects [07:32:59] [07:33:03] - enwikibooks [07:33:08] - trwikinews [07:33:11] - enwiktionary [07:33:23] tell me when you're done with that [07:33:47] don't worry, i'm still around. that was my phone [07:34:22] done [07:34:58] nice. now leave another blank line in between and type `Bug: T150618` [07:34:59] T150618: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 [07:35:23] what this would do is that it would associate your commit to the phabricator ticket. it's optional, but recommended. [07:36:23] so now you'll have [07:36:47] done [07:37:00] great. now press escape [07:37:06] type `:x` [07:37:09] press enter [07:38:53] done [07:39:48] just a sec Siyam, i'm on your case [07:40:44] Siyam: please give me a paste for the ouptut of `git --no-pager log -n 1` [07:41:11] (03PS10) 10Pwirth: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [07:42:01] (03CR) 10jerkins-bot: [V: 04-1] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [07:43:01] (03CR) 10Legoktm: [C: 032] bump wgVersion to 1.32.0-rc.1 [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/478987 (owner: 1020after4) [07:43:11] https://tools.wmflabs.org/paste/view/f81aa0aa [07:43:14] 10MediaWiki-Releasing, 10MW-1.32-notes, 10MW-1.32-release, 10Release-Engineering-Team (Kanban), 10User-MacFan4000: Release MW 1.32 RC1 - https://phabricator.wikimedia.org/T211653 (10Legoktm) @mmodell FYI I'm on "vacation" this week due to exams. I think @arielglenn took care of what you wanted though: [... [07:43:49] hmm you need to add a change-id [07:44:05] so usually there's this thing called a git hook which automatically adds a change id for you [07:44:12] but you don't seem to have it in place [07:44:42] which is fine (for now). you can manually add a change id and it'll be fine. will save us some effort in the short term [07:44:59] and maybe we can install the hook later [07:45:05] sounds good Siyam? [07:45:10] okay [07:45:31] run `git commit --amend`. will allow you to edit your commit message. [07:45:43] will open vim again. [07:46:16] press the i key to get into insert mode again [07:46:28] use the arrow keys to navigate now [07:47:01] okay [07:47:03] then [07:47:12] (03PS11) 10Robert Vogel: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 [07:47:32] add a space between the `Bug:` and `T150618` [07:47:32] T150618: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 [07:48:06] then [07:48:50] in the line after Bug:, Add a new line that begins with `Change-Id: ` [07:49:07] and exactly that, please don't change the case [07:49:14] ok [07:49:38] (03CR) 10jerkins-bot: [V: 04-1] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [07:49:42] https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [07:50:05] on the same line, add `I3240808644fd7abef526f7fdc5834ab8a44de4ab` [07:50:46] what i did to find this was that i changed a few characters from an old change-id. it's a hacky way, but suffices for now [07:51:15] can paste in vim [07:51:37] can or cannot? [07:51:53] or are you asking me? [07:52:18] (03PS12) 10Robert Vogel: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 [07:52:42] i cannot [07:53:04] shift + insert key? [07:53:20] that ~might~ work [07:53:34] (03Abandoned) 10Pwirth: Add an Action-API that mocks certain RESTBase interfaces [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478927 (owner: 10Robert Vogel) [07:53:40] what is insert key [07:53:45] oh [07:53:49] gotcha [07:53:50] (03CR) 10Pwirth: [C: 032] Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478881 (owner: 10Robert Vogel) [07:53:58] did it work? [07:53:59] (03PS1) 10Pwirth: Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479166 [07:54:05] (03CR) 10Pwirth: [C: 032] Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479166 (owner: 10Pwirth) [07:54:38] no [07:54:45] i cant paste [07:54:47] (03Merged) 10jenkins-bot: bump wgVersion to 1.32.0-rc.1 [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/478987 (owner: 1020after4) [07:55:18] let's try setting up the hook then [07:55:37] no [07:55:56] what? [07:56:28] (03CR) 10Pwirth: [C: 032] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [07:56:47] I3240808644fd7abef526f7fdc5834ab8a44de4ab is the first one i??? or L??? [07:56:48] (03PS1) 10Pwirth: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479167 [07:57:03] (03PS2) 10Pwirth: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479167 [07:57:06] capital 'eye' [07:57:13] (03CR) 10Pwirth: [C: 032] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479167 (owner: 10Pwirth) [07:57:19] (03CR) 10jenkins-bot: bump wgVersion to 1.32.0-rc.1 [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/478987 (owner: 1020after4) [07:57:46] (03Merged) 10jenkins-bot: Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478881 (owner: 10Robert Vogel) [07:57:58] done [07:58:03] i just typed [07:58:14] now save and leave vim. [07:58:17] press escape [07:58:22] type `:x` like earlier [07:58:24] enter [07:58:35] (take note, this is the procedure to save in vim) [07:58:46] should i give space after change-id: ??? [07:59:05] you should. please ensure C and I are capitalised [07:59:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Scribunto, 10Editing-team, 10Core Platform Team Kanban (Waiting for Review), and 2 others: Exception from line 1539 of ResourceLoader.php: JSON serialization of config data failed. This usually means the config... - https://phabricator.wikimedia.org/T208689 [07:59:45] (03Merged) 10jenkins-bot: Update dynamic parsoid config for SimpleFarmer [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479166 (owner: 10Pwirth) [08:00:28] (03Merged) 10jenkins-bot: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [08:00:48] done [08:01:14] give me a paste of the output of `git log --no-pager -n 1` again please? [08:02:00] what that command does is that it fetches the list of commits (logs), doesn't go into "fancy" mode (--no-pager) and limits the list to exactly one commit (-n 1) [08:02:19] (03PS2) 10ItSpiderman: Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 [08:03:08] (03Merged) 10jenkins-bot: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/479167 (owner: 10Pwirth) [08:03:17] 10UI-Standardization, 10OOUI: Embedded buttons in dialogs lack padding - https://phabricator.wikimedia.org/T207369 (10Petar.petkovic) [08:03:20] (03PS3) 10ItSpiderman: Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 [08:03:21] 10ContentTranslation: [wmf.8] "Restart the translation" label needs additional margins - https://phabricator.wikimedia.org/T211733 (10Petar.petkovic) [08:04:13] https://tools.wmflabs.org/paste/view/03a983e6 [08:04:34] (03CR) 10jerkins-bot: [V: 04-1] Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 (owner: 10ItSpiderman) [08:04:49] apologies. `git --no-pager log -n 1` [08:06:09] commit 24c0873b6d6ad0cbef5ad73f302c9f899f217da7 (HEAD -> master) Author: siyam410 Date: Wed Dec 12 13:27:59 2018 +0600 ADD HD Logos in 3 Wiki Projects -arwikibooks -bnwikibooks -hiwikibooks Bug: T150618 Change-Id: I3240808644fd7abef526f7dc5834ab8a44de4ab [08:06:09] T150618: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 [08:06:16] that does not help [08:06:26] can you upload it to a paste so it's clearer [08:06:34] as a paste* [08:06:41] (03PS4) 10ItSpiderman: Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 [08:06:51] https://tools.wmflabs.org/paste/view/ca10dafa [08:07:09] thanks. lgtm now. [08:07:22] enter `git review -R` [08:08:49] * shreyasminocha has to leave for lunch soon [08:09:42] (03CR) 10jerkins-bot: [V: 04-1] Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 (owner: 10ItSpiderman) [08:11:22] https://tools.wmflabs.org/paste/view/75c82c5a [08:12:01] `git remote rename origin gerrit` [08:13:06] and about the error with ssh, it's probably something to do with the ssh. since you claim that you have ssh keys set up already, i can't help you much with that. [08:13:18] this is where we were stuck yesterday as well... [08:13:34] C:\mediawiki-config>git review -R [08:13:35] Problems encountered installing commit-msg hook [08:13:35] The following command failed with exit code 1 [08:13:35] "scp -P29418 siyam410@gerrit.wikimedia.org:hooks/commit-msg .git/hooks/commit-msg" [08:13:35] ----------------------- [08:13:35] siyam410@gerrit.wikimedia.org: Permission denied (publickey). [08:13:53] so know you're ready for pushing for review, but you're stuck on that presumably because of misconfigured ssh keys [08:14:25] how to configure ssh key correctly [08:14:30] can't help + gtg for lunch. an option might be: get rid of all current ssh keys (both on your system and in gerrit), setting them up from scratch [08:15:08] also, when someone's guiding you through a process, please pay attention to the steps so that you don't have to ask for help to do the same thing again [08:15:15] i hope you do that already :) [08:16:07] try getting someone to help you with the ssh key thing. feel free to quote my "an option might be: " message when asking for help [08:16:09] can you help me setting up ssh keys? [08:16:21] i have to go. apologies. [08:16:27] okay [08:16:41] see you later. if you're still around, we'll try setting it up from scratch. [08:16:54] * shreyasminocha leaves [08:17:40] 10CommRel-Internals: CE Insights: Prioritize team questions for CE Insights - https://phabricator.wikimedia.org/T211624 (10Qgil) Maria, if you haven't already please sync with Benoît and Sherry. You had opinions about questions to be prioritized. [08:21:27] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [08:21:31] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) s7 eqiad progress [] labsdb1011 [] labsdb1010 [] labsdb1009 [] dbstore1002 [] db1125 [] db1116 [] db1101 [] db109... [08:31:35] (03PS5) 10ItSpiderman: Make role system object-based [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 [08:52:11] 10Wikimedia-Logstash, 10Tracking: Add system logs to logstash (tracking) - https://phabricator.wikimedia.org/T63779 (10hashar) [08:56:54] 10Ipwatcher: Get rid of bigbrother - https://phabricator.wikimedia.org/T194982 (10GTirloni) BigBrother has been disabled in Toolforge. https://wikitech.wikimedia.org/wiki/Help:Toolforge/Grid#Bigbrother_(Deprecated) [09:00:31] Urbanecm, fyi, just updated https://gerrit.wikimedia.org/r/#/c/operations/mediawiki-config/+/478945/ [09:05:22] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona)... [09:14:06] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Machine translation error shown when using Yandex - https://phabricator.wikimedia.org/T211685 (10santhosh) I tried to reproduce this, Yandex is working fine. But Apertium was throwing error: ` {"status":500,"type":"internal_error","t... [09:16:10] what's up with my phone's irc... [09:16:36] shreyasminocha, good question [09:16:45] btw, do you know you can connect to ZNC via phone? [09:16:57] couldn't manage to. do you? [09:17:07] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Michael) a:05Michael>03None [09:17:14] shreyasminocha, yup [09:17:39] shreyasminocha, IIRC there's only "password field" in AndroIRC [09:17:53] fill yourzncnickname:yourzncpassword there [09:17:54] should work [09:18:14] (or, if you have multiple nets in your ZNC, username/network:password) [09:18:31] okay, let me try [09:22:03] i've to use my znc server's ip and port for ip, port. right? [09:23:33] Urbanecm: i keep getting connection reset's [09:23:45] shreyasminocha, yeah [09:23:56] ip: znc server ip, port: port on which znc is running, nick: shreyasminocha, pwd: pwd [09:23:57] shreyasminocha, that might mean you have your pwd incorrect [09:24:07] pwd should be nick:pwd [09:24:31] hmm that's what i'm trying [09:24:35] let me retry [09:24:44] sure [09:27:02] 10WMCZ-Tracker: Use REST API instead of non-standard pseudo-API - https://phabricator.wikimedia.org/T211521 (10Nathan_fraignt) a:03Nathan_fraignt [09:28:03] 10MediaWiki-API, 10MediaWiki-extensions-WikibaseClient, 10Wikibase-DataModel, 10Wikidata, and 3 others: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser - https://phabricator.wikimedia.org/T208924 (10Michael) a:03Michael [09:29:39] (03PS10) 10Tchanders: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) (owner: 10Dbarratt) [09:32:52] :/ [09:42:03] shreyasminocha, what happened?: [09:42:15] no luck [09:42:30] that's sad [09:42:33] let me check my config [09:43:24] address: technetium.toolsnbots.de [09:43:26] port: 2501 [09:43:37] znc? [09:43:43] yeah, that's what I use [09:43:47] :o [09:43:52] pwd: Urbanecm/freenode:pwd [09:43:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lydia_Pintscher) \o/ [09:47:01] (03CR) 10Robert Vogel: [C: 032] Add tooltip for navigation toggler. ERM:13150 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478179 (owner: 10Pwirth) [09:47:12] (03PS1) 10Robert Vogel: Add tooltip for navigation toggler. ERM:13150 [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/479176 [09:47:20] (03CR) 10Robert Vogel: [C: 032] Add tooltip for navigation toggler. ERM:13150 [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/479176 (owner: 10Robert Vogel) [09:49:41] (03CR) 10Thiemo Kreuz (WMDE): "Thanks a lot for the rebase!" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478986 (https://phabricator.wikimedia.org/T211576) (owner: 10Thiemo Kreuz (WMDE)) [09:50:18] Urbanecm: should i try setting up sasl instead? [09:50:46] shreyasminocha, SASL is for auth ZNC to IRC, shouldn't be needed for client to ZNC [09:50:59] o [09:51:18] (03PS3) 10Nikhil-nk: Add StartDate/Datetime and EndDate/Datetime data type [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 [09:51:21] (03Merged) 10jenkins-bot: Add tooltip for navigation toggler. ERM:13150 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478179 (owner: 10Pwirth) [09:51:23] (03Merged) 10jenkins-bot: Add tooltip for navigation toggler. ERM:13150 [skins/BlueSpiceCalumma] (REL1_31) - 10https://gerrit.wikimedia.org/r/479176 (owner: 10Robert Vogel) [09:52:15] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Unnecessary vertical/horizontal scrollbars displayed for images - https://phabricator.wikimedia.org/T202180 (10Pginer-WMF) In the translation of [[ https://en.wikipedia.org/wiki/Row_House_in_Sumiyoshi | Row House in Sumiyoshi ]] from... [09:53:16] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Machine translation error shown when using Yandex - https://phabricator.wikimedia.org/T211685 (10Pginer-WMF) The original problem with Yandex cannot be reproduced, and Apertium works for me now too. In the process of checking I found... [09:59:27] (03CR) 10Nikhil-nk: "@Yaron Koren: I totally agree with you regarding the error messages." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 (owner: 10Nikhil-nk) [10:00:49] 10Accessibility, 10Wikidata, 10Wikidata-Campsite, 10User-Michael: Div to toggle termbox is unreachable with keyboard - https://phabricator.wikimedia.org/T211751 (10Michael) [10:02:00] (03CR) 10Alexandros Kosiaris: "This is an upstream problem. Cloning locally the upstream repo and running node_modules/.bin/mocha test/*_test.js (which is what is define" [services/zotero] - 10https://gerrit.wikimedia.org/r/479020 (https://phabricator.wikimedia.org/T196097) (owner: 10Mvolz) [10:12:42] 10CirrusSearch, 10Discovery-Search: Adapt or configure mjolnir so that it knows all search clusters within a DC - https://phabricator.wikimedia.org/T211752 (10dcausse) [10:12:55] 10CirrusSearch, 10Discovery-Search (Current work): Adapt or configure mjolnir so that it knows all search clusters within a DC - https://phabricator.wikimedia.org/T211752 (10dcausse) [10:13:00] (03PS8) 10Tchanders: Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [10:13:01] 10mediawiki-extensions-Semantic-Result-Formats, 10Page-Previews (Tracking), 10Readers-Web-Backlog (Tracking): Page Previews not working in SRF Datatables - https://phabricator.wikimedia.org/T211212 (10Sochin67) Dear all, understood - many thanks to all for your responses! [10:13:42] 10mediawiki-extensions-Semantic-Result-Formats, 10Page-Previews (Tracking), 10Readers-Web-Backlog (Tracking): Page Previews not working in SRF Datatables - https://phabricator.wikimedia.org/T211212 (10Sochin67) 05Open>03Resolved [10:14:39] 10Discovery-Search, 10Epic: [epic] Run multiple elasticsearch clusters on same hardware - https://phabricator.wikimedia.org/T193654 (10dcausse) [10:14:41] 10CirrusSearch, 10Discovery-Search (Current work): Adapt or configure mjolnir so that it knows all search clusters within a DC - https://phabricator.wikimedia.org/T211752 (10dcausse) [10:15:00] 10CirrusSearch, 10Discovery-Search (Current work): Adapt or configure mjolnir so that it knows all search clusters within a DC - https://phabricator.wikimedia.org/T211752 (10dcausse) p:05Triage>03Normal [10:16:25] 10CirrusSearch, 10Discovery-Search (Current work): Adapt or configure mjolnir so that it knows all search clusters within a DC - https://phabricator.wikimedia.org/T211752 (10dcausse) [10:21:47] (03CR) 10Robert Vogel: [C: 04-2] "Blocking this as it is targeted for 3.1" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478949 (owner: 10ItSpiderman) [10:24:19] 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Add more machine translation services (tracking) - https://phabricator.wikimedia.org/T86700 (10Pginer-WMF) [10:25:41] 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Add more machine translation services (tracking) - https://phabricator.wikimedia.org/T86700 (10Pginer-WMF) [10:26:05] (03CR) 10MarcoAurelio: "WMF Legal isn't responding and the text is a verbatim copy of that published by Creative Commons itself. I don't think we should keep the " [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/477507 (https://phabricator.wikimedia.org/T148217) (owner: 10MarcoAurelio) [10:27:29] 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Add more machine translation services (tracking) - https://phabricator.wikimedia.org/T86700 (10Pginer-WMF) [10:28:17] 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Add more machine translation services (tracking) - https://phabricator.wikimedia.org/T86700 (10Pginer-WMF) [10:31:36] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10MarcoAurelio) > Other 2FA providers do more (Google for example provides 10). Perhaps this could be raised in a different task, if not requeste... [10:35:40] 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Add more machine translation services (tracking) - https://phabricator.wikimedia.org/T86700 (10Pginer-WMF) [10:43:11] (03CR) 10D3r1ck01: "recheck" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 (owner: 10Nikhil-nk) [10:46:29] (03PS8) 10Daimona Eaytoy: [WIP] Overhaul throttle identifiers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/477580 (https://phabricator.wikimedia.org/T211101) [10:46:59] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13): CX2: Warning about article having changed too much - https://phabricator.wikimedia.org/T168287 (10Pginer-WMF) >>! In T168287#4816117, @Etonkovidova wrote: > All looks according to the specs (... [10:49:24] 10AbuseFilter, 10Patch-For-Review: Throttle identifiers are ambiguous - https://phabricator.wikimedia.org/T211101 (10Daimona) Update: actually, throttle identifiers aren't //too// bad: when creating the keys we pass $type to the constructor, so that a key is something like ` abusefilter:throttle:filterID:grou... [10:51:48] 04(no projects): PDF/DJVU defaults to first page for Page Previews - https://phabricator.wikimedia.org/T211754 (10Opencooper) [10:59:28] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Overhaul throttle identifiers [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/477580 (https://phabricator.wikimedia.org/T211101) (owner: 10Daimona Eaytoy) [10:59:38] (03PS1) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [11:00:02] (03CR) 10Daimona Eaytoy: "CI failing due to T211343" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/477580 (https://phabricator.wikimedia.org/T211101) (owner: 10Daimona Eaytoy) [11:00:33] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:04:48] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Catalogue where the MobileFrontend loading overlay is used - https://phabricator.wikimedia.org/T209708 (10phuedx) If you've set your preferred editor to VE, then when you click an edit icon, you'll see a fullscreen, semi-transparent overlay with a spi... [11:05:53] (03PS1) 10Daimona Eaytoy: Expand AbuseFilter::getFilter to select all fields [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/479186 [11:06:23] o/ [11:07:38] (03PS11) 10Daimona Eaytoy: Add tests for global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) [11:08:07] (03PS2) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [11:09:03] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:10:07] (03PS7) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [11:10:45] (03CR) 10Tchanders: [C: 031] Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [11:11:45] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Reedy) Indeed. This is out of the scope for this task, but could be considered necessary/a dependency for doing it [11:11:49] (03PS3) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [11:12:45] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:13:12] 10WMNO-Transcription-2018: Translate newly found captions into English - https://phabricator.wikimedia.org/T211755 (10jhsoby-WMNO) [11:13:19] 10CommRel-Specialists-Support: Support Translation for CE Insights - https://phabricator.wikimedia.org/T211229 (10Elitre) Edward, FYI we're discussing this request already. While I can't promise that I can attach a name to it before EOY, there's no doubt we're going to resource it in due course. HTH. [11:15:17] 10CommRel-Documentation, 10Goal: Represent CRels in Wikimedia Product Guidance finalisation - https://phabricator.wikimedia.org/T205963 (10Elitre) It should be acknowledged that Quim has actually been the driver behind this for a while. I'm now looking to finally push the content out on mw.org by the date agre... [11:15:29] 10Page-Previews: PDF/DJVU defaults to first page for Page Previews - https://phabricator.wikimedia.org/T211754 (10Aklapper) > a specific page is often used with the `page=` syntax Used where, by who? > However, Hovercards just uses the first page. See [[ https://en.wikipedia.org/wiki/The_Waste_Land | The Waste... [11:17:21] 10CommRel-Internals, 10Goal: Refine team Evaluation Framework document - https://phabricator.wikimedia.org/T205716 (10Elitre) I am not sure why there's an expiration date on this. I think the framework may actually be improved once we've agreed on our middle term plan, which isn't due by EOY. (Also, there's ne... [11:17:28] (03PS8) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [11:19:17] (03PS2) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) [11:19:21] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 3 others: Lock wait timeout exceeded in SqlIdGenerator::generateNewId - https://phabricator.wikimedia.org/T194299 (10Addshore) >>! In T194299#4814414, @Lucas_Werkmeister_WMDE wrote: >... [11:19:28] (03PS4) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [11:20:25] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:20:47] (03CR) 10jerkins-bot: [V: 04-1] Add tests for global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [11:22:19] (03CR) 10jerkins-bot: [V: 04-1] Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) (owner: 10Daimona Eaytoy) [11:22:21] Urbanecm/Takidelfin/shreyasminocha can one or more of you have a look at the eslint of https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185 ? [11:22:35] 9sure [11:22:36] sure [11:23:01] we're one clones -- double productivity [11:23:08] s/one//g [11:23:39] 4 errors to be precise [11:23:48] (03CR) 10jerkins-bot: [V: 04-1] Add tests for global filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [11:23:54] dolphin: you want to fix these or should i? [11:23:57] Yeah I know [11:24:20] takidelfin: ^ [11:24:20] The problems are: [11:24:43] Unused vars: They are used, not sure if I should add a line that ignores them, or make them (even more?) global if possible [11:25:06] * shreyasminocha is looking [11:25:12] (03CR) 10Takidelfin: [C: 04-1] Change: Edit/Create ticket view now uses REST API (034 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:25:21] dolphin is fast [11:25:36] Nathan_fraignt: async/await got introcuded in ES7 [11:25:37] :D [11:25:40] not in ES6 [11:25:47] yes [11:25:49] The arrow function: I think that one should be fixed with uploading a newer version of the eslint, merging that patchset first, rebasing this one [11:25:58] I know [11:26:01] i opened a ticket for it, yes [11:26:29] https://caniuse.com/#feat=async-functions [11:26:37] * shreyasminocha is fixing deez errors [11:26:39] And getTopicById is defined [11:27:02] Nathan_fraignt: ok, I will update the code to ES7 [11:27:19] major browsers support async/await [11:27:23] takidelfin: separate patch? [11:27:27] yup [11:27:28] You don´t have to do it, I kinda just wanted a second opinion on what to do :) [11:27:36] But if you want to, go ahead of course [11:27:40] k, sg [11:27:40] Leave it for me :D [11:27:40] I love ES :> [11:27:45] I hate it [11:27:48] truly do [11:27:49] ES6+ <3 [11:27:59] typescript <3 <3 [11:28:01] Just as this stupid bot that needs spaces everywhere [11:28:14] i hate the wikimedia config [11:28:24] why dey need em spaze [11:28:30] exactly lol [11:28:55] should i revert the arrow fn too? [11:29:08] the problem is not in the arrow [11:29:13] ohk that's the... [11:29:13] It´s with async [11:29:16] too late [11:29:32] arrows are supported since ES6 [11:29:44] yess, was wondering why it was showing up there [11:29:54] k, i'll leave this one for you to revert then? [11:30:07] or i'll do it? [11:30:11] fine either way [11:30:15] Revert what? You haven´t changed anything yet right? [11:30:19] Or am I missing something [11:30:28] revert the async-await for now [11:30:52] I think it´s better to support async-await [11:31:02] if I revert this, you will have about 6 nested promises, I think [11:31:04] 'tis. separate patch or this one, i wonder [11:31:12] your call [11:31:25] I´ll make a seperate patchset that changes the supported ES version [11:32:12] ohk so you want to introduce async await here, create a separate patch that updates the support es version, rebase this patch on top of that? i think i don't fully understand [11:32:17] 10MediaWiki-extensions-DeletePagesForGood: Exception when the page contains some categories - https://phabricator.wikimedia.org/T211757 (10Seb35) [11:32:25] supported* [11:32:33] Yeah, that should work right? [11:32:41] it should. cool. [11:32:50] 10WMCZ-Tracker: [Needs approval] Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 (10takidelfin) [11:32:56] i'll verify that the other errors are fixed and then push [11:33:38] sure [11:33:43] I can help you if you want [11:34:06] sure [11:35:25] (03PS1) 10Nathan fraignt: Change ES version in .eslintrc.json to 8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) [11:36:28] 10WMCZ-Tracker, 10Patch-For-Review: [Needs approval] Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 (10Nathan_fraignt) a:05takidelfin>03Nathan_fraignt [11:36:38] :<<< [11:36:41] minee task [11:36:57] ooh sorry, thought u created it for me lol [11:37:02] :( [11:37:08] anyways it was only one char change [11:37:11] don´t feel sad [11:37:24] I saved you the trouble of doing it, I would be happy lol [11:37:24] no, I want toconvert everything to ES7 then [11:37:35] but I like doing this [11:37:41] Converting is your thing [11:37:59] I only need the supported ES version to change, so my patch can be uploaded [11:38:07] so assign me back ;-; [11:38:31] 10WMCZ-Tracker, 10Patch-For-Review: [Needs approval] Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 (10Nathan_fraignt) a:05Nathan_fraignt>03takidelfin [11:38:32] https://babeljs.io/en/repl.html [11:38:40] You still have to convert all the code [11:38:46] I know [11:39:41] you will need to rebase your patch [11:39:50] 10Developer-Advocacy (Oct-Dec 2018), 10Documentation: Update documentation on [[mw:Community_metrics]] to reflect new UI on wikimedia.biterg.io - https://phabricator.wikimedia.org/T211759 (10Aklapper) p:05Triage>03Normal [11:39:52] I know [11:41:23] (03CR) 10Nathan fraignt: "Needs to be rebased on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479188 once that one is merged." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:42:02] https://usercontent.irccloud-cdn.com/file/N1YAewKL/screenshot_20181212_124157.png [11:42:16] ( ͡~ ͜ʖ ͡°) [11:42:23] Nice [11:42:58] did i miss something? [11:43:18] last thing i saw was taki's "you'll need to rebase" [11:43:28] Not really [11:44:03] (03CR) 10Takidelfin: [C: 031] Change ES version in .eslintrc.json to 8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [11:46:02] (03PS2) 10Esanders: Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 [11:46:07] (03PS5) 10Shreyasminocha: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:46:44] who's rebasing? [11:47:04] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:47:08] i'm up if no one else is [11:47:38] cool, rebasing 479185 onto 479188 [11:47:56] Sorry was getting some water [11:48:01] np [11:48:25] I did not know you could rebase patchsets on other patchsets, thought it only worked on the master branch; TIL [11:49:59] :D [11:50:07] 479188 has a thicc commit message :O [11:50:14] could you cut it down to 50 chars? [11:50:28] wait, let me rebase first [11:50:45] then i think the second rebase gerrit will be able to handle [11:51:03] https://kangax.github.io/compat-table/esnext/ [11:51:03] (03PS6) 10Shreyasminocha: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:51:49] (03PS3) 10Esanders: Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 [11:52:03] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [11:52:04] 10MediaWiki-Uploading, 10Commons, 10Multimedia: Automatically convert .heic image format files to .jpg or .webp - https://phabricator.wikimedia.org/T211745 (10Aklapper) Removing #Wikimedia-site-requests as this task is not about changing a configuration entry from something existing to something else existin... [11:52:15] * shreyasminocha is updating the commit message for 479188 [11:52:38] waait, first let's look at why jenkins daddy failed [11:52:42] You can have up to 80 chars for a commit message right? [11:53:01] convention is to limit the subject to 50 and wrap the body to 72 [11:53:01] yup [11:53:11] Why did no one tell me that [11:53:16] I thought it was 80, 100 [11:53:18] 10mediawiki-extensions-Semantic-Result-Formats, 10Page-Previews (Tracking), 10Readers-Web-Backlog (Tracking): Page Previews not working in SRF Datatables - https://phabricator.wikimedia.org/T211212 (10Aklapper) 05Resolved>03declined (Changing task status, as no code change was merged into the code base) [11:53:19] * takidelfin shrugs [11:53:29] 80 is a max max D: [11:53:35] yeah [11:53:45] hey guys, how do you guys know what to do if you see a bug? When I look at a bug on phabricator it takes me at least a couple hours to see even what I'm changing? [11:53:46] Well there goes my long in depth title [11:53:47] (03PS8) 10Pwirth: [WIP] BlueSpiceCustomMenu Component. ERM:13134 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/476848 (owner: 10Dvogel hallowelt) [11:53:58] What do you mean? [11:54:01] will move that into the topic :) [11:54:05] the body* [11:54:42] sure [11:54:50] source: /me is obsessed with commit messages (https://shreyasminocha.me/blog/commit-message-setup) [11:54:54] Anyways, I´m gonna have lunch. Will be back soon [11:54:59] see you [11:55:03] 10Developer-Advocacy (Oct-Dec 2018): Define questions for a potential code review survey among WMF tech/eng teams - https://phabricator.wikimedia.org/T211741 (10Aklapper) [11:57:41] Like for example with the change to rest api. I looked at the problem and all but I would have no idea what to change. [11:57:49] Do you guys have previous experience with django? [11:58:07] TheJair: just read your question(s) [11:58:17] hmm [11:58:50] or perhaps because I don't have as much experience with tracker [11:58:55] but I doubt that [11:58:58] familiarity with the language/framework the project involves is certainly important. if you're familiar with the codebase, it's usually easy to pick it up [11:59:08] yeah true [11:59:24] Feeling frustrated and stupid though xd [11:59:33] if you continue contributing to the same project, you'll get used to it ofc. :D [11:59:38] it's only natural, dw [11:59:59] You guys are great though :) [12:00:24] (03CR) 10Daimona Eaytoy: [V: 032] "T189560" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) (owner: 10Daimona Eaytoy) [12:01:22] :) not to sound too philosophical/mathematical, but we're all on a journey, each with a different trajectory, each at a different `x value` :D [12:01:47] it's just a matter of time [12:02:08] haha I don't mind philosophy [12:02:27] (03PS1) 10MarcoAurelio: Migrate some infos to a new README.md file from UploadLocal.php [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/479191 [12:02:40] "philosophy's just math sans rigour sense and practicality" [12:02:56] ("and math's just physics unconstrained by precepts of reality") [12:03:20] ((https://xkcd.com/1052/)) [12:03:37] lol [12:03:43] (03CR) 10Daimona Eaytoy: [C: 04-1] "Fix the problem with CI, and avoid the hack in AbuseFilter.php" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455324 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [12:03:45] 10CheckUser: [bug] Special:CheckUser display "Previously blocked" next to IP address if checkuser's current IP is blocked - https://phabricator.wikimedia.org/T211760 (10Urbanecm) [12:04:49] true though [12:05:22] (03PS2) 10MarcoAurelio: Migrate some infos to a new README.md file from UploadLocal.php [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/479191 [12:05:24] 10MediaWiki-Uploading, 10Commons, 10Multimedia: Automatically convert .heic image format files to .jpg or .webp - https://phabricator.wikimedia.org/T211745 (10IM3847) Ok, thank you [12:05:26] every major *is* terrible [12:05:40] lol [12:06:08] "A business major's just a thing you get so you can graduate" [12:06:10] lmao [12:06:35] :D [12:06:44] history gets killed pretty badly too [12:07:13] (03PS1) 10Paladox: Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 [12:08:19] weird, i can't reproduce jenkins' failures [12:08:59] (03PS2) 10Paladox: Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 [12:09:22] might be a nodejs version thing, let me try [12:09:24] (03CR) 10MarcoAurelio: Convert UploadLocal to use extension registration (031 comment) [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) (owner: 10MarcoAurelio) [12:09:27] takidelfin, may I help you somehow? [12:09:35] Urbanecm: i need help [12:09:41] reproducing jenkins' failures [12:09:46] (intended to ping TheJair ) [12:09:59] shreyasminocha, of course, what is your issue? [12:10:11] (03PS1) 10Paladox: Add support for php 7.3 [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/479193 [12:10:16] grunt lint gives one (intended) error on my sys [12:10:21] two more on jenkins [12:10:26] hmm [12:10:35] can you link me to the patch please? [12:10:35] (03PS2) 10Paladox: Add support for php 7.3 [extensions/MassEditRegex] - 10https://gerrit.wikimedia.org/r/479193 [12:10:51] https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185 [12:11:14] thanks, looking [12:12:28] shreyasminocha, https://integration.wikimedia.org/ci/job/wikimedia-cz-tracker-npm-node-6-docker/281/console has just "12:51:49 2:58 error Parsing error: Unexpected token =>" [12:12:34] or am I wrong? [12:12:36] that's the intended one [12:12:40] just saw the ping, thanks for asking Urbanecm but not currently [12:12:41] (03CR) 10jerkins-bot: [V: 04-1] Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 (owner: 10Paladox) [12:12:55] shreyasminocha, I can't see any other error [12:12:59] (in jenkins) [12:13:07] rly? [12:13:19] yes [12:13:27] please send me a link to the output you're looking at [12:13:46] must've been looking at dated output... dumb [12:13:50] (me) [12:14:00] my tabs are a mass [12:14:02] mess* [12:14:08] (03PS3) 10Paladox: Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 [12:14:19] sorry for the trouble Urbanecm [12:14:34] np :) [12:14:39] everyone's blind from time to time [12:14:45] indeed [12:15:03] * andre__ bumps into a door [12:15:14] (03CR) 10Paladox: "recheck" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/465384 (https://phabricator.wikimedia.org/T206519) (owner: 10Tpt) [12:15:14] lol [12:15:54] * Urbanecm waves to andre__ [12:15:55] (03PS2) 10Paladox: Revert "Escape date in non-gallery mode" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/465384 (https://phabricator.wikimedia.org/T206519) (owner: 10Tpt) [12:15:58] andre__: are you fine? :D [12:16:04] (03PS4) 10Paladox: Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 [12:16:42] 10CheckUser: [bug] Special:CheckUser display "Previously blocked" next to IP address if checkuser's current IP is blocked - https://phabricator.wikimedia.org/T211760 (10Urbanecm) [12:19:01] (03CR) 10jerkins-bot: [V: 04-1] Revert "Escape date in non-gallery mode" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/465384 (https://phabricator.wikimedia.org/T206519) (owner: 10Tpt) [12:19:05] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10RHo) >>! In T207717#4815994, @MMiller_WMF wrote: > @SBisson @RHo @Etonkovidova -- thank you for making this turn out great!... [12:19:44] (03CR) 10jerkins-bot: [V: 04-1] Revert "Escape date in non-gallery mode" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/465384 (https://phabricator.wikimedia.org/T206519) (owner: 10Tpt) [12:19:48] (03CR) 10jerkins-bot: [V: 04-1] Fix support for php7.3 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/479192 (owner: 10Paladox) [12:21:50] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lea_Lacroix_WMDE) It's deployed and it wor... [12:21:56] 10DynamicPageList (Wikimedia): DynamicPageList tests is failing - https://phabricator.wikimedia.org/T211762 (10Paladox) [12:23:07] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Adjust thresholds for unmodified content warnings - https://phabricator.wikimedia.org/T211763 (10Pginer-WMF) [12:23:18] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Adjust thresholds for unmodified content warnings - https://phabricator.wikimedia.org/T211763 (10Pginer-WMF) p:05Triage>03Normal [12:23:23] What does 'ack' stand for in tracker? [12:23:42] Acknowledged? [12:24:48] yes I think you're right [12:25:03] * shreyasminocha is doing hacky stuff with versions of deps to 479188 working [12:25:12] acknowledged it is [12:25:21] tcp much [12:27:03] TheJair, others are right. It's used for all events like confirming that the chapter received documents for your expenses, or that you sent them, or that ticket got approved etc [12:28:25] I get it :), thanks [12:29:59] yw [12:30:10] 10MediaWiki-API, 10MediaWiki-extensions-WikibaseClient, 10Wikibase-DataModel, 10Wikidata, and 3 others: PHP Fatal from querypage API: Argument passed to SpecialEntityUsage::__construct must implement EntityIdParser - https://phabricator.wikimedia.org/T208924 (10Lucas_Werkmeister_WMDE) It looks like that sp... [12:33:09] (03CR) 10Shreyasminocha: [C: 04-1] "Doesn't fix the Jenkins -1 in https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185 like it was meant to. I suspect it is somethi" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [12:35:46] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews, 10Services, 10Readers-Web-Backlog (Tracking): Page Previews should take FlaggedRevs' stabilization setting into account - https://phabricator.wikimedia.org/T211501 (10Jack_who_built_the_house) [12:43:07] 10Wikidata-Termbox-Iteration-6: Unbreak CI: `diff-index --quiet HEAD dist/` is red on travis - https://phabricator.wikimedia.org/T211764 (10Pablo-WMDE) [12:43:39] 10Wikidata-Termbox-Iteration-6: Unbreak CI: `diff-index --quiet HEAD dist/` is red on travis - https://phabricator.wikimedia.org/T211764 (10Pablo-WMDE) [12:46:22] o/ [12:46:25] I'm back [12:46:35] sorry for inactivity ;-; [12:48:28] Urbanecm: what happened? [12:48:37] what do you mean? [12:48:47] I got a ping from you :D [12:49:51] refeed: o/ [12:52:05] takidelfin, o/ [12:54:13] takidelfin, the ping was intended for TheJair, sorry :) [12:54:24] (anyway it was a general message "Do you need help?" :)) [12:54:33] ah, sorry then for "re-pinging" [12:54:34] :D [12:55:06] np [12:55:27] * Urbanecm should check after he does the tab completion thingie [12:55:39] :D [12:55:53] have fallen for that again and again [12:56:03] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki, 10TestMe: Make the CAPTCHA more visible when saving - https://phabricator.wikimedia.org/T72266 (10Esanders) The order was switched in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/335223/ when adding a slide transition, putting th... [12:56:23] Googley uses nginx? https://usercontent.irccloud-cdn.com/file/lqkG0obU/screenshot_20181212_135616.png [12:56:23] Nathan_fraignt, takidelfin: found the issue with https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479188 [12:56:26] fixing [12:56:43] thank you shreyasminocha [12:56:53] you're welcome [12:57:00] 10MediaWiki-Interface, 10Front-end-Standards-Group, 10TechCom, 10TechCom-RFC, and 3 others: Merge Extension:Theme into core - https://phabricator.wikimedia.org/T122924 (10mobrovac) [12:57:01] and my pleasure [12:57:46] shreyasminocha: hmm, good catch. I'll try to fix it too. [12:57:53] 10MediaWiki-Interface, 10Front-end-Standards-Group, 10TechCom, 10TechCom-RFC, and 3 others: Merge Extension:Theme into core - https://phabricator.wikimedia.org/T122924 (10mobrovac) I updated the task description to reflect the fact that the canonical place for this RfC is its MW page. [12:58:05] * Nathan_fraignt is back [12:58:09] i found it tho. the parseroptions was supposed to be on the outermost level [12:58:14] rather than within overrides [12:58:17] :P [12:58:18] Nice shreyasminocha [12:58:27] shreyasminocha: lol [12:58:30] Don´t exactly understand what the issue is, but good job on finding it [12:58:46] uploading after i fix some subsequent errors [12:59:03] Nathan_fraignt: you put ecmaVersion: 8 in override for static/toggleAllNotifis [12:59:13] while it should be in 'root' [12:59:15] oh I´m stupid [12:59:31] :D happens [12:59:33] Sorry, don´t have any experience with eslint whatsoever [12:59:52] Why I didn't catch that ;/ [13:00:00] happens even when to people who're familiar with it (source: me) [13:00:31] https://www.npmjs.com/package/eslint-plugin-async-await [13:01:19] shreyasminocha: #meToo :D [13:01:27] :D [13:01:35] `You were kicked by •ChanServ: This channel has been closed` [13:02:10] MatmaRex: o/ [13:02:17] hi [13:02:39] hmm looks like our package-lock.json is outdated [13:03:19] wonder if jenkins will cry if i don't push the updated one [13:03:22] let's try [13:04:18] 10Design, 10Wikipedia-Android-App-Backlog, 10Privacy, 10WorkType-NewFunctionality: "Incognito mode" - Add an option to disable save of recent search queries and recent articles (working patch available, but currently abandoned) - https://phabricator.wikimedia.org/T96546 (10Dbrant) [13:04:20] 10Wikipedia-Android-App-Backlog: As a user, I want to be able to turn off "recent searches" - https://phabricator.wikimedia.org/T211740 (10Dbrant) [13:05:12] shreyasminocha: true [13:11:02] Urbanecm: after fixing the issue at hand, there's another lint error that needs to be fixed [13:11:11] ack [13:11:17] I guess you're fixing it? :) [13:11:33] am updating the fix to eslintrc in the parent patch. wanted to check where i should fix this additional error [13:12:46] in parent patch, kid patch, separate patch, ... and if separate patch (i think the way to go), what should i make dependent on what [13:14:26] shreyasminocha: Could I help you somehow? [13:14:56] any ideas on where to place this new fix takidelfin? [13:15:09] Urbanecm: ^^ [13:15:18] eslint? [13:15:32] there is another lint error [13:15:37] umm? [13:15:41] which patch should i fit that in [13:16:02] i think it belongs to a separate one, but not sure what i would rebase onto what in that case [13:16:04] is it related to ES8? [13:16:24] shreyasminocha, to confirm, you want to set ES8 as the ES version for Tracker? [13:16:26] the error message has the word "const" in it [13:16:35] Urbanecm: yeah, but that's not the issue [13:16:37] Urbanecm: yup, because of await/async [13:16:54] https://phabricator.wikimedia.org/T211758 [13:16:55] ok, so what we're trying to do now? I'm a little bit confused, perhaps because I didn't watch the logs for some time :) [13:16:59] the issue is where to fix this additional error and how to structure the patches around these fixes [13:17:33] where does the additional lint error fix belong (one of these patches, a separate one) and if the latter, what would we make dependent on what [13:17:38] In that case, I'd upload a new patch and rebase https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185 on it [13:18:04] if you want to have patch C to be dependent on patch A and B, you need to do it in a different way [13:18:04] * shreyasminocha is checking if the error exists in master [13:18:08] https://gerrit.wikimedia.org/r/#/c/479188/ [13:18:21] patch C dependent on patch B and patch be dependent on patch A [13:18:28] so there's clear order of merging [13:18:32] okay :D [13:18:33] shreyasminocha, ^^ [13:18:51] o_O [13:18:55] * shreyasminocha is processing... [13:19:00] * Urbanecm is waiting on shreyasminocha [13:19:04] Also, could you review this task? T211758 [13:19:04] T211758: [Needs approval] Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 [13:19:27] I don't have a problem with it - why not .) [13:19:36] i'll be back in some thirty minutes [13:20:05] k shreyasminocha [13:20:15] 10WMCZ-Tracker, 10Patch-For-Review: [Needs approval] Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 (10takidelfin) [13:21:04] 10MediaWiki-extensions-DeletePagesForGood: Exception caught when deleting a page - https://phabricator.wikimedia.org/T201486 (10Seb35) @PlavorSeol: what are your versions of MediaWiki and DeletePagesForGood? And do you use MySQL or PostgreSQL? If you can, try with a recent version of DeletePagesForGood. @Palado... [13:21:07] 10WMCZ-Tracker, 10Patch-For-Review: Update Tracker code from ES6 to ES7 - https://phabricator.wikimedia.org/T211758 (10takidelfin) [13:21:11] 10WMCZ-Tracker, 10Patch-For-Review: Update Tracker code from ES6 to ES8 - https://phabricator.wikimedia.org/T211758 (10takidelfin) [13:21:19] (Whoops, I mistaken ES7 with ES8) [13:21:23] 10Growth-Team (Current Sprint): Help panel: design tweaks - https://phabricator.wikimedia.org/T211633 (10RHo) [13:21:32] (because of 2017 :( ) [13:21:54] 10Growth-Team (Current Sprint): Help panel: design tweaks - https://phabricator.wikimedia.org/T211633 (10RHo) >>! In T211633#4815795, @MMiller_WMF wrote: > @RHo will prioritize the different issues in this task to help the team work through them. Updated on each line item in the Task description. [13:22:52] * Urbanecm was thinking about it for a while [13:25:11] (03PS24) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [13:25:17] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Ladsgroup) It's not deployed yet (accordin... [13:26:15] (03PS1) 10Esanders: Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 [13:26:17] (03PS1) 10Esanders: mw.Title: Rename vars and imporve docs around newFromUserInput double signature [core] - 10https://gerrit.wikimedia.org/r/479200 [13:29:56] (03PS1) 10Paladox: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_29) - 10https://gerrit.wikimedia.org/r/479201 [13:30:03] (03CR) 10Paladox: [C: 032] Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_29) - 10https://gerrit.wikimedia.org/r/479201 (owner: 10Paladox) [13:30:05] (03CR) 10Phuedx: Avoid hitting DB in Category getters when they have the required info (031 comment) [core] - 10https://gerrit.wikimedia.org/r/472184 (https://phabricator.wikimedia.org/T63045) (owner: 10Agabi10) [13:30:09] The succession of these flame emperors, from Shennong, the first Yan Emperor, until the time of the last Yan Emperor's defeat by the Yellow [13:30:09] Emperor, may have been some 500 years. [13:30:09] (03PS1) 10Paladox: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_28) - 10https://gerrit.wikimedia.org/r/479202 [13:30:13] (03CR) 10Paladox: [C: 032] Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_28) - 10https://gerrit.wikimedia.org/r/479202 (owner: 10Paladox) [13:30:15] (03CR) 10Phuedx: "Sorry for the delay, Agabi10." [core] - 10https://gerrit.wikimedia.org/r/472184 (https://phabricator.wikimedia.org/T63045) (owner: 10Agabi10) [13:30:29] (03PS1) 10Paladox: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_27) - 10https://gerrit.wikimedia.org/r/479203 [13:30:31] (03CR) 10Paladox: [C: 032] Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_27) - 10https://gerrit.wikimedia.org/r/479203 (owner: 10Paladox) [13:32:33] 10Contributors-Analysis, 10Product-Analytics: Update editor_month generation to use change_tag table rather than tag_summary - https://phabricator.wikimedia.org/T210807 (10Ladsgroup) @Neil_P._Quinn_WMF Hey, this should work for the first part, the second part would be similar: ` select left(rev_timestamp, 6)... [13:33:25] (03CR) 10jerkins-bot: [V: 04-1] Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 (owner: 10Esanders) [13:34:33] (03CR) 10jerkins-bot: [V: 04-1] mw.Title: Rename vars and imporve docs around newFromUserInput double signature [core] - 10https://gerrit.wikimedia.org/r/479200 (owner: 10Esanders) [13:35:32] 10MediaWiki-extensions-DeletePagesForGood: Exception caught when deleting a page - https://phabricator.wikimedia.org/T201486 (10Paladox) @Seb35 i think so. [13:37:33] (03Merged) 10jenkins-bot: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_29) - 10https://gerrit.wikimedia.org/r/479201 (owner: 10Paladox) [13:37:35] (03Merged) 10jenkins-bot: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_28) - 10https://gerrit.wikimedia.org/r/479202 (owner: 10Paladox) [13:37:37] (03Merged) 10jenkins-bot: Fix condition for deletion of searchindex row [extensions/DeletePagesForGood] (REL1_27) - 10https://gerrit.wikimedia.org/r/479203 (owner: 10Paladox) [13:37:53] 10CheckUser: Special:CheckUser display "Previously blocked" next to IP address if checkuser's current IP is blocked - https://phabricator.wikimedia.org/T211760 (10Reedy) [13:38:12] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10SBisson) >>! In T207717#4816636, @RHo wrote: > [...] > FWIW, it is the same radio button control as var A, it has just been... [13:39:30] 10Contributors-Analysis, 10Product-Analytics: Update editor_month generation to use change_tag table rather than tag_summary - https://phabricator.wikimedia.org/T210807 (10Ladsgroup) Made https://github.com/wikimedia-research/Editing-movement-metrics/pull/1/files [13:39:31] Urbanecm, do you know what wgCategoryCollation that is appropriate for napwikisource? or .. I can ask it on the task [13:39:59] refeed, look what is used for other wikis in that language. Should be same, I think [13:42:03] Alright, I think it should be the default one then, since napwiki is using the default value [13:45:45] Urbanecm, I think I'll also ask in in the task to verify it much further (MarcoAurelio asked me to do so), since there are some cases like `frwiki` which uses `uca-fr-u-kn`, but `frwikibooks` uses `uca-fr` [13:45:59] ok, that's fine too [13:48:42] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10RHo) >>! In T207717#4816789, @SBisson wrote: >>>! In T207717#4816636, @RHo wrote: >> [...] >> FWIW, it is the same radio but... [13:48:52] Netaji Subhas Chandra Bose International Airport [13:48:52] Bir Tikendrajit International Airport [13:48:54] Guwahati International Airport [13:48:54] Mandalay International Airport [13:48:54] Chiang Mai International Airport [13:48:54] Noi Bai International Airport [13:48:54] Siem Reap-Angkor International Airport [13:48:54] Mactan–Cebu International Airport [13:53:39] what's that nelsonhb ? [13:53:44] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10rafidaslam) @StevenJ81 (or someone from Neapolitan Wikisource), Hi, I wanna ask about what `$wgCategor... [13:56:41] * refeed is getting used to the new Gerrit's UI [13:57:09] * shreyasminocha is back [13:57:19] someone please kick nelsonhb [13:57:23] Hiranyagarbha (the cosmic egg).He is more prominently mentioned in the post-Vedic Hindu epics and the mythologies in the Puranas. In the [13:57:23] epics, he is conflated with Purusha. [13:57:39] kick this lad please [13:57:56] mhm, is he a bot? [13:58:00] spam for sure [13:58:09] pastes this sh*t repeatedly [13:58:25] any ops around? [13:58:30] Urbanecm: anyone you know? [13:58:39] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10SBisson) >>! In T207717#4815994, @MMiller_WMF wrote: > @SBisson @RHo @Etonkovidova -- thank you for making this turn out gre... [13:59:32] actually, a kick might not be enough [13:59:45] 🤔 [13:59:48] !ops nelsonhb, spammer, please kick(ban) it, thanks [13:59:48] There is no such key, you probably want to try: !anonnotice, !oversight, !svnprops, !opsschool, !ternary, [13:59:55] no [13:59:58] earlier today they were trying to login but weren't able to because 'Excess flood'. they're back [13:59:59] hes doing the same thing in the en channel [14:00:06] important message [14:00:16] nice [14:00:18] thank you petan [14:00:21] thanks petan [14:00:23] ty ^-^ [14:01:04] np [14:01:14] * refeed just know that's what #wikimedia-ops channel is used for [14:01:21] * McJohn sets wm-bot to ignore… [14:01:40] btw thanks petan! [14:01:48] https://i.imgur.com/O3DHIA5.gif [14:02:05] :D [14:02:19] Item ops was inserted to ignore list [14:02:19] @infobot-ignore+ ops [14:02:31] :O [14:02:43] that's to prevent that no such key thing in future :P [14:02:51] nice [14:03:21] it should be !admins ? [14:03:34] takidelfin: btw we got our answer to "is he a bot?" :D [14:03:40] takidelfin: irc lingo [14:03:43] takidelfin, the key I used is to ping IRC channel operators [14:03:51] the key ops [14:03:56] ay ;-; [14:03:57] sorry [14:03:57] admins is usually used for on-wiki admins [14:03:58] np [14:04:01] just explaining :) [14:04:06] :D [14:04:52] Urbanecm: the new patch will have to depend on ----85 [14:05:51] shreyasminocha, shouldn't it be the other way around? [14:06:04] to have jenkins +2 on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185, we need your new patch [14:06:04] the error is in ----85 [14:06:17] or maybe I didn't understand something :) [14:06:45] the lint error exists only in https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185, so the new patch will be based off of that? [14:07:10] hmm, what caused the error? [14:07:14] --85? [14:07:24] yeah, seems like it [14:07:37] if --85, then let's fix it there [14:07:48] okay [14:08:13] (03PS9) 10Dbrant: [EXTREME WIP] Augmented keyboard for editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) [14:11:40] 10Editing Design , 10VisualEditor (Current work): User Testing of Isolated Section Editing - https://phabricator.wikimedia.org/T209986 (10iamjessklein) @Ryasmeen I think those questions perfectly compliment the ones I wrote. So what are the next steps? I think the first is finding out where the prototype will... [14:12:03] (03PS1) 10Pwirth: Fix css class handling and add contains-children class [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/479208 [14:12:15] (03PS2) 10Shreyasminocha: Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [14:12:45] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10Trizek-WMF) Concerning headers numbering, all options should be considered based on archiving options. At t... [14:12:46] (03PS9) 10Pwirth: [WIP] BlueSpiceCustomMenu Component. ERM:13134 [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/476848 (owner: 10Dvogel hallowelt) [14:12:48] (03CR) 10jerkins-bot: [V: 04-1] Fix css class handling and add contains-children class [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/479208 (owner: 10Pwirth) [14:12:49] 10Editing Design , 10VisualEditor (Current work): Design usability test for overlay - https://phabricator.wikimedia.org/T211597 (10JTannerWMF) [14:13:07] (03PS7) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) [14:13:34] (03PS2) 10Pwirth: Fix css class handling and add contains-children class [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/479208 [14:13:51] Urbanecm: i see three outstanding commits instead of 2... [14:14:00] strange [14:14:22] but look you updated https://gerrit.wikimedia.org/r/479188 successfully, didn't you? [14:14:27] yes [14:14:32] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Candalua) >>! In T210752#4816813, @rafidaslam wrote: > @StevenJ81 (or someone from Neapolitan Wikisour... [14:14:41] pushing rebased --88 [14:14:45] -85 * [14:16:17] Urbanecm: need to get rid of the one in between [14:16:51] You can simply click rebase on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185 and fill changeid (the shorter, numberic one) on which you want to rebase the change [14:17:06] or, you can delete the branch, download by git review -d, rebase again and push [14:17:13] former is easier, at least for me ;) [14:17:16] no button [14:17:34] ? [14:17:38] 10MobileFrontend, 10Advanced Mobile Contributions, 10VisualEditor, 10Readers-Web-Backlog (Tracking): iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode - https://phabricator.wikimedia.org/T211490 (10JTannerWMF) Hey @Esanders I will put this in needs discussion and let you decide... [14:17:42] no rebase button [14:17:43] shreyasminocha: use polygerrit maybe :D [14:17:51] https://gerrit.wikimedia.org/?polygerrit=1 [14:18:14] still no button [14:18:20] aha [14:18:26] gerrit's given up on auto-merging this i guess [14:18:39] * Urbanecm forgot only change owners or project owners see it :( [14:18:48] oh! [14:18:57] i'll rebase it manually, shouldn't take much [14:19:01] k [14:19:26] (03CR) 10Nouman: "@Esanders have updated handler to use promise for getting recaptcha script" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [14:20:36] will allow me to practice rebase-fu [14:21:06] (psst, try Intellij IDEA merge tool) [14:21:18] (it is better than Git Lens) [14:21:35] better than vs code's thing you mean? :p [14:21:38] :o* [14:21:39] yup [14:21:49] :o [14:21:52] I'm using VS Code too, so I can compare them :D [14:22:02] aha [14:22:04] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Catalogue where the MobileFrontend loading overlay is used - https://phabricator.wikimedia.org/T209708 (10Jdlrobson) See also "steps to reproduce" in T201687. Happy to walk someone through these if helpful! [14:22:07] (03PS7) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [14:22:17] Intellij's auto merge is so cool (every time it merged it as I expected :O ) [14:22:27] wait, did nathan just push something [14:22:29] (even if it was a hard to merge thing) [14:22:33] yup [14:22:43] I rebased it [14:22:49] ohk [14:22:54] cool :p [14:23:06] (03CR) 10jerkins-bot: [V: 04-1] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [14:23:08] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10rafidaslam) > According to the manual, there are collations specific for each language; nap is not the... [14:23:16] Sorry not actively chatting, busy [14:23:20] well still not working [14:23:26] ono it'll fail [14:23:32] gerit'll die [14:23:34] lemme try [14:23:36] fixing [14:23:41] 10Editing Design , 10VisualEditor (Current work): Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10iamjessklein) Things that I taking into account in the next iteration include: * Surfacing the toolbar to the user * The effect of the progress bar wit... [14:23:42] ohk [14:23:43] nevermind [14:23:46] this was is easy fix [14:23:53] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 2 others: Is it still necessary to insert a row into page_props when creating a MediaInfo item for a page? - https://phabricator.wikimedia.org/T205417 (10Cparle) 05Open>03Resolved [14:24:16] takidelfin: go on [14:24:42] form.js, gotta combine the const declarations [14:24:44] I think he is fixing it [14:24:46] + [14:24:49] yeah [14:25:07] But the weird errors/outdated errors are all gone now [14:25:09] so that is good [14:25:19] :D [14:25:43] today i was going through @wikimedia GH org's members [14:25:50] doen [14:25:52] done [14:25:55] or nope [14:25:55] ;-; [14:25:57] and i was able to put faces to so many names i see around here [14:26:05] [remote rejected] HEAD -> refs/publish/master/topics-use-rest-api (no new changes) [14:26:10] Ebe123: o/ [14:26:14] forgot to git add? [14:26:16] (03PS1) 10Anomie: ApiBase: Pass empty string, not null, for $conds to ->select [core] - 10https://gerrit.wikimedia.org/r/479210 [14:26:30] nope [14:26:37] takidelfin: delete your current branch, -d again, commit, push? [14:26:50] If it still doesn´t work I´ll change it [14:26:57] Hey! Last couple hours! [14:26:59] yeah, it's not much [14:27:01] oops, problem [14:27:02] umm [14:27:03] hi Ebe123 [14:27:16] hi Ebe123 [14:27:18] Nathan_fraignt: it's not much * [14:27:23] takidelfin, want me to fix it? [14:27:31] That probably easier and faster [14:27:33] wait, I forgot to stash changes from my previous [14:27:36] D: [14:27:38] :D [14:27:39] Git f-ck ups suck [14:27:47] they can get rly ugly [14:27:54] * shreyasminocha is looking for the relevant xkcd [14:28:05] https://xkcd.com/1597/ [14:28:34] Sigh, that comic strip does describe my workflow sometimes. :-( [14:28:42] Same [14:28:43] Ebe123: last couple hours what? [14:28:43] andre__: o/ [14:28:46] yeah, me too [14:29:04] 10Editing Design , 10VisualEditor (Current work): Design usability test for overlay - https://phabricator.wikimedia.org/T211597 (10Esanders) Agreed - we had this raised as an issue in our previous user tests, so if it becomes a non issue in subsequent tests that should be counted as a success. [14:29:06] shreyasminocha, students can submit tasks till 17:00 CET :) [14:29:14] oh, hah [14:29:18] forgot [14:29:33] All good things must come to an end :( [14:29:36] Though https://github.com/hbons/git-cheat-sheet is sometimes helpful [14:30:00] Ebe123: :( [14:30:10] cool sheet :) [14:30:14] 18:00 right? [14:30:17] git reflow save me now ;-; [14:30:21] 10:30 [14:30:21] Or timezone difference? [14:30:32] * andre__ should send a follow-up message to the most active GCI students, at least this year (been on my list for years now, sigh) [14:30:33] 2.5 hours [14:31:01] Takidelfin, what did you change? [14:31:08] There is only one const on line 9 [14:31:29] Does it want me to merge the line 3 const with the line 9 const!? [14:31:36] it does [14:31:38] precisely [14:31:43] But I don´t want that [14:31:47] lol [14:31:52] i realised, sad [14:32:00] andre__, what kind of message? :) [14:32:03] you could override it from eslint if you were keen. although it is a weird rule [14:32:14] Urbanecm: i'm guessing an invitation to continue contributing [14:32:28] Not sure about overriding, just trying to wrap my head around why it would want that [14:32:30] Nathan_fraignt, takidelfin: why not disable the rule altogether [14:32:36] that has my vote [14:32:42] mine too [14:32:57] (03CR) 10Zfilipin: "please create a phab ticket and reference it in the commit that fixes the problem, we need it for tracking incidents" [core] - 10https://gerrit.wikimedia.org/r/479210 (owner: 10Anomie) [14:33:32] let's just use eslint-config-shreyasminocha :D [14:33:33] Shreyasminocha, can you do that? (Since you are the eslint master that updated the conf) [14:33:36] (jk) [14:33:43] Nathan_fraignt: if takidelfin approves [14:33:50] I lost my redesign work ;c [14:33:55] t_t [14:33:59] sad [14:34:44] takidelfin, ? [14:34:45] (03PS8) 10Takidelfin: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [14:35:04] Inkscape wasn't behaving? [14:35:05] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds must be a string or an array - https://phabricator.wikimedia.org/T211769 (10zeljkofilipin) p:05Triage>03Unbreak! [14:35:12] takidelfin was working on redesigning tracker [14:35:17] yup [14:35:19] i think that's what he's referring to [14:35:22] (03PS2) 10Zfilipin: ApiBase: Pass empty string, not null, for $conds to ->select [core] - 10https://gerrit.wikimedia.org/r/479210 (https://phabricator.wikimedia.org/T211769) (owner: 10Anomie) [14:35:42] Ah, git wasn't behaving then [14:35:44] I kinda don´t like the way line 2 -18 are formatted in form.js now [14:35:58] hmm... Urbanecm can we remove the rule? [14:36:01] one-const [14:36:04] You added it [14:36:10] me? [14:36:13] yup, I prefer const const const [14:36:15] (03PS1) 10Pboehm: Merge i18n from master into REL1_31 [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/479212 [14:36:16] too [14:36:18] I think so, yes [14:36:26] (03CR) 10Anomie: "> please create a phab ticket and reference it in the commit that fixes the problem, we need it for tracking incidents" [core] - 10https://gerrit.wikimedia.org/r/479210 (https://phabricator.wikimedia.org/T211769) (owner: 10Anomie) [14:36:27] no [14:36:32] jenkins +2 [14:36:35] 'ed [14:36:37] 10Design, 10Mobile, 10Spanish-Sites: Review new es.wikipedia's main page - https://phabricator.wikimedia.org/T211482 (10alexhollender) Looks great to me on desktop and mobile. @abian were there any specific concerns? [14:36:39] It wasn´t there before the rebase on your patchset [14:36:52] I think [14:36:52] because it wasn't being able to parse the js earlier [14:36:56] so it couldn't check any rules [14:36:59] shreyasminocha, if you all agree on disabling an eslint rule, then it'll be probably fine with me too :) [14:37:06] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds must be a string or an array - https://phabricator.wikimedia.org/T211769 (10zeljkofilipin) [14:37:44] i personally prefer const, const, const too, but we'll stick to what the existing convention apart from where it makes logical sense to split them into blocks (like form.js) [14:37:46] https://usercontent.irccloud-cdn.com/file/3HB3XXKp/screenshot_20181212_153718.png [14:37:46] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds must be a string or an array - https://phabricator.wikimedia.org/T211769 (10zeljkofilipin) [14:37:50] https://usercontent.irccloud-cdn.com/file/9vyNpzbu/screenshot_20181212_153740.png [14:37:51] (03Abandoned) 10Pboehm: Merge i18n from master into REL1_31 [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/479212 (owner: 10Pboehm) [14:37:58] sounds good? [14:38:01] + [14:38:01] Urbanecm: screenshots [14:38:08] they ll show what we want :D [14:38:11] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:38:14] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:38:39] Not entirely^^ [14:38:41] so i'm removing the one-const rule and undoing PS8, but letting the commas be [14:38:42] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:38:44] takidelfin: ^ [14:38:50] godammit wikibugs [14:38:52] ok shreyasminocha [14:38:54] What shreyasminocha says, yeah [14:40:29] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:40:41] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:41:43] 10VisualEditor (Current work): [Regression wmf.4] Old content shows up for a brief second after opening VE for an article - https://phabricator.wikimedia.org/T210547 (10JTannerWMF) [14:42:09] (03PS9) 10Shreyasminocha: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [14:42:21] Urbanecm: related to T211601: [14:42:22] Two options: pre-commit hook auto-converting line-endings to LF, or adding it to .gitignore ? [14:42:22] T211601: Force unix line endings by a linter - https://phabricator.wikimedia.org/T211601 [14:42:41] takidelfin: i was thinking of editorconfig [14:42:47] 10VisualEditor (Current work): [Regression wmf.4] Old content shows up for a brief second after opening VE for an article - https://phabricator.wikimedia.org/T210547 (10JTannerWMF) a:03matmarex [14:43:09] (03PS1) 10Esanders: Remove unused /* global console */ [core] - 10https://gerrit.wikimedia.org/r/479214 [14:43:18] maybe editorconfig + one of these options? [14:43:29] Shreyasminocha, shoudln´t the eslint changes be done in the other patch? [14:43:45] ^ [14:43:45] point [14:43:56] Urbanecm: pls revert PS9? [14:44:00] shreyasminocha, will do [14:44:13] * Urbanecm is reverting PS9 of 479185 [14:44:16] \o/ [14:44:23] (and willing to teach shreyasminocha & others :)) [14:44:25] takidelfin: maybe we could use husky (on npm) to synchronise a pre-commit hook [14:44:33] Urbanecm: yess [14:44:59] shreyasminocha, okay, so I'll tell you what to do here :) [14:45:11] * Nathan_fraignt is also listening [14:45:26] on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185, you should be able to select a patchset above the list of the files [14:45:56] in next steps, we'll make the patch look exactly how it looked in selected patchset [14:46:06] as we want to revert PS9 only, let's select PS8 [14:46:20] then, click on "download" button next to the selection thing [14:46:26] it'll show several commands [14:46:32] copy the checkout one [14:46:37] and execute it locally [14:46:49] (03Restored) 10Pboehm: Merge i18n from master into REL1_31 [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/479212 (owner: 10Pboehm) [14:46:49] lmk once you're done shreyasminocha (or whoever is doing this) [14:46:51] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:46:54] :D [14:46:55] alr [14:47:52] takidelfin, ad your question. Hook would work, but it's bypassable - we should add a check to jenkins anyway [14:47:56] wait, but nathan: if stuff happened in order, you'd update eslint's version first in one patch. then when you made the other changes (to the api calling etc), you'd notice this weird rule [14:48:00] (03CR) 10Pboehm: "Pull changes in i18n from master into REL1_31" [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/479212 (owner: 10Pboehm) [14:48:20] and edit the eslintrc with latter patch [14:48:27] does that make sense? Nathan_fraignt [14:48:32] Euhm [14:48:35] Not really [14:48:59] You´d update eslint in one patch, that is the parnt patch [14:49:06] then the other changes, this patch [14:49:23] don´t know what ¨this weird rule¨ is [14:49:25] but you wouldn't be able to anticipate the rule in the first patch? [14:49:40] the weird rule(s) are "one-var" and "one-const" [14:49:45] Urbanecm: okay, so I will need to add it to htmlLint, eslint and styleLint? [14:49:51] and maybe tox [14:50:10] well, I don´t think they are weird, and I kinda get your point [14:50:15] takidelfin: or you could use editorconfig and not edit those three [14:50:22] Well I'd simply add a check (in tox or npm part, whatever is easier for you) to go through _all_ files within the repo and check if they have unix endings [14:50:36] Nathan_fraignt: i mean, yeah, can't quite call them weird ¯\_(ツ)_/¯ [14:50:49] but there is a lot of ES lint update stuff going on in the parent patch, and I think the rules fit nicely in there [14:50:59] hmm [14:51:03] we want to check not only .py, .css and .js, but also support/deploy or requirements.txt and others [14:51:08] your patch, so as you say :) [14:51:11] anyhow, they need to be in a patch before the api one, since if not, the api one won´t be able to merge [14:51:39] they could/should be in the api patch itself, is what i was proposing [14:51:43] but this thing's subjective [14:51:45] Wouldn´t work [14:51:50] why? [14:51:50] I think [14:51:57] hmm maybe, yeah [14:51:58] (03PS1) 10ItSpiderman: Refactoring of results panel [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/479217 [14:52:01] Don´t de rules need to be applied before the patch [14:52:01] no it would [14:52:05] no [14:52:14] they can be added with the patch [14:52:15] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [14:52:27] 10MediaWiki-History-or-Diffs, 10Advanced Mobile Contributions, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): It's not possible to undo edits from the revision history or d... - https://phabricator.wikimedia.org/T191706 [14:52:37] but your earlier arg is valid, so let's do that [14:52:41] in that case, it could work. Still, my preference is for it to be in the Eslint patch. I guess takidelfin/urbanecm has the deciding vote [14:52:55] Alright, also good [14:53:19] no big deal [14:53:28] (03PS3) 10Shreyasminocha: Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [14:53:47] * shreyasminocha is fixing form.js now [14:53:54] oh wait that's fixed already [14:54:02] i guess we're done [14:54:04] Urbanecm: ping [14:54:08] * Urbanecm waves [14:54:27] Nathan_fraignt: just rebase -85 onto -88 [14:54:36] (03PS10) 10Nathan fraignt: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) [14:54:47] :D [14:54:49] Done [14:54:50] I think [14:54:55] looks so [14:55:37] may the jenkins gods bless us [14:55:37] (03CR) 10Urbanecm: [C: 04-1] Update eslint to ES8 to support async/await (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [14:55:39] reviewed [14:55:51] cormacparle, addshore: I'm trying to set up MediaInfo, but I'm hitting problems with some js modules not being found. E.g. script file not found: "/var/www/mediawiki/extensions/Wikibase/view/lib/resources/wikibase-data-values/lib/../../../wikibase-data-values/lib/util/util.inherit.js" [14:56:15] That is your cup of tea shreyasminocha ^^ [14:56:15] duesen__, not checked it, but the repository might have submodules. Did you pull them? [14:56:33] Urbanecm: fair enough [14:56:36] cormacparle, addshore: I indeed can't find any of these files. any idea what's going on? [14:56:43] (03PS25) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [14:57:12] Urbanecm: i'll also sneak in a tiny indentation fix in eslintrc if you don't mind [14:57:19] ok shreyasminocha [14:57:24] duesen__, as I wrote above, those are likely part of submodules you didn't clone [14:57:37] git submodule update --init does that IIRC [14:57:49] ... [14:58:04] lol [14:59:15] hehe [14:59:22] I gtg, I´ll probably be back in about ~7 hours, but if works gets late, it´ll be tommorow. Cya! [14:59:28] bye [14:59:43] Bye! [15:00:11] (03PS4) 10Shreyasminocha: Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [15:00:20] Urbanecm: it seems like you were right, thank you! [15:00:25] Urbanecm: now all that's needed is a rebase [15:00:31] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @chiborg - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:00:31] yw duesen [15:00:35] let's do that then [15:00:35] (03CR) 10Takidelfin: Change: Edit/Create ticket view now uses REST API (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [15:00:54] (03PS11) 10Urbanecm: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [15:00:58] {{done}} [15:01:05] (03CR) 10Niedzielski: [C: 04-1] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [15:01:06] hmm, is there a way to change nickname capitalization in Gerrit? [15:01:14] I don't think so [15:01:15] takidelfin: unfortunately it's non-trivial [15:01:19] (03CR) 10Ladsgroup: [C: 032] ApiBase: Pass empty string, not null, for $conds to ->select [core] - 10https://gerrit.wikimedia.org/r/479210 (https://phabricator.wikimedia.org/T211769) (owner: 10Anomie) [15:01:19] i have the same issue [15:01:44] 10Wikidata-Termbox-Hike: Termbox toggle state for logged-in users - https://phabricator.wikimedia.org/T211771 (10Lea_WMDE) [15:01:54] * shreyasminocha needs to eat [15:01:57] (03PS1) 10Ladsgroup: ApiBase: Pass empty string, not null, for $conds to ->select [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479219 (https://phabricator.wikimedia.org/T211769) [15:02:14] ok, I will be back soon (exaaam tomorrow) [15:02:21] all the best, bye [15:02:27] shreyasminocha, I don't want to -1 again, but I don't think we should keep an empty override, should we? [15:02:30] good luck takidelfin [15:02:34] see you tomorrow! [15:02:41] s/tomorrow/later/ [15:02:44] (I ll be back today :D) [15:02:45] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:02:46] Urbanecm: fixing. shit. [15:03:01] Urbanecm: wait, what empty override? [15:03:13] 17-19 [15:03:15] Greetings, I'm trying to use mediawiki docker, and I've just added extention Flow, and I'm trying to understand where I should be running the populateContentModel.php script, as described here: https://www.mediawiki.org/wiki/Extension:StructuredDiscussions#Enabling_or_disabling_StructuredDiscussions [15:03:17] if there will be an important dissussion you can ping me ^-^ [15:03:19] ono [15:03:26] plus why are there two overrides blocks? [15:03:28] looks like an empty override [15:03:30] will fix after food [15:03:32] bye [15:03:35] o/ [15:03:36] one for each file? [15:03:57] toggleAllNotifs was in es6 and tests were failing [15:03:58] (03CR) 10Ladsgroup: [C: 032] ApiBase: Pass empty string, not null, for $conds to ->select [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479219 (https://phabricator.wikimedia.org/T211769) (owner: 10Ladsgroup) [15:04:00] so I added this second block [15:05:19] btw...iirc we didn't finish our revert lesson, did we? [15:05:58] uwe_: iirc, docker attach and then in finding mediawiki root folder and running the command (but replacing `mwscript` with `php maintenance/populateContentModel.php`) ? [15:07:43] (03CR) 10Tjones: [C: 032] Add noop surrogate_merger as a BC tokenfilter for WMF indices [search/extra] - 10https://gerrit.wikimedia.org/r/478887 (https://phabricator.wikimedia.org/T209348) (owner: 10DCausse) [15:08:44] (03CR) 10Niedzielski: [C: 04-1] Port toggle.js to webpack (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479137 (https://phabricator.wikimedia.org/T210208) (owner: 10Jdrewniak) [15:11:12] (03Merged) 10jenkins-bot: Add noop surrogate_merger as a BC tokenfilter for WMF indices [search/extra] - 10https://gerrit.wikimedia.org/r/478887 (https://phabricator.wikimedia.org/T209348) (owner: 10DCausse) [15:12:05] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:15:16] (03Merged) 10jenkins-bot: ApiBase: Pass empty string, not null, for $conds to ->select [core] - 10https://gerrit.wikimedia.org/r/479210 (https://phabricator.wikimedia.org/T211769) (owner: 10Anomie) [15:17:15] (03CR) 10jenkins-bot: Add noop surrogate_merger as a BC tokenfilter for WMF indices [search/extra] - 10https://gerrit.wikimedia.org/r/478887 (https://phabricator.wikimedia.org/T209348) (owner: 10DCausse) [15:17:45] (03CR) 10jenkins-bot: ApiBase: Pass empty string, not null, for $conds to ->select [core] - 10https://gerrit.wikimedia.org/r/479210 (https://phabricator.wikimedia.org/T211769) (owner: 10Anomie) [15:17:47] (03CR) 10Sbisson: [C: 04-1] Flow: Add Topic tour for GuidedTour extension and fix undefined error (033 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [15:18:17] (03Merged) 10jenkins-bot: ApiBase: Pass empty string, not null, for $conds to ->select [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479219 (https://phabricator.wikimedia.org/T211769) (owner: 10Ladsgroup) [15:18:31] (03PS1) 10Urbanecm: Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) [15:19:06] (03CR) 10jerkins-bot: [V: 04-1] Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) (owner: 10Urbanecm) [15:20:30] (03PS4) 10LukBukkit: Link log entries to Special:Log on ApiFeedWatchlist [core] - 10https://gerrit.wikimedia.org/r/479132 (https://phabricator.wikimedia.org/T210920) [15:20:32] 10WMCZ-Tracker: Update export logic to support new MediaInfos - https://phabricator.wikimedia.org/T211582 (10Urbanecm) 05Open>03Invalid Wait...we don't support MediaInfos yet! [15:20:59] Urbanecm: no, 9--21 and 38--47 [15:21:08] let me check [15:21:24] that blames back to me [15:21:28] :P [15:21:53] well [15:21:59] plus gruntfile * 2 :P [15:22:02] config file after https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479188/4/.eslintrc.json [15:22:13] that doesn't do anything for static/toggleAllNotifs.js, does it? [15:22:30] (03PS21) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [15:22:35] ik. [15:22:36] (03CR) 10jerkins-bot: [V: 04-1] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [15:22:47] what i'm also pointing out is lines 9--21 and 38--47 [15:22:51] and gruntfile * 2 [15:22:55] (03PS2) 10Urbanecm: Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) [15:23:10] (03CR) 10jerkins-bot: [V: 04-1] Update import logic to allow importing new MediaInfos [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479225 (https://phabricator.wikimedia.org/T211581) (owner: 10Urbanecm) [15:23:21] gruntfile * 2 == fatal error, gruntfile is NaN [15:24:01] :D [15:24:02] oh that double override! [15:24:03] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:24:05] didn't see it [15:24:10] oh, you weren't joking [15:24:20] no, I don't understand what you meant by gruntfile * 2 [15:24:35] so it was jokish version of i don't understand :D [15:24:35] double override [15:24:42] yeah, I just spotted that [15:24:46] s/dont/didnt/g [15:25:05] in your first message mainly :) [15:25:21] :) [15:25:47] anyway, let's merge the overrides and delete the empty one (17-19), right? [15:26:07] (03PS5) 10Shreyasminocha: Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [15:26:08] done [15:26:15] thx [15:26:16] looking [15:26:20] (03CR) 10Aklapper: [C: 04-1] "Please cover in your commit message *why* you revert the previous change." [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478393 (owner: 10Gerrituser) [15:27:13] lgtm now [15:27:19] let's wait on jenkins [15:27:20] nice [15:27:29] yes [15:27:36] (03CR) 10Urbanecm: [C: 032] Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [15:27:42] looks good to jenkins too [15:27:44] +2'ed [15:27:58] takidelfin, Nathan_fraignt ^ [15:28:00] nice [15:28:37] (03PS12) 10Urbanecm: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [15:28:44] (03Merged) 10jenkins-bot: Update eslint to ES8 to support async/await [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479188 (https://phabricator.wikimedia.org/T211758) (owner: 10Nathan fraignt) [15:28:44] ^^ rebased ^^ [15:28:52] 👌 [15:29:17] what to do with taki's comment in https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479185/10/static/ticketform/form.js#17? [15:29:38] discussed this with nathan here [15:29:43] aand ? [15:29:55] takidelfin's still watching IRC! [15:29:59] we think sticking to the convention in the rest of the codebase is better (which iirc is commas) [15:30:05] yeah, i was taken aback [15:30:05] * takidelfin hides [15:30:14] sorry, I couldn't resist :D [15:30:17] :D [15:30:24] even i get irc fomo [15:30:28] sucks [15:30:30] ok, so I guess we can +2 too, right [15:30:51] wait, i should test it before :D [15:31:01] yes, /me did no testing locally [15:31:27] ough, I can't :( [15:31:33] now I'm going study for real [15:31:35] :D [15:31:39] k [15:31:42] * shreyasminocha is switching to passive mode [15:31:48] 10MediaWiki-Database, 10Release, 10Train Deployments: Full table scans on oldimage table - https://phabricator.wikimedia.org/T211774 (10Marostegui) [15:32:45] (03CR) 10Urbanecm: [C: 032] Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [15:32:58] appears to be working, +2'ed too [15:33:00] thanks everyone [15:33:54] (03Merged) 10jenkins-bot: Change: Edit/Create ticket view now uses REST API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479185 (https://phabricator.wikimedia.org/T211521) (owner: 10Nathan fraignt) [15:34:44] similar thing is https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/views.py#L57-L79 (and correspondent management command) - a special API matching DataTables requirements. Didn't look to possibilites how to convert this to our API too, noting here for cases somebody wants to :) [15:34:48] 10MediaWiki-Database, 10Core Platform Team Kanban (Waiting for Review), 10Release, 10Train Deployments: Full table scans on oldimage table - https://phabricator.wikimedia.org/T211774 (10Anomie) a:03Anomie [15:34:53] 10MediaWiki-Database, 10Core Platform Team Kanban (Waiting for Review), 10Release, 10Train Deployments: Full table scans on oldimage table - https://phabricator.wikimedia.org/T211774 (10zeljkofilipin) p:05Normal>03Unbreak! Train blockers are UBN. [15:34:55] (03PS1) 10Anomie: ImageListPager: Don't query by oi_user [core] - 10https://gerrit.wikimedia.org/r/479227 (https://phabricator.wikimedia.org/T211774) [15:36:06] 10WMCZ-Tracker, 10Patch-For-Review: Use REST API instead of non-standard pseudo-API - https://phabricator.wikimedia.org/T211521 (10Urbanecm) 05Open>03Resolved [15:37:01] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:37:14] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:37:29] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10Patch-For-Review, 10Release-Engineering-Team (Kanban): Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $conds mu... - https://phabricator.wikimedia.org/T211769 [15:37:30] gtg now, bye all! [15:37:41] Bye! [15:38:25] (03CR) 10Dbrant: [C: 04-1] "This breaks the toolbar title when looking at other tabs in MainActivity (reading lists, history, nearby). See other minor comments inlin" (035 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475970 (https://phabricator.wikimedia.org/T209499) (owner: 10Sharvaniharan) [15:40:12] Siyam, any progress on your task? [15:42:07] Yes siyam [15:47:24] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Anomie) I... [15:50:10] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Scribunto, 10Editing-team, 10Core Platform Team Kanban (Waiting for Review), and 2 others: Exception from line 1539 of ResourceLoader.php: JSON serialization of config data failed. This usually means the config... - https://phabricator.wikimedia.org/T208689 [15:50:28] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @chiborg - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:50:47] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Talk, watchstar, download, and language buttons should not appear on missing page - https://phabricator.wikimedia.org/T211775 (10Niedzielski) [15:50:59] (03CR) 10Ladsgroup: [C: 032] ImageListPager: Don't query by oi_user [core] - 10https://gerrit.wikimedia.org/r/479227 (https://phabricator.wikimedia.org/T211774) (owner: 10Anomie) [15:51:15] (03PS1) 10Ladsgroup: ImageListPager: Don't query by oi_user [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479229 (https://phabricator.wikimedia.org/T211774) [15:53:34] (03CR) 10LukBukkit: Reloads the categories overlay after a category was added (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) (owner: 10LukBukkit) [15:55:04] (03CR) 10Anomie: "You should see if the maintainer of this extension will review it." [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/477701 (https://phabricator.wikimedia.org/T211037) (owner: 10Paladox) [15:55:45] 10MediaWiki-User-preferences, 10Page-Previews, 10Readers-Web-Backlog, 10User-TheDJ: Preference for page-previews default incorrect when resetting preferences - https://phabricator.wikimedia.org/T211305 (10TheDJ) [15:55:47] (03PS1) 10DCausse: Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) [15:55:52] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10User-TheDJ: Toolbar/charinsert don't handle CodeMirror's multiple selections/cursors - https://phabricator.wikimedia.org/T211205 (10TheDJ) [15:55:55] 10Wikidata-Termbox-Hike: Termbox toggle state for logged-in users - https://phabricator.wikimedia.org/T211771 (10WMDE-leszek) [15:57:13] 10Page-Previews, 10Readers-Web-Backlog: Hovering over a redlink should prompt the user to create the page - https://phabricator.wikimedia.org/T211778 (10Niedzielski) [15:57:28] 10MediaWiki-extensions-Page_Forms, 10WikiEditor, 10User-TheDJ: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page - https://phabricator.wikimedia.org/T103772 (10TheDJ) [15:57:46] 10Wikidata-Termbox-Hike: Termbox toggle state for logged-in users - https://phabricator.wikimedia.org/T211771 (10WMDE-leszek) [15:57:48] 10MediaWiki-Page-editing, 10CharInsert, 10Editing-team, 10User-TheDJ: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10TheDJ) [15:59:34] (03CR) 10jerkins-bot: [V: 04-1] Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) (owner: 10DCausse) [16:00:02] 10WMCZ-Tracker: Add column "Real Expenditures" everywhere - https://phabricator.wikimedia.org/T211779 (10Vojtech.dostal) [16:00:04] (03CR) 10Ladsgroup: [C: 032] ImageListPager: Don't query by oi_user [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479229 (https://phabricator.wikimedia.org/T211774) (owner: 10Ladsgroup) [16:00:11] 10Wikidata-Termbox-Hike: Termbox toggle state for logged-in users - https://phabricator.wikimedia.org/T211771 (10WMDE-leszek) [16:01:39] 10Wikidata-Termbox-Hike: Termbox toggle state for logged-in users - https://phabricator.wikimedia.org/T211771 (10WMDE-leszek) [16:02:59] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 3 others: Lock wait timeout exceeded in SqlIdGenerator::generateNewId - https://phabricator.wikimedia.org/T194299 (10Lucas_Werkmeister_WMDE) And then also leave it enabled on all three... [16:03:07] 10WMCZ-Tracker: Search field everywhere - https://phabricator.wikimedia.org/T211781 (10Vojtech.dostal) [16:04:29] (03Merged) 10jenkins-bot: ImageListPager: Don't query by oi_user [core] - 10https://gerrit.wikimedia.org/r/479227 (https://phabricator.wikimedia.org/T211774) (owner: 10Anomie) [16:05:18] (03PS1) 10Sbisson: [WIP] Help Panel: Search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/479236 (https://phabricator.wikimedia.org/T209301) [16:05:32] 10WMCZ-Tracker: Enable anyone to add receipts - https://phabricator.wikimedia.org/T211782 (10Vojtech.dostal) [16:06:45] duesen: you need the submodules? [16:06:59] (03CR) 10jenkins-bot: ImageListPager: Don't query by oi_user [core] - 10https://gerrit.wikimedia.org/r/479227 (https://phabricator.wikimedia.org/T211774) (owner: 10Anomie) [16:07:11] (03CR) 10Anomie: [C: 032] Link log entries to Special:Log on ApiFeedWatchlist [core] - 10https://gerrit.wikimedia.org/r/479132 (https://phabricator.wikimedia.org/T210920) (owner: 10LukBukkit) [16:07:13] (03CR) 10Dbrant: [C: 04-1] "Looking good so far. Some quick minor things inline." (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) (owner: 10Cooltey) [16:09:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Help Panel: Search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/479236 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [16:10:34] addshore: yea, pointed me to that. [16:10:38] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2018): Include gerrit DB's "author_bot" field also in the gerrit_demo DB - https://phabricator.wikimedia.org/T184907 (10Aklapper) 05Open>03Resolved T151161 has been worked on by Bitergia and this task works as expected: The new `Community > Demographics`... [16:10:48] Since when does Wikibase use submodules for libraries?? [16:10:52] 10WMCZ-Tracker: Enable everyone to add Statutory declaration in multi-driver tickets? - https://phabricator.wikimedia.org/T211783 (10Vojtech.dostal) [16:10:58] ...and why? [16:11:10] duesen, I think since the beginning [16:11:28] But the reasoning, don't know [16:11:37] Ebe123: I made the first commit, so I can tell with certainty that this is not the case :) [16:11:49] lol [16:12:03] I'm really talking without expertise [16:12:35] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona)... [16:12:43] I have not been following development for a couple of years now, so I'm a bit out of the loop :P [16:13:13] 10WMCZ-Tracker: Search field everywhere - https://phabricator.wikimedia.org/T211781 (10Vojtech.dostal) [16:13:15] yes, I was :D https://usercontent.irccloud-cdn.com/file/8uS7Yv7u/screenshot_20181212_171251.png [16:13:40] 10WMCZ-Tracker: Search field everywhere - https://phabricator.wikimedia.org/T211781 (10Vojtech.dostal) [16:14:21] (03Merged) 10jenkins-bot: ImageListPager: Don't query by oi_user [core] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479229 (https://phabricator.wikimedia.org/T211774) (owner: 10Ladsgroup) [16:15:40] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unused /* global console */ [core] - 10https://gerrit.wikimedia.org/r/479214 (owner: 10Esanders) [16:17:23] (03PS1) 10Tchanders: Make base class for multiselect widgets [core] - 10https://gerrit.wikimedia.org/r/479237 [16:17:33] (03CR) 10Jdlrobson: Reloads the categories overlay after a category was added (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) (owner: 10LukBukkit) [16:17:39] (03PS8) 10Niedzielski: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [16:20:40] (03Merged) 10jenkins-bot: Link log entries to Special:Log on ApiFeedWatchlist [core] - 10https://gerrit.wikimedia.org/r/479132 (https://phabricator.wikimedia.org/T210920) (owner: 10LukBukkit) [16:21:02] (03CR) 10Jdlrobson: Reloads the categories overlay after a category was added (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) (owner: 10LukBukkit) [16:23:22] (03CR) 10jenkins-bot: Link log entries to Special:Log on ApiFeedWatchlist [core] - 10https://gerrit.wikimedia.org/r/479132 (https://phabricator.wikimedia.org/T210920) (owner: 10LukBukkit) [16:23:30] 10Wikidata-Termbox-Iteration-6: Unbreak CI: `diff-index --quiet HEAD dist/` is red on travis - https://phabricator.wikimedia.org/T211764 (10Pablo-WMDE) a:05Pablo-WMDE>03Jakob_WMDE [16:31:02] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [16:31:47] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (New Features): Allow SlotRoleHandlers to control page layout - https://phabricator.wikimedia.org/T200915 (10daniel) [16:32:36] (03Merged) 10jenkins-bot: Remove unused /* global console */ [core] - 10https://gerrit.wikimedia.org/r/479214 (owner: 10Esanders) [16:33:33] (03CR) 10VolkerE: [C: 031] Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 (owner: 10Esanders) [16:33:47] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Catalogue where the MobileFrontend loading overlay is used - https://phabricator.wikimedia.org/T209708 (10Esanders) I suspect there may be a distinction between processes we expect to complete quickly (e.g. <500ms) and long processes like loading VE,... [16:35:05] 10WMCZ-Tracker: Enable everyone to add Statutory declaration in multi-driver tickets? - https://phabricator.wikimedia.org/T211783 (10Urbanecm) We can simply add a "add statutory declaration" button to each ticket, available to everyone. It'll show you statutory declaration's text and allow you to sign it digital... [16:35:11] (03CR) 10jenkins-bot: Remove unused /* global console */ [core] - 10https://gerrit.wikimedia.org/r/479214 (owner: 10Esanders) [16:35:58] (03CR) 10Yaron Koren: "Great! This patch is going to be a great addition. I'm sorry that I keep finding new things - I should have looked at the code more carefu" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 (owner: 10Nikhil-nk) [16:37:59] 10WMCZ-Tracker: Search field everywhere - https://phabricator.wikimedia.org/T211781 (10Urbanecm) I'm not sure if I get what you mean. Search field is near every table and works across all fields, see my screenshots below. {F27519873} {F27519872} As you wrote "Klára wants a search field on every //page// in t... [16:38:52] (03PS6) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [16:39:03] 10MediaWiki-extensions-DeletePagesForGood: Exception caught when deleting a page - https://phabricator.wikimedia.org/T201486 (10PlavorSeol) At that time, I was using one of MediaWiki 1.32.0 WMF build, and I'm currently using 1.33.0-wmf.8. I use SQLite database. But would you like to give me some time to test new... [16:42:42] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Catalogue where the MobileFrontend loading overlay is used - https://phabricator.wikimedia.org/T209708 (10Jdlrobson) > I suspect there may be a distinction between processes we expect to complete quickly (e.g. <500ms) and long processes like loading V... [16:43:45] 10Page-Previews, 10Readers-Web-Backlog (Design): Hovering over a redlink should prompt the user to create the page - https://phabricator.wikimedia.org/T211778 (10Jdlrobson) p:05Normal>03Low I like this idea, but @ovasileva guessing this is low priority while we focus on other things? [16:44:58] refeed[m], fyi, you have last 15 mins for submitting your task. [16:46:26] 10MobileFrontend, 10Readers-Web-Backlog (Design): [Bug] Talk, watchstar, download, and language buttons should not appear on missing page - https://phabricator.wikimedia.org/T211775 (10Jdlrobson) Note, some pages that don't exist will have talk pages in the case of deletion and there's nothing stopping someone... [16:47:18] 10CX-deployments, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10KartikMistry) @marcmiquel Hi, are you running the query again by any chance? Please let us know. Thanks! [16:47:33] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Remove CtaDrawer events and pass events for red link CtaDrawer via options - https://phabricator.wikimedia.org/T210870 (10Jdlrobson) [16:48:17] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 8hrs][Bug] Skin.test.js should call jQuery.tearDown() - https://phabricator.wikimedia.org/T210517 (10Jdlrobson) [16:48:29] 10WMCZ-Tracker: Add column "Real Expenditures" everywhere - https://phabricator.wikimedia.org/T211779 (10Urbanecm) Should be quite easy - move to "Ready (approved by PM)" once this is ready from your side. [16:49:32] (03PS6) 10LukBukkit: Reloads the categories overlay after a category was added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) [16:51:09] (03PS2) 10Sbisson: [WIP] Help Panel: Search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/479236 (https://phabricator.wikimedia.org/T209301) [16:52:35] (03CR) 10Jforrester: [C: 04-1] Replace $.type with typeof (031 comment) [core] - 10https://gerrit.wikimedia.org/r/479199 (owner: 10Esanders) [16:54:33] (03PS1) 10Pmiazga: Reset default mobilefrontend provider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479246 (https://phabricator.wikimedia.org/T210390) [16:54:53] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Help Panel: Search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/479236 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [16:55:25] (03CR) 10Jdlrobson: Add PHPUnit tests for methods in McsContentProvider::class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [16:55:36] (03PS7) 10LukBukkit: Reloads the categories overlay after a category was added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) [16:55:44] (03PS1) 10DLynch: schemaEditAttemptStep: avoid logging invalid null timings when switching editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479247 (https://phabricator.wikimedia.org/T211156) [16:56:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Help Panel: Search [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/479236 (https://phabricator.wikimedia.org/T209301) (owner: 10Sbisson) [16:57:54] 10MediaWiki-Releasing, 10Release-Engineering-Team (Kanban): Document the process for tagging, signing and preparing a tarball release. - https://phabricator.wikimedia.org/T211655 (10thcipriani) Maybe this info could be made a subpage of https://www.mediawiki.org/wiki/Release_checklist and linked from that open... [16:57:56] 10WMCZ-Tracker: Enable anyone to add receipts - https://phabricator.wikimedia.org/T211782 (10Urbanecm) It's doable easily. Maybe we can just display uploader's username next to the document and not bother with splitting it into separate sections, but if you want to, it's easy too. [16:58:00] 10CX-deployments, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10marcmiquel) Nope. I haven't for days. Since your last email. [16:58:05] (03PS2) 10Esanders: Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 [16:58:07] (03PS2) 10Esanders: mw.Title: Rename vars and imporve docs around newFromUserInput double signature [core] - 10https://gerrit.wikimedia.org/r/479200 [16:58:52] (03CR) 10Pmiazga: [C: 032] "done in Ic156f9a054b3d7151c6bd39bc0f6ebad7806153b" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [16:59:03] (03CR) 10Cooltey: [C: 032] Hygiene: fix some punctuation in Credits strings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/479021 (https://phabricator.wikimedia.org/T211656) (owner: 10Dbrant) [16:59:44] (03CR) 10Dbrant: "A few preliminary thoughts." (034 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) (owner: 10Sharvaniharan) [17:01:18] 10Wikimedia-Site-requests: be.wikisource logo issues - https://phabricator.wikimedia.org/T211795 (10MarcoAurelio) [17:04:36] Congrats to the GCI students! [17:04:48] end of GCI! :( [17:05:07] `Contest is over, no more work can be submitted` [17:05:14] it is sad... [17:05:23] that was a great time :D [17:05:31] 10WMCZ-Tracker: Enable anyone to add receipts - https://phabricator.wikimedia.org/T211782 (10Vojtech.dostal) OK! Lets do it your way, with usernames. One thing to be careful about: People should not be able to see other people receipts except for those with a user right (same as now). [17:05:51] well done everyone [17:06:02] RexxS: o/ [17:06:51] 10WMCZ-Tracker: Enable everyone to add Statutory declaration in multi-driver tickets? - https://phabricator.wikimedia.org/T211783 (10Vojtech.dostal) OK, good idea! [17:07:10] congratulations to mentors too :D Handling our stupidity, that had to be difficult [17:08:03] 10WMCZ-Tracker: Enable anyone to add receipts - https://phabricator.wikimedia.org/T211782 (10Urbanecm) Ok, will do soon. Thanks for your note on visibility of the receipts. Should requestors be able to see all receipts of their tickets? [17:08:04] nah, it was a pleasure, as always [17:08:27] 233 tasks mentored [17:09:28] I'll have to find something else to do with my time now [17:09:38] (like sleep or eat) [17:10:39] 10WMCZ-Tracker: Convert `.then` code to `async-await` - https://phabricator.wikimedia.org/T211727 (10takidelfin) [17:11:22] 10MediaWiki-Database, 10Core Platform Team Kanban (Waiting for Review), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Full table scans on oldimage table - https://phabricator.wikimedia.org/T211774 (10Ladsgroup) 05Open>03Resolved [17:12:45] 10WMCZ-Tracker: Implement autocompleted feature for comments mentions - https://phabricator.wikimedia.org/T210565 (10takidelfin) Could I try? It seems to be a good DRF lesson for me :D [17:13:29] (03Merged) 10jenkins-bot: Hygiene: fix some punctuation in Credits strings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/479021 (https://phabricator.wikimedia.org/T211656) (owner: 10Dbrant) [17:14:25] 10WMCZ-Tracker, 10Patch-For-Review: Update Tracker code from ES6 to ES8 - https://phabricator.wikimedia.org/T211758 (10takidelfin) p:05Triage>03Low [17:15:41] (03CR) 10jenkins-bot: Hygiene: fix some punctuation in Credits strings. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/479021 (https://phabricator.wikimedia.org/T211656) (owner: 10Dbrant) [17:21:01] duesen: i remember at tech conf there being some discussion about the hook system in php [17:21:12] but i cant find or remember which session that was in? [17:21:59] 10Reading-Admin: Define cross-schema event stitching approach - https://phabricator.wikimedia.org/T205569 (10Ottomata) If we include the sampling settings in the event data itself, then it will at least be unsurprising during analysis if the sampled events intersection doesn't match up. This is easy if our samp... [17:22:51] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2018): Have "Last Attracted Developers" information for Gerrit automatically updated / Integrate new demography panels in GrimoireLab product - https://phabricator.wikimedia.org/T151161 (10Aklapper) Quoting Bitergia: > We have been working on a new, unified... [17:23:19] (03CR) 10Esanders: [C: 032] schemaEditAttemptStep: avoid logging invalid null timings when switching editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479247 (https://phabricator.wikimedia.org/T211156) (owner: 10DLynch) [17:26:18] 10MediaWiki-Uploading, 10Commons, 10Multimedia: Automatically convert .heic image format files to .jpg or .webp - https://phabricator.wikimedia.org/T211745 (10AlexisJazz) @Aklapper okay, sorry, I didn't know how to tag this as a feature request. Can the mobile app convert it? (I guess that would only help fo... [17:26:25] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:30:14] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:30:46] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:32:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make RDF prefixes configurable - https://phabricator.wikimedia.org/T211799 (10daniel) [17:32:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make RDF prefixes configurable - https://phabricator.wikimedia.org/T211799 (10daniel) [17:33:15] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make RDF prefixes configurable - https://phabricator.wikimedia.org/T211799 (10daniel) ping @LucasWerkmeister @Lydia_Pintscher [17:36:16] (03Merged) 10jenkins-bot: schemaEditAttemptStep: avoid logging invalid null timings when switching editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479247 (https://phabricator.wikimedia.org/T211156) (owner: 10DLynch) [17:36:45] (03CR) 10Jforrester: [C: 032] Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 (owner: 10Esanders) [17:38:07] (03PS3) 10Jforrester: mw.Title.newFromUserInput: Rename vars, improve docs for double signature [core] - 10https://gerrit.wikimedia.org/r/479200 (owner: 10Esanders) [17:38:16] (03CR) 10Jforrester: [C: 032] mw.Title.newFromUserInput: Rename vars, improve docs for double signature [core] - 10https://gerrit.wikimedia.org/r/479200 (owner: 10Esanders) [17:38:21] 10MediaWiki-API, 10MediaWiki-General-or-Unknown, 10Core Platform Team Kanban (Waiting for Review), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review: Wikimedia\Rdbms\Database::selectSQLText called from ApiBase::filterIDs with incorrect parameters: $c... - https://phabricator.wikimedia.org/T211769 [17:39:34] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:39:53] (03CR) 10jenkins-bot: schemaEditAttemptStep: avoid logging invalid null timings when switching editors [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479247 (https://phabricator.wikimedia.org/T211156) (owner: 10DLynch) [17:40:33] (03CR) 10Jforrester: [C: 032] Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 (owner: 10Esanders) [17:44:20] 10MediaWiki-extensions-WikibaseRepository, 10Commons, 10SDC General, 10Wikidata: Resolve ambiguity of entity ID prefixes used on Commons. - https://phabricator.wikimedia.org/T211800 (10daniel) [17:44:51] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:44:53] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:45:23] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering: Find out how to deploy MediaInfo without breaking Commons - https://phabricator.wikimedia.org/T211801 (10daniel) [17:46:54] 10Growth-Team, 10StructuredDiscussions: [{exception_id}] {exception_url} Flow\Exception\FlowException from line 397 of /srv/mediawiki/php-1.33.0-wmf.8/extensions/Flow/includes/Block/TopicListBlock.php: The `newest` sort order does not allow the `offset` parameter. Plea... - https://phabricator.wikimedia.org/T211798 [17:49:30] 10Product-Analytics: Android navigation refresh - understand impact on user engagement metrics - https://phabricator.wikimedia.org/T211366 (10mpopov) # Plan of action All of these metrics will be calculated across all languages. 1. DAU: we have this (already in App core metrics spreadsheet) and can easily calc... [17:50:42] (03Merged) 10jenkins-bot: Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 (owner: 10Esanders) [17:51:54] 10VisualEditor (Current work): Wayfinding Isolate Section Editing: Determine Metrics Needs - https://phabricator.wikimedia.org/T209983 (10JTannerWMF) [17:53:14] (03CR) 10jenkins-bot: Replace $.type with typeof [core] - 10https://gerrit.wikimedia.org/r/479199 (owner: 10Esanders) [17:53:42] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Waiting for Review), 10PHP 7.0 support, 10Patch-For-Review, 10Performance-Team (Radar): Port mediawiki/php/wmerrors to PHP7 and deploy - https://phabricator.wikimedia.org/T187147 (10BPirkle) I checked a variety of fatal errors on both produ... [17:53:53] (03CR) 10D3r1ck01: [C: 032] "Per @Jdlrobson's comment here: Ie224b89787b631bd597273." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479246 (https://phabricator.wikimedia.org/T210390) (owner: 10Pmiazga) [17:55:33] 10MediaWiki-extensions-WikibaseRepository, 10Commons, 10SDC General, 10Wikidata: Resolve ambiguity of entity ID prefixes used on Commons. - https://phabricator.wikimedia.org/T211800 (10daniel) [17:55:38] (03Merged) 10jenkins-bot: mw.Title.newFromUserInput: Rename vars, improve docs for double signature [core] - 10https://gerrit.wikimedia.org/r/479200 (owner: 10Esanders) [17:55:40] (03Merged) 10jenkins-bot: Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 (owner: 10Esanders) [17:55:42] (03CR) 10Nikhil-nk: "I was forcing the “End Date” result with “Start Date” result in order to display it properly in timeline or calendar format on drilldown p" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 (owner: 10Nikhil-nk) [17:57:49] (03CR) 10jenkins-bot: Convert SimpleCaptcha to OOUI [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478235 (owner: 10Esanders) [17:58:08] (03CR) 10jenkins-bot: mw.Title.newFromUserInput: Rename vars, improve docs for double signature [core] - 10https://gerrit.wikimedia.org/r/479200 (owner: 10Esanders) [17:58:18] 10VisualEditor (Current work): Deploy section editing patches to prototype server - https://phabricator.wikimedia.org/T210661 (10JTannerWMF) [17:58:25] 10VisualEditor (Current work): Determine Business Requirements and Acceptance Criteria - https://phabricator.wikimedia.org/T209985 (10JTannerWMF) [17:59:35] lol [17:59:37] sorry [18:00:14] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering: Find out how to deploy MediaInfo without breaking Commons - https://phabricator.wikimedia.org/T211801 (10daniel) [18:00:20] I'll be inactive for like two days probably. I got sick ;( [18:01:00] 10Growth-Team: Help panel on ContentTranslation pages overlaps " - https://phabricator.wikimedia.org/T211803 (10Etonkovidova) [18:01:05] hello [18:01:09] takidelfin: rip [18:01:36] takidelfin: get well soon <3 [18:01:46] takidelfin: get well [18:02:28] 10Growth-Team: Help panel on ContentTranslation pages overlaps "Provide feedback" link - https://phabricator.wikimedia.org/T211803 (10Etonkovidova) [18:04:03] 10MediaWiki-Releasing, 10MW-1.32-notes, 10MW-1.32-release, 10Release-Engineering-Team (Kanban), 10User-MacFan4000: Release MW 1.32 RC1 - https://phabricator.wikimedia.org/T211653 (10mmodell) @legoktm, @arielglenn, Thank you! [18:05:47] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Patch-For-Review: In Wikidata Query GUI, make the placeholder update the language dynamically - https://phabricator.wikimedia.org/T207059 (10Shreyasminocha) 05Open>03Resolved Was fixed during GCI. [18:06:16] 10Google-Code-in-2018, 10MinervaNeue, 10Readers-Web-Backlog, 10Need-volunteer: PHPUnit test case warning about Special:Notifications missing aliases in SkinMinervaTest - https://phabricator.wikimedia.org/T202308 (10Shreyasminocha) Had abandoned on GCI. Sorry :( [18:07:11] (03Merged) 10jenkins-bot: Reset default mobilefrontend provider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479246 (https://phabricator.wikimedia.org/T210390) (owner: 10Pmiazga) [18:09:13] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode - https://phabricator.wikimedia.org/T211490 (10JTannerWMF) [18:10:15] * TheJair waves [18:10:34] * shreyasminocha waves back [18:10:35] (03CR) 10jenkins-bot: Reset default mobilefrontend provider [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479246 (https://phabricator.wikimedia.org/T210390) (owner: 10Pmiazga) [18:11:28] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Remove CtaDrawer events and pass events for red link CtaDrawer via options - https://phabricator.wikimedia.org/T210870 (10Jdlrobson) > I can conceive of a situation where you'd define a view with some default click event handler but an extending cla... [18:12:53] Hey RexxS, I made Lua task 9 but had no time to claim the task, would you mind having a look at it though? [18:13:17] TheJair: nice [18:13:22] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Split pageIssues.js into smaller functions - https://phabricator.wikimedia.org/T211257 (10Jdlrobson) [18:13:23] Of course - give me the links [18:13:25] 10Page-Issue-Warnings, 10Readers-Web-Backlog: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10Jdlrobson) [18:13:27] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: [EPIC] Post A-B test technical debt cleanup - https://phabricator.wikimedia.org/T201634 (10Jdlrobson) [18:13:32] i did #9 in the run up to the claim deadline [18:13:35] And takidelfin|sick get well soon! [18:13:37] btw hi RexxS [18:13:49] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: [EPIC] Post A-B test technical debt cleanup - https://phabricator.wikimedia.org/T201634 (10Jdlrobson) [18:14:04] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: [EPIC] Post A-B test technical debt cleanup - https://phabricator.wikimedia.org/T201634 (10Jdlrobson) [18:14:39] I think it's alright if I paste them here right? [18:15:12] https://en.wikipedia.org/wiki/Module:Sandbox/Stibba0/Wikidata and https://en.wikipedia.org/wiki/User:Stibba0/Sandbox/Wikidata [18:16:05] 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: View: Make isBorderBox and className passable options to the View cl... - https://phabricator.wikimedia.org/T209007 [18:16:17] I had no idea really how to make a wikitable using lua lol [18:17:19] i think the method is supposed to return just the x values for the property rather than an entire table [18:17:36] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) a:05ABorbaWMF>03Jdlrobson... [18:18:11] "To demonstrate that your function works, you will create a table similar to this: " [18:18:28] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10kostajh) [18:18:29] "In case there are multiple values, you'll need to step through the values of statementstbl[1], statementstbl[2], etc. Use for k, v in pairs(statementstbl), and v.mainsnak.datavalue.value.id. For each value found in the loop, store it as the next value in a table that you have declared to store the output of the function. At the end of your function, you will return the table converted to a [18:18:36] single string with separators that produce new lines in html." [18:18:39] 10Audiences-QA, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, and 2 others: [Research 4hrs] [Bug] Page issues link overlapping in multiple languages for larger screens - https://phabricator.wikimedia.org/T206887 (10Jdlrobson) This is not on production (Russian) yet... [18:18:53] table in the sandbox calling the method for each property i believe [18:19:20] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10kostajh) In our group chat, we settled on `Help panel question on X (2018-12-12 16:34)` and `Help panel quest... [18:19:24] hmm [18:20:09] but as long as you get the learning objectives, it doesn't matter [18:20:12] (any more) [18:21:33] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Make RDF prefixes configurable - https://phabricator.wikimedia.org/T211799 (10Lucas_Werkmeister_WMDE) A list of prefixes is available in the [RDF dump format documentation](https://www.mediawiki.org/wiki/Wikibase/Indexing/RDF_Dump_Format#Prefixes_used) – a... [18:22:38] okay yes I see you're right shreyasminocha [18:23:06] didn't realise that at all, but I don't think I would have to change a lot to fix it [18:23:12] yeah [18:23:25] you already have `getInformation` or whatever it was in place [18:23:41] (03PS1) 10Anomie: ApiPageSet::initFromPageIds: Default $filterIds to true [core] - 10https://gerrit.wikimedia.org/r/479257 (https://phabricator.wikimedia.org/T211804) [18:23:48] it's more removing code lol [18:23:57] most satisfying thing [18:25:07] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Remove CtaDrawer events and pass events for red link CtaDrawer via options - https://phabricator.wikimedia.org/T210870 (10Jdlrobson) [18:25:14] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 8hrs] [Bug] Skin.test.js should call jQuery.tearDown() - https://phabricator.wikimedia.org/T210517 (10MBinder_WMF) [18:26:59] 10WMCZ-Tracker: Force unix line endings by a linter - https://phabricator.wikimedia.org/T211601 (10Urbanecm) p:05Triage>03Low [18:28:21] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.0 support: Confirm that post-send functions work fine with mediawiki under PHP 7 - https://phabricator.wikimedia.org/T209981 (10Krinkle) @tstarling Yeah, the main thing I was thinking about with corruption is things we put outsi... [18:29:25] There is an html library in Scribunto - https://www.mediawiki.org/wiki/Extension:Scribunto/Lua_reference_manual#HTML_library - but I didn't intend you to write the table in Lua [18:30:05] (03CR) 10VolkerE: "@Zoranzoki21 Do you have time to transfer this to OOUI repo? Do you need extra help?" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [18:30:14] your code is fine at first glance [18:30:31] don't worry about removing anything [18:30:36] 10MinervaNeue, 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Transition Gruntfile.js tasks to NPM scripts (Popups, MinervaNeue) - https://phabricator.wikimedia.org/T206462 (10Jdlrobson) 05Open>03stalled Stalled on T206069 [18:30:49] 10Readers-Web-Backlog, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt: Transition MobileFrontend Gruntfile.js tasks to NPM scripts - https://phabricator.wikimedia.org/T206069 (10Jdlrobson) [18:31:57] if you want to test just the getInformation function, you can create a p.getInformation function as well [18:32:33] p.getInformation = function(frame) [18:32:53] yes I know :p [18:33:39] 10WMCZ-Tracker: Force unix line endings by a linter - https://phabricator.wikimedia.org/T211601 (10Shreyasminocha) Consider looking into [[ https://editorconfig.org | EditorConfig ]] as I mentioned on IRC. [18:33:45] return getInformation(frame.args.entityID, frame.args.propertyID, frame.args.link) [18:33:49] 10OOUI, 10Patch-For-Review, 10Performance: Replace jQuery functions with native equivalents - https://phabricator.wikimedia.org/T207418 (10Volker_E) [18:34:19] 10OOUI, 10Patch-For-Review, 10Performance: Replace jQuery functions with native equivalents - https://phabricator.wikimedia.org/T207418 (10Volker_E) This seems connected to https://github.com/wikimedia/eslint-config-wikimedia/issues/123 [18:34:23] then you just supply entityID, propertyID and link in the #invoke [18:35:01] I would probably remove the link part then and handle it in the code [18:35:02] ok - now the code: [18:35:30] because link was simply to check if it could be a link or not [18:35:34] 1. if you have for idx, v in pairs(infoTable) [18:35:43] then v cannot be nil [18:36:03] any table entry set to nil is removed from the table [18:36:58] oh lol [18:37:01] (03CR) 10Jdrewniak: Port toggle.js to webpack (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479137 (https://phabricator.wikimedia.org/T210208) (owner: 10Jdrewniak) [18:37:44] 2. Any value that isn't nil or false is true [18:37:47] (03PS2) 10Anomie: ApiPageSet::initFromPageIds: Default $filterIds to true [core] - 10https://gerrit.wikimedia.org/r/479257 (https://phabricator.wikimedia.org/T211804) [18:37:58] so [18:38:08] (03PS2) 10DCausse: Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) [18:38:15] local id = v.mainsnak.datavalue.value.id [18:38:34] if id and link then ... [18:39:49] What does getSiteLink return if there is no site link? [18:39:57] (03CR) 10Anomie: API: Filter lists of IDs before sending them to the database (031 comment) [core] - 10https://gerrit.wikimedia.org/r/299018 (https://phabricator.wikimedia.org/T140302) (owner: 10Anomie) [18:39:59] nil [18:40:19] RexxS: i was wondering: what does "snak" stand for / mean? [18:40:29] calls are more resource intensive than variable access, so if you're going to call mw.wikibase.getSitelink more than once, assign it to a local variable and use that instead [18:40:31] (03CR) 10Jforrester: [C: 032] Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478397 (owner: 10MarcoAurelio) [18:40:33] (03CR) 10Jforrester: [C: 032] Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_31) - 10https://gerrit.wikimedia.org/r/478399 (owner: 10MarcoAurelio) [18:40:35] (03CR) 10Jforrester: [C: 032] Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_32) - 10https://gerrit.wikimedia.org/r/478436 (owner: 10MarcoAurelio) [18:40:47] shreyasminocha, I wish i knew :P [18:40:56] :D [18:41:00] it's a chunk [18:41:17] a lump of an object [18:41:20] 10Google-Code-in-2018, 10Page-Previews, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review, and 2 others: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10phuedx) @nray: As discussed, [[ https://docs.google.com/document/d/1FZKpmCD7HapzFFsnKX1eJJBccRbfZM... [18:41:50] so maybe it's like "part of a meal (snack)" [18:42:04] (03CR) 10jerkins-bot: [V: 04-1] Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) (owner: 10DCausse) [18:42:08] main snack [18:42:46] yes - that's the principal chunk of the object [18:43:14] Anyhow, thanks for all the lua tasks RexxS! [18:43:19] (03Merged) 10jenkins-bot: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478397 (owner: 10MarcoAurelio) [18:43:25] I wrote a template/function to examine Wikidata [18:43:51] like this {{examine|P26|Q42}} [18:44:01] (03Merged) 10jenkins-bot: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_31) - 10https://gerrit.wikimedia.org/r/478399 (owner: 10MarcoAurelio) [18:44:22] (03PS3) 10DCausse: Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) [18:44:29] that shows the structure for P26 in Q42 (the spouse of Douglas Adams) [18:44:30] (03PS1) 10Thiemo Kreuz (WMDE): [WIP] Add reference preview type [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479259 [18:44:49] not finished with you yet, TheJair [18:44:52] lol [18:45:00] hahaha [18:45:16] 10Google-Code-in-2018, 10Page-Previews, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review, and 2 others: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10phuedx) >>! In T197883#4818045, @phuedx wrote: > Unfortunately, both the staging server and the Be... [18:45:19] 3. Lua has great table handing [18:45:19] 10Growth-Team: Help panel on ContentTranslation pages overlaps "Provide feedback" link - https://phabricator.wikimedia.org/T211803 (10kostajh) CS wiki: 4,764 users are trying this feature. KO wiki: 5,673 users are trying this feature. [18:45:45] so it's cheap to store a set of strings in a table [18:45:49] (03Merged) 10jenkins-bot: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_32) - 10https://gerrit.wikimedia.org/r/478436 (owner: 10MarcoAurelio) [18:45:52] like this: [18:45:59] out = {} [18:46:06] 10Reading-Admin: Define cross-schema event stitching approach - https://phabricator.wikimedia.org/T205569 (10Nuria) >we eventually want to support sampling by different values (not just session). Clarifying that at this time eventlogging code supports sampling per "page" and per 'session". Examples provided abov... [18:46:08] inside a loop [18:46:12] you do [18:46:14] 10CheckUser, 10Stewards-and-global-tools, 10Patch-For-Review: Duration of query recent changes in Check user tool - https://phabricator.wikimedia.org/T204347 (10MR70) Hi @Huji , Could you please take a look at the commit ? [18:46:28] out[#out+1] = some-string [18:46:40] when the loop ends you do [18:47:28] strResult = table.concat(out, "
") [18:47:34] (03CR) 10jerkins-bot: [V: 04-1] Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) (owner: 10DCausse) [18:47:47] then you don't need to test for the first loop [18:48:00] ah [18:48:00] 10MediaWiki-General-or-Unknown: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10zeljkofilipin) p:05Triage>03Unbreak! [18:48:11] (03PS3) 10Krinkle: Fixes WinCache keys longer than 150 chars. [core] - 10https://gerrit.wikimedia.org/r/476987 (https://phabricator.wikimedia.org/T210794) (owner: 10Juan Osorio (Microsoft)) [18:48:33] (03PS4) 10Krinkle: objectcache: Fix WinCache keys longer than 150 chars [core] - 10https://gerrit.wikimedia.org/r/476987 (https://phabricator.wikimedia.org/T210794) (owner: 10Juan Osorio (Microsoft)) [18:48:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add reference preview type [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479259 (owner: 10Thiemo Kreuz (WMDE)) [18:48:55] (03CR) 10Krinkle: [C: 031] "Rebased so that it triggers full tests on my behalf, and amended the commit message to conform to https://www.mediawiki.org/wiki/Gerrit/Co" [core] - 10https://gerrit.wikimedia.org/r/476987 (https://phabricator.wikimedia.org/T210794) (owner: 10Juan Osorio (Microsoft)) [18:49:00] it's also easy to change the separator from "
" to ", " or something else [18:49:28] within in the string or table? [18:50:07] I know there is string.gsub [18:50:18] it only appears in the table.concat [18:50:54] so make it a variable and pass it as a parameter with a sensible default [18:51:42] (03PS10) 10Sharvaniharan: Add edit tasks menu option [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475970 (https://phabricator.wikimedia.org/T209499) [18:51:59] (03PS1) 10Ppchelko: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/479260 (https://phabricator.wikimedia.org/T211805) [18:52:12] 4. Finally, your code will return things like "Ed (given name)" if a link is requested [18:52:26] (03PS4) 10DCausse: Augment the list of known clusters using cluster conf [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/479232 (https://phabricator.wikimedia.org/T211752) [18:52:29] you need to construct a piped link [18:52:30] (03CR) 10Thiemo Kreuz (WMDE): [WIP] Add reference preview type (036 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479259 (owner: 10Thiemo Kreuz (WMDE)) [18:52:58] 10MediaWiki-Vendor: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10zeljkofilipin) [18:53:02] (03PS1) 10Daimona Eaytoy: Add missing global to extension.json [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/479261 [18:53:12] (03CR) 10Sharvaniharan: Add edit tasks menu option (037 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475970 (https://phabricator.wikimedia.org/T209499) (owner: 10Sharvaniharan) [18:53:31] like this [18:54:02] [[ sitelink | displaytext ]] [18:54:31] and you can make the text to display by stripping off stuff in ( ) or after a comma [18:54:56] local pos = sitelink:find(":") or 0 [18:55:05] 10Google-Code-in-2018, 10MediaWiki-API, 10MediaWiki-Watchlist, 10Growth-Team, and 2 others: Fix incorrect & fields for RSS feed for watchlist - https://phabricator.wikimedia.org/T210920 (10Bawolff) 05Open>03Resolved a:03LukBukkit [18:55:18] I see, 3 & 4 were in the instructions as well but I didn't really pay attention to them [18:55:22] displaytext = sitelink:sub(pos+1):gsub("%s%(.+%)$", ""):gsub(",.+$", "") [18:56:26] You can now go and nit-pick some of my code if you wish [18:56:41] start at https://en.wikipedia.org/wiki/Module:WikidataIB [18:57:47] haha sure, not right now though, need to get back to studying [18:57:48] (03CR) 10Catrope: Migrate SpecialUndelete and Diff from tag_summary to change_tag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:58:03] have fun! [18:58:17] thanks [18:59:40] (03CR) 10Ladsgroup: Migrate SpecialUndelete and Diff from tag_summary to change_tag (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:59:40] RexxS: out of curiosity, how old're you (if you wish to share, that is). i remember you mention starting with Fortran in the '60s... [19:00:09] (03PS2) 10Ladsgroup: Stop updating tag_summary table [core] - 10https://gerrit.wikimedia.org/r/477610 (https://phabricator.wikimedia.org/T209525) [19:00:21] I'm 66 [19:00:32] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Punctuation mistakes - https://phabricator.wikimedia.org/T211656 (10Dbrant) 05Open>03Resolved a:03Dbrant Hard-coded punctuation is fixed, and the TWN strings will be updated upon the next sync. [19:00:45] nice. how long have you been working with/at wikimedia? [19:00:58] 10Research: Research Showcase December 2018 - https://phabricator.wikimedia.org/T208912 (10JLaytonWMF) [19:01:19] my first edit was in January 2008 [19:01:45] 10 years is pretty long, hmm [19:01:47] nice [19:01:55] I first became a Trustee of WikimediaUK in 2012 [19:02:19] i see [19:03:53] 10MediaWiki-Vendor: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10zeljkofilipin) wmf.6 to wmf.8 changes to vendor: https://www.mediawiki.org/wiki/MediaWiki_1.33/wmf.8#Vendor This one is related to guzzlehttp https://g... [19:06:00] 10ContentTranslation, 10Language-Team (Language-2019-January-March), 10Patch-For-Review: CX2: Missing link label wraps to two lines unnecessarily - https://phabricator.wikimedia.org/T211688 (10Petar.petkovic) a:03Petar.petkovic [19:08:41] (03PS1) 10Jdlrobson: Reset default mobilefrontend provider [extensions/MobileFrontend] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479265 (https://phabricator.wikimedia.org/T210390) [19:11:25] (03PS4) 10Robert Vogel: Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 [19:12:01] (03CR) 10jerkins-bot: [V: 04-1] Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 (owner: 10Robert Vogel) [19:12:42] (03PS5) 10Robert Vogel: Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 [19:13:20] (03PS7) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [19:15:20] (03CR) 10jerkins-bot: [V: 04-1] Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 (owner: 10Robert Vogel) [19:15:28] (03PS6) 10Robert Vogel: Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 [19:15:54] (03PS8) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [19:17:04] (03PS7) 10Robert Vogel: Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 [19:17:42] (03CR) 10Robert Vogel: [C: 032] Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 (owner: 10Robert Vogel) [19:17:58] (03PS4) 10Nikhil-nk: Add StartDate/Datetime and EndDate/Datetime data type [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 [19:18:04] (03PS6) 10Thcipriani: Support "application/json" in Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/468674 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [19:18:59] (03CR) 10Thcipriani: [C: 032] Support "application/json" in Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/468674 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [19:19:15] (03Merged) 10jenkins-bot: Support "application/json" in Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/468674 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [19:19:44] 10Readers-Web-Backlog: When I navigate away from an article and then back, I'd like my scroll position to be preserved - https://phabricator.wikimedia.org/T209418 (10Jdlrobson) [19:19:57] (03PS4) 10Dduvall: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) [19:21:38] (03PS1) 10Ladsgroup: Drop tag_summary and valid_tag tables [core] - 10https://gerrit.wikimedia.org/r/479266 (https://phabricator.wikimedia.org/T209525) [19:21:47] (03Merged) 10jenkins-bot: Add UserInfoModifier infrastructure [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478208 (owner: 10Robert Vogel) [19:23:05] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thanks @Jdlrobson!" [extensions/MobileFrontend] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479265 (https://phabricator.wikimedia.org/T210390) (owner: 10Jdlrobson) [19:25:13] bawolff: hello [19:25:17] Hi [19:25:50] (03CR) 10Nikhil-nk: "I have removed that part from CargoSQLQuery.php now and put it in CargoSpecialDrilldown.php. so, there shouldn't be any #cargo_query probl" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/471212 (owner: 10Nikhil-nk) [19:25:51] 10MediaWiki-Vendor: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) Can we get more of a stack? How frequently is it happening? [19:27:55] (03CR) 10jerkins-bot: [V: 04-1] [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) (owner: 10Sharvaniharan) [19:32:00] 10Front-end-Standards-Group, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Decide how to configure ESLint rules and ignores - https://phabricator.wikimedia.org/T204176 (10Krinkle) In today's FSG I brought up this pending decision and stated that either eslintrc/eslintignore or... [19:32:47] (03CR) 10Thcipriani: "no longer needed, I actually did this in the convert to json patch" [blubber] - 10https://gerrit.wikimedia.org/r/478743 (owner: 10Dduvall) [19:33:13] 10Front-end-Standards-Group, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Decide how to configure ESLint rules and ignores - https://phabricator.wikimedia.org/T204176 (10Esanders) I'm generally okay with the .eslintignore approach (included in the meeting count above). Some dr... [19:42:28] (03CR) 10jerkins-bot: [V: 04-1] Drop tag_summary and valid_tag tables [core] - 10https://gerrit.wikimedia.org/r/479266 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [19:42:38] (03CR) 10Zoranzoki21: "> @Zoranzoki21 Do you have time to transfer this to OOUI repo? Do you" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [19:45:42] 10wikimedia.biterg.io, 10Developer-Advocacy (Oct-Dec 2018), 10Documentation: Update documentation on [[mw:Community_metrics]] to reflect new UI on wikimedia.biterg.io - https://phabricator.wikimedia.org/T211759 (10Aklapper) 05Open>03Resolved * Updated https://www.mediawiki.org/wiki/File:Bitergia-dashboar... [19:49:58] (03CR) 10VolkerE: "git clone ssh://USERNAME@gerrit.wikimedia.org:29418/oojs/ui and just search for the occurrence…" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [19:52:05] (03Abandoned) 10Zoranzoki21: Fix typo "#$element" in the OOUI Documentation [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [19:52:23] 10Google-Code-in-2018, 10Developer-Advocacy (Oct-Dec 2018): Recruit Google Code-in 2018 mentors - https://phabricator.wikimedia.org/T203230 (10Aklapper) [19:52:29] 10Google-Code-in-2018, 10Pywikibot, 10Pywikibot-RfCs: Organizing the Pywikibot participation to GCI 2018 - https://phabricator.wikimedia.org/T203122 (10Aklapper) 05Open>03Resolved This task has no assignee and that's not good. I assume this is resolved by now as GCI is ending. Please reopen if I'm wrong.... [19:53:36] (03PS7) 10Cooltey: [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) [19:53:53] 10MediaWiki-Parser: quoted and unquoted attributes are not handled the same in Sanitizer.php - https://phabricator.wikimedia.org/T28441 (10matmarex) 05Open>03Resolved In the given example page (https://test.wikipedia.org/wiki/MW_ATTRIBS_REGEX), quoted and unquoted examples are now parsed identically. I thin... [19:54:21] 10CheckUser, 10Stewards-and-global-tools, 10Patch-For-Review: Duration of query recent changes in Check user tool - https://phabricator.wikimedia.org/T204347 (10Jalexander) p:05High>03Normal [19:56:36] 10Google-Code-in-2018, 10Pywikibot, 10Pywikibot-RfCs: Organizing the Pywikibot participation to GCI 2018 - https://phabricator.wikimedia.org/T203122 (10D3r1ck01) Thanks @Aklapper. So this task was mostly done by @Framawiki, @Dvorapa and @D3r1ck01. But I can't leave out @Xqt who did a lot of code review durin... [19:58:42] (03CR) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [19:59:43] 10Design, 10Mobile, 10Readers-Web-Backlog (Design), 10Spanish-Sites: Review new es.wikipedia's main page - https://phabricator.wikimedia.org/T211482 (10Jdrewniak) [20:00:01] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster - https://phabricator.wikimedia.org/T208808 (10Jdlrobson) Talked... [20:02:16] (03CR) 10Cooltey: [WIP] Add "adding title descriptions feed" (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) (owner: 10Cooltey) [20:04:42] (03CR) 10Zoranzoki21: "Done in https://gerrit.wikimedia.org/r/#/c/oojs/ui/+/479269/" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [20:05:17] 10MassMessage, 10Readers-Web-Backlog (Tracking), 10Wikimedia-production-error: Cannot render diffs where pages are converted from wikitext to MassMessageListContent - https://phabricator.wikimedia.org/T156293 (10Quiddity) >>! In T156293#4732807, @Jdlrobson wrote: > @legoktm @krinkle is there any easy way to... [20:06:21] 10MassMessage, 10Readers-Web-Backlog (Tracking), 10Wikimedia-production-error: Cannot render diffs where pages are converted from wikitext to MassMessageListContent - https://phabricator.wikimedia.org/T156293 (10Jdlrobson) It's okay I worked out how to replicate (see updated description) [20:11:10] 10CommRel-Internals, 10Goal: Refine team Evaluation Framework document - https://phabricator.wikimedia.org/T205716 (10Qgil) (I used expiration dates for goals identified for this quarter, as a way to remember to edit something if these tasks go beyond the quarter. #commrel-specialists-support has quarterly boa... [20:14:09] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) [20:16:57] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) Seems to be "bad calling" from a couple of entry points i... [20:19:20] (03PS5) 10Dduvall: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) [20:26:17] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) 84 in the last hour... I don't think this is unbreak now,... [20:27:11] 10MobileFrontend, 10Readers-Web-Backlog (Design): [Bug] Talk, watchstar, download, and language buttons should not appear on missing page - https://phabricator.wikimedia.org/T211775 (10Niedzielski) > That said, there seems little reason for the language and download icons Now I'm wondering if the language butt... [20:28:27] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) [20:30:20] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt (RW-Tech-Debt): Remove OO.EventEmitter functionality from View.js - https://phabricator.wikimedia.org/T211724 (10Jdlrobson) Following up on T211724#4815962, it looks like before-section-toggled, and talk-a... [20:31:44] 10MediaWiki-Special-pages, 10MediaWiki-User-management: Enable wgRelevantUserName for IP ranges - https://phabricator.wikimedia.org/T206954 (10Amorymeltzer) [20:32:49] (03CR) 10Jforrester: "The FIXME for postgres support presumably means this would break MW core's support for PG, which would mean this would get reverted after " [core] - 10https://gerrit.wikimedia.org/r/477610 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [20:35:11] (03PS6) 10Dduvall: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) [20:38:10] 10MinervaNeue, 10Readers-Web-Backlog: Resizing the window doesn't impact table of contents display - https://phabricator.wikimedia.org/T211815 (10Jdlrobson) [20:38:18] 10MinervaNeue, 10Readers-Web-Backlog: Resizing the window doesn't impact table of contents display - https://phabricator.wikimedia.org/T211815 (10Jdlrobson) p:05Triage>03Normal [20:38:30] experimental script for shell users to auto-detect the right bastion for you and fix your ssh config when bastions change https://people.wikimedia.org/~dzahn/bastion.sh.txt [20:38:55] (03CR) 10Dduvall: "This new implementation should be ready for review. :)" (032 comments) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [20:39:14] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10Jdl... [20:40:37] (03CR) 10Reedy: [C: 032] Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/479260 (https://phabricator.wikimedia.org/T211805) (owner: 10Ppchelko) [20:40:45] (03PS1) 10Reedy: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479272 (https://phabricator.wikimedia.org/T210608) [20:41:48] 10MediaWiki-Parser, 10Parsoid: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) - https://phabricator.wikimedia.org/T211816 (10matmarex) [20:42:29] (03PS2) 10Reedy: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479272 (https://phabricator.wikimedia.org/T211805) [20:42:44] 10Page-Previews, 10Readers-Web-Backlog: Prevent memory leaks from the nextState() function - https://phabricator.wikimedia.org/T211168 (10Krinkle) A few quick thoughts: Interesting find. Looking at the nextState function, it seems unlikely to leak, so I'd be interesting in figuring out what causes it. While a... [20:42:52] 10Page-Previews, 10Readers-Web-Backlog, 10Performance-Team (Radar): Prevent memory leaks from the nextState() function - https://phabricator.wikimedia.org/T211168 (10Krinkle) [20:44:26] (03Merged) 10jenkins-bot: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/479260 (https://phabricator.wikimedia.org/T211805) (owner: 10Ppchelko) [20:44:41] (03CR) 10Reedy: [C: 032] Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479272 (https://phabricator.wikimedia.org/T211805) (owner: 10Reedy) [20:46:03] too much revert [20:46:21] (03CR) 10jenkins-bot: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/479260 (https://phabricator.wikimedia.org/T211805) (owner: 10Ppchelko) [20:46:40] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [20:47:11] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) 05Open>03Resolved Not seei... [20:48:19] (03CR) 10Krinkle: [C: 032] filebackend: simplify code in FileBackendStore::getFileStat slightly [core] - 10https://gerrit.wikimedia.org/r/479034 (owner: 10Aaron Schulz) [20:48:45] (03Merged) 10jenkins-bot: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479272 (https://phabricator.wikimedia.org/T211805) (owner: 10Reedy) [20:48:49] 10ContentTranslation: [wmf.8 - minor] Monobook skin - misalgnied "Number of languages" element in 'New translation" suggestion list - https://phabricator.wikimedia.org/T211818 (10Etonkovidova) [20:49:07] (03CR) 10Krinkle: [C: 032] Add TransactionProfiler::redefineExpectations and migrate appropriate callers [core] - 10https://gerrit.wikimedia.org/r/477638 (owner: 10Aaron Schulz) [20:49:14] 10ContentTranslation: [wmf.8 - minor] Monobook skin - misalgned "Number of languages" element in 'New translation" suggestion list - https://phabricator.wikimedia.org/T211818 (10Etonkovidova) [20:50:52] (03CR) 10jenkins-bot: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.8) - 10https://gerrit.wikimedia.org/r/479272 (https://phabricator.wikimedia.org/T211805) (owner: 10Reedy) [20:52:52] 10MediaWiki-extensions-Cargo: Special:Drilldown not showing the articles when going in a category - https://phabricator.wikimedia.org/T211819 (10DSwissK) [20:54:26] (03PS1) 10Urbanecm: [bugfix] form.js was doing exactly the opposite [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479273 [20:54:38] (03CR) 10Urbanecm: [C: 032] [bugfix] form.js was doing exactly the opposite [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479273 (owner: 10Urbanecm) [20:55:41] (03Merged) 10jenkins-bot: [bugfix] form.js was doing exactly the opposite [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479273 (owner: 10Urbanecm) [20:56:17] 10MediaWiki-extensions-PageCuration, 10Growth-Team: unpatrolled/unreviewed pages aren't shown in Special:NewPagesFeed - https://phabricator.wikimedia.org/T204442 (10DSwissK) Looks like there is some conflict when using PageTriage with the cargo extension (version 1.7). Now that I updated it to version 2.0.1, i... [20:56:24] 10MediaWiki-extensions-PageCuration, 10Growth-Team: unpatrolled/unreviewed pages aren't shown in Special:NewPagesFeed - https://phabricator.wikimedia.org/T204442 (10DSwissK) 05Open>03Resolved a:03DSwissK [20:58:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/479274 (owner: 10L10n-bot) [21:02:02] (03CR) 10Krinkle: "I see." [core] - 10https://gerrit.wikimedia.org/r/478419 (owner: 10Aaron Schulz) [21:02:25] (03Merged) 10jenkins-bot: filebackend: simplify code in FileBackendStore::getFileStat slightly [core] - 10https://gerrit.wikimedia.org/r/479034 (owner: 10Aaron Schulz) [21:02:30] (03Merged) 10jenkins-bot: Add TransactionProfiler::redefineExpectations and migrate appropriate callers [core] - 10https://gerrit.wikimedia.org/r/477638 (owner: 10Aaron Schulz) [21:02:34] 10ContentTranslation: [wmf.8] CX2 - Infobox person template displays red links in source panel - https://phabricator.wikimedia.org/T211820 (10Etonkovidova) [21:02:41] 10Editing Design , 10VisualEditor (Current work): User Testing of Isolated Section Editing - https://phabricator.wikimedia.org/T209986 (10Ryasmeen) Yup! I think @dchan already suggested to have the prototype on our demo page: https://doc.wikimedia.org/oojs-ui/master/ Once we have that ready, I will able to se... [21:04:05] (03PS1) 10Arcayn: Fix error in ticket admin caused by fixing T211521 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479276 [21:04:37] (03CR) 10jenkins-bot: filebackend: simplify code in FileBackendStore::getFileStat slightly [core] - 10https://gerrit.wikimedia.org/r/479034 (owner: 10Aaron Schulz) [21:06:07] (03CR) 10jenkins-bot: Add TransactionProfiler::redefineExpectations and migrate appropriate callers [core] - 10https://gerrit.wikimedia.org/r/477638 (owner: 10Aaron Schulz) [21:06:53] (03CR) 10Niedzielski: [C: 04-1] Port toggle.js to webpack (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479137 (https://phabricator.wikimedia.org/T210208) (owner: 10Jdrewniak) [21:08:41] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt (RW-Tech-Debt): Remove OO.EventEmitter functionality from View.js - https://phabricator.wikimedia.org/T211724 (10nray) @Jdlrobson I really like the more granular pattern you've suggested which, as you said... [21:09:13] (03CR) 10Niedzielski: [C: 04-1] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [21:11:02] 10Google-Summer-of-Code, 10Graphs: Support Vega 3.0 and Vega Lite 2.0 - https://phabricator.wikimedia.org/T165118 (10Milimetric) Ok, I had some time, I poked around a bit. My conclusion is that graphoid needs some basic maintenance first before new features can be implemented. So I've talked to the services... [21:11:04] 10MediaWiki-extensions-General, 10Cleanup, 10GitHub-Mirrors, 10Other-skins, and 2 others: Archive the - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) [21:11:53] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10User-MarcoAurelio: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) p:05Triage>03Low [21:13:04] (03CR) 10Nray: Remove usage of global event emitter from MF (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477684 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [21:14:45] 10CommRel-Specialists-Support (Oct-Dec-2018): Specialist support for 2018/19 password strengthening project - https://phabricator.wikimedia.org/T205931 (10CKoerner_WMF) Upon recommendation I have additional sent a message to the stewards-l mailing list (waiting approval) and the Bureaucrats noticeboards. * htt... [21:14:55] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10User-MarcoAurelio: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) [21:15:01] 10CommRel-Specialists-Support (Oct-Dec-2018): Specialist support for 2018/19 password strengthening project - https://phabricator.wikimedia.org/T205931 (10TBolliger) 👍 [21:15:32] (03PS9) 10Niedzielski: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [21:15:43] (03PS2) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 [21:17:46] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10User-MarcoAurelio: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) [21:17:48] (03CR) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [21:18:23] (03CR) 10MarkAHershberger: Added hooks in get attribute functions. (031 comment) [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/475735 (owner: 10Cicalese) [21:19:22] (03CR) 10Ladsgroup: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/477610 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [21:20:20] (03CR) 10Niedzielski: [C: 032] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [21:24:44] (03CR) 10Cicalese: Added hooks in get attribute functions. (031 comment) [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/475735 (owner: 10Cicalese) [21:24:58] 10Product-Analytics, 10Reading-analysis, 10Wikimedia Taiwan, 10Chinese-Sites: [REQUEST] WMTW want to have zhwiki yearly-aggregate top 10 articles viewed in 2017. - https://phabricator.wikimedia.org/T183903 (10Milimetric) quickly adding an example for all wikis, in case it's needed in the future (I haven't... [21:25:44] (03PS1) 10MarcoAurelio: Archive extension [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/479326 (https://phabricator.wikimedia.org/T211821) [21:26:25] (03PS10) 10Niedzielski: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [21:29:33] (03CR) 10MarcoAurelio: [V: 032 C: 032] Archive extension [extensions/ConditionalShowSection] - 10https://gerrit.wikimedia.org/r/479326 (https://phabricator.wikimedia.org/T211821) (owner: 10MarcoAurelio) [21:30:04] (03PS9) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [21:31:05] (03PS5) 10Niedzielski: Hygiene: collapse mobile.search* into mobile.startup [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478109 (https://phabricator.wikimedia.org/T210207) [21:31:52] (03PS1) 10Niedzielski: Hygiene: remove deprecated ResourceLoader modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479331 (https://phabricator.wikimedia.org/T210207) [21:32:25] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Niedzielski) a:05Niedzielski>03None [21:32:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/479294 (owner: 10L10n-bot) [21:32:48] (03PS1) 10MarcoAurelio: [ConditionalShowSection] Archive extension [extensions] - 10https://gerrit.wikimedia.org/r/479332 (https://phabricator.wikimedia.org/T211821) [21:33:54] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [21:35:19] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Remove CtaDrawer events and pass events for red link CtaDrawer via options - https://phabricator.wikimedia.org/T210870 (10Niedzielski) a:03Niedzielski The context genie has smiled upon me! [21:37:21] (03PS2) 10MarcoAurelio: [ConditionalShowSection] Archive extension [extensions] - 10https://gerrit.wikimedia.org/r/479332 (https://phabricator.wikimedia.org/T211821) [21:37:25] (03CR) 10Aaron Schulz: "A boolean would make lockTSE logic have nothing to work on. Rather than have the callback look at a timestamp and compare it with $asOf, i" [core] - 10https://gerrit.wikimedia.org/r/478419 (owner: 10Aaron Schulz) [21:37:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/479300 (owner: 10L10n-bot) [21:37:47] (03PS3) 10MarcoAurelio: [ConditionalShowSection] Archive extension [extensions] - 10https://gerrit.wikimedia.org/r/479332 (https://phabricator.wikimedia.org/T211821) [21:37:56] (03CR) 10MarcoAurelio: [V: 032 C: 032] [ConditionalShowSection] Archive extension [extensions] - 10https://gerrit.wikimedia.org/r/479332 (https://phabricator.wikimedia.org/T211821) (owner: 10MarcoAurelio) [21:38:26] (03CR) 10MarkAHershberger: Added hooks in get attribute functions. (031 comment) [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/475735 (owner: 10Cicalese) [21:38:46] (03PS10) 10Dbrant: [EXTREME WIP] Augmented keyboard for editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) [21:39:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/479297 (owner: 10L10n-bot) [21:40:07] 10Google-Summer-of-Code, 10Graphs: Support Vega 3.0 and Vega Lite 2.0 - https://phabricator.wikimedia.org/T165118 (10domoritz) Thanks for the update. Let me know if there is anything I can help with. [21:40:09] (03CR) 10jerkins-bot: [V: 04-1] [EXTREME WIP] Augmented keyboard for editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) (owner: 10Dbrant) [21:40:49] 04(no projects): Need a bot for a Wiki Loves Africa / Glamify call for action - https://phabricator.wikimedia.org/T211441 (10Anthere) HI @Aklapper I needed at least one public place I could refer to :) I will follow your advice for the Commons:bots. Good idea ! [21:40:55] (03PS11) 10Dbrant: [EXTREME WIP] Augmented keyboard for editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) [21:41:08] (03CR) 10MarkAHershberger: Added hooks in get attribute functions. (031 comment) [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/475735 (owner: 10Cicalese) [21:43:07] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10zeljkofilipin) Do you have an estimate on the numbers when move... [21:44:56] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: remove deprecated ResourceLoader modules [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479331 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [21:45:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/479303 (owner: 10L10n-bot) [21:46:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/479301 (owner: 10L10n-bot) [21:48:09] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) [21:48:42] 10MediaWiki-Parser, 10Parsoid: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) - https://phabricator.wikimedia.org/T211816 (10Arlolra) p:05Triage>03Normal > The result is identical in the PHP parser as well as Parsoid (probably since rGPAR00ac33236f2a:... [21:48:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479309 (owner: 10L10n-bot) [21:49:29] (03PS13) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [21:50:51] 10MediaWiki-Parser, 10Parsoid: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) - https://phabricator.wikimedia.org/T211816 (10ssastry) >>! In T211816#4818606, @Arlolra wrote: >> The result is identical in the PHP parser as well as Parsoid (probably since rG... [21:51:09] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) [21:51:27] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ConditionalShowSection extension - https://phabricator.wikimedia.org/T211821 (10MarcoAurelio) Waiting for the remaining open patches to be merged before closing the task. [21:52:21] 10MediaWiki-Parser, 10Parsoid: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) - https://phabricator.wikimedia.org/T211816 (10Arlolra) p:05Normal>03Low > I think we can and should break compatibility in these cases. I think we should make Parsoid the o... [21:52:39] 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation loaded a translation draft badly after the source article was changed - https://phabricator.wikimedia.org/T122289 (10Etonkovidova) 05Open>03Resolved a:03Etonkovidova Re-checked with cx2 - the behavior seems to be changed: - an article was... [21:52:46] (03PS10) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [21:52:54] 10Discovery-Search: Investigate a “rare-character” index - https://phabricator.wikimedia.org/T211824 (10TJones) [21:53:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/479312 (owner: 10L10n-bot) [21:53:10] 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10nray) Tested anon / logged in users, previews with images / no images using https://en.wikipedia.beta.wmflabs.org/wiki/VisualEditor. All appears to be working... [21:53:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [21:55:34] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews, 10Readers-Web-Backlog (Tracking), 10Services (later): Page Previews should take FlaggedRevs' stabilization setting into account - https://phabricator.wikimedia.org/T211501 (10Pchelolo) Support for flagged revisions in #restbase have been haunting us for... [21:55:36] 10MediaWiki-Parser, 10Parsoid: Wikitext parsing of unescaped < and > inside tag attributes is unexpected (different from HTML rules) - https://phabricator.wikimedia.org/T211816 (10ssastry) >>! In T211816#4818634, @Arlolra wrote: >> I think we can and should break compatibility in these cases. > > I think we s... [21:55:46] 10Growth-Team (Current Sprint): Help panel: conduct user testing of initial help pane design - https://phabricator.wikimedia.org/T210112 (10RHo) [21:56:06] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10WMF-Legal, 10Patch-For-Review, and 3 others: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Pchelolo) [21:56:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479307 (owner: 10L10n-bot) [21:56:53] 10Growth-Team (Current Sprint): Help panel: conduct user testing of initial help pane design - https://phabricator.wikimedia.org/T210112 (10RHo) Findings summary presentation is complete, with most of the minor recommendations from the testing incorporated into the V1 design. [21:58:07] 10MediaWiki-Uploading, 10Commons, 10Multimedia: Automatically convert .heic image format files to .jpg or .webp - https://phabricator.wikimedia.org/T211745 (10Dinoguy1000) UIAM the WMF would want to keep the original file(s) as well, so that when the HEIF patents expire it could be made available, but there... [22:01:45] 10Google-Code-in-2018, 10Page-Previews, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review, and 2 others: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10nray) [22:02:08] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10Reedy) https://stackoverflow.com/a/38060763 seems very likely as... [22:02:30] 10Google-Code-in-2018, 10Page-Previews, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review, and 2 others: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10nray) a:05nray>03None [22:02:45] 10Product-Analytics, 10Reading-analysis: Request: Top articles of 2018 on all Wikipedias - https://phabricator.wikimedia.org/T211827 (10Quiddity) [22:04:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/479318 (owner: 10L10n-bot) [22:06:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/479315 (owner: 10L10n-bot) [22:08:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/479322 (owner: 10L10n-bot) [22:11:05] (03PS14) 10Kosta Harlan: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [22:11:41] (03CR) 10Catrope: [C: 032] Migrate SpecialUndelete and Diff from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [22:12:16] (03PS8) 10Jdlrobson: Allow users to change their mobile skin preference (take 2) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451807 (https://phabricator.wikimedia.org/T173527) [22:15:56] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10BPirkle) GuzzleHttpRequest.php line 94, we are indeed setting th... [22:16:23] (03CR) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479154 (owner: 10VolkerE) [22:24:04] (03CR) 10Thcipriani: [C: 031] "nitpick about gnu sed inline, otherwise: lgtm" (032 comments) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [22:28:10] 10Readers-Web-Backlog: Drop all usages of isBorderBox and className props on View and remove log warnings - https://phabricator.wikimedia.org/T211828 (10Jdlrobson) [22:28:19] 10Thumbor, 10media-storage: Outdated thumbnail for djvu file on Commons cannot be purged and does not update - https://phabricator.wikimedia.org/T206190 (10Ankry) 05Resolved>03Open [22:28:21] 10Readers-Web-Backlog: Drop all usages of isBorderBox and className props on View and remove log warnings - https://phabricator.wikimedia.org/T211828 (10Jdlrobson) p:05Triage>03High [22:29:43] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture): MFA: Drop all usages of isBorderBox and className props on View and remove log warnings - https://phabricator.wikimedia.org/T211828 (10Jdlrobson) [22:30:29] 10Thumbor, 10media-storage: Outdated thumbnail for djvu file on Commons cannot be purged and does not update - https://phabricator.wikimedia.org/T206190 (10Ankry) @Gilles The problem appeared again with file: https://commons.wikimedia.org/wiki/File:Poezye_oryginalne_i_t%C5%82omaczone.djvu pages: 468, 465, 447,... [22:30:58] (03Merged) 10jenkins-bot: Migrate SpecialUndelete and Diff from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [22:32:20] (03PS1) 10Urbanecm: [language] Fix minor language issue in default STATUTORY_DECLARATION_TEXT [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479338 [22:32:33] (03CR) 10Urbanecm: [C: 032] [language] Fix minor language issue in default STATUTORY_DECLARATION_TEXT [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479338 (owner: 10Urbanecm) [22:33:29] (03CR) 10jenkins-bot: Migrate SpecialUndelete and Diff from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [22:33:44] (03Merged) 10jenkins-bot: [language] Fix minor language issue in default STATUTORY_DECLARATION_TEXT [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479338 (owner: 10Urbanecm) [22:34:07] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Epic: [EPIC] Review and refactor Minerva components - https://phabricator.wikimedia.org/T195482 (10Jdlrobson) [22:34:09] 10MobileFrontend, 10MinervaNeue, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-Jdlrobson: [EPIC] Speed up unit test execution and increase code coverage - https://phabricator.wikimedia.org/T195478 (10Jdlrobson) [22:34:12] 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: View: Make isBorderBox and className passable options to the View cl... - https://phabricator.wikimedia.org/T209007 [22:34:21] 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: View: Make isBorderBox and className passable options to the View cl... - https://phabricator.wikimedia.org/T209007 [22:34:44] 10Page-Previews, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Popups: Upgrade Popups dependencies - https://phabricator.wikimedia.org/T209314 (10Jdlrobson) [22:34:48] 10Google-Code-in-2018, 10Page-Previews, 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10Patch-For-Review, and 2 others: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10Jdlrobson) 05Open>03Resolved a:03Jdlrobson Good work all! [22:35:21] (03PS1) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [22:36:18] (03CR) 10jerkins-bot: [V: 04-1] Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) (owner: 10Urbanecm) [22:38:29] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10dbarratt) >>! In T210790#4789197, @Anomie wrote: > * Sets $wgUser and the ContextSource user to an anonymous user. By default, the browser will not send credentials unless the preflight respon... [22:41:00] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10BPirkle) Reproduced the exception locally using trivial test dat... [22:42:33] (03PS15) 10Kosta Harlan: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [22:42:41] (03PS11) 10Sharvaniharan: [WIP] On boarding screens for the App Editor task list [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478233 (https://phabricator.wikimedia.org/T209539) [22:42:51] (03PS1) 10Jdlrobson: Suppress deprecation warnings on various Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479344 (https://phabricator.wikimedia.org/T211828) [22:43:24] 10New-Readers, 10Product-Analytics: Analysis of short term impact of Mexico campaign to site and landing page traffic - https://phabricator.wikimedia.org/T210813 (10atgo) Hey @chelsyx. Do you need anything else from this task? I am working on getting a detailed timeline and should have it by EOY [22:43:44] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10Jdl... [22:43:52] 10Readers-Web-Backlog, 10Epic: [EPIC] Talk about and improve our frontend code architecture - https://phabricator.wikimedia.org/T166905 (10Jdlrobson) [22:43:55] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.9; 2018-12-18), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10Jdl... [22:45:48] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10dbarratt) >>! In T210790#4787862, @Bawolff wrote: > Note previous discussion on T62835 - perhaps it was unnecessarily paranoid. Seems to be. [22:46:10] (03PS1) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [22:47:13] (03CR) 10jerkins-bot: [V: 04-1] Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) (owner: 10Urbanecm) [22:48:27] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt (RW-Tech-Debt): Remove OO.EventEmitter functionality from View.js - https://phabricator.wikimedia.org/T211724 (10Jdlrobson) Added to agenda! [22:48:49] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Technical-Debt (RW-Tech-Debt): [Spike] Discuss OO.EventEmitter usage for Views - https://phabricator.wikimedia.org/T211724 (10Jdlrobson) [22:49:39] (03CR) 10jerkins-bot: [V: 04-1] Suppress deprecation warnings on various Views [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479344 (https://phabricator.wikimedia.org/T211828) (owner: 10Jdlrobson) [22:50:06] (03CR) 10Dduvall: Provide OpenAPI spec for Blubberoid (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [22:51:19] 10New-Readers, 10Product-Analytics: Analysis of short term impact of Mexico campaign to site and landing page traffic - https://phabricator.wikimedia.org/T210813 (10Isaac) Thanks for asking @atgo -- @chelsyx and I are meeting tomorrow to discuss this task so should be able to get you an answer then [22:51:46] (03PS2) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [22:51:52] (03PS7) 10Dduvall: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) [22:52:11] (03PS2) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [22:52:37] (03CR) 10Dduvall: "Fixed up" (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [22:52:58] (03PS3) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [22:53:05] (03PS3) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [22:54:03] (03PS4) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [22:54:15] (03PS4) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [22:55:38] (03PS5) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [22:55:47] (03PS5) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [22:56:57] 10WMSE-Riksarkivet-NAD, 10WMSE-Riksarkivet-TORA: How should we manage/synchronize the creation of new/changed TORA/NAD objects in WD - https://phabricator.wikimedia.org/T199862 (10Salgo60) [22:59:50] (03PS1) 10Urbanecm: Remove topics_js from Tracker admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479347 [23:00:14] (03CR) 10Urbanecm: [C: 032] Remove topics_js from Tracker admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479347 (owner: 10Urbanecm) [23:00:16] (03CR) 10Thcipriani: Provide OpenAPI spec for Blubberoid (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [23:00:49] 10WMSE-Riksarkivet-NAD, 10WMSE-Riksarkivet-TORA: How should we manage/synchronize the creation of new/changed TORA/NAD objects in WD - https://phabricator.wikimedia.org/T199862 (10Salgo60) [23:01:15] (03Merged) 10jenkins-bot: Remove topics_js from Tracker admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479347 (owner: 10Urbanecm) [23:01:39] (03PS6) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [23:01:51] (03PS6) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [23:02:26] (03PS8) 10Dduvall: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) [23:02:42] (03CR) 10Dduvall: Provide OpenAPI spec for Blubberoid (031 comment) [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [23:03:58] (03CR) 10Jdlrobson: "The outcome looks good to me, but I am finding it difficult to follow and review this what with all the deletes/adds which are actually re" (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [23:05:37] (03CR) 10Thcipriani: [C: 032] "yipee!" [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [23:05:52] (03Merged) 10jenkins-bot: Provide OpenAPI spec for Blubberoid [blubber] - 10https://gerrit.wikimedia.org/r/461458 (https://phabricator.wikimedia.org/T205920) (owner: 10Dduvall) [23:05:53] 10MediaWiki-extensions-PageCuration, 10Growth-Team: New Pages Feed: toolbar loads inconsistently in Safari - https://phabricator.wikimedia.org/T211829 (10MMiller_WMF) [23:06:33] (03CR) 10Jdlrobson: Hygiene: collapse mobile.search* into mobile.startup (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [23:11:54] 10New-Readers, 10Product-Analytics: Analysis of short term impact of Mexico campaign to site and landing page traffic - https://phabricator.wikimedia.org/T210813 (10atgo) Great, thanks! [23:12:29] (03PS1) 10Jdlrobson: Hygiene: Drop unused test template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479349 [23:12:47] (03CR) 10Jdlrobson: Port toggle.js to webpack (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479137 (https://phabricator.wikimedia.org/T210208) (owner: 10Jdrewniak) [23:13:47] 10MediaWiki-extensions-OATHAuth: More safety codes for 2FA and ability to see which are used - https://phabricator.wikimedia.org/T211831 (10Leaderboard) [23:14:35] (03PS7) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [23:14:50] 10MediaWiki-extensions-DonationInterface, 10Fr-Ingenico-integration_2017-18, 10Fundraising-Backlog: Reconcile field length limits between DonationInterface and Ingenico Connect - https://phabricator.wikimedia.org/T211832 (10Ejegg) [23:15:20] (03PS7) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [23:15:25] (03PS1) 10Jdlrobson: Mediawiki.ui.input should be a dependency of the EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479350 (https://phabricator.wikimedia.org/T211743) [23:15:33] (03CR) 10jerkins-bot: [V: 04-1] Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) (owner: 10Urbanecm) [23:16:23] (03CR) 10jerkins-bot: [V: 04-1] Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) (owner: 10Urbanecm) [23:16:29] (03PS2) 10Jdlrobson: Mediawiki.ui.input should be a dependency of the EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479350 (https://phabricator.wikimedia.org/T211743) [23:16:42] (03CR) 10VolkerE: [C: 032] Mediawiki.ui.input should be a dependency of the EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479350 (https://phabricator.wikimedia.org/T211743) (owner: 10Jdlrobson) [23:17:25] (03PS8) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [23:17:46] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Leaderboard) Filed T211831 for that. [23:18:02] (03PS8) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [23:18:24] (03CR) 10jerkins-bot: [V: 04-1] Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) (owner: 10Urbanecm) [23:18:33] (03PS9) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [23:18:40] (03PS9) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [23:19:37] (03CR) 10Jforrester: [C: 032] Restructure highlighting code for improved readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478937 (owner: 10Thiemo Kreuz (WMDE)) [23:20:04] (03CR) 10Jforrester: [C: 032] Improve readability of SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/478578 (owner: 10Gergő Tisza) [23:20:14] (03PS10) 10Urbanecm: Enable everyone to add Statutory declaration in multi-driver tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479341 (https://phabricator.wikimedia.org/T211783) [23:20:18] (03PS10) 10Urbanecm: Add column "Expenditures" everywhere [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479345 (https://phabricator.wikimedia.org/T211779) [23:21:05] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/479351 [23:21:09] (03CR) 10Jforrester: Rename SpecialBlock::checkUnblockSelf to be more accurate (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478579 (owner: 10Gergő Tisza) [23:21:25] 10MediaWiki-Authentication-and-authorization, 10Security-Team, 10Security: Make the stored session id be a hash of the used session id to isolate them - https://phabricator.wikimedia.org/T209586 (10Tgr) Wikimedia production has four different session providers: MediaWiki core, CentralAuth, OAuth, bot passwor... [23:22:01] (03PS1) 10MarkAHershberger: Set up cache only once. [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/479352 [23:24:24] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions) - https://phabricator.wikimedia.org/T205732 (10Ramsey-WMF) [23:24:48] (03PS4) 10Jdlrobson: Fix dependencies on core modules for mw.user and mw.util [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 (owner: 10Fomafix) [23:25:13] (03CR) 10Jdlrobson: [C: 032] Fix dependencies on core modules for mw.user and mw.util [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 (owner: 10Fomafix) [23:26:51] (03PS2) 10Jdlrobson: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/479351 (owner: 10VolkerE) [23:26:55] (03CR) 10Jdlrobson: [C: 032] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/479351 (owner: 10VolkerE) [23:29:13] 10CX-analytics, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11): Extend CX2 translations graph to show also published translations that need review - https://phabricator.wikimedia.org/T209868 (10Etonkovidova) I checked today (the task is on my list of tasks to che... [23:30:37] (03PS1) 10Jdrewniak: POC - Storybook.js for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479354 (https://phabricator.wikimedia.org/T205989) [23:31:09] 10Language-Team: [Proposed]Localising template parameter gadget - https://phabricator.wikimedia.org/T211746 (10Huji) In fawiki, 2 and 3 are most common (and we are gradually moving away from 2 and towards 3). As more templates become Lua-based, we are also moving away from all of the above, towards having a wrap... [23:32:27] 10MediaWiki-extensions-OATHAuth: More safety codes for 2FA and ability to see which are used - https://phabricator.wikimedia.org/T211831 (10Reedy) > Additionally, it would be preferable if there was a way for the user to find out how many (and which if possible) codes are left. How many has some use, but it's l... [23:34:06] (03Merged) 10jenkins-bot: Mediawiki.ui.input should be a dependency of the EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479350 (https://phabricator.wikimedia.org/T211743) (owner: 10Jdlrobson) [23:34:08] (03CR) 10jerkins-bot: [V: 04-1] Restructure highlighting code for improved readability [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478937 (owner: 10Thiemo Kreuz (WMDE)) [23:34:42] (03CR) 10jerkins-bot: [V: 04-1] POC - Storybook.js for Popups [extensions/Popups] - 10https://gerrit.wikimedia.org/r/479354 (https://phabricator.wikimedia.org/T205989) (owner: 10Jdrewniak) [23:36:33] (03PS1) 10Reedy: Give 10 users 10 scratch tokens [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/479356 (https://phabricator.wikimedia.org/T211831) [23:36:33] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10Anomie) >>! In T210790#4818796, @dbarratt wrote: >>>! In T210790#4789197, @Anomie wrote: >> * Sets $wgUser and the ContextSource user to an anonymous user. > By default, the browser will not s... [23:36:41] (03CR) 10Jforrester: [C: 031] Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) (owner: 10Dbarratt) [23:36:58] (03PS5) 10Jforrester: Add tests to ensure that NamespaceRestrictions are returned from Block APIs. [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) (owner: 10Dbarratt) [23:37:10] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: Drop unused test template [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479349 (owner: 10Jdlrobson) [23:37:47] (03CR) 10jenkins-bot: Mediawiki.ui.input should be a dependency of the EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/479350 (https://phabricator.wikimedia.org/T211743) (owner: 10Jdlrobson) [23:38:16] 10CirrusSearch, 10Product-Analytics, 10Discovery-Search (Current work): Huge drop in search CTR as of Nov 30 2018 - https://phabricator.wikimedia.org/T211306 (10chelsyx) a:03chelsyx [23:38:34] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: More safety codes for 2FA and ability to see which are used - https://phabricator.wikimedia.org/T211831 (10Huji) >>! In T211831#4818950, @Reedy wrote: >> Additionally, it would be preferable if there was a way for the user to find out how many (and which if... [23:39:04] (03CR) 10Urbanecm: "Thanks! Sadly, i noticed your patch after i noticed (and fixed https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/479347 myself), so " [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479276 (owner: 10Arcayn) [23:39:32] (03Abandoned) 10Urbanecm: Fix error in ticket admin caused by fixing T211521 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/479276 (owner: 10Arcayn) [23:40:16] (03PS2) 10Reedy: Give users 10 scratch tokens [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/479356 (https://phabricator.wikimedia.org/T211831) [23:40:44] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: More safety codes for 2FA and ability to see which are used - https://phabricator.wikimedia.org/T211831 (10Reedy) >>! In T211831#4818970, @Huji wrote: >>>! In T211831#4818950, @Reedy wrote: >>> Additionally, it would be preferable if there was a way for the... [23:40:53] (03CR) 10Jforrester: [C: 031] Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) (owner: 10Dbarratt) [23:42:34] (03Merged) 10jenkins-bot: Improve readability of SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/478578 (owner: 10Gergő Tisza) [23:42:46] (03Merged) 10jenkins-bot: Fix dependencies on core modules for mw.user and mw.util [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 (owner: 10Fomafix) [23:42:50] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/479351 (owner: 10VolkerE) [23:43:55] 10Wikimedia-Extension-setup, 10Tracking: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123 (10MaxSem) [23:43:58] 10Wikimedia-Site-requests: Sunset Wikipedia Zero (tracking) - https://phabricator.wikimedia.org/T187716 (10MaxSem) 05stalled>03Open Arise, o ticket! We have 3 weeks left, might as well start our preparations. [23:44:08] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions) - https://phabricator.wikimedia.org/T205732 (10Ramsey-WMF) [23:44:15] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block - https://phabricator.wikimedia.org/T205891 (10Ramsey-WMF) 05Open>03Re... [23:45:01] (03CR) 10jenkins-bot: Improve readability of SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/478578 (owner: 10Gergő Tisza) [23:46:16] (03CR) 10jenkins-bot: Fix dependencies on core modules for mw.user and mw.util [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477628 (owner: 10Fomafix) [23:48:59] (03CR) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/479351 (owner: 10VolkerE) [23:49:46] Urbanecm, sorry, fell asleep last night :/ [23:50:20] (03CR) 10Jforrester: SiteMatrix should contain the IETF language tag (the "lang") of the wiki (031 comment) [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/458926 (https://phabricator.wikimedia.org/T203571) (owner: 10Dbarratt) [23:51:35] (03CR) 10Jforrester: [C: 032] "…" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478937 (owner: 10Thiemo Kreuz (WMDE)) [23:53:15] (03CR) 10Anomie: Rename SpecialBlock::checkUnblockSelf to be more accurate (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478579 (owner: 10Gergő Tisza) [23:54:37] (03CR) 10Catrope: [C: 04-1] "Looks good, some minor things inline" (0311 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [23:59:42] 10MediaWiki-Vendor, 10MediaWiki-extensions-JsonConfig, 10Collection, 10Wikidata, 10Wikidata-Campsite: Passing in the "body" request option as an array to send a POST request has been deprecated - https://phabricator.wikimedia.org/T211806 (10BPirkle) This looks more promising: ` if ( is_array( $postDa...