[00:20:47] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) Asked at nowiki if anyone sees this. Of seven replies all saw the garbage content at [[ https://commons.wikimedia.org/w/ind... [00:22:21] 10Wikimedia-production-error: ApiQuerySiteinfo.php: PHP Notice: Undefined index: 103 - https://phabricator.wikimedia.org/T211529 (10Krinkle) Caused by T205546 {d706a315b9653489fb2a7090b62258724ce6f255} [01:40:31] 10Google-Code-in-2018, 10FormWizard, 10FormWizard-Gadget: Design a logo for FormWizard Extension. - https://phabricator.wikimedia.org/T208193 (10Wwdjbox) {F27463310} [01:45:08] (03PS1) 10Leduyquang753: Version 0.0.2 experimental. [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478572 [01:45:10] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478572 (owner: 10Leduyquang753) [01:47:17] 10Google-Code-in-2018, 10Africa-Wikimedia-Developers: [Recurring] Unit tests for the awmd-stats tool - https://phabricator.wikimedia.org/T205450 (10Stibba) Hi, I wanted to add tests but I got somewhat confused because testGetContributors was added however it looks to me like it's testing getStatsFromDb instea... [01:51:45] 10MediaWiki-extensions-CentralAuth: Special:WikiSets is hard to read and should use a table like Special:UserGroupRights - https://phabricator.wikimedia.org/T211531 (10AntiCompositeNumber) [01:53:21] (03Abandoned) 10Leduyquang753: Version 0.0.2 experimental. [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478572 (owner: 10Leduyquang753) [01:57:34] (03PS1) 10Leduyquang753: ImageCompare version 0.0.2 experimental. [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478573 [02:02:33] (03CR) 10Leduyquang753: [V: 032 C: 032] "This is the commit to push initial code." [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478573 (owner: 10Leduyquang753) [02:03:07] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to entroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Xaosflux) [02:06:59] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to entroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Matiia) I was able to enable it using a sock with GS access. [02:11:01] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Update Youdao MT client to new API - https://phabricator.wikimedia.org/T210578 (10KartikMistry) Deployed in Production. No errors so far. [02:12:54] (03PS1) 10Leduyquang753: Version number change. [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478574 [02:14:07] (03CR) 10Leduyquang753: [V: 032 C: 032] "Somehow my version code in extension.json was reverted to 0.0.1." [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478574 (owner: 10Leduyquang753) [02:23:57] (03PS1) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [02:24:04] (03CR) 10jerkins-bot: [V: 04-1] i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [02:24:31] 10MediaWiki-ResourceLoader, 10Operations, 10Performance-Team, 10Traffic: Investigate source of 404 Not Found responses from load.php - https://phabricator.wikimedia.org/T202479 (10Krinkle) 05Open>03stalled a:05Krinkle>03None @ema @BBlack This outcome of this task should be for the mtail/varnishrls... [02:27:28] (03PS2) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [02:27:48] heh [02:27:50] 3 am [02:27:54] :D [02:28:33] (03CR) 10jerkins-bot: [V: 04-1] i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [02:28:38] eh wikibugs [02:29:17] you are such mean bot... [02:32:50] (03PS3) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [02:32:58] jenkins please [02:33:05] be a good bot [02:34:00] lol I love GCI. I'm using my on 3:34 am [02:34:51] Wikibugs i like you now [02:34:57] I like Jenkins bot too [02:35:05] you are such amazing bots [02:35:12] wm-bot: hey [02:35:12] Hi takidelfin, there is an error, I'm a stupid bot and not intelligent enough to hold a conversation with you :-) [02:35:30] i'm too sleppy to talk with a bot [02:35:36] goodnight everyone [02:35:49] Urbanecm: Could you review my patch? https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478576 :D [02:36:27] I will go to sleep now and start working on my task at 9 am I think [02:37:00] +/- 1.5 hour [02:37:03] goodnight [02:39:10] (03Abandoned) 10Krinkle: Load gadget JS-modules in the same batch as eveything else [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/457800 (owner: 10Krinkle) [02:39:27] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to entroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Xaosflux) @Chrissymad can you describe the problem you found more here please? [02:47:44] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: @import are broken due to be concatenated in the middle of output. - https://phabricator.wikimedia.org/T210891 (10Krinkle) @Alexia Apologies for the inconvenience resulting from this. It is intentional on our part for ResourceLoader to not... [02:47:54] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: @import are broken due to be concatenated in the middle of output. - https://phabricator.wikimedia.org/T210891 (10Krinkle) p:05Triage>03Normal [02:49:21] 10MediaWiki-ResourceLoader, 10Performance-Team: LESS in ResourceLoader can't parse two ampersands on one line - https://phabricator.wikimedia.org/T204816 (10Krinkle) [02:49:40] 10MediaWiki-ResourceLoader, 10Performance-Team: LESS in ResourceLoader can't parse two ampersands on one line - https://phabricator.wikimedia.org/T204816 (10Krinkle) p:05Triage>03Low [02:49:54] (03CR) 10Krinkle: [C: 04-1] "See task." [core] - 10https://gerrit.wikimedia.org/r/477329 (https://phabricator.wikimedia.org/T210891) (owner: 10Alexia) [02:56:55] (03CR) 10Krinkle: [C: 04-1] "two questions and a fixme in the test." (034 comments) [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [02:59:11] (03PS2) 10Krinkle: Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 [02:59:15] (03CR) 10Krinkle: [C: 032] Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [03:03:44] (03CR) 10Krinkle: [C: 032] Hard deprecated SiteSQLStore::newInstance() [core] - 10https://gerrit.wikimedia.org/r/478459 (owner: 10MaxSem) [03:05:26] (03CR) 10Krinkle: [C: 032] Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [03:05:46] (03CR) 10Krinkle: [C: 032] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [03:13:48] (03Merged) 10jenkins-bot: Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [03:16:21] (03CR) 10jenkins-bot: Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [03:17:48] (03Merged) 10jenkins-bot: Hard deprecated SiteSQLStore::newInstance() [core] - 10https://gerrit.wikimedia.org/r/478459 (owner: 10MaxSem) [03:18:51] (03Merged) 10jenkins-bot: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [03:19:50] (03CR) 10jenkins-bot: Hard deprecated SiteSQLStore::newInstance() [core] - 10https://gerrit.wikimedia.org/r/478459 (owner: 10MaxSem) [03:20:41] (03Merged) 10jenkins-bot: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [03:21:15] (03CR) 10jenkins-bot: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [03:23:06] (03CR) 10jenkins-bot: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [03:24:09] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 2 others: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Tgr) @Risker I had some time to look into self-unblock patterns. Interes... [03:28:33] (03PS1) 10Gergő Tisza: Improve readability of SpecialBlock::checkUnblockSelf [core] - 10https://gerrit.wikimedia.org/r/478578 [03:55:45] (03PS1) 10Gergő Tisza: Rename SpecialBlock::checkUnblockSelf to be more accurate [core] - 10https://gerrit.wikimedia.org/r/478579 [04:03:34] 10QRpedia-General: Page titles are being double-encoded - https://phabricator.wikimedia.org/T210050 (10Samwilson) @ErrantX do you have any update on this? [04:17:30] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Performance-Team (Radar): Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views - https://phabricator.wikimedia.org/T186062 (10Krinkle) I often audit mobile/desktop pages and analys... [04:34:33] 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAutoLogin delays fully load time - https://phabricator.wikimedia.org/T130935 (10Krinkle) [04:52:09] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Krinkle) [04:52:19] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Krinkle) [04:52:21] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance: Reduce calls to Special:CentralAutoLogin/checkLoggedIn - https://phabricator.wikimedia.org/T91196 (10Krinkle) [04:54:52] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Krinkle) >>! At T91196, @Nemo_bis wrote: > In an ideal world, unregistered users wouldn't... [04:55:09] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Krinkle) [04:55:11] 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAutoLogin delays fully load time - https://phabricator.wikimedia.org/T130935 (10Krinkle) [04:55:43] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-CentralAuth, 10Performance-Team: CentralAuth: Audit autologin procedure for performance and code quality - https://phabricator.wikimedia.org/T68828 (10Krinkle) [05:01:45] (03CR) 10Yaron Koren: "@Nikhil-nk - did you create a new patch for this?" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/462725 (owner: 10Nikhil-nk) [05:24:00] 10MediaWiki-extensions-CentralAuth, 10Security-Team: Beta Cluster login.wikimedia request blocked by CORS policy - https://phabricator.wikimedia.org/T211539 (10Krinkle) [05:24:19] 10MediaWiki-extensions-CentralAuth, 10Beta-Cluster-Infrastructure, 10Security-Team, 10Beta-Cluster-reproducible: Beta Cluster login.wikimedia request blocked by CORS policy - https://phabricator.wikimedia.org/T211539 (10Krinkle) [05:43:45] 10MediaWiki-API: allow to add section with no heading and custom edit summary - https://phabricator.wikimedia.org/T211540 (10Gryllida) [06:00:43] looks like i wouldn't be able to claim anything before the claim deadline T_T [06:08:31] Noi Bai International Airport [06:08:31] Wattay International Airport [06:08:32] Mandalay International Airport [06:08:32] Guwahati International Airport [06:08:32] Netaji Subhas Chandra Bose International Airport [06:08:45] (03PS1) 10Gergő Tisza: Rate limit blocks of admins [core] - 10https://gerrit.wikimedia.org/r/478581 (https://phabricator.wikimedia.org/T150826) [06:11:27] (03CR) 10Shreyasminocha: Refactor most of jQuery code to vanilla JS (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [06:11:39] NelsonHB: what happened? [06:21:29] (03CR) 10jerkins-bot: [V: 04-1] Rate limit blocks of admins [core] - 10https://gerrit.wikimedia.org/r/478581 (https://phabricator.wikimedia.org/T150826) (owner: 10Gergő Tisza) [06:26:24] Noi Bai International Airport [06:26:24] Wattay International Airport [06:26:24] Mandalay International Airport [06:26:25] Guwahati International Airport [06:26:25] Netaji Subhas Chandra Bose International Airport [06:26:25] Mactan–Cebu International Airport [06:29:39] :( [06:32:59] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Show reset option in the MT card only when the paragraph has been modified - https://phabricator.wikimedia.org/T196051 (10santhosh) a:03santhosh [06:34:45] (03PS2) 10Gergő Tisza: Rate limit blocks of admins [core] - 10https://gerrit.wikimedia.org/r/478581 (https://phabricator.wikimedia.org/T150826) [06:37:57] 10MediaWiki-extensions-FlaggedRevs, 10DBA, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Drop FlaggedRevs tables in database for srwikinews - https://phabricator.wikimedia.org/T209761 (10Marostegui) p:05Triage>03Normal @Zoranzoki21 can you confirm if this is good to go and if these are the tables that... [06:39:58] 10ContentTranslation: ContentTranslation creates erroneous tags in article text - https://phabricator.wikimedia.org/T211541 (10Effeietsanders) [06:50:36] 10MediaWiki-extensions-LoginNotify, 10Epic, 10User-Huji: LoginNotify should allow users to report malicious login attempts - https://phabricator.wikimedia.org/T188184 (10Tgr) Keep it simple, put an email address in there? Maybe with a pre-generated subject that contains a reference to some identifier (reques... [06:52:39] (03PS1) 10Amire80: Add "twice" instead of "2 times" in an English message [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478585 [06:58:44] 10MediaWiki-extensions-LoginNotify, 10Community-Tech: LoginNotify should expose the "is this an untrusted login?" check as a service - https://phabricator.wikimedia.org/T211542 (10Tgr) [07:00:10] 10ContentTranslation, 10Upstream: ContentTranslation creates erroneous tags in article text - https://phabricator.wikimedia.org/T211541 (10Amire80) Looks like it's related to Grammarly. If I'm right, then it's not the fault of Content Translation (CX) fault, and I don't think that CX can do anything about it.... [07:01:11] (03CR) 10Amire80: [C: 031] Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [07:05:54] (03PS1) 10Dvogel hallowelt: [WIP] Fix: Scroll to jumpmark [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 [07:07:51] 10MediaWiki-extensions-OATHAuth: Expand scratch code instruction with advice to mark which codes you have used - https://phabricator.wikimedia.org/T150868 (10Tgr) [07:07:53] 10MediaWiki-extensions-OATHAuth: Add option to generate new set of scratch codes - https://phabricator.wikimedia.org/T150601 (10Tgr) [07:07:55] 10MediaWiki-User-login-and-signup, 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Security: Force OATHAuth (2FA) for certain user groups in Wikimedia production - https://phabricator.wikimedia.org/T150898 (10Tgr) [07:07:57] 10MediaWiki-extensions-OATHAuth, 10Growth-Team, 10Notifications: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788 (10Tgr) [07:08:02] 10MediaWiki-extensions-OATHAuth, 10Security-team-backlog, 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Security: Allow all users on all wikis to use OATHAuth - https://phabricator.wikimedia.org/T166622 (10Tgr) [07:08:40] 10MediaWiki-extensions-OATHAuth, 10Trust-and-Safety, 10WMF-Legal, 10Security: Allow functionaries to reset second factor on low-risk accounts - https://phabricator.wikimedia.org/T180896 (10Tgr) [07:08:49] 10MediaWiki-extensions-OATHAuth, 10Security-team-backlog, 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Security: Allow all users on all wikis to use OATHAuth - https://phabricator.wikimedia.org/T166622 (10Tgr) [07:12:03] 10MediaWiki-extensions-OATHAuth, 10Security-team-backlog, 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Security: Allow all users on all wikis to use OATHAuth - https://phabricator.wikimedia.org/T166622 (10Tgr) This is not really blocked on forcing on anyone 2FA, so rearranged the dependency tree a bit. [07:14:17] 10MediaWiki-extensions-FlaggedRevs, 10DBA, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Drop FlaggedRevs tables in database for srwikinews - https://phabricator.wikimedia.org/T209761 (10Zoranzoki21) >>! In T209761#4809283, @Marostegui wrote: > @Zoranzoki21 can you confirm if this is good to go and if the... [07:14:48] 10MediaWiki-extensions-FlaggedRevs, 10DBA, 10Wikimedia-Site-requests, 10User-Zoranzoki21: Drop FlaggedRevs tables in database for srwikinews - https://phabricator.wikimedia.org/T209761 (10Marostegui) Thanks! [07:16:25] 10MediaWiki-extensions-OATHAuth, 10Stewards-and-global-tools, 10Trust-and-Safety, 10Patch-For-Review, 10Security: Be able to force OATHAuth for certain user groups - https://phabricator.wikimedia.org/T150562 (10Tgr) [07:16:46] 10ContentTranslation: CX2: "Pages with unreviewed translations" is added to all my articles - https://phabricator.wikimedia.org/T211543 (10Amire80) [07:17:23] 10MediaWiki-User-login-and-signup, 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Security: Force OATHAuth (2FA) for certain user groups in Wikimedia production - https://phabricator.wikimedia.org/T150898 (10Tgr) [07:17:29] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10CheckUser, 10Stewards-and-global-tools: Make users without 2FA setup not have checkuser right regardless of their groups - https://phabricator.wikimedia.org/T197501 (10Tgr) [07:18:03] 10ContentTranslation: CX2: "Pages with unreviewed translations" is added to all my articles - https://phabricator.wikimedia.org/T211543 (10KartikMistry) * guwiki example: https://gu.wikipedia.org/w/index.php?title=%E0%AA%AA%E0%AB%8D%E0%AA%B0%E0%AA%AC%E0%AA%B2%E0%AA%97%E0%AA%A2&type=revision&diff=644234&oldid=644... [07:19:08] 10MediaWiki-User-login-and-signup, 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Security: Force OATHAuth (2FA) for certain user groups in Wikimedia production - https://phabricator.wikimedia.org/T150898 (10Tgr) [07:24:28] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/478597 (owner: 10L10n-bot) [07:28:08] 10MediaWiki-Redirects: No redirect notice when redirect is a (user?) JS page with contentmodel "wikitext" - https://phabricator.wikimedia.org/T211066 (10Tgr) Works fine for me. I click on https://en.wikipedia.org/wiki/User_talk:Writ_Keeper/Scripts/commonHistory.js, I get a redirect notice. [07:28:16] 10MediaWiki-extensions-Translate: MW with translation extension (meta.wikimedia.org) sometimes fails to open proper section on [edit source] of section - https://phabricator.wikimedia.org/T211519 (10Nikerabbit) 05Open>03declined One of the headings was not tagged as instructed in the documentation. [07:48:07] (03CR) 10Pwirth: [C: 032] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478281 (owner: 10Umherirrender) [07:48:11] (03CR) 10Pwirth: [V: 032 C: 032] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478281 (owner: 10Umherirrender) [07:48:19] (03PS1) 10Pwirth: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478605 [07:48:24] (03CR) 10Pwirth: [V: 032 C: 032] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478605 (owner: 10Pwirth) [07:49:17] (03CR) 10jerkins-bot: [V: 04-1] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478605 (owner: 10Pwirth) [07:51:05] (03CR) 10jerkins-bot: [V: 04-1] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478281 (owner: 10Umherirrender) [07:51:16] (03CR) 10jerkins-bot: [V: 04-1] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478605 (owner: 10Pwirth) [07:54:58] (03PS1) 10Pwirth: Fix extension.sjon to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 [07:56:32] (03CR) 10jerkins-bot: [V: 04-1] Fix extension.sjon to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 (owner: 10Pwirth) [07:57:13] (03PS2) 10Pwirth: Fix extension.json to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 [07:59:53] (03CR) 10jerkins-bot: [V: 04-1] Fix extension.json to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 (owner: 10Pwirth) [08:05:49] (03PS3) 10Pwirth: Fix extension.json to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 [08:06:34] 10MediaWiki-Special-pages: Toggle links on Special:NewPages use wrong namespace - https://phabricator.wikimedia.org/T211549 (10Schnark) [08:08:27] 10ContentTranslation: CX2: "Pages with unreviewed translations" is added to all my articles - https://phabricator.wikimedia.org/T211543 (10Pginer-WMF) Is it possible that this is related to {T207913}? If user typed text is counted as MT for the purpose of the category this can be problematic here. @Amire80 and @... [08:08:34] (03CR) 10jerkins-bot: [V: 04-1] Fix extension.json to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 (owner: 10Pwirth) [08:08:42] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: "Pages with unreviewed translations" is added to all my articles - https://phabricator.wikimedia.org/T211543 (10Pginer-WMF) [08:09:53] Hello. Noticed that tgr rearranged a bit the task tree for T166622, but then a thing came to mind. Yet there are at least two identities - SUL and LDAP/Wikitech/labs, that support 2FA that are set up on-wiki and thus have recovery options (scratch codes), what comes with the Phabricator 2FA, that does not have backup codes? Given that all three 2FAs are set and the account is cross-linked [08:09:53] through Phab and on-wiki OAuths how that should be handled? I might be overlooking something, but I sense security concerns on this, particularly if one of the accounts gets compromised (stolen/misplaced phone) [08:09:54] T166622: Allow all users on all wikis to use OATHAuth - https://phabricator.wikimedia.org/T166622 [08:10:35] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Tgr) [08:11:15] (03PS1) 10Robert Vogel: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 [08:12:03] (03CR) 10jerkins-bot: [V: 04-1] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [08:19:33] (03CR) 10Legoktm: [C: 032] "I'll file follow-up tasks for the inline comments, none of them are blocker worthy." [vendor] - 10https://gerrit.wikimedia.org/r/477538 (https://phabricator.wikimedia.org/T202110) (owner: 10Reedy) [08:20:01] 10Language-Team (Language-2018-October-December): Language team's showcase for December 2018 - https://phabricator.wikimedia.org/T210488 (10Arrbee) 05Open>03Resolved [08:26:01] (03CR) 10Legoktm: Create GuzzleHttpRequest class as new default for HttpRequestFactory (033 comments) [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:31:08] (03PS7) 10Legoktm: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:31:28] (03CR) 10Legoktm: Create GuzzleHttpRequest class as new default for HttpRequestFactory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:32:04] (03Merged) 10jenkins-bot: Add guzzlehttp/guzzle 6.3.3 and dependancies [vendor] - 10https://gerrit.wikimedia.org/r/477538 (https://phabricator.wikimedia.org/T202110) (owner: 10Reedy) [08:32:56] Hey legoktm, if you have time, would you mind having a look at my task?: https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/GoogleLogin/+/478422/ [08:33:20] (03PS8) 10Legoktm: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:34:16] (03CR) 10jerkins-bot: [V: 04-1] Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:34:32] (03CR) 10jerkins-bot: [V: 04-1] Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:34:36] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Tgr) [08:35:05] (03PS4) 10Pwirth: Fix extension.json and remove random icon path from other extension to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 [08:36:05] (03CR) 10Legoktm: [C: 04-1] build: Replace jshint with eslint & stylelint (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [08:36:11] TheJair: left a comment [08:36:15] everything else looks right [08:36:24] legoktm: hi [08:36:25] thanks :) [08:36:32] hi shreyasminocha [08:36:50] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 2 others: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Bawolff) >>! In T150826#4808282, @Billinghurst wrote: > I tell you what... [08:37:11] (03PS9) 10Legoktm: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:38:27] (03PS2) 10Dvogel hallowelt: Fix: Scroll to jumpmark [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 [08:39:33] 10MediaWiki-General-or-Unknown: Figure out how to inject MediaWiki's mime mapping into Guzzle - https://phabricator.wikimedia.org/T211555 (10Legoktm) [08:39:53] (03CR) 10jerkins-bot: [V: 04-1] Fix extension.json and remove random icon path from other extension to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 (owner: 10Pwirth) [08:40:13] legoktm: what's the guzzle thing you've been working on for some days now? eli5? [08:40:34] guzzle is a PHP library that makes HTTP requests [08:41:01] aha [08:41:05] thanks [08:41:10] so we've been working on having MediaWiki use guzzle instead of our own HTTP code, which was less flexible and supported some less environments [08:41:25] :o [08:41:31] bpirkle did most (all really) of the work [08:41:44] nice [08:43:07] (03CR) 10Legoktm: [C: 031] "My changes:" [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [08:44:35] (03PS4) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [08:47:30] (03PS2) 10Pwirth: Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [08:47:46] 10MediaWiki-extensions-CollapsibleVector, 10TCB-Team, 10Multi-Content-Revisions (Reactive), 10Regression: Bad interaction between RevisionSlider and CollapsibleVector extension - https://phabricator.wikimedia.org/T211557 (10thiemowmde) [08:48:16] (03CR) 10jerkins-bot: [V: 04-1] Add proxy API module for Parsoid communication [extensions/BlueSpiceVisualEditorConnector] (REL1_31) - 10https://gerrit.wikimedia.org/r/478608 (owner: 10Robert Vogel) [08:49:09] Updated legoktm [08:52:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Thanks for the additional information!" (031 comment) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [08:52:53] (03PS1) 10Pboehm: Harmonizing naming of Special Page Title [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/478613 [08:53:50] (03PS1) 10Pwirth: Skip adding data attributes in unit test context to pass tests [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478614 [08:54:06] (03Abandoned) 10Pboehm: Harmonizing naming of Special Page Title [extensions/BlueSpiceConfigManager] (REL1_31) - 10https://gerrit.wikimedia.org/r/478613 (owner: 10Pboehm) [08:54:21] arseny92: probably worth writing that on a ticket somewhere [08:54:43] (03PS5) 10Pwirth: Fix extension.json and remove random icon path from other extension to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 [08:56:58] 10monitoring: rancid causes puppet to flap on netmon1002 - https://phabricator.wikimedia.org/T211459 (10fgiunchedi) I guess we should change puppet to create `configs` too and get rid of the placeholder [08:58:34] (03PS1) 10Pboehm: Harmonizing naming of Special Page Title [extensions/BlueSpiceConfigManager] - 10https://gerrit.wikimedia.org/r/478615 [08:58:49] 10WMSE-Riksarkivet-TORA: Lista med Litteraturbankens publicerade sidor - https://phabricator.wikimedia.org/T205398 (10Salgo60) [08:59:09] http://youmightnotneedjquery.com/#array_each [08:59:14] looks like it's pretty equivalent [08:59:35] (03CR) 10jerkins-bot: [V: 04-1] Fix extension.json and remove random icon path from other extension to pass tests [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478606 (owner: 10Pwirth) [08:59:44] $.each, i think it is [09:00:00] TheJair: the call signatures of $.each and array.forEach are swapped [09:00:14] $.each is index, value, while array.forEach is value, index [09:00:41] hot take: jquery has lost its relevance [09:01:16] (03CR) 10Catrope: [C: 032] Help Panel: Fix help panel question header [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478349 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:01:33] maybe, but jQuery has the best APIs I've ever seen in JavaScript [09:01:55] in what sense? [09:02:38] http://youmightnotneedjquery.com/#request [09:03:13] https://developer.mozilla.org/en-US/docs/Web/API/Fetch_API/Using_Fetch [09:03:25] not available in older browsers :) [09:03:34] :) [09:03:53] anyways, just reading through the You might not need page, you see the jQuery stuff on the left that looks simple, and then on the right side, it's some complicated mess of weirdly named functions [09:04:13] like $elem.before()'s DOM equivalent is elem.insertAdjacentHTML [09:04:24] I'll take before() any day [09:04:31] many parts of you might not need are outdated though, but i get your point [09:04:40] sorry, it's insertAdjacentHTML('beforebegin', ... ) [09:05:13] jQuery is nice, but a bit overused [09:05:27] and overused without justification [09:05:38] (03Merged) 10jenkins-bot: Help Panel: Fix help panel question header [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478349 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:05:48] /person has to make one API request [09:05:50] If you use 100 jequery function, go for it. If you need to hide one element than please don´t use jquery [09:06:02] /person downloads all of jquery [09:06:13] anyways, the new eslint-wikimedia-config has rules that prevent usage of jQuery functions where the native implementation is usable [09:06:17] e.g. $.each vs Array.forEach [09:06:20] that's nice to hear [09:06:21] Nice [09:06:39] bootstrap has a similar problem [09:06:57] (03CR) 10Legoktm: [C: 04-1] build: Replace jshint with eslint & stylelint (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [09:06:59] (03CR) 10Catrope: [C: 04-1] Help Panel: Add help panel tag (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478284 (https://phabricator.wikimedia.org/T211118) (owner: 10Kosta Harlan) [09:07:00] and i'm not pro-class-bloat [09:07:21] (03CR) 10jenkins-bot: Help Panel: Fix help panel question header [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478349 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:07:23] Btw, for all the GCI students: Today is the last day to claim tasks [09:07:28] (03CR) 10Catrope: [C: 04-1] "> Patch Set 1:" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478284 (https://phabricator.wikimedia.org/T211118) (owner: 10Kosta Harlan) [09:07:40] legoktm, not sure to which task that would belong to though [09:07:47] arseny92: me neither :) [09:07:56] anyways, it's always fun chatting with everyone [09:08:02] time to sleep though :(, gnite! [09:08:02] Nathan_fraignt: i'm still waiting on a review :D [09:08:12] might not get to claim anything before the deadline [09:08:12] Still the same review? [09:08:27] @bawolff [09:08:31] Oh wait nvm that was Takidelfin [09:08:34] Howdy [09:08:40] He was waiting for like 24h yesterday [09:08:44] Nathan_fraignt: yeah. he got his thankfully [09:08:50] what, no [09:08:53] Which one's are people waiting on review for? [09:09:07] Nathan_fraignt: takidelfin has some 30-33 iirc [09:09:18] 30-33 tasks? [09:09:18] bawolff: i'm waiting for a review on an update dependencies task [09:09:20] (03PS5) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [09:09:29] Nathan_fraignt: yes. i have 24 rn :/ [09:09:36] Nice [09:09:44] @bawolff : Please can you check https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FormWizard/+/475973/? [09:09:58] Kinda sad that we can´t see the tasks of other users anymore [09:10:00] "Nice"? says the one with more than double that [09:10:11] I think Arcayn has quite a lot [09:10:19] they do [09:10:23] Lol, 24 is more than most I think [09:10:33] You could probably look at what tasks people have assigned themselves in phab [09:10:40] Nathan_fraignt: yeah, that's there [09:10:42] pray for a hoodie xd [09:10:50] True, but i´ve done more phab tasks than GCI [09:11:02] bawolff: but many don't claim on phab [09:11:15] That´s not true, I´ve done tasks on phab that weren´t part of GCI [09:11:26] And I´ve done tasks on GCI that were not linked on phab [09:11:28] "many", not "all" or "Nathan" [09:11:35] same [09:12:07] Did you do all the LUA tasks? They´re quite easy (except 8 I think) [09:12:08] looks like I don't have access to a leaderboard either [09:12:30] I don´t think you would´ve been allowed to say it, even if you had access [09:12:39] Yeah I did all, will not be able to claim 9 though :/ [09:12:50] i did 6, never got around to doing 7 [09:12:51] 9 was the data one? [09:12:55] yeah [09:13:13] i did almost zero linting, add license fields, replace jslint etc tasks [09:13:28] I did ~10 linting tasks I think [09:13:43] bawolff: that's strange [09:13:44] eugene233: you have tested this right? [09:14:21] bawolff: Yes sure... [09:14:28] ok [09:14:36] Just checking because i can't test myself at the moment [09:14:49] (03CR) 10Brian Wolff: [C: 032] mw.notify needs to be i18n-ized [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/475973 (https://phabricator.wikimedia.org/T204659) (owner: 10Eugene233) [09:15:06] bawolff, can you see how many student's participated in the wikimedia tasks? [09:15:27] umm, it says 742 tasks completed [09:16:02] oh i'm not even signed [09:16:04] in [09:16:10] :D [09:16:10] So I guess i'm seeing the same as anyone else [09:16:14] yeah [09:16:17] (03CR) 10Catrope: [C: 031] "Looks good, but needs to be rebased to deal with conflicts" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) (owner: 10Kosta Harlan) [09:16:19] lol [09:16:42] am writing a blog post about gci 2018. there's too much to write about :/ [09:17:01] shreyasminocha: Consider getting your blog added to https://en.planet.wikimedia.org [09:17:04] shreyasminocha: 👍 [09:17:24] bawolff: sure [09:18:01] * bawolff wonders if anyone will take my last open task [09:18:15] (03CR) 10Legoktm: [C: 04-1] "Yeah, James basically explained my point. This is a functionally breaking change - something that used to work stopped working. And I thin" [core] - 10https://gerrit.wikimedia.org/r/478056 (owner: 10Tchanders) [09:18:29] (03PS9) 10Jdrewniak: Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [09:18:39] which one is it bawolff? [09:18:42] (03Merged) 10jenkins-bot: mw.notify needs to be i18n-ized [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/475973 (https://phabricator.wikimedia.org/T204659) (owner: 10Eugene233) [09:18:49] TheJair: 88 have done lua task 1, so at least 88 people [09:18:55] Which task bawolf? [09:19:03] I think its the rss one [09:19:07] Updated again legoktm, that swap is pretty confusing [09:19:30] I think I had a look at the rss, but I couldn't seem to find what the bug was xd [09:19:33] Hmm, there have been 8 more people to do the lua one than to do the irc one [09:19:50] That's just a sign I'm explaining the problem poorly :) [09:19:57] (03CR) 10Catrope: [C: 032] Help Panel: Button text, fix autopopulate, and simplify review panel (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:20:03] (03CR) 10jerkins-bot: [V: 04-1] Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:20:07] It looks like a php task, I´ve never worked with PHP before, sorry :/ [09:20:09] 10MobileFrontend, 10Growth-Team, 10Notifications: Notification links redirects to desktop site - https://phabricator.wikimedia.org/T211559 (10Force_Radical) [09:20:12] (03CR) 10Catrope: [C: 031] "Looks good, but needs conflict resolution" [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [09:20:20] (03CR) 10Jdrewniak: Pass isBorderbox and className properties as options (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [09:20:31] Nathan_fraignt: yes, it is a php one. And probably not exactly a "first" php task either [09:20:33] bawolff: i did have a look at it and thought "well maybe, if time permits" [09:20:38] :> [09:20:40] o/ [09:20:43] \o [09:20:47] o/ [09:20:49] good morning taki [09:21:01] Its that one https://codein.withgoogle.com/tasks/6561852751347712/ [09:21:16] yeah the fields, right? [09:21:18] yeah [09:21:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Looks good. I will merge this soon if there are no objections." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478585 (owner: 10Amire80) [09:21:31] yeah [09:21:35] (03CR) 10Catrope: [C: 032] Use VE focus/blur events for styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478499 (https://phabricator.wikimedia.org/T211515) (owner: 10Esanders) [09:21:48] but as of now i'm just hoping i get a review on my task before the claim deadline :D :/ [09:21:50] If anyone wants more tasks in a specific area, now is basically the last time to ask :) [09:22:31] (03CR) 10Nathan fraignt: i18n: Integrate common_settings.py LANGUAGES field with API (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [09:22:44] 10FormWizard, 10FormWizard-Gadget: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Eugene233) [09:22:45] 10FormWizard, 10FormWizard-Gadget, 10Patch-For-Review: mw.notify needs to be i18n-ized - https://phabricator.wikimedia.org/T204659 (10Eugene233) 05Open>03Resolved marking this as resolved. [09:23:13] bawolff, if you have some kind of python related task that doesn´t take too much time, I´ll do it [09:23:30] or JS related [09:23:35] Hmm. I don't think any of the stuff I work with is related to python [09:23:49] No problem [09:23:49] Other then the captcha stuff, and I can't think of a good way to make that into a task [09:23:52] (03PS1) 10PortalsBuilder: Assets build - 2018-12-10 09:23:51+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/478619 [09:23:58] ough [09:24:00] I'm dying [09:24:09] Anyways, I need to go to school [09:24:10] cya [09:24:15] \o [09:24:16] bye [09:24:17] bye [09:24:32] bawolff, the rss bug should be at action=feedwatchlist&feedformat=rss right? [09:24:52] TheJair: yes, but from api.php endpoint, not index.php [09:25:07] yeah I know, so you get to see the RSS feed [09:25:20] 10Google-Code-in-2018, 10MediaWiki-extensions-Newsletter, 10User-Zoranzoki21: "Register" newsletters instead of "Create" - https://phabricator.wikimedia.org/T154761 (10Zoranzoki21) a:03Zoranzoki21 [09:25:44] TheJair: so you are doing ` & ` task? [09:25:45] (03PS1) 10Zoranzoki21: Change strings to "Register" newsletters instead of "Create" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) [09:26:01] The page https://en.wikipedia.org/w/api.php?action=help&modules=feedwatchlist has the docs for all the parameteres [09:26:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/478414 (owner: 10Umherirrender) [09:26:51] takidelfin, if you want to do it go ahead because I still have tasks under review [09:26:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478415 (owner: 10Umherirrender) [09:27:05] (03CR) 10Urbanecm: [C: 04-1] i18n: Integrate common_settings.py LANGUAGES field with API (034 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [09:27:59] (03CR) 10jerkins-bot: [V: 04-1] Change strings to "Register" newsletters instead of "Create" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) (owner: 10Zoranzoki21) [09:28:20] (03CR) 10Urbanecm: [C: 04-1] i18n: Integrate common_settings.py LANGUAGES field with API (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [09:29:06] * Urbanecm waves to everyone [09:29:14] o/ [09:29:28] Oh i found a page on gci site that says wikimedia has 419 students [09:29:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478406 (owner: 10Umherirrender) [09:29:42] true [09:29:48] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478405 (owner: 10Umherirrender) [09:30:04] :o [09:30:05] and only 314 tasks [09:30:08] * Urbanecm waves to shreyasminocha too [09:30:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Remove unused .phpcs.xml [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/478359 (owner: 10Umherirrender) [09:30:16] * shreyasminocha waves back! [09:30:21] Hi Urbanecm [09:30:25] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 19.1.0 [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/478352 (owner: 10Umherirrender) [09:30:27] Hi TheJair [09:30:34] * takidelfin waves down [09:30:39] (03PS2) 10Zoranzoki21: Change strings to "Register" newsletters instead of "Create" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) [09:31:04] Urbanecm: thank you for the review, ... that was the only way that I found to overrride LANGCODE from user session properly :( [09:31:18] yw [09:31:22] takidelfin looks funny waving down, almost as if he's scrubbing the floor [09:31:29] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 19.1.0 [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/478353 (owner: 10Umherirrender) [09:31:51] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [extensions/ORES] - 10https://gerrit.wikimedia.org/r/478409 (owner: 10Umherirrender) [09:31:57] I was trying to do it using Accept-Language header, but it required 'blank' GET, without cookies or session cache [09:32:18] takidelfin, per the docs, i. [09:32:28] t should affect only the active thread [09:32:42] so the rest of Tracker will remain in the user's language, whatever it is [09:32:54] (03CR) 10jerkins-bot: [V: 04-1] Change strings to "Register" newsletters instead of "Create" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) (owner: 10Zoranzoki21) [09:33:27] bawolff, don't think it's your fault I don't understand the problem. I can't even find the guid and link themselves [09:34:09] TheJair: If you're testing it on english wikipedia, you should first add a bunch of random recently edited pages to your watchlist [09:34:50] No I'm testing on my own instance. Moved and protected some pages [09:35:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Use english for log text in AuthManagerSpecialPage [core] - 10https://gerrit.wikimedia.org/r/478471 (owner: 10Umherirrender) [09:35:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 (owner: 10Umherirrender) [09:35:53] (03Merged) 10jenkins-bot: Use VE focus/blur events for styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478499 (https://phabricator.wikimedia.org/T211515) (owner: 10Esanders) [09:36:39] Are you seeing any pages on your watchlist? [09:37:03] Yeah a couple [09:37:05] The and will only show up if it has the feed=rss in the url (it doesn't show up if the feed is in atom format) [09:37:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Not used anywhere else according to https://codesearch.wmflabs.org/search/?q=CreditsSource_swsite&i=1" [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/478413 (owner: 10Umherirrender) [09:37:36] Did the change occur due to a recent update? [09:37:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update sniff list in .phpcs.xml [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478404 (owner: 10Umherirrender) [09:37:48] afaik, this code hasn't changed in years [09:37:52] yeah I have feed=rss [09:38:00] On another topic, I totally just found the leaderboard in google code in [09:38:08] haha [09:38:12] :D [09:38:23] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Update Youdao MT client to new API - https://phabricator.wikimedia.org/T210578 (10Pginer-WMF) 05Open>03Resolved [09:38:56] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10Tracking: Language tools maintenance intervention: Improve the quality of translations for Translate extension - https://phabricator.wikimedia.org/T204818 (10Pginer-WMF) [09:38:58] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Microsoft Translator not working with new authorisation model - https://phabricator.wikimedia.org/T46679 (10Pginer-WMF) 05Open>03Resolved [09:40:30] (03CR) 10Thiemo Kreuz (WMDE): build: Remove unused mediawiki/mediawiki-codesniffer (031 comment) [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 (owner: 10Umherirrender) [09:40:53] This is so annoying, I don't see any s just divs and a's and h3's. And I can even subscribe to the feed [09:41:23] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/478414 (owner: 10Umherirrender) [09:41:25] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478415 (owner: 10Umherirrender) [09:42:29] (03CR) 10jenkins-bot: Use VE focus/blur events for styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478499 (https://phabricator.wikimedia.org/T211515) (owner: 10Esanders) [09:42:41] TheJair: Maybe you are viewing a rendered version. Did you try view source directly (i.e. not the developer console) [09:43:29] TheJair: If you go to view-source:https://www.mediawiki.org/w/api.php?action=feedwatchlist&allrev=1&wlowner=Bawolff&wltoken=dc1ce785eeff31ecaba80cab334df48686bd0b27&feedformat=rss do you see the tag? [09:43:54] Oh finally, wasn't working on firefox [09:44:05] you are right [09:46:13] So i don't see anything in the contest rules to say who is leading the leaderboard [09:46:18] is not allowed [09:46:48] 10Timeless: Printing pages with tables in Timeless-skin gives different result than printing in Vector-skin - https://phabricator.wikimedia.org/T211564 (10Dannymarly) [09:46:58] me neither :p [09:47:30] arcayn/nathan, i'm pretty sure [09:47:40] probably the latter [09:47:48] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478406 (owner: 10Umherirrender) [09:47:50] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478405 (owner: 10Umherirrender) [09:47:53] (03Merged) 10jenkins-bot: build: Remove unused .phpcs.xml [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/478359 (owner: 10Umherirrender) [09:47:56] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 19.1.0 [extensions/LDAPProvider] - 10https://gerrit.wikimedia.org/r/478352 (owner: 10Umherirrender) [09:47:57] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 19.1.0 [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/478353 (owner: 10Umherirrender) [09:47:59] There are rules we aren't allowed to say who is a finalist [09:48:29] but you are allowed to say who the winner is :D :P [09:48:33] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478415 (owner: 10Umherirrender) [09:48:38] anyhow, Nathan has currently completed the most number of tasks [09:48:51] (03CR) 10Jdrewniak: "recheck" [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/478619 (owner: 10PortalsBuilder) [09:48:52] Well number of tasks doesn't neccesarily translate to actual winner of contest [09:49:09] As long as you are in the top 20, you are eligable to be the "Winner" [09:49:50] The finalists and winners from last year are displayed on the GCI website [09:50:07] yeah, we just arent allowed to say prior to google's big announcement [09:50:13] ah yeah [09:50:16] these guys decide by the 27th [09:50:20] announced on the 7th [09:50:21] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/478414 (owner: 10Umherirrender) [09:50:38] yup [09:51:07] Nathan ~ 54 tasks [09:51:15] more than 1 / day on avg [09:51:23] shreyasminocha: You are right. Nathan is number 1, arcaynia is number 2 currently :P [09:51:30] * Urbanecm is wondering how does takidelfin know it :) [09:51:34] :D [09:51:53] asking lol [09:51:56] * takidelfin ヾ(⌐■_■)ノ♪ [09:51:58] takidelfin doesn't quite have the right number [09:52:17] Nathan has only completed 52 [09:52:24] "only" [09:52:26] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478405 (owner: 10Umherirrender) [09:52:28] "only" [09:52:29] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/ORES] - 10https://gerrit.wikimedia.org/r/478409 (owner: 10Umherirrender) [09:52:32] bawolff, fyi, takidelfin spotted an exploit in the GCI system (reported to Google and Google fixed it), that's why I'm asking [09:52:33] If only we had more time [09:52:43] Now it was social hacking :D [09:52:45] That's cool :) [09:53:06] 10CirrusSearch, 10Discovery-Search (Current work): Huge drop in search CTR as of Nov 30 2018 - https://phabricator.wikimedia.org/T211306 (10dcausse) I think it's due to [[ https://analytics.wikimedia.org/datasets/discovery/metrics/search/ | mobile_session_counts.tsv ]] not being updated. Trying to debug I foun... [09:53:25] Anyways, safe to say Nathan has quite a big lead [09:53:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-2] "Oh dear. This is going waaayyy to far, I'm afraid." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) (owner: 10Zoranzoki21) [09:53:54] anyway, once you're in top 20, number of tasks doesn't matter much [09:54:29] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/ORES] - 10https://gerrit.wikimedia.org/r/478409 (owner: 10Umherirrender) [09:54:46] * takidelfin hides. [09:55:20] * shreyasminocha hides too. [09:55:26] Which basically means as long as you have done 9 tasks you are good :) [09:55:37] :D [09:55:37] wololo [09:55:44] yeah [09:55:46] at least we all get a t-shirt :D [09:55:57] ^ [09:56:01] at least your work will be reviewed by the org [09:56:07] takidelfin: you are third currently, so you have nothing to worry about :P [09:56:08] ^^^ [09:56:16] :O [09:56:16] TheJair, you get an T-Shirt with 3+, I think [09:56:24] yeah :P [09:56:25] I know haha [09:56:58] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478406 (owner: 10Umherirrender) [09:57:11] _refeed_: hi, join the party [09:57:35] * Urbanecm waves to _refeed_ [09:57:39] (03PS4) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [09:57:44] _refeed_: o/ [09:57:52] <_refeed_> hi shreyasminocha, Urbanecm, takidelfin :D [09:58:34] (03CR) 10jerkins-bot: [V: 04-1] i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [09:58:42] :< [09:59:45] o/ [10:00:01] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Bawolff) using mb_strlen instead of strlen would probably get us 60% of the way to something reasonable. An alternative view would be, maybe using non-ascii characters that are... [10:00:04] Hi refeed [10:00:30] refeed: o/ [10:00:40] (03PS5) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [10:00:53] hi TheJair [10:00:55] wikibugs: you are too late now [10:01:05] (03CR) 10Pwirth: [C: 032] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] - 10https://gerrit.wikimedia.org/r/478357 (owner: 10Umherirrender) [10:01:18] * refeed is going to be afk in some minutes [10:01:29] (03PS1) 10Pwirth: build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 [10:01:31] (03CR) 10Pwirth: [C: 032] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:01:41] D: [10:01:49] (03CR) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API (036 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [10:01:59] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:02:06] Urbanecm: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478576 :D [10:02:15] 10MediaWiki-extensions-OAuth, 10Wikibase-Containers, 10Wikidata, 10Wikidata-Campsite: Create Maintentance Script(s) to produce OAuth Consumers - https://phabricator.wikimedia.org/T211568 (10Tarrow) p:05Triage>03Normal [10:03:52] `(pyenv) taki@desktop:~/dev/tracker$ git pull` [10:03:52] `Already up to date.` [10:04:03] Urbanecm: It is first time for me when nothing changed in Tracker master [10:04:04] branch [10:04:07] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [10:04:16] :) takidelfin [10:04:18] let me review it [10:04:23] ^-^ [10:04:43] (03CR) 10Pwirth: [C: 032] "recheck" [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:04:45] Nathan_fraignt is dormant with tracker looks like :D [10:05:24] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:05:30] https://usercontent.irccloud-cdn.com/file/YIAJiTCM/screenshot_20181210_110524.png [10:06:04] (03Merged) 10jenkins-bot: Use english for log text in AuthManagerSpecialPage [core] - 10https://gerrit.wikimedia.org/r/478471 (owner: 10Umherirrender) [10:06:05] takidelfin: which app is that? Postman? [10:06:09] (03Merged) 10jenkins-bot: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 (owner: 10Umherirrender) [10:06:10] Insonomnia [10:06:11] (03Merged) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478404 (owner: 10Umherirrender) [10:06:15] (03Merged) 10jenkins-bot: build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] - 10https://gerrit.wikimedia.org/r/478357 (owner: 10Umherirrender) [10:06:17] https://insomnia.rest/ [10:06:30] ooh, heard of that one [10:06:38] it's electron-based iirc? [10:06:38] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Bawolff) The internet also claims grapheme_strlen is a thing - https://secure.php.net/manual/en/function.grapheme-strlen.php but it didn't seem to work when i tested locally... [10:06:52] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:07:02] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Tgr) The SecLists [[https://github.com/danielmiessler/SecLists/blob/master/Passwords/Common-Credentials/10-million-password-list-top-1000000.txt|top million file] only contains... [10:07:13] https://usercontent.irccloud-cdn.com/file/gzOLOwOG/screenshot_20181210_110707.png [10:07:25] shreyasminocha: This is where I discovered that bug in Google's API [10:07:35] niiice [10:08:17] (03CR) 10jenkins-bot: Use english for log text in AuthManagerSpecialPage [core] - 10https://gerrit.wikimedia.org/r/478471 (owner: 10Umherirrender) [10:09:33] (03CR) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [10:09:41] 10Wikimedia-Site-requests: Add a localised logo for the Chewa Wikipedia - https://phabricator.wikimedia.org/T211570 (10tomasz) [10:09:44] (03CR) 10jenkins-bot: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 (owner: 10Umherirrender) [10:10:05] 10MediaWiki-User-login-and-signup: Password length check should count unicode characters - https://phabricator.wikimedia.org/T211550 (10Tgr) The other issue is that users understand characters better than bytes. But I guess as long as any discrepancies with the stated rule are on the permissive side, that's not... [10:10:15] (03CR) 10jenkins-bot: build: Update sniff list in .phpcs.xml [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478404 (owner: 10Umherirrender) [10:10:26] 10Wikimedia-Site-requests: Add a localised logo for the Chewa Wikipedia - https://phabricator.wikimedia.org/T211570 (10tomasz) [10:10:33] 10Google-Code-in-2018, 10Wikimedia-Site-requests, 10Goal, 10Patch-For-Review, and 2 others: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 (10tomasz) [10:10:37] 10Wikimedia-Site-requests: Add a localised logo for the Chewa Wikipedia - https://phabricator.wikimedia.org/T211570 (10tomasz) p:05Triage>03Low [10:13:23] 10Google-Code-in-2018, 10Wikimedia-Site-requests, 10Goal, 10Patch-For-Review, and 2 others: Provide HD logos for all projects - https://phabricator.wikimedia.org/T150618 (10tomasz) [10:14:38] 10Wikimedia-Site-requests: Add a localised logo for the Chewa Wikipedia - https://phabricator.wikimedia.org/T211570 (10Krishna_Chaitanya_Velaga) @tomasz Please provide transliteration for "Wikipedia" and translation for "The Free Encyclopedia" [10:15:45] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (... [10:15:48] 10TWLCon-2019-India: Survey from participants - https://phabricator.wikimedia.org/T210254 (10Krishna_Chaitanya_Velaga) 05Open>03Invalid [10:15:57] (03PS1) 10Jdrewniak: Hygiene: move pageList.less to reflect src/mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478627 (https://phabricator.wikimedia.org/T208921) [10:16:11] 10TWLCon-2019-India: Pre-event work Follow Up: Set 2 - https://phabricator.wikimedia.org/T210244 (10Krishna_Chaitanya_Velaga) [10:16:19] 10TWLCon-2019-India: Pre-event work Follow Up: Set 1 - https://phabricator.wikimedia.org/T210243 (10Krishna_Chaitanya_Velaga) [10:18:03] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (... [10:18:12] 10TWLCon-2019-India: Pre-event work Follow Up: Set 2 - https://phabricator.wikimedia.org/T210244 (10Krishna_Chaitanya_Velaga) a:03ManavpreetKaur [10:18:47] * bawolff should go to bed [10:18:54] gn bawolff [10:18:54] Its like 3 am [10:18:57] lol [10:19:03] 10TWLCon-2019-India: Pre-event work Follow Up: Set 1 - https://phabricator.wikimedia.org/T210243 (10Krishna_Chaitanya_Velaga) a:03Shypoetess [10:19:04] * shreyasminocha has had nights like those [10:19:46] 10TWLCon-2019-India: Pre-event work Follow Up: Set 1 - https://phabricator.wikimedia.org/T210243 (10Krishna_Chaitanya_Velaga) [10:19:52] Apparently I have a meeting scheduled for 8 am tomorrow [10:19:55] 10Prod-Kubernetes (Experiment): Kubernetes TODO List - https://phabricator.wikimedia.org/T149085 (10fselles) a:03fselles [10:19:57] 10TWLCon-2019-India: Pre-event work Follow Up: Set 2 - https://phabricator.wikimedia.org/T210244 (10Krishna_Chaitanya_Velaga) [10:20:15] bawolff, is it okay if I claim the rss tasks if I can't claim it on GCI? [10:20:27] This is why you should never check your calendar before you go to bed. I no longer have plausible deniability [10:20:34] :') [10:20:37] lawl [10:20:54] that feeling's real [10:21:00] 10TWLCon-2019-India: Create a list of tasks - https://phabricator.wikimedia.org/T210240 (10Krishna_Chaitanya_Velaga) 05Open>03Resolved [10:21:07] andre__: hello [10:21:08] 10Prod-Kubernetes (Experiment): Kubernetes TODO List - https://phabricator.wikimedia.org/T149085 (10fselles) i will split and expand this task a little bit and try to draw an small roadmap of features. There are things over that list that should be tasks in the backlog of this project while others should be disc... [10:21:15] Hi andre__ [10:21:22] andre__: hi [10:21:30] TheJair: Umm, maybe you should wait until after the deadline for claiming a task is over [10:21:35] I'm not sure [10:21:42] alright then [10:21:46] 10TWLCon-2019-India: Publish the final list on Meta-Wiki - https://phabricator.wikimedia.org/T210248 (10Krishna_Chaitanya_Velaga) 05Open>03Resolved [10:21:48] TheJair: I think you can't [10:21:51] yeah, even i'm waiting for a review [10:21:58] andre__ should know for sure if that's cool or not [10:22:01] https://codein.withgoogle.com/student-terms/ [10:22:05] (03PS19) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [10:22:17] 4.2.a [10:22:20] well it get's a bit messed up if I claim it on phabricator but somebody else claims it on GCI [10:22:27] yup [10:22:49] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) s8 eqiad progress [] labsdb1011 [] labsdb1010 [] labsdb1009 [] dbstore1002 [] db1124 [] db1116 [] db1109 [] db1104... [10:23:04] my suggestion (from experience of submitting a task (with unlimited instances even) on phabricator without claiming it): avoid [10:24:26] Anyways, claim task deadline is in 7 hours, so you don't have long to wait [10:24:52] yeah, gotta learn for my test week anyway [10:26:07] (03CR) 10Jdrewniak: [C: 032] Assets build - 2018-12-10 09:23:51+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/478619 (owner: 10PortalsBuilder) [10:26:07] andre__: Umm, I would want to ask you something. What will happen to integration/config/zuul/config.yml GCI Students section? Will you remove us (students) from Jenkins whitelist? :( [10:27:00] (03CR) 10Pwirth: "I had i mind, that the codesniffer test is required to be passed for commits." [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 (owner: 10Umherirrender) [10:27:02] (03Merged) 10jenkins-bot: Assets build - 2018-12-10 09:23:51+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/478619 (owner: 10PortalsBuilder) [10:27:39] (03CR) 10Pwirth: [C: 032] "recheck" [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:27:52] (03CR) 10Aklapper: "Sorry, Zoran! This is entirely my fault as, if I remember correctly, I incorrectly added a file path to the task on the GCI website..." [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [10:28:07] takidelfin, I don't think so, that whitelist was mostly to prevent malicious intent right? [10:28:23] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:28:25] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:28:34] But there are only ~ 16 students... so they probably erease it :( [10:28:34] the whitelist doesn't quite prevent malicious intent [10:28:37] they don't [10:28:41] ye/ [10:28:42] ? [10:28:47] there were students from previous years too [10:28:55] ;-; [10:29:16] Yay [10:29:42] (03Abandoned) 10Pwirth: build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceQrCode] (REL1_31) - 10https://gerrit.wikimedia.org/r/478624 (owner: 10Pwirth) [10:29:49] ~o~ [10:30:07] Yep. Now we force all the malicious people to sign up and solve some gci tasks [10:30:31] wow [10:30:34] takidelfin, I don't think so. :) [10:30:34] https://xkcd.com/810/ [10:30:37] TheJair: when i pre-submitted my task, étienne got pissed about it because of the rule that prevents students from working on two tasks at a time [10:30:48] bawolff: lol [10:30:49] (03CR) 10Urbanecm: i18n: Integrate common_settings.py LANGUAGES field with API (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [10:30:58] takidelfin, replied to your comment [10:31:03] * bawolff needs to watch his sarcasm levels :P [10:31:05] takidelfin: We'll send you a letter that you have to sign which says that you will always be good and behave, though. (just kidding) [10:31:16] lol [10:31:27] lol [10:31:37] Realistically, the list is mostly to prevent drive by attacks. Its very easy to get on the whitelist, so its not prevented anyone actually motivated [10:31:41] I guess [10:31:43] are signatures are technically invalid though [10:31:48] in courts of law :D [10:31:56] I'm not really sure what the threat model actually is [10:32:09] hmm [10:32:40] bawolff: so I need to raise down my level too :D [10:32:54] :D [10:33:02] (03CR) 10Zoranzoki21: "I am sorry for making mistake. I done this here because of file path which was in task. Path was for this repository, so I done this here." [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [10:33:19] you know, all the drive by script-kiddies using zero-day sandbox escape exploits ;) [10:33:26] :D [10:33:48] you've had those? [10:33:49] ̿̿ ̿̿ ̿̿ ̿'̿'\̵͇̿̿\з= ( ▀ ͜͞ʖ▀) =ε/̵͇̿̿/’̿’̿ ̿ ̿̿ ̿̿ ̿̿ [10:34:03] we've had those? [10:34:04] * takidelfin saw `exploit` [10:34:05] I guess it would help with the case, of major exploit discovered, and theres a delay in time it takes us to patch [10:34:08] shreyasminocha: no [10:34:26] Just thinking hypothetically what the whitelist would prevent [10:35:15] heh [10:35:34] As far as I am aware, nobody has ever attempted to use malicious code to attack the jenkins slaves. [10:36:37] hmm [10:36:52] When people try to attack wikipedia, the most common thing is trying to compromise accounts that use the same password on multiple websites [10:36:58] (03CR) 10Pwirth: [C: 04-1] Fix: Scroll to jumpmark (033 comments) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 (owner: 10Dvogel hallowelt) [10:37:37] `attack wikipedia` what a poor creatures (I mean attackers) [10:37:46] bawolff: naturally [10:38:17] It depends also on where you draw the line between "vandalism" and "attack", of course [10:38:43] ^^^ [10:39:01] ^-^ [10:39:38] http://www.meatballwiki.org/wiki/SoftSecurity is an interesting read if you've never seen it before [10:39:52] bawolff, vandalism is abusing a permission ('edit' or 'createpage' usually) you already have [10:39:59] an attack is gaining a permission you don't have [10:40:08] * refeed thought we were talking about https://www.reddit.com/r/netsec/comments/a4twqs/jenkins_code_execution_through_crafted_urls/ [10:40:13] at least that's what I think [10:40:22] you might have different POV :) [10:40:53] I usually draw the line somewhere around - vandalism is using the system as designed, an attack is abusing the system in a way that can't be easily handled on wiki [10:41:06] uh [10:41:24] `True` [10:41:26] e.g. if someone found a bug in editing that was hard to revert, I would call it an attack, even if they were only using rights they legitimately have [10:41:53] well, creating an edit that's hard to revert is effectively a protect = a right normal user don't have usually [10:42:01] *a protection [10:45:09] refeed: The usual threat scenario that the whitelist is thinking about is more to do with the fact that phpunit tests run actual code, so there's a worry that someone could upload a changeset with malicious code that could break out of sandboxing [10:45:32] The rather scary recent jenkins vulns aren't really prevented by the whitelist [10:46:32] bawolff: what's the time there? :D [10:46:47] 10CheckUser, 10Security: Special:CheckUserLog is accessible while a user with checkuser-log right is blocked - https://phabricator.wikimedia.org/T209585 (10Bawolff) [10:46:48] It is now 3:46 AM [10:46:57] 👌 [10:47:16] (03CR) 10Zoranzoki21: "> Oh dear. This is going waaayyy to far, I'm afraid." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) (owner: 10Zoranzoki21) [10:48:38] * bawolff did like almost none of my goals for last week [10:48:59] * takidelfin did not complete 40 tasks as he wanted [10:49:18] 6 hours left I will try my best tho [10:49:58] bawolff, was one goal go to bed early? :p [10:50:17] lol [10:50:18] Ah no, I gave up on that long ago [10:50:38] (03PS6) 10Takidelfin: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 [10:51:42] Jenkins bot +2 [10:51:47] hha, wikibugs you lost again [10:51:52] Urbanecm: done! Could you review it? [10:51:56] https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478576 [10:51:59] yup [10:53:44] (03CR) 10Urbanecm: [C: 032] i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [10:53:52] LGTM, +2'ed takidelfin [10:53:56] :D [10:53:59] thanks [10:54:08] yw [10:54:41] that was one of the hardest things for me - Django + Django Rest haste mode learning... lol [10:54:44] (03Merged) 10jenkins-bot: i18n: Integrate common_settings.py LANGUAGES field with API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478576 (owner: 10Takidelfin) [10:55:08] but you managed to do it, that's great! [10:55:26] * Urbanecm is deploying the change [10:55:29] thanks to your and ebe123 help :D [10:56:25] Ebe123 helped, that's nice :) [10:59:33] and now - resolving merge conflicts, this is what I love the most [11:00:05] hmm [11:01:02] Urbanecm: umm, I must rely on Bjornskjalds jQuery change, and now I must rely on master too... so I should reabse Bjornskjald's patch? [11:01:29] you can :) [11:01:32] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478635 [11:01:37] gtg, see you later [11:01:43] \o [11:05:33] * bawolff actually does go to bed [11:05:43] lol [11:05:46] bye bawolff [11:05:51] gn [11:06:05] gn [11:06:52] goodnight! [11:07:50] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Tamil Wikipedia to try version 2 - https://phabricator.wikimedia.org/T211572 (10Pginer-WMF) p:05Triage>03Normal [11:08:36] btw, is there any documentation that explains about wm projects logo size (e.g. Wikisource logo should be in 123x154px, Wiktionary should be 135x135px, etc)? [11:08:54] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478636 [11:09:00] (03PS4) 10Takidelfin: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [11:09:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-2] "In the file ….alias.php the right side is an array. It can contain more than one entry. The first is the preferred name of the special pag" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478620 (https://phabricator.wikimedia.org/T154761) (owner: 10Zoranzoki21) [11:09:58] (03CR) 10jerkins-bot: [V: 04-1] Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [11:10:13] refeed, as far as I know not. If there is already a current logo I think it should be the same size [11:10:25] actually, not nvm [11:10:27] *nvm [11:11:06] it isn't standardized, no [11:11:09] (03PS5) 10Takidelfin: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [11:11:11] TheJair, yes I'm using that method to figure out the size currently :D [11:11:19] shreyasminocha: I need to do these logo tasks too :D [11:11:31] idk, I think there should be an official documentation about it somewhere? [11:11:40] :D i've done only one, okay? don't look at me like that :D [11:12:10] (03CR) 10jerkins-bot: [V: 04-1] Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [11:12:11] refeed: you could create it? :) [11:13:14] 10Wikimedia-maintenance-script-run: Blank out remaining rev_comment fields on Wikimedia wikis - https://phabricator.wikimedia.org/T210935 (10Aklapper) Which existing maintenance script is required to run for this? [11:13:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478636 (owner: 10VolkerE) [11:14:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478635 (owner: 10VolkerE) [11:15:03] shreyasminocha: yes, sure, until I know what is the standardized size used here ;) [11:15:42] since there are some inconsistencies, like zhwiktionary uses 135x150 but zuwiktionary uses 135x128 [11:15:42] according to the task you have to check the current logo to find out [11:15:59] ¯\_(ツ)_/¯ i guess you could open a ticket to standardize them [11:16:18] or at least proposing to standardize them [11:16:34] (03PS6) 10Takidelfin: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [11:17:54] yeass [11:17:58] Jenkins +2'ed [11:18:01] 10MediaWiki-extensions-WikimediaBadges, 10Wikidata, 10Wikisource, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: Uses P629 (edition of) to add Wikipedia link in the other projects sidebar of Wikisource - https://phabricator.wikimedia.org/T180303 (10Lydia_Pintscher) Is there anything left to do... [11:18:07] good idea, I think it should be placed somewhere related to wikitech [11:18:21] *relating [11:18:22] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Adjust translation card to work better regardless of translation service availability - https://phabricator.wikimedia.org/T209606 (10santhosh) a:03santhosh [11:18:22] * takidelfin shrugs [11:18:35] 10Wikidata-Termbox-Iteration-5: Fix 404 detection in production build - https://phabricator.wikimedia.org/T211573 (10Pablo-WMDE) [11:18:40] * refeed wonders if there's #wikitech [11:19:03] ?? [11:19:16] #wikimedia-tech [11:19:27] refeed: #wikimedia-dev [11:19:30] *tch [11:19:32] eh [11:19:37] #wikimedia-tech [11:19:42] lol [11:20:14] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478636 (owner: 10VolkerE) [11:20:16] takidelfin, okay, thanks [11:23:08] iirc there are some mentions on meta:Logo pages and at wmf: [11:24:19] (03CR) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478636 (owner: 10VolkerE) [11:26:20] 10MediaWiki-User-login-and-signup, 10Anti-Harassment (AHT Sprint 35): Change password length requirement and ensure enforcement - https://phabricator.wikimedia.org/T208246 (10Tgr) >>! In T208246#4806016, @JBennett wrote: > There is a supporting blog post/Security awareness piece coming out with this announceme... [11:29:25] (03PS2) 10Pwirth: build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478358 (owner: 10Umherirrender) [11:30:56] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/475782 (owner: 10Pwirth) [11:31:27] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Adjust translation card to work better regardless of translation service availability - https://phabricator.wikimedia.org/T209606 (10santhosh) Screenshot: {F27473132 size=full} [11:31:29] 10MediaWiki-API: allow to add section with no heading and custom edit summary - https://phabricator.wikimedia.org/T211540 (10Aklapper) Thanks for structuring your task! Which specific API call with which parameters have you tried which comes closest? Probably something on https://www.mediawiki.org/wiki/API:Edit... [11:32:10] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Misleading error message for adding an image statement for incomplete filenames - https://phabricator.wikimedia.org/T199420 (10Lydia_Pintscher) 05Open>03Resolved \o/ [11:32:47] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Adjust translation card to work better regardless of translation service availability - https://phabricator.wikimedia.org/T209606 (10santhosh) @Pginer-WMF I linked the "Why?" text to https://www.mediawiki.org/wik... [11:32:50] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478635 (owner: 10VolkerE) [11:34:44] (03CR) 10jerkins-bot: [V: 04-1] build: Add grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceVisualEditorConnector] - 10https://gerrit.wikimedia.org/r/478358 (owner: 10Umherirrender) [11:35:18] (03CR) 10jerkins-bot: [V: 04-1] Add registration date column to UserManager. ERM:12999 [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/475782 (owner: 10Pwirth) [11:37:05] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Adjust translation card to work better regardless of translation service availability - https://phabricator.wikimedia.org/T209606 (10Pginer-WMF) >>! In T209606#4810031, @santhosh wrote: > @Pginer-WMF I linked the... [11:38:18] arseny92, yes, I just checked that page, but still don't find the thing that I'm looking for [11:39:46] refeed: ? [11:39:53] Maybe I will be able to help you [11:40:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Increase length limit for external identifier, string and URL datatype - https://phabricator.wikimedia.org/T154660 (10Lydia_Pintscher) We are seemingly not checking the length lim... [11:40:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Increase length limit for external identifier, string and URL datatype - https://phabricator.wikimedia.org/T154660 (10Lydia_Pintscher) p:05Low>03High [11:40:52] 10MediaWiki-extensions-Translate, 10Discovery, 10Discovery-Search, 10Elasticsearch, and 3 others: TTMServer performance and coverage issues - https://phabricator.wikimedia.org/T101236 (10Pginer-WMF) [11:41:37] takidelfin, hi. I'm talking about this "btw, is there any documentation that explains about wm projects logo size (e.g. Wikisource logo should be in 123x154px, Wiktionary should be 135x135px, etc)?" [11:41:51] ah [11:44:08] wow, Urbanecm deployed my API change [11:44:09] * takidelfin https://tracker.wikimedia.cz/api/tracker/languages/?lang=cs&format=json [11:44:18] 👌 [11:49:53] * refeed thought "👌" was a fire emoji [11:51:03] takidelfin, cool [11:51:06] 10IPv6: Enable IPv6 on tools.wmflabs.org - https://phabricator.wikimedia.org/T211575 (10Nikki) [11:55:14] refeed: i've got that earlier too [11:55:16] :D [11:55:26] (03PS1) 10Thiemo Kreuz (WMDE): Add missing test cases for code in Cite::refArg [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478645 (https://phabricator.wikimedia.org/T211576) [11:55:38] (03PS3) 10Dvogel hallowelt: Fix: Scroll to jumpmark [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 [12:01:19] (03CR) 10Pwirth: [C: 04-1] Fix: Scroll to jumpmark (031 comment) [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 (owner: 10Dvogel hallowelt) [12:04:10] shreyasminocha, what "that" in that sentence refers to? [12:04:17] fire emoji [12:04:27] aka "ok_hand" [12:04:33] or the other way around actually [12:05:10] oh ok :D [12:06:24] (03PS1) 10Pwirth: Mark ApiTasksUserManagerTest as broken [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/478646 [12:11:26] (03PS2) 10Pwirth: Add registration date column to UserManager. ERM:12999 [extensions/BlueSpiceUserManager] - 10https://gerrit.wikimedia.org/r/475782 [12:17:24] (03PS1) 10Pwirth: Remove targets from ResourceLoaderModules [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/478647 [12:19:12] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceChecklist] - 10https://gerrit.wikimedia.org/r/478648 [12:19:21] (03PS20) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [12:19:41] (03PS2) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/478647 [12:19:48] (03CR) 10Urbanecm: [C: 032] Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [12:20:49] (03Merged) 10jenkins-bot: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [12:21:48] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478649 [12:22:22] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceHideTitle] - 10https://gerrit.wikimedia.org/r/478650 [12:23:32] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceInsertCategory] - 10https://gerrit.wikimedia.org/r/478651 [12:24:20] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceInsertFile] - 10https://gerrit.wikimedia.org/r/478652 [12:25:10] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/478653 [12:25:59] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceInsertMagic] - 10https://gerrit.wikimedia.org/r/478654 [12:27:54] (03CR) 10jerkins-bot: [V: 04-1] Remove targets from ResourceLoader modules [extensions/BlueSpiceInsertLink] - 10https://gerrit.wikimedia.org/r/478653 (owner: 10Pwirth) [12:27:55] Urbanecm: Hmm, So why getting LANGUAGE using Jquery while it is injected using Django anyway? (ajax: {{LANGUAGE}}) https://usercontent.irccloud-cdn.com/file/kFzjqhUp/screenshot_20181210_132652.png [12:29:06] (there are syntax error, I know) [12:30:40] (03CR) 10Tchanders: "Could we also document that the ipb_allow_usertalk flag becomes meaningless for a partial block after this patch?" [core] - 10https://gerrit.wikimedia.org/r/477447 (https://phabricator.wikimedia.org/T210475) (owner: 10Dmaza) [12:31:44] takidelfin, that's because the {{LANGUAGE}} syntax is in index.html, if I'm not mistaken [12:31:54] yup [12:31:55] that's because index.html goes through the Django parser [12:32:03] but /static isn't going via Django at all [12:32:08] it's served directly by Apache [12:32:27] `const LANGUAGE = $('meta[http-equiv="Content-Language"]').attr('content');` [12:32:40] so it is unneccesary? [12:32:57] I should just put it like '{{LANGUAGE}}` [12:32:59] ? [12:33:14] `templates/tracker/index.html` [12:33:25] so it goes through Django parser [12:33:30] in index.html, you can use {{LANGUAGE}} directly [12:33:46] (but you can't do that in /static/* obv) [12:33:51] yup :D [12:35:21] ok, that's fine :) [12:35:24] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceMultiUpload] - 10https://gerrit.wikimedia.org/r/478655 [12:37:17] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/478657 [12:40:43] (03PS1) 10Pwirth: Remove targets from ResourceLoader modules [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/478658 [12:41:54] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Arabic Wikipedia to try version 2 - https://phabricator.wikimedia.org/T211571 (10alanajjar) So, how I can help? [12:49:48] (03PS4) 10Dvogel hallowelt: Fix: Scroll to jumpmark [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 [12:51:00] (03PS5) 10Dvogel hallowelt: Fix: Scroll to jumpmark [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/478588 [12:52:25] (03PS8) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [12:53:12] (03PS1) 10Takidelfin: Tracker: Refractor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) [12:57:31] (03PS2) 10Takidelfin: Tracker: Refractor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) [12:59:44] Urbanecm: Patch-for-review :D [12:59:44] https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478662 [12:59:49] Could you review it, please? [13:00:00] shreyasminocha: same question to you [13:00:21] sure, let me take a look [13:03:12] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lea_Lacroix_WMDE) Hey! I just tested it wi... [13:05:06] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Upgrade Tracker's JS to ES6 - https://phabricator.wikimedia.org/T211144 (10takidelfin) a:03takidelfin [13:06:04] * Nathan_fraignt is back [13:06:10] So I was reading the chatlogs [13:06:31] And was wondering [13:06:36] 🤔 [13:06:37] How many tasks did Arcayn do? [13:06:41] Nathan_fraignt: o/ [13:06:47] he is second [13:07:04] Yeah I know [13:07:08] you´re third right? [13:07:14] he is [13:07:25] so his tasks number ~ 35 - 43 [13:07:44] Taki did 36 as of yesterday [13:07:50] like no [13:07:51] no? [13:07:53] 33 [13:08:06] yeah [13:08:06] ~ 36 tasks if im right [13:08:10] lol [13:08:20] `~` ;) [13:08:25] Oh nevermind [13:08:29] That was about Arcayn [13:08:45] Don´t mind me I´m stupid [13:08:52] :D [13:09:01] human* [13:09:09] :) [13:09:27] actually i'm not sure :D [13:09:32] do tasks like a bot [13:09:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Michael) Hey @Lea_Lacroix_WMDE, that looks... [13:09:43] I´m half robot half human [13:10:39] (03CR) 10Daniel Kinzler: Fix the cache timestamp for forced updates. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [13:11:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lea_Lacroix_WMDE) @Michael I see, thanks! [13:11:14] beep, I'm human [13:11:22] can you get through google captcha as half robot half human? [13:11:25] r/totallynotrobots is leaking [13:11:32] half captcha 🤔 [13:11:41] semi-turing test [13:11:41] half the time I guess [13:11:43] the check mark is cut in a half [13:11:54] https://xkcd.com/329/ [13:12:23] TheJair captchas were hard, that´s why I removed them from Tracker when I´m logged in [13:12:39] Not a joka btw https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/475989 [13:12:45] joke* [13:12:48] i remember this one :D [13:12:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Ladsgroup) Actually it's testable in beta... [13:13:03] lol [13:14:13] 10Anti-Harassment: Replace Block::prevents with setters, getters and method that calculates the block's effects - https://phabricator.wikimedia.org/T211578 (10Tchanders) [13:15:03] can't focus with a task waiting for review xd [13:15:21] 10CX-deployments, 10Language-Team (Language-2018-October-December): Fourth manual run of unpublished draft purge script - https://phabricator.wikimedia.org/T203059 (10KartikMistry) Planning to run script on 17 December (To make sure that script is available in all wikis). [13:16:34] (03PS9) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [13:26:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lea_Lacroix_WMDE) Fancy \o/ Any idea when... [13:27:40] (03PS2) 10Daniel Kinzler: Print chained exceptions when maintenance script fails. [core] - 10https://gerrit.wikimedia.org/r/478503 [13:30:53] takidelfin: are you there? :) [13:31:06] idle time 28 seconds; hmmm [13:31:13] yup [13:31:25] why won’t you join the telegram group? [13:31:26] (03PS21) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [13:31:40] shrugg [13:31:42] also, thanks for the fix ;) [13:31:45] : [13:31:47] ) [13:32:04] https://t.me/wikimediagci [13:32:12] (03PS1) 10Esanders: build: Update linters [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/478664 [13:33:13] There is also a discord: https://discord.gg/MVYxbC [13:33:25] (I don´t have telegram, sorry :/ ) [13:33:34] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Michael) >>! In T186006#4810230, @Lea_Lacr... [13:34:15] 10WMCZ-Tracker: Update import logic to allow importing new MediaInfos - https://phabricator.wikimedia.org/T211581 (10Urbanecm) p:05Triage>03Low [13:34:39] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Ladsgroup) Wikidata is in group1, meaning... [13:34:55] any chat medium that requires a phone is difficult for me to keep up with [13:34:55] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Arabic Wikipedia to try version 2 - https://phabricator.wikimedia.org/T211571 (10Amire80) >>! In T211571#4810130, @alanajjar wrote: > So, how I can help? Thanks for the offer! I shared a document with you. Please let me know... [13:35:18] 10WMCZ-Tracker: Update export logic to support new MediaInfos - https://phabricator.wikimedia.org/T211582 (10Urbanecm) [13:35:26] 10WMCZ-Tracker: Update export logic to support new MediaInfos - https://phabricator.wikimedia.org/T211582 (10Urbanecm) a:05Urbanecm>03None [13:37:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 3 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Michael) >>! In T186006#4810272, @Ladsgrou... [13:38:52] 10MediaWiki-Debug-Logger, 10Operations, 10Performance-Team, 10Patch-For-Review: Set up request profiling for PHP 7 - https://phabricator.wikimedia.org/T206152 (10Joe) I did some benchmarks , using the same setup I used for T206341, with tideways enabled and disabled. I could not notice any clear trend besi... [13:40:26] (03PS1) 10Esanders: Missing space in JSON [extensions/Math] - 10https://gerrit.wikimedia.org/r/478665 [13:41:04] (03CR) 10Daniel Kinzler: Move queries for first/prev/next revision into RevisionStore. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [13:41:50] (03CR) 10Esanders: "Of course, no hurry." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [13:44:22] (03PS6) 10Esanders: Remove obsolete aliases from closures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) [13:44:24] (03PS2) 10Esanders: build: Update eslint-config-wikimedia to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477631 [13:44:39] (03CR) 10Esanders: [C: 04-1] "Waiting until January" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [13:44:57] (03CR) 10Nathan fraignt: "Looks really good, just a few things I saw:" (034 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [13:49:15] (03PS36) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [13:50:53] (03CR) 10Takidelfin: Tracker: Refractor all JS code to ES6 (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [13:51:10] Nathan_fraignt: thank you for the review, check my comments :D [13:52:59] (03PS2) 10Daniel Kinzler: WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 [13:53:16] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, and 3 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Lucas_Werkmeister_WMDE) [13:53:22] takidelfin, saw them :) [13:54:01] 10CX-deployments, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10Arrbee) [13:54:48] (03PS3) 10Takidelfin: Tracker: Refractor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) [13:55:21] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Fix 404 detection in production build - https://phabricator.wikimedia.org/T211573 (10WMDE-leszek) [13:55:31] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Add blubber configuration - https://phabricator.wikimedia.org/T211321 (10WMDE-leszek) [13:55:40] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Client: get (all) language translations in user lang - https://phabricator.wikimedia.org/T210407 (10WMDE-leszek) [13:55:44] 10Google-Code-in-2018, 10Library-Card-Platform, 10goodfirstbug: Add 'invalid' application status option - https://phabricator.wikimedia.org/T175249 (10Arcayn) There is a PR open for this on the github repo [13:56:07] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Server: Look up language directionality based on code - https://phabricator.wikimedia.org/T209288 (10WMDE-leszek) [13:56:13] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Client: Look up language directionality based on code - https://phabricator.wikimedia.org/T210406 (10WMDE-leszek) [13:56:26] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Add "in more languages" link - https://phabricator.wikimedia.org/T210408 (10WMDE-leszek) [13:56:33] Nathan_fraignt: Could you review it again? :) [13:56:43] phew finally done with this review [13:56:45] publishing [13:57:31] shreyasminocha: :) [13:57:36] (03CR) 10jerkins-bot: [V: 04-1] Remove obsolete aliases from closures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [13:57:49] (03CR) 10jerkins-bot: [V: 04-1] build: Update eslint-config-wikimedia to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477631 (owner: 10Esanders) [13:58:00] (03CR) 10Shreyasminocha: [C: 04-1] "Good job. I just need to point out some repetitive things." (0328 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [13:59:15] 10Google-Code-in-2018, 10Library-Card-Platform, 10goodfirstbug: Add 'invalid' application status option - https://phabricator.wikimedia.org/T175249 (10Samwalton9) Thanks @Arcayn, I'm going to take a look shortly! [14:00:32] i agree with nathan in that `(value === true || value === false || value === null)` should be left as-is. if your change were making the condition stricter, it would've been fine (as long as it worked), but don't think it should change it from stricter -> more lenient [14:02:46] takidelfin: i'm curious, how long did this patch take you? seems rather heavy. [14:02:58] like 2 hours? [14:03:08] beceuase of merge conflicts :( [14:03:16] 10CirrusSearch, 10Discovery-Search (Current work), 10Wikimedia-production-error: Job cirrusSearchLinksUpdate: Failed creating job from description ("Page does not exist") - https://phabricator.wikimedia.org/T208932 (10dcausse) The few pages I checked seem to be invalid title strings to do exist in the DB but... [14:03:17] merge conflicts are sad [14:06:15] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/473769 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [14:06:20] shreyasminocha, Urbanecm, Nathan_fraignt: Shreyas suggests setting `requireForBlockBody` to true [14:06:20] (https://eslint.org/docs/rules/arrow-parens#options) [14:06:42] i'd be pro-adding it to eslint-config-wikimedia, but yeah, for now [14:07:20] 10Wikidata-Termbox-Iteration-6: Add "edit pen" - https://phabricator.wikimedia.org/T211584 (10Pablo-WMDE) [14:07:27] 10Wikidata-Termbox-Iteration-6: Add "edit pen" & link - https://phabricator.wikimedia.org/T211584 (10Pablo-WMDE) [14:07:33] (03CR) 10jerkins-bot: [V: 04-1] WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 (owner: 10Daniel Kinzler) [14:08:53] in any case, we should standardise it to *something* [14:09:40] Don´t know what that is, will search on it a bit [14:09:49] (03PS1) 10Urbanecm: Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) [14:10:01] (03PS1) 10Esanders: build: Update linters [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478671 [14:10:10] Nathan_fraignt: https://eslint.org/docs/rules/arrow-parens [14:10:11] Shreyasminocha, why async await vs promises? [14:10:31] async await is syntax sugar over promises [14:10:41] sheyasminocha, yes I agree, I think parentheses should be used in arrow functions [14:10:52] (03CR) 10jerkins-bot: [V: 04-1] Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) (owner: 10Urbanecm) [14:10:52] okay [14:10:57] so 2/4 [14:11:07] I saw some of those without it, but I did not know if that was a reason enough to add a comment to it [14:11:28] takidelfin, I'm fine with that setting, if shreyasminocha & others are fine with it too :) [14:11:40] okay :D [14:11:58] Any other eslint related to es6 ? [14:12:01] settings* [14:12:21] there were some, but your patch isn't in violation of those [14:12:36] but i know for a fact eslint-config-wikimedia doesn't enforce them. so don't worry, go on [14:12:52] * shreyasminocha needs to propose patces in eslint-config-wikimedia [14:13:28] About the promises, I think promises are fine, and I think they have their places besides async/await, but I don´t use JS that much [14:13:42] (03PS2) 10Urbanecm: Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) [14:14:13] async await just makes code that uses promises more linear vs nested so that makes it easier to read imo [14:14:21] Urbanecm: thoughts? [14:14:39] thoughts on what? [14:15:19] async-await vs promises [14:15:20] removing promises would mean that the whole function needs to be async [14:15:24] (03CR) 10Ottomata: Send JSON string of event for validation errors in EventError (032 comments) [eventlogging] - 10https://gerrit.wikimedia.org/r/478101 (https://phabricator.wikimedia.org/T205437) (owner: 10Ottomata) [14:15:54] (03PS2) 10Kosta Harlan: Help Panel: Declare help panel question tag [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478284 (https://phabricator.wikimedia.org/T211118) [14:16:03] Which I guess is fine, but I don´t know if that is neccesary per se [14:16:12] (03CR) 10Kosta Harlan: Help Panel: Declare help panel question tag (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478284 (https://phabricator.wikimedia.org/T211118) (owner: 10Kosta Harlan) [14:16:51] (03PS3) 10Kosta Harlan: Help Panel: Declare help panel question tag [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478284 (https://phabricator.wikimedia.org/T211118) [14:17:15] i think it's not necessary, but better even if it comes at the cost of having to mark the relevant functions with async. want to hear what others have to say [14:17:30] Urbanecm: shreyasminocha Nathan_fraignt: async/await got introduced in ES2017 [14:17:41] so I will push it in another patch [14:17:44] if you want [14:17:45] sounds good [14:17:51] because it is unrelated to es2016 [14:17:55] and yes, ES7 it was [14:17:58] point. [14:18:03] ok :) [14:18:07] By the way, will we be using babel or something? Or just remove browser support? [14:18:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Increase length limit for external identifier, string and URL datatype - https://phabricator.wikimedia.org/T154660 (10Lucas_Werkmeister_WMDE) a:05Tarrow>03Lucas_Werkmeister_WMD... [14:18:49] babel sounds like a good idea [14:19:08] and may be necessary if i remember Urbanecm's browser usage chart correcly [14:19:11] Nathan_fraignt: wait some time :) [14:19:17] I'm doing something big [14:19:21] really big [14:19:21] :D [14:19:28] Sure :) [14:19:56] (03CR) 10jerkins-bot: [V: 04-1] Fully utilize LinkTarget passed to getRevisionByTitle [core] - 10https://gerrit.wikimedia.org/r/473769 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [14:20:40] (03PS2) 10Ottomata: Send JSON string of event for validation errors in EventError [eventlogging] - 10https://gerrit.wikimedia.org/r/478101 (https://phabricator.wikimedia.org/T205437) [14:20:46] Nathan_fraignt, wanna review https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478670 ;)? [14:22:00] Of course! [14:22:51] (03CR) 10jerkins-bot: [V: 04-1] Send JSON string of event for validation errors in EventError [eventlogging] - 10https://gerrit.wikimedia.org/r/478101 (https://phabricator.wikimedia.org/T205437) (owner: 10Ottomata) [14:22:56] thanks Nathan_fraignt [14:26:31] (03PS1) 10ItSpiderman: Add Base class for hook BSApiStoreBaseBeforeReturnData [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478677 [14:26:54] (03PS3) 10Daniel Kinzler: WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 [14:29:28] 10CirrusSearch, 10Discovery-Search (Current work), 10Wikimedia-production-error: Job cirrusSearchLinksUpdate: Failed creating job from description ("Page does not exist") - https://phabricator.wikimedia.org/T208932 (10dcausse) a:03dcausse [14:29:39] Urbanecm, if a (non-staff) user tries to change the user-object related to their trackerprofile they get a not-unique error [14:29:55] 10Wikidata-Termbox-Iteration-6: Make edit url configurable in termbox project - https://phabricator.wikimedia.org/T211587 (10Pablo-WMDE) [14:30:01] good point [14:30:03] While in theory this does prevent them from changing the user, this is not the right message to send an user [14:30:04] I think [14:30:28] 10Wikidata-Termbox-Iteration-6: Show/Style depending on user permissions - https://phabricator.wikimedia.org/T211588 (10Pablo-WMDE) [14:30:49] 10Wikidata-Termbox-Iteration-6: Style per layout - https://phabricator.wikimedia.org/T211589 (10Pablo-WMDE) [14:30:51] that's good point [14:30:53] Also, if there is a bug (like with the exampledata command a ~week back) which create an user without a trackerprofile, they can remove their own trackerprofile by adding it to someone else [14:31:10] :d [14:31:48] 10Wikidata-Termbox-Iteration-6: Find solution for dev view - https://phabricator.wikimedia.org/T211590 (10Pablo-WMDE) [14:32:07] (03CR) 10Nathan fraignt: [C: 04-1] " Urbanecm, if a (non-staff) user tries to change the user-object related to their trackerprofile they get a not-unique err" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) (owner: 10Urbanecm) [14:32:22] (03PS1) 10Pwirth: Add missing bluespice extension registry [extensions/BlueSpiceExtendedFilelist] - 10https://gerrit.wikimedia.org/r/478679 [14:32:41] (03PS11) 10Kosta Harlan: Help Panel: UI updates for different email statuses [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) [14:35:50] (03CR) 10Pwirth: [C: 04-1] Add Base class for hook BSApiStoreBaseBeforeReturnData (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478677 (owner: 10ItSpiderman) [14:39:55] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Wbm1058) While the fact this was first reported early on a Friday has led everyone to suspect something in a Thursday code deployment was respon... [14:41:48] 10Contributors-Analysis, 10Product-Analytics, 10Product-Design-Strategy: Construct and personify wiki clusters [segmentation phase 3] - https://phabricator.wikimedia.org/T203033 (10mpopov) a:05mpopov>03None @kzimmerman, @Neil_P._Quinn_WMF, and I need to schedule a discussion with @MNovotny_WMF to follow-... [14:42:26] (03CR) 10jerkins-bot: [V: 04-1] WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 (owner: 10Daniel Kinzler) [14:42:41] (03PS1) 10Pwirth: Remove BSExtendedSearchAdminButtons hook handler ... [extensions/BlueSpiceExtendedStatistics] - 10https://gerrit.wikimedia.org/r/478682 [14:42:45] 10Product-Analytics, 10Readers-Web-Backlog (Tracking), 10SEO: Check in sameAs A/B test results - https://phabricator.wikimedia.org/T211191 (10mpopov) [14:42:47] 10Product-Analytics, 10Readers-Web-Backlog (Tracking), 10SEO: SameAs A/B test preliminary analysis - https://phabricator.wikimedia.org/T211190 (10mpopov) 05Open>03Resolved @ovasileva feel free to re-open if you have additional questions [14:45:14] (03PS1) 10Urbanecm: Make user field of TrackerProfile read only in admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478683 [14:45:29] (03CR) 10Urbanecm: [C: 032] Make user field of TrackerProfile read only in admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478683 (owner: 10Urbanecm) [14:45:36] (03PS1) 10Anomie: User: Bypass repeatable-read when creating an actor_id [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/478685 (https://phabricator.wikimedia.org/T210621) [14:45:53] (03CR) 10Anomie: [C: 032] "Backporting a fix" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/478685 (https://phabricator.wikimedia.org/T210621) (owner: 10Anomie) [14:46:23] https://usercontent.irccloud-cdn.com/file/jxytwUwc/screenshot_20181210_154607.png [14:46:29] Urbanecm: lol, I am too slow [14:46:32] (03Merged) 10jenkins-bot: Make user field of TrackerProfile read only in admin [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478683 (owner: 10Urbanecm) [14:46:39] (still faster than reviewerbot) [14:46:47] is there a task that tracks invalid titles we have in the DB (e.g. title that can be loaded using Title::newFromID but fails with newFromText() )? [14:46:55] takidelfin, :) [14:47:05] e.g. https://es.wikipedia.org/w/api.php?action=query&prop=info&pageids=3214680&inprop=url [14:47:06] takidelfin, btw, you can instruct reviewer bot to add yourself as a reviewer to all tracker patches [14:47:07] 10AbuseFilter, 10SDC Engineering, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Blocked Externally), 10Multi-Content-Revisions (Tech Debt): Ensure that AbuseFilter applies to the content of all MCR slots - https://phabricator.wikimedia.org/T208769 (10daniel) [14:47:09] 10AbuseFilter, 10SDC Engineering, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Waiting for Review), and 2 others: Make AbuseFilter::revisionToString work across slots - https://phabricator.wikimedia.org/T209291 (10daniel) 05Open>03Resolved [14:47:15] or only to CSS/JS tracker patches [14:47:18] or whatever [14:47:22] Urbanecm: oh? Where? [14:47:23] bawolff: hello [14:47:30] bawolff: o/ [14:47:42] (03PS4) 10Takidelfin: Tracker: Refractor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) [14:47:42] takidelfin, https://www.mediawiki.org/wiki/Git/Reviewers [14:47:44] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to entroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Xaosflux) @Matiia during your test which project did you use Special:Two-factor_authentication on? [14:47:51] Urbanecm: thanks ^-^ [14:47:52] 10MediaWiki-API, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Waiting for Review), 10Multi-Content-Revisions (Reactive), and 2 others: Forcelinkupdate appears to have stopped working (on ENWIKI at least) - https://phabricator.wikimedia.org/T210307 (10daniel) [14:47:53] yw [14:48:01] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Tech Debt): Provide a way of having a meaningful slot header - https://phabricator.wikimedia.org/T205444 (10daniel) [14:48:04] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (New Features): Allow SlotRoleHandlers to control page layout - https://phabricator.wikimedia.org/T200915 (10daniel) [14:48:10] Hello [14:48:24] hi bawolff [14:48:24] bawolff: how did your sleep hold up? :D [14:48:32] :S [14:48:33] (03CR) 10Fomafix: "In my local manual tests a could not find any situation where the deprecated module is requested after deploying this change." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 (owner: 10Fomafix) [14:48:44] going back to bed after this [14:48:54] haha [14:49:05] (03PS10) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [14:49:12] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to enroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Adotchar) [14:49:32] 10Product-Analytics, 10Reading-analysis, 10Wikipedia-Android-App-Backlog, 10Epic: [EPIC] Analytics baseline for Android app - https://phabricator.wikimedia.org/T184098 (10mpopov) [14:49:34] 10Product-Analytics, 10Reading-analysis: Multi-lingual use of Android app - https://phabricator.wikimedia.org/T184091 (10mpopov) 05Open>03Resolved Here's a draft of the report I sent out privately back in July: https://commons.wikimedia.org/wiki/File:Wikipedia_Android_app_multilingual_update_post-release_r... [14:49:35] :o I got pinged [14:49:58] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Missing space in JSON [extensions/Math] - 10https://gerrit.wikimedia.org/r/478665 (owner: 10Esanders) [14:50:04] (03CR) 10Takidelfin: Tracker: Refractor all JS code to ES6 (0310 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [14:50:11] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [14:51:14] 10Product-Analytics, 10SEO: Compute average search result placement - https://phabricator.wikimedia.org/T201510 (10mpopov) p:05Normal>03Low Updating status to reflect reality. [14:52:54] Urbanecm: review? https://www.mediawiki.org/w/index.php?title=Git%2FReviewers&type=revision&diff=3003771&oldid=2997854 :D [14:53:39] small fix needed, https://www.mediawiki.org/w/index.php?title=Git/Reviewers&diff=3003772&oldid=3003771 [14:54:21] (03CR) 10Dbrant: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478603 (owner: 10L10n-bot) [14:54:24] lol, you sent it faster than me [14:54:25] ... [14:54:32] :_: [14:54:32] ? [14:54:38] missing `=` [14:54:40] right? [14:55:27] yeah [14:55:43] 10Discovery, 10Discovery-Analysis, 10Product-Analytics, 10Wikimedia-Blog-Content: [Blog Post] Applying epidemiology techniques to browser tabs - https://phabricator.wikimedia.org/T174512 (10mpopov) 05Open>03declined I think the window on this closed. [14:56:20] Hmm, MediaWiki resolved the possible conflict automaticaly. Maybe we should use wikitext as code repository [14:56:29] :D [14:57:29] 10Wikidata-Termbox-Iteration-6: Make edit url configurable in termbox project - https://phabricator.wikimedia.org/T211587 (10Pablo-WMDE) Discusses concepts: * **pass in termbox request** * emit placeholder and replace in wikibase * build according to base url * api request to get to edit url `/termbox?entity=Q1... [14:57:55] (03PS3) 10Urbanecm: Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) [14:57:57] fyi, MW uses basically the same algorithm to resolve conflict as git does (i.e. GNU diff3) [14:57:58] Urbanecm: Could you please review my patch? https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478662 [14:58:16] 10UniversalLanguageSelector, 10Technical-Debt: Fix jquery.ime CI - https://phabricator.wikimedia.org/T211417 (10Nikerabbit) [14:58:17] (03PS2) 10Niedzielski: WIP: Hygiene: collapse mobile.search* into mobile.startup [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478109 (https://phabricator.wikimedia.org/T210207) [14:58:20] bawolff: why doesn't MW use git? [14:58:34] bawolff: ∧.∧ [14:59:08] for human readable text, git isn't really the most user-friendly choice [14:59:23] For JS & Lua, I guess historical reasons? I'm not really sure [14:59:27] Nathan_fraignt, I fixed the issue you spotted in https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478670 [14:59:39] it predates git, but nonetheless I don't know why its not using separate version control [14:59:51] probably because JS pages were adopted slowly over time [14:59:54] * bawolff doesn't really know [15:00:15] We wanted strong integration with normal user flow i guess? [15:00:28] "predates git" o_0 [15:01:43] shreyasminocha: Well lots of other version control systems already existed [15:01:54] yeah, SVN, Hg i'm guessing? [15:01:56] (03Merged) 10jenkins-bot: User: Bypass repeatable-read when creating an actor_id [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/478685 (https://phabricator.wikimedia.org/T210621) (owner: 10Anomie) [15:02:05] Hg is still rather newish [15:02:08] don't know hold old any of these are :p [15:02:20] (03PS1) 10Pwirth: Remove unused class PageTemplatesAdmin [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/478691 [15:03:16] Originally, we used CVS for mediawiki source code (in a sourceforge repo I think). And eventually moved to svn, and then later git [15:03:26] We were using SVN when I started contributing [15:03:29] (03PS1) 10Bmansurov: Remove config [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478692 (https://phabricator.wikimedia.org/T211423) [15:04:35] Urbanecm: ;-; Please. No claims peroid starts soon (`2018-12-10T17:00:00Z`) [15:04:44] 10Editing Design : Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10iamjessklein) [15:04:44] https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478662 [15:04:57] version 1.0 of svn, is only in 2004(!) [15:05:03] * Urbanecm knows :) [15:05:06] that's in an hour [15:05:11] *two hours [15:05:13] not two? [15:05:14] ah [15:05:15] :D [15:05:22] * Urbanecm forgot he is in UTC+1 [15:05:42] https://usercontent.irccloud-cdn.com/file/neXczTnD/screenshot_20181210_160531.png [15:05:57] :) [15:06:05] https://codein.withgoogle.com/api/program/2018/ [15:06:11] there is api endpoint for it [15:06:29] This is interesting: `"winners_choosing": false,` [15:06:29] `"winners_published": false,` [15:06:32] grace period [15:06:42] like hunger games or something [15:06:56] grace period D: It sounds scary [15:07:01] 10Editing Design : Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10iamjessklein) [15:07:04] lol [15:08:11] 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10Epic, 10Patch-For-Review: Deploy refactored actor storage - https://phabricator.wikimedia.org/T188327 (10Anomie) [15:08:14] Sorry I´m back, will have a look Urbanecm [15:08:21] thanks Nathan_fraignt [15:10:00] How do you update a review branch? [15:10:07] Git pull did not do the trick [15:10:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478603 (owner: 10L10n-bot) [15:10:29] 10Wikipedia-Android-App-Backlog, 10I18n: [[Wikimedia:Wikipedia-android-strings-reading lists confirm remote delete yes/ga]] translation issue - https://phabricator.wikimedia.org/T210918 (10Dbrant) 05Open>03Resolved a:03Dbrant Yes. [15:11:10] Urbanecm ^ [15:11:24] git review -d [15:11:33] Oh you need to run it again? [15:11:45] yup, only that [15:11:51] Alright, thanks! [15:11:54] yw [15:12:48] takidelfin: `as-needed` allows you to skip parens when there's only one arg [15:13:02] yup [15:13:04] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Share doesn't work in File: namespace - https://phabricator.wikimedia.org/T210957 (10Dbrant) [15:13:13] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Share doesn't work in File: namespace - https://phabricator.wikimedia.org/T210957 (10Dbrant) [15:13:15] You didn't want this? [15:13:24] 10MediaWiki-API, 10MediaWiki-Page-editing: allow to add section with no heading and custom edit summary - https://phabricator.wikimedia.org/T211540 (10Anomie) The API action=edit simply passes the 'summary' and 'sectiontitle' in to EditPage's 'wpSummary' and 'wpSectionTitle'. The behavior would need to be chan... [15:13:30] will it allow skipping for multiline body? [15:13:59] ( ddd, [15:13:59] ddd2, [15:13:59] ddd3 ) [15:14:01] you mean? [15:14:15] no, i mean will it allow , arg => { [15:14:18] // [15:14:19] } [15:14:21] yup [15:14:22] (03CR) 10Nathan fraignt: "Sorry forgot to publish the drafts. :/" (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [15:14:33] (03Merged) 10jenkins-bot: Missing space in JSON [extensions/Math] - 10https://gerrit.wikimedia.org/r/478665 (owner: 10Esanders) [15:14:38] fine, as long as we're standardising on something that's not too bad, serves the purpose [15:14:39] (03CR) 10Nathan fraignt: [C: 031] "LGTM!" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) (owner: 10Urbanecm) [15:15:14] 10ContentTranslation, 10Growth-Team: Special:Import does not preserve Tag:ContentTranslation - https://phabricator.wikimedia.org/T206360 (10Arrbee) p:05Triage>03Normal [15:15:14] 10UniversalLanguageSelector: Deprecated ResourceLoader module "schema.UniversalLanguageSelector" - https://phabricator.wikimedia.org/T211598 (10KartikMistry) [15:15:35] my personal preference (not relevant to patch) is force for multiline, force none for single line [15:16:03] I would force brackets for single line [15:16:12] thank you Nathan_fraignt, merging [15:16:16] (03CR) 10Urbanecm: [C: 032] Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) (owner: 10Urbanecm) [15:16:18] (03PS4) 10Kosta Harlan: Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) [15:16:19] but that is my preferences, probably because I´ve used dart quite a lot [15:16:30] 10UniversalLanguageSelector, 10Performance-Team (Radar): Update use of the deprecated "schema.UniversalLanguageSelector" module - https://phabricator.wikimedia.org/T209629 (10Nikerabbit) [15:16:32] 10UniversalLanguageSelector: Deprecated ResourceLoader module "schema.UniversalLanguageSelector" - https://phabricator.wikimedia.org/T211598 (10Nikerabbit) [15:16:50] * shreyasminocha is not familiar with dart [15:17:38] (03Merged) 10jenkins-bot: Allow ordinary users to view their own TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478670 (https://phabricator.wikimedia.org/T211509) (owner: 10Urbanecm) [15:17:45] Only thing you need to know is that it´s either x => x.y or (x) => {return x.y} [15:17:54] not mix or match with the brackets [15:18:01] if that makes sense [15:18:07] takidelfin: there's a typo in your commit message [15:18:15] refractor -> refactor [15:18:21] lol again [15:18:22] also, the trailing "Tracker" [15:18:36] prefix* is unnecessary i think [15:18:40] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Caro_107) {F27475630} I fixed the pixellation and made it into a vector [15:18:43] (03CR) 10Niedzielski: [C: 032] Remove usage of global event emitter from MF (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477684 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:18:50] (03CR) 10Niedzielski: [C: 032] Remove usage of global event emitter from Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477689 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:19:05] will wait for your update before i +1 [15:19:42] maybe `Assets:` prefix? [15:19:53] up to you [15:20:02] (03PS5) 10Takidelfin: Assets: Refactor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) [15:20:10] (03PS11) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [15:20:36] (03CR) 10Shreyasminocha: [C: 031] "As discussed in #wikimedia-dev, async-await would be best done in a separate patch since this path is "... ES6"." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [15:20:55] (03PS12) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [15:21:03] "path" lol. i meant "patch" ofc [15:21:48] whereee [15:21:52] (03PS5) 10Kosta Harlan: Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) [15:22:09] my comment with +1 [15:22:46] (03CR) 10jenkins-bot: Missing space in JSON [extensions/Math] - 10https://gerrit.wikimedia.org/r/478665 (owner: 10Esanders) [15:24:53] (03CR) 10Takidelfin: "> Patch Set 5: Code-Review+1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [15:25:36] 10ContentTranslation, 10WorkType-Maintenance: Down-arrow and up-arrow keys don't work in lists in the translation column in ContentTranslation - https://phabricator.wikimedia.org/T111603 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF This is working on [[ https://www.mediawiki.org/wiki/Content_translati... [15:25:52] (03CR) 10BPirkle: [C: 032] Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [15:26:30] (03CR) 10Kosta Harlan: [C: 032] Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [15:26:32] 10WMCZ-Tracker: Force unix line endings by a linter - https://phabricator.wikimedia.org/T211601 (10Urbanecm) [15:26:41] ^^ any takers? ;) ^^ [15:26:52] 10MediaWiki-API: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Anomie) `titles` (and `pageids`, `revids`, and `generator`) belongs to action=query and specifies the titles for which to return properties for every module selected by the `prop` para... [15:27:05] (03CR) 10Kosta Harlan: [C: 032] "+2'ed myself since Roan attempted yesterday but was blocked by the merge conflict." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [15:27:37] (03CR) 10Anomie: [C: 032] Parser profiling data: Nicer float format [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/436313 (owner: 10Hoo man) [15:29:44] 10ContentTranslation, 10WorkType-Maintenance: Running content translation on Vagrant doesn't define src/target wikis out of box - https://phabricator.wikimedia.org/T115787 (10KartikMistry) @YaronSh Hi, If this error is still happening, let us know. Else, we can close this bug. Thanks! [15:30:37] Urbanecm: and how is my patch? [15:30:40] :D [15:30:45] looking :D [15:31:03] 1.5 hr [15:31:07] it is so bad now ;-; [15:31:41] looks like I will not reach my aimed 40 tasks done :( [15:32:32] (03Merged) 10jenkins-bot: Remove usage of global event emitter from MF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477684 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:32:34] (03Merged) 10jenkins-bot: Remove usage of global event emitter from Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477689 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:32:34] "life is what happens when you have other plans" [15:33:04] takidelfin, {{approved}} in GCI [15:33:11] :) [15:33:12] 10Wikidata-Termbox-Iteration-6: Style per layout - https://phabricator.wikimedia.org/T211589 (10Pablo-WMDE) [15:33:40] Urbanecm: ooh, thanks! But what is with my patch? I think it is more important for me :D [15:33:46] (03CR) 10Urbanecm: [C: 032] Assets: Refactor all JS code to ES6 [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [15:33:50] patch is going next ^^ [15:33:55] ^-^ [15:33:56] yay [15:35:00] takidelfin, what about lua #9 [15:35:29] hmm, I wanted to do SVG Logos for projects task [15:35:40] ok, that's fine too! [15:35:48] then you can get it deployed as your final task [15:35:55] just offering, you can do both probably :) [15:35:59] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10SDC General, 10Wikidata: Verify that abuse-/spam-related extensions work with Wikibase MediaInfo - https://phabricator.wikimedia.org/T204582 (10Jdforrester-WMF) [15:36:01] 10Core Platform Team (MCR), 10Core Platform Team Backlog (Epic), 10Epic, 10MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), 10Multi-Content-Revisions (Tech Debt): Ensure that relevant extensions are MCR-aware - https://phabricator.wikimedia.org/T189220 (10Jdforrester-WMF) [15:36:02] or all three, if including the deploy task :) [15:36:03] 10AbuseFilter, 10SDC Engineering, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Blocked Externally), 10Multi-Content-Revisions (Tech Debt): Ensure that AbuseFilter applies to the content of all MCR slots - https://phabricator.wikimedia.org/T208769 (10Jdforrester-WMF) 05Open>03Resolved a:0... [15:36:11] (03CR) 10jenkins-bot: Remove usage of global event emitter from MF [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477684 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:36:16] (03CR) 10Tpt: [C: 032] build: Update linters [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478671 (owner: 10Esanders) [15:36:46] * takidelfin reboots his computer to Windows, first time from 24 days,21hours and 33 mins [15:36:47] :D [15:36:54] :D [15:37:06] dual boot? [15:37:11] 10Readers-Web-Backlog: [Bug] Bad tracking on edit abort - https://phabricator.wikimedia.org/T211603 (10Niedzielski) [15:37:18] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Bad tracking on edit abort - https://phabricator.wikimedia.org/T211603 (10Niedzielski) [15:37:44] brb [15:37:54] k [15:38:19] (03CR) 10jenkins-bot: Remove usage of global event emitter from Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477689 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:39:38] 10WMCZ-Tracker: Ack names are in English shortly after adding - https://phabricator.wikimedia.org/T211604 (10Urbanecm) [15:39:41] lol it feels so weird [15:39:45] to be on windows again [15:39:52] (don't make the switch) [15:39:53] (03Merged) 10jenkins-bot: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [15:39:55] (03Merged) 10jenkins-bot: Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [15:39:57] (03Merged) 10jenkins-bot: Parser profiling data: Nicer float format [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/436313 (owner: 10Hoo man) [15:39:57] (stay on unix) [15:40:16] wait, we have two takidelfins? [15:40:23] cloned myself [15:40:25] to do more tasks [15:40:31] 🐬🐬 [15:40:34] :) [15:40:46] mouse acceleration is different also [15:40:51] `git clone taki.ml takidelfin_` [15:41:00] (03PS12) 10Kosta Harlan: Help Panel: UI updates for different email statuses [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) [15:41:05] (03Merged) 10jenkins-bot: build: Update linters [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478671 (owner: 10Esanders) [15:42:04] 10ContentTranslation, 10WorkType-Maintenance: Pressing backspace from the uneditable reference section takes user back in the tab - https://phabricator.wikimedia.org/T108013 (10Amire80) This still happens in CX2 exactly as described. [15:42:15] (03CR) 10jenkins-bot: Help Panel: Button text, fix autopopulate, and simplify review panel [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478239 (https://phabricator.wikimedia.org/T209318) (owner: 10Kosta Harlan) [15:42:21] 10ContentTranslation, 10WorkType-Maintenance: Pressing backspace from the uneditable reference section takes user back in the tab - https://phabricator.wikimedia.org/T108013 (10Amire80) a:05Amire80>03None [15:42:38] (03CR) 10jenkins-bot: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [15:43:46] 10ContentTranslation, 10Tracking: Fix erroneous appearance of span tags in translation (tracking) - https://phabricator.wikimedia.org/T90202 (10Amire80) [15:43:48] 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation added many unnecessary tags in the external links section - https://phabricator.wikimedia.org/T110173 (10Amire80) 05Open>03Resolved a:03Amire80 I remember this, and this is no longer supposed to happen in CX2. [15:43:50] 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation added many unnecessary tags in the external links section - https://phabricator.wikimedia.org/T110173 (10Arrbee) a:05Amire80>03None Not happening any more as per @Amire80 [15:44:37] (03CR) 10Niedzielski: [C: 04-1] Remove moduleLoader's event bus (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477685 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [15:44:45] (03CR) 10jenkins-bot: build: Update linters [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478671 (owner: 10Esanders) [15:45:04] (03PS1) 10Pwirth: Fix notice [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478696 [15:45:25] 10MediaWiki-Cache, 10Operations, 10Performance-Team (Radar), 10User-Elukey, 10Wikimedia-production-error: Mcrouter periodically reports soft TKOs for mc[1,2]035 leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10elukey) [15:45:37] 10ContentTranslation, 10Upstream: ContentTranslation creates erroneous "" tags in article text - https://phabricator.wikimedia.org/T211541 (10Amire80) [15:45:44] 10MediaWiki-Cache, 10Operations, 10Performance-Team (Radar), 10User-Elukey, 10Wikimedia-production-error: Mcrouter periodically reports soft TKOs for mc1022 (was mc1035) leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10elukey) [15:46:44] 10DC-Ops, 10Discovery-Search (Current work): IPMI Sensor error on elastic2051 - https://phabricator.wikimedia.org/T211219 (10Papaul) 05Open>03Resolved This looks good now [15:48:19] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (New Features): Specify PageTypeHandler - https://phabricator.wikimedia.org/T209924 (10daniel) [15:48:43] 10MediaWiki-Vendor, 10MW-1.31-release, 10MW-1.32-notes, 10MW-1.32-release, and 4 others: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3 - https://phabricator.wikimedia.org/T206975 (10RazeSoldier) [15:48:46] 10Core Platform Team Kanban, 10SDC Engineering, 10Core Platform Team (MCR), 10Multi-Content-Revisions (Tech Debt): Provide a way of having a meaningful slot header - https://phabricator.wikimedia.org/T205444 (10Jdforrester-WMF) [15:48:48] 10Composer, 10PHP 7.3 support: Publish wikimedia/less.php on Packagist - https://phabricator.wikimedia.org/T207127 (10RazeSoldier) 05Open>03Resolved a:03MaxSem Looks like already done. [15:49:28] (03PS13) 10Kosta Harlan: Help Panel: UI updates for different email statuses [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) [15:50:29] 10ContentTranslation, 10Technical-Debt, 10WorkType-Maintenance: create a robust way in which ContentTranslation could know the language code in edge cases - https://phabricator.wikimedia.org/T106723 (10Arrbee) a:03Amire80 [15:52:34] (03CR) 10Kosta Harlan: "> Patch Set 10: Code-Review+1" (032 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) (owner: 10Kosta Harlan) [15:53:21] (03CR) 10jenkins-bot: Parser profiling data: Nicer float format [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/436313 (owner: 10Hoo man) [15:54:26] (03PS1) 10Urbanecm: Introduce get_token method to get CSRF and other tokens from MW's API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478698 [15:55:01] 10Growth-Team (Current Sprint): Create API module for posting messages to help desk, remove MessagePoster implementation - https://phabricator.wikimedia.org/T211370 (10kostajh) a:03kostajh [15:55:02] (03PS2) 10Urbanecm: Introduce get_token method to get CSRF and other tokens from MW's API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478698 [15:56:10] (03CR) 10Urbanecm: [C: 032] Introduce get_token method to get CSRF and other tokens from MW's API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478698 (owner: 10Urbanecm) [15:56:16] * takidelfin_ switches back to linux due to expiration of Illustrator [15:56:22] lel [15:57:02] takidelfin doesn't need to use Illustrator for such a simple task :) [15:57:12] (03Merged) 10jenkins-bot: Introduce get_token method to get CSRF and other tokens from MW's API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478698 (owner: 10Urbanecm) [15:57:15] imagemagick is enough [15:57:49] yup [15:57:56] 10MediaWiki-General-or-Unknown, 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Create GuzzleHttpRequest class as new default for HttpRequestFactory - https://phabricator.wikimedia.org/T202110 (1... [15:57:56] takidelfin: i'm sure you'll agree that Urbanecm deserves appreciation for being here (literally and figuratively) for us in this time of crisis [15:58:01] :D [15:58:06] 10MediaWiki-Page-editing: Redlinks auto launch into edit source mode - https://phabricator.wikimedia.org/T195914 (10Classicwiki) [15:58:22] Urbanecm: ❤️ [15:58:29] thank you shreyasminocha [15:58:34] (03CR) 10Niedzielski: [C: 031] Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [15:58:37] praise Urbanecm! [15:58:37] o/ o/ o/ [15:58:43] thank you takidelfin [15:58:46] 10ContentTranslation, 10WorkType-Maintenance: Update the user guide with information about link manipulation features - https://phabricator.wikimedia.org/T118145 (10Pginer-WMF) [15:58:48] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Reorganize user-facing help for Content Translation - https://phabricator.wikimedia.org/T203152 (10Pginer-WMF) [15:58:58] GCI final push :) [15:59:14] praise bawolff too [15:59:14] o/ o/ o/ [15:59:21] o/ o/ o/ [15:59:26] praise mentors ¯\_(ツ)_/¯ [15:59:27] * bawolff didn't do anything (recently) [15:59:40] If it was up to bawolff, I'd still be in bed :P [15:59:46] :D [15:59:47] (03PS13) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [15:59:54] (aha, fixing our bugs with mediawiki is doing nothing) [16:00:09] :) [16:01:15] (03PS14) 10Kosta Harlan: Help Panel: UI updates for different email statuses [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478231 (https://phabricator.wikimedia.org/T211113) [16:01:36] 10Security-Reviews, 10The-Wikipedia-Library: Security review for TheWikipediaLibrary extension - https://phabricator.wikimedia.org/T207990 (10sbassett) p:05Triage>03Low [16:03:14] (03PS2) 10Aaron Schulz: Add TransactionProfiler::redefineExpectations and migrate appropriate callers [core] - 10https://gerrit.wikimedia.org/r/477638 [16:04:44] (03PS2) 10Alexia: Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) [16:05:02] (03CR) 10Niedzielski: [C: 032] Fix bug in `ABANDON_END` test [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478391 (owner: 10Shreyasminocha) [16:05:57] (03PS1) 10Urbanecm: Add get_content method to API for MW [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478704 [16:06:08] (03CR) 10Urbanecm: [C: 032] Add get_content method to API for MW [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478704 (owner: 10Urbanecm) [16:07:22] (03Merged) 10jenkins-bot: Add get_content method to API for MW [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478704 (owner: 10Urbanecm) [16:09:23] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 10Security-Team, 10Trust-and-Safety, and 2 others: Remove auto-fill/suggest of usernames from password reset forms - https://phabricator.wikimedia.org/T209972 (10sbassett) If we're looking to abandon https://gerrit.wikimedia.org/r/475... [16:09:45] 10Wikipedia-Android-App-Backlog: As a user, I want to able to award tokens to articles. - https://phabricator.wikimedia.org/T211460 (10Charlotte) 05Open>03declined [16:09:50] (03Merged) 10jenkins-bot: Fix bug in `ABANDON_END` test [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478391 (owner: 10Shreyasminocha) [16:09:54] (03CR) 10Aaron Schulz: "The problem is that it's hard to use lockTSE (it doesn't apply) and have proper statsd metrics if there is no way to treat this kind of co" [core] - 10https://gerrit.wikimedia.org/r/478419 (owner: 10Aaron Schulz) [16:10:08] (03CR) 10Jforrester: "Has the extension and its test code been moved to no longer use this table? I'm surprised this didn't just break…" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/477611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [16:10:24] (03CR) 10Niedzielski: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477993 (https://phabricator.wikimedia.org/T211257) (owner: 10Jdrewniak) [16:10:34] (03CR) 10SBassett: [C: 031] "I like this option the best compared to I4ae492230 and my revert at Ic3cf69181." [core] - 10https://gerrit.wikimedia.org/r/478395 (https://phabricator.wikimedia.org/T209972) (owner: 10Gergő Tisza) [16:11:31] D: https://usercontent.irccloud-cdn.com/file/6BLnozpE/screenshot_20181210_171123.png [16:11:40] it got stuck ;-; [16:12:12] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Zientzia eta Teknologia Fakultatea - Ekologia - https://phabricator.wikimedia.org/T211607 (10Theklan) p:05Triage>03Low [16:12:21] decimal value i think [16:12:24] shrugg [16:12:30] it works [16:12:33] but it is broken [16:12:41] i rounded up to 203 [16:12:43] inkascape save me [16:12:55] (03CR) 10jenkins-bot: Fix bug in `ABANDON_END` test [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478391 (owner: 10Shreyasminocha) [16:13:05] (03CR) 10Ladsgroup: "> Patch Set 1:" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/477611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [16:13:19] (03PS1) 10Yaron Koren: Changed from DB_MASTER in read-only queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/478705 [16:14:30] (03PS2) 10Yaron Koren: Changed from DB_MASTER in read-only queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/478705 [16:14:31] 10MediaWiki-Page-editing: Redlinks auto launch into edit source mode - https://phabricator.wikimedia.org/T195914 (10Classicwiki) To explain a little further, having to switch between turning VE source editing and an older editor is burdensome for me, I don't know if others feel the same way. Often in anti-vandal... [16:14:42] (03PS3) 10Alexia: Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) [16:15:35] (03CR) 10Niedzielski: [C: 04-1] Hygiene: move pageList.less to reflect src/mobile.startup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478627 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [16:15:36] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10sbassett) I'm not sure how worthwhile this would be if we ever got a decent password strength meter deployed. Though digging through the... [16:16:29] (03CR) 10Alexia: ">" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [16:19:04] (03CR) 10jerkins-bot: [V: 04-1] Refactor pageIssues.js into smaller functions [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/477993 (https://phabricator.wikimedia.org/T211257) (owner: 10Jdrewniak) [16:21:09] The task claiming period is going to end in 40 mins! [16:24:42] (03CR) 10Jforrester: [C: 032] build: Update linters [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/478664 (owner: 10Esanders) [16:25:00] aaaa [16:26:01] eeeeeeeeek [16:26:09] (03CR) 10Jforrester: [C: 032] build: Update stylelint-config-wikimedia to 0.5.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478496 (owner: 10Esanders) [16:26:51] (03PS3) 10BPirkle: Convert MultiHttpClient to use Guzzle [core] - 10https://gerrit.wikimedia.org/r/454346 (https://phabricator.wikimedia.org/T202352) [16:27:00] (03CR) 10Jforrester: [C: 032] Remove unused mw-ui-field classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478501 (owner: 10Esanders) [16:29:05] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478383 (owner: 10Esanders) [16:29:12] (03PS2) 10Jforrester: eslint: Remove rule exceptions and auto-fix [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478384 (owner: 10Esanders) [16:29:32] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Special-pages, 10Security-Team, 10Trust-and-Safety, and 2 others: Remove auto-fill/suggest of usernames from password reset forms - https://phabricator.wikimedia.org/T209972 (10chasemp) >>! In T209972#4810972, @sbassett wrote: > If we're looking to... [16:29:52] (03CR) 10Jforrester: [C: 032] eslint: Remove rule exceptions and auto-fix [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478384 (owner: 10Esanders) [16:29:53] 10Page-Previews, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Popups: Upgrade Popups dependencies - https://phabricator.wikimedia.org/T209314 (10nray) a:03nray [16:30:47] 10AbuseFilter, 10SDC Engineering, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Done with CPT), 10Multi-Content-Revisions (Tech Debt): Ensure that AbuseFilter applies to the content of all MCR slots - https://phabricator.wikimedia.org/T208769 (10CCicalese_WMF) [16:30:53] 10MediaWiki-API, 10MediaWiki-History-or-Diffs, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Done with CPT), and 4 others: RevisionAccessException from ApiComparePages.php: Could not determine title for page/revision ID - https://phabricator.wikimedia.org/T208929 (10CCicalese_WMF) [16:30:55] 10AbuseFilter, 10SDC Engineering, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Done with CPT), and 2 others: Make AbuseFilter::revisionToString work across slots - https://phabricator.wikimedia.org/T209291 (10CCicalese_WMF) [16:31:03] Rip.. no new last task [16:31:17] Also didn't quite make my goal lol [16:31:29] 10MediaWiki-ServiceContainer, 10SDC Engineering, 10Wikidata, 10Core Platform Team (MCR), and 3 others: ServiceContainer: Allow extensions to manipulate services upon creation - https://phabricator.wikimedia.org/T195212 (10CCicalese_WMF) [16:34:52] (03CR) 10Yaron Koren: [C: 032] Changed from DB_MASTER in read-only queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/478705 (owner: 10Yaron Koren) [16:36:00] 10MediaWiki-Cache, 10Librarization, 10User-Addshore: Create objectcache/BagOStuff library - https://phabricator.wikimedia.org/T146257 (10Krinkle) [16:36:06] 10Growth-Team, 10StructuredDiscussions, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10VisualEditor (Current work): Flow widgets lose focus styling after using an inspector - https://phabricator.wikimedia.org/T211515 (10Jdforrester-WMF) a:03Esanders [16:38:44] ssss [16:39:26] 10MediaWiki-ServiceContainer, 10Librarization: Move includes/services/ into includes/libs/ - https://phabricator.wikimedia.org/T211608 (10Lucas_Werkmeister_WMDE) [16:41:06] 10MediaWiki-Cache, 10Librarization, 10User-Addshore: Create objectcache/BagOStuff library - https://phabricator.wikimedia.org/T146257 (10Krinkle) Removing the T110022 sub-task because creation a the library isn't blocked on having our HTTP abstraction published. Nothing in the relevant interfaces and utiliti... [16:41:18] 10MediaWiki-Cache, 10Librarization, 10User-Addshore: Create objectcache/BagOStuff library - https://phabricator.wikimedia.org/T146257 (10Krinkle) [16:44:34] Urbanecm: https://codein.withgoogle.com/dashboard/task-instances/5113083862188032/ Submitted [16:44:49] looking [16:45:51] takidelfin, surprisingly, frwikinews doesn't use logo with any French text in it [16:45:55] see https://fr.wikibooks.org/wiki/Accueil [16:46:09] ... [16:46:16] (03CR) 10jerkins-bot: [V: 04-1] Convert MultiHttpClient to use Guzzle [core] - 10https://gerrit.wikimedia.org/r/454346 (https://phabricator.wikimedia.org/T202352) (owner: 10BPirkle) [16:46:16] oh no [16:46:53] please amend :) [16:47:02] so what should i do? [16:47:05] https://en.wikipedia.org/static/images/project-logos/frwikinews.png [16:47:15] but there is a text ;-;; [16:47:41] (03Merged) 10jenkins-bot: build: Update linters [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/478664 (owner: 10Esanders) [16:47:42] *wikibooks [16:47:52] https://en.wikipedia.org/static/images/project-logos/frwikibooks.png [16:47:56] uses too ;-; [16:48:12] ah [16:48:14] french text [16:48:15] but on https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/478709/1/static/images/project-logos/frwikibooks-1.5x.png, there's something in French [16:48:23] on https://en.wikipedia.org/static/images/project-logos/frwikibooks.png there's nothing like it [16:48:26] lo [16:48:32] 12 minutes [16:48:34] FAAST [16:49:22] Urbanecm: https://upload.wikimedia.org/wikipedia/commons/d/df/Wikibooks-logo-en-noslogan.svg [16:49:27] so this is good then? [16:49:32] lgtm [16:49:44] (03Merged) 10jenkins-bot: build: Update stylelint-config-wikimedia to 0.5.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478496 (owner: 10Esanders) [16:50:08] (03Merged) 10jenkins-bot: Remove unused mw-ui-field classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478501 (owner: 10Esanders) [16:50:10] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478383 (owner: 10Esanders) [16:50:12] (03Merged) 10jenkins-bot: eslint: Remove rule exceptions and auto-fix [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478384 (owner: 10Esanders) [16:50:14] (03Merged) 10jenkins-bot: Changed from DB_MASTER in read-only queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/478705 (owner: 10Yaron Koren) [16:50:17] (03PS1) 10DCausse: Do not index invalid titles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) [16:50:18] also pick something else than frwikinews, other student picked it [16:50:33] * Urbanecm whispers to takidelfin: pick enwikinews ;) [16:50:42] (you need to only rename the file for that) [16:52:59] (03CR) 10jenkins-bot: Remove unused mw-ui-field classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478501 (owner: 10Esanders) [16:54:14] (03PS1) 10D3r1ck01: Api: Add missing parameter PHPDoc to @param [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 [16:55:16] 5 minutes left! [16:55:20] yup [16:55:21] Ikr [16:55:22] :((( [16:56:12] can I help? [16:56:44] Urbanecm: pusheeeed [16:57:04] * shreyasminocha has super-rapid heartbeat rn [16:57:29] (03PS1) 10Daimona Eaytoy: Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 [16:57:39] takidelfin, lookign [16:57:43] 3 minutes xd [16:58:17] (03CR) 10jenkins-bot: build: Update stylelint-config-wikimedia to 0.5.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478496 (owner: 10Esanders) [16:58:41] * shreyasminocha dies a relieved death [16:58:43] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: boolean_operators_clean_api_setup_main_and_NOT_prohibit_words_in_search_results, cl" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [16:58:52] im dying now [16:59:01] i hope the best for you [16:59:05] 1 minute left 20 s [16:59:12] (03CR) 10Anomie: Rate limit blocks of admins (033 comments) [core] - 10https://gerrit.wikimedia.org/r/478581 (https://phabricator.wikimedia.org/T150826) (owner: 10Gergő Tisza) [16:59:15] (03PS1) 10D3r1ck01: Profile: Remove non-existent method parameter PHPDoc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 [16:59:15] lgtm [16:59:17] approved [16:59:18] takidelfin: keep the other tab open [16:59:25] claim the deploy task! :D [16:59:25] \o/ [16:59:30] https://codein.withgoogle.com/dashboard/task-instances/5064609921761280/ [16:59:37] (03CR) 10jerkins-bot: [V: 04-1] Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 (owner: 10Daimona Eaytoy) [16:59:45] 15s [16:59:56] and [16:59:58] we're [17:00:00] claimed it [17:00:01] done [17:00:02] xdd [17:00:04] lol [17:00:10] jesus [17:00:11] (03CR) 10jenkins-bot: eslint: Remove rule exceptions and auto-fix [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478384 (owner: 10Esanders) [17:00:14] \o/ [17:00:23] takidelfin: even i made it with three minutes to spare [17:00:24] I hereby pronounce GCI 2018's task claiming period as over. Thank you everyone, it was fun [17:00:24] (03CR) 10Aaron Schulz: [C: 032] Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [17:00:26] Urbanecm: thanks you so much ^-^ [17:00:27] nice takidelfin [17:00:35] yw [17:00:40] Urbanecm: i have no words to thank you with [17:00:45] my heart [17:00:56] literally [17:01:01] none but these [17:01:01] it ... [17:01:07] is faster than light now [17:01:08] aaa [17:01:15] Am I dying? [17:01:18] am i dead? [17:01:27] although taki's was definitely more intense [17:01:29] * takidelfin dies [17:01:32] i made it with three minutes to spare [17:01:33] * takidelfin died [17:01:36] * shreyasminocha dies [17:01:38] * shreyasminocha died [17:01:45] last 15 seconds masterrace [17:01:47] shreyasminocha, you got another task as well? [17:01:47] D: [17:01:56] yeah, made it [17:02:01] nice! [17:02:03] (03CR) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478383 (owner: 10Esanders) [17:02:08] ough. ok. sorry for being childish, but I couldn't resist this pressure [17:02:14] i'm so sorry :( [17:02:51] Urbanecm: let me know thank you more explicitly since I'm now recovering [17:02:59] now* [17:03:24] Urbanecm: thank you *so* much [17:03:37] you saved the day [17:03:40] and made our day [17:03:45] (03CR) 10Florianschmidtwelzow: [C: 031] build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [17:03:46] I'm happy I could help you [17:03:50] * andre__ rings a bell [17:03:52] (03PS1) 10DCausse: Titles rejected by newFromDBKey are not necessarily inexistent [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) [17:03:58] andre__: o/ [17:04:04] andre__: hello! [17:04:07] lol my task just got approved [17:04:08] (03CR) 10jenkins-bot: Changed from DB_MASTER in read-only queries [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/478705 (owner: 10Yaron Koren) [17:04:25] :) [17:04:32] hi andre__ [17:04:34] TheJair: try claiming another one? [17:04:36] (03CR) 10jerkins-bot: [V: 04-1] Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 (owner: 10Daimona Eaytoy) [17:04:37] you never know [17:04:43] No it's not possible [17:04:44] there was some "grace_period" in the api [17:04:54] Urbanecm: I can't express how grateful now I am... you stayed with us to last seconds :D [17:05:03] shreyasminocha: yup [17:05:20] someone please acknowledge Urbanecm's pressure too [17:05:25] (03CR) 10Aaron Schulz: "Would be nice to get this passing Jenkins." [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [17:05:28] his was perhaps more intense [17:05:33] ` "no_claims": true,` [17:05:33] ` "grace_period": false,` [17:05:38] shreyasminocha: agree :O [17:06:18] takidelfin, I'm happy I could mentor you. I really enjoyed it. Of course, in case you have other questions, #wikimedia-dev will warmly welcome you [17:06:31] top 10 scariest messages in the world https://usercontent.irccloud-cdn.com/file/BPEHm1F2/screenshot_20181210_180610.png [17:06:47] #7 will shock you [17:07:06] if you don't mind, I'll go home now. See you in ~1 hour [17:07:12] bye Urbanecm [17:07:13] bye [17:07:14] you're our hero [17:07:16] goobye! [17:07:17] yup [17:07:21] o/ o/ o/ [17:07:25] o/ o/ o/ [17:07:28] see you later! [17:07:38] Number #2 https://usercontent.irccloud-cdn.com/file/dDubAhZ5/screenshot_20181210_180703.png [17:07:50] so there it is [17:07:52] 36 tasks done [17:07:58] (35 actually) [17:08:06] so... [17:08:14] #7: "22:29 < shreyasminocha> 15s" [17:08:38] I can't +1 [17:08:43] I can +0 [17:08:47] shreyasminocha: +1 [17:09:20] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:12:49] (03CR) 10DCausse: Api: Add missing parameter PHPDoc to @param (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:12:50] * takidelfin googles relaxation music no vocals [17:13:15] alas, the end [17:13:16] * shreyasminocha has dinner [17:13:20] (03PS2) 10Daimona Eaytoy: Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 [17:13:27] hey bawolff [17:13:30] bawolff: were you here for the intense action? [17:13:38] Did the rss task get claimed on GCI? [17:13:38] I was in a meeting [17:13:44] Yes [17:13:45] it didn't last i checked [17:13:47] :O [17:13:53] i checked like a couple hours back [17:13:59] oh okay [17:14:02] LukasA claimed it [17:14:11] don't know who that is... [17:14:31] glad it got claimed though \o/ hopefully it'll get completed as well [17:14:43] Now at least I didn't already start working on it [17:14:47] (03PS2) 10D3r1ck01: Api: Add missing parameter PHPDoc to @param [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 [17:15:00] TheJair: I wanted to claim it too [17:15:12] (03Merged) 10jenkins-bot: Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [17:15:28] (03CR) 10D3r1ck01: Api: Add missing parameter PHPDoc to @param (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:15:36] LukasA completed a couple of the mediawiki php tasks before [17:15:44] it was a bit lower on my wanna claim list, but yeah, i was interested too :D [17:15:45] (03CR) 10jerkins-bot: [V: 04-1] Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 (owner: 10Daimona Eaytoy) [17:15:56] takidelfin, did you claim the deploy task? [17:15:57] nice, so they'll probably deliver [17:16:01] he did [17:16:03] just in time [17:16:07] *just* [17:16:19] like i was watching the clock count down [17:16:30] i typed "done" before he typed "claimed" or equivalent [17:16:46] (03CR) 10jerkins-bot: [V: 04-1] Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 (owner: 10Daimona Eaytoy) [17:16:48] TheJair: yup [17:16:50] bawolff: i had one of the most intense moments of my life [17:17:13] 3 minutes before the deadline, Urbanecm approved my task, i claimed another one [17:17:15] thankfuly to Urbanecm :D [17:17:24] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 (owner: 10D3r1ck01) [17:17:27] 0 minutes before the deadline, Urbanecm approved takidelfin's task, he claimed another one [17:17:28] which one did you claim shreyasminocha? [17:17:28] 15 s [17:17:29] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Fix 404 detection in production build - https://phabricator.wikimedia.org/T211573 (10Pablo-WMDE) a:05Pablo-WMDE>03None [17:17:36] TheJair: deploy [17:17:37] 10Wikidata-Termbox-Iteration-5, 10Wikidata-Termbox-Iteration-6: Add blubber configuration - https://phabricator.wikimedia.org/T211321 (10Pablo-WMDE) a:05Pablo-WMDE>03None [17:18:01] 10DC-Ops, 10decommission: decommission elastic200[01-23] for lease return in December 2018 - https://phabricator.wikimedia.org/T211071 (10RobH) 05Open>03declined Turns out I had this on T211023, and its ready for onsite wipe, this is dupe, declining. [17:18:01] ah nice [17:18:11] (03CR) 10jenkins-bot: Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [17:19:41] Ok, I'm going back to bed. Happy GCI everyone, and I hope you all consider sticking around after the contest is done [17:20:51] goodbye bawolff! [17:20:54] I'm afk now as well because test week ;-; [17:20:55] (03CR) 10Bartosz Dziewoński: [C: 032] Special:AllMessages: Remove 'id' attribute from message rows [core] - 10https://gerrit.wikimedia.org/r/478494 (owner: 10Krinkle) [17:22:49] 10Readers-Web-Backlog: Add @pmiazga to the reading-web-staging admin group in horizon - https://phabricator.wikimedia.org/T211610 (10Krenair) (nothing to do with administration of horizon itself, this is a project decision to be handled by the `reading-web-staging` project administrators) [17:24:31] Wasn´t there when the contest ended (at least for me, got no task claiemed) but I just want to thank all the mentors who put up amazing tasks and helped us to complete. Special shoutout to Urbanecm, who was always there to answer any and all questions! :) [17:24:33] (03CR) 10Anomie: "Rename itself seems sane, and codesearch finds no uses outside of core." [core] - 10https://gerrit.wikimedia.org/r/478579 (owner: 10Gergő Tisza) [17:26:16] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:28:07] (03CR) 10Ppchelko: "I guess they are either non existent or invalid. Should we say both options?" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [17:28:36] 10Readers-Web-Backlog: Add @pmiazga to the reading-web-staging admin group in horizon - https://phabricator.wikimedia.org/T211610 (10pmiazga) @Krenair sorry for tagging it with Horizon, I didn't know it's used only for administration of Horizon itself. I used this tag to indicate that this is related to Horizon. [17:28:39] (03PS3) 10Daimona Eaytoy: Rewrite the method for getting a global emergency value [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478716 [17:29:24] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - https://phabricator.wikimedia.org/T178676 (10Theklan) [17:29:26] 10Wikimedia-User-Group-Basque: Bizkaiko campusa - Euskal sortzaileen wiki tailerra - https://phabricator.wikimedia.org/T205859 (10Theklan) 05Open>03Invalid Ez zen egin, ez zelako inor apuntatu. [17:29:31] 10Readers-Web-Backlog: When I navigate away from an article and then back, I'd like my reading depth to be preserved - https://phabricator.wikimedia.org/T209418 (10alexhollender) I am unable to reproduce this on either Android or iOS. However, oddly, if I follow the reproduction steps on T211162, I am then able... [17:30:00] (03CR) 10Jforrester: [C: 032] Remove 'valid_tag' from tablesUsed in tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/477611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [17:30:30] 10Wikimedia-User-Group-Basque: EHU - Bizkaiko campusa - Irakasleen Eskola - Gizarte Zientzien didaktika I - https://phabricator.wikimedia.org/T205517 (10Theklan) Gaur bilera izan dut hainbat irakaslerekin bigarren lauhilekoan martxan jartzeko. Bertan zeudenen artean Teresak bakarrik du ikasgaia eta esan didate A... [17:31:59] (03CR) 10Anomie: "> How do you test a method that depends on an optional composer library?" [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [17:34:35] (03PS1) 10Lucas Werkmeister (WMDE): Move includes/services/ into includes/libs/ [core] - 10https://gerrit.wikimedia.org/r/478729 (https://phabricator.wikimedia.org/T211608) [17:34:42] (03CR) 10DCausse: [C: 032] "thanks!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:34:53] shreyasminocha: looks like I have got two tasks to deploy :) [17:35:04] Redundant namespaces and HD Logos [17:35:06] (03CR) 10Lucas Werkmeister (WMDE): Move includes/services/ into includes/libs/ (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478729 (https://phabricator.wikimedia.org/T211608) (owner: 10Lucas Werkmeister (WMDE)) [17:35:38] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 (owner: 10D3r1ck01) [17:35:40] (03CR) 10DCausse: [C: 032] Profile: Remove non-existent method parameter PHPDoc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 (owner: 10D3r1ck01) [17:36:20] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Arabic Wikipedia to try version 2 - https://phabricator.wikimedia.org/T211571 (10alanajjar) > Thanks for the offer! I shared a document with you. Please let me know if you received it. It needs to be translated into Arabic. **... [17:38:39] (03Merged) 10jenkins-bot: Special:AllMessages: Remove 'id' attribute from message rows [core] - 10https://gerrit.wikimedia.org/r/478494 (owner: 10Krinkle) [17:38:41] (03Merged) 10jenkins-bot: Remove 'valid_tag' from tablesUsed in tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/477611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [17:39:30] (03CR) 10DCausse: "> Patch Set 1:" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [17:39:35] Maybe I will write a summary of this GCI 🤔 [17:40:14] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Exiting the image gallery loses page scroll offset - https://phabricator.wikimedia.org/T211162 (10alexhollender) Confirming this bug (although on iOS/Chrome & Safari I am unable to reproduce it). As far as I can tell this only occurs as the result of using the bro... [17:41:09] (03CR) 10jenkins-bot: Special:AllMessages: Remove 'id' attribute from message rows [core] - 10https://gerrit.wikimedia.org/r/478494 (owner: 10Krinkle) [17:42:00] (03CR) 10Ppchelko: [C: 031] Titles rejected by newFromDBKey are not necessarily inexistent [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [17:45:32] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [17:45:34] (03PS2) 10DCausse: Titles rejected by newFromDBKey are invalid not inexistent [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) [17:46:20] (03CR) 10Nuria: [V: 032 C: 032] Send JSON string of event for validation errors in EventError [eventlogging] - 10https://gerrit.wikimedia.org/r/478101 (https://phabricator.wikimedia.org/T205437) (owner: 10Ottomata) [17:46:36] (03CR) 10Anomie: [C: 031] Add wfGetErrorText, a global helper function for log error formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [17:47:13] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10JJMC89) This isn't the first time a bot has mass moved pages. When I've done it with my bot, it moved 6 pages (+ talk) per minute. TheSandBot w... [17:48:36] (03CR) 10jerkins-bot: [V: 04-1] Send JSON string of event for validation errors in EventError [eventlogging] - 10https://gerrit.wikimedia.org/r/478101 (https://phabricator.wikimedia.org/T205437) (owner: 10Ottomata) [17:49:11] (03Abandoned) 10Alexia: Hoist @import blocks to the top of concatenated output. [core] - 10https://gerrit.wikimedia.org/r/477329 (https://phabricator.wikimedia.org/T210891) (owner: 10Alexia) [17:49:12] (03CR) 10Tjones: [C: 031] "Seems reasonable!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [17:49:13] 10MediaWiki-ResourceLoader, 10Performance-Team: @import are broken due to be concatenated in the middle of output. - https://phabricator.wikimedia.org/T210891 (10Alexia) 05Open>03declined [17:49:33] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [17:50:27] (03Merged) 10jenkins-bot: Api: Add missing parameter PHPDoc to @param [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [17:50:32] 10MediaWiki-ResourceLoader, 10Performance-Team: @import are broken due to be concatenated in the middle of output. - https://phabricator.wikimedia.org/T210891 (10Alexia) Understood. I changed our local CSS to embed the output of the Google Font URL call directly.(Which is not recommended, but not the worst th... [17:50:34] (03Merged) 10jenkins-bot: Profile: Remove non-existent method parameter PHPDoc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 (owner: 10D3r1ck01) [17:51:12] 10MediaWiki-Vagrant, 10Wikidata, 10wikiba.se: Error returned during `vagrant provision` of wikidata role - https://phabricator.wikimedia.org/T211611 (10jeblad) [17:57:33] (03CR) 10Esanders: [C: 032] "That is correct, we should detect if the textarea is still the primary input area. CodeMirror still works I think via change events, and V" [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) (owner: 10TheDJ) [17:58:07] 10MediaWiki-User-management, 10Anti-Harassment: Replace Block::prevents with setters, getters and method that calculates the block's effects - https://phabricator.wikimedia.org/T211578 (10TBolliger) [17:58:09] 10Readers-Web-Backlog: Add @pmiazga to the reading-web-staging admin group in horizon - https://phabricator.wikimedia.org/T211610 (10Niedzielski) We added @pmiazga as an admin under https://horizon.wikimedia.org/project/member/. [17:58:12] (03CR) 10Jforrester: [C: 031] "We could also do 3=thrice, but perhaps not for en-US users. ;-)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478585 (owner: 10Amire80) [17:58:45] 10SVG Translate Tool: Create a gadget/template to link to svgtranslate tool from Commons images - https://phabricator.wikimedia.org/T210887 (10Samwilson) [17:58:54] (03PS1) 10Urbanecm: Localization [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478733 [17:59:03] (03PS1) 10Esanders: Revert "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478734 [17:59:27] (03CR) 10Urbanecm: [C: 032] Localization [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478733 (owner: 10Urbanecm) [17:59:40] (03CR) 10Jforrester: [C: 032] Revert "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478734 (owner: 10Esanders) [17:59:48] 10SVG Translate Tool: Create a gadget/template to link to svgtranslate tool from Commons images - https://phabricator.wikimedia.org/T210887 (10Samwilson) [17:59:57] (03CR) 10Jforrester: [C: 032] Add missing test cases for code in Cite::refArg [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478645 (https://phabricator.wikimedia.org/T211576) (owner: 10Thiemo Kreuz (WMDE)) [18:00:29] 10Editing Design , 10VisualEditor (Current work): Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10JTannerWMF) [18:01:02] (03CR) 10Jforrester: [C: 031] "Fancy." [core] - 10https://gerrit.wikimedia.org/r/478503 (owner: 10Daniel Kinzler) [18:01:06] (03Merged) 10jenkins-bot: Localization [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478733 (owner: 10Urbanecm) [18:01:20] (03CR) 10Amire80: "That's exactly what en-gb is for :)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478585 (owner: 10Amire80) [18:01:26] 10Discovery-Search (Current work): Port the elasticsearch plugin extra-analysis-surrogates to 6.4.2 as a noop plugin - https://phabricator.wikimedia.org/T209348 (10dcausse) a:03dcausse [18:01:43] 10Discovery-Search (Current work): Port the elasticsearch plugin extra-analysis-surrogates to 6.4.2 as a noop plugin - https://phabricator.wikimedia.org/T209348 (10dcausse) p:05Triage>03Normal [18:01:47] (03CR) 10Esanders: [C: 032] "Reverting this pre-deploy." [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) (owner: 10TheDJ) [18:02:06] 10SVG Translate Tool: Make first letters of translation URL case-insensitive - https://phabricator.wikimedia.org/T211612 (10Samwilson) [18:02:30] (03CR) 10jenkins-bot: Api: Add missing parameter PHPDoc to @param [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478715 (owner: 10D3r1ck01) [18:02:51] (03CR) 10jerkins-bot: [V: 04-1] Structure test for wrong calls in LoadExtensionSchemaUpdates [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [18:03:48] 10MediaWiki-Export-or-Import: importDump does not work with actor if the user does not exist - https://phabricator.wikimedia.org/T211450 (10Anomie) Relaying from IRC: It turns out the problem is because the `` is containing a name with a lowercased first letter. That fails the `isUsableName()` check wh... [18:04:03] (03CR) 10Umherirrender: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 19.1.0 [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/478353 (owner: 10Umherirrender) [18:05:51] (03CR) 10Jforrester: [C: 031] "> Patch Set 1:" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478585 (owner: 10Amire80) [18:05:57] 10MediaWiki-extensions-PageAssessments, 10Community-Tech, 10Operations, 10Performance, 10User-Banyek: Issues with purgeUnusedProjects.php cron job on mwmaint1002 (Fri Oct 26) - https://phabricator.wikimedia.org/T208231 (10kaldari) @Banyek - Thanks for the ping. I don't think anything is unexpected here.... [18:07:57] 10Research: Synthesize algorithmic bias mitigation strategies from existing process frameworks - https://phabricator.wikimedia.org/T207513 (10Capt_Swing) p:05Triage>03Normal [18:08:06] 10CirrusSearch, 10Discovery-Search: Add support for bulk scoring in the LTR plugin - https://phabricator.wikimedia.org/T211614 (10dcausse) [18:08:26] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Restructure and improve 'Basic information' section - https://phabricator.wikimedia.org/T203727 (10Jdforrester-WMF) >>! In T203727#4808672, @Esanders wrote: > What does "View global account info" do? It takes you to `Special:CentralAuth... [18:08:32] 10MediaWiki-extensions-PageAssessments, 10Community-Tech, 10Operations, 10Performance, 10User-Banyek: Issues with purgeUnusedProjects.php cron job on mwmaint1002 (Fri Oct 26) - https://phabricator.wikimedia.org/T208231 (10Banyek) I think we should adjust the slow timer in a way of not to alert if the sc... [18:13:34] :D [18:14:21] (03CR) 10jenkins-bot: Profile: Remove non-existent method parameter PHPDoc [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478719 (owner: 10D3r1ck01) [18:15:26] 10Readers-Web-Backlog: Add @pmiazga to the reading-web-staging admin group in horizon - https://phabricator.wikimedia.org/T211610 (10pmiazga) I'm an admin now. Thanks [18:15:33] 10Readers-Web-Backlog: Add @pmiazga to the reading-web-staging admin group in horizon - https://phabricator.wikimedia.org/T211610 (10pmiazga) 05Open>03Resolved [18:15:52] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - page/talk toggle - https://phabricator.wikimedia.org/T210658 (10alexhollender) [18:16:51] (03CR) 10Jforrester: "Those failures were not the ones I was expecting. :-)" [core] - 10https://gerrit.wikimedia.org/r/475065 (https://phabricator.wikimedia.org/T157651) (owner: 10Gergő Tisza) [18:17:59] (03Merged) 10jenkins-bot: Revert "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478734 (owner: 10Esanders) [18:18:01] (03Merged) 10jenkins-bot: Add missing test cases for code in Cite::refArg [extensions/Cite] - 10https://gerrit.wikimedia.org/r/478645 (https://phabricator.wikimedia.org/T211576) (owner: 10Thiemo Kreuz (WMDE)) [18:20:27] (03PS3) 10Thcipriani: Combine blubberoid.yaml and .pipeline/blubber.yaml [blubber] - 10https://gerrit.wikimedia.org/r/474379 [18:20:29] (03CR) 10jenkins-bot: Revert "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478734 (owner: 10Esanders) [18:21:46] 10MediaWiki-API, 10MediaWiki-Page-editing: allow to add section with no heading and custom edit summary - https://phabricator.wikimedia.org/T211540 (10MarkAHershberger) As someone else noted on the support desk, there is already an "appendtext" parameter. {F27477885} [18:22:41] (03CR) 10Dduvall: [C: 032] Combine blubberoid.yaml and .pipeline/blubber.yaml [blubber] - 10https://gerrit.wikimedia.org/r/474379 (owner: 10Thcipriani) [18:23:22] (03Merged) 10jenkins-bot: Combine blubberoid.yaml and .pipeline/blubber.yaml [blubber] - 10https://gerrit.wikimedia.org/r/474379 (owner: 10Thcipriani) [18:23:28] (03CR) 10Umherirrender: "> I had i mind, that the codesniffer test is required to be passed for commits." [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 (owner: 10Umherirrender) [18:24:50] (03CR) 10Anomie: "> Yeah, let's put this aside for the moment. Although I think most of that can be done as a separate patch on top of this." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/471664 (https://phabricator.wikimedia.org/T197153) (owner: 10Gergő Tisza) [18:26:46] (03CR) 10Ppchelko: "This would need a counterpart in the deployment repo I think" [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478692 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [18:27:26] (03PS1) 10Tchanders: Fix TitlesMultiSelectWidget documentation [core] - 10https://gerrit.wikimedia.org/r/478740 [18:28:12] (03CR) 10Anomie: [C: 031] "Should we go ahead and merge this, or put it aside until I319b58cc is figured out?" [core] - 10https://gerrit.wikimedia.org/r/477454 (owner: 10Gergő Tisza) [18:28:31] (03PS2) 10Tchanders: Fix TitlesMultiselectWidget documentation [core] - 10https://gerrit.wikimedia.org/r/478740 [18:28:35] what a silence [18:29:17] 10MediaWiki-Change-tagging, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Ladsgroup, and 2 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Lucas_Werkmeister_WMDE) [18:29:34] 10MediaWiki-Change-tagging, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Ladsgroup, and 2 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Lucas_Werkmeister_WMDE) [18:30:11] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10nra... [18:30:13] (03CR) 10Daniel Kinzler: [C: 04-1] "The namespace should also change, stuff in libs should not be in the MediaWiki namespace. This should be moved to Wikimedia\Services or so" [core] - 10https://gerrit.wikimedia.org/r/478729 (https://phabricator.wikimedia.org/T211608) (owner: 10Lucas Werkmeister (WMDE)) [18:30:21] hmm, it is active silence [18:30:49] (03CR) 10Daniel Kinzler: [C: 04-1] "...for the record, I entirely agree with the intent, we should definitely do this!" [core] - 10https://gerrit.wikimedia.org/r/478729 (https://phabricator.wikimedia.org/T211608) (owner: 10Lucas Werkmeister (WMDE)) [18:30:58] 10TechCom, 10TechCom-RFC: TechCom: Review development policies - https://phabricator.wikimedia.org/T190379 (10Krinkle) a:03Krinkle [18:31:02] (03CR) 10Bmansurov: "The deploy repo doesn't have this config yet. It was only introduced in the previous patch, which hasn't been merged yet. Or do you mean s" [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478692 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [18:32:00] (03CR) 10Ppchelko: [C: 031] "nope, that's what I meant." [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478692 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [18:33:13] 10TechCom, 10TechCom-RFC: RFC: Re-establish the development policies - https://phabricator.wikimedia.org/T190379 (10Krinkle) [18:34:01] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 2 others: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10TBolliger) @Johan — Please note the new patch https://gerrit.wikimedia.o... [18:34:05] 10TechCom, 10TechCom-RFC: RFC: Re-establish the development policies - https://phabricator.wikimedia.org/T190379 (10Krinkle) p:05Triage>03Normal [18:35:04] (03CR) 10Mobrovac: Titles rejected by newFromDBKey are invalid not inexistent (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/478721 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [18:37:42] 10MobileFrontend, 10Chinese-Sites, 10Maps (Kartographer): The Chinese Wikivoyage mobile version only shows part of the map; some tiles remain white/blank - https://phabricator.wikimedia.org/T211323 (10Mholloway) I spent a good chunk of time on Friday and over the weekend attempting to reproduce this in MW-Va... [18:39:32] (03PS1) 10Tchanders: WIP Add namespaces multiselectwidget to Special:Block [core] - 10https://gerrit.wikimedia.org/r/478742 (https://phabricator.wikimedia.org/T204986) [18:41:16] 10Editing Design , 10VisualEditor (Current work): Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10Esanders) This looks fine. > a “screenshot” of the users last action is taken and cached On a technical level this may be a little misleading because... [18:41:44] 10Research: Research Showcase December 2018 - https://phabricator.wikimedia.org/T208912 (10JLaytonWMF) [18:42:09] (03PS1) 10Dduvall: Ignore blubberoid binary created by `make` [blubber] - 10https://gerrit.wikimedia.org/r/478743 [18:42:40] 10Growth-Team, 10StructuredDiscussions, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Wikimedia-production-error: Flow: InvalidDataException "Flow workflow is for different page" from WorkflowLoaderFactory.php - https://phabricator.wikimedia.org/T70526 (10Krinkle) [18:42:59] (03PS1) 10Esanders: Revert "Revert "textSelection: Use execcommand to replace text"" [core] - 10https://gerrit.wikimedia.org/r/478744 (https://phabricator.wikimedia.org/T33780) [18:43:18] (03CR) 10Esanders: [C: 04-2] "Per Bartosz:" [core] - 10https://gerrit.wikimedia.org/r/478744 (https://phabricator.wikimedia.org/T33780) (owner: 10Esanders) [18:43:47] 10Google-Code-in-2018, 10Library-Card-Platform, 10goodfirstbug: Add 'invalid' application status option - https://phabricator.wikimedia.org/T175249 (10Arcayn) Updated PR! [18:44:10] (03PS3) 10Umherirrender: build: Run mediawiki/mediawiki-codesniffer and make pass [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 [18:45:16] (03CR) 10jerkins-bot: [V: 04-1] build: Run mediawiki/mediawiki-codesniffer and make pass [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 (owner: 10Umherirrender) [18:46:15] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Regression: Pages in main namespace are being noindexed despite being older than 90 days - https://phabricator.wikimedia.org/T211043 (10kaldari) It seems to at least be sort-of working correctly. For example, these two articles were both nominated for spe... [18:49:36] (03PS4) 10Umherirrender: build: Run mediawiki/mediawiki-codesniffer and make pass [extensions/BlueSpiceCustomMenu] - 10https://gerrit.wikimedia.org/r/478347 [18:49:47] 10Google-Code-in-2018, 10Bouquet, 10CSS, 10Patch-For-Review, 10goodfirstbug: Overlapping of bullet points with the text in Advanced Search - https://phabricator.wikimedia.org/T205177 (10takidelfin) 05Open>03Resolved @Gopavasanth hmm, any problems with https://gerrit.wikimedia.org/r/c/mediawiki/skins/... [18:50:52] 10Google-Code-in-2018, 10Bouquet, 10CSS, 10Patch-For-Review, 10goodfirstbug: Overlapping of bullet points with the text in Advanced Search - https://phabricator.wikimedia.org/T205177 (10takidelfin) 05Resolved>03Open [18:51:11] :/ [18:52:03] (03CR) 10Lucas Werkmeister (WMDE): [C: 031] "(Earlier question resolved IRL.)" [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:54:36] takidelfin: what up? [18:57:06] * Urbanecm waves to everyone [18:57:14] Hello all! [18:57:36] hello! [18:57:52] Hi shreyasminocha and Ebe123! [18:58:03] and takidelfin! [18:58:13] takidelfin's here, nice! [18:58:25] * shreyasminocha greets Urbanecm in his style. ~wave~ [18:59:18] (03CR) 10Smalyshev: Do not index invalid titles (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [18:59:19] /wave [18:59:22] * takidelfin waves [18:59:23] (03CR) 10Smalyshev: [C: 032] Do not index invalid titles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [18:59:31] Urbanecm: hello! [18:59:36] Ebe123: hello! [18:59:40] Hi takidelfin! [18:59:40] takidelfin: why not set up /wave as a alias in your client [19:00:10] I am setting up my workspaces in i3 (that was a bad idea to reboot to windows) [19:00:13] :< [19:00:21] shreyasminocha: good idea :D [19:00:23] I hope everyone who claimed the deployment task added the commit(s) to the calendae :) [19:00:30] *calendar [19:00:35] :D doing rn [19:00:42] K [19:00:48] but you know how i am with calendars/reminders/todo-lists [19:01:05] Go to -operations, a bot will ping you :d [19:01:21] do i need to enter a command? [19:01:29] Urbanecm: same, I am doing it now [19:01:38] shreyasminocha: #wikimedia-operations [19:01:57] yeah, i thought i had to invoke the bot [19:01:59] No, just include your commit together with your irc nickname in the calendar [19:02:23] It will automatically load the page and ping everyone when the window starts [19:02:32] * shreyasminocha is not sure which calendar we're speaking of [19:02:49] https://wikitech.wikimedia.org/wiki/Deployments [19:02:59] Sorry, should clarified :) [19:03:24] np, i should've known [19:04:08] (03CR) 10Ppchelko: [V: 032 C: 032] Consistently name API paths [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478199 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [19:04:13] shreyasminocha: which SWAT window? [19:04:15] :D [19:04:24] (03CR) 10Ppchelko: [V: 032 C: 032] Fix comments, typos, and imports [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478201 (owner: 10Bmansurov) [19:04:33] (03PS11) 10Nray: Remove moduleLoader's event bus [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477685 (https://phabricator.wikimedia.org/T156186) [19:04:38] (03CR) 10Ppchelko: [V: 032 C: 032] Add tests for morelike API [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478234 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [19:04:42] thinking [19:04:52] (03CR) 10Ppchelko: [V: 032 C: 032] Morelike: replace request to WDQS with one to MW API [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478361 (https://phabricator.wikimedia.org/T211453) (owner: 10Bmansurov) [19:04:58] evening SWAT? [19:05:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix TitlesMultiselectWidget documentation [core] - 10https://gerrit.wikimedia.org/r/478740 (owner: 10Tchanders) [19:05:04] (03CR) 10Ppchelko: [V: 032 C: 032] Remove config [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/478692 (https://phabricator.wikimedia.org/T211423) (owner: 10Bmansurov) [19:05:14] I will probably take this: 21:00–22:00 UTC [19:05:16] 10Patch-For-Review, 10Stewards-and-global-tools (Temporary-UserRights): Remove $wgDisableUserGroupExpiry feature flag - https://phabricator.wikimedia.org/T162517 (10Jamesmontalvo3) This change seems to have made group expiry a requirement rather than optional. Personally I'd like to disable this feature (or at... [19:05:31] 10Google-Code-in-2018, 10Developer-Advocacy (Oct-Dec 2018): Organize and coordinate Wikimedia's participation in Google Code-In 2018 - https://phabricator.wikimedia.org/T203200 (10Aklapper) [19:05:33] 10Google-Code-in-2018, 10Developer-Advocacy (Oct-Dec 2018): Find Google Code-in co-admins - https://phabricator.wikimedia.org/T203231 (10Aklapper) 05Open>03Resolved Technically speaking, Aklapper, D3r1ck01, Ebe123, Florian, Mhutti1 and Reedy were admins in this #GCI-2018 round. (Personal opinion: I was als... [19:05:36] Taki, are you sure a SWAT window happens at that time; [19:05:59] https://usercontent.irccloud-cdn.com/file/udGprloG/screenshot_20181210_200550.png [19:06:05] 10OOUI, 10Patch-For-Review, 10Performance: Replace jQuery functions with native equivalents - https://phabricator.wikimedia.org/T207418 (10Jdforrester-WMF) Done in 434432324ff0ffd12718a90d9a7943eb5155f145 ish, right? [19:06:08] (maybe i'm wrong, sorry then) [19:06:19] ahh [19:06:20] okay [19:06:36] (03CR) 10Thiemo Kreuz (WMDE): Fix notice (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/478696 (owner: 10Pwirth) [19:06:52] 10Developer-Advocacy (Oct-Dec 2018): AKlapper to help CommRel triaging Community Wishlist 2018 proposals - https://phabricator.wikimedia.org/T204846 (10Aklapper) [19:07:03] That's a deployment window, but not a SWAT window [19:07:05] am going with 12:00–13:00 UTC tomorrow [19:07:13] i'm stupid :( Sorry. I missunderstood what SWAT window. [19:07:17] is [19:07:20] 10Developer-Advocacy (Oct-Dec 2018): AKlapper to help CommRel triaging Community Wishlist 2018 proposals - https://phabricator.wikimedia.org/T204846 (10Aklapper) 05stalled>03Resolved Looks like I made about 104 edits on proposals in November. Was fun. :) [19:07:30] You're not stupid, you're new to deployment ;) [19:07:33] ^ [19:07:47] shreyas, nice, looks like EU SWAT to me :) [19:08:01] 10Trust-and-Safety, 10CommRel-Specialists-Support (Oct-Dec-2018): Support for new Access Policy/Confidentiality Agreement rollout - https://phabricator.wikimedia.org/T208536 (10Quiddity) a:05Quiddity>03sguebo_WMF I did everything requested, and left notes for final followup. Re-assigning task to Samuel for... [19:08:25] yeah :) [19:08:33] it is bad... all `SWAT` windows are when I'm in school... [19:08:43] Really? [19:09:05] Including Morning or Evening ones? [19:09:11] Either when in school or in bed I guess :) [19:09:18] Morning's rn [19:09:20] Ebe123: right :( [19:09:35] my mom said I need to go to sleep earlier today [19:09:36] And he's IRC'ing in class [19:09:48] (03CR) 10Nray: Remove moduleLoader's event bus (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477685 (https://phabricator.wikimedia.org/T156186) (owner: 10Nray) [19:09:54] lol [19:09:58] Yeah, the hours of the SWAT windows aren't perfect. [19:10:02] better than texting ;) [19:10:14] Morning SWAT look like the most appropriate for those in your country taki [19:10:15] (03PS4) 10Umherirrender: Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 [19:10:18] i did irc between clasese and in free classes when school was on :D [19:10:24] was on on * [19:10:27] 10MW-1.32-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 2 others: MFA: MobileFrontend should not have a global event emitter - https://phabricator.wikimedia.org/T156186 (10nra... [19:10:29] (03PS7) 10Esanders: Remove obsolete aliases from closures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) [19:10:30] (03PS3) 10Esanders: build: Update eslint-config-wikimedia to 0.9.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/477631 [19:10:43] (03CR) 10Esanders: [C: 04-1] Remove obsolete aliases from closures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [19:10:44] Urbanecm: right :D [19:10:48] (03CR) 10Umherirrender: "Patch Set 4: Rebased" [core] - 10https://gerrit.wikimedia.org/r/461203 (owner: 10Umherirrender) [19:10:55] but I will probably go to sleep now, and wake up at 1 am [19:11:28] and after deploying changes I will go to bed again [19:11:30] i'll probably sleep at 1 am (15 min). sleeping early too :D [19:11:43] Taki, you pinged me, what you wrote? [19:11:46] takidelfin: sounds like a bad idea, but is better rthan nothing [19:12:04] you could take a window on wednesday? [19:12:16] Uh, deadlines [19:12:19] I think [19:12:31] there must be windows before the deadline? [19:12:36] i guess [19:12:40] There's one rn [19:12:47] takidelfin [19:12:52] Run! [19:13:01] * takidelfin runs [19:13:08] * takidelfin runs away [19:13:40] (03Merged) 10jenkins-bot: Do not index invalid titles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [19:13:50] i'd take one tomorrow [19:13:54] Catch the train; get thhrough the window! [19:14:34] Urbanecm: hmm, PuppetSWAT ? [19:14:51] funny name [19:14:51] `PuppetSWAT patches should be: [19:14:51] Trivial in complexity. [19:14:51] Easy to verify and test for people who are not in the Operations team. [19:14:51] (Preferred) At least one Code-Review +1 from someone familiar with the area of code the patch is changing.` [19:15:21] "at least one +1" [19:15:24] really? that's it? [19:15:49] 10MediaWiki-Templates, 10Crosswiki: Find out whether people are interested in supporting Global Templates - https://phabricator.wikimedia.org/T207766 (10Whatamidoing-WMF) 05Open>03Resolved No obvious interest in this subject at enwiki [19:15:57] "Trivial in complexity" is the key point [19:16:11] ah [19:16:31] my commit says "(Merge conflict)" do i need to fix it, or should i not worry? [19:17:26] Don't worry (yet) [19:17:54] takidelfin, puppet SWAT is a wrong one - that's for changes in operations/puppet [19:17:56] shreyasminocha, you don't need to - it might be false alarm [19:17:58] at worse, a deployer will tell you if it's unmergable [19:18:22] shreyasminocha, if you wanna do some preps, read https://wikitech.wikimedia.org/wiki/X-Wikimedia-Debug and learn how to connect to the debug servers [19:18:38] oh okay [19:18:39] a deployer might want you to test the change on the debug servers before it's deployed worldwide [19:19:43] * Urbanecm don't see any commits in the calendar (yet) :) [19:20:26] * shreyasminocha is figuring out the calendar :D [19:20:34] when I deployed a new logo, the actual site first didn't update because of my browser cache [19:20:47] I freaked out for a minute [19:21:03] browser cache is always a pain [19:21:17] cache in general [19:21:23] idea: create a separate profile (in chrome) for dev work [19:21:31] (03CR) 10Lucas Werkmeister (WMDE): "Okay, thanks! According to codesearch, not too many extensions seem to refer to the namespace, so this should be doable." [core] - 10https://gerrit.wikimedia.org/r/478729 (https://phabricator.wikimedia.org/T211608) (owner: 10Lucas Werkmeister (WMDE)) [19:21:42] better idea: Check with ctrl+shift+r :) [19:22:00] (maybe) better idea [19:22:02] easy to forget [19:22:17] ⌘-shift-R [19:22:18] (03PS2) 10Milimetric: Merge subscriber functionality into core module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) [19:22:24] (03Merged) 10jenkins-bot: Fix TitlesMultiselectWidget documentation [core] - 10https://gerrit.wikimedia.org/r/478740 (owner: 10Tchanders) [19:22:41] * Urbanecm doesn't use Mac [19:22:44] Ebe123: my man [19:22:44] (03CR) 10Milimetric: "Thanks for the review! Thoughts inline." (034 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [19:23:19] hope i added myself to the calendar correctly [19:23:27] let me check [19:24:01] or ctrl shift n :D [19:24:14] (03CR) 10jerkins-bot: [V: 04-1] Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 (owner: 10Umherirrender) [19:24:20] shreyasminocha, you did, but https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/478034 is missing [19:24:30] :O [19:24:30] ?action=purge for MW cache [19:24:46] hah, I have got one beginner task left :D [19:24:46] fixing [19:25:09] (03CR) 10jenkins-bot: Fix TitlesMultiselectWidget documentation [core] - 10https://gerrit.wikimedia.org/r/478740 (owner: 10Tchanders) [19:25:12] What will you choose, takidelfin? [19:25:15] takidelfin uses his trap card [19:25:17] 10OOUI, 10Patch-For-Review, 10Performance: Replace jQuery functions with native equivalents - https://phabricator.wikimedia.org/T207418 (10Esanders) I agree, we should follow eslint-config-wikimedia on what jQuery functions are allowed, which is what the above patch did. > with native equivalents where poss... [19:25:26] (GCI claims peroid ended btw) [19:25:31] (03CR) 10jenkins-bot: Do not index invalid titles [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478713 (https://phabricator.wikimedia.org/T208932) (owner: 10DCausse) [19:25:37] so, hehe, I basically lost one free task :D [19:25:51] * takidelfin doesn't use his trap card [19:26:01] * takidelfin hides [19:26:04] You're on the leaderboard, so it's meaningless [19:26:20] yup :D [19:26:44] In fact, it could play in your favour as you aren't diluting all your significant tasks with easy stuff [19:26:54] jk [19:26:56] * shreyasminocha comes out from hiding [19:27:09] Wait a moment... [19:27:15] * takidelfin thinking [19:27:29] takidelfin goes in and shreyasminocha comes out [19:27:31] * 🤔 [19:27:33] :O [19:27:45] * shreyasminocha doesn't fully comprehend what's going on [19:27:48] maybe shreasminocha is me too [19:27:52] he is cheating! [19:27:58] #MeToo? [19:28:05] That way, you mighht get 2 trips to california [19:28:10] ;;;-;;; [19:28:30] there are two batches iirc [19:28:33] A and B [19:28:46] 🤔v2 [19:28:49] * Urbanecm joined #MeToo just to check if there's something :D [19:28:54] :D [19:29:02] `#MeToo: Cannot join channel (+b) - you are banned` [19:29:04] (and yes, there's, an autobanner) [19:29:07] * shreyasminocha joins #MeToo too [19:29:14] someone's trolling us lol [19:29:14] Sorry men [19:29:17] My frist ban on IRC [19:29:23] lol [19:29:29] #MeToo (I mean getting banned :D) [19:29:45] I think it's because of znc takidelfin [19:29:48] same for me [19:29:53] idts [19:29:58] someone's just trolling us [19:30:00] hi though TheJair [19:30:05] hi shreyasminocha [19:30:07] I think it's because the channel is closed [19:30:10] hi TheJair [19:30:10] just lurking lol [19:30:15] hi Urbanecm [19:30:25] /TheJair comes out of hiding, more like [19:30:32] lol [19:30:32] :D [19:30:38] * Ebe123 leads TheJair out of his hiding-spot [19:30:57] * shreyasminocha leads TheJair to the stage [19:31:03] in the spotlight [19:31:10] I thought I was banned and now I get this [19:31:10] Theatre kids [19:31:10] You have been kicked from #metoo by ChanServ (This channel has been closed) [19:31:29] * TheJair Is nervous [19:31:44] TheJair has a performance prepared for us [19:31:51] Dis merde! [19:31:56] Pierogi! [19:32:00] This Merge [19:32:06] lol [19:32:09] +1 [19:32:19] (probably doesn't match the original meeting) [19:32:22] * TheJair Didn't learn his speech well as usual [19:32:23] lol [19:32:23] *meaning [19:32:34] https://en.wiktionary.org/wiki/je_te_dis_merde#French [19:32:36] "break a leg" apparently [19:32:50] (03PS1) 10Alexia: Can't call escaped() on a string. [core] - 10https://gerrit.wikimedia.org/r/478749 (https://phabricator.wikimedia.org/T211442) [19:32:50] shreyasminocha, https://wikitech.wikimedia.org/w/index.php?title=Deployments&diff=1810671&oldid=1810670 is wrong [19:32:59] you can add more patches under a single {{ircnick|aaa}} header [19:33:06] whoops [19:33:08] 10Collection, 10Electron-PDFs, 10Wikimedia-production-error (Shared Build Failure): SpecialPageFatalTest::testSpecialPageDoesNotFatal is risky in Collection extension - https://phabricator.wikimedia.org/T209614 (10Krinkle) At https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ElectronPdfService/+/473485... [19:33:41] Outside of coding, you guys do performing arts? [19:33:57] not me [19:34:30] Ebe123: i guess you play an instrument? [19:34:30] yes, writing commit messages with emojis on github :D [19:34:39] lol [19:34:39] Or theatre [19:34:41] is instrument an art as well? [19:34:49] I have played guitar but quit a couple years ago [19:34:53] You perform, and music is an art :) [19:34:56] performing art [19:35:07] ¯\_(ツ)_/¯ [19:35:10] (03CR) 10jerkins-bot: [V: 04-1] Merge subscriber functionality into core module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [19:35:25] * Urbanecm finally +1'ed takidelfin's config patches [19:35:38] 🎉 [19:35:51] * takidelfin is learning to play on Tableheld Portable MIDI device (P.I.A.N.O) [19:35:52] (03CR) 10Urbanecm: [C: 032] Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 (owner: 10Arcayn) [19:36:06] Urbanecm: ^-^ [19:36:25] do you guys play sports? [19:36:44] No [19:36:49] paladox, I guess the gerrit version we run still doesn't support web editing? [19:36:52] soccer/ I run sometimes [19:36:54] wby? [19:36:58] (03Merged) 10jenkins-bot: Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 (owner: 10Arcayn) [19:37:07] I just walk 5k and call that enoughh [19:37:08] no :p [19:37:14] Ebe123: :D [19:37:25] i run decently, but i run less than i should [19:37:29] I'm playing hide'n seek with semicolons [19:37:34] (03PS3) 10Urbanecm: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [19:37:38] i guess that counts as a sport :D [19:37:40] (03CR) 10jerkins-bot: [V: 04-1] Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [19:37:57] Portable Instrument of Acoustic Notation Operation ? [19:38:00] A thinking sport called programming [19:38:00] PIANO [19:38:10] wow, never heard that [19:38:22] Ebe123: :D [19:38:22] Urbanecm: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478662, hmm, looks like +2 does not work [19:38:33] Wait a moment [19:38:47] When does somebody get to give 2+? [19:38:56] aha [19:38:58] *to be able to [19:39:01] when they have the rights [19:39:03] They get nominated on Phabricator [19:39:03] takidelfin, it's blocked on https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478423 [19:39:09] when they contribute sufficiently to the project [19:39:14] and then a waiting period of a week [19:39:16] and global +2 is Phab nominated i think [19:39:23] Urbanecm: oops, I forgot [19:39:25] d3r1ck recently got his global +2 [19:39:29] ^ [19:39:31] do you have to get nominated by other people? [19:39:35] nvm [19:39:36] Any WMF extension is Phab-nominated [19:39:44] oh [19:39:51] shreyasminocha, it's better to say "mediawiki/* +2" [19:39:52] my bad [19:39:53] So I got nominated for WikimediaIncubator and Score [19:39:53] https://phabricator.wikimedia.org/T209775 [19:40:02] shhhh I'm hiding [19:40:14] for example, IIRC, d3r1ck (or anybody else with +2 on mediawiki/*) can't +2 patches on Tracker [19:40:14] Get better soon! [19:40:15] sorry for summoning you d3r1ck [19:40:19] * takidelfin hides faster than d3r1ck [19:40:30] ┬┴┬┴┤ ͜ʖ ͡°) [19:40:39] * shreyasminocha hides [19:40:43] * shreyasminocha covers his camera [19:40:46] TheJair, you can in theory nominate yourself, but usually you get nomination from others [19:41:04] shreyasminocha, did you cover your microphone? [19:41:10] :O [19:41:11] * Urbanecm just found shreyasminocha, takidelfin and others who were hidden [19:41:19] :O [19:41:22] And then people that already have the 2+ have to vote? [19:41:30] No [19:41:37] everyone can comment on the nomination [19:41:38] It's more "anyone opposed"? [19:41:49] ah [19:41:51] and if there are any reasonable objections, the nomination might be rejected [19:41:56] if there are not, it's approved [19:42:09] shreyasminocha: remember about covering your with Flex tape [19:42:10] 10Mathe für Nicht-Freaks: Artikel "Lineare Abbildungen" - https://phabricator.wikimedia.org/T209966 (10Kulla) a:05Matheoldie>03None [19:42:11] cool [19:42:25] interesting 🤔 [19:42:27] (03PS5) 10Umherirrender: Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 [19:42:38] (03CR) 10Urbanecm: [C: 031] "LGTM, blocked on parent change" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478662 (https://phabricator.wikimedia.org/T211144) (owner: 10Takidelfin) [19:42:40] * shreyasminocha comes out. wait a minute... no he doesn't. [19:42:50] wait a minute... [19:42:52] takidelfin, I changed my +2 on your patch to +1 [19:43:19] I'd probably need to re-+2 it anyway once https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478423/6 is merged, as it triggers the gate-and-submit jobs that are needed [19:43:25] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Anomie) I don't see anything in the SAL around that time period either. Your suspicion that it had to do with the thrott... [19:43:32] * shreyasminocha is straight just to clarify :D [19:44:10] shreyasminocha, it'd be strange if you were round [19:44:23] :D i see what you did there [19:44:24] Urbanecm: if Bjornskjlajd will not finish this patch, Could I finish it? [19:44:39] yeah, or help bjornskjald to finish it :) [19:44:45] but I hope he'll get this done [19:44:52] Can't claim it though :) [19:45:36] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: The 'your password is weak' message should only display on log in for privileged accounts - https://phabricator.wikimedia.org/T211621 (10TBolliger) p:05Triage>03High [19:45:48] Urbanecm: yeah, I hope it too. He is my friend, so I will of course help him! [19:46:26] going through `X-Wikimedia-Debug`. can i, in theory, have any HTTP header? [19:46:52] Yes [19:47:02] You control what is sent from your computer [19:47:20] But I'm worried that he (hmm, how to say it?) abandonned GCI for now. So I am just asking if there is a possibility. I'm gonna contact with him, maybe he needs help (but he is good, so I don't think so :D) [19:47:28] :O i thought there was a set of few that were permitted [19:47:31] Exams probably [19:47:48] What do you mean shreyasminocha ? [19:47:48] yeah, he had 4 contests at a time iirc [19:47:55] http headers [19:48:05] shreyasminocha, HTTP is just a text [19:48:12] (HTTP 1.1, to be precise) [19:48:16] bjornskjald rn https://usercontent.irccloud-cdn.com/file/6qHmErXq/screenshot_20181210_204802.png [19:48:18] i thought there were some defined by some RFC somewhere and those were the only sacrosanct ones [19:48:24] if you want to, you can send HTTP requests via telnet [19:48:39] shreyasminocha, yup, but IIRC the RFC also defines X-* as custom headers [19:48:47] :O [19:48:47] similar to data-* HTML attributes [19:48:49] 10MediaWiki-Page-editing, 10CommRel-Specialists-Support (Oct-Dec-2018): Support the Editing team in their changes to classic edit toolbar - https://phabricator.wikimedia.org/T163929 (10Whatamidoing-WMF) 05Open>03Resolved [19:48:52] but still [19:48:54] thanks for the analogy [19:49:01] 10MediaWiki-Page-editing, 10JavaScript, 10MW-1.32-notes, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Whatamidoing-WMF) [19:49:06] :O [19:49:07] it doesn't prevent me (technically) to send any HTTP header with my request [19:49:09] takidelfin: lol [19:49:19] ah [19:49:19] it might violate RFC [19:49:23] but still technically possible :) [19:49:26] is it the same with methods? [19:49:40] You can type anything! [19:49:42] can i send a request with a DANCE method? [19:49:50] No guarantees it'll work though [19:49:50] DANCE? [19:49:52] shreyasminocha, you can send it, but noone would understand it [19:49:59] (probably) [19:50:05] * challenge accepted [19:50:06] but you can build a HTTP server that will understand it [19:50:08] ❯ http DANCE google.com [19:50:08] HTTP/1.1 405 Method Not Allowed [19:50:09] MediaWiki patch to implement DANCE [19:50:14] :D [19:50:15] lol [19:50:20] (03PS1) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [core] - 10https://gerrit.wikimedia.org/r/478752 (https://phabricator.wikimedia.org/T211154) [19:50:23] Like GET, but with more randomness [19:50:37] lol [19:50:40] and a bit slower [19:50:44] I'd simply return HTTP 418 with it [19:50:45] `sudo apt install httpie` [19:50:45] Interesting name [19:50:52] It's the process, not the result [19:50:52] httpie [19:50:55] that's i'm a teapot, isn't it [19:50:58] yeah [19:50:58] yes [19:51:07] takidelfin: httpie is good stuff [19:51:11] Urbanecm: lol [19:51:16] shreyasminocha, you remember all the codes? [19:51:21] ` the server refuses to brew coffee because it is a teapot.` [19:51:24] wonder who snuck that in [19:51:29] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: Change password length requirement and ensure enforcement for non-privileged users (from 1 to 8) - https://phabricator.wikimedia.org/T211622 (10TBolliger) 05Open>03stalled p:05Triage>03High [19:51:31] Urbanecm: that'd be cool, but no :D [19:51:31] ^ [19:51:44] shreyasminocha, you don't want to dance with a teapot? :D [19:52:01] with my current relationship situation, i might be some time :D [19:52:02] honestly, I know only about one server who sends HTTP 418 some times. [19:52:04] my own server :D [19:52:12] :D [19:52:13] I'm a little teapot, short and stout! [19:52:15] ... [19:52:17] :D [19:52:27] this is my handle and this is my spout? [19:52:32] What does `stout` mean? [19:52:35] fat [19:52:42] 10MediaWiki-User-login-and-signup, 10Anti-Harassment (AHT Sprint 35): Change password length requirement and ensure enforcement for privileged users (from 8 to 10) - https://phabricator.wikimedia.org/T208246 (10TBolliger) [19:52:48] takidelfin, standard output [19:52:54] (should be stdout I think) [19:52:56] "This error is a reference of Hyper Text Coffee Pot Control Protocol which was an April Fools' joke in 1998." [19:53:07] 10CommRel-Internals: CE Insights support: Copyedit questions - https://phabricator.wikimedia.org/T211623 (10Whatamidoing-WMF) [19:53:07] wait, maybe not [19:53:08] (yup, I thought about stdout too) [19:53:21] :D thought y'all were kidding [19:53:21] ooks it's a word :D [19:53:23] sorry :D [19:53:37] 10CommRel-Internals: CE Insights support: Copyedit questions - https://phabricator.wikimedia.org/T211623 (10Whatamidoing-WMF) [19:53:50] Hyper text toaster protocol [19:53:54] 10CommRel-Internals: CE Insights support: Copyedit questions - https://phabricator.wikimedia.org/T211623 (10Whatamidoing-WMF) Initial copyediting completed. [19:53:55] need to draft that up [19:53:57] When I was little, my mom could not participate in singing with other parents in my daycare because we were French (and thus didn't know any of the songs) [19:53:59] shreyasminocha: teach me master [19:54:09] https://en.wikipedia.org/wiki/Stout [19:54:27] * takidelfin fells of the wall agaain [19:54:37] This server refuses to fry eggs because it is a toaster [19:54:40] Ebe123: lol [19:54:41] (03PS1) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478756 (https://phabricator.wikimedia.org/T211154) [19:54:44] Ebe123: lol [19:55:38] section 2.3.2: [19:55:39] Any attempt to brew coffee with a teapot should result in the error [19:55:39] code "418 I'm a teapot". The resulting entity body MAY be short and [19:55:39] stout. [19:55:54] https://tools.ietf.org/html/rfc2324#section-2.3.2 [19:55:57] (03CR) 10jerkins-bot: [V: 04-1] Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 (owner: 10Umherirrender) [19:56:03] https://developer.mozilla.org/en-US/docs/Web/HTTP/Status [19:56:04] pot-designator = "pot-" integer ; for machines with multiple pots [19:56:05] additions-list = #( addition [19:56:31] 10CommRel-Internals: CE Insights: Prioritize team questions for CE Insights - https://phabricator.wikimedia.org/T211624 (10Whatamidoing-WMF) [19:56:48] * takidelfin tried joinin #( [19:56:52] "Because coffee is international, there are international coffee URI [19:56:52] schemes." [19:56:56] takidelfin: lol [19:57:34] `The "message/coffeepot" media type`, wow didn't know that was a thing [19:57:37] (03PS4) 10Urbanecm: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [19:57:38] 10CommRel-Internals: CE Insights: Prioritize team questions for CE Insights - https://phabricator.wikimedia.org/T211624 (10Whatamidoing-WMF) [19:57:50] god, this section is gold [19:58:08] back to work: Can anyone review https://gerrit.wikimedia.org/r/478482? [19:58:42] sure [19:59:12] sure^2 [19:59:35] oh, grammar patch... Sorry, I can't :( I will try Grammarling it tho [19:59:40] (03PS1) 10Esanders: Enable eslint-config-wikimedia and fix errors [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478757 [19:59:50] 10MediaWiki-Special-pages, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10CCicalese_WMF) [20:00:11] Urbanecm, LGTM [20:00:12] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10CCicalese_... [20:00:20] (03CR) 10Shreyasminocha: [C: 031] Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:00:21] ditto [20:00:21] takidelfin, shouldn't it be sure²? ;) [20:00:46] $$\sure^2$$ [20:01:02] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10Dbrant) @cmadeo A very general design question stemming from this task: In your mock, the negative dialog button ("Maybe... [20:01:21] Urbanecm: :D https://usercontent.irccloud-cdn.com/file/6YDZXBUg/screenshot_20181210_210109.png [20:01:48] (I meant ^2) [20:02:26] oops, i was wrong too [20:02:43] forgetting how custom symbols work [20:04:06] (03PS6) 10Umherirrender: Pass language to Status::getWikiText [core] - 10https://gerrit.wikimedia.org/r/461203 [20:04:19] * shreyasminocha was to sleep early [20:04:40] bawolff's curse, i think, it is [20:04:58] (03CR) 10Urbanecm: [C: 032] Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:05:02] (03PS1) 10Dbrant: Dialog with customized title plus image. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478764 [20:05:05] shreyasminocha, don't forget about Unicode's Private Use Spaces [20:05:05] thank you everyone for reviewing, +2'ed [20:05:13] private use spaces? [20:05:14] what's that? [20:05:32] some characters are reserved [20:05:37] So that people/orgs can create their own characters [20:05:46] and assign them to codes [20:06:00]  does this look like an apple? [20:06:26] I see F8FF in a square [20:06:27] lol, asking your students to review you just to +2 [20:06:31] (03PS5) 10Urbanecm: Fix grammar messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:06:42] (03CR) 10Urbanecm: [C: 032] Fix grammar messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:06:43] U+E000–U+F8FF [20:07:00] on apple devices that'd be an apple [20:07:11] an  a day keeps the doc away [20:07:27] U+E000–U+F8FF [20:07:31] 🍎 [20:07:32] looks like a apple to me [20:07:44] now I see an apple [20:07:52] the one above. [20:07:57]  vs 🍎 vs 🍏 [20:08:10] first is the apple logo (to me / us) [20:08:10] yeah these last 2 [20:08:12] (03CR) 10Takidelfin: Fix grammar messages in views.py (0311 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:08:16] (03CR) 10Bartosz Dziewoński: [C: 032] Enable eslint-config-wikimedia and fix errors [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478757 (owner: 10Esanders) [20:08:35] Apple likes to "act different" [20:08:37] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Forgot the #" [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478756 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [20:08:39] lol [20:08:39] (03Merged) 10jenkins-bot: Fix grammar messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [20:08:49] Urbanecm: umm, there should be `succes*s*fully` at the end of the file [20:08:55] apple is a kid with "different" needs [20:09:12] oh no [20:09:16] it got merged [20:09:17] or a control freak [20:09:17] takidelfin, opps... [20:09:27] we need a new patch [20:09:30] (03PS2) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [core] - 10https://gerrit.wikimedia.org/r/478752 (https://phabricator.wikimedia.org/T211154) [20:09:30] :> [20:09:31] sure [20:09:32] TheJair: that too :D [20:09:47] with one patch you'd be a pirate [20:09:51] with two you'd be blind [20:10:51] with three you'd be a developer [20:10:53] With 3 you need a stick [20:11:02] or a dog [20:11:25] :D [20:11:33] or you need to take off VR headset [20:11:49] How does VR work if you can't see to begin with? [20:11:54] audio [20:11:56] 10Patch-For-Review: LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) Verified coexistence with Wikibase, which is ok. Have not verified whether there were changes in reported errors from tests. Wikibase started as ([[ https://www.mediaw... [20:12:01] camera [20:12:03] and movement i guess [20:12:11] Take off your earbuds [20:12:12] and olfactory too actually [20:12:20] Headsets can do thaht [20:12:23] I'm out of the loop now [20:12:24] Take off your noseplugs too [20:12:24] ;-; [20:12:30] olfactory = smell [20:12:37] VR for people that are blind, seems like a million dollar idea [20:12:46] i agree [20:12:47] ah, true [20:12:57] * takidelfin hides and cries [20:12:58] VR for the blind is just headphones [20:13:00] but their other senses are pretty darn strong from what i hear [20:13:04] something that connects to the brain directly? [20:13:12] no, i mean smell, movement [20:13:19] Brain slugs! [20:13:26] :O [20:13:32] https://theinfosphere.org/Brain_slugs [20:13:53] Got to go though; I'll be back in a few hours [20:13:56] (03CR) 10Jforrester: [C: 032] Avoid deprecated OO.ui.infuse( id ) [core] - 10https://gerrit.wikimedia.org/r/478752 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [20:14:12] Ebe123: o/ [20:14:59] (03PS1) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [20:16:29] (03CR) 10jerkins-bot: [V: 04-1] WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [20:16:36] * shreyasminocha heads to bed for real [20:16:44] gn [20:17:20] shreyasminocha: goodnight! [20:18:47] Urbanecm: hmm, If I'll come 35 minutes after 1pm (when SWAT window starts), will be it a problem? [20:18:55] gn shreyasminocha [20:19:09] Because I can't find better 'frame' [20:19:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [20:19:14] `European Mid-day SWAT` [20:19:29] takidelfin, might be, the deployer can say "well, only takidelfin has patches, takidelfin's not around, I'll go to bed" [20:23:11] (03PS2) 10Kosta Harlan: WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) [20:23:39] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering: Trim initial and trailing whitespace from captions on input and display - https://phabricator.wikimedia.org/T209736 (10daniel) Not all API modules use ChangeOpDeserializers. All *should* use that, but not all do. Especially the one for creating entit... [20:25:19] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: wbgetentities has stopped returning content on Beta Cluster Commons - https://phabricator.wikimedia.org/T211237 (10daniel) If this becomes urgent, I could probably dig in. I'd need good justification to spend time... [20:25:48] (03PS4) 10Niedzielski: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [20:25:57] (03CR) 10jerkins-bot: [V: 04-1] WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [20:26:38] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike 16hrs] Investigate opt-in audience and instrumentation - https://phabricator.wikimedia.org/T211195 (10Tbayer) [20:26:40] Urbanecm: Problem solved :D [20:26:43] (03CR) 10jerkins-bot: [V: 04-1] WIP: Help Panel: Add API module to post questions [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478769 (https://phabricator.wikimedia.org/T211370) (owner: 10Kosta Harlan) [20:26:48] how? [20:26:50] I'm not going to school tomorrow :P [20:27:04] I know it sounds bad... [20:27:18] but, I don't have choice :/ [20:27:36] what should i say... [20:27:53] (03Merged) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [core] - 10https://gerrit.wikimedia.org/r/478752 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [20:28:27] I'm not bad at school, so it is not a problem for me /o [20:28:29] 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike 16hrs] Investigate opt-in audience and instrumentation - https://phabricator.wikimedia.org/T211195 (10Tbayer) Is the opt-in/out status going to be stored in the user preferences (for logged-in use... [20:28:30] \o/ [20:29:57] (03PS1) 10Aaron Schulz: rdbms: reduce LoadBalancer replication log spam [core] - 10https://gerrit.wikimedia.org/r/478773 (https://phabricator.wikimedia.org/T204531) [20:30:29] 10Research: Write an "Image Analysis Component" proposal for the 3-5 year plan - https://phabricator.wikimedia.org/T211339 (10leila) p:05Triage>03Normal [20:30:44] (03CR) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [core] - 10https://gerrit.wikimedia.org/r/478752 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [20:30:48] Tomorrow you don't go to class, next year you'll be out on the street doing cocaine. [20:32:26] D: [20:32:57] * takidelfin hides and cries again [20:33:46] * shreyasminocha is on irc while checking his phone [20:33:54] * while brushing [20:34:17] * shreyasminocha politely urges takidelfin to not bunk [20:34:20] Heavy multitasking could lead to memory loss! [20:34:41] i'm sorry, where was is? [20:34:42] (03CR) 10Niedzielski: "Thank you for this change! Please see question inline." (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [20:34:43] 10MediaWiki-Parser, 10Math: Inclusion of template containing div tag in page containing math tags causes parser to drop paragraph tags - https://phabricator.wikimedia.org/T132314 (10Pkra) 05Open>03declined Please re-open this issue if the problem persists. [20:34:59] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to enroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Matiia) The ones Praxidicae told me that she tried: Mediawikiwiki and snwiki. [20:35:42] (03CR) 10ArielGlenn: "Do we want to just lose *all* the messages though?" [core] - 10https://gerrit.wikimedia.org/r/478773 (https://phabricator.wikimedia.org/T204531) (owner: 10Aaron Schulz) [20:36:27] d3r1ck (to avoid bothering Urbanecm again): [20:36:27] Hi! Could you review my "SWAT Deploy" entry? https://wikitech.wikimedia.org/w/index.php?title=Deployments&type=revision&diff=1810682&oldid=1810672 [20:37:03] takidelfin, it's in opposite order [20:37:16] (looks it's in opposite order for shreyasminocha's entry too) [20:37:33] the change in /static must be deployed first, the change of is.php second [20:37:35] (03PS2) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478756 (https://phabricator.wikimedia.org/T211154) [20:37:37] (03PS2) 10Esanders: Enable eslint-config-wikimedia and fix errors [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478757 [20:38:07] takidelfin: Sir, can I have a look at it tomorrow, not in the best state now, please! [20:38:53] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: wbgetentities has stopped returning content on Beta Cluster Commons - https://phabricator.wikimedia.org/T211237 (10Jdforrester-WMF) >>! In T211237#4811844, @daniel wrote: > If this becomes urgent, I could probably... [20:39:29] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10cmadeo) @Dbrant, my apologies, I had carried this over from iOS without checking Android. Please keep both buttons the sam... [20:39:53] d3r1ck: sorry :( [20:40:12] takidelfin: It's okay, I'll have a look at it first thing tomorrow morning. [20:40:29] If someone else has not reviewed before then, okay? [20:40:36] * Urbanecm already reviewed it [20:40:50] Urbanecm: Thank you, a lot! [20:41:02] yw [20:41:14] * d3r1ck checks out! [20:42:33] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: wbgetentities has stopped returning content on Beta Cluster Commons - https://phabricator.wikimedia.org/T211237 (10daniel) > This is UBN. WBMI on Beta Commons is useless (no edits possible at all). So the prio is... [20:45:57] (03PS1) 10Jforrester: [DNM][MediaInfo] Depend on the Commons role and apply this there, not everywhere [vagrant] - 10https://gerrit.wikimedia.org/r/478777 [20:46:44] (03CR) 10jerkins-bot: [V: 04-1] [DNM][MediaInfo] Depend on the Commons role and apply this there, not everywhere [vagrant] - 10https://gerrit.wikimedia.org/r/478777 (owner: 10Jforrester) [20:49:38] (03PS5) 10Shreyasminocha: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) [20:50:16] Urbanecm: thank you for the review ^-^ Also sorry to D3rrick for pinging him :( [20:50:16] Fixed this order issue [20:50:50] lgtm now [20:52:47] 04(no projects): Enhance Random + Queuing - https://phabricator.wikimedia.org/T211630 (10Ethanpet113) [20:53:02] 10TechCom, 10TechCom-RFC, 10Performance-Team (Radar): RFC: Re-establish the development policies - https://phabricator.wikimedia.org/T190379 (10Imarlier) [20:53:50] 04(no projects): Enhance Random + Queuing - https://phabricator.wikimedia.org/T211630 (10Ethanpet113) [20:53:54] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Watching / External), 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona)... [20:58:07] (03PS3) 10Milimetric: Merge subscriber functionality into core module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) [21:00:46] (03PS3) 10Cooltey: [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) [21:04:43] 10MediaWiki-Logging, 10Dumps-Generation, 10Performance-Team, 10Wikidata, and 3 others: Wikidata dumps creating large amounts of log spam - https://phabricator.wikimedia.org/T204531 (10Imarlier) a:03aaron @aaron is going to see what else can be done to reduce spam, will then assign back to @ArielGlenn [21:05:43] (03CR) 10Bartosz Dziewoński: [C: 032] Avoid deprecated OO.ui.infuse( id ) [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478756 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [21:06:05] (03CR) 10Bartosz Dziewoński: [C: 032] Enable eslint-config-wikimedia and fix errors [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478757 (owner: 10Esanders) [21:07:47] shreyasminocha: psst... Urbanęcm said that our list of patches in SWAT window in in reverse order [21:09:01] I think he might have gone to bed [21:09:25] hmm, you are right [21:09:32] it is ~ 2 am for him [21:09:46] (03Merged) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478756 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [21:09:49] (03Merged) 10jenkins-bot: Enable eslint-config-wikimedia and fix errors [extensions/ForcePreview] - 10https://gerrit.wikimedia.org/r/478757 (owner: 10Esanders) [21:10:00] I'm gonna do that `big Tracker change` now :D [21:11:30] the no PM approvel needed ones? [21:12:01] I'm doing it just for fun [21:12:05] * takidelfin shrugs [21:12:10] 10Discovery-Search (Current work), 10Epic: [EPIC] Transform wikidata autocomplete click logs into a useful dataset - https://phabricator.wikimedia.org/T205111 (10debt) [21:12:11] (and to learn Tracker better) [21:12:14] 10Discovery-Search (Current work), 10Patch-For-Review: Build pipeline to transform elastic explains into feature vectors and a tf graph - https://phabricator.wikimedia.org/T208917 (10debt) 05Open>03Resolved [21:12:21] yeah I know, I was thinking of doing one of those as well [21:12:40] (Tracker - Django + DRF, I mean) [21:13:34] 10Wikistorm: Reduce runtime of "Links naar doorverwijspagina's" update script - https://phabricator.wikimedia.org/T208059 (10Edoderoo) 05Open>03Resolved [21:14:58] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: Introduce SearchQuery - https://phabricator.wikimedia.org/T189880 (10debt) [21:15:00] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work), 10MW-1.32-notes (WMF-deploy-2018-09-25 (1.32.0-wmf.23)), and 2 others: Introduce rewrite/second-try strategies - https://phabricator.wikimedia.org/T204255 (10debt) 05Open>03Resolved [21:17:16] takidelfin, nice way to obfuscate my nickname :) [21:18:49] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: The 'your password is weak' message should display on log in for privileged accounts only - https://phabricator.wikimedia.org/T211621 (10jrbs) [21:19:06] (03PS4) 10Milimetric: Merge subscriber functionality into core module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) [21:19:11] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: The 'your password is weak' message should display on log in for privileged accounts only - https://phabricator.wikimedia.org/T211621 (10jrbs) (Just changing to grammatically reflect what this task appears to be for :) [21:19:18] hehe [21:19:24] funny [21:23:01] (03PS5) 10Milimetric: Merge subscriber functionality into core module [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) [21:23:51] (03CR) 10Milimetric: "apologies for the spam, catching up with how jsduck works and tweaking the comments. You can go straight to PS5 when you review." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:24:08] 10Editing Design , 10VisualEditor (Current work): Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10iamjessklein) [21:24:58] 10Phabricator: Add a link from Phabricator task to a Gerrit search for bug:TXXXXX - https://phabricator.wikimedia.org/T209463 (10Krinkle) See also , which provides this in an even nicer way (on workboard views). [21:25:32] 10Growth-Team (Current Sprint): Design tweaks to the Help panel - https://phabricator.wikimedia.org/T211633 (10RHo) [21:26:27] 10Google-Code-in-2018, 10MediaWiki-API, 10MediaWiki-Watchlist, 10Growth-Team: Fix incorrect & fields for RSS feed for watchlist - https://phabricator.wikimedia.org/T210920 (10LukBukkit) I can't reproduce the problem, because MediaWiki assigns a diff number to every small change (protection fo... [21:34:06] 10Editing Design , 10VisualEditor (Current work): Design Mockups for Overlay to manage performance expectations - https://phabricator.wikimedia.org/T211595 (10iamjessklein) Thanks @Esanders I tweaked the copy above to try to (hopefully) avoid any confusion. [21:35:27] 10MediaWiki-extensions-OnlineStatusBar: Convert OnlineStatusBar to use extension registration - https://phabricator.wikimedia.org/T204313 (10Petrb) p:05Triage>03Low [21:38:49] 10MediaWiki-extensions-LoginNotify: LoginNotify should expose the "is this an untrusted login?" check as a service - https://phabricator.wikimedia.org/T211542 (10Niharika) [21:39:32] (03PS10) 10Nray: Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:40:03] 10MediaWiki-extensions-PageAssessments: Store each assessment instead of just current one - https://phabricator.wikimedia.org/T211485 (10Niharika) [21:43:56] (03CR) 10Mooeypoo: [C: 04-1] WIP Add namespaces multiselectwidget to Special:Block (034 comments) [core] - 10https://gerrit.wikimedia.org/r/478742 (https://phabricator.wikimedia.org/T204986) (owner: 10Tchanders) [21:43:56] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: [BUG] Field info popups get weird if user scrolls while popup is open - https://phabricator.wikimedia.org/T203559 (10Niharika) 05Open>03Resolved This seems... [21:47:49] (03CR) 10Mooeypoo: [C: 04-1] WIP Add namespaces multiselectwidget to Special:Block (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478742 (https://phabricator.wikimedia.org/T204986) (owner: 10Tchanders) [21:48:08] (03PS6) 10Bartosz Dziewoński: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [21:49:31] (03PS8) 10Sharvaniharan: Add edit tasks menu option [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475970 (https://phabricator.wikimedia.org/T209499) [21:50:16] (03PS11) 10Nray: Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:50:19] (03CR) 10Bartosz Dziewoński: "@Nouman We were looking for something like this – moving the new code into the ReCaptchaNoCaptcha directory and registering it in its exte" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [21:51:32] (03CR) 10Nouman: "@Bartosz Dziewoński don't mind at all -- thank you! I'll give this a try tonight and report back." [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [21:52:35] (03CR) 10Nray: "PS 10 - I rebased this patch onto the latest from master (which included my event bus changes). PS 11 - corrections for my rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:53:37] (03CR) 10Aaron Schulz: [C: 032] Can't call escaped() on a string. [core] - 10https://gerrit.wikimedia.org/r/478749 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [21:55:44] (03PS1) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478791 (https://phabricator.wikimedia.org/T211154) [22:01:04] 10WMCZ-Tracker: Expose old MediaInfo in the API - https://phabricator.wikimedia.org/T211636 (10Urbanecm) [22:01:06] (03CR) 10jerkins-bot: [V: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [22:01:07] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: wbgetentities has stopped returning content on Beta Cluster Commons - https://phabricator.wikimedia.org/T211237 (10Jdforrester-WMF) p:05Triage>03Unbreak! Sorry, good point. Cormac and I are each unable to repr... [22:01:59] (03PS1) 10Esanders: build: Introduce eslint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478792 [22:02:26] 10MediaWiki-Parser, 10Tracking: Strip marker (UNIQ / QINU) issues (tracking) - https://phabricator.wikimedia.org/T28213 (10Pppery) [22:02:33] 10MediaWiki-Parser, 10TemplateStyles: TemplateStyles don't work when the template is inside a link - https://phabricator.wikimedia.org/T200704 (10Pppery) [22:03:54] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10Wikidata, 10Patch-For-Review: wbgetentities has stopped returning content on Beta Cluster Commons - https://phabricator.wikimedia.org/T211237 (10daniel) I know next to nothing about how the beta instances work, I'll probably need to hack around... [22:03:59] (03PS1) 10Esanders: build: Update stylelint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478793 [22:04:07] (03CR) 10Niedzielski: [C: 04-1] Switch from babel-preset-env to @babel/preset-env (032 comments) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [22:07:29] (03Merged) 10jenkins-bot: Can't call escaped() on a string. [core] - 10https://gerrit.wikimedia.org/r/478749 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [22:08:33] (03PS1) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478794 (https://phabricator.wikimedia.org/T211154) [22:10:18] (03CR) 10jenkins-bot: Can't call escaped() on a string. [core] - 10https://gerrit.wikimedia.org/r/478749 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [22:14:38] (03PS1) 10Esanders: build: Update devDependencies [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478795 [22:14:49] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to enroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Xaosflux) On your own test, where were you successful? (Was it anywhere BESIDES meta?) [22:15:31] (03CR) 10Bartosz Dziewoński: "Hmm, I guess the PHP changes are not actually needed, as any shipped messages will be ignored by the JS code. I think I had some different" [core] - 10https://gerrit.wikimedia.org/r/470181 (owner: 10Bartosz Dziewoński) [22:16:45] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help Panel: Enable on beta labs - https://phabricator.wikimedia.org/T211206 (10Etonkovidova) >>! In T211206#4808899, @kostajh wrote: >> Note: the blank input is a valid... [22:17:42] Urbanecm nope. [22:17:50] that's sad :( [22:18:04] (03PS2) 10Bartosz Dziewoński: Support message parameters in JavaScript messages with uselang=qqx [core] - 10https://gerrit.wikimedia.org/r/470181 [22:18:04] let's wait for next commits/release then! [22:18:16] (03PS3) 10Bartosz Dziewoński: Support message parameters in JavaScript messages with uselang=qqx [core] - 10https://gerrit.wikimedia.org/r/470181 [22:22:40] (03PS12) 10Nray: Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:24:27] (03PS1) 10Esanders: Avoid deprecated OO.ui.infuse( id ) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478796 (https://phabricator.wikimedia.org/T211154) [22:25:14] (03CR) 10Nray: [C: 031] "PS 12 adds corrects a nitpick that I missed in earlier reviews. I think this is ready to go now! Jan please +1 so I can +2 (or if anyone e" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:28:57] (03CR) 10Jforrester: [C: 032] Avoid deprecated OO.ui.infuse( id ) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478796 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:29:04] (03PS1) 10Esanders: build: Update devDependencies [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478797 [22:29:10] (03CR) 10Jforrester: [C: 032] Avoid deprecated OO.ui.infuse( id ) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478794 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:29:48] (03CR) 10Jforrester: [C: 032] build: Update devDependencies [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478795 (owner: 10Esanders) [22:30:28] (03CR) 10Jforrester: [C: 032] build: Update devDependencies [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478797 (owner: 10Esanders) [22:30:40] (03CR) 10Jforrester: [C: 032] Avoid deprecated OO.ui.infuse( id ) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478791 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:31:13] (03CR) 10Jforrester: [C: 032] build: Introduce eslint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478792 (owner: 10Esanders) [22:31:22] (03CR) 10Jforrester: [C: 032] build: Update stylelint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478793 (owner: 10Esanders) [22:32:59] (03PS2) 10Jforrester: Re-apply "textSelection: Use execcommand to replace text" [core] - 10https://gerrit.wikimedia.org/r/478744 (https://phabricator.wikimedia.org/T33780) (owner: 10Esanders) [22:33:12] (03Merged) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478796 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:33:55] (03PS2) 10Thcipriani: Update library to convert YAML to JSON [blubber] - 10https://gerrit.wikimedia.org/r/471277 (https://phabricator.wikimedia.org/T207694) [22:34:18] (03CR) 10jerkins-bot: [V: 04-1] Update library to convert YAML to JSON [blubber] - 10https://gerrit.wikimedia.org/r/471277 (https://phabricator.wikimedia.org/T207694) (owner: 10Thcipriani) [22:34:39] (03Merged) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478794 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:35:18] (03Merged) 10jenkins-bot: build: Update devDependencies [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/478795 (owner: 10Esanders) [22:35:20] (03Merged) 10jenkins-bot: build: Update devDependencies [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/478797 (owner: 10Esanders) [22:35:22] (03Merged) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478791 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:35:26] (03Merged) 10jenkins-bot: build: Introduce eslint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478792 (owner: 10Esanders) [22:35:46] (03Merged) 10jenkins-bot: build: Update stylelint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478793 (owner: 10Esanders) [22:36:20] (03PS14) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [22:37:18] (03CR) 10jenkins-bot: Avoid deprecated OO.ui.infuse( id ) [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478791 (https://phabricator.wikimedia.org/T211154) (owner: 10Esanders) [22:37:30] (03CR) 10jerkins-bot: [V: 04-1] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [22:37:46] (03PS15) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [22:39:07] (03CR) 10jenkins-bot: build: Update stylelint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478793 (owner: 10Esanders) [22:39:14] (03PS3) 10Niedzielski: WIP: Hygiene: collapse mobile.search* into mobile.startup [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478109 (https://phabricator.wikimedia.org/T210207) [22:39:16] (03CR) 10jerkins-bot: [V: 04-1] Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [22:39:26] (03PS3) 10Niedzielski: WIP: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [22:39:32] (03CR) 10jerkins-bot: [V: 04-1] WIP: Hygiene: collapse mobile.search* into mobile.startup [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478109 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [22:39:43] 10MediaWiki-Releasing, 10Phabricator, 10Project-Admins, 10Security-team-backlog: Create "security pre-announce" group in Phab (to easier allow 3rd parties who get pre-release notifications to access Security tasks) - https://phabricator.wikimedia.org/T108360 (10chasemp) 05Open>03Resolved https://phabri... [22:39:47] (03PS16) 10Urbanecm: Introduce new MediaInfo in the backend [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [22:40:04] 10Security-Team, 10ShoutWiki, 10WMF-Legal, 10WMF-NDA-Requests: Early security release access for Lcawte (ShoutWiki) - https://phabricator.wikimedia.org/T101017 (10chasemp) small progress https://phabricator.wikimedia.org/T108360#4812282 [22:41:06] (03CR) 10jenkins-bot: build: Introduce eslint [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/478792 (owner: 10Esanders) [22:45:19] (03PS4) 10Niedzielski: WIP: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [22:45:34] (03CR) 10Jforrester: "Presumably we have some unit tests for qqx behaviour? Can we extend them for this use case?" [core] - 10https://gerrit.wikimedia.org/r/470181 (owner: 10Bartosz Dziewoński) [22:48:08] (03PS3) 10Thcipriani: Update library to convert YAML to JSON [blubber] - 10https://gerrit.wikimedia.org/r/471277 (https://phabricator.wikimedia.org/T207694) [22:48:24] (03CR) 10jerkins-bot: [V: 04-1] Update library to convert YAML to JSON [blubber] - 10https://gerrit.wikimedia.org/r/471277 (https://phabricator.wikimedia.org/T207694) (owner: 10Thcipriani) [22:48:40] (03PS4) 10Thcipriani: Update library to convert YAML to JSON [blubber] - 10https://gerrit.wikimedia.org/r/471277 (https://phabricator.wikimedia.org/T207694) [22:49:43] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Niedzielski) Do we want to move extendSearchParams.js under src/mobile.st... [22:52:24] (03PS6) 10Aaron Schulz: filebackend: avoiding computing file SHA-1 hashes unless needed [core] - 10https://gerrit.wikimedia.org/r/472608 (https://phabricator.wikimedia.org/T204174) [22:57:32] 10MediaWiki-User-login-and-signup, 10Anti-Harassment (AHT Sprint 35): Change password length requirement and ensure enforcement for privileged users (from 8 to 10) - https://phabricator.wikimedia.org/T208246 (10JMinor) [22:58:07] (03CR) 10jerkins-bot: [V: 04-1] WIP: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [22:58:36] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11): Scraped description text of images shows remnants of CSS transforms in MediaViewer - https://phabricator.wikimedia.org/T211444 (10Jdforrester-WMF) [23:05:05] 10Proton, 10Readers-Web-Backlog: Verify that PDFs generated by Proton service are correct - https://phabricator.wikimedia.org/T210793 (10alexhollender) I tested the following pages via https://polishdeveloper.pl/wmf/proton/, and found no major issues: Coffee - en - desktop Diego Velázquez - es - mobile Disc g... [23:08:38] (03PS5) 10Niedzielski: WIP: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) [23:09:30] 10MediaWiki-extensions-OATHAuth: users with oathauth-enable access via global groups are unable to enroll in two factor authentication - https://phabricator.wikimedia.org/T211532 (10Matiia) Mediawikiwiki and snwiki. [23:13:38] (03PS6) 10Paladox: Add support for actor [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/477701 (https://phabricator.wikimedia.org/T211037) [23:13:42] (03CR) 10Paladox: Add support for actor (0311 comments) [extensions/ContributionScores] - 10https://gerrit.wikimedia.org/r/477701 (https://phabricator.wikimedia.org/T211037) (owner: 10Paladox) [23:16:45] 10MediaWiki-extensions-TitleKey, 10Patch-For-Review: TitleKey should drop special characters, like diacritics - https://phabricator.wikimedia.org/T22097 (10PFWOz) Another year gone... the lack of normalization contributes to "Illegal mix of collations" errors, which results in user-facing database query error... [23:17:36] looks kinda cool https://usercontent.irccloud-cdn.com/file/N0IGQcfg/lo [23:21:41] (03CR) 10jerkins-bot: [V: 04-1] WIP: Hygiene: collapse mobile.search* into mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478108 (https://phabricator.wikimedia.org/T210207) (owner: 10Niedzielski) [23:28:11] 10Research: Test the model for eliciting new editor interests - https://phabricator.wikimedia.org/T190776 (10leila) We have a new experiment based on the learnings from the previous one. I put a note on enwiki's VP about it https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(miscellaneous)#Experiment:_Elicitin... [23:33:16] (03CR) 10Jdrewniak: [C: 031] Pass isBorderbox and className properties as options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [23:35:04] (03CR) 10Krinkle: [C: 032] filebackend: avoiding computing file SHA-1 hashes unless needed [core] - 10https://gerrit.wikimedia.org/r/472608 (https://phabricator.wikimedia.org/T204174) (owner: 10Aaron Schulz) [23:35:22] (03CR) 10Bartosz Dziewoński: [C: 032] Introduce HTMLGlobalUserTextField [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/470753 (https://phabricator.wikimedia.org/T204411) (owner: 10Jayprakash12345) [23:37:12] (03CR) 10Jack Phoenix: [C: 04-1] "-1 due to using deprecated (in MW 1.26) function aliases instead of calling the library functions directly." (032 comments) [extensions/TitleKey] - 10https://gerrit.wikimedia.org/r/382968 (https://phabricator.wikimedia.org/T22097) (owner: 10Sophivorus) [23:38:11] 10Wikipedia-Android-App-Backlog: Russian article does not display mathematical symbols - https://phabricator.wikimedia.org/T211642 (10LGoto) [23:38:54] (03CR) 10Jforrester: [C: 032] Chinese Conversion Table Update 2018-3 [core] - 10https://gerrit.wikimedia.org/r/464941 (owner: 10Chiefwei) [23:40:08] (03CR) 10Jforrester: [C: 031] "Given this is wanted in production on 13 December, this should get merged after the cut tomorrow, right?" [core] - 10https://gerrit.wikimedia.org/r/477487 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy) [23:41:22] (03PS1) 10Bartosz Dziewoński: GlobalUsersPager: Fix default value of 'group' when passed as subpage parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478805 [23:41:46] (03PS2) 10Bartosz Dziewoński: GlobalUsersPager: Fix default value of "Group" when passed as subpage parameter [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478805 [23:42:54] (03CR) 10Jforrester: [C: 031] Fixes WinCache keys longer than 150 chars. [core] - 10https://gerrit.wikimedia.org/r/476987 (https://phabricator.wikimedia.org/T210794) (owner: 10Juan Osorio (Microsoft)) [23:44:44] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [BUG] Link preview for elliptic curve shows a small green box - https://phabricator.wikimedia.org/T193084 (10Dbrant) [23:44:46] 10Wikipedia-Android-App-Backlog: Russian article does not display mathematical symbols - https://phabricator.wikimedia.org/T211642 (10Dbrant) [23:45:48] 10ContentTranslation, 10WorkType-Maintenance: Translation Section collision, case-insensitive data-source/id attrib comparison? - https://phabricator.wikimedia.org/T136160 (10Etonkovidova) There is still the case of using two different id name (in terms of the case) for the same element: ` (03PS5) 10Jforrester: Fixes shell edge-cases in Windows [core] - 10https://gerrit.wikimedia.org/r/471885 (https://phabricator.wikimedia.org/T183759) (owner: 10Juan Osorio (Microsoft)) [23:50:51] (03Abandoned) 10Paladox: Update git-review to 1.27.0 [vagrant] - 10https://gerrit.wikimedia.org/r/435192 (https://phabricator.wikimedia.org/T163242) (owner: 10Paladox) [23:51:40] (03Merged) 10jenkins-bot: filebackend: avoiding computing file SHA-1 hashes unless needed [core] - 10https://gerrit.wikimedia.org/r/472608 (https://phabricator.wikimedia.org/T204174) (owner: 10Aaron Schulz) [23:51:41] (03CR) 10Jforrester: [C: 032] Use Travis CI cache and reduce clone depth to speed up setup time [core] - 10https://gerrit.wikimedia.org/r/472447 (https://phabricator.wikimedia.org/T209056) (owner: 10Kosta Harlan) [23:51:43] (03Merged) 10jenkins-bot: Introduce HTMLGlobalUserTextField [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/470753 (https://phabricator.wikimedia.org/T204411) (owner: 10Jayprakash12345) [23:52:57] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools, 10Patch-For-Review: Convert Special:CentralAuth to use OOUI - https://phabricator.wikimedia.org/T122016 (10matmarex) [23:53:02] 10MediaWiki-User-management, 10UI-Standardization, 10Patch-For-Review: Convert Special:UserRights to OOUI - https://phabricator.wikimedia.org/T117884 (10matmarex) [23:53:07] 10MediaWiki-HTMLForm, 10OOUI, 10Patch-For-Review, 10User-Jayprakash12345: Introduce HTMLGlobalUserTextField::class for global users - https://phabricator.wikimedia.org/T204411 (10matmarex) 05Open>03Resolved Thanks! [23:53:17] (03PS7) 10Bartosz Dziewoński: Partially convert Special:CentralAuth to use OOUI [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/424373 (https://phabricator.wikimedia.org/T122016) (owner: 10Jayprakash12345) [23:54:27] (03PS8) 10Bartosz Dziewoński: Partially convert Special:CentralAuth to use OOUI [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/424373 (https://phabricator.wikimedia.org/T122016) (owner: 10Jayprakash12345) [23:54:34] (03CR) 10jenkins-bot: filebackend: avoiding computing file SHA-1 hashes unless needed [core] - 10https://gerrit.wikimedia.org/r/472608 (https://phabricator.wikimedia.org/T204174) (owner: 10Aaron Schulz) [23:54:57] (03CR) 10Bartosz Dziewoński: [C: 031] "PS7 is a rebase on top of https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/470753 and PS8 fixes autocompletion using th" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/424373 (https://phabricator.wikimedia.org/T122016) (owner: 10Jayprakash12345) [23:55:07] (03Merged) 10jenkins-bot: Chinese Conversion Table Update 2018-3 [core] - 10https://gerrit.wikimedia.org/r/464941 (owner: 10Chiefwei) [23:55:11] (03Merged) 10jenkins-bot: Hygiene: remove package-lock.json [extensions/Popups] - 10https://gerrit.wikimedia.org/r/470309 (owner: 10Niedzielski) [23:56:20] (03CR) 10jenkins-bot: Introduce HTMLGlobalUserTextField [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/470753 (https://phabricator.wikimedia.org/T204411) (owner: 10Jayprakash12345) [23:57:28] (03CR) 10jenkins-bot: Chinese Conversion Table Update 2018-3 [core] - 10https://gerrit.wikimedia.org/r/464941 (owner: 10Chiefwei) [23:58:28] 10Wikipedia-Android-App-Backlog: Faction not displaying correcting in app - https://phabricator.wikimedia.org/T211645 (10LGoto)