[00:00:16] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Krinkle) @Tgr The task as written appears to be working as expected. We currently, and have for years, collect the "suppressed errors" in produc... [00:01:29] (03PS2) 10Gergő Tisza: Add a checker that stores hashes in local binary files [extensions/PwnedPasswords] - 10https://gerrit.wikimedia.org/r/478455 [00:09:27] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10rafidaslam) a:03rafidaslam [00:14:41] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Wbm1058) Is this still a problem? A week ago Friday I saw this error every time I tried to move over a page with history. It didn't seem random,... [00:16:22] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) [00:16:38] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) [00:16:43] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar): Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) [00:20:43] (03PS1) 10Gergő Tisza: Add bjeavons/zxcvbn-php [vendor] - 10https://gerrit.wikimedia.org/r/478456 (https://phabricator.wikimedia.org/T32574) [00:21:22] (03CR) 10Gergő Tisza: [C: 04-2] "Blocked on security review (T211489)." [vendor] - 10https://gerrit.wikimedia.org/r/478456 (https://phabricator.wikimedia.org/T32574) (owner: 10Gergő Tisza) [00:21:56] (03PS8) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:25:13] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) p:05Triage>03High [00:31:00] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) related to T42076 [00:35:03] 10MobileFrontend: iPad Pro/iOS 12.1: scrolling is broken when editing mobile site in source mode - https://phabricator.wikimedia.org/T211490 (10AxelBoldt) [00:37:51] (03CR) 10jerkins-bot: [V: 04-1] Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:39:16] (03CR) 10Krinkle: [C: 032] Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:53:27] (03Merged) 10jenkins-bot: Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:55:41] (03CR) 10jenkins-bot: Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [00:56:40] (03PS9) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [00:59:00] 04(no projects): iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode - https://phabricator.wikimedia.org/T211491 (10AxelBoldt) [01:09:31] (03CR) 10jerkins-bot: [V: 04-1] Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:13:12] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property - https://phabricator.wikimedia.org/T210062 (10Salgo60) See [[ http://minancestry.blogspot.com/2018/12/bygdeband-swedish-site-containing-local.html | Blogpost ]] Next step: - speak with bygdeband -- explain how they can link - decide if Wiki... [01:13:57] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property - https://phabricator.wikimedia.org/T210062 (10Salgo60) [01:14:48] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property and match "Församlingar" - https://phabricator.wikimedia.org/T210062 (10Salgo60) [01:20:27] (03CR) 10Krinkle: [C: 031] "Given we do not require use of Yoda conditionals, their infrequent use is unexpected, cause for confusion, and increases cognitive overhea" [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:21:12] (03CR) 10Krinkle: [C: 032] No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:22:35] (03CR) 10Krinkle: [C: 04-1] "Renaming modules is suspicious. Can you confirm that the name of the old module is not cached in any way in HTML or ParserOutput cache and" [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 (owner: 10Fomafix) [01:34:28] (03Merged) 10jenkins-bot: No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:35:24] (03PS10) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:36:45] (03CR) 10jenkins-bot: No yoda conditions [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [01:37:55] (03PS11) 10Gergő Tisza: Add a password strength policy to validate the password [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [01:42:59] (03CR) 10Krinkle: "I assume you're referring to https://github.com/wikimedia/mediawiki/blob/2ca16a7bd3bbf/resources/src/mediawiki.ui/components/radio.less." [core] - 10https://gerrit.wikimedia.org/r/475809 (owner: 10VolkerE) [01:44:50] (03CR) 10Krinkle: "Hm.. also check whether the upstream is meant to handle file-system paths. I believe our function is meant to handle that (it's use for ur" [core] - 10https://gerrit.wikimedia.org/r/477964 (owner: 10Reedy) [01:46:22] (03CR) 10Krinkle: [C: 032] ResourceLoaderContext: Add getConfig() method [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:46:44] (03PS2) 10Krinkle: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:46:47] (03CR) 10Krinkle: [C: 032] resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [01:51:44] (03CR) 10Krinkle: [C: 032] Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:01:21] (03Merged) 10jenkins-bot: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [02:01:23] (03Merged) 10jenkins-bot: Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:03:38] (03CR) 10jenkins-bot: Provide a default for $wgVERPdomainPart at runtime [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/447934 (https://phabricator.wikimedia.org/T180192) (owner: 10Legoktm) [02:03:40] (03CR) 10jenkins-bot: resourceloader: Add getConfig() method to ResourceLoaderContext [core] - 10https://gerrit.wikimedia.org/r/478380 (owner: 10Catrope) [02:04:23] (03CR) 10Krinkle: Add wfGetErrorText, a global helper function for log error formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [02:11:26] (03CR) 10Krinkle: [C: 04-1] "See task for details (-1 for that), but if/when this goes, we should have tests as well." [core] - 10https://gerrit.wikimedia.org/r/477264 (https://phabricator.wikimedia.org/T210684) (owner: 10Thiemo Kreuz (WMDE)) [02:11:55] (03CR) 10Krinkle: Emit debug logs when filtering without title (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) (owner: 10Daimona Eaytoy) [02:12:28] (03PS1) 10Krinkle: Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 [02:13:22] (03CR) 10jerkins-bot: [V: 04-1] Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [02:13:58] (03CR) 10jerkins-bot: [V: 04-1] Revert "Pass $context to 'GetPreferences' hook" [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [02:28:06] 10WMSE-Riksarkivet-TORA: Add Bygdeband to Wikidata as a Property and match "Församlingar" - https://phabricator.wikimedia.org/T210062 (10Salgo60) [02:42:45] Oh my, I didn't realize one of my super-old bugs is still up: https://phabricator.wikimedia.org/T32574 [05:31:49] o/ [05:34:18] \o [05:50:00] where is wikibugs ? [05:50:48] was wondering [05:52:11] probably just needs a restart / legoktm [06:04:34] [*] [06:12:45] (03PS1) 10MaxSem: Hard deprecated SiteSQLStore::newInstance() [core] - 10https://gerrit.wikimedia.org/r/478459 [06:12:47] (03PS1) 10MaxSem: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 [06:12:49] (03PS1) 10MaxSem: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 [06:13:24] it's alive [06:14:02] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) @Tgr Thanks for explaining. That solved the issue. (That was too simple but I have been struggling. My bad) Can't we make it simple and... [06:14:26] uhh [06:14:44] ^^ [06:15:37] i don't feel so good, Mr Bugs... [06:17:37] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [06:17:41] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [06:18:12] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [06:18:30] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 (owner: 10MaxSem) [06:24:21] (03PS2) 10MaxSem: Hard deprecate LinkCache::addLink() [core] - 10https://gerrit.wikimedia.org/r/478460 [06:24:23] (03PS2) 10MaxSem: Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 [06:31:48] (03CR) 10Liuxinyu970226: [C: 031] Chinese Conversion Table Update 2018-3 [core] - 10https://gerrit.wikimedia.org/r/464941 (owner: 10Chiefwei) [06:39:50] (03CR) 10Shreyasminocha: [C: 04-1] Refactor most of jQuery code to vanilla JS (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [07:21:47] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10kaldari) I'm happy to provide the manager approval, but you'll still need a C-level sign-off. [07:22:26] 10MobileFrontend: iPad Pro/iOS 12.1: cursor jumps out of view when editing mobile site in source mode - https://phabricator.wikimedia.org/T211491 (10Liuxinyu970226) [07:27:34] d: [07:40:39] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Tgr) You can, but that will result in an urlencoded POST body. Maybe that works too, I don't know what are the exact requirements for the upload API. As far... [07:55:51] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) Yes you are right. If I use file_gets_content(), I am getting authorization error. [08:03:08] (03CR) 10Zoranzoki21: [C: 04-1] "> So this is superseded by / already included in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Spark/+/424605/" [extensions/Spark] - 10https://gerrit.wikimedia.org/r/451600 (https://phabricator.wikimedia.org/T189687) (owner: 10Dheerajmalisetty) [08:18:15] (03CR) 10Arcayn: [C: 031] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [08:24:43] (03CR) 10Tpt: [C: 032] Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:29:31] (03Merged) 10jenkins-bot: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:31:49] (03CR) 10jenkins-bot: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 (owner: 10MarcoAurelio) [08:58:14] (03CR) 10Smalyshev: [C: 031] Hard deprecate SearchEngine::getNearMatchResultSet() [core] - 10https://gerrit.wikimedia.org/r/478461 (owner: 10MaxSem) [09:27:28] (03PS5) 10Daimona Eaytoy: Emit debug logs when filtering without title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) [09:32:11] (03CR) 10D3r1ck01: [C: 032] "LGTM! Thanks @Marco :)" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [09:36:26] (03CR) 10D3r1ck01: [C: 031] "Thanks a lot Marco ;), I'm not a nap expert (or native) but this patch LGTM. I'm wondering if we should run this against a "nap" reviewer " [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) (owner: 10MarcoAurelio) [09:50:40] (03Merged) 10jenkins-bot: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [09:58:25] (03CR) 10jenkins-bot: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) (owner: 10MarcoAurelio) [10:03:37] hello [10:03:49] anyone awake? [10:05:36] mogmog123: Hey! :) [10:05:52] Hello :) [10:05:54] How are you doing? [10:07:06] Not bad! And you? [10:07:31] I'm fine thanks [10:07:49] i feel it's been quite in here these few last days [10:08:07] quiet* [10:11:03] hello [10:11:21] d3r1ck, mogmog123: hi [10:11:53] mogmog123: no, day-before we had many many people online [10:12:15] oh unfortunately i missed it [10:12:26] mogmog123: Not sure but I can't deny your feeling ;/ [10:12:35] shreyasminocha: Hey! What's up? [10:12:58] hi! setting up a personal eslint config [10:13:17] simultaneously installing MAMP [10:15:13] Ohh, nice! [10:16:12] my time here encouraged me to brush the dust off a php/mysql book that's been lying around :P [10:16:28] never thought i'd learn php, but figured it's probably worth a shot [10:17:50] hi shreyasminocha, d3r1ck, mogmog123 [10:17:53] (03PS1) 10Umherirrender: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 [10:17:55] shreyasminocha: :D [10:18:00] hi refeed [10:18:09] refeed: Hey! What's up? :) [10:18:21] hey refeed what's up [10:18:39] (03PS2) 10Umherirrender: Use english for message text in SparqlException [core] - 10https://gerrit.wikimedia.org/r/478470 [10:19:12] nothing, actually just saying hi :D because of bored [10:20:12] been working in T210752 [10:20:13] T210752: Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 [10:20:55] and still have two exams tomorrow :' [10:20:56] ah, was planning to claim that :P [10:21:20] sometimes I'm stuck in making my priority list, what should I done first, etc [10:21:27] been stuck on an advanced update deps task because my patch dropped codecov by 5% :D [10:21:34] shreyasminocha, :D [10:22:03] * refeed just heard MAMP [10:22:37] (03PS1) 10Umherirrender: Use english for log text in AuthManagerSpecialPage [core] - 10https://gerrit.wikimedia.org/r/478471 [10:23:38] shreyasminocha, hmm, interesting, I never thought updating deps would decrease coverage [10:23:56] babel etc are the deps in question [10:24:01] tests are run on transpiled code [10:24:14] the update must've changed the transpiled code significantly [10:24:31] sourcemaps aren't set up so codecov doesn't map transpiled lines back to source lines [10:24:37] therefore, rip [10:24:45] i'm looking into sourcemaps... [10:24:48] hopefully those'll help [10:25:05] (03CR) 10Bartosz Dziewoński: [C: 031] "Needs rebase." [core] - 10https://gerrit.wikimedia.org/r/478457 (owner: 10Krinkle) [10:27:35] (03PS2) 10Umherirrender: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:27:40] (03CR) 10Umherirrender: [C: 032] Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:28:53] heh, that makes sense [10:29:11] I also think it's not a quite good idea to run tests on the transpiled code :/ [10:29:50] although sometimes it can be necessary [10:30:13] (03PS2) 10Umherirrender: Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:30:16] (03CR) 10Umherirrender: [C: 032] Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:35:36] (03CR) 10Mainframe98: [C: 04-1] Convert UploadLocal to use extension registration (031 comment) [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) (owner: 10MarcoAurelio) [10:39:18] interesting. this reddit page explained it a little to me https://www.reddit.com/r/javascript/comments/5955qk/should_i_test_source_code_or_transpiled_code/ [10:39:27] Hi Nathan_fraignt [10:39:38] Hi :) [10:41:45] (03Merged) 10jenkins-bot: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:41:47] (03Merged) 10jenkins-bot: Use common function names for hook functions [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/472471 (owner: 10Fomafix) [10:44:00] (03CR) 10jenkins-bot: Remove useless continue at end of loop [core] - 10https://gerrit.wikimedia.org/r/464790 (owner: 10Fomafix) [10:46:14] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) I tell you what I find truly infuriating about this implementation 1) A soluti... [10:47:24] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) [10:49:58] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Billinghurst) Emended possibly reference to admins "locking themselves out". Locks are impos... [11:00:29] Is there a neat way to reference another patch (not commit!) in a commit message in Gerrit? [11:07:38] (03PS1) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:08:21] (03PS2) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:09:16] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:14:19] (03CR) 10Fomafix: "I keep the previous module name for compatibility to cached versions in PS2." [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 (owner: 10Fomafix) [11:14:26] (03PS2) 10Fomafix: Move styles that only used in JavaScript to JavaScript module [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 [11:16:42] (03PS3) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:17:38] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:18:42] Nathan_fraignt: what do you mean by patch? a separate patchset? [11:19:02] p858snake, yes [11:19:18] you just reference the change-id iirc [11:20:27] Alright, thanks [11:21:04] actually no, you reference the commit id, eg: https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/478457/ [11:21:55] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Re-enable EP Namespaces in wmf-config - https://phabricator.wikimedia.org/T211494 (10Reedy) [11:23:03] Reedy: re-enabling the extension or namespaces? ^ [11:23:16] p858snake: Just namespaces [11:23:34] may want to update the task description then ;) [11:25:19] (03PS4) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:25:51] 10MediaWiki-extensions-EducationProgram, 10Wikimedia-Site-requests: Re-enable EP Namespaces in wmf-config - https://phabricator.wikimedia.org/T211494 (10Reedy) [11:26:13] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:29:26] (03PS5) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:30:24] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:33:28] (03PS6) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:34:23] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [11:38:20] (03PS7) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [11:39:57] (03CR) 10Nathan fraignt: "> Patch Set 7:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [11:40:42] 10MediaWiki-Codesniffer, 10Patch-For-Review: Allow deprecated @type in MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation - https://phabricator.wikimedia.org/T203922 (10Umherirrender) 05Open>03declined [11:41:18] (03CR) 10Nathan fraignt: [C: 031] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [11:50:09] (03PS1) 10Umherirrender: Improve paramater docs of NotifiedUsersTest::getTestData [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478475 [11:56:37] (03PS3) 10Umherirrender: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [11:56:39] (03CR) 10Umherirrender: [C: 032] Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [11:59:50] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Great work so far :) I've one thing, though :)" (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:00:46] (03Merged) 10jenkins-bot: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 (owner: 10Fomafix) [12:02:50] (03CR) 10Urbanecm: [C: 032] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [12:03:49] (03Merged) 10jenkins-bot: Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [12:13:33] (03CR) 10Umherirrender: build: Replace jshint with eslint & stylelint (034 comments) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:21:11] (03PS3) 10Shreyasminocha: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) [12:32:07] (03PS3) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [12:34:21] 10Google-Code-in-2018, 10Library-Card-Platform, 10goodfirstbug: Add 'invalid' application status option - https://phabricator.wikimedia.org/T175249 (10Arcayn) a:03Arcayn [12:35:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Partial RDF dumps - https://phabricator.wikimedia.org/T46581 (10abian) [12:35:16] (03CR) 10Stibba: build: Replace jshint with eslint & stylelint (031 comment) [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) (owner: 10Stibba) [12:43:50] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Dodecane) {F27453897} [12:47:41] (03CR) 10Shreyasminocha: "Had to lower nyc's threshold for branches because updating babel and related dependencies caused branch coverage to drop significantly, pr" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [12:49:33] 10MediaWiki-General-or-Unknown, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10MarcoAurelio) [12:50:15] (03CR) 10Urbanecm: [C: 031] "LGTM, but I'd like to wait on Arcayn's review, as they commented on previous patch with issues the patch has." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [12:51:31] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Sorting by (pre)expeditures doesn't work - https://phabricator.wikimedia.org/T211277 (10Urbanecm) 05Resolved>03Open Reopening, for details see the merged commit linked above. [12:52:38] 10MediaWiki-General-or-Unknown, 10Security-Team, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10Reedy) p:05Triage>03Low It's because it's something added in wmf-config I think there's a task for this already [12:53:18] 10MediaWiki-General-or-Unknown, 10Security-Team, 10I18n: Missing passwordpolicies-policy-blockattacker message - https://phabricator.wikimedia.org/T211496 (10Reedy) [12:55:10] (03CR) 10Shreyasminocha: [C: 031] Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [12:56:40] 10MediaWiki-extensions-Scribunto, 10I18n, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Localize Scribunto magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210825 (10MarcoAurelio) 05Open>03Resolved a:03Ruthven [12:56:49] 10MediaWiki-extensions-Scribunto, 10I18n, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11): Localize Scribunto magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210825 (10MarcoAurelio) [12:57:54] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10MarcoAurelio) >>! In T211042#4808232, @kaldari wrote: > I'm happy to provide the manager approval, but you'll still need a C-level sign-off. Let's ping @VColeman for this. [12:58:31] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Nathan_fraignt) This isn't an issue with the amount, all the columns are impossible to order. Also see this error (occurs when actually clicking an order arrow/button): ` jquery.d... [13:03:33] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Stibba) settings.aaSorting seems to be false so there is probably an issue when the tables are created. [13:04:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: possible to create duplicate sitelinks - https://phabricator.wikimedia.org/T50260 (10Liuxinyu970226) [13:06:20] 10WMCZ-Tracker: It isn't possible to order by amount on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Nathan_fraignt) a:03Nathan_fraignt [13:07:40] (03PS8) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:08:06] (03PS9) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:09:56] (03CR) 10Nathan fraignt: "Added the fix to T211280 to this patchset. The bug is closely related to T211277, which was/is fixed with this patchset." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [13:10:36] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Partial RDF dumps - https://phabricator.wikimedia.org/T46581 (10abian) [13:13:34] 10WMCZ-Tracker, 10Patch-For-Review: It isn't possible to order on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Urbanecm) [13:16:40] (03CR) 10Urbanecm: [C: 04-1] Fix sorting of dates and (pre)expeditures on ticket tables (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [13:22:35] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Nathan_fraignt) a:03Nathan_fraignt [13:23:25] (03CR) 10Reedy: "This certainly isn't a blocker to merging the guzzle patch, just a "nice to have" if it'll work" [core] - 10https://gerrit.wikimedia.org/r/477964 (owner: 10Reedy) [13:25:24] (03PS10) 10Nathan fraignt: Fix sorting of dates and (pre)expeditures on ticket tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [13:27:42] (03CR) 10MarcoAurelio: "The translations have been actually provided by a Neapolitan speaker as referenced in the commit message of this patch. But if you prefer " [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) (owner: 10MarcoAurelio) [13:28:22] (03CR) 10Aklapper: [C: 031] Fix typo "#$element" in the OOUI Documentation [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [13:31:17] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Reedy) Based on https://github.com/bjeavons/zxcvbn-php/pull/32 (seems a mismatch with the dropbox js version as detailed in https://github.com/bjeav... [13:34:31] (03PS1) 10Daimona Eaytoy: Move a method out of AbuseFilter.php [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478478 [13:40:49] 10Wikipedia-Android-App-Backlog: As a user, I want to able to award tokens to articles. - https://phabricator.wikimedia.org/T211460 (10Reedy) Reward who? How? With what? Why? [13:49:29] o/ [13:52:10] \o [13:52:18] o/ [13:52:24] (03CR) 10Matěj Suchánek: Migrate UserMerge to modern logging system (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [13:52:30] wikibugs why ;-; [14:11:20] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Ankit-Maity) >>! In T150826#4808282, @Billinghurst wrote: > I tell you what I find truly infu... [14:14:22] (03PS23) 10Matěj Suchánek: Use actor table in AbuseFilter [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/445185 (https://phabricator.wikimedia.org/T188180) [14:17:57] (03PS1) 10Urbanecm: Internacionalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 [14:21:32] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10Aklapper) @Sju: Hi. As you prioritized this task, do you plan to work on fixing this task? If so, please feel free... [14:24:24] (03PS1) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [14:26:47] (03PS2) 10Shreyasminocha: Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:29:47] (03CR) 10Nathan fraignt: [C: 031] "Tested. Code LGTM!" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:34:36] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews: Page Previews should take into account FlaggedRevs' stabilization setting - https://phabricator.wikimedia.org/T211501 (10Jack_who_built_the_house) [14:36:02] (03CR) 10Urbanecm: [C: 032] Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:36:58] (03CR) 10Takidelfin: Internationalize example files (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:37:02] (03Merged) 10jenkins-bot: Internationalize example files [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:37:52] 10MediaWiki-extensions-FlaggedRevs, 10Page-Previews: Page Previews should take FlaggedRevs' stabilization setting into account - https://phabricator.wikimedia.org/T211501 (10Jack_who_built_the_house) [14:38:52] (03CR) 10Takidelfin: Internationalize example files (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478480 (owner: 10Urbanecm) [14:44:08] (03PS1) 10Nathan fraignt: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 [14:45:14] (03CR) 10jerkins-bot: [V: 04-1] Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:45:55] (03PS4) 10Daimona Eaytoy: Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) [14:46:00] (03PS5) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [14:49:02] (03PS2) 10Nathan fraignt: Fix grammar in messages in views.py [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 [14:50:59] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Leaderboard) Not in favour of this change, considering the potential issues with 2FA (5 scratch codes that're displayed one-time? That's too lit... [14:51:48] (03CR) 10Daimona Eaytoy: [C: 04-1] "I'd actually like to investigate again saving old variables in cache (like we do for matched filters, tags etc.), and doing something else" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/423978 (https://phabricator.wikimedia.org/T191430) (owner: 10Daimona Eaytoy) [14:51:52] 10MediaWiki-extensions-OATHAuth, 10Growth-Team, 10Notifications: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788 (10Leaderboard) A better solution is for MW to just list out the remaining scratch codes left. [14:57:42] (03CR) 10Stibba: Fix grammar in messages in views.py (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:58:50] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [14:59:04] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [14:59:13] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [15:00:44] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:00:55] (03CR) 10Takidelfin: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:01:16] (03CR) 10Takidelfin: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:05:48] (03CR) 10Nathan fraignt: "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:07:20] (03CR) 10Stibba: [C: 031] "You're right, did not know. LGTM." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:08:22] (03CR) 10jerkins-bot: [V: 04-1] Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) (owner: 10Daimona Eaytoy) [15:08:49] (03PS5) 10Daimona Eaytoy: Add unit tests for stashed edits [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454888 (https://phabricator.wikimedia.org/T201193) [15:15:43] (03CR) 10Takidelfin: [C: 031] "> Patch Set 2:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478482 (owner: 10Nathan fraignt) [15:16:03] (03PS6) 10Daimona Eaytoy: Add unit tests for profiling [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455173 (https://phabricator.wikimedia.org/T201193) [15:21:12] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10takidelfin) a:05Bjornskjald>03takidelfin [15:21:52] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10takidelfin) [15:22:03] (03PS1) 10Takidelfin: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) [15:28:27] 10MediaWiki-History-or-Diffs, 10Advanced Mobile Contributions, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): It's not possible to undo edits from the revision history or d... - https://phabricator.wikimedia.org/T191706 [15:30:55] (03CR) 10Stibba: "Looks good! In import.html however is still a message that is hard-coded on '100' rows, perhaps that could be adjusted to the set number a" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [15:32:29] 04(no projects): Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:32:57] 04(no projects): Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:33:44] 10MediaWiki-Debian, 10MediaWiki-Releasing, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10RazeSoldier) [15:33:46] 10WMSE-Riksarkivet-TORA: Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) [15:33:48] 10MediaWiki-Vendor, 10MW-1.31-release, 10MW-1.32-notes, 10MW-1.32-release, and 4 others: vendor/oyejorge/less.php/lib/Less/Exception/Chunk.php triggers warnings in PHP 7.3 - https://phabricator.wikimedia.org/T206975 (10RazeSoldier) 05Open>03Resolved [15:36:02] (03CR) 10Shreyasminocha: [C: 031] Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [15:46:37] (03PS1) 10D3r1ck01: content-providers: Use FormatJson::decode() instead of json_decode() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478486 [15:50:10] (03PS1) 10Stibba: Remove (random?) 'user: (;;);' at right top of navigation [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 [16:02:04] (03PS1) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:03:20] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478486 (owner: 10D3r1ck01) [16:04:57] (03PS2) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:07:07] (03PS3) 10D3r1ck01: CPs: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:07:36] (03PS4) 10D3r1ck01: MediaWikiServices & Service Wirings in MwApiContentProvider.php [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 [16:13:22] 10WMSE-Riksarkivet-TORA: Upload kulturnav: Uppfinnare i Sverige (Tekniska museet) - https://phabricator.wikimedia.org/T211503 (10Salgo60) 05Open>03Resolved Done see - List of [[ http://tinyurl.com/y8t4v2rm | members uploaded ]] [16:18:40] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10SJu) @Aklapper: If nobody is capable to make functionality of UploadWizard at least comparable with the basic uplo... [16:21:32] "As you prioritized this task, do you plan to work on fixing this task?" -- this is a convention in wikimedia, isn't it? [16:22:46] (03CR) 10Shreyasminocha: [C: 031] "Wonder how this slipped in." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [16:32:55] Does anyone know what's going on here? https://github.com/WikiEducationFoundation/WikiEduDashboard/pull/2297 Rspec tests keep failng and I can't figure it out [16:35:44] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Zache) I will assign this to @Dereckson because he was the person who enabled the testing period for 6 months (per T121995 and [[ https://gerrit.wikimedia.org/r/#/c/operations/mediawiki... [16:35:46] Hello? [16:36:05] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Zache) a:03Dereckson [16:39:54] (03CR) 10Arcayn: [C: 04-1] "Code LGTM but but the new method for sorting money columns is not only required in ticket_table but also in the grant_detail and grant_lis" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:41:48] 10MediaWiki-Categories, 10Multimedia, 10UploadWizard: The Category field of UploadWizard doesn't enable to go through the category tree up and down - https://phabricator.wikimedia.org/T177687 (10Aklapper) p:05High>03Triage That sounds like a valid [meta-level discussion](https://www.mediawiki.org/wiki/Bu... [16:43:02] o/ [16:43:45] pterp: looking [16:43:55] What is o/? [16:45:34] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478488 (owner: 10D3r1ck01) [16:46:06] `1) TrainingController#reload for a single module, from wiki returns the result upon success [16:46:06] Failure/Error: raw_categories.to_hashugar [16:46:06] [16:46:07] SystemStackError: [16:46:07] stack level too deep [16:46:07] # ./lib/training_library.rb:38:in `categories' [...]` [16:46:57] I thought I pushed the fix. [16:47:26] pterp: also try running `bundle exec rspec --color --profile --format documentation --tag $TEST_SUITE` tests before pushing :) [16:47:36] Running. [16:48:17] Errored out: https://pastebin.com/G9wma4y5 [16:49:07] ahh, sorry I forgot to remove --tag [16:49:13] `bundle exec rspec --color --profile --format documentation` [16:49:30] Running [16:49:32] this command works in my env [16:49:38] so it should work for you too [16:49:59] Full green so far. [16:53:49] Got red. Here's some of the errors: https://pastebin.com/NZd8NNM8. I cut if off earlier, and these are only a couple of the ones that showed. [16:54:57] (03CR) 10Nathan fraignt: "> Patch Set 10: Code-Review-1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:06] (03CR) 10Arcayn: "Looks like the patch didnt apply correctly on my machine. I apologise, index.html DOES sort correctly, but my original comments do stand. " [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:08] (03PS2) 10Urbanecm: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:55:25] (03CR) 10Arcayn: [C: 04-1] "(keeping cr-1 for now)" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [16:55:31] (03CR) 10Urbanecm: [C: 032] Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:56:28] \o/ [16:56:35] (03Merged) 10jenkins-bot: Stylelint: Fix stylelint violations [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478483 (https://phabricator.wikimedia.org/T211150) (owner: 10Takidelfin) [16:56:47] takidelfin: Not sure what's going on, huh? [16:56:52] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Fix CSS violations - https://phabricator.wikimedia.org/T211150 (10Urbanecm) 05Open>03Resolved [16:57:08] pterp: umm, what do you mean? [16:57:36] I thought the \o/ was a shrug emoticon, like you were confused. [16:58:44] (03CR) 10Urbanecm: "> Patch Set 10: -Code-Review" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [17:01:08] (03PS1) 10Daimona Eaytoy: Simplify static properties in AbuseFilterHooks [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478489 [17:01:44] (03CR) 10Nathan fraignt: "> Patch Set 10:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [17:02:49] (03CR) 10Urbanecm: [C: 032] "> Patch Set 1: Code-Review+1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [17:03:34] (03PS11) 10Nathan fraignt: Fix sorting of dates, (pre)expeditures and wages on ticket and grant tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [17:03:51] (03Merged) 10jenkins-bot: Remove (random?) 'user: (;;);' at right top of navigation [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478487 (owner: 10Stibba) [17:05:18] (03CR) 10Urbanecm: [C: 04-1] "> Patch Set 1:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:05:55] Hello? [17:06:19] hi pterp [17:06:45] Do you have an idea of what's going on? [17:09:40] pterp: Could you upload results somewhere? [17:09:48] Of what? [17:09:57] results of that command that I sent you [17:10:03] bundle exe [17:10:06] *exec [17:10:06] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Upgrade Tracker's JS to ES6 - https://phabricator.wikimedia.org/T211144 (10Urbanecm) Per @takidelfin's request. [17:10:54] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Upgrade Tracker's JS to ES6 - https://phabricator.wikimedia.org/T211144 (10Urbanecm) https://codein.withgoogle.com/tasks/5222886546604032/ [17:11:57] Running and logging. [17:12:37] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10ToBeFree) @Billinghurst , one comment above yours: "Allow blocked admins to block the user wh... [17:15:22] 10MediaWiki-extensions-OATHAuth, 10Growth-Team, 10Notifications: Users should be notified when only two scratch tokens are left - https://phabricator.wikimedia.org/T131788 (10Reedy) >>! In T131788#4808465, @Leaderboard wrote: > A better solution is for MW to just list out the remaining scratch codes left. I... [17:15:24] (03CR) 10Arcayn: "grant_list uses the grant_table datatable whereas grant_detail and topic_list both use the topic_table datatable which you might as well a" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [17:15:43] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Ignore null revisions when checking if a non-admin can overwrite a redirect - https://phabricator.wikimedia.org/T211504 (10ToBeFree) p:05Triage>03Lowest [17:15:58] (03PS2) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [17:16:15] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Do not show a rollback link if all the affected edits are null revisions - https://phabricator.wikimedia.org/T211505 (10ToBeFree) p:05Triage>03Lowest [17:16:33] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10Reedy) >>! In T199118#4808463, @Leaderboard wrote: > Not in favour of this change, considering the potential issues with 2FA (5 scratch codes th... [17:16:35] (03CR) 10Nathan fraignt: "> Patch Set 1: Code-Review-1" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:16:43] How long does it take to run? [17:16:59] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10Growth-Team, 10Thanks: Thanking for a null revision should cause the same message as thanking for the log entry. - https://phabricator.wikimedia.org/T211506 (10ToBeFree) p:05Triage>03Lowest [17:17:08] (03CR) 10jerkins-bot: [V: 04-1] Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [17:17:23] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10Growth-Team, 10Thanks: Thanking for a null revision should cause the same message as thanking for the log entry. - https://phabricator.wikimedia.org/T211506 (10ToBeFree) p:05Lowest>03Triage [17:18:09] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Do not show a rollback link if all the affected edits are null revisions - https://phabricator.wikimedia.org/T211505 (10ToBeFree) p:05Lowest>03Triage [17:18:21] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Ignore null revisions when checking if a non-admin can overwrite a redirect - https://phabricator.wikimedia.org/T211504 (10ToBeFree) p:05Lowest>03Triage [17:18:49] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Generate entries for deletions and restores in page histories - https://phabricator.wikimedia.org/T72239 (10ToBeFree) Sub-tasks created. [17:24:22] pterp: ~ 20 minutes [17:24:32] Ok. [17:24:45] but If there is a weird timeout bug - it can take hours [17:26:54] It's ~ 19 thousand lines. Where can I paste it? [17:27:24] Gist [17:27:30] gist.github.com [17:28:11] (03PS3) 10Nathan fraignt: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) [17:28:26] https://gist.github.com/pjht/f627029d0d180a9d31604b8225ea53ab The [0;33m and  are the color codes. They do not show in regular output. [17:28:43] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Dereckson) "Although the opinions are mixed about its positive/negative impact, that is clear it should be reverted." I've some difficulties with this concept. How can a thing could be... [17:30:42] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (032 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:31:29] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Bencemac) Because we voted for a test period/temporary time, but currently this is the default settings. [17:35:17] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:36:48] 10ContentTranslation: CX2: MT abuse warning shown when draft is loaded - https://phabricator.wikimedia.org/T211507 (10Petar.petkovic) [17:39:25] pterp: [17:39:30] Yes? [17:39:34] https://www.irccloud.com/pastebin/qA8zASXA/ [17:39:44] Try installing chromedriver [17:39:51] What's that? [17:40:18] up, what is? [17:40:19] http://chromedriver.chromium.org/ [17:40:54] by installing I mean updating tho [17:41:04] try running 'chromedriver-update' in terminal [17:42:10] Done. [17:42:17] :) [17:42:21] try running it again [17:42:27] pterp: hi! what're you working on [17:42:29] or, maybe try running one test only [17:42:35] shreyasminocha: wikiedudashboard [17:42:38] Running again. [17:42:44] No logging. [17:42:45] ah, the set up task [17:42:59] nope, rubocop task [17:43:00] :D [17:43:17] No idea what the set up task is. Never did it. [17:43:23] pterp: Are you on WikiEducation slack? [17:43:50] ? No. I don't have slack. I'm connected to the #wikimedia-dev IRC channel. [17:44:04] Tests are failing. [17:44:25] what do they say? [17:44:42] ^ [17:45:12] https://pastebin.com/wu4AnHcn [17:45:59] That's only two of the more that I got and I cut the command off before it finished. [17:46:59] (03CR) 10Esanders: [C: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [17:47:16] hmm... [17:47:22] pterp: maybe join #wikimedia-ed [17:47:31] I will let you know when I see RexxS around here [17:47:31] @notify RexxS [17:47:33] or wait, ragesoss is here too [17:47:43] Ok. Joined. What should I say to them? [17:48:00] describe your issue, be clear [17:48:06] ragesoss: hi! I think GCI student needs your help \o/ [17:48:12] pterp: offer more details if they ask for them [17:48:46] 3 options: ask here, ask on #wikimedia-ed or ask on Slack [17:49:08] tried one [17:49:29] but keep checking here too, someone might come up with suggestions [17:49:40] i doubt #wikimedia-ed is active [17:49:46] but might be worth a shot [17:50:04] I don't even have slack, so that's out. [17:50:12] slack accounts are separate [17:50:23] you gotta create an account for each workspace you wish to join [17:50:34] or place a comment in the task? [17:50:37] i feel it's your best bet (apart from waiting for responses here) [17:51:15] * shreyasminocha is looking for GH issues that might be relevant to our problem [17:52:32] pterp: I could ask Sage to add you, or ask them by yourself. PM'ed you with Sage's email [17:52:47] Who's Sage? [17:53:16] maintainer of wikiedudashboard [17:53:17] *main*tainer of WikiEdu [17:53:22] aka ragesoss [17:53:27] or ragesock [17:53:37] (sage ross -> ragesoss -- get it?) [17:53:42] Ok. What should I email to him? [17:53:59] Ask him to give you access to Wikiedu slack workspace [17:54:17] or you could PM him on irc? [17:54:24] 10Design, 10WMF-Design, 10Wikimedia Design Style Guide, 10CSS: Align the image on the Design Landing Page - https://phabricator.wikimedia.org/T197140 (10Iniquity) @Volker_E hm, so, Is it necessary to move this image too? {F27458071} [17:54:28] I don't really want to sign up for slack though. [17:54:34] shreyasminocha: I don't think so [17:54:55] pterp: Slack is the fastest way to contact with WikiEdu contributors [17:54:59] Ok. fine. [17:55:30] So do i go to slack.com, put my email in, and hit get started? [17:55:58] Send an email to Sage Ross [17:56:09] PM'ed you with mail address [17:56:29] pterp: you'll need to be invited to the slack? [17:56:33] Email sent. [17:57:15] accidental question mark [17:57:24] Ok. [17:57:53] (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ ✧ﾟ･: *ヽ(◕ヮ◕ヽ) [17:58:17] Huh? [17:58:27] don't worry pterp :D [17:59:52] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) [18:01:05] (03PS1) 10Urbanecm: Add a way how to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:02:02] (03CR) 10jerkins-bot: [V: 04-1] Add a way how to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:02:27] (03PS2) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:03:22] (03CR) 10jerkins-bot: [V: 04-1] Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:04:09] (03PS3) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:04:51] (03PS4) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:06:03] (03CR) 10jerkins-bot: [V: 04-1] Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:07:28] (03CR) 10Takidelfin: "Added Jenkins output from flake8" (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:07:30] (03CR) 10Arcayn: "Will let urbanecm decide whether this should affect cr" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:08:31] 10WMCZ-Tracker: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) [18:10:18] (03PS5) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:11:51] `( ͡~ ͜ʖ ͡°)` [18:13:25] `( ͡- ͜ʖ ͡+) [18:13:30] gerrit face [18:13:50] \(+ _ -)/ [18:14:22] "do things diff-ly" [18:16:02] (+_-) [18:16:10] simple gerrit face [18:16:39] (03PS1) 10Urbanecm: Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 [18:16:42] what is gerrit man's fav math subject? [18:16:47] DIFFerentiation [18:16:52] (03CR) 10Urbanecm: [C: 032] Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 (owner: 10Urbanecm) [18:17:01] * badum tss* [18:17:20] no one is here [18:17:21] ;c [18:17:25] wikibugs joke now [18:17:27] or maybe we're too lame [18:17:33] ah, true [18:17:37] takidelfin, beware, c is an IRC nickname ;) [18:17:44] lol [18:17:52] (03Merged) 10jenkins-bot: Add migration to properly propagate new TrackerProfile Meta class [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478491 (owner: 10Urbanecm) [18:17:52] Whoops [18:17:57] setting themselves up for trouble with a nickname like that [18:18:23] (trouble keeping up with pings, that is) [18:19:23] (03PS6) 10Urbanecm: Add a way to make authorized API requests [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478490 (https://phabricator.wikimedia.org/T211508) [18:22:00] what's the funniest irc nick you've seen? [18:22:18] takidelfin[znc]4 [18:22:31] lol [18:23:15] why `[4]`?? [18:23:22] i've seen the ones in between, but wondering [18:23:27] i really don't know [18:23:54] it is random (nickname already taken bug) [18:24:04] lol [18:25:06] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Tgr) Current WMF config discards error-json entirely. I see your point about this change being problematic with the default config (it does see... [18:25:57] * shreyasminocha is editing his /etc/hosts [18:25:58] * shreyasminocha copy-pasted a large /etc/hosts that blocks ads, shock sites etc into his once upon a time [18:26:10] * shreyasminocha hates having to go through the list of shock sites while editing [18:26:53] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) 1. Feel free to figure out how to reproduce, I can't even get this behavior to go away. 2. An empty edit window, there are... [18:30:58] need help with apache [18:30:59] apachectl configtest [18:30:59] AH00557: httpd: apr_sockaddr_info_get() failed for Mars.local [18:30:59] AH00558: httpd: Could not reliably determine the server's fully qualified domain name, using 127.0.0.1. Set the 'ServerName' directive globally to suppress this message [18:31:02] Syntax OK [18:31:19] "Forbidden" on visiting `localhost` [18:31:26] (03PS1) 10Urbanecm: Add system description field to tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478492 (https://phabricator.wikimedia.org/T211508) [18:31:40] shreyasminocha, what does the log say? [18:31:52] Hauskatze, the wiki task is claimed, fyi [18:32:20] wait, restarting give something more interesting [18:32:27] I saw Urbanecm :) [18:32:28] * shreyasminocha is uploading [18:32:39] https://paste.ee/p/eJtVo [18:32:51] I saw Hauskatze :D [18:33:11] * shreyasminocha is amused by the exchange between Hauskatze and Urbanecm [18:33:28] "Set the 'ServerName' directive globally" -- how? [18:33:29] 10MediaWiki-Debug-Logger, 10Continuous-Integration-Config, 10Patch-For-Review: Log suppressed errors with level=DEBUG - https://phabricator.wikimedia.org/T193472 (10Krinkle) @Tgr That seems fine by me as a first step (separate channel). [18:33:42] shreyasminocha, by editing /etc/apache2/apache2.conf or similar file [18:34:03] httpd.conf or apache2.conf? [18:34:09] httpd.conf [18:34:17] (wait, you have both files? [18:34:25] 10MediaWiki-extension-requests, 10Patch-For-Review, 10Performance-Team (Radar): Develop an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [18:34:26] yeah [18:34:35] that's strange [18:34:50] i might have mis-created something earlier, don't worry [18:35:05] there are more files beginning with httpd.conf, so i guess that is it? [18:35:12] probably [18:36:03] you can use NGINX too if there are problems with Apache [18:36:14] i've used nginx earlier actually [18:36:26] but wikimedia uses apache so wanna aget familiar with that too [18:36:26] (03PS12) 10Nathan fraignt: Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) [18:36:36] + it's used frequently in combo with php, mysql [18:36:58] (03CR) 10Nathan fraignt: "> Patch Set 11:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:37:24] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:37:42] "make_sock: could not bind to address [::]:80" should i just change `Listen 80` to something else? [18:38:59] (03PS6) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [18:41:07] shreyasminocha: yup, It should work [18:41:08] (03CR) 10Nathan fraignt: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:41:20] but I think you will need to update LocalSettings.php then [18:41:36] fyi: not my mediawiki instance [18:41:45] setting up to follow my php book [18:41:54] (03Abandoned) 10Urbanecm: Add system description field to tickets [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478492 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [18:43:44] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Tgr) >>! In T210224#4808558, @Bencemac wrote: > Because we voted for a test period/temporary time, not for default (currently this is the default setting). Actually we voted to test it... [18:43:55] shreyasminocha: so set it to anything you want \d [18:46:56] (03CR) 10Esanders: [C: 032] ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:50:37] (03CR) 10Arcayn: [C: 031] "lgtm, great work" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [18:53:21] (03Merged) 10jenkins-bot: ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:53:38] 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.0 support: Confirm that post-send functions work fine with mediawiki under PHP 7 - https://phabricator.wikimedia.org/T209981 (10Krinkle) @BPirkle That might be a problem. It is already a source of uncertainty to me whether our e... [18:54:38] interesting one case switch :D https://www.irccloud.com/pastebin/0rPTAZSu/ [18:54:55] future-ready! :D [18:55:19] (03CR) 10jenkins-bot: ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [18:56:34] Urbanecm: ^ that's why, isn't it? [18:56:49] that's why what? [18:56:58] 00:24 < takidelfin> interesting one case switch :D https://www.irccloud.com/pastebin/0rPTAZSu/ [18:57:01] 00:24 < shreyasminocha> future-ready! :D [18:57:09] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [18:57:13] yeah [18:57:42] hmm, true [18:57:50] in theory it should take data from https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/common_settings.py#L82-L85 [18:58:06] so new languages needs to be added once [18:58:07] this patch or another? :D [18:58:12] another :D [19:00:34] (03PS1) 10Arcayn: Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 [19:02:14] (03PS4) 10Krinkle: Special:AllMessages: Improve zebra striping on hover [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:08:46] (03CR) 10Kosta Harlan: [C: 032] Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:10:22] (03PS10) 10Esanders: [WIP] Special:Preferences (OOUI): Re-design the view-only "basic" section [core] - 10https://gerrit.wikimedia.org/r/458626 (https://phabricator.wikimedia.org/T203727) (owner: 10Jforrester) [19:12:22] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10MusikAnimal) [19:12:34] (03Merged) 10jenkins-bot: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:14:00] (03PS5) 10Krinkle: Special:AllMessages: Improve zebra striping on hover [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:14:02] (03PS1) 10Krinkle: Special:AllMessages: Remove 'id' attribute from message rows [core] - 10https://gerrit.wikimedia.org/r/478494 [19:14:16] (03CR) 10jenkins-bot: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 (owner: 10Catrope) [19:14:40] (03CR) 10Krinkle: "@Volker: I've removed a few hundred bytes (about 2x as much as this one introduces) with I53bd56e0d5a82fba65388e1c2da3c8349a138261. I thin" [core] - 10https://gerrit.wikimedia.org/r/473247 (owner: 10Bartosz Dziewoński) [19:15:47] (03CR) 10Krinkle: Special:AllMessages: Remove 'id' attribute from message rows (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478494 (owner: 10Krinkle) [19:15:58] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review, 10User-notice: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Tgr) >>! In T150826#4808282, @Billinghurst wrote: > 1) A solution to a problem at enWP became... [19:16:38] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Restructure and improve 'Basic information' section - https://phabricator.wikimedia.org/T203727 (10Esanders) What does "View global account info" do? [19:17:36] (03CR) 10Krinkle: [C: 04-1] "The special-casing on the client seems fine (although I'm not a 100% sure yet), but I would prefer for the server-side code to remain agno" [core] - 10https://gerrit.wikimedia.org/r/470181 (owner: 10Bartosz Dziewoński) [19:18:32] (03CR) 10Kosta Harlan: [C: 032] "Thanks for this." (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [19:20:14] (03CR) 10jenkins-bot: Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [19:23:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Special:Preferences (OOUI): Re-design the view-only "basic" section [core] - 10https://gerrit.wikimedia.org/r/458626 (https://phabricator.wikimedia.org/T203727) (owner: 10Jforrester) [19:23:49] (03CR) 10Kosta Harlan: [C: 032] Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:27:57] (03Merged) 10jenkins-bot: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:28:52] (03PS4) 10Kosta Harlan: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:29:40] (03CR) 10jenkins-bot: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:34:20] 10Google-Code-in-2018, 10JSDoc WMF theme, 10Patch-For-Review: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Stibba) 05Open>03Resolved [19:34:41] 10MediaWiki-User-login-and-signup, 10Security: No way to force a user to change their password if it's invalid - https://phabricator.wikimedia.org/T118774 (10Tgr) Logging skips would probably be a good start, we don't seem to be doing that now. (Or are we worried that it might highlight who have vulnerable pas... [19:38:30] (03CR) 10Kosta Harlan: [C: 032] Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:42:15] (03Merged) 10jenkins-bot: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:44:04] (03CR) 10jenkins-bot: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [19:48:55] (03PS1) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 [19:49:53] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (owner: 10Urbanecm) [19:49:57] (03PS2) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:50:57] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:51:00] (03PS3) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:51:32] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [19:51:38] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [19:52:02] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:52:09] 10MediaWiki-User-login-and-signup: Consider displaying a tooltip by the password input field to explain password requirements - https://phabricator.wikimedia.org/T211440 (10Tgr) A tooltip (if you mean in the traditional sense, ie. something shown on hover) does not seem useful as people have no reason to hover o... [19:52:27] Urbanecm: `('en', _('English')),` [19:52:27] Is it equalivent to `[ language, fullLanguage ]`? (I'm assuming that fullLanguage is english name) [19:52:38] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) [19:52:53] takidelfin, yes, but the method called _ will localize English [19:53:04] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Tgr: Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) [19:54:02] (03PS4) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:54:09] So _ does not return 'localized' message? Just English? [19:54:24] localise english -> diff language i think [19:54:39] (03CR) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [19:54:39] Urbanecm: hmm, I think I missunderstood you [19:54:43] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: implement support for VE and MobileFrontend - https://phabricator.wikimedia.org/T211059 (10kostajh) @Catrope looks good! Moving back to "Ready for development" to implement the MobileFrontend bit. We'll... [19:54:59] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:55:02] takidelfin, _('anything') returns anything in current user's language [19:55:11] You mean that _('') will [19:55:12] ah [19:55:21] Thank you ^-^ [19:55:23] yw [19:55:45] so fullLanguage is always `English name` then [19:56:15] yes, in datatables-init.js, fullLanguage should be the English name of the language [19:57:10] (03PS5) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [19:57:57] Urbanecm: https://gist.github.com/takidelfin/2524b9485a822e4f615f5f67cd01a9fa [19:58:08] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [19:59:02] so `url = blahblah/i18n/English.json` [19:59:10] hmm [20:00:00] if I go to tracker.wikimedia.cz and have English as my current locale, then it downloads https://cdn.datatables.net/plug-ins/9dcbecd42ad/i18n/English.json [20:00:20] if I go to tracker.wikimedia.cz and have Czech as my locale, it downloads https://cdn.datatables.net/plug-ins/9dcbecd42ad/i18n/Czech.json [20:00:21] why? [20:00:35] https://usercontent.irccloud-cdn.com/file/rciFbyOp/screenshot_20181209_210018.png [20:01:23] for some strange reason, it looks to me it is working [20:01:27] (but it shouldn't) [20:01:53] 10MediaWiki-User-login-and-signup, 10MediaWiki-Vendor, 10Security-Reviews: Security review of bjeavons/zxcvbn-php - https://phabricator.wikimedia.org/T211489 (10Tgr) Although the discussion there gives the impression that the bjeavons version actually does a better job. And the last commit to the Dropbox rep... [20:02:00] * shreyasminocha waves goodbye [20:02:37] goodbye shreyasminocha [20:02:54] bye shreyasminocha [20:03:07] shreyasminocha: o/ [20:03:22] \o bye all [20:03:26] hmm, you are right... it is weird https://usercontent.irccloud-cdn.com/file/8MzDK0mP/screenshot_20181209_210259.png [20:03:51] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) See also T32574#4446825. [20:05:33] takidelfin, hmm, I know why [20:05:56] index.html doesn't use datatables-init.js [20:06:04] it doesn't work on any non-index page [20:06:08] https://gist.github.com/takidelfin/4cd228e38451dc07084f6bb9231ec601 [20:06:12] right [20:06:15] got it too :D [20:06:26] good! [20:06:40] are you going to fix it or do you want me to? [20:06:48] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Nathan_fraignt) MediaWiki username is also visible on the preferences page. [20:07:03] I will fix it in this 'case' from common_settings.py [20:08:02] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) [20:09:06] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Urbanecm) Sorry, I wrote the description in a confusing way. I meant that it isn't possible to get the username in JavaScript code easily (I don't take scrapping preferences page as an easy way). [20:09:25] nice, that's good takidelfin [20:10:13] 10WMCZ-Tracker: Allow ordinary users to view their own TrackerProfile - https://phabricator.wikimedia.org/T211509 (10Nathan_fraignt) True. I thought you meant that it was impossible to see their username in general. [20:12:25] (03PS6) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [20:13:26] (03CR) 10Nathan fraignt: [C: 031] Fix the grant_detail breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478493 (owner: 10Arcayn) [20:13:42] (03CR) 10jerkins-bot: [V: 04-1] Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) (owner: 10Urbanecm) [20:14:18] (03PS1) 10Esanders: build: Update stylelint-config-wikimedia to 0.5.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478496 [20:15:41] (03PS7) 10Urbanecm: Update MediaInfo schema structure [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478495 (https://phabricator.wikimedia.org/T211508) [20:16:20] Urbanecm: I think I will need do something like this: extend primitive base to include a global variable (array of arrays, so tuple of tuple conversion) JSON dumps'ed and passed as a context. Then JS can simply access a LANGUAGES field [20:18:40] takidelfin, that would work, but what about doing something about https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/views.py#L215-L236? Or, it'll be even better if it is added to "regular" API [20:19:01] So: when Django loads primitive base, pass a context to it (effect of json.dumps ( variable from commons settings py )), and then use it like: const LANGUAGES = {{ LANGUAGES_JSON|escapejs}} [20:19:10] Urbanecm: hmm, API? [20:20:55] * takidelfin facepalms [20:20:55] * takidelfin Why I forgot that I can use it to connect py -> js... "overthinking" a problem [20:21:25] (hey IRC client, it should not send as two /me) [20:22:23] :) [20:25:58] Urbanecm: So I should add it to views.py ? [20:27:56] takidelfin, yup (and to urls.py too). Or, as I said, you can think about how to add languages to /api (defined here https://github.com/wikimedia/wikimedia-cz-tracker/tree/master/trackersite/api, docs https://www.django-rest-framework.org/) [20:28:25] I will add it to /api maybe (and learn how it works first :D) [20:28:28] (03CR) 10Urbanecm: [C: 032] Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [20:28:35] Maybe it will be helpful in future [20:28:44] yeah, so others might load it in a standardized way [20:28:51] feel free to ask questions if you need :) [20:29:29] (03Merged) 10jenkins-bot: Fix sorting of dates, (pre)expeditures and wages on all tables [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478472 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [20:30:04] 04(no projects): Release Huggle 3.4.6 - https://phabricator.wikimedia.org/T211517 (10Petrb) [20:36:33] (03CR) 10Urbanecm: [C: 032] Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [20:37:40] (03Merged) 10jenkins-bot: Add max import rows to settings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478481 (https://phabricator.wikimedia.org/T211486) (owner: 10Nathan fraignt) [20:38:14] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Urbanecm) 05Open>03Resolved [20:46:12] Krinkle, thank you for merging https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/467448, but doesn't it need to be deployed too? [20:49:06] Don't think so as they are just tests [20:50:04] Ebe123, even the tests directory is cloned on the deploy host [20:50:41] and relevant commits will be downloaded once a deployer does git fetch [20:51:03] (03PS1) 10Esanders: Use VE focus/blur events for styling [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478499 (https://phabricator.wikimedia.org/T211515) [20:55:48] (03PS1) 10Esanders: Remove unused mw-ui-field classes [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478501 [20:58:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/478500 (owner: 10L10n-bot) [20:59:41] (03PS5) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) [21:00:00] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) https://codein.withgoogle.com/tasks/6523125417115648/ [21:02:28] (03CR) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA (034 comments) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [21:17:05] 10Google-Code-in-2018, 10Developer-Advocacy (Oct-Dec 2018): Google Code-in 2018: Collect Feedback and Lessons Learned - https://phabricator.wikimedia.org/T205328 (10Ebe123) Some quick comments to jot down * Section 4.2 of the rules should be clarified either for GCI as a whole or for an org interpretation. (T2... [21:20:05] `Cannot apply DjangoModelPermissions on a view that does not set `.queryset` or have a `.get_queryset()` method.` [21:20:06] hmm [21:20:23] I'm trying to do it using APIView [21:20:29] because it doesn't have Model [21:21:00] class LanguagesViewSet(APIView): [21:21:00] def get(self): [21:21:00] return Response(dumps(LANGUAGES)) [21:21:26] urlpatterns = router.urls [21:21:26] urlpatterns += [ [21:21:26] url(r'tracker/languages', LanguagesViewSet.as_view(), name='languages') [21:21:26] ] [21:21:55] (I was trying to find a solution, there are the results - nothing works :( ) [21:22:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478502 (owner: 10L10n-bot) [21:22:18] Urbanecm: Could you take a look? Maybe I'm should use model? (create it?) [21:22:47] https://medium.com/django-rest-framework/django-rest-framework-viewset-when-you-don-t-have-a-model-335a0490ba6f [21:22:52] because queryset requires a model [21:23:09] https://stackoverflow.com/questions/35019030/how-to-return-custom-json-in-django-rest-framework/35019122 [21:23:14] https://medium.com/crowdbotics/how-to-write-an-api-in-3-lines-of-code-with-django-rest-framework-59b0971edfa4 [21:23:34] 10MediaWiki-User-login-and-signup, 10Security, 10User-Tgr: Add password generator to account creation / password change form - https://phabricator.wikimedia.org/T151011 (10Tgr) There are two types of good password generation: # A medium-length string of random uppercase/lowercase/numbers (say 12 or 16 charac... [21:24:13] (03PS1) 10Daniel Kinzler: Print chained exceptions when maintenance script fails. [core] - 10https://gerrit.wikimedia.org/r/478503 [21:24:29] Ebe123: thanks, I will try it [21:26:55] 10MediaWiki-extensions-Translate: MW with translation extension (meta.wikimedia.org) sometimes fails to open proper section on [edit source] of section - https://phabricator.wikimedia.org/T211519 (10Petrb) [21:27:27] (03PS1) 10Nathan fraignt: Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) [21:29:54] this looks like a lamp tho: /•_•\ [21:31:19] /•-•\ [21:31:19] ¥ [21:31:19] | [21:34:54] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Nathan_fraignt) a:03Nathan_fraignt [21:40:19] 10Google-Code-in-2018, 10Goatification, 10International-Developer-Events, 10Wikimedia-Technical-Conference-2018: GCI: Racconicorn Racoonmendations Sticker - https://phabricator.wikimedia.org/T207973 (10Stibba) {F27460155} [21:43:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/478511 (owner: 10L10n-bot) [21:47:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478508 (owner: 10L10n-bot) [21:49:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/478513 (owner: 10L10n-bot) [21:51:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/478510 (owner: 10L10n-bot) [21:53:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/478520 (owner: 10L10n-bot) [21:54:06] (03CR) 10Urbanecm: [C: 032] Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) (owner: 10Nathan fraignt) [21:54:28] takidelfin, sorry, I missed your message [21:54:53] takidelfin, you can write custom viewset [21:54:56] https://www.django-rest-framework.org/api-guide/viewsets/ [21:55:13] (03Merged) 10jenkins-bot: Fix: addexampledata only generates tickets with example users. [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478504 (https://phabricator.wikimedia.org/T211510) (owner: 10Nathan fraignt) [21:55:17] o? [21:55:40] takidelfin, if that means you don't understand me [21:55:46] nono no [21:55:56] I need to make my own viewset, right? [21:56:09] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: addexampledata should create tickets with only self-generated users in requested_user field - https://phabricator.wikimedia.org/T211510 (10Urbanecm) 05Open>03Resolved [21:56:46] takidelfin, yes. [21:56:52] ^-^ [21:56:56] an example is on https://www.django-rest-framework.org/api-guide/viewsets/#example [21:58:14] takidelfin, you don't need to create whole model, because there's no need to store the languages in the database - we already have them somewhere [21:58:39] 10WMCZ-Tracker: Use REST API instead of non-standard pseudo-API - https://phabricator.wikimedia.org/T211521 (10Urbanecm) [21:58:58] yup, I thought that it would be weird to create a model for a really simple thing [21:59:07] :) [21:59:25] thanks for explanation \\ [21:59:29] yw [22:00:37] 10WMCZ-Tracker, 10Patch-For-Review: It isn't possible to order on page of any individual ticket - https://phabricator.wikimedia.org/T211280 (10Urbanecm) 05Open>03Resolved [22:00:57] 10WMCZ-Tracker: Tests in Tracker fail from time to time from non-obvious reason - https://phabricator.wikimedia.org/T207310 (10Urbanecm) p:05High>03Low Not high priority anymore, as it doesn't break anything. [22:02:13] hmm, also `queryset` needs a Model. Without `queryset` Django returns: `Cannot apply DjangoModelPermissions on a view that does not set `.queryset` or have a `.get_queryset()` method.` [22:02:41] :< [22:02:42] (03CR) 10Prtksxna: [C: 04-2] "Hey Zoranzoki, sorry for the delayed response. The patchset is correct but you've made it in the wrong repository. The mediawiki repositor" [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) (owner: 10Zoranzoki21) [22:04:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/478518 (owner: 10L10n-bot) [22:05:14] hmm, I should pass LANGUAGES as queryset? [22:05:31] (03PS18) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [22:06:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478528 (owner: 10L10n-bot) [22:07:13] `AssertionError: `base_name` argument not specified, and could not automatically determine the name from the viewset, as it does not have a `.queryset` attribute.` [22:08:18] 10Google-Code-in-2018, 10JSDoc WMF theme, 10Patch-For-Review: Remove the redundant Class:* heading from the page - https://phabricator.wikimedia.org/T207381 (10Prtksxna) Thanks for your work on this, @Stibba {icon smile-o} [22:08:31] hmm, third argument 🤔 [22:11:11] http://www.tomchristie.com/rest-framework-2-docs/api-guide/routers [22:13:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/478530 (owner: 10L10n-bot) [22:15:42] takidelfin, you shouldn't need to specify a queryset for this API [22:15:44] *viewset [22:15:44] https://medium.com/django-rest-framework/django-rest-framework-viewset-when-you-don-t-have-a-model-335a0490ba6f [22:15:48] ^^ this might help you ^^ [22:16:10] (sorry for delayed response, ping me if you need my fast response - I have notifications on pings) [22:16:18] Is serializer required? [22:17:18] yes, serializer specifies how should the API format the data [22:18:30] (03PS1) 10Urbanecm: [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 [22:20:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478531 (owner: 10L10n-bot) [22:21:11] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) [22:21:33] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) p:05Triage>03High [22:22:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478532 (owner: 10L10n-bot) [22:23:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478536 (owner: 10L10n-bot) [22:27:04] (03PS3) 10Bjornskjald: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) [22:27:10] (03CR) 10jerkins-bot: [V: 04-1] Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:28:23] (03CR) 10Urbanecm: [C: 032] [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 (owner: 10Urbanecm) [22:29:16] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Core Platform Team Backlog (Watching / External), 10Technical-Debt: Audit and simplify MediaWiki initialisation code (Spring 2018) - https://phabricator.wikimedia.org/T189966 (10Krinkle) a:05Krinkle>03None Un-assigning for now as this isn't current... [22:29:21] (03Merged) 10jenkins-bot: [notifications] Internationalize subject [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478565 (owner: 10Urbanecm) [22:30:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478540 (owner: 10L10n-bot) [22:30:38] 10WMCZ-Tracker: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10takidelfin) a:03takidelfin [22:32:37] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Help Panel: Enable on beta labs - https://phabricator.wikimedia.org/T211206 (10kostajh) > the asterisk is not present until 'Review and submit' is clicked - should we co... [22:32:59] (03PS1) 10Urbanecm: [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 [22:33:14] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [22:33:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/478538 (owner: 10L10n-bot) [22:34:23] (03CR) 10Gergő Tisza: "This should be good to go barring security review of the library, but I feel the UX is not great and I would personally not enable somethi" [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [22:35:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478553 (owner: 10L10n-bot) [22:35:42] (03PS1) 10QChris: Add .gitreview [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478567 [22:35:44] (03CR) 10QChris: [V: 032 C: 032] Add .gitreview [extensions/ImageCompare] - 10https://gerrit.wikimedia.org/r/478567 (owner: 10QChris) [22:36:30] (03CR) 10Gergő Tisza: Add a password strength policy to validate the password (031 comment) [core] - 10https://gerrit.wikimedia.org/r/434105 (https://phabricator.wikimedia.org/T32574) (owner: 10Edlira) [22:39:56] (03CR) 10Urbanecm: [C: 032] [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 (owner: 10Urbanecm) [22:41:07] (03Merged) 10jenkins-bot: [bugfix] Some notifications were always in English [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478566 (owner: 10Urbanecm) [22:42:48] 10MediaWiki-User-login-and-signup, 10MediaWiki-User-preferences, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Tgr: Display a password strength bar - https://phabricator.wikimedia.org/T32574 (10Tgr) I feel using zxcvbn as a standard password policy check is not good UX. One issue is that it can... [22:43:57] 10Google-Code-in-2018, 10FormWizard, 10FormWizard-Gadget: Design a logo for FormWizard Extension. - https://phabricator.wikimedia.org/T208193 (10Stibba) Here is my logo License: Attribution 4.0 International (CC BY 4.0) {F27460875} [22:45:04] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [22:46:54] 10Growth-Team: Help Panel: Show search link content and help link content inside help panel - https://phabricator.wikimedia.org/T211513 (10kostajh) [22:47:24] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy checks should be able to communicate details to client-side logic via the validatepassword API - https://phabricator.wikimedia.org/T211525 (10Tgr) [22:48:08] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) > And password checking methods should probably be able to return extra data that's communicated to the client via the password validation API module, so someth... [22:48:22] (03PS1) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:48:34] 10MediaWiki-User-login-and-signup: $wgPasswordPolicy should be able to alter the password form field - https://phabricator.wikimedia.org/T211514 (10Tgr) [22:48:53] (03PS2) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:50:00] (03PS3) 10Takidelfin: Style: Fix button being to big [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:51:17] (03PS4) 10Takidelfin: Style: Fix too big checkbox [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:51:53] (03PS5) 10Takidelfin: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [22:52:26] Urbanecm: https://phabricator.wikimedia.org/T211522 [22:52:31] Could you review my patch? [22:52:32] :D [22:52:40] oops, wrong link [22:52:40] * takidelfin https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478568 [23:00:03] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) Original: {F27461086} Now: {F27461091} [23:01:04] takidelfin, compare the two images on https://phabricator.wikimedia.org/T211522#4808972 [23:01:06] the checkbox looks to be indented a little [23:01:08] why? [23:01:14] yup, I see [23:01:17] It is weird :/ [23:01:56] Urbanecm: Could you give me a link to this view? [23:02:15] you mean the view I screenshoted? [23:02:35] http://localhost:8000/ticket/new/ [23:02:42] :O [23:03:07] the screenshot titled original is from https://tracker2.wikimedia.cz/ticket/new/ [23:05:11] I don't see `did you travel by car` option :/ https://usercontent.irccloud-cdn.com/file/mtQdxao9/screenshot_20181210_000439.png [23:05:56] _shreyasminocha: o. [23:05:58] o/ [23:06:34] takidelfin, you need to select a topic that has "Require statutory declaration" checked [23:07:36] Urbanecm: so it is still too big? [23:08:04] it isn't too big. It is only indented [23:09:09] (03PS6) 10Takidelfin: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) [23:10:03] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10takidelfin) {F27461240} [23:10:21] looks good now [23:10:24] thanks [23:10:36] yeay [23:10:55] (03CR) 10Urbanecm: [C: 032] Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) (owner: 10Takidelfin) [23:11:30] * takidelfin whispers: psst, there will be a big UI patch soon [soon - 5 days] [23:11:33] (03CR) 10Urbanecm: [C: 031] "looks reasonable" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478378 (owner: 10Takidelfin) [23:12:05] Urbanecm: thanks for +1 :D [23:12:08] yw [23:12:11] (03Merged) 10jenkins-bot: Style: Fix too big checkboxes [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478568 (https://phabricator.wikimedia.org/T211522) (owner: 10Takidelfin) [23:12:19] 🎉 [23:12:53] okay, so the deployment blocker was resolved thanks to takidelfin, let's deploy changes on prod and go to bed. see you tomorrow! [23:13:07] Goodnight! [23:13:15] I should do some tasks now, because I have got only 33 tasks done ough [23:14:14] that's still more than number of GCI tasks I completed :D [23:14:36] ?-? [23:14:45] 10WMCZ-Tracker, 10Patch-For-Review: Checkboxes are extremely big - https://phabricator.wikimedia.org/T211522 (10Urbanecm) 05Open>03Resolved [23:14:59] was meant as a joke, nevermind :) [23:15:22] ah, now I undestand [23:15:23] :)\ [23:15:44] More GCI and I will start writing my messages like that\n [23:16:04] :) [23:16:19] ad task, what about https://codein.withgoogle.com/tasks/5763295794429952/? should be quite easy and useful :) [23:16:32] (ofc, it's up to you, just suggesting :)) [23:16:59] Maybe I will make another tool like I did it with redundant namespaces 🤔 [23:17:03] Thanks for suggestion! [23:17:12] yw [23:17:48] you can also do lua #8 or #9 :) [23:18:27] looks like I will don't go to school tomorrow (or today lol) :D [23:22:37] (03CR) 10Gergő Tisza: [C: 04-1] "checkUnblockSelf is invoked from checkExecutePermissions which runs on GET as well. When the user visits the base block page (Special:Bloc" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:23:43] 04(no projects): Copy and paste does not work in Source code editor - https://phabricator.wikimedia.org/T211528 (10MichaelSchoenitzer) [23:24:07] Urbanecm: `dobranoc` btw! (heh, this is so similiar to Czech `dobrou noc`, eq. Miej(`mejte sve`) [23:24:07] `dobrą noc`, `ą` -> `ou`) :D [23:24:32] :) [23:24:57] * similar [23:25:17] (03PS4) 10Gergő Tisza: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:27:17] (03CR) 10Gergő Tisza: "Added a trivial fix. There are probably nicer ways to do it but I don't want to hold up this patch. (Same applies to my earlier comments a" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:34:10] (03CR) 10Gergő Tisza: [C: 032] "Tested, works as expected. (With the quirk that the user cannot use Special:Block, only Special:Block/, as the former fails" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:47:52] (03Merged) 10jenkins-bot: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:50:25] (03CR) 10jenkins-bot: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:54:39] 10Wikimedia-production-error: T206030 - https://phabricator.wikimedia.org/T211529 (10Krinkle) [23:54:48] 10Wikimedia-production-error: ApiQuerySiteinfo.php: PHP Notice: Undefined index: 103 - https://phabricator.wikimedia.org/T211529 (10Krinkle)