[00:00:51] 10MediaWiki-General-or-Unknown, 10Tracking: High-density display issues (HiDPI) (tracking) - https://phabricator.wikimedia.org/T34101 (10Pkra) [00:05:45] 10MobileFrontend, 10Math, 10Need-volunteer, 10Readers-Web-Backlog (Design): Math formulas can be unreadable in references in mobile view - https://phabricator.wikimedia.org/T129054 (10Pkra) This is effectively the same as T111222. Once again, inlining equation SVGs would help here, too (since they would... [00:13:37] 10MediaWiki-File-management, 10MediaWiki-Maintenance-scripts, 10Commons, 10Multimedia, and 3 others: cronspam cleanup: Cron /usr/local/bin/foreachwiki maintenance/cleanupUploadStash.php > /dev/null - https://phabricator.wikimedia.org/T150375 (10Dzahn) >>! In T150375#4803529, @jijiki wrot... [00:19:12] (03CR) 10Krinkle: "Interesting to see these two connected. Especially because unlike typical xhprof/tideways-like profilers, this would presumably have much " [core] - 10https://gerrit.wikimedia.org/r/476198 (owner: 10Tim Starling) [00:22:43] (03PS17) 10Catrope: ResourceLoader: Add support for packageFiles [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) [00:22:48] (03PS1) 10Cooltey: [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) [00:24:21] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) (owner: 10Cooltey) [00:29:19] 10MediaWiki-API, 10Category: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Kipod) [00:29:42] 10MediaWiki-API, 10Category: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Kipod) [00:31:37] (03PS2) 10Cooltey: [WIP] Add "adding title descriptions feed" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/478375 (https://phabricator.wikimedia.org/T164606) [00:33:46] (03PS5) 10MR70: List of permissions should not be shown for non-existent global groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456997 (https://phabricator.wikimedia.org/T201723) [00:35:58] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Personalized first day: build Variation C - https://phabricator.wikimedia.org/T207717 (10Etonkovidova) Checked https://gerrit.wikimedia.org/r/478230 in betalabs - all looks good. [00:40:28] (03PS1) 10Catrope: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 [00:46:39] (03PS2) 10Catrope: Help panel: Make sure "view more" link is localized [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478376 [00:46:41] (03CR) 10Brian Wolff: [C: 04-1] "Some small grammatical things" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/478289 (https://phabricator.wikimedia.org/T210923) (owner: 10Rafidaslam) [00:49:04] Hmm, is it worth making new gci tasks? deadline is in 2 days [00:49:10] probably not [00:49:45] I was contemplating converting https://www.mediawiki.org/wiki/Template:Extension to use the lua module into a gci task and never got around to it [00:49:46] bawolff: o/ [00:50:20] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: CX2: Don't add block templates to the translation if equivalent template is missing - https://phabricator.wikimedia.org/T204937 (10Etonkovidova) Notes for QA: When testing... [00:51:02] `Uncaught TypeError: Cannot read property 'useUS' of undefined` [00:51:02] `resources/src/mediawiki.api/options.js:44` [00:51:05] D: [00:51:20] `// Can we bundle this option, or does it need a separate request? [00:51:20] if ( this.defaults.useUS ) {` [00:51:49] defaults is undefined ;-; [00:52:14] bawolff: maybe you know what is happening? [00:52:53] Where are you getting this error? [00:53:08] (I'm writing a message) [00:53:08] (03CR) 10Krinkle: ResourceLoader: Add support for packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) (owner: 10Catrope) [00:53:30] this problem occurs when I try to call `mw.Api.prototype.saveOptions('name', 'value` [00:53:36] ') [00:53:45] * saveOption [00:53:59] mw.Api.prototype.saveOption('name', 'value') [00:54:06] ok, you should not be calling .prototype directly [00:54:19] oh? [00:54:24] So how to access it? [00:54:31] you're supposed to be calling it like: var api = new mw.Api; api.saveOption( 'name', 'value' ); [00:54:35] Because `mw.Api.saveOption` is undefined [00:54:38] ahh [00:54:40] sorry :( [00:54:45] The property named prototype is special in javascript [00:54:51] yup, I know it [00:54:53] And related to how Object-orientedness works in js [00:55:01] but I thought something is broken [00:55:27] thank you ^-^ [00:57:13] When you call like mw.Api.prototype.saveOptions, `this` becomes set to mw.api.prototype, but defaults is not a property of mw.Api.prototype, but the specific instance of the mw.Api class, so that's how you end up with an undefined [01:15:29] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Create a guided tour about accessing a StructuredDiscussions Topic page the first time - https://phabricator.wikimedia.org/T210403 (10takidelfin) @SBisson Looks like I need to add step 5... [01:18:19] (03PS8) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [01:19:27] (03CR) 10Takidelfin: "This change is ready for review." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [01:21:48] (03CR) 10jerkins-bot: [V: 04-1] Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [01:22:18] (03CR) 10jerkins-bot: [V: 04-1] Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [01:23:16] (03PS9) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [01:27:12] (03PS1) 10Takidelfin: git: Ignore Intellij IDEA and VS Code preferences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478378 [01:27:59] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Communicate template exists in the target wiki but mapping could not be completed - https://phabricator.wikimedia.org/T209473 (10Etonkovidova) Thanks, @Pginer-WMF - I completely agree >For this ticket we are focusing on the cases wh... [01:28:46] (03PS2) 10Takidelfin: git: Ignore Intellij IDEA and VS Code preferences [extensions/Flow] - 10https://gerrit.wikimedia.org/r/478378 [01:31:40] (03CR) 10Takidelfin: "> We're not going to show it to IPs. We're missing a key part of infrastructure for that in GuidedTour. That would be an" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [01:31:55] 10Growth-Team (Current Sprint): Help panel: implement support for VE and MobileFrontend - https://phabricator.wikimedia.org/T211059 (10Catrope) a:03Catrope [01:32:03] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team (Current Sprint): Help panel: implement support for VE and MobileFrontend - https://phabricator.wikimedia.org/T211059 (10Catrope) [01:32:23] (03CR) 10Takidelfin: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [01:33:35] (03PS1) 10Catrope: Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 [01:34:00] what is wrong with Jenkins bot 🤔 [01:34:16] I want to sleeep [01:34:18] *sleep [01:34:46] wikibugs: hey, maybe you know what happened to him? [01:34:55] wm-bot: or maybe you? [01:34:55] Hi takidelfin, there is an error, I'm a stupid bot and not intelligent enough to hold a conversation with you :-) [01:35:00] ;( [01:35:16] I'm alone [01:35:16] (03CR) 10jerkins-bot: [V: 04-1] Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [01:35:25] ah, wikibugs is there [01:35:49] (03CR) 10jerkins-bot: [V: 04-1] Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [01:35:52] only that he is not so willing to talk [01:36:05] ! [01:36:05] Hello, I'm wm-bot. The database for this channel is published at http://wm-bot.wmflabs.org/db/%23mediawiki.htm More about WM-Bot: https://meta.wikimedia.org/wiki/wm-bot [01:36:11] Hello! [01:37:58] (03CR) 10Catrope: ResourceLoader: Add support for packageFiles (031 comment) [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) (owner: 10Catrope) [01:39:30] (03PS1) 10Catrope: ResourceLoaderContext: Add getConfig() method [core] - 10https://gerrit.wikimedia.org/r/478380 [01:40:37] (03PS18) 10Catrope: ResourceLoader: Add support for packageFiles [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) [01:50:08] goodbye! [02:03:04] (03CR) 10Esanders: [C: 04-1] "I think it would be better to create a separate file, module and handler for ReCaptcha JS. The code containing the google.com recaptcha sc" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [02:10:19] (03PS1) 10Catrope: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) [02:10:21] (03PS1) 10Catrope: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) [02:10:45] (03PS2) 10Catrope: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) [02:10:56] (03PS2) 10Catrope: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) [02:12:38] (03CR) 10jerkins-bot: [V: 04-1] Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [02:12:42] (03PS2) 10Catrope: Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 [02:13:23] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478383 [02:14:23] (03CR) 10jerkins-bot: [V: 04-1] Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) (owner: 10Catrope) [02:14:29] (03CR) 10jerkins-bot: [V: 04-1] Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 (owner: 10Catrope) [02:15:56] (03PS3) 10Catrope: Help panel: Factor out help panel link generation into its own function [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478379 [02:16:44] (03PS3) 10Catrope: Help panel: Move config vars into a data module [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478381 (https://phabricator.wikimedia.org/T211059) [02:18:36] (03PS3) 10Catrope: Help panel: display the help panel when VisualEditor is opened [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/478382 (https://phabricator.wikimedia.org/T211059) [02:19:10] 10ContentTranslation: Suggestions do not include a valid article title - https://phabricator.wikimedia.org/T211465 (10Etonkovidova) [02:20:26] 10ContentTranslation: New translation: Suggestions do not include a valid article title - https://phabricator.wikimedia.org/T211465 (10Etonkovidova) [02:24:49] (03PS1) 10Esanders: eslint: Remove rule expcetions and auto-fix [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/478384 [02:38:49] (03CR) 10Esanders: [C: 032] "recheck" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [02:43:37] (03CR) 10jerkins-bot: [V: 04-1] Use existing overlay for all popups [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [03:02:30] 10Google-Code-in-2018, 10OOUI, 10User-Zoranzoki21: OOUI Documentation: ClippableElement: Fix typo in #$element - https://phabricator.wikimedia.org/T210133 (10Zoranzoki21) a:03Zoranzoki21 [03:11:25] (03CR) 10Gergő Tisza: [C: 032] Add missing dependencies on core modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/477816 (owner: 10Fomafix) [03:14:37] 10WikiApiary: wikiapiary not updating - https://phabricator.wikimedia.org/T207952 (10edwardspec) @DeepBlue Looks like BumbleBee bot is not running: https://wikiapiary.com/wiki/Special:Contributions/Bumble_Bee [03:15:06] (03Merged) 10jenkins-bot: Add missing dependencies on core modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/477816 (owner: 10Fomafix) [03:17:15] (03PS1) 10Zoranzoki21: Fix typo "#$element" in the OOUI Documentation [core] - 10https://gerrit.wikimedia.org/r/478386 (https://phabricator.wikimedia.org/T210133) [03:18:00] (03PS2) 10Esanders: ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [03:19:39] (03CR) 10jenkins-bot: Add missing dependencies on core modules [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/477816 (owner: 10Fomafix) [03:22:37] (03PS8) 10Gerrit Patch Uploader: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:22:39] (03CR) 10Gerrit Patch Uploader: "This commit was uploaded using the Gerrit Patch Uploader [1]." [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:23:01] (03CR) 10Zoranzoki21: "Rollbacked to PS 6" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:23:43] (03CR) 10Zoranzoki21: "recheck" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:27:52] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:33:18] (03PS9) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [03:36:01] (03PS10) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [03:38:33] (03CR) 10Bartosz Dziewoński: [C: 031] ve.init.mw.TitleBlacklistSaveErrorHandler: Disallow retrying [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478238 (owner: 10Bartosz Dziewoński) [03:40:10] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [03:40:36] (03PS4) 10Rafidaslam: SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed [core] - 10https://gerrit.wikimedia.org/r/478289 (https://phabricator.wikimedia.org/T210923) [03:47:22] (03PS11) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [03:50:52] (03PS12) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [03:50:55] i'm getting a failed test after updating babel-preset-env and related dependencies... [03:51:06] unlike last time, i have a more descriptive rror message [03:51:16] would anyone please care to look? https://paste.ee/p/7E4e6 [03:54:46] (03PS13) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [03:58:55] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [04:00:57] (03PS14) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [04:04:46] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [04:07:04] (03PS15) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [04:11:11] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [04:40:42] (03PS3) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) [04:41:17] Zoranzoki seems to be struggling with his patch [04:41:22] wish they were online [04:41:35] (03PS1) 10Nouman: @Esanders great idea. I've moved the code into it's own handler file. Please let me know if you would prefer another way of passing the recaptcha script URL to the client. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478389 [04:43:15] (03CR) 10Nouman: "Esanders I've moved the code into it's own handler file. Please let me know if you'd prefer an alternate way of passing the recaptcha scri" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [04:43:19] (03CR) 10Shreyasminocha: "FYI: You can run tests locally with `grunt test` assuming you have grunt installed globally (which you can do with `npm install -g grunt`)" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [04:43:32] (03Abandoned) 10Nouman: @Esanders great idea. I've moved the code into it's own handler file. Please let me know if you would prefer another way of passing the recaptcha script URL to the client. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478389 (owner: 10Nouman) [04:54:23] 10MediaWiki-Authentication-and-authorization, 10Patch-For-Review, 10Security, 10User-Tgr: Make some providers optional for reauthentication - https://phabricator.wikimedia.org/T197153 (10Tgr) [04:54:54] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10WMF-Legal, and 3 others: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Tgr) [05:16:25] (03CR) 10Jayprakash12345: [C: 032] build: Add php-parallel-lint, MinusX, jsonlint and banana-checker [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478355 (owner: 10Umherirrender) [05:20:57] (03Merged) 10jenkins-bot: build: Add php-parallel-lint, MinusX, jsonlint and banana-checker [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478355 (owner: 10Umherirrender) [05:43:28] 10MediaWiki-extensions-Suhosin, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10translatewiki.net: Archive Suhosin extension - https://phabricator.wikimedia.org/T205684 (10PlavorSeol) [05:48:07] 10MediaWiki-extensions-General, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive the DPL Page Name S/N Maker extension - https://phabricator.wikimedia.org/T205954 (10PlavorSeol) [05:48:10] (03PS1) 10Shreyasminocha: Fix bug in `ABANDON_END` test [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478391 [05:49:41] (03PS1) 10Shreyasminocha: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) [05:53:43] (03CR) 10jerkins-bot: [V: 04-1] Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [05:56:21] (03PS2) 10Shreyasminocha: Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) [06:00:02] (03CR) 10jerkins-bot: [V: 04-1] Switch from babel-preset-env to @babel/preset-env [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478392 (https://phabricator.wikimedia.org/T197883) (owner: 10Shreyasminocha) [06:02:44] wonder how updating babel can reduce coverage for branches by a solid 5% [06:18:53] 10MediaWiki-Cache, 10Gadgets, 10Operations, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 4 others: Mcrouter periodically reports soft TKOs for mc[1,2]035 leading to MW Memcached exceptions - https://phabricator.wikimedia.org/T203786 (10aaron) >>! In T203786#4805938, @elukey wrote: > Today another mediaw... [06:38:36] 10MediaWiki-API, 10Category: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Jayprakash12345) You should use `titles` instead of `lltitle` See:- https://en.wikipedia.org/w/api.php?action=query&prop=langlinks&lllang=he&titles=Category:Druze_commun... [06:40:03] 10MediaWiki-API, 10Category: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Jayprakash12345) 05Open>03Invalid [06:54:29] 10Wikimedia-Site-requests: Allow uploading of .swf (flash) files to commons - https://phabricator.wikimedia.org/T28269 (10Koavf) >>! In T28269#303675, @MaxSem wrote: > The Wikimedia board of trustees had made it clear that there will be no Flash on Wikimedia sites. In addition to unfreeness, this file format is... [07:02:13] 10Security-Team, 10TechCom, 10TechCom-RFC, 10Security: Proposal for partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10Tgr) One thing I would consider is adding some kind of usage tracking (I think we can do that by having a stricter report-only and a looser f... [07:09:15] (03PS1) 10Gerrituser: Revert "build: Add php-parallel-lint, MinusX, jsonlint and banana-checker" [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478393 [07:09:17] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478393 (owner: 10Gerrituser) [07:10:02] (03PS2) 10Gerrituser: Revert "build: Add php-parallel-lint, MinusX, jsonlint and banana-checker" [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478393 [07:13:45] 10MediaWiki-API: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Aklapper) removing #Category tag, please see its project description [07:14:43] 10Design, 10MediaWiki-Interface: Ability to dynamically change base font-size of Mediawiki - https://phabricator.wikimedia.org/T26739 (10Quiddity) [07:18:41] 10MediaWiki-API: langlinks API call does not work for pages in Category namespace - https://phabricator.wikimedia.org/T211463 (10Kipod) thanks. i find the documentation confusing. it would be nice to mention that "titles" work with this query, and nicer if it will explain what's the diff between lltitles and tit... [07:20:46] (03CR) 10Tim Starling: "It was mostly just an exercise, suggested by Legoktm, but maybe you noticed that I used it in https://gerrit.wikimedia.org/r/#/c/478137/ f" [core] - 10https://gerrit.wikimedia.org/r/476198 (owner: 10Tim Starling) [07:27:41] 10MediaWiki-Page-editing: The edited amount/content were not consistent with the revision history - https://phabricator.wikimedia.org/T211426 (10Aklapper) 05stalled>03Invalid [08:23:17] (03PS2) 10Amire80: Delete unnecessary optional Russian messages [core] - 10https://gerrit.wikimedia.org/r/477806 (https://phabricator.wikimedia.org/T209461) [08:29:56] (03PS1) 10Gergő Tisza: Rely on browser autocomplete for Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/478394 (https://phabricator.wikimedia.org/T209972) [08:33:31] (03PS1) 10Gergő Tisza: Use username from last successful login in Special:PasswordReset [core] - 10https://gerrit.wikimedia.org/r/478395 (https://phabricator.wikimedia.org/T209972) [08:41:15] 10Wikimedia-Site-requests: Allow uploading of .swf (flash) files to commons - https://phabricator.wikimedia.org/T28269 (10MaxSem) Don't remember where it was. In any case, even with their approval, this request would be denied today as Flash will be completely out of support in two years, as even [[ https://tec... [08:44:16] (03CR) 10Umherirrender: "Why you created a revert?" [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/478393 (owner: 10Gerrituser) [08:44:36] (03CR) 10Thiemo Kreuz (WMDE): "Oh dear. You make it very hard to respond to this one. :-(" [core] - 10https://gerrit.wikimedia.org/r/475066 (owner: 10Fomafix) [08:47:59] 10TWLCon-2019-India: Finalisation of Participants - https://phabricator.wikimedia.org/T210247 (10Krishna_Chaitanya_Velaga) 05Open>03Resolved [08:48:41] 10TWLCon-2019-India: Invite external personnel - https://phabricator.wikimedia.org/T210368 (10Krishna_Chaitanya_Velaga) a:03SubodhKulkarni [08:49:08] 10TWLCon-2019-India: Create a Telegram group - https://phabricator.wikimedia.org/T210367 (10Krishna_Chaitanya_Velaga) 05Open>03Resolved [08:56:51] (03CR) 10Umherirrender: build: Replace jshint/jscs with eslint & stylelint (036 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [09:03:12] (03PS16) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [09:14:52] (03CR) 10Umherirrender: [C: 032] "Changing Commit Message after CR+2 needs a resubmit" [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/471562 (owner: 10Fomafix) [09:19:06] (03Merged) 10jenkins-bot: Apply some fixes [extensions/DiscussionThreading] - 10https://gerrit.wikimedia.org/r/471562 (owner: 10Fomafix) [09:28:16] stephanebisson: o/ I was trying to add a tour for IP users, but I noticed something weird. [09:28:16] `modules/flow-initialize.js:28` = `initializer.initOldComponent();` [09:28:16] For IP users, everything executes until this line. `initializer.finishLoading()` is never called (on master branch also). [09:28:16] `modules/engine/components/flow-registry.js:24` This is where `initOldComponent()` lives [09:28:41] But for logged-in users, everything is fine [09:32:18] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10I18n: Please translate the "Wikipedia" namespace in Santali for Santali Wikipedia - https://phabricator.wikimedia.org/T211294 (10Ramjit99) >>! In T211294#4804472, @Framawiki wrote: > Also note that on my screen your message looks like that: > {F27407... [09:37:52] stephanebisson: There is a problem with flow-handlebars. `data.target` is undefined [09:38:03] when user is IP only [09:40:43] `flow-handlebars.js:112` [09:41:35] I've just claimed my 5th task- lua task 3 [09:42:50] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10Daimona) @MarcoAurelio I think that should have been done before adding me to WMF-NDA-Requests per wikitech. Anyway, I'd like to ask whether I have to open two separate tasks for logstash (actually, the nda LDAP group) a... [09:43:29] methodsolver1782: gz :D [09:44:04] thx [09:53:54] i got an error [09:54:53] attempt to concatenate global "celsius" [10:01:36] methodsolver1782: umm, Could you send me a link to your sandbox? [10:01:47] stephanebisson: Could you take a look? https://gist.github.com/takidelfin/47b91d4d9bd932df588b6a7eccc3df12 [10:01:53] i fixed it [10:01:55] thx [10:02:26] :) [10:04:12] (03PS10) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [10:05:11] 10TWLCon-2019-India: Publish the final list on Meta-Wiki - https://phabricator.wikimedia.org/T210248 (10Krishna_Chaitanya_Velaga) [10:05:28] 10TWLCon-2019-India: Publish the final list on Meta-Wiki - https://phabricator.wikimedia.org/T210248 (10Krishna_Chaitanya_Velaga) p:05Triage>03High [10:07:06] one thing i wanted to do- can you help me out takidelfin? [10:07:15] sure [10:07:20] what's the problem? [10:08:10] while I was writing the code- the concatenation error came up bcoz I wanted to call celsius from the user sandbox [10:08:19] so i removed that [10:08:46] i created three new functions tempa, tempb and tempc [10:09:00] so it's basically a print command right now [10:09:16] to call the different lines [10:09:21] hmm [10:09:47] It's not a problem until I go to the testing part of the task [10:09:56] Could you provide me a link to your user sandbox? [10:10:14] https://en.wikipedia.org/wiki/User:Methodsolver1782/sandbox [10:10:25] https://en.wikipedia.org/wiki/Module:Sandbox/Saaswath_Sundaresan [10:10:34] (03PS11) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [10:10:39] the second one's my module sandbox [10:11:12] looking [10:12:56] Your function should be dynamic [10:12:56] I mean that it should display the variable cel like you are doing it with fah [10:13:39] (03CR) 10jerkins-bot: [V: 04-1] Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [10:14:12] methodsolver1782: So combine these temperatureX functions into one dynamic temperature :D [10:14:12] that's what I trie [10:14:20] tried [10:14:25] ? [10:14:35] (03CR) 10jerkins-bot: [V: 04-1] Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [10:14:38] But it's not giving the same output [10:15:13] Could you gime me an example for it? [10:15:30] what's the output then? [10:16:16] Also: "..fah.." degrees celsius.
" [10:16:16] "celsius" should be "fahrenheit" [10:16:44] like when the fah concatenation strings are in use, it doesnt give me any error [10:17:20] so when i try putting ..celsius.. before the degree stuff, it gives me a concatenation error [10:17:35] `return variable.." regular text"..variable2.." regular text end" [10:17:42] i noticed the celsius thing- will change it [10:17:58] you should not put double dots before variable on the start [10:18:12] so no ..celsius..? [10:18:23] look at my example above [10:18:41] `return variable..`, not `return ..variable` [10:19:46] i tried return ""..celsius.."degrees celsius is "..fah.."degrees farenheit [10:20:43] so gimme around five minutes while i fix this thing [10:21:22] that `""..` before celsius is redundant [10:21:35] also it should be cel [10:21:43] because celsius is undefined [10:23:36] done.. fixed it [10:23:41] thx [10:23:51] Also could you please indent your function? [10:24:12] it will be easier to read :) [10:24:27] sure.. [10:24:51] where should i do it... user or module? [10:25:30] module [10:25:37] ok- will do [10:26:23] looks better now? [10:26:41] umm, it still looks the same [10:27:13] look at `p.temperature` function [10:27:27] oh yeah, forgot to save it :p [10:27:31] :D [10:28:32] now? [10:29:02] should I add comments too? [10:29:17] Like for each task and its functions and stuff [10:29:29] by `indent` I meant using tabs, not to add more breaklines :D [10:29:39] ok [10:29:59] so spacing horizontally is what you're trying to say? [10:30:09] yup [10:30:20] function p.hello( frame ) [10:30:20] return "Hello, world!" [10:30:20] end [10:30:23] like this [10:30:28] return is indented [10:30:55] ok will do [10:32:10] done [10:32:17] take a look at it now? [10:33:07] ough [10:33:23] I'll revert it maybe [10:34:04] did you do something or... [10:34:34] coz i just moved every thing a few spaces to the right [10:34:56] sorry If I was unclear [10:34:56] I will fix this, because it is my fault (my english is bad, I explained it wrongly) [10:35:13] 10TWLCon-2019-India: Invite external personnel - https://phabricator.wikimedia.org/T210368 (10SubodhKulkarni) Through some of the events, rapport with GIPE, Pune University and NCL librarians has been developed. All three librarians - Nanaji Shewale, Shubhada Nagarkar and Sunita Barve are very active and thinkin... [10:35:58] okie- no probs takidelfin [10:36:16] methodsolver1782: take a look now :D [10:37:06] also, Could you change that "degrees celsius" to "degrees fahrenheit" ? [10:37:35] yes- I'll do that right away [10:37:41] 10Timeless: Improper handling of hook SkinTemplateToolboxEnd - https://phabricator.wikimedia.org/T211449 (10ashley) You should be using [[https://www.mediawiki.org/wiki/Manual:Hooks/BaseTemplateToolbox|BaseTemplateToolbox]] instead. (But yes, this legacy hook isn't handled properly and that's tracked as T161578.) [10:37:54] 10Timeless: Improper handling of hook SkinTemplateToolboxEnd - https://phabricator.wikimedia.org/T211449 (10ashley) [10:37:56] 10Timeless: TOOLBOXEND appearing under navigation with extension-added links there instead of in toolbox - https://phabricator.wikimedia.org/T161578 (10ashley) [10:38:10] so you just gave in uniformity within all the pieces of code so that we know where is what [10:40:25] yup [10:41:48] 10Timeless, 10CSS, 10Patch-For-Review: Timeless pictures do not have a "Go to file description" icon - https://phabricator.wikimedia.org/T181144 (10ashley) 05Open>03Resolved a:03Isarra [10:42:04] (03PS12) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [10:42:06] 10Timeless, 10CSS: Timeless pictures do not have a "Go to file description" icon - https://phabricator.wikimedia.org/T181144 (10ashley) [10:42:09] so the testing part is where things get a little more intense [10:43:08] 10TWLCon-2019-India: Invite external personnel - https://phabricator.wikimedia.org/T210368 (10SubodhKulkarni) Pradip Rawat is associated with us in Wikimedia movement. He has developed free library in Pune - [[ http://rawatacademy.in/index.php?page=home | Rawat's Nature Academy ]]. I have spoken to him and reque... [10:43:52] methodsolver1782: If you need help, feel free to ping me [10:43:58] i don't understand the step 7 [10:44:30] `. In your module sandbox, amend the function to supply 0 as the default if no parameter is supplied. Save it.` [10:44:57] so if celsius is= nil then 0 comes in place? [10:45:10] (03PS1) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [10:45:14] so, this step wants you to change cel value to 0 if it is nil [10:45:16] (03CR) 10jerkins-bot: [V: 04-1] Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [10:45:34] methodsolver1782: yup, but remember to assign it like this: cel = 0 [10:46:17] so itll be an if then else statement kind of thing [10:46:41] yup [10:48:36] (03PS2) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [10:48:44] so take a look at this - before the return tag, i type in : if cel= 0 cel=0 [10:49:05] remember about putting double = [10:49:07] (03PS15) 10Nathan fraignt: Allow normal users to do more via API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/477764 (https://phabricator.wikimedia.org/T206603) [10:49:13] (03CR) 10jerkins-bot: [V: 04-1] Allow normal users to do more via API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/477764 (https://phabricator.wikimedia.org/T206603) (owner: 10Nathan fraignt) [10:49:20] double = where [10:49:26] because cel= 0 assings a 0 to cel [10:49:29] (03CR) 10jerkins-bot: [V: 04-1] Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [10:49:33] so it should be like this: cel == 0 [10:49:48] so if cel==0 [10:49:53] right? [10:50:04] iyup] [10:50:05] (03PS3) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [10:50:06] https://www.lua.org/pil/3.2.html [10:50:11] k [10:50:56] (03CR) 10jerkins-bot: [V: 04-1] Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [10:51:16] Also there is a simpler way to do it instead of this big if-else statement: [10:51:16] `variable = thisVariableCanBeNil or 0` [10:51:16] `or 0` is executed if thisVariableCanBeNil is nil :) [10:51:56] (03PS13) 10Takidelfin: Flow: Add Topic tour for GuidedTour extension and fix undefined error [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) [10:53:35] i typed in if cel==0 then cel=0 [10:53:39] will it still work [10:54:03] anyway, it's basically the same thing [10:54:40] (03PS4) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [10:55:22] (03PS16) 10Nathan fraignt: Allow normal users to do more via API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/477764 (https://phabricator.wikimedia.org/T206603) [10:55:37] (03CR) 10jerkins-bot: [V: 04-1] Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [10:58:30] (03CR) 10Takidelfin: "recheck" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/477989 (https://phabricator.wikimedia.org/T210403) (owner: 10Takidelfin) [10:59:13] (03PS5) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [11:03:11] It didn't work [11:03:48] 10Google-Code-in-2018, 10Gadgets, 10I18n, 10goodfirstbug: Localize Gadgets magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210826 (10Ruthven) @MarcoAurelio Hi, from the grammar point of view, `chiàcchiera` is correct; however, `chiacchiera` is understandable without problems (... [11:04:19] methodsolver1782: what do you mean? [11:04:38] ah [11:04:40] ` cel= thisvariablecanbenil or 0` [11:05:06] yep- it didnt work [11:05:13] you should add `or 0` to first declaration of cel [11:05:22] `cel = frame.args.celsius or 0` [11:05:23] :D [11:05:30] oh ok [11:05:34] gimme a sec [11:06:59] 10TWLCon-2019-India: Invite external personnel - https://phabricator.wikimedia.org/T210368 (10Krishna_Chaitanya_Velaga) Awesome! It would be nice to hear from them about their work and previous interaction with Wikimedia. We will them some slots to discuss their work, please find out from them for the following... [11:07:03] nope- still didnt work [11:08:19] look at p.hello [11:08:39] it uses same approach [11:09:38] you mean p.hi [11:10:07] hello [11:10:14] Lua error in Module:Sandbox/Saaswath_Sundaresan at line 19: attempt to perform arithmetic on global 'cel' (a string value). [11:10:26] what up methodsolver1782? [11:10:40] hello shreyas! [11:10:54] hi takidelfin! [11:10:57] hey shreyasminocha or marquee [11:10:59] methodsolver1782: you should wrap frame.args.celsius in toNumber [11:11:02] tonumber * [11:11:06] look at the lua docs [11:11:09] brb [11:11:47] i fixed it and the value now is 32 tghough [11:12:04] methodsolver1782: what're you tryna do? [11:12:26] lua task 3 step 7 [11:12:28] methodsolver1782: Great! [11:12:43] gz [11:13:11] Do the next step now :) [11:13:21] so what i did is basically put cel= frame.args.celsius or "0" [11:13:53] (03CR) 10Urbanecm: [C: 032] Allow normal users to do more via API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/477764 (https://phabricator.wikimedia.org/T206603) (owner: 10Nathan fraignt) [11:14:03] great [11:14:26] `cel = tonumber(frame.args.celsius) or 0` [11:14:49] (03Merged) 10jenkins-bot: Allow normal users to do more via API [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/477764 (https://phabricator.wikimedia.org/T206603) (owner: 10Nathan fraignt) [11:14:53] they haven't got there yet, have they? [11:15:06] although it is better I think. But every way is good if it works :D [11:15:22] I mean that snipper above [11:15:25] .-. [11:15:57] in step 10 they'll be told to add it if i'm not mistaken [11:17:01] so i think it's fine, let 'em move on [11:18:38] I think I'll continue at around 6 [11:18:57] haven't eaten lunch yet :p [11:19:05] see you soon! [11:19:10] sure [11:19:15] although that's super-late for kunch [11:19:34] methodsolver1782: 👋 [11:19:37] (4:49 PM) [11:20:02] ~/~ [11:25:59] \o/ [11:26:38] what happened to jenkins bot :( https://usercontent.irccloud-cdn.com/file/Ydi5IPHl/screenshot_20181208_122617.png [11:26:44] :O [11:27:22] enough of laughing at :D [11:28:00] takidelfin: looks like that project has only codecov tests [11:28:16] and no unit tests (guessing) [11:28:18] finally https://usercontent.irccloud-cdn.com/file/VXuWE7ys/q [11:28:43] ¯\_(ツ)_/¯ [11:28:43] shreyasminocha: nope, there are unit tests [11:29:00] 12:04 when it is 12:28 for me ;-; [11:30:05] stephanebisson: Could you review my task please? [11:30:10] *, please [11:30:48] jdlrobsonvacatio: if you're out here, i'd love your help [11:30:53] whatsup guys :) [11:31:00] oh rip username [11:31:04] hi takidelfin [11:31:06] whoops [11:31:08] hi TheJair_ [11:31:19] hi TheJair_! [11:31:26] hi shreyasminocha :P [11:31:51] \o \o \o \o/ o/ o/ o/ [11:33:02] TheJair: I didn't know what your irc nick translated to on the leaderboard until like yesterday [11:33:19] lol [11:34:10] yeah it's stibba haha [11:34:16] how did you figure out? [11:34:28] zuul/config [11:34:34] someone told me, i don't remember [11:34:40] https://gerrit.wikimedia.org/r/plugins/gitiles/integration/config/+/master/zuul/layout.yaml#631 [11:34:41] takidelfin: was it you? [11:34:46] yup ^-^ [11:35:07] I had this IRC account already [11:35:12] although I didn't really use it [11:35:28] i feel it means something although idk what [11:35:46] You mean 'stibba' or 'thejair'? [11:35:55] latter [11:36:37] wow, lukbukkit started off as a gci student it seems [11:36:46] not really haha, it's a name that is used a lot in brazil [11:36:57] lol [11:37:02] ah. from what wikibugs's activity suggests, lukbukkit is quite an active contributor [11:37:14] check by mail [11:38:23] so to whoever was saying "gci is for thirsty google kids", we have a counter-example right there (although they did ack exceptions) [11:38:56] We should keep in contact after GCI ends :)! There is also an unofficial telegram group btw (although it is not active at all lol) [11:39:07] i agree we should [11:39:21] i think we should keep in contact on #wikimedia-dev :D [11:39:32] 'thirsty google kids' ? [11:39:34] Yeah as well [11:39:50] takidelfin: see the beginning of trimmed logs [11:40:01] https://www.mediawiki.org/wiki/Google_Code-in/2018 on the bottom of the page is a link to a telegram group [11:40:07] ikr [11:40:08] Who said that? [11:40:19] some Jade01 or sth [11:40:23] student themselves [11:40:29] there was some interesting discussion going on [11:40:53] TheJair: i collected logs from the beginning of GCI and sed'ed wikibugs out [11:41:20] ah, speaking of wikibugs it is just me or is it not here? [11:41:35] not here, i was wondering too [11:41:47] hmm [11:41:58] (03CR) 10MarcoAurelio: "recheck" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [11:42:05] ddd [11:42:08] speak of the devil [11:42:12] lmao [11:42:41] no changes for about 40 minutes lol [11:42:49] I was writing a message to Platonides that wikibugs is down again ... good that someone 'recheck'ed it :D [11:43:08] JakeD01 it was (https://paste.ee/p/xSWn0) [11:43:43] (03CR) 10jerkins-bot: [V: 04-1] ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [11:43:56] (my last message probably includes 999 grammar errors) •Ŋ• [11:44:05] wow that conversation.. [11:44:11] just one actually takidelfin [11:44:57] "about wikibugs being down again" instead of "that wikibugs ... down again" [11:47:49] ^-^ [11:48:01] [22:01:57] Its going to be thirsty google kids [11:48:11] ` Jeeze.` [11:48:12] ` People are thirsty for a trip to google.` [11:48:12] ` Its going to be thirsty google kids` [11:48:28] ` Not trying to be rude but its hard to get talent from a mass advertisement hosted by a huge comp` [11:48:36] Krenair's response was appropriate [11:52:44] (03PS1) 10MarcoAurelio: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478397 [11:54:49] That was like the first day of GCI ^ [11:55:01] I´ve never seen him after that [11:55:10] ik [11:55:10] Hi Nathan_fraignt [11:55:16] Hi :) [11:55:23] hi Nathan_fraignt [11:55:47] Reading the conversation, and like you said then Nathan_fraignt, literally no one I know IRL has heard of it [11:56:11] Although I don't know a lot of programmers irl though [11:56:17] me neither [11:56:23] (heard of GCI) [11:56:28] same [11:56:35] I also had not heard of GCI until this year [11:56:39] thought of advertising it in my school, but it was too late by then [11:56:42] and I´m pretty sure it was by accident [11:56:46] same. i wish i heard of it earlier. [11:57:03] Yeah me too, This is the last year I can do it [11:57:09] same [11:57:10] Same lol [11:57:12] ALthough I saw Google Summers of Code [11:57:16] Which looked pretty fun [11:57:19] same [11:57:24] same also haha [11:57:33] But I can´t do it this year, so I´ll have to wait like 1.5 years for that [11:57:43] I thought I wouldn't be good enough for these competitions yet [11:57:57] Yeah me too, but I actually think I have a fairly ok chance to win [11:57:59] 'competitions' [11:58:04] ^ [11:58:15] (03PS1) 10Fomafix: Remove obsolete aliases from closures [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478398 (https://phabricator.wikimedia.org/T208951) [11:58:20] But it doesn´t really feel like a competition to be honest [11:58:24] true [11:58:27] I think we underestimate how much we learn over the years, or at least I do [11:58:30] yeah true [11:58:38] I guess [11:58:38] i agree [11:58:52] For me it was really nice working in a ¨profesional¨ enviroment [11:58:53] i know that i give myself credit for less than i know [11:59:00] i agree. [11:59:03] With gerrit/git code reviews etc. [11:59:10] yup [11:59:10] Nathan_fraignt, yeah, like all these tasks you can do [11:59:12] (03CR) 10MarcoAurelio: "Thanks for your reply, James. Is there any way we can review this change to check if it works as expected? Maybe with some visible results" [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [11:59:13] it is great [11:59:16] never used anything but Github in the past [11:59:21] also Polygerrit is so cool [11:59:24] nice to be exposed to new stuff [11:59:27] not a project of your own which you know everything off [11:59:29] I tried getting into open-source a year back, but I found it pretty hard [11:59:36] And this is a nice way to get familiar [11:59:41] fair [11:59:42] Exactly TheJair [11:59:51] I actually did the github hacktoberfest and then I found out about GCI [12:00:00] before i knew git, open source was intimidating. after that, not so much [12:00:17] I upload my own projects to git [12:00:21] github? [12:00:23] but more as a backup kinda thing [12:00:24] yeah [12:00:29] (03PS1) 10MarcoAurelio: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_31) - 10https://gerrit.wikimedia.org/r/478399 [12:00:36] 3to1null you are, right? [12:00:42] Yeah [12:00:44] yup he is [12:00:48] Lol you know everything about everyone [12:00:51] You all do [12:00:57] But most of my projects are private [12:00:59] i've stalked all of your GH's [12:01:02] lol [12:01:04] ^ [12:01:08] Woah [12:01:15] Github edu <3 [12:01:21] https://github.com/3to1null [12:01:22] but as I said, mopst of mine are private [12:01:24] (speaking of private repos) [12:01:27] shreyasminocha: yup <3 [12:01:34] I think there are like 2 kinda intereseting non private repos on my github [12:01:42] Why don't we do a project together someday soon? :D [12:01:46] https://www.jetbrains.com/student/ [12:01:49] also this is <3 [12:01:49] That would be fun [12:01:54] Also have pycharm student [12:01:58] I live on student packages [12:02:02] * shreyasminocha uses vs code [12:02:10] * Nathan_fraignt uses vs code for JS [12:02:21] But pycharm for python [12:02:24] I use VS Code and Jetbrains tools [12:02:29] ALso use vs code for Flutter [12:02:32] (03CR) 10MarcoAurelio: "No actual changes here, just a commit message :)" [core] - 10https://gerrit.wikimedia.org/r/477806 (https://phabricator.wikimedia.org/T209461) (owner: 10Amire80) [12:02:36] anyone ever used flutter? It´s great [12:02:39] different apps for different languages seems cumbersome, but whatever works for you :) [12:02:40] Flutter is cool [12:02:54] * TheJair had to search up what vs code was [12:03:07] If I have like one project I use the IDE I prefer, even if there are multiple languages in there [12:03:08] "Made by Google" -- Flutter [12:03:13] But pycharm for python is jsut the best [12:03:13] * shreyasminocha shuts tab [12:03:19] lol why [12:03:34] I dunno I just like it [12:03:36] * shreyasminocha is anti-Google [12:03:40] )shh) [12:03:45] why [12:03:47] Material Design ? :( [12:03:51] On the GCI contest [12:03:52] anti google [12:03:53] nice [12:03:54] XD [12:04:00] thus the "(shh)" :D [12:04:04] lol [12:04:10] tracking [12:04:10] lol [12:04:12] mostly [12:04:13] (03PS1) 10Fomafix: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 [12:04:18] we should maybe make like a discord for ex-gci student [12:04:21] or someting [12:04:23] Idk [12:04:24] yeah certainly [12:04:29] (03PS2) 10Fomafix: Add missing dependency on core module 'user.options' [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478400 [12:04:37] That would make is easier to do a project afterwards [12:05:00] https://discord.gg/FruYu4 [12:05:07] help me with setting it up please [12:05:19] discord is blocked in shreyasminocha's school [12:05:23] sure [12:05:24] oh rip [12:05:30] Sad [12:05:36] Can you access it when at home? [12:05:43] am at home, works ofc [12:07:17] (03CR) 10MarcoAurelio: [C: 032] build: Add MinusX, jsonlint and banana-checker [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478356 (owner: 10Umherirrender) [12:07:48] (03CR) 10MarcoAurelio: [C: 032] build: Updating php-parallel-lint to 1.0.0 [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478351 (owner: 10Umherirrender) [12:11:48] (03Merged) 10jenkins-bot: build: Updating php-parallel-lint to 1.0.0 [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478351 (owner: 10Umherirrender) [12:12:23] (03Merged) 10jenkins-bot: build: Add MinusX, jsonlint and banana-checker [extensions/LDAPUserInfo] - 10https://gerrit.wikimedia.org/r/478356 (owner: 10Umherirrender) [12:25:28] (03Abandoned) 10Amire80: Delete unnecessary optional Russian messages [core] - 10https://gerrit.wikimedia.org/r/477806 (https://phabricator.wikimedia.org/T209461) (owner: 10Amire80) [12:29:27] (03CR) 10Amire80: "> No actual changes here, just a commit message :)" [core] - 10https://gerrit.wikimedia.org/r/477806 (https://phabricator.wikimedia.org/T209461) (owner: 10Amire80) [12:32:26] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Fix timezone-related warnings - https://phabricator.wikimedia.org/T208624 (10Urbanecm) @Nathan_fraignt asked me to import this task into GCI. [12:34:13] stephanebisson: trizek: Could you review my task please? [12:34:13] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions, 10Patch-For-Review: Create a guided tour about accessing a StructuredDiscussions Topic page the first time - https://phabricator.wikimedia.org/T210403 (10takidelfin) Done! ` if ( mw.config.get( 'wgUserName'... [12:35:43] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Allow normal user to do things they are allowed to do in frontend in API as well - https://phabricator.wikimedia.org/T206603 (10Nathan_fraignt) 05Open>03Resolved [12:37:11] is there somoeone who could review my task about adding a GuidedTour for Topic in Flow extension? [12:37:44] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/477989 [12:38:32] Urbanecm: maybe you could? Because stephanebisson and Trizek are offline for long time :( [12:39:09] Hmm, I can have a look at least [12:39:41] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Importing more than 100 rows should be a Django-level permission - https://phabricator.wikimedia.org/T211392 (10Urbanecm) https://codein.withgoogle.com/tasks/4588742208651264/ [12:39:50] sorry for impatience though [12:41:07] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Sorting by (pre)expeditures doesn't work - https://phabricator.wikimedia.org/T211277 (10Urbanecm) https://codein.withgoogle.com/tasks/4907200578322432/ [12:42:10] 10WMCZ-Tracker: Fix timezone-related warnings - https://phabricator.wikimedia.org/T208624 (10Urbanecm) [12:43:35] 10WMCZ-Tracker: Fix timezone-related warnings - https://phabricator.wikimedia.org/T208624 (10Nathan_fraignt) a:03Nathan_fraignt [13:07:15] (03PS5) 10Umherirrender: parser: Fix PHPDoc annotations in parser module [core] - 10https://gerrit.wikimedia.org/r/477285 (owner: 10D3r1ck01) [13:07:22] (03CR) 10Umherirrender: [C: 032] parser: Fix PHPDoc annotations in parser module [core] - 10https://gerrit.wikimedia.org/r/477285 (owner: 10D3r1ck01) [13:08:05] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Fix timezone-related warnings - https://phabricator.wikimedia.org/T208624 (10Urbanecm) https://codein.withgoogle.com/tasks/5016576383254528/ [13:11:29] 10Accessibility, 10Wikipedia-iOS-App-Backlog, 10iOS-app-feature-Accessibility, 10I18n, and 3 others: Localize the app's name in the Apple Store - https://phabricator.wikimedia.org/T194452 (10Iniquity) Thanks! [13:17:56] (03CR) 10Umherirrender: "check php" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [13:18:12] (03PS1) 10Nathan fraignt: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) [13:19:07] (03CR) 10jerkins-bot: [V: 04-1] Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [13:19:55] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [13:21:18] (03Merged) 10jenkins-bot: parser: Fix PHPDoc annotations in parser module [core] - 10https://gerrit.wikimedia.org/r/477285 (owner: 10D3r1ck01) [13:22:22] (03CR) 10jerkins-bot: [V: 04-1] Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [13:23:26] (03CR) 10jenkins-bot: parser: Fix PHPDoc annotations in parser module [core] - 10https://gerrit.wikimedia.org/r/477285 (owner: 10D3r1ck01) [13:23:30] (03CR) 10Umherirrender: [V: 032 C: 032] "T189560" [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [13:23:32] (03CR) 10jenkins-bot: parser: Fix PHPDoc annotations in parser module [core] - 10https://gerrit.wikimedia.org/r/477285 (owner: 10D3r1ck01) [13:24:39] hi Ebe123 [13:28:53] (03PS3) 10Umherirrender: Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [13:28:55] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10PHP 7.0 support, 10PHP 7.1 support, 10PHP 7.2 support: selenium tests are flaky under php7 on TemplateWizard - https://phabricator.wikimedia.org/T211470 (10Umherirrender) [13:28:59] (03CR) 10Umherirrender: [V: 032] "T211470" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [13:29:09] (03PS2) 10Umherirrender: eslint: Drop 'dot-notation' rule [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476354 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [13:29:22] (03CR) 10Umherirrender: [V: 032] "T211470" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476354 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [13:29:42] (03PS4) 10Umherirrender: Use existing overlay for all popups [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [13:29:46] (03CR) 10Umherirrender: [V: 032] "T211470" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [13:30:15] (03CR) 10jenkins-bot: Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [13:31:15] (03PS2) 10Nathan fraignt: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) [13:32:11] (03CR) 10jerkins-bot: [V: 04-1] Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [13:34:28] (03PS5) 10Umherirrender: Adjust for core change I4764c1c78 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/461442 (https://phabricator.wikimedia.org/T204669) (owner: 10Anomie) [13:34:35] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/461442 (https://phabricator.wikimedia.org/T204669) (owner: 10Anomie) [13:38:25] (03CR) 10jerkins-bot: [V: 04-1] Adjust for core change I4764c1c78 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/461442 (https://phabricator.wikimedia.org/T204669) (owner: 10Anomie) [13:38:29] (03CR) 10jerkins-bot: [V: 04-1] Adjust for core change I4764c1c78 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/461442 (https://phabricator.wikimedia.org/T204669) (owner: 10Anomie) [13:44:18] 10MediaWiki-extensions-Renameuser, 10phan-taint-check-plugin: taint-checks for Renameuser failing - https://phabricator.wikimedia.org/T211471 (10Umherirrender) [13:44:24] (03CR) 10Umherirrender: [V: 032 C: 032] "T211471" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/461442 (https://phabricator.wikimedia.org/T204669) (owner: 10Anomie) [13:44:32] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [13:45:37] 10MediaWiki-extensions-Renameuser, 10phan-taint-check-plugin: taint-checks for Renameuser failing - https://phabricator.wikimedia.org/T211471 (10Umherirrender) Possible flaky, because there are some passes on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Renameuser/+/461442/ [13:47:55] (03CR) 10Umherirrender: "check php" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461529 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [13:50:53] (03CR) 10jerkins-bot: [V: 04-1] Implements SlotDiffRenderer for Index: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461529 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [13:52:11] 10CirrusSearch, 10Discovery, 10Discovery-Search: Fails to find same word with an apostrophe before (French usage) - https://phabricator.wikimedia.org/T59832 (10Pols12) Seems to be fixed, isn’t it? [13:56:49] (03CR) 10Umherirrender: "check php" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/462400 (owner: 10Tpt) [14:06:01] (03CR) 10Umherirrender: "php7 passed on another patch set - https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ProofreadPage/+/462400/" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461529 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [14:16:28] (03PS3) 10Nathan fraignt: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) [14:16:32] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Amire80) [14:16:59] (03PS1) 10Umherirrender: build: Update sniffs in .phpcs.xml [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478404 [14:17:27] (03CR) 10jerkins-bot: [V: 04-1] Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [14:18:16] (03PS1) 10Umherirrender: build: Update sniff in .phpcs.xml [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478405 [14:19:41] (03PS1) 10Umherirrender: build: Update sniff in .phpcs.xml [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478406 [14:21:47] what a silence [14:22:17] Urbanecm: Do you plan adding more Tracker tasks ? [14:22:45] (03PS1) 10Daimona Eaytoy: Remove usage of MakeGlobalVariablesScript hook [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478407 [14:31:03] takidelfin, I added some, they're awaiting review [14:32:10] okay ^-^ [14:32:55] takidelfin, if you're interested which, see https://phabricator.wikimedia.org/project/view/3391/, GCI column [14:34:20] (03PS2) 10Umherirrender: build: Update sniff list in .phpcs.xml [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/478406 [14:34:40] (03PS2) 10Umherirrender: build: Update sniff list in .phpcs.xml [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478404 [14:34:59] (03PS2) 10Umherirrender: build: Update sniff list in .phpcs.xml [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478405 [14:36:26] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Title tag in edit ticket view should show ticket's name - https://phabricator.wikimedia.org/T211341 (10Urbanecm) [14:36:56] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Title tag in edit ticket view should show ticket's name - https://phabricator.wikimedia.org/T211341 (10Urbanecm) https://codein.withgoogle.com/tasks/6124596408352768/ [14:38:41] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Breadcrumb in edit ticket view doesn't contain ticket's name - https://phabricator.wikimedia.org/T211340 (10Urbanecm) [14:38:44] (03PS1) 10Umherirrender: build: Update sniff list in .phpcs.xml [extensions/ORES] - 10https://gerrit.wikimedia.org/r/478409 [14:39:50] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Breadcrumb in edit ticket view doesn't contain ticket's name - https://phabricator.wikimedia.org/T211340 (10Urbanecm) https://codein.withgoogle.com/tasks/5229901201276928/ [14:40:38] (03PS4) 10Nathan fraignt: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) [14:47:04] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Refactor JQuery code to pure JS solutions in WMCZ-Tracker - https://phabricator.wikimedia.org/T211145 (10Urbanecm) [14:49:39] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Refactor JQuery code to pure JS solutions in WMCZ-Tracker - https://phabricator.wikimedia.org/T211145 (10Urbanecm) https://codein.withgoogle.com/tasks/4532348180758528/ [14:52:31] (03PS16) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [14:53:03] 10MediaWiki-extensions-JsonConfig: Temporary copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) [14:53:06] https://usercontent.irccloud-cdn.com/file/v0EzB8ty/screenshot_20181208_155238.png [14:53:16] 22 days :O [14:53:48] (03PS17) 10Zoranzoki21: build: Replace jshint/jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) [14:54:00] (03CR) 10Zoranzoki21: build: Replace jshint/jscs with eslint (032 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [14:54:41] (03PS3) 10Daimona Eaytoy: Emit debug logs when filtering without title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) [14:56:54] (03PS4) 10Daimona Eaytoy: Emit debug logs when filtering without title [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/466842 (https://phabricator.wikimedia.org/T144265) [14:58:04] 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Technical-Debt, and 2 others: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113 (10Zoranzoki21) [14:58:13] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [15:01:34] (03PS4) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [15:01:46] (03PS1) 10Umherirrender: Move class VipsCommand and VipsConvolution to own files [extensions/VipsScaler] - 10https://gerrit.wikimedia.org/r/478410 [15:05:29] (03PS5) 10Daimona Eaytoy: [WIP] Add a new class for methods related to running filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478232 [15:07:24] (03CR) 10Shreyasminocha: build: Replace jshint/jscs with eslint (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [15:07:55] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) [15:08:48] i wish gerrit worked better on mobile phones [15:09:23] 10JSDoc WMF theme: grunt test no runs because of Task "test" not found. - https://phabricator.wikimedia.org/T211476 (10Zoranzoki21) [15:11:18] 10JSDoc WMF theme: grunt test no runs because of Task "test" not found. - https://phabricator.wikimedia.org/T211476 (10Shreyasminocha) Try `npm test` instead [15:11:56] I wish we used Phabricator's inbuilt CR app [15:12:08] there is one? [15:12:30] https://phabricator.wikimedia.org/differential/ [15:14:22] 10Google-Code-in-2018, 10JSDoc WMF theme: JSDoc WMF theme: Fix JS and CSS linting issues - https://phabricator.wikimedia.org/T210349 (10Shreyasminocha) [15:14:24] 10JSDoc WMF theme: grunt test no runs because of Task "test" not found. - https://phabricator.wikimedia.org/T211476 (10Shreyasminocha) 05Open>03Invalid [15:14:24] til [15:24:51] (03CR) 10Takidelfin: [C: 04-1] build: Replace jshint/jscs with eslint (0314 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [15:24:59] ough [15:25:06] 14 comments D: [15:27:16] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) [15:27:40] (03CR) 10Takidelfin: [C: 04-1] build: Replace jshint/jscs with eslint (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/477843 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [15:28:52] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) [15:28:55] Why wikibugs doubled this message? 🤔 [15:29:05] Ah, because of this new comment [15:31:22] (03PS1) 10Daimona Eaytoy: Use data provider's array keys to specify test description [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478412 [15:32:04] (03PS1) 10Umherirrender: Rename class in swsite maintenance script [extensions/CreditsSource] - 10https://gerrit.wikimedia.org/r/478413 [15:34:52] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) [15:37:33] stephanebisson: hi! Could you review my task? (Because /whois shows that you are online and !idle <-- notidle? unidle?) [15:37:39] https://phabricator.wikimedia.org/T210403 [15:37:49] https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Flow/+/477989 [15:38:00] https://codein.withgoogle.com/dashboard/ [15:38:09] * https://codein.withgoogle.com/dashboard/task-instances/6288610203533312/ [15:39:51] (03PS1) 10Umherirrender: build: Update sniff list in .phpcs.xml [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/478414 [15:40:04] (03PS1) 10Umherirrender: build: Update sniff list in .phpcs.xml [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/478415 [15:44:59] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) Created a page at [[ https://commons.wikimedia.org/wiki/Data:Folk2.tab | c:Data:Folk2.tab ]], then went to [[ https://commo... [15:48:26] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10jeblad) Tried to go to [[ https://commons.wikimedia.org/wiki/Data:Folk3.tab | c:Data:Folk3.tab ]] and save it "as is", and then ope... [16:12:27] 04(no projects): delete page with badtitle on enwiki - https://phabricator.wikimedia.org/T211478 (10Xaosflux) [16:12:50] (03PS5) 10Nathan fraignt: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) [16:15:22] 04(no projects): delete page with badtitle on enwiki - https://phabricator.wikimedia.org/T211478 (10Xaosflux) Community approval for delete (admin discretion for cleanup) at: https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=872693759#Special:Badtitle/NS447:Stanford_University/... [16:16:55] (03PS1) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [16:17:50] (03CR) 10jerkins-bot: [V: 04-1] Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [16:21:22] (03PS1) 10Aaron Schulz: objectcache: add expiration check callback to WANObjectCache::getWithSetCallback [core] - 10https://gerrit.wikimedia.org/r/478419 [16:24:07] (03CR) 10Shreyasminocha: Make notification_html localized by the standard machinery (037 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [16:29:38] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Wbm1058) See https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(technical)#Special_pages_for_the_Education_Program_%E2%80%93_what_happened_to_them? Might be best to discuss this on wiki... [16:30:47] Does anyone else get an error when trying to install eslint-config-wikimedia? https://github.com/wikimedia/eslint-config-wikimedia [16:30:56] Specifically version 0.9.0 [16:32:05] (03CR) 10Aaron Schulz: [C: 04-1] Cancel the transaction if the file fails to move. This prevents losing files when there is a database error. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/478237 (https://phabricator.wikimedia.org/T211442) (owner: 10Alexia) [16:35:01] TheJair: let me try [16:35:30] TheJair: no error, at least on globally installing [16:35:38] what error do you see? [16:35:43] and it's version 0.9? [16:35:51] yep [16:36:25] npm ERR! cb() never called!npm ERR! This is an error with npm itself. [16:36:44] Unhandled rejection Error: Command failed: /usr/bin/git clone --depth=1 -q -b v1.3.2-wmf.1 git://github.com/wikimedia/eslint-plugin-jquery.git [16:37:21] .npm/_cacache/tmp/git-clone-48d53395/.git: Permission denied [16:39:13] "This is an error with npm itself." -- never seen that before [16:39:34] I think it has to do something with permissions, found something on stackoverflow [16:42:30] TheJair: looks like there's something wrong with the way you installed node [16:43:02] yeah [16:43:31] per https://stackoverflow.com/a/24404451/3363528, try uninstalling node and reinstalling either following instructions in the docs or with nvm as outlined in the linked answer [16:43:50] node/npm's supposed to get permissions right when it installs [16:44:39] (03PS4) 10Nouman: ConfirmEdit: Support No CAPTCHA reCAPTCHA [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) [16:46:14] 10Wiki-Loves-Monuments (2018): Blog post on South African monument diversity story - https://phabricator.wikimedia.org/T189934 (10Discott) Thanks for the ping on this. I must really get onto it. Been distracted by the stuff going on in parliament these days. [16:46:35] (03CR) 10Nouman: "addressed syntax warnings from jenkins build" [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/478288 (https://phabricator.wikimedia.org/T203478) (owner: 10Nouman) [16:46:57] I used https://stackoverflow.com/a/49805455/5669372, it worked but might do that reinstall in the future [16:47:24] (03PS1) 10Urbanecm: [DNM] Test for https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Popups/+/478392 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 [16:47:39] glad you got it working [16:48:48] 04(no projects): delete page with badtitle on enwiki - https://phabricator.wikimedia.org/T211478 (10Xaosflux) Unless someone else did something, the API attempt may have succeeded as seen in log now: 2018-12-08T16:07:29 Xaosflux (talk | contribs | block) deleted page Special:Badtitle/NS447:Stanford University/... [16:52:42] yes, thanks for the effort! [16:54:47] np [16:55:54] (03PS2) 10Urbanecm: [DNM] Test patch [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 [16:59:45] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Test patch [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 (owner: 10Urbanecm) [17:05:01] (03PS3) 10Urbanecm: [DNM] Test patch [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 [17:08:37] oh? [17:08:59] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Test patch [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 (owner: 10Urbanecm) [17:14:58] (03CR) 10Daniel Kinzler: [C: 032] Pass title to Revision constructor in ContribsPager [core] - 10https://gerrit.wikimedia.org/r/462132 (owner: 10Umherirrender) [17:19:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I'm happy with the addition. Feel free to +2 this any time." [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [17:20:40] (03PS1) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [17:23:11] (03PS6) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [17:29:12] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Refactor JQuery code to pure JS solutions in WMCZ-Tracker - https://phabricator.wikimedia.org/T211145 (10takidelfin) a:05takidelfin>03Bjornskjald Changed the assignee as the task got claimed by a student on GCI site [17:29:48] Urbanecm: good? ^-- wikibugs message [17:29:56] ^-^ [17:30:19] yep, thanks [17:32:27] (03Merged) 10jenkins-bot: Pass title to Revision constructor in ContribsPager [core] - 10https://gerrit.wikimedia.org/r/462132 (owner: 10Umherirrender) [17:34:54] (03CR) 10jenkins-bot: Pass title to Revision constructor in ContribsPager [core] - 10https://gerrit.wikimedia.org/r/462132 (owner: 10Umherirrender) [17:44:09] (03Abandoned) 10Urbanecm: [DNM] Test patch [extensions/Popups] - 10https://gerrit.wikimedia.org/r/478421 (owner: 10Urbanecm) [17:47:13] (03PS2) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [17:48:42] (03PS3) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [17:48:48] (03PS2) 10Stibba: build: Replace jshint with eslint & stylelint [extensions/GoogleLogin] - 10https://gerrit.wikimedia.org/r/478422 (https://phabricator.wikimedia.org/T210365) [17:49:13] (03CR) 10Arcayn: Make notification_html localized by the standard machinery (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [17:52:09] (03PS4) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [17:53:03] (03PS5) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [17:53:55] (03CR) 10Urbanecm: Make notification_html localized by the standard machinery (037 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [17:56:13] (03CR) 10Arcayn: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [17:57:50] (03CR) 10Arcayn: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [17:58:21] (03CR) 10Arcayn: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [17:59:32] (03CR) 10Thiemo Kreuz (WMDE): Migrate UserMerge to modern logging system (032 comments) [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/461292 (https://phabricator.wikimedia.org/T72836) (owner: 10Matěj Suchánek) [18:00:42] (03CR) 10Takidelfin: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [18:02:35] (03PS6) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [18:05:05] (03PS7) 10Arcayn: Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [18:05:46] (03CR) 10Takidelfin: [C: 031] Added i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [18:10:50] (03CR) 10Urbanecm: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [18:13:35] (03PS2) 10LukBukkit: Reloads the categories overlay after a category was added [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) [18:13:45] (03PS1) 10Bjornskjald: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) [18:15:59] 10Google-Code-in-2018, 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: Bug: Category overlay does not refresh after category added - https://phabricator.wikimedia.org/T163121 (10LukBukkit) This problem is related to [[ https://www.mediawiki.org/wiki/Manual:Job_queue | job queu... [18:17:42] (03CR) 10LukBukkit: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/478214 (https://phabricator.wikimedia.org/T163121) (owner: 10LukBukkit) [18:19:53] 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Technical-Debt, and 2 others: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113 (10Aklapper) @Zoranzoki21: Why did you remove those two release project tags... [18:21:32] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10Aklapper) >>! In T211042#4807524, @Daimona wrote: > @MarcoAurelio I think that should have been done before adding me to WMF-NDA-Requests per wikitech. If you for some reason think that the order of steps matters, feel... [18:28:36] (03PS1) 10Daimona Eaytoy: [WIP] Add a new data type for non-initialized stuff [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/478424 (https://phabricator.wikimedia.org/T204654) [18:31:33] 04(no projects): delete page with badtitle on enwiki - https://phabricator.wikimedia.org/T211478 (10Xaosflux) 05Open>03Resolved a:03Xaosflux Deleted via API call [18:31:45] 10AbuseFilter, 10Patch-For-Review: Find a better way to compute variables when testing filter syntax - https://phabricator.wikimedia.org/T204654 (10Daimona) a:03Daimona [18:33:52] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10Daimona) @Aklapper I do not :-) However, to be nit-picky, the checklist on wikitech does: - [...] support from a Wikimedia Foundation employee [...] - [...] approval from one Wikimedia Foundation manager [...] - [...]... [18:36:04] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Xaosflux) Can a batch fix of moving them all to Project/Project_talk just be done? [18:42:26] (03PS6) 10Urbanecm: Make notification_html localized by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [18:42:40] (03CR) 10Urbanecm: Make notification_html localized by the standard machinery (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [18:43:50] (03PS7) 10Urbanecm: Localize notification_html by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 [18:47:29] (03CR) 10Urbanecm: [C: 04-1] Added i18n linting and fixed issues (038 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [18:52:35] (03CR) 10Urbanecm: [C: 031] "LGTM" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [19:06:36] 10Wikimedia-Site-requests: Allow uploading of .swf (flash) files to commons - https://phabricator.wikimedia.org/T28269 (10Koavf) Sure but it can serve as an archive of older files. No one is making new Flash and no one should have made Flash back in the day but preserving some of this content can be valuable. [19:16:37] (03PS8) 10Arcayn: Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [19:30:49] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Reedy) >>! In T200391#4807778, @Wbm1058 wrote: > Might be best to discuss this on wiki as any mass solution will likely require a bot, needing approval at WP:BRFA No, a bot wouldn't need ap... [19:32:40] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Reedy) >>! In T200391#4807816, @Xaosflux wrote: > Can a batch fix of moving them all to Project/Project_talk just be done? I wonder if we should just re-add the EducationProgram NS in mw-co... [19:43:44] (03CR) 10Takidelfin: [C: 04-1] Refactor most of jQuery code to vanilla JS (036 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [19:48:31] (03CR) 10Krinkle: [C: 04-1] Add TransactionProfiler::redefineExpectations and migrate appropriate callers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/477638 (owner: 10Aaron Schulz) [19:48:57] (03CR) 10Krinkle: [C: 04-1] "Code LGTM, but concerned about docs given we now have three methods. They state what they do but not why." [core] - 10https://gerrit.wikimedia.org/r/477638 (owner: 10Aaron Schulz) [19:49:15] 10Google-Code-in-2018, 10Gadgets, 10I18n, 10goodfirstbug: Localize Gadgets magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210826 (10MarcoAurelio) Yes, that helps. We can add both though (just wondering if there was a typo, etc.). Regards. [19:49:51] (03PS5) 10Gergő Tisza: Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [19:50:01] 10MediaWiki-extensions-EducationProgram: Cleaning up after EducationProgram - https://phabricator.wikimedia.org/T200391 (10Wbm1058) >>! In T200391#4807826, @Reedy wrote: >>>! In T200391#4807816, @Xaosflux wrote: >> Can a batch fix of moving them all to Project/Project_talk just be done? > > I wonder if we shoul... [19:50:12] Just realized how ugly my nickname is when `T` is uppercased ._. https://usercontent.irccloud-cdn.com/file/W7bCQwXT/screenshot_20181208_204832.png [19:50:39] (03CR) 10Gergő Tisza: [C: 032] "Thanks for the patch! Sorry this took so long." [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [19:50:54] Someone’s using polygerrit :P [19:51:32] (03Merged) 10jenkins-bot: Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [19:51:34] :c [19:52:01] (03CR) 10jenkins-bot: Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [19:52:37] (03PS1) 10Nathan fraignt: Change edit ticket view now show's ticket name [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478425 (https://phabricator.wikimedia.org/T211341) [19:53:21] paladox: I shouldn't use it? [19:54:38] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Title tag in edit ticket view should show ticket's name - https://phabricator.wikimedia.org/T211341 (10Nathan_fraignt) a:03Nathan_fraignt [19:54:56] takidelfin: yes you should :) [19:55:09] Didn’t mean to sound like it was a bad thing :) [19:55:17] ah :D [19:56:27] The old ui was removed upstream anyways :) [19:57:54] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Tgr) 05Open>03Resolved Verified that uploading works now. Thanks! @Jnanaranjan_sahu at a glance the problem is that you are using setExtraParams. File u... [20:02:12] (03CR) 10Urbanecm: [C: 032] Change edit ticket view now show's ticket name [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478425 (https://phabricator.wikimedia.org/T211341) (owner: 10Nathan fraignt) [20:02:47] (03Merged) 10jenkins-bot: Change edit ticket view now show's ticket name [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478425 (https://phabricator.wikimedia.org/T211341) (owner: 10Nathan fraignt) [20:05:06] (03CR) 10Krinkle: "LGTM, but curious about the use case. In particular, whether it could/should be the responsibility of the caller instead, or whether there" [core] - 10https://gerrit.wikimedia.org/r/478419 (owner: 10Aaron Schulz) [20:05:31] 10Wikidocumentaries: Update Wikibase, migate content to it - https://phabricator.wikimedia.org/T211480 (10Susannaanas) [20:06:11] 10Wikidocumentaries: Update Wikibase, migate content to it - https://phabricator.wikimedia.org/T211480 (10Susannaanas) p:05Triage>03High [20:07:01] 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas) p:05Triage>03High [20:08:06] (03PS4) 10Krinkle: Skin: Remove default loading of module 'mediawiki.user' [core] - 10https://gerrit.wikimedia.org/r/477261 (owner: 10Fomafix) [20:09:57] (03CR) 10Krinkle: [C: 04-1] "Agreed. This is for compatibility. I think we should document this explicitly, but I do not believe it is worth deprecating/removing." [core] - 10https://gerrit.wikimedia.org/r/478159 (owner: 10Fomafix) [20:10:11] (03CR) 10Krinkle: [C: 032] "Awesome. Well-spotted!" [core] - 10https://gerrit.wikimedia.org/r/477261 (owner: 10Fomafix) [20:10:20] (03CR) 10Krinkle: [C: 032] Remove obsolete aliases from closures [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478398 (https://phabricator.wikimedia.org/T208951) (owner: 10Fomafix) [20:10:32] (03PS1) 10Gergő Tisza: Improve example code in README [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478426 [20:10:34] (03PS1) 10Gergő Tisza: Improve phpdocs for Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478427 [20:10:59] (03CR) 10Gergő Tisza: [C: 032] "Self-merge, docs-only change" [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478426 (owner: 10Gergő Tisza) [20:11:14] (03CR) 10Gergő Tisza: [C: 032] "Self-merge, docs-only change" [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478427 (owner: 10Gergő Tisza) [20:12:04] (03PS1) 10Nathan fraignt: Change edit ticket view now show's ticket name in title [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478428 (https://phabricator.wikimedia.org/T211341) [20:12:07] (03Merged) 10jenkins-bot: Improve example code in README [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478426 (owner: 10Gergő Tisza) [20:12:11] (03Merged) 10jenkins-bot: Improve phpdocs for Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478427 (owner: 10Gergő Tisza) [20:12:35] (03CR) 10Urbanecm: [C: 032] Change edit ticket view now show's ticket name in title [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478428 (https://phabricator.wikimedia.org/T211341) (owner: 10Nathan fraignt) [20:12:39] (03CR) 10jenkins-bot: Improve example code in README [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478426 (owner: 10Gergő Tisza) [20:12:52] (03CR) 10jenkins-bot: Improve phpdocs for Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/478427 (owner: 10Gergő Tisza) [20:13:31] (03Merged) 10jenkins-bot: Change edit ticket view now show's ticket name in title [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478428 (https://phabricator.wikimedia.org/T211341) (owner: 10Nathan fraignt) [20:13:49] (03CR) 10Krinkle: [C: 032] Fix dependencies on core modules [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/477723 (owner: 10Fomafix) [20:16:55] 10Phabricator: Phab 'deadline' feature prevents changing some other fields - https://phabricator.wikimedia.org/T211481 (10Quiddity) [20:16:59] 04(no projects): Error trying to delete specific page on enwiki (worked via API) - https://phabricator.wikimedia.org/T211478 (10Aklapper) [20:20:07] (03PS1) 10Nathan fraignt: Move import statement to top of file [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478429 [20:23:37] (03Merged) 10jenkins-bot: Skin: Remove default loading of module 'mediawiki.user' [core] - 10https://gerrit.wikimedia.org/r/477261 (owner: 10Fomafix) [20:23:39] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/478398 (https://phabricator.wikimedia.org/T208951) (owner: 10Fomafix) [20:23:41] (03Merged) 10jenkins-bot: Fix dependencies on core modules [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/477723 (owner: 10Fomafix) [20:25:57] (03CR) 10jenkins-bot: Skin: Remove default loading of module 'mediawiki.user' [core] - 10https://gerrit.wikimedia.org/r/477261 (owner: 10Fomafix) [20:26:03] (03CR) 10jenkins-bot: Fix dependencies on core modules [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/477723 (owner: 10Fomafix) [20:26:32] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/478430 [20:29:42] (03PS1) 10Nathan fraignt: Add permission to import 100+ rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) [20:29:52] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Importing more than 100 rows should be a Django-level permission - https://phabricator.wikimedia.org/T211392 (10Nathan_fraignt) a:03Nathan_fraignt [20:38:48] (03PS1) 10MarcoAurelio: Fix lack of title when there's no files [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478432 [20:39:01] (03PS1) 10VolkerE: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/Timeless] - 10https://gerrit.wikimedia.org/r/478433 [20:42:19] (03CR) 10MarcoAurelio: [C: 032] Fix lack of title when there's no files [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478432 (owner: 10MarcoAurelio) [20:43:28] (03PS1) 10Urbanecm: [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 [20:43:35] (03CR) 10jerkins-bot: [V: 04-1] [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 (owner: 10Urbanecm) [20:44:23] (03Merged) 10jenkins-bot: Fix lack of title when there's no files [extensions/UploadLocal] (REL1_27) - 10https://gerrit.wikimedia.org/r/478432 (owner: 10MarcoAurelio) [20:44:33] (03PS2) 10Urbanecm: [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 [20:44:45] (03CR) 10Urbanecm: [C: 032] [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 (owner: 10Urbanecm) [20:45:29] (03CR) 10jerkins-bot: [V: 04-1] [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 (owner: 10Urbanecm) [20:45:43] (03CR) 10jerkins-bot: [V: 04-1] [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 (owner: 10Urbanecm) [20:48:27] (03PS3) 10Urbanecm: [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 [20:48:35] (03CR) 10Urbanecm: [C: 032] [security] Fix XSS vulnerability [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478434 (owner: 10Urbanecm) [20:49:17] (03PS1) 10MarcoAurelio: Fix lack of title when there's no files [extensions/UploadLocal] (REL1_31) - 10https://gerrit.wikimedia.org/r/478435 [20:49:45] 10MediaWiki-extensions-JsonConfig: Content for temporary working copy shows up on wrong page in the data space, and can not be deleted - https://phabricator.wikimedia.org/T211475 (10Aklapper) 05Open>03stalled Can you please edit and update the task description to 1) Provide clear steps to see the problem. As... [20:51:07] (03Abandoned) 10MarcoAurelio: Fix lack of title when there's no files [extensions/UploadLocal] (REL1_31) - 10https://gerrit.wikimedia.org/r/478435 (owner: 10MarcoAurelio) [20:51:49] (03PS1) 10MarcoAurelio: Expand $wgExtensionCredits for UploadLocal [extensions/UploadLocal] (REL1_32) - 10https://gerrit.wikimedia.org/r/478436 [20:56:05] 10Design, 10Mobile, 10Spanish-Sites: Review new es.wikipedia's main page - https://phabricator.wikimedia.org/T211482 (10abian) [20:57:18] (03PS1) 10Urbanecm: Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 [20:57:34] (03CR) 10Urbanecm: [C: 032] Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 (owner: 10Urbanecm) [20:58:19] (03CR) 10jerkins-bot: [V: 04-1] Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 (owner: 10Urbanecm) [20:58:32] (03CR) 10jerkins-bot: [V: 04-1] Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 (owner: 10Urbanecm) [21:01:55] (03PS1) 10MarcoAurelio: Convert UploadLocal to use extension registration [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) [21:02:50] (03PS2) 10Urbanecm: Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 [21:03:52] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (100x010C) @Tgr thanks for the review and the merge! [21:04:03] (03CR) 10Urbanecm: [C: 032] Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 (owner: 10Urbanecm) [21:04:36] (03PS2) 10Bjornskjald: Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) [21:04:56] (03PS9) 10Arcayn: Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) [21:05:02] (03Merged) 10jenkins-bot: Convert |safe to |urlize in some fields [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478437 (owner: 10Urbanecm) [21:10:42] hello bawolff! [21:10:45] hi [21:11:54] hi bawolff! [21:12:04] hello shreyasminocha [21:12:37] Last weekend of GCI :( [21:12:47] yup, that is really sad [21:12:49] Hi all [21:12:49] :( [21:12:53] Yeah it´s sad [21:12:58] Hi bawolff and Nathan_fraignt [21:13:01] o/ [21:13:04] and everyone lol [21:13:09] But I´m kinda happy, GCI is draining my time lol [21:13:11] yeah. hopefully we'll continue to meet right here [21:13:17] That is the plan^ [21:13:23] I do really think this years GCI was terrible timing, right in the middle of people's exams [21:13:32] yup [21:13:32] it was better for me [21:13:34] yup [21:13:44] ¯\_(ツ)_/¯ [21:16:46] 10MediaWiki-extensions-Other: Convert UploadBlacklist to use extension registration - https://phabricator.wikimedia.org/T211483 (10MarcoAurelio) [21:18:47] (03CR) 10Brian Wolff: [C: 032] "Looks good" [core] - 10https://gerrit.wikimedia.org/r/478289 (https://phabricator.wikimedia.org/T210923) (owner: 10Rafidaslam) [21:21:03] (03CR) 10Isarra: [C: 032] "<3" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/478430 (owner: 10VolkerE) [21:21:11] (03CR) 10Isarra: [C: 032] build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/Timeless] - 10https://gerrit.wikimedia.org/r/478433 (owner: 10VolkerE) [21:22:24] 10WMSE-Riksarkivet-TORA: Create a Proof of Concept displaying data from Wikipedia/Wikidata - https://phabricator.wikimedia.org/T204229 (10Salgo60) [21:24:43] 10WMF-NDA-Requests: Volunteer NDA for Daimona - https://phabricator.wikimedia.org/T211042 (10MusikAnimal) > I guess @aezell is @MusikAnimal's magager per https://meta.wikimedia.org?oldid=18624969#Team ? (required for step 2) I shall ask him about this, though I will say AbuseFilter isn't within Community Tech's... [21:24:55] (03PS2) 10Lokal Profil: Use proper User object instead of reading database [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/455859 (owner: 10Seb35) [21:32:20] 10MediaWiki-extensions-Other, 10Software-Licensing: UploadBlacklist is missing licensing - https://phabricator.wikimedia.org/T211484 (10MarcoAurelio) [21:32:22] (03Merged) 10jenkins-bot: SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed [core] - 10https://gerrit.wikimedia.org/r/478289 (https://phabricator.wikimedia.org/T210923) (owner: 10Rafidaslam) [21:32:24] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/478430 (owner: 10VolkerE) [21:32:26] (03Merged) 10jenkins-bot: build: Update 'stylelint-config-wikimedia' to v0.5.0 and make pass [skins/Timeless] - 10https://gerrit.wikimedia.org/r/478433 (owner: 10VolkerE) [21:33:22] 10MediaWiki-extensions-Other: Convert UploadBlacklist to use extension registration - https://phabricator.wikimedia.org/T211483 (10MarcoAurelio) 05Open>03stalled Stalling until licensing is clarified here. [21:33:25] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10MarcoAurelio) [21:33:58] (03CR) 10Urbanecm: [C: 032] Localize notification_html by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [21:34:06] (03CR) 10Lokal Profil: [C: 032] Use proper User object instead of reading database [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/455859 (owner: 10Seb35) [21:34:50] (03CR) 10jenkins-bot: SpecialUnusedimages: Change message when CountCategorizedImagesAsUsed [core] - 10https://gerrit.wikimedia.org/r/478289 (https://phabricator.wikimedia.org/T210923) (owner: 10Rafidaslam) [21:35:00] (03Merged) 10jenkins-bot: Localize notification_html by the standard machinery [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478418 (owner: 10Urbanecm) [21:38:26] (03Merged) 10jenkins-bot: Use proper User object instead of reading database [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/455859 (owner: 10Seb35) [21:42:18] (03CR) 10Urbanecm: [C: 032] Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [21:44:05] (03PS10) 10Urbanecm: Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [21:45:13] (03CR) 10Urbanecm: [C: 032] Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [21:46:13] (03Merged) 10jenkins-bot: Add i18n linting and fixed issues [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478396 (https://phabricator.wikimedia.org/T211105) (owner: 10Arcayn) [21:46:32] brion: mind choosing a license for an extension of yours, UploadBlacklist - T211484 -- thanks :) [21:46:32] T211484: UploadBlacklist is missing licensing - https://phabricator.wikimedia.org/T211484 [21:46:54] brion: a question ofc, forgot the "?" [21:47:53] :D [21:48:57] 10MediaWiki-Special-pages, 10Core Platform Team, 10Wikimedia-production-error: Target deletion during page move fails - https://phabricator.wikimedia.org/T210739 (10Krinkle) This fatal exception in WMF-deployed code is currently missing a team tag. It appears individual(s) from CPT are already involved, henc... [21:49:34] (03CR) 10Takidelfin: [C: 031] Refactor most of jQuery code to vanilla JS [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [21:49:53] thanks takidelfin :D [21:49:58] ^-^ [21:55:00] (03CR) 10Krinkle: [C: 04-1] "one nit. LGTM otherwise. Thanks!" (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:56:33] (03CR) 10Krinkle: [C: 04-1] Merge subscriber functionality into core module (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:57:05] (03CR) 10Krinkle: [C: 04-1] Merge subscriber functionality into core module (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:59:54] (03CR) 10Krinkle: [C: 04-1] Merge subscriber functionality into core module (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/478228 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:01:18] 10MediaWiki-Core-Tests, 10Patch-For-Review: Do not initialise the database in tests when not needed - https://phabricator.wikimedia.org/T155147 (10Krinkle) [22:01:20] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-production-error (Shared Build Failure): CentralAuth causes DBAccessError in non-database phpunit suite - https://phabricator.wikimedia.org/T201290 (10Krinkle) [22:02:14] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10MarcoAurelio) Please note, with regards to the Talk namespaces, that the gramatically correct way to w... [22:02:27] 10MediaWiki-extensions-CentralAuth, 10Wikimedia-production-error (Shared Build Failure): CentralAuth causes DBAccessError in non-database phpunit suite - https://phabricator.wikimedia.org/T201290 (10Krinkle) 05Open>03stalled Okay, so it sounds like this bug would automatically fix itself when the core beha... [22:02:31] Urbanecm: maybe I can be your student for T210752 ? :) [22:02:31] T210752: Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 [22:02:49] 10MediaWiki-Core-Tests, 10Patch-For-Review: Do not initialise the database in tests when not needed - https://phabricator.wikimedia.org/T155147 (10Krinkle) p:05Normal>03High Raising priority per T201290. [22:02:57] although wiki creation is painful, slow and boring [22:03:13] 10MediaWiki-extensions-PageAssessments, 10Community-Tech: Store each assessment instead of just current one - https://phabricator.wikimedia.org/T211485 (10mahmoud) [22:03:18] Hauskatze, yeah, but we have to live with that... [22:03:36] * Hauskatze prefers closing them :P [22:03:41] it's easier, technically [22:03:42] (03CR) 10Mainframe98: [C: 04-1] Convert UploadLocal to use extension registration (032 comments) [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) (owner: 10MarcoAurelio) [22:03:54] but the language committee doesn't, IIRC [22:04:49] Well, the task is available to real GCI students. The task claiming period ends on Monday 17:00 UTC, maybe you can do it after this date? ;) [22:05:43] (03CR) 10MarcoAurelio: Convert UploadLocal to use extension registration (032 comments) [extensions/UploadLocal] - 10https://gerrit.wikimedia.org/r/478438 (https://phabricator.wikimedia.org/T211428) (owner: 10MarcoAurelio) [22:06:01] Maybe I will do it? [22:06:19] Urbanecm: I don't really have much interest in doing all that myself [22:06:48] I can still take care of the translations, etc. [22:08:31] well, namespace translations should be done (something in that language already exist), so hopefully only the configuration patch needs to be done [22:08:41] takidelfin, that'll be great! [22:08:56] (03CR) 10Shreyasminocha: [C: 04-1] "Overall great work; I have just a few things to add." (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:09:38] * shreyasminocha goes to sleep. my eyes are literally drooping (3:39 AM. wtf am i doing) [22:09:50] (03CR) 10Takidelfin: "> Patch Set 2: Code-Review-1" (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:10:43] goodbye shreyasminocha! [22:12:53] (03CR) 10Bjornskjald: "> Patch Set 2: Code-Review-1" (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:13:14] (03CR) 10Urbanecm: [C: 04-1] Add permission to import 100+ rows (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) (owner: 10Nathan fraignt) [22:13:24] oh, bye shreyasminocha [22:14:41] (03PS1) 10MarcoAurelio: Add Neapolitan (nap) translations for Gadgets namespaces and special pages [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 [22:15:33] (03CR) 10Urbanecm: [C: 032] Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [22:16:39] (03Merged) 10jenkins-bot: Fix timezone related warnings [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478401 (https://phabricator.wikimedia.org/T208624) (owner: 10Nathan fraignt) [22:16:56] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Fix timezone-related warnings - https://phabricator.wikimedia.org/T208624 (10Urbanecm) 05Open>03Resolved [22:17:26] (03PS2) 10Nathan fraignt: Add permission to import 100+ rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) [22:18:41] (03PS1) 10Takidelfin: HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 [22:19:01] (03PS2) 10MarcoAurelio: Add Neapolitan (nap) translations for Gadgets namespaces and special pages [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) [22:19:38] (03CR) 10jerkins-bot: [V: 04-1] HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 (owner: 10Takidelfin) [22:20:02] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Title tag in edit ticket view should show ticket's name - https://phabricator.wikimedia.org/T211341 (10Urbanecm) 05Open>03Resolved [22:20:13] (03PS1) 10MarcoAurelio: Fix neapolitan talk namespace [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 [22:20:59] (03PS2) 10MarcoAurelio: Fix neapolitan talk namespace [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 [22:21:35] (03PS2) 10Takidelfin: HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 [22:21:59] (03PS3) 10Nathan fraignt: Add permission to import 100+ rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) [22:22:23] (03PS3) 10MarcoAurelio: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 [22:22:25] (03CR) 10Urbanecm: [C: 032] Add permission to import 100+ rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) (owner: 10Nathan fraignt) [22:22:30] (03PS4) 10MarcoAurelio: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 [22:23:28] (03Merged) 10jenkins-bot: Add permission to import 100+ rows [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478431 (https://phabricator.wikimedia.org/T211392) (owner: 10Nathan fraignt) [22:23:47] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Importing more than 100 rows should be a Django-level permission - https://phabricator.wikimedia.org/T211392 (10Urbanecm) 05Open>03Resolved [22:24:05] Urbanecm: Could you review my patch? https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478442 [22:24:10] :D [22:24:35] (03PS5) 10MarcoAurelio: Fix neapolitan talk namespaces for ProofreadPage [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/478443 [22:25:14] Sure [22:25:24] 10Google-Code-in-2018, 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Make $wgCountCategorizedImagesAsUsed change the description message of Special:Unusedfiles - https://phabricator.wikimedia.org/T210923 (10Bawolff) 05Open>03Resolved [22:26:12] takidelfin, I think h2 here https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478442/2/trackersite/templates/404.html is too big [22:26:18] takidelfin: did the other mentor accept your task? [22:26:35] bjornskjald, this isn't for a GCI task [22:26:40] ah okay [22:26:46] \o/ [22:27:03] takidelfin, maybe we should get rid of h2 in this context, as it is not true headline [22:27:03] (03PS17) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [22:27:24] hmm, ok, I will use paragraph then [22:27:33] ok [22:27:42] 10MinervaNeue, 10Readers-Web-Backlog (Design): "Related articles" appears too late and displaces footer links - https://phabricator.wikimedia.org/T208180 (10Krinkle) @Jdlrobson Could you summarise the original reasoning for why related article metadata is lazy-loaded, and evaluate whether that still applies?... [22:27:45] feel free to style it, if you think it's appropriate [22:28:05] 10MediaWiki-extensions-Scribunto, 10I18n: Localize Scribunto magic words and namespaces to Neapolitan - https://phabricator.wikimedia.org/T210825 (10MarcoAurelio) >>! In T210825#4803438, @Ruthven wrote: > @MarcoAurelio for Namespace names 828 and 829, let's use the ones of nap.wiki: "Modulo" and "Modulo_chiàcc... [22:28:16] 10MinervaNeue, 10Performance-Team (Radar), 10Readers-Web-Backlog (Design): "Related articles" appears too late and displaces footer links (FOUC; content jump) - https://phabricator.wikimedia.org/T208180 (10Krinkle) [22:28:46] (03PS1) 10MarcoAurelio: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 [22:30:54] (03PS2) 10MarcoAurelio: Translate Scribunto namespaces to Neapolitan (nap) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/478444 (https://phabricator.wikimedia.org/T210825) [22:31:37] (03CR) 10MarcoAurelio: [C: 04-1] "quick fix incoming" [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) (owner: 10MarcoAurelio) [22:31:37] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Add an item to the grunt lint `task` to check for un-internationalized strings - https://phabricator.wikimedia.org/T211105 (10Urbanecm) 05Open>03Resolved [22:32:56] (03PS3) 10MarcoAurelio: Add Neapolitan (nap) translations for Gadgets namespaces and special pages [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/478441 (https://phabricator.wikimedia.org/T210826) [22:34:48] (03CR) 10Urbanecm: [C: 032] Move import statement to top of file [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478429 (owner: 10Nathan fraignt) [22:35:05] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10MarcoAurelio) [22:35:53] (03Merged) 10jenkins-bot: Move import statement to top of file [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478429 (owner: 10Nathan fraignt) [22:42:01] (03PS1) 10Lokal Profil: Removing unneded globals [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/478445 [22:45:57] (03CR) 10Urbanecm: "> Patch Set 2:" (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:47:23] (03PS3) 10Takidelfin: HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 [22:47:25] (03CR) 10Bjornskjald: "> Patch Set 2:" (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:50:18] (03CR) 10Takidelfin: "> Patch Set 2:" (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478423 (https://phabricator.wikimedia.org/T211145) (owner: 10Bjornskjald) [22:51:21] (03PS4) 10Takidelfin: HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 [22:52:46] Urbanecm: done https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/478442 [22:52:57] looking [22:53:33] (03PS1) 10Urbanecm: Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 [22:55:46] (03CR) 10Urbanecm: [C: 032] HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 (owner: 10Takidelfin) [22:56:42] (03Merged) 10jenkins-bot: HTTP Errors: Unify error pages style [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478442 (owner: 10Takidelfin) [22:56:47] (03CR) 10Takidelfin: Use HTML5 doctype (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 (owner: 10Urbanecm) [23:03:56] (03PS1) 10Arcayn: Fixed unclosed trans template tag [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478448 [23:04:50] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Sorting by (pre)expeditures doesn't work - https://phabricator.wikimedia.org/T211277 (10Nathan_fraignt) a:03Nathan_fraignt [23:05:06] (03PS1) 10Nathan fraignt: Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) [23:05:08] (03CR) 10Urbanecm: [C: 032] Fixed unclosed trans template tag [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478448 (owner: 10Arcayn) [23:06:05] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt) [23:06:07] (03Merged) 10jenkins-bot: Fixed unclosed trans template tag [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478448 (owner: 10Arcayn) [23:07:32] (03PS2) 10Nathan fraignt: Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) [23:08:28] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt) [23:08:41] (03PS2) 10Urbanecm: Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 [23:09:42] (03CR) 10Takidelfin: [C: 031] Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 (owner: 10Urbanecm) [23:09:47] (03CR) 10Stibba: [C: 031] Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 (owner: 10Urbanecm) [23:10:12] (03PS3) 10Nathan fraignt: Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) [23:11:10] (03CR) 10jerkins-bot: [V: 04-1] Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt) [23:12:33] (03PS1) 10Arcayn: Add ticket name to edit_ticket breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478450 (https://phabricator.wikimedia.org/T211340) [23:16:03] (03CR) 10Urbanecm: [C: 032] Add ticket name to edit_ticket breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478450 (https://phabricator.wikimedia.org/T211340) (owner: 10Arcayn) [23:17:03] (03Merged) 10jenkins-bot: Add ticket name to edit_ticket breadcrumb [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478450 (https://phabricator.wikimedia.org/T211340) (owner: 10Arcayn) [23:17:15] (03PS4) 10Nathan fraignt: Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) [23:20:09] (03CR) 10Urbanecm: [C: 032] Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 (owner: 10Urbanecm) [23:20:39] TheJair, takidelfin: Thanks for reviewing ^^^ [23:21:08] (03Merged) 10jenkins-bot: Use HTML5 doctype [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478446 (owner: 10Urbanecm) [23:21:36] :D [23:22:28] Urbanecm: \o/ [23:23:13] (03CR) 10Takidelfin: [C: 031] Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed! [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt) [23:23:23] (03PS1) 10Fomafix: Move styles that only used in JavaScript to JavaScript module [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/478451 [23:24:42] `Fix sorting: (Pre)expenditures now sorted correctly and arrows are displayed!` [23:24:42] hmm, maybe it will be better like this: [23:24:42] `Fix (pre)expenditures sorting and sorting arrows displaying` ? [23:24:42] #grammaradvice [23:24:52] Nathan_fraignt Urbanecm shreyasminocha [23:25:00] or something like that [23:25:05] Don't know [23:25:22] Don´t, but will change it to 2 patches anyways [23:25:30] don know* [23:25:44] don kihot [23:25:56] Don Quixote [23:26:02] shh typing is hard [23:26:12] don quijote [23:26:19] ;D [23:26:38] goodybe everyone! [23:26:50] goodbye (night?) :) [23:26:54] (03CR) 10Lokal Profil: [C: 032] ">" [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/474554 (https://phabricator.wikimedia.org/T189222) (owner: 10Seb35) [23:27:33] (03PS5) 10Nathan fraignt: Fix (pre)expenditure sorting [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) [23:27:40] cya takidelfin [23:28:04] Gn! [23:30:46] (03PS6) 10Nathan fraignt: Fix (pre)expenditure sorting [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) [23:30:54] (03Merged) 10jenkins-bot: Remove deprecated dieUsage method [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/474554 (https://phabricator.wikimedia.org/T189222) (owner: 10Seb35) [23:35:56] 10MediaWiki-Logging, 10Operations, 10Wikimedia-Logstash: Move mediawiki to new logging infrastructure - https://phabricator.wikimedia.org/T211124 (10Krinkle) [23:36:26] (03CR) 10Urbanecm: [C: 032] Fix (pre)expenditure sorting [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [23:37:03] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Breadcrumb in edit ticket view doesn't contain ticket's name - https://phabricator.wikimedia.org/T211340 (10Urbanecm) 05Open>03Resolved a:03Urbanecm [23:37:11] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Breadcrumb in edit ticket view doesn't contain ticket's name - https://phabricator.wikimedia.org/T211340 (10Urbanecm) a:05Urbanecm>03Arcayn [23:37:24] (03Merged) 10jenkins-bot: Fix (pre)expenditure sorting [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [23:37:46] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Sorting by (pre)expeditures doesn't work - https://phabricator.wikimedia.org/T211277 (10Urbanecm) 05Open>03Resolved [23:40:48] (03CR) 10Arcayn: "This will only fix the sorting for the index.html page, not any other places a ticket table appears e.g. 'topic_detail.html'" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [23:44:26] 10MediaWiki-General-or-Unknown, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Technical-Debt, and 2 others: Remove MediaWiki code marked for removal in a past release - https://phabricator.wikimedia.org/T61113 (10Zoranzoki21) >>! In T61113#4807794, @Aklapper wrote: > @Zoranzoki21: Why d... [23:46:39] (03PS1) 10Nathan fraignt: Fix sorting arrows on localhost [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478452 (https://phabricator.wikimedia.org/T210987) [23:47:30] (03PS1) 10Lokal Profil: Use extension registration [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/478453 (https://phabricator.wikimedia.org/T204315) [23:48:30] 10OpenBadges, 10Patch-For-Review: Convert OpenBadges to use extension registration - https://phabricator.wikimedia.org/T204315 (10Lokal_Profil) a:03Lokal_Profil [23:48:47] (03PS1) 10Urbanecm: Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) [23:48:54] (03PS1) 10Gergő Tisza: Add a checker that stores hashes in local binary files [extensions/PwnedPasswords] - 10https://gerrit.wikimedia.org/r/478455 [23:49:31] (03CR) 10jerkins-bot: [V: 04-1] Add a checker that stores hashes in local binary files [extensions/PwnedPasswords] - 10https://gerrit.wikimedia.org/r/478455 (owner: 10Gergő Tisza) [23:49:44] (03CR) 10jerkins-bot: [V: 04-1] Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) (owner: 10Urbanecm) [23:50:06] (03CR) 10Gergő Tisza: "> per IRC discussion, should use PwnedPasswords.class.php to have a file-based alternative implementation of the service (and packpwdhashe" [extensions/PwnedPasswords] - 10https://gerrit.wikimedia.org/r/477113 (owner: 10Gergő Tisza) [23:51:57] 10Google-Code-in-2018, 10WMCZ-Tracker, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Urbanecm) https://codein.withgoogle.com/tasks/6496707140386816/ [23:52:19] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm, 10goodfirstbug: Move the maximum number of rows ordinary user can import to settings.py - https://phabricator.wikimedia.org/T211486 (10Urbanecm) [23:55:14] (03CR) 10Urbanecm: [C: 032] Fix sorting arrows on localhost [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478452 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt) [23:55:35] (03CR) 10Nathan fraignt: "> Patch Set 7:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478449 (https://phabricator.wikimedia.org/T211277) (owner: 10Nathan fraignt) [23:55:47] (03PS2) 10Urbanecm: Automatically revoke statutory declaration when "car_travel" is unchecked [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478454 (https://phabricator.wikimedia.org/T211429) [23:56:02] (03Merged) 10jenkins-bot: Fix sorting arrows on localhost [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/478452 (https://phabricator.wikimedia.org/T210987) (owner: 10Nathan fraignt)