[00:00:19] 10Event Metrics: Don't refresh page IDs if current date is after end date of the event - https://phabricator.wikimedia.org/T210682 (10MusikAnimal) [00:03:02] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Jdlrobson) To add to Joaquin's outputs, the following can also be considered outputs: * 100% code coverage for MobileFronten... [00:03:06] (03CR) 10jerkins-bot: [V: 04-1] DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [00:03:52] (03CR) 10Catrope: [C: 032] Add block notice stats on EditPage. [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [00:09:11] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Platonides) Ok, I have been preparing the mentioned poc. Should I directly request an extension for it? A... [00:09:48] 10MediaWiki-Core-Tests: If Zlib extension is not loaded, the Zlib related tests should be skipped - https://phabricator.wikimedia.org/T207125 (10RazeSoldier) Also https://codesearch.wmflabs.org/core/?q=gzdeflate&i=nope&files=&repos=. [00:11:42] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Performance-Team (Radar): Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views - https://phabricator.wikimedia.org/T186062 (10Jdlrobson) > That solution is well-tested and is also... [00:12:03] 10Wikimedia-Site-requests, 10Patch-For-Review: Throttle exemption for event at Wikimedia office on 2018-12-06 - https://phabricator.wikimedia.org/T210681 (10Catrope) 05Open>03Resolved [00:13:00] 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10Whatamidoing-WMF) User:Popcornduff can reproduce this in Chrome at the English Wikipedia. [00:13:17] (03CR) 10Jdlrobson: [C: 04-1] "Agreed. Let's deprecate this (and maybe entire mobileview api) first before making any changes like this. It's good practice if nothing el" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/402130 (https://phabricator.wikimedia.org/T99009) (owner: 10Jdlrobson) [00:14:58] (03CR) 10Jdlrobson: [C: 032] Hygiene: add tests for Drawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476428 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [00:16:53] (03CR) 10Ephemeralwaves: "> Should this be abandoned in favour of I172e7b16d?" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/471910 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [00:16:55] (03CR) 10jerkins-bot: [V: 04-1] Add block notice stats on EditPage. [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [00:16:57] (03CR) 10jerkins-bot: [V: 04-1] Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) (owner: 10Dmaza) [00:18:02] (03CR) 10Catrope: "Bogus failure:" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [00:18:07] (03CR) 10Catrope: [C: 032] Add block notice stats on EditPage. [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [00:18:17] (03CR) 10VolkerE: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [00:18:19] (03Merged) 10jenkins-bot: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [00:19:01] (03PS4) 10Ephemeralwaves: Test: notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) [00:19:20] (03CR) 10Ephemeralwaves: "> > Patch Set 3: Verified-1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [00:28:23] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476367 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:28:27] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476365 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:29:03] (03CR) 10VolkerE: "aaand pseudo-class > Expected ":Collapsible_elements/Demo/Simple" to be ":collapsible_elements/demo/simple" selector-pseudo-class-case" [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [00:31:10] (03PS1) 10Esanders: Use ve.targetLinksToNewWindow where possible [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/476435 [00:31:48] (03CR) 10VolkerE: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [00:32:45] (03PS2) 10VolkerE: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/476425 [00:33:04] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476354 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:33:16] (03CR) 10Esanders: [C: 032] Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [00:34:25] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476367 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:36:07] (03PS10) 10Cooltey: [ALMOST] Fix: Chinese variants issues that title on the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 [00:36:15] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476350 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:38:39] (03CR) 10VolkerE: "PS 2 removes obsolete stylelint-disable overrides with new version" [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [00:40:20] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/476344 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:41:21] (03Merged) 10jenkins-bot: Add block notice stats on EditPage. [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [00:42:33] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/476344 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:43:44] (03PS6) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [00:49:59] 10MediaWiki-Database, 10DBA, 10TechCom-RFC: RFC: Proposal to add wl_addedtimestamp attribute to the watchlist table - https://phabricator.wikimedia.org/T209773 (10daniel) >>! In T209773#4765225, @Marostegui wrote: > Does this has something to do with {T125991}? Is that some sort of duplicate? I just talked... [00:56:32] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [00:59:05] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10Continuous-Integration-Config: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10matmarex) Also occurred on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Math/+/4... [00:59:14] (03CR) 10Bartosz Dziewoński: [C: 032] "Test failure is T210634" [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:00:05] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Tracking): Standardising our use of headless node qunit tests across Popups and MobileFrontend - https://phabricator.wikimedia.org/T203137 (10Jhernandez) I was just re-reading the task and I find these comments funny 😃: > a... [01:00:55] (03PS1) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [01:01:22] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/476332 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:04:44] (03Merged) 10jenkins-bot: Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) (owner: 10Dmaza) [01:07:05] (03CR) 10jenkins-bot: Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) (owner: 10Dmaza) [01:07:17] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476326 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:07:19] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/476321 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:09:13] (03Abandoned) 10Jdlrobson: Upgrade mediawiki selenium packages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476157 (owner: 10Jdlrobson) [01:09:36] (03CR) 10jerkins-bot: [V: 04-1] QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [01:10:45] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/476332 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:14:28] 10Growth-Team: [wmf.4 - minor] FF: De-attached user warnings on RC/Watchlist on 'Display options' - https://phabricator.wikimedia.org/T210688 (10Etonkovidova) [01:14:38] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/476321 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:15:05] (03Merged) 10jenkins-bot: Use ParserCache in CategoryMembershipChangeJob [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) (owner: 10Daniel Kinzler) [01:15:07] (03Merged) 10jenkins-bot: Make page logs link actually work for page [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476415 (owner: 10Isarra) [01:15:12] (03Merged) 10jenkins-bot: Add use of Slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476427 (owner: 10Yaron Koren) [01:16:31] (03PS2) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [01:16:46] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476326 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:17:32] (03CR) 10jenkins-bot: Use ParserCache in CategoryMembershipChangeJob [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) (owner: 10Daniel Kinzler) [01:20:57] (03CR) 10jenkins-bot: Add use of Slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476427 (owner: 10Yaron Koren) [01:21:00] (03PS2) 10Jdlrobson: Hygiene: add tests for Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476428 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [01:21:08] (03CR) 10Jdlrobson: [C: 032] Hygiene: add tests for Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476428 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [01:27:05] (03PS3) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [01:40:23] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) a:03Huji Excellent idea! Patch coming shortly. [01:41:00] (03CR) 10jerkins-bot: [V: 04-1] QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [01:41:37] (03CR) 10jenkins-bot: Hygiene: add tests for Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476428 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [01:43:52] (03Merged) 10jenkins-bot: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [01:43:56] (03Merged) 10jenkins-bot: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [01:43:59] (03Merged) 10jenkins-bot: Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [01:44:01] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [01:44:03] (03PS1) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [01:45:55] (03PS4) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [01:46:20] (03PS5) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [01:48:57] (03CR) 10jenkins-bot: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [01:53:46] (03CR) 10jenkins-bot: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [01:54:25] (03CR) 10jerkins-bot: [V: 04-1] QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [01:56:35] (03CR) 10jenkins-bot: Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [02:00:40] (03PS2) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [02:01:21] (03PS3) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [02:16:57] (03CR) 10jerkins-bot: [V: 04-1] Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [02:22:16] (03CR) 10VolkerE: [C: 032] "Ok, let's make it a double-feature then…" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [02:27:03] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [02:31:41] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [02:32:25] 10Android-app-Bugs, 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Get invisible lead image when continuing open articles from trending list - https://phabricator.wikimedia.org/T208910 (10ABorbaWMF) Looks good on 2.7.267-alpha-2018-... [02:34:16] 10Android-app-feature-Offline, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Provide clear indication of which articles in History are available whilst offline - https://phabricator.wikimedia.org/T157448 (10ABorbaWMF) Looks good to me across a few devices... [02:34:17] (03PS1) 10VolkerE: build: Follow 'svgmin' step option best-practices [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476440 [02:36:49] (03CR) 10VolkerE: [C: 032] "Follow-up at Ic69532ad165" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [02:39:56] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Offline message appears after refreshing saved article in airplane mode - https://phabricator.wikimedia.org/T210691 (10ABorbaWMF) [02:42:37] 10MediaWiki-User-preferences, 10MediaWiki-extensions-CentralAuth, 10OOUI: Extra margin on CentralAuth preference buttons - https://phabricator.wikimedia.org/T210534 (10Volker_E) @kaldari Thanks for the pointer! The reason for HorizontalLayout buttons' margin is the possibility to end up with many widgets in... [02:46:26] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Offline message appears after refreshing saved article in airplane mode - https://phabricator.wikimedia.org/T210691 (10Dbrant) I'm fairly sure this is expected behavior: pulling down to refresh implies wanting to fetch the latest version of the article from... [02:52:23] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476441 [02:52:27] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476441 (owner: 10Ejegg) [02:52:49] (03PS4) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [02:54:03] 10MediaWiki-User-preferences, 10MediaWiki-extensions-CentralAuth, 10OOUI: Extra margin on CentralAuth preference buttons - https://phabricator.wikimedia.org/T210534 (10Volker_E) Actually, when looking closer, it might not even need the HorizontalLayout. ButtonWidgets are inline block elements and have margin... [02:56:37] (03CR) 10Jforrester: [C: 032] build: Follow 'svgmin' step option best-practices [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476440 (owner: 10VolkerE) [02:58:49] (03CR) 10VolkerE: "I don't have a very strong opinion here. VE currently uses 'help' in 'help' popup. But it could be argued that 'help' is better in toolbar" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476051 (https://phabricator.wikimedia.org/T90414) (owner: 10Gopavasanth) [03:01:27] (03CR) 10Jforrester: [C: 032] "…" [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [03:04:24] (03Abandoned) 10Jforrester: Test: notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/471910 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [03:05:25] (03CR) 10Jforrester: [C: 031] Use ve.targetLinksToNewWindow where possible [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/476435 (owner: 10Esanders) [03:07:01] (03CR) 10Jforrester: [C: 032] build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [03:15:05] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476441 (owner: 10Ejegg) [03:15:07] (03Merged) 10jenkins-bot: build: Follow 'svgmin' step option best-practices [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476440 (owner: 10VolkerE) [03:21:26] (03CR) 10jenkins-bot: build: Follow 'svgmin' step option best-practices [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476440 (owner: 10VolkerE) [03:21:54] 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10matmarex) a:03matmarex I think I identified the cause of the problem: {b2718b186abcc92f2279927d4b3f7cdb73dd19a7}. In short: we accidentally re... [03:23:30] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [03:33:42] 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10matmarex) [03:35:54] (03Merged) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [03:39:15] (03CR) 10jenkins-bot: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [04:02:12] (03PS1) 10Bartosz Dziewoński: ve.ui.MWCitationDialog: Fix condition for enabling insert/apply action [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476443 (https://phabricator.wikimedia.org/T210686) [04:02:45] (03PS2) 10Bartosz Dziewoński: ve.ui.MWCitationDialog: Fix condition for enabling insert/apply action [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476443 (https://phabricator.wikimedia.org/T210686) [04:03:03] (03CR) 10Bartosz Dziewoński: "Caused T210686." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476159 (owner: 10Esanders) [04:05:51] 10MobileFrontend: Is there a future where we unify front ends - https://phabricator.wikimedia.org/T210694 (10Milimetric) [04:06:07] 10WikiHiero, 10Regression: Hieroglyphs are no longer inline - https://phabricator.wikimedia.org/T210695 (10MaxSem) [04:06:10] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Milimetric) Thanks for outlining that, @Jhernandez. I agree with @Jdlrobson about making a separate task, so I did: T210694 [04:22:11] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10minhhuy) It really nonsense for me to read a Germany text in a English hompage without any context as what is it's meaning or purpose. [05:28:20] 👋 hello [05:38:53] Hello shreyasminocha! [05:38:59] Sorry for the delay! [05:41:40] (03CR) 10Reedy: "OMG MY HARD WORK" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [05:45:40] hi Ebe123 :) [05:46:38] to channel: does anyone know what i need to know to be able to work on T208620? [05:46:38] T208620: Parsoid should support SVG thumbnails in page language - https://phabricator.wikimedia.org/T208620 [05:50:50] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text - https://phabricator.wikimedia.org/T194524 (10Kaartic) Thanks. Looks much better now. Would adding when the text box would come into effect... [05:51:16] Sorry, can't really help; not enough details on the task, and don't really work on Parsoid [05:53:59] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text - https://phabricator.wikimedia.org/T194524 (10Kaartic) >>! In T194524#4784162, @Kaartic wrote: > > `Others: Examples: "-07:00" or "01:30"` O... [06:00:23] (03PS1) 10Reedy: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476449 (https://phabricator.wikimedia.org/T210643) [06:07:30] (03CR) 10Reedy: [C: 032] Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476449 (https://phabricator.wikimedia.org/T210643) (owner: 10Reedy) [06:12:02] (03Merged) 10jenkins-bot: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476449 (https://phabricator.wikimedia.org/T210643) (owner: 10Reedy) [06:16:58] 10MediaWiki-extensions-OATHAuth, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Wikistorm: Add logging to OATHAuth - https://phabricator.wikimedia.org/T151010 (10Reedy) 05Resolved>03Open Reverted due to some monolog (or our additional functions) issues [06:17:26] 10MediaWiki-Watchlist, 10Growth-Team: [wmf.4 - minor] FF: De-attached user warnings on RC/Watchlist on 'Display options' - https://phabricator.wikimedia.org/T210688 (10Aklapper) [06:18:51] 10MediaWiki-Debug-Logger, 10wikitech.wikimedia.org: Wikitech fails to enable 2fa - https://phabricator.wikimedia.org/T210669 (10Aklapper) For the records (as the other task is access restricted), fix has been deployed. [06:21:18] 10MediaWiki-Debug-Logger, 10Wikimedia-General-or-Unknown: OATHAuth logging fails using Monolog - https://phabricator.wikimedia.org/T210696 (10Reedy) [06:32:59] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Browser tests for TemplateWizard - https://phabricator.wikimedia.org/T199580 (10Samwilson) 05Resolved>03Open No, this really does seem to be flakey. Sorry!... [06:37:41] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [06:39:01] (03PS3) 10Takidelfin: Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 [06:39:16] (03CR) 10Takidelfin: "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 (owner: 10Takidelfin) [06:43:53] 10QuickSurveys, 10Mobile: Quick survey won't show up on mobile - https://phabricator.wikimedia.org/T210646 (10Aklapper) [06:48:53] (03PS3) 10Samwilson: Use existing overlay for all popups [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) [06:48:58] (03CR) 10Samwilson: Use existing overlay for all popups (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [06:49:42] (03PS6) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [06:57:57] (03CR) 10jerkins-bot: [V: 04-1] QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [07:08:27] (03PS2) 10Samwilson: Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [07:09:15] (03CR) 10Samwilson: Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [07:11:08] (03CR) 10Aklapper: "D3r1ck01: Should the bug ID in the commit message be T210510 instead?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [07:21:52] (03PS1) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [07:22:13] 10Wikimedia-Site-requests: Set WP namespace alias to NS_PROJECT in Shan Wikipedia (shnwiki) - https://phabricator.wikimedia.org/T210699 (10Ninjastrikers) [07:22:45] 10MediaWiki-Installer: Installer seemingly using wrong db name and username - https://phabricator.wikimedia.org/T123819 (10Aklapper) 05Open>03declined [07:23:59] (03CR) 10jerkins-bot: [V: 04-1] Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [07:27:27] (03PS1) 10Sharvaniharan: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) [07:29:19] (03CR) 10Urbanecm: [C: 04-2] "Recapitulation from IRC:" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) (owner: 10Nathan fraignt) [07:30:47] (03CR) 10jerkins-bot: [V: 04-1] Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [07:37:29] (03PS4) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [07:40:26] (03CR) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [07:41:59] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [07:45:32] (03CR) 10Jayprakash12345: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [07:45:47] 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10TheDJ) 05Open>03Resolved a:03Bjornskjald [07:45:58] 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10TheDJ) [07:52:29] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [08:03:28] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Regression: Autosave can be triggered for loaded drafts without user change - https://phabricator.wikimedia.org/T207699 (10Petar.petkovic) [08:07:32] 10MediaWiki-Page-editing, 10CharInsert, 10Editing-team: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10Schnark) I'm wondering: The WikiEditor toolbar already has a way to input special characters quite similar to the abov... [08:12:50] (03CR) 10Urbanecm: [C: 04-1] "Mute notifications and Ignore ack types have different width. Can you make them look more similar?" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [08:18:05] (03PS10) 10Reedy: Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [08:19:42] (03CR) 10Reedy: Add namespaces & psr-4 support in GuidedTour (031 comment) [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [08:19:46] (03Abandoned) 10Urbanecm: Revert "Remove temporarily some tests to try to workaround a bug in tests" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/473141 (https://phabricator.wikimedia.org/T207310) (owner: 10Urbanecm) [08:21:48] 10MediaWiki-User-preferences, 10OOUI, 10Browser-Support-Firefox: Scrolling in the rcdays input field in the preferences leads to decimal value with lots of digits - https://phabricator.wikimedia.org/T210574 (10Schnark) This is more or less {T102128}. The `step` value seems to be derived from the minimum and... [08:24:50] (03CR) 10jerkins-bot: [V: 04-1] Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [08:30:25] (03CR) 10Reedy: [C: 031] "I only didn't CR+2 it because it didn't fix the issue. But I definitely agree it shouldn't be there" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [08:32:07] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Zoranzoki21) [08:34:12] 10SDC General, 10Wikimedia-Stream: Verify that EventStreams work with WikiBase MediaInfo - https://phabricator.wikimedia.org/T210702 (10Abbe98) [08:35:34] (03CR) 10Robert Vogel: "@Raimond: Cindy and I want to change the whole code base here. Can you help me deal with the I18N changes please? I don't know which proce" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [08:36:48] (03PS1) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [08:39:59] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [08:40:14] 10Trust-and-Safety: Need resetting my 2FA at Wikitech - https://phabricator.wikimedia.org/T210703 (10Jnanaranjan_sahu) [08:41:52] (03CR) 10D3r1ck01: "> D3r1ck01: Should the bug ID in the commit message be T210510 instead?" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [08:42:26] (03PS2) 10D3r1ck01: Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) [08:44:35] 10MediaWiki-Core-Tests, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: MediaWiki Core LocalIdLookupTest uses undefined wgDBName - https://phabricator.wikimedia.org/T210512 (10D3r1ck01) 05Open>03Resolved a:03D3r1ck01 Can be nicely gently resolved(?). The CirrusSearch ticket is tracked h... [08:45:07] (03PS2) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [08:45:37] (03PS3) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [08:46:40] 10Trust-and-Safety: Need resetting 2FA of user Jnanaranjan_sahu at Wikitech - https://phabricator.wikimedia.org/T210703 (10Zoranzoki21) [08:47:34] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [08:48:42] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [08:50:14] (03CR) 10Zoranzoki21: "I got this errors in previous mwgate-npm-node-6-docker test. I no know what I should do:" [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [08:58:19] (03CR) 10Reedy: [C: 031] "AutoLoaderStructureTest::parseFile() doesn't find the class_alias in GuidedTourLauncher.php in that other patch" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:01:18] wikimedia-tech [09:01:40] Oops! [09:01:57] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [09:03:32] (03PS7) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:04:04] (03CR) 10Reedy: "class_alias \s* \( \s*" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:09:49] (03CR) 10jerkins-bot: [V: 04-1] Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:15:13] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [09:16:09] (03CR) 10ItSpiderman: Update privacy handler (031 comment) [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/475285 (owner: 10ItSpiderman) [09:16:32] (03PS6) 10ItSpiderman: Update privacy handler [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/475285 [09:20:24] (03PS4) 10ItSpiderman: Update privacy handler [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/475286 [09:23:52] (03CR) 10Reedy: "But that breaks other stuff :D" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:27:16] d3r1ck: congrats btw. just saw the final result of your nomination [09:30:00] (03PS8) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:30:58] (03PS9) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:31:33] (03CR) 10Reedy: "fsck regex" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:34:08] heh [09:37:14] (03CR) 10jerkins-bot: [V: 04-1] Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:37:37] what happened foks? [09:39:37] 10AbuseFilter, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona) [09:40:22] shreyasminocha, "fsck regex" [09:40:28] just thought that was funny :) [09:40:43] hehe [09:41:02] 10AbuseFilter, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona) p:05Triage>03Unbreak! Just making it clear, this is **not** train blocker since on itwiki we're still at wmf.4; until proven otherwise, of course. [09:42:03] hello..is there any human???? [09:42:19] there is [09:42:23] hey [09:42:25] you [09:42:31] hi. yes, me [09:42:32] help me [09:43:16] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (031 comment) [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/475286 (owner: 10ItSpiderman) [09:43:16] i have added my public key on git.gerrit.wmflabs.com .......what next???? [09:43:40] have you created the file in the gci folder? [09:44:05] NO.....there is no file [09:44:19] you have to create one [09:44:32] what file?? [09:44:37] from what i remember, it's supposed to be named Siyam.txt or something like that, but i'm not sure [09:44:42] check the instructions in your task [09:45:07] okay..i am creating [09:46:03] what should be the directory>??? [09:46:16] gci [09:46:37] wait...there is no folder named gci [09:46:47] i deleted them as you said [09:46:59] run the git clone command i gave you last time then [09:47:26] what was the command [09:49:39] git clone ssh://Shreyasminocha@gerrit.git.wmflabs.org:29418/gci && scp -p -P 29418 Shreyasminocha@gerrit.git.wmflabs.org:hooks/commit-msg gci/.git/hooks/ [09:49:44] but replace my uname with yours [09:50:00] in the future, you can find it by going to https://gerrit.git.wmflabs.org/r/admin/repos/gci [09:50:05] signing in, [09:50:09] clicking on the "ssh" tab [09:50:10] (03CR) 10Raimond Spekking: "i18n review" (031 comment) [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [09:50:29] (03CR) 10Thiemo Kreuz (WMDE): Remove array_unique() on expected classes in checkAutoLoadConf() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [09:52:33] what this does, is that it creates a copy of the "gci" repository on your folder. secondly, it copies a file into your .git/hooks directory [09:52:36] just fyi [09:54:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 4 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lydia_Pintscher) 05Open>03Resolved [09:56:02] (03PS1) 10Eugene233: showProjectButton should call addJsConfigVars() directly instead of setExtensionData() [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/476465 (https://phabricator.wikimedia.org/T204648) [09:56:36] $ git clone ssh://siyam410@gerrit.git.wmflabs.org:29418/gci && scp -p -P 29418 siyam410@gerrit.git.wmflabs.org:hooks/commit-msg gci/.git/hooks/ [09:56:37] Cloning into 'gci'... [09:56:37] siyam410@gerrit.git.wmflabs.org: Permission denied (publickey). [09:56:37] fatal: Could not read from remote repository. [09:56:37] Please make sure you have the correct access rights [09:56:38] and the repository exists. [09:56:58] 10FormWizard, 10FormWizard-Gadget, 10Patch-For-Review: showProjectButton should call addJsConfigVars() directly instead of setExtensionData() - https://phabricator.wikimedia.org/T204648 (10Eugene233) a:03Eugene233 [09:59:45] have you got it?? [10:00:24] 10FormWizard, 10FormWizard-Gadget, 10Documentation: Document How to build JSON schema which FormWizard Uses ( How to define schema) - https://phabricator.wikimedia.org/T204646 (10Eugene233) a:03Eugene233 [10:00:27] (03PS1) 10Pwirth: Improve WikiTextLinksHelper [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476466 [10:00:46] hello.. [10:01:12] Siyam: that shouldn't be happening [10:01:34] if ssh key was added correctly [10:02:16] i have added [10:02:23] i'm not sure how to proceed from here [10:02:27] (03PS2) 10Pwirth: Improve WikiTextLinksHelper [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476466 [10:02:32] hopefully someone else can join-in and help [10:07:24] its done [10:07:47] actually the first letter of my username shoulld be in capital [10:07:50] (03PS10) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:07:55] Are you here??? [10:10:04] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Joe) >>! In T189641#4783826, @Platonides wrote: > Ok, I have been preparing the mentioned poc. Should I d... [10:10:27] Siyam, hi [10:10:31] (03PS11) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:10:40] hey [10:10:55] i have added public key whats next [10:11:09] (03CR) 10Reedy: "Heh, hadn't seen your reply but had worked out that there wasn't enough \ yet :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:11:24] the addition isn't working, as it didn't authenticate you successfully [10:11:37] no [10:12:04] please do ssh -p 29418 -v siyam410@gerrit.git.wmflabs.org, post the complete output somewhere and link it here [10:12:17] paste.ee [10:12:44] Why do we seem to have GCI people talking to gerrit.git.wmflabs.org instead of gerrit.wikimedia.org ? [10:12:52] there's a task [10:12:58] "getting started with gerrit" [10:13:01] only people who really know what they're doing should be touching that gerrit instance... [10:13:18] (03PS1) 10Aklapper: Clarify that the default Help link in the sidebar is about MediaWiki itself [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) [10:13:55] Krenair: really? i thought it was a playground of sorts [10:13:59] Krenair, because it wasn't possible to get a test repository on prod instance... [10:14:09] Urbanecm, why not? [10:14:16] we used to have one [10:14:42] (03CR) 10Aklapper: "Note that I have no idea if the generic "Help" string is used in other UI places (hence I kept it) as it's too generic to grep for, but I " [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) (owner: 10Aklapper) [10:14:42] Urbanecm, shreyasminocha: o/ [10:14:49] \o [10:14:54] unfortunately I don't remember who told it to me, but when I was talking about something of that sorts, I was directed to this instance [10:15:09] ḧi takidelfin, how's your GCI task going? :) [10:15:17] $ git clone ssh://Siyam410@gerrit.git.wmflabs.org:29418/gci && scp -p -P 29418 Siyam410@gerrit.git.wmflabs.org:hooks/commit-msg gci/.git/hooks/ [10:15:17] Cloning into 'gci'... [10:15:17] Enter passphrase for key '/c/Users/LENOVO/.ssh/id_rsa': [10:15:17] remote: Counting objects: 3, done [10:15:17] remote: Finding sources: 100% (3/3) [10:15:19] remote: Getting sizes: 100% (2/2) [10:15:21] remote: Total 8 (delta 0), reused 8 (delta 0) [10:15:23] Receiving objects: 100% (8/8), done. [10:15:25] Enter passphrase for key '/c/Users/LENOVO/.ssh/id_rsa': [10:15:27] commit-msg 100% 1405 2.9KB/s 00:00 [10:15:29] good [10:15:37] what next?? [10:15:51] now creaye the file the task asks you to [10:17:24] Krenair, I'll note "to get a prod test repo or not have this task at all" on the lessons learned page through, I agree it'll be probably more simple [10:18:12] wait [10:18:22] what's happening Siyam ? [10:20:01] Siyam: once you create your file, you should be able to folloe the instructions at https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch [10:20:08] * shreyasminocha will brb [10:20:30] okay..let me check [10:20:47] takidelfin, did you see my message? :) [10:21:26] Urbanecm, I don't know if it's worth shutting down the task altogether but I would be very careful about that instance [10:21:34] Urbanecm: might be afk [10:21:54] Krenair: lesson for next yr [10:22:10] for Urbanecm and team [10:22:27] Krenair, I meant to create this task for GCI 2019 with prod repository instead :) [10:22:32] right :) [10:22:45] i have created the file... [10:22:52] When I was new there was a training repository in gerrit.wikimedia.org [10:22:54] now i will try to submit [10:23:01] Sumana gave me access IIRC [10:23:02] paray for me :p [10:23:26] Siyam, let us know if you have questions [10:23:27] (03CR) 10jerkins-bot: [V: 04-1] Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:23:28] Feb 28, 2012 9:53 PM Added Alex Monk (98) Sumanah (83) [10:23:30] examples? [10:23:51] * shreyasminocha is back [10:23:59] * Urbanecm waves to shreyasminocha [10:24:03] sure [10:24:13] * shreyasminocha waves back [10:24:16] all the best Siyam [10:24:24] thanks [10:24:42] Urbanecm, this one is requiring people to set up separate accounts right? [10:24:48] yep [10:25:25] Krenair, it's https://codein.withgoogle.com/tasks/4513104365879296/ [10:25:57] $ git pull origin master [10:25:58] fatal: not a git repository (or any of the parent directories): .git [10:26:07] problem again [10:26:22] Did you cd into the repo after you cloned it? [10:26:43] where is repo???? [10:26:44] Siyam: run your command from the gci directory [10:26:49] (03PS1) 10Urbanecm: Test [sandbox] - 10https://gerrit.wikimedia.org/r/476468 [10:26:51] oh [10:26:53] i see [10:26:58] wait [10:27:06] (03Abandoned) 10Urbanecm: Test [sandbox] - 10https://gerrit.wikimedia.org/r/476468 (owner: 10Urbanecm) [10:27:26] * Urbanecm noticed sandbox repository [10:27:38] thanks Krenair, going to update my note :D [10:27:45] okay :D [10:28:08] worked thanks urbanecm [10:28:13] yw Siyam [10:28:19] Krenair: Having a training repo might be a good idea to consider again, yeah. There are enough people already who (ab)use "mediawiki/extensions/example" in Gerrit for that, unfortunately (it's a valid code repository and not for testing). Plus I've seen at least one random tutorial website linking to our Gerrit instance for 'testing'. [10:28:39] heh [10:29:11] Siyam, did you upload the patch? :) [10:29:22] not yet [10:29:24] (03PS12) 10Reedy: Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:29:36] i am following the instruction of mediawiki [10:29:36] ok, waiting :) [10:29:41] sure [10:30:03] (03CR) 10Reedy: [C: 031] "Should be good to go now, I think!" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:30:25] andre__, as I noted on https://www.mediawiki.org/wiki/Google_Code-in/Lessons_learned, there's "sandbox". Looking this can be used for testing (also anybody has +2 on it) [10:30:33] (03CR) 10Reedy: "recheck" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [10:30:41] (03CR) 10Reedy: "Should hopefully be playing nice on PS12 of the core patch" [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [10:30:54] (03Abandoned) 10Alex Monk: Testing change via web UI [extensions/examples] - 10https://gerrit.wikimedia.org/r/354934 (owner: 10Alexhusic) [10:31:06] (03Abandoned) 10Alex Monk: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/387405 (owner: 10Vijeth89) [10:31:15] (03Abandoned) 10Alex Monk: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/421883 (owner: 10Yasmin) [10:31:21] can students add stuff to the "Lessons learned page"? [10:31:22] (03Abandoned) 10Alex Monk: Insert the description of the change. [extensions/examples] - 10https://gerrit.wikimedia.org/r/435999 (owner: 10MezRed) [10:32:03] I would assume so [10:32:04] shreyasminocha: Sure, if it's about something organizational [10:32:35] shreyasminocha: Whatever helps org admins to run a better GCI next year, basically [10:34:07] yeah, picked that vibe from the existing feedback on the page [10:34:16] LENOVO@DESKTOP-6OQVQCO MINGW64 ~/.ssh/gci (master) [10:34:16] $ git checkout -b GCI origin/master [10:34:16] Switched to a new branch 'GCI' [10:34:16] Branch 'GCI' set up to track remote branch 'master' from 'origin'. [10:34:16] LENOVO@DESKTOP-6OQVQCO MINGW64 ~/.ssh/gci (GCI) [10:34:16] $ git diff [10:34:18] LENOVO@DESKTOP-6OQVQCO MINGW64 ~/.ssh/gci (GCI) [10:34:20] $ git add Siyam009.txt [10:34:22] LENOVO@DESKTOP-6OQVQCO MINGW64 ~/.ssh/gci (GCI) [10:34:24] $ git review [10:34:26] No changes between HEAD and origin/master. Submitting for review would [10:34:28] be pointless. [10:34:29] 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10Ciencia_Al_Poder) Adding /* Header with a [[Help:Links|link]] */ to a summary... [10:34:30] LENOVO@DESKTOP-6O [10:34:30] !pastebin | Siyam [10:34:30] Siyam: To avoid overflowing the channel with inane amounts of text, use https://dpaste.org or https://phabricator.wikimedia.org/paste/edit/form/14/ or other awesome pastebin sites to share code, errors, and other large texts. [10:34:32] not working [10:34:40] Siyam: you need to commit [10:34:42] Siyam, you didn't commit [10:34:54] git commit -m "Add Siyam009.txt" [10:35:28] Siyam: Which instructions are you following for Gerrit? Any link to share? [10:35:49] (03CR) 10jerkins-bot: [V: 04-1] Clarify that the default Help link in the sidebar is about MediaWiki itself [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) (owner: 10Aklapper) [10:35:54] they're on Gerrit/Tutorial [10:36:01] the tut does mention git commit, however [10:36:08] https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch [10:36:21] https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch mentions "git commit" right after "git add". [10:36:25] next?? [10:36:36] Siyam: What's next on https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch ? [10:36:59] what should i do next [10:37:09] Siyam: What is written next on https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch ? [10:37:20] (03CR) 10jerkins-bot: [V: 04-1] Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [10:37:35] (03PS1) 10Ladsgroup: Drop $wgChangeTagsSchemaMigrationStage, part II [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/476470 (https://phabricator.wikimedia.org/T194163) [10:38:19] should i try git diff [10:38:40] follow the instructions, although git diff shouldn't matter here [10:38:49] do it anyway, it'll help you better understand the process perhaps [10:38:55] Siyam: Please follow the steps on https://www.mediawiki.org/wiki/Gerrit/Tutorial#How_to_submit_a_patch [10:38:59] i was following [10:39:05] Siyam: Then what is your question? [10:39:22] Siyam: you should do next whatever is written next in the instructions [10:40:55] (03PS11) 10Reedy: Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [10:41:54] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Ladsgroup) p:05Triage>03Normal [10:42:13] Siyam: We are happy to help if you run into problems and if the instructions are unclear, but you need to tell us at which step you are and *what* is exactly unclear and why. [10:42:14] Siyam: I hope you don't want us to copy what is already written in the instructions and then paste that here on IRC. That would not be a good use of anyone's time. :) [10:43:01] :) [10:43:32] https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker#Feedback,_questions_and_support applies, basically :) [10:43:55] (03CR) 10Lokal Profil: [C: 031] "looks good. one minor detail with the i18n strings" (031 comment) [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/474554 (https://phabricator.wikimedia.org/T189222) (owner: 10Seb35) [10:44:12] (03CR) 10jerkins-bot: [V: 04-1] Drop $wgChangeTagsSchemaMigrationStage, part II [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/476470 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [10:44:29] i like http://www.catb.org/esr/faqs/smart-questions.html [10:46:52] (03CR) 10jerkins-bot: [V: 04-1] Remove array_unique() on expected classes in checkAutoLoadConf() [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [10:46:54] 04(no projects): 1.33.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T210714 (10Nhatminh01) [10:47:20] (03CR) 10jerkins-bot: [V: 04-1] Add namespaces & psr-4 support in GuidedTour [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/466675 (owner: 10D3r1ck01) [10:47:58] 04(no projects): 1.33.0-wmf.27 deployment blockers - https://phabricator.wikimedia.org/T210714 (10Nhatminh01) I can't create like form [10:49:04] how to see if my patch was submitted??? [10:49:25] am i able to check it in gerrit [10:49:40] https://gerrit.git.wmflabs.org/r/q/project:gci [10:49:49] looks like it was submitted [10:51:16] thanks [10:51:44] you're welcome [10:59:56] (03CR) 10Lokal Profil: [C: 032] Property 'hashed' in Assertion must be a boolean [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/458480 (owner: 10Seb35) [11:00:07] (03CR) 10Reedy: [C: 031] "Unrelated test failure bug filed at T210712" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [11:00:19] (03PS7) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [11:03:28] (03Merged) 10jenkins-bot: Property 'hashed' in Assertion must be a boolean [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/458480 (owner: 10Seb35) [11:05:56] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10Aklapper) @jeblad: I don't know what exactly is asked for in this task and what exactly is "weird". Please see + follow https://www.mediawiki.org/wiki/How_to_report_a_bug "this seems to fixed" means that it see... [11:07:53] (03PS1) 10Pwirth: Replace BsLinkProvider with WikitextLinkHelper service [extensions/BlueSpiceWatchList] - 10https://gerrit.wikimedia.org/r/476475 [11:08:18] 10Phabricator, 10Puppet: Local config file contains escape characters - https://phabricator.wikimedia.org/T103924 (10Aklapper) 05Open>03declined No reply. :( Please reopen this task when clarifying what is the actual problem here and where. (I also assume this is an upstream issue?) Thanks a lot! [11:13:40] (03PS1) 10Pwirth: Replace BsLinkProvider with WikitextLinkHelper service [extensions/BlueSpicePagesVisited] - 10https://gerrit.wikimedia.org/r/476477 [11:15:52] (03PS1) 10Pwirth: Use linkRenderer service instead of BsLinkProvider [extensions/BlueSpiceSmartList] - 10https://gerrit.wikimedia.org/r/476478 [11:17:04] (03PS5) 10ItSpiderman: Update privacy handler [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/475286 [11:18:14] (03PS1) 10Pwirth: Remove usage of BsLinkProvider and mark it as deprecated [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476479 [11:18:31] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10mforns) @Amire80 Oh! No, the table you created will not be accessible on the web. What is accessible on the web are reports created by RU. As... [11:18:53] 10MediaWiki-extensions-CentralNotice, 10Readers-Web-Backlog (Tracking): Banner close button overlaps search controls on mobile - https://phabricator.wikimedia.org/T176092 (10Aklapper) @Jseddon: Could you answer the last question please? [11:20:22] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/475286 (owner: 10ItSpiderman) [11:21:05] 10MediaWiki-Docker: Warning when running docker build - https://phabricator.wikimedia.org/T210716 (10Marciofoz) [11:22:19] Hi, I have problems with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/HoverGallery/+/476457/ [11:22:38] What I should fix in HoverGallery.js [11:22:44] 09:46:48 /src/modules/HoverGallery.js 09:46:48 19:4 error Combine this with the previous 'var' statement one-var 09:46:48 19:4 error All 'var' declarations must be at the top of the function scope vars-on-top 09:46:48 25:4 error Combine this with the previous 'var' statement one-var 09:46:48 25:4 error All 'var' declarations must be at the top of the function scope [11:22:56] See https://integration.wikimedia.org/ci/job/mwgate-npm-node-6-docker/61300/console [11:23:48] 10AbuseFilter, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona) Totally random idea: are cache entries deleted after they expire? [11:26:43] (03CR) 10WMDE-leszek: [C: 032] Drop $wgChangeTagsSchemaMigrationStage, part II [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/476470 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [11:27:05] Zoranzoki21: Checking! Let me leave comments on the patch now [11:29:45] 10MediaWiki-extensions-Page_Forms: Save-And-Continue not fully supported by Multi-Instance-Templates - https://phabricator.wikimedia.org/T208610 (10Aklapper) >>! In T208610#4773870, @Emwiemaikel wrote: > @Aklapper I really have problems with the gerrit setup here. @Emwiemaikel: Thanks for the feedback! Would yo... [11:29:57] (03CR) 10D3r1ck01: "Great work! some fixes to apply :)" (035 comments) [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [11:29:59] Zoranzoki21: Done! [11:33:46] (03Merged) 10jenkins-bot: Drop $wgChangeTagsSchemaMigrationStage, part II [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/476470 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [11:47:25] (03PS7) 10Pboehm: Add new DefaultRobotPolicy [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 [11:49:58] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Amire80) [11:52:00] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Amire80) Oh, I get it now 🤦🏼 Cool, so the Superset dashboard is the next step! I'll really need help with that, 'cause I have no Superset expe... [11:52:07] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [11:53:20] (03CR) 10Zfilipin: "> Patch Set 4:" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [12:07:04] 10InternetArchiveBot (v2.0): IABot adds # to all URLs - https://phabricator.wikimedia.org/T209071 (10Cyberpower678) 05Open>03Resolved [12:08:49] 10Android-app-feature-Offline, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): UX-enhancement - when there is no connectivity, disable articles list items that are not available offli... - https://phabricator.wikimedia.org/T158852 [12:13:18] (03CR) 10jerkins-bot: [V: 04-1] Test: notify a new user with welcome message [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [12:29:01] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: View: Make isBorderBox and className passable options to the View cl... - https://phabricator.wikimedia.org/T209007 [12:33:47] (03PS4) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [12:34:39] (03CR) 10Pwirth: Add new DefaultRobotPolicy (031 comment) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 (owner: 10Pboehm) [12:35:53] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [12:36:52] (03CR) 10Urbanecm: [C: 04-1] "Please remove trailing whitespace." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 (owner: 10Takidelfin) [12:45:47] (03PS4) 10MarcoAurelio: Add PHP entry point with deprecation warning [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/467467 (https://phabricator.wikimedia.org/T206806) [12:49:48] (03CR) 10星耀晨曦: "recheck" [extensions/Math] (REL1_32) - 10https://gerrit.wikimedia.org/r/475082 (https://phabricator.wikimedia.org/T198564) (owner: 10星耀晨曦) [12:53:09] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Yes, 3 backslashes are also enough, because in the string "[\\\]" the first two backslashes are 1 escaped backslash, and the last is a mea" [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [12:53:32] (03CR) 10jerkins-bot: [V: 04-1] Log STDERR from mathoids cli output [extensions/Math] (REL1_32) - 10https://gerrit.wikimedia.org/r/475082 (https://phabricator.wikimedia.org/T198564) (owner: 10星耀晨曦) [12:53:38] (03PS1) 10Daimona Eaytoy: Allow unblocking if the blocker is a system user [core] - 10https://gerrit.wikimedia.org/r/476492 (https://phabricator.wikimedia.org/T150826) [13:00:06] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Petar.petkovic) [13:01:58] (03PS1) 10Pwirth: Remove BsCategoryHelper as it last usage was in version BS2.23 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476494 [13:03:13] (03CR) 10Daimona Eaytoy: [C: 04-1] Enable restricting certain groups from blocking certain groups. (0311 comments) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [13:04:16] (03CR) 10Daimona Eaytoy: [C: 04-1] Enable restricting certain groups from blocking certain groups. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [13:10:04] (03Abandoned) 10Aklapper: "Bug: T207781 fixed" [core] - 10https://gerrit.wikimedia.org/r/472496 (https://phabricator.wikimedia.org/T207781) (owner: 10Vijay9908) [13:10:09] (03Abandoned) 10Aklapper: Bug: "T207781 Revisionslider: highlighting of users sometimes doesn't apply to out of ares revisions" [core] - 10https://gerrit.wikimedia.org/r/472422 (owner: 10Vijay9908) [13:12:14] 04(no projects): Address recurrent service check time out for "HP RAID" - https://phabricator.wikimedia.org/T210723 (10fgiunchedi) [13:16:12] 10Patch-For-Review, 10Readers-Web-Backlog (Design): Add night mode to Minerva - https://phabricator.wikimedia.org/T206094 (10Esanders) [13:16:13] (03PS1) 10Pcoombe: Fundraising banners for wikipedia.org portal [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/476496 (https://phabricator.wikimedia.org/T202497) [13:17:39] 10Patch-For-Review, 10Readers-Web-Backlog (Design): Add night mode to Minerva - https://phabricator.wikimedia.org/T206094 (10Esanders) [13:19:09] 10Patch-For-Review, 10Readers-Web-Backlog (Design): Add night mode to Minerva - https://phabricator.wikimedia.org/T206094 (10Esanders) [13:20:33] 10MediaWiki-Database, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) [13:20:43] (03CR) 10Eugene233: [C: 032] showProjectButton should call addJsConfigVars() directly instead of setExtensionData() [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/476465 (https://phabricator.wikimedia.org/T204648) (owner: 10Eugene233) [13:21:47] 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update package.json, tests/selenium/wdio.conf.js, tests/selenium/README.md - https://phabricator.wikimedia.org/T210726 (10zeljkofilipin) [13:21:56] 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update package.json, tests/selenium/wdio.conf.js, tests/selenium/README.md - https://phabricator.wikimedia.org/T210726 (10zeljkofilipin) p:05Triage>03Normal [13:22:55] 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update package.json, tests/selenium/wdio.conf.js, tests/selenium/README.md - https://phabricator.wikimedia.org/T210726 (10zeljkofilipin) [13:25:33] 10MediaWiki-Database, 10DBA, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) [13:25:43] (03Merged) 10jenkins-bot: showProjectButton should call addJsConfigVars() directly instead of setExtensionData() [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/476465 (https://phabricator.wikimedia.org/T204648) (owner: 10Eugene233) [13:25:54] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona) I feel this is a cache problem, but I really cannot explain it (especially because it appeared suddenly, and not... [13:27:27] 10MediaWiki-Database, 10DBA, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) Not sure if to file this separately or not, but: we also purchased an extra host this time- We can make it work transparently through s... [13:31:17] 10FormWizard, 10FormWizard-Gadget: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Eugene233) [13:31:19] 10FormWizard, 10FormWizard-Gadget, 10Patch-For-Review: showProjectButton should call addJsConfigVars() directly instead of setExtensionData() - https://phabricator.wikimedia.org/T204648 (10Eugene233) 05Open>03Resolved Making this as resolved [13:37:51] 10CirrusSearch, 10Discovery-Search: Add a config var to control which clusters (replica) the saneitizer works on by default - https://phabricator.wikimedia.org/T210728 (10dcausse) [13:38:57] 10CirrusSearch, 10Discovery-Search (Current work): Add a config var to control which clusters (replica) the saneitizer works on by default - https://phabricator.wikimedia.org/T210728 (10dcausse) [13:39:24] 10CirrusSearch, 10Discovery-Search (Current work): Add a config var to control which clusters (replica) the saneitizer works on by default - https://phabricator.wikimedia.org/T210728 (10dcausse) p:05Triage>03Normal [13:43:49] 10CirrusSearch, 10Discovery-Search (Current work): Add a config var to control which clusters (replica) the sanitizer works on by default - https://phabricator.wikimedia.org/T210728 (10Aklapper) [13:45:40] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10jeblad) You may replace the title with whatever works for you. The mediawiki extension OATHAuth is in use on several wikis, and I observed this on Meta as I recall (?), but later I could not reproduce on Meta... [13:47:27] 10Design, 10Design-Research, 10VisualEditor, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog: EPIC: What are the current best UI practices for mobile editing? - https://phabricator.wikimedia.org/T201877 (10iamjessklein) [13:47:31] 10Design, 10Design-Research, 10Wikipedia-Android-App-Backlog, 10Wikipedia-iOS-App-Backlog, 10VisualEditor (Current work): Perform comparative analysis of focus techniques - https://phabricator.wikimedia.org/T208737 (10iamjessklein) 05Open>03Resolved I shared out the research with the team and this ca... [13:47:34] 10MediaWiki-Authentication-and-authorization: InvalidArgumentException from line 110 of includes/utils/MWCryptHash.php - https://phabricator.wikimedia.org/T141247 (10MaxSem) 05Open>03Resolved a:03MaxSem This code is gone since 1.31. [13:48:24] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 4 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Lea_Lacroix_WMDE) That's awesome, people w... [13:50:55] 10MediaWiki-General-or-Unknown: Blank Screen for MW 1.23/1.25 on FreeBSD 10.1 due to timeout of MWCryptRand.php mcrypt_create_iv - https://phabricator.wikimedia.org/T104426 (10MaxSem) 05Open>03Resolved We aren't using mcrypt for random number generation since 1.31. [13:51:52] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10iamjessklein) 👍this looks good to me. Thanks for figuring o... [13:54:32] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 4 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Pablo-WMDE) @Lea_Lacroix_WMDE Seems to be... [13:55:20] (03PS1) 10Sbisson: Welcome survey C: UI messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476505 (https://phabricator.wikimedia.org/T207717) [13:56:02] (03PS5) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [13:58:27] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, and 4 others: References aren't readable to unprivileged users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Ladsgroup) >>! In T186006#4785015, @Pablo-... [14:05:41] (03CR) 10Kosta Harlan: [C: 032] Welcome survey C: UI messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476505 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [14:06:45] (03CR) 10Rafidaslam: New version 1.2 (031 comment) [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [14:09:06] (03CR) 10jerkins-bot: [V: 04-1] Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [14:09:24] (03Merged) 10jenkins-bot: Welcome survey C: UI messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476505 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [14:09:49] (03PS1) 10Anomie: User: Bypass repeatable-read when creating an actor_id [core] - 10https://gerrit.wikimedia.org/r/476508 (https://phabricator.wikimedia.org/T210621) [14:10:34] 10MobileFrontend, 10Readers-Web-Backlog: Is there a future where we unify front ends - https://phabricator.wikimedia.org/T210694 (10Niedzielski) [14:11:07] (03CR) 10jenkins-bot: Welcome survey C: UI messages [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476505 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [14:12:45] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10Aklapper) > You may replace the title with whatever works for you. That first requires a task description that allows others to understand what you think is (or was) a problem. [14:16:41] (03PS2) 10Nathan fraignt: Change internationalize notifications [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) [14:17:40] (03PS3) 10Nathan fraignt: Change internationalize notifications [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) [14:18:31] (03CR) 10jerkins-bot: [V: 04-1] Change internationalize notifications [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) (owner: 10Nathan fraignt) [14:20:50] (03CR) 10Urbanecm: [C: 04-2] "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) (owner: 10Nathan fraignt) [14:21:32] (03PS4) 10Nathan fraignt: Change internationalize notifications [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) [14:27:18] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster - https://phabricator.wikimedia.org/T208808 (10Jdrewniak) Lookin... [14:29:05] (03CR) 10Daimona Eaytoy: Enable restricting certain groups from blocking certain groups. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [14:32:41] (03PS1) 10Pwirth: Remove unused common constants that have been used for extension registration in BS1* [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476516 [14:33:52] 10Google-Code-in-2018, 10WMCZ-Tracker: Users created by addexampledata comment don't have TrackerPreferences object - https://phabricator.wikimedia.org/T210354 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/5124527819325440/. [14:33:54] 10WMCZ-Tracker: addexampledata command doesn't set the password correctly - https://phabricator.wikimedia.org/T210352 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/5124527819325440/. [14:34:22] 10Google-Code-in-2018, 10WMCZ-Tracker: addexampledata command doesn't set the password correctly - https://phabricator.wikimedia.org/T210352 (10Urbanecm) [14:34:53] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Image license info often displays the 'uploader unknown' incorrectly - https://phabricator.wikimedia.org/T210544 (10Dbrant) [14:35:05] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Image license info often displays the 'uploader unknown' incorrectly - https://phabricator.wikimedia.org/T210544 (10Dbrant) [14:35:20] (03PS25) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [14:39:19] (03CR) 10Raimond Spekking: [C: 031] Add PHP entry point with deprecation warning [extensions/Lockdown] - 10https://gerrit.wikimedia.org/r/467467 (https://phabricator.wikimedia.org/T206806) (owner: 10MarcoAurelio) [14:39:59] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/475285 (owner: 10ItSpiderman) [14:40:09] 10Wikipedia-Android-App-Backlog, 10Chinese-Sites: TOC and language problems on Chinese article - https://phabricator.wikimedia.org/T203806 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [14:40:41] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] TBC: MobileFrontend breaks Special:JavaScriptTest - https://phabricator.wikimedia.org/T210680 (10Niedzielski) 05Open>03Invalid My mistake! I had an old Core. [14:41:25] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Flag icons do not show in certain article - https://phabricator.wikimedia.org/T201884 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [14:42:10] 04(no projects): Commons upload fails for a 18MB file - https://phabricator.wikimedia.org/T210730 (10ravl) [14:45:12] (03CR) 10Rafidaslam: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472528 (https://phabricator.wikimedia.org/T203979) (owner: 10Rafidaslam) [14:45:18] (03CR) 10jerkins-bot: [V: 04-1] tracker/tests.py: Add some unittests for the notification part [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472528 (https://phabricator.wikimedia.org/T203979) (owner: 10Rafidaslam) [14:46:03] 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user - https://phabricator.wikimedia.org/T210732 (10hashar) [14:46:26] 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user - https://phabricator.wikimedia.org/T210732 (10hashar) [14:48:45] 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10Epic, 10Patch-For-Review: Deploy refactored actor storage - https://phabricator.wikimedia.org/T188327 (10hashar) CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.... [14:48:54] (03PS1) 10Pwirth: Move \BSDebug to \BlueSpice\Debug [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476518 [14:49:21] 10Wikipedia-Android-App-Backlog, 10Patch-For-Review, 10Technical-Debt, 10WorkType-Maintenance: Make dev settings show actual setting name, instead of dev string. - https://phabricator.wikimedia.org/T109618 (10Dbrant) 05Open>03Resolved a:03Dbrant [14:49:22] (03PS2) 10Pwirth: Move \BSDebug to \BlueSpice\Debug [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476518 [14:49:23] 10MediaWiki-extensions-ParserFunctions, 10Chinese-Sites: Magic word "PAGESINCATEGORY" with parameter "pages" returns negative value on zhwikibooks - https://phabricator.wikimedia.org/T210733 (10WhitePhosphorus) [14:50:49] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Banyek) Do you need anything from our side this moment @Ladsgroup ? [14:50:51] (03PS1) 10Daimona Eaytoy: [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 [14:52:01] (03Abandoned) 10Dbrant: create EventLogging dev setting [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/403457 (https://phabricator.wikimedia.org/T167314) (owner: 10Yashasvi) [14:52:11] 10MediaWiki-Database, 10DBA, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Anomie) > Those first column of IPs (10.64.0.12, 10.64.32.72, 10.64.48.128) are not really IPs but sharding keys. Ugh, that's awful. > Will tha... [14:53:10] (03PS2) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [14:53:43] 10GeoCrumbs, 10Wikimedia-production-error: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given - https://phabricator.wikimedia.org/T210734 (10h... [14:54:06] 10GeoCrumbs, 10Wikimedia-production-error: incubatorwiki: PHP Fatal Error from line 143 of /srv/mediawiki/php-1.33.0-wmf.6/extensions/GeoCrumbs/GeoCrumbs.class.php: Argument 1 passed to GeoCrumbs::getParentRegion() must be an instance of ParserOutput, bool given - https://phabricator.wikimedia.org/T210734 (10h... [14:54:38] (03PS3) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [14:55:03] 10Core Platform Team Kanban, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user - https://phabricator.wikimedia.org/T210732 (1... [14:55:24] 10Core Platform Team Kanban, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an actor for a usable name that is not an existing user - https://phabricator.wikimedia.org/T210732 (1... [14:56:02] (03CR) 10Robert Vogel: "@Raimond: Thanks for the hint. I thought about this and came to the conclusion thta the old description was sufficient. Therefore I decide" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [14:56:14] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Ladsgroup) >>! In T209525#4785174, @Banyek wrote: > Do you need anything from our side this mo... [14:56:38] 10Research, 10CommRel-Specialists-Support (Oct-Dec-2018), 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Elitre) >>! In T210085#4778125, @bmansurov wrote: > @Elitre yes, that's correct. Sorry to be asking from time to time, but I gave people your email, so I can't t... [14:57:05] (03CR) 10jerkins-bot: [V: 04-1] Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [14:57:10] 10Wikipedia-Android-App-Backlog: Convert explicit setting of div margins to media queries - https://phabricator.wikimedia.org/T134283 (10Dbrant) 05Open>03Invalid [14:57:28] 10MediaWiki-Database, 10DBA, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) > Ugh, that's awful. To clarify the context- this was done in a rush with a record patch the day before the first datacenter switch, so... [14:57:37] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster - https://phabricator.wikimedia.org/T208808 (10Jdrewniak) Judgin... [14:57:42] (03PS4) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [14:57:44] (03CR) 10Pwirth: [V: 032 C: 032] quick typo fix [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/472985 (owner: 10Pboehm) [14:58:00] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Display subtopics in topic_list as well, with some indentation to indicate hiearchy - https://phabricator.wikimedia.org/T203472 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/6078859385503744/ and I will mentor it. [14:58:02] (03PS1) 10Pwirth: quick typo fix [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/476520 [14:58:07] (03CR) 10Pwirth: [C: 032] quick typo fix [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/476520 (owner: 10Pwirth) [14:58:18] (03CR) 10jerkins-bot: [V: 04-1] Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [14:58:37] 10Wikipedia-Android-App-Backlog, 10Spike: Identify memory hogs - https://phabricator.wikimedia.org/T158361 (10Dbrant) 05Open>03Resolved a:03Dbrant [14:59:32] (03PS5) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [14:59:53] (03PS6) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [15:00:42] 10Wikipedia-Android-App-Backlog, 10wikimedia-page-library-tshirt: Integrate first paragraph relocation on Android - https://phabricator.wikimedia.org/T165409 (10Dbrant) 05Open>03Resolved a:03Dbrant Pretty sure this is done. [15:01:39] (03PS2) 10Daimona Eaytoy: [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 [15:02:23] (03CR) 10jerkins-bot: [V: 04-1] Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [15:02:35] (03CR) 10jerkins-bot: [V: 04-1] quick typo fix [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/476520 (owner: 10Pwirth) [15:04:49] (03PS7) 10Sbisson: Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) [15:04:50] 10Wikipedia-Android-App-Backlog: Explore use of different fonts in the Android app - https://phabricator.wikimedia.org/T105086 (10Dbrant) 05Open>03Invalid [15:04:52] 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) [15:04:58] 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) p:05Triage>03Unbreak! [15:05:16] 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) [15:06:39] 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Surface page issues on articles more prominently to Android app users - https://phabricator.wikimedia.org/T187206 (10Dbrant) 05Open>03Resolved a:03Dbrant [15:06:42] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [15:07:12] 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) [15:07:45] (03PS3) 10Daimona Eaytoy: [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 [15:07:54] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10Performance-Team-notice, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) This is not on performance, they may be able to give some ideas on how to move forwar... [15:08:29] 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) [15:08:43] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) [15:09:59] (03CR) 10jerkins-bot: [V: 04-1] quick typo fix [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/476520 (owner: 10Pwirth) [15:10:39] 10MobileFrontend, 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10hashar) I think it is related to #mobilefrontend the few stacktraces I have looked at all comes from it. And apparently from the watchl... [15:11:01] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Display subtopics in topic_list as well, with some indentation to indicate hiearchy - https://phabricator.wikimedia.org/T203472 (10Shreyasminocha) a:03Shreyasminocha [15:11:45] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Drop change_tag.ct_tag column - https://phabricator.wikimedia.org/T194163 (10Ladsgroup) 05Open>03Resolved Beta cluster: ` MariaDB [enwiki]> select * from change_tag limit 5; +... [15:11:48] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata, 10MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), and 5 others: Normalize change tag schema - https://phabricator.wikimedia.org/T185355 (10Ladsgroup) [15:14:03] (03CR) 10Pwirth: [V: 032 C: 032] quick typo fix [extensions/BlueSpiceCountThings] (REL1_31) - 10https://gerrit.wikimedia.org/r/476520 (owner: 10Pwirth) [15:15:19] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Marostegui) Which schema change? [15:16:51] 10MediaWiki-extensions-JsonConfig, 10Wikimedia-production-error: JsonConfig api emits PHP Warning "API call had warnings trying to get remote JsonConfig" - https://phabricator.wikimedia.org/T204774 (10hashar) [15:17:42] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Ladsgroup) >>! In T209525#4785305, @Marostegui wrote: > Which schema change? `DROP TABLE tag... [15:18:07] (03PS8) 10Sbisson: Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) [15:18:16] 10Wikipedia-Android-App-Backlog: Copy text in a mobile app (in Czech) - https://phabricator.wikimedia.org/T192151 (10Dbrant) 05Open>03declined Closing as too device-specific. [15:18:45] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Marostegui) >>! In T209525#4785310, @Ladsgroup wrote: >>>! In T209525#4785305, @Marostegui wro... [15:20:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 (owner: 10Daimona Eaytoy) [15:20:38] (03PS4) 10Daimona Eaytoy: [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 [15:21:28] 10MediaWiki-extensions-Page_Forms, 10WikiEditor: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page - https://phabricator.wikimedia.org/T103772 (10cicalese) I created https://sandbox.semantic-mediawiki.org/wiki/Form:TestWikiEditor that you... [15:21:43] 10MediaWiki-extensions-JsonConfig, 10Maps (Kartographer), 10Wikimedia-production-error: JsonConfig api emits PHP Warning "API call had warnings trying to get remote JsonConfig" - https://phabricator.wikimedia.org/T204774 (10hashar) Seems Kartographer lacks a rvslot when doing the query: ` name=includes/Simp... [15:22:22] 04(no projects): schema:about URLs in Wikidata are encoded (mangled) - https://phabricator.wikimedia.org/T210738 (10VladimirAlexiev) [15:23:09] (03PS5) 10Daimona Eaytoy: [WIP] Add config for Selenium [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 [15:23:15] (03PS1) 10DCausse: Properly test the "classic" profile name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476526 (https://phabricator.wikimedia.org/T208248) [15:23:52] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10WorkType-Maintenance: Android app ignores markup requesting style change to serif fonts - https://phabricator.wikimedia.org/T106960 (10Dbrant) 05Open>03Invalid Please reopen if still an issue. [15:24:12] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10Jdlrobson) [15:24:39] 10MediaWiki-Change-tagging, 10Blocked-on-schema-change, 10User-Ladsgroup: Drop change_tag.ct_tag column in production - https://phabricator.wikimedia.org/T210713 (10Marostegui) I will start with this after the code freeze. I might alter an slave in enwiki earlier to see how this goes, as `change_tag` is a c... [15:24:43] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476519 (owner: 10Daimona Eaytoy) [15:25:13] (03PS1) 10Robert Vogel: Refactor to LDAPAuthentication2 [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/476527 [15:25:30] 10Discovery-Search, 10Patch-For-Review, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10dcausse) Thanks for the investigations! See the attached patch for the cause. [15:25:32] 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10hashar) p:05Triage>03Unbreak! [15:25:52] 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10hashar) [15:26:08] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [BUG] Leaving the gallery loses an image - https://phabricator.wikimedia.org/T145802 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [15:26:10] (03Abandoned) 10Pwirth: Add missing Texts to CountCharacters Inspector [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/461953 (owner: 10Pboehm) [15:26:42] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Wikipedia Android - Bug - {{multiple images}} does not open the tapped image as expected - https://phabricator.wikimedia.org/T142837 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [15:26:47] (03CR) 10jerkins-bot: [V: 04-1] Refactor to LDAPAuthentication2 [extensions/LDAPAuthentication2] - 10https://gerrit.wikimedia.org/r/476527 (owner: 10Robert Vogel) [15:28:14] 10Discovery-Search (Current work), 10Patch-For-Review, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10dcausse) [15:28:31] 10Wikimedia-production-error: Cannot create actor ID for user_id=156 user_name=Sz-iwbot - https://phabricator.wikimedia.org/T210740 (10hashar) [15:28:49] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [15:29:02] o/ [15:29:27] o/ takidelfin [15:29:30] wow... My message was faster than 'takidelfin joined' message [15:29:36] (03PS7) 10Robert Vogel: Swap code with MWStake "LDAPAuthorization" [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 [15:29:47] 10Core Platform Team Kanban, 10Wikimedia-production-error: Cannot create actor ID for user_id=156 user_name=Sz-iwbot - https://phabricator.wikimedia.org/T210740 (10hashar) [15:30:02] hi takidelfin and refeed [15:30:06] o/ [15:30:12] hi shreyasminocha [15:30:45] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) So given the fact that we started with all the pc partially cold after switching back from codfw to eqiad (due... [15:31:39] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476526 (https://phabricator.wikimedia.org/T208248) (owner: 10DCausse) [15:31:40] * shreyasminocha is looking forward to vacations beginning on the second [15:31:50] * shreyasminocha is not looking forward to his exams on the first and second [15:32:05] 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Wikimedia-Site-requests, 10User-notice, 10Wikimedia-maintenance-script-run: Run maintenance/cleanupUsersWithNoId.php on all wikis - https://phabricator.wikimedia.org/T181731 (10hashar) [15:32:08] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10hashar) 05Resolved>03Open Based on Brad comment at T2... [15:32:10] 10Discovery-Search (Current work), 10Patch-For-Review, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10dcausse) to clarify the bug was affecting all users having set "classic" in their search preferences. [15:32:32] 10MediaWiki-Special-pages, 10DBA, 10Datacenter-Switchover-2018: Significant (17x) increase in time spent by updateSpecialPages.php script since datacenter switch over updating commons special pages - https://phabricator.wikimedia.org/T206592 (10Marostegui) @Bawolff did you have a moment to look into the valu... [15:32:35] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10pmiazga) a:03pmiazga [15:32:52] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10WorkType-Maintenance: Hyperlink click area is too large - https://phabricator.wikimedia.org/T103950 (10Dbrant) [15:32:54] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10WorkType-Maintenance: Incorrect link shown as highlighted when long-pressing on a link in close proximity to another link - https://phabricator.wikimedia.org/T171517 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [15:34:15] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Banyek) >>! In T210725#4785416, @Marostegui wrote: > So given the fact that we started with all the pc partially cold after... [15:34:32] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10Anomie) It looks like it's just that the need to run popu... [15:34:47] (03PS7) 10Jdlrobson: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 [15:34:53] 10Research, 10CommRel-Specialists-Support (Oct-Dec-2018), 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10bmansurov) @Elitre thanks! It looks like we've got the data we need. I think we can mark this task as complete. Thanks everyone for your help! [15:35:14] (03PS4) 10Takidelfin: Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 [15:36:01] 10MediaWiki-extensions-FlaggedRevs: Pages are sometimes not auto-reviewed when moved from user namespace to article namespace on dewiki - https://phabricator.wikimedia.org/T210519 (10Bjs) The first sentence above of course applies only if the user has the corresponding rights, which I have. I also checked other... [15:36:14] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10Ladsgroup) We can't run populateSitesTable.php on prod n... [15:36:59] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10Anomie) I just ran it on several wiktionaries and it seem... [15:38:47] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10Ladsgroup) It might cause fatals here and there. Proceed... [15:38:54] (03CR) 10Krinkle: Swap code with MWStake "LDAPAuthorization" (031 comment) [extensions/LDAPAuthorization] - 10https://gerrit.wikimedia.org/r/476455 (owner: 10Robert Vogel) [15:40:38] 10MediaWiki-Special-pages, 10DBA, 10Datacenter-Switchover-2018: Significant (17x) increase in time spent by updateSpecialPages.php script since datacenter switch over updating commons special pages - https://phabricator.wikimedia.org/T206592 (10Marostegui) looks like this is back to normal values: ` root@mwm... [15:40:40] 10Wikipedia-Android-App-Backlog: [BUG] Image display issue when more than one images are displayed horizontally - https://phabricator.wikimedia.org/T188808 (10Dbrant) 05Open>03Resolved a:03Dbrant Please reopen if still an issue. [15:41:57] (03CR) 10Krinkle: User: Bypass repeatable-read when creating an actor_id (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476508 (https://phabricator.wikimedia.org/T210621) (owner: 10Anomie) [15:42:48] 10MobileFrontend, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10pmiazga) It's caused by https://github.com/wikimedia/mediawiki-extens... [15:45:36] (03CR) 10Krinkle: "I've not seen "CannotCreateActorException" before the ref'd task. Is this a regression from a recent commit or something we just hadn't no" [core] - 10https://gerrit.wikimedia.org/r/476508 (https://phabricator.wikimedia.org/T210621) (owner: 10Anomie) [15:46:07] (03PS8) 10Pboehm: Add new DefaultRobotPolicy [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 [15:47:27] (03CR) 10Urbanecm: [C: 032] Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 (owner: 10Takidelfin) [15:47:47] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10Pginer-WMF) >>! In T210530#4779732, @leila wrote: > we'd like to understand what kind of input/output would be interesting to Content Translation (even if it's not immediately used by the tool). The data that we have, f... [15:48:16] (03PS6) 10Krinkle: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (https://phabricator.wikimedia.org/T210671) (owner: 10TheDJ) [15:48:19] (03Merged) 10jenkins-bot: Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 (owner: 10Takidelfin) [15:49:19] 10MediaWiki-Change-tagging, 10Wikidata, 10MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)), 10MW-1.27-release-notes, and 3 others: Performance issues with tags - https://phabricator.wikimedia.org/T91535 (10Ladsgroup) [15:49:32] 10CommRel-Specialists-Support (Oct-Dec-2018): Specialist support for 2018/19 password strengthening project - https://phabricator.wikimedia.org/T205931 (10CKoerner_WMF) Project page is now on-wiki: https://www.mediawiki.org/wiki/Wikimedia_Security_Team/Password_strengthening_2019 Next up the announcement on-wiki. [15:49:34] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata, 10MW-1.32-notes (WMF-deploy-2018-05-15 (1.32.0-wmf.4)), and 4 others: Normalize change tag schema - https://phabricator.wikimedia.org/T185355 (10Ladsgroup) 05Open>03Resolved Almost a year now. Everything is done 🥳 🥳🥳🥳 (We need to apply the... [15:50:42] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [15:50:51] (03PS1) 10Robert Vogel: [WiP] Improve AllGroupSync [extensions/LDAPGroups] - 10https://gerrit.wikimedia.org/r/476530 [15:51:47] 10Android-app-feature-Feeds, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Final design tweaks in News card/activity - https://phabricator.wikimedia.org/T140385 (10Dbrant) 05Open>03Resolved a:03Dbrant [15:51:54] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 (owner: 10Pboehm) [15:52:08] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_32) - 10https://gerrit.wikimedia.org/r/476531 [15:52:15] (03CR) 10jerkins-bot: [V: 04-1] [WiP] Improve AllGroupSync [extensions/LDAPGroups] - 10https://gerrit.wikimedia.org/r/476530 (owner: 10Robert Vogel) [15:52:17] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_31) - 10https://gerrit.wikimedia.org/r/476532 [15:52:21] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_30) - 10https://gerrit.wikimedia.org/r/476533 [15:52:27] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_29) - 10https://gerrit.wikimedia.org/r/476534 [15:52:33] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_28) - 10https://gerrit.wikimedia.org/r/476535 [15:52:39] (03PS1) 10Pwirth: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_27) - 10https://gerrit.wikimedia.org/r/476536 [15:53:08] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_27) - 10https://gerrit.wikimedia.org/r/476536 (owner: 10Pwirth) [15:53:11] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_28) - 10https://gerrit.wikimedia.org/r/476535 (owner: 10Pwirth) [15:53:14] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_29) - 10https://gerrit.wikimedia.org/r/476534 (owner: 10Pwirth) [15:53:18] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_30) - 10https://gerrit.wikimedia.org/r/476533 (owner: 10Pwirth) [15:53:21] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_31) - 10https://gerrit.wikimedia.org/r/476532 (owner: 10Pwirth) [15:53:24] (03CR) 10Pwirth: [C: 032] Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_32) - 10https://gerrit.wikimedia.org/r/476531 (owner: 10Pwirth) [15:56:19] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 (owner: 10Pboehm) [15:56:58] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_27) - 10https://gerrit.wikimedia.org/r/476536 (owner: 10Pwirth) [15:59:17] 10Wikipedia-Android-App-Backlog: Consider disabling installation to external media - https://phabricator.wikimedia.org/T141000 (10Dbrant) 05Open>03Resolved a:03Dbrant Updated the Android FAQ. [15:59:47] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_28) - 10https://gerrit.wikimedia.org/r/476535 (owner: 10Pwirth) [15:59:51] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_29) - 10https://gerrit.wikimedia.org/r/476534 (owner: 10Pwirth) [16:00:26] 10MediaWiki-Internationalization, 10Patch-For-Review: Image alignment dropdown options in WikiEditor are not localized correctly in Chechen wikipedia - https://phabricator.wikimedia.org/T196784 (10TheDJ) @Nikerabbit maybe those pages should be deleted then ? To avoid people accidentally using them ? [16:01:57] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site(s) - https://phabricator.wikimedia.org/T154813 (10Dbrant) 05Open>03Resolved a:03Dbrant Our internal logic will now re-login the user (silently) if we detect that they've been logged out. [16:02:16] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_30) - 10https://gerrit.wikimedia.org/r/476533 (owner: 10Pwirth) [16:02:18] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_31) - 10https://gerrit.wikimedia.org/r/476532 (owner: 10Pwirth) [16:04:38] (03PS1) 10Pmiazga: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476537 (https://phabricator.wikimedia.org/T210737) [16:07:07] (03Merged) 10jenkins-bot: Add new DefaultRobotPolicy [extensions/AdvancedMeta] (REL1_32) - 10https://gerrit.wikimedia.org/r/476531 (owner: 10Pwirth) [16:08:04] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Imarlier) >>! In T210725#4785435, @Banyek wrote: >>>! In T210725#4785416, @Marostegui wrote: >> So given the fact that we s... [16:12:04] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476540 [16:12:16] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476540 (owner: 10Dbrant) [16:12:19] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [16:12:36] (03CR) 10Jdrewniak: [C: 032] Fix `id` for correct label association [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [16:13:42] Urbanecm: umm, I can't create a ticket in my Tracker instance ;-; [16:13:53] What does mean "can't"? [16:14:16] I am not able to create a ticket [16:14:45] Maybe it is related to: Uncaught TypeError: $(...).DataTable is not a function [16:14:48] ? [16:14:49] (03Merged) 10jenkins-bot: Fix `id` for correct label association [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [16:15:17] When I try to create a ticket, it returns that 'name' field is required [16:16:24] 10Android-app-feature-Compilations, 10Wikipedia-Android-App-Backlog, 10android-task-estimation: Allow users in restricted locations to access the Wikipedia app with offline compilation/s - https://phabricator.wikimedia.org/T165744 (10Dbrant) 05Open>03Invalid [16:16:34] (03CR) 10Jdrewniak: [C: 032] QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [16:16:36] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Page history divider is too narrow - https://phabricator.wikimedia.org/T210745 (10Niedzielski) [16:17:06] API returns '25' [16:18:23] 10Design, 10VisualEditor (Current work): Draft design brief for section editing feature - https://phabricator.wikimedia.org/T208759 (10iamjessklein) I shared and had a productive conversation about this [[ https://docs.google.com/presentation/d/10R0sT1CKgJ3n_QOZPwha7pkkoJmFKSjK2JcR4FBdgQQ/edit#slide=id.g47d5ac... [16:18:26] 10Audiences-QA, 10android-app-feature-notifications, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): [QA only] Perform exploratory testing of the Notifications in Android app - https://phabricator.wikimedia.org/T202911 (10Dbrant) 05Open>03Resolved [16:18:29] 10android-app-feature-notifications, 10Epic, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [EPIC] Add Echo Notifications relevant to New Editor encouragement to the Android app - https://phabricator.wikimedia.org/T201931 (10Dbrant) [16:18:30] 10Android-app-feature-Navigation, 10Epic, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): [EPIC] Improve app and article navigation - https://phabricator.wikimedia.org/T195264 (10Dbrant) [16:18:32] 10Android-app-feature-Navigation, 10Epic, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): Update the TOC to include section hierarchy: As a user of the Android app I want to be able to see section hierarchy reflecte... - https://phabricator.wikimedia.org/T209497 [16:19:05] 10MinervaNeue, 10Readers-Web-Backlog (Design): Last edited history arrow, icon, and cell should be clickable - https://phabricator.wikimedia.org/T163853 (10Niedzielski) [16:19:12] 10Android-app-Bugs, 10Chinese-Sites, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Showing incorrect cache contents when switching Chinese variants - https://phabricator.wikimedia.org/T191550 (10Dbrant) 05Open>03Resolved [16:19:14] 10android-app-feature-notifications, 10Epic, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [EPIC] Add Echo Notifications relevant to New Editor encouragement to the Android app - https://phabricator.wikimedia.org/T201931 (10Dbrant) [16:19:16] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Create setting to explicitly enable/disable Notification polling - https://phabricator.wikimedia.org/T201429 (10Dbrant) 05Open>03Resolved [16:19:20] 10Design, 10VisualEditor (Current work): Draft design brief for section editing feature - https://phabricator.wikimedia.org/T208759 (10iamjessklein) 05Open>03Resolved [16:19:26] 10Android-app-Bugs, 10Patch-For-Review, 10Regression, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] [REGRESSION] Incorrect font styling on text-fields in the reading list name and description dialog - https://phabricator.wikimedia.org/T201030 (10Dbrant) 05Open>03Re... [16:19:28] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Remove articles from reading lists does not remove the articles' offline data - https://phabricator.wikimedia.org/T201879 (10Dbrant) 05Open>03Resolved [16:19:31] 10Android-app-Bugs, 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Get invisible lead image when continuing open articles from trending list - https://phabricator.wikimedia.org/T208910 (10Dbrant) 05Open>03Resolved [16:19:33] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add "Undo close tab" feature to the app - https://phabricator.wikimedia.org/T158082 (10Dbrant) 05Open>03Resolved [16:19:36] 10MinervaNeue, 10Readers-Web-Backlog (Design): Last edited history arrow, icon, and cell should be clickable - https://phabricator.wikimedia.org/T163853 (10Niedzielski) a:05Nirzar>03None [16:19:38] 10Android-app-feature-Offline, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Provide clear indication of which articles in History are available whilst offline - https://phabricator.wikimedia.org/T157448 (10Dbrant) 05Open>03Resolved [16:19:40] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Show complete license info for images shown in full screen - https://phabricator.wikimedia.org/T164957 (10Dbrant) 05Open>03Resolved [16:19:42] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Onboarding language add/edit button hidden on 4" devices - https://phabricator.wikimedia.org/T198263 (10Dbrant) 05Open>03Resolved [16:21:20] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Crash when tapping on images from portals - https://phabricator.wikimedia.org/T210041 (10Dbrant) 05Open>03Resolved a:03Dbrant [16:22:33] (03PS1) 10Anomie: Fix RevisionDeleteUser rev_actor query for MySQL [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) [16:22:52] "POST /ticket/new/ HTTP/1.1" 200 27306 [16:23:46] Urbanecm: I think it is frontend problem :/ Maybe something is wrong with my installation? [16:24:02] (some info above my last message) [16:24:38] 'name' field is required [16:25:07] (03Merged) 10jenkins-bot: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [16:25:25] (03PS2) 10Anomie: Fix RevisionDeleteUser rev_actor query for MySQL [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) [16:26:33] :( [16:26:55] 10Core Platform Team Kanban, 10Patch-For-Review, 10Wikimedia-production-error: Cannot create actor ID for user_id=156 user_name=Sz-iwbot - https://phabricator.wikimedia.org/T210740 (10Anomie) [16:27:24] (03PS3) 10MarcoAurelio: Fix composer package name to match conventions [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [16:28:26] (03PS2) 10Anomie: User: Bypass repeatable-read when creating an actor_id [core] - 10https://gerrit.wikimedia.org/r/476508 (https://phabricator.wikimedia.org/T210621) [16:30:17] (03PS1) 10Michael Große: Update upstream wikimedia eslint config [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/476544 (https://phabricator.wikimedia.org/T209932) [16:30:28] (03CR) 10Jdrewniak: [C: 032] Combine input and search button on intriniscally tied together widget [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/460185 (https://phabricator.wikimedia.org/T197195) (owner: 10VolkerE) [16:30:34] (03CR) 10SBassett: [C: 031] "Looks sane, test coverage fine, though I don't have a great way to locally test the performance of the subquery removal atm." [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [16:30:59] (03CR) 10jenkins-bot: QA: Browser tests should limit write operations [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476437 (owner: 10Jdlrobson) [16:31:12] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476540 (owner: 10Dbrant) [16:31:25] (03PS1) 10DCausse: Allow setting the list of cluster to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) [16:31:58] takidelfin, sorry, I'm in a rush now. Can it wait for 2 hours? [16:32:19] (03Merged) 10jenkins-bot: Combine input and search button on intriniscally tied together widget [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/460185 (https://phabricator.wikimedia.org/T197195) (owner: 10VolkerE) [16:33:33] (03CR) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476540 (owner: 10Dbrant) [16:34:03] Urbanecm: ok [16:34:09] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10WorkType-Maintenance: Android app ignores markup requesting style change to serif fonts - https://phabricator.wikimedia.org/T106960 (10DavidEppstein) 05Invalid>03Open This issue still happens in the current Android app. E.g. view the Wikipedia articl... [16:34:15] (03CR) 10jerkins-bot: [V: 04-1] Allow setting the list of cluster to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [16:34:19] (03CR) 10BryanDavis: [C: 04-1] Clarify that the default Help link in the sidebar is about MediaWiki itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) (owner: 10Aklapper) [16:34:57] (03CR) 10jerkins-bot: [V: 04-1] Allow setting the list of cluster to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [16:35:05] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [16:35:22] (03CR) 10Michael Große: "This change is ready for review." [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/476544 (https://phabricator.wikimedia.org/T209932) (owner: 10Michael Große) [16:36:21] (03PS2) 10DCausse: Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) [16:37:44] James_F: btw, is this branch okay to remove? https://github.com/wikimedia/stylelint-config-wikimedia/tree/bump-stylelint [16:37:56] seems to be ahead of master, but with commits similar to ones once merged [16:38:17] (03PS4) 10Yaron Koren: Fix composer package name to match conventions [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [16:39:32] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Tgr) >>! In T189641#4784525, @Joe wrote: > While doing this as an external service is just my preference,... [16:39:36] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) The multiple keys is ok, we already do that for the External Storage, my worry is not that, as much as the migrati... [16:39:50] (03CR) 10jerkins-bot: [V: 04-1] Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [16:40:23] 10Browser-Support-Internet-Explorer, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: IE11: AfC - sort order drop down displays all options for any filter state selection - https://phabricator.wikimedia.org/T205669 (10Etonkovidova) 05Open>03Resolved [16:40:55] (03CR) 10Krinkle: [C: 031] "LGTM. The toolbar shows up after initial render regardless. So this doesn't really add additional FOUC or reflows. Rather, it changes the " [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (https://phabricator.wikimedia.org/T210671) (owner: 10TheDJ) [16:41:17] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10ovasileva) p:05Normal>03H... [16:42:09] (03CR) 10Anomie: "> I've not seen "CannotCreateActorException" before the ref'd task. Is this a regression from a recent commit or something we just hadn't " (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476508 (https://phabricator.wikimedia.org/T210621) (owner: 10Anomie) [16:42:54] (03CR) 10Krinkle: textSelection: Use execcommand to replace text (031 comment) [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) (owner: 10TheDJ) [16:43:15] (03PS3) 10DCausse: Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) [16:44:46] Hey guys, can someone check out my GCI task and gerrit review? GCI task: https://codein.withgoogle.com/dashboard/task-instances/5107080135442432/ Gerrit review: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CollaborationKit/+/476373 [16:45:31] (03CR) 10Dbrant: [C: 04-1] Fix: Remove extra indentation in Settings without overriding properties (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [16:46:49] (03CR) 10Jcrespo: "I can attest the performance difference on WMF production in the positive way- of course mileage may vary from version to version, but thi" [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [16:48:19] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [16:49:21] Hello? [16:50:20] pterp: i'm not a mentor, but you really should replace spaces with tabs [16:50:36] do a find-replace operation maybe [16:50:37] 10ContentTranslation: CX2: Unable to type diacritics in the translation - https://phabricator.wikimedia.org/T209874 (10He7d3r) I don't get it: why would I need to change a configuration in the Ubuntu to make something work in ContentTranslation, if it already works in other places? And why would this happen inte... [16:50:42] I'll see what I can do [16:50:54] or temporarily change your editor's settings [16:51:05] or use a different editor temporarily [16:51:16] which editor do you use btw? [16:51:19] Atom [16:51:38] i think you can set indentation settings on a folder-by-folder basis in atom [16:53:04] (03PS1) 10Esanders: VE: Convert to SaveErrorHandler [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/476549 [16:53:13] (03CR) 10SBassett: [C: 032] Fix RevisionDeleteUser rev_actor query for MySQL [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [16:54:52] 10MediaWiki-Cache, 10AbuseFilter, 10Core Platform Team, 10Wikimedia-production-error: Throttling isn't counted at all for filters using it - https://phabricator.wikimedia.org/T210709 (10Daimona) Little update: this still isn't working. I tried to re-enable the filter, and the first edit was caught. I also... [16:55:35] (03PS4) 10Pjht: Replace jslint and jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) [16:55:55] shreyasminocha: Replaced the spaces with tabs [16:57:44] pterp: apart from that it lgtm [16:57:46] shreyasminocha: Also, I think that once someone who was not a mentor for my task approved it, so you might be able to do it. [16:58:02] they must be another mentor [16:58:07] i'm not a mentor at all [16:58:21] but i can add a +1 on your patch [16:59:47] pterp: small thing: is the `globals` key in .eslintrc necessary if all globals are set to false? [16:59:51] i may be wrong [16:59:56] I dont know. [17:00:17] where did you get it from? [17:00:26] (03CR) 10Niedzielski: [C: 032] RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476537 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [17:00:44] https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Linting [17:01:06] Ok. Also, this patch has been sitting around for awhile from my first Wikimedia task, can you tell the bot to merge it in? It was approved before, but had a few style problems, and nobody's done anything with it once i fixed the problems. This is it: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/475333 [17:02:51] (03CR) 10Shreyasminocha: "recheck" [core] - 10https://gerrit.wikimedia.org/r/475333 (https://phabricator.wikimedia.org/T123228) (owner: 10Pjht) [17:04:14] pterp: https://eslint.org/docs/user-guide/configuring#specifying-globals [17:04:29] apparently setting a global to false ensures one can't write to them but only read [17:04:32] so that lgtm [17:04:47] (03CR) 10Shreyasminocha: [C: 031] Replace jslint and jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [17:05:00] What does lgtm mean? [17:05:07] "looks good to me" [17:05:13] basically, gerrit has four things: [17:05:20] -2 = patch rejected [17:05:25] -1 = more changes needed [17:05:33] +1 = lgtm, but someone else must approve [17:05:40] +2 = merged. [17:05:50] (03CR) 10Jon Harald Søby: "Shouldn't this file have the extension .php?" [vagrant] - 10https://gerrit.wikimedia.org/r/474482 (https://phabricator.wikimedia.org/T209089) (owner: 10John Erling Blad) [17:05:55] i don't have the right to +2, but i can +1, like i just did [17:06:07] 10MediaWiki-extensions-FlaggedRevs: Pages are sometimes not auto-reviewed when moved from user namespace to article namespace on dewiki - https://phabricator.wikimedia.org/T210519 (10Bjs) additional information: creating a new article in the article namespace is auto-reviewed. Example: https://de.wikipedia.or... [17:06:30] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/476559 (owner: 10L10n-bot) [17:06:45] you'll have to wait for legoktm to +2 your patch before your task can be accepted [17:06:58] Ok [17:07:51] (03Merged) 10jenkins-bot: Fix RevisionDeleteUser rev_actor query for MySQL [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [17:07:58] (03PS2) 10Sharvaniharan: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) [17:08:05] (03CR) 10Jon Harald Søby: [C: 031] "> Shouldn't this file have the extension .php?" [vagrant] - 10https://gerrit.wikimedia.org/r/474482 (https://phabricator.wikimedia.org/T209089) (owner: 10John Erling Blad) [17:08:12] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Anomie) >>! In T210725#4785678, @jcrespo wrote: > Alternatively, we can setup 4 hosts actively, but I think the sharding fu... [17:08:31] (03CR) 10Sharvaniharan: Fix: Remove extra indentation in Settings without overriding properties (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [17:08:40] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Joe) >>! In T189641#4785677, @Tgr wrote: >>>! In T189641#4784525, @Joe wrote: >> While doing this as an e... [17:08:51] (03PS1) 10Anomie: Fix RevisionDeleteUser rev_actor query for MySQL [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476566 (https://phabricator.wikimedia.org/T210628) [17:09:36] (03CR) 10jerkins-bot: [V: 04-1] Replace jslint and jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [17:09:39] (03CR) 10Anomie: [C: 032] "Backporting fix" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476566 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [17:10:15] (03CR) 10jenkins-bot: Fix RevisionDeleteUser rev_actor query for MySQL [core] - 10https://gerrit.wikimedia.org/r/476542 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [17:10:18] 10Android-app-feature-Navigation, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: As a user of the TOC I expect to be able to swipe the TOC closed after swiping it open - https://phabricator.wikimedia.org/T208060 (10Dbrant) [17:10:30] 10Android-app-feature-Navigation, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): As a user of the TOC I expect to be able to swipe the TOC closed after swiping it open - https://phabricator.wikimedia.org/T208060 (10Dbrant) [17:10:52] (03PS1) 10Esanders: Move in VE support code from the VE extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476569 [17:11:32] (03CR) 10jerkins-bot: [V: 04-1] Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [17:12:04] (03CR) 10Cooltey: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476564 (owner: 10L10n-bot) [17:14:12] (03PS26) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [17:16:58] (03CR) 10Phuedx: Remove `noimages` flag from MobileView API (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/402130 (https://phabricator.wikimedia.org/T99009) (owner: 10Jdlrobson) [17:17:30] (03CR) 10Takidelfin: [C: 031] Add namespace to action=info page [core] - 10https://gerrit.wikimedia.org/r/475333 (https://phabricator.wikimedia.org/T123228) (owner: 10Pjht) [17:17:33] (03CR) 10Jdlrobson: [C: 032] RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476537 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [17:17:54] (03PS2) 10Esanders: Move in VE support code from the VE extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476569 [17:17:56] (03PS1) 10Esanders: build: Replace jshint with eslint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476571 [17:18:36] (03Merged) 10jenkins-bot: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476537 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [17:21:21] (03PS8) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [17:23:51] (03CR) 10jenkins-bot: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476537 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [17:25:34] (03Merged) 10jenkins-bot: Fix RevisionDeleteUser rev_actor query for MySQL [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476566 (https://phabricator.wikimedia.org/T210628) (owner: 10Anomie) [17:26:02] (03CR) 10Cooltey: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476564 (owner: 10L10n-bot) [17:26:53] (03PS6) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [17:27:02] (03CR) 10EBernhardson: [C: 032] Properly test the "classic" profile name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476526 (https://phabricator.wikimedia.org/T208248) (owner: 10DCausse) [17:27:33] (03CR) 10Huji: "Sorry, I have been working not from my primary machine, and therefore the work has been a bit sloppy and not properly tested." [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [17:28:01] (03PS1) 10DCausse: Add bot password to login to API [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476573 [17:28:33] (03CR) 10Jdlrobson: [C: 031] "1 minor thought but this LGTM" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [17:30:02] (03PS3) 10Jdlrobson: DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 [17:30:18] 10Growth-Team (Current Sprint): Help pane: business rules on displaying the feature - https://phabricator.wikimedia.org/T206716 (10kostajh) @RHo @MMiller_WMF Should the help panel show when editing Talk pages? If so, should the "Include article title" checkbox reference the article page or the article's talk pa... [17:30:45] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint with eslint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476571 (owner: 10Esanders) [17:31:15] (03PS6) 10Jdlrobson: Remove TalkOverlayBase and a level of inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/469535 [17:31:20] (03CR) 10Jdrewniak: [C: 04-1] "I have the wee'st tiniest nitpick." [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/476496 (https://phabricator.wikimedia.org/T202497) (owner: 10Pcoombe) [17:31:53] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476573 (owner: 10DCausse) [17:31:55] (03CR) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [17:31:59] (03CR) 10Daimona Eaytoy: [C: 04-1] Enable restricting certain groups from blocking certain groups. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [17:32:23] (03CR) 10Daimona Eaytoy: [C: 04-1] "> Sorry, I have been working not from my primary machine, and" [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [17:35:16] shreyasminocha: The task recheck failed as it couldn't find the module eslint-config-wikimedia/jquery, which had to do with having "wikimedia/jquery" as an entry in the extends array in .eslintrc, then the same thing happend with the module eslint-config-wikimedia/client. Can I get rid of them? [17:35:34] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: On a kindle fire, closing the last tab opens the second to last article - https://phabricator.wikimedia.org/T210756 (10JoeWalsh) [17:35:49] pterp: get rid of what, "wikimedia/jquery"? [17:36:02] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: On a kindle fire, closing the last tab opens the second to last article - https://phabricator.wikimedia.org/T210756 (10JoeWalsh) [17:36:03] and "wikimedia/client"? [17:36:10] pterp: but your patch actually got +2 from Jenkins ;-; [17:36:39] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [17:36:40] i don't think so. the lint guidelines mention it so you should leave it in imo [17:36:41] (03CR) 10EBernhardson: "overall looks good, minor suggestion to cleanup the init() function" (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [17:36:46] pterp: ^ [17:37:07] you can fix it by doing `npm install --save-dev eslint-config-wikimedia/client` [17:37:20] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [17:37:24] and same with `eslint-config-wikimedia/jquery` [17:37:30] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [17:38:25] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) > Alternatively, we can setup 4 hosts actively, but I think the sharding function won't work ok? Sorry, my fault,... [17:38:53] The +2 was the "Add namespace to action=info page" patch. The other one got -1 because of those two lines making the Jenkins build fail. I also don't think those modules actually exist, because I'm pretty sure you cant have the build run custom commands, so Jenkins should have auto-downloaded the modules. [17:39:14] Also, reoving those two lines got it to run fine locally. [17:39:38] um, if the guidelines mention it you should leave those lines in [17:39:43] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: On a kindle fire, closing the last tab opens the second to last article - https://phabricator.wikimedia.org/T210756 (10Dbrant) It doesn't look like you were using the latest version of the app. Does this occur with the latest beta? [17:39:44] the fix is rather easy too pterp [17:40:04] just `npm install --save-dev` those two modules, upload a patchset [17:40:31] (03PS1) 10Niedzielski: Hygiene: remove unused click listener in CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476576 [17:41:08] The .eslintrc isn't from the guidelines. I got it from the mentioned example eslint change in the task: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ExtensionDistributor/+/330054 [17:41:26] (03PS3) 10Sharvaniharan: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) [17:41:27] pterp: the module you're looking for is eslint-config-wikimedia [17:42:02] I know. I'm wondeing if the lines are even required though. Did you see my last message? [17:42:13] pterp: https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Linting does mention those two [17:42:22] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: On a kindle fire, closing the last tab opens the second to last article - https://phabricator.wikimedia.org/T210756 (10JoeWalsh) 05Open>03Resolved a:03JoeWalsh Closing, looks to be resolved when running a newer build [17:42:22] yes, i did [17:42:34] OK. I'll run the commands. [17:43:22] (03CR) 10jerkins-bot: [V: 04-1] DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [17:43:57] pterp: btw removing those lines would mean running tests against only the `rules` object, which is not what we want [17:44:01] Ok. [17:44:01] pterp: what is the problem? Eslint? [17:44:34] This is the error: "Warning: Cannot find module 'eslint-config-wikimedia/jquery' [17:44:34] Referenced from: /vagrant/mediawiki/extensions/CollaborationKit/.eslintrc Use --force to continue." And the same for eslint-config-wikimedia/client [17:44:49] (03CR) 10jerkins-bot: [V: 04-1] Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [17:45:00] (03PS4) 10DCausse: Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) [17:45:03] (03PS27) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [17:45:04] takidelfin: i told them to install `eslint-config-wikimedia` [17:45:16] that should fix it, shouldn't it? takidelfin [17:45:25] (03PS9) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) [17:45:27] (03CR) 10DCausse: Allow setting the list of clusters to sanitize (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [17:45:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476564 (owner: 10L10n-bot) [17:46:16] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/ContentProviderFactory.php with unit tests - https://phabricator.wikimedia.org/T210400 (10D3r1ck01) [17:46:17] takidelfin: vide https://www.npmjs.com/package/eslint-config-wikimedia [17:48:11] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10pmiazga) [17:48:59] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10pmiazga) All tasks are solved - this task is ready to sign off. [17:49:33] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10leila) Thanks, Pau. [17:49:48] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Anomie) >>! In T189641#4785677, @Tgr wrote: > Code-wise using the DB would be a very simple solution, but... [17:49:50] pterp: let me know once you've removed `eslint-config-wikimedia/jquery` and the other one and replaced them with `eslint-config-wikimedia` [17:49:52] (03CR) 10jerkins-bot: [V: 04-1] Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [17:49:53] oh well [17:50:30] 10Accessibility, 10Wikimedia-Portals: Language label disconnected from language select and should feature long-form of language title - https://phabricator.wikimedia.org/T209018 (10Volker_E) 05Open>03Resolved p:05Triage>03Normal a:03Volker_E [17:50:33] looks like that's what they've done, hmm [17:50:53] they might be right in their suspicion [17:51:02] (03PS4) 10Jdlrobson: DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 [17:51:04] (03PS1) 10Jdlrobson: Documentation: icon functions watch, watched [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476578 [17:51:43] (03Merged) 10jenkins-bot: Properly test the "classic" profile name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476526 (https://phabricator.wikimedia.org/T208248) (owner: 10DCausse) [17:53:53] (03CR) 10Shreyasminocha: Replace jslint and jscs with eslint (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [17:54:00] (03PS2) 10Aklapper: Clarify that the default Help link in the sidebar is about MediaWiki itself [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) [17:54:30] Urbanecm: okay... So creating a ticket requires a Topic [17:54:31] (03PS1) 10Niedzielski: Hygiene: remove unused CtaDrawer flows [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476579 [17:54:58] and that was my problem [17:54:59] ... [17:55:09] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [17:56:01] That error message looks that it refers to name field :( [17:56:10] 10Discovery-Search (Current work), 10Patch-For-Review, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10EBernhardson) a:03dcausse [17:56:19] !ask | andre__ [17:56:19] andre__: Please feel free to ask your question: if anybody who knows the answer is around, they will surely reply. Don't ask for help or for attention before actually asking your question, that's just a waste of time – both yours and everybody else's. :) [17:58:48] (03CR) 10EBernhardson: [C: 032] Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [17:58:55] ;-; [18:00:43] (03CR) 10D3r1ck01: "Excellent work Andre, thanks for your patch :) Just a little minor fix :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) (owner: 10Aklapper) [18:02:03] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10ArielGlenn) Just a note that while it's taken 5 years for that number of records to go from 154 million t... [18:02:44] (03CR) 10D3r1ck01: "> Patch Set 2: Code-Review-1" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:03:04] 10Product-Analytics, 10Growth-Team (Current Sprint): Personalized first day: experiments - https://phabricator.wikimedia.org/T206380 (10MMiller_WMF) Now that [[ https://phabricator.wikimedia.org/T207717 | Variation C ]] is almost ready, we should modify the written experiment plan to indicate what share of use... [18:03:46] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port the references feature to webpack: Merge mobile.references and ... - https://phabricator.wikimedia.org/T207805 [18:04:31] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: version 2.7.239-alpha-2018-09-20 crashes - https://phabricator.wikimedia.org/T205207 (10Dbrant) @Matanya This no longer seems to be happening. Can you confirm (with latest alpha)? [18:05:52] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210 (10nray) a:03nray [18:06:10] (03CR) 10DLynch: [C: 032] ve.ui.MWCitationDialog: Fix condition for enabling insert/apply action [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476443 (https://phabricator.wikimedia.org/T210686) (owner: 10Bartosz Dziewoński) [18:06:15] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid err... - https://phabricator.wikimedia.org/T193505 [18:06:19] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Offline message appears after refreshing saved article in airplane mode - https://phabricator.wikimedia.org/T210691 (10ABorbaWMF) I keep running into it by mistake. Perhaps adding a button to go back to the offline version of the article? [18:06:22] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 3 others: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10Jdlrobson) a:05LukBukki... [18:07:12] (03CR) 10Huji: Enable restricting certain groups from blocking certain groups. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [18:07:49] (03PS7) 10Huji: Enable restricting certain groups from blocking certain groups. [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) [18:08:21] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:09:03] (03PS8) 10Dbrant: [EXTREME WIP] Augmented keyboard for editing. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469672 (https://phabricator.wikimedia.org/T195208) [18:09:27] (03PS1) 10Thiemo Kreuz (WMDE): Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) [18:09:54] (03CR) 10jenkins-bot: Properly test the "classic" profile name [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476526 (https://phabricator.wikimedia.org/T208248) (owner: 10DCausse) [18:10:11] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10pmiazga) a:05pmiazga>... [18:10:13] 10Growth-Team (Current Sprint): Help panel: conduct user testing of initial help pane design - https://phabricator.wikimedia.org/T210112 (10MMiller_WMF) [18:10:46] (03CR) 10DCausse: [C: 032] Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:11:09] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Anomie) On the MediaWiki site the relevant code is in SqlBagOStuff. It looks like the current code will treat a failing ser... [18:11:21] (03CR) 10DCausse: [C: 032] "I've disabled the bot for now, it's broken" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:12:09] (03CR) 10D3r1ck01: "> I've disabled the bot for now, it's broken" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:12:59] (03Merged) 10jenkins-bot: Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [18:13:07] 10Design, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10phuedx) | Priority | Actual | | --- | --- |... [18:14:10] (03PS6) 10Dbrant: [SUPER WIP] Sepia. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/471028 (https://phabricator.wikimedia.org/T194327) [18:15:49] 10CirrusSearch, 10Discovery-Search, 10Dumps-Generation: CirrusSearch dumps for the Norwegian Bokmål Wikipedia link to the Italian Wikipedia - https://phabricator.wikimedia.org/T210623 (10EBjune) We'll double check on where the data is going here [18:15:57] (03PS1) 10Matthewrbowker: Remove SpecialResetTokens class (Deprecated since 1.26) [core] - 10https://gerrit.wikimedia.org/r/476586 [18:16:14] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) > I see no logic for automatic switching That is ok, the plan B (or even plan A, based on your opinions) was to p... [18:16:17] (03PS3) 10Esanders: Move in VE support code from the VE extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476569 [18:16:19] (03PS2) 10Esanders: build: Replace jshint with eslint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476571 [18:16:21] 10CirrusSearch, 10Dumps-Generation, 10Discovery-Search (Current work): CirrusSearch dumps for the Norwegian Bokmål Wikipedia link to the Italian Wikipedia - https://phabricator.wikimedia.org/T210623 (10EBjune) [18:17:40] (03PS1) 10Esanders: Bring in VE support from VE extension [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476588 [18:17:46] 10MediaWiki-Platform-Team, 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Patch-For-Review, and 2 others: Wikibase must not insert local recentchanges entries for nonexistent local users (days: 5) - https://phabricator.wikimedia.org/T183019 (10Anomie) FYI: I ran it on a bunch more wiktionaries and al... [18:18:19] (03CR) 10Esanders: [C: 04-1] Bring in VE support from VE extension (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476588 (owner: 10Esanders) [18:18:30] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: Change password length requirement and ensure enforcement - https://phabricator.wikimedia.org/T208246 (10TBolliger) [18:19:14] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster - https://phabricator.wikimedia.org/T208808 (10Jdlrobson) Still... [18:19:16] (03Merged) 10jenkins-bot: ve.ui.MWCitationDialog: Fix condition for enabling insert/apply action [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476443 (https://phabricator.wikimedia.org/T210686) (owner: 10Bartosz Dziewoński) [18:20:31] 10Growth-Team (Current Sprint): Help pane: business rules on displaying the feature - https://phabricator.wikimedia.org/T206716 (10kostajh) Following up on the preference: one way to proactively surface this and also get feedback from users would be to implement a "Feedback on this tool" dialog like we have else... [18:20:55] 10MediaWiki-User-management, 10Anti-Harassment: FormSpecialPage::checkExecutePermissions should only block a FormSpecialPage if the user is sitewide blocked - https://phabricator.wikimedia.org/T209097 (10TBolliger) [18:21:04] (03PS2) 10Matthewrbowker: Remove SpecialResetTokens class (Deprecated since 1.26) [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) [18:21:08] (03CR) 10jerkins-bot: [V: 04-1] Add browser test for preview functionality to MediaWiki core [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [18:22:02] What a poorly designed interface... [18:22:54] 10MediaWiki-User-management, 10Anti-Harassment: Partially blocked admins should be able to restore revisions of deleted pages - https://phabricator.wikimedia.org/T209662 (10TBolliger) [18:24:04] (03CR) 10Thiemo Kreuz (WMDE): ""unexpected alert open: … Leaving this page may cause you to lose any changes you have made."" [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [18:24:21] (03CR) 10jerkins-bot: [V: 04-1] Move in VE support code from the VE extension [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476569 (owner: 10Esanders) [18:25:04] (03CR) 10jenkins-bot: Allow setting the list of clusters to sanitize [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476546 (https://phabricator.wikimedia.org/T210728) (owner: 10DCausse) [18:25:30] 10MediaWiki-Search, 10Discovery-Search: Pagination links are broken for search if limit is set higher than 50 - https://phabricator.wikimedia.org/T23287 (10EBjune) 05Open>03Resolved a:03EBjune This has been long fixed [18:26:05] (03Merged) 10jenkins-bot: Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:26:49] (03CR) 10jerkins-bot: [V: 04-1] Bring in VE support from VE extension [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476588 (owner: 10Esanders) [18:27:43] 10MediaWiki-Search, 10incubator.wikimedia.org: Allow extensions to append stuff to search queries, e.g. for search by prefix - https://phabricator.wikimedia.org/T32229 (10debt) Hi, removing our team tag - let us know if you need help with this very old ticket. [18:31:03] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) >>! In T210725#4785536, @Imarlier wrote: > > Something that I would suggest, if it's possible, is taking this... [18:31:14] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint with eslint [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476571 (owner: 10Esanders) [18:32:24] (03CR) 10Thiemo Kreuz (WMDE): Rewrite private Cite::refArg for readability (032 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474711 (owner: 10Thiemo Kreuz (WMDE)) [18:33:22] (03CR) 10D3r1ck01: "Some minor fixes, thanks for your work :)" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:33:39] (03PS1) 10VolkerE: build: Use eslint-config-wikimedia v0.9.0 and make pass [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476594 [18:33:41] (03PS5) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:33:49] (03CR) 10D3r1ck01: [C: 04-1] "recheck" [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:34:23] (03PS2) 10VolkerE: build: Use stylelint-config-wikimedia v0.9.0 and make pass [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476594 [18:34:45] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [18:35:59] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:36:24] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) > How will the disk space grow on those servers? Remember space is not capped except for expiration. The same con... [18:37:41] 10Library-Card-Platform: Migrate all remaining information from old on-wiki signup pages - https://phabricator.wikimedia.org/T201151 (10AVasanth_WMF) [18:37:44] (03CR) 10jenkins-bot: Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210510) (owner: 10D3r1ck01) [18:37:45] 10Library-Card-Platform: Provide a link or form for suggesting new partners - https://phabricator.wikimedia.org/T201156 (10AVasanth_WMF) 05Open>03Resolved [18:38:32] (03CR) 10Zoranzoki21: New version 1.2 (031 comment) [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:38:37] 10Library-Card-Platform: Migrate all remaining information from old on-wiki signup pages - https://phabricator.wikimedia.org/T201151 (10AVasanth_WMF) 05Open>03Resolved [18:38:55] (03PS6) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:39:09] d3r1ck: Can I have a quick hand? On the "Commit Message" comment you made, I'm not seeing an extra line anywhere except in your review. [18:39:29] You have something like [18:39:34] Bug: TXXXX [18:39:44] A newline before Change-Id [18:39:49] Remove the extra line [18:40:12] So there should be no newline at all between the Bug: and the Change-Id: ? https://usercontent.irccloud-cdn.com/file/j2pBxttX/Screen%20Shot%202018-11-29%20at%2011.39.25.png [18:40:50] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10greg) If that patch fix... [18:40:52] Yup! It should be [18:40:55] 10MediaWiki-Vagrant: Vagrant has detected a configuration issue which exposes a vulnerability with the installed version of VirtualBox - https://phabricator.wikimedia.org/T210764 (10zeljkofilipin) [18:40:56] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:40:58] Bug: TXXXX [18:41:07] Change-Id: xxxx [18:41:15] Not extra new line needed [18:41:26] 10MediaWiki-Special-pages, 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10greg) [18:41:29] Matthew: See this: https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines, for more info [18:41:42] Okay. I made the change, thanks for the help. [18:41:52] 10Security-Team, 10TechCom, 10TechCom-RFC, 10Security: Proposal for partial opt-out method for Content security policy - https://phabricator.wikimedia.org/T208188 (10kchapman) TechCom is hosting an IRC meeting on this: Wednesday December 5th 11pm PST(December 6th 07:00 UTC, 08:00 CET) in [[https://meta.wik... [18:41:53] (03PS3) 10Matthewrbowker: Remove SpecialResetTokens class (Deprecated since 1.26) [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) [18:42:28] (03CR) 10Matthewrbowker: Remove SpecialResetTokens class (Deprecated since 1.26) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:42:38] (03PS7) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:43:47] 10MediaWiki-Internationalization, 10I18n, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10User-Zoranzoki21: Serbian (sr-ec and sr-el) should support GRAMMAR parser function - https://phabricator.wikimedia.org/T35546 (10Zoranzoki21) 05Open>03Resolved a:03Acamicamacaraca Should be resolved. [18:44:08] 10WikimediaMessages: Add napwikisource to WikimediaMessages - https://phabricator.wikimedia.org/T210765 (10MarcoAurelio) [18:44:48] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:45:32] Matthew: You're correct about the 2 spaces [18:45:49] (03CR) 10Urbanecm: [C: 04-1] Add ability for users to ignore selected acks (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:45:55] 10CirrusSearch, 10Dumps-Generation, 10Discovery-Search (Current work): CirrusSearch dumps for the Norwegian Bokmål Wikipedia link to the Italian Wikipedia - https://phabricator.wikimedia.org/T210623 (10jhsoby-WMNO) >>! In T210623#4786158, @EBjune wrote: > We'll double check on where the data is going here T... [18:45:58] (03PS9) 10Urbanecm: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:46:06] (03PS8) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:46:31] Okay, thank you :) [18:46:42] (03CR) 10D3r1ck01: [C: 04-1] "Due to the wrapping, I missed that, sorry!" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:47:44] (03CR) 10D3r1ck01: "Are there any tests cases related to the class you've removed? If so, I think you should also remove them?" [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:47:57] (03CR) 10Thiemo Kreuz (WMDE): Clarify that the default Help link in the sidebar is about MediaWiki itself (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) (owner: 10Aklapper) [18:49:09] (03PS4) 10Sharvaniharan: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) [18:49:19] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:49:32] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) Yes, I'm fine with the overshard I just wanted to make sure disk space will remain untouched Thanks for clarify... [18:50:09] (03PS1) 10Pmiazga: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476596 (https://phabricator.wikimedia.org/T210737) [18:50:40] (03CR) 10Pmiazga: [C: 032] RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476596 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [18:50:55] (03CR) 10Thiemo Kreuz (WMDE): Add browser test for preview functionality to MediaWiki core (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476585 (https://phabricator.wikimedia.org/T210758) (owner: 10Thiemo Kreuz (WMDE)) [18:52:00] (03PS9) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:53:29] 10MediaWiki-User-management, 10Wikimedia-Site-requests, 10Patch-For-Review: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) Test instructions for https://gerrit.wikimedia.org/r/476439 1. Add the following to LocalSettings.php : ` $wgGroupBlockRestrictions... [18:54:15] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [18:54:56] 10MediaWiki-extensions-WikibaseClient, 10Core Platform Team Kanban, 10Wikidata, 10Wikimedia-production-error: wiktionary: /rpc/RunSingleJob.php CannotCreateActorException from line 2540 of /srv/mediawiki/php-1.33.0-wmf.6/includes/user/User.php: Cannot create an a... - https://phabricator.wikimedia.org/T210732 [18:55:38] 10MediaWiki-Core-Tests, 10MediaWiki-User-management: Create a unit test for $wgGroupBlockRestrictions - https://phabricator.wikimedia.org/T210767 (10Huji) p:05Triage>03Low [18:55:56] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10jcrespo) > Is my understanding correct? That is what I understood. [18:56:06] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Imarlier) @jcrespo I should have kept my answer simpler: I think it's fine to go ahead and do this. I would suggest changi... [18:56:41] (03PS10) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [18:57:18] (03CR) 10D3r1ck01: "recheck" [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [18:58:30] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476598 [18:59:43] Hi guys [19:00:13] thanks @anomie for the tip about the database lagging. I really appreciate it, the issue with the beta cluster read only mode has been driving me mad all week! <3 [19:00:20] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:00:41] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476598 (owner: 10Ejegg) [19:00:49] jdlrobson: You're welcome! [19:01:11] (03CR) 10Zoranzoki21: "quibble-vendor-mysql-hhvm-docker SUCCESS in 3m 32s" [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:01:38] Hello TheJair [19:02:53] :) [19:03:38] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476598 (owner: 10Ejegg) [19:04:03] 10MediaWiki-Core-Tests, 10MediaWiki-User-management: Create a unit test for $wgGroupBlockRestrictions - https://phabricator.wikimedia.org/T210767 (10Huji) I am separating this because I will need some time to familiarize myself with the unit tests to devise an appropriate strategy for this. I don't want the im... [19:04:51] 10Design, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10Jdlrobson) a:03phuedx ^ @phuedx I'm going... [19:05:06] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port the references feature to webpack: Merge mobile.references and ... - https://phabricator.wikimedia.org/T207805 [19:06:00] (03PS1) 10Takidelfin: Ticket details: New paragraph after a linebreak [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476599 (https://phabricator.wikimedia.org/T210237) [19:06:30] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: View: Make isBorderBox and className passable options to the View cl... - https://phabricator.wikimedia.org/T209007 [19:09:39] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) a:03ABorbaWMF [19:09:41] (03Merged) 10jenkins-bot: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476596 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [19:09:56] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image, VE and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [19:10:46] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [Regression] Settings list items not left aligned - https://phabricator.wikimedia.org/T210446 (10Sharvaniharan) a:03Sharvaniharan [19:10:48] 10Growth-Team (Current Sprint): Help panel: comparative review of in-context questioning - https://phabricator.wikimedia.org/T206713 (10MMiller_WMF) [19:10:50] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10jeblad) This is pretty well-known, but here it comes. Resetting the password (what you know) on a two-factor enabled account without the second factor being triggered leads to a one-factor system. A system isn... [19:11:03] 10Growth-Team (Current Sprint): Help panel: Review similar past projects (MoodBar, Article Feedback Tool) & summarize relevant learnings for in-context help design - https://phabricator.wikimedia.org/T206714 (10MMiller_WMF) [19:11:06] (03CR) 10Dbrant: [C: 032] "A nicely-researched workaround!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [19:11:27] 10Growth-Team (Current Sprint): Help panel: write English copy for translation - https://phabricator.wikimedia.org/T210213 (10MMiller_WMF) [19:11:28] (03PS11) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [19:11:44] 10Growth-Team (Current Sprint): Help panel: translate and test content - https://phabricator.wikimedia.org/T206718 (10MMiller_WMF) [19:12:38] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: add call-to-action and help panel into the editing UI - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) [19:12:51] 10WMCZ-Tracker: Add comment button doesn't work on topic_detail - https://phabricator.wikimedia.org/T210769 (10Urbanecm) [19:12:57] 10Growth-Team (Current Sprint): Help panel: business rules on displaying the feature - https://phabricator.wikimedia.org/T206716 (10MMiller_WMF) [19:13:04] (03CR) 10Urbanecm: [C: 032] Ticket details: New paragraph after a linebreak [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476599 (https://phabricator.wikimedia.org/T210237) (owner: 10Takidelfin) [19:13:27] 10CommRel-Specialists-Support (Oct-Dec-2018), 10Growth-Team (Current Sprint): Help panel: Determine what text and links to show in the help pane on KO and CS wikis - https://phabricator.wikimedia.org/T209297 (10MMiller_WMF) [19:13:29] 10Mathe für Nicht-Freaks: Fakultät neue Einführung (Abschnitt Herleitung} - https://phabricator.wikimedia.org/T209751 (10ZornschesLemma) a:05ZornschesLemma>03GregorAlexandru [19:13:45] (03CR) 10Dbrant: [C: 032] "My favorite kind of patch: improving the product by removing code." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469811 (https://phabricator.wikimedia.org/T166151) (owner: 10Cooltey) [19:13:48] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Make 403 responses nicer - https://phabricator.wikimedia.org/T210394 (10takidelfin) a:03takidelfin [19:13:50] (03CR) 10Matthewrbowker: "From a look, no. It appears that SpecialPageFactoryTest.php just gets the list of pages from SpecialPageFactory.php. And there is no tes" [core] - 10https://gerrit.wikimedia.org/r/476586 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [19:13:58] 10MediaWiki-User-login-and-signup, 10Anti-Harassment: Change password length requirement and ensure enforcement - https://phabricator.wikimedia.org/T208246 (10TBolliger) [19:14:11] 10CommRel-Specialists-Support (Oct-Dec-2018), 10Growth-Team (Current Sprint): Help panel: Determine what text and links to show in the help panel on KO and CS wikis - https://phabricator.wikimedia.org/T209297 (10MMiller_WMF) [19:14:14] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Goal: [GOAL] Advanced mobile contributions - https://phabricator.wikimedia.org/T198313 (10Jdlrobson) [19:14:16] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid err... - https://phabricator.wikimedia.org/T193505 [19:14:24] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid err... - https://phabricator.wikimedia.org/T193505 [19:14:30] (03Merged) 10jenkins-bot: Ticket details: New paragraph after a linebreak [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476599 (https://phabricator.wikimedia.org/T210237) (owner: 10Takidelfin) [19:14:32] (03CR) 10jenkins-bot: RecordRevision::getUser() returns UserIdentity not int [extensions/MobileFrontend] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476596 (https://phabricator.wikimedia.org/T210737) (owner: 10Pmiazga) [19:14:49] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:15:00] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: instrumentation - https://phabricator.wikimedia.org/T206719 (10MMiller_WMF) [19:15:20] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: Develop Schema - https://phabricator.wikimedia.org/T209982 (10MMiller_WMF) [19:15:47] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: experiments - https://phabricator.wikimedia.org/T206720 (10MMiller_WMF) [19:16:24] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10MMiller_WMF) [19:16:48] 10Growth-Team: Help panel: provide templates replies for questions posted - https://phabricator.wikimedia.org/T209331 (10MMiller_WMF) [19:17:04] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 3 others: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10Jdlrobson) [19:17:13] 10Growth-Team: Help panel: enable feedback on Help Desk responses - https://phabricator.wikimedia.org/T209332 (10MMiller_WMF) [19:17:41] 10Growth-Team: Help panel: enable searching help articles - https://phabricator.wikimedia.org/T209301 (10MMiller_WMF) [19:18:10] 10Growth-Team: Help panel: allow anonymous users to use the panel and ask a question - https://phabricator.wikimedia.org/T209325 (10MMiller_WMF) [19:18:36] 10Growth-Team: Help panel: provide suggested answers as users type their question - https://phabricator.wikimedia.org/T209327 (10MMiller_WMF) [19:19:02] 10Growth-Team: Help panel: allow users to mark the context of their question - https://phabricator.wikimedia.org/T209328 (10MMiller_WMF) [19:19:07] 10MediaWiki-User-management, 10Anti-Harassment: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox - https://phabricator.wikimedia.org/T210002 (10TBolliger) [19:19:15] Hi, what I should fix 20:12:21 /src/modules/HoverGallery.js 20:12:21 31:9 error Parsing error: Unexpected token . [19:19:25] https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/HoverGallery/+/476457 [19:20:26] 10UI-Standardization, 10OOUI, 10UI-Standardization-Kanban: Create a rounded button widget for Floating action buttons - https://phabricator.wikimedia.org/T210770 (10RHo) [19:20:28] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 3 others: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10Jdlrobson) 05Open>03R... [19:20:42] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10jeblad) 05Open>03Invalid Never mind, this will not be fixed. [19:20:59] 10MediaWiki-User-management, 10Anti-Harassment: Oversighters should only be able to suppress a username for sitewide blocks (not partial blocks) via "Hide username from edits and lists" checkbox - https://phabricator.wikimedia.org/T210002 (10TBolliger) Change itself should be simple, but `5` because there will... [19:22:34] 10MediaWiki-extensions-OAuth, 10GitHub-Mirrors, 10JavaScript: Fix passport-mediawiki-oauth - https://phabricator.wikimedia.org/T210771 (10Tgr) [19:22:41] (03PS3) 10Aklapper: Clarify that the default Help link in the sidebar is about MediaWiki itself [core] - 10https://gerrit.wikimedia.org/r/476467 (https://phabricator.wikimedia.org/T209335) [19:23:10] 10MediaWiki-Categories, 10MediaWiki-Internationalization: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10jeblad) a:05jeblad>03None [19:23:28] (03PS1) 10Matthewrbowker: Remove EDIT_TOKEN_SUFFIX, a deprecated constant in Users.php since 1.27. [core] - 10https://gerrit.wikimedia.org/r/476603 (https://phabricator.wikimedia.org/T61113) [19:23:50] Ignore that one, not ready for review^ [19:24:13] 10Research, 10CommRel-Specialists-Support (Oct-Dec-2018), 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Elitre) 05Open>03Resolved [19:26:01] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review: Create default luacheckrc for Wikibase - https://phabricator.wikimedia.org/T180925 (10jeblad) 05Open>03Resolved [19:26:21] (03PS12) 10Zoranzoki21: New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) [19:26:37] 10MediaWiki-User-management, 10Anti-Harassment, 10CheckUser: Partial blocks log entries display as malformed on Special:CheckUser - https://phabricator.wikimedia.org/T208523 (10TBolliger) [19:26:56] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Empty line in a comment should be interpreted as new paragraph - https://phabricator.wikimedia.org/T210237 (10Urbanecm) 05Open>03Resolved [19:27:31] (03Merged) 10jenkins-bot: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [19:27:34] (03Merged) 10jenkins-bot: Split off SearchFragment into its own Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469811 (https://phabricator.wikimedia.org/T166151) (owner: 10Cooltey) [19:28:19] (03CR) 10Tpt: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [19:28:21] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Make email mandatory field for all users - https://phabricator.wikimedia.org/T203983 (10Urbanecm) [19:28:39] 10WMCZ-Tracker: Display if an user did statutory declaration in printed version of a ticket - https://phabricator.wikimedia.org/T210590 (10Urbanecm) [19:29:47] (03CR) 10jenkins-bot: Split off SearchFragment into its own Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469811 (https://phabricator.wikimedia.org/T166151) (owner: 10Cooltey) [19:29:50] (03CR) 10jenkins-bot: Fix: Remove extra indentation in Settings without overriding properties [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476456 (https://phabricator.wikimedia.org/T210446) (owner: 10Sharvaniharan) [19:29:52] (03CR) 10jerkins-bot: [V: 04-1] New version 1.2 [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:30:56] (03PS1) 10Dbrant: Follow-up to Search activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476605 [19:31:06] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Make email mandatory field - https://phabricator.wikimedia.org/T203983 (10Urbanecm) [19:31:49] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow user to opt-out from notifications - https://phabricator.wikimedia.org/T210773 (10Urbanecm) [19:32:59] 10MediaWiki-Page-editing: Autolinking to edited section does not work certain chars - https://phabricator.wikimedia.org/T153681 (10jeblad) [19:33:34] 10MediaWiki-Page-editing: Autolinking to edited section does not work certain chars - https://phabricator.wikimedia.org/T153681 (10jeblad) [19:35:02] 10MediaWiki-Page-editing: Autolinking to edited section does not work certain chars - https://phabricator.wikimedia.org/T153681 (10jeblad) [19:35:36] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Make email mandatory field - https://phabricator.wikimedia.org/T203983 (10Urbanecm) https://codein.withgoogle.com/tasks/5282636604899328/ [19:36:08] (03PS2) 10Matthewrbowker: Remove EDIT_TOKEN_SUFFIX, a deprecated constant in Users.php since 1.27. [core] - 10https://gerrit.wikimedia.org/r/476603 (https://phabricator.wikimedia.org/T61113) [19:36:12] (03PS5) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [19:37:23] (03CR) 10Matthewrbowker: "Note that the only place this constant is still used is in the PageForms extension, after a check for the "\MediaWiki\Session\Token" class" [core] - 10https://gerrit.wikimedia.org/r/476603 (https://phabricator.wikimedia.org/T61113) (owner: 10Matthewrbowker) [19:37:34] (03PS10) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [19:38:08] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [19:38:11] 10Design, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10phuedx) Further to T206177#4786144: | Titl... [19:39:15] (03PS11) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [19:39:42] 10Design, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, and 2 others: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10phuedx) >>! In T206177#4786421, @Jdlrobson... [19:39:48] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow user to opt-out from notifications easily - https://phabricator.wikimedia.org/T210773 (10Urbanecm) [19:41:07] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Wikimedia-production-error: Various User.php: PHP Notice: Object of class User could not be converted to int - https://phabricator.wikimedia.org/T210737 (10ha... [19:41:28] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow user to opt-out from notifications easily - https://phabricator.wikimedia.org/T210773 (10Urbanecm) https://codein.withgoogle.com/tasks/5988339510411264/ [19:41:34] My "ignore that" can be ignored now. Is there a way to create a changeset in Gerrit and keep it as a draft for an extended period? Without notifying anyone for review? I can't Git anymore against the MediaWiki repo so I'm curious. [19:42:30] 10Discovery-Search (Current work), 10Patch-For-Review: Repair transfer_to_es analytics job - https://phabricator.wikimedia.org/T210545 (10debt) 05Open>03Resolved [19:43:49] 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10debt) 05Open>03Resolved [19:43:51] 10WMCZ-Tracker: Allow to override default DataTables settings in each template - https://phabricator.wikimedia.org/T196405 (10Urbanecm) 05Open>03declined [19:45:17] 10MediaWiki-Revision-deletion, 10Technical-Debt: RevisionDeleteUser should batch all of its updates - https://phabricator.wikimedia.org/T210777 (10Anomie) [19:45:19] 10MediaWiki-Database: Add IDatabase::updateJoin() - https://phabricator.wikimedia.org/T210778 (10Anomie) [19:45:35] 10CirrusSearch, 10Discovery-Search (Current work): The ltr plugin should not fail when profiling a featureset that depends on on the featurevector - https://phabricator.wikimedia.org/T205249 (10debt) 05Open>03Resolved [19:46:02] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Volans) I wasn't aware of this task, but I've contacted the #security team few months ago with more or le... [19:46:04] 10MediaWiki-User-management, 10Anti-Harassment: If a user/IP combo is partially/sitewide (overlapping) blocked, always enforce the sitewide block - https://phabricator.wikimedia.org/T206163 (10TBolliger) [19:48:19] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work), 10Epic, and 2 others: Characters in CJK extension C treated as U+FFFD when searching on zhWP [EPIC-ish] - https://phabricator.wikimedia.org/T168427 (10debt) [19:48:21] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work): Deploy extra-analysis-surrogates & the experimental highlighter 5.5.2.4 to production - https://phabricator.wikimedia.org/T209155 (10debt) 05Open>03Resolved [19:48:23] (03CR) 10Dbarratt: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) (owner: 10Dbarratt) [19:48:44] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work): Deploy extra-analysis-surrogates & the experimental highlighter 5.5.2.4 to production - https://phabricator.wikimedia.org/T209155 (10debt) [19:48:47] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work): Re-index Chinese Wikis to fix Surrogate Split - https://phabricator.wikimedia.org/T209156 (10debt) 05Open>03Resolved [19:48:53] (03CR) 10Urbanecm: [C: 032] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [19:49:28] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work), 10Epic, and 2 others: Characters in CJK extension C treated as U+FFFD when searching on zhWP [EPIC-ish] - https://phabricator.wikimedia.org/T168427 (10debt) 05Open>03Resolved [19:50:11] (03Merged) 10jenkins-bot: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [19:50:40] (03PS1) 10Niedzielski: Hygiene: add test for CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) [19:51:00] 10Discovery-Search, 10Epic: [epic] Run multiple elasticsearch clusters on same hardware - https://phabricator.wikimedia.org/T193654 (10debt) [19:51:03] 10Discovery-Search (Current work), 10Patch-For-Review: Setup two elasticsearch clusters on relforge to test multi-instance - https://phabricator.wikimedia.org/T198352 (10debt) 05Open>03Resolved [19:51:07] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: add tests for Drawer and CtaDrawer - https://phabricator.wikimedia.org/T208920 (10Niedzielski) a:05Niedzielsk... [19:52:02] 10Elasticsearch, 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Elastica dependencies need update to v5.3.2 - https://phabricator.wikimedia.org/T208650 (10debt) 05Open>03Resolved a:03debt [19:52:49] 10MediaWiki-Search, 10Discovery-Search (Current work), 10MW-1.32-notes, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), and 2 others: Prefix search broken when using multiple namespaces and namespaces with $wgCapitalLinks = false; - https://phabricator.wikimedia.org/T208255 (10debt) 05Open>03Resolved [19:53:48] 10WMCZ-Tracker: Datatables isn't working on /users/ - https://phabricator.wikimedia.org/T210351 (10Urbanecm) https://codein.withgoogle.com/tasks/5057139547570176/ [19:53:59] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Datatables isn't working on /users/ - https://phabricator.wikimedia.org/T210351 (10Urbanecm) [19:54:11] 10Discovery, 10Chinese-Sites, 10Discovery-Search (Current work): Deploy extra-analysis-surrogates & the experimental highlighter 5.5.2.4 to production - https://phabricator.wikimedia.org/T209155 (10debt) [19:54:15] 04(no projects): write some unit tests for jsub and friends in toollabs - https://phabricator.wikimedia.org/T210779 (10Bstorm) [19:54:17] 10Discovery, 10Discovery-Search (Current work), 10Patch-For-Review: Prepare a deb package with the experimental highlighter 5.5.2.4 - https://phabricator.wikimedia.org/T209293 (10debt) 05Open>03Resolved [19:54:36] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10TBolliger) 05Open>03stalled Blocked because @Mooeypoo will check with others to see how we should proceed with this task. ------ There is a documented process some... [19:54:48] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10aezell) This is primarily a socialization task because this usage in the core code is quite small. Seems like this: {F27325901} Or, here: https://codesearch.wmflabs.o... [19:55:03] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Internacionalize notifications - https://phabricator.wikimedia.org/T196425 (10Urbanecm) a:03Nathan_fraignt [19:55:05] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10TBolliger) a:03Mooeypoo [19:55:15] 10CirrusSearch, 10Discovery-Search (Current work), 10Patch-For-Review: The experimental highlighter should not break unicode surrogate pairs when cutting the snippet. - https://phabricator.wikimedia.org/T208736 (10debt) 05Open>03Resolved [19:55:18] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Allow users to watch only certain acks - https://phabricator.wikimedia.org/T208655 (10Urbanecm) 05Open>03Resolved a:03Arcayn [19:55:43] 10CirrusSearch, 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Tracking): [Bug] Precondition failed: Trying to get token image at offset -1 - https://phabricator.wikimedia.org/T209299 (10debt) 05Open>03Resolved [19:56:59] 10WMCZ-Tracker: Investigate DataTables error report - https://phabricator.wikimedia.org/T196426 (10Urbanecm) [19:57:25] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: add test for CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [19:57:50] 10Discovery-Search (Current work): Fix elasticsearch_hot_threads on relforge (ImportError: No module named 'yaml') - https://phabricator.wikimedia.org/T209030 (10debt) 05Open>03Resolved a:03debt [19:58:18] 10MediaWiki-User-management, 10Anti-Harassment: If a user/IP combo is partially/sitewide (overlapping) blocked, always enforce the sitewide block - https://phabricator.wikimedia.org/T206163 (10dbarratt) The user could have two overlapping partial blocks... and I think those should be enforced together rather t... [19:59:55] (03CR) 10Tpt: "Thank you! CI seems to be fixed. I should have a bikeshedding comment to be consistent with MW practices." (032 comments) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [20:03:29] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Anomie) >>! In T189641#4786713, @Volans wrote: > Given that MediaWiki should work both inside our infrast... [20:03:34] (03PS6) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [20:04:35] (03PS1) 10Takidelfin: Topic details: Fix 'add comment' button disappearing [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) [20:04:44] (03PS2) 10Niedzielski: Hygiene: add test for CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) [20:04:49] (03PS1) 10Urbanecm: Hide muted type notification in preferences and watch grant [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476611 [20:04:55] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Krinkle) The above all sounds great. Two quick fly-by notes/recommendations: * Change at most one key on a given day (and... [20:05:18] (03CR) 10Urbanecm: [C: 032] Hide muted type notification in preferences and watch grant [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476611 (owner: 10Urbanecm) [20:05:38] (03CR) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI (032 comments) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [20:06:10] (03Merged) 10jenkins-bot: Hide muted type notification in preferences and watch grant [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476611 (owner: 10Urbanecm) [20:09:28] (03PS1) 10Dmaza: Change config flag for enabling Block Notice stats [extensions/MobileFrontend] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476613 (https://phabricator.wikimedia.org/T201719) [20:09:33] (03PS2) 10Takidelfin: Topic details: Fix 'add comment' button disappearing [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) [20:09:44] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Change language should redirect to the URL user was before clicking it - https://phabricator.wikimedia.org/T210782 (10Urbanecm) [20:12:34] (03PS3) 10Takidelfin: Topic details: Fix 'add comment' button disappearing [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) [20:13:00] (03CR) 10Takidelfin: "This change is ready for review." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) (owner: 10Takidelfin) [20:13:49] (03PS11) 10Cooltey: Fix: Chinese variants issues that title in the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 (https://phabricator.wikimedia.org/T115266) [20:14:13] (03PS12) 10Cooltey: Fix: Chinese variants issues that title in the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 (https://phabricator.wikimedia.org/T115266) [20:17:36] (03CR) 10Urbanecm: [C: 032] Topic details: Fix 'add comment' button disappearing [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) (owner: 10Takidelfin) [20:17:46] 10MediaWiki-Special-pages, 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10hashar) Happened in wmf.4 as well: reqId W-chAgpAAEAAAEtvpOMAAAAW ` Failed to delete page-move revision: 10MediaWiki-Special-pages, 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10hashar) p:05Unbreak!>03Normal [20:18:10] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10CDanis) >> but I think we should aim for having the data in memory as much as possible to achieve good pe... [20:18:19] (03CR) 10Cooltey: [C: 032] Follow-up to Search activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476605 (owner: 10Dbrant) [20:18:25] 10MediaWiki-Special-pages, 10Wikimedia-production-error: Failed to delete page-move revision: - https://phabricator.wikimedia.org/T210739 (10hashar) [20:18:28] (03Merged) 10jenkins-bot: Topic details: Fix 'add comment' button disappearing [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476610 (https://phabricator.wikimedia.org/T210769) (owner: 10Takidelfin) [20:18:45] (03CR) 10Krinkle: [C: 032] Remove unnecessary // eslint-disable-next-line dot-notation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476162 (owner: 10Legoktm) [20:19:25] (03PS3) 10Catrope: RCFilters: Export config vars in the RL modules where possible [core] - 10https://gerrit.wikimedia.org/r/460954 (https://phabricator.wikimedia.org/T201574) [20:19:32] 04(no projects): Interwiki links on sl.wikt Main Page - https://phabricator.wikimedia.org/T210784 (10Janezdrilc) [20:20:54] 10WMCZ-Tracker, 10Patch-For-Review: Add comment button doesn't work on topic_detail - https://phabricator.wikimedia.org/T210769 (10Urbanecm) 05Open>03Resolved a:03takidelfin [20:21:34] (03CR) 10Aklapper: [C: 04-1] "You're close. :)" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [20:21:36] 10CommRel-Documentation, 10Wikimedia-Technical-Conference-2018-Organization, 10CommRel-Specialists-Support (Oct-Dec-2018): Note Taking Feedback: Wikimedia Technical Conference - https://phabricator.wikimedia.org/T198988 (10Rfarrand) 05Open>03Resolved Sounds like we are good to close this! Thank you for a... [20:21:50] (03PS8) 10Catrope: Use packageFiles feature to replace special-purpose RL modules [core] - 10https://gerrit.wikimedia.org/r/471872 [20:22:10] (03CR) 10Legoktm: [C: 04-1] "See inline comment. Do you have npm installed locally? It would be good to test your patches to ensure they work :)" (031 comment) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [20:22:57] (03Merged) 10jenkins-bot: Remove unnecessary // eslint-disable-next-line dot-notation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476162 (owner: 10Legoktm) [20:23:13] 10AbuseFilter, 10Anti-Harassment, 10Wikimedia-Logstash: Slow filters logstash dashboard no longer being updated - https://phabricator.wikimedia.org/T210636 (10MusikAnimal) @Daimona Thanks. Do you know how to filter the AbuseFilter channel so that it only shows the slow filters? [20:23:16] 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10Wargo) [20:23:19] 10MediaWiki-History-or-Diffs: Implement "link-section-edits" user script in MediaWiki itself - https://phabricator.wikimedia.org/T207565 (10Wargo) 05Open>03Resolved a:03Wargo Resolved in T165189 [20:23:33] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Aklapper) [20:23:35] 10Patch-For-Review: LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [20:23:49] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Change language should redirect to the URL user was before clicking it - https://phabricator.wikimedia.org/T210782 (10Urbanecm) https://codein.withgoogle.com/tasks/5812315996815360/ [20:24:11] 10Patch-For-Review: LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [20:25:51] (03CR) 10jenkins-bot: Remove unnecessary // eslint-disable-next-line dot-notation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476162 (owner: 10Legoktm) [20:27:46] (03PS1) 10Yaron Koren: Table striping now done differently based on "merge similar cells" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476614 [20:28:22] 10AbuseFilter, 10Anti-Harassment, 10Wikimedia-Logstash: Slow filters logstash dashboard no longer being updated - https://phabricator.wikimedia.org/T210636 (10Daimona) @MusikAnimal Unfortunately I don't, since I don't have access to logstash. However, looking at the commit message by Krinkle, IIUC you should... [20:28:51] (03CR) 10jerkins-bot: [V: 04-1] Use packageFiles feature to replace special-purpose RL modules [core] - 10https://gerrit.wikimedia.org/r/471872 (owner: 10Catrope) [20:30:43] (03CR) 10jerkins-bot: [V: 04-1] RCFilters: Export config vars in the RL modules where possible [core] - 10https://gerrit.wikimedia.org/r/460954 (https://phabricator.wikimedia.org/T201574) (owner: 10Catrope) [20:31:06] (03CR) 10jerkins-bot: [V: 04-1] Use packageFiles feature to replace special-purpose RL modules [core] - 10https://gerrit.wikimedia.org/r/471872 (owner: 10Catrope) [20:31:41] 10Patch-For-Review: LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [20:33:11] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Anomie) >>! In T210725#4786814, @Krinkle wrote: > * Add the additional overshard keys either before any or after all shard... [20:35:01] 10Patch-For-Review: LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [20:35:51] 10MediaWiki-Database, 10DBA, 10Performance-Team, 10User-Marostegui: Replace parsercache keys to something more meaningful on db-XXXX.php - https://phabricator.wikimedia.org/T210725 (10Marostegui) As we are not in a super rush, we don't we take small moves just to be on the safe side? * Replace the current... [20:36:27] (03Merged) 10jenkins-bot: Follow-up to Search activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476605 (owner: 10Dbrant) [20:38:39] (03CR) 10jenkins-bot: Follow-up to Search activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476605 (owner: 10Dbrant) [20:39:29] (03CR) 10Daimona Eaytoy: Enable restricting certain groups from blocking certain groups. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476439 (https://phabricator.wikimedia.org/T210642) (owner: 10Huji) [20:41:16] (03PS1) 10Esanders: Remove obsolete aliases from closures [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/476616 (https://phabricator.wikimedia.org/T208951) [20:41:18] (03PS1) 10Esanders: build: Update devDependencies [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/476617 [20:43:22] (03PS3) 10TheDJ: textSelection: Use execcommand to replace text [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) [20:43:43] (03CR) 10TheDJ: textSelection: Use execcommand to replace text (031 comment) [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) (owner: 10TheDJ) [20:46:15] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Krinkle) We intentionally removed the toolbar from core with the plan to let core work by default as plainly as possible (basic, but functional). The idea of merging WikiEditor has co... [20:46:27] (03Abandoned) 10Catrope: ResourceLoader: Add "configVars" option to module definitions [core] - 10https://gerrit.wikimedia.org/r/460953 (owner: 10Catrope) [20:46:29] 10MediaWiki-Page-editing, 10TechCom, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Krinkle) [20:47:51] Urbanecm, should the intial configuration be a GCI task? [20:48:00] T210752 [20:48:01] T210752: Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 [20:54:31] (03CR) 10Catrope: [C: 031] "Looks good to me overall, suggestion for fixing the schema version 2 issue inline" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476588 (owner: 10Esanders) [20:54:35] itajara, it can - nothing that's urgent. I'll unassign myself and create a task for it [20:54:41] 10MediaWiki-API: The Action API should allow input in JSON - https://phabricator.wikimedia.org/T210107 (10dbarratt) >>! In T210107#4779326, @Anomie wrote: > So, if we were going to implement this as an API module, I'd recommend: Would you recommend using an API module or a special page? (see T210107#4767038). I... [20:55:04] 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Blocked Externally), 10Epic, 10Patch-For-Review: Deploy refactored actor storage - https://phabricator.wikimedia.org/T188327 (10hashar) [20:55:23] 10Google-Code-in-2018, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Urbanecm) a:05Urbanecm>03None Let's do it as part of #google-code-in-2018 this year. [20:58:48] 04(no projects): No "In other languages" section on sl.wikt Main Page, though listed in Wikidata item - https://phabricator.wikimedia.org/T210784 (10Aklapper) [20:59:18] (03PS2) 10Yaron Koren: Table striping now done differently based on "merge similar cells" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476614 [21:03:57] (03PS28) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [21:04:16] (03CR) 10Yaron Koren: [C: 032] Table striping now done differently based on "merge similar cells" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476614 (owner: 10Yaron Koren) [21:04:45] (03CR) 10Tpt: [C: 032] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:05:19] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/476619 (owner: 10L10n-bot) [21:06:10] 10Google-Code-in-2018, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Urbanecm) https://codein.withgoogle.com/tasks/5700913856512000/ [21:06:20] 10Google-Code-in-2018, 10User-Urbanecm, 10Wiki-Setup (Create): Create Wikisource Neapolitan - https://phabricator.wikimedia.org/T210752 (10Urbanecm) p:05Triage>03Low [21:09:46] (03Merged) 10jenkins-bot: Table striping now done differently based on "merge similar cells" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476614 (owner: 10Yaron Koren) [21:09:48] (03Merged) 10jenkins-bot: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:11:18] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10dbarratt) [21:12:37] (03CR) 10jenkins-bot: Table striping now done differently based on "merge similar cells" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476614 (owner: 10Yaron Koren) [21:12:41] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10dbarratt) In T204991 we've added the method `Block::appliesToNamespace()` which can be used for new entity creation. [21:13:30] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10Kerry_Raymond) I thought it was fixed as I was having no problems for a while... [21:14:42] 10UI-Standardization, 10ProofreadPage, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Jayprakash12345) @Tpt Do you know any other form or HTML input elements, which is used in ProofreadPage [21:14:48] (03CR) 10jenkins-bot: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:15:04] (03CR) 10Raimond Spekking: [V: 032 C: 032] "False positive with an typo. Fixed in https://translatewiki.net/w/i.php?title=MediaWiki:Tags-delete-explanation-active/fi&diff=prev&oldid=" [core] - 10https://gerrit.wikimedia.org/r/476619 (owner: 10L10n-bot) [21:15:34] (03CR) 10Jdlrobson: Hygiene: add test for CtaDrawer (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [21:17:34] 10New-Readers: Execute campaign to promote Android app in Nigeria - https://phabricator.wikimedia.org/T193283 (10atgo) [21:17:40] 10New-Readers: [EPIC] Figure out plans for comms campaigns and product plans for next FY - https://phabricator.wikimedia.org/T193285 (10atgo) [21:17:42] 10New-Readers: Hire designer for new readers - https://phabricator.wikimedia.org/T204002 (10atgo) 05Open>03declined [21:17:45] 10New-Readers: Execute post-campaign survey in Mexico - https://phabricator.wikimedia.org/T193593 (10atgo) a:05DFoy>03ZMcCune [21:17:49] 10New-Readers: Execute post-campaign survey in Mexico - https://phabricator.wikimedia.org/T193593 (10atgo) [21:18:02] (03CR) 10Jdlrobson: [C: 04-1] "I'm not too keen on the approach taken here to test HTML output. It seems a little extreme." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [21:18:09] 10New-Readers: Create & publish 2nd version of Iraq report - https://phabricator.wikimedia.org/T193280 (10atgo) [21:18:11] 10New-Readers: Brown bag for Iraq results - https://phabricator.wikimedia.org/T193304 (10atgo) 05Open>03declined [21:18:22] 10New-Readers: Deliver report of Hindi marketing campaign - https://phabricator.wikimedia.org/T193293 (10atgo) a:03satdeep_gill [21:18:31] 10New-Readers: Develop evaluation framework for awareness campaigns - https://phabricator.wikimedia.org/T193290 (10atgo) [21:18:43] 10New-Readers: Present phone survey research (initial) to Indian community - https://phabricator.wikimedia.org/T193291 (10atgo) 05Open>03declined [21:18:50] 10New-Readers: Select languages/regions for campaigns in next FY - https://phabricator.wikimedia.org/T193286 (10atgo) [21:18:54] 10New-Readers: Select languages/regions for campaigns in next FY - https://phabricator.wikimedia.org/T193286 (10atgo) a:03atgo [21:20:15] 10New-Readers: [EPIC] Hindi awareness campaign - https://phabricator.wikimedia.org/T193292 (10atgo) [21:20:43] 10New-Readers: [EPIC] Figure out plans for comms campaigns and product plans for next FY - https://phabricator.wikimedia.org/T193285 (10atgo) [21:20:46] 10New-Readers: Hire product manager for New Readers - https://phabricator.wikimedia.org/T199945 (10atgo) 05Open>03Resolved [21:20:53] 10UI-Standardization, 10Goal: Convert all extensions/skins to OOUI - https://phabricator.wikimedia.org/T122014 (10Tpt) [21:20:57] 10UI-Standardization, 10ProofreadPage, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Tpt) 05Open>03Resolved a:03Jayprakash12345 I believe everything has been converted. We still have T146160 opened, but it's not related to HTML input... [21:21:12] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:21:33] 10UI-Standardization, 10Goal: Convert all extensions/skins to OOUI - https://phabricator.wikimedia.org/T122014 (10Tpt) [21:22:14] 10UI-Standardization, 10Goal: Convert all extensions/skins to OOUI - https://phabricator.wikimedia.org/T122014 (10Tpt) [21:22:17] 10UI-Standardization, 10OOUI, 10Epic: Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core - https://phabricator.wikimedia.org/T100270 (10Tpt) [21:22:25] 10Wikipedia-App-Generic: Math images have a different background color than the app which looks ugly - https://phabricator.wikimedia.org/T66426 (10Dbrant) [21:23:20] (03CR) 10Esanders: "> but by disabling the $ global it means we're restricting usage of global jQuery anywhere altogether so why would we need it...?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [21:23:47] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:24:28] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:24:43] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:24:55] (03PS2) 10Pcoombe: Fundraising banners for wikipedia.org portal [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/476496 (https://phabricator.wikimedia.org/T202497) [21:25:45] (03PS1) 10Bartosz Dziewoński: Avoid fatals when parent page doesn't exist [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 [21:25:45] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:26:02] (03CR) 10Pcoombe: "Good spot! I went with the overflow-x: hidden, looks fine in Firefox now." [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/476496 (https://phabricator.wikimedia.org/T202497) (owner: 10Pcoombe) [21:26:20] (03PS3) 10Esanders: Remove obsolete aliases from closures [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) [21:26:31] (03CR) 10Esanders: "(PS3 is a rebase)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [21:26:39] (03PS2) 10Bartosz Dziewoński: Avoid fatals when parent page doesn't exist [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) [21:27:19] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10dbarratt) [21:27:52] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10dbarratt) [21:28:08] (03CR) 10Tpt: [C: 032] "Simple change" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/472031 (owner: 10Tpt) [21:31:19] (03PS1) 10Ottomata: Avoid deserializing kafka message if we don't need to [services/eventstreams] - 10https://gerrit.wikimedia.org/r/476753 (https://phabricator.wikimedia.org/T210741) [21:32:50] (03CR) 10Ottomata: "Note that KafkaSSE SSEResponse handles both Strings and Objects when finally sending to clients: https://github.com/wikimedia/KafkaSSE/blo" [services/eventstreams] - 10https://gerrit.wikimedia.org/r/476753 (https://phabricator.wikimedia.org/T210741) (owner: 10Ottomata) [21:33:30] 10MediaWiki-API: Action API should default to origin=* on Wikimedia Wikis - https://phabricator.wikimedia.org/T210790 (10dbarratt) [21:33:44] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/476737 (owner: 10L10n-bot) [21:33:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476629 (owner: 10L10n-bot) [21:34:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/Video] - 10https://gerrit.wikimedia.org/r/476747 (owner: 10L10n-bot) [21:34:27] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/476750 (owner: 10L10n-bot) [21:35:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/476627 (owner: 10L10n-bot) [21:37:17] (03CR) 10Raimond Spekking: [V: 032 C: 032] "false positive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/476750 (owner: 10L10n-bot) [21:37:34] (03CR) 10Bartosz Dziewoński: "This change is ready for review." [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:37:36] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Volans) >>! In T189641#4786808, @Anomie wrote: > Consideration should be given to whether having to maint... [21:38:21] (03CR) 10Raimond Spekking: [C: 032] "false positive" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/476737 (owner: 10L10n-bot) [21:38:27] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload in Chrome - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [21:38:35] (03Merged) 10jenkins-bot: Drops some orphans i18n messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/472031 (owner: 10Tpt) [21:39:13] 10CommRel-Specialists-Support (Oct-Dec-2018): CRS support to host a Remote Edit-a-thon/Edit party for the WMF Design team - https://phabricator.wikimedia.org/T207503 (10CKoerner_WMF) 05Open>03Resolved This was successfully held with about a dozen folks in attendance. [21:39:51] (03PS7) 10Tpt: Implements SlotDiffRenderer for Page: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461527 (https://phabricator.wikimedia.org/T204875) [21:40:01] (03PS3) 10Niedzielski: Hygiene: add test for CtaDrawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) [21:40:17] (03CR) 10Niedzielski: "> I'm not too keen on the approach taken here to test HTML output. It seems a little extreme." (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [21:40:19] (03CR) 10Raimond Spekking: [V: 032 C: 032] "False positive" [extensions/Video] - 10https://gerrit.wikimedia.org/r/476747 (owner: 10L10n-bot) [21:40:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/476619 (owner: 10L10n-bot) [21:41:19] (03CR) 10Krinkle: "(Responding to #2 and #3, which I had notes on already, will think a bit more about the other two.)" [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) (owner: 10Catrope) [21:41:25] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10Verified, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10Ryasmeen) [21:41:37] (03PS3) 10Anomie: Avoid fatals when PoolCounterArticleView fails [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:41:51] 10MediaWiki-General-or-Unknown, 10PHP 7.1 support, 10Security: Remove uses of mcrypt from MediaWiki - https://phabricator.wikimedia.org/T210792 (10MaxSem) [21:41:56] (03CR) 10Anomie: [C: 031] "Virtual +2, if you like the changed commit message" [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:43:12] (03CR) 10Bartosz Dziewoński: [C: 031] Avoid fatals when PoolCounterArticleView fails [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:43:40] 10CommRel-Specialists-Support (Oct-Dec-2018): CRS support to host a Remote Edit-a-thon/Edit party for the WMF Design team - https://phabricator.wikimedia.org/T207503 (10jmatazzoni) And according to Grant Metrics, y’all improved three pages. Congratulations! J _____________________ Joe Matazzoni Product Manag... [21:43:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476757 (owner: 10L10n-bot) [21:44:09] (03CR) 10Anomie: [C: 032] Avoid fatals when PoolCounterArticleView fails [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:44:17] 10New-Readers: Phone surveys for Mexico - https://phabricator.wikimedia.org/T193590 (10atgo) [21:44:19] 10New-Readers: Execute benchmark survey for Mexico - https://phabricator.wikimedia.org/T193592 (10atgo) 05Open>03Resolved [21:44:36] 10New-Readers: [EPIC] Mexico awareness campaign - https://phabricator.wikimedia.org/T193299 (10atgo) [21:44:37] 10New-Readers, 10Spanish-Sites: New custom landing pages for marketing campaign in es.wiki - https://phabricator.wikimedia.org/T200289 (10atgo) 05Open>03Resolved [21:44:39] (03CR) 10Krinkle: [C: 031] "Looks like all the type hints within this class and WikiPage/PoolWorkArticleView all account for this already with false|ParserOutput, so " [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:44:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/476635 (owner: 10L10n-bot) [21:44:46] 10MediaWiki-Watchlist, 10Expiring-Watchlist-Items, 10Growth-Team, 10Community-Wishlist-Survey-2015, and 3 others: Watchlist expiry: Watch pages for a specified time frame (2013) - https://phabricator.wikimedia.org/T100508 (10daniel) This is on the Community Wishlist Survey 2019, and seems to get a lot of s... [21:44:55] 10New-Readers, 10Spanish-Sites: New custom landing pages for marketing campaign in es.wiki - https://phabricator.wikimedia.org/T200289 (10atgo) [21:44:57] 10New-Readers, 10Readers-Web-Backlog: [Spike] How can we use template styles to change the main page on eswiki - https://phabricator.wikimedia.org/T201335 (10atgo) 05Open>03Resolved [21:45:24] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Make 403 responses nicer - https://phabricator.wikimedia.org/T210394 (10takidelfin) {F27326595} [21:47:42] (03CR) 10Jdlrobson: [C: 04-2] "> The problem with this is that you don't get the jQuery plugin rules from the config, so on pages where "/* global $ */" is enabled, user" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [21:49:06] 10Proton, 10Readers-Web-Backlog: Verify that PDFs generated by Proton service are correct - https://phabricator.wikimedia.org/T210793 (10pmiazga) [21:49:08] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10Patch-For-Review, 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10matmarex) @Kerry_Raymond The patch is not deployed yet. I'm about to schedule... [21:49:17] 10Proton, 10Readers-Web-Backlog: Verify that PDFs generated by Proton service are correct - https://phabricator.wikimedia.org/T210793 (10pmiazga) Temporarily assigned to me, I need to verify that both the testing tool is up to date (can handle production service) and the Beta Cluster has the latest proton serv... [21:49:32] 10MediaWiki-Cache: WinCache Bug - Keys (e.g. Headings) with more than 150 characters - https://phabricator.wikimedia.org/T210794 (10osorio-juan-microsoft) [21:49:54] (03CR) 10Jdlrobson: "Can we pull out the template test so we can chew over that some more. The rest looks pretty sound to me." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [21:50:03] (03PS1) 10Takidelfin: HTTP Errors: Add 403 Forbidden error [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476760 (https://phabricator.wikimedia.org/T210394) [21:51:30] 10New-Readers: Complete report for Mexico campaign - https://phabricator.wikimedia.org/T210795 (10atgo) [21:51:45] (03Merged) 10jenkins-bot: Avoid fatals when PoolCounterArticleView fails [extensions/GeoCrumbs] - 10https://gerrit.wikimedia.org/r/476621 (https://phabricator.wikimedia.org/T210734) (owner: 10Bartosz Dziewoński) [21:52:07] 10New-Readers: Complete report for Mexico campaign - https://phabricator.wikimedia.org/T210795 (10atgo) [21:54:00] 10MediaWiki-Database, 10DBA, 10TechCom-RFC: RFC: Proposal to add wl_addedtimestamp attribute to the watchlist table - https://phabricator.wikimedia.org/T209773 (10daniel) @D3r1ck01 is there community support for this idea? Do many people find this useful? It seems pointless to discuss the technical merit of... [21:54:45] (03CR) 10Tpt: "Self +2. The only difference between PS2 reviewed by Tgr is addition of unit tests" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461527 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [21:55:04] (03CR) 10Tpt: [C: 032] Implements SlotDiffRenderer for Page: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461527 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [21:55:08] (03CR) 10Gergő Tisza: "Moved all the non-resolved threads to PS41 to make it easier to keep track of them. They are just nitpicks, except https://gerrit.wikimedi" (0322 comments) [core] - 10https://gerrit.wikimedia.org/r/434544 (https://phabricator.wikimedia.org/T194046) (owner: 10Daniel Kinzler) [21:55:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476648 (owner: 10L10n-bot) [21:55:37] (03PS2) 10Takidelfin: HTTP Errors: Add 403 Forbidden error [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476760 (https://phabricator.wikimedia.org/T210394) [21:56:00] (03PS1) 10Bjornskjald: Fix all lint errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476763 [21:56:25] (03CR) 10Gergő Tisza: "(Gerrit claims there are a few more old unresolved comments but as far as I can tell they don't exist.)" [core] - 10https://gerrit.wikimedia.org/r/434544 (https://phabricator.wikimedia.org/T194046) (owner: 10Daniel Kinzler) [21:56:36] (03CR) 10Tpt: [C: 032] Implements SlotDiffRenderer for Index: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461529 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [21:57:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476650 (owner: 10L10n-bot) [21:59:47] (03Merged) 10jenkins-bot: Implements SlotDiffRenderer for Page: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461527 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [21:59:51] 10VisualEditor (Current work): Apply changes action is enabled on several dialogs before any changes are made - https://phabricator.wikimedia.org/T206000 (10matmarex) [22:00:06] 10VisualEditor (Current work): Apply changes action is enabled on several dialogs before any changes are made - https://phabricator.wikimedia.org/T206000 (10matmarex) [22:00:48] (03PS4) 10Tpt: Refactors Special:PagesWithoutScan to make use of Extension:Disambiguator [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/462400 [22:03:02] (03CR) 10Urbanecm: [C: 032] Fix all lint errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476763 (owner: 10Bjornskjald) [22:03:27] I was granted analytics-privatedata-users access this morning: https://phabricator.wikimedia.org/T209298 but I'm having trouble ssh'ing in. Can I get help here? [22:03:50] (03CR) 10Urbanecm: [C: 032] Fix all lint errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476763 (owner: 10Bjornskjald) [22:03:55] (03Merged) 10jenkins-bot: Fix all lint errors [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476763 (owner: 10Bjornskjald) [22:04:29] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:04:31] (03CR) 10jerkins-bot: [V: 04-1] Implements SlotDiffRenderer for Index: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461529 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [22:04:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/476651 (owner: 10L10n-bot) [22:05:33] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:05:39] oof [22:05:49] Goodbye! [22:05:58] hi ryanmax [22:06:19] ryanmax, what host are you trying to get to? [22:07:20] (03CR) 10Cooltey: [C: 031] Offline feed content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/474800 (https://phabricator.wikimedia.org/T157340) (owner: 10Sharvaniharan) [22:07:25] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:07:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/476658 (owner: 10L10n-bot) [22:08:08] I fixed my access issue. Thank you for your willingness to help, masti [22:08:37] not sure who masti is but okay [22:08:52] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:09:04] sorry. Krenair [22:09:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/476657 (owner: 10L10n-bot) [22:09:26] np [22:10:21] (03CR) 10Urbanecm: [C: 04-1] HTTP Errors: Add 403 Forbidden error (033 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476760 (https://phabricator.wikimedia.org/T210394) (owner: 10Takidelfin) [22:10:55] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:11:47] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:14:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/476661 (owner: 10L10n-bot) [22:15:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/476669 (owner: 10L10n-bot) [22:18:08] (03PS29) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [22:19:44] 10WikiCite: The info on the Citoid gadget does not state the you can paste a QID - https://phabricator.wikimedia.org/T210799 (10Mvolz) [22:21:09] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476667 (owner: 10L10n-bot) [22:21:35] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: add call-to-action and help panel into the editing UI - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) @RHo @kostajh @Trizek-WMF -- I'm getting caught up on this now, and I see four things in the conversation where I wanted weigh in. I... [22:22:54] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/476674 (owner: 10L10n-bot) [22:24:21] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Mvolz) See also: T127354 [22:24:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/476670 (owner: 10L10n-bot) [22:25:15] 10New-Readers: Support Inspire grantees through their projects - https://phabricator.wikimedia.org/T193306 (10atgo) [22:26:12] 10New-Readers: Complete report about Inpsire campaign/Rapid Grants - https://phabricator.wikimedia.org/T210800 (10atgo) [22:26:22] 10New-Readers: Complete report about Inpsire campaign/Rapid Grants - https://phabricator.wikimedia.org/T210800 (10atgo) a:03SGill [22:26:42] 10New-Readers: Support Inspire grantees through their projects - https://phabricator.wikimedia.org/T193306 (10atgo) [22:26:44] 10New-Readers: [EPIC] Inspire campaign to support awareness - https://phabricator.wikimedia.org/T199943 (10atgo) [22:26:46] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Mvolz) [22:27:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/476675 (owner: 10L10n-bot) [22:27:43] 10New-Readers: Roll out Rapid Grants for awareness - https://phabricator.wikimedia.org/T210801 (10atgo) p:05Triage>03Normal [22:27:59] 10Google-Code-in-2018, 10MediaWiki-History-or-Diffs, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): "→" link to page section on History page can be hard to click, should be larger somehow - https://phabricator.wikimedia.org/T165189 (10stjn) Could this be done with saving previous colour by default (unless on ho... [22:28:28] 10New-Readers: Roll out Rapid Grants for awareness - https://phabricator.wikimedia.org/T210802 (10atgo) p:05Triage>03Normal [22:28:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476676 (owner: 10L10n-bot) [22:29:02] 10Proton, 10Readers-Web-Backlog: Verify that PDFs generated by Proton service are correct - https://phabricator.wikimedia.org/T210793 (10ovasileva) p:05Triage>03High [22:29:14] 10Wikimedia-General-or-Unknown, 10Privacy: id.wikipedia's MediaWiki:Common.css sets background-images from a third-party server for some (unused) styles - https://phabricator.wikimedia.org/T210803 (10Aklapper) [22:29:24] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: add call-to-action and help panel into the editing UI - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) [22:29:31] 04(no projects): Citoid remarks from small languge wikis - https://phabricator.wikimedia.org/T210797 (10Susannaanas) [22:29:42] (03PS30) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [22:30:22] 10New-Readers: [EPIC] Inspire campaign to support awareness - https://phabricator.wikimedia.org/T199943 (10atgo) [22:30:37] 10WikiCite: The info on the Citoid gadget does not state the you can paste a QID - https://phabricator.wikimedia.org/T210799 (10Mvolz) a:05Mvolz>03None [22:33:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/476679 (owner: 10L10n-bot) [22:33:31] (03PS1) 10Bartosz Dziewoński: ve.ui.MWCitationDialog: Remove unneeded code re-setting insert label [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476768 [22:33:33] (03PS1) 10Bartosz Dziewoński: ve.ui.MWCitationDialog: Unbreak the logic to enable/disable actions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476769 (https://phabricator.wikimedia.org/T210796) [22:35:17] 10Android-app-feature-Offline, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): UX-enhancement - when there is no connectivity, disable articles list items that are not available offli... - https://phabricator.wikimedia.org/T158852 [22:35:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/476688 (owner: 10L10n-bot) [22:36:07] (03CR) 10Nray: [C: 032] Revert "Revert "Several View's now pass className and isBorderBox as a property"" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:36:16] (03CR) 10Nray: [C: 032] Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:36:24] (03CR) 10Nray: [C: 04-2] Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:38:05] (03CR) 10Nray: [C: 04-1] "Sorry I accidentally hit +2 on my way to replying so then I had to -2. But anyways, when I test this locally I still get SearchOverlay iss" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:39:26] 10Wikimedia-General-or-Unknown, 10Privacy: id.wikipedia's MediaWiki:Common.css sets background-images from a third-party server for some (unused) styles - https://phabricator.wikimedia.org/T210803 (10Krenair) Looks like they get used in Templat:Banner which is transcluded on https://id.wikipedia.org/wiki/Wikip... [22:39:56] (03PS2) 10Bartosz Dziewoński: ve.ui.MWCitationDialog: Unbreak the logic to enable/disable actions [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476769 (https://phabricator.wikimedia.org/T210796) [22:40:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/476698 (owner: 10L10n-bot) [22:41:02] (03CR) 10Nray: "Please see my first +2 for my question. And sorry for the confusion!" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:41:35] 10Wikimedia-General-or-Unknown, 10Privacy: id.wikipedia's MediaWiki:Common.css sets background-images from a third-party server for some (unused) styles - https://phabricator.wikimedia.org/T210803 (10Krenair) Removed the blocks involving nocookie.net, not sure what other steps need to be taken. [22:43:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476692 (owner: 10L10n-bot) [22:45:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476700 (owner: 10L10n-bot) [22:48:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/476697 (owner: 10L10n-bot) [22:49:07] (03CR) 10Jdlrobson: Revert "Revert "Several View's now pass className and isBorderBox as a property"" (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [22:51:33] 10CommRel-Specialists-Support (Oct-Dec-2018), 10Growth-Team (Current Sprint): Help panel: Determine what text and links to show in the help panel on KO and CS wikis - https://phabricator.wikimedia.org/T209297 (10MMiller_WMF) @Trizek-WMF -- in the matrix you made, it looks like (at least in English Wikipedia),... [22:55:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/476706 (owner: 10L10n-bot) [22:59:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/476713 (owner: 10L10n-bot) [23:00:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476711 (owner: 10L10n-bot) [23:01:02] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30): Update EventLogging code to facilitate move to EditAttemptStep schema - https://phabricator.wikimedia.org/T207803 (10Etonkovidova) @Catrope - looking at `EditAttemptStep_18530416` in **betalabs**, columns ended in `_timing` have to ma... [23:01:33] 10Design, 10UI-Standardization, 10Discovery, 10Wikimedia-Portals, and 2 others: Combine input and button on portal into one visual element - https://phabricator.wikimedia.org/T197195 (10Ryasmeen) @Volker_E: Sure, where do you want me to check this? [23:06:48] 10Contributors-Analysis, 10Product-Analytics: Update editor_month generation to use change_tag table rather than tag_summary - https://phabricator.wikimedia.org/T210807 (10Neil_P._Quinn_WMF) [23:08:24] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/476724 (owner: 10L10n-bot) [23:09:19] 10Readers-Web-Backlog: Mark the MobileView API as deprecated - https://phabricator.wikimedia.org/T210808 (10Jdlrobson) p:05Triage>03Normal [23:10:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476716 (owner: 10L10n-bot) [23:10:56] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [23:11:08] 10MediaWiki-API, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Remove noimages transform (was inconsistent parameter names for action=mobileview when you compare with action=parse) - https://phabricator.wikimedia.org/T99009 (10Jdlrobson) Okay I've setup T210808 and have c... [23:11:20] 10Readers-Web-Backlog, 10Epic: [EPIC] Deprecate the MobileView API - https://phabricator.wikimedia.org/T186627 (10Jdlrobson) [23:11:26] 10MediaWiki-API, 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10Technical-Debt: Remove noimages transform (was inconsistent parameter names for action=mobileview when you compare with action=parse) - https://phabricator.wikimedia.org/T99009 (10Jdlrobson) 05Open>03stalled [23:11:52] (03CR) 10Jdlrobson: [C: 04-1] "Let's do https://phabricator.wikimedia.org/T210808 first." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/402130 (https://phabricator.wikimedia.org/T99009) (owner: 10Jdlrobson) [23:11:56] 10MediaWiki-Interface, 10CSS, 10JavaScript: Table of contents' hidden state isn't kept after reload - https://phabricator.wikimedia.org/T210789 (10Jack_who_built_the_house) [23:12:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/476728 (owner: 10L10n-bot) [23:15:27] 10Android-app-feature-Offline, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): UX-enhancement - when there is no connectivity, disable articles list items that are not available offli... - https://phabricator.wikimedia.org/T158852 [23:16:19] 10Proton, 10Readers-Web-Backlog: Verify that PDFs generated by Proton service are correct - https://phabricator.wikimedia.org/T210793 (10ovasileva) [23:16:21] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10ovasileva) [23:17:06] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10ovasileva) [23:19:54] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Platonides) @Joe: That's not a problem. Actually, not using local storage is actually easier. It will sim... [23:23:27] (03CR) 10Catrope: [C: 04-1] "Still reviewing, but saving my comments in the meantime" (039 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [23:27:27] (03CR) 10Rafidaslam: New version 1.2 (031 comment) [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/476457 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [23:27:27] 10Technical-Tool-Request: Create SparqlBlocks-based Wikidata tutorial - https://phabricator.wikimedia.org/T210810 (10Tgr) [23:28:06] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10MMiller_WMF) @kostajh @RHo @Trizek-WMF -- some things I would like to weigh in on: * The requirements say "Tag the post as coming from the help panel so t... [23:30:55] 10Growth-Team (Current Sprint), 10Patch-For-Review: Help panel: allow users to "Ask a question" to help desk - https://phabricator.wikimedia.org/T209318 (10MMiller_WMF) [23:31:02] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: add test for CtaDrawer (034 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476607 (https://phabricator.wikimedia.org/T208920) (owner: 10Niedzielski) [23:32:00] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: Personalized first day: build Variation A - https://phabricator.wikimedia.org/T206371 (10MMiller_WMF) @SBisson -- @Etonkovidova found that the survey does not work for no-JS users. Is that a bug? [23:33:00] 10Technical-Tool-Request: Create SparqlBlocks-based Wikidata tutorial - https://phabricator.wikimedia.org/T210810 (10Tgr) Some time ago I tried to set up the tool at Toolforge ([[https://toolsadmin.wikimedia.org/tools/id/sparqlblocks|sparqlblocks]]) but never had time to get off the ground. [23:35:02] (03PS3) 10Jdlrobson: Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) [23:35:19] (03CR) 10jerkins-bot: [V: 04-1] Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [23:35:53] (03PS2) 10Jdlrobson: Prepare View's for option usage rather than class property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476426 (https://phabricator.wikimedia.org/T210670) [23:37:07] (03PS3) 10Jdlrobson: Prepare View's for option usage rather than class property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476426 (https://phabricator.wikimedia.org/T210670) [23:37:09] (03PS4) 10Jdlrobson: Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) [23:37:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/476741 (owner: 10L10n-bot) [23:38:27] 10MediaWiki-User-management, 10Anti-Harassment: If a user/IP combo is partially/sitewide (overlapping) blocked, always enforce the sitewide block - https://phabricator.wikimedia.org/T206163 (10TBolliger) >>! In T206163#4786793, @dbarratt wrote: > The user could have two overlapping partial blocks... and I thin... [23:39:21] 10MediaWiki-User-management, 10Anti-Harassment: If a user/IP combo is partially/sitewide (overlapping) blocked, always enforce the sitewide block - https://phabricator.wikimedia.org/T206163 (10TBolliger) p:05Triage>03Normal [23:39:42] (03CR) 10jenkins-bot: Implements SlotDiffRenderer for Page: pages content model [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/461527 (https://phabricator.wikimedia.org/T204875) (owner: 10Tpt) [23:41:33] (03PS1) 10MaxSem: There's no need to load user properties here [extensions/GlobalUserPage] - 10https://gerrit.wikimedia.org/r/476778 [23:41:48] (03CR) 10jenkins-bot: Drops some orphans i18n messages [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/472031 (owner: 10Tpt) [23:43:28] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: experiments - https://phabricator.wikimedia.org/T206720 (10MMiller_WMF) [23:43:49] 10QuickSurveys, 10Mobile, 10Readers-Web-Backlog (Tracking): Quick survey won't show up on mobile - https://phabricator.wikimedia.org/T210646 (10Jdlrobson) [23:44:11] 10QuickSurveys, 10Readers-Web-Backlog (Tracking): Loading a specific survey doesn't work - https://phabricator.wikimedia.org/T210613 (10Jdlrobson) [23:44:28] 10Product-Analytics, 10Growth-Team (Current Sprint): Help panel: experiments - https://phabricator.wikimedia.org/T206720 (10MMiller_WMF) a:05MMiller_WMF>03nettrom_WMF Thanks, @RHo. I added one additional experiment that I could think of. The next step is for @nettrom_WMF to think this through and propose... [23:45:05] 10Design, 10MonoBook, 10CSS, 10Readers-Web-Backlog (Design): Something strange with a:visited link color in Monobook skin - https://phabricator.wikimedia.org/T191401 (10Jdlrobson) p:05Triage>03Low [23:45:27] 10UI-Standardization, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Revisit different color of links for internal (inner-domain) and interwiki/external links - https://phabricator.wikimedia.org/T178862 (10Jdlrobson) p:05Triage>03Low [23:45:44] 10UI-Standardization, 10Wikimedia Design Style Guide, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Revisit different color of links for internal (inner-domain) and interwiki/external links - https://phabricator.wikimedia.org/T178862 (10Jdlrobson) p:05Low>03Triage [23:46:37] (03PS1) 10BryanDavis: Remove usage of mcrypt_create_iv [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476782 [23:46:39] (03PS1) 10BryanDavis: Bump mediawiki/mediawiki-codesniffer [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476783 [23:46:40] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Goal: [GOAL] Advanced mobile contributions - https://phabricator.wikimedia.org/T198313 (10Jdlrobson) [23:46:42] 10Design, 10MobileFrontend, 10WMF-Design, 10Readers-Web-Backlog (Design): Summary of activity at the top of mobile history page - https://phabricator.wikimedia.org/T94297 (10Jdlrobson) [23:47:02] (03CR) 10jerkins-bot: [V: 04-1] Remove usage of mcrypt_create_iv [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476782 (owner: 10BryanDavis) [23:47:03] 10Design, 10MobileFrontend, 10WMF-Design, 10Readers-Web-Backlog (Design): Summary of activity at the top of mobile history page - https://phabricator.wikimedia.org/T94297 (10Jdlrobson) p:05Triage>03Low This should either be folded into something we can do as part of AMC or declined. [23:47:22] 10UI-Standardization, 10Collection, 10Mobile, 10Readers-Web-Backlog (Design): Warning box inconsistent on collections view - https://phabricator.wikimedia.org/T166740 (10Jdlrobson) p:05Triage>03Low [23:47:49] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Goal: [GOAL] Advanced mobile contributions - https://phabricator.wikimedia.org/T198313 (10Jdlrobson) [23:47:51] 10Design, 10MobileFrontend, 10Readers-Web-Backlog (Design): Table of contents does not appear in mobile site - https://phabricator.wikimedia.org/T147026 (10Jdlrobson) [23:48:11] 10Design, 10MobileFrontend, 10Readers-Web-Backlog (Design): Table of contents does not appear in mobile site - https://phabricator.wikimedia.org/T147026 (10Jdlrobson) p:05Triage>03Normal TOC is important to advanced editors so should probably be considered as part of the project. [23:48:27] (03PS2) 10BryanDavis: Bump mediawiki/mediawiki-codesniffer [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476783 [23:48:29] (03PS2) 10BryanDavis: Remove usage of mcrypt_create_iv [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476782 [23:48:39] 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Design): Provide immediate and consistent feedback when tapping elements on MW - https://phabricator.wikimedia.org/T189147 (10Jdlrobson) p:05Triage>03Normal [23:51:10] 10MediaWiki-User-management, 10MobileFrontend, 10Anti-Harassment, 10Readers-Web-Backlog (Tracking): Better handle block reasons on mobile (specifically templates and HTML comments) - https://phabricator.wikimedia.org/T189717 (10Jdlrobson) @TBolliger I'm still confused. This bug was raised by you and my tea... [23:52:47] 10MinervaNeue, 10Design (RW-Design-Debt), 10Readers-Web-Backlog (Design): Contents icon should feature an icon color aligned with text - https://phabricator.wikimedia.org/T183269 (10Jdlrobson) p:05Triage>03Low @Volker_E was this fixed? I see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/MobileF... [23:53:49] 10Design, 10MobileFrontend, 10Wikimedia-Interwiki-links, 10Readers-Web-Backlog (Design): On MobileFrontend, don't split to Suggested and All languages when the number of languages is very small - https://phabricator.wikimedia.org/T190281 (10Jdlrobson) p:05Triage>03Normal Remember suggested languages is... [23:53:59] (03CR) 10BryanDavis: "Trivial (mostly for PHP 7.3 testing support)" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476783 (owner: 10BryanDavis) [23:54:56] (03CR) 10Platonides: "Not that this reference to mcrypt_create_iv() could have caused any problem, as it is properly guarded in a function_exists() Moreover, on" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476782 (owner: 10BryanDavis) [23:58:15] (03CR) 10BryanDavis: "> Not that this reference to mcrypt_create_iv() could have caused any" [wikimedia/slimapp] - 10https://gerrit.wikimedia.org/r/476782 (owner: 10BryanDavis)