[00:00:14] 10SVG Translate Tool: Allow user to upload translated file to Commons - https://phabricator.wikimedia.org/T210564 (10Niharika) [00:00:38] 10MediaWiki-User-management, 10Anti-Harassment: Allow a user to be blocked from creating pages only - https://phabricator.wikimedia.org/T199918 (10TBolliger) [00:02:22] 10Anti-Harassment, 10Product-Analytics: AHT: Implement monthly reports about Block usage - https://phabricator.wikimedia.org/T206021 (10TBolliger) [00:02:24] 10Anti-Harassment, 10Product-Analytics: AHT: Implement monthly reports about ANI and other abuse-reporting venues - https://phabricator.wikimedia.org/T206025 (10TBolliger) [00:03:52] (03CR) 10EBernhardson: [C: 032] Protect legacy URL parameter syntax in link and alt options [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [00:04:33] 10WMCZ-Tracker: Implement autocompleted feature for comments mentions - https://phabricator.wikimedia.org/T210565 (10Urbanecm) [00:04:55] 10WMCZ-Tracker: Allow normal user to do things they are allowed to do in frontend in API as well - https://phabricator.wikimedia.org/T206603 (10Urbanecm) [00:04:57] 10WMCZ-Tracker: Implement autocompleted feature for comments mentions - https://phabricator.wikimedia.org/T210565 (10Urbanecm) [00:05:25] 10WMCZ-Tracker: Implement autocompleted feature for comments mentions - https://phabricator.wikimedia.org/T210565 (10Urbanecm) Would need an API working. [00:11:10] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10WikiEditor, 10Performance: CodeMirror should not completely load when disabled in WikiEditor - https://phabricator.wikimedia.org/T209824 (10Niharika) [00:11:13] 10ContentTranslation, 10WorkType-Maintenance: Formatting bar is not visible when text below image is being translated - https://phabricator.wikimedia.org/T118244 (10Etonkovidova) 05Open>03declined cx1 - The editing controls (**B**, //I//) are not display when a user just clicks inside the text under the im... [00:14:45] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Legoktm) I wrote a simple HTTP API wrapper around `sgrep` at https://git.legoktm.com/legoktm/PawnedPasswo... [00:17:01] (03CR) 10jerkins-bot: [V: 04-1] Protect legacy URL parameter syntax in link and alt options [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [00:17:33] (03CR) 10EBernhardson: [C: 032] "test failure is npm intermittent wokiness, unrelated." [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [00:18:43] (03CR) 10DLynch: Debug flag for EditAttemptStep tracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [00:19:48] 10MediaWiki-extensions-Page_Forms, 10Browser-Support-Internet-Explorer: Semantic Forms, HeaderTabs and WikiEditor not working together well with IE - https://phabricator.wikimedia.org/T68201 (10Yaron_Koren) I suppose... I don't know what the statute of limitations is for IE bugs. [00:19:54] (03PS2) 10DLynch: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 [00:20:17] (03PS3) 10DLynch: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 [00:20:47] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10StructuredDiscussions, and 2 others: Fix `.mw-ui-icon` with overhauled icon canvas sizes - https://phabricator.wikimedia.org/T191021 (10Volker_E) From conversation with @Jdlrobson today, he would not want to see a possible regression so... [00:30:02] 10Contributors-Analysis, 10Product-Analytics: Calculate monthly mobile Wikipedia edits for Major Gifts report - https://phabricator.wikimedia.org/T209889 (10JCuriel) @Neil_P._Quinn_WMF Thanks so much! Really appreciate your help on this. Makes all the differnence! [00:37:44] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Petar.petkovic) [00:41:25] (03Merged) 10jenkins-bot: Protect legacy URL parameter syntax in link and alt options [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [00:47:33] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476185 [00:47:42] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476185 (owner: 10Ejegg) [00:47:50] 10Core Platform Team Kanban, 10Core Platform Team (PHP7 (TEC4)), 10PHP 7.2 support: Create a way to intentionally trigger fatal errors in MediaWiki - https://phabricator.wikimedia.org/T210567 (10BPirkle) [00:48:39] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10diego) @bmansurov , eyeballing I can say: - The **92% **of cases are "especie de plantas (species of plant)", I don't have the knowledge to say if they are duplicated or not, but my first try would be... [00:50:57] (03PS1) 10EBernhardson: Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 [00:51:04] (03CR) 10EBernhardson: [C: 032] Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 (owner: 10EBernhardson) [00:52:22] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476185 (owner: 10Ejegg) [00:57:10] 10MediaWiki-extensions-Page_Forms: Red links to Talks namespaces must not use the FormChooser when $wgPageFormsLinkAllRedLinksToForms = true; - https://phabricator.wikimedia.org/T209520 (10Yaron_Koren) 05Open>03Resolved a:03Yaron_Koren Good point - I just checked in a change for this, so now it only applie... [00:57:55] (03PS1) 10Krinkle: Override supportsURLLoading() instead of getScriptURLsForDebug() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476187 [00:58:40] 04(no projects): $wgNamespacePermissionLockdown doesn't work for the createpage right - https://phabricator.wikimedia.org/T210568 (10MarkAHershberger) [00:59:55] 04(no projects): $wgNamespacePermissionLockdown doesn't work for the createpage right - https://phabricator.wikimedia.org/T210568 (10MarkAHershberger) 05Open>03Resolved Ah! I had to specify ` $wgNamespacePermissionLockdown[NS_TIP]['edit'] = [ '*' ]; ` to get it to work. [01:01:38] 10MediaWiki-Parser, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Arlolra) @cscott Unfortunately, I wasn't able to conf... [01:05:29] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Tracking): [EPIC] Proposal: abandon use of template partials in MobileFrontend - https://phabricator.wikimedia.org/T149909 (10Jdlrobson) From https://github.com/developit/vhtml > New: "Sortof" Components! > vhtml intention... [01:05:58] (03CR) 10Jdlrobson: [C: 031] "LGTM" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [01:06:22] (03CR) 10jerkins-bot: [V: 04-1] Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 (owner: 10EBernhardson) [01:06:52] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10Patch-For-Review, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10Ryasmeen) [01:09:03] (03CR) 10Jdlrobson: [C: 032] Use the 'csrf' token to authenticate post requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475831 (https://phabricator.wikimedia.org/T188451) (owner: 10LukBukkit) [01:09:31] (03PS8) 10Cooltey: [WIP] Fix: Chinese variants issues that title on the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 [01:09:57] (03PS7) 10Jdlrobson: Allow users to change their mobile skin preference (take 2) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451807 (https://phabricator.wikimedia.org/T173527) [01:10:35] (03CR) 10Daniel Kinzler: Move queries for first/prev/next revision into RevisionStore. (034 comments) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [01:10:52] (03PS5) 10Daniel Kinzler: Move queries for first/prev/next revision into RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/475467 [01:12:20] 10MediaWiki-API, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (10Jdlrobson)... [01:14:31] 10MediaWiki-Parser, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10cscott) https://en.wikipedia.org/wiki/User:Cscott/T20... [01:14:50] (03CR) 10EBernhardson: [C: 032] Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 (owner: 10EBernhardson) [01:19:30] (03PS2) 10Legoktm: Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 [01:22:48] (03CR) 10EBernhardson: [C: 04-2] Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 (owner: 10EBernhardson) [01:23:39] 10MediaWiki-Parser, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Arlolra) > I think you forgot to purge the parser cac... [01:24:43] (03Merged) 10jenkins-bot: Use the 'csrf' token to authenticate post requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475831 (https://phabricator.wikimedia.org/T188451) (owner: 10LukBukkit) [01:25:51] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10Sharvaniharan) Thank you so much @cmadeo ! will wrap this up now :) [01:26:43] (03CR) 10Tim Starling: [C: 032] SQLite: Make patch-add-3d.sql a no-op [core] - 10https://gerrit.wikimedia.org/r/475114 (owner: 10Anomie) [01:26:46] (03Abandoned) 10EBernhardson: Revert "Protect legacy URL parameter syntax in link and alt options" [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476186 (owner: 10EBernhardson) [01:28:15] (03CR) 10jenkins-bot: Use the 'csrf' token to authenticate post requests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475831 (https://phabricator.wikimedia.org/T188451) (owner: 10LukBukkit) [01:30:17] (03CR) 10jerkins-bot: [V: 04-1] Move queries for first/prev/next revision into RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [01:32:50] 10MediaWiki-Parser, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Arlolra) > The oldid for the page I was rendering is... [01:41:24] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Performance-Team (Radar): Unused MobileFrontend/Minerva variables loaded on desktop/Vector page views - https://phabricator.wikimedia.org/T186062 (10Krinkle) @Jdlrobson I'm not sure this needs to be bloc... [01:41:41] (03CR) 10jerkins-bot: [V: 04-1] Move queries for first/prev/next revision into RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [01:42:16] (03Merged) 10jenkins-bot: SQLite: Make patch-add-3d.sql a no-op [core] - 10https://gerrit.wikimedia.org/r/475114 (owner: 10Anomie) [01:44:55] (03CR) 10jenkins-bot: SQLite: Make patch-add-3d.sql a no-op [core] - 10https://gerrit.wikimedia.org/r/475114 (owner: 10Anomie) [01:46:35] 10MediaWiki-API, 10Quibble, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (... [01:53:55] (03PS1) 10Jdlrobson: QA: Tagging changes from beta cluster [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476190 [01:54:11] 10MediaWiki-API, 10Quibble, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (... [01:54:25] (03CR) 10Jdlrobson: [C: 032] "Making tag changes. Want to make sure the build is green and clean before thursday's deploy." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476190 (owner: 10Jdlrobson) [01:57:26] 10MediaWiki-API, 10Quibble, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (... [02:03:22] (03CR) 10Tim Starling: [C: 032] Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) (owner: 10Anomie) [02:04:52] (03CR) 10Catrope: [C: 032] Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 (owner: 10Legoktm) [02:08:10] 10Google-Code-in-2018, 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, and 3 others: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10Jdlrobson) [02:09:02] (03Merged) 10jenkins-bot: QA: Tagging changes from beta cluster [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476190 (owner: 10Jdlrobson) [02:17:08] 10MediaWiki-extensions-Page_Forms, 10Wikimedia Australia: Show nicer error message for incorrect timezones (input type=datetime|include timezone) - https://phabricator.wikimedia.org/T210343 (10Yaron_Koren) 05Open>03Resolved a:03Yaron_Koren Sorry about that. This was a pretty recent bug... I just checked... [02:17:35] (03CR) 10jerkins-bot: [V: 04-1] Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) (owner: 10Anomie) [02:17:37] (03CR) 10jenkins-bot: QA: Tagging changes from beta cluster [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476190 (owner: 10Jdlrobson) [02:19:51] (03Merged) 10jenkins-bot: Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 (owner: 10Legoktm) [02:25:20] (03CR) 10jenkins-bot: Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 (owner: 10Legoktm) [02:32:42] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): ResourceLoader: It should be possible to define per module config variables - https://phabricator.wikimedia.org/T210035 (10Krinkle) A similar idea was proposed by Roan at 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): Per-module data exports from the server-side in ResourceLoader (e.g. configuration) - https://phabricator.wikimedia.org/T210035 (10Krinkle) p:05High>03Normal [02:33:44] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team (Radar), 10Readers-Web-Backlog (Tracking): Per-module data exports from the server-side in ResourceLoader (e.g. configuration) - https://phabricator.wikimedia.org/T210035 (10Krinkle) [02:33:50] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team, 10Patch-For-Review, and 2 others: Provide standard-compatible way to load multi-file packages (not plain concatenation) - https://phabricator.wikimedia.org/T133462 (10Krinkle) [02:34:04] 10MediaWiki-ResourceLoader, 10Front-end-Standards-Group, 10Performance-Team, 10Readers-Web-Backlog (Tracking): Per-module data exports from the server-side in ResourceLoader (e.g. configuration) - https://phabricator.wikimedia.org/T210035 (10Krinkle) [02:36:33] (03PS2) 10Sharvaniharan: Create custom dialog with image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475946 (https://phabricator.wikimedia.org/T209511) [02:39:27] 10MediaWiki-extensions-Page_Forms, 10Wikimedia Australia: Show nicer error message for incorrect timezones (input type=datetime|include timezone) - https://phabricator.wikimedia.org/T210343 (10Yaron_Koren) By the way, a dropdown or autocompletion for the timezone input makes sense... it just seems like there a... [02:40:44] 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: A/B testing plan for wbsearchentities, context=item - https://phabricator.wikimedia.org/T209402 (10EBernhardson) Test is shipped out. 10% of english item searches will use the newly tuned parameters. Another 10... [02:46:17] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: add easier export with attribution - https://phabricator.wikimedia.org/T210219 (10Gryllida) Hello @Aklapper and thank you for your assessment. However media viewer has a button 'show me how' for showing how to attribute. It also has the button to download... [02:46:33] 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Milimetric) The undefined line is due to an empty newline at the end of the file, I'll fix it as a bug in dashiki and deploy your dashboard again, n... [02:49:55] 10Discovery-Search (Current work), 10Patch-For-Review: Build pipeline to transform elastic explains into feature vectors and a tf graph - https://phabricator.wikimedia.org/T208917 (10EBernhardson) Not sure it would be worth figuring out, but I realized while testing the deployed AB code that this model doesn't... [02:53:48] (03CR) 10Gopavasanth: "> Just to be clear, this is the icon in question: https://phabricator.wikimedia.org/F27318923" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476051 (https://phabricator.wikimedia.org/T90414) (owner: 10Gopavasanth) [03:11:22] 10MediaWiki-Change-tagging, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), and 3 others: Duplicate entry 'emoji' for key 'ctd_name' - https://phabricator.wikimedia.org/T201934 (10Krinkle) [03:30:43] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: keep history of copied images - https://phabricator.wikimedia.org/T210220 (10Gryllida) Thanks, I guess for multiple images the gadget could export to bibtex or similar. I will follow it up with them. [03:31:48] (03PS1) 10Yaron Koren: Ignore red-linked topics in non-draft manuals [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476196 [03:36:06] (03PS1) 10Tim Starling: Add aggregateByFunction() and other new features [php/excimer] - 10https://gerrit.wikimedia.org/r/476197 [03:36:40] (03CR) 10jerkins-bot: [V: 04-1] Add aggregateByFunction() and other new features [php/excimer] - 10https://gerrit.wikimedia.org/r/476197 (owner: 10Tim Starling) [03:40:21] (03PS2) 10Yaron Koren: Ignore red-linked topics in non-draft manuals [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476196 [03:43:10] (03PS2) 10Tim Starling: Add aggregateByFunction() and other new features [php/excimer] - 10https://gerrit.wikimedia.org/r/476197 [03:43:52] (03PS1) 10Tim Starling: Add ProfilerExcimer [core] - 10https://gerrit.wikimedia.org/r/476198 [03:48:02] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Tgr) According to Logstash there are about 10 logins and account creations per second. (Grafana seems to... [03:48:39] (03CR) 10Yaron Koren: [C: 032] Ignore red-linked topics in non-draft manuals [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476196 (owner: 10Yaron Koren) [03:54:20] (03Merged) 10jenkins-bot: Ignore red-linked topics in non-draft manuals [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476196 (owner: 10Yaron Koren) [04:01:07] (03CR) 10jerkins-bot: [V: 04-1] Add ProfilerExcimer [core] - 10https://gerrit.wikimedia.org/r/476198 (owner: 10Tim Starling) [04:05:43] 10MediaWiki-History-or-Diffs: add navigation to diff viewer - https://phabricator.wikimedia.org/T210572 (10Gryllida) [04:28:10] 10MediaWiki-extensions-Page_Forms, 10Wikimedia Australia: Show nicer error message for incorrect timezones (input type=datetime|include timezone) - https://phabricator.wikimedia.org/T210343 (10Samwilson) I see that SMW defines its own list of timezones. Maybe PF could do something similar, but generate them f... [04:48:22] (03CR) 10Gergő Tisza: Move queries for first/prev/next revision into RevisionStore. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [05:23:06] (03CR) 10Samwilson: [C: 04-1] Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [05:24:57] (03CR) 10EBernhardson: [C: 032] "great first steps. The name handling seems sane enough, and the tests pass. No loss removing 'tfNorm' from the names, that's really a luce" (031 comment) [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/475107 (https://phabricator.wikimedia.org/T209485) (owner: 10DCausse) [05:26:01] (03Merged) 10jenkins-bot: Add support for multiple rescore queries [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/475107 (https://phabricator.wikimedia.org/T209485) (owner: 10DCausse) [05:34:26] (03CR) 10EBernhardson: [C: 031] "seems fine to merge" (032 comments) [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/475502 (https://phabricator.wikimedia.org/T209485) (owner: 10DCausse) [05:35:32] 10Security-Team: Reset 2FA code for 'nakon' on en.wiki - https://phabricator.wikimedia.org/T210573 (10Nakon) [05:47:27] 10Security-Team, 10Trust-and-Safety: Reset 2FA code for 'nakon' on en.wiki - https://phabricator.wikimedia.org/T210573 (10JJMC89) [05:52:47] o/ [05:53:43] framawiki, d3r1ck: Could you review my patch? https://gerrit.wikimedia.org/r/c/pywikibot/core/+/476106 [05:53:43] ~o~ [05:55:19] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) By default, Is it possible to upload file using oauthclient-php library? I am stuck here. Unable to upload any file. Here is the request a... [06:07:13] (03PS4) 10Dmaza: Add block notice stats on EditPage. [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) [06:07:18] 10MediaWiki-Database, 10DBA, 10Scoring-platform-team, 10Blocked-on-schema-change, and 2 others: Schema change for rc_this_oldid index - https://phabricator.wikimedia.org/T202167 (10Marostegui) [06:10:54] 10MediaWiki-User-preferences, 10OOUI, 10Browser-Support-Firefox: Scrolling in the rcdays input field in the preferences leads to decimal value with lots of digits - https://phabricator.wikimedia.org/T210574 (10Fomafix) [06:11:45] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Joe) >>! In T189641#4779787, @Legoktm wrote: > I wrote a simple HTTP API wrapper around `sgrep` at https:... [06:12:03] (03CR) 10Dmaza: "> Patch Set 2:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472376 (https://phabricator.wikimedia.org/T201719) (owner: 10Dmaza) [06:12:41] (03Abandoned) 10Dmaza: Change key for storing metrics when tracking block notices [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472376 (https://phabricator.wikimedia.org/T201719) (owner: 10Dmaza) [06:17:37] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10MaxSem) Uh, just stick it into MySQL and be done with it? :P [06:22:55] :/ [06:30:14] (03CR) 10Samwilson: Use custom overlay for help popups (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [06:32:27] 10MediaWiki-extensions-ORES, 10Scoring-platform-team, 10Performance: Clean up ORES thresholds cache: pre-emptively check before expiry - https://phabricator.wikimedia.org/T182256 (10Ladsgroup) p:05Triage>03Normal [06:33:01] takidelfin: :wave: [06:33:05] (03PS7) 10Dmaza: Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) [06:33:10] o/ [06:33:59] (03CR) 10jerkins-bot: [V: 04-1] Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) (owner: 10Dmaza) [06:34:38] (03PS8) 10Dmaza: Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) [06:38:10] 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Scoring-platform-team: ORES "is model really enabled?" PHP API - https://phabricator.wikimedia.org/T205323 (10Ladsgroup) p:05Triage>03Normal [06:38:26] 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Scoring-platform-team: ORES "is model really enabled?" PHP API - https://phabricator.wikimedia.org/T205323 (10Ladsgroup) p:05Normal>03Triage [06:39:29] 10Design, 10JADE, 10Scoring-platform-team: Find way to re-surface judgments for continuous evaluation - https://phabricator.wikimedia.org/T204064 (10Ladsgroup) p:05Low>03Triage [06:41:04] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Hindi-Sites, 10Patch-For-Review, and 2 others: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias - https://phabricator.wikimedia.org/T206497 (10Legoktm) +#wikimedia-site-requests since this is a request for a configurat... [06:42:22] 10MediaWiki-extensions-ORES, 10Growth-Team, 10Scoring-platform-team: RC filters: Un-scored Bot edits in Namespaces displayed with ORES full-coverage filters - https://phabricator.wikimedia.org/T206271 (10Ladsgroup) [07:04:31] takidelfin[znc]: i found nathan's github acc [07:04:57] (03PS3) 10Ladsgroup: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) [07:05:10] (03CR) 10Ladsgroup: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [07:08:21] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) @0x010C I have tried your patch. First error after adding your patch is > http_build_query(): Parameter 1 expected to be Array or Obje... [07:11:20] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06): Translate extension language bar not reliably showing how complete a translation is - https://phabricator.wikimedia.org/T208521 (10Nikerabbit) It looks fine to me, so I believe it i... [07:15:49] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) I have checked again and see that if I am changing the file parameter from from ` 'file' => file_get_contents($path), ` to ` 'file' => n... [07:26:45] hi [07:31:38] (03CR) 10Daimona Eaytoy: [C: 032] Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [07:36:50] my guess: josh_ was a new gci student who wished to complete the "get onto irc task" but didn't read the instructions carefully enough to know that they have to stick around for an hour [07:48:02] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Joe) >>! In T189641#4780088, @MaxSem wrote: > Uh, just stick it into MySQL and be done with it? :P Well,... [07:52:10] (03Merged) 10jenkins-bot: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [07:55:40] (03CR) 10jenkins-bot: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [07:57:25] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Browser tests for TemplateWizard - https://phabricator.wikimedia.org/T199580 (10Samwilson) It was failing just for fun I think. I rechecked, and all is well. :... [07:59:53] 10Dumps-Generation: Generate IPFS snapshots (via HTML dumps) - https://phabricator.wikimedia.org/T210413 (10Nemo_bis) The test instance currently causes trouble: https://github.com/ipfs/distributed-wikipedia-mirror/issues/55 https://github.com/ipfs/distributed-wikipedia-mirror/issues/48 . Is there a way to prev... [08:09:41] 10MediaWiki-Change-tagging, 10User-Ladsgroup: Tag filtering timeouts on the order of 100,000 revisions - https://phabricator.wikimedia.org/T27083 (10Ladsgroup) 05Open>03Resolved a:03Ladsgroup Not happening anymore. Due to all of fixes happened to change_tag :) [08:11:11] (03PS3) 10Fomafix: Parser: Apply markNoConversion only when language conversion is active [core] - 10https://gerrit.wikimedia.org/r/470255 (https://phabricator.wikimedia.org/T208145) [08:11:38] 10ContentTranslation: Update Youdao MT client to new API - https://phabricator.wikimedia.org/T210578 (10santhosh) [08:12:26] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Update Youdao MT client to new API - https://phabricator.wikimedia.org/T210578 (10santhosh) p:05Triage>03Normal [08:13:02] 10MediaWiki-Cache, 10Operations, 10Patch-For-Review, 10Performance-Team (Radar), 10User-Elukey: Apply -R 200 to all the memcached mw object cache instances running in eqiad/codfw - https://phabricator.wikimedia.org/T208844 (10elukey) [08:13:49] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10TestMe: Database error when filtering page log - https://phabricator.wikimedia.org/T136687 (10Ladsgroup) Isn't this done already? I can't see any errors when I open the link. Very likely because of T185355 and T209525 [08:16:01] 10MediaWiki-Change-tagging, 10MediaWiki-Installer, 10MW-1.32-release: update.php is super-slow thanks to populateChangeTagDef.php - https://phabricator.wikimedia.org/T206568 (10Ladsgroup) hmm, if there is already tags to be populated, it makes sense to have it to avoid read-only in non-WMF prod. [08:19:35] 10Trust-and-Safety: Reset 2FA code for 'nakon' on en.wiki - https://phabricator.wikimedia.org/T210573 (10Aklapper) [08:20:10] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: Convert inline templates into text if equivalent template is missing - https://phabricator.wikimedia.org/T204942 (10santhosh) a:05santhosh>03None > In order to support this what's proposed is for the plain te... [08:23:12] 10CX-cxserver, 10Language-Team (Language-2018-October-December): Use rate-limiter for cxserver - https://phabricator.wikimedia.org/T210581 (10KartikMistry) [08:28:26] 10Google-Code-in-2018, 10MediaWiki-extensions-MultimediaViewer, 10Multimedia, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Use of SVG nominal size in MMV - https://phabricator.wikimedia.org/T71237 (10Tgr) @Johan I forgot about the notice and the patch went out this week but probably better lat... [08:29:30] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10User-Tgr: Port CentralAuth Selenium tests from Ruby to Node - https://phabricator.wikimedia.org/T173989 (10Tgr) I don't know who else is getting the warning; I don't mind having a daily reminder that this needs to be done. [08:29:36] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10MaxSem) Sgrep is just binary search, databases have indexes for that. [08:30:52] (03PS3) 100x010C: Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) [08:30:58] (03CR) 10jerkins-bot: [V: 04-1] Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [08:43:54] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Incorporate 404 and 500 messages better in Tracker's interface - https://phabricator.wikimedia.org/T210395 (10Urbanecm) 05Open>03Resolved [08:44:53] 10ContentTranslation: CX2: Reference in infobox not displayed in Reference section - https://phabricator.wikimedia.org/T210563 (10santhosh) [08:44:55] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10santhosh) [08:49:19] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Internacionalize notifications - https://phabricator.wikimedia.org/T196425 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/6538611391463424/ and I will mentor it. [08:52:53] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Show reset option in the MT card only when the paragraph has been modified - https://phabricator.wikimedia.org/T196051 (10Pginer-WMF) [08:54:57] (03PS4) 10Pwirth: TitleTargetCache ERM:12692 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/474740 [09:10:37] 10donate.wikimedia.org: Donation leads to missing Thank you/vi page - https://phabricator.wikimedia.org/T210587 (10mxn) [09:12:55] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Amire80) Summary: - Problem with translating citation templates from English into Czech. ([[ https://www.mediawiki.org/wiki/Topic:Upct23z2e1tot495... [09:17:36] 10InternetArchiveBot: PMC deadlinks - https://phabricator.wikimedia.org/T210588 (10Spinningspark) [09:17:48] I am having problem setting up git-review....anyone can help???? [09:19:11] what up? [09:19:45] i cant set up git-review from mediawiki tutorial....i face fatal error [09:20:19] please be clearer about the error you face? [09:21:03] fatal; not a git repisotary [09:21:20] okay [09:21:31] do you remember the url Urbanecm gave you yesterday? [09:21:37] no [09:21:58] i have installed ubuntu though [09:22:26] First of all, Siyam, it looks you don't have the GCI task claimed on my side. Can you do it, please? [09:22:34] Siyam: which directory are you in? [09:22:46] sounds like you're in the wrong directory [09:22:57] (this is assuming you have cloned the repo already) [09:23:35] i am on /c/users [09:23:46] have you run a git clone command yet? [09:23:53] at any stage? [09:24:07] yes [09:24:14] in which directory did you run it? [09:24:18] from where? [09:24:37] same directory i think [09:24:46] type `cd gci`? [09:25:19] no i didnt type that....should I??? [09:25:24] yes [09:25:47] i have typed.... [09:25:53] should i try now??? [09:25:56] did it give any errors? [09:26:08] no error [09:26:18] okay, no try again [09:26:23] now* [09:28:21] i tried $ git checkout -b gci task origin/mster [09:28:22] fatal: Cannot update paths and switch to branch 'gci' at the same time. [09:29:10] what are you trying to do exactly? [09:29:20] create and checkout a branch? push your changes? [09:29:35] i dont know what i am trying [09:29:45] which tutorial are you following? [09:29:59] i was just following the tutorial of mediawiki [09:30:08] can you link me to it please? [09:30:29] i cant send you the link [09:30:42] why? [09:30:43] you gave me the link if u remember [09:31:23] please give me the link so that i can see which step you're trying to complete [09:31:31] i don't remember which link i gave you [09:31:42] wait i am giving [09:32:22] m.mediawiki.org/wiki/Gerrit/Tutorial [09:32:35] thanks, looking [09:32:59] Siyam: branch names cannot have spaces [09:33:13] try `git checkout -b gci-task origin/master` [09:33:24] i dont know what is branch [09:33:24] 10MediaWiki-extensions-Lockdown: $wgNamespacePermissionLockdown doesn't work for the createpage right - https://phabricator.wikimedia.org/T210568 (10Aklapper) 05Resolved>03Invalid Closing as invalid as no code change was made. Assuming this is about the Lockdown extension. [09:33:35] do you want an explanation? [09:34:08] i just want to learn git and submit patch [09:34:31] fine. let's get your patch submitted first, then i'll explain git basics [09:34:33] sounds good? [09:35:00] Siyam: https://www.mediawiki.org/wiki/Gerrit/Tutorial#What_is_Git? explains what is a branch [09:36:11] yeah [09:36:22] just help me complete my gci task [09:36:33] 10MediaWiki-User-preferences, 10OOUI, 10Browser-Support-Firefox: Scrolling in the rcdays input field in the preferences leads to decimal value with lots of digits - https://phabricator.wikimedia.org/T210574 (10Mainframe98) I can reproduce on Google Chrome 70.0 this using the arrow keys, and I can reproduce t... [09:36:37] then i will learn git with explanation [09:36:49] try `git checkout -b gci-task origin/master` [09:37:13] wth semicolon??? [09:37:19] doesn't matter [09:37:36] i'm guessing you meant "with" rather than "what the hell" [09:37:44] no [09:37:57] i asked with semicolon??? [09:38:07] it doesn't matter [09:38:15] at least as long as you're writing one command at a time [09:38:52] 10MediaWiki-History-or-Diffs: add navigation to diff viewer - https://phabricator.wikimedia.org/T210572 (10Aklapper) 05Open>03stalled Please provide clearer steps and always follow https://www.mediawiki.org/wiki/How_to_report_a_bug when creating tasks. Which diff viewer? RevisionSlider? The default "Revisi... [09:39:11] $ git checkout -b gci-task origin/master [09:39:11] fatal: 'origin/master' is not a commit and a branch 'gci-task' cannot be created from it [09:39:32] what does `git remote` say? [09:39:47] git remote??? [09:39:52] try running it [09:40:05] how [09:40:24] um, the way you ran `git checkout -b ...` [09:40:40] whats the command [09:40:49] `git remote -v` [09:41:02] (Which code repository is this even about? Which repository did you "git clone" before?) [09:41:13] no error [09:41:27] what's the output [09:41:31] andre__, it should be for https://codein.withgoogle.com/tasks/4513104365879296/ [09:41:37] andre__: they're doing the get started with gerrit task [09:41:39] no output its empty [09:42:06] Siyam: are there any files in the directory at all? [09:42:21] wait [09:43:26] i am on gci folder that i have created with your help and there is no file [09:43:46] i thought you had run `git clone` already [09:44:06] now?? [09:44:15] Siyam: Did you run "git clone" before? [09:44:20] Siyam: go back to c/users [09:44:28] let's clone the repo [09:44:31] okay [09:44:45] delete the gci directory [09:45:23] (from the command line you can do `rm -rf gci`) [09:45:36] (or you could delete it from file explorer) [09:46:09] done [09:46:44] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: add easier export with attribution - https://phabricator.wikimedia.org/T210219 (10Aklapper) You are free to use or develop tools for your use case. This is //out of scope for MultimediaViewer// as I explained above. [09:46:47] let me just find the ssh clone url Siyam [09:46:49] just a sec [09:59:34] rsa is the algorithm ssh uses to create its keys [09:59:37] by default at least [10:00:09] (03CR) 10DCausse: [C: 032] Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (https://phabricator.wikimedia.org/T210545) (owner: 10EBernhardson) [10:00:12] so...should i add the rsa key in gerrit.git.wmflabs.org??? [10:00:30] id_rsa.pub is your ssh public key [10:00:46] so should i add it?? [10:00:59] yes [10:01:03] the key is [10:01:09] 2048 37 2196653100808015165845675573842622095821788163929874538452783165261642562392947975939277753745181241520517416979388359178331785094026685664436983860541092732881710272712346911121932176944638472126052098488658577625857790428693766558076927484237650185963407132794670352487963636517301576783278955067524620528602121353717288700333499348749528958182572328457428329287124707467510125651559364825845426305440984228498068933420501459184310942365118332792 [10:01:09] 6965510289742735617585075119806053604016008565710444133320147045133257614498218663797713282920690366446192071612704176328891709465417317782966196567244015843489258080731 rsa-key-20181127 [10:01:09] don't [10:01:22] no??' [10:01:22] add the key [10:01:38] is this correct?? [10:01:42] add the key, i was saying don't paste it, but i was too late [10:01:55] there's supposed to be a line at the top that says "-- BEGIN ..." [10:01:59] or something of that sort [10:02:02] is it a problem??? [10:02:04] make sure you copy-paste the entire thing [10:02:17] and don't skip the initial "ssh-rsa " text [10:02:18] shreyasminocha, wait, public SSH key doesn't start with begin [10:02:25] at least how linux generates it [10:02:31] then i might be wrong [10:02:40] but i think it does have some stuff in the beginning [10:02:45] as Platonides says, it starts with "ssh-rsa " [10:02:46] LENOVO@DESKTOP-6OQVQCO MINGW64 ~ [10:02:47] $ cat /c/Users/LENOVO/.ssh/id_rsa.pub [10:02:47] 2048 37 2196653100808015165845675573842622095821788163929874538452783165261642562392947975939277753745181241520517416979388359178331785094026685664436983860541092732881710272712346911121932176944638472126052098488658577625857790428693766558076927484237650185963407132794670352487963636517301576783278955067524620528602121353717288700333499348749528958182572328457428329287124707467510125651559364825845426305440984228498068933420501459184310942365118332792 [10:02:47] 6965510289742735617585075119806053604016008565710444133320147045133257614498218663797713282920690366446192071612704176328891709465417317782966196567244015843489258080731 rsa-key-20181127 [10:02:55] * shreyasminocha is running low in battery. see you soon if it does out [10:02:59] this is the full...there is no beginning [10:03:13] hmm... [10:03:19] shreyasminocha: I think that's RFC4716 [10:03:38] you want the format used by openssh [10:03:56] Siyam: what did you use to generate it? [10:04:10] puttygen i think [10:04:17] i told them to [10:04:20] my bad [10:04:34] yeah [10:04:59] you can use puttygen [10:05:10] but you will then need to convert it to the right one [10:05:29] i am all messed upnow [10:05:39] relax [10:05:40] what to do first>?? [10:05:41] 10Excimer, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.1 support, and 2 others: Excimer: new profiler for PHP - https://phabricator.wikimedia.org/T205059 (10tstarling) @Joehoyle: internal functions were just skipped for simplicity. We configure xhprof to skip them, so w... [10:05:45] hmm, start from scratch, then? :D [10:05:52] as they surely didn't add the key anywhere (unless prod Gerrit does convert this to right format out of the box), I think the easiest thing would be to delete the key and regenerate it using ssh-keygen [10:05:52] yeah [10:06:04] yes [10:06:12] you could also load the key in puttygen [10:06:13] rhey didn't have ubuntu subsys back then [10:06:15] remember one thing [10:06:21] and use the export option [10:06:30] i have a ssh key added in my gerrit account [10:06:33] ot however it is named [10:06:35] *or [10:06:51] (03CR) 10Nikerabbit: Implement Title.wantSignaturesNamespace in JS (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476061 (owner: 10Esanders) [10:06:51] Platonides, if you think it's easier, can you guide them how to do it? I don't use Putty [10:07:24] i saw export option...but lets create a new ssh [10:07:31] me neither [10:07:34] how to generate a new ssh [10:07:46] firstly, you need to remove id_rsa and id_rsa.pub files [10:08:14] you can do it by doing `rm id_rsa id_rsa.pub` [10:08:30] let me know when you're done [10:08:30] done [10:08:33] nice [10:08:35] next? [10:08:38] now, run `ssh-keygen` [10:09:12] done [10:09:29] followed all instructions? [10:09:32] Urbanecm: I know it has such option, but don't know by heart where it is [10:09:35] yeah [10:09:56] now upload the pub key to gerrit.git.wmflabs [10:10:20] ok. Now, can you do `cat id_rsa.pub` and verify the key starts with ssh-rsa [10:10:25] 10Datasets-Archiving, 10Datasets-General-or-Unknown: Make mediacounts available in Wikimedia Labs - https://phabricator.wikimedia.org/T117956 (10Hydriz) 05Open>03Resolved a:03Hydriz Apparently done when T188726 was resolved. Files are in `/public/dumps/public/other/mediacounts`. [10:10:37] (03CR) 10Mobrovac: [V: 032 C: 032] Add configuration for 'morelike' API [services/recommendation-api/deploy] - 10https://gerrit.wikimedia.org/r/476024 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [10:11:35] $ cat id_rsa.pub [10:11:35] cat: id_rsa.pub: No such file or directory [10:11:50] c/Users/LENOVO/.ssh/id_rsa.pub [10:11:50] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: When at least one notification about one of "changed" object exist, do not emit others - https://phabricator.wikimedia.org/T204605 (10rafidaslam) a:03rafidaslam [10:12:00] or something of that sort. same as last time though [10:12:12] yeah, cat /c/Users/LENOVO/.ssh/id_rsa.pub [10:13:25] yeah got it [10:13:33] it starts with ssh [10:13:43] perfect [10:13:51] now try uploading it to gerrit.git.wmflabs [10:13:58] how to uplaod it?? [10:14:12] go to your settings [10:14:18] click on the ssh keys option [10:14:21] then [10:14:32] paste your key into the field [10:15:07] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10mobrovac) If we have the data locally (in our prod env), perhaps having a prefix-search-tree-based soluti... [10:18:10] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Platonides) What's the benefit of having a service for this? These are just static files. Given the rece... [10:18:38] Siyam: lmk how it does [10:18:39] goes* [10:19:01] i am loggingg in [10:19:09] 10TWLCon-2019-India: Finalisation of Participants - https://phabricator.wikimedia.org/T210247 (10Krishna_Chaitanya_Velaga) [10:19:43] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [Regression] Settings list items not left aligned - https://phabricator.wikimedia.org/T210446 (10Charlotte) [10:20:00] 10TWLCon-2019-India: Finalise Participants List - https://phabricator.wikimedia.org/T210239 (10Krishna_Chaitanya_Velaga) 05Open>03Invalid [10:20:33] it says authentication failed [10:21:41] is it the same as wikitech?? [10:21:52] you might need to create an account [10:22:02] you'll need to create a separate account [10:22:18] oh..i see [10:24:59] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Create setting to explicitly enable/disable Notification polling - https://phabricator.wikimedia.org/T201429 (10Charlotte) @cmadeo - Since you have broken out the settings left-alignment into a separate task, can... [10:32:53] i have added [10:33:53] 10MediaWiki-Internationalization: Image alignment dropdown options in WikiEditor are not localized correctly in Chechen wikipedia - https://phabricator.wikimedia.org/T196784 (10Nikerabbit) They haven't been translated in translatewiki.net for long while now. [10:34:01] i will see you later/....because it has not been completed [10:34:11] i will have to go [10:34:48] 10WMDE volunteer workboard, 10German-Community-Wishlist-Main-Wishes, 10Need-volunteer: Highlight the jump mark letter where you came from (#6 2017) - https://phabricator.wikimedia.org/T194511 (10WMDE-Fisch) [10:35:35] umm okay [10:36:45] although thtey didn't need to leave [10:37:03] must've been in a rush to leave i guess ¯\_(ツ)_/¯ [10:37:10] shreyasminocha: Thanks for your help and patience. :) [10:37:23] my pleasure [10:42:45] 10MediaWiki-extensions-OATHAuth: Weird behavior for 2FA - https://phabricator.wikimedia.org/T210594 (10jeblad) [10:44:24] (03PS1) 10Hashar: (WIP) Try minimal wgMWLoggerDefaultSpi in DevelopmentSettings.php [core] - 10https://gerrit.wikimedia.org/r/476230 [10:45:04] (03PS2) 10Hashar: (WIP) Try minimal wgMWLoggerDefaultSpi in DevelopmentSettings.php [core] - 10https://gerrit.wikimedia.org/r/476230 [11:00:53] Urbanecm, hi, I wanna ask something about wmcz-tracker. Where can I see a list of notification received by my account? [11:03:44] refeed: Urbanecm's away rn [11:04:42] shreyasminocha, hmm, okay, thanks for the information [11:08:00] tried msg-ing him, was auto-away [11:09:17] (03CR) 10Esanders: Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [11:09:54] (03CR) 10Esanders: "recheck" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [11:10:13] (03CR) 10Pmiazga: "Let's follow the deprecation policy, first for some time we should show a warning that this field will be removed in ..., and then delete " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/402130 (https://phabricator.wikimedia.org/T99009) (owner: 10Jdlrobson) [11:11:10] okay [11:12:58] at least we have pinged him, his irc client will notify him [11:14:50] (03PS1) 10Thiemo Kreuz (WMDE): Make backlink highlighting robust for community customized HTML [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476237 (https://phabricator.wikimedia.org/T205270) [11:15:11] * Urbanecm is back [11:15:39] refeed, simple way is to connect to your database and dig into tracker_notification table [11:16:10] Urbanecm, is there any way to access it from the web interface? [11:16:25] I mean to show the notification [11:16:30] No [11:16:43] hmm, okay [11:17:10] you can add a NotificationAdmin to admin.py temporarily if you want [11:17:26] okay [11:18:16] Urbanecm, btw, why is it created (the notification system) if it can't be accessed by the user that's commonly access it from the web interface? [11:18:41] Tracker uses email notifications only [11:18:57] oh, that makes sense [11:19:16] to not email users too frequently, database is used as queue [11:19:47] and https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/management/commands/sendnotifications.py is ran once a day [11:20:31] interesting, I thought the notification would received by the watcher directly. I was wrong then [11:20:42] (03CR) 10WMDE-Fisch: [C: 032] Make backlink highlighting robust for community customized HTML [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476237 (https://phabricator.wikimedia.org/T205270) (owner: 10Thiemo Kreuz (WMDE)) [11:20:55] (03PS1) 10WMDE-Fisch: Make backlink highlighting robust for community customized HTML [extensions/Cite] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476241 (https://phabricator.wikimedia.org/T205270) [11:21:52] I'm not sure what you mean by "directly" [11:22:05] it isn't immediate, if that's what you mean [11:22:11] yup [11:22:30] thanks Urbanecm [11:22:38] yw [11:26:15] (03CR) 10Zfilipin: "> Patch Set 3: Verified-1" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [11:27:44] (03CR) 10Esanders: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [11:28:58] (03CR) 10Esanders: Implement Title.wantSignaturesNamespace in JS (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476061 (owner: 10Esanders) [11:30:16] (03PS1) 10Esanders: Fix typo in mw.Title test [core] - 10https://gerrit.wikimedia.org/r/476242 [11:31:29] (03PS4) 10Tchanders: Improve layout of ExpiryInputWidget on mobile [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) [11:32:08] (03CR) 10Tchanders: [C: 04-1] "Awaiting decision about whether to have the tablet mode" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [11:32:33] (03PS1) 10Nathan fraignt: Fix: "All" is checked if all notifications are [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476243 (https://phabricator.wikimedia.org/T210353) [11:34:08] (03PS1) 10Daimona Eaytoy: [WIP] Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [11:34:33] (03Merged) 10jenkins-bot: Make backlink highlighting robust for community customized HTML [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476237 (https://phabricator.wikimedia.org/T205270) (owner: 10Thiemo Kreuz (WMDE)) [11:43:02] (03PS1) 10Thiemo Kreuz (WMDE): Make backlink highlighting robust when "mw-cite-backlink" is missing [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476246 (https://phabricator.wikimedia.org/T205270) [11:45:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Make backlink highlighting robust for community customized HTML [extensions/Cite] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476241 (https://phabricator.wikimedia.org/T205270) (owner: 10WMDE-Fisch) [11:57:45] Nathan_fraignt, I'm looking on your patch. Honestly, I had front-end solution in mind while creating the task, as in case I check all notifications manually, it doesn't do its job. [11:58:08] (maybe I should have added several steps of reproduce to the task's description...) [11:59:55] Hmm, that is true. Sorry. Iḿ going to have lunch in a few minutes, will try to create a front end solution afterwards. Do you want to keep the backend solution, so it´s rendered correctly without JS, or can I completely remove it urbanecm? [12:00:36] (03PS2) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [12:00:48] Keeping it is good idea to support users w/o JS (although I think no-JS users are pretty rare nowadays). [12:00:58] (03PS1) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) [12:01:26] I have no problem with the code included, but I wouldn't require it in case you started with frontend solution [12:01:36] it's not a problem, do it whenever you have time :) [12:02:09] Alright, will do! [12:03:14] (03CR) 10Urbanecm: [C: 04-1] "As this is back-end solution, it won't work in cases user selects all notifications manually." [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476243 (https://phabricator.wikimedia.org/T210353) (owner: 10Nathan fraignt) [12:03:45] I've reviewed it on GCI and on Gerrit to clear my dashboard, resubmit once you're done! [12:04:07] (03CR) 10jerkins-bot: [V: 04-1] Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) (owner: 10Daimona Eaytoy) [12:06:56] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476252 (https://phabricator.wikimedia.org/T210552) [12:06:59] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 [12:09:59] (03CR) 10Esanders: [C: 04-1] Debug flag for EditAttemptStep tracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [12:10:45] (03CR) 10Esanders: "we should deduplicate this to a core module, but this will do for now" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [12:11:41] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) [12:13:24] (03CR) 10Zfilipin: [C: 032] "SWAT" [extensions/Cite] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476241 (https://phabricator.wikimedia.org/T205270) (owner: 10WMDE-Fisch) [12:26:43] (03CR) 10Daimona Eaytoy: [V: 032] "T189560" [extensions/AbuseFilter] (REL1_32) - 10https://gerrit.wikimedia.org/r/476251 (https://phabricator.wikimedia.org/T203336) (owner: 10Daimona Eaytoy) [12:27:04] (03PS1) 10Pwirth: Remove saferEdit ping on namespaces lower than 0. [extensions/BlueSpiceSaferEdit] - 10https://gerrit.wikimedia.org/r/476257 [12:27:36] (03CR) 10Jdrewniak: [C: 032] Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [12:27:59] (03CR) 10Mobrovac: [C: 04-1] Add translation based 'morelike' API for missing articles (034 comments) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [12:29:49] (03Merged) 10jenkins-bot: Make backlink highlighting robust for community customized HTML [extensions/Cite] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476241 (https://phabricator.wikimedia.org/T205270) (owner: 10WMDE-Fisch) [12:34:02] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [12:51:29] (03Merged) 10jenkins-bot: Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [13:00:01] (03CR) 10jenkins-bot: Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [13:03:15] (03PS3) 10Pjht: Check that the page has a talk page before calling Title::getTalkPage [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 [13:04:41] (03PS4) 10Esanders: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [13:05:13] (03CR) 10Esanders: [C: 031] "+2 if you are happy with my small change in PS4" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [13:07:11] (03CR) 10Jdrewniak: [C: 032] Provide some recommended (opt-in classes) for projects not opted into page issues [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476169 (https://phabricator.wikimedia.org/T206177) (owner: 10Jdlrobson) [13:09:02] (03PS1) 10Esanders: Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 [13:09:26] (03CR) 10jerkins-bot: [V: 04-1] Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [13:09:27] i am back...is there anyone [13:12:16] I am here, Siyam [13:12:53] i dont think you know about my problem...do you??? [13:14:59] I don´t think so [13:15:02] Nvm [13:15:03] He is gone [13:15:42] (03CR) 10Esanders: Use custom overlay for help popups (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [13:15:44] (03PS2) 10Nathan fraignt: Fix: "All" is checked if all notifications are [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476243 (https://phabricator.wikimedia.org/T210353) [13:16:24] (03CR) 10Esanders: Don't require editSchema to be setup to use trackdebug (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [13:19:26] hello [13:19:46] (03PS1) 10Mamert: Test [extensions/examples] - 10https://gerrit.wikimedia.org/r/476262 [13:22:26] (03PS2) 10Tchanders: Don't indicate partial blocks on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) [13:22:31] (03Merged) 10jenkins-bot: Provide some recommended (opt-in classes) for projects not opted into page issues [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476169 (https://phabricator.wikimedia.org/T206177) (owner: 10Jdlrobson) [13:26:26] (03CR) 10Tchanders: Don't indicate partial blocks on Special:ActiveUsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [13:26:31] (03PS4) 10Esanders: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [13:26:33] (03PS5) 10Esanders: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [13:26:35] (03PS2) 10Esanders: Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 [13:27:22] (03CR) 10Esanders: Don't require editSchema to be setup to use trackdebug (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [13:28:14] (03CR) 10Nikerabbit: "When is this limit actually used? What I recall I am seeing ~1000 results when replacing in page titles." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/473850 (owner: 10Edward Chernenko) [13:30:36] (03Abandoned) 10Mamert: Test [extensions/examples] - 10https://gerrit.wikimedia.org/r/476262 (owner: 10Mamert) [13:31:40] hey..is there anyone [13:33:32] (03CR) 10jenkins-bot: Provide some recommended (opt-in classes) for projects not opted into page issues [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476169 (https://phabricator.wikimedia.org/T206177) (owner: 10Jdlrobson) [13:34:24] (03CR) 10Esanders: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [13:37:08] (03CR) 10Aklapper: "Hi Mamert. Congratulations to your patch in Wikimedia Gerrit!" [extensions/examples] - 10https://gerrit.wikimedia.org/r/476262 (owner: 10Mamert) [13:39:45] by... [13:42:20] (03CR) 10D3r1ck01: "recheck" [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/468722 (owner: 10HerrTaschenbier) [13:42:54] (03CR) 10Urbanecm: [C: 032] Fix: "All" is checked if all notifications are [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476243 (https://phabricator.wikimedia.org/T210353) (owner: 10Nathan fraignt) [13:44:19] (03Merged) 10jenkins-bot: Fix: "All" is checked if all notifications are [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476243 (https://phabricator.wikimedia.org/T210353) (owner: 10Nathan fraignt) [13:45:48] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: In watch.html, the "All" notification should be checked if all notifications are - https://phabricator.wikimedia.org/T210353 (10Urbanecm) 05Open>03Resolved [13:51:56] 10MediaWiki-Uploading, 10Commons, 10Multimedia, 10media-storage: Uploading files (around 6MB) makes browsers stall - https://phabricator.wikimedia.org/T202366 (10Aklapper) I'm wondering a little bit if this might be a connection issue (unlikely though): https://wikitech.wikimedia.org/wiki/Reporting_a_conne... [13:52:39] 10Wiki-Loves-Monuments (2018): [Daily Uploads] Add parameters to url - https://phabricator.wikimedia.org/T144724 (10Aklapper) [13:54:10] 10MediaWiki-Interface, 10MediaWiki-Internationalization: Make a custom date-time format for users in Special:Preferences - https://phabricator.wikimedia.org/T209766 (10Aklapper) >>! In T209766#4756301, @Aklapper wrote: >> Secondly, why did I say "often"? Many people in my country [...] want to have the date di... [13:55:57] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Create setting to explicitly enable/disable Notification polling - https://phabricator.wikimedia.org/T201429 (10Charlotte) @cmadeo - https://phabricator.wikimedia.org/T210446 mentions the alignment issues, albeit... [14:02:37] (03PS3) 10D3r1ck01: Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 [14:02:50] Urbanecm, hi, I wanna confirm that I understand T204605. When we created a new ticket, a `new_ticket` Notification is written into the database. After that we updated the expenditure, and the wage on the ticket and saved it, but the expenditure, and wage notifications are not written into the database, and that's the issue. Am I right? [14:02:51] T204605: When at least one notification about one of "changed" object exist, do not emit others - https://phabricator.wikimedia.org/T204605 [14:04:54] Not quite. If you create a ticket, regardless if it has expeditures, only new_ticket is written (that's okay) [14:05:31] *ticket_new [14:06:00] If you modify this ticket before notifications were distributed (=send to users and deleted from database), new notification ticket_change is stored [14:06:25] If I edit ticket 100 times, it'll create 100 notifications per watcher [14:06:59] If a watcher receives a notification, we can safely assume the watcher knows about the ticket and that it was changed [14:07:11] So there's no point in sending him another notification [14:08:00] refeed, do you now understand the point of the task better? [14:12:10] BTW, "wage" is an attribute of expediture in this context [14:13:45] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Urbanecm) That's probably problem of all languages? IIRC we don't have a map between citation templates by project. [14:14:10] hmm, I still quite don't understand. So, I think the point is, when a user created a new ticket, it'll store the `ticket_new` notif first, and then the user changed (updated) some fields of the ticket, and then some new `ticket_change` notifs get stored. But the expected result is: don't let any `ticket_change` notification get written (stored) into the database if there is a `ticket_new` notification with the same ticket still. Am I right? [14:14:16] Urbanecm, ^^ [14:14:27] sorry if my long sentences make you confused [14:14:45] I have no problem with your sentences :) [14:15:03] You're right now [14:15:36] Urbanecm, okay, thanks [14:15:40] yw [14:15:47] (03PS2) 10Sbisson: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:16:27] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Milimetric) I also have some questions about this effort on behalf of #TechCom. Mainly, is there a future where we unify fr... [14:16:45] (03PS2) 10Fomafix: Use instead of for JavaScript click events [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/459898 [14:16:54] (03CR) 10Sbisson: "PS2 adds a few packages and a grunt task for this to run." [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:19:21] (03CR) 10jerkins-bot: [V: 04-1] Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:20:21] refeed, additionally, if I make an edit of description and then (before the notification is distributed) I edit description again, the second edit shouldn't cause second notification to be created. [14:21:38] On the other hand, editing a title and then a description should create two notifications (as those things are different and are edited in different cases) [14:22:02] I hope I didn't confuse you by telling you this second part of this task too early [14:23:28] (03PS3) 10Sbisson: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:25:13] Urbanecm, so I think I need to fix this also right "(if I make an edit of description and then (before the notification is distributed) I edit description again, the second edit shouldn't cause second notification to be created. )" ? [14:25:35] Yes [14:25:43] alright [14:26:55] (03CR) 10jerkins-bot: [V: 04-1] Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:27:58] (03PS4) 10Sbisson: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:28:53] (03CR) 10Kosta Harlan: [C: 031] "Looks good, with the caveat that I haven't tested and we will have Elena QA in IE and other browser on beta labs before this rides the tra" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) (owner: 10Sbisson) [14:32:18] 10MediaWiki-Installer: Misleading error message in web installer when cookies are disabled in web browser - https://phabricator.wikimedia.org/T210609 (10Aklapper) [14:33:23] Urbanecm, hmm, somehow I can't reproduce it. I've created a ticket, then I see a `ticket_new` notif, but after I edited the ticket, there is no `ticket_change` or something like that get stored into the database [14:34:22] 10Design, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624 (10Elitre) [14:35:58] Urbanecm, I think it's intended? https://github.com/wikimedia/wikimedia-cz-tracker/blob/6b345dbc438ac95aa6bf5a5fa7a238760fc38c46/trackersite/tracker/models.py#L1023 [14:36:37] (03CR) 10Kosta Harlan: [C: 032] Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:39:42] refeed, sorry, had a phone call. Oops, looks the first part is solved. [14:40:26] Can you try to fix the second part? (quoting: "if I make an edit of description and then (before the notification is distributed) I edit description again, the second edit shouldn't cause second notification to be created.") [14:40:38] Urbanecm: o/ [14:40:42] okay, I'll try it [14:40:47] takidelfin, hi [14:40:47] refeed: o/ [14:40:51] hi takidelfin [14:41:11] thanks refeed and sorry for confusing you [14:41:34] np :D [14:41:42] (03Merged) 10jenkins-bot: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:41:42] :) [14:43:29] (03CR) 10jenkins-bot: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [14:44:04] Urbanecm, I think I need to remove the `ticket_new` notifications first right? [14:44:16] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Hindi-Sites, 10Patch-For-Review, and 2 others: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias - https://phabricator.wikimedia.org/T206497 (10Imarlier) >>! In T206497#4780170, @Legoktm wrote: > +#wikimedia-site-reques... [14:44:26] * in the database [14:46:16] Why would you remove them? [14:46:58] (03PS20) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [14:47:04] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [14:47:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [14:47:34] Urbanecm: the same like I told you before (because of there's a `ticket_new` notif, I don't get any `ticket_change` notif, https://github.com/wikimedia/wikimedia-cz-tracker/blob/6b345dbc438ac95aa6bf5a5fa7a238760fc38c46/trackersite/tracker/models.py#L1026 ) [14:48:52] No, you don't need to remove this code [14:50:22] (03PS21) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [14:50:24] Yup, I won't. I meant the `ticket_new` notification in the database by running `Notification.objects.all().delete()` [14:52:02] 10Product-Analytics, 10VisualEditor (Current work): Clarification on mobile editing stats - https://phabricator.wikimedia.org/T210556 (10Esanders) [14:52:33] Urbanecm, ^^ [14:53:51] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [14:53:54] (03CR) 10jerkins-bot: [V: 04-1] WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [14:54:26] * to reproduce (quoting: "if I make an edit of description and then (before the notification is distributed) I edit description again, the second edit shouldn't cause second notification to be created.") [14:54:58] refeed, try the same with expediture [14:56:25] Urbanecm, yes, I can reproduce them now [14:56:31] great [14:57:35] alright thanks Urbanecm [14:58:28] yw [14:58:30] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Create setting to explicitly enable/disable Notification polling - https://phabricator.wikimedia.org/T201429 (10cmadeo) @Charlotte would it be possible to put that ticket on the K board then? I'm a bit worried ab... [14:58:48] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about accessing a StructuredDiscussions Topic page the first time - https://phabricator.wikimedia.org/T210403 (10Trizek-WMF) [14:58:52] 10MediaWiki-Interface, 10MediaWiki-Internationalization: Make a custom date-time format for users in Special:Preferences - https://phabricator.wikimedia.org/T209766 (10Leduyquang753) My country is Vietnam. And yes it uses h\Hi j/n/Y. We don't need to bring it on an online discussion to state the preference. An... [14:59:04] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about Talk pages using StructuredDiscussions - https://phabricator.wikimedia.org/T210402 (10Trizek-WMF) [14:59:19] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about switching editors in StructuredDiscussions - https://phabricator.wikimedia.org/T210415 (10Trizek-WMF) [14:59:26] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about editing replies in StructuredDiscussions - https://phabricator.wikimedia.org/T210427 (10Trizek-WMF) [14:59:58] 10QuickSurveys: Loading a specific survey doesn't work - https://phabricator.wikimedia.org/T210613 (10bmansurov) [15:00:13] 10QuickSurveys: Loading a specific survey doesn't work - https://phabricator.wikimedia.org/T210613 (10bmansurov) [15:00:27] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @chiborg - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:01:40] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about accessing a StructuredDiscussions Topic page the first time - https://phabricator.wikimedia.org/T210403 (10Trizek-WMF) @Aklapper, I've importer that task. Can you add @SBisson as a m... [15:02:13] Urbanecm, btw, is there any reason why https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/472528/ still not get merged? Is there any big problem with it (I remember that I placed a new requirements `mock` in it, I think you've fixed it)? I can solve the merge conflict if you want. and also I think it'd be great if it can be merged, so I can also submit unittests for this task (the task that I'm working now) [15:03:46] The problem is T207310 [15:03:47] T207310: Tests in Tracker fail from time to time from non-obvious reason - https://phabricator.wikimedia.org/T207310 [15:03:54] 10Product-Analytics, 10VisualEditor (Current work): Clarification on mobile editing stats - https://phabricator.wikimedia.org/T210556 (10Esanders) > but if the initial drop-off for VE on mobile is smaller than desktop, then maybe optimizing the loading experience isn't a huge priority Maybe, but the current u... [15:04:29] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [Regression] Settings list items not left aligned - https://phabricator.wikimedia.org/T210446 (10cmadeo) [15:06:30] refeed, it's a glitch in testing environment [15:06:42] Urbanecm, hmm okay, I also noticed it in https://gerrit.wikimedia.org/r/#/c/wikimedia-cz/tracker/+/472528/ 's jenkins [15:06:43] your patch has a test failed randomly [15:07:00] okay, so it's an intermittent failure [15:07:51] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about editing replies in StructuredDiscussions - https://phabricator.wikimedia.org/T210427 (10Trizek-WMF) @Aklapper, [[ https://codein.withgoogle.com/dashboard/tasks/5653302751526912/ | I'... [15:08:01] exactly [15:08:29] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about switching editors in StructuredDiscussions - https://phabricator.wikimedia.org/T210415 (10Trizek-WMF) @Aklapper, [[ https://codein.withgoogle.com/dashboard/tasks/6700235507105792/ |... [15:08:54] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about Talk pages using StructuredDiscussions - https://phabricator.wikimedia.org/T210402 (10Trizek-WMF) @Aklapper, [[ https://codein.withgoogle.com/dashboard/tasks/6325545982754816/ | I've... [15:08:58] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [Regression] Settings list items not left aligned - https://phabricator.wikimedia.org/T210446 (10Charlotte) [15:09:17] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [Regression] Settings list items not left aligned - https://phabricator.wikimedia.org/T210446 (10Charlotte) p:05Triage>03High [15:09:43] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Create setting to explicitly enable/disable Notification polling - https://phabricator.wikimedia.org/T201429 (10Charlotte) @cmadeo - Done! We'll talk about this briefly at standup as well. [15:10:57] (03PS1) 10Hydriz: Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/476278 [15:11:19] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10Patch-For-Review, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10marcella) a:05Tchanders>03None [15:12:23] (03CR) 10Hydriz: "The original patch was reverted as this fixed one issue and introduced many others. Revert until an actual fix was found." [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/476278 (owner: 10Hydriz) [15:13:40] (03CR) 10Niedzielski: [C: 04-1] "This looks way better. Please consider my question inline." (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [15:13:54] (03PS1) 10Ladsgroup: Don't try to add scores in API where there is nothing to add [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) [15:16:03] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Regression: Message infopage-status-beforeincubator has broken link - https://phabricator.wikimedia.org/T111600 (10Hydriz) [15:16:07] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) [15:17:02] 10MediaWiki-extensions-WikimediaIncubator, 10Beta-Cluster-Infrastructure: Create a Wikimedia Incubator test wiki on the Beta Cluster - https://phabricator.wikimedia.org/T210492 (10Ebe123) https://incubator.wmflabs.org/wiki/Main_Page ? [15:17:10] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about editing replies in StructuredDiscussions - https://phabricator.wikimedia.org/T210427 (10Aklapper) @Trizek-WMF: Thanks. I've rephrased a bit and published. I assumed this requires stu... [15:17:49] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Afar test wikis on Incubator incorrectly shows the Wikimedia logo for Wikipedia - https://phabricator.wikimedia.org/T117024 (10Hydriz) [15:17:51] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) [15:19:41] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) [15:19:43] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): When viewing pages for non-Incubator pages on Incubator, the link to the page on the new wiki is broken - https://phabricator.wikimedia.org/T126827 (10Hydriz) [15:20:08] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) [15:20:10] 10MediaWiki-extensions-WikimediaIncubator, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Special:SearchWiki is broken for existing Wikipedias - https://phabricator.wikimedia.org/T162518 (10Hydriz) [15:20:55] (03PS22) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [15:21:42] (03PS9) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [15:22:20] 10MediaWiki-extensions-WikimediaIncubator, 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) [15:23:26] (03CR) 10Niedzielski: [C: 04-1] "Do we want to centralize all icon creation in mobile.startup?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [15:23:35] 10MediaWiki-extensions-WikimediaIncubator, 10User-Hydriz: Auto-generated infopages incorrectly links to the current page for Wikipedia - https://phabricator.wikimedia.org/T117023 (10Hydriz) This fix is not trivial. The original patch has been reverted in https://gerrit.wikimedia.org/r/#/c/476278/ until further... [15:24:08] 10Product-Analytics, 10VisualEditor (Current work): Clarification on mobile editing stats - https://phabricator.wikimedia.org/T210556 (10marcella) >>! In T210556#4781532, @Esanders wrote: >> but if the initial drop-off for VE on mobile is smaller than desktop, then maybe optimizing the loading experience isn't... [15:29:10] 10Wikidata-Termbox-Hike: View historic revisions of entities - https://phabricator.wikimedia.org/T210615 (10Pablo-WMDE) [15:30:09] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10mforns) @Amire80 I just checked and data looks good in analytics-slave::staging.cx_abuse_filter_daily. [15:32:47] (03PS8) 10Bmansurov: Add translation based 'morelike' API for missing articles [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) [15:34:21] (03CR) 10Bmansurov: Add translation based 'morelike' API for missing articles (031 comment) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [15:34:43] 10MediaWiki-Installer: Clarify in web installer that the database must already exist (and is not automagically created by the installer) - https://phabricator.wikimedia.org/T210616 (10Aklapper) [15:38:32] (03PS4) 100x010C: Allow file upload through the Client [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) [15:39:23] 10MediaWiki-extensions-Other, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.1 support, 10Patch-For-Review: MultiMaps tests are failing on PHP 7.1 - https://phabricator.wikimedia.org/T206291 (10BPirkle) 05Open>03Resolved A fix for this issue has been merged. [15:39:59] 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Amire80) Is it accessible on the web? On the web I still see a file with `date` and `done`. [15:42:41] (03PS1) 10Anomie: Message: Don't include Title objects in the serialization (part 1) [core] - 10https://gerrit.wikimedia.org/r/476287 (https://phabricator.wikimedia.org/T210528) [15:42:45] (03PS1) 10Anomie: Message: Don't include Title objects in the serialization (part 2) [core] - 10https://gerrit.wikimedia.org/r/476288 (https://phabricator.wikimedia.org/T210528) [15:43:04] (03PS1) 10Anomie: Message: Throw if given invalid serialized data [core] - 10https://gerrit.wikimedia.org/r/476289 (https://phabricator.wikimedia.org/T210528) [15:43:54] (03CR) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [15:44:02] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10Patch-For-Review, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10Tchanders) @ryasmeen Oops looks like I forgot to push the change - thanks for pointing that out! [15:45:50] (03CR) 100x010C: "recheck" [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [15:46:22] (03PS2) 10Anomie: Message: Don't include Title objects in the serialization (part 1) [core] - 10https://gerrit.wikimedia.org/r/476287 (https://phabricator.wikimedia.org/T210528) [15:46:24] (03PS2) 10Anomie: Message: Don't include Title objects in the serialization (part 2) [core] - 10https://gerrit.wikimedia.org/r/476288 (https://phabricator.wikimedia.org/T210528) [15:50:17] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @Thiemo_WMDE & @chiborg - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [15:52:12] (03CR) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [15:53:26] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about editing replies in StructuredDiscussions - https://phabricator.wikimedia.org/T210427 (10Trizek-WMF) >>! In T210427#4781611, @Aklapper wrote: > @Trizek-WMF: Thanks. I've rephrased a b... [15:54:22] (03CR) 10Edward Chernenko: "It's used for fulltext Search/Replace (when searching in page text, not page titles)." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/473850 (owner: 10Edward Chernenko) [15:58:35] (03CR) 10Edward Chernenko: "> ~1000 results when replacing in page titles." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/473850 (owner: 10Edward Chernenko) [15:59:16] (03CR) 10Anomie: [C: 031] "Looks good, seems to work. But you could test it easily enough." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [15:59:34] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10Niedzielski) [16:01:37] \o [16:02:14] Urbanecm: https://codein.withgoogle.com/dashboard/task-instances/4968379283668992/ [16:02:20] Could you review my task, please? [16:02:23] :D [16:02:32] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10StructuredDiscussions: Create a guided tour about editing replies in StructuredDiscussions - https://phabricator.wikimedia.org/T210427 (10SBisson) >>! In T210427#4781611, @Aklapper wrote: > @Trizek-WMF: Thanks. I've rephrased a bit... [16:02:47] in a while [16:02:55] (03PS8) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) [16:03:35] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10Anomie) OTOH, that would be a negative for the majority of properties that //aren't// shoving binary data into `page_props`. [16:04:32] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [16:05:07] 10OOUI: Undo/redo icons have white gap and arrow base at non-100% zoom levels - https://phabricator.wikimedia.org/T210622 (10Esanders) [16:06:03] (03CR) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [16:07:32] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Generate entries for deletions and restores in page histories - https://phabricator.wikimedia.org/T72239 (10RoySmith) Please see https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(proposals)&oldid=871029729#Diffs_should_include_log_extrac... [16:07:59] (03CR) 10D3r1ck01: "To make sure everything is okay apart from the ServiceWirings part, I'm requesting for another gentle review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [16:08:18] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (100x010C) @Jnanaranjan_sahu The `$this->config` parameter send to `makeCurlCall` in 5th position on line 253 in the initial version was useless, this method wa... [16:10:21] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10ovasileva) [16:12:01] (03PS13) 10Jdlrobson: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [16:15:16] 10CirrusSearch, 10Discovery-Search, 10Dumps-Generation: CirrusSearch dumps for the Norwegian Bokmål Wikipedia link to the Italian Wikipedia - https://phabricator.wikimedia.org/T210623 (10jhsoby-WMNO) [16:17:17] (03CR) 10DLynch: [C: 032] Don't require editSchema to be setup to use trackdebug [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476261 (owner: 10Esanders) [16:18:57] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [16:20:00] (03CR) 10DLynch: [C: 032] Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [16:21:08] (03CR) 10DLynch: "> Patch Set 3:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [16:24:32] (03CR) 10Dmaza: [C: 031] Don't indicate partial blocks on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [16:30:51] (03CR) 10Hydriz: [V: 032 C: 032] Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/476278 (owner: 10Hydriz) [16:32:35] (03PS1) 10Thcipriani: Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476304 [16:36:19] (03CR) 10Jdlrobson: [C: 031] "Wanna test this some more (and fix nearby locally!!)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [16:39:38] (03CR) 10Hydriz: [V: 032 C: 032] Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/476278 (owner: 10Hydriz) [16:40:54] (03CR) 10Thcipriani: [C: 032] Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476304 (owner: 10Thcipriani) [16:42:28] 10Google-Code-in-2018, 10MobileFrontend, 10Readers-Web-Backlog, 10Need-volunteer, 10goodfirstbug: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi - https://phabricator.wikimedia.org/T204876 (10Jdlrobson) a:03Jdlrobson [16:44:21] (03PS3) 10Jdlrobson: Every ambox has its own issue and icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475030 (https://phabricator.wikimedia.org/T202349) [16:45:09] (03CR) 10Anomie: Fix the cache timestamp for forced updates. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [16:45:50] 10Core Platform Team (MCR), 10Core Platform Team Backlog (Epic), 10Epic, 10Multi-Content-Revisions (New Features): Allow control of page layout of multiple slots during rendering - https://phabricator.wikimedia.org/T209878 (10Jdforrester-WMF) [16:45:52] (03Merged) 10jenkins-bot: Revert "Replace wiki with wikipedia as wmf-config has been updated" [extensions/WikimediaIncubator] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476304 (owner: 10Thcipriani) [16:45:52] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (New Features): Introduce PageTypeHandler - https://phabricator.wikimedia.org/T209924 (10Jdforrester-WMF) [16:45:54] 10Core Platform Team Kanban, 10Core Platform Team (MCR), 10Multi-Content-Revisions (New Features): Allow SlotRoleHandlers to control page layout - https://phabricator.wikimedia.org/T200915 (10Jdforrester-WMF) [16:45:56] 10MediaWiki-ServiceContainer, 10Core Platform Team Kanban, 10SDC Engineering, 10Wikidata, and 3 others: ServiceContainer: Allow extensions to manipulate services upon creation - https://phabricator.wikimedia.org/T195212 (10Jdforrester-WMF) [16:46:03] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block - https://phabricator.wikimedia.org/T205891 (10Jdforrester-WMF) [16:46:28] (03CR) 10Esanders: [WIP] Convert WelcomeSurvey Popup to require() (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474972 (owner: 10Catrope) [16:46:35] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Get WikibaseMediaInfo to the state that we're happy to proceed with initial production deployment (captions) - https://phabricator.wikimedia.org/T205732 (10Jdforrester-WMF) [16:46:42] 10MediaWiki-extensions-WikibaseMediaInfo, 10Multimedia, 10SDC Engineering, 10Wikidata, and 2 others: Display WikibaseMediaInfo captions block on the File page immediately after the file links, before the content of the wikitext block - https://phabricator.wikimedia.org/T205891 (10Jdforrester-WMF) 05stalle... [16:46:53] 10Design, 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: The background for the Wikipedia app in the Play Store features some broken languages - https://phabricator.wikimedia.org/T196870 (10cmadeo) {F27322228} {F27322260} [16:48:12] (03CR) 10Fomafix: Message: Don't include Title objects in the serialization (part 1) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476287 (https://phabricator.wikimedia.org/T210528) (owner: 10Anomie) [16:49:33] 10Readers-Web-Backlog (Design): [Bug] Async loading code if failing occludes the page and disables interactivity - https://phabricator.wikimedia.org/T201687 (10DannyH) [16:50:39] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering: Trim initial and trailing whitespace from captions on input and display - https://phabricator.wikimedia.org/T209736 (10Jdforrester-WMF) a:03Jdforrester-WMF [16:52:54] (03CR) 10jerkins-bot: [V: 04-1] Every ambox has its own issue and icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475030 (https://phabricator.wikimedia.org/T202349) (owner: 10Jdlrobson) [16:54:53] Gerrit will need a restart to reload config . .will be right back [16:57:35] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion: Generate entries for deletions and restores in page histories - https://phabricator.wikimedia.org/T72239 (10RoySmith) There is a related discussion at https://wm-bot.wmflabs.org/logs/%23wikimedia-tech/20181128.txt [16:58:31] gerrit back to normal [17:03:11] (03PS1) 10Esanders: Remove obsolete aliases from closures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476307 (https://phabricator.wikimedia.org/T208951) [17:03:13] (03PS1) 10Esanders: build: Update linters [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476308 [17:03:15] (03PS1) 10Esanders: Update to eslint-config-wikimedia 0.9.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476309 [17:03:17] (03PS1) 10Esanders: Fix alignment of checkboxes in monobook [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476310 [17:03:37] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Matthias_Geisler_WMDE) 05Open>03Resolved [17:03:57] (03CR) 10Krinkle: [C: 032] Remove obsolete aliases from closures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476307 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [17:04:21] (03CR) 10Krinkle: [C: 032] Fix typo in mw.Title test [core] - 10https://gerrit.wikimedia.org/r/476242 (owner: 10Esanders) [17:04:44] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476252 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [17:04:57] 10Readers-Web-Backlog (Design): [Bug] Async loading code if failing occludes the page and disables interactivity - https://phabricator.wikimedia.org/T201687 (10DannyH) [17:06:02] 10Readers-Web-Backlog (Design): [Bug] Async loading code if failing occludes the page and disables interactivity - https://phabricator.wikimedia.org/T201687 (10DannyH) [17:06:04] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Research Design Improvements to MobileFrontend Loading Overlay - https://phabricator.wikimedia.org/T209708 (10DannyH) [17:06:10] (03CR) 10Jforrester: [C: 04-1] "One minor issue, otherwise good to merge." (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 (owner: 10Esanders) [17:10:28] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10I18n: Georgian words are automatically (incorrectly) capitalized when entered - https://phabricator.wikimedia.org/T208139 (10Aklapper) 05stalled>03Open [17:10:58] 10Google-Code-in-2018, 10MediaWiki-extensions-GuidedTour, 10Collaboration-Community-Engagement, 10CommRel-Documentation, and 2 others: Create a guided tour about StructuredDiscussions - https://phabricator.wikimedia.org/T112757 (10Trizek-WMF) >>! In T112757#4773139, @Trizek-WMF wrote: > @SBisson , did you... [17:16:23] (03PS3) 10Daimona Eaytoy: Fix big problems with normalizeThrottleParameters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476244 (https://phabricator.wikimedia.org/T203336) [17:18:12] (03CR) 10Jforrester: [C: 032] build: Update linters [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476308 (owner: 10Esanders) [17:18:24] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Show complete license info for images shown in full screen - https://phabricator.wikimedia.org/T164957 (10ABorbaWMF) LGTM on 2.7.266-alpha-2018-11-27 I did find a related issue while testing this T210544 [17:18:30] (03PS2) 10Jforrester: build: Update eslint-config-wikimedia to 0.9.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476309 (owner: 10Esanders) [17:18:45] (03CR) 10Jforrester: [C: 032] build: Update eslint-config-wikimedia to 0.9.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476309 (owner: 10Esanders) [17:18:59] (03PS2) 10Jforrester: Fix alignment of checkboxes in monobook [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476310 (owner: 10Esanders) [17:19:27] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [17:20:38] (03CR) 10Krinkle: "> Ed wrote:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [17:22:56] 10MediaWiki-extensions-Scribunto, 10Wikidata: LuaStandalone: SecurityTests[1]: CVE-2014-5461 failing - https://phabricator.wikimedia.org/T210634 (10Lucas_Werkmeister_WMDE) [17:23:13] (03CR) 10Jforrester: [C: 032] Fix alignment of checkboxes in monobook [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476310 (owner: 10Esanders) [17:24:48] (03CR) 10Esanders: [C: 032] Remove obsolete aliases from closures, and fix line lengths [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/473615 (https://phabricator.wikimedia.org/T208951) (owner: 10Jforrester) [17:25:43] (03CR) 10Tchanders: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) (owner: 10Dbarratt) [17:25:45] 10MediaWiki-extensions-OpenStackManager, 10cloud-services-team, 10wikitech.wikimedia.org: Remove OpenStackManager from Wikitech - https://phabricator.wikimedia.org/T161553 (10bd808) [17:27:22] 10Android-app-Bugs, 10Chinese-Sites, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Showing incorrect cache contents when switching Chinese variants - https://phabricator.wikimedia.org/T191550 (10ABorbaWMF) This appears to be fixed on 2.7.266-alpha-2018-11-27 [17:29:21] 10MediaWiki-extensions-Scribunto, 10Wikidata: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Lucas_Werkmeister_WMDE) [17:29:34] 10MediaWiki-extensions-Scribunto, 10Wikidata: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Lucas_Werkmeister_WMDE) [17:29:43] (03PS4) 10Sbisson: [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) [17:30:20] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10Continuous-Integration-Config: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Lucas_Werkmeister_WMDE) [17:30:29] 10CirrusSearch, 10Discovery-Search, 10Dumps-Generation: CirrusSearch dumps for the Norwegian Bokmål Wikipedia link to the Italian Wikipedia - https://phabricator.wikimedia.org/T210623 (10jhsoby-WMNO) @Aklapper Could you please see if these are the right tags for this bug? [17:30:41] framawiki, d3r1ck: Could you review my patch (and task)? https://gerrit.wikimedia.org/r/c/pywikibot/core/+/476106 [17:30:46] https://codein.withgoogle.com/dashboard/task-instances/4968379283668992/ [17:31:03] Will do! [17:31:12] (03CR) 10jerkins-bot: [V: 04-1] [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [17:31:16] ^-^ [17:32:19] (03CR) 10jerkins-bot: [V: 04-1] [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [17:32:31] (03PS1) 10Mobrovac: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476314 (https://phabricator.wikimedia.org/T210608) [17:32:33] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34): Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks - https://phabricator.wikimedia.org/T204986 (10Tchanders) [17:32:55] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34): Update Special:Block, Special:Unblock, API:Block, and API:Unblock to set/remove namespace blocks - https://phabricator.wikimedia.org/T204986 (10Tchanders) a:03Tchanders [17:33:54] (03CR) 10Anomie: "Looks good, seems to work. A few minor things in the comments." (035 comments) [php/excimer] - 10https://gerrit.wikimedia.org/r/476197 (owner: 10Tim Starling) [17:36:38] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/EventBus] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476314 (https://phabricator.wikimedia.org/T210608) (owner: 10Mobrovac) [17:37:18] (03CR) 10Mobrovac: "This caused the wmf.6 train to be blocked - T210608 - so I created a revert in I7fed41b9e82b79ef2aaab840ca71912f487340d9 . Note that the r" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/472189 (owner: 10Ppchelko) [17:38:50] 10Android-app-feature-Offline, 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): UX-enhancement - when there is no connectivity, disable articles list items that are not available offli... - https://phabricator.wikimedia.org/T158852 [17:40:12] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476307 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [17:41:11] (03Merged) 10jenkins-bot: Fix typo in mw.Title test [core] - 10https://gerrit.wikimedia.org/r/476242 (owner: 10Esanders) [17:41:55] (03PS2) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 [17:42:20] (03CR) 10jenkins-bot: Remove obsolete aliases from closures [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476307 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [17:42:54] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 (owner: 10Esanders) [17:43:44] (03CR) 10jenkins-bot: Fix typo in mw.Title test [core] - 10https://gerrit.wikimedia.org/r/476242 (owner: 10Esanders) [17:46:56] 10Design, 10VisualEditor (Current work): Draft design brief for section editing feature - https://phabricator.wikimedia.org/T208759 (10DannyH) [17:48:34] 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10Patch-For-Review, 10VisualEditor (Current work): Dialog actions are inconsistent in visual editor - https://phabricator.wikimedia.org/T205807 (10matmarex) (@iamjessklein said she wanted to take a look at this.) [17:49:50] 10VisualEditor (Current work): Extension of the Visual Editor namespaces on the French Wikiversity to "Project" (ns102) - https://phabricator.wikimedia.org/T182669 (10JTannerWMF) [17:50:47] 10OOUI (OOUI-0.29.6), 10Patch-For-Review: Undo/redo icons have white gap and arrow base at non-100% zoom levels - https://phabricator.wikimedia.org/T210622 (10Jdforrester-WMF) [17:50:59] 10OOUI (OOUI-0.29.6): Undo/redo icons have white gap and arrow base at non-100% zoom levels - https://phabricator.wikimedia.org/T210622 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [17:53:13] (03PS4) 10Jdlrobson: Every ambox has its own issue and icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475030 (https://phabricator.wikimedia.org/T202349) [17:53:19] (03CR) 10Daniel Kinzler: Move queries for first/prev/next revision into RevisionStore. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [17:54:28] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476252 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [17:54:37] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10Jdlrobson) @Jdrewniak pointe... [17:55:01] 10AbuseFilter, 10Anti-Harassment, 10Wikimedia-Logstash: Slow filters logstash dashboard no longer being updated - https://phabricator.wikimedia.org/T210636 (10MusikAnimal) [17:56:18] (03PS6) 10Daniel Kinzler: Move queries for first/prev/next revision into RevisionStore. [core] - 10https://gerrit.wikimedia.org/r/475467 [17:57:13] 10MediaWiki-extensions-OAuth, 10Patch-For-Review: Allow oauthclient-php to forge requests containing files - https://phabricator.wikimedia.org/T186739 (10Jnanaranjan_sahu) @0x010C Thank You Antoine for your respond. I am really stuck and thinking why I used this library as I am in the last stage of the develo... [17:57:26] 10Trust-and-Safety: Reset 2FA code for 'nakon' on en.wiki - https://phabricator.wikimedia.org/T210573 (10jrbs) Hi @Nakon, could you email ca@wikimedia.org from the email address associated with your Wikipedia account? Thanks. [17:57:41] 10Trust-and-Safety: Reset 2FA code for 'nakon' on en.wiki - https://phabricator.wikimedia.org/T210573 (10jrbs) p:05Triage>03High [17:58:22] (03CR) 10Awight: [C: 032] "FYI we don't need to return true any more, "return;" is sufficient." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [17:58:27] Urbanecm: any Tracker tasks for getting familiar with codebase? :D [17:59:45] 10AbuseFilter, 10Anti-Harassment, 10Wikimedia-Logstash: Slow filters logstash dashboard no longer being updated - https://phabricator.wikimedia.org/T210636 (10Daimona) 05Open>03Invalid @MusikAnimal Yeah, this is intended, see https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/472245/ [17:59:49] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476252 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:00:52] (03CR) 10Jdlrobson: [C: 04-2] "Why? This commit message should at least explain itself before making style changes to the codebase..." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:01:28] (03CR) 10Jdlrobson: [C: 04-2] "Is this because this is now done in the parent eslint config or are we allowing dot notation going forward?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:02:35] 04(no projects): Allow edits that touch multiple pages and that can still be undone with single click - https://phabricator.wikimedia.org/T210348 (10Aklapper) 05Open>03stalled [18:03:08] maybe I will start with flake8 violations [18:04:45] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10pmiazga)... [18:04:55] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Empty line in a comment should be interpreted as new paragraph - https://phabricator.wikimedia.org/T210237 (10takidelfin) a:03takidelfin I'll try do it. [18:05:11] (03CR) 10Hashar: "Please cherry pick it to wmf/1.33.0-wmf.6 so we can hotfix production as well :)" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:05:46] (03CR) 10Ladsgroup: "Already on it. Waiting for jenkins :D" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:06:38] (03CR) 10jerkins-bot: [V: 04-1] Every ambox has its own issue and icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475030 (https://phabricator.wikimedia.org/T202349) (owner: 10Jdlrobson) [18:08:08] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team: [EPIC] Prioritization tools for AfC and NPP - https://phabricator.wikimedia.org/T193782 (10MMiller_WMF) [18:08:10] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Simplify and improve consistency in curation toolbar display logic - https://phabricator.wikimedia.org/T207982 (10MMiller_WMF) 05Open>03Resolved Thanks for testing. This... [18:12:20] 10MediaWiki-extensions-ORES, 10Scoring-platform-team: Write tests for ApiHooksHandler - https://phabricator.wikimedia.org/T210638 (10awight) [18:13:10] 10TimedMediaHandler, 10Browser-Support-Apple-Safari: Video does not run on Safari - https://phabricator.wikimedia.org/T208704 (10Esanders) [18:14:39] (03CR) 10jerkins-bot: [V: 04-1] Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476314 (https://phabricator.wikimedia.org/T210608) (owner: 10Mobrovac) [18:15:13] (03CR) 10Zoranzoki21: "recheck" [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C) [18:15:15] (03CR) 10Thcipriani: [V: 032 C: 032] Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476314 (https://phabricator.wikimedia.org/T210608) (owner: 10Mobrovac) [18:15:43] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/476321 (https://phabricator.wikimedia.org/T210552) [18:17:05] (03Merged) 10jenkins-bot: build: Update linters [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476308 (owner: 10Esanders) [18:17:34] (03PS2) 10Jdlrobson: eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:17:50] (03CR) 10jenkins-bot: Revert "Revert "Revert "Set event datetime with microsecond resolution.""" [extensions/EventBus] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476314 (https://phabricator.wikimedia.org/T210608) (owner: 10Mobrovac) [18:18:04] (03CR) 10Jdlrobson: [C: 04-2] "Does the new commit message reflect what's happening here?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:19:17] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10bmansurov) @diego thanks for the feedback. I agree with you that we can improve the results by adding more features. I briefly talked with @leila about this and at this stage, because of time constrain... [18:19:18] (03PS1) 10Anomie: Enable assertions in tests/cpu.phpt [php/excimer] - 10https://gerrit.wikimedia.org/r/476323 [18:19:33] 10TimedMediaHandler, 10Browser-Support-Apple-Safari: Video does not run on Safari - https://phabricator.wikimedia.org/T208704 (10Esanders) [18:19:57] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: [Spike, 2hrs] Toast busters: I'm afraid of no toast - should toast be upstream to core? - https://phabricator.wikimedia.org/T209188 (10Niedzielski) [18:20:01] (03CR) 10jenkins-bot: build: Update linters [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476308 (owner: 10Esanders) [18:20:32] 10Discovery-Search, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10Krinkle) (Initial triage shows matches since at least wmf.1, feel free to move elsewhere as appropiate.) [18:22:29] (03CR) 10Jforrester: [C: 032] "> Patch Set 1: Code-Review-2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:22:46] 10Wikimedia-Language-setup, 10I18n: Auto-detect interface language for anonymous users on Wikimedia projects - https://phabricator.wikimedia.org/T5665 (10Sjoerddebruin) [18:23:45] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: mobile.toggle migrated to webpack - https://phabricator.wikimedia.org/T210208 (10ovasileva) [18:23:48] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476324 [18:23:59] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10ovasileva) [18:24:10] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476325 (https://phabricator.wikimedia.org/T210552) [18:25:44] takidelfin, looks you claimed a task, nice! [18:25:48] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.9.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476309 (owner: 10Esanders) [18:25:50] (03Merged) 10jenkins-bot: Fix alignment of checkboxes in monobook [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476310 (owner: 10Esanders) [18:25:52] (03Merged) 10jenkins-bot: Remove obsolete aliases from closures, and fix line lengths [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/473615 (https://phabricator.wikimedia.org/T208951) (owner: 10Jforrester) [18:25:54] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476326 (https://phabricator.wikimedia.org/T210552) [18:25:59] (03PS1) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [18:26:03] (03CR) 10jerkins-bot: [V: 04-1] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476324 (owner: 10Ejegg) [18:26:05] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:27:46] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476328 (https://phabricator.wikimedia.org/T210552) [18:27:50] (03CR) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.9.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476309 (owner: 10Esanders) [18:29:31] (03PS2) 10Daimona Eaytoy: Further clarify docs for emergency disable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/475824 [18:29:38] (03CR) 10jenkins-bot: Fix alignment of checkboxes in monobook [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476310 (owner: 10Esanders) [18:30:39] (03PS3) 10Jdlrobson: eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:30:41] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/476331 (https://phabricator.wikimedia.org/T210552) [18:31:28] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/476332 (https://phabricator.wikimedia.org/T210552) [18:31:52] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 (owner: 10Esanders) [18:31:57] (03Merged) 10jenkins-bot: Don't try to add scores in API where there is nothing to add [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:32:16] (03CR) 10Mholloway: [C: 032] Check that the page has a talk page before calling Title::getTalkPage [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 (owner: 10Pjht) [18:32:43] (03CR) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [18:33:14] (03CR) 10Jdlrobson: [C: 032] "> There's an explicit Task about what's happening and why." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:33:17] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) [18:33:30] (03PS4) 10Jdlrobson: eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [18:33:31] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) [18:33:53] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) p:05Triage>03Low [18:33:54] (03PS2) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [18:34:28] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:35:02] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Huji) I am setting priority, as I will be working on it myself. I am setting it to low for now, to match the parent task. But indeed, since T150826 has been al... [18:35:20] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30): Update EventLogging code to facilitate move to EditAttemptStep schema - https://phabricator.wikimedia.org/T207803 (10JTannerWMF) [18:35:29] (03PS3) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [18:35:34] (03PS1) 10Ladsgroup: Don't try to add scores in API where there is nothing to add [extensions/ORES] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476334 (https://phabricator.wikimedia.org/T210610) [18:35:44] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: MFA: [Spike, 2hr] Agree on a test approach for Views - https://phabricator.wikimedia.org/T209126 (10nray) The doc looks good to me so far. I'm sure there will be revisions down the road as we continue to port and learn new things [18:35:55] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:36:30] (03CR) 10Ladsgroup: [C: 032] Don't try to add scores in API where there is nothing to add [extensions/ORES] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476334 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:36:37] (03PS4) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [18:36:43] (03Merged) 10jenkins-bot: Check that the page has a talk page before calling Title::getTalkPage [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 (owner: 10Pjht) [18:37:01] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:37:06] 10Product-Analytics, 10Growth-Team (Current Sprint): Understanding first day: decide on a purging strategy for the EditorJourney schema - https://phabricator.wikimedia.org/T209721 (10JTannerWMF) [18:37:19] (03CR) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476253 (owner: 10Esanders) [18:37:25] (03PS5) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [18:37:50] (03CR) 10jerkins-bot: [V: 04-1] Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) (owner: 10Arcayn) [18:38:15] 10Product-Analytics, 10Growth-Team (Current Sprint): Help pane: experiments - https://phabricator.wikimedia.org/T206720 (10RHo) [18:38:58] (03PS1) 10Anomie: Fix ExcimerProfiler::setMaxDepth() [php/excimer] - 10https://gerrit.wikimedia.org/r/476338 [18:40:15] (03CR) 10jenkins-bot: Don't try to add scores in API where there is nothing to add [extensions/ORES] - 10https://gerrit.wikimedia.org/r/476279 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:40:40] (03Merged) 10jenkins-bot: Don't try to add scores in API where there is nothing to add [extensions/ORES] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476334 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:41:27] 10Product-Analytics, 10Growth-Team (Current Sprint): Help pane: experiments - https://phabricator.wikimedia.org/T206720 (10RHo) a:05RHo>03MMiller_WMF hi @MMiller_WMF – I posted some potential experiments in the task description to run based on our chat earlier, please review and make additions/changes as y... [18:42:03] (03CR) 10Anomie: Message: Don't include Title objects in the serialization (part 1) (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476287 (https://phabricator.wikimedia.org/T210528) (owner: 10Anomie) [18:42:50] (03CR) 10jenkins-bot: Don't try to add scores in API where there is nothing to add [extensions/ORES] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476334 (https://phabricator.wikimedia.org/T210610) (owner: 10Ladsgroup) [18:43:13] (03PS3) 10Anomie: Message: Don't include Title objects in the serialization (part 1) [core] - 10https://gerrit.wikimedia.org/r/476287 (https://phabricator.wikimedia.org/T210528) [18:43:16] (03PS3) 10Anomie: Message: Don't include Title objects in the serialization (part 2) [core] - 10https://gerrit.wikimedia.org/r/476288 (https://phabricator.wikimedia.org/T210528) [18:44:43] 10Design, 10MediaWiki-User-management, 10Anti-Harassment, 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Communicate user blocked status - https://phabricator.wikimedia.org/T209967 (10TBolliger) Overall this looks good to me, Pau. My only feedback would be that you may want... [18:44:57] 10MobileFrontend, 10Readers-Web-Backlog, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jdlrobson) [18:45:12] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) [18:45:17] 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jdlrobson) Hi @Jack_who_built_the_house per https://www.mediawiki.org/wiki/Recommendations_for_mobile_friend... [18:46:43] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) [18:47:41] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog: Bug: Category overlay does not refresh after category added - https://phabricator.wikimedia.org/T163121 (10Jdlrobson) [18:47:55] 10MediaWiki-User-management, 10Wikimedia-Site-requests: Dissallow eliminators to block sysops on fawiki - https://phabricator.wikimedia.org/T210642 (10Daimona) @Huji maybe we could add a new global config, for instance `wgGroupBlockRestrictions` to serve this purpose. In fawiki's case, that would take a value... [18:48:35] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog: Bug: Category overlay does not refresh after category added - https://phabricator.wikimedia.org/T163121 (10Jdlrobson) This came up during T188451. @LukBukkit helpfully explained what's going on here: > The problem is caused by the CategoryGateway. The... [18:49:01] 10Google-Code-in-2018, 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog: Bug: Category overlay does not refresh after category added - https://phabricator.wikimedia.org/T163121 (10Jdlrobson) [18:49:06] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/476341 (https://phabricator.wikimedia.org/T210552) [18:51:52] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) a:05Jdrewniak>03Jdlrobson Su... [18:53:04] 10OOUI (OOUI-0.29.6): Undo/redo icons have white gap and arrow base at non-100% zoom levels - https://phabricator.wikimedia.org/T210622 (10Volker_E) Thanks @Esanders for catching and fixing these. I've updated Lingo as well and provided a PR for updating the source Illustrator file in Style Guide. [18:54:56] 10address-knowledge-gaps, 10Epic: Output 1.1: Improved section recommendation algorithm with user-feedback - https://phabricator.wikimedia.org/T203043 (10leila) [18:59:43] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476324 (owner: 10Ejegg) [19:00:01] (03PS2) 10Cooltey: Fix: FacePostprocessor won't be completed in low-end devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) [19:00:32] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/476344 (https://phabricator.wikimedia.org/T210552) [19:00:34] (03CR) 10Catrope: [C: 032] Override supportsURLLoading() instead of getScriptURLsForDebug() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476187 (owner: 10Krinkle) [19:00:36] (03PS6) 10Anomie: Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) [19:00:46] (03PS1) 10Anomie: SQLite: Split actor and comment filearchive updates to a separate file [core] - 10https://gerrit.wikimedia.org/r/476345 [19:00:57] (03CR) 10VolkerE: Fix `id` for correct label association [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [19:01:54] (03CR) 10Krinkle: Fix locked UI above headings (031 comment) [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/465930 (owner: 10Prtksxna) [19:02:08] (03CR) 10Anomie: "check sqlite" [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) (owner: 10Anomie) [19:02:44] (03CR) 10Krinkle: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/476341 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:02:46] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text - https://phabricator.wikimedia.org/T194524 (10Volker_E) That's a screenshot in English (only language changed for the time being with the pat... [19:03:08] (03CR) 10Krinkle: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476328 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:03:51] (03CR) 10VolkerE: [C: 032] eslint: Drop 'dot-notation' rule [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/476331 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:04:05] 10QuickSurveys: Quick survey won't show up on mobile - https://phabricator.wikimedia.org/T210646 (10bmansurov) [19:04:08] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476324 (owner: 10Ejegg) [19:04:53] (03CR) 10Mobrovac: [C: 04-1] Add translation based 'morelike' API for missing articles (032 comments) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [19:05:33] (03PS3) 10Cooltey: Fix: lead image does not show in low-end devices if it requires face detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) [19:06:56] (03Merged) 10jenkins-bot: Override supportsURLLoading() instead of getScriptURLsForDebug() [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476187 (owner: 10Krinkle) [19:07:19] (03CR) 10Cooltey: ">" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) (owner: 10Cooltey) [19:08:30] (03CR) 10Bmansurov: Add translation based 'morelike' API for missing articles (031 comment) [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [19:09:05] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476347 (https://phabricator.wikimedia.org/T210552) [19:09:06] 10Growth-Team, 10Epic: [EPIC] Growth: Understanding first day - https://phabricator.wikimedia.org/T205754 (10MMiller_WMF) [19:09:11] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: Understanding first day: testing and QA - https://phabricator.wikimedia.org/T207307 (10MMiller_WMF) 05Open>03Resolved Thank you. We accomplished this. [19:09:55] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/476341 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:10:14] (03PS9) 10Bmansurov: Add translation based 'morelike' API for missing articles [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) [19:10:46] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule over-ride [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476348 (https://phabricator.wikimedia.org/T210552) [19:12:27] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476350 (https://phabricator.wikimedia.org/T210552) [19:13:13] (03CR) 10Dmaza: [C: 032] Don't indicate partial blocks on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [19:13:16] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/Score] - 10https://gerrit.wikimedia.org/r/476351 (https://phabricator.wikimedia.org/T210552) [19:13:52] 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: Personalized first day: build Variation A - https://phabricator.wikimedia.org/T206371 (10Etonkovidova) @MMiller_WMF >This version should work for both Javascript and non-Javascript users. The form accommodates n... [19:14:56] (03PS6) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [19:15:32] (03PS7) 10Arcayn: Add ability for users to ignore selected acks [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476327 (https://phabricator.wikimedia.org/T208655) [19:16:03] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476354 (https://phabricator.wikimedia.org/T210552) [19:17:04] 10Product-Analytics, 10Growth-Team (Current Sprint): Help pane: experiments - https://phabricator.wikimedia.org/T206720 (10JTannerWMF) a:05MMiller_WMF>03RHo [19:17:07] Where's the gerrit repo for the CollaborationKit extension? [19:17:39] 10Product-Analytics, 10Growth-Team (Current Sprint): Help pane: experiments - https://phabricator.wikimedia.org/T206720 (10JTannerWMF) a:05RHo>03MMiller_WMF [19:18:41] (03CR) 10Tpt: [C: 032] eslint: Drop 'dot-notation' rule [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476347 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:19:40] 10Growth-Team: Help pane: enable searching help articles - https://phabricator.wikimedia.org/T209301 (10JTannerWMF) [19:19:53] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476328 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:19:55] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/CodeEditor] - 10https://gerrit.wikimedia.org/r/476331 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:20:16] 10Product-Analytics, 10Growth-Team (Current Sprint): Understanding first day: post-deployment QA - https://phabricator.wikimedia.org/T209009 (10MMiller_WMF) [19:20:18] 10Product-Analytics, 10Growth-Team (Current Sprint): return/returnto query not always hashed as intended - https://phabricator.wikimedia.org/T210417 (10MMiller_WMF) 05Open>03declined [19:20:44] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint): [EPIC] Prioritization tools for AfC and NPP - https://phabricator.wikimedia.org/T193782 (10JTannerWMF) [19:20:59] Hello? [19:22:23] 10CirrusSearch, 10Discovery, 10Discovery-Search: ElasticaWrite.php: Unsupported operand types error with CirrusSearch in runJobs.php - https://phabricator.wikimedia.org/T157759 (10debt) Moving back into needs triage to review recent comments and suggestions. [19:24:06] (03CR) 10Krinkle: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Score] - 10https://gerrit.wikimedia.org/r/476351 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:24:42] pterp: Hey! [19:24:46] Hi! [19:24:53] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476364 (https://phabricator.wikimedia.org/T210552) [19:25:01] Have you found it? CollaborationKit repo link? [19:25:06] No. [19:25:19] That's why i'm asking. [19:25:40] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476365 (https://phabricator.wikimedia.org/T210552) [19:25:41] pterp: https://gerrit.wikimedia.org/r/admin/projects/mediawiki/extensions/CollaborationKit [19:25:48] Thanks! [19:25:48] You can find the link there [19:25:57] SSH, HTTP etc [19:26:01] You're welcome! [19:28:12] (03PS1) 10Jforrester: eslint: Drop 'dot-notation' rule [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476367 (https://phabricator.wikimedia.org/T210552) [19:28:33] 10CommRel-Documentation, 10Wikimedia-Technical-Conference-2018-Organization, 10CommRel-Specialists-Support (Oct-Dec-2018): Note Taking Feedback: Wikimedia Technical Conference - https://phabricator.wikimedia.org/T198988 (10debt) It looks like all the notes have been added to https://www.mediawiki.org/wiki/Wi... [19:28:54] (03CR) 10Krinkle: [C: 031] Add block notice stats on EditPage. [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:29:01] (03CR) 10Krinkle: [C: 031] "LGTM :)" [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:30:49] 10Reading-Admin: Add guards for session stitching - https://phabricator.wikimedia.org/T210648 (10dr0ptp4kt) [19:31:12] (03Merged) 10jenkins-bot: Don't indicate partial blocks on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [19:31:14] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476347 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:31:20] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Score] - 10https://gerrit.wikimedia.org/r/476351 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:31:21] Hi pterp! [19:31:28] Hi! [19:32:53] (03CR) 10Dbrant: [C: 032] "There we go." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) (owner: 10Cooltey) [19:33:20] 10Reading-Admin: Add guards for session stitching - https://phabricator.wikimedia.org/T210648 (10dr0ptp4kt) [19:33:50] (03CR) 10jenkins-bot: Don't indicate partial blocks on Special:ActiveUsers [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [19:34:29] (03CR) 10Cooltey: Create custom dialog with image (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475946 (https://phabricator.wikimedia.org/T209511) (owner: 10Sharvaniharan) [19:34:43] (03CR) 10Mooeypoo: [C: 032] Add block notice stats on EditPage. [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:34:46] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476347 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:37:20] (03CR) 10jerkins-bot: [V: 04-1] eslint: Drop 'dot-notation' rule [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476367 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:39:35] (03PS1) 10Dmaza: Add block notice stats on EditPage. [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476371 (https://phabricator.wikimedia.org/T201718) [19:41:51] 10MediaWiki-Releasing, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10Security: Install docker on releases-jenkins - https://phabricator.wikimedia.org/T208529 (10thcipriani) a:03thcipriani [19:42:21] (03PS1) 10Dbrant: Follow-up to face postprocessor. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476372 [19:43:02] 10Research, 10Patch-For-Review: Quicksurvey for reader trust - https://phabricator.wikimedia.org/T209882 (10Capt_Swing) [19:43:05] 10MediaWiki-Search, 10UI-Standardization, 10Discovery-Search: Suggestions in a search field on Special:Search should act the same as suggestions in search bar - https://phabricator.wikimedia.org/T210649 (10stjn) [19:43:29] 10Research, 10Patch-For-Review: Quicksurvey for reader trust - https://phabricator.wikimedia.org/T209882 (10Capt_Swing) Updated the task description to reflect new deployment window. [19:44:20] (03Merged) 10jenkins-bot: Fix: lead image does not show in low-end devices if it requires face detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) (owner: 10Cooltey) [19:44:24] (03PS1) 10Pjht: Replace jshint with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 [19:45:33] Urbanecm: Umm, Is it intentional? (margins) https://usercontent.irccloud-cdn.com/file/mVhF5h4C/tracker-margin [19:45:57] 10Research, 10Patch-For-Review: Quicksurvey for reader trust - https://phabricator.wikimedia.org/T209882 (10bmansurov) Update: We tested it on beta labs on desktop and the survey seemed to work. Couldn't get the survey to show up on mobile and created {T210646}. [19:46:26] (03CR) 10jenkins-bot: Fix: lead image does not show in low-end devices if it requires face detection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) (owner: 10Cooltey) [19:46:40] takidelfin, no, it isn't, thanks for spotting that! I'm just too lazy to fix it ;). Feel free to upload a patch! [19:46:53] okay :D [19:49:47] (03CR) 10VolkerE: [C: 04-1] "SVG changes?" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:51:01] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Goal: [GOAL] Advanced mobile contributions - https://phabricator.wikimedia.org/T198313 (10ovasileva) [19:51:16] 10Advanced Mobile Contributions, 10Product-Analytics, 10Reading-analysis, 10Readers-Web-Backlog (Tracking): Generate list of most used special pages - https://phabricator.wikimedia.org/T198218 (10ovasileva) [19:51:35] (03CR) 10VolkerE: [C: 032] eslint: Drop 'dot-notation' rule [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476325 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:52:35] 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Investigate ideas for navigation for advanced mobile contributions - https://phabricator.wikimedia.org/T198319 (10ovasileva) [19:53:23] 10Design, 10MobileFrontend, 10Advanced Mobile Contributions, 10Wikimedia-Israel-Hackers, and 4 others: [Epic] Display the categories on the mobile site for everyone - https://phabricator.wikimedia.org/T24660 (10ovasileva) [19:53:33] 10donate.wikimedia.org: Typo in "Ways to give" on donate.wikimedia.org - https://phabricator.wikimedia.org/T210650 (10Deskana) [19:54:01] 10Design, 10MediaWiki-Categories, 10MobileFrontend, 10Advanced Mobile Contributions, and 4 others: [EPIC] Redesign category pages and overlay for mobile - https://phabricator.wikimedia.org/T142124 (10ovasileva) [19:54:07] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10Continuous-Integration-Config: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Anomie) Apparently the test added for {T209232} is sometimes running out of allowed memor... [19:54:14] 10donate.wikimedia.org: Typo in "Ways to give" on donate.wikimedia.org - https://phabricator.wikimedia.org/T210650 (10Deskana) [19:54:22] 10Design, 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Need-volunteer: Display categories button for logged-in users on mobile web stable - https://phabricator.wikimedia.org/T152199 (10ovasileva) [19:54:28] 10donate.wikimedia.org: Typo in "Ways to give" on donate.wikimedia.org - https://phabricator.wikimedia.org/T210650 (10Deskana) Sorry. got the tags wrong there. [19:54:37] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic, 10Technical-Debt: Rewrite CategoryOverlay using composition, adding tests - https://phabricator.wikimedia.org/T161050 (10ovasileva) [19:54:50] (03PS1) 10Cooltey: Fix: Image license info often displays the 'uploader unknown' incorrectly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476374 (https://phabricator.wikimedia.org/T210544) [19:54:59] 10MediaWiki-Categories, 10Advanced Mobile Contributions, 10Mobile: (2) Restyle category pagination links as buttons - https://phabricator.wikimedia.org/T85495 (10ovasileva) [19:55:06] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Image license info often displays the 'uploader unknown' incorrectly - https://phabricator.wikimedia.org/T210544 (10cooltey) a:03cooltey [19:55:09] 10Proton, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Deploy the mediawiki-services-chromium-render service (Proton) - https://phabricator.wikimedia.org/T181084 (10pmiazga) [19:55:16] (03Merged) 10jenkins-bot: Add block notice stats on EditPage. [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:55:23] 10MobileFrontend, 10Advanced Mobile Contributions, 10Wikidata, 10Wikidata Mobile, 10Readers-Web-Backlog (Design): Link to wikidata item in mobile view - https://phabricator.wikimedia.org/T183126 (10ovasileva) [19:55:39] 10Research, 10Patch-For-Review: Quicksurvey for reader trust - https://phabricator.wikimedia.org/T209882 (10Capt_Swing) [19:55:41] (03CR) 10Jforrester: "> Patch Set 1: Code-Review-1" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/476340 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [19:56:41] (03PS1) 10Yaron Koren: Add TRIM() hack for not-to-be-parsed fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476375 [19:56:44] 10Design, 10Advanced Mobile Contributions, 10MinervaNeue, 10Readers-Web-Backlog (Design): Improve how talk page is accessible on mobile Web - https://phabricator.wikimedia.org/T193044 (10ovasileva) [19:57:11] 10MediaWiki-Watchlist, 10Advanced Mobile Contributions, 10Growth-Team, 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): Unseen changes on the Watchlist are not highlighted/bold on mobile site - https://phabricator.wikimedia.org/T198807 (10ovasileva) [19:57:22] (03CR) 10Cooltey: [C: 032] Follow-up to face postprocessor. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476372 (owner: 10Dbrant) [19:57:27] (03CR) 10jenkins-bot: Add block notice stats on EditPage. [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [19:57:30] 10MediaWiki-History-or-Diffs, 10Advanced Mobile Contributions, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): It's not possible to undo edits from the revision history or d... - https://phabricator.wikimedia.org/T191706 [19:57:59] 10Advanced Mobile Contributions, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid err... - https://phabricator.wikimedia.org/T193505 [19:58:04] (03CR) 10Catrope: [C: 04-1] IE: add/remove sort options because show/hide doesn't work (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) (owner: 10Sbisson) [19:58:27] (03CR) 10Sharvaniharan: Create custom dialog with image (033 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475946 (https://phabricator.wikimedia.org/T209511) (owner: 10Sharvaniharan) [19:58:35] 10Advanced Mobile Contributions, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: AMC: Collect data on users who are switching from mobile to desktop - https://phabricator.wikimedia.org/T208457 (10ovasileva) [19:59:19] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Design): What links here on mobileview - https://phabricator.wikimedia.org/T208698 (10ovasileva) [20:00:06] (03PS2) 10Yaron Koren: Add TRIM() hack for not-to-be-parsed fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476375 [20:00:08] (03CR) 10Dbrant: [C: 032] Fix: Image license info often displays the 'uploader unknown' incorrectly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476374 (https://phabricator.wikimedia.org/T210544) (owner: 10Cooltey) [20:00:37] 10Research: Interface text for Reader Trust Quicksurvey - https://phabricator.wikimedia.org/T210029 (10Capt_Swing) [20:00:54] (03CR) 10Catrope: [C: 04-1] WIP: Add help button and pane (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [20:00:54] 10Advanced Mobile Contributions, 10MW-1.27-release (WMF-deploy-2016-01-12_(1.27.0-wmf.10)), 10MinervaNeue (3rd party support), 10Readers-Web-Backlog (Design): Allow configuration of the Minerva menu - https://phabricator.wikimedia.org/T65459 (10ovasileva) [20:01:17] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Design): Allow users to reach the current version of a page directly from mobile diff - https://phabricator.wikimedia.org/T200804 (10ovasileva) [20:01:26] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Design): No way to reach the editable version of a page when viewing the most recent mobile diff - https://phabricator.wikimedia.org/T200969 (10ovasileva) [20:01:46] 10MobileFrontend, 10Advanced Mobile Contributions, 10MinervaNeue, 10Readers-Web-Backlog (Design): Hack to edit the 1st section of the page when the 0th section is empty doesn't work if the page has a TOC - https://phabricator.wikimedia.org/T205403 (10ovasileva) [20:02:39] 10MediaWiki-Recent-changes, 10Advanced Mobile Contributions, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, and 3 others: Enable new RC on mobile - https://phabricator.wikimedia.org/T178194 (10ovasileva) [20:02:43] (03PS1) 10Catrope: Consistently call restore_error_handler() from finally { } [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476376 (https://phabricator.wikimedia.org/T208146) [20:02:54] (03PS5) 10Sbisson: [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) [20:02:57] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog: Cannot access user contributions when following red link to user page on mobile - https://phabricator.wikimedia.org/T201339 (10ovasileva) [20:03:07] 10MobileFrontend, 10Advanced Mobile Contributions, 10Readers-Web-Backlog (Design): Make it possible to reach the page history from mobile diff - https://phabricator.wikimedia.org/T201228 (10ovasileva) [20:03:08] Urbanecm: Is it possible to add a file minifier in Django? I have found something: https://github.com/django-compressor/django-compressor [20:03:35] \o/ [20:04:59] (03PS2) 10Sbisson: IE: append/detach sort options because show/hide doesn't work [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) [20:05:19] (03CR) 10jerkins-bot: [V: 04-1] [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [20:06:37] (03CR) 10Yaron Koren: [C: 032] Add TRIM() hack for not-to-be-parsed fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476375 (owner: 10Yaron Koren) [20:08:03] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476325 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [20:08:10] (03CR) 10Catrope: [C: 032] Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [20:08:34] (03Merged) 10jenkins-bot: Follow-up to face postprocessor. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476372 (owner: 10Dbrant) [20:08:55] 10Research: Gather feedback on algorithmic bias report from internal stakeholders - https://phabricator.wikimedia.org/T207515 (10Capt_Swing) Meeting scheduled with Margeigh, Aaron, Jess, Marshall & Adam on 12/13. Meeting scheduled with Research team on 12/18. [20:09:09] (03CR) 10jerkins-bot: [V: 04-1] [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) (owner: 10Sbisson) [20:09:15] 10Research: Gather feedback on algorithmic bias report from internal stakeholders - https://phabricator.wikimedia.org/T207515 (10Capt_Swing) p:05Triage>03Normal [20:09:46] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC - Opting in - https://phabricator.wikimedia.org/T210653 (10ovasileva) p:05Triage>03Normal [20:10:04] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/476325 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [20:10:10] (03CR) 10Catrope: [C: 032] Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [20:10:42] (03CR) 10jenkins-bot: Follow-up to face postprocessor. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476372 (owner: 10Dbrant) [20:10:51] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [20:12:46] (03PS6) 10Jdlrobson: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 [20:13:18] (03Merged) 10jenkins-bot: Add TRIM() hack for not-to-be-parsed fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476375 (owner: 10Yaron Koren) [20:13:40] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [Epic] AMC Navigation - https://phabricator.wikimedia.org/T210655 (10ovasileva) p:05Triage>03Normal [20:13:52] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - https://phabricator.wikimedia.org/T210655 (10ovasileva) [20:14:08] (03CR) 10jerkins-bot: [V: 04-1] Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [20:14:10] (03CR) 10jerkins-bot: [V: 04-1] Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [20:15:26] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - https://phabricator.wikimedia.org/T210655 (10ovasileva) [20:15:37] takidelfin, sorry, I was having a dinner [20:16:04] Urbanecm: Umm, if there is no phabricator task for a patch, what should I do with 'Bug' in commit message? [20:17:49] Two possibilities: 1) If you want to keep an eye on the task's progress, you can create one! As this is going to be single and simple patch, there's probably no need for it. 2) In case you don't want a Phabricator task, you can simply not include any Bug: line at all [20:17:52] (03CR) 10Pmiazga: [C: 031] Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [20:18:05] thanks ^-^ [20:18:13] (03CR) 10Nray: [C: 032] Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [20:18:30] yw [20:18:48] (03CR) 10jenkins-bot: Add TRIM() hack for not-to-be-parsed fields [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476375 (owner: 10Yaron Koren) [20:19:33] (03CR) 10C. Scott Ananian: [C: 04-1] "Self C-1'ing since Anomie's right: I can easily add a test case for this before it's merged." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [20:19:53] (03CR) 10Jforrester: [C: 032] "Fun." [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476376 (https://phabricator.wikimedia.org/T208146) (owner: 10Catrope) [20:20:09] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - page/talk toggle - https://phabricator.wikimedia.org/T210658 (10ovasileva) p:05Triage>03Normal [20:21:16] (03Merged) 10jenkins-bot: Fix: Image license info often displays the 'uploader unknown' incorrectly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476374 (https://phabricator.wikimedia.org/T210544) (owner: 10Cooltey) [20:21:41] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] eslint: Drop 'dot-notation' rule over-ride [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476348 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [20:22:50] (03CR) 10Jforrester: [C: 032] SQLite: Split actor and comment filearchive updates to a separate file [core] - 10https://gerrit.wikimedia.org/r/476345 (owner: 10Anomie) [20:22:56] (03CR) 10DCausse: [C: 032] Correct regex escaping [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476112 (owner: 10EBernhardson) [20:23:05] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Jhernandez) This work is specifically about the skin Minerva, and its frontend, and splitting mobilefrontend and minerva sen... [20:23:13] (03Merged) 10jenkins-bot: Correct regex escaping [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476112 (owner: 10EBernhardson) [20:23:17] (03Merged) 10jenkins-bot: Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (https://phabricator.wikimedia.org/T210545) (owner: 10EBernhardson) [20:23:24] (03CR) 10jenkins-bot: Fix: Image license info often displays the 'uploader unknown' incorrectly [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476374 (https://phabricator.wikimedia.org/T210544) (owner: 10Cooltey) [20:23:29] takidelfin, ad minification, I didn't find anything bad on that library - I didn't try it, through. Feel free to upload a patch too [20:23:38] (03CR) 10jerkins-bot: [V: 04-1] Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [20:24:10] 10MediaWiki-Categories, 10MediaWiki-Internationalization: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10cscott) I don't have any problem with using the unicode codepoint. I just don't think we should invent a bogus entity name for it. You can use the... [20:24:36] 10Research: Interface text for Reader Trust Quicksurvey - https://phabricator.wikimedia.org/T210029 (10Capt_Swing) @bmansurov all the necessary interface pages have been created! [20:25:04] (03PS1) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476379 [20:25:07] (03CR) 10Ejegg: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476379 (owner: 10Ejegg) [20:25:20] If not anything else, you'll learn something new, which is good enough itself :) [20:26:09] (ノ◕ヮ◕)ノ*:・゚✧ [20:27:15] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - Actions menu (primary actions) - https://phabricator.wikimedia.org/T210659 (10ovasileva) p:05Triage>03Normal [20:27:43] (03PS1) 10Takidelfin: Fix: Remove negative margin from forms [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476380 [20:27:47] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Navigation - Actions menu (primary actions) - https://phabricator.wikimedia.org/T210659 (10ovasileva) @alexhollender - did we decide whether we wanted to have the menu only show when scrolling up? [20:27:50] (03PS1) 10Ottomata: Move errors out of scores object into its own array [event-schemas] - 10https://gerrit.wikimedia.org/r/476381 (https://phabricator.wikimedia.org/T210465) [20:28:09] (03CR) 10jerkins-bot: [V: 04-1] Fix: Remove negative margin from forms [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476380 (owner: 10Takidelfin) [20:28:49] Urbanecm: uh, `This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset.` [20:29:16] My local repo is outdated? [20:29:22] takidelfin, exactly [20:29:30] Gerrit has a rebase button in it [20:29:37] I'm not sure if it will work in your case, but it might [20:29:51] try to press it and rebase on top of the master branch [20:30:17] Merge conflict :( [20:30:37] In that case, please switch to master branch of your local repository and do git pull [20:30:53] when done, checkout back the branch with your code and do git rebase master [20:31:33] then you'll have to resolve conflict(s) it reported [20:31:43] (git status might be useful) [20:31:49] ye, I know :D [20:32:02] (03CR) 10Joal: [C: 031] "LGTM !" [event-schemas] - 10https://gerrit.wikimedia.org/r/476381 (https://phabricator.wikimedia.org/T210465) (owner: 10Ottomata) [20:32:08] (03PS2) 10Takidelfin: Fix: Remove negative margin from forms [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476380 [20:32:13] (03CR) 10VolkerE: [C: 032] Add monospace font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/475949 (https://phabricator.wikimedia.org/T209915) (owner: 10VolkerE) [20:32:30] Ok, nice! :D [20:33:07] (03Merged) 10jenkins-bot: Add monospace font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/475949 (https://phabricator.wikimedia.org/T209915) (owner: 10VolkerE) [20:33:37] wow.... such a fast test. onlt 48 sec :O [20:34:28] (03CR) 10Legoktm: [C: 04-1] "You also need to update package.json to add a dependency upon eslint and remove the jshint/jscs dependencies." (033 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (owner: 10Pjht) [20:34:42] Honestly I'd like to see it faster some times :D [20:35:08] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General, 10Need-volunteer, 10Patch-For-Review, 10goodfirstbug: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139 (10PFWOz) Is it expected for this to break these extensions on 1.27... [20:35:13] comparing it to ~ 23 minutes in other projects [20:35:21] it is blazing fast [20:35:54] (03PS1) 10Takidelfin: Git: Ignore configuration files from text editors/IDEs [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476382 [20:36:02] 10Advanced Mobile Contributions, 10Readers-Web-Backlog, 10Epic: [EPIC] AMC Metrics - https://phabricator.wikimedia.org/T210660 (10ovasileva) p:05Triage>03Normal [20:36:22] :) [20:36:25] * Urbanecm is reviewing the patch [20:37:18] (03CR) 10Nuria: [C: 032] Move errors out of scores object into its own array [event-schemas] - 10https://gerrit.wikimedia.org/r/476381 (https://phabricator.wikimedia.org/T210465) (owner: 10Ottomata) [20:37:35] (03Merged) 10jenkins-bot: Move errors out of scores object into its own array [event-schemas] - 10https://gerrit.wikimedia.org/r/476381 (https://phabricator.wikimedia.org/T210465) (owner: 10Ottomata) [20:38:04] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Hindi-Sites, 10Patch-For-Review, and 2 others: Enable $wgMFNoindexPages for: Italian, Dutch, Korean, Arabic, Chinese, and Hindi Wikipedias - https://phabricator.wikimedia.org/T206497 (10Legoktm) >>! In T206497#4781442, @Imarlier wrote: > We have an explicit ind... [20:38:21] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10leila) @bmansurov I did some eye-balling and here are my observations: * There are a lot of false-positives in the set: items that are suggested to be the same while they're not. For the initial applica... [20:40:52] (03CR) 10Urbanecm: [C: 032] Fix: Remove negative margin from forms [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476380 (owner: 10Takidelfin) [20:41:47] (03Merged) 10jenkins-bot: Fix: Remove negative margin from forms [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476380 (owner: 10Takidelfin) [20:41:54] (03PS1) 10Jdlrobson: Nearby works again locally! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476384 (https://phabricator.wikimedia.org/T204876) [20:41:57] (03PS1) 10Ottomata: Revert "Move errors out of scores object into its own array" [event-schemas] - 10https://gerrit.wikimedia.org/r/476385 [20:42:02] \o/ [20:42:08] (03CR) 10Ottomata: [V: 032 C: 032] Revert "Move errors out of scores object into its own array" [event-schemas] - 10https://gerrit.wikimedia.org/r/476385 (owner: 10Ottomata) [20:42:37] 10Google-Code-in-2018, 10MobileFrontend, 10Need-volunteer, 10Patch-For-Review, and 2 others: [Bug - development NOT production] Nearby TypeError when using JSONPForeignApi - https://phabricator.wikimedia.org/T204876 (10Jdlrobson) [20:43:35] (03PS1) 10Ottomata: Ok, since the other one was accidentally merged, we'll use this revert revert for review. [event-schemas] - 10https://gerrit.wikimedia.org/r/476386 [20:44:52] (03PS2) 10Pjht: Replace jslint and jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) [20:45:09] (03PS2) 10Ottomata: Move errors out of scores object into its own array [event-schemas] - 10https://gerrit.wikimedia.org/r/476386 (https://phabricator.wikimedia.org/T210465) [20:45:40] (03CR) 10Urbanecm: [C: 032] Git: Ignore configuration files from text editors/IDEs [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476382 (owner: 10Takidelfin) [20:46:33] (03PS3) 10Pjht: Replace jslint and jscs with eslint [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) [20:47:23] (03Merged) 10jenkins-bot: Git: Ignore configuration files from text editors/IDEs [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476382 (owner: 10Takidelfin) [20:47:27] (03CR) 10Bartosz Dziewoński: "I think this is the change that caused a (broken) parser test in Kartographer to start failing: https://gerrit.wikimedia.org/r/c/mediawiki" [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [20:48:04] 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jack_who_built_the_house) The problem is that adding the class `hatnote` doesn't help, I've tried that on [[... [20:49:16] (03CR) 10Pjht: Replace jslint and jscs with eslint (033 comments) [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/476373 (https://phabricator.wikimedia.org/T210365) (owner: 10Pjht) [20:51:08] (03CR) 10Mooeypoo: [C: 032] Add stats for block errors on create/edit actions [core] - 10https://gerrit.wikimedia.org/r/474020 (https://phabricator.wikimedia.org/T201717) (owner: 10Dmaza) [20:53:50] (03PS1) 10Isarra: Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 [20:53:52] 10Design, 10VisualEditor, 10Readers-Web-Backlog (Design): Catalogue where the MobileFrontend loading overlay is used - https://phabricator.wikimedia.org/T209708 (10marcella) [20:54:49] 10donate.wikimedia.org: Donation leads to missing Thank you/vi page - https://phabricator.wikimedia.org/T210587 (10Pcoombe) a:03Pcoombe Oh, that's not good. As a stopgap I've redirected Vietnamese and other top 40 most used languages where we don't already have a translation to [the English page](https://donat... [20:56:34] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10abian) [20:56:58] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Wikimedia-production-error: Avoid "Lock wait timeout exceeded" from MessageGroupStats::clear - https://phabricator.wikimedia.org/T134252 (10Etonkovidova) @Nikerabbit I see numer... [20:57:27] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General, 10Need-volunteer, 10Patch-For-Review, 10goodfirstbug: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139 (10TheDJ) @PFWOz yes. We always advise people to use extensions that... [21:01:19] (03CR) 10jerkins-bot: [V: 04-1] Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 (owner: 10Isarra) [21:01:26] (03PS1) 10Paladox: Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 [21:01:58] (03CR) 10TheDJ: [C: 032] eslint: Drop 'dot-notation' rule [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476364 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [21:02:09] (03CR) 10jerkins-bot: [V: 04-1] Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 (owner: 10Paladox) [21:03:44] (03PS2) 10Paladox: Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 [21:04:29] (03PS23) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [21:04:48] (03CR) 10Kosta Harlan: WIP: Add help button and pane (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [21:05:40] (03PS2) 10Isarra: Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 [21:07:47] (03CR) 10Yaron Koren: [C: 032] Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 (owner: 10Paladox) [21:08:12] (03PS1) 10Nathan fraignt: Change internationalize notifications [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476390 (https://phabricator.wikimedia.org/T196425) [21:08:39] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10Continuous-Integration-Config: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Bawolff) The gci task is already accepted - we cant force the student to do more work... [21:09:30] Urbanecm: I am trying to do some redesign in Tracker's calendar. And... I have discovered a really strange thing. `previous` arrow is always smaller than `next` (18px > 21px) https://usercontent.irccloud-cdn.com/file/qPLSpa65/calendar-newstyle [21:09:48] (03CR) 10jerkins-bot: [V: 04-1] Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 (owner: 10Isarra) [21:09:53] :/ [21:10:10] 10Discovery-Search, 10Elasticsearch, 10monitoring: Elasticsearch health check for shards icinga check shows OK status when cluster health is yellow - https://phabricator.wikimedia.org/T210668 (10herron) p:05Triage>03Normal [21:10:23] (03PS14) 10Jdlrobson: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [21:10:24] It was there before I started modyfying styles [21:10:25] (03PS2) 10Jdlrobson: Nearby works again locally! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476384 (https://phabricator.wikimedia.org/T204876) [21:10:49] takidelfin, hmm, that's very strange [21:10:55] will have a look in a moment, walking a dog [21:10:58] see you in 15 mins [21:11:01] :D [21:11:05] 👋 [21:12:09] (03PS24) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [21:12:24] 04(no projects): Changing 2fa app - https://phabricator.wikimedia.org/T210669 (10Physikerwelt) [21:12:53] (03CR) 10jenkins-bot: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [21:13:58] 10MediaWiki-Maintenance-scripts, 10MediaWiki-extensions-General, 10Need-volunteer, 10Patch-For-Review, 10goodfirstbug: Update Maintenance scripts in extensions to use $this->requireExtension() - https://phabricator.wikimedia.org/T152139 (10PFWOz) @TheDJ Thanks. I'll request backports of some significant... [21:14:20] 10MediaWiki-Debug-Logger, 10Cloud-Services: Changing 2fa app - https://phabricator.wikimedia.org/T210669 (10Physikerwelt) [21:14:28] (03PS15) 10Jdlrobson: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [21:14:30] (03PS3) 10Jdlrobson: Nearby works again locally! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476384 (https://phabricator.wikimedia.org/T204876) [21:14:34] 10MediaWiki-Debug-Logger, 10Cloud-Services: Changing 2fa app - https://phabricator.wikimedia.org/T210669 (10Physikerwelt) p:05Triage>03Normal [21:14:55] 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Prepare selenium browser test for page issues A/B test - https://phabricator.wikimedia.org/T206647 (10nray) The page issues tests pass for me locally as sho... [21:15:52] (03PS3) 10Isarra: Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 [21:15:54] (03PS1) 10Dmaza: Change config flag for enabling Block Notice stats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476392 (https://phabricator.wikimedia.org/T201719) [21:15:56] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476254 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [21:16:41] Krinkle: could you have another look into https://gerrit.wikimedia.org/r/#/c/wikimedia-ui-base/+/463547/ it's mostly just awaiting 2nd look into after last comment and it blocks me from next base release to be used in style guide [21:16:41] 10MediaWiki-Debug-Logger, 10Cloud-Services: Changing 2fa app - https://phabricator.wikimedia.org/T210669 (10Physikerwelt) [21:17:34] (03PS2) 10Dmaza: Change config flag for enabling Block Notice stats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476392 (https://phabricator.wikimedia.org/T201719) [21:18:06] (03CR) 10Pmiazga: [C: 031] "Tested locally, works as expected" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [21:18:12] (03CR) 10Pmiazga: [C: 032] Simplify APIParseExtender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [21:18:36] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MobileFrontend throws away warnings and other data from action=parse - https://phabricator.wikimedia.org/T86210 (10pmiazga) [21:18:57] 10MediaWiki-Debug-Logger, 10wikitech.wikimedia.org: Wikitech fails to enable 2fa - https://phabricator.wikimedia.org/T210669 (10Andrew) p:05Normal>03High [21:19:08] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [21:19:12] 10MediaWiki-Debug-Logger, 10wikitech.wikimedia.org: Wikitech fails to enable 2fa - https://phabricator.wikimedia.org/T210669 (10bd808) [21:19:15] 10MediaWiki-Debug-Logger, 10wikitech.wikimedia.org: Wikitech fails to enable 2fa - https://phabricator.wikimedia.org/T210669 (10Andrew) This happens to me too. It's not currently possible to enable 2fa. [21:19:24] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) p:05Triage>03Unbreak! I can replicate on beta cluster and locally [21:19:31] (03CR) 10Mobrovac: [C: 031] "LGTM. @Ppchelko, could you please give it a quick review as well?" [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [21:19:40] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10pmiazga)... [21:19:48] 10MobileFrontend, 10Readers-Web-Backlog, 10Epic: [Epic] Improve PHPUnit coverage in MobileFrontend to medium - https://phabricator.wikimedia.org/T208761 (10pmiazga) [21:19:51] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10pmiazga) 05Open>03Resolved [21:19:58] (03PS2) 10Tim Starling: Add ProfilerExcimer [core] - 10https://gerrit.wikimedia.org/r/476198 [21:20:36] https://usercontent.irccloud-cdn.com/file/2rQMLUNl/screenshot_20181128_222003.png [21:20:47] It is centered vertically [21:21:03] (03PS1) 10C. Scott Ananian: Update repo URL in package.json after migration to WMF gerrit [libs/LangConv] - 10https://gerrit.wikimedia.org/r/476394 [21:21:47] (03PS1) 10C. Scott Ananian: Add AUTHORS.txt file [libs/LangConv] - 10https://gerrit.wikimedia.org/r/476395 [21:22:36] (03PS4) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (https://phabricator.wikimedia.org/T210671) [21:24:13] (03PS1) 10Jdlrobson: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) [21:24:24] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Milimetric) I think the questions are around unifying Mobile Front End and Core. Is this a good idea, something that's plan... [21:24:30] (03CR) 10jerkins-bot: [V: 04-1] Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:24:45] (03PS5) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (https://phabricator.wikimedia.org/T210671) [21:25:13] (03PS2) 10Jdlrobson: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) [21:25:20] 10Discovery-Search, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10EBernhardson) Rather than track this at the mediawiki level, i recorded all the http traffic coming into the eqiad search cluster, waited for some error messages to... [21:26:39] (03PS3) 10Jdlrobson: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) [21:27:02] (03PS4) 10Jdlrobson: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) [21:27:36] 10Discovery-Search, 10Wikimedia-production-error: Intermittent json parse failures in comp suggest - https://phabricator.wikimedia.org/T208248 (10EBernhardson) @dcausse you might have an idea of how completion suggester could have no requests? [21:27:37] (03PS3) 10Sharvaniharan: Create custom dialog with image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475946 (https://phabricator.wikimedia.org/T209511) [21:28:00] (03CR) 10Catrope: [C: 032] IE: append/detach sort options because show/hide doesn't work [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) (owner: 10Sbisson) [21:28:36] Urbanecm: Okay, I found a fix for this CSS bug. `display:flex` to parent div and `margin-right:auto` to 'previous' [21:28:50] (03CR) 10Jdlrobson: [C: 04-1] "Checking other things... dont merge just yet." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:29:27] 10Timeless, 10Chinese-Sites: Empty strings in Chinese - https://phabricator.wikimedia.org/T202213 (10Isarra) 05Open>03Resolved a:03Isarra [21:31:20] 10MediaWiki-Debug-Logger, 10wikitech.wikimedia.org: Wikitech fails to enable 2fa - https://phabricator.wikimedia.org/T210669 (10Andrew) ` 2018-11-28 21:30:15 [21e0eb4bd24ee09ec643ca0f] labweb1002 labswiki 1.33.0-wmf.6 error ERROR: [21e0eb4bd24ee09ec643ca0f] /wiki/Special:Two-factor_authentication ErrorExcept... [21:31:29] 10UI-Standardization, 10ProofreadPage, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Jayprakash12345) [21:32:08] takidelfin, I'm back. Nice you found a solution [21:32:16] (03PS1) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [21:33:18] Urbanecm: This error exists on 'production' too [21:33:27] (03CR) 10jerkins-bot: [V: 04-1] Add ProfilerExcimer [core] - 10https://gerrit.wikimedia.org/r/476198 (owner: 10Tim Starling) [21:33:36] yup [21:34:08] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:35:09] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:35:17] I think we can use your solution [21:36:46] (03PS1) 10TheDJ: Translate magicwords of file to chechen [core] - 10https://gerrit.wikimedia.org/r/476400 (https://phabricator.wikimedia.org/T196784) [21:37:01] 10MediaWiki-Parser, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Arlolra) After that deploy, Parsoid now gets this rig... [21:37:51] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, ImageOverlay - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [21:38:39] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) [21:38:43] 10MediaWiki-Internationalization, 10Patch-For-Review: Image alignment dropdown options in WikiEditor are not localized correctly in Chechen wikipedia - https://phabricator.wikimedia.org/T196784 (10TheDJ) ping @Umar hi, can you provide your feedback to my change that is linked in the comment above ? I've not re... [21:40:27] 10MediaWiki-Core-Tests: If Zlib extension is not loaded, the Zlib related tests should be skipped - https://phabricator.wikimedia.org/T207125 (10D3r1ck01) @RazeSoldier, are you talking of https://codesearch.wmflabs.org/core/?q=Zlib&i=nope&files=&repos= or are there more? [21:41:09] (03PS2) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [21:42:00] (03PS3) 10Ladsgroup: Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) [21:43:06] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:43:08] (03PS5) 10Ladsgroup: Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) [21:43:42] 10UI-Standardization, 10ProofreadPage, 10Patch-For-Review, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Jayprakash12345) [21:44:01] (03CR) 10jerkins-bot: [V: 04-1] Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [21:44:04] 10UI-Standardization, 10Goal: Convert all extensions/skins to OOUI - https://phabricator.wikimedia.org/T122014 (10Jayprakash12345) [21:44:11] 10UI-Standardization, 10ProofreadPage, 10Patch-For-Review, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Jayprakash12345) [21:44:15] Urbanecm: `ImproperlyConfigured at / [21:44:15] settings.DATABASES is improperly configured. Please supply the ENGINE value. Check settings documentation for more details.` [21:44:31] `'ENGINE': 'django.db.backends.sqlite3', # Add 'postgresql_psycopg2', 'mysql', 'sqlite3' or 'oracle'. [21:44:31] 'NAME': './trackerdb.sqlite', # Or path to database file if using sqlite3.` [21:44:42] hmm [21:44:52] 10UI-Standardization, 10ProofreadPage, 10Patch-For-Review, 10User-Jayprakash12345: Convert Extension:ProofreadPage to use OOUI - https://phabricator.wikimedia.org/T210672 (10Jayprakash12345) p:05Triage>03Normal [21:44:59] Everything was fine before ;-; [21:45:34] (03CR) 10Catrope: Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:45:39] (03CR) 10Catrope: [C: 032] Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:46:16] (03CR) 10Jack Phoenix: [C: 032] Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 (owner: 10Isarra) [21:47:37] (03PS3) 10Jayprakash12345: Convert Extension:ProofreadPage to use OOUI [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) [21:48:11] https://hastebin.com/sewununuqo.rb [21:48:21] logs [21:48:29] (03CR) 10Ladsgroup: "PS3 is manual rebase only" [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:48:54] D: https://usercontent.irccloud-cdn.com/file/IxiZqswa/image.png [21:49:49] (03PS1) 10Jdlrobson: Overlays should respect inheritance chain when passing up options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476404 (https://phabricator.wikimedia.org/T210670) [21:50:28] (03CR) 10Jdlrobson: [C: 031] Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:51:04] 10MediaWiki-Database, 10DBA, 10TechCom-RFC: RFC: Proposal to add wl_addedtimestamp attribute to the watchlist table - https://phabricator.wikimedia.org/T209773 (10Joe) Looking at the `watchlist` table, it includes a `wl_id` which at least on mysql is declared as an `int(10) unsigned NOT NULL AUTO_INCREMENT`.... [21:51:20] (03CR) 10Catrope: [C: 032] Add GRAMMAR parser function support for Serbian [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/457543 (https://phabricator.wikimedia.org/T35546) (owner: 10Acamicamacaraca) [21:51:48] takidelfin, sorry for taking a while [21:51:56] Now I should be paying 100% attention to this problem :) [21:52:21] \o/ [21:52:26] looks you touched settings.py before the state it worked and now [21:52:54] Umm, I don't think so [21:53:11] can you try to restart runserver command? [21:53:20] no effects :( [21:53:26] (03CR) 10Nray: [C: 032] Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [21:53:39] Tried a couple of times [21:53:47] (03CR) 10jerkins-bot: [V: 04-1] Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:54:00] hmm [21:54:29] can you post your settings.py somewhere? [21:54:42] (don't forget to redact passwords and other sensitive things if there are some) [21:55:23] (03CR) 10Mooeypoo: [C: 032] "works for me with the new var in core" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476392 (https://phabricator.wikimedia.org/T201719) (owner: 10Dmaza) [21:55:53] (03CR) 10jerkins-bot: [V: 04-1] Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:56:17] (03PS1) 10D3r1ck01: Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) [21:56:50] I regenerated settings and it works now [21:56:50] Weird thing, I did not touch settings.py :/ [21:56:53] @Urbanecm [21:57:11] Maybe something happened when git checkout-ing branches [21:57:15] (03PS6) 10Sbisson: [wip] Welcome survey variation C [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472721 (https://phabricator.wikimedia.org/T207717) [21:57:25] that shouldn't touch settings.py, as it is gitignored, but glad it works now :) [21:57:30] but it is in gitignore :hmm [21:57:34] ah [21:57:40] I'm too slow [21:57:43] :D [21:58:11] (03CR) 10jerkins-bot: [V: 04-1] Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [21:58:13] (03CR) 10Subramanya Sastry: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [21:58:57] (03Abandoned) 10Sharvaniharan: [DO NOT MERGE] Trial patch for offline content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475262 (https://phabricator.wikimedia.org/T157340) (owner: 10Sharvaniharan) [21:59:43] Urbanecm: Could you tell me where Calendar *component* is stored? [21:59:48] in HTML files? [22:00:11] (03CR) 10Sbisson: "You'll have to redo this patch almost from scratch when you rebase but that should be pretty easy since I've extracted all the widgets to " [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474972 (owner: 10Catrope) [22:01:05] It's not written by anyone Tracker developer [22:01:25] https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/views.py#L246 [22:01:45] uh ;-; [22:02:19] okay, it will be more difficult that I expected [22:02:31] 10ContentTranslation: CX2: Matching template names displayed in source language - https://phabricator.wikimedia.org/T210673 (10Etonkovidova) [22:03:48] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:03:54] (03PS4) 10Ladsgroup: Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) [22:03:57] (03PS6) 10Ladsgroup: Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) [22:04:03] Happens sometime :) [22:04:45] 10ContentTranslation, 10WorkType-Maintenance: ContentTranslation should not automatically translate text inside of an auto-adapted template if it does not allow users to change it - https://phabricator.wikimedia.org/T135940 (10Etonkovidova) 05Open>03Resolved a:03Etonkovidova Checked with CX2 version - t... [22:05:27] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10cscott) Yes, true. But we need some way to disambiguate between returning `\xFF` meaning the literal byte 255 and `\u00FF` meaning the UTF-8 byte sequence denoting... [22:06:32] (03CR) 10Arlolra: "> Patch Set 3:" [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [22:08:18] 10MediaWiki-Internationalization, 10Patch-For-Review: Image alignment dropdown options in WikiEditor are not localized correctly in Chechen wikipedia - https://phabricator.wikimedia.org/T196784 (10Umar) >>! In T196784#4783437, @TheDJ wrote: > ping @Umar hi, can you provide your feedback to my change that is li... [22:09:57] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:10:36] (03PS2) 10C. Scott Ananian: Don't silently fail if API result fails to encode [core] - 10https://gerrit.wikimedia.org/r/476170 [22:12:50] (03CR) 10DCausse: [C: 032] Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:15:22] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review+2" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:17:01] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:17:23] (03Merged) 10jenkins-bot: Consistently call restore_error_handler() from finally { } [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476376 (https://phabricator.wikimedia.org/T208146) (owner: 10Catrope) [22:18:48] (03CR) 10Jforrester: [C: 032] Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [22:19:19] (03CR) 10D3r1ck01: "> Patch Set 1: Code-Review-1" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:22:17] 10Timeless, 10Patch-For-Review: Links to sections in an article will land behind unscrollable header - https://phabricator.wikimedia.org/T181484 (10Isarra) 05Open>03Resolved a:03Isarra [22:22:36] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule over-ride [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476348 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [22:23:12] (03PS5) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [22:23:22] (03PS1) 10Dmaza: Add stats for block errors on create/edit actions [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476409 (https://phabricator.wikimedia.org/T201717) [22:23:58] (03CR) 10jenkins-bot: Consistently call restore_error_handler() from finally { } [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476376 (https://phabricator.wikimedia.org/T208146) (owner: 10Catrope) [22:24:03] (03PS1) 10Takidelfin: Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 [22:24:52] Urbanecm: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/476410 [22:24:53] :D [22:25:00] (03CR) 10jerkins-bot: [V: 04-1] Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 (owner: 10Takidelfin) [22:25:49] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule over-ride [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476348 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [22:26:02] (03CR) 10Tpt: [C: 04-1] "Thank you so much for this change!" (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/476399 (https://phabricator.wikimedia.org/T210672) (owner: 10Jayprakash12345) [22:26:17] (03PS2) 10Takidelfin: Calendar: Update UI [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/476410 [22:27:58] takidelfin, in css, you have some trailing whitespace [22:28:02] can you remove it? [22:30:13] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [22:32:23] 10MobileFrontend, 10Readers-Web-Backlog (Design): Menu and notifications drawers should slide over content - https://phabricator.wikimedia.org/T206354 (10Niedzielski) @alexhollender, since we're overhauling the navigation menu for advanced mobile contributions, is there any chance we could reevaluate tweaking... [22:32:48] (03Merged) 10jenkins-bot: SQLite: Split actor and comment filearchive updates to a separate file [core] - 10https://gerrit.wikimedia.org/r/476345 (owner: 10Anomie) [22:32:54] (03Merged) 10jenkins-bot: Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) (owner: 10Anomie) [22:33:00] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476379 (owner: 10Ejegg) [22:33:18] (03PS16) 10Jdlrobson: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:33:20] (03PS4) 10Jdlrobson: Nearby works again locally! [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476384 (https://phabricator.wikimedia.org/T204876) [22:34:34] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10Anomie) IMO the thing to do for the API is probably twofold: 1. Have `ApiResult::validateValue()` refuse strings that are not valid UTF-8. We can detect that by se... [22:34:38] (03PS1) 10SBassett: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 [22:34:43] (03CR) 10Jdlrobson: [C: 032] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:36:55] (03PS9) 10Cooltey: [WIP] Fix: Chinese variants issues that title on the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 [22:37:10] (03CR) 10jerkins-bot: [V: 04-1] Don't silently fail if API result fails to encode [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [22:37:26] (03CR) 10jerkins-bot: [V: 04-1] Don't silently fail if API result fails to encode [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [22:37:57] (03CR) 10jenkins-bot: SQLite: Split actor and comment filearchive updates to a separate file [core] - 10https://gerrit.wikimedia.org/r/476345 (owner: 10Anomie) [22:40:07] (03CR) 10jenkins-bot: Default $wgCommentTableSchemaMigrationStage to MIGRATION_NEW [core] - 10https://gerrit.wikimedia.org/r/472715 (https://phabricator.wikimedia.org/T166733) (owner: 10Anomie) [22:42:50] 10ContentTranslation: CX2: Matching template names displayed in source language - https://phabricator.wikimedia.org/T210673 (10Etonkovidova) [22:43:14] (03CR) 10Anomie: Don't silently fail if API result fails to encode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [22:44:30] (03CR) 10Andrew Bogott: "This isn't crazy, as it would resolve T210643. I'd like to see if Reedy has an idea for moving forward rather than back though." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (owner: 10SBassett) [22:45:33] (03PS2) 10SBassett: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) [22:46:29] (03CR) 10SBassett: "Unf Reedy is still on vacation through next week. Not sure how urgent this is. There's also a conflict with r/475039" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [22:47:11] (03PS1) 10Isarra: Make page logs link actually work for page [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476415 [22:48:23] (03CR) 10jerkins-bot: [V: 04-1] Make page logs link actually work for page [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476415 (owner: 10Isarra) [22:48:29] 10MediaWiki-extensions-Scribunto, 10Wikidata, 10Continuous-Integration-Config: Scribunto test “LuaStandalone: SecurityTests[1]: CVE-2014-5461” failing in Wikibase CI builds - https://phabricator.wikimedia.org/T210634 (10Anomie) Or you could have someone else try it again. [22:50:13] (03PS3) 10SBassett: Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) [22:50:17] (03PS2) 10Isarra: Make page logs link actually work for page [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476415 [22:54:44] (03CR) 10Bartosz Dziewoński: "Right, that sounds reasonable then, I think it is fine as-is. Thanks for the reply!" [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [22:57:39] 04(no projects): Slowish query being triggered by one of our jobs - https://phabricator.wikimedia.org/T210676 (10Eileenmcnaughton) [23:01:25] (03PS4) 10Sharvaniharan: Offline feed content [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/474800 (https://phabricator.wikimedia.org/T157340) [23:06:20] 10SDC Engineering: Ensure AbuseFilter filters can monitor deletion of multilingual file captions - https://phabricator.wikimedia.org/T210677 (10Ramsey-WMF) [23:07:09] 10SDC Engineering: Ensure AbuseFilter filters can monitor deletion of multilingual file captions - https://phabricator.wikimedia.org/T210677 (10Ramsey-WMF) a:03Cparle Assigning to Cormac for now, but not a high priority :) [23:10:29] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476364 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:10:31] (03Merged) 10jenkins-bot: Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 (owner: 10Paladox) [23:10:34] (03Merged) 10jenkins-bot: Simplify APIParseExtender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [23:10:37] (03Merged) 10jenkins-bot: IE: append/detach sort options because show/hide doesn't work [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) (owner: 10Sbisson) [23:10:41] (03Merged) 10jenkins-bot: Add offset for # links to work around fixed header on desktop [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476388 (owner: 10Isarra) [23:10:43] (03Merged) 10jenkins-bot: Add GRAMMAR parser function support for Serbian [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/457543 (https://phabricator.wikimedia.org/T35546) (owner: 10Acamicamacaraca) [23:10:46] (03Merged) 10jenkins-bot: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [23:11:08] (03CR) 10Brian Wolff: [C: 032] Revert "Add some logging of OATHAuth actions" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [23:11:35] (03CR) 10Andrew Bogott: [C: 031] "I take it all back, let's go ahead and revert :)" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [23:11:54] (03CR) 10Brian Wolff: [C: 032] "I think it makes sense to revert for now temporarily until we can fix whats going on." [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/476413 (https://phabricator.wikimedia.org/T210643) (owner: 10SBassett) [23:12:50] (03CR) 10Jdlrobson: [WIP] Convert WelcomeSurvey Popup to require() (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474972 (owner: 10Catrope) [23:13:11] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Patch-For-Review, 10Performance-Team (Radar), and 2 others: MFA: Remove mobile.startup/user - https://phabricator.wikimedia.org/T204866 (10pmiazga) LGTM [23:13:39] 10MediaWiki-Internationalization, 10I18n, 10User-Zoranzoki21: Serbian (sr-ec and sr-el) should support GRAMMAR parser function - https://phabricator.wikimedia.org/T35546 (10Petar.petkovic) [23:13:50] 10MobileFrontend, 10MinervaNeue, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-Jdlrobson: [EPIC] Speed up unit test execution and increase code coverage - https://phabricator.wikimedia.org/T195478 (10pmiazga) [23:13:54] 10MW-1.33-notes (1.33.0-wmf.8; 2018-12-11), 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Performance-Team (Radar), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: MFA: Remove mobile.startup/user - https://phabricator.wikimedia.org/T204866 (10pmiazga)... [23:16:25] (03CR) 10jenkins-bot: Simplify APIParseExtender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [23:17:50] (03CR) 10jenkins-bot: Add slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476389 (owner: 10Paladox) [23:20:38] 04(no projects): Make WDQS auto-completion keyboard shortcut configurable - https://phabricator.wikimedia.org/T210679 (10DarTar) [23:20:50] (03CR) 10jenkins-bot: Revert "Several View's now pass className and isBorderBox as a property" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476397 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [23:24:52] (03CR) 10jenkins-bot: IE: append/detach sort options because show/hide doesn't work [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/475349 (https://phabricator.wikimedia.org/T205669) (owner: 10Sbisson) [23:27:06] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476367 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:08] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476365 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:36] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476354 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:40] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476350 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:44] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/476344 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:46] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Math] - 10https://gerrit.wikimedia.org/r/476339 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:27:52] 10MobileFrontend, 10MinervaNeue, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Jhernandez) I'll try to provide some information as a summary, let me know if it helps: At the end of the project, we shoul... [23:27:55] (03PS1) 10Jdlrobson: Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 [23:27:57] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/476332 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:28:01] (03CR) 10jenkins-bot: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [23:28:03] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476326 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:28:05] (03CR) 10jerkins-bot: [V: 04-1] Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (owner: 10Jdlrobson) [23:28:07] (03CR) 10Esanders: [C: 032] eslint: Drop 'dot-notation' rule [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/476321 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:28:09] (03CR) 10Esanders: [V: 032 C: 032] eslint: Drop 'dot-notation' rule [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476326 (https://phabricator.wikimedia.org/T210552) (owner: 10Jforrester) [23:28:19] (03CR) 10jerkins-bot: [V: 04-1] Fix global variable name typo in InterwikiResolverTest.php [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/476406 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [23:28:52] (03Abandoned) 10Jdlrobson: Overlays should respect inheritance chain when passing up options [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476404 (https://phabricator.wikimedia.org/T210670) (owner: 10Jdlrobson) [23:31:16] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Regression: UI broken in search overlay, image and language overlays - https://phabricator.wikimedia.org/T210670 (10Jdlrobson) p:05Unbreak!>03Normal The regressions were due to some problems in the inheritance chain. I've d... [23:32:03] (03CR) 10jenkins-bot: Change config flag for enabling Block Notice stats [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476392 (https://phabricator.wikimedia.org/T201719) (owner: 10Dmaza) [23:32:11] (03PS1) 10VolkerE: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass [core] - 10https://gerrit.wikimedia.org/r/476425 [23:32:49] (03CR) 10Aaron Schulz: [C: 032] Use ParserCache in CategoryMembershipChangeJob [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) (owner: 10Daniel Kinzler) [23:33:00] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: add tests for Drawer and CtaDrawer - https://phabricator.wikimedia.org/T208920 (10Niedzielski) [23:33:25] (03CR) 10Jack Phoenix: [C: 032] Make page logs link actually work for page [skins/Timeless] - 10https://gerrit.wikimedia.org/r/476415 (owner: 10Isarra) [23:37:33] (03PS1) 10Jdlrobson: Prepare View's for option usage rather than class property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476426 (https://phabricator.wikimedia.org/T210670) [23:38:33] 10Timeless, 10Patch-For-Review: Page logs link brings up logs for page title as actor, not target - https://phabricator.wikimedia.org/T163262 (10Isarra) 05Open>03Resolved a:03Isarra [23:39:38] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] MobileFrontend breaks Special:JavaScriptTest - https://phabricator.wikimedia.org/T210680 (10Niedzielski) [23:39:59] (03PS1) 10Yaron Koren: Add use of Slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476427 [23:40:01] (03PS2) 10Jdlrobson: Revert "Revert "Several View's now pass className and isBorderBox as a property"" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476423 (https://phabricator.wikimedia.org/T210670) [23:41:59] (03PS1) 10Niedzielski: Hygiene: add tests for Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476428 (https://phabricator.wikimedia.org/T208920) [23:42:23] (03PS4) 10Jdlrobson: Officially deprecate isBorderBox and className when not using option [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475148 (https://phabricator.wikimedia.org/T209007) [23:44:01] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) There are 2 patches needed to follow up this: 1) refe... [23:44:14] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) [23:44:23] (03PS2) 10Yaron Koren: Add use of Slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476427 [23:44:27] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) [23:47:05] (03CR) 10Bartosz Dziewoński: build: Upgrade stylelint-config-wikimedia to 0.5.0 and make pass (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476425 (owner: 10VolkerE) [23:47:59] 10MediaWiki-extensions-CentralNotice: [bug] Banners adding themselves to some buckets - https://phabricator.wikimedia.org/T99915 (10jrbs) I'm guessing this is still an issue, but I'm not sure it belongs with #trust-and-safety [23:48:11] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) [23:48:19] 10MobileFrontend (MobileFrontend and MinervaNeue architecture), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Jdlrobson) a:05Jdlrobson>03None [23:49:08] (03CR) 10Yaron Koren: [C: 032] Add use of Slick fonts [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476427 (owner: 10Yaron Koren) [23:50:40] (03PS2) 10Jdlrobson: DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 [23:50:58] (03CR) 10Jdlrobson: "> Do we want to centralize all icon creation in mobile.startup?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [23:51:27] (03CR) 10Jdlrobson: DRYing things up: cancelButton helper (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 (owner: 10Jdlrobson) [23:52:03] (03Merged) 10jenkins-bot: Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [23:52:09] (03Merged) 10jenkins-bot: Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [23:52:55] (03CR) 10Tim Starling: "The Jenkins failure is due to Phan complaining that it doesn't know anything about Excimer." [core] - 10https://gerrit.wikimedia.org/r/476198 (owner: 10Tim Starling) [23:54:33] (03CR) 10jenkins-bot: Drop $wgChangeTagsSchemaMigrationStage [core] - 10https://gerrit.wikimedia.org/r/473629 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [23:56:04] (03CR) 10jenkins-bot: Drop ct_tag column from change_tag table [core] - 10https://gerrit.wikimedia.org/r/473601 (https://phabricator.wikimedia.org/T194163) (owner: 10Ladsgroup) [23:56:53] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] MobileFrontend breaks Special:JavaScriptTest - https://phabricator.wikimedia.org/T210680 (10Jdlrobson) This WFM. Obvious questions: Is core, MobileFrontend and Minerva running master? Can you give more information on the stack trace and what code is triggering t... [23:57:01] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] TBC: MobileFrontend breaks Special:JavaScriptTest - https://phabricator.wikimedia.org/T210680 (10Jdlrobson) [23:59:28] 10Wikimedia-Site-requests: Throttle exemption for event at Wikimedia office on 2018-12-06 - https://phabricator.wikimedia.org/T210681 (10Catrope) [23:59:30] 10Wikimedia-Site-requests: Throttle exemption for event at Wikimedia office on 2018-12-06 - https://phabricator.wikimedia.org/T210681 (10Catrope) a:03Catrope [23:59:48] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Add an in-app notification to be sent to users when they unlock the App Editor Tasks list - https://phabricator.wikimedia.org/T207333 (10Jhernandez) Just FYI, there is some ongoing conversation in an email thread with the engineers about...