[00:00:13] (03PS4) 10D3r1ck01: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 [00:01:15] (03CR) 10Gergő Tisza: [C: 031] Move queries for first/prev/next revision into RevisionStore. (035 comments) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler) [00:01:27] (03PS5) 10D3r1ck01: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 [00:02:37] (03CR) 10Krinkle: "Hm.. why not? These violations could be changed, right?" [core] - 10https://gerrit.wikimedia.org/r/475809 (owner: 10VolkerE) [00:03:02] (03CR) 10Krinkle: [C: 032] Vector menu: Simplify and cleanup LESS structure [skins/Vector] - 10https://gerrit.wikimedia.org/r/435067 (owner: 10VolkerE) [00:04:13] 10MediaWiki-Commenting, 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Doing), 10Epic, and 2 others: Deploy refactored comment storage - https://phabricator.wikimedia.org/T166733 (10greg) [00:04:14] (03CR) 10Catrope: [C: 032] Split ChangeTags::modifyDisplayQuery() to two smaller functions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/473611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [00:04:28] (03Merged) 10jenkins-bot: build: Update eslint-config-wikimedia to 0.9.0 [skins/Vector] - 10https://gerrit.wikimedia.org/r/475916 (owner: 10Esanders) [00:04:31] (03Merged) 10jenkins-bot: build: Update devDependencies [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475915 (owner: 10Esanders) [00:04:49] (03CR) 10VolkerE: Implement `cite` styles (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/419964 (https://phabricator.wikimedia.org/T189754) (owner: 10VolkerE) [00:06:43] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Mobile, and 4 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10ABorbaWMF) Looks good to me on master {F27316525} {F27316528} {F27316530} {F2731653... [00:06:49] (03CR) 10Isarra: "Actually I highly recommend switching to taking over this patch instead, as it... at least sort of works to begin with, frankly. Rebase, a" [skins/Tomas] - 10https://gerrit.wikimedia.org/r/266025 (owner: 10MtDu) [00:06:55] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:07:42] (03CR) 10D3r1ck01: [C: 032] "Wooo, figured it out! Will need to write test for the exception path in sendEmail()." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:08:26] * d3r1ck checks out! [00:10:19] Bye! [00:10:51] 10Patch-For-Review, 10VisualEditor (Current work): Add ability to set a revision tag by passing a URL parameter to the Visual Editor - https://phabricator.wikimedia.org/T209132 (10kaldari) @matmarex - For now, it's fine if this only works in VisualEditor. Thanks for your quick work on this! [00:14:22] (03PS3) 10Isarra: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/266025 (owner: 10MtDu) [00:15:34] 10MediaWiki-User-login-and-signup, 10Security: No way to force a user to change their password if it's invalid - https://phabricator.wikimedia.org/T118774 (10Tgr) >>! In T118774#4690498, @Bawolff wrote: > There was previous discussion somewhere, where people felt it should more be, you need to change your pass... [00:18:12] 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Feature flag the page issues code - https://phabricator.wikimedia.org/T206179 (10ABorbaWMF) Looks good to me on staging |old|new| |{F27316561}|{F27316563}|... [00:19:51] (03CR) 10Isarra: Convert Tomas to use skin registration (031 comment) [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:21:55] (03Merged) 10jenkins-bot: Pass `mode` property to MobileWebMainMenuClickTracking schema [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475922 (https://phabricator.wikimedia.org/T193505) (owner: 10Pmiazga) [00:22:05] (03PS1) 10VolkerE: Remove unused '.mw-ui-checked' class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 [00:25:06] (03PS8) 10Cooltey: Split off SearchFragment into its own Activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/469811 (https://phabricator.wikimedia.org/T166151) [00:25:14] (03PS2) 10Cooltey: Fix: set thumbnail URL to the PageTitle in TabList to prevent empty thumbnail [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472599 [00:25:29] 10Audiences-QA, 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, and 2 others: [Research 4hrs] [Bug] Page issues link overlapping in multiple languages for larger screens - https://phabricator.wikimedia.org/T206887 (10ABorbaWMF) @ovasileva This one is still occurring f... [00:25:43] (03CR) 10Krinkle: [C: 031] "LGTM, per Thiemo's reasoning. I agree though we shouldn't land it until we confirmed the depending patch such as https://gerrit.wikimedia." [core] - 10https://gerrit.wikimedia.org/r/472202 (https://phabricator.wikimedia.org/T206728) (owner: 10D3r1ck01) [00:26:05] (03CR) 10VolkerE: [C: 04-2] "Sure, but I personally find a change in for example radio.less less readable." [core] - 10https://gerrit.wikimedia.org/r/475809 (owner: 10VolkerE) [00:27:36] (03Merged) 10jenkins-bot: rdbms: rename setDomainPrefix to setLocalDomainPrefix in ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/475017 (owner: 10Aaron Schulz) [00:27:38] (03Merged) 10jenkins-bot: Vector menu: Simplify and cleanup LESS structure [skins/Vector] - 10https://gerrit.wikimedia.org/r/435067 (owner: 10VolkerE) [00:27:48] (03CR) 10jenkins-bot: Pass `mode` property to MobileWebMainMenuClickTracking schema [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475922 (https://phabricator.wikimedia.org/T193505) (owner: 10Pmiazga) [00:28:12] (03PS5) 10Zoranzoki21: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) [00:28:18] (03CR) 10jerkins-bot: [V: 04-1] Remove unused '.mw-ui-checked' class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 (owner: 10VolkerE) [00:30:29] (03CR) 10jenkins-bot: rdbms: rename setDomainPrefix to setLocalDomainPrefix in ILoadBalancer [core] - 10https://gerrit.wikimedia.org/r/475017 (owner: 10Aaron Schulz) [00:31:01] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, and 2 others: [Bug] Control clicking image doesn't open in new tab - https://phabricator.wikimedia.org/T206348 (10ABorbaWMF) Seems to be working on Beta for both desktop and mobile {F27316613} [00:31:15] (03CR) 10jerkins-bot: [V: 04-1] Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:31:25] (03Abandoned) 10Isarra: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/266025 (owner: 10MtDu) [00:31:27] (03CR) 10Brian Wolff: [C: 032] Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) (owner: 10Mogmog123) [00:33:15] (03Merged) 10jenkins-bot: Split ChangeTags::modifyDisplayQuery() to two smaller functions [core] - 10https://gerrit.wikimedia.org/r/473611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [00:33:20] (03Merged) 10jenkins-bot: Migrate ApiQueryLogEvents from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/473617 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [00:33:22] (03Merged) 10jenkins-bot: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:34:38] (03CR) 10Daniel Kinzler: "> The links update would probably better be left post-send instead of going all the way to the job queue." [core] - 10https://gerrit.wikimedia.org/r/470099 (owner: 10Aaron Schulz) [00:35:42] (03CR) 10jenkins-bot: Migrate ApiQueryLogEvents from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/473617 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [00:35:53] (03CR) 10jenkins-bot: Add more coverage for SGHooks methods [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/475914 (owner: 10D3r1ck01) [00:37:14] (03CR) 10jenkins-bot: Split ChangeTags::modifyDisplayQuery() to two smaller functions [core] - 10https://gerrit.wikimedia.org/r/473611 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [00:39:41] (03Merged) 10jenkins-bot: Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) (owner: 10Mogmog123) [00:40:04] (03PS6) 10Isarra: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:40:37] 10Direct content and outreach support for CE teams, 10CommRel-Specialists-Support (Oct-Dec-2018): Education portal redesign - https://phabricator.wikimedia.org/T207111 (10mcruzWMF) [00:41:53] (03PS7) 10Isarra: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:47:13] (03CR) 10Bartosz Dziewoński: [C: 032] build: Update devDependencies [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/475918 (owner: 10Esanders) [00:48:26] (03PS2) 10VolkerE: Remove unused '.mw-ui-checked' class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 [00:48:40] (03CR) 10Bartosz Dziewoński: [C: 04-1] Remove unused '.mw-ui-checked' class (031 comment) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 (owner: 10VolkerE) [00:49:04] (03CR) 10Bartosz Dziewoński: [C: 032] Remove unused '.mw-ui-checked' class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 (owner: 10VolkerE) [00:49:20] (03CR) 10Isarra: [C: 032] Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:51:43] (03CR) 10jenkins-bot: Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) (owner: 10Mogmog123) [00:55:30] 10Discovery-Search (Current work), 10Patch-For-Review: Build pipeline to transform elastic explains into feature vectors and a tf graph - https://phabricator.wikimedia.org/T208917 (10EBernhardson) There wasn't really a perfect ticket for this report, but the analysis of this first tuning run on item search in... [00:58:34] (03Merged) 10jenkins-bot: build: Update devDependencies [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/475918 (owner: 10Esanders) [00:58:36] (03Merged) 10jenkins-bot: Remove unused '.mw-ui-checked' class [skins/Timeless] - 10https://gerrit.wikimedia.org/r/475926 (owner: 10VolkerE) [00:58:38] (03Merged) 10jenkins-bot: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [00:59:29] (03CR) 10Jdlrobson: "ready for review!" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [00:59:46] (03CR) 10VolkerE: "I think the default should be 20px and the 24px should be moved to MinervaNeue. We also define 20px in OOUI and Vector consumes pretty muc" [core] - 10https://gerrit.wikimedia.org/r/425743 (https://phabricator.wikimedia.org/T191021) (owner: 10VolkerE) [01:00:08] (03CR) 10Aaron Schulz: Use ParserCache in CategoryMembershipChangeJob (031 comment) [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) (owner: 10Daniel Kinzler) [01:00:44] (03CR) 10jenkins-bot: build: Update devDependencies [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/475918 (owner: 10Esanders) [01:03:05] (03CR) 10Catrope: [C: 04-1] WIP: Add help button and pane (0325 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [01:04:05] (03PS1) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [01:04:26] (03PS3) 10Catrope: [WIP] Convert WelcomeSurvey Popup to require() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474972 [01:04:58] (03PS1) 10Pmiazga: Add reusable getEditCountBucket method [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/475931 (https://phabricator.wikimedia.org/T210106) [01:05:28] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10StructuredDiscussions, and 2 others: Fix `.mw-ui-icon` with overhauled icon canvas sizes - https://phabricator.wikimedia.org/T191021 (10Volker_E) @Jdlrobson The default should be 20px and the 24px should be moved to MinervaNeue. We als... [01:07:41] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10StructuredDiscussions, and 2 others: Fix `.mw-ui-icon` with overhauled icon canvas sizes - https://phabricator.wikimedia.org/T191021 (10Volker_E) We could probably also first iterate by adding code to all of the extensions, 20px for -... [01:08:34] (03CR) 10jerkins-bot: [V: 04-1] Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) (owner: 10Melos) [01:08:43] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert WelcomeSurvey Popup to require() [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474972 (owner: 10Catrope) [01:19:08] 10ContentTranslation: CX2: May corrupt work started with CX1, duplicate reference list and staggered paragraphs - https://phabricator.wikimedia.org/T207631 (10Etonkovidova) 05Open>03declined I checked the issue in testwiki (wmf.4) to rule out possible regression or specific issues related to `en-zh` `Metrica... [01:19:22] (03PS2) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [01:21:14] 10MediaWiki-Interface: Create standard method for registering and displaying skin preferences - https://phabricator.wikimedia.org/T210009 (10Isarra) Should this be an RfC, or should I just implement something and declare it the standard? [01:23:49] (03CR) 10Catrope: "Some open questions that I wrote down last week but forgot to put in here:" [core] - 10https://gerrit.wikimedia.org/r/471370 (https://phabricator.wikimedia.org/T133462) (owner: 10Catrope) [01:23:51] 10MediaWiki-General-or-Unknown, 10TechCom, 10Patch-For-Review, 10Technical-Debt, 10User-Daniel: Hooks system should support MediaWiki services - https://phabricator.wikimedia.org/T171515 (10pmiazga) @Krinkle I'm happy to help with this task, I still keep the https://gerrit.wikimedia.org/r/#/c/mediawiki/c... [01:24:51] (03CR) 10jerkins-bot: [V: 04-1] Add reusable getEditCountBucket method [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/475931 (https://phabricator.wikimedia.org/T210106) (owner: 10Pmiazga) [01:26:01] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10StructuredDiscussions, and 2 others: Fix `.mw-ui-icon` with overhauled icon canvas sizes - https://phabricator.wikimedia.org/T191021 (10Volker_E) PagePreviews should work with the smaller canvas when icon are updated too: {F27316780} [01:28:15] 10ContentTranslation: [wmf.23] scribunto-error for template Infobox Settlement - https://phabricator.wikimedia.org/T205766 (10Etonkovidova) 05Open>03Resolved a:03Etonkovidova @Pginer-WMF - you're right. I re-checked in wmf.4 - the warning to a user about a unavailable template is in place. Closing the task... [01:36:55] 04(no projects): Creation of "Work" namespace in Bengali Wikisource - https://phabricator.wikimedia.org/T210472 (10Hrishikes) [01:39:10] (03CR) 10Isarra: "Yeah, the lowercase is clearly an intentional design decision for the skin itself. I would highly recommend getting buy-in from MonoBook u" [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/462272 (owner: 10Gopavasanth) [01:40:15] (03CR) 10Kosta Harlan: WIP: Add help button and pane (037 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [01:45:44] 10Wikimedia-Site-requests: Creation of "Work" namespace in Bengali Wikisource - https://phabricator.wikimedia.org/T210472 (10Bodhisattwa) [01:45:59] (03PS1) 10Kosta Harlan: Add .eslintrc.json [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 [01:46:05] 10Wikimedia-Site-requests, 10Bengali-Sites: Creation of "Work" namespace in Bengali Wikisource - https://phabricator.wikimedia.org/T210472 (10Bodhisattwa) [01:47:02] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Isarra) [01:52:52] (03CR) 10Pmiazga: Add PHPUnit tests for testing methods in ContentProviderFactory::class (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [01:53:52] (03CR) 10Pmiazga: [C: 032] Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [01:54:14] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10pmiazga) [01:59:32] (03PS7) 10Cooltey: [WIP] Fix: Chinese variants issues that title on the lists does not match the article itself [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472751 [02:06:11] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10StructuredDiscussions, and 2 others: Fix `.mw-ui-icon` with overhauled icon canvas sizes - https://phabricator.wikimedia.org/T191021 (10Volker_E) MultimediaViewer features very few `.mw-ui-icon`s, they are already 20x20px icons, like `.... [02:07:39] 10Excimer, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing): Excimer: Expose event_count in ExcimerLogEntry - https://phabricator.wikimedia.org/T207497 (10CCicalese_WMF) [02:08:07] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Majora) Why was this done globally instead of just to enwiki as requested? No other project requested this as far as I'm aware. [02:08:19] 10Core Platform Team Kanban, 10Excimer, 10Core Platform Team (PHP7 (TEC4)): ExcimerProfiler::start(), ExcimerTimer::start(), and so on should warn if starting fails - https://phabricator.wikimedia.org/T207498 (10CCicalese_WMF) p:05Triage>03Low [02:09:29] 10Excimer, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing): Excimer: Expose event_count in ExcimerLogEntry - https://phabricator.wikimedia.org/T207497 (10CCicalese_WMF) a:03tstarling [02:13:06] 10MediaWiki-Internationalization, 10Core Platform Team (PHP7 (TEC4)), 10Core Platform Team Kanban (Doing), 10PHP 7.3 support, 10Patch-For-Review: LanguageTrTest::testDottedAndDotlessI fails in PHP 7.3 - https://phabricator.wikimedia.org/T207100 (10CCicalese_WMF) a:03Legoktm [02:16:07] (03CR) 10Kosta Harlan: WIP: Add help button and pane (0319 comments) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) (owner: 10Kosta Harlan) [02:16:38] (03PS19) 10Kosta Harlan: WIP: Add help button and pane [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/474310 (https://phabricator.wikimedia.org/T206717) [02:26:57] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Aklapper I have got the font from Adobe Illustrator CC 2019 font list [02:30:41] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Aklapper Did I make any mistake? As you said siyam's fault......Is there any fault that I have... [02:35:05] (03CR) 10BPirkle: "recheck" [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/474808 (https://phabricator.wikimedia.org/T206291) (owner: 10BPirkle) [02:38:38] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Ebe123) > that's not siyam's fault It's *not* your fault. [02:46:39] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Risker) I'm inclined to agree with Majora on this point. I see good reason to move ahead with this change on enwiki; there is a pretty clear... [02:54:03] 10Contributors-Analysis, 10Product-Analytics: Calculate monthly mobile Wikipedia edits for Major Gifts report - https://phabricator.wikimedia.org/T209889 (10Neil_P._Quinn_WMF) 05Open>03Resolved @JCuriel, this is done. The results are in the table below; let me know if you notice any issues. For future ref... [03:01:39] 10Contributors-Analysis, 10Product-Analytics: wmfdata package can be installed but not imported - https://phabricator.wikimedia.org/T202594 (10Tbayer) 05Resolved>03Open Import still fails for me, but with a new error message: ` In [1]: !pip install git+https://github.com/neilpquinn/wmfdata.git [...] Succ... [03:04:20] (03CR) 10jenkins-bot: Fix failing phpunit tests on PHP 7.1+ [extensions/MultiMaps] - 10https://gerrit.wikimedia.org/r/474808 (https://phabricator.wikimedia.org/T206291) (owner: 10BPirkle) [03:31:05] 10Contributors-Analysis, 10Product-Analytics: wmfdata package can be installed but not imported - https://phabricator.wikimedia.org/T202594 (10Tbayer) Testing again after Neil's [[https://github.com/neilpquinn/wmfdata/commit/97caf8c4e2cb42ed12d37a724c839ffa29a6560a#diff-2eeaed663bd0d25b7e608891384b7298|update]... [04:00:27] (03PS2) 10Samwilson: Use custom overlay for help popups [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) [04:01:34] (03CR) 10Samwilson: Use custom overlay for help popups (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/471911 (https://phabricator.wikimedia.org/T203559) (owner: 10Samwilson) [04:09:17] (03PS2) 10VolkerE: Use `opacity` for a WikimediaUI aligned transition on opening menu [skins/Vector] - 10https://gerrit.wikimedia.org/r/475802 [04:10:57] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10MusikAnimal) I'll note the relevant recent vandalism has occurred on wikis other than just enwiki. It stands to reason the account compromise... [04:12:37] (03PS1) 10Sharvaniharan: Create custom dialog with image [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475946 (https://phabricator.wikimedia.org/T209511) [04:16:50] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10Sharvaniharan) @cmadeo @schoenbaechler Image for the dialog is not provided in the Zeplin mocks. Few more questions: --Wit... [04:17:31] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10Majora) >>! In T150826#4776565, @MusikAnimal wrote: > I'll note the relevant recent vandalism has occurred on wikis other than just enwiki. I... [04:17:43] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10Sharvaniharan) Screenshot as of now https://drive.google.com/open?id=1tg5NtJWY8G4xYI0icO5ZrG_JL8VbeAwS [04:21:02] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10AfroThundr3007730) I agree with Majora and Risker that this should be communicated to all the projects affected (enwiki is already aware, of... [04:21:13] 10Design, 10UI-Standardization, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10UI-Standardization-Kanban: Update fontstack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877 (10Volker_E) @Krinkle shared on the patch discussion: > I haven't found any issue with this... [04:24:52] 10Design, 10UI-Standardization, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10UI-Standardization-Kanban: Update fontstack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877 (10Volker_E) [04:24:57] (03PS2) 10Ejegg: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/475892 [04:25:14] (03CR) 10Ejegg: [V: 032 C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/475892 (owner: 10Ejegg) [04:26:52] 10Design, 10UI-Standardization, 10Patch-For-Review, 10Readers-Web-Backlog (Design), 10UI-Standardization-Kanban: Update fontstack on mobile web to use system typefaces - https://phabricator.wikimedia.org/T175877 (10Volker_E) [04:28:08] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/475892 (owner: 10Ejegg) [04:29:58] (03PS2) 10VolkerE: Add `font-family-system-sans` font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) [04:30:49] 10Wikimedia-Site-requests: Change Minang Wikipedia logo - https://phabricator.wikimedia.org/T210387 (10SpartacksCompatriot) The new ones would do fine. [04:31:08] (03CR) 10VolkerE: "It's not worth risking to repeat issues of others with our global audience. Removed `system-ui` in PS 2." [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [04:32:57] (03PS4) 10VolkerE: Combine input and search button on intriniscally tied together widget [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/460185 (https://phabricator.wikimedia.org/T197195) [04:34:04] 10UI-Standardization, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Readers-Web-Backlog (Tracking), 10UI-Standardization-Kanban: Remove deprecated color values from mediawiki.ui variables - https://phabricator.wikimedia.org/T210118 (10Volker_E) 05Open>03Resolved p:05Triage>03Normal [04:34:33] 10Design, 10UI-Standardization, 10Advanced-Search, 10Discovery, and 5 others: Combine inputs and buttons that are intrinsically tied together (ex: ActionFieldLayout) - https://phabricator.wikimedia.org/T195973 (10Volker_E) p:05High>03Triage [04:34:59] 10UI-Standardization, 10MinervaNeue, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), and 4 others: Highlight does not cover the menu option entirely in the toolbar on Mobile VE - https://phabricator.wikimedia.org/T190596 (10Volker_E) [04:35:19] 10UI-Standardization, 10MinervaNeue, 10Editing Q1 2018-19 mobile improvements, 10MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), and 4 others: Highlight does not cover the menu option entirely in the toolbar on Mobile VE - https://phabricator.wikimedia.org/T190596 (10Volker_E) p:05Normal>03Triage [04:35:28] 10UI-Standardization, 10ContentTranslation, 10Patch-For-Review, 10UI-Standardization-Kanban: Use 14px font size in ContentTranslation - https://phabricator.wikimedia.org/T191432 (10Volker_E) p:05Normal>03Triage [04:35:46] 10UI-Standardization, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps), and 2 others: Button with "oo-ui-icon-fullScreen" icon has extra space - https://phabricator.wikimedia.org/T192852 (10Volker_E) p:05Normal>03Triage [04:35:55] 10UI-Standardization, 10Discovery, 10Maps, 10Collaboration-Feature-Rollouts (Collaboration-Maps), and 2 others: Button with "oo-ui-icon-fullScreen" icon has extra space - https://phabricator.wikimedia.org/T192852 (10Volker_E) [04:36:15] 10UI-Standardization, 10OOUI (OOUI-0.26.5), 10UI-Standardization-Kanban: De-emphasize toolbar tool group borders - https://phabricator.wikimedia.org/T191266 (10Volker_E) p:05Normal>03Triage [04:37:06] 10Design, 10UI-Standardization, 10Revision-Slider, 10TCB-Team, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Volker_E) [04:37:21] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Patch-For-Review: Remove unblockself right on wikimedia wikis - https://phabricator.wikimedia.org/T150826 (10MusikAnimal) >>! In T150826#4776573, @Majora wrote: >>>! In T150826#4776565, @MusikAnimal wrote: >> I'll note the relevant recent vandalism h... [04:38:33] 10UI-Standardization, 10OOUI (OOUI-0.27.5), 10UI-Standardization-Kanban: Apex theme: Make faux 3D widget gradient more subtle, less gimmicky - https://phabricator.wikimedia.org/T198710 (10Volker_E) p:05Normal>03Triage [04:38:49] 10UI-Standardization, 10WikiEditor, 10MW-1.32-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10UI-Standardization-Kanban: WikiEditor 2010 should use standard 'reference' icon instead of 'book' - https://phabricator.wikimedia.org/T202463 (10Volker_E) p:05Normal>03Triage [04:39:06] 10UI-Standardization, 10OOUI (OOUI-0.27.5), 10Technical-Debt, 10UI-Standardization-Kanban: WikimediaUI theme: Remove & replace complex cubic bezier transition option - https://phabricator.wikimedia.org/T198393 (10Volker_E) p:05Normal>03Triage [04:39:15] 10MediaWiki-HTMLForm, 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10UI-Standardization-Kanban: CheckboxMatrix: distinguish alternating items in table more clearly - https://phabricator.wikimedia.org/T194536 (10Volker_E) p:05Normal>03Triage [04:40:03] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Notifications, 10Growth-Team (Current Sprint), 10UI-Standardization-Kanban: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837 (10Volker_E) p:05Normal>03Triage [04:40:41] 10UI-Standardization, 10OOUI, 10Security, 10UI-Standardization-Kanban: Size disparity in caret indicators - https://phabricator.wikimedia.org/T184313 (10Volker_E) p:05Lowest>03Triage [04:40:55] 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601 (10Volker_E) p:05Lowest>03Triage [04:42:08] 10Design, 10UI-Standardization, 10CSS, 10OOUI (OOUI-0.27.5), 10UI-Standardization-Kanban: WikimediaUI theme: Apply `ease-out` to human initiated dialog opening transition - https://phabricator.wikimedia.org/T198397 (10Volker_E) p:05Normal>03Triage [04:45:27] 10UI-Standardization, 10Growth-Team, 10Notifications, 10UI-Standardization-Kanban: Report on “cut off” notification badges after icon update - https://phabricator.wikimedia.org/T191481 (10Volker_E) 05Open>03Invalid As this hasn't seen any other inputs or user voices, putting it on “invalid” as it shoul... [04:51:04] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Window dressing is mostly olive oil, 10I18n: Right 'banner-protect' is missing i18n descriptions - https://phabricator.wikimedia.org/T209763 (10Ejegg) Since banner-protect is defined in wmf-settings (rOMWC7d084e54705) and not... [05:16:38] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Window dressing is mostly olive oil, 10I18n: Right 'banner-protect' is missing i18n descriptions - https://phabricator.wikimedia.org/T209763 (10Legoktm) If it's a Wikimedia-specific thing, then the messages should go in the W... [05:22:17] (03PS2) 10Daniel Kinzler: Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) [05:26:53] 10MediaWiki-User-management, 10Anti-Harassment, 10wikitech.wikimedia.org, 10Security, 10Wikimedia-production-error: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist - https://phabricator.wikimedia.org/T209674 (10dbarratt) [05:27:14] 10MediaWiki-User-management, 10Anti-Harassment, 10wikitech.wikimedia.org, 10Security, 10Wikimedia-production-error: Fatal: Cannot block user at wikitech: Table 'labswiki.ipblocks_restrictions' doesn't exist - https://phabricator.wikimedia.org/T209674 (10dbarratt) >>! In T209674#4766069, @chasemp wrote: >... [05:27:19] :( [05:34:13] (03CR) 10Samwilson: "recheck" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/454479 (https://phabricator.wikimedia.org/T199580) (owner: 10Samwilson) [05:35:13] (03CR) 10jerkins-bot: [V: 04-1] Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [05:35:58] 10UI-Standardization, 10Wikimedia Design Style Guide: Typography: Define a font stack for monospace fonts - https://phabricator.wikimedia.org/T209915 (10Volker_E) [05:36:12] (03PS1) 10Daniel Kinzler: WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 [05:42:39] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: Add tests for NamespaceRestriction enforcement - https://phabricator.wikimedia.org/T204988 (10dbarratt) [05:48:23] Hello [05:49:18] hello rachit! [05:49:18] urbanecm are you there? [05:49:25] hello takidelfin [05:49:29] He is away [05:49:39] i require a little help [05:49:43] yea? [05:49:53] can you check my code and tell if its fine? [05:50:03] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech [05:50:03] I will try :D [05:50:12] https://en.wikipedia.org/wiki/User:RexxS/GCI-Task06 step 3 [05:52:36] (03PS1) 10VolkerE: Add monospace font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/475949 (https://phabricator.wikimedia.org/T209915) [05:53:14] rachit: I think that it loooks good [05:53:18] (03CR) 10jerkins-bot: [V: 04-1] Add monospace font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/475949 (https://phabricator.wikimedia.org/T209915) (owner: 10VolkerE) [05:53:42] (03PS6) 10Dbarratt: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) [05:53:47] takidelfin okay :D [05:53:53] (03PS2) 10Dbarratt: Ensure that namespace blocking is enforced. [core] - 10https://gerrit.wikimedia.org/r/475786 (https://phabricator.wikimedia.org/T204988) [05:53:54] 10Anti-Harassment: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dmaza) [05:54:07] (03PS4) 10Dbarratt: Add tests to ensure that NamespaceRestrictions are returned from Block APIs. [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) [05:54:23] (03PS5) 10Dbarratt: Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) [05:54:39] but maybe you should add 'or 'en'' as a fallback for fallbacks :D When argument is nil . So you could do this like this: local langcode = frame.args.langcode or 'en' [05:55:58] 10Anti-Harassment (AHT Sprint 34): User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dmaza) [05:56:30] (03CR) 10jerkins-bot: [V: 04-1] WIP simplify prepareUpdate logic. [core] - 10https://gerrit.wikimedia.org/r/475948 (owner: 10Daniel Kinzler) [05:57:42] (03CR) 10LukBukkit: "Sorry for the spam, but I didn't know how to run QUnit and Karma together on my local machine." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475831 (https://phabricator.wikimedia.org/T188451) (owner: 10LukBukkit) [06:01:09] 10Anti-Harassment (AHT Sprint 34): User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) [06:01:47] 10Anti-Harassment (AHT Sprint 34): User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) [06:08:49] (03CR) 10jerkins-bot: [V: 04-1] Ensure that namespace blocking is enforced. [core] - 10https://gerrit.wikimedia.org/r/475786 (https://phabricator.wikimedia.org/T204988) (owner: 10Dbarratt) [06:15:03] (03CR) 10jerkins-bot: [V: 04-1] Ensure that namespace blocking is enforced. [core] - 10https://gerrit.wikimedia.org/r/475786 (https://phabricator.wikimedia.org/T204988) (owner: 10Dbarratt) [06:26:45] 10MediaWiki-Logging, 10MediaWiki-User-management: Unblock log entry should contain the log ID of the block being undone - https://phabricator.wikimedia.org/T210476 (10Tgr) [06:27:24] (03Abandoned) 10Dbarratt: Ensure that namespace blocking is enforced. [core] - 10https://gerrit.wikimedia.org/r/475786 (https://phabricator.wikimedia.org/T204988) (owner: 10Dbarratt) [06:27:54] 10Anti-Harassment (AHT Sprint 34): User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) a:03dbarratt [06:28:21] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: Add tests for NamespaceRestriction enforcement - https://phabricator.wikimedia.org/T204988 (10dbarratt) a:05dbarratt>03None [06:42:56] hello everyone [06:46:20] (03PS1) 10Dbarratt: Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) [06:55:24] hi rachit [06:55:54] hi! [06:55:56] sup [06:58:53] 10Growth-Team, 10StructuredDiscussions, 10Technical-Debt: Store (including Parsoid version number) for HTML Flow content - https://phabricator.wikimedia.org/T209114 (10Catrope) [06:59:11] hi shreyasminocha ! [06:59:14] 10Lingua Libre: RecordWizard does not work well the user interface in Occitan - https://phabricator.wikimedia.org/T210477 (10Pamputt) [06:59:38] Google pushed another patch (3137 - mispelled 1337) to the gci website as hotfix :D [07:01:02] 10Lingua Libre: RecordWizard does not work well the user interface in Occitan - https://phabricator.wikimedia.org/T210477 (10Pamputt) [07:07:22] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10siyam-_-) @Ebe123 but what fault? [07:11:10] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Wwdjbox) {F27317397} [07:11:49] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Growth-Team: FlaggedRevs: code stewardship review - https://phabricator.wikimedia.org/T185664 (10Catrope) I'm not really excited about the Growth team being put on the hook to maintain yet another unloved extension. Of all the patches merged i... [07:13:36] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Tracking: Lua in Wikibase (tracking) - https://phabricator.wikimedia.org/T112073 (10Rical) [07:13:39] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata, 10Need-volunteer: Create the easy function mw.wikibase.property('P21', 'Q8023', 'en') - https://phabricator.wikimedia.org/T185557 (10Rical) 05Open>03Resolved a:03Rical The status of this function is enough advance in Central modules t... [07:18:07] 10VisualEditor (Current work): [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10matmarex) a:03matmarex [07:21:37] takidelfin: hi [07:21:46] rachit: nm. have a free class rn [07:21:56] (oops, too late) [07:26:31] 10MediaWiki-Recent-changes, 10Growth-Team: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10Catrope) [07:26:37] 10MediaWiki-Recent-changes, 10Growth-Team: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10Catrope) [07:31:09] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) @TBolliger This change basically means that specifying `User_talk:Apples` or checking `Prevent this user from... [07:40:54] 10VisualEditor (Current work): [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10matmarex) [07:41:51] 10VisualEditor (Current work): [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10matmarex) [07:42:07] 10VisualEditor (Current work): [Regression] Blockquotes can't be edited, because they're alienated content - https://phabricator.wikimedia.org/T209162 (10matmarex) [07:49:36] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10JJMC89) >>! In T210475#4776769, @dbarratt wrote: > This change basically means that specifying `User_talk:Apples` or ch... [07:59:04] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Confirmation dialog when publishing with pending issues - https://phabricator.wikimedia.org/T190036 (10Petar.petkovic) a:03Petar.petkovic [07:59:14] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Unexpected automatic review of translations in page mode - https://phabricator.wikimedia.org/T206748 (10Nikerabbit) [08:04:58] 10ContentTranslation: CX2: Allow easy selection of displayed adapted link text - machine translation or target title - https://phabricator.wikimedia.org/T210308 (10Amire80) >>! In T210308#4773806, @Pginer-WMF wrote: > This may be the same issue described in {T197662} Indeed, the solution proposed there is good.... [08:05:21] 10ContentTranslation: CX2: Allow easy selection of displayed adapted link text - machine translation or target title - https://phabricator.wikimedia.org/T210308 (10Amire80) [08:05:24] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Quickly switch between alternative link label translations - https://phabricator.wikimedia.org/T197662 (10Amire80) [08:06:39] 10ContentTranslation: CX2: "Mark as missing" creates a misleading target title - https://phabricator.wikimedia.org/T210397 (10Amire80) >>! In T210397#4773800, @Pginer-WMF wrote: > This may be the same issue described in {T197787} It's indeed similar enough. I'll close this one as duplicate and comment there. Th... [08:08:17] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Apply the right target when creating a missing link - https://phabricator.wikimedia.org/T197787 (10Amire80) [08:08:19] 10ContentTranslation: CX2: "Mark as missing" creates a misleading target title - https://phabricator.wikimedia.org/T210397 (10Amire80) [08:25:12] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Communicate session has expired on translation view - https://phabricator.wikimedia.org/T192066 (10Petar.petkovic) [08:34:35] 10CX-analytics, 10Language-Team (Language-2018-October-December): Extend CX2 translations graph to show also published translations that need review - https://phabricator.wikimedia.org/T209868 (10Pginer-WMF) a:03Amire80 [08:35:21] 10CX-analytics, 10Language-Team (Language-2018-October-December): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Pginer-WMF) a:03Amire80 [08:35:23] 10CX-analytics, 10Language-Team (Language-2018-October-December): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Pginer-WMF) a:05Amire80>03None [08:35:39] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Pginer-WMF) a:03Amire80 [08:35:46] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Korean Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210386 (10Pginer-WMF) a:03Amire80 [08:36:00] 10CX-analytics, 10Language-Team (Language-2018-October-December): Extend CX2 translations graph to show also deleted translations - https://phabricator.wikimedia.org/T210138 (10Pginer-WMF) a:03Amire80 [08:36:36] 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10matmarex) [08:37:09] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): PHP warnings in maintenance/groupStatistics.php - https://phabricator.wikimedia.org/T208481 (10Pginer-WMF) 05Open>03Resolved [08:37:26] 10MediaWiki-General-or-Unknown, 10Availability (MediaWiki-MultiDC), 10Patch-For-Review: Fix problematic database master queries performed on HTTP GET/HEAD - https://phabricator.wikimedia.org/T92357 (10Pginer-WMF) [08:37:30] 10MediaWiki-extensions-Translate, 10Availability, 10Language-Team (Language-2018-October-December): MessageGroupStats::queueUpdates trigger on page views - https://phabricator.wikimedia.org/T134841 (10Pginer-WMF) 05Open>03Resolved [08:37:40] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Regression, 10Wikimedia-production-error: PHP fatal error: Argument 1 passed to MessageGroups::isDynamic() must implement interface M... - https://phabricator.wikimedia.org/T209141 [09:07:32] 10Wikimedia-Portals: www.wikipedia.org says 0+ articles for all languages - https://phabricator.wikimedia.org/T210401 (10Jdrewniak) [09:10:08] (03PS1) 10Sharvaniharan: [WIP] Add edit tasks menu option [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475970 (https://phabricator.wikimedia.org/T209499) [09:12:36] refeed: hello [09:12:47] shreyasminocha, hello [09:14:32] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): As a user of the Android app I would like to know where to navigate to to use the App Editor Tasks list - https://phabricator.wikimedia.org/T209499 (10Sharvaniharan) a:03Sharvaniharan [09:16:21] 10FormWizard, 10FormWizard-Gadget: mw.notify needs to be i18n-ized - https://phabricator.wikimedia.org/T204659 (10Eugene233) a:03Eugene233 [09:17:09] 10FormWizard, 10FormWizard-Gadget: mw.notify needs to be i18n-ized - https://phabricator.wikimedia.org/T204659 (10Eugene233) [09:19:17] how to upload a patch in gerrit????is there any tutorial video??? [09:19:58] Siyam: https://www.mediawiki.org/wiki/Gerrit/Tutorial/tl;dr [09:20:22] i saw that but could not understand!!! [09:20:35] Siyam, what part that you don't understand? [09:20:46] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Support for references added by name when the details are inside a template - https://phabricator.wikimedia.org/T209266 (10Pginer-WMF) >>! In T209266#4759138, @Doc_James wrote: > So does this mean that this problem is not easily fixab... [09:21:06] (03CR) 10DCausse: [C: 032] Fix a few sonar warnings: [search/extra] - 10https://gerrit.wikimedia.org/r/475776 (owner: 10Gehel) [09:21:42] i didnt understand how to upload a patch in gerrit....i have installed git in my pc but i cant upload a patch to fulfill my GCI task [09:22:09] Siyam: hmm okay, have you ever used git before this? [09:22:24] no..never...i am new [09:23:16] Siyam, okay, so you will need to learn how to create a commit in git first [09:23:27] Siyam: what OS are you using if you don't mind? [09:24:32] i am on windows and i have learned to write commit...from the video given n the tutorial but i have no idea how to submit that commit in wikimwdia [09:25:37] Siyam, that's good. Have you installed `git-review` in your computer? (https://www.mediawiki.org/wiki/Gerrit/git-review#Windows) [09:25:59] no...do i have to installed it??? [09:26:34] (03CR) 10Daimona Eaytoy: "> > I don't have the time to run a check against all extensions to" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/464179 (owner: 10Daimona Eaytoy) [09:26:46] Siyam, yup you need to install it in order to upload your patch to gerrit [09:27:02] but how to install this [09:27:43] (03Merged) 10jenkins-bot: Fix a few sonar warnings: [search/extra] - 10https://gerrit.wikimedia.org/r/475776 (owner: 10Gehel) [09:27:51] i have installed git bash [09:28:07] Siyam, it's similar to how you install a python package everyday since it's a Python package. I recommend you to take a look on https://www.mediawiki.org/wiki/Gerrit/git-review#Windows [09:28:15] so with one command i can install git review...right??? [09:29:22] yup `pip install git-review` (if you have configured the PATH environment variable) [09:29:29] 10Phabricator: Task dependency tree is unusable in mobile devices - https://phabricator.wikimedia.org/T210482 (10Agabi10) [09:29:47] wait i will come back...i am installing python first [09:29:59] Siyam, alright [09:34:56] (03CR) 10jenkins-bot: Fix a few sonar warnings: [search/extra] - 10https://gerrit.wikimedia.org/r/475776 (owner: 10Gehel) [09:36:21] hey i have installed pip an git review...what next>????? [09:37:30] Siyam, the next step is to configure it [09:37:48] how to configure [09:38:28] Siyam, w8 I'm searching the documentation of it. I guess it's listed somewhere in https://www.mediawiki.org/wiki/Gerrit/Tutorial [09:38:45] okayyyy....i am here [09:39:19] Siyam, ok in the "Setting up git-review" [09:39:38] what should i do?? [09:40:49] Siyam, I think you might wanna start in "Configure Git" section in https://www.mediawiki.org/wiki/Gerrit/Tutorial [09:41:13] okay wait...,i will come back [09:43:08] actually i have configured git [09:43:42] Siyam, jump to the next step then. "Set Up SSH Keys in Gerrit" [09:44:08] Siyam, have you created an account in gerrit.wikimedia.org? [09:44:19] no [09:44:37] you''ll need to create it then [09:46:12] You don't create a account on gerrit, You need to create a account of wikitech and use those details to log into gerrit [09:47:18] (03PS1) 10Eugene233: mw.notify needs to be i18n-ized [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/475973 (https://phabricator.wikimedia.org/T204659) [09:47:40] ah yup ^^ forgot about it [09:50:42] i have wikitech account....what next?? [09:51:47] Siyam, follow the instructions in "Set Up SSH Keys in Gerrit" [09:52:10] wait..i will set up that [09:52:30] 04(no projects): Add "New subection" or "New section below section X" feature to MediaWiki - https://phabricator.wikimedia.org/T210483 (10ToBeFree) [09:56:38] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10KartikMistry) [09:58:03] i am having problem in my gerrit account...i cant login [09:58:40] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10KartikMistry) p:05Triage>03High [09:59:24] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10KartikMistry) [09:59:44] it says----- Cannot assign user name siyam-_- to account 6596, name does not conform [09:59:48] Siyam, can you login with the same account in wikitech.wikimedia.org? If you forgot your password, I think you can change it there [10:00:14] read my last message [10:00:26] okay, I didn't see that message [10:01:13] so whats the solve [10:01:16] Sigyn, so can you login to wikitech or not? [10:01:53] i can.......its siyam by the way [10:02:23] but you can't log into gerrit with the same username and password? [10:02:42] yes.....i saw a message [10:02:54] it says----- Cannot assign user name siyam-_- to account 6596, name does not conform [10:03:08] interesting [10:03:42] I guess it's a bug somewhere in gerrit :/ [10:03:56] https://stackoverflow.com/questions/52646805/gerrit-ldap-cannot-assign-user-name-x-to-account-y-name-does-not-conform [10:04:06] sounds like Gerrit does not accept your shell username [10:05:14] how can i get my account then??? [10:05:42] In https://wikitech.wikimedia.org/w/index.php?title=Special:CreateAccount&returnto=Gerrit/NewUser is also mentioned "Your shell username will be used when logging into Toolforge and other Wikimedia VPS hosts using ssh. This name is typically shorter than a wiki username. __It must start with a-z, and can only contain lowercase a-z, 0-9 and - characters__" [10:05:58] were you able to use the account to get into labs servers? [10:06:29] * refeed is gonna be afk atm [10:06:47] i never went to labs servers [10:08:09] 10ContentTranslation, 10Language-Team (Language-2018-October-December): Investigate high usage of Apertium and V2 endpoint - https://phabricator.wikimedia.org/T210485 (10akosiaris) I 've helped with the debugging. Starting from apertium it was clear something automated was POSTing a lot of requests to it. It t... [10:09:22] what can i do....????? [10:11:00] can file a task and ask to be renamed. I don't know how long that will take [10:11:12] IIRC it's a horrific process [10:11:35] can open a new account if your current one is more or less unused (haven't logged into labs, haven't used gerrit?) [10:11:55] i aam now really disappointed [10:12:49] well I'm sorry about that [10:12:57] sometimes computer systems don't like special characters [10:13:20] I don't know exactly what character in your name gerrit is upset about [10:13:31] It's worth finding out what and removing it from the allowed character set for wikitech creations [10:13:52] how to create a new account...???? because i already have a wikitech account [10:14:54] yes and I'm saying that current account is sounding rather broken [10:15:13] I'm saying you should create a new one in the same way, but without the problematic characters [10:15:54] but i already have a wikitech account...so how can i create another??? [10:19:58] is there anyone [10:22:20] hi Siyam [10:23:38] can you read the pat messages and give me a solve [10:24:26] Siyam, people are not limited to one account [10:24:42] having an account does not prevent you from creating a new one [10:25:05] in fact mediawiki is unusual in that our account registration function works regardless of whether you are logged in or logged out - most sites will only allow account creation while logged out [10:25:17] we specifically allow logged in account creation and log this appropriately [10:25:27] even if it didn't you could log out and make a new account anyway [10:25:32] should i create another account????? [10:25:48] Another account will need another email..... [10:26:17] no it won't? [10:26:25] you should be able to have many accounts with the same email [10:29:07] (03PS2) 10Mobrovac: Convert $archivedRevisionCount to integer. [core] (wmf/1.33.0-wmf.4) - 10https://gerrit.wikimedia.org/r/475893 (https://phabricator.wikimedia.org/T210013) (owner: 10Ppchelko) [10:29:50] i'm having issues with mediawiki [10:30:12] i have `include_once '/vagrant/LocalSettings.php';` in core's localsettings [10:30:26] wiki works fine, can't run tests [10:31:41] PHP Warning: include_once(/vagrant/LocalSettings.php): failed to open stream: No such file or directory in /vagrant/mw/mediawiki/LocalSettings.php on line 133 [10:31:57] (php tests/phpunit/phpunit.php --wiki wiki) [10:34:22] hi shreyasminocha [10:38:06] Did I understand your first message correctly, that you added `include_once '/vagrant/LocalSettings.php';` to localsettings itself? [10:38:51] hi Urbanecm [10:41:54] to core's localsettings, yes [10:42:07] and i have core in /vagrant/mw/mediawiki [10:42:51] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10Dinoguy1000) [10:43:12] well, per https://www.mediawiki.org/wiki/MediaWiki-Vagrant you should edit LocalSettings.php by creating file in settings.d (from your path it looks you use vagrant) [10:43:35] alright, ty [10:43:59] yw [10:44:39] * shreyasminocha is going afk, will report with results soon [10:44:48] k [10:46:48] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10Dinoguy1000) The OP specifically calls for a user to be blocked from their UTP if the UTP block box is **not** checked,... [10:52:25] Urbanecm, need you help for T205136 . The easiest way to fix this would be to remove the captcha field from the CustomCommentForm, but as far as I can see, there is no way to get the user in the form, if the form is only called for rendering. Is this correct? Or am I missing something? [10:52:25] T205136: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 [10:53:01] with the for only being called for rendering, I mean the GET request, that gets the html for the form (if that makes sense) [10:53:53] Nathan_fraignt, you can use request_provider.signals.get_request function to get request object anywhere in Tracker. [10:54:20] Woah, that makes everything a whole lot easier. Thanks! [10:54:37] yw [10:54:42] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Nathan_fraignt) a:03Nathan_fraignt [10:58:06] 10Design, 10WMF-Design, 10ContentTranslation, 10Tracking, 10WorkType-NewFunctionality: Experiment ways to get more users to translate articles (tracking) - https://phabricator.wikimedia.org/T87867 (10Pginer-WMF) [10:58:09] 10Design, 10ContentTranslation, 10Tracking: Ask users to try the beta feature (tracking) - https://phabricator.wikimedia.org/T90532 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF Thanks for the reminder @Aklapper. I'll mark as resolved since the work is done and it can only bring confusion with the wo... [11:04:25] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: CX2: Don't add block templates to the translation if equivalent template is missing - https://phabricator.wikimedia.org/T204937 (10Petar.petkovic) a:05Petar.petkovic>03... [11:05:37] (03PS1) 10Nathan fraignt: Change: Captcha will not show if user is logged in [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475989 (https://phabricator.wikimedia.org/T205136) [11:14:48] 10ContentTranslation, 10Tracking, 10WorkType-Maintenance: Publishing and saving errors (tracking) - https://phabricator.wikimedia.org/T96003 (10Pginer-WMF) [11:14:50] 10CX-out-of-beta, 10Tracking, 10WorkType-Maintenance: Failures with auto-save causes users data loss when translating (tracking) - https://phabricator.wikimedia.org/T104059 (10Pginer-WMF) 05Open>03Resolved a:03Pginer-WMF Let's close this. Version 2 is expected to solve these, and individual issues are... [11:18:31] 10Language-Team (Language-2018-October-December): Language team's showcase for December 2018 - https://phabricator.wikimedia.org/T210488 (10Arrbee) [11:19:02] 10Language-Team (Language-2018-October-December): Language team's showcase for December 2018 - https://phabricator.wikimedia.org/T210488 (10Arrbee) p:05Triage>03Normal [11:22:04] (03CR) 10Phuedx: [C: 032] Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [11:23:03] (03CR) 10Phuedx: "Recheck." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [11:24:27] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10phuedx) [11:30:54] 10Language-Team (Language-2018-October-December): Language team's showcase for December 2018 - https://phabricator.wikimedia.org/T210488 (10Arrbee) [11:32:49] (03CR) 10Urbanecm: [C: 032] Change: Captcha will not show if user is logged in [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475989 (https://phabricator.wikimedia.org/T205136) (owner: 10Nathan fraignt) [11:33:45] (03Merged) 10jenkins-bot: Change: Captcha will not show if user is logged in [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475989 (https://phabricator.wikimedia.org/T205136) (owner: 10Nathan fraignt) [11:35:09] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Urbanecm) 05Open>03Resolved [11:40:30] (03PS2) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [11:43:38] (03PS1) 10Mobrovac: Update proton to 6ba6069 [services/chromium-render/deploy] - 10https://gerrit.wikimedia.org/r/475994 [11:43:54] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Incorporate 404 and 500 messages better in Tracker's interface - https://phabricator.wikimedia.org/T210395 (10Nathan_fraignt) a:03Nathan_fraignt [11:46:29] (03PS1) 10Nathan fraignt: Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) [11:57:41] (03CR) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [12:00:39] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [12:03:40] Nathan_fraignt, the Warning: You are not in production. message is centered, while it isn't centered in other views, like https://tracker2.wikimedia.cz/ticket/18/ [12:04:22] Urbanecm, will fix it, give me 5 seconds [12:04:25] sure [12:05:01] (03CR) 10Phuedx: [C: 032] Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:06:36] (03PS2) 10Nathan fraignt: Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) [12:06:47] Should be good now Urbanecm [12:06:53] * Urbanecm is reviewing [12:07:24] Although maybe I should remove the inline style altogether? [12:08:21] (03CR) 10Mobrovac: [C: 032] "SWAT" [core] (wmf/1.33.0-wmf.4) - 10https://gerrit.wikimedia.org/r/475893 (https://phabricator.wikimedia.org/T210013) (owner: 10Ppchelko) [12:08:41] (03PS1) 10John Erling Blad: Core: Allow SOFT HYPHEN to be decimal encoded [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) [12:10:54] (03CR) 10Urbanecm: [C: 032] Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) (owner: 10Nathan fraignt) [12:12:01] (03PS2) 10TheDJ: Make context available after being done with basic setup [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 [12:12:23] Nathan_fraignt, good point, would be useful for re-using in https://codein.withgoogle.com/tasks/5023013482266624/ too [12:13:07] can you do it too? I've revoked my +2 for that purpose :) [12:13:11] Nathan_fraignt, ^ [12:13:24] (03CR) 10John Erling Blad: "Nikerabbit had the initial changeset for "shy", so adding him as reviewer." [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) (owner: 10John Erling Blad) [12:13:56] Will do [12:14:18] 10LDAP-Access-Requests, 10Patch-For-Review: WMF Audiences engineers and analysts missing from `wmf` LDAP group - https://phabricator.wikimedia.org/T209901 (10jcrespo) @Mvolz you have been added to the wmf group, please verify you can now log in into Grafana: https://grafana.wikimedia.org/login?redirect=%2F [12:18:50] (03CR) 10D3r1ck01: "Thanks a lot for your review @Pmiazga. So the advantage with $this->setMwGlobals() is that it maintains a stashed version of the previous " (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [12:18:58] Urbanecm, I added a line to static/teh-tracker.css and now all my requests to static files are 404. Any ideas? [12:19:49] Can you try python manage.py collectstatic --noinput? [12:20:59] (03PS7) 10D3r1ck01: Add PHPUnit tests for testing methods in ContentProviderFactory::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) [12:21:02] Nvm, let me try something else first. I think it´s because I turned off debug=True to test the errors [12:22:03] Well that only fixes it for as long as you´re in debug [12:22:46] Collectstatic errors out [12:23:40] Hmm [12:23:45] Let me try to reproduce it [12:24:00] It´s probably an error on my side, but go ahead [12:26:40] (03PS2) 10Phuedx: Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:26:43] When I was testing your patch for the first time, /static was 404 for me too (that's why I tested it on tracker2.wikimedia.cz and not locally :D). [12:27:42] Yeah, it´s probably because debug=False means that django does not serve static files [12:27:55] Which means that something else needs to [12:27:59] Nathan_fraignt, try to use python manage.py runserver --insecure [12:28:10] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [12:28:54] Doesn´t work urbanecm [12:29:04] Well it works, just without the static files [12:29:10] even with --insecure? [12:29:27] yeah, although I might be able to fix the error. Hold on [12:29:38] Strange, per runserver --help it should "Allow serving static files even if DEBUG is False." [12:29:50] Might be a cache issue? [12:30:03] Yeah, it might be because I kinda f--ked up my settings while trying to get it to work [12:31:06] Alright fixed it [12:31:16] Thanks for the help, --insecure did the trick [12:31:26] 10Anti-Harassment (AHT Sprint 34): SWAT deploy PartialBlocks on Italian Wikipedia — 🇮🇹 - https://phabricator.wikimedia.org/T210444 (10Aklapper) [12:31:29] yw [12:31:29] uploading my patch now [12:31:32] (03CR) 10jerkins-bot: [V: 04-1] Convert $archivedRevisionCount to integer. [core] (wmf/1.33.0-wmf.4) - 10https://gerrit.wikimedia.org/r/475893 (https://phabricator.wikimedia.org/T210013) (owner: 10Ppchelko) [12:32:33] (03PS3) 10Nathan fraignt: Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) [12:33:16] * Urbanecm is looking [12:35:34] Having block head with only block.super in it looks like redundant operation to me [12:35:49] (03PS3) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [12:36:30] (03CR) 10Mobrovac: [V: 032 C: 032] Convert $archivedRevisionCount to integer. [core] (wmf/1.33.0-wmf.4) - 10https://gerrit.wikimedia.org/r/475893 (https://phabricator.wikimedia.org/T210013) (owner: 10Ppchelko) [12:36:41] 10MediaWiki-Change-tagging, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Ladsgroup) Based on https://codesearch.wmflabs.org/search/?q=tag_summary&i=nope&files=&repos= Core: [] ApiQue... [12:36:46] Of course, completely forgot to remove it [12:37:40] (03PS4) 10Nathan fraignt: Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) [12:38:59] (03CR) 10Urbanecm: [C: 032] Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) (owner: 10Nathan fraignt) [12:39:23] (03CR) 10Phuedx: "PS1 was submitted in Iadd798a8 and Idca4c892. PS2 is a cherry-pick of this change to master." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:39:47] Thanks Nathan_fraignt, +2ed and approved on GCI [12:39:51] (03Merged) 10jenkins-bot: Incorporate 404 and 500 messages in Tracker's interface [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475996 (https://phabricator.wikimedia.org/T210395) (owner: 10Nathan fraignt) [12:39:55] Np, thank you! [12:40:30] yw [12:41:00] (03CR) 10Phuedx: [C: 032] "Per Pmiazga's review above." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:47:04] 10MediaWiki-Categories, 10MediaWiki-Internationalization: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10jeblad) [12:50:14] (03Merged) 10jenkins-bot: Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:53:10] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), and 2 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10phuedx) [12:53:32] (03CR) 10Pmiazga: [C: 032] Update proton to 6ba6069 [services/chromium-render/deploy] - 10https://gerrit.wikimedia.org/r/475994 (owner: 10Mobrovac) [12:53:35] (03CR) 10Pboehm: Add new DefaultRobotPolicy (031 comment) [extensions/AdvancedMeta] - 10https://gerrit.wikimedia.org/r/472443 (owner: 10Pboehm) [12:55:41] 10Wikimedia-Site-requests, 10Patch-For-Review: Change Minang Wikipedia logo - https://phabricator.wikimedia.org/T210387 (10tomasz) 05Open>03Resolved This has now been merged and deployed on the production cluster and the new logo is visible on the wiki. [12:55:54] (03CR) 10jenkins-bot: Zero is a sensible default for this feature flag [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475890 (https://phabricator.wikimedia.org/T205008) (owner: 10Jdlrobson) [12:58:25] (03PS1) 10John Erling Blad: Core: Added entity for "combining grapheme joiner" [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) [13:01:24] (03CR) 10Pmiazga: [V: 032 C: 032] Update proton to 6ba6069 [services/chromium-render/deploy] - 10https://gerrit.wikimedia.org/r/475994 (owner: 10Mobrovac) [13:01:35] (03CR) 10John Erling Blad: "Adding Nikerabbit as a reviewer as he had a pretty much similar changeset." [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [13:03:08] (03PS4) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [13:05:44] (03PS2) 10John Erling Blad: Core: Allow "soft hyphen" to be decimal encoded [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) [13:08:28] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Improve a11y support on backlinks [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474893 (https://phabricator.wikimedia.org/T206323) (owner: 10WMDE-Fisch) [13:11:38] 10MediaWiki-extensions-WikimediaIncubator, 10Beta-Cluster-Infrastructure: Create a Wikimedia Incubator test wiki on the Beta Cluster - https://phabricator.wikimedia.org/T210492 (10Hydriz) [13:13:11] (03PS2) 10John Erling Blad: Core: Added entity for "combining grapheme joiner" [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) [13:13:35] (03CR) 10Jdrewniak: "It took me a while to track down "why" there is a non-js & js language picker. I think the main reason was *in order to* show the language" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [13:16:09] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 10Patch-For-Review: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10jeblad) [13:16:14] (03CR) 10Jdrewniak: "Also see https://phabricator.wikimedia.org/T125571#2102059" [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [13:16:52] (03CR) 10Nikerabbit: "I don't think MessageCache is the right place to add this." [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [13:17:47] (03PS3) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [13:22:01] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Wikidata-Campsite, and 2 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Lydia_Pintscher) Thank you for your patch :) [13:22:17] (03Merged) 10jenkins-bot: Improve a11y support on backlinks [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474893 (https://phabricator.wikimedia.org/T206323) (owner: 10WMDE-Fisch) [13:23:30] \o/ [13:25:58] (03CR) 10Jdrewniak: "Racking my brain a bit more, I think at the very beginning we developed a totally custom language dropdown, that we later replaced with a " [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472373 (https://phabricator.wikimedia.org/T209018) (owner: 10VolkerE) [13:26:26] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10MW-1.32-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Add ability to oversample specific pages - https://phabricator.wikimedia.org/T197607 (10Gilles) [13:27:02] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Performance-Team: Support optimized WebP thumbnails as alternative to JPEG, PNG - https://phabricator.wikimedia.org/T27611 (10Gilles) [13:27:03] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Apply the right target when creating a missing link - https://phabricator.wikimedia.org/T197787 (10Amire80) As I wrote in T210397 (which I merged into this task), using the same target name as in the source wiki is probably the worst... [13:30:26] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Quickly switch between alternative link label translations - https://phabricator.wikimedia.org/T197662 (10Amire80) I love the quick correction box! The design shows pretty much the same thing I imagined in T210308, so it's a dupe. Tha... [13:30:34] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Trizek-WMF) @matej_suchanek, maybe you can help on that task? [13:31:13] 10MediaWiki-Page-editing: Add "New subection" or "New section below section X" feature to MediaWiki - https://phabricator.wikimedia.org/T210483 (10Aklapper) 05Open>03declined Anyone is free to create subpages and/or use transclusion (instead of subsections) if you'd like to use `section=new`. [13:34:13] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10TheDJ) FYI, unlike skins, WikiEditor is not enabled by default: {F27318380} [13:38:13] d3r1ck: Umm... something related to my open patches. Could I abandon them and send them as one bigger change? Because they are connected using relation chain... And it is destroying everything :( [13:38:33] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Amire80) @matej_suchanek , if you can help with this, please see the Google Doc I shared with you. Thank you! [13:38:42] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Agabi10) >>! In T209217#4777452, @TheDJ wrote: > FYI, unlike skins, WikiEditor is not enabled by default Then it should probably be checked by default, but not merged into core. [13:38:45] Okay! [13:38:57] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Korean Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210386 (10Amire80) @revi, if you can help with this, please see the Google Doc I shared with you. Thank you! [13:39:24] Do so with a reason for abandoning, so Pywikiboters know why :) [13:40:34] thanks \o/ [13:43:51] (03CR) 10TheDJ: Make context available after being done with basic setup (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [13:46:28] 10MediaWiki-Cache, 10Performance-Team, 10Wikimedia-production-error: PHP Fatal Error: Argument passed to MessageCache::isMainCacheable() must be array - https://phabricator.wikimedia.org/T208897 (10Gilles) Unless I'm querying logstash incorrectly, I don't see any occurence of the original fatal in the last 7... [13:46:41] 10MediaWiki-Commenting, 10VisualEditor, 10VisualEditor-MediaWiki: VisualEditor: For edit summary field, give users an auto-fill drop-down (or similar) of recent edit summaries they've used - https://phabricator.wikimedia.org/T50274 (10Dvorapa) Proposed in [[https://meta.wikimedia.org/wiki/Community_Wishlist_... [13:46:46] 10Anti-Harassment: 👩‍👦‍👦 AHT password strengthing work, 2018/19 - https://phabricator.wikimedia.org/T208441 (10JBennett) >>! In T208441#4711167, @TBolliger wrote: >>>! In T208441#4710847, @Framawiki wrote: >> Related: {T197577} and others > > Yeah, good catch. Makes sense to bump this one up too. I forget, thou... [13:47:38] (03CR) 10John Erling Blad: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [13:47:44] 10MediaWiki-History-or-Diffs, 10MW-1.32-notes (WMF-deploy-2018-10-02 (1.32.0-wmf.24)), 10MobileFrontend (MobileFrontend Special Pages), 10Readers-Web-Backlog (Design): It's not possible to undo edits from the revision history or diff in "Mobile" mode - https://phabricator.wikimedia.org/T191706 (10Dvorapa)... [13:49:55] (03CR) 10Jdrewniak: [C: 032] isBorderBox and className properties are deprecated [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475354 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [13:58:37] (03Merged) 10jenkins-bot: isBorderBox and className properties are deprecated [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475354 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [13:59:52] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Jarekt) [14:01:00] 10Accessibility, 10Cite, 10TCB-Team, 10German-Community-Wishlist, and 4 others: Establish caret/arrow as jump mark for screen readers - https://phabricator.wikimedia.org/T206323 (10WMDE-Fisch) Again, can be tested on beta e.g. here: https://de.wikipedia.beta.wmflabs.org/wiki/Tacrin?purge=now ( cache might... [14:01:39] 10MediaWiki-extensions-Html2Wiki: Html2Wiki hangs up and does not convert the file - https://phabricator.wikimedia.org/T209862 (10Sferg008) Up! [14:04:17] (03CR) 10jenkins-bot: isBorderBox and className properties are deprecated [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475354 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [14:04:25] (03PS1) 10Dbrant: Fix exception handling when saving offline pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476019 [14:05:03] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, and 2 others: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10Lucas_Werkmeister_WMDE) [14:05:52] Urbanecm: hi. are you still there? [14:05:57] yep [14:06:22] 👋. mediawiki still works after removing the include command [14:06:30] but now running tests fail with a different error [14:06:34] fails* [14:06:44] [9d8ac1c5a03cd88c1cb4094d] [no req] Wikimedia\Rdbms\DBConnectionError from line 1195 of /vagrant/mw/mediawiki/includes/libs/rdbms/loadbalancer/LoadBalancer.php: Cannot access the database: Unknown error () [14:07:01] i've run mysql.server start [14:08:37] 10MediaWiki-General-or-Unknown, 10Multi-Content-Revisions, 10Wikimedia-production-error: Page Move Internal Error - https://phabricator.wikimedia.org/T209202 (10CCicalese_WMF) [14:08:42] 10MediaWiki-General-or-Unknown, 10Core Platform Team (MCR), 10Core Platform Team Backlog (Next), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 3 others: Move action aborted by fatal error "Argument must be MediaWiki\Storage\RevisionRecord, null given... - https://phabricator.wikimedia.org/T205675 [14:10:05] any idea? [14:12:08] (03PS1) 10Dbrant: Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 [14:12:43] (03PS1) 10Bmansurov: Add configuration for 'morelike' API [services/recommendation-api/deploy] - 10https://gerrit.wikimedia.org/r/476024 (https://phabricator.wikimedia.org/T201192) [14:13:12] 10Design, 10Cite, 10TCB-Team, 10WMDE-Design: Find a better way to highligth letters then bold - https://phabricator.wikimedia.org/T210281 (10thiemowmde) I played around with a few styling options. The little "b" is what is relevant in the following examples. {F27318457 size=full} `lang=css .mw-cite-backlin... [14:15:41] sorry, forgot to look here [14:16:05] does it say anything else than "Unknown error"? [14:16:32] shreyasminocha, ^ [14:17:09] gives me a stacktrace [14:18:11] 10Research, 10Patch-For-Review: Quicksurvey for reader trust - https://phabricator.wikimedia.org/T209882 (10Capt_Swing) @bmansurov I was never able to get the QuickSurvey to load on [this page](https://en.wikipedia.beta.wmflabs.org/wiki/Book) or on any other I tried. Were you able to preview it? [14:18:31] Can you pastebin full stacktrace? I'm not sure something else is there, I just have no clue how to debug "Unknown error" type error :) [14:18:36] https://paste.ee/p/bz1dT [14:18:41] was on it :D [14:18:55] nice [14:20:11] (03CR) 10Jdrewniak: [C: 031] "needs rebase" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) (owner: 10Jdlrobson) [14:20:18] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Microsoft Translator not working with new authorisation model - https://phabricator.wikimedia.org/T46679 (10Nikerabbit) [14:20:20] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Agabi10) It can't be added until the change is deployed. If added before it's considered normal text, not a magic word. [14:21:29] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10IKhitron) >>! In T210496#4777675, @Agabi10 wrote: > It can't be added until the change is deployed. If added before it's conside... [14:21:51] (03CR) 10Kosta Harlan: [C: 032] Preferences: Remove unused message for RC/Watchlist opt-out section [core] - 10https://gerrit.wikimedia.org/r/475815 (https://phabricator.wikimedia.org/T207741) (owner: 10Catrope) [14:22:55] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) [14:23:47] Not sure, but maybe setting "$wgShowSQLErrors = true;" and "$wgShowExceptionDetails = true;" will help [14:24:14] sure, let me try [14:24:34] (will help clarify the error ofc) [14:24:42] yeah [14:26:00] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Agabi10) >>! In T210496#4777683, @IKhitron wrote: >>>! In T210496#4777675, @Agabi10 wrote: >> It can't be added until the change... [14:28:08] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10IKhitron) I see, my fault. Thank you. [14:28:27] (03CR) 10Nikerabbit: "> > I don't think MessageCache is the right place to add this." [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [14:28:35] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Jarekt) >>! In T210496#4777675, @Agabi10 wrote: > It can't be added until the change is deployed. If added before it's considere... [14:29:13] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Jarekt) 05Open>03Invalid [14:34:43] Urbanecm: same stack trace [14:34:58] hmm [14:35:06] (03PS2) 10Gilles: Add new Thumbor config keys for private swift user [vagrant] - 10https://gerrit.wikimedia.org/r/414630 (https://phabricator.wikimedia.org/T187822) [14:35:43] (03Abandoned) 10Gilles: Add new Thumbor config keys for private swift user [vagrant] - 10https://gerrit.wikimedia.org/r/414630 (https://phabricator.wikimedia.org/T187822) (owner: 10Gilles) [14:36:35] (03Merged) 10jenkins-bot: Preferences: Remove unused message for RC/Watchlist opt-out section [core] - 10https://gerrit.wikimedia.org/r/475815 (https://phabricator.wikimedia.org/T207741) (owner: 10Catrope) [14:38:44] I'm wondering if tests should be ran inside vagrant or outside vagrant [14:39:20] ssh-ed, ran same command. file not found [14:39:34] (03CR) 10jenkins-bot: Preferences: Remove unused message for RC/Watchlist opt-out section [core] - 10https://gerrit.wikimedia.org/r/475815 (https://phabricator.wikimedia.org/T207741) (owner: 10Catrope) [14:43:59] 04(no projects): Rollback links broken in Special:Contributions - https://phabricator.wikimedia.org/T210500 (10Andy_Dingley) [14:45:21] 04(no projects): Rollback links broken in Special:Contributions - https://phabricator.wikimedia.org/T210500 (10Andy_Dingley) [14:50:37] (03CR) 10Fomafix: "There are even more entity notations for a soft hyphen in HTML:" [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) (owner: 10John Erling Blad) [14:51:09] (03CR) 10Tpt: [C: 031] "Thanks!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [14:53:19] (03PS1) 10Dbrant: Fix theming of notification preference icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476030 [14:54:14] (03CR) 10Fomafix: [C: 04-1] Make context available after being done with basic setup (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [14:55:17] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) >>! In T210475#4776808, @JJMC89 wrote: >>>! In T210475#4776769, @dbarratt wrote: >> This change basically mea... [14:55:58] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Invalid CSRF token error when unreviewing - https://phabricator.wikimedia.org/T177037 (10kostajh) 05Open>03Resolved a:03kostajh In September/October 2018 we re-worked the code that obtains/sends CSRF tokens, if this occurs again please re-open the issue. [14:57:13] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10WMDE-QWERTY-Team, 10WMDE-mediawiki-maintenance, and 2 others: Clean up config variable handling - https://phabricator.wikimedia.org/T194272 (10WMDE-Fisch) a:05WMDE-Fisch>03None [14:57:30] 10MediaWiki-Recent-changes, 10Growth-Team: Mark redirects in RecentChanges and Watchlist - https://phabricator.wikimedia.org/T177281 (10Trizek-WMF) So we can close that task? [14:58:56] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) [14:59:03] (03PS1) 10TheDJ: Search: Add option to search whole words [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476031 (https://phabricator.wikimedia.org/T24478) [14:59:51] (03PS5) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [15:01:08] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: Add tests for NamespaceRestriction enforcement - https://phabricator.wikimedia.org/T204988 (10dbarratt) [15:01:57] 10MediaWiki-Watchlist, 10Edit-Review-Improvements, 10Growth-Team: Box to choose different numbers of changes to show in "new filters for edit review" overflows with custom number specified in URL - https://phabricator.wikimedia.org/T176971 (10kostajh) The current state of the appearance of this bug is {F27... [15:02:19] ❯ php tests/phpunit/phpunit.php --wiki wiki [15:02:20] PHP Warning: require_once(/var/www/w/MWMultiVersion.php): failed to open stream: No such file or directory in /vagrant/mw/settings.d/wikis/CommonSettings.php on line 19 [15:02:28] why might i be getting this error? [15:02:43] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) >>! In T210475#4777135, @Dinoguy1000 wrote: > The OP specifically calls for a user to be blocked from their U... [15:02:44] looks like some file is missing [15:03:05] weird vagrant stuff [15:03:24] sigh, yeah [15:04:27] (03PS2) 10TheDJ: Search: Add option to search whole words [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476031 (https://phabricator.wikimedia.org/T24478) [15:04:37] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [15:04:42] any idea how i can resolve it? [15:05:31] (03PS3) 10TheDJ: Make context available after being done with basic setup [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 [15:07:49] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Pablo-WMDE) [15:08:53] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) @Anomie Sorry to add you but e... [15:09:08] (03CR) 10Subramanya Sastry: [C: 032] Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:11:56] (03CR) 10C. Scott Ananian: [C: 04-2] Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:12:09] (03PS2) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 [15:12:21] (03PS5) 10C. Scott Ananian: Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) [15:13:16] (03CR) 10C. Scott Ananian: [C: 031] "Stopped subbu's C+2 for a moment to allow me to update an outdated comment in the code." [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:14:46] (03PS7) 10Dbarratt: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) [15:14:47] how to add ssh key to use with git in gerrit? [15:14:48] 10Wikidata-Termbox-Iteration-4, 10Wikidata-Termbox-Iteration-5: Server: Look up language directionality based on code - https://phabricator.wikimedia.org/T209288 (10Pablo-WMDE) a:05Pablo-WMDE>03None [15:15:02] how to add ssh key to use with git in gerrit? [15:16:07] (03CR) 10Subramanya Sastry: [C: 032] Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:16:57] (03CR) 10John Erling Blad: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) (owner: 10John Erling Blad) [15:17:03] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Pablo-WMDE) a:03Pablo-WMDE [15:17:28] Siyam: have you created an ssh key pair? [15:17:42] (03PS6) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [15:17:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10Anomie) >>! In T210499#4777821, @jcresp... [15:18:01] no [15:18:13] which os are you on? [15:18:15] how to create ssh key pair [15:18:24] i am on windows [15:18:36] hmm, not sure about windows [15:18:56] lemme check [15:19:07] lemme??? [15:19:17] "let me" [15:19:31] sure [15:19:50] 10MediaWiki-General-or-Unknown, 10MediaWiki-Vagrant: `npm install` fails for mediawiki/core with EPEERINVALID when running from mediawiki-vagrant VM - https://phabricator.wikimedia.org/T210506 (10zeljkofilipin) [15:20:11] Siyam: download puttygen.exe from https://www.chiark.greenend.org.uk/~sgtatham/putty/latest.html [15:20:24] okay [15:20:58] (03CR) 10Dmaza: [C: 031] Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [15:21:40] done [15:21:47] nextt???? [15:22:20] (03CR) 10John Erling Blad: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [15:22:25] run it [15:22:40] i have run it [15:22:53] it says generate pair [15:23:01] key type "ssh-2 rsa" [15:23:09] number of bits "2048" [15:23:13] (03CR) 10Dmaza: [C: 032] Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [15:23:27] i dont see the key type [15:23:27] then click generate and follow instructions [15:23:29] 04(no projects): Rollback links broken in Special:Contributions - https://phabricator.wikimedia.org/T210500 (10Krenair) Rollback links look okay on Special:Contributions to me: `https://en.wikipedia.org/w/index.php?title=redacted&action=rollback&from=Krenair&token=redacted%2B%5C` [15:23:35] which options do you see? [15:23:48] ssh-1 rsa [15:24:03] fine, no issue [15:24:05] do the rest [15:24:30] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [15:25:28] (03CR) 10jerkins-bot: [V: 04-1] Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [15:26:17] what next?i have got a public key [15:26:37] 10MediaWiki-General-or-Unknown, 10MediaWiki-Vagrant: `npm install` fails for mediawiki/core with EPEERINVALID when running from mediawiki-vagrant VM - https://phabricator.wikimedia.org/T210506 (10zeljkofilipin) [15:26:45] are you logged into gerrit? [15:27:22] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) Ok, so this is either a "hidde... [15:27:55] yes [15:28:12] go to your settings [15:28:20] then? [15:28:27] 10MediaWiki-General-or-Unknown, 10MediaWiki-Vagrant: `npm install` fails for mediawiki/core with EPEERINVALID when running from mediawiki-vagrant VM - https://phabricator.wikimedia.org/T210506 (10zeljkofilipin) [15:28:42] click ssh public keys [15:28:49] then?? [15:29:10] paste your pub key in the field [15:29:28] which one??? [15:29:35] which ones do you see? [15:29:41] (03CR) 10C. Scott Ananian: [C: 032] Parse wikitext in gallery caption [core] - 10https://gerrit.wikimedia.org/r/417029 (https://phabricator.wikimedia.org/T187958) (owner: 10Arlolra) [15:29:46] that i got from puttygen??? [15:29:49] yes [15:30:01] i thought you meant which field [15:30:30] it says invalid ssh code [15:30:44] (03PS2) 10Dbarratt: Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) [15:30:49] strange. you didn't make any changes to the public key before pasting? [15:31:08] (03CR) 10Fomafix: [C: 031] "Are there any workarounds that can removed now?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/475361 (owner: 10TheDJ) [15:31:11] no [15:32:22] i don't know then, man [15:32:39] oh no [15:32:49] (03Merged) 10jenkins-bot: Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:33:24] Siyam: i'm sorry. try the instructions at https://www.mediawiki.org/wiki/Gerrit/Tutorial#Set_Up_SSH_Keys_in_Gerrit? [15:33:42] although those instructions aren't for windows afaik [15:33:57] by the way i have added one ssh code before in gerrit......what should i do next [15:34:22] oh, you've already added a ssh key to gerrit earlier? [15:34:53] yes [15:35:03] then what's the issue? [15:35:25] what should i do next??? [15:35:29] (03PS1) 10Dbrant: Remove Wikipedia Zero. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476037 [15:35:51] (03CR) 10jenkins-bot: Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:35:57] do you have a patch ready to submit? [15:36:15] yeah may be [15:36:43] i think you should be able to push to gerrit now [15:37:29] but how???...this has all messed up [15:37:35] what do you mean? [15:37:39] what has messed up? [15:38:21] i dont know how to submit a patch....or how can i create a patch [15:38:52] (03CR) 10jenkins-bot: Protect legacy URL parameter syntax in link and alt options [core] - 10https://gerrit.wikimedia.org/r/475801 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [15:38:58] have you made any changes to code for some task? [15:39:04] (03PS7) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [15:39:30] i was working on GCI task.... [15:39:52] which one? [15:40:52] its in beginner tasks [15:41:01] oh, the get started with gerrit one? [15:41:14] yes [15:41:31] (03PS8) 10D3r1ck01: Add PHPUnit tests for methods in McsContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) [15:41:40] let me take a quick look Siyam [15:41:52] sure [15:42:58] (03CR) 10C. Scott Ananian: [C: 032] Parse wikitext in gallery caption (031 comment) [core] - 10https://gerrit.wikimedia.org/r/417029 (https://phabricator.wikimedia.org/T187958) (owner: 10Arlolra) [15:43:04] alright, so have you created your new file Siyam? [15:43:59] i have created a .txt file to be true [15:44:12] good [15:44:16] do you have git installed? [15:44:21] yes [15:45:19] great. in the directory where you added your file, run `git add siyam.txt` (or whatever the name of your file is) [15:46:01] from my pc's folder??? [15:46:17] whichever folder you added the file to [15:46:48] i believe it's called `gci`, but not sure [15:47:11] let me clear you [15:47:27] i have only created the file with notepad [15:47:54] (03Merged) 10jenkins-bot: Parse wikitext in gallery caption [core] - 10https://gerrit.wikimedia.org/r/417029 (https://phabricator.wikimedia.org/T187958) (owner: 10Arlolra) [15:48:04] oh, you haven't run `git clone` yet? [15:48:13] so.....is it the right way to submit it...and get my task done??? [15:48:19] no [15:48:36] (03PS1) 10Niedzielski: Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 [15:48:37] (03PS1) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [15:48:39] i see. first you'll need to get a copy of the "repository" they want you to add the file to [15:48:46] create the file inside that folder [15:48:55] and then submit a "patch" [15:49:02] (03Abandoned) 10Niedzielski: Hygiene: consolidate singleton state in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474962 (owner: 10Niedzielski) [15:49:05] (03CR) 10Niedzielski: Hygiene: consolidate singleton state in mobile.startup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474962 (owner: 10Niedzielski) [15:49:22] but my problem was configuring git in my windows [15:49:45] i was having problem with ssh keys [15:49:59] oh okay, i thought you already had git installed correctly [15:50:13] in the tutorial.....it said to run ssh...but how to run ssh??? [15:50:28] the tutorial is unix-centric [15:50:38] for windows, you'll have to use "putty" [15:50:43] (not puttygen, but putty) [15:51:03] i'm not sure about the entire process for windows, but know that you'll have to use putty for ssh [15:51:09] and git bash for git [15:51:20] putyy or puttygen??? [15:51:25] (03CR) 10jenkins-bot: Parse wikitext in gallery caption [core] - 10https://gerrit.wikimedia.org/r/417029 (https://phabricator.wikimedia.org/T187958) (owner: 10Arlolra) [15:51:26] putty [15:51:29] i have gitbash [15:51:45] is it putty.exe??? [15:51:48] yes [15:52:27] wait..please....i know i am wasting your timee.....but please help me out...... [15:52:43] no, don't think of it that way [15:52:51] i'm not familiar with dev setup on windows [15:52:59] but i'm trying to help in whatever way i can [15:53:20] can you give me the link??? [15:53:31] download link of putty [15:53:43] Siyam, do you use Windows 10? [15:53:56] yes [15:54:01] (oh, the ubuntu subsystem) [15:54:19] that's what I'm going to suggest [15:54:26] :) didn't strike me [15:54:50] what suggestion?? [15:54:53] Siyam, Windows 10 supports running a virtual Ubuntu environment, called Windows Linux Subsystem [15:54:57] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [15:54:57] I'm writing it :) [15:55:11] *Window Subsystem for Linux [15:55:31] https://www.wikihow.com/Enable-the-Windows-Subsystem-for-Linux [15:55:32] You can also just use mediawiki on windows [15:55:43] With WAMP [15:55:58] oh no/........thats a huge task.....i dont think i can really use ubuntu in my windows..... [15:56:00] bawolff: they're trying to install git correctly. i'm not sure how mediawiki will help? [15:56:10] Siyam, it's quite easy [15:56:14] but i might be completely wrong [15:56:17] oh, sorry i thought we were talking about MW [15:56:31] (03CR) 10C. Scott Ananian: [C: 032] Quoted attributes don't need to be followed by a space [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [15:56:34] bawolff, I believe using the linux subsystem will help Siyam following our help pages more easily, as they're linux-centric [15:56:50] it's fine, we were talking about mw some time back [15:56:56] maybe that confused you :) [15:57:13] okay....then...help me install linux-subsystem in windows [15:57:52] Please read through https://www.wikihow.com/Enable-the-Windows-Subsystem-for-Linux. If you run into problems, ask here for advice :) [16:01:52] (03CR) 10Esanders: "ping" [extensions/3D] - 10https://gerrit.wikimedia.org/r/461960 (owner: 10Esanders) [16:03:07] (03CR) 10Esanders: SpecialPreferences: Make save button bar sticky (031 comment) [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [16:03:44] (03CR) 10Dmaza: [C: 032] Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [16:04:35] i followed the tutorial...but my windows is keep searching for required fies to activate the feature [16:04:37] (03PS5) 10Bmansurov: Add translation based 'morelike' API for missing articles [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) [16:04:49] its done [16:05:03] :/ [16:06:47] Sigyn, now you should be able to run Ubuntu [16:06:58] whoop [16:07:40] Urbanecm: siyam's out already for some reason. you mis-pinged sigyn [16:08:00] Thanks, didn't notice [16:08:25] whatever happened to siyam... [16:10:40] (03PS1) 10D3r1ck01: Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 [16:11:50] (03CR) 10jerkins-bot: [V: 04-1] Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [16:12:07] prtksxna: hi [16:12:15] (03PS6) 10Bmansurov: Add translation based 'morelike' API for missing articles [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) [16:13:03] (03PS2) 10D3r1ck01: Use $this->setMwGlobals() to set test globals / configs [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 [16:13:31] (03CR) 10D3r1ck01: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [16:13:53] (03PS3) 10TheDJ: Animations: Get rid of jquery animations [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 [16:14:57] (03PS1) 10Niedzielski: Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 [16:18:44] should i use ubuntu or kaali linux for best performane???? [16:19:04] windows 10 has only ubuntu's subsystem [16:19:09] afaik [16:19:22] oh..i see..... [16:19:55] Siyam, it was that the font was proprietary [16:20:08] (03PS1) 10Tchanders: Improve layout of ExpiryInputWidget on mobile [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) [16:20:12] oh..yeah [16:20:16] i know you [16:20:30] etienne beaule, he is [16:20:51] (03Abandoned) 10Niedzielski: Hygiene: always tear down jQuery tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/468376 (owner: 10Niedzielski) [16:21:46] (03Merged) 10jenkins-bot: Quoted attributes don't need to be followed by a space [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [16:22:42] (03PS2) 10Niedzielski: Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 [16:24:00] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10Patch-For-Review: [Bug] MobileFrontend CI browser tests failing on Ruby bundle install - https://phabricator.wikimedia.org/T207861 (10zeljkofilipin) >>! In T207861#4693009, @Jdlrobson wrote: > Browser tests are green aga... [16:24:16] Étienne Beaulé (the accents :) ) [16:24:20] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10thcipriani) @hashar noticed something p... [16:24:24] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [16:24:37] (03CR) 10jenkins-bot: Quoted attributes don't need to be followed by a space [core] - 10https://gerrit.wikimedia.org/r/471363 (owner: 10Arlolra) [16:27:10] Ebe123: sorry :) i had a feeling you'll bring them up [16:28:05] (03Merged) 10jenkins-bot: Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [16:28:57] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) Memcache would indeed be a pos... [16:29:45] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10hashar) I am pretty sure that is relate... [16:29:47] (03CR) 10Fomafix: "Where is the decimal entity ­ in use?" [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) (owner: 10John Erling Blad) [16:30:39] (03CR) 10jenkins-bot: Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [16:31:29] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Unable to serialize r:46: Id 46 out of range. - https://phabricator.wikimedia.org/T209582 (10jcrespo) Potentially reappeared at T210499 [16:31:33] (03PS8) 10Dbarratt: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) [16:32:01] Hello Volker_E , In https://phabricator.wikimedia.org/T90414 What is ment be Consistent help icon ? Should we use 'Frameless' Help icon in Echo extension? Is this the required desire? [16:32:18] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): [Bug] Skin.test.js should call jQuery.tearDown() - https://phabricator.wikimedia.org/T210517 (10Niedzielski) [16:33:26] (03CR) 10jerkins-bot: [V: 04-1] Improve layout of ExpiryInputWidget on mobile [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [16:34:07] (03CR) 10Mobrovac: [C: 04-1] "LGTM, a couple of minors." (032 comments) [services/recommendation-api/deploy] - 10https://gerrit.wikimedia.org/r/476024 (https://phabricator.wikimedia.org/T201192) (owner: 10Bmansurov) [16:35:15] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) It is just reported as a Warni... [16:36:02] 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update Selenium/Node.js/Target Custom MediaWiki - https://phabricator.wikimedia.org/T210518 (10zeljkofilipin) [16:38:01] (03CR) 10Jforrester: Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [16:38:04] 10MediaWiki-Core-Tests, 10User-zeljkofilipin: Update Selenium/Node.js/Target Custom MediaWiki - https://phabricator.wikimedia.org/T210518 (10zeljkofilipin) p:05Triage>03High [16:39:58] 10MediaWiki-extensions-Html2Wiki: Html2Wiki hangs up and does not convert the file - https://phabricator.wikimedia.org/T209862 (10Sferg008) Thanks for the answer! But I am stuck with this problem and do not know what to do. I hoped you would help, maybe I missed something. [16:41:12] 10MediaWiki-extensions-FlaggedRevs: Pages are sometimes not auto-reviewed when moved from user namespace to article namespace on dewiki - https://phabricator.wikimedia.org/T210519 (10Giftpflanze) [16:43:54] 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: User should not be allowed to edit user talk page if checkbox is enabled (partial blocks) - https://phabricator.wikimedia.org/T210475 (10dbarratt) 05Open>03Resolved [16:44:18] hi! I'm baaack [16:44:31] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10Anomie) >>! In T210499#4778228, @hashar... [16:44:40] (03PS2) 10Bmansurov: Add configuration for 'morelike' API [services/recommendation-api/deploy] - 10https://gerrit.wikimedia.org/r/476024 (https://phabricator.wikimedia.org/T201192) [16:45:14] (03PS7) 10Bmansurov: Add translation based 'morelike' API for missing articles [services/recommendation-api] - 10https://gerrit.wikimedia.org/r/450601 (https://phabricator.wikimedia.org/T201192) [16:45:20] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/471909 (owner: 10Ephemeralwaves) [16:45:45] hi takidelfin [16:45:45] (03CR) 10Zfilipin: "recheck" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [16:45:55] (03PS1) 10Gopavasanth: Replace 'help' by 'helpNotice' icon [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476051 (https://phabricator.wikimedia.org/T90414) [16:46:10] Window subsytem for Linux? :D [16:46:16] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [16:46:19] it is awesome ~o~ [16:46:26] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [16:46:39] dev-ing on windows was painful back in the day [16:46:41] (When you need to use linux and adobe apps at same time) [16:47:09] (well, part of linux) [16:47:21] that's a perk of macOS [16:47:38] hackintosh [16:47:53] (insert lenny face) [16:47:57] ~^~ [16:48:25] ( ͡° ͜ʖ ͡°)ノ=☆ [16:48:42] :) [16:48:43] 10MediaWiki-extensions-GettingStarted, 10Growth-Team, 10Patch-For-Review: Port GettingStarted Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180224 (10zeljkofilipin) Sorry, I have missed this. Should I delete the failing job? [16:48:54] shreyas which os you use??? [16:49:12] macOS [16:49:14] he uses macos iirc [16:49:16] ah [16:49:22] ( ͡° ͜ʖ ͡°)ノ=☆ [16:49:33] :D [16:50:14] ͡° ͜ʖ ͡°)ノ=☆( ͡° ͜ʖ ͡° [16:50:23] oops [16:50:34] hehehe [16:50:55] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10User-Tgr: Port CentralAuth Selenium tests from Ruby to Node - https://phabricator.wikimedia.org/T173989 (10zeljkofilipin) Should I delete failing [[ https://integration.wikimedia.org/ci/job/selenium-CentralAuth/ | selenium-CentralAuth ]] job? [16:51:03] shreyasminocha: https://www.lennyfaces.net/ [16:51:06] \o/ [16:51:11] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10jcrespo) ~~This may have stopped since... [16:51:14] \o/ [16:51:16] I'd rather use online apps like Gdocs, instead of, euhm "Word" [16:51:25] hi refeed [16:51:30] hello refeed! [16:51:39] hi shreyasminocha, takidelfin [16:51:43] i write markdown [16:51:50] me too [16:51:55] Caret [16:51:58] caret.io [16:52:09] youi have installed ubuntu in my windows [16:52:21] typora [16:52:32] typora.io [16:53:03] takidelfin, shreyasminocha: interesting, I just know those apps anyway [16:53:08] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): [Bug] Skin.test.js should call jQuery.tearDown() - https://phabricator.wikimedia.org/T210517 (10Niedzielski) [16:53:19] I've been using emacs plugin and vscode plugin for editing markdown [16:53:27] Urbanecm: Siyam has installed the ubuntu subsystem thing. i'm not familiar with it so maybe you want to guide him? [16:53:39] refeed: yeah, i write in vs code too sometimes [16:53:45] * Urbanecm waves [16:54:07] Guide him to do...what? [16:54:11] * shreyasminocha waves back [16:54:19] 10MediaWiki-extensions-GettingStarted, 10Growth-Team, 10Patch-For-Review: Port GettingStarted Selenium tests from Ruby to Node.js - https://phabricator.wikimedia.org/T180224 (10phuedx) @zeljkofilipin: Until someone (including me!) can get the time to fix 'em, I think it'd be best to disable them. That's the... [16:54:45] 10MediaWiki-extensions-FlaggedRevs: Pages are sometimes not auto-reviewed when moved from user namespace to article namespace on dewiki - https://phabricator.wikimedia.org/T210519 (10PerfektesChaos) Note: The migration from //user// to //actor// happened at the same time. That may or may not influence the access... [16:54:50] is there anything ubuntu subsystem specific about using git on ubuntu subsystem? [16:54:52] Urbanecm: ^ [16:55:22] Once the subsystem is correctly installed, it is basically the same like any terminal app [16:55:43] so it should behave exactly like it would if you entered commands on native linuux [16:55:50] this includes fancy tools like apt :) [16:56:14] I'm not sure if he has approached this step, through [16:56:15] so how can i start git now??? [16:56:24] open the subsystem Siyam [16:56:38] i have opened [16:57:02] run the git clone command [16:57:03] I can help with WSL [16:57:19] what is the command [16:57:24] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer, 10Wikidata-Campsite (Wikidata-Campsite-Iteration-∞): Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10rafidaslam) a:05rafidaslam>03None [16:57:29] $ git clone [16:57:31] depending on what you want to clone [16:57:41] shreyasminocha: also: https://github.com/qilin-editor/qilin-app [16:57:45] he wants to clone the `gci` repo for the getting started with gerrit task [16:57:50] i forget the url [16:58:02] what is repo [16:58:10] Siyam: link me to your task please? [16:58:42] Siyam: Repository (version control), a concept from the distributed revision control that refers to a data structure. [16:58:47] https://en.wikipedia.org/wiki/Repository [16:58:59] https://gerrit.git.wmflabs.org/r/admin/repos/gci [16:59:05] right [16:59:10] ** https://en.wikipedia.org/wiki/Repository_(version_control) [16:59:17] run `git clone https://gerrit.git.wmflabs.org/r/admin/repos/gci` [16:59:22] Siyam: ^ [16:59:36] shreyasminocha, ehm... shouldn't he run it with SSH version? [16:59:57] Urbanecm: does it make a diff? not sure [17:00:15] hmm [17:00:18] if you're clonning it via HTTPS, you'd need to auth via HTTPS [17:00:28] make sense [17:00:37] with Gerrit, it means using password generated by Gerrit [17:00:46] long and impossible to remember [17:00:58] 10MediaWiki-Releasing, 10Phabricator, 10Project-Admins, 10Security-team-backlog: Create "security pre-announce" group in Phab (to easier allow 3rd parties who get pre-release notifications to access Security tasks) - https://phabricator.wikimedia.org/T108360 (10chasemp) 05stalled>03Open a:03chasemp [17:01:08] and also, I posted a link that displays the correct command if you're logged in :) [17:01:19] sorry for being ambiguous [17:01:30] \o/ [17:02:29] Urbanecm, I've often gone into that. I thought the password was the same password that I entered while login from the web interface xD [17:02:50] i use git-review [17:02:53] i cant understand anything [17:03:02] you needn't worry about it Siyam [17:03:20] Urbanecm: what's the ssh url for that repo [17:03:33] * shreyasminocha is sorry [17:03:35] I'm not sure if Siyam is working on the Gerrit GCI task [17:03:37] it depends on what's Siyam's ssh username [17:03:49] i just copy-paste it each time [17:03:57] anyway, it's git clone ssh://@gerrit.git.wmflabs.org:29418/gci [17:04:02] for the GCI task [17:04:14] but again, I'm not sure if Siyam is working on the GCI task about Gerrit [17:04:22] Siyam, what you're trying to accomplish? [17:04:29] Siyam: pls link to the task you're working on? [17:04:33] what is the username [17:04:39] (although i remember asking him about it) [17:04:44] your gerrit username [17:04:47] * takidelfin lols [17:05:17] As far as I can tell, Siyam doesn't have a task in progress [17:05:29] * takidelfin lols again [17:05:41] that's why I'm asking what Siyam needs to accomplish [17:05:46] /o\ [17:05:52] i am working in gci task [17:05:57] ;-; [17:05:58] which one?? [17:06:16] Siyam, can you send us a link to that task? [17:06:56] (03CR) 10jerkins-bot: [V: 04-1] Update Echo.page.js::check for welcome element, Fix Echo.js::added page load, Add notification_welcome test [extensions/Echo] - 10https://gerrit.wikimedia.org/r/470729 (https://phabricator.wikimedia.org/T204775) (owner: 10Ephemeralwaves) [17:07:02] Urbanecm: Umm, Could you tell me what Xqt meant, please? Urbanecm: umm, may [17:07:11] https://gerrit.wikimedia.org/r/c/pywikibot/core/+/475833/2/scripts/version.py#50 [17:07:17] let me have a look [17:07:17] i dont have link [17:07:20] (03PS1) 10Subramanya Sastry: Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/476055 [17:07:35] Siyam: then how are you working on it? [17:07:49] takidelfin: "un-indented" [17:08:04] (03PS2) 10Dbrant: Remove Wikipedia Zero. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476037 [17:08:07] * Urbanecm was writing "I have no idea" [17:08:07] (03PS1) 10Dbrant: Remove unused resources. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476056 [17:08:30] mhm [17:08:39] (03CR) 10Arlolra: Sync up with Parsoid parserTests.txt (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476055 (owner: 10Subramanya Sastry) [17:08:46] I'm still confused [17:08:49] looks the commit is abandoned? [17:08:57] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10bmansurov) [17:08:57] takidelfin: aka "indent can be removed" [17:09:06] "but can also be kept" [17:09:07] i cant give the link now [17:09:07] (I'm margin multiple patches into one) [17:09:12] *merging [17:09:14] 10UI-Standardization, 10MinervaNeue, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Add `cite` styles to MinervaNeue - https://phabricator.wikimedia.org/T189754 (10Jdlrobson) Only example I can find does not use blockquotes... https://en.m.wikipedia.org/wiki/Are_You_Experienced#February [17:09:42] (03CR) 10Subramanya Sastry: Sync up with Parsoid parserTests.txt (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476055 (owner: 10Subramanya Sastry) [17:09:52] if (not hasattr(requests, 'certs') [17:09:52] or not hasattr(requests.certs, 'where') [17:09:52] or not callable(requests.certs.where)): [17:09:52] pywikibot.output(' cacerts: not defined') [17:09:58] Siyam, what is the name of GCI task you're working on? [17:10:03] takidelfin: they're saying "either keep the indent or remove it" [17:10:06] l-l [17:10:15] its in beginner task [17:10:20] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10ovasileva) [17:10:25] its name getting into gci [17:10:36] Siyam: is it "Learn how to use Gerrit for code review, by submitting a patch" [17:10:43] Siyam, is it https://codein.withgoogle.com/tasks/4513104365879296/? [17:10:46] takidelfin: i hope you're no longer confused [17:10:55] 10Google-Code-in-2018, 10Page-Previews, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: Popups: Update babel-preset-env and friends - https://phabricator.wikimedia.org/T197883 (10ovasileva) [17:10:55] thanks :D [17:11:02] I will keep it [17:11:04] (03PS2) 10Subramanya Sastry: Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/476055 [17:11:06] np :) [17:12:21] 10Page-Previews, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Popups: Upgrade Popups dependencies - https://phabricator.wikimedia.org/T209314 (10ovasileva) [17:12:23] ❯ alias vag=vagrant [17:12:27] * shreyasminocha is ashamed of himself [17:12:46] (03PS1) 10Ladsgroup: Migrate Api modules from tag_summary table to change_tag [core] - 10https://gerrit.wikimedia.org/r/476058 (https://phabricator.wikimedia.org/T209525) [17:12:48] (03CR) 10Arlolra: [C: 032] Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/476055 (owner: 10Subramanya Sastry) [17:13:08] 10Page-Previews, 10Performance-Team (Radar), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions - https://phabricator.wikimedia.org/T208634 (10ovasileva) p:05Normal>03High [17:16:39] 10Readers-Web-Backlog, 10Epic, 10SEO: [Epic] [SEO] Enable Schema.org Article linked data for all main namespace pages - https://phabricator.wikimedia.org/T209306 (10pmiazga) [17:17:45] Siyam, We'd like to help you, but we need to know what you're trying to do [17:17:52] +1 [17:17:55] ^ [17:18:15] pure git should be working now [17:18:22] or working after running one command [17:18:33] Git should also work on Windows [17:18:45] but that's git bash [17:19:40] takidelfin, it's way easier to use subsystem when working with Wikimedia [17:19:45] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: mobile.toggle migrated to webpack - https://phabricator.wikimedia.org/T210208 (10ovasileva) [17:19:55] as those are linux-centric [17:20:12] yup [17:20:57] (03PS1) 10Ladsgroup: Migrate WatchedItemQueryService from tag_summary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476059 (https://phabricator.wikimedia.org/T209525) [17:21:02] (if you plan on dev-ing long-term, switch to linux if and when possible) [17:22:00] 10Growth-Team (Current Sprint): Help pane: write English copy for translation - https://phabricator.wikimedia.org/T210213 (10RHo) >>! In T210213#4777952, @Trizek-WMF wrote: > The texts look fine to me after a first pass. Can I share it with the Ambassadors? Should we add the translations there? Sure thing if th... [17:22:30] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Jdlrobson) [17:23:59] it's quite easy to dual boot these days. There's often the need to support clients on different platforms, so good to be familiar with all of them [17:24:05] (03CR) 10Tchanders: Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [17:24:07] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [17:24:24] RexxS: fair [17:24:41] An old pc can be brouhgt back to life with a lubuntu install [17:24:49] :D [17:24:52] run ti headless [17:25:07] yes thats the link [17:25:17] (03CR) 10Jforrester: Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [17:25:18] or if cost is a problem get a raspberry pi [17:26:13] the one I posted? [17:26:26] In that case, do you have an acc on https://gerrit.git.wmflabs.org/r/ ? [17:26:27] (acc=account) [17:26:42] (03PS1) 10Esanders: Implement Title.wantSignaturesNamespace in JS [core] - 10https://gerrit.wikimedia.org/r/476061 [17:26:45] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Jdlrobson) [17:26:49] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10Niedzielski) [17:26:51] 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port mobile.watchstar and mobile.pagelist.scripts code to webpack - https://phabricator.wikimedia.org/T208921 (10Niedzielski) [17:26:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix global variable name typo in LocalIdLookupTest.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [17:26:54] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: Port search related code to webpack - https://phabricator.wikimedia.org/T210207 (10ovasileva) [17:26:56] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 34), 10Patch-For-Review: Clean up Expiry field on Special:Block on Mobile - https://phabricator.wikimedia.org/T208271 (10Tchanders) Here are some screenshots in the different skins with that patch: ||Vector|Monobook|Minerva| |Desktop|{F27318766}|{F2... [17:27:00] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Pablo-WMDE) a:05Pablo-WMDE>03None [17:27:19] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Pablo-WMDE) Findings: https://github.com/vuejs/vue-class-component/issues/174 https://github.com/vuejs/vue-class-component#adding-custom-hooks https://github.com/vuejs/vue-class-component/issues... [17:27:21] 10Wikidata-Termbox-Iteration-5: Make asyncData work in production build - https://phabricator.wikimedia.org/T210504 (10Pablo-WMDE) https://github.com/wmde/wikibase-termbox/pull/83 [17:27:32] 10MediaWiki-extensions-FlaggedRevs, 10Code-Stewardship-Reviews, 10Growth-Team: FlaggedRevs: code stewardship review - https://phabricator.wikimedia.org/T185664 (10Jrbranaa) @Catrope, we can certainly find another home for this extension if you think another team is a better fit. Out of curiosity, is this re... [17:28:46] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) - https://phabricator.wikimedia.org/T210210 (10ovasileva) [17:28:57] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Amire80) Thank you so much! [17:29:08] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Rename Toggler - https://phabricator.wikimedia.org/T210521 (10Niedzielski) [17:29:10] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Amire80) [17:29:30] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): MFA: mobile.languages.structured is bundled in webpack (code splitting warning!!) - https://phabricator.wikimedia.org/T210210 (10Jdlrobson) [17:29:57] (03PS1) 10VolkerE: Fix navigation controls wrapping on Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476063 (https://phabricator.wikimedia.org/T210487) [17:30:01] (03Merged) 10jenkins-bot: Sync up with Parsoid parserTests.txt [core] - 10https://gerrit.wikimedia.org/r/476055 (owner: 10Subramanya Sastry) [17:53:26] (03CR) 10Jforrester: [C: 031] Add `font-family-system-sans` font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [17:53:27] (03PS1) 10DLynch: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) [17:54:52] (03CR) 10Mholloway: [C: 04-1] "Thanks for the patch! One suggestion inline." (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476066 (https://phabricator.wikimedia.org/T172146) (owner: 10Rafidaslam) [17:55:57] d3r1ck: umm, maybe you could help me? https://gerrit.wikimedia.org/r/c/pywikibot/core/+/475823#120 [17:55:57] Is rule E128 used? `continuation line under-indented for visual indent` [17:56:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "The really only thing this tests needs is some "truthy" value. This can be anything, the string "dummy", true, 1, whatever you like. Curre" [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [17:56:18] (03PS2) 10Jforrester: Add monospace font stack [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/475949 (https://phabricator.wikimedia.org/T209915) (owner: 10VolkerE) [17:56:24] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10bmansurov) [17:56:37] (03PS1) 10Ladsgroup: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) [17:57:46] :( [17:57:49] No one knows [17:59:12] (03PS2) 10Rafidaslam: ArticleHelper.class.php: Change getTalkPage() to getTalkPageIfDefined() [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476066 (https://phabricator.wikimedia.org/T172146) [17:59:29] Volker_E: Ping ? [18:00:40] (03PS3) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [18:01:45] (03PS4) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [18:02:15] (03CR) 10D3r1ck01: "Dependency to the global dropped and "true" used. Thanks @Theimo :)" [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [18:02:51] (03PS5) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [18:03:35] (03CR) 10Mholloway: "Great! I'll merge after CI passes." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476066 (https://phabricator.wikimedia.org/T172146) (owner: 10Rafidaslam) [18:04:53] (03Merged) 10jenkins-bot: Implement Title.wantSignaturesNamespace in JS [core] - 10https://gerrit.wikimedia.org/r/476061 (owner: 10Esanders) [18:04:56] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476067 (owner: 10Esanders) [18:04:57] (03CR) 10jerkins-bot: [V: 04-1] Use mw.Title.wantSignaturesNamespace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:05:45] (03CR) 10Sharvaniharan: [C: 032] Remove unused resources. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476056 (owner: 10Dbrant) [18:05:54] (03Merged) 10jenkins-bot: Fix theming of notification preference icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476030 (owner: 10Dbrant) [18:06:13] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10Jdlrobson) Requesting feedba... [18:06:52] (03PS1) 10Yaron Koren: Remove $wgMintyDocsProductPages setting/requirement [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476074 [18:07:02] (03CR) 10jerkins-bot: [V: 04-1] Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [18:07:06] (03CR) 10jenkins-bot: Implement Title.wantSignaturesNamespace in JS [core] - 10https://gerrit.wikimedia.org/r/476061 (owner: 10Esanders) [18:07:25] (03CR) 10Mholloway: [C: 032] ArticleHelper.class.php: Change getTalkPage() to getTalkPageIfDefined() [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476066 (https://phabricator.wikimedia.org/T172146) (owner: 10Rafidaslam) [18:07:27] (03CR) 10Thiemo Kreuz (WMDE): "Are you aware of the massive backlash created by https://www.mediawiki.org/wiki/Typography_refresh in 2014? The result back then was to re" [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [18:07:50] takidelfin, I think yes, it's not ignored in `tox.ini`, and if you run `tox -e flake8` and the E128 errors shows up, that means the rule is used [18:07:59] ye [18:08:06] (03CR) 10jenkins-bot: Fix theming of notification preference icons. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476030 (owner: 10Dbrant) [18:08:14] I know it is not present in toxini [18:08:27] but Xqt said that indent shoulld be multiple of 4 [18:09:10] (03CR) 10Jforrester: [C: 032] "…" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:09:25] 10VisualEditor (Current work): [Regression wmf.4] "Publish Changes" button stays disabled while trying to re-edit a page - https://phabricator.wikimedia.org/T209542 (10matmarex) (I can reproduce on en.wp on https://en.wikipedia.org/wiki/User:Matma_Rex/sandbox, but not locally.) [18:09:29] (03PS2) 10DLynch: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) [18:09:55] takidelfin, where's the patch btw? [18:10:05] (03CR) 10jerkins-bot: [V: 04-1] Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:10:05] (abandonned) [18:10:42] 10Page-Previews, 10Performance-Team (Radar), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: Popups: [Spike, 16hrs] Replicate Popups memory leak without other extensions - https://phabricator.wikimedia.org/T208634 (10pmiazga) a:03pmiazga [18:10:43] (03PS2) 10Yaron Koren: Remove $wgMintyDocsProductPages setting/requirement [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476074 [18:10:47] 10MediaWiki-Change-tagging, 10DBA, 10Operations, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: Migrate tag_summary usage to change_tag and drop the table - https://phabricator.wikimedia.org/T209525 (10Ladsgroup) a:03Ladsgroup [18:12:17] takidelfin, the patch that's abandoned still can be accessed [18:12:31] ikr [18:13:14] (03CR) 10jerkins-bot: [V: 04-1] Migrate SpecialUndelete and Diff from tag_sumaary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:13:19] (03CR) 10Pmiazga: [C: 032] Wean editor off getEditCount in preparation for user deprecation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475138 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [18:13:26] 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): MFA: Port the references feature to webpack: Merge mobile.references and mobile.references.gateway - https://phabricator.wikimedia.org/T207805... [18:15:05] Wow, the logic in SpecialBlock.php is terrible [18:15:46] (03CR) 10DLynch: "...arguably I should pull the debugtrack out into a separate patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/VisualEditor/+/4" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) (owner: 10DLynch) [18:15:52] (03PS2) 10Ladsgroup: Migrate SpecialUndelete and Diff from tag_sumaary to change_tag [core] - 10https://gerrit.wikimedia.org/r/476069 (https://phabricator.wikimedia.org/T209525) [18:15:54] (03CR) 10Niedzielski: [C: 032] Organise src folder by feature (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [18:16:04] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Unable to serialize r:46: Id 46 out of range. - https://phabricator.wikimedia.org/T209582 (10Anomie) I suppose one option would be to abandon Serializable entirely. A trait like this should give basically the same functionality without the bug: ` la... [18:16:32] (03CR) 10VolkerE: "@Thiemo Kreuz, yes sure. We (design team and myself joining in May 2015) were dealing with the outlash of this for quite a long time. This" [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [18:17:19] takidelfin, btw, I just wanna see the patch where Xqt said that the indent should be multiple of 4 [18:17:20] (03Merged) 10jenkins-bot: Remove unused resources. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476056 (owner: 10Dbrant) [18:17:31] https://gerrit.wikimedia.org/r/c/pywikibot/core/+/475823#120 [18:17:42] (03Merged) 10jenkins-bot: Fix navigation controls wrapping on Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476063 (https://phabricator.wikimedia.org/T210487) (owner: 10VolkerE) [18:17:44] (03Merged) 10jenkins-bot: ArticleHelper.class.php: Change getTalkPage() to getTalkPageIfDefined() [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476066 (https://phabricator.wikimedia.org/T172146) (owner: 10Rafidaslam) [18:17:58] (03PS2) 10Ladsgroup: Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) [18:18:09] 10LDAP-Access-Requests, 10Patch-For-Review: WMF Audiences engineers and analysts missing from `wmf` LDAP group - https://phabricator.wikimedia.org/T209901 (10Mvolz) >>! In T209901#4777257, @jcrespo wrote: > @Mvolz you have been added to the wmf group, please verify you can now log in into Grafana: https://gra... [18:18:17] refeed: but it works for this line [18:18:33] I'm talking about indent other than mulitple of 4 [18:18:56] *indents other than multiples of 4 [18:19:02] Ebe123: o/ [18:19:34] (03CR) 10jenkins-bot: Remove unused resources. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476056 (owner: 10Dbrant) [18:21:24] (03CR) 10C. Scott Ananian: "@james: ping? can I convince you to turn that +1 into +2?" [core] - 10https://gerrit.wikimedia.org/r/445664 (owner: 10C. Scott Ananian) [18:21:34] 10MediaWiki-Interface, 10Discovery-Search (Current work), 10I18n: Namespaces are shown in the local language rather than in the user interface language - https://phabricator.wikimedia.org/T174057 (10EBernhardson) [18:22:03] (03Merged) 10jenkins-bot: Remove Wikipedia Zero. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476037 (owner: 10Dbrant) [18:22:11] 10MediaWiki-Interface, 10Discovery-Search (Current work), 10I18n: Namespaces are shown in the local language rather than in the user interface language - https://phabricator.wikimedia.org/T174057 (10EBernhardson) a:05EBernhardson>03None [18:22:30] takidelfin, yup, to avoid E127 you need to indent the line by 4 again, not more not less [18:22:37] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) a:03nray [18:22:40] 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Prepare selenium browser test for page issues A/B test - https://phabricator.wikimedia.org/T206647 (10nray) a:03nray [18:22:50] (03CR) 10jenkins-bot: Fix navigation controls wrapping on Notifications page [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476063 (https://phabricator.wikimedia.org/T210487) (owner: 10VolkerE) [18:23:01] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 [18:23:01] I think it'd be better if we had an example [18:23:27] shrug, I fixed it (did some other tweaks to indent) [18:23:47] thanks for help c: [18:24:23] np [18:24:59] (03Merged) 10jenkins-bot: Use mw.Title.wantSignaturesNamespace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/476068 (owner: 10Esanders) [18:25:09] framawiki is here, I think he can help you if you have any problem with Python (if he has free time) :) [18:25:28] 10Discovery-Search (Current work), 10Patch-For-Review: Configure LVS endpoints for new elasticsearch clusters - https://phabricator.wikimedia.org/T207195 (10Gehel) [18:25:34] (03CR) 10jenkins-bot: Remove Wikipedia Zero. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476037 (owner: 10Dbrant) [18:25:51] hi refeed and takidelfin! [18:26:05] hello framawiki! [18:26:12] (03PS1) 10VolkerE: Update 'UserAvatar' to latest WikimediaUI icon [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/476077 (https://phabricator.wikimedia.org/T123810) [18:26:24] framawiki, hi! [18:26:28] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10diego) Hey @bmansurov , the list in Spanish it's over 11K. Maybe you could sample by cosine similarity, and create an stratified sample. Doing 11K sounds not realistic for me. Another thing, I see a l... [18:26:40] I think I wanna go to bed right now [18:26:48] it's 1.26 am here [18:27:05] Goodnight everyone! [18:27:16] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work), 10MW-1.32-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)): Introduce keyword interfaces dedicated per usage - https://phabricator.wikimedia.org/T190132 (10dcausse) [18:27:24] 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Patch-For-Review, 10UI-Standardization-Kanban: Update avatar icon - https://phabricator.wikimedia.org/T123810 (10Volker_E) [18:27:36] goodbye refeed! [18:27:38] (03CR) 10jerkins-bot: [V: 04-1] Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [18:27:41] 04(no projects): Database error when installing MW 1.31.1 - https://phabricator.wikimedia.org/T210524 (10Joergi123) The problem can be described more clearly: $wgDBprefix is not set, so there should not be a table prefix. Depending on which table engine is chosen, MediaWiki during installation tries to access... [18:27:50] 10CirrusSearch, 10Discovery, 10Discovery-Search (Current work), 10Epic: EPIC: Refactor query parsing logic - https://phabricator.wikimedia.org/T185108 (10dcausse) [18:28:33] takidelfin, bye! [18:29:50] (03Merged) 10jenkins-bot: Wean editor off getEditCount in preparation for user deprecation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475138 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [18:31:36] (03CR) 10jerkins-bot: [V: 04-1] Migrate AbuseFilterConsequencesTest from tag_summary to change_tag [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:31:45] (03CR) 10C. Scott Ananian: [C: 04-1] "I don't think we should invent our own &cgj; entity name, which AFAICT isn't present in HTML5." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [18:31:53] (03CR) 10jerkins-bot: [V: 04-1] Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [18:32:29] 10Hashtags: Restart scripts container if it exits - https://phabricator.wikimedia.org/T210525 (10Samwalton9) [18:33:21] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) [18:33:44] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) One general fix would be to abandon Serializable entirely. A trait like this should give basically the same functionality without the bug: `... [18:34:06] (03PS4) 10Sharvaniharan: Network Interceptors to Kotlin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475060 [18:34:29] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10Anomie) [18:34:31] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) [18:34:35] (03CR) 10jenkins-bot: Wean editor off getEditCount in preparation for user deprecation [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475138 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [18:34:37] (03CR) 10jerkins-bot: [V: 04-1] Network Interceptors to Kotlin [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475060 (owner: 10Sharvaniharan) [18:34:43] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Unable to serialize r:46: Id 46 out of range. - https://phabricator.wikimedia.org/T209582 (10Anomie) [18:34:45] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) [18:35:31] (03CR) 10Jforrester: "This can't use the OOUI icon directly because it is included in e-mails, is that right?" [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/476077 (https://phabricator.wikimedia.org/T123810) (owner: 10VolkerE) [18:35:33] (03CR) 10Daimona Eaytoy: "Only minor issue, the rest seems fine. The failure for PS2 is T207173 ." (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476073 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [18:35:35] (03CR) 10Jforrester: [C: 032] Update 'UserAvatar' to latest WikimediaUI icon [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/476077 (https://phabricator.wikimedia.org/T123810) (owner: 10VolkerE) [18:35:41] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Unable to serialize r:46: Id 46 out of range. - https://phabricator.wikimedia.org/T209582 (10Anomie) I filed {T210528} to explain the issue rather than the symptom, so I'm closing this as a duplicate of that task. [18:36:01] (03CR) 10Jforrester: [C: 032] Accept BCP 47 codes in LanguageConverter rules [core] - 10https://gerrit.wikimedia.org/r/445664 (owner: 10C. Scott Ananian) [18:36:07] 10MediaWiki-General-or-Unknown, 10MediaWiki-Logging, 10Wikimedia-production-error: ErrorException from line 1159 of /srv/mediawiki/php-1.33.0-wmf.4/includes/Message.php: PHP Warning: Invalid argument supplied for foreach() - https://phabricator.wikimedia.org/T210499 (10Anomie) I filed {T210528} to explain th... [18:36:29] 10Wikimedia-Portals: www.wikipedia.org says 0+ articles for all languages - https://phabricator.wikimedia.org/T210401 (10Marostegui) [18:37:31] 10AbuseFilter, 10Core Platform Team Backlog (Watching / External), 10MW-1.32-release, 10Patch-For-Review, 10Wikimedia-production-error: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null - https://phabricator.wikimedia.org/T203336 (10greg) Status/next steps f... [18:39:22] (03PS6) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [18:40:45] (03PS1) 10Brian Wolff: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) [18:41:16] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, and 2 others: [Bug] Control clicking image doesn't open in new tab - https://phabricator.wikimedia.org/T206348 (10ovasileva) 05Open>03Resolved looks good, thanks all! [18:41:19] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) Another possible fix, that might also bring some benefit towards {T161647}, would be to write our own serializer that will only serialize/un... [18:41:43] (03CR) 10Thiemo Kreuz (WMDE): "Cool. Thanks for the insight!" [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [18:41:50] 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Feature flag the page issues code - https://phabricator.wikimedia.org/T206179 (10ovasileva) 05Open>03Resolved all done! [18:42:43] 10Google-Code-in-2018, 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Mobile, and 4 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10ovasileva) 05Open>03Resolved [18:43:56] (03Merged) 10jenkins-bot: Update 'UserAvatar' to latest WikimediaUI icon [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/476077 (https://phabricator.wikimedia.org/T123810) (owner: 10VolkerE) [18:44:52] (03Abandoned) 10Imarlier: MWHttpRequest: Be less naive about status [core] - 10https://gerrit.wikimedia.org/r/448566 (https://phabricator.wikimedia.org/T200524) (owner: 10Imarlier) [18:45:01] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Anomie) [18:45:05] (03CR) 10VolkerE: "@Thiemo Thanks for the question and the pointer. It is good to provide insights for others!" [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/463547 (https://phabricator.wikimedia.org/T175877) (owner: 10VolkerE) [18:45:42] 10Design, 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10OOUI, 10Tracking: Use the same icons to represent the same things (tracking) - https://phabricator.wikimedia.org/T55733 (10Volker_E) [18:45:46] 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10UI-Standardization-Kanban: Update avatar icon - https://phabricator.wikimedia.org/T123810 (10Volker_E) 05Open>03Resolved [18:46:32] 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10Legoktm) >>! In T210528#4778665, @Anomie wrote: > One general fix would be to abandon Serializable entirely. There are few cases of using Serializ... [18:46:34] (03CR) 10Niedzielski: Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [18:47:01] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Patch-For-Review: MWHttpRequest needs to be a little smarter about setting status - https://phabricator.wikimedia.org/T200524 (10Imarlier) 05Open>03declined I still think that there are better options for status than the way that MWHttpRequest handles... [18:47:12] (03PS3) 10Niedzielski: Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [18:47:42] (03CR) 10jenkins-bot: Update 'UserAvatar' to latest WikimediaUI icon [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/476077 (https://phabricator.wikimedia.org/T123810) (owner: 10VolkerE) [18:48:09] (03CR) 10Niedzielski: [C: 032] "This failed because a patch that didn't update the build products was merged which doesn't create a merge conflict but does cause the dist" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [18:48:40] 10Growth-Team, 10StructuredDiscussions, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Random failures for several Flow tests - https://phabricator.wikimedia.org/T207173 (10Daimona) [18:48:41] (03CR) 10Esanders: "In eslint-config-wikimedia 0.9.0 we introduce the wikimedia/jquery ruleset. This ruleset defines the '$' global, which can't be overridden" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [18:49:10] 10Growth-Team, 10StructuredDiscussions, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Random failures for several Flow tests - https://phabricator.wikimedia.org/T207173 (10Daimona) [18:49:25] 10LDAP-Access-Requests, 10Patch-For-Review: WMF Audiences engineers and analysts missing from `wmf` LDAP group - https://phabricator.wikimedia.org/T209901 (10jcrespo) a:05jcrespo>03None Please the rest, as mentioned at T209901#4773777 feel free to request access if needed. I will leave this task open until... [18:49:29] (03Merged) 10jenkins-bot: Accept BCP 47 codes in LanguageConverter rules [core] - 10https://gerrit.wikimedia.org/r/445664 (owner: 10C. Scott Ananian) [18:49:40] 10Design, 10Citoid, 10VisualEditor, 10VisualEditor-MediaWiki-References: Be able to generate citation list using citoid - https://phabricator.wikimedia.org/T173624 (10Mvolz) FYI there is a way to do this using scholia/wikidata if the author is in wikidata that generates wikitext. It does not use citoid.... [18:49:42] 10Design, 10Collab-Notifications-Page, 10Growth-Team, 10Tracking: Design adjustments for the Notifications Page - https://phabricator.wikimedia.org/T136567 (10Etonkovidova) [18:50:25] wikimedia/stylelint-config-wikimedia#33 (build - 60d499b jdforrester): The build failed. - https://travis-ci.org/wikimedia/stylelint-config-wikimedia/builds/460406923 [18:50:40] 10Growth-Team, 10StructuredDiscussions, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review, 10Wikimedia-production-error (Shared Build Failure): Random failures for several Flow tests - https://phabricator.wikimedia.org/T207173 (10Daimona) [18:51:58] (03CR) 10Daimona Eaytoy: "Aside from task number: yes please!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/475364 (https://phabricator.wikimedia.org/T210204) (owner: 10D3r1ck01) [18:52:10] (03CR) 10jenkins-bot: Accept BCP 47 codes in LanguageConverter rules [core] - 10https://gerrit.wikimedia.org/r/445664 (owner: 10C. Scott Ananian) [18:52:46] (03CR) 10Tchanders: "Sounds like this can be abandoned now?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472376 (https://phabricator.wikimedia.org/T201719) (owner: 10Dmaza) [18:53:18] (03CR) 10Daimona Eaytoy: "recheck" [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/472456 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [18:53:25] (03CR) 10jerkins-bot: [V: 04-1] Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [18:53:31] (03PS2) 10D3r1ck01: Mark flaky PostCollectionTest::testGetLastRevision() test as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/475364 (https://phabricator.wikimedia.org/T207173) [18:54:20] (03CR) 10Daimona Eaytoy: [C: 031] Mark flaky PostCollectionTest::testGetLastRevision() test as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/475364 (https://phabricator.wikimedia.org/T207173) (owner: 10D3r1ck01) [18:54:20] (03CR) 10Legoktm: [C: 032] API: Validate API error codes [core] - 10https://gerrit.wikimedia.org/r/472211 (https://phabricator.wikimedia.org/T208926) (owner: 10Anomie) [18:54:21] (03CR) 10D3r1ck01: Mark flaky PostCollectionTest::testGetLastRevision() test as broken (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/475364 (https://phabricator.wikimedia.org/T207173) (owner: 10D3r1ck01) [18:54:41] (03CR) 10Legoktm: [C: 032] "Thanks for splitting this" [core] - 10https://gerrit.wikimedia.org/r/475814 (owner: 10Anomie) [18:56:32] (03CR) 10jerkins-bot: [V: 04-1] Temporarily mark flaky tests as broken [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/472456 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [18:56:34] (03CR) 10jerkins-bot: [V: 04-1] Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [18:57:30] (03PS1) 10Kaldari: Just a couple code comments to make it easier to follow [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476085 [18:57:34] (03CR) 10Daimona Eaytoy: "I think this needs to be manually verified due to T189560." [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/472456 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [18:58:56] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/3D] - 10https://gerrit.wikimedia.org/r/476087 [18:58:58] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10bmansurov) [18:59:31] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10bmansurov) @leila is the task description what you had in mind when you were talking about creating an API for the paper? [19:00:28] (03PS10) 10Jdlrobson: Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) [19:00:52] 10AbuseFilter, 10Core Platform Team Backlog (Watching / External), 10MW-1.32-release, 10Patch-For-Review, 10Wikimedia-production-error: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null - https://phabricator.wikimedia.org/T203336 (10Daimona) @greg Waiting fo... [19:01:17] (03CR) 10Legoktm: "Definitely needs tests :-). Does the API also need updating?" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [19:05:26] 10Phabricator, 10Scap, 10Release-Engineering-Team (Kanban): Refresh Jenkins API token for Harbormaster - https://phabricator.wikimedia.org/T207335 (10greg) p:05Triage>03Normal [19:08:29] (03Merged) 10jenkins-bot: API: Validate API error codes [core] - 10https://gerrit.wikimedia.org/r/472211 (https://phabricator.wikimedia.org/T208926) (owner: 10Anomie) [19:09:25] (03CR) 10Legoktm: [C: 04-1] "I'm not sure exactly what's wrong, but eslint doesn't seem to be working...in Jenkins it outputs:" (031 comment) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:09:50] 10Discovery, 10Discovery-Search: Detect "wrong keyboard" queries for Hebrew/American keyboards on EN/HE Wikipedias - https://phabricator.wikimedia.org/T155104 (10TJones) Bummer. The DWIM edit works, in that it generates wrong-keyboard suggestions in the main search box on Special:Search, but it interacts impro... [19:11:13] (03CR) 10Niedzielski: [C: 032] Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [19:11:28] (03CR) 10jenkins-bot: API: Validate API error codes [core] - 10https://gerrit.wikimedia.org/r/472211 (https://phabricator.wikimedia.org/T208926) (owner: 10Anomie) [19:13:10] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 [19:13:20] 10MediaWiki-API, 10Reading List Service, 10Reading-Infrastructure-Team-Backlog, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), and 4 others: PHP Fatal from ApiMain.php: Header may not contain more than a single header, new line dete... - https://phabricator.wikimedia.org/T208926 [19:14:16] (03Merged) 10jenkins-bot: API: Add exception class as data to internal_api_error codes [core] - 10https://gerrit.wikimedia.org/r/475814 (owner: 10Anomie) [19:14:22] (03CR) 10Legoktm: [C: 04-1] "Figured it out, this was missing root: true, which we don't have everywhere yet. So if you could add that in and fix the other inline comm" (031 comment) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:15:28] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Window dressing is mostly olive oil, 10I18n: Right 'banner-protect' is missing i18n descriptions - https://phabricator.wikimedia.org/T209763 (10MarcoAurelio) @Ejegg Thanks for your reply. Would then: "banner-protect": "Pro... [19:16:01] (03CR) 10Legoktm: [C: 04-1] build: Replace jshint/jscs with eslint & stylelint (031 comment) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:17:01] (03CR) 10Jforrester: "Great start, thank you!" (032 comments) [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [19:17:12] (03CR) 10jenkins-bot: API: Add exception class as data to internal_api_error codes [core] - 10https://gerrit.wikimedia.org/r/475814 (owner: 10Anomie) [19:18:25] (03Abandoned) 10John Erling Blad: Core: Added entity for "combining grapheme joiner" [core] - 10https://gerrit.wikimedia.org/r/476010 (https://phabricator.wikimedia.org/T210490) (owner: 10John Erling Blad) [19:19:56] (03Abandoned) 10John Erling Blad: Core: Allow "soft hyphen" to be decimal encoded [core] - 10https://gerrit.wikimedia.org/r/475999 (https://phabricator.wikimedia.org/T127062) (owner: 10John Erling Blad) [19:20:08] (03CR) 10Yaron Koren: [C: 032] Remove $wgMintyDocsProductPages setting/requirement [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476074 (owner: 10Yaron Koren) [19:21:29] 10Code-Health-Metrics, 10Epic: Enable commit risk assessment - https://phabricator.wikimedia.org/T210533 (10Jrbranaa) [19:22:28] 10Code-Health-Metrics, 10Epic: Enable commit risk assessment - https://phabricator.wikimedia.org/T210533 (10Jrbranaa) [19:22:30] 10MediaWiki-Categories, 10MediaWiki-Internationalization, 10Patch-For-Review: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10jeblad) Seems like this is a non-existing problem, or rather "problem does not exist in my language". Perhaps someone else can... [19:22:31] (03PS2) 10Dbrant: Fix exception handling when saving offline pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476019 [19:23:02] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Window dressing is mostly olive oil, 10I18n, 10Patch-For-Review: Make protection reason localizable, display on wiki content language - https://phabricator.wikimedia.org/T210102 (10MarcoAurelio) >>! In T210102#4775060, @And... [19:23:28] 10MediaWiki-Categories, 10MediaWiki-Internationalization: Some names like "Aachen" are sorted wrongly in Norwegian - https://phabricator.wikimedia.org/T210490 (10jeblad) [19:23:58] 10MediaWiki-User-preferences, 10MediaWiki-extensions-CentralAuth, 10OOUI: Extra margin on CentralAuth preference buttons - https://phabricator.wikimedia.org/T210534 (10kaldari) [19:24:22] 10Code-Health-Metrics, 10Epic: Code Health Metrics should enable commit and/or patch set risk assessment - https://phabricator.wikimedia.org/T210533 (10Jrbranaa) [19:24:36] 10MediaWiki-Internationalization, 10MW-1.27-release (WMF-deploy-2016-03-01_(1.27.0-wmf.15)), 10MW-1.27-release-notes: Allow soft hyphen (­) in interface messages - https://phabricator.wikimedia.org/T127062 (10jeblad) [19:25:35] 10MediaWiki-General-or-Unknown, 10Core Platform Team (Security, stability, performance and scalability (TEC1)), 10Core Platform Team Backlog (Next), 10Patch-For-Review, and 2 others: Mediawiki revision-related queries are failing with high rate for enwiki on codfw - https://phabricator.wikimedia.org/T163495... [19:25:39] (03PS2) 10Dbrant: Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 [19:26:11] 10MediaWiki-User-preferences, 10MediaWiki-extensions-CentralAuth, 10OOUI: Extra margin on CentralAuth preference buttons - https://phabricator.wikimedia.org/T210534 (10kaldari) @Volker_E - Any preference on how to fix this? [19:26:35] (03CR) 10jerkins-bot: [V: 04-1] Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 (owner: 10Dbrant) [19:26:40] (03PS2) 10Dbrant: Enable cleartext traffic in debug builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475838 [19:27:05] (03CR) 10Kaldari: [C: 032] Just a couple code comments to make it easier to follow [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476085 (owner: 10Kaldari) [19:28:25] (03PS3) 10Dbrant: Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 [19:28:59] (03PS2) 10VolkerE: SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:29:43] (03CR) 10Jforrester: [C: 04-1] Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [19:30:29] (03PS3) 10Daniel Kinzler: Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) [19:31:16] (03CR) 10jerkins-bot: [V: 04-1] Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [19:31:19] (03Merged) 10jenkins-bot: Remove $wgMintyDocsProductPages setting/requirement [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/476074 (owner: 10Yaron Koren) [19:32:05] (03CR) 10Pmiazga: [C: 04-1] Add PHPUnit tests for testing methods in ContentProviderFactory::class (035 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475754 (https://phabricator.wikimedia.org/T210400) (owner: 10D3r1ck01) [19:33:05] (03CR) 10Mooeypoo: [C: 04-1] Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [19:34:13] (03CR) 10Jforrester: "Doesn't look this is being run? Also a neat new profile system as of the new release last week. :-)" (031 comment) [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475936 (owner: 10Kosta Harlan) [19:34:33] 04(no projects): Renew jsamra's SSL cert - https://phabricator.wikimedia.org/T210536 (10Jksamra) [19:35:13] (03Merged) 10jenkins-bot: Just a couple code comments to make it easier to follow [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476085 (owner: 10Kaldari) [19:35:56] (03CR) 10Sharvaniharan: [C: 032] Fix exception handling when saving offline pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476019 (owner: 10Dbrant) [19:37:50] (03CR) 10jenkins-bot: Just a couple code comments to make it easier to follow [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/476085 (owner: 10Kaldari) [19:38:54] (03CR) 10Pmiazga: Add PHPUnit tests for methods in McsContentProvider::class (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475730 (https://phabricator.wikimedia.org/T210390) (owner: 10D3r1ck01) [19:40:33] (03PS2) 10Tchanders: Improve layout of ExpiryInputWidget on mobile [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) [19:41:07] 10CommRel-Documentation, 10Wikimedia-Technical-Conference-2018-Organization, 10CommRel-Specialists-Support (Oct-Dec-2018): Note Taking Feedback: Wikimedia Technical Conference - https://phabricator.wikimedia.org/T198988 (10Quiddity) I'm done with my part. [19:41:17] 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review, 10Schema-change, 10Stewards-and-global-tools (Temporary-UserRights): Allow global groups to be assigned temporarily (expire) - https://phabricator.wikimedia.org/T153815 (10MarcoAurelio) Thanks @Melos !!! AFAICS your change does some DB changes so I'm... [19:43:09] (03CR) 10Jforrester: "Thanks! Maybe a TODO: so we come back to this later?" [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [19:43:57] (03CR) 10Jdlrobson: [C: 032] Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [19:44:03] (03CR) 10Anomie: "> The really only thing this tests needs is some "truthy" value." [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [19:44:56] (03CR) 10VolkerE: [C: 04-1] "Looks good, tested in a wide variety of emulators in BrowserStack:" [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:45:19] (03CR) 10VolkerE: [C: 04-1] "Looks good with exception of Safari/iOS surprise…" [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:45:49] (03CR) 10Cooltey: [C: 032] Enable cleartext traffic in debug builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475838 (owner: 10Dbrant) [19:46:59] (03PS3) 10Tchanders: Improve layout of ExpiryInputWidget on mobile [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) [19:47:14] (03Merged) 10jenkins-bot: Fix exception handling when saving offline pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476019 (owner: 10Dbrant) [19:47:50] (03CR) 10Tchanders: Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [19:47:55] (03PS7) 10D3r1ck01: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) [19:48:35] (03PS5) 10Jforrester: mediawiki.util: Drop jsMessage(), deprecated since 1.20 and mostly unused [core] - 10https://gerrit.wikimedia.org/r/430951 (https://phabricator.wikimedia.org/T193901) [19:48:44] (03CR) 10Tchanders: [C: 04-1] "Awaiting decision about whether to have the tablet mode" [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [19:48:52] (03CR) 10Cooltey: [C: 032] Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 (owner: 10Dbrant) [19:49:28] (03PS1) 10Niedzielski: Hygiene: rename Cta.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476094 [19:49:42] (03CR) 10jenkins-bot: Fix exception handling when saving offline pages. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476019 (owner: 10Dbrant) [19:50:43] (03CR) 10VolkerE: [C: 04-1] "meant to write 'unsupported property value'" [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:51:21] (03CR) 10VolkerE: [C: 04-1] "Screenshot proof: https://phabricator.wikimedia.org/F27319310" [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:52:10] (03CR) 10jerkins-bot: [V: 04-1] Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [19:53:06] (03PS1) 10Niedzielski: Hygiene: remove unused prop in Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476096 [19:55:18] 10Design, 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Apply the right target when creating a missing link - https://phabricator.wikimedia.org/T197787 (10Amire80) >>! In T197787#4777911, @Pginer-WMF wrote: > Good point @Amire80. > I think it is worth exploring ways for the use... [19:55:35] 10Design, 10JADE, 10Patch-For-Review, 10Scoring-platform-team (Current): Come up with view mode for JADE pages - https://phabricator.wikimedia.org/T208819 (10Harej) [19:57:59] (03Merged) 10jenkins-bot: Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [19:58:12] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06): Translate extension language bar not reliably showing how complete a translation is - https://phabricator.wikimedia.org/T208521 (10Etonkovidova) Re-checked - the different lang page... [19:59:33] (03PS3) 10VolkerE: SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [19:59:43] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.27x-L-Lamington): Create a custom dialog that includes an image - https://phabricator.wikimedia.org/T209511 (10cmadeo) >>! In T209511#4776571, @Sharvaniharan wrote: > @cmadeo @schoenbaechler Image for the dialog is not provided in th... [20:01:31] (03CR) 10jenkins-bot: Organise src folder by feature [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475828 (https://phabricator.wikimedia.org/T207805) (owner: 10Jdlrobson) [20:01:57] (03Merged) 10jenkins-bot: Enable cleartext traffic in debug builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475838 (owner: 10Dbrant) [20:01:59] (03Merged) 10jenkins-bot: Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 (owner: 10Dbrant) [20:03:09] (03PS2) 10Brian Wolff: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) [20:03:44] (03CR) 10VolkerE: "Yeah, if we put the vendor prefix on the value and not the property as it's supposed to be, then it suddenly works." [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [20:04:11] (03CR) 10Esanders: [C: 04-1] Improve layout of ExpiryInputWidget on mobile (031 comment) [core] - 10https://gerrit.wikimedia.org/r/476048 (https://phabricator.wikimedia.org/T208271) (owner: 10Tchanders) [20:04:27] (03PS4) 10Tchanders: TitlesMultiselectWidget: display pending element [core] - 10https://gerrit.wikimedia.org/r/475121 (https://phabricator.wikimedia.org/T210080) [20:04:54] (03CR) 10jenkins-bot: Don't run the notification polling service unnecessarily. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476023 (owner: 10Dbrant) [20:04:59] 04(no projects): As a new MediaWiki user who often edits via the GUI editor, I really wish I could change text color quickly - https://phabricator.wikimedia.org/T210539 (10Rhaining23) [20:05:32] (03CR) 10jenkins-bot: Enable cleartext traffic in debug builds. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/475838 (owner: 10Dbrant) [20:06:13] (03CR) 10Brian Wolff: "The api calls the same checkUnblockSelf method for permissions" [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [20:06:34] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [Alpha] Onboarding screen text not visible in landscape - https://phabricator.wikimedia.org/T209764 (10Dbrant) 05Open>03Resolved a:03Dbrant [20:07:22] (03CR) 10Esanders: Update eslint-config-wikimedia to 0.9.0 (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [20:08:18] (03CR) 10Jforrester: [C: 032] "Selenium, you suck." [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [20:08:24] (03CR) 10Esanders: [C: 031] "Nice" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [20:08:41] (03CR) 10Esanders: [C: 031] "Is there a task for this?" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [20:09:10] (03CR) 10Anomie: [C: 031] Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [20:09:11] 04(no projects): As a new MediaWiki user who often edits via the GUI editor, I really wish I could change text color quickly - https://phabricator.wikimedia.org/T210539 (10Rhaining23) (I'm sure this has been suggested before, but I made a good faith effort to find an existing feature request like it and couldn'... [20:10:46] 04(no projects): As a new MediaWiki user who often edits via the GUI editor, I really wish I could change text color quickly - https://phabricator.wikimedia.org/T210539 (10Aklapper) Hi and welcome! [Which exact editor software is this about?](https://www.mediawiki.org/wiki/Editor) [20:11:56] (03PS3) 10DLynch: Include timing information for EditAttemptStep [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476071 (https://phabricator.wikimedia.org/T205166) [20:11:58] 10MobileFrontend, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jack_who_built_the_house) [20:12:04] 10Developer-Advocacy (Oct-Dec 2018): Create a list of GSoC/ Outreachy alums who work for WMF or are active in the volunteer community - https://phabricator.wikimedia.org/T209894 (10srishakatux) Sent email to ~22 former GSoC / Outreachy who are possibly active in Wikimedia asking to write a blurb outlining their... [20:13:50] (03PS1) 10DLynch: Debug flag for EditAttemptStep tracking [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 [20:14:13] (03PS5) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) [20:14:55] 10MobileFrontend, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jack_who_built_the_house) [20:15:24] (03CR) 10Zoranzoki21: "I done some things. Jforrester, how it should be included in file? What is expected?" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [20:15:33] 10MinervaNeue, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Spike: [Spike, 2hrs] Identify the problem with the toast notification tests on the beta cluster - https://phabricator.wikimedia.org/T208808 (10Jdlrobson) a:05J... [20:15:36] 10MobileFrontend, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jack_who_built_the_house) [20:16:51] (03CR) 10Jdlrobson: [C: 031] "this patch looks great." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475831 (https://phabricator.wikimedia.org/T188451) (owner: 10LukBukkit) [20:17:21] 04(no projects): As a new MediaWiki user who often edits via the GUI editor, I really wish I could change text color quickly - https://phabricator.wikimedia.org/T210539 (10Rhaining23) The wiki site is gamepedia.com. On the page you linked, the picture for "2017 wikitext editor" looks like the correct one. [20:17:47] 04(no projects): As a new MediaWiki user who often edits via the GUI editor, I really wish I could change text color quickly - https://phabricator.wikimedia.org/T210539 (10Rhaining23) (And thanks for the prompt response!!) [20:18:07] (03PS4) 10Jdlrobson: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [20:19:45] (03PS4) 10VolkerE: SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [20:20:25] (03CR) 10VolkerE: [C: 031] SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [20:21:34] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Community-Wishlist-Survey-2015, 10I18n: Make PageTriage wiki agnostic - https://phabricator.wikimedia.org/T50552 (10kaldari) [20:22:01] 10MediaWiki-Installer: When $wgDBprefix is not set, the updater should not use a table prefix (leads to "Error: 1146 Table doesn't exist") - https://phabricator.wikimedia.org/T210524 (10Aklapper) [20:25:47] (03PS5) 10Jdlrobson: Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) [20:26:17] (03CR) 10jerkins-bot: [V: 04-1] Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [20:27:06] (03PS1) 10VolkerE: ApiSandbox: Fix sticky value for Webkit [core] - 10https://gerrit.wikimedia.org/r/476102 [20:27:18] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) Tested on https://en.m.wikipedia.org... [20:27:26] (03CR) 10jerkins-bot: [V: 04-1] Update eslint-config-wikimedia to 0.9.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [20:27:31] (03PS2) 10Jdlrobson: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 [20:27:31] 10Google-Code-in-2018, 10MinervaNeue, 10Wikimedia-Site-requests, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 3 others: AMC: wgMFSchemaMainMenuClickTrackingSampleRate should be set in production not MobileFrontend - https://phabricator.wikimedia.org/T205008 (10nray) 05Open>03Resolved [20:27:34] 10MediaWiki-Categories, 10MediaWiki-Special-pages, 10Commons: Magic word __EXPECTUNUSEDCATEGORY__ should not be displayed on the page - https://phabricator.wikimedia.org/T210496 (10Dinoguy1000) [20:27:57] (03CR) 10jerkins-bot: [V: 04-1] Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [20:31:37] 10MediaWiki-extensions-Html2Wiki: Html2Wiki hangs up and does not convert the file - https://phabricator.wikimedia.org/T209862 (10Aklapper) >>! In T209862#4777597, @Sferg008 wrote: > Up! This is not some internet forum or support channel, but a database to track issues. Please refrain from such postings. Thanks... [20:35:39] (03CR) 10Dmaza: [C: 032] Don't indicate partial blocks on Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/475486 (owner: 10Tchanders) [20:35:43] (03PS3) 10Jdlrobson: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 [20:35:59] 10Design, 10JADE, 10Scoring-platform-team (Current): Discuss and create a UI mockup for the JADE editor interface - https://phabricator.wikimedia.org/T168993 (10Harej) [20:36:40] (03PS2) 10Jdlrobson: Hygiene: rename Cta.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476094 (owner: 10Niedzielski) [20:37:20] (03CR) 10Jdlrobson: [C: 032] Hygiene: rename Cta.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476094 (owner: 10Niedzielski) [20:37:34] I think this task should be removed: https://codein.withgoogle.com/tasks/6268937055502336/?sp-organization=4956074911203328&sp-is_beginner=False. It asks to fix mediawiki/extensions/ConfirmAccount/business/AccountConfirmSubmission.php, and it's ony call is $article = new WikiPage( $user->getTalkPage() );. $user is of User type, so this does not need to be fixed. [20:43:19] I'll look into it pterp [20:43:38] ping mholloway [20:43:59] (03CR) 10Jack Phoenix: [C: 04-1] "A super minor nitpick inline, once that's fixed I'll gladly +2 this!" (031 comment) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/475803 (https://phabricator.wikimedia.org/T210429) (owner: 10Alexia) [20:44:04] (03CR) 10Anomie: [C: 031] Migrate Api modules from tag_summary table to change_tag [core] - 10https://gerrit.wikimedia.org/r/476058 (https://phabricator.wikimedia.org/T209525) (owner: 10Ladsgroup) [20:45:03] (03CR) 10Jdlrobson: Debug flag for EditAttemptStep tracking (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476099 (owner: 10DLynch) [20:48:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [20:49:23] 10Design, 10JADE, 10Scoring-platform-team: Create overlay UI for editing Judgement pages - https://phabricator.wikimedia.org/T199128 (10Harej) p:05Low>03Normal [20:49:35] 10Design, 10JADE, 10Scoring-platform-team: Create overlay UI for editing Judgement pages - https://phabricator.wikimedia.org/T199128 (10Harej) [20:49:40] (03CR) 10Anomie: "Code-Review-1" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [20:51:57] (03CR) 10Anomie: [C: 031] Simplify APIParseExtender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [20:52:04] (03PS2) 10Jdlrobson: Hygiene: remove unused prop in Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476096 (owner: 10Niedzielski) [20:52:06] (03PS1) 10Jdlrobson: DRYing things up: cancelButton helper [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476103 [20:52:14] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove unused prop in Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476096 (owner: 10Niedzielski) [20:52:35] (03PS1) 10Pjht: Check that the page has a talk page before calling Title::getTalkPage [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 [20:52:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Looks very nice!" [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [20:53:31] (03PS3) 10Jdlrobson: Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 (owner: 10Niedzielski) [20:53:33] (03CR) 10Jdlrobson: [C: 032] Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 (owner: 10Niedzielski) [20:53:40] (03CR) 10Jdlrobson: [C: 032] Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 (owner: 10Niedzielski) [20:53:55] (03PS5) 10Jdlrobson: Remove TalkOverlayBase and a level of inheritance [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/469535 [20:54:48] (03PS6) 10Jdlrobson: Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) [20:54:50] (03CR) 10D3r1ck01: "> Is there somebody else actively working on this extension who want's to have a look?" [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/476045 (owner: 10D3r1ck01) [20:55:16] (03CR) 10Jdlrobson: [C: 031] "will rebase when the other +2s have gone to merge-ville." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [20:58:09] (03CR) 10Thiemo Kreuz (WMDE): ApiSandbox: Resize layout to fit content, and remove fullscreen mode (031 comment) [core] - 10https://gerrit.wikimedia.org/r/428641 (https://phabricator.wikimedia.org/T129157) (owner: 10Esanders) [20:59:11] (03CR) 10Pmiazga: [C: 04-1] Don't pollute the MediaWiki global in tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [20:59:27] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Image license info often displays the 'uploader unknown' incorrectly - https://phabricator.wikimedia.org/T210544 (10ABorbaWMF) [20:59:30] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Introduced via Ia3c3176 about 7 months ago. Caniuse.com says "position: sticky" must be prefixed, but doesn't say what must be prefixed. I" [core] - 10https://gerrit.wikimedia.org/r/476102 (owner: 10VolkerE) [20:59:41] (03Merged) 10jenkins-bot: Don't indicate partial blocks on Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/475486 (owner: 10Tchanders) [20:59:43] (03Merged) 10jenkins-bot: Hygiene: rename Cta.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476094 (owner: 10Niedzielski) [21:00:50] 10MobileFrontend, 10Russian-Sites: In ruwiki, on mobile, hatnotes sometimes go after the first paragraph - https://phabricator.wikimedia.org/T210540 (10Jack_who_built_the_house) [21:01:02] 10Security-Team, 10Security: SQL injection attacks showing up in webrequest logs - https://phabricator.wikimedia.org/T208474 (10sbassett) 05Open>03Resolved p:05High>03Normal a:03sbassett Hey Jon- Thanks for reporting this and sorry for the delay in response. The #security-team discussed this today... [21:01:03] 10Security-Team, 10Security: SQL injection attacks showing up in webrequest logs - https://phabricator.wikimedia.org/T208474 (10sbassett) [21:01:47] (03CR) 10Jforrester: [C: 032] "…" [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [21:04:06] 10MediaWiki-extensions-UsabilityInitiative, 10Tracking: "Babaco" release of the Usability Initiative (tracking) - https://phabricator.wikimedia.org/T38111 (10Jdforrester-WMF) [21:04:11] d3r1ck: framawiki: Submitted a patch, could you review it please? https://gerrit.wikimedia.org/r/c/pywikibot/core/+/476106 [21:04:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/476105 (owner: 10L10n-bot) [21:04:56] (03CR) 10Anomie: Do not ignore the 'Prevent this user from editing his own talk page while blocked' option on partial blocks. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475952 (https://phabricator.wikimedia.org/T210475) (owner: 10Dbarratt) [21:05:09] 10MediaWiki-extensions-UsabilityInitiative, 10Tracking: "Babaco" release of the Usability Initiative (tracking) - https://phabricator.wikimedia.org/T38111 (10Jdforrester-WMF) [21:05:18] 10MediaWiki-extensions-Drafts: Insert Links : Link suggestions are not refreshed in Safari - https://phabricator.wikimedia.org/T22866 (10Jdforrester-WMF) [21:05:20] 10MediaWiki-extensions-UsabilityInitiative, 10Tracking: "Babaco" release of the Usability Initiative (tracking) - https://phabricator.wikimedia.org/T38111 (10Jdforrester-WMF) [21:05:30] 10MediaWiki-extensions-UsabilityInitiative, 10Tracking: "Babaco" release of the Usability Initiative (tracking) - https://phabricator.wikimedia.org/T38111 (10Jdforrester-WMF) [21:05:32] 10MediaWiki-Parser: "Insert Table" in WikiEditor: High column count makes table go out of boundary - https://phabricator.wikimedia.org/T23408 (10Jdforrester-WMF) [21:05:42] (03CR) 10jenkins-bot: Don't indicate partial blocks on Special:ListUsers [core] - 10https://gerrit.wikimedia.org/r/475486 (owner: 10Tchanders) [21:05:46] (03CR) 10jenkins-bot: Hygiene: rename Cta.hogan [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476094 (owner: 10Niedzielski) [21:06:00] (03PS1) 10EBernhardson: Include commonswiki_file in query_clicks tables [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476110 [21:06:02] (03PS1) 10EBernhardson: Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 [21:06:17] (03CR) 10jerkins-bot: [V: 04-1] Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (owner: 10EBernhardson) [21:06:19] (03CR) 10jerkins-bot: [V: 04-1] Include commonswiki_file in query_clicks tables [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476110 (owner: 10EBernhardson) [21:06:46] 04(no projects): Repair transfer_to_es analytics job - https://phabricator.wikimedia.org/T210545 (10EBernhardson) [21:06:58] 10Discovery-Search (Current work): Repair transfer_to_es analytics job - https://phabricator.wikimedia.org/T210545 (10EBernhardson) [21:07:00] 10MediaWiki-Parser: "Insert Table" in WikiEditor: High column count makes table go out of boundary - https://phabricator.wikimedia.org/T23408 (10Jdforrester-WMF) 05Open>03declined I'm Declining this as though I agree that a very wide table is not good, I don't think we should add code in the 2010 wikitext ed... [21:07:38] (03PS2) 10EBernhardson: Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (https://phabricator.wikimedia.org/T210545) [21:07:55] (03CR) 10jerkins-bot: [V: 04-1] Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (https://phabricator.wikimedia.org/T210545) (owner: 10EBernhardson) [21:08:17] 10Discovery-Search (Current work), 10Patch-For-Review: Configure LVS endpoints for new elasticsearch clusters - https://phabricator.wikimedia.org/T207195 (10EBernhardson) a:03Gehel [21:08:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476107 (owner: 10L10n-bot) [21:10:23] (03CR) 10Jforrester: "> Patch Set 5:" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:10:39] (03CR) 10Mholloway: [C: 04-1] "Don't uncomment commented-out lines with this change; rather, just expand the comments with your conditional blocks." [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 (owner: 10Pjht) [21:10:47] (03CR) 10Anomie: "Two typos left, otherwise I think this looks good enough." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/434544 (https://phabricator.wikimedia.org/T194046) (owner: 10Daniel Kinzler) [21:12:45] (03PS4) 10TheDJ: Editor: Use flexbox to position the elements evenly [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475222 (https://phabricator.wikimedia.org/T209939) [21:13:01] (03PS3) 10EBernhardson: Make transfer_to_es work with cdh5.15 [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476111 (https://phabricator.wikimedia.org/T210545) [21:13:03] (03PS1) 10EBernhardson: Correct regex escaping [wikimedia/discovery/analytics] - 10https://gerrit.wikimedia.org/r/476112 [21:13:27] (03CR) 10Jforrester: [C: 032] SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [21:13:27] 10MediaWiki-Core-Tests, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Q1 Selenium framework improvements - https://phabricator.wikimedia.org/T198389 (10greg) [21:14:02] 10Design, 10MediaWiki-User-preferences, 10UI-Standardization: Improve Special:Preferences UI/UX - https://phabricator.wikimedia.org/T180538 (10Jdforrester-WMF) [21:14:05] 10MediaWiki-User-preferences: Make save button more visible on Special:Preferences - https://phabricator.wikimedia.org/T205866 (10Jdforrester-WMF) 05Open>03Resolved a:03Esanders [21:14:19] (03PS6) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) [21:14:41] 10Design, 10MediaWiki-User-preferences, 10UI-Standardization: Improve Special:Preferences UI/UX - https://phabricator.wikimedia.org/T180538 (10Jdforrester-WMF) [21:14:56] (03Merged) 10jenkins-bot: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [21:15:03] (03PS7) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) [21:15:25] (03CR) 10Zoranzoki21: "> > Patch Set 5:" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:15:55] (03CR) 10TheDJ: Editor: Use flexbox to position the elements evenly (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475222 (https://phabricator.wikimedia.org/T209939) (owner: 10TheDJ) [21:18:23] (03CR) 10jenkins-bot: Fix global variable name typo in LocalIdLookupTest.php [core] - 10https://gerrit.wikimedia.org/r/476041 (https://phabricator.wikimedia.org/T210512) (owner: 10D3r1ck01) [21:18:28] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476113 (owner: 10L10n-bot) [21:19:18] (03PS1) 10Yaron Koren: Add quoting of DB index names [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/476139 [21:19:27] 10Research: Identify and release data on similar Wikidata items - https://phabricator.wikimedia.org/T210433 (10bmansurov) @diego how can I easily stratify this data? I was hoping that we could eyeball the results. I know that some of the results don't make sense and that's because we're only relying on item desc... [21:19:52] (03PS2) 10Pjht: Check that the page has a talk page before calling Title::getTalkPage [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 [21:20:36] (03Merged) 10jenkins-bot: Hygiene: remove unused prop in Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476096 (owner: 10Niedzielski) [21:20:39] (03Merged) 10jenkins-bot: Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 (owner: 10Niedzielski) [21:20:44] (03Merged) 10jenkins-bot: ApiSandbox: Fix sticky value for Webkit [core] - 10https://gerrit.wikimedia.org/r/476102 (owner: 10VolkerE) [21:21:33] (03CR) 10Tpt: [C: 032] "Thank you!" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475222 (https://phabricator.wikimedia.org/T209939) (owner: 10TheDJ) [21:21:59] (03CR) 10Nray: "Could we remove mw.config.set entirely from mockMediaWiki? I only see it being used now in TalkOverlay.test.js which seems like it could u" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [21:23:00] (03CR) 10TheDJ: "Not really. I actually started off on https://phabricator.wikimedia.org/T137541" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [21:23:23] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:24:24] (03CR) 10jenkins-bot: ApiSandbox: Fix sticky value for Webkit [core] - 10https://gerrit.wikimedia.org/r/476102 (owner: 10VolkerE) [21:25:26] (03PS8) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) [21:26:19] (03PS2) 10Jdlrobson: Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [21:26:42] (03CR) 10Mholloway: [C: 04-1] "Almost there. Thanks for the whitespace cleanup, too!" (031 comment) [extensions/Favorites] - 10https://gerrit.wikimedia.org/r/476104 (owner: 10Pjht) [21:26:54] (03PS3) 10Jdlrobson: Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [21:27:37] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10cscott) [21:28:26] 04(no projects): test - https://phabricator.wikimedia.org/T210514 (10Aklapper) 05Resolved>03Invalid [21:28:43] (03CR) 10Jdlrobson: [C: 04-1] "> In eslint-config-wikimedia 0.9.0 we introduce the wikimedia/jquery ruleset. This ruleset defines the '$' global, which can't be overridd" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [21:29:29] (03CR) 10Jdlrobson: [C: 032] Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [21:29:39] 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: A/B testing plan for wbsearchentities, context=item - https://phabricator.wikimedia.org/T209402 (10EBernhardson) [21:29:50] (03CR) 10Zoranzoki21: "What`s wrong:" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:30:19] 10Discovery-Search (Current work), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review: A/B testing plan for wbsearchentities, context=item - https://phabricator.wikimedia.org/T209402 (10EBernhardson) This should be all ready to go. Will need to SWAT out the AB testing code from WikimediaEvents al... [21:30:23] (03CR) 10jerkins-bot: [V: 04-1] build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:30:39] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10cscott) As an example, PHP `var_export` says the raw value is: ` 'kartographer' => ' � ' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . '' . "\0" . ' E... [21:32:00] 10MediaWiki-API: The Action API should allow input in JSON - https://phabricator.wikimedia.org/T210107 (10Anomie) >>! In T210107#4766880, @dbarratt wrote: > It's a key/value store that could be anything (scalars, arrays, objects, array of objects, etc.) basically anything you can represent in JSON (which is prob... [21:32:39] 10ContentTranslation, 10Language-Team (Language-2018-October-December): CX2: Invite Czech Wikipedia to try version 2 - https://phabricator.wikimedia.org/T210385 (10Amire80) [21:32:50] (03CR) 10Jforrester: "Sorry, you also need to remove the obsolete aliases from the JS files (in this case, there's just dismissableSiteNotice.js), like Ed did i" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:33:54] (03PS1) 10C. Scott Ananian: Protect legacy URL parameter syntax in link and alt options [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) [21:34:04] (03CR) 10Jgleeson: [V: 031 C: 031] "As discussed on IRC, code looks good but will wait until https://phabricator.wikimedia.org/T209413 is up to test all 3 patches combined." [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/475244 (owner: 10Ejegg) [21:34:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/476119 (owner: 10L10n-bot) [21:34:38] (03CR) 10C. Scott Ananian: "Cherry-picked fix for UBN bug which narrowly missed the 1.33.wmf.6 branch. Should ride this week's train." [core] (wmf/1.33.0-wmf.6) - 10https://gerrit.wikimedia.org/r/476145 (https://phabricator.wikimedia.org/T209236) (owner: 10C. Scott Ananian) [21:36:13] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10Jdforrester-WMF) Presumably this also is broken for TemplateData when that page prop is gzipped? [21:36:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/476124 (owner: 10L10n-bot) [21:37:58] (03PS4) 10Jdlrobson: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 [21:38:03] (03CR) 10Jdlrobson: Don't pollute the MediaWiki global in tests (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [21:39:55] (03Merged) 10jenkins-bot: SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [21:39:57] (03Merged) 10jenkins-bot: Editor: Use flexbox to position the elements evenly [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475222 (https://phabricator.wikimedia.org/T209939) (owner: 10TheDJ) [21:41:10] (03CR) 10jerkins-bot: [V: 04-1] Update eslint-config-wikimedia to 0.9.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/476090 (owner: 10Esanders) [21:41:12] (03PS9) 10Zoranzoki21: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) [21:41:22] (03CR) 10Zoranzoki21: "> Sorry, you also need to remove the obsolete aliases from the JS" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:41:33] (03CR) 10Niedzielski: [C: 032] Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [21:42:18] (03CR) 10jenkins-bot: SpecialPreferences: Make save button bar sticky [core] - 10https://gerrit.wikimedia.org/r/471956 (https://phabricator.wikimedia.org/T205866) (owner: 10Esanders) [21:42:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476122 (owner: 10L10n-bot) [21:43:39] (03Merged) 10jenkins-bot: Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [21:44:09] (03CR) 10Esanders: [C: 031] "Seems like a big enough change." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474821 (owner: 10TheDJ) [21:45:09] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10Anomie) The API isn't really designed to return binary data. I'm not sure whether client libraries would handle it properly or if they too would somehow blow up whe... [21:45:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476127 (owner: 10L10n-bot) [21:47:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/476125 (owner: 10L10n-bot) [21:49:19] (03CR) 10Jforrester: [C: 032] "Wonderful. Thank you!" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [21:50:22] (03CR) 10jerkins-bot: [V: 04-1] Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [21:52:24] (03PS4) 10Daniel Kinzler: Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) [21:54:51] (03CR) 10jenkins-bot: Fix: tear down jQuery in Browser, OverlayManager, PageGateway [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476047 (owner: 10Niedzielski) [21:55:24] (03CR) 10Niedzielski: [C: 04-1] "> In eslint-config-wikimedia 0.9.0 we introduce the wikimedia/jquery ruleset. This ruleset defines the '$' global, which can't be overridd" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474282 (https://phabricator.wikimedia.org/T208951) (owner: 10Esanders) [21:55:38] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Page curation (rfd) creates an error message - https://phabricator.wikimedia.org/T194826 (10Etonkovidova) 05Open>... [21:55:57] (03CR) 10Nray: [C: 031] "latest patch lgtm, but will wait on Piotr's response to see if he's good with it" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 (owner: 10Jdlrobson) [21:57:02] (03PS1) 10Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 [21:57:13] (03CR) 10Ejegg: [C: 032] update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 (owner: 10Ejegg) [21:57:31] (03PS2) 10Ejegg: update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 [21:58:00] (03PS7) 10Niedzielski: Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [21:58:22] (03CR) 10Niedzielski: [C: 032] Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [21:58:24] (03CR) 10jenkins-bot: Hygiene: remove unused prop in Drawer [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476096 (owner: 10Niedzielski) [21:58:38] 10MediaWiki-extensions-Page_Forms, 10Browser-Support-Internet-Explorer: Semantic Forms, HeaderTabs and WikiEditor not working together well with IE - https://phabricator.wikimedia.org/T68201 (10TheDJ) [21:59:17] 10MediaWiki-extensions-Page_Forms, 10Browser-Support-Internet-Explorer: Semantic Forms, HeaderTabs and WikiEditor not working together well with IE - https://phabricator.wikimedia.org/T68201 (10TheDJ) This was only with IE8/9 right ? So i guess it could be closed ? [21:59:42] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476152 [22:00:39] (03Merged) 10jenkins-bot: build: Replace jshint/jscs with eslint & stylelint [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/475841 (https://phabricator.wikimedia.org/T210365) (owner: 10Zoranzoki21) [22:01:34] (03PS41) 10Daniel Kinzler: [MCR] Introduce SlotRoleHandler and SlotRoleRegistry [core] - 10https://gerrit.wikimedia.org/r/434544 (https://phabricator.wikimedia.org/T194046) [22:01:36] (03CR) 10jenkins-bot: Hygiene: remove unneeded local in mobile.startup [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/476042 (owner: 10Niedzielski) [22:01:40] (03CR) 10Dmaza: [C: 04-1] Don't indicate partial blocks on Special:ActiveUsers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475738 (https://phabricator.wikimedia.org/T210391) (owner: 10Tchanders) [22:02:20] (03CR) 10Daniel Kinzler: [MCR] Introduce SlotRoleHandler and SlotRoleRegistry (032 comments) [core] - 10https://gerrit.wikimedia.org/r/434544 (https://phabricator.wikimedia.org/T194046) (owner: 10Daniel Kinzler) [22:02:31] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476152 (owner: 10Esanders) [22:02:40] (03PS1) 10Dbrant: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476153 [22:02:50] (03CR) 10Dbrant: [C: 032] Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476153 (owner: 10Dbrant) [22:03:05] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/3D] - 10https://gerrit.wikimedia.org/r/476087 (owner: 10Esanders) [22:03:26] (03CR) 10jerkins-bot: [V: 04-1] update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 (owner: 10Ejegg) [22:04:07] 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MinervaNeue (Desktop), 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): AMC: Fix MobileWebMainMenuClickTracking schema for Minerva desktop to avoid errors - https://phabricator.wikimedia.org/T193505 (10Aklapper) [22:04:33] 10MediaWiki-extensions-Page_Forms, 10WikiEditor: Toolbar buttons that invoke dialogs insert text into incorrect text areas when there is more than one WikiEditor on a page - https://phabricator.wikimedia.org/T103772 (10TheDJ) >>! In T103772#3913636, @Seb35 wrote: > Could someone more knowlegeable in JS and Wik... [22:04:44] 10OOUI: DropdownInputWidget: In non-JS, focus state border is missing on the right side - https://phabricator.wikimedia.org/T194523 (10Volker_E) [22:04:47] 10Design, 10MediaWiki-User-preferences, 10UI-Standardization: Improve Special:Preferences UI/UX - https://phabricator.wikimedia.org/T180538 (10Volker_E) [22:05:14] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [22:05:47] (03PS5) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:06:01] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:06:11] (03CR) 10jenkins-bot: Editor: Use flexbox to position the elements evenly [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475222 (https://phabricator.wikimedia.org/T209939) (owner: 10TheDJ) [22:06:26] 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10Patch-For-Review: Replace usage of jshint and/or jscs with eslint in MediaWiki extensions (clonable) - https://phabricator.wikimedia.org/T210365 (10Legoktm) [22:06:48] 10MediaWiki-User-preferences: move editing/labs preference section out of WikiEditor and into Core - https://phabricator.wikimedia.org/T30955 (10TheDJ) 05Open>03Invalid We now have #betafeatures but WikiEditor no longer has any labs modules, so this ticket is no longer valid or resolved. however you want to... [22:09:09] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476154 [22:09:12] 10Page-Issue-Warnings, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Prepare selenium browser test for page issues A/B test - https://phabricator.wikimedia.org/T206647 (10nray) Good news: I haven't noticed any test failures... [22:10:09] (03PS6) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:13:25] (03CR) 10Ejegg: [C: 032] update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 (owner: 10Ejegg) [22:13:47] (03PS3) 10Brian Wolff: Allow users to block the user that blocked them. [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) [22:14:45] (03PS1) 10Jdlrobson: Upgrade mediawiki selenium packages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476157 [22:15:22] (03Merged) 10jenkins-bot: Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [22:15:24] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/476152 (owner: 10Esanders) [22:15:26] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/3D] - 10https://gerrit.wikimedia.org/r/476087 (owner: 10Esanders) [22:15:28] (03CR) 10jerkins-bot: [V: 04-1] Update eslint-config-wikimedia to 0.9.0 [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/476076 (owner: 10Esanders) [22:16:18] 10Accessibility, 10WikiEditor: WikiEditor: Provide some basic formatting and action keyboard shortcut commands - https://phabricator.wikimedia.org/T62928 (10TheDJ) I think it is very unlikely this will ever be added to #wikieditor, now that we have #visualeditor-mediawiki-2017wikitexteditor providing this func... [22:16:38] (03PS5) 10Alexia: Update to use OOUI JS button and inputs to fix out of place button. [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/475803 (https://phabricator.wikimedia.org/T210429) [22:16:42] (03Merged) 10jenkins-bot: update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/476151 (owner: 10Ejegg) [22:16:57] (03PS7) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:17:20] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:17:32] (03PS11) 10Jdlrobson: Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) [22:17:48] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis but enwiki - https://phabricator.wikimedia.org/T210553 (10ovasileva) p:05Triage>03Normal [22:18:16] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis but enwiki - https://phabricator.wikimedia.org/T210553 (10ovasileva) [22:18:18] 10Product-Analytics, 10Reading-analysis, 10Readers-Web-Backlog (Tracking): Analyze results of page issues A/B test - https://phabricator.wikimedia.org/T200794 (10ovasileva) [22:18:45] (03Merged) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476153 (owner: 10Dbrant) [22:18:47] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis (except enwiki) - https://phabricator.wikimedia.org/T210553 (10ovasileva) [22:19:35] 10Design, 10JADE, 10Scoring-platform-team: Create overlay UI for editing Judgement pages - https://phabricator.wikimedia.org/T199128 (10awight) [22:20:02] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to enwiki - https://phabricator.wikimedia.org/T210554 (10ovasileva) p:05Triage>03Normal [22:20:42] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog: Make page issue class names configurable so we are not English-Wikipedia centric - https://phabricator.wikimedia.org/T201975 (10ovasileva) [22:20:44] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis (except enwiki) - https://phabricator.wikimedia.org/T210553 (10ovasileva) [22:20:57] (03CR) 10jenkins-bot: Remove the user object from MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475139 (https://phabricator.wikimedia.org/T204866) (owner: 10Jdlrobson) [22:21:23] (03CR) 10jenkins-bot: Bump versionCode [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476153 (owner: 10Dbrant) [22:22:34] 10Design, 10JADE, 10Scoring-platform-team: Create overlay UI for editing Judgement pages - https://phabricator.wikimedia.org/T199128 (10awight) [22:22:41] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10ovasileva) [22:22:43] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis (except enwiki) - https://phabricator.wikimedia.org/T210553 (10ovasileva) [22:24:40] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476159 [22:24:53] (03PS8) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:25:09] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:25:13] 10Page-Issue-Warnings, 10Readers-Web-Backlog: Deploy page issues to all wikis (except enwiki) - https://phabricator.wikimedia.org/T210553 (10ovasileva) [22:25:19] (03CR) 10Alexia: ">" (031 comment) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/475803 (https://phabricator.wikimedia.org/T210429) (owner: 10Alexia) [22:27:06] 10MediaWiki-extensions-Other, 10Patch-For-Review: DeleteBatch overwrites the global $wgUser context causing errors and session collisions. - https://phabricator.wikimedia.org/T210453 (10Alexia) @ashley: You might be interested in this one since you were working on it recently. [22:27:26] framawiki: umm, could you take a quick look at my comments? https://gerrit.wikimedia.org/r/c/pywikibot/core/+/476106 [22:27:54] Because xqt says that I need to indent fixing_redirects.py:120 by 2 spaces [22:28:33] but it causes `[flake8] continuation line over-indented for visual indent [E127]` [22:28:43] @d3r1ck [22:29:29] (03CR) 10Jack Phoenix: [C: 032] Update to use OOUI JS button and inputs to fix out of place button. [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/475803 (https://phabricator.wikimedia.org/T210429) (owner: 10Alexia) [22:31:24] (03CR) 10jerkins-bot: [V: 04-1] Upgrade mediawiki selenium packages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476157 (owner: 10Jdlrobson) [22:31:42] (03CR) 10Jack Phoenix: [C: 032] "Thanks! This code is super old (like from 2006 or so) and it shows in quite a few places, because back then overriding the global variable" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/475839 (https://phabricator.wikimedia.org/T210453) (owner: 10Alexia) [22:32:39] (03PS1) 10Legoktm: Remove unnecessary // eslint-disable-next-line dot-notation [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/476162 [22:34:21] (03Merged) 10jenkins-bot: Update to use OOUI JS button and inputs to fix out of place button. [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/475803 (https://phabricator.wikimedia.org/T210429) (owner: 10Alexia) [22:34:32] (03PS9) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:34:34] (03CR) 10Dmaza: "> Patch Set 3:" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/472375 (https://phabricator.wikimedia.org/T201718) (owner: 10Dmaza) [22:34:45] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:35:53] (03PS10) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:36:06] (03CR) 10jerkins-bot: [V: 04-1] Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [22:36:57] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [core] - 10https://gerrit.wikimedia.org/r/476163 (https://phabricator.wikimedia.org/T210552) [22:37:13] 10MediaWiki-extensions-PageAssessments, 10Timeless: Special:PageAssessments project form field autocomplete ends up in the main search box's autocomplete when using Timeless skin - https://phabricator.wikimedia.org/T210321 (10Isarra) Okay, so they're both class=suggestions, which is fine, except there are also... [22:37:19] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476159 (owner: 10Esanders) [22:37:22] 10MediaWiki-extensions-Drafts, 10Patch-For-Review: Update to use OOUI JS button and inputs to fix out of place button. - https://phabricator.wikimedia.org/T210429 (10Alexia) 05Open>03Resolved [22:37:37] 10MediaWiki-extensions-Other, 10Patch-For-Review: DeleteBatch overwrites the global $wgUser context causing errors and session collisions. - https://phabricator.wikimedia.org/T210453 (10Alexia) 05Open>03Resolved [22:38:24] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule [core] - 10https://gerrit.wikimedia.org/r/476163 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:38:39] (03Merged) 10jenkins-bot: Do not override the global $wgUser. Just pass the deleting user to the doDeleteArticle() function. Actually use the system message username for user creation. [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/475839 (https://phabricator.wikimedia.org/T210453) (owner: 10Alexia) [22:40:38] (03PS1) 10Legoktm: Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 [22:40:42] 10MediaWiki-Internationalization: Image alignment dropdown options in WikiEditor are not localized correctly in Chechen wikipedia - https://phabricator.wikimedia.org/T196784 (10TheDJ) i don't think magicwords are still translated via those messages in translatewiki.net.... ping @Nikerabbit [22:41:11] 10Google-Code-in-2018, 10International-Developer-Events: Design a sticker: Don't fix it because you should, fix it because you might be the only one who can. - https://phabricator.wikimedia.org/T206249 (10Aryanmediratta) {F27319785} [22:42:10] 10MediaWiki-API, 10Maps (Kartographer): gzip-encoded page properties can't be exported from the API - https://phabricator.wikimedia.org/T210548 (10cscott) Probably the most straightforward solution would be to deprecate the "properties" value in ApiParse.php and replace it with a "binProperties" value which is... [22:48:00] 10MediaWiki-extensions-General, 10Front-end-Standards-Group: Set root: true in eslintrc.json - https://phabricator.wikimedia.org/T206485 (10Legoktm) a:03Legoktm [22:48:29] (03CR) 10Jforrester: [C: 031] Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 (owner: 10Legoktm) [22:48:48] (03PS1) 10Esanders: eslint: Drop 'dot-notation' rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476167 (https://phabricator.wikimedia.org/T210552) [22:48:51] (03PS1) 10Esanders: Update eslint-config-wikimedia to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476168 [22:48:55] (03PS1) 10Jdlrobson: Provide some recommended (opt-in classes) for projects not opted into page issues [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476169 (https://phabricator.wikimedia.org/T206177) [22:49:11] 10Design, 10Page-Issue-Warnings, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10Technical-Debt: Page issues: Simplify class selectors we support to provide more sustainable support for severity parsing - https://phabricator.wikimedia.org/T206177 (10Jdlrobson) [22:49:21] (03PS11) 10Jdrewniak: Moving Watchstar, WatchstarGateway & WatchstarPagelist to webpack [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) [22:49:28] (03PS1) 10C. Scott Ananian: Don't silently fail if API result fails to encode [core] - 10https://gerrit.wikimedia.org/r/476170 [22:49:54] 10SVG Translate Tool: Show message when loading an SVG with no translations - https://phabricator.wikimedia.org/T210218 (10Niharika) @Prtksxna Assigning this to you. I think Sam's proposed solution above in the description is great. Let's get a design for it. Open to hear other ideas too, of course. :) [22:49:59] (03PS2) 10Jdlrobson: Every ambox has its own issue and icon [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475030 (https://phabricator.wikimedia.org/T202349) [22:50:39] 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Spike 8hrs] Page issues: When a page has multiple issue boxes but doesn't use multiple issues template, the icon is shared across all issues boxes. - https://phabricator.wikimedia.org/T202349 (10Jdlrobson) [22:53:08] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476154 (owner: 10Esanders) [22:53:19] (03CR) 10Jforrester: [C: 032] eslint: Drop 'dot-notation' rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476167 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [22:53:55] (03CR) 10Jforrester: [C: 032] Update eslint-config-wikimedia to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476168 (owner: 10Esanders) [22:54:38] (03CR) 10jerkins-bot: [V: 04-1] Move handlebars-v3.0.0.js out of vendor/ [extensions/Flow] - 10https://gerrit.wikimedia.org/r/476164 (owner: 10Legoktm) [22:54:51] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/476159 (owner: 10Esanders) [22:56:02] (03PS3) 10Jforrester: Set editfont size to 16px (100%) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/423530 (owner: 10Esanders) [22:58:33] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [core] - 10https://gerrit.wikimedia.org/r/476163 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:00:42] q [23:00:58] (03PS4) 10Melos: Allow global groups to be assigned temporarily [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475930 (https://phabricator.wikimedia.org/T153815) [23:01:25] thedj: You're wonderful, BTW. [23:02:01] 10Product-Analytics, 10VisualEditor (Current work): Clarification on mobile editing stats - https://phabricator.wikimedia.org/T210556 (10DannyH) [23:02:24] 10Android-app-Bugs, 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Get invisible lead image when continuing open articles from trending list - https://phabricator.wikimedia.org/T208910 (10ABorbaWMF) On 2.7.266-alpha-2018-11-27 I am... [23:02:35] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10Patch-For-Review: Browser tests for TemplateWizard - https://phabricator.wikimedia.org/T199580 (10Mooeypoo) 05Open>03Resolved [23:02:49] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/wikihiero] - 10https://gerrit.wikimedia.org/r/476154 (owner: 10Esanders) [23:02:52] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [core] - 10https://gerrit.wikimedia.org/r/476163 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:03:58] James_F: too kind, i'm just doing some dredging in mud [23:04:32] 10MediaWiki-API, 10Readers-Web-Backlog, 10Release-Engineering-Team, 10Browser-Tests: Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (10Jdlrobson) [23:04:40] 10MediaWiki-API, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (10Jdlrobson) [23:04:42] thedj: You see the mud you're moving, I see the sparkling-clean waters of the easy shipping channel you've carved out. :-) [23:05:09] (Metaphor doesn't really work much beyond this point.) [23:05:15] haha [23:05:34] (03PS1) 10VolkerE: Special:Preferences: Add example value as placeholder to timezone offset [core] - 10https://gerrit.wikimedia.org/r/476172 (https://phabricator.wikimedia.org/T194524) [23:05:37] 10MediaWiki-API, 10Release-Engineering-Team, 10Browser-Tests, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Ruby browser tests failing consistently with "The wiki is currently in read-only mode. (readonly) (MediawikiApi::ApiError)" - https://phabricator.wikimedia.org/T210557 (10Jdlrobson)... [23:06:01] (03PS1) 10Cooltey: Fix: FacePostprocessor won't be completed in low-end devices [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) [23:06:25] (03PS1) 10Rafidaslam: ArticleHelper.class.php: Remove strict comparsion to null [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476174 [23:07:25] (03Merged) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476167 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:08:14] 10MediaWiki-User-preferences, 10UI-Standardization, 10Patch-For-Review: Special:Preferences: Describe the empty text box ("Other timezone") with some placeholder text - https://phabricator.wikimedia.org/T194524 (10Volker_E) @Kaartic Have altered label above to “Other (specify offset below)“ and added placeho... [23:08:35] (03PS2) 10Rafidaslam: ArticleHelper.class.php: Remove strict comparsion to null [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476174 [23:10:45] (03CR) 10Dbrant: Fix: FacePostprocessor won't be completed in low-end devices (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/476173 (https://phabricator.wikimedia.org/T208910) (owner: 10Cooltey) [23:10:57] (03Merged) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476168 (owner: 10Esanders) [23:11:48] 10Android-app-Bugs, 10Chinese-Sites, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Get invisible lead image when continuing open articles from trending list - https://phabricator.wikimedia.org/T208910 (10cooltey) >>! In T208910#4779582, @ABorbaWMF... [23:11:52] (03CR) 10jenkins-bot: eslint: Drop 'dot-notation' rule [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476167 (https://phabricator.wikimedia.org/T210552) (owner: 10Esanders) [23:16:04] (03CR) 10jenkins-bot: Update eslint-config-wikimedia to 0.9.0 [extensions/Echo] - 10https://gerrit.wikimedia.org/r/476168 (owner: 10Esanders) [23:17:12] (03CR) 10Mholloway: [C: 032] "Thank you!" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476174 (owner: 10Rafidaslam) [23:22:55] (03Merged) 10jenkins-bot: ArticleHelper.class.php: Remove strict comparsion to null [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/476174 (owner: 10Rafidaslam) [23:22:57] 10MediaWiki-Page-editing, 10CharInsert, 10Editing-team: Remove MediaWiki:edittools and update charinsert extension to use JS generated inserter - https://phabricator.wikimedia.org/T210561 (10TheDJ) [23:25:47] (03CR) 10Pmiazga: [C: 031] "Code looks good, if someone feels strong can go with +2. Before I add +2 I need to understand what's going on in the ApiResult.php class t" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [23:27:35] 10Technical-Tool-Request: Feature request: be able to click a button to review suggested links - https://phabricator.wikimedia.org/T210551 (10Aklapper) This sounds like functionality that should not be provided by MediaWiki core itself. I wonder if http://tools.wmflabs.org/navlink-recommendation/ on [Toolforge... [23:28:22] 10Technical-Tool-Request: Scan wiki page content and provide a list of suggested internal links to other wiki pages to add - https://phabricator.wikimedia.org/T210551 (10Aklapper) [23:35:56] 10Mail: Problems with email delivery - https://phabricator.wikimedia.org/T210384 (10Aklapper) 05Open>03stalled [23:41:54] 10address-knowledge-gaps, 10Epic: Output 1.4: Public test APIs corresponding to section recommendation algorithms - https://phabricator.wikimedia.org/T203046 (10leila) [23:41:56] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10leila) [23:42:03] 10MediaWiki-Uploading, 10MediaWiki-User-management, 10Anti-Harassment, 10Multimedia: Allow users to be blocked from uploading files only - https://phabricator.wikimedia.org/T6995 (10TBolliger) [23:44:05] (03PS2) 10Jdlrobson: Upgrade mediawiki selenium packages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476157 [23:46:14] (03CR) 10Arlolra: [C: 031] Don't silently fail if API result fails to encode [core] - 10https://gerrit.wikimedia.org/r/476170 (owner: 10C. Scott Ananian) [23:46:23] (03PS3) 10Daniel Kinzler: Use ParserCache in CategoryMembershipChangeJob [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) [23:46:32] (03CR) 10Daniel Kinzler: Use ParserCache in CategoryMembershipChangeJob (031 comment) [core] - 10https://gerrit.wikimedia.org/r/473564 (https://phabricator.wikimedia.org/T205369) (owner: 10Daniel Kinzler) [23:46:34] 10MediaWiki-Uploading, 10MediaWiki-User-management, 10Anti-Harassment, 10Multimedia: Allow users to be blocked from uploading files only - https://phabricator.wikimedia.org/T6995 (10TBolliger) Some thoughts/opinions on the behavior of the checkbox: * The defaults for the pages and namespaces input fields a... [23:48:21] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10leila) @bmansurov almost. I'll open a thread about this with you, Bob, and Diego now to find out the exact format of the data and output of the API [23:50:14] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Remove articles from reading lists does not remove the articles' offline data - https://phabricator.wikimedia.org/T201879 (10ABorbaWMF) Works for me on 2.7.266-alpha-2018-11-27 [23:50:16] 10ContentTranslation: CX2: Reference in infobox not displayed in Reference section - https://phabricator.wikimedia.org/T210563 (10Etonkovidova) [23:51:18] (03CR) 10Gergő Tisza: Allow users to block the user that blocked them. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/476080 (https://phabricator.wikimedia.org/T150826) (owner: 10Brian Wolff) [23:52:38] 10ContentTranslation, 10WorkType-Maintenance: Wrong segmentation of content inside the reference cause partial publishing - https://phabricator.wikimedia.org/T142814 (10Etonkovidova) Another issue is present with https://en.wikipedia.org/wiki/Central_Bank_of_the_Republic_of_Turkey translation - the first refer... [23:53:06] 10Research: Expose section mappings via an API - https://phabricator.wikimedia.org/T210530 (10leila) @Pginer-WMF We will soon have a working model that aligns article sections across some/many languages. We are building an API to surface the alignment, and we'd like to understand what kind of input/output would... [23:53:21] (03CR) 10BryanDavis: [C: 032] Update ffi and rubyzip gems [vagrant] - 10https://gerrit.wikimedia.org/r/475722 (https://phabricator.wikimedia.org/T209940) (owner: 10Hashar) [23:55:04] 10Core Platform Team Kanban, 10Core Platform Team (PHP7 (TEC4)): PHP/HHVM serialization incompatibility in some situations when using Serializable - https://phabricator.wikimedia.org/T210528 (10CCicalese_WMF) [23:55:45] (03Merged) 10jenkins-bot: Update ffi and rubyzip gems [vagrant] - 10https://gerrit.wikimedia.org/r/475722 (https://phabricator.wikimedia.org/T209940) (owner: 10Hashar) [23:57:11] (03CR) 10jerkins-bot: [V: 04-1] Upgrade mediawiki selenium packages [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/476157 (owner: 10Jdlrobson) [23:57:48] (03CR) 10Jdlrobson: [C: 04-1] "A few regressions that need taking care of relating to mobile.watchstar module not being loaded any more." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475766 (https://phabricator.wikimedia.org/T208921) (owner: 10Jdrewniak) [23:58:03] (03PS5) 10Jdlrobson: Don't pollute the MediaWiki global in tests [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/473603 [23:58:12] 10SVG Translate Tool: Allow user to upload translated file to Commons - https://phabricator.wikimedia.org/T210564 (10Niharika) p:05Triage>03Normal [23:58:57] (03CR) 10jenkins-bot: Update ffi and rubyzip gems [vagrant] - 10https://gerrit.wikimedia.org/r/475722 (https://phabricator.wikimedia.org/T209940) (owner: 10Hashar)