[00:03:57] <wikibugs>	 (03CR) 10Legoktm: [C: 032] "I tagged 0.1.3 with the PHP_SAPI guard, and submitted 2 more patches for further improvements, but this is good enough to go now." [vendor] - 10https://gerrit.wikimedia.org/r/414602 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:05:48] <wikibugs>	 (03CR) 10Legoktm: [C: 032] "Rebased for 1.33." [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:14:21] <wikibugs>	 (03CR) 10VolkerE: stylelint: Replaced CSSLint with StyleLint (032 comments) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[00:20:11] <wikibugs>	 (03Merged) 10jenkins-bot: Add wikimedia/password-blacklist 0.1.3 [vendor] - 10https://gerrit.wikimedia.org/r/414602 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:20:17] <wikibugs>	 (03Merged) 10jenkins-bot: Add PasswordPolicy to check the password isn't in the large blacklist [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:22:35] <wikibugs>	 (03CR) 10jenkins-bot: Add PasswordPolicy to check the password isn't in the large blacklist [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:24:35] <wikibugs>	 (03CR) 10Jforrester: "Yay." [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[00:26:43] <wikibugs>	 10Accessibility, 10Design, 10MediaWiki-User-preferences: Accessibility settings/preferences - https://phabricator.wikimedia.org/T91201 (10Quiddity) Note: A related idea was recently suggested at [[https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(idea_lab)#Feature_Request:_Add_a_'Reading-mode'_button_to_...
[00:28:44] <wikibugs>	 (03PS2) 10Jforrester: RevisionStore: Avoid exception on prev/next of deleted revision [core] - 10https://gerrit.wikimedia.org/r/475459 (https://phabricator.wikimedia.org/T208929) (owner: 10Daniel Kinzler)
[00:30:08] <wikibugs>	 (03CR) 10Jforrester: Move queries for first/prev/next revision into RevisionStore. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/475467 (owner: 10Daniel Kinzler)
[00:31:17] <wikibugs>	 (03CR) 10Jforrester: [C: 031] RevisionStore: Avoid exception on prev/next of deleted revision [core] - 10https://gerrit.wikimedia.org/r/475459 (https://phabricator.wikimedia.org/T208929) (owner: 10Daniel Kinzler)
[00:32:20] <mogmog123>	 Hi. Anyone awake?
[00:34:20] <wikibugs>	 (03PS3) 10Rafidaslam: Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320)
[00:35:24] <refeed>	 mogmog123, Morning
[00:36:08] <refeed>	 I missed all of the fun :(
[00:39:41] <wikibugs>	 10MediaWiki-extensions-GlobalPreferences: Allow signatures to be global - https://phabricator.wikimedia.org/T188200 (10kaldari) FYI, this has been made into [[https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2019/Miscellaneous/Global_signature|a proposal at the 2019 Community Wishlist]].
[01:01:19] <wikibugs>	 (03CR) 10Krinkle: "Wow, I didn't know we logged that much for API reqs. If I understand correctly, this is available on mwlog1001 only (not in Logstash), but" [core] - 10https://gerrit.wikimedia.org/r/474933 (https://phabricator.wikimedia.org/T207941) (owner: 10Gilles)
[01:28:36] <wikibugs>	 10MediaWiki-Database, 10MediaWiki-Templates, 10Wikimedia-production-error: Lock wait timeout exceeded (WikiPage::insertRedirectEntry) when editing a self-redirecting template - https://phabricator.wikimedia.org/T120140 (10Krinkle) >>! In T120140#4644077, @aaron wrote: > Are these jobs that try to also move u...
[01:32:50] <wikibugs>	 10Wikimedia-General-or-Unknown: fdc.wikimedia.org Atom feed url for watchlist is not working  in "Feedly.com" RSS reader - https://phabricator.wikimedia.org/T54516 (10Quiddity)
[01:32:50] <wikibugs>	 10MediaWiki-Recent-changes, 10Growth-Team: RSS RecentChanges does not work on login-required wiki - https://phabricator.wikimedia.org/T92469 (10Quiddity)
[01:37:35] <wikibugs_>	 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: "Revision history" pages should not offer global "recent changes" feed - https://phabricator.wikimedia.org/T20802 (10Quiddity) 05Open>03Invalid Afaict, that second link is no longer part of the page.
[01:46:32] <wikibugs>	 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech, 10Community-Tech-Sprint, 10Wikimedia-production-error: [BUG] GlobalPreferencesFactory emits "PHP Error: in_array() expects parameter 2 to be an array or collection" - https://phabricator.wikimedia.org/T204781 (10Krinkle)
[02:44:46] <rachit>	 hello
[02:45:02] <rachit>	 is anyone who knows lua code available right now?
[03:25:11] <rachit>	 hello
[03:25:29] <rachit>	 is anyone who knows lua code available rn?
[03:25:54] <Krenair>	 your message was received
[03:26:34] <Krenair>	 probably the answer is no, not right now
[03:26:56] <Krenair>	 I'd help if I knew a decent amount of lua and it wasn't half 3 in the morning :p
[03:27:10] <paladox>	 Krenair: Lol
[03:37:14] <rachit>	 lol i'll wait 
[03:49:21] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-extensions-General, 10translatewiki.net, 10I18n, and 3 others: Move all apihelp translatable messages to separate files - https://phabricator.wikimedia.org/T189982 (10Zoranzoki21)
[03:51:57] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Incubator configuration updates - https://phabricator.wikimedia.org/T37161 (10Hydriz)
[03:52:03] <wikibugs>	 10Wikimedia-Extension-setup, 10incubator.wikimedia.org: Enabling of Extension:Translate on the Wikimedia Incubator - https://phabricator.wikimedia.org/T36213 (10Hydriz)
[03:52:07] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Set wgNarayamUseBetaMapping to true on Incubator - https://phabricator.wikimedia.org/T35001 (10Hydriz)
[03:52:14] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Enable Narayam on Incubator - https://phabricator.wikimedia.org/T34418 (10Hydriz)
[03:52:21] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Enable MoodBar on Incubator - https://phabricator.wikimedia.org/T34417 (10Hydriz)
[03:52:25] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10incubator.wikimedia.org: [[Special:ViewUserLang]] Error on test.wikipedia.org - https://phabricator.wikimedia.org/T32566 (10Hydriz)
[03:52:43] <wikibugs>	 10Internet-Archive, 10incubator.wikimedia.org: Deploy InternetArchiveBot on the Wikimedia Incubator (incubatorwiki) - https://phabricator.wikimedia.org/T208158 (10Hydriz)
[03:52:54] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10Language-strategy, 10Release-Engineering-Team, 10incubator.wikimedia.org, and 2 others: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Hydriz)
[03:53:13] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10incubator.wikimedia.org: Fake Wikipedia logo links to Wikidata shown on Incubator - https://phabricator.wikimedia.org/T69519 (10Hydriz)
[03:53:17] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: MoodBar and WikiLove don't work on Incubator with WikimediaIncubator extension installed - https://phabricator.wikimedia.org/T34772 (10Hydriz)
[03:53:19] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Fatal exception error on Special:Preferences on Wikimedia Incubator - https://phabricator.wikimedia.org/T44068 (10Hydriz)
[03:53:21] <wikibugs>	 10Wikimedia-Extension-setup, 10incubator.wikimedia.org: Enable GeoCrumbs on Incubator - https://phabricator.wikimedia.org/T46725 (10Hydriz)
[03:53:23] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10incubator.wikimedia.org, 10I18n: Languages not supported in MediaWiki should not fall back to English - https://phabricator.wikimedia.org/T35028 (10Hydriz)
[03:53:25] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Editing certain namespace pages at Incubator gives a time out error - https://phabricator.wikimedia.org/T32514 (10Hydriz)
[03:53:27] <wikibugs>	 10Wikimedia-Extension-setup, 10incubator.wikimedia.org: Set up SignWriting extension on Incubator for testing - https://phabricator.wikimedia.org/T24216 (10Hydriz)
[03:53:30] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Incubator needs database maintenance - https://phabricator.wikimedia.org/T30465 (10Hydriz)
[03:53:32] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Additional transwiki import sources on Incubator - https://phabricator.wikimedia.org/T22973 (10Hydriz)
[03:53:34] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org, 10I18n: Enable WebFonts on Incubator - https://phabricator.wikimedia.org/T34455 (10Hydriz)
[03:53:38] <wikibugs>	 10MediaWiki-extensions-CentralAuth, 10incubator.wikimedia.org: SUL doesn't autologin on Incubator - https://phabricator.wikimedia.org/T16509 (10Hydriz)
[03:53:42] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Set $wgMaximumMovedPages for Incubator - https://phabricator.wikimedia.org/T17396 (10Hydriz)
[03:53:44] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: New group (translator) on Incubator - https://phabricator.wikimedia.org/T17443 (10Hydriz)
[03:53:48] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Install DynamicPageList on the Wikimedia Incubator - https://phabricator.wikimedia.org/T13963 (10Hydriz)
[03:53:50] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Add localization settings to the LocalSettings.php file of Incubator - https://phabricator.wikimedia.org/T13834 (10Hydriz)
[03:53:52] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Disable uploads and add a namespace on the Incubator - https://phabricator.wikimedia.org/T13168 (10Hydriz)
[03:53:54] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Create the group "test-sysop" for the Wikimedia Incubator - https://phabricator.wikimedia.org/T12727 (10Hydriz)
[03:53:56] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Set wgUploadNavigationUrl for Incubator - https://phabricator.wikimedia.org/T14831 (10Hydriz)
[03:53:58] <wikibugs>	 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Install DynamicPageList on Incubator - https://phabricator.wikimedia.org/T13112 (10Hydriz)
[03:54:00] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Re-enable upload on Incubator - https://phabricator.wikimedia.org/T14642 (10Hydriz)
[03:54:02] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Enable subpages on the Incubator - https://phabricator.wikimedia.org/T12749 (10Hydriz)
[03:54:04] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Set favicon for Wikimedia Incubator - https://phabricator.wikimedia.org/T8921 (10Hydriz)
[03:54:06] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Set {{SITENAME}} of the Incubator to Wikimedia Incubator - https://phabricator.wikimedia.org/T8874 (10Hydriz)
[03:54:08] <wikibugs>	 10Wikimedia-Interwiki-links, 10incubator.wikimedia.org: Some interproject links from Incubator go to nonexistent projects, not to en by default - https://phabricator.wikimedia.org/T9216 (10Hydriz)
[03:54:10] <wikibugs>	 10Wikimedia-Interwiki-links, 10incubator.wikimedia.org: Interwiki links to the language projects (except for Wikipedia) are broken in MediaWiki.org and Incubator - https://phabricator.wikimedia.org/T9185 (10Hydriz)
[03:54:12] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org, 10WorkType-NewFunctionality: missing.php redirect function should work also for closed wikis - https://phabricator.wikimedia.org/T58876 (10Hydriz)
[03:54:14] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10ContentTranslation, 10incubator.wikimedia.org, 10WorkType-NewFunctionality: Make ContentTranslation work in the Wikimedia Incubator - https://phabricator.wikimedia.org/T89089 (10Hydriz)
[03:54:16] <wikibugs>	 10Wikimedia-Extension-setup, 10incubator.wikimedia.org: Enable the WikiLove extension for incubator - https://phabricator.wikimedia.org/T33209 (10Hydriz)
[03:54:18] <wikibugs>	 10MediaWiki-Search, 10Discovery-Search, 10incubator.wikimedia.org: Allow extensions to append stuff to search queries, e.g. for search by prefix - https://phabricator.wikimedia.org/T32229 (10Hydriz)
[03:54:20] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Enable upload of XML files on Incubator (for MediaWiki dumps) - https://phabricator.wikimedia.org/T32228 (10Hydriz)
[03:54:22] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Fix import source on Incubator - https://phabricator.wikimedia.org/T23409 (10Hydriz)
[03:54:24] <wikibugs>	 10Wikimedia-Extension-setup, 10incubator.wikimedia.org: Enable the Incubator-specific extension on the Wikimedia Incubator - https://phabricator.wikimedia.org/T20788 (10Hydriz)
[03:54:26] <wikibugs>	 10Wikimedia-Site-requests, 10incubator.wikimedia.org: Remove the reupload right from autoconfirmed at Incubator - https://phabricator.wikimedia.org/T32492 (10Hydriz)
[03:54:28] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10incubator.wikimedia.org, 10Community-Wishlist-Survey-2016, 10Goal: [Goal] Sitelinks and arbitrary accesses to Incubator, OldWikisource and BetaWikiversity - https://phabricator.wikimedia.org/T54971 (10Hydriz)
[03:56:14] <wikibugs>	 10Wikimedia-General-or-Unknown, 10Tracking: Wikimedia Incubator site settings and related tasks (tracking) - https://phabricator.wikimedia.org/T30486 (10Hydriz) 05Open>03Resolved a:03Hydriz Now tracked in #incubator.wikimedia.org.
[03:56:39] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Create the group "test-sysop" for the Wikimedia Incubator - https://phabricator.wikimedia.org/T12727 (10Hydriz)
[03:56:41] <wikibugs>	 10Wikimedia-Interwiki-links, 10incubator.wikimedia.org: Some interproject links from Incubator go to nonexistent projects, not to en by default - https://phabricator.wikimedia.org/T9216 (10Hydriz)
[03:56:43] <wikibugs>	 10Wikimedia-Interwiki-links, 10incubator.wikimedia.org: Interwiki links to the language projects (except for Wikipedia) are broken in MediaWiki.org and Incubator - https://phabricator.wikimedia.org/T9185 (10Hydriz)
[03:56:45] <wikibugs>	 10Wikimedia-General-or-Unknown, 10incubator.wikimedia.org: Set {{SITENAME}} of the Incubator to Wikimedia Incubator - https://phabricator.wikimedia.org/T8874 (10Hydriz)
[03:56:48] <wikibugs>	 10Wikimedia-General-or-Unknown, 10Tracking: Wikimedia Incubator site settings and related tasks (tracking) - https://phabricator.wikimedia.org/T30486 (10Hydriz)
[04:08:02] <wikibugs>	 10MediaWiki-Internationalization, 10incubator.wikimedia.org, 10translatewiki.net, 10I18n, 10RTL: Wikimedia Incubator and translatewiki cannot set the rtl direction for N'Ko (nqo) language, probably because there's no MessagesNqo.php - https://phabricator.wikimedia.org/T152908 (10Hydriz)
[04:08:04] <wikibugs>	 10incubator.wikimedia.org: EducationProgram test fail with permission error caused by WikimediaIncubator - https://phabricator.wikimedia.org/T69608 (10Hydriz)
[04:08:09] <wikibugs>	 10ContentTranslation, 10incubator.wikimedia.org, 10WorkType-NewFunctionality: Make ContentTranslation work in the Wikimedia Incubator - https://phabricator.wikimedia.org/T89089 (10Hydriz)
[04:09:16] <rachit>	 hello
[04:09:42] <rachit>	 i need help regarding a gci task related to lua 
[04:13:15] <Ebe123>	 Hi Rachit
[04:13:22] <Ebe123>	 I might be able to help
[04:13:51] <rachit>	 https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech this is my module sandbox
[04:13:52] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team: RecentChanges don't load on on Incubator - https://phabricator.wikimedia.org/T176986 (10Hydriz)
[04:14:18] <rachit>	 https://en.wikipedia.org/w/index.php?title=User:Bleed.tech/sandbox&action=edit this is my user sandbox
[04:14:51] <Ebe123>	 ok
[04:15:01] <rachit>	 ebel 123 i submitted it but my mentor said "When you make test cases for your functions, you should consider what happens when the user supplies bad input, such as nil, blank or invalid values for the parameter. Your code traps the missing parameter case (nil) but misses the blank and invalid (e.g. text) cases.  I've added two more tests to your sandbox to show the errors you get.  You can fix the problem by attempting the conv
[04:15:35] <rachit>	 You can fix the problem by attempting the conversion to a number earlier in your code. The tonumber() function returns nil if it could not convert, so your trap for nil will then catch all of the bad input and use zero instead.
[04:15:55] <rachit>	 that is whar he said
[04:16:08] <Ebe123>	 Try putting "if cel==nil then cel=0 end" after tonumber()
[04:17:01] <rachit>	 ok done.
[04:17:45] <Ebe123>	 Works now?
[04:18:22] <rachit>	 but he said to convert to a number earlier in your code
[04:18:47] <rachit>	 wait
[04:18:53] <rachit>	 yes it does work now
[04:19:04] <rachit>	 thank you Ebel1234
[04:19:11] <rachit>	 Ebel123 :)
[04:19:51] <Ebe123>	 Great!
[04:30:14] <wikibugs>	 (03PS1) 10Zoranzoki21: Move all apihelp translatable messages to separate files [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/475610 (https://phabricator.wikimedia.org/T189982)
[05:19:39] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10Language-strategy, 10Release-Engineering-Team, 10incubator.wikimedia.org, and 2 others: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Amire80)
[05:42:06] <wikibugs>	 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas)
[06:04:05] <wikibugs>	 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas)
[06:09:38] <wikibugs>	 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas)
[06:11:44] <wikibugs>	 (03CR) 10Reedy: "I think we should remove the 10K one eventually, yeah" [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy)
[06:12:12] <wikibugs>	 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas)
[06:52:24] <wikibugs>	 10MediaWiki-extensions-Linter: Otrs-wiki lint errors are not being updated - https://phabricator.wikimedia.org/T210342 (10TheDragonFire)
[07:05:07] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10Language-strategy, 10Release-Engineering-Team, 10incubator.wikimedia.org, and 2 others: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Hydriz) @Amire80 Anything that the extension can do in this task? It seems to me th...
[07:05:31] <wikibugs>	 10MediaWiki-Special-pages, 10Wikidata, 10Chinese-Sites: Two talk pages (Talk:沙溪兴教寺 and User talk:Yuriy kosygin) shown in Special:Shortpages and Special:Unconnectedpages on zh.wikipedia - https://phabricator.wikimedia.org/T185404 (10Liuxinyu970226)
[07:39:23] <shreyasminocha>	 hey
[07:43:12] <shreyasminocha>	 boy is it lonely at this hour
[07:49:25] <p858snake|_>	 it is also the weekend
[07:49:44] <wikibugs>	 10SpamBlacklist, 10Stewards-and-global-tools: Spam Blacklist shouldn't be fooled by similar-looking Unicode characters - https://phabricator.wikimedia.org/T14896 (10MaxSem)
[07:50:58] <shreyasminocha>	 p858snake|_: fair enough
[08:12:33] <ebel123>	 hi i need a generic help
[08:14:03] <rachit_>	 Hello
[08:14:10] <rachit_>	 I am a gci student
[08:14:53] <takidelfin>	 Hello! I'm back to fight with my task
[08:15:11] <rachit_>	 lol 
[08:15:22] <rachit_>	 how many tasks have you done?
[08:16:51] <rachit_>	 takidelfin you there?
[08:16:57] <takidelfin>	 yup
[08:17:05] <takidelfin>	 How is your task btw?
[08:17:27] <rachit_>	 I have submitted it for review :)
[08:17:37] <rachit_>	 working on lua #4
[08:17:52] <rachit_>	 i mean will start rn
[08:18:17] <rachit_>	 what about you?
[08:19:14] <takidelfin>	 Fixing linter bugs :D
[08:19:32] <rachit_>	 how many tasks have you completed btw? 
[08:19:56] <takidelfin>	 does it matters 🤔
[08:20:04] <takidelfin>	 ~ 26
[08:20:51] <rachit_>	 that is a pretty good number :)
[08:22:10] <wikibugs>	 10MediaWiki-extensions-WikimediaIncubator, 10Language-strategy, 10Release-Engineering-Team, 10incubator.wikimedia.org, and 2 others: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Amire80) Nothing immediate, but it's close enough to the topic.  This project is ne...
[08:24:36] <shreyasminocha>	 hi people
[08:31:48] <rachit_>	 hi shreyasminocha
[08:32:34] <shreyasminocha>	 nice too see you again
[08:33:06] <takidelfin>	 shreyasminocha: hello o/
[08:33:19] <shreyasminocha>	 \o
[08:33:46] <wikibugs>	 (03PS2) 10Takidelfin: stylelint: Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506)
[08:34:14] <wikibugs>	 (03CR) 10Takidelfin: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[08:36:16] <rachit_>	 shreyasminocha you too :))
[08:38:10] <rachit_>	 shreyasminocha i need help
[08:38:44] <rachit_>	 my step says "Edit p.times in your module sandbox so that it will display 6 times 1 equals 6, etc. Save it. Check it in your user sandbox by refreshing the page and fix any errors."
[08:39:22] <rachit_>	 p.times = function(frame)
[08:39:40] <rachit_>	 ignore the last message^
[08:40:09] <rachit_>	 can you tell me how do i do that step shreyasminocha takidelfin
[08:42:47] <shreyasminocha>	 you have to use string concatenation like you did yesterday
[08:42:58] <shreyasminocha>	 try to figure it out yourself, it's the same concept
[08:44:21] <shreyasminocha>	 the format is x times y equals x*y. try to figure out which variables store x and y. then use string concatenation like last time to create the string
[08:44:54] <takidelfin>	 yeah
[08:47:10] <takidelfin>	 :(
[08:47:35] <shreyasminocha>	 :(
[08:47:56] <shreyasminocha>	 was i rude?
[08:49:06] <takidelfin>	 :D
[08:50:44] <shreyasminocha>	 i'll take that to be a "no"
[08:51:20] <rachit>	 hi shreyasminocha
[08:51:36] <takidelfin>	 yeay
[08:51:36] <shreyasminocha>	 hi
[08:53:07] <rachit>	 did you see my doubt?
[08:53:14] <shreyasminocha>	 i replied
[08:53:29] <rachit>	 sorry I lost the server so couldn't see it
[08:53:38] <shreyasminocha>	 14:10 < rachit_> can you tell me how do i do that step shreyasminocha takidelfin
[08:53:41] <shreyasminocha>	 14:12 < shreyasminocha> you have to use string concatenation like you did 
[08:53:44] <shreyasminocha>	                         yesterday
[08:53:46] <shreyasminocha>	 14:12 < shreyasminocha> try to figure it out yourself, it's the same concept
[08:53:50] <shreyasminocha>	 14:14 < shreyasminocha> the format is x times y equals x*y. try to figure out 
[08:53:52] <shreyasminocha>	                         which variables store x and y. then use string 
[08:53:55] <shreyasminocha>	                         concatenation like last time to create the string
[08:54:32] <rachit>	 .."6".."1"= 6?
[08:54:51] <takidelfin>	 nope
[08:54:53] <takidelfin>	 it is 61
[08:55:06] <takidelfin>	 because yo are concating a string
[08:55:27] <takidelfin>	 To add 6 to 1 you need to do: 6 + 1
[08:55:49] <rachit>	 .."6*1"=6?
[08:56:09] <rachit>	 Edit p.times in your module sandbox so that it will display 6 times 1 equals 6, etc. Save it. Check it in your user sandbox by refreshing the page and fix any errors.
[08:56:12] <shreyasminocha>	 rachit: not sure at which step you are, but if you have started accepting a parameter, you want to use the value of that parameter. you wouldn't always be printing the table for just 6
[08:56:40] <shreyasminocha>	 `6 times 1 equals 6` you want it to show the times table in that format
[08:56:48] <rachit>	 ya
[08:56:58] <shreyasminocha>	 whenever text has the grey-ish background behind it, understand that you should take it literally
[08:58:00] <rachit>	 6 times 1 equals 6 doesn't have a grey-ish background
[08:58:17] <takidelfin>	 nope
[08:58:26] <takidelfin>	 nvm
[08:58:52] <shreyasminocha>	 it does
[08:58:56] <shreyasminocha>	 in the instructions page
[08:59:12] <rachit>	 I am on step 8
[08:59:21] <shreyasminocha>	 i know
[09:00:11] <shreyasminocha>	 https://imgur.com/a/G9F7Sp8
[09:00:46] <shreyasminocha>	 whenever something's formatted like that, take it literally
[09:00:58] <shreyasminocha>	 as when we guys surround something with `s
[09:01:15] <shreyasminocha>	 so you want to print stuff in the form `6 times 1 equals 6`
[09:01:28] <rachit>	 ok
[09:01:30] <rachit>	 yeah
[09:01:35] <shreyasminocha>	 identify which things are dynamic
[09:01:43] <shreyasminocha>	 identify which variables contain those dynamic things
[09:01:49] <rachit>	 tonumber?
[09:02:04] <rachit>	 local num?
[09:02:05] <shreyasminocha>	 *variables*
[09:02:24] <shreyasminocha>	 yes
[09:02:37] <shreyasminocha>	 num is one of them
[09:02:41] <shreyasminocha>	 which is the other?
[09:02:46] <rachit>	 out
[09:02:58] <shreyasminocha>	 no, out is what stores the final output
[09:03:09] <shreyasminocha>	 you aren't understanding my question
[09:03:20] <shreyasminocha>	 see, you want to print something of the format `6 times 1 equals 6`
[09:03:27] <rachit>	 ya
[09:03:29] <shreyasminocha>	 now the text in this will be the same each time
[09:03:33] <shreyasminocha>	 but the numbers will not
[09:03:41] <rachit>	 right
[09:03:46] <shreyasminocha>	 so you will have to get the numbers from variables ofc
[09:03:54] <rachit>	 xyz?
[09:04:03] <shreyasminocha>	 p.times = function(frame)
[09:04:03] <shreyasminocha>	 	local num = tonumber( frame.args.num ) or 2
[09:04:03] <shreyasminocha>	 	local out = "6 Times table<br>"
[09:04:03] <shreyasminocha>	 	for i = 1, 10 do
[09:04:04] <shreyasminocha>	 		out = out .. i * num .. "<br>"
[09:04:05] <shreyasminocha>	 	end
[09:04:08] <shreyasminocha>	 	return out
[09:04:11] <shreyasminocha>	 end
[09:04:17] <shreyasminocha>	 i don't see any x, y, or z here
[09:04:44] <shreyasminocha>	 think, think
[09:05:03] <rachit>	 um
[09:05:37] <rachit>	 if then else?
[09:05:42] <rachit>	 no
[09:05:43] <shreyasminocha>	 you identified one of the variables correctly: num. which numbers in `6 times 1 equals 6` can be obtained from `num`?
[09:06:24] <rachit>	 2?
[09:07:01] <shreyasminocha>	 see, currently you're simply doing `out = out .. i * num .. "<br>"`. but you want to be clearer. more clear than just writing the answer. what you're doing in this line is multiplying i * num. that is, `num` times `i` equals <the product>
[09:07:47] <rachit>	 oh okay
[09:07:47] <shreyasminocha>	 but rather than just writing the product `i * num`, you want to write a clear string that says something of the form `6 times 1 equals 6`
[09:07:53] <shreyasminocha>	 yes
[09:08:25] <rachit>	 something with ..6*1..?
[09:09:43] <shreyasminocha>	 if you hardcode 6 * 1, each time you'll get the same answer. you need to use the variables to generate your string. i've given you a big clue.
[09:10:29] <rachit>	 is the other variable I?
[09:10:33] <rachit>	 i
[09:10:37] <shreyasminocha>	 yes!
[09:10:38] <rachit>	 ?
[09:10:55] <shreyasminocha>	 hopefully  you understand why
[09:11:15] <rachit>	 .."I".."num"?
[09:11:43] <shreyasminocha>	 try
[09:12:10] <rachit>	 it needs to be written before <br> ?
[09:12:27] <shreyasminocha>	 <br> creates a line break
[09:12:44] <rachit>	 ya ik
[09:12:50] <rachit>	 so after that right?
[09:13:04] <shreyasminocha>	 try both
[09:13:14] <shreyasminocha>	 i don't want to give you the answer right away
[09:13:26] <shreyasminocha>	 hopefully you don't mind
[09:14:49] <rachit>	 none of that works right shreyasminocha :(
[09:15:11] <shreyasminocha>	 do you get errors or incorrect output?
[09:15:35] <rachit>	 error on the left side and incorrect output on the right side of <br>
[09:16:04] <shreyasminocha>	 you shouldn't get an error putting it on the left side
[09:16:10] <shreyasminocha>	 but yes, i expected the incorrect output
[09:16:19] <shreyasminocha>	 do you understand what you're doing wrong?
[09:16:23] <rachit>	 	out = out .. i * num.."i".."num" "<br>"
[09:16:34] <rachit>	 isn't this right?
[09:16:41] <rachit>	 I think I do 
[09:16:45] <shreyasminocha>	 you're missing a .. between "num" and "<br>" bro
[09:16:54] <rachit>	 ohh
[09:17:15] <shreyasminocha>	 (you'll still get incorrect output though. don't be disheartened)
[09:17:31] <rachit>	 yeah the output is wrong 
[09:17:38] <shreyasminocha>	 any guesses as to why?
[09:18:32] <rachit>	 I don't have to do "I".."num" ig?
[09:18:51] <shreyasminocha>	 we're going step by step. we want to see the values of i and num
[09:19:06] <shreyasminocha>	 but what you're doing is literally printing "Inum"
[09:20:06] <shreyasminocha>	 any guesses as to why?
[09:20:48] <rachit>	 quotation marks?
[09:20:54] <shreyasminocha>	 perfect
[09:22:05] <shreyasminocha>	 no you're getting <product><i><num>
[09:22:10] <shreyasminocha>	 now*
[09:22:18] <shreyasminocha>	 but it's very unreadable because of the lack of spaces
[09:22:39] <rachit>	 yes
[09:23:11] <rachit>	 how do I put spaces without quotation marks?
[09:23:30] <shreyasminocha>	 concatenate another tiny string with just spaces ;)
[09:24:50] <rachit>	 done :)
[09:24:54] <shreyasminocha>	 now you can clearly see the components!
[09:25:03] <rachit>	 yes :))
[09:25:07] <rachit>	 thank you
[09:25:15] <shreyasminocha>	 now you just gotta rearrange them in the format `x times y equals <product>`
[09:25:21] <shreyasminocha>	 you got this rachit 
[09:25:41] <rachit>	 yes 
[09:31:22] <rachit>	 shreyasminocha
[09:31:25] <shreyasminocha>	 yo
[09:31:33] <rachit>	 shouldn't my code be "out = out ..i.."  "..num.."  ".. i * num"<br>""
[09:32:25] <shreyasminocha>	 missing the .. between i * num and "<br>"
[09:33:27] <rachit>	 did that but there is an output error
[09:34:14] <shreyasminocha>	 your .. is inside the string bro
[09:34:28] <shreyasminocha>	 it's supposed to be between num and open quotation mark :)
[09:35:29] <rachit>	 yeah typing error
[09:35:33] <shreyasminocha>	 np
[09:35:42] <rachit>	 thank you again lol
[09:35:54] <shreyasminocha>	 now you need to get your output in the format
[09:36:01] <shreyasminocha>	 `6 times 1 equals 6`
[09:36:08] <shreyasminocha>	 `6 times 2 equals 6`
[09:36:10] <shreyasminocha>	 12
[09:36:15] <shreyasminocha>	 and so on
[09:36:22] <shreyasminocha>	 same thing: string concatenation
[09:40:19] <shreyasminocha>	 hi refeed 
[09:40:33] <refeed>	 shreyasminocha, hello!
[09:40:37] <takidelfin>	 refeed:o/
[09:40:51] <refeed>	 takidelfin, o/
[09:40:56] <takidelfin>	 rachit: shreyasminocha: and?
[09:41:35] <rachit>	 hello refeed
[09:41:45] <shreyasminocha>	 takidelfin: `and?` wdym?
[09:41:48] <refeed>	 rachit, hello!
[09:42:14] <takidelfin>	 How is their task ;-;
[09:42:42] <shreyasminocha>	 they're going fine
[09:42:47] <shreyasminocha>	 waiting for their reply
[09:44:46] <shreyasminocha>	 rachit: hey
[09:44:57] <rachit>	 hello
[09:45:06] <shreyasminocha>	 you're almost there. just two minor things
[09:45:39] <shreyasminocha>	 firstly, in the heading "6 Times table", you don't want to hardcode it. you want to show the correct number instead of 6. i'm sure you know which variable to use, don't you?
[09:45:45] <takidelfin>	 yeah
[09:46:01] <takidelfin>	 you need to do this as you did with celsius task
[09:46:21] <takidelfin>	 contcate a variable to a string
[09:46:40] <shreyasminocha>	 yeah, they've got the hang of that now :)
[09:47:29] <shreyasminocha>	 rachit: second, you want to invert the order when you print "9 times 2 equals 18". why? because in their example, they used the number "6" and in their example output they said "6 times 1 equals 6"
[09:48:15] <shreyasminocha>	 so it's safe to assume that they want it as `6 times 1 equals 6`, `6 times 2 equals 6`, and so on rather than `1 times 6 equals 6`, `2 times 6 equals 6` and so on
[09:48:30] <shreyasminocha>	 (oops, i wrote 6 instead of 12)
[09:49:16] <rachit>	 shreyasminocha can you check the first error you pointed out
[09:49:20] <rachit>	 have I don't it right?
[09:49:33] <rachit>	 done*
[09:49:38] <shreyasminocha>	 lgtm apart from a missing space
[09:49:54] <shreyasminocha>	 gj
[09:50:48] <rachit>	 ty
[09:51:15] <rachit>	 and i'll edit the second thing as well :)
[09:51:23] <shreyasminocha>	 :) awesome
[09:52:28] <rachit>	 shreyasminocha can you check?
[09:52:43] <shreyasminocha>	 perfect
[09:52:49] <takidelfin>	 :D
[09:53:03] <rachit>	 thnx :')
[09:53:20] <shreyasminocha>	 see? you figured all of this out almost independently :)
[09:53:44] <rachit>	 ty :D
[09:55:07] <rachit>	 eh there is one thing I couldn't understand
[09:55:18] <rachit>	 . Amend the code in your module sandbox so that it uses a numeric for loop around line 4 which loops from 1 to 5 so that the output will be five lines, the first one displaying "Hello Dad", the next "Hello Mum", and so on, showing the members of the family table.
[09:55:46] <rachit>	 i get what i'm supposed to do 
[09:56:15] <rachit>	 but can you give me a clue on how to use 'for'
[09:56:40] <shreyasminocha>	 check https://www.lua.org/pil/4.3.4.html
[09:57:52] <rachit>	 for i=1,5 do print(i) end  ?
[09:58:48] <shreyasminocha>	 you don't have to print numbers
[09:59:01] <shreyasminocha>	 but you have to print the i-th element of the family array
[09:59:12] <shreyasminocha>	 'the first one displaying "Hello Dad"'
[09:59:19] <shreyasminocha>	 'the next "Hello Mum", and so on, showing the members of the family table.'
[09:59:48] <rachit>	 yes
[10:01:29] <rachit>	 shreyasminocha what should i do then?
[10:01:57] <shreyasminocha>	 print the i-th element of the family array
[10:02:04] <shreyasminocha>	 do you know how to get an element of an array?
[10:02:33] <rachit>	 nope
[10:02:56] <rachit>	 wait yeah i do
[10:03:09] <shreyasminocha>	 how?
[10:04:11] <rachit>	 family[1]
[10:04:16] <rachit>	 will refer to dad 
[10:04:25] <shreyasminocha>	 yep
[10:04:38] <shreyasminocha>	 (dad is the first element right)
[10:04:43] <shreyasminocha>	 (i don't remember)
[10:04:46] <rachit>	 yes
[10:04:50] <rachit>	 	for i=1,5 do print(family[i-th]) end
[10:04:53] <rachit>	 am i closer
[10:04:54] <rachit>	 ?
[10:05:14] <shreyasminocha>	 closer, yes
[10:05:17] <shreyasminocha>	 but not quite
[10:05:35] <rachit>	 any other hint?
[10:05:43] <shreyasminocha>	 like you did family[1], family[i] will refer to the i-th element :)
[10:05:54] <takidelfin>	 um
[10:06:06] <shreyasminocha>	 if you do family[i-th], it will try to subtract th from i and get the resulting element :)
[10:06:23] <takidelfin>	 You have got a big cardboard box with 10 small boxes in it
[10:06:29] <rachit>	 oh
[10:06:41] <takidelfin>	 these small boxes have got number 1,2,3 etc
[10:07:03] <rachit>	 takidelfin yeah i got how the family members have numbers assigned to them
[10:07:06] <takidelfin>	 ah
[10:07:08] <takidelfin>	 okay
[10:07:11] <takidelfin>	 :D
[10:07:19] <rachit>	 :) thanks anyway
[10:07:36] <takidelfin>	 Ping me if you need help
[10:07:43] <takidelfin>	 I'm gonna do some GCI tasks now
[10:07:47] <rachit>	 sure thanks
[10:07:55] <rachit>	 atb :p
[10:08:12] * shreyasminocha is waiting on a review :/
[10:08:31] * shreyasminocha is patient
[10:08:46] <rachit>	 haha
[10:08:58] <rachit>	 shreyasminocha for i=1,5 do print(family[i]) end this?
[10:09:20] <shreyasminocha>	 lgtm. try it out?
[10:09:32] <rachit>	 isn't working
[10:09:35] <rachit>	 output error
[10:10:05] <shreyasminocha>	 oh, oh, oh
[10:10:24] <shreyasminocha>	 looks like in these sandboxes, print isn't a function
[10:10:36] <rachit>	 ohh
[10:10:39] <shreyasminocha>	 you'll have to concatenate stuff to msg like you were doing in the rest of the function
[10:10:47] <shreyasminocha>	 and the other function
[10:10:51] <shreyasminocha>	 my bad
[10:11:26] <rachit>	 ill have to do like 	msg = msg .. "Hello " .. family[1] .. "<br>" ?
[10:11:30] <rachit>	 till 5
[10:11:42] <rachit>	 means 5 lines of msg=msg  code?
[10:12:02] <rachit>	 where will i use 'for' then
[10:12:17] <shreyasminocha>	 instead of manually writing msg = msg .. five times
[10:12:25] <shreyasminocha>	 you can put that line inside the for
[10:12:57] <shreyasminocha>	 and use the for loop's counter instead of hardcoding the number
[10:13:44] <rachit>	 how?
[10:14:15] <shreyasminocha>	 for i=1,5 do
[10:14:27] <shreyasminocha>	     -- msg = msg .. stuff
[10:14:29] <shreyasminocha>	 end
[10:14:46] <shreyasminocha>	 (btw the first two -- signify comments)
[10:14:56] <rachit>	 okay
[10:15:01] <rachit>	 ya ik
[10:15:13] <shreyasminocha>	 just confirming
[10:16:22] <wikibugs>	 10MediaWiki-extensions-Other: MW MultiMaps extension: adding support for multiple URLs in Leaflet - https://phabricator.wikimedia.org/T210033 (10FellTiger) a:03FellTiger Thanks for the assistance.  I just wanted to assure that nobody objects to the addition of this feature from the start already.
[10:16:48] <rachit>	 	for i=1,5 do-- msg = msg .. "Hello "..family[i] end shreyasminocha
[10:17:03] <shreyasminocha>	 remove the -- or your code wouldn't run :)
[10:17:18] <shreyasminocha>	 btw i recommend writing for loops, if-else blocks etc over multiple lines
[10:17:25] <shreyasminocha>	 can prevent confusion
[10:17:45] <rachit>	 hmm
[10:19:14] <rachit>	 shreyasminocha can you check if its correct
[10:19:48] <shreyasminocha>	 yep
[10:21:45] <wikibugs>	 (03PS8) 10D3r1ck01: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296
[10:22:43] <shreyasminocha>	 (i meant that it is correct)
[10:23:03] <rachit>	 shreyasminocha how do i put upperlimit to 'for' ?]
[10:23:21] <shreyasminocha>	 `for i=1,5`. here, 5 is the upper limit
[10:23:35] <rachit>	 oh ok 
[10:23:52] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01)
[10:24:18] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296 (owner: 10D3r1ck01)
[10:25:04] <rachit>	 shreyasminocha lua #4 is completed
[10:25:23] <rachit>	 Thank you :D
[10:25:27] <shreyasminocha>	 :)
[10:53:24] <wikibugs>	 10MediaWiki-extensions-Page_Forms: Show nicer error message for incorrect timezones (input type=datetime|include timezone) - https://phabricator.wikimedia.org/T210343 (10Samwilson)
[10:53:52] <wikibugs>	 10MediaWiki-extensions-Page_Forms, 10Wikimedia Australia: Show nicer error message for incorrect timezones (input type=datetime|include timezone) - https://phabricator.wikimedia.org/T210343 (10Samwilson) Tagging WMAU as this is currently happening for https://wikimedia.org.au/wiki/Form:Event
[11:12:38] <wikibugs>	 10MediaWiki-Installer, 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup: {{NUMBEROFACTIVEUSERS}} doesn’t get updated when $wgMiserMode = false - https://phabricator.wikimedia.org/T140079 (10Zoglun) We encounter a new error in MW 1.31.  The active user number droped from 1.3k to 50 after `php /var...
[11:29:23] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10User-notice: [Epic] Unit support - https://phabricator.wikimedia.org/T77977 (10Liuxinyu970226)
[11:38:55] <wikibugs>	 04(no projects): Add which sitelink is moved by the Move Sitelinks gadget - https://phabricator.wikimedia.org/T210345 (10Melderick)
[11:39:27] <wikibugs>	 (03CR) 10Urbanecm: [C: 032] Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) (owner: 10Rafidaslam)
[11:40:45] <wikibugs>	 (03Merged) 10jenkins-bot: Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) (owner: 10Rafidaslam)
[11:43:30] <rachit>	 hello guys
[11:43:44] <rachit>	 urbanecm are you there?
[11:43:50] <Urbanecm>	 Hi rachit 
[11:44:24] <rachit>	 u just reviewd my task and you told me to use or '0 part"
[11:45:13] <rachit>	 although you have approved my task but do you still want me to change it to 'or 0'? urbanecm
[11:45:45] <wikibugs>	 10MediaWiki-Installer, 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup: {{NUMBEROFACTIVEUSERS}} doesn’t get updated when $wgMiserMode = false - https://phabricator.wikimedia.org/T140079 (10Ciencia_Al_Poder) >>! In T140079#4772255, @Zoglun wrote: > We encounter a new error in MW 1.31.  > The acti...
[11:46:04] <wikibugs>	 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Epic, 10Tracking: [Epic] data quality and trust - https://phabricator.wikimedia.org/T76230 (10abian)
[11:46:08] <wikibugs>	 10MediaWiki-Page-protection, 10Wikidata: Protection of classes of Wikidata items based on attributes of their statements - https://phabricator.wikimedia.org/T209243 (10abian)
[11:47:32] <Urbanecm>	 It was meant as a note, your code works exactly how it would work after using my suggestion. As it have no differences from "what the code does" side, I approved the task. But as GCI is also about learning new things, I decided to tell you about easier solution. 
[11:47:52] <rachit>	 oh ohk 
[11:47:58] <rachit>	 thank you :D
[11:48:09] <Urbanecm>	 You're welcome. 
[11:48:58] <rachit>	 urbanecm also I have submitted another task so please review it whenever you are free :)
[11:49:14] <Urbanecm>	 Let's do it immediately :)
[11:49:44] <rachit>	 haha thank you :d
[11:50:29] <Urbanecm>	 It looks you didn't understand what "level 2" and "level 3" headlines are. Are you familiar with HTML?
[11:52:21] <Urbanecm>	 rachit, ^^
[11:52:25] <rachit>	 ye
[11:52:27] <rachit>	 yes
[11:52:43] <rachit>	 ohh I got it
[11:52:45] <rachit>	 sorry 
[11:52:51] <rachit>	 ill edit it rn
[11:53:34] <rachit>	 urbanecm do I have to use <h2> and <h3>
[11:53:36] <rachit>	 ?
[11:54:15] <Nathan_fraignt>	 Are you doing a lua task?
[11:54:32] <Urbanecm>	 No, in wikitext (a markup language Wikipedia uses) "== something ==" is equivalent to "<h2>something</h2>" in HTML.
[11:54:51] <Urbanecm>	 and "=== something ===" to "<h3>something</h3>" and so on
[11:55:01] <rachit>	 oh ok 
[11:55:05] <rachit>	 ill edit it rn
[11:55:39] <Urbanecm>	 ok :)
[11:55:57] <Urbanecm>	 Hi Nathan_fraignt , yeah, they're doing lua task #4
[11:56:24] <Nathan_fraignt>	 Yeah, I was wondering, since that would mean you owuldn´t have to use <h2>, but you already answered :)
[11:57:00] <rachit>	 urbanecm done :)
[11:58:16] <Urbanecm>	 rachit, {{approved}}
[11:58:30] <rachit>	 Thank you :))
[11:58:58] <Nathan_fraignt>	 Urbanecm, in tracker, where do I find the code that sends the notifications if you are the owner of a ticket?
[11:59:37] <Urbanecm>	 https://github.com/wikimedia/wikimedia-cz-tracker/blob/master/trackersite/tracker/models.py#L941-L957
[11:59:52] <Nathan_fraignt>	 Thanks
[11:59:54] <Urbanecm>	 yw
[12:00:51] <rachit>	 urbanecm rexxs had sent me a link for a task called "getting on the IRC" it is opening but the claim task button isn't working
[12:01:03] <rachit>	 does that mean that the task is removed?
[12:01:14] <Nathan_fraignt>	 It probably means that you´ve done 2 beginner tasks
[12:01:27] <Nathan_fraignt>	 Or that you already claimed it
[12:01:31] <rachit>	 right
[12:01:47] <rachit>	 2 beginner tasks already done
[12:01:50] <Nathan_fraignt>	 (I think urbanecm can see if you´ve done 2 beginner tasks)
[12:01:59] <Nathan_fraignt>	 In that case, you can´t claim it anymore
[12:02:02] <rachit>	 thanks Nathan_fraignt
[12:02:05] <Nathan_fraignt>	 Np
[12:06:50] <wikibugs>	 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] nudge editors to add a reference when adding a new claim - https://phabricator.wikimedia.org/T76231 (10abian) Now the properties needing a reference may be those with a [[https://www.wikidata.org/wiki/Help:Property_constraints_portal/Cit...
[12:09:54] <wikibugs>	 (03CR) 10Shreyasminocha: "> Patch Set 1: Code-Review-1" [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) (owner: 10Shreyasminocha)
[12:16:23] <rachit>	 Hi! Is anyone available to help me with a GCI Task regarding lua
[12:17:14] <rachit>	 Nathan_fraignt you there?
[12:17:39] <Nathan_fraignt>	 I am, just ask away! (I´m doing some coding at the same time, so answers might not be there instantly)
[12:18:09] <wikibugs>	 (03PS1) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[12:18:38] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Nathan_fraignt) a:03Nathan_fraignt
[12:19:22] <rachit>	 8. Change the function p.sentence in your module sandbox so that it takes the first letter of the string supplied and turns it into a capital (this is called "sentence case"). You need to get the first letter and capitalise it, then get the rest of the string, and concatenate the two parts.
[12:19:34] <rachit>	 my step says ^
[12:19:54] <Nathan_fraignt>	 Can you send your urls, so I can see what you´ve done?
[12:19:55] <rachit>	 how should I do it ?
[12:20:13] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox
[12:20:18] <rachit>	 https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech
[12:21:05] <Nathan_fraignt>	 Alright, well the first things should probably be thinking about the small steps you need to do in order to capitalise the first letter of a string.
[12:21:08] <rachit>	 https://en.wikipedia.org/wiki/User:RexxS/GCI-Task05 this is the url to my task and I am on step 8
[12:21:33] <Nathan_fraignt>	 For instance: step 1: Getting the string, step 2: Getting the first letter of the string
[12:21:41] <Nathan_fraignt>	 Try to think in small steps that a computer can do
[12:21:50] <rachit>	 um
[12:22:02] <Nathan_fraignt>	 So how would you do step 8, if you can only do one small thing/step at a time?
[12:22:31] <rachit>	 is it something to do with string.upper?
[12:23:08] <Nathan_fraignt>	 Probably, but you shouldn´t think in terms of code to begin, you should try to make the problem less complicated
[12:23:37] <rachit>	 first I will capitalize the first letter i.e "t"
[12:23:58] <Nathan_fraignt>	 (urbanecm: I submitted a patch for T208656: https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/475615 , it´s probably not perfect yet, but have a look!)
[12:23:59] <stashbot>	 T208656: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656
[12:24:05] <Urbanecm>	 will do
[12:24:05] <Nathan_fraignt>	 How will you get the first letter?
[12:24:21] <rachit>	 by the code local out = string.sub(str, 1, 1) 
[12:24:56] <Nathan_fraignt>	 Alright, so you have step 1: getting the first letter. You should also store the other part of the string somewhere (the part without the first letter)
[12:25:11] <rachit>	 and then I would concatenate it with the rest of the part i.e "his is easy."
[12:25:12] <wikibugs>	 (03CR) 10Amire80: [C: 032] Move all apihelp translatable messages to separate files [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/475610 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21)
[12:25:50] <Nathan_fraignt>	 Yes, exactly
[12:26:32] <Nathan_fraignt>	 Be carefull to not name 2 variables the same, that will overwrite them
[12:26:54] <Nathan_fraignt>	 And try to make the name descriptive, for instance, name the first letter: first_letter
[12:27:42] <rachit>	 let me try
[12:28:48] <rachit>	 Nathan_fraignt how will I capitalize that letter?
[12:29:57] <Nathan_fraignt>	 Alright, if you don´t know the langauge you´ll look those kinds of things up on google, language documentation, etc. In this case though, I think you already mentioned the correct function
[12:30:13] <wikibugs>	 (03CR) 10Nathan fraignt: Change: All notifications will now go via watcher object (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[12:30:14] <rachit>	 string.upper( s )
[12:30:25] <Nathan_fraignt>	 Yes!
[12:30:30] <rachit>	 ok
[12:33:06] <wikibugs>	 (03Merged) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/475610 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21)
[12:33:11] <wikibugs>	 (03CR) 10Gergő Tisza: [C: 04-1] "> Yes, I did change it because of that, but also because it requested the 1024px images for small thumbnails." [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish)
[12:34:26] <rachit>	 Nathan_fraignt I couldn't find a way to use the function string.upper( s ) 
[12:35:03] <Nathan_fraignt>	 Alright, what does string.upper() take? What is the thing that you put between the brackets?
[12:35:13] <rachit>	 the letter?
[12:35:22] <Nathan_fraignt>	 Yes
[12:35:24] <wikibugs>	 (03CR) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/475610 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21)
[12:35:34] <Nathan_fraignt>	 Or the var that has the letter
[12:35:36] <rachit>	 but it is showing an error
[12:35:51] <rachit>	 oh ok let me try that
[12:36:39] <Urbanecm>	 Nathan_fraignt, your patch will stop admins to get notifications on all tickets that already exist
[12:37:25] <Nathan_fraignt>	 Hmm, good point. Did not think about that. Should I make a command that generates watcher objects from all tickets?
[12:37:50] <rachit>	 Nathan_fraignt my code isn't working -local out = string.sub(str, 1, 1) string.upper(out)
[12:38:23] <Urbanecm>	 Nathan_fraignt, I recommend https://docs.djangoproject.com/en/2.1/topics/migrations/#data-migrations instead
[12:38:23] <Nathan_fraignt>	 The string.upper() function returns a string, that means you need to ¨catch¨ that return value
[12:38:36] <Nathan_fraignt>	 Thanks urbanecm, I´ll have a look
[12:38:39] <Urbanecm>	 yw
[12:38:52] <wikibugs>	 10MediaWiki-General-or-Unknown, 10TestMe: Sometimes sysops are temporarily not able to assign themself flood flag on wikis where they should - https://phabricator.wikimedia.org/T26826 (10Zoranzoki21) 05Open>03declined The answer was not given for 3 years, nobody reported the problem, so I closing this task...
[12:39:01] <Nathan_fraignt>	 So the normal way to that is to do first_letter_upper = string.upper(first_letter)
[12:39:43] <rachit>	 so do I have to change the out variable to first_letter_upper?
[12:39:56] <Nathan_fraignt>	 No, you´ll create a new variable
[12:40:15] <rachit>	 ok let me try
[12:40:17] <wikibugs>	 10MediaWiki-Categories: Allow more/fewer than 200 pages to be viewed at once in a category - https://phabricator.wikimedia.org/T13281 (10Aklapper) p:05Normal>03Low @MB-one: Do you [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | plan to work on fixing this task ]], a...
[12:40:24] <Nathan_fraignt>	 (and I would suggest renaming the out variable to something that describes what´s actually in it)
[12:40:33] <wikibugs>	 10MediaWiki-Internationalization, 10I18n, 10TestMe: Hard coded brackets in includes/specials/SpecialActiveusers.php - https://phabricator.wikimedia.org/T41846 (10Zoranzoki21) 05Open>03declined >>! In T41846#4484697, @MarcoAurelio wrote: > Cannot reproduce in the [[ https://gerrit.wikimedia.org/r/plugins/...
[12:40:42] <rachit>	 ok
[12:41:41] <rachit>	 Nathan_fraignt there's some error
[12:42:17] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech can you check it once ?
[12:42:32] <Nathan_fraignt>	 you used the variable first_letter, which you did not declare. In your case, it should be the variable out .
[12:42:54] <Nathan_fraignt>	 But again, I highly recommend renaming the variable out to something more descriptive
[12:44:20] <wikibugs>	 (03CR) 10Urbanecm: [C: 04-1] "<Urbanecm> Nathan_fraignt, your patch will stop admins to get notifications on all tickets that already exist" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[12:44:51] <rachit>	 Nathan_fraignt did that but now my letter disappeared
[12:44:59] <rachit>	 please check my sandbox once
[12:45:31] <Nathan_fraignt>	 You are still returning the variable out, but that is not the variable you want to return
[12:46:17] <rachit>	 yea sorry
[12:46:20] <rachit>	 edited
[12:46:38] <rachit>	 but the letter still hasn't capitalized Nathan_fraignt
[12:47:18] <Nathan_fraignt>	 No, because you are returning first_letter, not the variable you want to return.
[12:47:32] <Nathan_fraignt>	 Which would be the captialized version of first_letter
[12:47:35] <rachit>	 that's my variable no?
[12:47:45] <wikibugs>	 10MediaWiki-extensions-Other: MW MultiMaps extension: adding support for multiple URLs in Leaflet - https://phabricator.wikimedia.org/T210033 (10Aklapper) Ah. :) In that case you'll probably need to wait for maintainers to reply. Not sure how active @Pastakhov is these days.
[12:47:45] <Nathan_fraignt>	 It´s one of your variables, but not the one you want to return
[12:47:51] <rachit>	 oh so first_letter_uppercase?
[12:47:59] <takidelfin>	 hi Nathan_fraignt and rachit 
[12:48:03] <takidelfin>	 i'm back again
[12:48:07] <Nathan_fraignt>	 Hi takidelfin
[12:48:15] <rachit>	 Hey takidelfin
[12:48:35] <takidelfin>	 rachit: Lua tasks? :D
[12:48:53] <rachit>	 yes task #5
[12:49:15] <rachit>	 thanks Nathan_fraignt! got it :)
[12:49:26] <rachit>	 what are you upto takidelfin?
[12:49:52] <Nathan_fraignt>	 Nice rachit!
[12:58:14] <rachit>	 takidelfin
[12:58:22] <takidelfin>	 yup?
[12:58:27] <rachit>	 What does %d+ match in a Lua pattern?
[12:58:34] <takidelfin>	 all digits
[12:58:51] <rachit>	 what about %w+
[12:58:56] <takidelfin>	 Like: ddd 123 25 ddd - matches 123
[12:59:07] <takidelfin>	 %w+ matches all letters
[12:59:13] <takidelfin>	 in a sequence
[12:59:20] <rachit>	 ohh ohl
[12:59:22] <rachit>	 ohk
[12:59:27] <rachit>	 thank you
[12:59:32] <takidelfin>	 :)
[12:59:40] <takidelfin>	 That was answer for your task?
[13:00:07] <takidelfin>	 Check out the Lua Patterns docs to learn more: http://www.lua.org/manual/5.2/manual.html#6.4.1
[13:00:32] <takidelfin>	 * http://www.lua.org/manual/5.3/manual.html#6.4.1
[13:00:44] <takidelfin>	 rachit: ^ -- use the link above
[13:00:58] <rachit>	 thank you so much ! this is very helpful :)
[13:02:19] <Nathan_fraignt>	 Urbanecm, what would be a safe way to get the NOTIFICATION_TYPES from models.py into the migration? Can I just import it?
[13:03:19] <Nathan_fraignt>	 Asking cause I don´t know if that would be save if notifications types is edited afterwards. Or maybe I can just copy it into the file?
[13:05:23] <takidelfin>	 NOTIFICATION_TYPES are constants?
[13:05:38] <Nathan_fraignt>	 It is a constant, yes
[13:05:53] <takidelfin>	 so I think you can import it
[13:07:14] <Nathan_fraignt>	 Problem is, if the Notifications are edited in a migration after this one, this migrations will add unknown notifications 
[13:07:46] <Nathan_fraignt>	 Since the migrations run in order
[13:07:52] <takidelfin>	 :/
[13:08:03] <rachit>	 hi I had a doubt 
[13:08:04] <Nathan_fraignt>	 I think it´ll be fine, but I´d like urbanecm´s view on this
[13:08:10] <takidelfin>	 rachit: ?
[13:08:26] <takidelfin>	 Nathan_fraignt: :D
[13:08:28] <rachit>	 my step says "14. In a new paragraph in your user sandbox, write the pattern you would use to extract the day, month and year from an American-style date like "October 31, 2018"."
[13:08:39] <rachit>	 what do I have to do exactly>
[13:08:41] <rachit>	 ?
[13:08:49] <takidelfin>	 write a pattern 
[13:08:55] <takidelfin>	 it is like RegEx
[13:09:06] <rachit>	 ?
[13:09:09] <takidelfin>	 You need to use these %w+ %d+ 
[13:09:09] <Nathan_fraignt>	 Rachit, in your sentence function, you return first_letter_upper .."his is easy." . Meaning that it will only work when the sentence is ¨this is easy¨
[13:09:38] <rachit>	 yea..
[13:09:40] <rachit>	 so?
[13:10:04] <takidelfin>	 like: `Cake 15$` <-- pattern: `(%w+) (%d+)$`
[13:10:19] <Nathan_fraignt>	 So, your function probably won´t be accepted. Just trying to help you ^^
[13:10:28] <takidelfin>	 this pattern extracts 'Cake' and a cost of a cake '15'
[13:10:39] <rachit>	 um wait
[13:10:58] <rachit>	 first Nathan_fraignt can you tell me how to solve it?
[13:11:11] <rachit>	 the return thingy
[13:11:23] <takidelfin>	 rachit: just change his to this
[13:11:43] <Nathan_fraignt>	 Well, you should figure it out yourself. But you basically need to get the other part of the inputted sentence, and add that after the first letter
[13:13:05] <rachit>	 um  takidelfin after changing his to this now I have two 't's in the output
[13:13:33] <rachit>	 Nathan_fraignt haven't I done it already?
[13:13:33] <takidelfin>	 ah
[13:13:39] <takidelfin>	 sorry
[13:13:48] <takidelfin>	 I missunderstood your problem
[13:13:56] <takidelfin>	 Could you give me a link to our sandbox?
[13:14:00] <takidelfin>	 * module sandbox
[13:14:07] <wikibugs>	 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: connectedDevDebugAndroidTest task fails due to okhttp create() static method being removed by ProGuard - https://phabricator.wikimedia.org/T210347 (10svata.novak)
[13:14:16] <rachit>	 https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech
[13:14:28] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox
[13:14:54] <Nathan_fraignt>	 Rachit, you need to get the second part of the inputted string. This does not have to be ¨this is easy¨ it should also work with ¨this is hard¨ or ¨i like icecream¨
[13:14:55] <wikibugs>	 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: connectedDevDebugAndroidTest task fails due to okhttp ResponseBody.create() static method being removed by ProGuard - https://phabricator.wikimedia.org/T210347 (10svata.novak)
[13:15:21] <rachit>	 um ok let me try
[13:15:21] <takidelfin>	 yeah
[13:15:24] <Nathan_fraignt>	 I hope that makes it clearer, if not, maybe takidelfin can explain it better
[13:15:37] <takidelfin>	 you need to substing a str variable
[13:15:43] <takidelfin>	 from index 2
[13:17:31] <rachit>	 https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech
[13:17:41] <rachit>	 can you check it ?
[13:18:57] <rachit>	 Nathan_fraignt takidelfin ^
[13:19:21] <Nathan_fraignt>	 As far as I can see it looks good now
[13:19:33] <rachit>	 okay
[13:20:04] <takidelfin>	 yeah
[13:20:23] <rachit>	 takidelfin can you explain me the step I asked for ?
[13:20:34] <rachit>	  "14. In a new paragraph in your user sandbox, write the pattern you would use to extract the day, month and year from an American-style date like "October 31, 2018"." 
[13:20:37] <takidelfin>	 ok, I ll try
[13:20:39] <takidelfin>	 so
[13:20:45] <takidelfin>	 you need to write a lua pattern
[13:20:58] <takidelfin>	 that will extract month, year and day from string
[13:21:04] <takidelfin>	 this string is a date
[13:21:13] <takidelfin>	 October 31, 2018
[13:21:24] <takidelfin>	 or January 21, 2017
[13:21:25] <rachit>	 oh ok
[13:21:27] <takidelfin>	 so
[13:21:35] <rachit>	 ok ill try
[13:21:40] <takidelfin>	 ;D
[13:21:45] <takidelfin>	 ping me if you are stuck
[13:23:55] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox
[13:24:09] <rachit>	 please check the last para
[13:24:17] <rachit>	 why isn't it working?
[13:24:48] <rachit>	 takidelfin ^
[13:24:51] <takidelfin>	 umm
[13:25:23] <takidelfin>	 ate|mdydate=October 31 2018}}
[13:25:32] <takidelfin>	 you misses 'd' before mdydate
[13:25:38] <takidelfin>	 *missed
[13:25:42] <takidelfin>	 rachit: 
[13:26:03] <rachit>	 why do I need dmdydate?
[13:26:19] <rachit>	 its month day year right?
[13:26:52] <takidelfin>	 ahh
[13:26:59] <takidelfin>	 You are doing another step
[13:27:00] <takidelfin>	 k
[13:27:02] <takidelfin>	 so
[13:27:20] <rachit>	 I am doing step 14
[13:27:20] <takidelfin>	 because your function takes mdydate as a parametr
[13:27:33] <takidelfin>	 * dmydate
[13:27:41] <takidelfin>	 an you are trying to pass mdydate into it
[13:27:44] <takidelfin>	 *and
[13:28:07] <rachit>	 oh I changed it considering the order of month and day changed
[13:28:10] <rachit>	 let me try
[13:28:13] <takidelfin>	 Also, step 14 says that you need to write a pattern in your user sandbox , not in the module sanbox
[13:28:16] <takidelfin>	 *sandbox
[13:28:32] <takidelfin>	 :)
[13:28:55] <rachit>	 I am writing it in the user sandbox only
[13:29:05] <rachit>	 but its still showing an error
[13:29:14] <rachit>	 can you check it once 
[13:29:29] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox
[13:29:38] <rachit>	 takidelfin
[13:30:27] <rachit>	 takidelfin you there?
[13:30:39] <takidelfin>	 yup
[13:31:13] <takidelfin>	 uh..
[13:31:24] <takidelfin>	 At first: You need to modify your lua pattern
[13:31:28] <takidelfin>	 it is in string.match
[13:31:47] <takidelfin>	 but, you task says that you need to put this new pattern in your user sandbox
[13:31:56] <takidelfin>	 not in lua module sandbox
[13:32:25] <takidelfin>	 just write a pattern that you would pass into string.matc
[13:32:27] <takidelfin>	 *match
[13:33:08] <rachit>	 how?
[13:34:25] <rachit>	 really sorry but idk how to do that can you brief me on it takidelfin
[13:34:45] <takidelfin>	 local day, month, year = string.match(dmydate, "(%d+) (%w+) (%d+)")
[13:34:59] <takidelfin>	 there is your pattern stored
[13:35:05] <takidelfin>	 look at second argument of string.match
[13:35:17] <rachit>	 ya
[13:35:18] <takidelfin>	 "(%d+) (%w+) (%d+)
[13:35:34] <takidelfin>	 this pattern matches: digits word digits
[13:35:41] <rachit>	 yea
[13:35:46] <takidelfin>	 and this corresponds to 13 January 2018
[13:35:56] <rachit>	 right
[13:36:08] <takidelfin>	 and you need to write a pattern that matches January 13, 2018
[13:36:14] <rachit>	 yes
[13:36:20] <takidelfin>	       ^-- this colon is important
[13:36:34] <rachit>	 ok
[13:36:42] <rachit>	 you mean comma?
[13:36:43] <takidelfin>	 so, modify the pattern in string.match
[13:37:08] <takidelfin>	 to match January 13, 2018
[13:37:12] <rachit>	 i need to modify or make a new one?
[13:37:37] <takidelfin>	 to test your pattern copy this function 
[13:37:39] <takidelfin>	 change the name
[13:37:45] <takidelfin>	 and then start playing with a pattern
[13:37:58] <takidelfin>	 but remember to remove it after you will find right one
[13:38:15] <takidelfin>	 because you need to put final pattern in a paragraph in your user sandbox
[13:38:57] <takidelfin>	 tip: You shouldn't match ',' in a pattern. So put it outside matchin brackets '(' and ')'
[13:39:10] <takidelfin>	 these brackes extract the matched string to a variable 
[13:39:21] <rachit>	 canyou check my sandboxes once
[13:39:26] <takidelfin>	 k
[13:39:54] <takidelfin>	 um, you have removed a space character.
[13:40:03] <takidelfin>	 now your pattern will not work
[13:40:09] <rachit>	 in the module sandbox?
[13:40:30] <takidelfin>	 but you are on a correct way
[13:40:34] <takidelfin>	 rachit: yes
[13:40:52] <rachit>	 edited that
[13:41:14] <rachit>	 but still the answer is not correct
[13:41:20] <rachit>	 i mean the output
[13:41:24] <takidelfin>	 now look at  my 'tip'
[13:41:38] <takidelfin>	 because this  ' , ' is crucial
[13:41:59] <rachit>	 in the module sandbox
[13:42:01] <rachit>	 ?
[13:43:00] <rachit>	 takidelfin did that
[13:43:10] <wikibugs>	 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Bencemac) @Aklapper All I can say is that the majority (who participated in the discussion) still want the reverting.
[13:43:58] <wikibugs>	 10SpamBlacklist, 10Stewards-and-global-tools, 10Trust-and-Safety: Spam Blacklist shouldn't be fooled by similar-looking Unicode characters - https://phabricator.wikimedia.org/T14896 (10Pigsonthewing) A //decade-old// ticket reporting a  backdoor to the spam blacklist? Remarkable.
[13:44:03] <takidelfin>	 rachit: ;)
[13:44:06] <takidelfin>	 correct pattern
[13:44:06] <takidelfin>	 gj
[13:44:22] <rachit>	 but it doesn't work
[13:44:27] <rachit>	 in the output
[13:44:33] <takidelfin>	 yeah, because you are still passing a wrong argument
[13:44:42] <takidelfin>	 I told you to copy a function and paste it
[13:44:47] <takidelfin>	 then modify the name
[13:46:00] <takidelfin>	 also
[13:46:14] <takidelfin>	 first argument in string.match
[13:46:18] <takidelfin>	 is undefined variabl
[13:46:32] <takidelfin>	 because you have got dmydate defined
[13:46:38] <takidelfin>	 not mdydate
[13:48:10] <rachit>	 not working...
[13:48:18] <rachit>	 i mean i don't understand 
[13:48:23] <rachit>	 whats wrong
[13:48:44] <rachit>	 takidelfin
[13:49:34] <takidelfin>	 you have pasted the function in a wrong scope :(
[13:49:53] <takidelfin>	 you need to paste it outside a function unpackdate
[13:50:03] <takidelfin>	 and remember to change name from unpackdate to something esle
[13:50:06] <takidelfin>	 *else
[13:50:28] <rachit>	 what is a scope?
[13:51:38] <rachit>	 takidelfin
[13:51:39] <takidelfin>	 http://lua-users.org/wiki/ScopeTutorial
[13:52:12] <takidelfin>	 Maybe this will help you understand what is the scope
[13:53:22] <takidelfin>	 maybe I should use other word to refer to 'placing' of function definition
[13:53:23] <takidelfin>	 🤔
[13:54:29] <rachit>	 takidelfin i am so sorry
[13:54:38] <rachit>	 i am just very confused rn
[13:54:41] <rachit>	 :{
[13:54:43] <takidelfin>	 :(
[13:54:49] <rachit>	 :(
[13:55:10] <rachit>	 can you check my module sandbox and start again please?
[13:55:18] <takidelfin>	 okay :)
[13:55:20] <rachit>	 i am so sorry
[13:55:23] * Urbanecm waves
[13:55:40] <rachit>	 urbanecm help required 
[13:55:47] <takidelfin>	 rachit: move p.trial function outside p.unpackdate
[13:55:53] * takidelfin waves too
[13:56:07] <Urbanecm>	 takidelfin, if I'm looking correctly, just indentation is wrong
[13:56:39] <takidelfin>	 🤦‍♂️ yes... Sorry , thats my fault
[13:56:58] <takidelfin>	 Thats why indentation is important :/
[13:56:59] <rachit>	 takidelfin isn't it already outside p.unpackdate
[13:57:04] <takidelfin>	 yeah it is
[13:57:13] <takidelfin>	 just your identation confused me
[13:57:15] <takidelfin>	 sorry
[13:57:15] <takidelfin>	 :(
[13:57:23] <rachit>	 wdym :(
[13:57:31] <rachit>	 urbanecm can you help please?
[13:57:41] <Urbanecm>	 if you ask a question :)
[13:58:23] <rachit>	 the step 14 task # 5 says "14. In a new paragraph in your user sandbox, write the pattern you would use to extract the day, month and year from an American-style date like "October 31, 2018""
[13:58:59] <takidelfin>	 Urbanecm: Could I publish one little change to rachit's module sandbox? Just identation change (to prevent mistakes)
[13:59:24] <Urbanecm>	 It's fine with me as long as it's fine with rachit, as it is his sandbox
[13:59:49] <rachit>	 can you check my module sandbox and user sandbox and tell me where am i going wrong?
[13:59:50] <Urbanecm>	 rachit, and what you don't understand on that step?
[14:00:19] <rachit>	 i don't understand on how to imply it
[14:00:51] <takidelfin>	 rachit: Could I fix these indentaion issues in your Lua code?
[14:01:09] <rachit>	 sure
[14:02:04] <rachit>	 urbanecm you there>
[14:02:08] <rachit>	 ?
[14:02:09] <Urbanecm>	 yeah
[14:02:21] <rachit>	 i need a little guidance
[14:02:36] <Urbanecm>	 do you understand what the step wants you to do?
[14:02:41] <rachit>	 ya
[14:02:55] <Urbanecm>	 do you know what pattern is?
[14:03:02] <rachit>	 not exactly
[14:03:26] <takidelfin>	 rachit: http://lua-users.org/wiki/PatternsTutorial
[14:03:33] <takidelfin>	 Introduction to patterns in Lua
[14:03:40] <takidelfin>	 Lua patterns can match sequences of characters, where each character can be optional, or repeat multiple times. If you're used to other languages that have regular expressions to match text, remember that Lua's pattern matching is not the same: it's more limited, and has different syntax.
[14:03:46] <takidelfin>	 ~ link above
[14:03:46] <rachit>	 i saw that but couldn't understand much
[14:04:02] <Urbanecm>	 Okay. I just found again your user and module sandbox
[14:04:08] <Urbanecm>	 I see you have an error in step before 14th
[14:04:41] <Urbanecm>	 If you open your user sandbox, do you see the red bold errors?
[14:04:47] <rachit>	 yes
[14:04:52] <takidelfin>	 (that is because he/she modified it when trying to find right pattern)
[14:05:09] <rachit>	 right 
[14:05:19] <rachit>	 he* lol
[14:05:32] <Urbanecm>	 it's because you declare variable on line 60 with one name, and uses it with different name on the next line
[14:06:34] <Urbanecm>	 can you fix it, please?
[14:06:35] <takidelfin>	 and this causes errors in your user sandbox
[14:06:56] <rachit>	 edited that but still not working
[14:07:22] <Urbanecm>	 that's because another issue
[14:07:32] <rachit>	 edited
[14:07:46] <rachit>	 step 13 isn't an error anymore
[14:07:54] <Urbanecm>	 great
[14:07:59] <Urbanecm>	 let's move to step 14
[14:08:03] <rachit>	 yes
[14:08:20] <Urbanecm>	 step 14 is theoretical and doesn't want you to write any code
[14:08:28] <rachit>	 um ok
[14:08:46] <Urbanecm>	 Your function parses date that looks like "31 October 2018". In English, you can write dates like "October 31, 2018"
[14:08:53] <Urbanecm>	 (you can write date like ... too)
[14:08:55] <rachit>	 yes
[14:09:11] <Urbanecm>	 what pattern you would use to parse this text?
[14:09:40] <Urbanecm>	 simply answer here, no need to edit your sandboxes now
[14:10:14] <rachit>	 %w+ %d+ %d+?
[14:10:26] <Urbanecm>	 almost :)
[14:10:38] <Urbanecm>	 check your pattern character by character and find a little mistake in it
[14:11:16] <rachit>	 idk the plus signs?
[14:11:41] <Urbanecm>	 No
[14:12:04] <rachit>	 what else ? :(
[14:12:05] <Urbanecm>	 %d means "any digit, but only once". 
[14:12:14] <Urbanecm>	 %d+ means "match as many digits as possible"
[14:12:14] <rachit>	 yes
[14:12:36] <rachit>	 yes
[14:12:43] <rachit>	 so whats the mistake ?
[14:12:51] <Urbanecm>	 but your date doesn't contain only alphanumeric characters and digits
[14:12:59] <Urbanecm>	 there is also one other character your pattern doesn't contain
[14:13:07] <Urbanecm>	 remember that patterns matches almost everything literally
[14:13:17] <Urbanecm>	 Nathan_fraignt, are you still here? I have thought about your patch and maybe a better solution than you choose is available. I'd like to discuss my idea with you
[14:13:58] <rachit>	 is it . ?
[14:14:07] <wikibugs>	 (03PS5) 10Flutterish: SVG files display at max resolution [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237)
[14:14:07] <Urbanecm>	 do you see a dot in the date?
[14:14:18] <rachit>	 yes 
[14:14:24] <takidelfin>	 o?
[14:14:31] <Urbanecm>	 really? where?
[14:14:50] <rachit>	 no i mean the date matches everything
[14:14:54] <takidelfin>	 isn't it a comma?
[14:15:08] <rachit>	 in the date?yes
[14:15:11] <takidelfin>	 XX January, 2018
[14:15:53] <rachit>	 yes comma 
[14:16:22] <Urbanecm>	 do you think your pattern will match it?
[14:16:33] <rachit>	 oh wait
[14:16:48] <rachit>	 %w+ %d+, %d+? 
[14:17:02] <Urbanecm>	 that's better
[14:17:19] <Urbanecm>	 all that step 14 wants you to do is to answer this question on a new line of your user sandbox
[14:17:37] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] SVG files display at max resolution [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish)
[14:17:51] <rachit>	 "(%w+) (%d+), (%d+)")
[14:17:54] <rachit>	 ?
[14:18:20] <rachit>	 urbanecm
[14:18:26] <Urbanecm>	 I'm still here :)
[14:18:41] <Urbanecm>	 the ") isn
[14:18:45] <Urbanecm>	 isn't part of a pattern
[14:18:54] <Urbanecm>	 but yes, what you wrote just before a sec is correct
[14:18:56] <wikibugs>	 (03PS6) 10Flutterish: SVG files display at max resolution [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237)
[14:19:00] <Urbanecm>	 paste it into your _user sandbox_, please
[14:19:02] <takidelfin>	 \o/
[14:19:14] <takidelfin>	 rachit: congratulations 
[14:19:27] <rachit>	 https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox#Task_5 is this correct?
[14:20:04] <Urbanecm>	 yeah, pattern is good. Ad Q1 and Q2, can you explain more what the plus sign is about please?
[14:21:11] <rachit>	 plus sign means 1 or more repetitions of characters in the class right ? urbanecm
[14:21:37] <Urbanecm>	 Yep. Can you edit your answer to include this?
[14:21:54] <rachit>	 ok sure
[14:21:59] <rachit>	 thank you :)
[14:22:18] <rachit>	 thank you takidelfin :D 
[14:22:37] <rachit>	 and a huge sorry for the inconveniences caused
[14:23:23] <Urbanecm>	 yw
[14:24:14] <takidelfin>	 only 17 days left for gci 
[14:24:17] <takidelfin>	 :(
[14:24:21] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: User that was created by OAuth cannot set password - https://phabricator.wikimedia.org/T209320 (10Urbanecm) 05Open>03Resolved
[14:24:37] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: After an account is registered, it isn't automatically logged in - https://phabricator.wikimedia.org/T210334 (10Urbanecm) 05Open>03Resolved
[14:25:09] <wikibugs>	 10WMCZ-Tracker: Squash "Ticket changed" and "Ticket changed [for requestor]" notification types in frontend - https://phabricator.wikimedia.org/T208658 (10Urbanecm) 05Open>03Invalid Isn't necessary anymore.
[14:25:39] <rachit>	 Urbanecm  i have submitted my task,please check it whenever you are free :')
[14:25:39] <Urbanecm>	 takidelfin, you can contribute to Wikimedia even when no GCI's running :D
[14:25:57] <Urbanecm>	 ok
[14:26:43] <takidelfin>	 Urbanecm: :D Hopefuly
[14:26:59] <Urbanecm>	 It depends only on your availability, nothing more :D
[14:27:22] <Urbanecm>	 rachit, approved
[14:27:45] <takidelfin>	 I have learnt almost 4 now languages (Lua, Ruby, Crystal, And now learning Python) during 1.5 month. big wow for me
[14:28:11] <takidelfin>	 So contributing more will help me learn more languages yeay
[14:29:02] <takidelfin>	 *I dont know why I put 'now' after 4 
[14:31:24] <Urbanecm>	 I read it as "new", maybe that's what you meant?
[14:32:02] <takidelfin>	 yes D:
[14:33:03] <takidelfin>	 Urbanecm: Umm, does flake8 require a config ? Because when I try running flake 8 --select=W504 it does not work ;-;
[14:33:32] <Urbanecm>	 what does "it doesn't work" mean?
[14:34:07] <takidelfin>	 it does not return anything
[14:34:20] <takidelfin>	 and when I try running it without arguments
[14:34:27] <takidelfin>	 It returns a list of E241 violations
[14:34:46] <takidelfin>	 That is why I'm assuming that there is missing config
[14:35:21] <takidelfin>	 (I'm working on Pywikibot flake8 W504 )
[14:35:31] <takidelfin>	 (Maybe there is a command like bundle for Rails)
[14:41:39] <wikibugs>	 (03PS1) 10Urbanecm: Convert notification to Czech [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475616
[14:49:17] <takidelfin>	 :/
[14:52:45] <Nathan_fraignt>	 Urbanecm, I´m back! Let´s hear your idea!
[14:58:45] <takidelfin>	 :(
[14:59:36] <takidelfin>	 Urbanecm: Okay, I have got it.  It is `flake8 --ignore W503 --select W504`
[14:59:48] <takidelfin>	 maybe somehow a hacky way, but it works
[15:01:20] <Urbanecm>	 Nathan_fraignt, what about sending all notifications to admin in case they have not any Watcher object connected with particular ticket and only notifications matching the Watcher object in case they have?
[15:01:51] <Urbanecm>	 This will save database space, as you won't have to have explicit Watcher objects for everything, but will still allow admins to override their notifications at any level
[15:02:23] <Urbanecm>	 Your solution won't allow an admin to get all notifications about topic A, but only "ticket_new" for topic B
[15:02:34] <Nathan_fraignt>	 Urbanecm, that´s quite smart. And just create a watcher object when an admin saves the watch ticket form
[15:03:00] <Urbanecm>	 saves the watch ticket form and doesn't have everything checked
[15:03:10] <Nathan_fraignt>	 Yes
[15:03:17] <Nathan_fraignt>	 I´ll work on it
[15:03:35] <takidelfin>	 noice tips here I see
[15:03:54] <Urbanecm>	 takidelfin, nice to see your issue was resolved. Sorry, I forgot you asked me something :D
[15:04:25] <Urbanecm>	 Ok, that's nice Nathan_fraignt . Looking forward to see new patch!
[15:07:27] <wikibugs>	 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10User-notice: A translatable subpage page should not be messed while moving subpages - https://phabricator.wikimedia.org/T114592 (10Nikerabbit)...
[15:10:54] <Nathan_fraignt>	 Urbanecm, what is the best way to test/debug the fire_notification function?
[15:11:30] <Urbanecm>	 I personally just make changes in the local webinterface, connect to mysql directly and look into tracker_notification table
[15:11:58] <Nathan_fraignt>	 hmm
[15:12:06] <Urbanecm>	 but you can also call the function in manage.py shell
[15:12:14] <Nathan_fraignt>	 you can?
[15:12:35] <Urbanecm>	 yes, you can invoke a shell by doing python manage.py shell and in this shell you can run arbitrary code
[15:12:38] <takidelfin>	 Urbanecm: I have got one question related to this Python code. I think that this code contains a syntax error https://usercontent.irccloud-cdn.com/file/RwR8KMYq/screenshot_20181125_151635.png
[15:12:49] <takidelfin>	 because there is 'string' 'string' 
[15:12:57] <takidelfin>	 without any operator
[15:13:05] <Urbanecm>	 let me see takidelfin 
[15:13:09] <takidelfin>	 But I don't know ;-;
[15:13:45] <Nathan_fraignt>	 its between ´(´ ´)´
[15:13:55] <Nathan_fraignt>	 the brackets make it so you can format a string on multiple lines
[15:14:21] <Nathan_fraignt>	 At least I think that is what you mean
[15:14:28] <Urbanecm>	 https://ctrlv.cz/YO0a
[15:14:38] <Urbanecm>	 you can use this syntax to put strings together
[15:15:09] <Urbanecm>	 Gotta go, dinner, be back in a minute
[15:15:12] <takidelfin>	 oh, okay! Thanks :D
[15:15:29] <takidelfin>	 I haven't saw something like this in other languages
[15:15:42] <Nathan_fraignt>	 Cya, eetsmakelijk! (No clue how to say that in English, it means ¨to enjoy your dinner¨)
[15:15:59] <takidelfin>	 haha
[15:16:03] <takidelfin>	 Smacznego!
[15:24:28] <rachit>	 Hello!\
[15:25:12] <rachit>	 is anyone there?
[15:26:56] <rachit>	 Hi prtksxna
[15:27:28] <rachit>	 urbanecm are you there?
[15:27:36] <Urbanecm>	 Nathan_fraignt, https://en.wiktionary.org/wiki/enjoy_your_meal :)
[15:27:38] <Urbanecm>	 yep
[15:27:40] <prtksxna>	 Hey rachit o/ 
[15:27:53] <wikibugs>	 04(no projects): Allow edits that touch multiple pages and that can still be undone with single click - https://phabricator.wikimedia.org/T210348 (10ChristianKl)
[15:27:59] <rachit>	 I had a doubt urbanecm
[15:28:02] <Nathan_fraignt>	 Thanks hahaha :)
[15:28:06] <Urbanecm>	 prtksxna, do you think you can review https://gerrit.wikimedia.org/r/c/jsdoc/wmf-theme/+/475582?
[15:28:24] <Urbanecm>	 Nathan_fraignt, it was an answer to "how to express it in English" +;)
[15:28:25] <prtksxna>	 Urbanecm: Yep, came online just to review that :) 
[15:28:44] <Nathan_fraignt>	 Yeah I got it :) I knew the expression, just couldn
[15:28:48] <Nathan_fraignt>	 ´´ t think of it
[15:28:57] <rachit>	 step 3 of lua #4 says "3. Based on the function above, create a new function p.fallbacks in your module sandbox that takes a parameter |langcode= (which represents a language code), and uses mw.language.getFallbacksFor( langcode ) to return a list of all of the fallback language codes for that code. Save your module sandbox."
[15:29:22] <rachit>	 can you tell me how to set the parameter of the function urbanecm
[15:29:33] <rachit>	 in module sandbox?
[15:30:39] <rachit>	 urbanecm are you there?
[15:33:05] <wikibugs>	 (03CR) 10Prtksxna: [V: 032 C: 032] "Thanks for working on this Shreyasminocha!" [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) (owner: 10Shreyasminocha)
[15:33:24] <Urbanecm>	 thanks prtksxna 
[15:33:48] <Urbanecm>	 rachit, do you know how you call functions?
[15:33:59] <wikibugs>	 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Lsanabria) es-r3 is complete.
[15:34:17] <rachit>	 Urbanecm: in the user sandbox yes
[15:34:37] <Urbanecm>	 do you remember how you called the Temperature function, that needed parameter called "celsius"?
[15:35:05] <rachit>	 yes
[15:35:18] <wikibugs>	 10Google-Code-in-2018, 10JSDoc WMF theme, 10Patch-For-Review, 10Technical-Debt: Implement linting for JSDoc Wikimedia theme own specific styles and scripts - https://phabricator.wikimedia.org/T209561 (10Prtksxna) 05Open>03Resolved
[15:35:21] <rachit>	 I did that in the user sandbox using invoke code right?
[15:35:53] <Urbanecm>	 yeah
[15:36:04] <Urbanecm>	 and do you know how you accessed the parameter's value in the module?
[15:36:16] <rachit>	 yes
[15:36:43] <rachit>	 Celsius=?
[15:37:11] <wikibugs>	 10Google-Code-in-2018, 10JSDoc WMF theme: JSDoc WMF theme: Fix JS and CSS linting issues - https://phabricator.wikimedia.org/T210349 (10Prtksxna)
[15:37:45] <wikibugs>	 10Google-Code-in-2018, 10JSDoc WMF theme, 10Patch-For-Review, 10Technical-Debt: Implement linting for JSDoc Wikimedia theme own specific styles and scripts - https://phabricator.wikimedia.org/T209561 (10Prtksxna) See also: {T210349}
[15:38:42] <rachit>	 urbanecm are you there?
[15:38:48] <Urbanecm>	 yeah
[15:39:03] <Urbanecm>	 no, you accessed the parameter's value by different syntax
[15:39:21] <wikibugs>	 10ContentTranslation: Reorganize Language team's stats dashboards scripts - https://phabricator.wikimedia.org/T210350 (10Amire80)
[15:40:01] <rachit>	 urbanecm what was it?
[15:40:08] <Urbanecm>	 read through your code
[15:40:41] <Urbanecm>	 we're not here to do your tasks for you, we can answer you questions you have, but we cannot write code you need to use line by line
[15:40:55] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Identify common abuse filters that affect translations - https://phabricator.wikimedia.org/T189475 (10Amire80)
[15:41:00] <wikibugs>	 10WMCZ-Tracker: Internacionalize notifications - https://phabricator.wikimedia.org/T196425 (10Urbanecm)
[15:42:21] <prtksxna>	 Urbanecm: Done! Thanks for the reminder :D 
[15:42:21] <rachit>	 urbanecm is it if then else?
[15:42:43] <Urbanecm>	 no, that's for tests
[15:43:02] <rachit>	 tonumber ?
[15:44:03] <Urbanecm>	 do you really think something that's called "tonumber" will give you value of a parameter?
[15:44:31] <rachit>	 not really...
[15:44:42] <rachit>	 fah?
[15:45:41] <Urbanecm>	 please think about an answer for 5 minutes before you post it here. How did you access the value of parameter "celsius" in previous lua tasks?
[15:45:53] <takidelfin>	 parameter also can be called argument
[15:49:47] <wikibugs>	 (03PS2) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[15:50:29] <Nathan_fraignt>	 Alright Urbanecm, It took a bit longer than expected, but I think I kinda got it. Again, probably not perfect yet.
[15:50:40] <Urbanecm>	 Looking
[15:51:26] <rachit>	 urbanecm: all I did in the previous task was to put |celsius=number in the user sandbox
[15:51:38] <Urbanecm>	 yes, that's how you passed the parameter to the function
[15:51:46] <Urbanecm>	 my question is how you accessed it in your code - module sandbox
[15:53:02] <Urbanecm>	 Nathan_fraignt, looks your function isn't sending anything to ticket.requested_user
[15:53:14] <Urbanecm>	 aka the ticket owner/requestor
[15:53:32] <Nathan_fraignt>	 Which function?
[15:53:36] <Urbanecm>	 fire_notification
[15:54:03] <Nathan_fraignt>	 The owner should have watchers
[15:54:07] <rachit>	 urbanecm I don't know :(
[15:54:11] <Nathan_fraignt>	 I think
[15:54:51] <Urbanecm>	 ah, I didn't open the view
[15:55:36] <Urbanecm>	 thanks, mea culpa
[15:56:12] <Nathan_fraignt>	 In theory, the owner of a ticket should have all the watchers. I might be able to do the same with the owner as with the admins (so don´t give them watchers unless they change them), but part of the task was to make so that only one thing handles the notifications
[15:56:13] <Nathan_fraignt>	 I think
[15:56:48] <Nathan_fraignt>	 ¨This should make notifications easier, as there will be only one way how to get a notification - by having *Watcher object.¨
[15:57:12] <Urbanecm>	 No, this solution is right, I just didn't notice you added this into the view
[15:57:18] <takidelfin>	 legoktm: Hello! Could you please review my task? 
[15:57:20] <Urbanecm>	 (s/right/fine/g)
[15:58:08] <rachit>	 urbanecm, the temperature function uses the variable cel,fah and if then else code right?
[15:58:29] <takidelfin>	 yes...
[15:58:32] <takidelfin>	 so?
[15:59:07] <Urbanecm>	 rachit, you declared cel variable and assigned value of parameter celsius to it. How did you do it?
[15:59:27] <Urbanecm>	 Nathan_fraignt, while I'm reviewing your patch, can you look on T196425 and tell me if this is doable using info I provided in the task's description? I plan to convert into a GCI task too, I'm just not sure if it's understandable to somebody else than ,e
[15:59:28] <stashbot>	 T196425: Internacionalize notifications - https://phabricator.wikimedia.org/T196425
[15:59:29] <Urbanecm>	 *me
[15:59:45] <Nathan_fraignt>	 I´ll have a look
[16:00:11] <Urbanecm>	 thanks
[16:00:16] <rachit>	 urbanecm, cel = frame.args.celsius?
[16:00:51] <Urbanecm>	 yeah, that's the row you did the assignment at. Which piece of this line contains the parameter value itself?
[16:01:15] <rachit>	 Celsius no?
[16:02:20] <Urbanecm>	 pure celsius won't work
[16:02:35] <rachit>	 frame.args.celsius ?
[16:02:36] <Urbanecm>	 you need to prefix the name of the parameter with somethign
[16:02:38] <Urbanecm>	 yeah
[16:02:39] <Urbanecm>	 exactly
[16:02:53] <rachit>	 okay
[16:03:08] <Nathan_fraignt>	 Urbanecm, As far as I understand, the task is to change the Czech texts to English, but with the localization function. Also, the parameters within the Czech text are in different order than those in English
[16:03:52] <Urbanecm>	 yes, it's to make it easier for those who cannot speak Czech to touch notification-related code
[16:04:15] <Nathan_fraignt>	 Yeah, I´m happy I did not have to touch messages in models.py
[16:04:19] <rachit>	 urbanecm,how do I imply it on my current step 
[16:04:42] <rachit>	 my current step 3 of task 5 says " Based on the function above, create a new function p.fallbacks in your module sandbox that takes a parameter |langcode= (which represents a language code), and uses mw.language.getFallbacksFor( langcode ) to return a list of all of the fallback language codes for that code. Save your module sandbox."
[16:04:55] <Urbanecm>	 yeah
[16:05:25] <Urbanecm>	 so you need to create a new function that will accept parameter langcode and print a list of fallback language codes for that language
[16:05:39] <Urbanecm>	 with knowledge you earned in previous tasks it should be doable
[16:05:49] <rachit>	 ok ill try
[16:06:18] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Amire80)
[16:07:53] <wikibugs>	 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) Google Code-in task: https://codein.withgoogle.com/tasks/5408647254376448/.
[16:10:50] <rachit>	 urbanecm, https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech can you tell me where am I going wrong?
[16:13:49] <rachit>	 takidelfin,are you there?
[16:13:56] <takidelfin>	 ye
[16:14:06] <rachit>	 can you help me ?
[16:15:10] <rachit>	 takidelfin ?
[16:15:40] <Urbanecm>	 Nathan_fraignt, I can successfully set Tracker to send me only comment notifications on particular ticket
[16:15:55] <Urbanecm>	 However, Tracker allow users to watch whole topics or even grants
[16:16:21] <Urbanecm>	 I don't see watch settings link on a topic page
[16:17:11] <Urbanecm>	 also, I cannot completely mute a ticket. A solution can be to create dummy notification type "mute" and add it in case admin saves an empty form
[16:17:19] <wikibugs>	 10Google-Code-in-2018, 10MinervaNeue, 10Readers-Web-Backlog, 10Need-volunteer: PHPUnit test case warning about Special:Notifications missing aliases in SkinMinervaTest - https://phabricator.wikimedia.org/T202308 (10Shreyasminocha) a:03Shreyasminocha
[16:17:52] <takidelfin>	 rachit: langcode is a array
[16:17:56] <takidelfin>	 * an
[16:18:53] <Nathan_fraignt>	 Hmmm, I´ll look into muting first
[16:19:06] <rachit>	 can you guide me on how to fix it ? takidelfin
[16:19:28] <takidelfin>	 Try googling how to iterate over Lua array
[16:19:32] <takidelfin>	 (for i)
[16:20:10] <Urbanecm>	 or look on your previous functions, you already did it once
[16:20:29] <Urbanecm>	 up to you Nathan_fraignt
[16:20:52] * Urbanecm is going to walk a dog, brb
[16:23:36] <takidelfin>	 ~ waves ~
[16:26:17] <wikibugs>	 10MediaWiki-General-or-Unknown: Allow edits that touch multiple pages and that can still be undone with single click - https://phabricator.wikimedia.org/T210348 (10MarcoAurelio)
[16:27:46] <wikibugs>	 (03PS3) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[16:37:32] * Urbanecm is back
[16:43:07] <wikibugs>	 (03PS4) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[16:44:06] <Nathan_fraignt>	 Urbanecm, it is now possible to select nothing, topics can now be watched. You also said something about grants, but AFAIK they always worked fine since they do not have an owner
[16:44:57] <Urbanecm>	 Sorry, you're right, don't know why I talked about them
[16:45:11] <Nathan_fraignt>	 No problem at all
[17:09:07] * Nathan_fraignt is now having dinner
[17:21:45] <wikibugs>	 (03CR) 10Urbanecm: [C: 04-1] Change: All notifications will now go via watcher object (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[17:22:11] <Urbanecm>	 Nathan_fraignt, reviewed. I hope my inline comment on line 946 is understandable, ask if it isn't
[17:54:04] <wikibugs>	 10ContentTranslation: CX2: Unable to type diacritics in the translation - https://phabricator.wikimedia.org/T209874 (10He7d3r) I was not able to reproduce the bug using Visual Editor (on Firefox). The problem happens with Firefox 63.0.3 (64-bit), on Ubuntu 18.04.1 LTS. This is the keyboard layout: {F27312035}  W...
[17:56:07] <wikibugs>	 (03PS9) 10D3r1ck01: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296
[18:06:50] <takidelfin>	 RexxS: /o
[18:06:53] <takidelfin>	 * o/
[18:12:26] <RexxS>	 hey takidelfin
[18:26:26] <wikibugs>	 10WMCZ-Tracker: Datatables isn't working on /users/<username> - https://phabricator.wikimedia.org/T210351 (10Urbanecm)
[18:26:55] <wikibugs>	 (03CR) 10VolkerE: [C: 04-1] "Everything else looks good." (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[18:29:56] <wikibugs>	 (03PS5) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[18:30:39] <Nathan_fraignt>	 Urbanecm, New patch. Honestly don´t know if it´s bug free. This task is turning out to be a lot harder than expected :)
[18:30:46] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[18:31:19] <Nathan_fraignt>	 Oh let me fix the style first
[18:32:53] <Urbanecm>	 Yeah, it's one of the most difficult Tracker tasks, which correspond with me giving you 7 days (the maximum) to complete the task
[18:33:33] <Nathan_fraignt>	 Let´s see if I can still do it within one
[18:33:54] <Urbanecm>	 I hope you find the difficulty challenging rather than annoying :)
[18:34:45] <wikibugs>	 (03PS6) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[18:35:11] <Nathan_fraignt>	 Mostly challenging, but the fact that I don´t know how some of the code works can be kinda annoying at times :)
[18:35:44] <Urbanecm>	 :)
[18:36:13] <Nathan_fraignt>	 I´m getting more and more familiar with Tracker codebase, but every now and then you have a function that just takes ages before you understnad why it´s there (and then come to the conclusion that you didn´t need it at all)
[18:36:36] <takidelfin>	 Urbanecm: Umm, I have got one question related to W504 Line break after binary operator. https://hastebin.com/gehuhafudu.python
[18:36:36] <takidelfin>	 Which variant looks better?
[18:37:37] <Nathan_fraignt>	 I´d say #2
[18:38:07] <Urbanecm>	 Me too
[18:38:10] <Nathan_fraignt>	 But to be honest I wouldn´t write it like either of them (although completely refractoring is not something you need to do I think)
[18:38:14] <takidelfin>	 okay :D
[18:39:12] <Nathan_fraignt>	 Urbanecm, looks like the bot is happy, I´m gonna do some chores and take a shower. Good luck with reviewing, I´ll probably be back in ~2 hours
[18:39:17] * Nathan_fraignt is now away
[18:39:25] <takidelfin>	 ~o~
[18:39:50] <wikibugs>	 (03CR) 10Bartosz Dziewoński: [C: 032] mediawiki.ui: Move remaining mixin to buttons.less; remove mixins.less [core] - 10https://gerrit.wikimedia.org/r/475509 (owner: 10VolkerE)
[18:39:56] * Urbanecm suggests Nathan_fraignt to use /away MESSAGE
[18:40:18] * Nathan_fraignt Did not know that existed
[18:41:33] <Urbanecm>	 You can then use /back to mark you're back
[18:42:24] <takidelfin>	 sadly legoktm is still away :/
[18:43:16] <wikibugs>	 (03CR) 10Bartosz Dziewoński: [C: 032] Change check to canHaveTalkPage before calling getTalkPage() [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/475584 (https://phabricator.wikimedia.org/T172146) (owner: 10Arcayn)
[18:46:59] <wikibugs>	 (03CR) 10Bartosz Dziewoński: [C: 032] "Seems harmless. Note that this would behave differently if the 'sandbox' key was already set (e.g. by another extension), but we don't rea" [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/475596 (owner: 10John Erling Blad)
[18:47:40] <wikibugs>	 10WMCZ-Tracker: addexampledatay command doesn't set the password correctly - https://phabricator.wikimedia.org/T210352 (10Urbanecm)
[18:48:57] <wikibugs>	 10ContentTranslation: Reorganize Language team's stats dashboards scripts - https://phabricator.wikimedia.org/T210350 (10Amire80)
[18:48:59] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Amire80)
[18:49:21] <wikibugs>	 10WMCZ-Tracker: addexampledata command doesn't set the password correctly - https://phabricator.wikimedia.org/T210352 (10Urbanecm)
[18:49:55] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Amire80) I did the first two trivial points.  For the rest, we should do if together with T210350 because it will require redeployment.
[18:50:48] <takidelfin>	 hello bawolff!
[18:51:31] <bawolff>	 Hey
[18:52:05] <wikibugs>	 10Google-Code-in-2018, 10JSDoc WMF theme: JSDoc WMF theme: Fix JS and CSS linting issues - https://phabricator.wikimedia.org/T210349 (10D3r1ck01) Imported as: https://codein.withgoogle.com/tasks/5320968315600896/
[18:52:05] <bawolff>	 oh crap
[18:52:19] <bawolff>	 Someone did one of my gci tasks, and i totally didn't notice
[18:52:24] <bawolff>	 And now its been almost 72 hours :(
[18:52:28] <takidelfin>	 :(
[18:52:37] * bawolff feels bad
[18:52:49] <Platonides>	 oops
[18:53:12] <bawolff>	 Oh wait, it hasn't been 72 hours
[18:53:18] <bawolff>	 Well this is confusing
[18:53:20] <takidelfin>	 (>ლ)
[18:53:39] <bawolff>	 submitted for review on November 24, 2018 at 11:26
[18:53:46] <bawolff>	 Ok, so /me not totally terrible
[18:53:46] <takidelfin>	 ・-・
[18:53:57] <bawolff>	 that was only yesterday
[18:54:26] <bawolff>	 Then why is google yelling at me, that it needs review in the next 12 hours
[18:54:41] <RexxS>	 24 hours and you get an email
[18:54:57] <RexxS>	 just mark it as spam
[18:55:02] <Platonides>	 lol
[18:55:40] <bawolff>	 ah ok, I was worried I was getting into trouble :)
[18:56:08] <takidelfin>	 I'm waiting just 10 hours ;-;
[18:56:19] <Platonides>	 hmm, "2. You agree to respond to contestant requests within thirty-six (36) hours."
[18:56:37] <Platonides>	 24 + 12 = 36
[18:56:39] <bawolff>	 oh, i thought it was 72
[18:56:46] * bawolff should read the rules
[18:56:48] <Platonides>	 so it seems Google has the math right
[18:56:52] <takidelfin>	 tam dam dam
[18:57:44] <wikibugs>	 10WMCZ-Tracker: In watch.html, the "All" notification should be checked if all other notifications are - https://phabricator.wikimedia.org/T210353 (10Urbanecm)
[18:57:46] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Amire80) @Milimetric, do you know why is "undefined" shown there? I cannot see anything like that in the [[ https://analytics.wikimedia.org/datasets...
[19:01:41] <wikibugs>	 10WMCZ-Tracker: Users created by addexampledata comment don't have TrackerPreferences object - https://phabricator.wikimedia.org/T210354 (10Urbanecm)
[19:02:09] <wikibugs>	 10CX-analytics, 10Language-Team (Language-2018-October-December): Adjust MT graph to clarify the presented concepts - https://phabricator.wikimedia.org/T210135 (10Amire80) The current query filters things out like this: `cxc_origin not in ('disable-mt', 'no-mt', 'user', 'source', 'source-mt')`  If I don't filt...
[19:03:47] <wikibugs>	 (03Merged) 10jenkins-bot: mediawiki.ui: Move remaining mixin to buttons.less; remove mixins.less [core] - 10https://gerrit.wikimedia.org/r/475509 (owner: 10VolkerE)
[19:03:49] <wikibugs>	 (03Merged) 10jenkins-bot: Change check to canHaveTalkPage before calling getTalkPage() [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/475584 (https://phabricator.wikimedia.org/T172146) (owner: 10Arcayn)
[19:06:05] <wikibugs>	 (03CR) 10jenkins-bot: mediawiki.ui: Move remaining mixin to buttons.less; remove mixins.less [core] - 10https://gerrit.wikimedia.org/r/475509 (owner: 10VolkerE)
[19:10:48] <wikibugs>	 (03Merged) 10jenkins-bot: SandboxLink: Remove explicit state [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/475596 (owner: 10John Erling Blad)
[19:16:29] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Patch-For-Review, 10Technical-Debt: Remove unchecked calls to Title::getTalkPage from extensions - https://phabricator.wikimedia.org/T172146 (10Stibba)
[19:18:40] <wikibugs>	 (03CR) 10Urbanecm: [C: 04-1] Change: All notifications will now go via watcher object (034 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[19:18:55] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Patch-For-Review, 10Technical-Debt: Remove unchecked calls to Title::getTalkPage from extensions - https://phabricator.wikimedia.org/T172146 (10Stibba) The getTalkPage in the WikiLove extension is to a User talk page...
[19:20:15] <wikibugs>	 (03CR) 10Urbanecm: [C: 032] Convert notification to Czech [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475616 (owner: 10Urbanecm)
[19:21:09] <wikibugs>	 (03Merged) 10jenkins-bot: Convert notification to Czech [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475616 (owner: 10Urbanecm)
[19:33:20] <takidelfin>	 :(
[19:33:49] <Platonides>	 takidelfin: ?
[19:34:16] <takidelfin>	 Waiting for a task review
[19:36:00] <Platonides>	 I see that VolkerE left you a comment hours ago
[19:36:23] <Platonides>	 (on gerrit, not on gci site)
[19:36:34] <takidelfin>	 yup
[19:37:13] <Platonides>	 I would expect that you at least replied to his concerns :P
[19:37:58] <TheJair>	 Hi people :)
[19:38:03] <takidelfin>	 hello TheJair 
[19:38:04] <Platonides>	 hi TheJair 
[19:38:10] <Ebe123>	 Hello!
[19:38:47] <TheJair>	 Does anything special happen if a mentor doesn't reply to a submitted review within 36 hours?
[19:39:20] <Nathan_fraignt>	 I´d think it would be accepted
[19:39:44] <Platonides>	 an angry Google drone comes to his house?
[19:39:46] <Nathan_fraignt>	 Since anything else (like just abandoning) would be negative to the student
[19:39:51] <Nathan_fraignt>	 Probably
[19:40:06] <TheJair>	 Yeah but that would be a bit weird if the task isn't done yet
[19:40:23] <wikibugs>	 (03PS7) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[19:40:35] <Platonides>	 well, but it's not the student fault's either
[19:40:51] <TheJair>	 true
[19:41:31] <RexxS>	 I think we'd try to get the task reviewed by another mentor
[19:41:50] <RexxS>	 and apologise for the delay
[19:42:13] <bawolff>	 Platonides: An agry gci admin starts emailing me ;)
[19:42:51] <wikibugs>	 (03PS8) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[19:43:26] <Nathan_fraignt>	 Urbanecm, published a new patch. Sorry for taking so much of your time :)
[19:44:15] <Urbanecm>	 Not a problem :)
[19:44:40] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Patch-For-Review, 10Technical-Debt: Remove unchecked calls to Title::getTalkPage from extensions - https://phabricator.wikimedia.org/T172146 (10Platonides)
[19:45:32] <Platonides>	 bawolff: go review https://codein.withgoogle.com/dashboard/task-instances/4974272951877632/ :P
[19:46:29] <bawolff>	 Platonides: I'm busy figuring out why everyone's account keeps getting hacked ;)
[19:46:48] <Platonides>	 who cares? ;)
[19:47:05] <Platonides>	 may I help with any of them?
[19:47:33] <bawolff>	 But yes, I'm going to get to that soon once I finish going through my bug backlog
[19:47:54] <shreyasminocha>	 hey Platonides and bawolff
[19:48:05] <Platonides>	 hey shreyasminocha 
[19:48:33] <TheJair>	 hi shreyasminocha 
[19:48:33] <Urbanecm>	 Hi shreyasminocha 
[19:48:41] <bawolff>	 Platonides: I'm fine with other people reviewing any of them if you feel like it, although I really am going to start reviewing it in like 15 minutes
[19:48:56] <shreyasminocha>	 hey TheJair, Urbanecm. thought i'll check irc before going to sleep :P
[19:49:12] <Urbanecm>	 Not a good idea if you want to sleep within several minutes :D
[19:49:13] <Platonides>	 I suspect setting up the environment it would take me more time
[19:49:13] <Nathan_fraignt>	 Shreyasminocha, did any tasks today? :)
[19:49:45] <shreyasminocha>	 Nathan_fraignt: got my previous one reviewed at 9:30 pm. i've selected one to work on, couldn't being
[19:49:48] <shreyasminocha>	 begin*
[19:50:01] <shreyasminocha>	 Urbanecm: that's really true :D
[19:50:06] <Nathan_fraignt>	 Ah, sad. I didn´t finish any today either
[19:50:28] <shreyasminocha>	 it's okay :)
[19:50:51] <Urbanecm>	 That doesn't need to be necessarily true, I'm reviewing your patch rn :D
[19:51:14] <Nathan_fraignt>	 Not yet at least :)
[19:51:26] <Urbanecm>	 :)
[19:51:40] <Nathan_fraignt>	 Still hopeful, maybe I can do a quick one after it (although I do really need to sleep before 22:00)
[19:51:45] <shreyasminocha>	 (i'm telling you Nathan_fraignt's just trying to be humble :D he does all these tasks and doesn't tell us ;D)
[19:52:13] <Nathan_fraignt>	 Nah man, I´m stuck with one task, this whole day :)
[19:52:33] <Nathan_fraignt>	 But it´s supposed to be one of the hardest (according to Urbanecm) so I guess it´s alright
[19:53:04] <wikibugs>	 10video2commons: Add logged username in the interface - https://phabricator.wikimedia.org/T210355 (10Framawiki) p:05Triage>03Low
[19:53:37] <shreyasminocha>	 i choose tasks on the basis of their priority on phab
[19:53:51] <shreyasminocha>	 (and also if i'm interested in doing them obv)
[19:54:21] <shreyasminocha>	 anyone else?
[19:54:38] <Nathan_fraignt>	 I choose them based on their description and prefer tasks in projects I´ve worked on before
[19:54:48] <Nathan_fraignt>	 And I try to find a balance between hard and easy tasks
[19:55:13] <shreyasminocha>	 "balance between hard and easy tasks" i need to get some of that
[19:55:31] <Nathan_fraignt>	 Hahah emphasis on I TRY
[19:55:35] <TheJair>	 I just try out a bunch of different sorts of tasks
[19:55:41] <Nathan_fraignt>	 I did a bit too much easy style fixes tbh
[19:55:53] <wikibugs>	 (03CR) 10Takidelfin: stylelint: Replaced CSSLint with StyleLint (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[19:55:56] <shreyasminocha>	 these days i'm not getting enough easy tasks
[19:56:25] <Nathan_fraignt>	 Do some PEP8 style fixes
[19:56:54] <shreyasminocha>	 yeah, i guess doing some of those too is necessary for mental well-being
[19:56:56] <wikibugs>	 (03CR) 10Platonides: [C: 04-2] Change getTalkPage() to getTalkPageIfDefined() (031 comment) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594 (owner: 10Pjht)
[19:57:01] <Nathan_fraignt>	 haha:)
[19:57:42] <Urbanecm>	 shreyasminocha, looks you didn't complete https://codein.withgoogle.com/tasks/6093941754560512/ too :)
[19:58:24] <shreyasminocha>	 that was the first one i did :D
[19:58:50] <shreyasminocha>	 i was introduced to Urbanecm via that
[19:59:55] <Urbanecm>	 shreyasminocha, wasn't it https://gerrit.wikimedia.org/r/c/labs/tools/wikinity/+/469310? :)
[20:00:33] <shreyasminocha>	 oh ya! :) :)
[20:00:33] <Urbanecm>	 I don't see any commit that might match the task on https://gerrit.wikimedia.org/r/q/project:wikimedia-cz%252Ftracker+owner:shreyasminocha%2540protonmail.com 
[20:00:35] <Nathan_fraignt>	 There are LOTS of line length violations in Tracker
[20:00:41] <shreyasminocha>	 lol
[20:01:12] <Urbanecm>	 That's true, unfortunately
[20:01:31] <Nathan_fraignt>	 Maybe you can do the same as pywikibot and import them to gci in multiple tasks, like this: https://codein.withgoogle.com/tasks/5715704318787584/?sp-organization=4956074911203328&sp-is_beginner=False&sp-search=python
[20:01:36] <Platonides>	 that's when you change the max_length parameter on the linter config ;)
[20:01:54] <Nathan_fraignt>	 And just start cleaning them file by file
[20:01:54] <shreyasminocha>	 hahah
[20:02:13] <shreyasminocha>	 i saw this task that said "fix 60 line length violations"
[20:02:23] <shreyasminocha>	 and another that said "30 ..."
[20:02:36] <Urbanecm>	 Yeah, I'm thinking how many line length violations should be worth one task completed. Any idea? :)
[20:02:58] <shreyasminocha>	 10?
[20:03:06] <Nathan_fraignt>	 I think either one file with 60+ or multiple with a max of 50/5 files
[20:03:13] <Nathan_fraignt>	 50 violations or 5 files
[20:03:14] <Nathan_fraignt>	 that is
[20:03:29] <Urbanecm>	 I'd also rate https://codein.withgoogle.com/tasks/5763295794429952/ as easy :)
[20:03:34] <TheJair>	 I agree with Nathan_fraignt 
[20:03:38] <Nathan_fraignt>	 Or maybe a bit lower if shreyasminocha´s guess is 10
[20:03:57] <TheJair>	 But it's fairly easy
[20:04:03] <shreyasminocha>	 ~10 would make a 1/2 day task
[20:04:15] <shreyasminocha>	 (that's "1 or 2", not "half")
[20:04:16] <Nathan_fraignt>	 10 line violations = 5 minutes work
[20:04:24] <shreyasminocha>	 i mean yeah, ofc :D
[20:04:36] <shreyasminocha>	 but all these tasks have lot of extra time available
[20:04:44] <Nathan_fraignt>	 True
[20:04:44] <shreyasminocha>	 i'm guessing there must be a reason
[20:05:10] <Urbanecm>	 One of reasons is that we cannot set the field to <3
[20:05:24] <shreyasminocha>	 o rly?
[20:05:37] <Urbanecm>	 No. The number of days must be 3 or higher and 7 or less
[20:05:50] <TheJair>	 I guess also so that you don't immediately have to start working on them
[20:06:54] <Nathan_fraignt>	 And if a you submit it for review, but the mentor answers in a different time zone, and you have to sleep + school, it can be 20 hours later.
[20:07:00] <wikibugs>	 10Wikimedia Design Style Guide: Something strange with WikimediaUI-components_overview.svg - https://phabricator.wikimedia.org/T210357 (10Iniquity)
[20:07:05] <Nathan_fraignt>	 Which means that if that happens twice you need at least 2 days.
[20:07:08] <shreyasminocha>	 yeah
[20:08:49] <Urbanecm>	 Nathan_fraignt, submitting a task for review pauses the timer
[20:08:57] <Urbanecm>	 oh, never mind
[20:09:05] <Nathan_fraignt>	 :)
[20:09:33] <bawolff>	 Now i just need to figure out how to run scribunto unit tests
[20:10:10] <shreyasminocha>	 the name "scribunto" keeps reminding me of "ubuntu"
[20:10:35] <Urbanecm>	 bawolff, by submitting a patch to gerrit? :D
[20:10:54] <shreyasminocha>	 it does help to be able to run tests locally though imo
[20:11:07] <wikibugs>	 10Google-Code-in-2018, 10Wikimedia-Site-requests: Add the extension "SandboxLink" for nowiki - https://phabricator.wikimedia.org/T210325 (10Framawiki) Offering to Google Code in participants. Please do not claim this task unless you're GCI student, thanks!
[20:11:16] <bawolff>	 Urbanecm: I like your style :)
[20:11:17] <takidelfin>	 :D
[20:11:21] <bawolff>	 That's my approach usually too
[20:11:47] <bawolff>	 I need to verify the test fails if I run it with a super old version of lua
[20:11:59] <wikibugs>	 (03PS3) 10Takidelfin: stylelint: Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506)
[20:12:14] <wikibugs>	 (03CR) 10Takidelfin: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[20:12:53] <takidelfin>	  /o\
[20:13:58] <shreyasminocha>	 takidelfin: is that you holding your head?
[20:14:09] <Urbanecm>	 bawolff, `composer test` looks like an opinion
[20:14:14] <takidelfin>	 it is upside down \o/
[20:14:26] <TheJair>	 like a handstand
[20:14:31] <shreyasminocha>	 yeah, but looks like someone holding their head in despair
[20:14:34] <takidelfin>	 🤔
[20:14:38] <shreyasminocha>	 ... or a handstand :D
[20:15:06] <Urbanecm>	 shreyasminocha, Nathan_fraignt: I updated the flake8 task's description to make it a little bit more accessible
[20:15:11] <Platonides>	 *11
[20:15:41] <shreyasminocha>	 Urbanecm: nice, although not sure what was there to clarify
[20:15:49] <wikibugs>	 10Internet-Archive, 10Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678)
[20:15:51] <wikibugs>	 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Catalan Wikiquote (cawikiquotewiki) - https://phabricator.wikimedia.org/T184855 (10Cyberpower678) 05Open>03Resolved
[20:16:18] <Urbanecm>	 not clarify, the task required students to fix 3 errors, which means you'd have to fix all the line length violations
[20:16:43] <shreyasminocha>	 ohk
[20:18:24] <takidelfin>	 'How did your holidays pass?' is it correct? and does it look good ( I mean a style )? :D
[20:18:38] <shreyasminocha>	 "how were your holidays" might be better
[20:18:48] <takidelfin>	 thanks :)
[20:21:55] <wikibugs>	 10Internet-Archive, 10Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678)
[20:21:59] <wikibugs>	 10Wiktionary, 10InternetArchiveBot (v2.0): InternetArchiveBot Wiktionary support (enwikt, frwikt) - https://phabricator.wikimedia.org/T181879 (10Cyberpower678) 05Open>03Resolved
[20:22:26] <wikibugs>	 10Internet-Archive, 10Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678)
[20:22:28] <wikibugs>	 10Bengali-Sites, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Bengali Wikipedia (bnwiki) - https://phabricator.wikimedia.org/T169482 (10Cyberpower678) 05Open>03Resolved
[20:22:34] <wikibugs>	 10WMCZ-Tracker: Return user to page they were on while clickin on login after successful authentication - https://phabricator.wikimedia.org/T210358 (10Urbanecm)
[20:24:12] <wikibugs>	 10Internet-Archive, 10Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678)
[20:24:14] <wikibugs>	 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Cyberpower678) 05Open>03Resolved
[20:24:36] <Urbanecm>	 Nathan_fraignt, there's a bug in your patch
[20:24:43] <takidelfin>	 :O
[20:24:57] <Nathan_fraignt>	 Oh no
[20:25:09] <Urbanecm>	 It doesn't send anything to ticket owner at least if topic admin restricted their watch settings
[20:25:24] <Nathan_fraignt>	 Alright, will figure it out and fix it
[20:25:30] <wikibugs>	 10Internet-Archive, 10Tracking: Add IABot support for other wikis (tracking) - https://phabricator.wikimedia.org/T136130 (10Cyberpower678)
[20:25:32] <wikibugs>	 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on Cantonese Wikipedia (zh-yuewiki) - https://phabricator.wikimedia.org/T188206 (10Cyberpower678) 05Open>03Resolved
[20:26:01] <shreyasminocha>	 (don't fall for it, he's just trying to pass the turing test)
[20:26:20] <shreyasminocha>	 :D
[20:27:34] <Urbanecm>	 Nathan_fraignt, in all cases. 
[20:28:03] <Nathan_fraignt>	 Sounds like the bug is somewhere in fire_notification()
[20:28:46] <wikibugs>	 10Trust-and-Safety, 10Security: Ciphers claimed that his account was compromised - https://phabricator.wikimedia.org/T210361 (10alanajjar)
[20:29:20] * Urbanecm wonders why Nathan_fraignt defines users as a dict on line 954
[20:29:51] * Nathan_fraignt thinks Urbanecm should learn the difference between a set and a dict
[20:30:05] <Nathan_fraignt>	 AFAIK {x} is a set, {x:y} is a dict
[20:30:20] <Nathan_fraignt>	 But I might be completely wrong
[20:30:46] <shreyasminocha>	 ...
[20:30:48] <Urbanecm>	 Didn't know I can declare a set that way :D
[20:30:53] <Nathan_fraignt>	 https://www.programiz.com/python-programming/set
[20:31:03] <Nathan_fraignt>	 :D
[20:31:14] <Nathan_fraignt>	 Glad to see I learned my mentor something :)
[20:34:03] <Nathan_fraignt>	 But to be honest I don´t see why the watch settings of an admin interfere with that of a user
[20:34:43] <Nathan_fraignt>	 Urbanecm, any ideas?
[20:34:52] <Urbanecm>	 It doesn't, the bug is present regardless on admin's settings
[20:35:18] <Urbanecm>	 I just knew I restricted admins settings, so I noted the bug occurs at least in those cases
[20:35:29] <Nathan_fraignt>	 Hmm, so you basically mean that notifs aren´t send to the owner of a ticket?
[20:35:39] <Urbanecm>	 yes
[20:36:30] <Urbanecm>	 It looks the condition in ticket owner if is wrong
[20:37:03] <Nathan_fraignt>	 Do you mean line 948-954 in models.py?
[20:37:11] <Urbanecm>	 yeah
[20:37:17] <Nathan_fraignt>	 Yeah, that´s my guess also
[20:37:45] <Urbanecm>	 I think you should remove ticket owner from users set when the condition is true
[20:37:51] <Urbanecm>	 but you _add_ ticket owner instead :)
[20:38:23] <Nathan_fraignt>	 Could be, but could it be because of the muted Watcher?
[20:38:59] <Nathan_fraignt>	 Since what you say shouldn´t make any difference, in theory, (right? or am I missing something?)
[20:39:42] <Urbanecm>	 In case I have currently on my computer, I don't have any watcher with notification_type=="mute"
[20:40:39] <Nathan_fraignt>	 yeah, nvm, that wouldn´tmatter anyways, since then they are supposed to not recieve messages
[20:40:44] <Urbanecm>	 yep
[20:40:59] <Nathan_fraignt>	 I´ll try your thing, but I can´t wrap my head around how that would make a difference
[20:41:01] <wikibugs>	 (03CR) 10Brian Wolff: [C: 04-1] "Hi. My apologies for the delay in reviewing this." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) (owner: 10Mogmog123)
[20:41:29] <Urbanecm>	 If you look at how you process admins
[20:41:39] <Urbanecm>	 you remove admins from admins set if they have some watcher
[20:41:41] <takidelfin>	 bawolff: heh
[20:41:49] <Nathan_fraignt>	 Oh wait
[20:41:52] <Nathan_fraignt>	 Yeah think I got it
[20:41:58] <Nathan_fraignt>	 Yeah sorry
[20:42:00] <Nathan_fraignt>	 Got it
[20:42:01] <Urbanecm>	 np
[20:42:33] <wikibugs>	 (03PS9) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[20:43:11] <Nathan_fraignt>	 yeah no, this is it. Sorry for being so dumb lol
[20:43:23] <wikibugs>	 (03PS2) 10Pjht: Change getTalkPage() to getTalkPageIfDefined() [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594
[20:43:25] <Nathan_fraignt>	 or at least I feel dumb atm
[20:43:25] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:44:03] <Urbanecm>	 you feel similar to how I felt after the set thing. Honestly I don't think anyone of us is actually dumb :)
[20:44:04] <wikibugs>	 (03CR) 10Pjht: Change getTalkPage() to getTalkPageIfDefined() (031 comment) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594 (owner: 10Pjht)
[20:44:26] <Nathan_fraignt>	 Hmm that bot message is not good
[20:44:52] <Nathan_fraignt>	 Nah I don´t think that either, which is why I said that I at least __feel__ dumb
[20:45:10] <wikibugs>	 (03CR) 10Urbanecm: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:45:27] <Urbanecm>	 I think it's T207310
[20:45:29] <stashbot>	 T207310: Tests in Tracker fail from time to time from non-obvious reason - https://phabricator.wikimedia.org/T207310
[20:45:52] <Urbanecm>	 let's see if it succeeds next time
[20:46:07] <Nathan_fraignt>	 Yeah it must be, the 2 lines I changed shouldn´t change a thing for the bots tests
[20:46:27] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:46:43] <Urbanecm>	 hmm, second fail
[20:46:50] <wikibugs>	 (03CR) 10Urbanecm: "recheck" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:47:07] <Urbanecm>	 let's see what third run of tests will so
[20:47:07] <Nathan_fraignt>	 Third time´s the charm
[20:47:20] <Nathan_fraignt>	 And if not than it probably is my fault
[20:47:33] <Urbanecm>	 yeah
[20:47:41] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:47:49] <Nathan_fraignt>	 sad
[20:47:54] <Urbanecm>	 yeah
[20:48:04] <Urbanecm>	 I'll walk a dog, see you in a while
[20:48:22] <Nathan_fraignt>	 ERROR: test_access_rights (trackersite.tracker.tests.ImportTests)
[20:48:31] <Nathan_fraignt>	 Sure, cya
[20:49:59] <wikibugs>	 (03PS10) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[20:50:46] <wikibugs>	 (03PS11) 10Nathan fraignt: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656)
[20:50:48] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[20:52:15] <Nathan_fraignt>	 Done, bot is happy urbanecm!
[20:56:51] <Urbanecm>	 Nice to see that Nathan_fraignt 
[21:07:02] <takidelfin>	 Volker_E: hi! Could you review my patch again? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CookieWarning/+/475599 :D
[21:11:50] <wikibugs>	 (03CR) 10Urbanecm: [C: 032] Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[21:11:54] <Urbanecm>	 Congrats, Nathan_fraignt 
[21:12:37] <Nathan_fraignt>	 Woah, thanks. Submitting it for review on GCI!
[21:12:44] <wikibugs>	 (03Merged) 10jenkins-bot: Change: All notifications will now go via watcher object [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475615 (https://phabricator.wikimedia.org/T208656) (owner: 10Nathan fraignt)
[21:12:59] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) 05Open>03Resolved
[21:13:17] <Urbanecm>	 Approved
[21:14:25] <Nathan_fraignt>	 Thanks!
[21:15:03] <Urbanecm>	 Yw
[21:18:15] <wikibugs>	 (03CR) 10Esanders: Move VE's ConfirmEdit support to this extension (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/475505 (https://phabricator.wikimedia.org/T141676) (owner: 10Esanders)
[21:18:57] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/475621 (owner: 10L10n-bot)
[21:25:34] <wikibugs>	 (03CR) 10Raimond Spekking: [V: 032] Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/475621 (owner: 10L10n-bot)
[21:25:47] <wikibugs>	 (03CR) 10Raimond Spekking: [V: 032 C: 032] "false positive" [core] - 10https://gerrit.wikimedia.org/r/475621 (owner: 10L10n-bot)
[21:29:35] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475624 (owner: 10L10n-bot)
[21:43:09] <wikibugs>	 (03CR) 10Platonides: [C: 031] Change getTalkPage() to getTalkPageIfDefined() [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594 (owner: 10Pjht)
[21:43:56] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475657 (owner: 10L10n-bot)
[21:45:10] <wikibugs>	 (03CR) 10jerkins-bot: [V: 04-1] Change getTalkPage() to getTalkPageIfDefined() [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594 (owner: 10Pjht)
[21:46:13] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/475630 (owner: 10L10n-bot)
[21:46:30] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/475621 (owner: 10L10n-bot)
[21:47:06] <takidelfin>	 legoktm: Could you review my patch please? https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CookieWarning/+/475599
[21:47:34] <takidelfin>	 Jenkins test passed succesfuly :D
[21:48:37] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/475628 (owner: 10L10n-bot)
[21:52:32] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/475631 (owner: 10L10n-bot)
[21:55:42] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/475632 (owner: 10L10n-bot)
[21:58:04] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/475634 (owner: 10L10n-bot)
[22:02:21] <wikibugs>	 10MediaWiki-API: API should return a helpful error message when URL is too long - https://phabricator.wikimedia.org/T209590 (10Huji) @Anomie: when I try `https://fa.wikipedia.org/w/api.php?action=query&prop=coordinates&titles=File:Pandora Tomorrow box art.jpg&format=json` with my browser, I get a valid API respo...
[22:07:42] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/475641 (owner: 10L10n-bot)
[22:07:51] <takidelfin>	 `Your text is very simple and easy to read, likely to be understood by an average 5th-grader (age 10).` I don't think it is good for me ._.
[22:10:23] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/475636 (owner: 10L10n-bot)
[22:12:11] <wikibugs>	 10SpamBlacklist, 10Stewards-and-global-tools, 10Trust-and-Safety: Spam Blacklist shouldn't be fooled by similar-looking Unicode characters - https://phabricator.wikimedia.org/T14896 (10Bawolff) So a quick hack fix would be in includes/parser/Sanitizer.php ~ line 2047 in Sanitizer::cleanUrl() to add a line `$...
[22:16:58] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/475642 (owner: 10L10n-bot)
[22:19:34] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/475643 (owner: 10L10n-bot)
[22:21:40] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/475650 (owner: 10L10n-bot)
[22:23:41] <wikibugs>	 (03PS12) 10Acamicamacaraca: Add GRAMMAR parser function support for Serbian [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/457543 (https://phabricator.wikimedia.org/T35546)
[22:24:28] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/475649 (owner: 10L10n-bot)
[22:26:23] <wikibugs>	 (03PS10) 10D3r1ck01: tests: Add unit tests for SpamlistLookup::factory() [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/473296
[22:28:18] <wikibugs>	 10WMCZ-Tracker: In watch.html, the "All" notification should be checked if all notifications are - https://phabricator.wikimedia.org/T210353 (10Urbanecm)
[22:28:23] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475656 (owner: 10L10n-bot)
[22:29:37] <wikibugs>	 10WMCZ-Tracker: In watch.html, the "All" notification should be checked if all notifications are - https://phabricator.wikimedia.org/T210353 (10Urbanecm)
[22:30:41] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: In watch.html, the "All" notification should be checked if all notifications are - https://phabricator.wikimedia.org/T210353 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/5390623558336512/ and I will mentor it.
[22:31:44] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Return user to page they were on while clicking on login after successful authentication - https://phabricator.wikimedia.org/T210358 (10Urbanecm)
[22:32:24] <wikibugs>	 10Repository-Ownership-Requests: Nominate Alangi Derick for +2 on mediawiki/* - https://phabricator.wikimedia.org/T209775 (10Bawolff) 05Open>03Resolved a:03Bawolff Its been a week. Closing as success.
[22:33:59] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/475661 (owner: 10L10n-bot)
[22:35:16] <wikibugs>	 04(no projects): Allow edits that touch multiple pages and that can still be undone with single click - https://phabricator.wikimedia.org/T210348 (10Aklapper) How does one edit 'touch' multiple pages? Clear steps to reproduce welcome. Please see https://www.mediawiki.org/wiki/How_to_report_a_bug
[22:44:18] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/475665 (owner: 10L10n-bot)
[22:46:51] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/475670 (owner: 10L10n-bot)
[22:53:32] <wikibugs>	 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Return user to page they were on while clicking on login after successful authentication - https://phabricator.wikimedia.org/T210358 (10Urbanecm) https://codein.withgoogle.com/tasks/4579093363294208/
[22:56:36] <wikibugs>	 (03PS3) 10Pjht: Change getTalkPage() to getTalkPageIfDefined() [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594
[22:58:29] <wikibugs>	 (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/475672 (owner: 10L10n-bot)
[23:00:53] <wikibugs>	 (03CR) 10Gergő Tisza: "Sorry for taking forever to review!" [oauthclient-php] - 10https://gerrit.wikimedia.org/r/408853 (https://phabricator.wikimedia.org/T186739) (owner: 100x010C)
[23:08:44] <wikibugs>	 10MediaWiki-Interface, 10MediaWiki-User-management, 10Security: Editing sitewide JS/CSS pages should require elevated security - https://phabricator.wikimedia.org/T197137 (10Platonides) For what is worth, someone at WMF seems to have decided to start enforcing 2FA for this. Last week, WMFOffice started maili...
[23:10:11] <wikibugs>	 10video2commons: Add logged username in the interface - https://phabricator.wikimedia.org/T210355 (10zhuyifei1999) 05Open>03Invalid Filed https://github.com/toolforge/video2commons/issues/100  Closing as issues regarding v2c's internals are not tracked here.
[23:35:14] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-User-management, 10Security: audit password policy check for constant time string comparisons - https://phabricator.wikimedia.org/T207777 (10Aklapper)
[23:37:52] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-User-management, 10Security: audit password policy check for constant time string comparisons - https://phabricator.wikimedia.org/T207777 (10Aklapper) Imported and published as https://codein.withgoogle.com/tasks/5147920727801856/
[23:52:16] <legoktm>	 takidelfin: looking now
[23:53:52] <wikibugs>	 (03PS4) 10Legoktm: Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[23:54:54] <wikibugs>	 10Google-Code-in-2018, 10Pywikibot, 10Pywikibot-archivebot.py: Add "level=n" option to the template for specifying the heading level of the sections to be archived - https://phabricator.wikimedia.org/T119791 (10Aklapper) @Dvorapa: You have two more weeks for #GCI-2018, if you still plan to. :)
[23:54:58] <wikibugs>	 (03CR) 10Legoktm: [C: 032] Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin)
[23:55:05] <wikibugs>	 10Google-Code-in-2018, 10Pywikibot, 10Pywikibot-cosmetic-changes.py: Edit pages only if edit size/number of characters changed is above threshold - https://phabricator.wikimedia.org/T151438 (10Aklapper) @Dvorapa: You have two more weeks for #GCI-2018, if you still plan to. :)
[23:55:53] <wikibugs>	 10Google-Code-in-2018, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), and 2 others: Remove unchecked calls to Title::getTalkPage from extensions - https://phabricator.wikimedia.org/T172146 (10Aklapper)
[23:58:27] <wikibugs>	 10Google-Code-in-2018, 10Analytics, 10Analytics-Dashiki, 10goodfirstbug: Add external link to tabs layout - https://phabricator.wikimedia.org/T146774 (10Aklapper) @Milimetric: If you'd still be interested in mentoring this in #GCI-2018, you'd have two more weeks [to register as a mentor](https://www.mediaw...