[00:00:54] (03Abandoned) 10Jdlrobson: DONOTMERGE Demonstration: I can update src but not resources/dist [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/471350 (owner: 10Jdlrobson) [00:03:10] (03CR) 10Jdlrobson: [C: 031] "Haven't tested but looks sane!" [core] - 10https://gerrit.wikimedia.org/r/475509 (owner: 10VolkerE) [00:04:09] (03PS1) 10Jdlrobson: Simplify APIParseExtender [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) [00:04:42] (03PS5) 10Dbarratt: Add NamespaceRestriction class so that BlockRestriction can handle namespaces. [core] - 10https://gerrit.wikimedia.org/r/470656 (https://phabricator.wikimedia.org/T204991) [00:12:38] 10UniversalLanguageSelector, 10Performance-Team (Radar): Update use of the deprecated "schema.UniversalLanguageSelector" module - https://phabricator.wikimedia.org/T209629 (10Krinkle) @Nikerabbit See T205744 for details. The recommended approach is using `mw.track('event. 10UniversalLanguageSelector, 10Performance-Team (Radar): Update use of the deprecated "schema.UniversalLanguageSelector" module - https://phabricator.wikimedia.org/T209629 (10Krinkle) [00:14:31] Finally done \o/ [00:14:48] bye! [00:14:56] 10Readers-Web-Backlog, 10Patch-For-Review, 10Spike: MFA: [spike, 2hr] How do we stub modules ? - https://phabricator.wikimedia.org/T210020 (10Jdlrobson) Given all View's call View.prototype.initialize we could stub that method... [00:16:07] (03PS9) 10Jdlrobson: Several View's now pass className and isBorderBox as a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475147 (https://phabricator.wikimedia.org/T209007) [00:18:52] 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, 10Performance-Team (Radar), and 2 others: MFA: Remove mobile.startup/user - https://phabricator.wikimedia.org/T204866 (10Krinkle) [00:20:02] 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27), 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, 10Performance-Team (Radar), and 2 others: MFA: Remove mobile.startup/user - https://phabricator.wikimedia.org/T204866 (10Krinkle) //(Tagging internally for historical record, so that we easily find this ta... [00:21:37] (03PS3) 10Dbarratt: Add tests to ensure that NamespaceRestrictions are returned from Block APIs. [core] - 10https://gerrit.wikimedia.org/r/473967 (https://phabricator.wikimedia.org/T204989) [00:21:42] (03PS4) 10Dbarratt: Add Namespace Restrictions to Special:BlockList [core] - 10https://gerrit.wikimedia.org/r/475434 (https://phabricator.wikimedia.org/T204990) [01:12:41] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: User that was created by OAuth cannot set password - https://phabricator.wikimedia.org/T209320 (10rafidaslam) a:03rafidaslam [01:38:59] (03PS4) 10Gergő Tisza: Allow AuthenticationRequest to return load errors [core] - 10https://gerrit.wikimedia.org/r/475035 [01:39:43] (03CR) 10Gergő Tisza: Allow AuthenticationRequest to return load errors (038 comments) [core] - 10https://gerrit.wikimedia.org/r/475035 (owner: 10Gergő Tisza) [01:46:01] 10UniversalLanguageSelector, 10Upstream: ULS Suggested languages is cutting of language names vertically - https://phabricator.wikimedia.org/T210111 (10Petar.petkovic) [01:46:04] (03CR) 10Gergő Tisza: [C: 04-1] "On second thought I don't really like this. The real problem is not that the API can filter the requests (although I agree there is not mu" [core] - 10https://gerrit.wikimedia.org/r/475035 (owner: 10Gergő Tisza) [01:52:23] (03PS1) 10Jdlrobson: pageIssuesOverlay is a factory function that returns an Overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/475576 (https://phabricator.wikimedia.org/T209647) [01:54:02] (03CR) 10Anomie: Simplify APIParseExtender (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [02:02:56] (03CR) 10Anomie: "User::newFromSession() is ok as long as you don't trigger ->load()." [core] - 10https://gerrit.wikimedia.org/r/474933 (https://phabricator.wikimedia.org/T207941) (owner: 10Gilles) [02:13:22] (03CR) 10Jdlrobson: Simplify APIParseExtender (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [02:15:44] (03CR) 10Jforrester: [C: 032] Move VE's ConfirmEdit support to this extension [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/475505 (https://phabricator.wikimedia.org/T141676) (owner: 10Esanders) [02:40:47] (03CR) 10Krinkle: Add wfGetErrorText, a global helper function for log error formatting (032 comments) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [02:41:19] (03Merged) 10jenkins-bot: Move VE's ConfirmEdit support to this extension [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/475505 (https://phabricator.wikimedia.org/T141676) (owner: 10Esanders) [02:44:37] (03CR) 10jenkins-bot: Move VE's ConfirmEdit support to this extension [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/475505 (https://phabricator.wikimedia.org/T141676) (owner: 10Esanders) [03:04:28] (03CR) 10Krinkle: "Apologies if I misunderstand, but I suspect there may be a problem here." [core] - 10https://gerrit.wikimedia.org/r/474726 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [03:22:20] (03PS5) 10Legoktm: Make "→" link to page section on History page larger by adding section name to it [core] - 10https://gerrit.wikimedia.org/r/475230 (https://phabricator.wikimedia.org/T165189) (owner: 10Bjornskjald) [03:25:41] (03CR) 10Legoktm: [C: 032] Make "→" link to page section on History page larger by adding section name to it [core] - 10https://gerrit.wikimedia.org/r/475230 (https://phabricator.wikimedia.org/T165189) (owner: 10Bjornskjald) [03:35:30] (03CR) 10Gergő Tisza: [C: 04-1] SVG files display at max resolution (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish) [03:39:12] (03Merged) 10jenkins-bot: Make "→" link to page section on History page larger by adding section name to it [core] - 10https://gerrit.wikimedia.org/r/475230 (https://phabricator.wikimedia.org/T165189) (owner: 10Bjornskjald) [03:41:25] (03CR) 10jenkins-bot: Make "→" link to page section on History page larger by adding section name to it [core] - 10https://gerrit.wikimedia.org/r/475230 (https://phabricator.wikimedia.org/T165189) (owner: 10Bjornskjald) [03:43:10] (03CR) 10Gergő Tisza: [C: 04-1] "https://github.com/wikimedia/mediawiki-extensions-MultimediaViewer/blob/99115fe9cf1f938a611a980510c962f9d8568d56/resources/mmv/mmv.Thumbna" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish) [03:44:58] 10Unofficial-Apps-Wiktionary-Android, 10Wiktionary: Decide on future of Android Wiktionary app - https://phabricator.wikimedia.org/T205727 (10Kaartic) > The second idea is to look for open-source frameworks (or start from scratch) and build a new app. May be pushing the following forward might lead to a bette... [03:56:24] (03CR) 10Gergő Tisza: [C: 04-1] "The first version of the patch actually looked correct. Did you change it because of the test failure? The test looks at SVG resizing, whi" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish) [04:40:40] 10MediaWiki-Stakeholders-Group: Write about presentation given at Wikimedia Lyon Hackathon on NASA extensions on MWStake.org - https://phabricator.wikimedia.org/T100214 (10Quiddity) 05Open>03declined [05:28:42] 10MediaWiki-User-preferences, 10Edit-Review-Improvements-Integrated-Filters, 10User-kostajh, 10Growth-Team (Current Sprint), 10MW-1.33-notes (1.33.0-wmf.6; 2018-11-27): Change the opt-out message for watchlists and recent changes in preferences, to reflect the fa... - https://phabricator.wikimedia.org/T207741 [05:28:58] Hey [05:29:09] Chris1086, Hello [05:30:02] refeed, How u doin ? [05:32:04] Chris1086, busy with exams :(, at least I don't have any sleep deprivation anymore this year :D [05:36:53] I hate exams too :( ,not those exam kinda guys ... And as I'm into gaming sleep depriviation is common for me :P [05:40:04] Yeah, sometimes I also got sleep deprivation from gaming, but well, the consequence is I can't concentrate the day after, so I'm managing my time to not get sleep deprived every night [05:40:22] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-User-login-and-signup, 10Services, 10Security: Service for checking the Pwned Passwords database - https://phabricator.wikimedia.org/T189641 (10Tgr) [05:40:34] When I was doing my first GCI, I often slept at 5.00 AM [05:41:21] heyyo [05:41:27] But I can't do it anymore, since this year's GCI not even touching one day of my holiday [05:41:37] shreyasminocha: Hello [05:41:55] reading some of the discussion in the scrollback, i can relate [05:42:19] even i'm having to sleep really late, usually because of work: gci and otherwise [05:42:50] thankfully, holidays in a week's time [05:44:09] hi Chris1086 [05:44:36] shreyasminocha: Haha, that's nice [05:44:57] when does winter holiday start in India btw? [05:45:31] my school is diff from the rest in terms of yearly schedule, but typically they begin second week of december iirc [05:45:45] They start like in January refeed [05:45:53] hi shreyasminocha [05:47:40] shreyasminocha: Okay, it's same with my schedule here, but well, this year's holiday is not a holiday, I still need to do some "Practice Exams" etc. [05:47:55] ditto [05:48:10] Chris1086, are you living in India as well? [05:48:45] although last year was my "practice exams" year. next year will be the same. [05:49:05] this year it'll be study for SAT sub tests, projects, ... [05:50:04] shreyasminocha: same with me (about SAT) [05:50:19] refeedz; yeah [05:50:40] refeed* : yeah [05:50:59] okay [05:51:02] refeed: the US applicant life's the tough life. where do you stay again? [05:52:12] shreyasminocha, I'm still thinking about it [05:56:28] btw shreyasminocha, how are you doing? [05:56:42] all good [05:57:04] have math 2 in a week's time :| [05:57:20] shreyasminocha, exam? [05:57:31] yeah, sat subject test [05:57:58] hmm, okay, I haven't practiced much for the SAT yet T_T [05:58:18] i gave mine this october. not sure if i'll retake. [05:58:59] i'm stuck in the zone that's between "why the hell would you want to retake this score" and "yeah, go for a retake". weird situation. [06:00:28] shreyasminocha, is that a practice test or something? iirc there are two kind of tests in SAT, the practice one, and the real one [06:00:52] first there's the SAT with reading, writing and math [06:00:55] or perhaps I misunderstood with ACT [06:01:14] then there are SAT subject tests for each subject. colleges require two to three subject tests in addition to the SAT/ACt [06:02:16] and ofc you can practice at home with full-length tests. that's separate. [06:03:05] 10Google-Code-in-2018, 10JSDoc WMF theme, 10Technical-Debt: Implement linting for JSDoc Wikimedia theme own specific styles and scripts - https://phabricator.wikimedia.org/T209561 (10Shreyasminocha) a:03Shreyasminocha [06:03:49] shreyasminocha, ah okay, I see [06:04:15] shreyasminocha, btw I have a question for you in T196776 [06:04:15] T196776: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 [06:04:29] sure, fire away [06:04:41] i'll try to answer [06:05:32] 10Wikimedia-Site-requests: Revert FlaggedRevs changes on the Hungarian Wikipedia - https://phabricator.wikimedia.org/T210224 (10Tgr) MediaWiki has a public log of all edits and registrations; I'm not sure what other data we would want to collect. It's just that someone needs to actually analyse it. I don't thin... [06:06:46] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Kaartic) I could help with the English one but there's one thing that I'm doubtful about. I'm **not a** native English speaker. So I'm not sure I could do this correctly, could I? [06:10:54] 10Google-Code-in-2018, 10JSDoc WMF theme, 10Technical-Debt: Implement linting for JSDoc Wikimedia theme own specific styles and scripts - https://phabricator.wikimedia.org/T209561 (10Shreyasminocha) [06:11:58] refeed: are you around? [06:12:12] shreyasminocha, yes [06:12:25] still have a question? [06:14:48] shreyasminocha, yup, my question in T196776 still hasn't answered yet. It's an "are you still working on this task?" question. [06:14:48] T196776: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 [06:14:57] https://phabricator.wikimedia.org/T196776#4768786 [06:16:58] i am SO sorry [06:17:33] i didn't get a notif for your question and i forgot to un-claim it after i abandoned it on GCI (because i didn't have time then) [06:18:36] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10Shreyasminocha) a:05Shreyasminocha>03None @rafidaslam sincere apologies for not un-claiming it here after abandoning it on th... [06:19:43] shreyasminocha, no problem :) [06:20:05] I think Nathan_fraignt is working on it right now [06:20:28] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10rafidaslam) a:03Nathan_fraignt [06:20:55] refeed: once again, sorry for the trouble caused :( [06:21:18] although if the task is still available on the GCI interface, you can claim it and submit a patch [06:21:37] (although that might be "un-sportsmanly", but permitted anyway) [06:25:54] np, yeah it is permitted I think, but it can be caused by the person forgot to claim the task in GCI interface, if that's the case we need to ping the person to claim the task in GCI interface [06:26:53] * refeed hopes he could edit a msg in irc [06:27:33] (03CR) 10Gergő Tisza: Add wfGetErrorText, a global helper function for log error formatting (032 comments) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [06:27:33] my guess is that Nathan_fraignt was waiting for review on another task so he decided to submit a patch for this one without first claiming it on GCI ('coz one task at a time) [06:27:58] (03CR) 10Gergő Tisza: [C: 04-1] Add wfGetErrorText, a global helper function for log error formatting (031 comment) [core] - 10https://gerrit.wikimedia.org/r/467111 (owner: 10Gergő Tisza) [06:41:39] 10MediaWiki-extensions-Linter: Some lint issues are linked to attributed template without the Template: namespace prefix - https://phabricator.wikimedia.org/T210315 (10TheDragonFire) [06:47:31] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Allow users to deactivate their own account - https://phabricator.wikimedia.org/T209317 (10rafidaslam) 05Open>03Resolved [06:51:29] shreyasminocha, I'm not sure, I could see the gci task before Nathan_fraignt uploaded his patch, but right after he submitted the patch I can't see it again now [06:54:05] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10rafidaslam) @Shreyasminocha no problem :) [07:00:41] Hello, i am on IRC for GCI [07:16:38] Uskompuf, welcome! [07:17:42] :) [07:32:13] 10TWLCon-2019-India: Add topics from participants to the program - https://phabricator.wikimedia.org/T210255 (10ManavpreetKaur) a:03ManavpreetKaur [07:32:36] 10TWLCon-2019-India: Survey from participants - https://phabricator.wikimedia.org/T210254 (10ManavpreetKaur) a:03ManavpreetKaur [07:33:26] 10TWLCon-2019-India: Finalise a draft of program - https://phabricator.wikimedia.org/T210253 (10ManavpreetKaur) a:03ManavpreetKaur [07:34:27] 10TWLCon-2019-India: Finalise and Publish on Meta-Wiki - https://phabricator.wikimedia.org/T210256 (10ManavpreetKaur) a:03ManavpreetKaur [08:03:53] (03PS1) 10Shreyasminocha: Implement js, css linting [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) [08:07:37] 10Google-Code-in-2018, 10JSDoc WMF theme, 10Patch-For-Review, 10Technical-Debt: Implement linting for JSDoc Wikimedia theme own specific styles and scripts - https://phabricator.wikimedia.org/T209561 (10Shreyasminocha) I've added `grunt lint`. Now either you could create several tasks ("Fix lint errors ...... [08:10:12] 10Wikidocumentaries: Define saving an image in Wikidocumentaries - https://phabricator.wikimedia.org/T197968 (10Susannaanas) [08:11:05] prtksxna: hey! is the task for T209562 unclaimed? [08:11:06] T209562: Font family for code needs improvement - https://phabricator.wikimedia.org/T209562 [08:11:35] 10Wikidocumentaries: Create mockups for image interfaces in Wikidocumentaries - https://phabricator.wikimedia.org/T208388 (10Susannaanas) [08:11:48] shreyasminocha: I think so, let me double check on the dashboard once [08:12:51] shreyasminocha: Yup its unclaimed on the dashboard as far as I can see [08:13:51] Thanks for the linting patch shreyasminocha, I'll review it in a bit :) [08:14:05] hello everyone! [08:14:07] np. i'll claim the other one once this's done [08:14:11] takidelfin: hey [08:14:53] i'm so happy to be able to contribute again after my sabbatical [08:15:37] *sabbatical*? [08:16:24] paid holiday/vacation granted for personal reasons [08:16:33] (although mine wasn't paid or compensated for) [08:16:37] :D [08:17:30] thanks :D [08:20:26] so takidelfin, tell me: what's up? [08:23:24] (sucks how you don't get irc pings when your nick is not the first word in the message) [08:23:25] I'm waiting for my task get reviewed [08:23:36] aha. which one? [08:23:44] Lua 7 :( [08:23:57] nice. finally done with it? [08:24:14] I was trying to develop easy expandable solution D: [08:24:19] I think yes :D [08:24:31] (03CR) 10Prtksxna: [C: 04-1] "Thanks for working on this Shreyasminocha! This works great, but I had a few small things to mention:" [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) (owner: 10Shreyasminocha) [08:24:39] (:D D:) [08:24:49] mm [08:25:42] prtksxna: alright. lemme fix it rn. [08:26:04] shreyasminocha: btw I'll raise a separate task (on phab and GCI dashboard) for fixing the errors [08:26:11] shreyasminocha: Thanks [08:26:17] my pleasure [08:27:35] prtksxna: does me changing `"test": "jsdoc -c fixtures/fixtures.conf.json"` to `"test": "jsdoc -c fixtures/fixtures.conf.json && grunt lint"` work? [08:28:18] shreyasminocha: yep [08:32:17] (03PS2) 10Shreyasminocha: Implement js, css linting [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) [08:32:34] (03PS3) 10Shreyasminocha: Implement js, css linting [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/475582 (https://phabricator.wikimedia.org/T209561) [08:33:21] (03PS3) 10Amire80: Move all apihelp translatable messages to separate files [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/475357 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [08:33:45] (03CR) 10Amire80: [C: 032] Move all apihelp translatable messages to separate files [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/475357 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [08:40:03] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:41:35] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:42:19] 10MediaWiki-Language-converter, 10Chinese-Sites: Language converter problems after WMF software updating - https://phabricator.wikimedia.org/T25115 (10Liuxinyu970226) [08:43:17] 10MediaWiki-Internationalization, 10MediaWiki-User-preferences: "Member of group(s)" in Special:Preferences causes language difficulties - https://phabricator.wikimedia.org/T16454 (10Liuxinyu970226) [08:46:11] (03Merged) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/475357 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [08:46:31] 10Wikidocumentaries: Create a fallback header for a topic without image - https://phabricator.wikimedia.org/T210316 (10Susannaanas) p:05Triage>03Normal [08:47:32] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:48:07] (03CR) 10jenkins-bot: Move all apihelp translatable messages to separate files [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/475357 (https://phabricator.wikimedia.org/T189982) (owner: 10Zoranzoki21) [08:48:59] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:49:31] 10MediaWiki-Internationalization, 10Chinese-Sites: Chinese needs sensible fallback character encoding set - https://phabricator.wikimedia.org/T19020 (10Liuxinyu970226) [08:50:05] 10MediaWiki-Internationalization, 10MediaWiki-Special-pages: The info on special:Version should follow the direction of the language - https://phabricator.wikimedia.org/T21170 (10Liuxinyu970226) [08:52:19] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:52:22] 10MediaWiki-Page-deletion: Special:Undelete title search should not be case sensitive - https://phabricator.wikimedia.org/T187307 (10Liuxinyu970226) [08:53:35] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [08:54:36] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) p:05Triage>03Normal [08:55:26] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) p:05Normal>03Triage [08:58:50] `Fix rendering problems around image captions on mobile Internet Explorer` [08:58:56] mobile Internet Explorer [09:00:51] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:01:49] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:06:40] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:07:22] 10MediaWiki-Internationalization, 10I18n, 10RTL: Names.php includes RTL control characters - https://phabricator.wikimedia.org/T40674 (10Liuxinyu970226) [09:08:37] 10MediaWiki-Internationalization, 10User-MarcoAurelio: Add Nataoran/Sakizaya (ais) to Names.php - https://phabricator.wikimedia.org/T174601 (10Liuxinyu970226) [09:17:24] (03PS2) 10Arcayn: Add spacing below buttons on mobile ticket detail [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475506 (https://phabricator.wikimedia.org/T209865) [09:17:42] 10Wikidocumentaries: Research language fallback in Wikidata and reuse - https://phabricator.wikimedia.org/T210318 (10Susannaanas) p:05Triage>03Normal [09:20:22] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:21:08] (03CR) 10Urbanecm: [C: 032] Add spacing below buttons on mobile ticket detail [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475506 (https://phabricator.wikimedia.org/T209865) (owner: 10Arcayn) [09:21:27] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:22:35] (03Merged) 10jenkins-bot: Add spacing below buttons on mobile ticket detail [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475506 (https://phabricator.wikimedia.org/T209865) (owner: 10Arcayn) [09:22:43] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [09:23:09] 10Wikidocumentaries: Make fallback options for missing content and translations - https://phabricator.wikimedia.org/T210231 (10Susannaanas) [09:24:14] 10Wikidocumentaries: Language fallback tasks - https://phabricator.wikimedia.org/T210317 (10Susannaanas) [09:26:22] 10Wikidocumentaries: Define saving or syncing an image with Wikimedia Commons - https://phabricator.wikimedia.org/T210305 (10Susannaanas) p:05Triage>03Normal [09:26:51] 10Wikidocumentaries: Create a list of most significant Wikidocumentaries topics from Wikidata - https://phabricator.wikimedia.org/T207734 (10Susannaanas) p:05Triage>03Low [09:27:00] 10Wikidocumentaries: Create tiled view for the Images section - https://phabricator.wikimedia.org/T210096 (10Susannaanas) p:05Triage>03Normal [09:27:57] 10Wikidocumentaries: Create a model entry for an image - https://phabricator.wikimedia.org/T208379 (10Susannaanas) p:05High>03Low [09:28:42] 10Wikidocumentaries: Configure wikidocumentaries.io domain at wikidocumentaries.wmflabs.org - https://phabricator.wikimedia.org/T207731 (10Susannaanas) p:05Triage>03High [09:28:53] 10Wikidocumentaries: Resolve slow speed of the Wikidocumentaries site - https://phabricator.wikimedia.org/T207630 (10Susannaanas) p:05Triage>03Normal [09:29:01] 10Wikidocumentaries: Allow svg upload to Wikidocumentaries - https://phabricator.wikimedia.org/T206999 (10Susannaanas) p:05Triage>03Lowest [09:29:12] 10Wikidocumentaries: Install Visual Editor for creating local articles - https://phabricator.wikimedia.org/T200605 (10Susannaanas) p:05Normal>03High [09:30:04] 10Internet-Archive, 10Wikidocumentaries: Make image metadata mapping scheme for connected sources - https://phabricator.wikimedia.org/T197970 (10Susannaanas) [09:30:12] 10Internet-Archive, 10Wikidocumentaries: Make image metadata mapping scheme for connected sources - https://phabricator.wikimedia.org/T197970 (10Susannaanas) p:05Normal>03High [09:30:44] 10Wikidocumentaries: Draft the workflow to create a new topic in Wikidocumentaries - https://phabricator.wikimedia.org/T197966 (10Susannaanas) p:05Normal>03High [09:31:37] 10Internet-Archive, 10Wikidocumentaries: Add new APIs - https://phabricator.wikimedia.org/T210302 (10Susannaanas) p:05Triage>03Normal [09:33:01] 10Wikidocumentaries: API tasks - https://phabricator.wikimedia.org/T210300 (10Susannaanas) [09:34:12] (03CR) 10Urbanecm: [C: 04-1] "Quoting from GCI" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475458 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [09:34:50] 10Wikidocumentaries: API tasks - https://phabricator.wikimedia.org/T210300 (10Susannaanas) [09:35:50] 10Wikidocumentaries: API tasks - https://phabricator.wikimedia.org/T210300 (10Susannaanas) [09:37:58] 10Internet-Archive, 10Wikidocumentaries: Add new APIs - https://phabricator.wikimedia.org/T210302 (10Susannaanas) [09:45:50] 10Internet-Archive, 10Wikidocumentaries: Add new APIs - https://phabricator.wikimedia.org/T210302 (10Susannaanas) [09:48:08] 10Internet-Archive, 10Wikidocumentaries: Add new APIs - https://phabricator.wikimedia.org/T210302 (10Susannaanas) [09:49:49] 10Wikidocumentaries: API tasks - https://phabricator.wikimedia.org/T210300 (10Susannaanas) [09:51:45] 10Wikidocumentaries: API tasks - https://phabricator.wikimedia.org/T210300 (10Susannaanas) [09:53:22] 10Wikidocumentaries: Model the pilot data imports - https://phabricator.wikimedia.org/T197961 (10Susannaanas) p:05Normal>03Low [09:54:14] 10Wikidocumentaries: Alter demo http://wikidocumentaries-demo.wmflabs.org/ to navigate via Wikidata items - https://phabricator.wikimedia.org/T207733 (10Susannaanas) p:05Triage>03High [09:54:24] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10Nathan_fraignt) Sorry, I did claim it on GCI (after Shreyaminocha abandonded it), but did not claim it here. [09:55:38] 10Wikidocumentaries: Describe interaction between Wikidocumentaries and Ajapaik - https://phabricator.wikimedia.org/T209612 (10Susannaanas) [09:56:31] prtksxna: did you get a chance to have a look at my updated patch? [09:56:48] shreyasminocha: Sorry not yet, will soon [09:57:08] 10Wikidocumentaries: Describe interaction between Wikidocumentaries and Ajapaik - https://phabricator.wikimedia.org/T209612 (10Susannaanas) [09:57:09] no issue at all. sure. [09:57:40] sorry for bothering [10:01:24] (03PS2) 10Nathan fraignt: Fix order by event-date: "None" is now the oldest [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475458 (https://phabricator.wikimedia.org/T196776) [10:01:49] ah i notice that the "make a config change" task is now back up [10:02:01] Urbanecm: what was the issue with that one? [10:02:37] shreyasminocha: There were some technical issues on Google side [10:03:32] (03PS1) 10Arcayn: Change order of imports stylesheet import and remove !important [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475583 [10:03:38] (03CR) 10jerkins-bot: [V: 04-1] Change order of imports stylesheet import and remove !important [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475583 (owner: 10Arcayn) [10:04:19] (03PS2) 10Arcayn: Change order of imports stylesheet import and remove !important [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475583 [10:05:06] takidelfin[znc]3: "Fix rendering ... on mobile Internet Explorer" probably meant "Fix rendering ... on [the] mobile [website] (Internet Explorer)" [10:06:09] (03CR) 10Urbanecm: [C: 032] Fix order by event-date: "None" is now the oldest [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475458 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [10:07:00] (03Merged) 10jenkins-bot: Fix order by event-date: "None" is now the oldest [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475458 (https://phabricator.wikimedia.org/T196776) (owner: 10Nathan fraignt) [10:07:12] congrats Nathan_fraignt [10:07:27] :D [10:08:03] shreyasminocha: I know :D 'mobile internet explorer [10:08:21] yeah :D [10:08:48] Hi, could I get some help for a task? [10:08:59] what up? [10:11:18] geophertz: Hi, on IRC, there's general unwritten rule: Don't ask to ask, just ask :-) [10:11:41] If somebody knows an answer to your question, they will write it here. If not, you can ask later or on GCI [10:12:07] was about to mention it :) [10:12:38] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Tickets with no event date are being in unuseful order - https://phabricator.wikimedia.org/T196776 (10Urbanecm) 05Open>03Resolved [10:13:11] How do you cite a line in gerrit? [10:13:43] 10MediaWiki-Parser, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Legoktm) p:05Triage>03Unbreak! Sorry, this bug was not triaged properly, it should have been unbreak now!, given that... [10:14:15] geophertz: example https://gerrit.wikimedia.org/r/c/jsdoc/wmf-theme/+/475582/3/Gruntfile.js#15 [10:14:38] in the file url, add a `#x`, where `x` is the line number you want to cite [10:16:01] (you can also just click the line number in the left gutter) [10:16:07] no like that: https://imgur.com/a/vwLGGQN [10:16:40] oh, that's adding a review [10:17:07] sorry, I wasn't sure of the vocab to use [10:17:10] click on the line number in the left gutter, type your message in the text box that appears [10:17:14] no problem [10:17:15] Urbanecm: hi! [10:17:20] ok ty [10:17:30] Hi takidelfin, nice to see you [10:18:39] 10MediaWiki-Parser, 10Regression: "¶ms" URL parameter (used in a link parameter in [[File]] markup) incorrectly parsed as "¶ms" (%C2%B6ms) - https://phabricator.wikimedia.org/T209236 (10Legoktm) ad80f0bca27c2b0905b2b137977586bfab80db34 is the first bad commit commit ad80f0bca27c2b0905b2b137977586bfab80db34... [10:19:47] shreyasminocha: It says there is a draft. But the review doesn't appear in the history. is that normal [10:19:50] ? [10:20:01] (03CR) 10Legoktm: "This caused T209236." [core] - 10https://gerrit.wikimedia.org/r/467529 (https://phabricator.wikimedia.org/T206940) (owner: 10C. Scott Ananian) [10:20:02] go back to the main page of the patch [10:20:08] click the big blue "reply" button [10:20:17] sorry for not making that clear. forgot. [10:20:33] ok thanks. it works [10:20:44] 👍 [10:20:53] 10MediaWiki-Categories, 10Growth-Team, 10Wikimedia-General-or-Unknown: Allow filtering/sorting by categories on "Category:All articles with too few wikilinks" page - https://phabricator.wikimedia.org/T151986 (10Quiddity) [10:24:03] Urbanecm: Could you review my task please ? :D https://codein.withgoogle.com/dashboard/task-instances/4666076265709568/ [10:24:30] this method should be easy to extend tho :D [10:24:50] Looking :-D [10:26:47] do you guys think a GCI bot for irc is a good idea? [10:26:54] like what? [10:27:07] displaying current leaders? [10:27:23] I have got one actually [10:27:25] takidelfin[znc]3: [10:27:43] no, a bot that says "so-and-so task completed. so-and-so task for review. so-and-so new task..." [10:27:55] takidelfin[znc]3: like this? [10:28:02] no no [10:28:45] only private messages right now :( [10:28:57] ah [10:29:09] so how do i use it? just send a pm? [10:29:31] (actually whitelisted to me only) [10:29:46] can you change that please? :) [10:29:49] okay :D [10:30:23] takidelfin: The test table in the instructions defines a format parameter for the dates. Your convertTest function doesn't count with anything like that [10:31:18] ok, adding it [10:33:08] shreyasminocha: nope [10:34:36] takidelfin: then? [10:35:00] wait one second, I need to fix my GCI task first ;-; [10:35:12] sure [10:37:13] shreyasminocha: Btw, the task you saw is still unpublished [10:38:07] which one? [10:38:59] "[TEMP UNPUBLISHED DUE TO GOOGLE REQUEST - TECHNICAL ISSUES] Deploy a Wikimedia site configuration change" is its full title [10:39:07] umm? [10:39:17] Create a Wikimedia site configuration change was never unpublished [10:39:22] Urbanecm: looks like it got published now? [10:39:28] the prefix has been removed at least [10:39:43] https://codein.withgoogle.com/tasks/5612296471576576/?sp-search=Wikimedia%20Configuration%20Change [10:40:08] ah, there are _two_ site requests tasks [10:40:10] Yeah, it isn't published [10:40:32] the one takidelfin linked is for creating a site-request patch [10:40:52] the unpublished one is for getting the change deployed [10:41:00] https://codein.withgoogle.com/tasks/5612296471576576/?sp-organization=4956074911203328&sp-is_beginner=False [10:41:14] this one seems published to me [10:41:15] that's for creating a patch [10:41:22] and it never was unpublished [10:41:35] aha, i mixed them up [10:41:36] You are talking about *deploy* or *create* change? [10:41:52] the problematic task is deploy [10:42:08] Urbanecm: done :D https://en.wikipedia.org/w/index.php?title=User:Takidelfin/sandbox/Dates&action=submit [10:42:24] ops [10:42:25] wrong link [10:43:05] unlike almost all other code bases in Wikimedia, site configuration changes are not deployed automatically, but the author (or somebody else) must schedule them for deployment. That's why I splitted the tasks up [10:43:33] ah [10:49:21] Urbanecm: https://en.wikipedia.org/wiki/Module:Sandbox/Takidelfin/Dates [10:49:37] Will have a look in a moment [10:49:53] :) [10:51:57] https://en.wikipedia.org/w/index.php?title=User:Takidelfin/sandbox/Dates [10:52:17] I quite don't like "31 August 2013 (uncertain)" is "2018-08-31" when using ISO format. In my opinion, it should either note the uncertainity somehow or throw an error, something like "ISO format cannot handle uncertain dates". [10:52:28] Exact solution is up to you of course [10:53:06] hmm, because ISO standard is used to make dates easily parsable, isn't it? [10:53:25] So I will reject it with an error [10:53:29] ok [10:54:17] 27/08/2013 in ISO is 2013-nil-27 [10:54:33] (according to your sandbox) [10:54:48] ._. [10:54:59] same with "04/27/2013" [10:55:01] you can easily differentiate between months/days just by checking if one of them is higher than 12 [10:55:02] yup... [10:55:06] I see now [10:55:16] Nathan_fraignt: yeah, I know [10:55:22] Nathan_fraignt: How that would work for January 01? [10:55:32] *would that work [10:55:36] Parsing dates is not a problem [10:55:53] It wouldn´t, but if you get the date as 01/01/20016 or something, there is no reasonable way to do check that [10:56:46] :D [10:57:10] hmm, you're right, even humans will have problems with parsing this date with no context... [10:57:36] Is it January 1 20016 or 1 Januray 20016 🤔 [10:57:44] hm [10:57:57] yeah 01/02 wouldve been better, but you get the point lol [10:58:31] yeah [10:59:07] that's quite bigger problem, February and January are slightly different from the time side [11:00:25] (03PS1) 10Arcayn: Change check to canHaveTalkPage before calling getTalkPage() [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/475584 (https://phabricator.wikimedia.org/T172146) [11:00:47] https://en.wikipedia.org/wiki/ISO_8601 [11:02:50] (03CR) 10Arcayn: "recheck" [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/475584 (https://phabricator.wikimedia.org/T172146) (owner: 10Arcayn) [11:03:24] takidelfin: 31 August 2013 BC isn't 2013-08-31 in ISO. Two ways: Note your module supports "negative" years (doing something in addition to what's required is only good in this task) and display it correctly or reject with an error. [11:04:21] That is the problem too :( [11:04:56] the problem == when it was mentioned in this chat? [11:05:04] yup [11:05:16] https://www.irccloud.com/pastebin/rvee92O3/ [11:05:35] 10Extension-MobileApp, 10Wikipedia-Android-App-Backlog, 10I18n: Translations for platform-specific change tags are not available - https://phabricator.wikimedia.org/T210319 (10matej_suchanek) [11:06:20] Sorry, real quick, a really dumb question, what the command for checking code style with tox in one file? I just completely forgot it and can´t find it/figure it out [11:06:26] what is the* [11:07:24] no question is dumb, only answers can be dumb [11:07:34] yup :D [11:07:43] 'Tox' You mean this? https://tox.readthedocs.io/en/latest/ [11:08:00] anyway, don't know, it probably differ project by project, as tox is just a framework [11:08:04] https://github.com/tox-dev/tox [11:08:07] this ? [11:08:21] Yes [11:08:40] Yeah, I thought it was tox -e lint [11:09:25] tox -e lint runs only lint environment [11:09:30] maybe try -- [11:10:02] tox -e lint may or may not be working, as it entriely depends on whatever is behind the -e lint [11:10:28] (or as taki says, tox -e lint -- to force the interpreter to interpret as an argument and not as an option> [11:10:32] Yeah I know, but I´m 99% sure this is how it worked a few days ago [11:10:48] spam Arrow up! [11:10:50] :D [11:11:14] Doesn´t work, pycharm terminal doesn´t keep hoistory (I think) [11:11:25] Not from before the session at least [11:11:34] hmm, what comes to my mind is that you used it in another project? [11:11:49] Possibly [11:12:02] it is a TOX plugin? [11:12:19] Nathan_fraignt, anyway, lint should be pretty fast even on whole stream [11:12:22] *tree [11:12:31] how can I possibly write stream instead of tree... [11:12:47] True, but I can´t even get it to only lint. It just does all the tests ( which just took about 10 minutes) or nothing at all [11:13:00] or pipe it into tox linter 🤔 [11:15:15] Urbanecm: done :D [11:15:20] https://en.wikipedia.org/w/index.php?title=User:Takidelfin/sandbox/Dates [11:15:36] Nathan_fraignt, what's content of tox.ini? [11:15:39] takidelfin, looking [11:16:14] Nathan_fraignt: umm, Could you tell me the name of the project? [11:16:19] Maybe I could help you [11:16:21] Pywikibot [11:16:25] I think I got it though [11:16:26] okay [11:16:32] \o/ [11:16:40] It might have been flake8 instead of lint [11:16:41] So what's the command? [11:16:48] ah, true [11:16:49] tox -e flake8 [11:17:03] but it´s the first time running in the project so its still taking a while [11:17:04] because there is a task for Pywikibot flake8 issues :D [11:17:14] lots of tasks [11:17:42] *I haven't even cloned it yet* [11:18:18] I did like 5 of them [11:18:24] Maybe I will do some of these tasks next. I will learn Python then (ﾉ◕ヮ◕)ﾉ*:･ﾟ✧ [11:18:32] but they take a while to be accepted, even if they are already merged [11:18:42] ._. [11:19:14] btw, congratulations on being first student with 30 completed tasks :D [11:19:27] Thanks, how do you see that? [11:19:33] And am I really the first!? [11:19:33] (03PS1) 10Mogmog123: Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) [11:19:38] I second Nathan_fraignt's question [11:19:53] GCI site /shrug [11:20:08] I can only see the leaders, not the amount of tasks [11:20:15] uh [11:20:18] can you send a link? [11:20:35] https://codein.withgoogle.com/organizations/wikimedia/ [11:20:43] 14 leaders :O [11:21:06] takidelfin: There are no numbers on this page [11:21:15] How do you know Nathan_fraignt has 30 tasks completed? [11:21:32] Hah, they are there. [11:21:39] I don´t have them either [11:21:41] this is sad [11:21:43] hidden tho ;c [11:22:02] I´m looking into the xhr request it sends, but don´t see them there either [11:22:08] yes, they are there [11:22:11] just secret :D [11:22:36] Urbanecm: I can even see which tasks have user done [11:22:42] Maybe it is a security issue? [11:23:09] I'm currently trying to find more, maybe there are some serious bugs [11:23:21] And what should I do with them then? [11:23:23] I don´t think you´re supposed to see that [11:23:29] yup, maybe [11:24:37] takidelfin, bugs are supposed to be reported to gci-support@google.com [11:24:55] okay! [11:25:17] I can tell you how I discovered them [11:25:33] maybe google shares them for people who want to find it :) [11:25:48] yes, maybe it is intentional [11:25:51] https://codein.withgoogle.com/api/program/2018/organization/4956074911203328 [11:26:02] (03PS2) 10Mogmog123: Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) [11:26:03] This is the URL that return current leaders [11:26:10] I know, looking into that one [11:26:16] It also returns ID of students [11:26:20] https://codein.withgoogle.com/api/program/2018/taskdefinition [11:26:21] Probably can resolve the IDS [11:26:25] this URL returs tasks [11:26:55] If you properly form the request you can get all available tasks for a org or just for everyone [11:26:58] but [11:27:18] If you will visit page tasks on gci site [11:27:24] It sends request there [11:27:27] So it looks like the API is available to unauthorized users [11:27:42] with parameter not_completed_by [11:28:02] now a little question, how to get tasks completed by user? [11:28:06] It is easy and maybe so stupid :D [11:28:27] I see [11:28:31] :D [11:28:32] https://codein.withgoogle.com/api/program/2018/taskdefinition?completed_by=6751850784096256 [11:28:34] there it is [11:29:00] Urbanecm: So... it is a security issue? [11:29:13] Should I report it to Google? [11:29:23] That is mine lol [11:29:30] yup :D [11:29:46] It's always better to report intentional thing to Google than not reporting a bug [11:29:51] okay [11:29:51] I don´t think you´re supposed to see it [11:30:14] You can fairly easily make a script which checks what users are doing, and you can definetly get an advantage out of that [11:30:19] even if it is just a small one [11:30:21] If you word your message like "I noticed X and I don't think it's intentional" rather than "You have buggy site", it will be only appreciated [11:30:42] :D [11:31:01] But I have the most tasks completed!? That´s pretty cool. Did not expect that [11:31:16] I see usecase (silly, but still) for those data - I guess Google sets the disabled attr of "claim" button based on this [11:31:45] maybe [11:31:48] but that probably could´ve been done by just returning something like: disabled = true [11:31:53] and doing the check serverside [11:32:00] that would make way more sense [11:32:08] yes, that's why I call this usecase as "silly" [11:32:26] Anyway, interesting is that the API takidelfin linked isn't available to mentors [11:32:44] (03PS3) 10Mogmog123: Adding a unit test for CVE-2014-5461 in Scribunto. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) [11:32:54] looks like negated permission checking for me :D [11:33:00] *to [11:33:12] I had to log out to see those data. Really interesting :-D [11:33:28] In that case, it definetly isn´t intentional [11:33:30] I think [11:33:36] https://taki.ml/gci-coala [11:33:45] https://taki.ml/gci-wikimedia-leaders [11:33:55] last url is little bugged [11:34:07] (I meant to see it in the API, I have easier way to access it - simply use mentors' interface) [11:35:24] anyway, I'm going to a shop. See you all in a while! [11:35:29] Cya! [11:35:40] takidelfin: If I didn't told you yet, the nil issue isn't resolved yet [11:35:58] oh [11:35:59] weird [11:36:05] goodbye anyway, I will fix it :D [11:39:27] holly molly... I have sent it from my second mail :D [11:39:39] sent what? [11:39:47] a report to gci-support [11:40:04] Don´t think that matters too much [11:40:35] shrugg [11:53:40] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (032 comments) [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/475286 (owner: 10ItSpiderman) [11:56:56] Urbanecm: now that weird nil is gone :D https://en.wikipedia.org/w/index.php?title=User:Takidelfin/sandbox/Date [11:58:14] (03CR) 10Raimond Spekking: [C: 04-1] "i18n review" (033 comments) [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/475285 (owner: 10ItSpiderman) [11:58:24] Hey guys [11:58:27] what is going here lol [11:59:02] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/475288 (owner: 10ItSpiderman) [11:59:30] Hello TheJair :D [12:00:01] Hi takidelfin [12:03:32] I'm back [12:03:38] Hi Urbanecm [12:03:44] Hi TheJair [12:07:02] takidelfin: Looks good now to me. BTW, "or nil" is redundant [12:07:38] in the p.convertDate frame? [12:07:46] yeah [12:07:49] something or "something else" is a shotcut for if something == nil then something = "something else" end [12:08:27] (almost, it is an expression assigned to nowhere, but I hope you get the point) [12:08:51] Yup, I know what or does :D [12:09:13] I have just added it as an 'anti weird bugs' [12:09:17] ah [12:09:47] Because I have included nil check in convertDate [12:10:14] it should be nil, but.. Weird things can happend D: [12:10:22] sureyeah [12:10:25] ehh [12:10:41] anyway, approved [12:13:32] * Hauskatze wrongly downloaded Python 32 bits [12:13:35] sigh [12:13:41] uninstall - reinstall again [12:13:42] :\ [12:14:35] * Urbanecm uses apt-get install python [12:15:09] I don't have that fancy tool :) [12:16:29] <_refeed_> takidelfin, heh, that's interesting (GCI API), I just know Google exposed those data [12:16:39] (03CR) 10Mogmog123: "This change is ready for review." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/475586 (https://phabricator.wikimedia.org/T209232) (owner: 10Mogmog123) [12:17:17] * refeed uses dnf [12:17:44] * refeed recommends Urbanecm to start using `apt install` instead of `apt-get install` [12:25:30] Hauskatze: try chocolatey [12:25:33] https://chocolatey.org [12:25:40] https://chocolatey.org/packages?q=python [12:27:10] 10MediaWiki-extensions-PageAssessments, 10Community-Tech, 10Timeless: Special:PageAssessments project form field autocomplete ends up in the main search box's autocomplete when using Timeless skin - https://phabricator.wikimedia.org/T210321 (10Legoktm) [12:32:13] Urbanecm, Do you have any more tracker tasks coming up? [12:35:19] hey guys [12:35:36] Hi bjornskjald [12:41:47] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Jony) If required help for advanced English I could do it. [12:46:33] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10bmansurov) @Kaartic thanks! We'd prefer to have native experienced English editors in order to not let subtle mistakes in. [12:48:28] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10bmansurov) @Jony if you're a native English speaker and are an experienced enwiki editor, I'll send you an invitation to edit the file (if I can have your email — you can email... [12:56:45] Hey Ebe123 [12:56:58] Helllo! [12:57:36] I updated the caption to a row btw :) [12:58:49] Thanks! [12:59:08] Approved task [12:59:23] Yay [13:03:04] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Jony) @bmansurov I'm not native English speaker but my English level is good also I've two years experience on enwiki. If anything for me let me know I'll give you a email. Sinc... [13:06:37] * Urbanecm hates Windows, constantly switching keyboard layouts... [13:11:24] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow superusers and users granted special permission to comment even enable_comment is False - https://phabricator.wikimedia.org/T210309 (10Urbanecm) [13:13:44] 10MediaWiki-Releasing: Add Git tags REL1_XX for historical branches - https://phabricator.wikimedia.org/T188084 (10Seb35) I didn’t know git-ls-remote, that helps a bit, but from a programmatic (or mental for humans) point of view you still have to implement some logic to: 1. git ls-remote 2. remove various stuff... [13:14:36] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow superusers and users granted special permission to comment even enable_comment is False - https://phabricator.wikimedia.org/T210309 (10Urbanecm) https://codein.withgoogle.com/dashboard/tasks/4954353061330944/ [13:16:39] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow superusers and users granted special permission to comment even enable_comment is False - https://phabricator.wikimedia.org/T210309 (10Urbanecm) [13:16:51] 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10Tracking: Language tools maintenance intervention: Improve the quality of translations for Translate extension - https://phabricator.wikimedia.org/T204818 (10matej_suchanek) [13:16:55] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-Translate, 10Language-Team (Language-2018-October-December), 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10User-notice: A translatable subpage page should not be messed while moving subpages - https://phabricator.wikimedia.org/T114592 (10matej_suchane... [13:23:43] Hi! I am a gci participant [13:23:50] Hi rachit [13:24:03] urbanecm can you help me [13:24:13] Hi rachit [13:24:23] Ask your question ;-) [13:24:24] i need help regarding a task related to lua [13:24:27] sure [13:24:57] I am stuck on step 3 [13:25:54] of task 3, I guess? [13:26:04] https://en.wikipedia.org/wiki/User:RexxS/GCI-Task03 i am stuck on step 3 of this task [13:26:13] yes [13:26:25] 3. Write a line of code that returns something like 15 degrees Celsius is 59 degrees Fahrenheit. when the function is passed 15 as the |celsius= parameter. You'll need the concatenation (..) operator that puts strings together. Save your module sandbox. [13:26:30] this line? [13:26:43] yes [13:27:08] rachit, your function Temperature in your module sandbox (https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech) doesn't return anything [13:27:20] Compare it with your hello function to see the difference [13:27:33] yeah [13:27:47] the step 3 asks you to make the function return like "15 degress Celsius is 59 degress Farenheit" [13:28:06] (of course, the numbers should match numbers user entered/your program calculated) [13:28:14] rachit, is it more clear to you now? [13:29:09] i am so sorry , i am unable to understand [13:30:16] takidelfin, can you try to say what I just said in your own words? [13:30:31] 10MediaWiki-Change-tagging, 10Wikidata, 10MW-1.27-release (WMF-deploy-2015-11-03_(1.27.0-wmf.5)), 10MW-1.27-release-notes, and 3 others: Performance issues with tags - https://phabricator.wikimedia.org/T91535 (10matej_suchanek) [13:30:33] okay, I will try [13:30:45] thanks :-) [13:30:54] so... [13:31:11] You have got a variable fah, right? [13:31:19] yeah [13:31:34] fah is the result of convertingcelsius to fahrenheit [13:31:43] yes [13:32:10] step 3 says that you need to display ( so return it like in Hello function ) the result [13:32:27] so you need to display variable fah [13:33:25] and 'displplaying' a variable is handled by Scribunto, so you don't need to manipulate the DOM (I mean you don't need to do anything with HTML) [13:33:31] *displaying* [13:33:44] Urbanecm, when posting a comment on tracker (my own local version) I get the following error: ¨RelatedObjectDoesNotExist at /comments/post/ [13:33:44] User has no trackerpreferences. [13:33:45] ¨. AFAIK I didn´t edit anything. Can you check if you have the same error? [13:33:51] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech i just made a change can you tell me if its corect ? [13:34:08] umm, [13:34:13] sadly no :/ [13:34:23] leave the fah variable as it is [13:34:52] then? [13:34:54] because the way as you did it tells lua that it you want to return a string (and this string is your fah variable *declaration* [13:34:56] Nathan_fraignt, that's because new object that is connected to user was added and no migrations assuring it really exists for all users were added :-( [13:35:04] you can try 'return [13:35:15] this returns the variable *value* [13:35:18] Nathan_fraignt, you can fix it by doing manage.py shell and in that shell save each user [13:35:27] >> from django.contrib.auth.models import User [13:35:35] >> for u in User.objects.all() [13:35:38] .. u.save() [13:35:42] like that ^^^ [13:35:58] thanks! [13:36:00] ehh, missing semicolon after for :-( [13:36:17] rachit: try it, maybe then you will figure out what to do :D [13:36:20] No problem, I get the point :) [13:36:38] There are Django tasks? [13:36:55] Ebe123: Tracker task [13:37:15] Ebe123, yep, Tracker (an expense tracking app developped&used by Wikimedia CZ) is a Django app [13:37:20] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech takidelfin: can you please check again ? [13:37:27] Ah [13:37:31] Not in GCI anymore (not that I could find anyway) [13:37:33] rachit: umm [13:37:58] You are closer [13:38:17] but you are still returning a string [13:38:29] examples of string: "blah" [13:38:34] Nathan_fraignt, I'll create some more tasks soon :-D (I'm surprised by the speed they're getting completed) [13:38:36] "" [13:38:58] string is a word wrapped in " [13:39:10] so, doing "fah" returns a string fah [13:39:15] Urbanecm, you are one of the fastest mentors with tasks that are fun to do [13:39:16] not value of variable fah [13:39:36] so, to return a value of variable, you shouldn't wrap it in " [13:39:37] takidelfin: https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech now? [13:39:38] Nathan_fraignt, If you want to, you can add a data migration to add new TrackerPreferences to all users that exist. [13:39:50] Thank you, it's nice to hear that [13:40:02] oh [13:40:07] by the way, should the buttons on the post commnet form thingie be bootstrap styled? [13:40:11] comment* [13:40:19] rachit: sorry, I my explaination is bad [13:40:28] String - everything wrapped in " [13:40:39] I´ll have a look, but I´ve never done any migrations, so no promises [13:40:57] Nathan_fraignt, yep, looks I totally overlook that button. [13:41:05] rachit: https://www.lua.org/pil/2.4.html [13:41:06] but if i put it only then it shows an error [13:41:26] yeah, because you should not put < > [13:41:42] Nathan_fraignt, it's basically one method that will contain the code you ran manually. Should be easy to do. As always, ask me if you run into issues [13:41:52] forget that "" [13:41:55] string is "string" [13:42:01] or "blah" [13:42:07] or "15 C" [13:42:17] um [13:42:23] okay i got string [13:42:50] now, drop these brackets and " from the return [13:43:06] okay done [13:43:27] (Could you publish your changes in your sandbox, please?) [13:43:42] done [13:43:55] Yay! [13:44:05] Now it is correct [13:44:13] but, you are returning a fah now [13:44:14] okay wow [13:44:20] and fah is just a result of calculations [13:44:21] so [13:44:27] return fah returns eq. 15 [13:45:18] (03PS1) 10Nathan fraignt: Fix button style in add comment form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475589 [13:45:29] got it takidelfin: [13:45:33] but the task says that you need to return a string eq."15 Celsius is 59 Fahrenheit" [13:45:48] now, you need to join a string with your result [13:46:22] and how do i join a string with my result [13:46:25] so: you have got now two variables, cel - celsius deegres, and fah - result of converting celsius to fahrenheit [13:46:33] yes [13:46:46] and joining a string is done like this: " My name is " .. myName [13:46:53] (03CR) 10Urbanecm: [C: 032] Fix button style in add comment form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475589 (owner: 10Nathan fraignt) [13:46:53] myName is a variable [13:47:33] another example: " My name is " .. myName .. "!" [13:47:47] (03Merged) 10jenkins-bot: Fix button style in add comment form [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475589 (owner: 10Nathan fraignt) [13:48:08] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech takidelfin: can you check it again? [13:48:15] sure [13:48:31] You need to return this string [13:48:44] remove the linebreak after return fah [13:48:48] it should be one line [13:48:59] like: return "fah is " .. fah [13:49:05] ok [13:49:31] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech now? [13:50:15] um [13:50:35] return fah "fah is " .. fah => should be return "fah is " .. fah [13:50:46] takidelfin, reload ;) [13:51:05] (still the same) [13:51:23] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech now? [13:51:38] Correct! [13:51:41] \o/ [13:51:55] Thank you so much :)) [13:52:08] Almost correct, the returned string does not match the sentence from step 3 [13:53:07] urbanecm: what? [13:53:38] yup [13:53:46] The text the function returns should be "15 degrees Celsius is 59 degrees Fahrenheit", where 15 and 59 are cel and fah respectively [13:53:48] Now make it return a string as step 3 says :D [13:54:29] (03CR) 10Flutterish: "> Patch Set 4:" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/475338 (https://phabricator.wikimedia.org/T71237) (owner: 10Flutterish) [13:55:05] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech is it correct ? urbanecm [13:55:37] Nope, that would result in string "15 degrees Celsius is 59 degrees Fahrenheit " [13:55:52] This can help you: https://en.wikipedia.org/wiki/User:Martin_Urbanec/sandbox [13:55:56] I called your function in my sandbox [13:56:03] you can see its output there [13:56:40] so the output is incorrect right? [13:56:43] yeah [13:57:02] how do i resolve it? [13:57:08] it should be " degress Celsius is degress Fahrenheit" [13:57:40] you need to touch the line starting "return" in your function [13:57:50] and what should should be after .. [13:57:52] fah? [13:58:01] you can use as many .. as you want [13:58:14] .. means "take what is on my left side and on my right side and join it to one string" [13:58:38] (03PS1) 10Rafidaslam: Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) [13:58:55] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech now/ [13:58:58] ? [13:59:08] No [13:59:13] What I wrote wasn't Lua code [13:59:36] it was how the output should look like [13:59:59] (03CR) 10jerkins-bot: [V: 04-1] Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) (owner: 10Rafidaslam) [14:00:14] step 3 wants you to write code to return this output [14:00:41] okay i'll try again [14:02:27] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech urbanecm:now? [14:02:33] hi rachit [14:02:59] hi shreyasminocha [14:03:09] no :-( [14:03:23] :( [14:03:30] idk how to put strings together :( [14:03:33] haven't seen you around here earlier rachit [14:03:40] by using .. operator [14:03:43] what's the issue? [14:03:45] let's use an analogy [14:04:22] do you know how you would multiply two numbers? [14:04:35] shreyasminocha: i am not able to complete step 3 of lua task 3 [14:04:42] by using * [14:05:06] how would an expression multpilying 3 by 2 look like? [14:05:20] 3*2 [14:05:38] multiplying a and b will be a*b [14:05:42] exactly. It's very similar how putting strings together work. [14:05:59] in your example rachit, 3 is left operand, 2 right operand and * is the operator [14:06:13] (03PS2) 10Rafidaslam: Allow user that has no old password to create a password [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) [14:06:23] if you want to put two strings together, you must use .. as the operator (in Lua) [14:06:38] multiplying a by 3 will be a * 3. similarly, you can concatenate (add together) var, literal; literal, literal; var, var [14:06:45] just use .. instead of * [14:07:08] so do i need to put two strings "15 degress Celsius" and " 59 degress Fahrenheit" together by operator * ? [14:07:16] not *, but .. [14:07:24] BUT [14:07:33] you need to get the number of degrees too [14:07:43] so you add no of degrees to " degrees celsius" [14:07:46] and so on [14:08:03] the multiplication thing was an analogy to show you operators work on an example you might know [14:08:13] (you know according to what you just said) [14:08:29] (you can add a number to a string too. lua automatically converts the number to a string) [14:08:48] (aka implicit typecasting) [14:09:37] should it be return"15 degress celsius".."59 degrees fahrenheit" .. fah? [14:09:44] almost [14:09:54] but, you'll want to use the correct number of degrees to rachit [14:10:01] and the correct number of fahrenheit [14:10:07] it wouldn't always be 15 degrees [14:10:13] or 59 degrees for that matter. [14:10:51] you'll have to use the variables that store number of celsius and number of fahrenheit when making the string [14:10:58] so what do i have to write instead of 15 and 59? [14:11:02] ohhk [14:11:07] i think i got it [14:11:13] excellent [14:11:39] should it be return"cel degress celsius".."fah degrees fahrenheit" .. fah? [14:11:40] Urbanecm, is there a way to check if a user is trusted? Or do I need to edit the trackerprofile model to include that? (regarding T210309 ) [14:11:41] T210309: Allow superusers and users granted special permission to comment even enable_comment is False - https://phabricator.wikimedia.org/T210309 [14:12:00] `cel` and `fah` shouldn't be within the string [14:12:11] if you put them inside the string, their true values wouldn't be used [14:12:34] but lua will play a joke (of sorts) on you and literally say "cel degrees calsius" [14:12:37] should it be return" degress celsius".."degrees fahrenheit" .. fah .. cel? [14:12:53] that's how it works in some languages, but not here [14:13:00] add the parts together in order :) [14:13:32] should it be return"degress celsius".."degrees fahrenheit" .. cel .. fah ? [14:13:51] put the variables where you want them to be replaced [14:14:05] (03CR) 10Florianschmidtwelzow: [C: 032] Add namespace to action=info page [core] - 10https://gerrit.wikimedia.org/r/475333 (https://phabricator.wikimedia.org/T123228) (owner: 10Pjht) [14:14:36] shreyasminocha i dont get it [14:14:47] let me explain [14:14:59] it's similar to natural speaking order [14:15:29] when you want to say something without using the exact values, you use `x books, y pens` for example [14:15:41] ya [14:15:42] you don't say `books, pens, x, y` [14:15:53] see where this is going? ;) [14:15:54] ok i think i got it [14:16:27] should it be return..cel"degress celsius"..fah"degrees fahrenheit" ? [14:16:42] you're so close [14:16:53] you're just putting some dots in the wrong places [14:17:05] and not putting them in some places [14:17:37] when you do addition, you use the `+` operator on both sides [14:17:52] `1 + x + 2 + y` [14:18:06] yes [14:18:21] try once more, i think you'll get it right this time [14:18:56] should it be return cel.."degress celsius"fah.."degrees fahrenheit" ? [14:19:19] Nathan_fraignt, just add django permission [14:19:24] admins will grant it to users they trust [14:19:27] rachit: look closely at that. [14:19:33] should it be return ..cel.."degress celsius"..fah.."degrees fahrenheit" ? [14:19:51] get rid of the dots between return and cel, you should be good [14:20:04] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Add some space between two rows of button - https://phabricator.wikimedia.org/T209865 (10rafidaslam) 05Open>03Resolved [14:20:05] you aren't concatenating some `return` variable to `cel`, right :) [14:20:07] Nathan_fraignt, https://docs.djangoproject.com/en/2.1/topics/auth/customizing/#custom-permissions describes how to add custom permission [14:20:19] should it be return cel.."degress celsius"..fah.."degrees fahrenheit" ? [14:20:25] Thanks, I did not Django had it´s own permission thingie [14:20:29] did not know * [14:20:39] perfect. try it once. there's one very minor thing you're missing, but it's best caught by trying rachit [14:21:04] okay thank you shreyasminocha :) [14:21:13] np :) [14:22:12] rachit: found it? [14:22:39] ah, looks like your cel variable is empty [14:23:09] shreyasminocha why do you think? https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech shows something [14:23:16] rachit: you're calling the function incorrectly [14:23:30] when you're passing parameters, you want to use the name of the parameter to [14:23:37] you're doing {{#invoke:Sandbox/bleed.tech|Temperature|25}} [14:23:51] but the instructions explicity ask you to use `|celsius=25` [14:24:10] ohh [14:24:29] One more question Urbanecm, as far as I can tell, the permissions need to be added by the model that they are relevant too. Comments however don´t have a model. Where do I add it? [14:24:53] aha! now you see what i was talking about rachit? [14:25:03] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech [14:25:05] https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox [14:25:06] now? [14:25:20] looks like your fahrenheit value is incorrect in the output [14:25:33] both of them aren't supposed to be 59 in fahrenheit obv [14:25:42] exactly [14:25:56] and i dont get where am i going wrong :( [14:25:59] try figuring out yourself, i'll step in if you can't [14:26:26] Nathan_fraignt, permission "Bypass disabled comments restriction" (or whatever you call it) is relevant to user too [14:26:30] check it out now [14:26:36] shreyasminoch [14:26:59] (03CR) 10jerkins-bot: [V: 04-1] Add namespace to action=info page [core] - 10https://gerrit.wikimedia.org/r/475333 (https://phabricator.wikimedia.org/T123228) (owner: 10Pjht) [14:27:02] urbanecm can you check and tell me if its correct? [14:27:17] rachit: neat. just follow the exact format they want you to [14:27:21] Nathan_fraignt, as you cannot touch User model directly, I'd add it to TrackerProfile [14:27:36] Urbanecm, Alright, Thanks! [14:27:37] rachit: read step 3. what's the exact format they use [14:27:48] yw [14:28:20] Write a line of code that returns something like 15 degrees Celsius is 59 degrees Fahrenheit. when the function is passed 15 as the |celsius= parameter. You'll need the concatenation (..) operator that puts strings together. Save your module sandbox. [14:28:37] whats the format? [14:28:37] "15 degrees Celsius is 59 degrees Fahrenheit" [14:28:44] Nathan_fraignt, looks like you didn't claim the task on GCI. Can you do it please? [14:29:01] rachit: if you pass 15, will it give that *exact* output? [14:29:08] I can´t find it yet [14:29:10] On GCI [14:29:18] rachit: even without trying it's clear it wouldn't [14:29:28] ya [14:29:28] try fixing that and i think you should be good to go [14:29:29] Nevermind, it just popped up [14:29:32] Nathan_fraignt, https://codein.withgoogle.com/tasks/4954353061330944/ [14:29:53] Nice [14:30:00] Yeah I had the link from the phab. task, but it hadn´t loaded on GCI [14:30:46] shreyasminocha sorry i dont understand [14:30:59] capitalization, spaces, ... [14:31:13] Ok Nathan_fraignt :) [14:32:13] rachit: i suggest installing the lua interpreter on your computer so that you can try lua expressions on your computer before you use them in your sandbox [14:32:13] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Empty line in comments should be interpreted as new paragraph - https://phabricator.wikimedia.org/T210237 (10Urbanecm) [14:32:59] rachit: adding a space between the operators will not translate to a space in the final string [14:33:37] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Empty line in a comment should be interpreted as new paragraph - https://phabricator.wikimedia.org/T210237 (10Urbanecm) [14:33:53] if you want to include something, say a space, in oone of your strings, you should add it inside the quotation marks because the quotation marks are the boundary of the string [14:34:49] i dont understand what is wrong with what i've already done? [14:35:07] Urbanecm: is the exact formatting necessary for the task? [14:35:59] although they should know it for their own good, don't want to make them spend unnecessary time fixing this if they don't want to [14:36:12] unnecessarily spend time* [14:37:05] i do want to fix this but i am still unclear on how to :( shreyasminocha [14:37:14] oh okay, sure then [14:37:27] you've understood what we're trying to do, right? [14:37:42] shreyasminocha, well, I might accept a task with slightly wrong formatting (like one missing space), but a whole word missing in the message [14:37:48] *a whole word is missing [14:37:52] i dont understand what you mean by format [14:37:59] ohh [14:38:31] Urbanecm: aah, didn't notice that. i was referring to the missing spaces rachit. [14:39:24] all of them shouldnt be on one line ? shreyasminocha [14:39:40] nothing like that [14:39:50] first off, add the missing word [14:40:02] 10MediaWiki-Installer: PHP Fatal error: Call to undefined function MediaWiki\suppressWarnings() in ... Maintenance.php on line 960 - https://phabricator.wikimedia.org/T106148 (10Seb35) p:05High>03Normal Still an issue? It seems to work in [recent builds](https://travis-ci.org/SemanticMediaWiki/SemanticExtra... [14:40:36] is the missing word
[14:40:41] no [14:40:52] your output is "5degress Celsius41degrees Fahrenheit" [14:41:04] yes [14:41:09] their output is "5 degrees Celsius is 41 degrees Fahrenheit. [14:41:26] notice the differences? [14:41:35] "is" [14:41:45] that's the missing word, yes [14:41:52] apart from that, missing spaces [14:42:03] how do i add "is" with the other strings [14:42:15] you don't need to add it separately [14:42:29] just add it to one of the existing string literals [14:43:03] (a string literal is a string you type out explicitly and surround with quotation marks) [14:43:18] currently, you have return cel.."degress Celsius"..fah.."degrees Fahrenheit" [14:43:29] edited. [14:43:41] alright, great [14:43:45] the missing word is there [14:43:48] now about the spaces [14:44:05] spaces after 5 and 25? [14:44:22] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Empty line in a comment should be interpreted as new paragraph - https://phabricator.wikimedia.org/T210237 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/4876626232868864/ [14:44:27] yes, or in other words, before "degrees" and "degrees" ;) [14:44:45] (and after `is`) [14:45:25] I am back! [14:45:38] shreyasminocha now? [14:45:42] rachit: how is your task? [14:45:55] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10Kaartic) @bmansurov Thanks for the info. It would be nice if you could add make requirements more specific in the task description :-) [14:45:59] and although it might not be necessary for this task, try being as exact with the instructions as possible rachit. there's just one teeny full stop at the end missing :) [14:46:16] hope you aren't annoyed by my obsessive corrections [14:46:34] hi takidelfin [14:46:38] hello! [14:46:47] ok i'll edit that as well.Thanks a lot shreyasminocha [14:47:00] (03PS1) 10Nathan fraignt: Add superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [14:47:06] takidelfin i am up a step now :) [14:47:11] you're welcome :) [14:47:13] :D [14:47:18] gj! [14:47:49] gotta go, see you later all! [14:47:52] (03CR) 10jerkins-bot: [V: 04-1] Add superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [14:47:58] bye Urbanecm [14:48:15] congrats rachit for completing this! [14:48:18] goodbye! [14:49:26] (03PS2) 10Nathan fraignt: Add superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [14:50:01] (03PS3) 10Nathan fraignt: Fix: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [14:50:07] urbanecm takidelfin shreyasminocha thank you for your help :) [14:50:19] np \o/ [14:50:53] rachit: i just guided you in the right direction, you discovered it all yourself [14:51:14] :) [14:51:24] Sad, literally submitted my task 3 minutes after Urbanecm left [14:51:40] rip, hah [14:52:38] (03CR) 10Rafidaslam: Fix: superusers, trusted users can always post comments (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [14:52:54] shreyasminocha i kind of need help again [14:53:07] go ahead [14:53:25] (although in general address your questions to everyone so that anyone who might know the answer can help) [14:53:26] so my step 7 says " In your module sandbox, amend the function to supply 0 as the default if no parameter is supplied. Save it." [14:53:43] yes [14:54:02] but where do i have to write 0 in the module sandbox? [14:54:23] okay. firstly, do you know who empty values are represented in lua? [14:54:24] (03CR) 10Nathan fraignt: "> Patch Set 3:" (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [14:54:44] shreyasminocha idk :( [14:55:21] okay. carefully read the first paragraph of "Tests", please? [14:55:53] actually, you need onnly the first few sentences [14:56:04] (03CR) 10Rafidaslam: "> I think I already deleted them, in patch set 2. (Although your comment says that you replied to patch set 3, can you confirm/deny this?)" [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [14:56:38] i dont understand it shreyasminocha [14:56:44] nil [14:56:47] (tip) [14:56:52] what do you not understand rachit? [14:57:00] specifically? [14:58:00] yeah, tell us. Maybe someone will be able to clarify it [14:59:15] i got the first few lines of that para [14:59:43] but still coudnt figure out how to use 'nil' to make my function supply 0 [14:59:48] okay [15:00:04] remember that error mesage you got some minutes back? when you were incorrectly passing parameters? [15:00:17] um ya [15:00:24] cannot add "nil" value to string [15:00:24] (03CR) 10Rafidaslam: Fix: superusers, trusted users can always post comments (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [15:00:43] yes [15:00:50] when a function is expecting a param and you don't pass one at all, it stores a nil in there [15:00:59] this is not a string that says "nil", mind you [15:01:21] but a different kind of value. like "null" from other languages if you're familiar with those [15:01:47] It is like a object [15:02:01] ~ nil [15:02:06] so you want to compare the value of the parameter to this nil thing [15:02:25] Note that a Scribunto function always returns a string (i.e. text) to the Wikipedia page where it is invoked and parameters passed to the module are always strings (or nil) [15:02:34] There is the solution for your problem :D [15:02:43] if the parameter is nil, that usually means that no parameter was passed [15:03:07] (or nil) [15:03:07] only in that case will you need to use a default value [15:03:32] yeah, hence the "usually" :) don't want to confuse them with details for now takidelfin [15:04:01] (my previous message is a solution :D) [15:04:04] okya [15:04:13] rachit: can you take it from here? [15:04:13] (03PS4) 10Nathan fraignt: Fix: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [15:04:37] (03CR) 10Nathan fraignt: "> Patch Set 3:" (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [15:04:41] idts [15:04:59] first, figure out if a parameter was passed at all [15:05:10] it wasnt [15:05:24] second, if no parameter was passed, change the value to the default value [15:05:38] what is the default value? [15:05:42] if a parameter was passed, let it be [15:05:49] rachit: 0, remember :) [15:06:00] "supply 0 as the default if no parameter is supplied" [15:06:33] and if parameter was supplied, you don't need to bother [15:06:40] if something is empty do something with something [15:06:59] else, don't bother (you won't need a separate else clause in this case) [15:07:01] do i need to write this {{#invoke:Sandbox/bleed.tech|Temperature|celsius=0}} ? [15:07:07] oh, no, no [15:07:14] uhh [15:07:16] you need to edit your code in module sandbox [15:07:21] it's fine, np [15:07:25] rachit: https://devhints.io/lua Maybe this cheatsheet will give you more understanding. It is a Lua syntax [15:07:51] so rachit, you need to edit your function in the module sandbox (like the instructions suggest) [15:07:56] don't touch the user sandbox for now [15:08:02] rachit: You need to set cel to 0 if "celsius=" argument is not passed [15:08:18] and the logic for that needs to be in your function itself [15:08:40] great site by the way https://devhints.io/ [15:08:54] takidelfin: i agree [15:09:07] whats a parameter in module sandbox? [15:09:11] a fast introduction to syntaxes of various things [15:09:15] * quick [15:09:24] rachit: wdym? [15:09:29] rachit: what do you mean? [15:09:43] you're getting the parameter as `frame.args.celsius` [15:09:43] (lol, I extended shreyasminocha message) [15:09:51] and storing it in `cel` [15:09:53] takidelfin: lol [15:10:14] so wdym by "if a parameter was passed?" [15:10:23] and if nothing is passed as a argument (celsius parameter), so it is a nil, you need to set celsius to 0 [15:10:34] if in user sandbox, i just to |Temperature [15:10:36] do* [15:10:48] without adding the `|celsius-9` at the end [15:10:57] that would mean that no parameter was passed [15:11:11] and like we said, when no parameter is passed, nil is stored [15:11:34] so since you're storing the value of the "parameter" in `cel`, if no parameter was passed, `cel` would be ... [15:11:34] nil - completly nothing [15:12:10] (completly nothing) [15:12:22] so it is ... [15:12:32] rachit: are you following? [15:12:47] ;-; [15:12:54] can you check my user sandbox once? [15:13:06] https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox#Task_3 [15:13:19] yes, so that's the line you'll want to add later [15:13:33] but you don't need to touch your user sandbox for now like i said [15:13:43] That error says that if no parameter was passed (argument) then it is a nil [15:13:52] and you can't perfrom math operations on nil [15:13:55] see, it says " attempt to perform ... a nil value" [15:13:57] because it isn't a number [15:14:04] i dont understand what am i supposed to do in module sandbox [15:14:11] okay. [15:14:20] let's go from the top [15:14:26] you need to perform a test [15:14:33] yes [15:14:37] checking if the `cel` variable is a `nil` [15:14:45] when you do `|celsius=4`, the value of `celsius` goes into `frame.args.celsius` [15:14:55] similarly with all "parameters" (as they are called) [15:14:59] Do you know how to check for equality in Lua? [15:15:18] no takidelfin [15:15:33] it is == [15:15:45] rachit: have you fully understood what the task wants you to do? [15:15:46] like this: 'me' == 'me' [15:15:47] true [15:15:53] but 'me' == 'you' [15:15:54] false [15:16:03] or numbers: 1 == 3 [15:16:04] false [15:16:04] 10MediaWiki-Installer: Installer seemingly using wrong db name and username - https://phabricator.wikimedia.org/T123819 (10Seb35) Well, without more information I’m tempted to close as invalid. At first sight I would say a " GRANT ALL PRIVILEGES ON my_wiki.* TO wikiuser@localhost; " was forgotten, and I guess @d... [15:16:13] but 3 == 3 [15:16:14] true [15:16:27] so if myVariable = nil [15:16:32] then ... [15:16:41] assign a myVariable to a default value [15:17:00] shreyasminocha i have understood what the task wants but cant figure what am i supposed to do in the module sandbox [15:17:22] alright. you understand that the value of the param gets stored in `cel`, right? [15:17:31] rachit: Could you read what I said above? Maybe it will help you :D [15:17:54] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech please check it once [15:18:02] oh [15:18:04] you are closer [15:18:13] but, you need to add a *test* [15:18:23] *test* is writed using `if` [15:18:28] if something [15:18:38] (missclicked enter) [15:18:48] if something == true then [15:18:57] something = 'It works' [15:18:58] end [15:19:25] i dont understand.. [15:19:31] okay, let me try [15:19:38] you understand that the value of the param [15:19:40] gets stored in `cel` [15:19:42] ? [15:19:49] yes [15:20:10] and you understand that if no value is given to `celsius` from your user sandbox, `cel` will have `nil` [15:20:13] and `cel` is a faiaable [15:20:13] ? [15:20:16] *variable [15:20:22] yes' [15:20:26] alright [15:20:33] now what you wanted to do is: [15:20:45] if cel is empty (aka nil), [15:20:56] use a different value instead of cel [15:21:09] myVariable? [15:21:10] (you could do this by setting cel to the different value, for example) [15:21:15] myVariable is a variable [15:21:19] cel is a variable too [15:21:20] myvaribable was just an exmaple [15:21:35] but your variable that you should use is cel [15:21:37] are you following so far rachit? [15:21:41] because you store celsius value here [15:22:06] if cel is empty (because no value was given to it in your user sandbox), [15:22:23] use a different value. one way of doing this is setting cel to the different value [15:22:25] how do i set a different value of cel [15:22:29] then set cel to 0 [15:22:32] cel = [15:22:36] yeah [15:22:49] but you'll need to use an if statement to check the condition [15:22:50] declaring a variable is also setting it to a value [15:22:59] "Lua uses the if then else end structure to pick one of two outcomes depending on whether the test turns out true or false." [15:23:14] you'll need to use a similar if statement to check if cel is empty [15:23:22] making sense? [15:23:40] um [15:23:44] and instead of you'll set cel to the default value (0) [15:23:48] tbh not really [15:23:58] okay [15:24:17] when we discuss, we say "if don't buy" [15:24:22] "else " [15:24:28] (lame analogy, but works i guess) [15:24:49] with lua, you can do a similar thing, but you have to follow lua's prescribed format for if statements [15:25:00] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 1 - https://phabricator.wikimedia.org/T210236 (10Krishna_Chaitanya_Velaga) a:03ManavpreetKaur [15:25:00] if [15:25:05] if then else end [15:25:09] yeah [15:25:14] so [15:25:16] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 1 - https://phabricator.wikimedia.org/T210236 (10Krishna_Chaitanya_Velaga) [15:25:17] if then [15:25:21] where do i use it and how [15:25:23] [15:25:26] else [15:25:32] [15:25:33] end [15:25:42] yes, so after you store the value of the param in cel, [15:25:49] you want to check if cel is empty [15:25:58] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 2 - https://phabricator.wikimedia.org/T210238 (10Krishna_Chaitanya_Velaga) a:03Shypoetess [15:26:00] using an if statement [15:26:08] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 1 - https://phabricator.wikimedia.org/T210236 (10Krishna_Chaitanya_Velaga) [15:26:18] and if it is, you'll change it's value to the default value you want to use [15:26:26] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 2 - https://phabricator.wikimedia.org/T210238 (10Krishna_Chaitanya_Velaga) p:05Triage>03High [15:26:30] otherwise, you don't need to do anything [15:26:32] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 2 - https://phabricator.wikimedia.org/T210238 (10Krishna_Chaitanya_Velaga) p:05High>03Triage [15:26:41] rachit: following me? [15:26:45] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 2 - https://phabricator.wikimedia.org/T210238 (10Krishna_Chaitanya_Velaga) [15:26:51] if then else <0> end [15:26:59] ... :( [15:27:04] not quite. don't be sad. [15:27:11] if then [15:27:13] :) [15:27:19] [15:27:22] else [15:27:27] [15:27:28] end [15:27:29] 10TWLCon-2019-India: Add topics from participants to the program - https://phabricator.wikimedia.org/T210255 (10Krishna_Chaitanya_Velaga) a:05ManavpreetKaur>03Krishna_Chaitanya_Velaga [15:27:38] 10TWLCon-2019-India: Survey from participants - https://phabricator.wikimedia.org/T210254 (10Krishna_Chaitanya_Velaga) a:05ManavpreetKaur>03Krishna_Chaitanya_Velaga [15:27:43] (later we'll see that the else can be omitted, ,but don't bother withi that for now) [15:27:49] 10TWLCon-2019-India: Survey from participants - https://phabricator.wikimedia.org/T210254 (10Krishna_Chaitanya_Velaga) a:05Krishna_Chaitanya_Velaga>03ManavpreetKaur [15:27:56] rachit: following? [15:28:14] 10TWLCon-2019-India: Finalise a draft of program - https://phabricator.wikimedia.org/T210253 (10Krishna_Chaitanya_Velaga) a:05ManavpreetKaur>03Krishna_Chaitanya_Velaga [15:28:36] 10TWLCon-2019-India: Finalise and Publish on Meta-Wiki - https://phabricator.wikimedia.org/T210256 (10Krishna_Chaitanya_Velaga) a:05ManavpreetKaur>03Shypoetess [15:28:43] have you understood what i said at least (even if not how to do the individual steps)? [15:29:10] if then else [15:29:16] yes [15:29:24] when i write this it shows an error [15:29:28] now how would you check for [15:29:37] that was just pseudocode :) [15:29:57] you'll have to fill in the stuff between < and > [15:30:07] oh ohk [15:30:19] so how would you check for ? [15:30:20] would i check for [15:30:36] you know that if no param is passed, the variable stores `nil` [15:30:49] and takidelfin told you how equality is tested for [15:30:50] 10MediaWiki-User-preferences, 10UI-Standardization: Special:Preferences: For JS-requiring features, re-use the styling that Beta Features invented and show a red warning but only to non-JS users - https://phabricator.wikimedia.org/T194531 (10Kaartic) Some thoughts, >>! In T194531#4759527, @Volker_E wrote: > F... [15:30:57] yes [15:31:14] so if you want to check if cel is nil, how would you do that? [15:31:25] nil==0 ? [15:31:33] umm, no [15:31:36] cell ==0 ? [15:31:46] misconception alert [15:31:53] `nil` is different from 0 [15:31:53] 10TWLCon-2019-India: Travel Arrangements: by CIS-A2K - https://phabricator.wikimedia.org/T210250 (10Krishna_Chaitanya_Velaga) a:03ManavpreetKaur [15:32:05] 10TWLCon-2019-India: Survey from participants - https://phabricator.wikimedia.org/T210254 (10Krishna_Chaitanya_Velaga) a:05ManavpreetKaur>03Shypoetess [15:32:07] then? [15:32:15] 10TWLCon-2019-India: Venue Booking - https://phabricator.wikimedia.org/T210251 (10Krishna_Chaitanya_Velaga) a:03Krishna_Chaitanya_Velaga [15:32:16] `nil` is a whole different thing. when we say `nil`, we mean "EMPTY value" [15:32:21] 10TWLCon-2019-India: Accommodation Booking - https://phabricator.wikimedia.org/T210252 (10Krishna_Chaitanya_Velaga) a:03Krishna_Chaitanya_Velaga [15:32:25] okay [15:32:28] because lua calls empty things nil [15:32:33] so how would you compare? [15:32:52] cell==nil? [15:33:05] yes! (except it's `cel` and not `cell`) [15:33:20] lol yeah [15:33:21] so: [15:33:26] if cel == nil then [15:33:33] [15:33:35] else [15:33:40] [15:33:41] end [15:33:48] ohh [15:33:50] how would you do ? [15:34:20] cel= 0? [15:34:23] perfect [15:34:44] if cel == nil then [15:34:45] cel = 0 [15:34:45] else [15:34:45] [15:34:45] end [15:34:45] and what about do nothing at all? [15:34:58] ohh [15:35:01] got it [15:35:04] let me try [15:35:09] sure [15:36:13] there is some error [15:36:34] i don't think you edited your module sandbox [15:36:35] did you? [15:37:01] i did [15:37:18] save it once? [15:37:21] i can't see your changes [15:37:58] (03CR) 10Jason Linehan: "> Apologies if I misunderstand, but I suspect there may be a problem here." [core] - 10https://gerrit.wikimedia.org/r/474726 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [15:38:22] shreyasminocha it isnt saving bcz of the error ig [15:38:59] can you copy-paste the code to paste.ee and share the link? [15:39:20] if then else end [15:39:34] get rid of the < and > [15:39:56] and you'll still get an error, but don't be frightened [15:39:56] oh poor me [15:40:05] it's fine [15:40:30] also, i suggest you start with a different programming language too, say python [15:40:48] because lua is obscure (and weird?) [15:40:54] if cel==nil then cel=0 else do nothing at all end [15:40:59] still some error [15:41:01] but once you know another language, pikcing up lua will be effortless [15:41:05] or to https://hastebin.com/ [15:41:14] yes. now get rid of "do nothing at all" [15:41:37] you can also do it if cel == nil then cel = 0 end [15:41:44] does it work rachit? [15:41:50] i think so [15:41:53] or: The best thing [15:41:56] can you please check [15:41:56] takidelfin: yea, was going to tell them in the end [15:42:09] cel = frame.args.celsius or 0 [15:42:12] rachit: you're adding the if statement in the wrong place [15:42:31] ^ -- this above is a shorthand for if cel == nil then cel = 0 end [15:42:32] takidelfin: i'd say let's try to explain the concept in the most basic way first [15:42:33] where is it supposed to be > [15:42:51] rachit: you want to perform the check after you set cel and before you use cel's value [15:42:55] shreyasminocha: yeah, sorry [15:43:02] np [15:43:02] I will be back [15:43:07] see you soon! [15:43:08] soontm [15:43:14] (like 4 hours [15:43:17] goodbye! [15:43:21] i'll be awake :) [15:43:23] so long! [15:43:47] i think i got it [15:43:50] can you check it [15:43:53] yay! [15:44:08] now you can get rid of the `else end` part [15:44:08] thank youuu :) [15:44:14] np :) [15:44:35] another important thing is that when there are no statements in an `else` clause, you can get rid of it altogether [15:44:47] but when there are statements, you'll put them between `else` and `end` [15:45:25] and if there's more than just one statement in the `if` part or the `else` part, you'll want to write your `if` and `else` over multiple lines [15:45:27] okay :) [15:46:10] (yeah, i mistyped by saying remove `else end`, you had to remove only `else`, but you figured that out yourself!) [15:46:31] awesome! programming is rewarding when it works, isn't it? :) [15:47:52] sure it is :) [15:48:31] Hello Snowstorm! [15:48:39] hello [15:48:45] hi Ebe123 and Snowstorm! [15:49:16] is this like discord [15:49:22] but no call [15:49:22] yeah! [15:49:34] you sure seem active [15:49:45] fundamentally the same. haha, yeah [15:49:48] k, now i got last for an hour [15:50:06] shreyasminocha: another step says " Make changes to the function temperature to store the text that you are returning in a variable called msg. Then return msg as the last line before the end of the function. Save it and check in your user sandbox that it is still working (refresh the page or preview an edit)." [15:50:09] 10MediaWiki-Installer, 10Composer: Improve the web installer's error page for missing dependencies - https://phabricator.wikimedia.org/T108097 (10Seb35) **I like it!** I was wondering: * if it should be translated, but it would be too complicated, and if people use Git they probably speak some basic English,... [15:50:19] rachit: yes, what about it [15:50:38] what does it mean by "the text that you are returning" [15:50:58] everything after the keyword `return` [15:51:38] rachit: please take me up on my suggestion to learn python (or some other popular language) simultaneously though. it'll really help you [15:51:55] should i learn javascript/ [15:51:58] ? [15:52:11] if you want to [15:52:19] it's an option, although it's very lenient so i wouldn't recommend it [15:52:19] python is easier in my opinion [15:52:33] if you know html, css then go for javascript though [15:52:53] yea ik html css coz i am into webdev [15:53:02] nice. [15:53:15] (btw you might be surprised to know that javascript can be run outside the browser too) [15:53:45] Snowstorm, leading question: Are you a GCI student? (You are required to state that for the IRC task) [15:54:09] i figured they are, but rules are rules :D [15:54:13] shreyasminocha, am i supposed to do this ? msg=return cel.." degress Celsius is "..fah.." degrees Fahrenheit." return msg [15:54:32] yeah, pretty much [15:54:44] but its showing an error [15:54:55] what does it say? [15:55:09] Eber123, is CGI those tasks thing [15:55:14] 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions: Testing AbuseFilter on StructuredDiscussions edits is not possible - https://phabricator.wikimedia.org/T210324 (10Wargo) [15:55:20] yes; Google Code-in [15:55:30] I am in Google Code in [15:55:50] I am a CGI student [15:55:53] shreyasminocha,Error: [19:5] expected near 'return' [15:56:00] I am a GCI student [15:56:14] does my hour start now? [15:56:23] rachit: could you please copy-paste your Temperature function here or in a paste website? [15:56:27] Snowstorm: it does! [15:56:35] oh yay [15:56:43] p.Temperature = function(frame) cel = frame.args.celsius if cel==nil then cel=0 end fah = cel*9/5+32 msg=return cel.." degress Celsius is "..fah.." degrees Fahrenheit." return msg end [15:56:44] so [15:56:50] you all have timers [15:56:55] ? [15:57:11] rachit: whoops [15:57:25] msg is not supposed to equal `return cel.. and the rest` [15:57:33] return is a statement in itself [15:57:36] then? [15:57:45] you can't set something equal to a return statement :) [15:57:56] are you all doing those definition functions [15:58:02] rachit: i said "everything after return" [15:58:03] then what should i do? [15:58:15] rachit: set msg to "everything after return" :) [15:58:19] Snowstorm: yeah [15:58:25] this is lua though, not python [15:58:36] No, there are timestamps on each message on IRC, so we'll just find that comment when you say that your hour is up to check, Snowstorm [15:58:37] mediawiki uses lua for embedded code [15:58:44] I hate those in python [15:58:47] I see [15:58:55] Snowstorm: they're really useful though :D [15:59:28] 10MediaWiki-API, 10Core Platform Team, 10Multi-Content-Revisions, 10Regression: Forcelinkupdate appears to have stopped working (on ENWIKI at least) - https://phabricator.wikimedia.org/T210307 (10daniel) p:05Triage>03High Analysis: * RefreshLinksJob is hitting the ( $page->getLinksTimestamp() > $skewe... [15:59:32] shreyasminocha, return msg=cel.." degress Celsius is "..fah.." degrees Fahrenheit." return msg [15:59:41] nah [15:59:50] I know it shortens the code by 10 folds but in my head when I try to convert it into pseudocode, it doesn't make sense [15:59:51] don't `return msg=...` [16:00:02] then? [16:00:09] see, `return` begins a statement [16:00:20] `x = y` is also a statement [16:00:34] what follows return must be an expression [16:00:56] (that is, it must be something that is, after being calculated, a value) [16:01:08] so you want to do `msg = cel .. ` [16:01:16] followed by `return msg` [16:01:35] did you understand *why* your current code isn't working? [16:02:13] yes i did [16:02:22] you can have only one statement on a line. you can't write a statement where an expression is expected (that's what you did both times you got it wrong) [16:02:25] great. [16:02:36] so erm, does anyone here like Pokemon? [16:02:36] hope it works now [16:02:58] (03PS1) 10Daniel Kinzler: Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) [16:03:19] Snowstorm: i find it funny how you know it's an awkward question ("erm") [16:03:34] but no, i was never quite into pokémon [16:03:52] yes, I know it is an awkward question [16:03:59] not getting it right [16:04:09] rachit: what does it say? [16:04:12] Snowstorm: :) [16:04:43] i need to add msg after return but before cel right? [16:04:55] nothing after return [16:05:34] what return does (unless it's inside an if condition), is that it causes the function to say "i'm done here. give this value back to whoever asked for it." [16:05:37] I thought Pokemon is a hit [16:05:47] and then whoever asked for it does whatever they want to do with it [16:05:55] Snowstorm: yeah, it's quite popular [16:06:03] 10MediaWiki-Installer: Installer seemingly using wrong db name and username - https://phabricator.wikimedia.org/T123819 (10daniel) @Seb35 missing privileges shoudl still show the correct credentials in the error, which it did not. But yea, close it, it was probably fixed since then :) [16:06:21] among the age group it is popular in [16:06:33] dont you mean : return msg cel.." degress Celsius is "..fah.." degrees Fahrenheit." return msg [16:06:49] don't `return` twice [16:06:55] first, set the value of msg [16:07:06] with `msg = ` [16:07:12] then return it [16:07:59] when you try to reach the word count [16:08:22] shreyasminocha got it thanks [16:08:25] Snowstorm: most people out here are adults, that's why it's an awkward question. would've probably been fine to ask within a group of just kids your (our? idk) age. [16:08:30] rachit: good job [16:08:42] good job [16:08:58] out of curiosity whats your age shreyasminocha [16:09:01] u above<20? [16:09:11] seventeen years and three days [16:09:24] happy belated birthday [16:09:31] oh happy belated birthday ;) [16:09:33] thanks :D [16:09:42] i'm a gci participant too, btw [16:09:52] erm, Internet high five [16:10:02] you are there on the leaderboard :) [16:10:10] * shreyasminocha "internet high five's" back [16:10:30] rachit: yeah, i'm doing fine in terms of tasks done [16:10:47] how many have you done? [16:10:54] I don't I will be on the leaderboard, since I started yesterday [16:10:58] i'm at 21 + one waiting for review [16:11:14] oh great! [16:11:21] I think I will stop after 3 [16:11:23] Snowstorm: it's fine honestly, you probably have more years to try. more importantly, have fun and learn. i'm doing the same [16:11:38] Snowstorm: do as many as time permits you to do [16:11:42] wait, isn't this your last year? [16:11:56] it depends on when gci starts next year [16:12:08] if it starts before my bday, lucky me [16:12:11] shreyasminocha do you know something about tonumber [16:12:12] Then its on to gsoc! [16:12:20] yeah! [16:12:24] yeah about that, I kept delaying all my homework so yeah [16:12:27] rachit: yeah, i can try [16:12:38] Snowstorm: :D [16:12:51] try to balance though :) [16:13:09] I mean this is my 3rd tasks [16:13:13] task [16:13:18] so I will stop and grind [16:13:19] aha [16:13:32] all the best and hope to see you around here more often [16:13:43] will you be around here [16:13:44] (but focus on your hw ofc) [16:13:51] i'm around here quite a bit [16:14:02] so probably [16:14:33] shreyasminocha: the step says"Change function temperature to explicitly convert the variable cel to a number. You'll need the tonumber() function built in to Lua. Save it and check. [16:14:57] alright, yes. [16:15:47] (03CR) 10jerkins-bot: [V: 04-1] Fix the cache timestamp for forced updates. [core] - 10https://gerrit.wikimedia.org/r/475593 (https://phabricator.wikimedia.org/T210307) (owner: 10Daniel Kinzler) [16:15:47] so how do i do it? [16:16:31] hi pterp [16:16:39] Where's the git repo for the GoogleNewsSitemap extension? [16:16:39] rachit: one sec [16:17:17] https://www.lua.org/manual/5.1/manual.html#pdf-tonumber [16:17:20] rachit: & [16:17:22] ^ [16:17:44] and erm, does anyone like anime [16:18:00] i know a friend who does :D [16:18:10] rachit: lmk once you're done reading that [16:18:23] keep in mind, you don't have to bother about the `base` argument [16:18:46] I take that as a no [16:18:54] heheh [16:18:57] Hello? [16:19:02] hi pterp [16:19:08] not sure where you'll find the repo [16:19:17] ok so what am i supposed to do [16:19:22] Hello pterp [16:19:33] Hi! Can you help? [16:19:53] rachit: after your if statement, set cel to the converted value (by calling the function and passing cel as a param) [16:20:07] pterp: i'm trying to look for the repo [16:20:15] Ok. [16:20:38] pterp: the github mirror is at https://github.com/wikimedia/mediawiki-extensions-GoogleNewsSitemap [16:21:04] and the gerrit repo is at https://gerrit.wikimedia.org/g/mediawiki/extensions/GoogleNewsSitemap [16:21:28] searching on mediawiki for extension will usually take you to their page [16:21:44] here's the page for geooglenewssitemap for example: https://www.mediawiki.org/wiki/Extension:GoogleNewsSitemap [16:21:46] 10MediaWiki-Installer: Installer environmental checks don't update when reloading page - https://phabricator.wikimedia.org/T50083 (10Seb35) Tested on MW 1.33-alpha by removing all my database drivers (php7.0-mysql and php7.0-sqlite3). This task was solved in the meantime for the MediaWiki part: when you reload... [16:22:23] shreyasminocha: do i need to do cel=tonumber? [16:22:37] tonumber is not a variable, it's a function [16:22:47] you want to call that function [16:23:03] one sec, let me try setting up a demo for you [16:23:09] ok [16:23:43] Also, I've claimed this task:https://codein.withgoogle.com/dashboard/task-instances/4636267967938560/ It ony says to check one file,and it ony has one reference to the function I need to change. It that really it? [16:24:06] *Is [16:24:58] rachit: btw did you install the lua interpreter on your system? [16:26:07] wait, I assume the 1 hour online means I can be afk [16:26:16] you can, yes [16:26:55] yes, Time to watch the Good Doctor, New Amsterdam, Supernatural S14 and Walking Dead [16:27:22] Hello? [16:27:37] hi pterp. i'm not sure. [16:27:53] shreyasminocha i did install lua interpreter [16:28:02] great [16:28:06] run the interpreter [16:29:23] rachit: done? [16:29:30] wait [16:30:40] (03PS1) 10Pjht: Change getTalkPage() to getTalkPageIfDefined() [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/475594 [16:31:15] fine. go through the code at https://paste.ee/p/QVQk5. once your interprer is open, paste this code into it and see the output. [16:31:29] i wanted to link you to a repl.it, but it ain't working for some reason [16:32:32] lmk if there's something unclear in the code at https://paste.ee/p/QVQk5 [16:33:14] shreyasminocha, i have lua interpreter downloaded but how to install it? i have extracted the zip file [16:33:52] umm... i'm not sure. i installed it with homebrew, but that might not be available on your os or you might now have it installed. [16:33:56] let it be [16:34:23] ok should i use lua interpreter online? [16:34:30] https://www.lua.org/demo.html [16:34:33] yes [16:35:12] Brooklyn 9-9? [16:35:15] anyone? [16:35:30] i've heard some very good things about it [16:35:38] but haven't had the time to watch yet [16:35:42] 10MediaWiki-Installer, 10I18n: cli installer ignores lang parameter - https://phabricator.wikimedia.org/T63146 (10Seb35) [16:35:47] awww [16:35:54] 10MediaWiki-Installer, 10I18n: cli installer ignores lang parameter - https://phabricator.wikimedia.org/T63146 (10Seb35) Still an issue on MediaWiki 1.33-alpha, although I rewrote a bit the description because indeed the CLI installer does not set $wgLanguageCode in the generated LocalSettings.php, but the par... [16:36:05] we have no tv interest in common [16:36:25] mr robot? [16:36:37] shreyasminocha, https://paste.ee/p/QVQk5 couldnt understand anything :( [16:37:12] rachit: first line: we're simply calling the tonumber function on a number itself and we're not doing anything with the value we get back [16:37:27] second line, is obvious [16:37:32] nope [16:37:46] looks amazing [16:37:50] third line, we're converted x (already a number) to a number and storing it in y [16:37:58] Snowstorm: yeah, the first season is especially good [16:38:06] fourth line, we're printing the value of y [16:38:16] 1st seasons are always good [16:38:17] fifth line, this time, 44 is a string rather than a number [16:38:23] Snowstorm: totally agree [16:38:37] fifth line, but '44' can be converted to a number [16:38:51] sixth line, we try adding a number to z [16:38:52] Law and Order? [16:39:00] Modern Family? [16:39:03] Snowstorm: i'm so sorry to disappoint [16:39:05] modern family! [16:39:11] yes [16:39:11] alas, we have found our intersection [16:39:25] I got super desperate [16:39:27] rachit: but lua is smart enought o auto convert '44' to a number [16:39:33] Snowstorm: heheh [16:39:36] (03PS5) 10Pjht: Add namespace to action=info page [core] - 10https://gerrit.wikimedia.org/r/475333 (https://phabricator.wikimedia.org/T123228) [16:39:56] shreyasminocha how to inculcate it in my module sandbox? [16:40:09] rachit: (although it converts it to a decimal number rather than an integer. this is called implicit typecasting btw because it implicity converts string to int [16:40:16] Supernatural? [16:40:21] the step says "Change function temperature to explicitly convert the variable cel to a number. You'll need the tonumber() function built in to Lua. Save it and check." [16:40:25] line 7, this time we explicitly convert z to a number, add one, print [16:40:45] Snowstorm: the more you ask, the more i feel like a disappointment, so let's stop :D [16:40:51] ok [16:41:09] Netflix? [16:41:29] rachit: use the tonumber function in one of the ways i showed in the paste there rachit, passing cel as a parameter [16:41:41] store the value that tonumber returns back into cel [16:41:51] Snowstorm: *sigh* prime video [16:42:18] 10Wikimedia-Site-requests: Add the extension "SandboxLink" for nowiki - https://phabricator.wikimedia.org/T210325 (10jeblad) [16:42:18] shreyasminocha: how?/ [16:42:31] * shreyasminocha is embarassed. he feels out of place among his friends that watch a lot of tv too. [16:42:48] rachit: you can use tonumber(cel) to convert cel to a number [16:43:01] what other shows you watch [16:43:24] tonumber(cel) will "evavluate" to a value. you can directly store that value into `cel` like i showed in line 8 of what i sent you rachit [16:44:18] Snowstorm: young sheldon, mr robot, black mirror. that's all i've watched in terms of american/british tv :| i have a long list of shows to watch though *sigh* [16:44:39] young sheldon and black mirror!!! [16:45:03] * shreyasminocha internet high fives Snowstorm! [16:45:20] *high fives back* [16:45:36] shreyasminocha internet high fives Snowstorm! [16:45:43] how do you do that [16:45:53] begin what you want to say with "/me" [16:46:02] /me is trying to use /me [16:46:04] 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions: Testing AbuseFilter on StructuredDiscussions edits is not possible - https://phabricator.wikimedia.org/T210324 (10Daimona) [16:46:10] except without the leading space [16:46:35] * Snowstorm screams with joy [16:46:35] shreyasminocha can you check if i have done it right/ [16:46:38] https://en.wikipedia.org/wiki/Module:Sandbox/bleed.tech [16:47:19] rachit: no. do it the way i did it in line 8 of what i sent you [16:47:40] z = tonumber(z) [16:47:50] yeah, similar [16:48:03] (except you wouldn't convert z, duh) [16:48:20] whoops, looks like you tried to convert z [16:48:37] ... :( [16:49:04] i'm trying to make you more independent, that's why i'm not giving you the code itself, but encouraging you to experiment, read the docs, figure things out yourself (given clues), etc [16:49:15] what about now? [16:49:34] don't use `z`, convert what we're trying to convert `cel` and store it into what we want to store it in `cel` again [16:49:47] ya i did that [16:49:48] ig [16:50:06] works! [16:50:15] you're ready to move to the next step [16:50:26] okay thank you :) [16:51:03] for step 11, you'll use another if-else statement [16:51:32] and you'll put it between the `msg = ` line and the return statement ofc [16:53:11] has anyone ever felt like I am going to watch later, records the show, bombarded with hw and life and forgot about it [16:53:19] 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, 10Wikimedia-production-error: Testing AbuseFilter on StructuredDiscussions edits is not possible - https://phabricator.wikimedia.org/T210324 (10Daimona) There isn't any other internal problem, aside from Flow edits not being testable, AFAIK. The capabi... [16:53:25] Snowstorm: relatable [16:54:36] Snowstorm: looks like your nick has already been registered by someone else [16:54:36] same [16:54:47] you'll have to use a different nick and register it [16:54:54] for the "get onto irc task" [16:56:20] Snowstorm: switch nicks and follow the instructions at https://freenode.net/kb/answer/registration [16:57:18] will i HAVE TO RESTART? [16:57:35] probably not [16:57:58] I can't change [16:58:11] use /nick [16:58:43] Erroneous nickname [16:58:56] replace with whatever nick you want [16:59:04] example: /nick exampleNick [17:00:37] rachit: how's it going? [17:01:22] I can't change [17:03:05] helo shreyasminocha [17:03:08] help [17:04:28] yo [17:04:48] I can't change while banned/quieted on channel [17:05:36] weird [17:05:52] shreyasminocha [17:05:52] do I need to disconnect/ [17:05:56] ? [17:05:57] i need a help [17:06:06] Snowstorm: not sure. [17:06:21] can anyone else help Snowstorm with his irc problem? [17:06:24] rachit: yes [17:06:27] msg=cel.." degress Celsius is "..fah.." degrees Fahrenheit."if cel>9 then add It is warm. else add It is cold. end return msg [17:06:44] is this what m supposed to do? [17:06:51] no rachit [17:07:07] then? [17:07:17] looks like you've literally copied the instructions :) [17:07:32] um lol [17:07:44] the instructions want you to add " It is warm." or " It is cold." to msg [17:07:53] depending on whether cel is > 9 ofc [17:08:28] so if cel>9 [17:08:30] you can use the .. operator to concatenate (here =add), as you remember [17:08:33] yes, go on [17:08:49] then .. [17:08:57] "it is warm." [17:09:22] you're doing .. "It is warm." but lua can't know what you want to add "it is warm" to [17:09:50] unless you tell it [17:09:53] so how do i do it? [17:10:18] what do you want to add "it is warm" to? [17:10:29] do you know? [17:10:31] the msg right [17:10:37] yep [17:11:09] * shreyasminocha is sad snowstorm left that way [17:11:34] (03PS1) 10John Erling Blad: SandboxLink: Remove explicit state [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/475596 [17:11:34] * shreyasminocha ...and the he couldn't help snowstorm [17:11:48] how do i add to msg? [17:12:07] .."add blah to msg" [17:12:08] ? [17:12:18] read step 11 [17:12:25] the last part [17:12:33] " - you'll need the ..." [17:13:14] so do i need to write a new msg variable? [17:13:28] no, [17:13:34] in lua you can first set x = 4 [17:13:42] then you can later be like `x = 5` [17:13:51] and later `x = 'yee'` [17:13:58] so you're just changing the value in msg [17:14:25] i dont have to write any of xyz code right? [17:14:35] correcy [17:16:13] 10CommRel-Specialists-Support, 10Research, 10Tech-Ambassadors: Help mapping synonyms - https://phabricator.wikimedia.org/T210085 (10bmansurov) [17:16:32] shreyasminocha something like this msg=cel>9.."add it is hot"" degress Celsius is "..fah.." degrees Fahrenheit." end return msg? [17:16:51] you were closer last time [17:17:02] uh [17:17:05] undo to your previous situation [17:17:12] if cel > 9 then [17:17:21] msg = msg .. [17:17:23] else [17:17:33] msg = msg .. [17:17:34] (03CR) 10John Erling Blad: "Matma is listed as author of the extension, so should probably be invited to review this." [extensions/SandboxLink] - 10https://gerrit.wikimedia.org/r/475596 (owner: 10John Erling Blad) [17:17:36] end [17:17:43] screw you wikibugs [17:17:47] lol [17:18:29] ok let me try [17:20:10] 10Wikimedia-Site-requests: Add the extension "SandboxLink" for nowiki - https://phabricator.wikimedia.org/T210325 (10jeblad) [17:20:24] there is some error shreyasminocha [17:20:33] what's the error [17:20:55] Error: [25:0] 'end' expected near '' [17:21:00] very unusual error [17:21:09] paste your method? [17:21:10] msg=cel.." degress Celsius is "..fah.." degrees Fahrenheit." if cel>9 then msg=msg.."It is warm." else msg=msg.."It is cold." return msg [17:21:19] is this correct [17:21:25] hi [17:21:29] hi WeatherStorm [17:21:34] its me [17:21:38] i'm glad you're back [17:21:39] Hello weatherStorm [17:21:40] SnowStorm [17:21:43] hi WeatherStorm [17:21:50] hi [17:21:55] hi TheJair, Krenair [17:22:03] sup [17:22:13] helping rachit with lua #3 [17:22:23] Hey shreyasminocha, Krenair and rachit [17:22:24] lol [17:22:33] msg=cel.." degress Celsius is "..fah.." degrees Fahrenheit." if cel>9 then msg=msg.."It is warm." else msg=msg.."It is cold." return msg [17:22:37] is it correct [17:22:39] rachit: you aren't doing end [17:22:45] as the error message suggests [17:22:55] before return, you want to `end` the if-block [17:22:57] hi [17:23:04] p.Temperature = function(frame) cel = frame.args.celsius if cel==nil then cel=0 end cel = tonumber(cel) fah = cel*9/5+32 msg=cel.." degress Celsius is "..fah.." degrees Fahrenheit." if cel>9 then msg=msg.."It is warm." else msg=msg.."It is cold." return msg end return p [17:23:09] rachit: wikibugs broke my message [17:23:26] ah, no. this way you're `end`ing after you return msg [17:23:47] you don't want to return only when cel <= 9, do you :) [17:23:58] rn, return is within your else block [17:24:04] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10Epic: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349 (10Seb35) [17:24:06] 10MediaWiki-Installer: Include math extension again in default extensions of MediaWiki tarball - https://phabricator.wikimedia.org/T63415 (10Seb35) [17:24:13] got it shreyasminocha [17:24:28] i am good to go to the next step [17:24:30] thanks [17:24:39] :') [17:24:41] sure thing [17:24:48] HI [17:24:53] HI [17:25:03] 10Wikidocumentaries: Define the creation of new accounts - https://phabricator.wikimedia.org/T197969 (10Susannaanas) [17:25:11] Why does my name have a star [17:25:18] does it? idk [17:25:37] maybe only you can see it because your client uses a star to denote that it's you [17:25:46] oh [17:25:56] just a guess [17:26:06] hi shreyasminocha, its me snowstorm from before [17:26:27] i noticed, i said "glad to have you back" :) [17:26:42] (or sth similarlY) [17:26:49] I am a CGI student [17:27:01] gci* [17:27:10] I am a GCI student [17:27:15] lol [17:27:21] Hi WeatherStorm [17:27:25] do I have to start the hour again? [17:27:28] Hi rachit [17:27:33] i hope not WeatherStorm [17:27:48] but you can remain afk, we won't mind :) [17:27:54] :) [17:27:55] that is, in case you have to [17:29:31] d3r1ck: hi! will WeatherStorm have to start his hour again? [17:29:37] No [17:29:48] nice. sorry for the ping d3r1ck. [17:29:50] ok [17:29:54] thanks [17:29:56] bye bye guys i'm gonna go afk for some time [17:30:03] cool. bye! [17:30:10] cya [17:30:10] Bye! [17:30:11] glad you managed to complete the task [17:30:16] bye [17:30:33] thanks to you shreyasminocha :)) [17:30:35] Can someone accept my task review [17:30:46] rachit: ;) [17:30:58] WeatherStorm: have you submitted it on gci? [17:31:03] yes [17:31:26] someone will review it soon. although the official time for mentors to review is 36 hours, they're usually much faster than that [17:31:56] 10MediaWiki-Installer: Include math extension again in default extensions of MediaWiki tarball - https://phabricator.wikimedia.org/T63415 (10Seb35) I have the same opinion as @Legoktm here: the extension Math requires some external config and it needs specific actions from the sysadmin. Also I’m not completely s... [17:31:59] I did it [17:32:03] a gentle ping on irc is fine, but keep in mind that they get email notifs for "task submitted for review" [17:32:19] ok [17:32:30] I did it [17:32:34] all 3 tasks [17:32:37] now [17:32:40] great [17:32:44] back to real life [17:32:50] homework [17:32:51] pick up more perhaps! or back to real life [17:33:02] balance :) [17:33:11] I can't [17:33:14] some hw, some tasks [17:33:15] its a lot of hw [17:33:16] why so? [17:33:24] Exams soon [17:33:36] well, as time permits. yeah, if exams soon, then focus on those [17:33:42] ok [17:33:46] couldn't participate last year vide exams [17:33:54] I will gone for a while [17:33:56] bye [17:33:59] see ya [17:34:02] bye [17:34:37] let me get back to "real life" too for some time :D [17:35:15] cya than [17:35:16] 10MediaWiki-Installer: Please enable ParserFunctions by default - https://phabricator.wikimedia.org/T46429 (10Seb35) See also T55983 [17:35:20] so long [17:45:00] 10MediaWiki-Page-editing: Append additional summaries to the present one - https://phabricator.wikimedia.org/T210327 (10jeblad) [18:01:01] 10Google-Code-in-2018, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Technical-Debt, 10goodfirstbug: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10LukBukkit) a:03LukBukkit [18:19:07] (03CR) 10Jason Linehan: "Okay, I see what is going on. I take back what I said earlier about the hypothetical TitleCache fix being a no-op -- that's not the case. " [core] - 10https://gerrit.wikimedia.org/r/474726 (https://phabricator.wikimedia.org/T206498) (owner: 10Jason Linehan) [18:29:52] 10TWLCon-2019-India: Reminder Notifications about Scholarships: Set 2 - https://phabricator.wikimedia.org/T210238 (10Shypoetess) 05Open>03Resolved [18:41:25] 10Google-Summer-of-Code, 10Graphs: Support Vega 3.0 and Vega Lite 2.0 - https://phabricator.wikimedia.org/T165118 (10domoritz) As an author of Vega-Lite and contributor to Vega, I'd like to offer my support and help with this effort. [19:56:17] 10ApiFeatureUsage: Add new url to upload photos using API - https://phabricator.wikimedia.org/T210330 (10Jnanaranjan_sahu) [20:11:39] 10Wikidocumentaries: Apply site design to image viewer - https://phabricator.wikimedia.org/T210331 (10Susannaanas) [20:12:22] 10Wikidocumentaries: User interface modifications - https://phabricator.wikimedia.org/T210229 (10Susannaanas) [20:12:24] 10Wikidocumentaries: Apply site design to image viewer - https://phabricator.wikimedia.org/T210331 (10Susannaanas) [20:13:39] 10Wikidocumentaries: MediaWiki tasks - https://phabricator.wikimedia.org/T210230 (10Susannaanas) [20:13:41] 10Wikidocumentaries: Research language fallback in Wikidata and reuse - https://phabricator.wikimedia.org/T210318 (10Susannaanas) [20:15:58] 10Wikidocumentaries: Apply site design to image viewer - https://phabricator.wikimedia.org/T210331 (10Susannaanas) p:05Triage>03Normal [20:19:40] 10Wikimedia-production-error: Exception of type Wikimedia\\Rdbms\\DBConnectionError after an API query - https://phabricator.wikimedia.org/T210332 (10He7d3r) [20:19:50] i'm back :D [20:20:17] shreyasminocha: How is rachit's task? [20:20:29] he got done with it [20:20:45] Urbanecm: and i were discussing your recent *exploits* [20:20:45] https://en.wikipedia.org/wiki/User:Bleed.tech/sandbox#Task_3 [20:20:55] um, errors [20:21:07] shreyasminocha: huh, and? [20:21:20] thinking of all the possibilities [20:21:26] esp in terms of data viz [20:21:30] Oh [20:21:50] google said 'Thank you for the report. We'll investigate this' [20:21:59] oh, you've reported? [20:22:07] Urbanecm and I didn't know [20:22:20] and.. [20:22:25] they have fixed it [20:22:26] hahah [20:22:27] so fast [20:22:34] Urbanecm: :D [20:22:42] idts, no they haven't [20:22:46] no [20:22:50] they have fixed it completly [20:23:00] even removing ids from organization [20:23:01] wo [20:23:03] fast [20:23:16] i can still access the stuff [20:23:18] yeah [20:23:21] the old stuff [20:23:26] but heh [20:23:30] they have fixed the issue [20:23:37] because the id is so long [20:23:44] and brute forcing it will take so long [20:23:50] shit, i was so excited. [20:23:53] and google's server will add a temp ban [20:23:59] I was trying [20:24:01] :) [20:24:13] no, not bruteforce [20:24:25] so does the endpoint still show the latest data? [20:24:52] If you have got an id - yes [20:25:09] but getting ids from organization endpoint ripped [20:25:12] [*] [20:25:23] oh, i see [20:26:06] /api/program/current/taskinstance still shows ids i think [20:26:26] it only shows your current tasks [20:26:42] no, but there's a claimed_by_id key [20:27:07] try running it from a REST client without cookies [20:27:26] 04(no projects): Add new url to upload photos using API - https://phabricator.wikimedia.org/T210330 (10Aklapper) @Jnanaranjan_sahu: Hi, is this a request to add a URL to `$wgCopyUploadsDomains` for Wikimedia Commons? If it is, please see https://commons.wikimedia.org/wiki/Commons:Upload_tools/wgCopyUploadsDoma... [20:28:31] dk how to set up auth headers in postman, but i'll take your word for it [20:28:38] the entire key is gone, you say? [20:28:43] yup [20:28:53] because /taskinstance is based on auth [20:29:09] fck that's sad [20:29:30] no, wait [20:29:37] so if you're authed, it'll still show [20:29:42] but if you aren't, it wouldn't [20:29:46] amirite? [20:29:48] nono [20:29:55] https://codein.withgoogle.com/api/program/2018/organization/4956074911203328 [20:30:07] look at "leaders" array [20:30:20] you are able to get your own ID, but not ID of others [20:30:20] it no longer contains user ids [20:30:24] yup [20:30:36] oh i see [20:30:39] Google have fixed the main thing that allowed my *exploit* work [20:31:03] * shreyasminocha sighs sadly [20:31:10] I could try finding more *exploits* [20:31:17] shreyasminocha: why? [20:31:23] hats off to you though for your work takidelfin [20:31:39] no, was really excited about what cool stuff we could use this for [20:31:46] white or black hats ? ( ͡° ͜ʖ ͡°) [20:31:59] shreyasminocha: yeah, that is true [20:32:03] Like for graphs [20:32:09] exactly [20:32:20] I'm stupid, I could keep the latest leader id array [20:32:21] takidelfin: greyish-white ;) [20:32:21] :/ [20:32:26] :D [20:32:53] don't you already have the ids of us lot? [20:33:10] I was getting it dynamically to be always up-to-date [20:33:32] okay [20:33:37] so you wrote a script, eh? [20:33:38] I have restored the IDS [20:33:41] shreyasminocha: :D [20:33:46] 3 scripts to be honest [20:33:50] one for irc bot [20:33:52] one for a site [20:33:57] and one for cmd line [20:34:12] 04(no projects): Add new url to upload photos using API - https://phabricator.wikimedia.org/T210330 (10Jnanaranjan_sahu) Sorry for the wrong tag and thank you for the information. I see there is a different process to request for this task. Shall I create new one or just edit this? [20:34:24] takidelfin: you're a [redacted to keep you modest] [20:34:51] * takidelfin googles word 'modest' [20:35:46] you'll realize it was a great compliment [20:36:00] anyway, hand me them ids please? [20:36:11] sure [20:36:14] https://gist.github.com/takidelfin/c7e45da9e35e0038b3a1260b4818f5fa [20:36:45] the one i care most about is Nathan's [20:36:54] ex dee [20:36:56] same here [20:37:03] https://taki.ml/gci-wikimedia-leaders [20:37:04] LOL [20:37:17] that weird limit gone [20:37:19] but [20:37:28] now because the id of leader is null [20:37:34] it returns all tasks done by user [20:37:43] wow lol [20:37:44] (03CR) 10Urbanecm: [C: 04-1] Fix: superusers, trusted users can always post comments (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [20:37:59] * all tasks available in org [20:38:04] gotcha [20:38:15] https://taki.ml/gci-coala [20:38:19] same thing for COala [20:38:26] so takidelfin, when the exploit worked, would it have been possible to get a list of all students' ids [20:38:36] Nope [20:38:39] But... [20:38:42] I could try find another [20:38:43] ;> [20:38:51] * shreyasminocha tips his hat [20:39:14] btw, are you male or female? (asking because in my conversation with Urbanecm i had to refer to you as he/she) [20:39:25] male :D [20:39:37] actually, i should've asked you for you "preferred pronoun" to be politically correct [20:39:41] ah. [20:40:02] now that i think of oit, i should've figured from your GH pic [20:40:11] * takidelfin shrugs [20:40:35] or just use, gender natural without using he/she [20:40:50] usually do, context didn't permit me to use "they" [20:40:58] https://codein.withgoogle.com/api/app_manifest/ [20:41:03] also it is a interesting thing [20:41:10] status of the GCI [20:41:16] HAHHAHAH [20:41:21] They have added a version header [20:41:24] hotfix1 [20:41:25] "hotfix" [20:41:28] yup [20:41:35] * shreyasminocha laughs out loud irl [20:41:36] so my *exploit* was hot [20:42:02] OK, Google I like it [20:44:44] (your comma should've been after "Google" unless you wanted me to search for "I like it". asked for-nazi-ism :D) [20:45:15] thanks \o/ [20:46:26] * Urbanecm keeps wonder why Google simple didn't add something like "if id != my_id"... [20:46:30] *wondering [20:47:25] um [20:47:35] because it is used for anonymous users too [20:47:47] it simply fetches a tasks list [20:48:05] hey takidelfin, how are you? :p [20:48:13] hello! [20:48:16] but you don't need completed_by, do you? [20:48:24] i wonder if it would've shown the winners and finalists before they were released [20:48:32] Then it gets all available tasks [20:48:33] shreyasminocha: "winners": {}, [20:48:38] in org endpoint [20:48:44] https://codein.withgoogle.com/api/program/2018/organization/4956074911203328 [20:48:58] i wonder at what stage they'll fill their array [20:48:58] I think google doesn't add winners into system before releasing [20:49:04] yup [20:49:15] they've got to be better than that [20:49:19] but that's the assumption we all made [20:49:25] until taki found this gold [20:49:59] https://codein.withgoogle.com/api/program/ [20:50:09] i have that open, yes [20:50:28] "winners_published": false [20:50:53] * shreyasminocha is digesting the implications of that [20:51:07] "orgs_published": true, [20:51:07] "competition_open": true, [20:51:07] "no_claims": false, [20:51:07] "grace_period": false, [20:51:07] "winners_choosing": false, [20:51:07] "winners_published": false, [20:51:13] Grace peroid [20:51:18] *period [20:51:21] yeah, noticed. [20:51:23] lol [20:51:48] takidelfin: do you have a list of al the endpoints? [20:52:01] this is what im doing now [20:52:14] brute? [20:52:50] "winners_choosing_starts":"2018-12-13T17:00:00Z","winners_choosing_ends":"2019-01-07T16:59:59Z" [20:52:57] long time period [20:53:31] okay, I think I have found something interesting [20:53:37] a patch to follow [20:53:50] you've found a lead, sherlock [20:54:45] yes sherlock. disclose. [20:54:52] (if you shall please) [20:56:09] takidelfin: you tried bruteforcing th ids, yes? [20:56:16] yup [20:56:22] and then I have got banned for 15 hrs [20:56:28] ono lol [20:56:28] ;( [20:57:24] how many requests did you make before you were banned? [20:57:37] 120 [20:57:42] ~ [20:57:44] sad [20:58:05] what was the thing you were going to mention? "a patch to follow"? [20:59:07] auth [20:59:34] also, There was 52163 tasks in all GCI programs! [20:59:34] what about it? [20:59:40] holy cow [21:00:51] takidelfin, together from all GCI years? Or 52163 only in 2018? [21:01:01] together from all GCI year [21:01:02] s [21:02:45] ough [21:02:47] (03PS5) 10Nathan fraignt: Fix: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [21:02:52] Maybe I will figure it out later [21:03:03] Now lets do some real GCI tasks :> [21:03:16] Sup, I´m back [21:03:27] hi! [21:03:29] Time to crush some GCI tasks [21:03:42] C: [21:03:52] hi Nathan_fraignt [21:05:15] https://taki.ml/gci-wikimedia-leaders It´s broken :( [21:05:20] yup [21:05:29] Because google have deployed a hotfix [21:05:32] hotfix1 [21:05:36] Sad [21:05:43] Nathan_fraignt: check the scrollback [21:05:47] or the logs [21:05:54] I don't recommend clicking on the user name now.. [21:06:04] because it will show you all 250 tasks [21:06:14] Kinda glossed over it shreyasminocha [21:06:24] something about everyone wanting to see my finished tasks lol [21:06:42] you're a bullet, man [21:06:58] Not sure if that´s good or bad [21:07:06] (being a bullet) [21:07:09] good [21:07:13] Because you have got the most number of tasks done [21:07:14] (fast as a bullet) [21:07:16] you are our master [21:07:22] we are followin you [21:07:23] * shreyasminocha bows down to Nathan_fraignt [21:07:23] Hahaha thanks shreyasminocha [21:07:36] Feel really honored [21:07:45] but like, a lot of my tasks are just PEP8 style fixes [21:07:57] ( I can confirm ) [21:08:07] So it´s not that impressive [21:08:11] takidelfin: lol [21:08:32] I am still holding some trapcards [21:08:40] UrbanecM, could you have a look at https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/475592 ? [21:08:46] wow [21:08:47] looking [21:08:49] that speed tho [21:09:03] hi am back, 4 minutes later, could you review my task? [21:09:03] Was already finished lol [21:09:13] (lies) [21:09:20] Hahahah [21:09:32] not but for real you can look at it, it was already finished :D [21:09:35] Nathan_fraignt: are you human? [21:09:43] Yes I am human. [21:09:47] Beep boop [21:09:48] oh! He is a robot [21:09:54] I knew it [21:09:55] *makes human noises* [21:10:01] Nathan_fraignt: https://www.drupal.org/files/project-images/reCAPTCHA_images_0.png [21:10:11] What is all soup [21:10:20] hhah [21:10:31] PRAISE THE OMNISSIAH [21:10:45] Without kidding, I did about 50 captachs today [21:10:49] this is how he resolves caotchas [21:10:49] https://www.youtube.com/watch?v=fsF7enQY8uI [21:10:56] *captchas [21:11:00] Nathan_fraignt: not surprised you're trigerring captchas lol [21:11:28] If you do like 5 of them in a row, they get stupid hard [21:11:40] But I had to test comments for a task [21:11:53] Which had a stupid catcha in front of them [21:12:22] (03CR) 10Urbanecm: [C: 04-1] Fix: superusers, trusted users can always post comments (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [21:12:31] * takidelfin opens devtools [21:12:48] I'm gonna fight with it [21:13:27] with what? [21:13:34] (03PS6) 10Nathan fraignt: Change: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) [21:13:37] with captcha system [21:13:45] Nathan: 241 [21:13:45] Shreyas Minocha: 241 [21:13:46] wow [21:13:48] such speed [21:13:55] 241 tasks done [21:13:58] wow [21:14:00] * shreyasminocha wears thug life goggles [21:14:06] * shreyasminocha picks up pipe [21:14:17] * takidelfin googles thug life wear [21:14:22] * shreyasminocha is surrounded by thug-life music [21:14:47] takidelfin: http://www.freepngimg.com/thumb/thug/1-2-thug-life-sunglasses-png-thumb.png [21:15:07] * thug-life_music is surrounded by shreyasminocha [21:15:08] heheh [21:15:14] 10MobileFrontend, 10Readers-Web-Backlog: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10D3r1ck01) [21:15:27] Nathan_fraignt, {{reviewed}}, as you can see [21:15:42] takidelfin: https://ih0.redbubble.net/image.91305735.3369/ap,550x550,12x12,1,transparent,t.u1.png [21:15:42] Already pushed a change Urbanecm [21:15:47] ah :D [21:15:51] 10MobileFrontend, 10Readers-Web-Backlog, 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10D3r1ck01) [21:15:52] reviewing again [21:15:55] :D [21:15:56] :D [21:16:12] Urbanecm: why do you always surround `reviewed` and `approved` with two curly brace pairs? [21:16:14] 10MobileFrontend, 10Readers-Web-Backlog, 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10D3r1ck01) a:03D3r1ck01 [21:16:33] I think it is a MediaWiki joke [21:16:37] (03CR) 10Urbanecm: [C: 032] Change: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [21:16:42] or a trigger for IRC client [21:16:49] the former one [21:16:50] joke is more likely [21:16:53] Got that fancy +2 code review [21:16:59] wow [21:17:09] Thanks urbanecm :) [21:17:12] yw Nathan_fraignt [21:17:29] (03Merged) 10jenkins-bot: Change: superusers, trusted users can always post comments [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475592 (https://phabricator.wikimedia.org/T210309) (owner: 10Nathan fraignt) [21:17:39] Introducing a *weird smile* [21:17:41] Wikitext (a markup language MediaWiki uses) uses this syntax to include templates [21:17:42] (: [21:17:51] which confuses everyone [21:18:00] yeah [21:18:21] so I was right ._. [21:18:25] and in places like the Administrator noticeboard, admins use "done" or "not done" and so on as their templates to add icons in front of the message [21:18:25] or the schrondinger's emoji :): and sibling :(: [21:18:35] ah [21:18:42] \._./ [21:18:48] | [21:18:56] shit, my nick's too long [21:19:12] Sad, no more tracker tasks [21:19:20] Well time for some style fixes in that case [21:19:21] sad.png [21:19:32] scared.jpg [21:19:41] Nathan_fraignt: you can find them on Urbanecm's phab board, can't you? [21:19:55] you can find the tickets and request for them to be imported into gci [21:20:06] Hmmm that is a great idea [21:20:12] credits to Urbanecm [21:20:17] Thanks [21:20:23] np [21:20:27] (Leave some Tracker tasks for me too) [21:20:32] same [21:20:35] ( I want to learn Python too) [21:20:38] ( :D ) [21:20:49] rip copyleft games though [21:20:49] Already have a merged stylefix though, so as soon as urbanecm accepts this task I´ll submit that one [21:21:09] batch tasks [21:21:10] done [21:21:11] Tracker tasks might not be the best to learn Python, AFAIK all the beginner tasks are gone [21:21:22] * takidelfin shrugs [21:21:30] tracker beginner tasks that is [21:21:42] leave some for me Nathan_fraignt! [21:21:48] heheh [21:21:52] I have learnt unit testis in previous GCI... [21:21:52] jk [21:22:11] And I had only 7 tasks done [21:22:12] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Allow superusers and users granted special permission to comment even enable_comment is False - https://phabricator.wikimedia.org/T210309 (10Urbanecm) 05Open>03Resolved a:03Nathan_fraignt [21:22:14] (alhtough i want some tracker tasks too. not gonna stop you ofc.) [21:22:27] Hahah, I´ll try and leave some [21:22:42] He [21:22:49] * takidelfin oops [21:22:49] She [21:23:02] I´ll probably have to wait ~16 hours till this one is accepted [21:23:03] * Urbanecm is going to import some Tracker tasks to GCI [21:23:09] You´re the ebst [21:23:13] best* [21:23:28] * takidelfin opens REST Client to add a watcher for a task list change with tag Tracker [21:23:28] i'm still waiting on a review, so no tasks for me [21:23:50] It´s better to watch on phab [21:24:12] ain't no fun in normie workflows, aye? [21:24:13] it takes quite a bit of time before tasks that are imported show on GCI [21:24:28] Well we do want to be efficient [21:24:32] :( [21:24:48] we do want the thug life too [21:25:00] but one doesn't choose the thug life. the thug life chooses them [21:25:31] tfw you open nano but try to use vim keybindings [21:25:39] wth am i using nano anyway [21:25:45] 'radziecka inwersja' - soviet inversion [21:25:56] 10Google-Code-in-2018, 10WMCZ-Tracker: When at least one notification about one of "changed" object exist, do not emit others - https://phabricator.wikimedia.org/T204605 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/4689265716887552/. [21:26:03] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: When at least one notification about one of "changed" object exist, do not emit others - https://phabricator.wikimedia.org/T204605 (10Urbanecm) [21:26:49] 10WMCZ-Tracker: Fail sliently when the same notification is to be added in the second time - https://phabricator.wikimedia.org/T196234 (10Urbanecm) 05Open>03Invalid Doesn't happen now. [21:27:57] 10WMCZ-Tracker: Add grant name to breadcrumb in admin interface (/admin/tracker/ticket//) - https://phabricator.wikimedia.org/T195997 (10Urbanecm) [21:30:31] Nathan_fraignt, it takes some time because tasks a mentor imports to GCI must be then published by an org admin [21:30:53] aklapper :O [21:31:00] Yeaj, I thought it would be something along those lines [21:31:03] he's one of them [21:31:12] Etienne is another [21:31:24] I literally know none of them [21:31:31] Should´ve made more friends [21:31:33] rip [21:31:39] Etienne is ebe123 [21:31:51] Oh nevermind kinda know who that is [21:31:57] you must be familiar with aklapper though [21:32:00] :) [21:32:08] Don´t think so [21:32:10] he has edits on all the phab tickets [21:32:21] "aklapper edited the task description" [21:32:24] Honestly don´t know who that is [21:32:27] hah [21:32:45] on one percent battery [21:32:53] and have a vm running fml [21:33:01] :/ [21:33:42] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow users to watch only certain acks - https://phabricator.wikimedia.org/T208655 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/5112556973719552/ [21:34:13] Urbanecm, when registering an account, it doesn´t aautomaticallylog that account in. Is that intentional? [21:34:46] In Tracker? No, it's a bug I felt too lazy to create even Phab task for [21:35:27] ( ͡° ͜ʖ├┬┴┬ [21:35:34] whoa whoa whoa takidelfin [21:35:39] going to do it now, and will import it into GCI too :D [21:35:52] ᕦ(▀̿ ̿ -▀̿ ̿ )つ├┬┴┬┴ [21:36:02] * A GCI task have appeared * [21:36:05] these are going way above my head now [21:36:07] lol [21:36:19] Alright [21:36:23] Urbanecm: all your task are belong to us [21:36:24] yes [21:36:46] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: After an account is registered, it isn't automatically logged in - https://phabricator.wikimedia.org/T210334 (10Urbanecm) [21:36:53] ^^^^^ [21:36:57] That one is mine [21:37:08] lol, no if anyone else is able to claim it before me, good luck [21:37:27] Lol that description though [21:37:59] lol [21:38:02] lol [21:38:41] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: After an account is registered, it isn't automatically logged in - https://phabricator.wikimedia.org/T210334 (10Urbanecm) https://codein.withgoogle.com/tasks/4827716621697024/ [21:38:46] gn fellas, it's 3 am here [21:38:53] see you tomorrow shreyasminocha [21:39:03] so long, so long [21:39:50] Gn [21:40:39] 10WMCZ-Tracker: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) [21:41:41] shreyasminocha: Goodnight! [21:41:49] 10WMCZ-Tracker: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) [21:42:51] 10Google-Code-in-2018, 10WMCZ-Tracker: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) [21:43:01] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) [21:43:35] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Allow topic admins/ticket owners to override watching set up by system - https://phabricator.wikimedia.org/T208656 (10Urbanecm) Imported as https://codein.withgoogle.com/tasks/5999535416410112/ [21:44:20] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Urbanecm) [21:44:32] Nathan_fraignt, ^^^ something for the captcha issue ^^^ [21:44:49] Woah lots of tasks [21:44:54] Thanks [21:45:11] yw [21:45:16] (03PS1) 10D3r1ck01: Add PHPUnit test cases for DefaultContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475598 (https://phabricator.wikimedia.org/T210333) [21:45:23] Stupid account login is harder than expected since you use the Django standard auth thingie which I´ve nver used [21:45:28] But i´ll figure it out [21:46:26] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Disable ReCaptcha for logged in users - https://phabricator.wikimedia.org/T205136 (10Urbanecm) https://codein.withgoogle.com/tasks/5663655971520512/ [21:46:40] ask if you have questions :) [21:47:03] Andre (an org admin) told me he will publish the tasks in a couple of mins :) [21:48:35] (03PS1) 10Takidelfin: stylelint: Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) [21:48:36] Well, the login/register views look custom, so there should be at least a template for them somewhere, but I can´t find it. Also I probably need to override the register function/form procces function of the register view and add authenticate(user, pw) [21:48:42] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit test cases for DefaultContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475598 (https://phabricator.wikimedia.org/T210333) (owner: 10D3r1ck01) [21:49:04] So I´m bassically looking of anything that remotely represents a login view/template/something [21:49:04] (03PS2) 10D3r1ck01: Add PHPUnit test cases for DefaultContentProvider::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475598 (https://phabricator.wikimedia.org/T210333) [21:49:17] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer: Improve code examples of the Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [21:49:18] Nathan_fraignt, /trackersite/users/templates [21:49:33] Woah [21:49:37] That fixes everything [21:49:40] there is another app [21:49:41] woah [21:49:50] (03CR) 10Takidelfin: "recheck" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin) [21:50:01] Sorry lol, just never seen that folder. A whole new world just opened [21:50:18] np [21:54:55] 10Google-Code-in-2018, 10Wikidata, 10Wikidata Query UI, 10Need-volunteer: Improve code examples of the Wikidata Query UI - https://phabricator.wikimedia.org/T207749 (10abian) [21:54:57] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: After an account is registered, it isn't automatically logged in - https://phabricator.wikimedia.org/T210334 (10Nathan_fraignt) a:03Nathan_fraignt [21:55:09] (03PS1) 10Nathan fraignt: Change: User will now login after registering [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475600 (https://phabricator.wikimedia.org/T210334) [21:55:34] Here is to hoping no one claims it before my other task is claimed [21:57:16] (03CR) 10jerkins-bot: [V: 04-1] stylelint: Replaced CSSLint with StyleLint [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin) [21:57:41] Nathan_fraignt, I approved the W504 task you did, as it is already merged, it is not a problem [21:58:04] oh, maybe I will try W504 task to get familiar with Python first [21:58:27] Woah, thanks did not know that you could do that! [21:58:45] Takidelfin, W504 are easy to start with! [22:00:02] Yw. Mentors can approve anything they're comfortable to approve :) [22:01:13] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm, 10goodfirstbug: Fix issues found by flake8 - https://phabricator.wikimedia.org/T203951 (10Urbanecm) [22:01:33] takidelfin, if you want to get familiar with Tracker code, I recommend https://codein.withgoogle.com/tasks/6093941754560512/ [22:01:59] That is just what I wanted to say [22:02:23] ) [22:04:37] (03CR) 10Legoktm: [C: 04-1] "Good start!" (035 comments) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin) [22:07:14] (03CR) 10Legoktm: [C: 04-1] stylelint: Replaced CSSLint with StyleLint (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin) [22:07:22] 10MobileFrontend, 10Readers-Web-Backlog, 10Patch-For-Review, 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10D3r1ck01) [22:07:39] 10MobileFrontend, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10User-D3r1ck01: PHPUnit: Cover methods in content-providers/DefaultContentProvider.php with unit tests - https://phabricator.wikimedia.org/T210333 (10D3r1ck01) [22:11:25] Urbanecm: First I need to get familiar with Python :d [22:12:28] I think Python should be quite clear to you if you know some other language [22:13:14] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475598 (https://phabricator.wikimedia.org/T210333) (owner: 10D3r1ck01) [22:14:52] It is, the syntax is really easy, and AFAIK there aren´t that many weird quirks [22:15:26] The hardest thing about the tasks is Django imho [22:20:41] (03CR) 10Urbanecm: [C: 04-1] Allow user that has no old password to create a password (032 comments) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475590 (https://phabricator.wikimedia.org/T209320) (owner: 10Rafidaslam) [22:22:01] (03CR) 10Takidelfin: stylelint: Replaced CSSLint with StyleLint (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/475599 (https://phabricator.wikimedia.org/T206506) (owner: 10Takidelfin) [22:22:20] that's true Nathan_fraignt [22:26:05] Urbanecm do you have an ETA on when the tasks will show up in GCI? [22:27:39] in #wikimedia-devrel andre__ said it'll be in a few mins. I reminded for case he forgot, but this is beyond my control. Also it's 23:30 in Czechia - my and andre__'s country [22:28:28] so might be tomorrow, we'll see :) [22:29:51] yeah, same time here. I´ll wait for a bit, if they aren´t there I´ll just go to bed. [22:31:01] (03PS1) 10Urbanecm: Ensure deployer is on master when deploying code to production [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475602 [22:31:40] (03CR) 10Urbanecm: [C: 032] Ensure deployer is on master when deploying code to production [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475602 (owner: 10Urbanecm) [22:32:32] (03Merged) 10jenkins-bot: Ensure deployer is on master when deploying code to production [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475602 (owner: 10Urbanecm) [22:35:40] Nathan_fraignt: published [22:35:40] Urbanecm: I can help publish [22:35:47] d3r1ck: Heh, yay :) [22:35:50] Ohhh! [22:35:57] thanks andre__ [22:36:08] andre__: If you've handled it, then I got back to my shell :) [22:36:16] Thanks a lot! [22:36:36] I get easily distracted by watching Monty Python sketches on the interwebs, I'm afraid. :P Sorry that took a bit longer [22:36:58] Hahah, no problem at all andre__ [22:54:37] (03CR) 10Urbanecm: [C: 032] Change: User will now login after registering [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475600 (https://phabricator.wikimedia.org/T210334) (owner: 10Nathan fraignt) [22:55:30] (03Merged) 10jenkins-bot: Change: User will now login after registering [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/475600 (https://phabricator.wikimedia.org/T210334) (owner: 10Nathan fraignt) [23:23:12] (03CR) 10Anomie: Simplify APIParseExtender (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/475572 (https://phabricator.wikimedia.org/T86210) (owner: 10Jdlrobson) [23:26:14] (03CR) 10Legoktm: [C: 032] ApiQueryBlocks.php: Call static function statically [core] - 10https://gerrit.wikimedia.org/r/474843 (owner: 10Reedy) [23:29:22] (03PS1) 10Legoktm: Don't export scripts/ [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/475604 [23:31:06] (03PS1) 10Legoktm: Drop pre-PHP 7 support [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/475605 [23:39:07] (03PS8) 10Legoktm: Add wikimedia/password-blacklist 0.1.3 [vendor] - 10https://gerrit.wikimedia.org/r/414602 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy) [23:40:19] (03CR) 10Legoktm: "You're using an old version of composer to generate this, which is why there were unrelated changes in ClassLoader.php." [vendor] - 10https://gerrit.wikimedia.org/r/473630 (https://phabricator.wikimedia.org/T209371) (owner: 10Addshore) [23:40:38] (03Merged) 10jenkins-bot: ApiQueryBlocks.php: Call static function statically [core] - 10https://gerrit.wikimedia.org/r/474843 (owner: 10Reedy) [23:43:04] (03CR) 10jenkins-bot: ApiQueryBlocks.php: Call static function statically [core] - 10https://gerrit.wikimedia.org/r/474843 (owner: 10Reedy) [23:48:05] (03PS26) 10Legoktm: Add PasswordPolicy to check the password isn't in the large blacklist [core] - 10https://gerrit.wikimedia.org/r/414603 (https://phabricator.wikimedia.org/T151425) (owner: 10Reedy) [23:55:08] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata: Should blocking a user from a Wikibase item also block them from referencing that item? - https://phabricator.wikimedia.org/T207948 (10abian) Could this be optional (a checkbox)? I think users should be blocked from editing references/... [23:56:22] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata: Should blocking a user from a Wikibase property also block them from using the property? - https://phabricator.wikimedia.org/T207906 (10abian) I would say the same as on T207948. Could this be optional (a checkbox)?