` tag which is a tag f... [05:17:21] connect [05:29:18] 10IPSet, 10PHP 7.3 support: IPSet tests fail on PHP 7.3 - https://phabricator.wikimedia.org/T209756 (10RazeSoldier) For my test, the warning throwed by `trigger_error` (https://github.com/wikimedia/IPSet/blob/master/src/IPSet.php#L126), not by `inet_pton()`. [05:29:25] 10IPSet, 10PHP 7.3 support: IPSet tests fail on PHP 7.3 - https://phabricator.wikimedia.org/T209756 (10RazeSoldier) For my test, the warning throwed by `trigger_error` (https://github.com/wikimedia/IPSet/blob/master/src/IPSet.php#L126), not by `inet_pton()`. [05:34:37] um, hello kong|430 [05:42:39] 10IPSet, 10PHP 7.3 support: IPSet tests fail on PHP 7.3 - https://phabricator.wikimedia.org/T209756 (10RazeSoldier) For my test, the warning is not only triggered once. `trigger_error()` (https://github.com/wikimedia/IPSet/blob/master/src/IPSet.php#L126) and `inet_pton()` will trigger a warning. This looks ver... [06:37:15] :D [07:16:46] (03PS2) 10TheDJ: textSelection: Use execcommand to replace text [core] - 10https://gerrit.wikimedia.org/r/474520 (https://phabricator.wikimedia.org/T33780) [07:18:48] (03Abandoned) 10TheDJ: Allow Pygments be run via CGI [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/474517 (owner: 10Gerrit Patch Uploader) [07:19:15] (03PS2) 10TheDJ: Allow Pygments to be run via CGI [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/474518 (https://phabricator.wikimedia.org/T209700) (owner: 10Gerrit Patch Uploader) [07:21:17] (03CR) 10jerkins-bot: [V: 04-1] Allow Pygments to be run via CGI [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/474518 (https://phabricator.wikimedia.org/T209700) (owner: 10Gerrit Patch Uploader) [07:27:33] takidelfin: hi [07:36:58] i don't see an option to choose "MediaWiki Screenshot" on Wikimedia Commons [07:37:13] it just allows me to choose between one of the Creative Commons [07:37:26] i'm following the instructions given here: https://codein.withgoogle.com/dashboard/task-instances/5097767320944640/ [07:48:45] nvm, i used the most permissive one available and chose the "Mediawiki Screenshot" category [07:49:37] shreyasminocha: Hello :D [07:50:19] hey! [08:10:33] 10Wiki-Loves-Monuments (2018): [2018] Reconsider the scheme for participating campaigns - https://phabricator.wikimedia.org/T178957 (10Theklan) 05Resolved>03Open Not solved in any way. We are exactly at the starting point. Or worst. [08:10:55] 10Wiki-Loves-Monuments (2018): [2018] Reconsider the scheme for participating campaigns - https://phabricator.wikimedia.org/T178957 (10Theklan) p:05Normal>03High [08:36:29] hi refeed [08:37:06] shreyasminocha: Hello [08:37:15] refeed: hi! [08:37:50] takidelfin: Hello o/ [08:39:37] * refeed[m] gonna be afk for some minutes [08:45:35] 10Google-Code-in-2018, 10Quarry: Create api health point for monitoring - https://phabricator.wikimedia.org/T205151 (10rafidaslam) a:03rafidaslam I'll work on this [08:52:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Cover the NULL cases in getPluralLicenseInfo() unit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474462 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [08:55:20] (03PS1) 10星耀晨曦: Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) [08:55:42] 10IPSet, 10PHP 7.3 support, 10Patch-For-Review: IPSet tests fail on PHP 7.3 - https://phabricator.wikimedia.org/T209756 (10RazeSoldier) a:03RazeSoldier [08:55:50] (03CR) 10jerkins-bot: [V: 04-1] Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [09:00:06] (03PS2) 10星耀晨曦: Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) [09:00:33] (03CR) 10jerkins-bot: [V: 04-1] Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [09:07:14] (03Merged) 10jenkins-bot: Cover the NULL cases in getPluralLicenseInfo() unit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474462 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [09:10:17] (03PS3) 10星耀晨曦: Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) [09:10:55] (03CR) 10jerkins-bot: [V: 04-1] Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [09:12:34] (03CR) 10jenkins-bot: Cover the NULL cases in getPluralLicenseInfo() unit test [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474462 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [09:16:49] (03PS4) 10星耀晨曦: Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) [09:26:56] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Dragable Corners on Page Curation toolbar windows (for resizing) - https://phabricator.wikimedia.org/T207439 (10Insertcleverphrasehere) [09:28:43] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Page Curation toolbar: do not mark pages as 'reviewed' when adding CSD and PROD tags - https://phabricator.wikimedia.org/T208685 (10Insertcleverphrasehere) Twinkle has been updated to not mark CSDs as 'reviewed', (It never did mark PRODs as 'reviewed' in the... [09:30:15] hello [09:44:50] jenghongkong: Hello [09:56:44] (03Abandoned) 10Raimond Spekking: Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/474371 (owner: 10L10n-bot) [09:58:15] (03CR) 10Raimond Spekking: Localisation updates from https://translatewiki.net. (031 comment) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/474513 (owner: 10L10n-bot) [09:59:34] 10Repository-Ownership-Requests: Nominate Alangi Derick for +2 on mediawiki/* - https://phabricator.wikimedia.org/T209775 (10TheDJ) +2 (pun intended) [10:02:26] jenghongkong: hi [10:17:20] 10Wiki-Loves-Monuments-Sources, 10Wiki-Loves-Monuments (2018): Recreate a monuments lists for Morocco in French - https://phabricator.wikimedia.org/T175034 (10VIGNERON) Some of it happened for sure, but probably not all. For instance, the property https://www.wikidata.org/wiki/Property:P5694 corresponding to... [10:23:13] hello! i am here on irc for the completion of the task of Google Code In 2018. [10:24:13] pariboy123: Welcome! [10:24:25] thank you [10:24:41] this is my second task [10:25:27] pariboy123: Keep on continuing! :) [10:25:36] thanks [10:25:41] pariboy123: Btw, what irc client are you using? [10:25:42] so basically [10:25:53] i am using hexchat [10:26:03] pariboy123: You're welcome :) [10:26:14] jenghongkong: Hello, you're welcome :) [10:26:22] i just surfed for good irc clients i got hexchat listed at the top [10:26:28] hello [10:26:44] i use kvirc [10:26:50] haha [10:26:51] oh [10:26:59] it's new to me [10:27:14] in fact irc is new to me [10:27:17] this is my second task XD [10:27:32] XD? [10:27:55] pariboy123, jenghongkong : Good choice, they are opensource irc clients, which means you guys are on the right way :) [10:28:06] XD means 'happy face' [10:28:14] oh thanks [10:28:32] i again got to learn something new. thanks [10:28:41] :) [10:28:58] what's your task [10:29:30] Get onto Internet Relay Chat (IRC) [10:29:45] oh i see [10:30:10] i did something similar to that [10:31:03] so do you have any software experience ? [10:31:28] ? [10:31:49] like have you learnt any programming languages ? [10:32:22] javascript , c [10:32:35] completely? [10:32:48] ya [10:32:53] wow [10:32:57] keep going [10:33:02] :) [10:34:16] hey guys [10:34:23] hey [10:34:36] i heard you're into js? [10:35:03] oh that was jenghongkong, my bad. [10:35:07] anyway. what's up? [10:35:18] nothing much [10:35:35] so are you here for a gci task? [10:35:52] i'm doing gci, but not here rn for something specific [10:36:00] oh [10:36:02] i hang out here every now and then [10:36:09] how many tasks over ? [10:36:16] 19 + 1 waiting review [10:36:23] oh i see [10:36:29] really?? [10:36:45] you look like a computer genius [10:36:53] just checked to confirm :) [10:37:03] what? [10:37:05] not really :D i'm really interested though [10:37:15] same here [10:37:16] number of tasks completed. it's 20 + 1 waiting review actually [10:37:24] oh wow [10:37:27] neat [10:37:52] did you start recently? [10:38:05] no [10:38:13] from the starting date [10:38:13] with gci, that is [10:38:27] ah [10:38:28] i was busy with other stuff [10:38:36] how's it going so far? having fun? [10:38:43] yeah [10:38:44] yeah ofc, gci's not the only thing :D [10:39:01] great. keep going! [10:39:02] i am looking forward for some coding task in python [10:39:12] :) [10:39:13] there are some, actually [10:39:19] oh [10:39:26] i'll fish them out [10:39:50] you daily work on gci/ [10:39:55] ? [10:40:03] i try to, as and when possible [10:40:10] oh [10:40:15] nathan is really consistent with it [10:40:24] nathan ? [10:40:24] his current avg is exactly 1 / day, i believe [10:40:38] 1 task per day ? [10:40:41] yeah, the dude with the most no of completed tasks for wikimedia [10:40:45] yeah! [10:40:54] omg [10:41:10] i don't think he goes to school [10:41:22] :D ofc you're kidding [10:41:34] :) [10:41:39] that's good [10:41:44] (03CR) 10Seb35: "If this change is merged, MediaWiki and some extensions should be updated to catch the exceptions from IPSet::match() and avoid triggering" [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [10:41:51] there's this wikimedia project called tracker that's written in python [10:41:56] Urbanecm looks after it [10:41:59] https://phabricator.wikimedia.org/project/view/3391/ [10:42:03] oh [10:42:18] if there's anything you find interesting, you can drop him a message and he'll be happy to import it into gci for you [10:42:33] i'm sure it's the same for other projects as well [10:42:34] ok thank you [10:42:39] np [10:42:44] so where are you from [10:42:50] which country [10:42:55] india [10:43:01] oh [10:43:22] i see [10:43:49] then you must be busy with all your hw and classes [10:44:00] how do you find time fo gci [10:44:07] for [10:44:45] between end of classes and study time usually. sometimes i work during my study time and compensate for it by studying late into the night [10:45:02] oh wow that's good [10:45:11] wait [10:45:22] you take your pc to school ? [10:45:35] i study in a boarding school :) [10:45:44] and yes, 11th grade and above are allowed laptops there [10:45:46] oh i see [10:45:55] oh lucky [10:46:07] (03CR) 10Seb35: "Also, given the constructor could also throw LogicException, these exceptions should be also caught in other repos." [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [10:46:12] pariboy123, jenghongkong, your IRC nick is registered right? :) [10:46:20] yep [10:46:24] yes [10:46:36] Cool, that's great :) [10:46:37] i sent the verification message [10:46:48] and i got it verified [10:46:55] Nice one! [10:47:02] d3r1ck: hey. just read your comment on my task. my submission was legit :D. i had set up a local install some days back and brought it "back to life" recently. so to do the task i had to install the extension [10:47:11] but yes, will do what you've asked me to [10:47:31] shreyasminocha: Oh, it's you? Pardon me if I'm totally wrong there okay? [10:47:45] no prob! i understand [10:48:03] shreyasminocha: But looking at the perspective I'm coming from, it makes sense right? [10:48:09] exactly [10:48:23] So, I think all you need to do is do another submission :) [10:48:33] sure :) [10:48:48] This time do 2 snapshots, 1 with the env UI and another with the just the required image. [10:48:54] So we can both we on the same page :) [10:49:12] shreyasminocha: But the snapshot to go on the ext page would definitely be the required not the env UI one [10:49:27] Again, sorry about that. [10:49:36] I didn't even know it was you. [10:49:42] yep, no problem at all. [10:50:13] I got use to the handle here on IRC and not the handle on GCI [10:50:19] :( [10:50:37] relax! it's fine :D [10:50:56] * d3r1ck grins [10:51:00] irc includes a lot of people though [10:51:27] but still it's fun [10:53:52] pariboy123: It's more fun during week days here :) [10:54:00] why [10:54:01] Everyone getting busy, bots too :D [10:54:06] more ppl? [10:54:17] Weekends, people are AFK and spending some time in real life [10:54:21] Bots too are doing same [10:54:25] oh i see [10:54:27] pariboy123: Yes more people too [10:58:03] anyone there ? [10:58:24] I'm here :) [10:58:32] If you've got a question, feel free to ask :) [10:58:44] okay [10:58:59] are you also a participant of gci ? [10:59:20] or you are just a member on irc ? [10:59:37] Yes, I'm also participating. But not as a student. [10:59:44] I'm a mentor! :) [10:59:55] oh wow ! [10:59:57] great [11:00:05] Great to have you too :) [11:00:12] :) [11:00:24] so for which organisation ? [11:00:40] This organisation: Wikimedia [11:00:47] oh [11:01:02] i did both my tasks of this organisation only [11:01:20] Okay, nice! We've got more tasks available for you to claim :) [11:01:29] this is my second one [11:01:31] So when you're done with your second and it's approved, go ahead, take on more [11:01:40] yeah sure [11:02:28] can i come here and ask any doubt i have ? [11:02:39] sure [11:02:46] if anyone around can answer, they will [11:02:58] Ideally any doubt around Wikimedia development. But we've got a lot of people here with different expertise. So yes, you can ask :) [11:03:01] at wikimedia ? [11:03:07] Exactly, follow shreyasminocha advice too :) [11:03:23] oh [11:03:32] what is freenode then ? [11:03:41] irc network [11:03:50] or irc server might be the better word [11:04:05] there are several of these [11:04:05] so i need to join some channel to ask questions [11:04:05] Wikipedians love reading but shreyasminocha summarised it right. For more info, see: https://en.wikipedia.org/wiki/Freenode. [11:04:13] freenode's the most popular [11:04:20] there are all sorts of channels [11:04:21] oh [11:04:27] #python, #wikimedia-dev, ... [11:04:37] so i cannot interact on freenode ? [11:04:46] you are on freenode rn [11:04:48] i need to join some channel first ? [11:04:51] yes [11:05:01] you can join as many as you like [11:05:03] okayyy [11:05:09] i see [11:05:15] pariboy123: Think of Freenode like a house / building with many rooms [11:05:22] You've got the keys to all those rooms [11:05:30] nice analogy [11:05:30] okayy [11:05:32] But to interact with people in those rooms, you need to open a room and get it [11:05:35] i got it [11:05:58] But the advantage of freenode away from that analogy is that you can be present in different rooms at the same time [11:05:59] and the key is the channel name ? [11:06:07] Key = Channel name [11:06:10] oh [11:06:26] Normally, in real life we can't achive been in different places at the same time [11:06:31] But digitally, we can :D [11:06:34] https://www.youtube.com/watch?v=O2rGTXHvPCQ [11:06:41] This is a better description [11:06:45] Well, it was just an analogy to make you understand. [11:06:53] Great, pariboy123 follow geophertz's link :) [11:07:01] The link I sent has a better analogy [11:07:09] Cool then :) [11:07:32] d3r1ck: this would do, wouldn't it? https://imgur.com/a/WzRmcDW [11:07:58] That looks super awesome [11:08:13] cool [11:08:23] I'm wondering if you'll update the page a little (extension page) to include the new link I shared with you? [11:08:32] Rather than keep using the old one which has same content? [11:08:39] Does that make sense? [11:08:56] shreyasminocha: ^^ [11:09:00] not sure what you mean [11:09:24] oh, you want me to update the extension page? [11:09:30] with the new pic? [11:18:55] 10MediaWiki-Database, 10DBA, 10TechCom-RFC: RFC: Proposal to add wl_addedtimestamp attribute to the watchlist table - https://phabricator.wikimedia.org/T209773 (10D3r1ck01) Great input @Bawolff. That sounds great to me, and is alternative solution. I do see something with this approach. In the approach menti... [11:19:02] (03PS3) 10WMDE-Fisch: Add browser test for highlighting of jump mark symbols [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474171 (https://phabricator.wikimedia.org/T205270) [11:19:09] 10MediaWiki-Interface, 10MediaWiki-Internationalization: Make a custom date-time format for users in Special:Preferences - https://phabricator.wikimedia.org/T209766 (10Aklapper) >>! In T209766#4756141, @Leduyquang753 wrote: > Firstly, I have read the documentation before going here. As it says: >> Options are... [11:19:40] (03CR) 10WMDE-Fisch: Add browser test for highlighting of jump mark symbols (032 comments) [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474171 (https://phabricator.wikimedia.org/T205270) (owner: 10WMDE-Fisch) [11:20:25] shreyasminocha: yes, that will have the new site info right? [11:20:36] the prev is a little outdated :) [11:20:54] yes, it will (does). check? [11:20:57] (03PS4) 10WMDE-Fisch: Add browser test for highlighting of jump mark symbols [extensions/Cite] - 10https://gerrit.wikimedia.org/r/474171 (https://phabricator.wikimedia.org/T205270) [11:21:12] shreyasminocha: Also, the page currently mentions the blog.wikimedia... but I'm thinking you could update those links to the new one I shared on the task [11:21:24] oh, okay [11:21:32] sure thing. i thought you meant only the screenshot [11:21:48] Ohh I see. So both the screen shot and the links :) [11:22:02] And if you have time, the example area :) [11:22:08] yes [11:22:51] (03CR) 10星耀晨曦: "There is also a solution: just modify the test file and perform different tests for different PHP versions." [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [11:24:15] Thanks :) [11:24:20] shreyasminocha: But it's not a requirement [11:24:38] yeah, i figured. not an issue. [11:24:41] The requirement is the snapshot and once you've updated it, let me know and I'll approve [11:24:42] just one thing: [11:24:58] how do i update the list of whitelisted fields on the extension's page? [11:25:07] and i've updated the screenshot btw [11:25:59] "whitelisted fields"? I don't understand [11:26:03] What do you mean? :) [11:26:44] so the extension allows rss feeds from only whitelisted domains to be rendered. in my local installation i was able to edit localsettings.php to get the new domain to work. was wondering how i could do the same on the ext page [11:26:58] and there was this other config setting i changed to get things to work. same witih that [11:27:50] Ohh I see [11:28:01] Okay I think it's per wiki instance right? [11:28:08] That page runs on mediawiki.org [11:28:09] i'm guessing [11:28:15] yes [11:28:20] So it should be something to be done at the backend level I guess [11:28:39] That's why you could do it on your local wiki instance [11:29:04] So for now, the page looks really good to me [11:29:10] And you just need to submit on GCI :) [11:29:27] Oh, you've done so already [11:29:33] :) [11:30:52] jenghongkong: Hello and welcome! [11:31:06] I just saw you submitted your work but seems your IRC nick is not registered? [11:31:39] well [11:32:26] that was strange, their sudden exit when mentioned [11:32:41] funny coincidence [11:32:50] shreyasminocha: You're up and running :) [11:32:53] Ride on! [11:33:06] I've approved [11:33:10] thanks! [11:34:09] You're welcome :) [11:39:03] d3r1ck: wznt me to contact RSS's authors and req them to update the page? [11:39:42] Emmmm... not really sure! Let me check something quickly [11:39:49] d3r1ck: wouldn't it be better if W504 was removed from errors to ignore in tox.ini? [11:39:57] for pywikibot [11:40:17] stuff would start failing [11:40:39] the jenkins pipeline would fail [11:41:06] and i bwlieve wouldn't allow merge, but that shouldn't happen either way [11:41:13] shreyaminocha: we have to remove all the errors before this modification can be done? [11:41:18] ok [11:41:28] idk about the task [11:41:41] geophertz: Yes! [11:41:57] All those have to be removed before fixing the tox.ini file [11:42:08] shreyasminocha: So I think you should drop a message on the talk page :) [11:42:52] Just write something nice and short about the new link to the blog and you trying to update the example page gives you some erros and if it can be done [11:43:07] shreyasminocha: Do you get the point, I would say the talk page should be the contact point here :) [11:43:16] okay! [11:52:37] d3r1ck: for the code review I code the following comment if nocontent and ( [11:52:40] What about the "and ("? Maybe it could be also on the next line [11:52:45] what should I do about it? [11:54:06] geophertz: I think you should update it. Dvorapa is just suggesting that it should be on the next line. [11:54:26] Like so "and (nocontent in pagecontents [11:54:34] etc [11:54:52] ok how do I update it? [11:56:13] geophertz: let me fetch a link [11:56:27] ok [11:56:29] thank you [11:56:34] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Amending_a_change_(your_own_or_someone_else's) [11:56:37] geophertz: ^^ [11:56:48] kong|3: You're welcome :) [11:58:28] d3r1ck: hi [11:59:54] I've seen your submission, is this your actual IRC nickname? [12:00:06] kong|3: ^^ [12:00:36] (03CR) 10Prtksxna: [C: 031] Render 'Mixed' type as plain text [jsdoc/wmf-theme] - 10https://gerrit.wikimedia.org/r/474152 (https://phabricator.wikimedia.org/T206734) (owner: 10Arcayn) [12:05:51] I did "git review -d" should I rebase after making my changes? [12:06:40] geophertz: Errrmmmm, well do a "git pull --rebase origin master" [12:06:52] So your patch is at least the latest on master [12:09:48] ok I did git review -R [12:10:29] I hope I didn't mess something up. (´･ω･`) [12:11:40] Not sure but it shouldn't be the case :) [12:15:20] d3r1ck, I fixed the problems in my last task, would you be able to have a look sometime soon? :) [12:18:46] Yes! [12:19:26] 04(no projects): "/run//meta", "/rev//meta", "/query//meta" endpoints throw internal server error (code 500) when the id doesn't exist - https://phabricator.wikimedia.org/T209783 (10rafidaslam) [12:22:20] geophertz: I'll take a look at the ammended patch now :) [12:22:35] Thanks d3r1ck! [12:23:01] 10MediaWiki-extensions-WikimediaIncubator, 10Language-strategy, 10Release-Engineering-Team, 10Epic, 10I18n: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Liuxinyu970226) @C933103: > Not sure why are you asking me this here when you yourself have stated that th... [12:23:09] Nathan_fraignt: You're welcome! [12:23:47] Submitted another one :D. (You don´t have to look at it right away if you don´t want to, I´m just trying to get back at my 1 tasks/day) [12:26:16] Nathan_fraignt: You know how Jenkins work right? [12:26:26] FIFO architecture? :D [12:26:34] I'm trying to process things in queue [12:26:52] Trying to Round-Robbin to it too :D [12:27:18] Sorry haha [12:28:00] It's okay, I'm reviewing patches and once I get to yours, I'll definitely review too :) [12:28:03] Thanks for doing what you do ^^ [12:28:12] heh [12:36:03] (03CR) 10D3r1ck01: "> Patch Set 3: Code-Review+2" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/474462 (https://phabricator.wikimedia.org/T209765) (owner: 10D3r1ck01) [12:41:38] (03Abandoned) 10Aklapper: Updated the colour of Revision Slider [core] - 10https://gerrit.wikimedia.org/r/471540 (owner: 10Anandh18500) [12:41:44] (03Abandoned) 10Aklapper: Updated the colour of Revision Slider [core] - 10https://gerrit.wikimedia.org/r/471542 (owner: 10Anandh18500) [12:44:35] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Buttons on the curation toolbar stay blue - https://phabricator.wikimedia.org/T179220 (10Liuxinyu970226) [12:48:29] 10MediaWiki-User-login-and-signup, 10Growth-Team: Accounts created using Special:CreateAccount should trigger the survey at the first connexion - https://phabricator.wikimedia.org/T209583 (10Liuxinyu970226) [13:04:02] 10Google-Code-in-2018, 10International-Developer-Events: GCI: Research good venues in the USA where technical Wikimedia events could take place - https://phabricator.wikimedia.org/T209645 (10Aklapper) [13:09:32] (03CR) 10MarcoAurelio: [C: 04-1] Fix composer package name to match conventions (031 comment) [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [13:17:30] (03CR) 10Umherirrender: Add missing @covers tag (032 comments) [extensions/NewUserActions] - 10https://gerrit.wikimedia.org/r/474480 (https://phabricator.wikimedia.org/T195148) (owner: 10Zoranzoki21) [13:23:07] (03CR) 10Umherirrender: "I have no idea if wikimedia/at-ease could be used in this library for the error suppression, but that seems more standard way than @ in me" (032 comments) [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) (owner: 10星耀晨曦) [13:56:24] (03CR) 10Melos: [C: 031] Revert "Revert "Add typehinting for every object-only parameter"" (031 comment) [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/467879 (owner: 10Daimona Eaytoy) [14:07:13] 10MediaWiki-File-management, 10Commons, 10Multimedia: UploadStash - Cannot serve a file larger than 1048576 bytes. - https://phabricator.wikimedia.org/T97539 (10Seb35) This task should be either better phrased or declined: * the part about completing the upload process is already discussed on T85561 for Uplo... [14:07:15] 10WMSE-Riksarkivet-NAD, 10WMSE-Riksarkivet-TORA: Wikidata add basic properties for all Svenska Församlingar - https://phabricator.wikimedia.org/T199792 (10Salgo60) [14:07:17] 10WMSE-Riksarkivet-TORA: SCB map "församlingar" error reported - https://phabricator.wikimedia.org/T199802 (10Salgo60) 05Resolved>03Open Nere igen se [[ https://twitter.com/salgo60/status/1021757904171487232 | tweet ]] [14:15:43] (03CR) 10Esanders: [C: 031] Search & Replace: Use actual global replace [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474483 (https://phabricator.wikimedia.org/T58228) (owner: 10TheDJ) [14:16:45] (03CR) 10Esanders: Search & Replace: Fix using replace as first action (032 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474461 (https://phabricator.wikimedia.org/T76750) (owner: 10TheDJ) [14:17:55] (03CR) 10Esanders: [C: 032] "LOL. I guess this missed all our searches for IE[0-9]!" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474454 (owner: 10TheDJ) [14:18:52] (03CR) 10Esanders: [C: 032] LinkDialog: Switch to jquery.throttle-debounce plugin [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474457 (owner: 10TheDJ) [14:25:02] (03CR) 10Esanders: [C: 032] "Technically we should move this to extensions/Cite too." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474332 (owner: 10TheDJ) [14:31:54] (03PS2) 10Zoranzoki21: Add missing @covers tag [extensions/NewUserActions] - 10https://gerrit.wikimedia.org/r/474480 (https://phabricator.wikimedia.org/T195148) [14:31:56] (03Merged) 10jenkins-bot: JS for ie-mac is not supported, so no need for this CSS [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474454 (owner: 10TheDJ) [14:31:59] (03Merged) 10jenkins-bot: LinkDialog: Switch to jquery.throttle-debounce plugin [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474457 (owner: 10TheDJ) [14:32:26] 10MediaWiki-Email, 10Regression: Special:EmailUser/name should say if name cannot be emailed - https://phabricator.wikimedia.org/T209786 (10PrimeHunter) [14:33:38] (03PS5) 10星耀晨曦: Modify the test logic to make sure compatibility with PHP 7.3 [IPSet] - 10https://gerrit.wikimedia.org/r/474522 (https://phabricator.wikimedia.org/T209756) [14:34:05] 10Browser-Support-Firefox, 10VisualEditor (Current work): Focussing an (e.g. Gallery→Options→Image height) crashes VE on Firefox - https://phabricator.wikimedia.org/T209646 (10Esanders) `document.activeElement` [14:35:29] 10MediaWiki-API, 10Patch-Needs-Improvement: API export action does not support exporting specific revisions - https://phabricator.wikimedia.org/T40669 (10Aklapper) a:05rohan013>03None [14:37:26] 10Accessibility, 10MediaWiki-Parser, 10MW-1.27-release (WMF-deploy-2016-02-02_(1.27.0-wmf.12)), 10MW-1.27-release-notes: Whitelist additional values for the WAI-ARIA role attribute on certain elements in wikitext - https://phabricator.wikimedia.org/T26659 (10Aklapper) a:05MattFitzpatrick>03None [14:38:24] (03Merged) 10jenkins-bot: Remove the dialog version of ref inserter [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/474332 (owner: 10TheDJ) [14:38:25] 10MediaWiki-Special-pages, 10Patch-Needs-Improvement: Uncategorized categories/pages/templates/files refactoring - https://phabricator.wikimedia.org/T14942 (10Aklapper) a:05Harmageddon>03None [14:40:12] 10MediaWiki-File-management, 10Commons, 10Multimedia: Image redirects from the shared repo don't show "redirected from" - https://phabricator.wikimedia.org/T16117 (10Aklapper) a:05vvv>03None [14:40:49]