[00:01:15] (03PS4) 10VolkerE: Special:MergeHistory: Partially convert to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/302092 (https://phabricator.wikimedia.org/T134675) (owner: 10Sethakill) [00:05:01] 10QRpedia-General: qrpedia.org and qrwp.org are down - https://phabricator.wikimedia.org/T209019 (10Samwilson) @BBlack I sort of thought that might be the case; thanks for confirming. Sorry for the noise. @MichaelMaggs are you someone who might know how to progress this? [00:05:44] 10MinervaNeue, 10MobileFrontend, 10Mobile, 10Reading-Web-Local-Wiki-Issues: There is desktop Main page shown on mobile - https://phabricator.wikimedia.org/T209211 (10Dvorapa) No, only routine content changes, nothing like that. It was correct at October 25 per [[https://web.archive.org/web/20181025071041/h... [00:11:18] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10I18n: Date fields shouldn't force users to input ISO dates - https://phabricator.wikimedia.org/T209205 (10Aklapper) [00:12:46] (03Abandoned) 10Urbanecm: [DNM] Test [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472789 (owner: 10Urbanecm) [00:17:25] 10MinervaNeue, 10MobileFrontend, 10Mobile, 10Reading-Web-Local-Wiki-Issues: There is desktop Main page shown on mobile - https://phabricator.wikimedia.org/T209211 (10Dvorapa) I think I know what caused this problem. I already reverted the wrong edit on translatewiki and I need to update the Czech translati... [00:21:08] (03CR) 10jerkins-bot: [V: 04-1] Special:MergeHistory: Partially convert to use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/302092 (https://phabricator.wikimedia.org/T134675) (owner: 10Sethakill) [00:44:43] (03CR) 10Urbanecm: [C: 032] tracker/tests.py: Add some unittests for the notification part [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472528 (https://phabricator.wikimedia.org/T203979) (owner: 10Rafidaslam) [00:45:31] (03CR) 10jerkins-bot: [V: 04-1] tracker/tests.py: Add some unittests for the notification part [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472528 (https://phabricator.wikimedia.org/T203979) (owner: 10Rafidaslam) [00:48:41] (03CR) 10VolkerE: [C: 04-1] "PS 4 was rebased and fixed a minor MediaWiki Codesniffer issue. Comment from Bartosz above remains." [core] - 10https://gerrit.wikimedia.org/r/302092 (https://phabricator.wikimedia.org/T134675) (owner: 10Sethakill) [00:50:20] 10MediaWiki-Internationalization, 10translatewiki.net: Single edit of MediaWiki:Mainpage broke Main pages on multiple projects - https://phabricator.wikimedia.org/T209211 (10Dvorapa) [00:52:10] 10UI-Standardization: Convert Special:MergeHistory to OOUI - https://phabricator.wikimedia.org/T134675 (10Volker_E) Not to forget about when form is transformed from HTMLForm to OOUI: First button should not be a primary button, but solely a progressive one. [00:52:53] 10UI-Standardization: Convert Special:MergeHistory to OOUI - https://phabricator.wikimedia.org/T134675 (10Volker_E) [01:08:04] Hello o/ [01:11:41] (03PS1) 10VolkerE: Special:Log: Use OOUI [core] - 10https://gerrit.wikimedia.org/r/472862 (https://phabricator.wikimedia.org/T117737) [01:16:18] 10MediaWiki-Logging, 10UI-Standardization, 10MW-1.32-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-notice: Convert Special:Log to OOUI - https://phabricator.wikimedia.org/T117737 (10Volker_E) [01:19:52] 10MediaWiki-Internationalization, 10translatewiki.net, 10Security: Single edit of MediaWiki:Mainpage broke Main pages on multiple projects - https://phabricator.wikimedia.org/T209211 (10Jdlrobson) [01:20:54] 10MediaWiki-Watchlist, 10UI-Standardization, 10Front-end-Standards-Group, 10Growth-Team, and 2 others: Convert old Special:Watchlist to OOUI (HTMLForm?) - https://phabricator.wikimedia.org/T99256 (10Volker_E) p:05Normal>03Lowest Similar to T117740, with T157642: Graduate New Filters UX out of beta on R... [01:25:10] 10MediaWiki-General-or-Unknown: Interwiki redirection should preserve request string - https://phabricator.wikimedia.org/T12093 (10Quiddity) 05declined>03Resolved >>! In T12093#155755, @TTO wrote: > This works now! Yay. Changing status from Declined to Resolved, per above. :) [02:43:25] (03PS10) 10VolkerE: Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [02:52:40] 10Google-Code-in-2018, 10MediaWiki-extensions-OAuthAuthentication, 10Test-Coverage, 10User-Zoranzoki21: OAuthAuthentication extension is missing @covers tags - https://phabricator.wikimedia.org/T195151 (10Zoranzoki21) a:03Zoranzoki21 [02:53:10] (03PS1) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [02:54:34] (03PS2) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [02:56:56] (03CR) 10jerkins-bot: [V: 04-1] Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [02:58:23] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:01:18] (03CR) 10Legoktm: [C: 04-1] "See inline comments. Also you need to indent the comments at the same level as other doc blocks." (034 comments) [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:05:37] (03PS3) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:06:30] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:07:43] (03PS4) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:11:32] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:18:19] (03PS11) 10VolkerE: Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [03:19:40] (03PS5) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:23:37] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:24:10] (03PS12) 10VolkerE: Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [03:25:04] (03CR) 10VolkerE: [C: 04-1] "For a moment before rebasing, it worked. Tsk." [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [03:25:42] (03PS6) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:29:38] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:33:07] (03PS7) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:36:59] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:39:12] (03CR) 10jerkins-bot: [V: 04-1] Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [03:52:45] (03PS8) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [03:56:32] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [03:59:15] (03PS9) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [04:03:10] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [04:08:00] Hi, I need help with https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/OAuthAuthentication/+/472865/ [04:10:21] Zoranzoki21: sup? what do you need help with? [04:12:33] 10MediaWiki-extensions-FlaggedRevs, 10Wikimedia-Site-requests, 10Patch-For-Review, 10User-Tgr: Switch FlaggedRevs on Hungarian Wikipedia to a "flagged protection" mode - https://phabricator.wikimedia.org/T121995 (10Tgr) Filed {T209224} for looking into what impact the change had. [04:14:42] shrezasminocha: With making it works [04:15:17] the test failures? [04:15:44] yes [04:16:34] apparently instead of '', you are outputting 'MediaWiki\Extensions\OAuthAuthentication\OAuthAuthConfigTest::testGetDefaultConfig: Trying to @cover or @use not existing method "Config::getDefaultConfig".'. i'm not fully surek, but that seems to be the case [04:18:08] also, are you calling User::setPassword in OAuthAuthDBTest.php at line 23? [04:18:43] apparently that's deprecated [04:19:37] but look at the other three failures first i think [04:19:59] because you don't seem to be adding anything that'll call User::setpassword [04:21:43] Hello shreyasminocha, Zoranzoki21! [04:21:52] hi Ebe123 [04:22:02] Zoranzoki21: might want to check https://stackoverflow.com/questions/27605392/phpunit-trying-to-cover-or-use-not-existing-method [04:23:10] d3r1ck: hi, btw did you have a look at my comments on phab? [04:33:20] Zoranzoki21: Perhaps you want to fix the comment's indentation first like legoktm said :) Regarding to the failures, especially for the usage of the deprecated method, I think it's not related to your patch [04:33:59] and hello shreyasminocha Ebe123 Zoranzoki21 o/ [04:35:50] Zoranzoki21: perhaps you wanna create a phab ticket about the usage of deprecated method on OAuthAuthentication if there isn't any [04:36:15] I think some of those failures are the result of Zoranzoki21's patch [04:37:20] I'm guessing maybe due to namespace issues [04:37:49] err maybe not, the test wouldn't work at all if it was work namespace [04:37:58] Yes, I guess the wrong indentation makes phpcs confused, but haven't looked deeper anyway [04:38:18] I agree, that first things first, Zoranzoki21 should probably address legoktm's comments [04:38:35] which i think will fix some of the test failures anyways, and then once that's done figure out what's with the failure [04:40:30] agreed [04:41:43] i assumed they had fixed those already [04:45:48] shreyasminocha: me too [05:43:39] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Bawolff) >>! In T209217#4737220, @Aklapper wrote: > Proposing to decline this task: Users would get no toolbar at all without the WikiEditor extension, but if users don't have the Wik... [06:43:46] 10MobileFrontend, 10Reading-Web-Third-Party-Support, 10Readers-Web-Backlog (Tracking): MobileFrontend breaks MediaWiki 1.31 - https://phabricator.wikimedia.org/T208669 (10alex-mashin) [06:44:51] 10MediaWiki-Page-deletion: Add paging to Special:Undelete title prefix search - https://phabricator.wikimedia.org/T110989 (10Liuxinyu970226) [06:59:58] 10MobileFrontend, 10Reading-Web-Third-Party-Support, 10Readers-Web-Backlog (Tracking): MobileFrontend breaks MediaWiki 1.31 - https://phabricator.wikimedia.org/T208669 (10alex-mashin) 05Open>03Invalid [07:24:38] :( [08:10:13] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10Legoktm) 05declined>03Open I think declining this is pretty premature. This has been proposed in other places like https://www.mediawiki.org/wiki/Suggestions_for_extensions_to_be_... [08:11:08] uouh [08:11:11] hello [08:26:59] 10MediaWiki-API, 10Wikidata, 10Wikimedia-Site-requests: [Task] Investigation: how to handle the rename of a site id in Wikidata - https://phabricator.wikimedia.org/T112647 (10Liuxinyu970226) Dear all: Maybe there's a good news for this problem: T209089 I wonder if this extension can be integrated with our W... [08:33:19] 10MediaWiki-API, 10Wikidata, 10Wikimedia-Site-requests: [Bug] Querying Wikipedia for langlinks doesn't work for be-tarask, but works for be-x-old - https://phabricator.wikimedia.org/T112426 (10Liuxinyu970226) Maybe a good news for us, or maybe not here: T209089, which although looks literary like fixing side... [09:08:43] 10Wikimedia-Site-requests, 10I18n, 10Tracking: [DO NOT USE] Wikis waiting to be renamed (tracking) [superseded by #Wiki-Setup (Rename)] - https://phabricator.wikimedia.org/T21986 (10Liuxinyu970226) [09:33:18] 10Bouquet: Provide mobile version of Bouquet skin - https://phabricator.wikimedia.org/T208835 (10Giby) Actually, I feel the better start would be to propose to hide the sidebar when users are using a smart phone. Would that be easy to code? [09:39:05] (03CR) 10D3r1ck01: "Thanks for the reviews @Volker :)" (039 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [09:39:40] (03PS10) 10D3r1ck01: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 [09:43:57] (03CR) 10D3r1ck01: "This change is ready for review." [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [09:48:09] 10Lingua Libre: Record Wizard is broken - https://phabricator.wikimedia.org/T209225 (10Pamputt) [11:34:50] 10MediaWiki-extensions-WikimediaIncubator, 10Repository-Ownership-Requests: Requesting +2 for Hydriz on WikimediaIncubator - https://phabricator.wikimedia.org/T209227 (10Hydriz) [11:56:57] 10MediaWiki-API, 10Internet-Archive: Action api should reject requests with unsupported http methods with a 405 - https://phabricator.wikimedia.org/T209228 (10Bawolff) [11:59:13] 10MediaWiki-API, 10Internet-Archive: Action api should reject requests with unsupported http methods with a 405 - https://phabricator.wikimedia.org/T209228 (10Bawolff) [12:24:28] (03CR) 10Mainframe98: Convert Special:AllMessages to use OOUI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [12:26:34] 10Wikimedia-SVG-rendering, 10Upstream: CSS class are not inherited to child text/tspan elements in SVG (not general) - https://phabricator.wikimedia.org/T68551 (10Liuxinyu970226) [12:29:12] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10MW-1.32-release: Expand the set of bundled skins - https://phabricator.wikimedia.org/T194266 (10MGChecker) [12:29:19] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10Epic: Expand the set of bundled extensions to achieve a default MediaWiki experience that's comparable to Wikimedia sites - https://phabricator.wikimedia.org/T178349 (10MGChecker) [12:29:21] 10MediaWiki-Installer, 10MediaWiki-Releasing, 10Growth-Team, 10Epic, 10MW-1.32-release: Expand the set of bundled extensions and skins in MediaWiki 1.32 - https://phabricator.wikimedia.org/T196650 (10MGChecker) 05Resolved>03declined No extension has been added to MW 1.32, so resolving this seems wron... [12:37:04] 10TimedMediaHandler: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found - https://phabricator.wikimedia.org/T208643 (10Aklapper) 05Resolved>03declined No code change was committed, hence closing as declined. [12:37:07] 10MediaWiki-extensions-ExternalData: ExternalData doesn't load if $wgDevelopmentWarnings = true or MW version is 1.29 - https://phabricator.wikimedia.org/T208335 (10Aklapper) 05Resolved>03declined No code change was committed, hence closing as declined. [12:39:11] 10Wikimedia-SVG-rendering, 10Upstream: CSS class are not inherited to child text/tspan elements in SVG (not general) - https://phabricator.wikimedia.org/T68551 (10JoKalliauer) [12:40:43] 10Wikimedia-SVG-rendering, 10Upstream: CSS class are not inherited to child text/tspan elements in SVG (not general) - https://phabricator.wikimedia.org/T68551 (10JoKalliauer) [12:45:14] 04(no projects): LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [12:56:49] 04(no projects): LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [13:01:31] 04(no projects): LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10jeblad) [13:03:12] 10Google-Code-in-2018, 10MediaWiki-extensions-Scribunto: Add a unit test to Scribunto testing it is not vulnerable to CVE-2014-5461 - https://phabricator.wikimedia.org/T209232 (10Bawolff) [13:21:41] 04(no projects): LangCodeOverride: Extension to override language codes in the sidebar - https://phabricator.wikimedia.org/T209089 (10Nikerabbit) [13:31:10] 10I18n, 10InternetArchiveBot (v2.0): IABot Management Interface shows incomplete translation warning even though all messages are translated - https://phabricator.wikimedia.org/T196705 (10Nikerabbit) [13:33:38] 10wikimedia-page-library: Add wikimedia-page-library to translatewiki.net - https://phabricator.wikimedia.org/T163830 (10Nikerabbit) [13:39:26] (03PS10) 10Zoranzoki21: Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) [13:43:23] (03CR) 10jerkins-bot: [V: 04-1] Add missing @covers tags [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472865 (https://phabricator.wikimedia.org/T195151) (owner: 10Zoranzoki21) [13:52:49] 10MediaWiki-extensions-OAuthAuthentication: Use of User::setPassword was deprecated in MediaWiki 1.27. - https://phabricator.wikimedia.org/T209234 (10Zoranzoki21) [13:54:24] (03CR) 10Urbanecm: [C: 04-1] Split preferences from TrackerProfile (031 comment) [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472777 (https://phabricator.wikimedia.org/T208680) (owner: 10Arcayn) [13:58:25] Hi, I trying to work on (T100016) [13:58:25] T100016: Some system messages missing - https://phabricator.wikimedia.org/T100016 [13:58:45] And I no know what is correct message [13:59:05] oh [13:59:07] hello [13:59:54] 04(no projects): Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Pavanaja) [14:00:17] Should it be The target subpage is invalid. [14:01:32] d3r1ck: jdlrobson: Could you please review my Gerrit patch? https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/472701 [14:06:43] 04(no projects): Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10BHARATHESHAALASANDEMAJALU) Its need of Tulu Wikipedia [14:07:24] (03PS1) 10Zoranzoki21: Add message oauthauth-invalid-subpage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472872 (https://phabricator.wikimedia.org/T100016) [14:09:18] (03CR) 10Framawiki: Convert Loops to use extension registration (031 comment) [extensions/Loops] - 10https://gerrit.wikimedia.org/r/425913 (https://phabricator.wikimedia.org/T192113) (owner: 10Zoranzoki21) [14:10:24] (03PS43) 10Zoranzoki21: Convert Loops to use extension registration [extensions/Loops] - 10https://gerrit.wikimedia.org/r/425913 (https://phabricator.wikimedia.org/T192113) [14:10:43] (03CR) 10Zoranzoki21: Convert Loops to use extension registration (031 comment) [extensions/Loops] - 10https://gerrit.wikimedia.org/r/425913 (https://phabricator.wikimedia.org/T192113) (owner: 10Zoranzoki21) [14:11:18] (03CR) 10jerkins-bot: [V: 04-1] Add message oauthauth-invalid-subpage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472872 (https://phabricator.wikimedia.org/T100016) (owner: 10Zoranzoki21) [14:12:15] (03CR) 10Nikerabbit: "Perhaps you could split these big commits to smaller ones in the future? They are quite tiresome to review." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/472734 (owner: 10Umherirrender) [14:12:32] d3r1ck, please let me know how to proceed with T205600. thanks! [14:12:33] T205600: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 [14:12:50] (03PS2) 10Zoranzoki21: Add message oauthauth-invalid-subpage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472872 (https://phabricator.wikimedia.org/T100016) [14:14:58] Zoranzoki21: did you eventually manage to fix that issue? [14:15:51] (03PS1) 10LukBukkit: Use a textbox for the summary on the announce page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) [14:16:50] (03CR) 10jerkins-bot: [V: 04-1] Add message oauthauth-invalid-subpage [extensions/OAuthAuthentication] - 10https://gerrit.wikimedia.org/r/472872 (https://phabricator.wikimedia.org/T100016) (owner: 10Zoranzoki21) [14:17:34] shreyasminocha: For message or covers tags? [14:17:50] cover tags [14:18:40] (03PS1) 10Urbanecm: Allow users to not request any badge at all [wikimedia-cz/events] - 10https://gerrit.wikimedia.org/r/472874 [14:19:18] (03CR) 10Urbanecm: [C: 032] Allow users to not request any badge at all [wikimedia-cz/events] - 10https://gerrit.wikimedia.org/r/472874 (owner: 10Urbanecm) [14:19:25] hi shreyasminocha and Zoranzoki21, nice to see you again :) [14:19:32] shreyasminocha: no [14:19:35] (03Merged) 10jenkins-bot: Allow users to not request any badge at all [wikimedia-cz/events] - 10https://gerrit.wikimedia.org/r/472874 (owner: 10Urbanecm) [14:19:36] Urbanecm: tnx. Too! [14:19:36] hi Urbanecm! [14:20:45] 10Outreach-Programs-Projects: Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Framawiki) [14:22:55] 10Outreach-Programs-Projects: Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Aklapper) Please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and provide steps *where* to add it [14:23:27] I never had met "Segmentation fault" in Python code... [14:23:30] until now [14:23:46] wth?! [14:24:12] 10Outreach-Programs-Projects: Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Zoranzoki21) Hi, do you think on translations? [14:24:39] 10MediaWiki-extensions-OAuthAuthentication, 10Technical-Debt: Use of User::setPassword was deprecated in MediaWiki 1.27. - https://phabricator.wikimedia.org/T209234 (10Aklapper) [14:25:33] Urbanecm: how? where? why? [14:25:40] 10Outreach-Programs-Projects: Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Pavanaja) >>! In T209235#4738012, @Zoranzoki21 wrote: > Hi, do you think on translations? No. The list of languages in the drop-down list of languages does not have Tulu (tcy) as of now. I am request... [14:25:57] shreyasminocha, I got https://en.wikipedia.org/wiki/Segmentation_fault in Python, by calling this piece of code https://github.com/wikimedia/wikimedia-cz-events/blob/master/src/app.py#L240-L275 [14:26:37] and why - that's what I'm trying to figure out [14:26:53] i was surprised that python too has segfaults [14:27:01] me too [14:27:56] 10Outreach-Programs-Projects: Add Tulu (tcy) to Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Zoranzoki21) >>! In T209235#4738015, @Pavanaja wrote: >>>! In T209235#4738012, @Zoranzoki21 wrote: >> Hi, do you think on translations? > > No. The list of languages in the drop-down list of language... [14:27:56] "This happens when a python extension (written in C) tries to access a memory beyond reach." [14:28:19] that makes it a bit more plausible [14:29:02] I'm not lying shreyasminocha, https://ctrlv.cz/Zn31 [14:29:17] i trust you heh [14:29:31] i looked up "python segfaults" and found what i quoted above [14:30:11] yeah, it cannot happen in environment that doesn't allow you to control your memory [14:30:26] yeah [14:30:42] the question is: what library causes it and how to fix it? [14:31:40] 10Outreach-Programs-Projects: Offer Tulu (tcy) in the language dropdown on Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Aklapper) [14:34:33] hmm, while installing python-dev and python3-dev packages, my computer suddenly logged me out [14:35:10] o_0 [14:36:44] Ok, tried exactly same command on another machine. Works perfectly :( [14:36:56] * Urbanecm hates debugging issues he cannot reproduce [14:37:10] doesn't everyone :) [14:38:24] 10Outreach-Programs-Projects: Offer Tulu (tcy) in the language dropdown on Outreachdashboard - https://phabricator.wikimedia.org/T209235 (10Pavanaja) >>! In T209235#4738015, @Pavanaja wrote: >>>! In T209235#4738012, @Zoranzoki21 wrote: >> Hi, do you think on translations? > > No. The list of languages in the dr... [14:38:28] I suppose so. [14:38:37] another issue I cannot reproduce is https://gerrit.wikimedia.org/r/c/wikimedia-cz/tracker/+/472528 [14:38:43] (03Abandoned) 10Aklapper: Success [core] - 10https://gerrit.wikimedia.org/r/471712 (owner: 10Anandh18500) [14:38:48] as you can see, test build succeeded many times [14:38:51] so I merged the patch [14:38:55] (gave +2 to it) [14:39:00] and test build failed [14:39:05] with no change to the code itself [14:39:59] ehhh [14:40:07] what's this black magic [14:41:20] (03Abandoned) 10Aklapper: T207783 is fixed [core] - 10https://gerrit.wikimedia.org/r/472648 (owner: 10Nithin999) [14:41:48] I'd like to know :) [14:41:57] some silly mistake I suppose [14:42:06] hard to debug bugs are ALWAYS caused by silly causes [14:42:38] (03CR) 10Aklapper: "Hi mustaqmustu and thanks for your patch!" [core] - 10https://gerrit.wikimedia.org/r/472757 (owner: 10Mustaq Ahammad) [14:42:39] apparently you're getting a 403 when it was expected a 302. some error in auth maybe? [14:43:41] yeah, but interesting is that no such test fails are given outside this patch (I tried approx. 10 rechecks on patch changing just README) and that the test doesn't fail everytime [14:44:03] :/ [14:45:05] uh [14:49:02] Urbanecm: here's a diff of the console outputs if it helps debug things: https://pastebin.com/tGiZ5cUT. let me know what the issue was when you do figure it out! [14:49:19] hey guys :)\ [14:49:33] hi bjornskjald [14:49:38] hi bjornskjald [14:49:47] long time no see [14:50:07] btw, shreyasminocha, there's another strange thing on this. I tried to add some print() commands to debug this. Guess what - no fail. Once I removed it, tests failed. WHY? [14:50:14] yeah, i was quite busy [14:50:25] have anyone seen Ebe123? [14:51:04] bjornskjald: saw her earlier today [14:51:04] @seen Ebe123 [14:51:04] Urbanecm: Last time I saw Ebe123 they were quitting the network with reason: no reason was given N/A at 11/11/2018 5:51:28 AM (8h59m36s ago) [14:51:10] Urbanecm: weird [14:51:26] shreyasminocha, isn't he a guy? [14:51:28] lol [14:51:52] the name is "Etienne". i'm almost sure they're female. shouldn't have assumed :( [14:52:21] i have no idea too [14:52:31] but it's a french name and there can be different rules [14:52:34] Urbanecm: something like that happened to me once. turns out, it was because of regex using the position of the last find. this is probably unrelated though. [14:52:35] https://www.french-future.org/fr/etienne-beaule/ [14:52:48] if that's him, he looks like a guy [14:52:58] shreyasminocha, https://en.wikipedia.org/wiki/%C3%89tienne_B%C3%A9zout and many others ;) [14:53:01] shit. apparently it's a guy's name. sorry ebernhardson [14:53:09] oops [14:53:10] use they/them when you're not 100 % sure [14:53:15] Ebe123 [14:53:20] yeah. my bad. [14:53:26] "Étienne, a French equivalent of Stephen/Steven" [14:53:31] and sorry ebernhardson for accidentally pinging you. [14:53:37] same page I was reading bjornskjald :) [14:53:50] one mystery solved i guess [14:53:52] 10Lingua Libre: Record Wizard is broken - https://phabricator.wikimedia.org/T209225 (100x010C) 05Open>03Resolved Thanks for the report. The deploy script failed (silently...) to install the Wikibase sub-modules during the migration from Mediawiki 1.30 to Mediawiki 1.31. I fixed it manually (you can load the... [14:54:24] In English, I can write with people without knowing anything about them, including their gender [14:55:03] In Czech, that's not possible, as many verbs have different forms based on gender [14:55:51] Hindi is similar to English in this regard [14:57:01] at least you don't have those gender-related problems when speaking about people you know from written-English word :) [14:59:27] I shouldn't write code on Sundays. Got the script to work without segfaults on my local machine. Issued command to generate attendee list based on registration form and...in the resulting PDF, there is a lot of names that aren't in the registration form _at all_. [15:00:00] but presumably, Sundays don't have to do anything with this... [15:00:09] :) perhaps [15:01:06] 10Language-strategy, 10Wikimedia-General-or-Unknown, 10Category, 10Community-Tech (2015-2017), and 3 others: Central Global Repository for Templates, Lua modules, and Gadgets - https://phabricator.wikimedia.org/T121470 (10Yurik) I added bot approach to the wish list -- https://meta.wikimedia.org/wiki/Commu... [15:03:29] I got the cause... The code uses cloud service to generate the attendee list based on docx template. Each page is converted separately and then special job "concat pdfs" is issued, that downloads the pdfs from WMCZ's server [15:03:37] and yes, running my code on other machine than WMCZ's server doesn't work [15:03:48] and on WMCZ's server it causes segfault [15:04:27] oh [15:05:20] "on other machine than WMCZ's server doesn't work" do you mean it does work? [15:07:12] WMCZ's server (the "server") serves events.wikimedia.cz. On this domain there's a directory pdfs mapped to /var/www/events.wikimedia.cz/deploy/pdfs. To this directory the temporary files (one for each page) are stored to this directory and then the concat pdfs jo is called and given URLs to those temp files [15:07:45] So when I run it on my notebook, files are stored to /var/www/events.wikimedia.cz/deploy/pdfs, but the cloud service doesn't have access to those files [15:07:50] and downloads old files [15:11:27] oh i see [15:11:50] :D at least you got it figured 🍻 [15:13:20] anyone here knows lilypond? [15:21:56] 10MediaWiki-Parser: Parser fails to parse file link (with link parameter) - https://phabricator.wikimedia.org/T209236 (10Herzi.Pinki) [15:22:19] 10MediaWiki-Parser: Parser fails to parse file link (with link parameter) - https://phabricator.wikimedia.org/T209236 (10Herzi.Pinki) [15:22:40] nvm, got it fixed [15:22:47] 10MediaWiki-Parser: Parser fails to parse file link (with link parameter) - https://phabricator.wikimedia.org/T209236 (10Herzi.Pinki) [15:23:36] 10MediaWiki-Parser: Parser fails to parse file link (with link parameter) - https://phabricator.wikimedia.org/T209236 (10Herzi.Pinki) [15:38:11] 10MediaWiki-extensions-OAuthAuthentication, 10Technical-Debt (Deprecation): Use of User::setPassword was deprecated in MediaWiki 1.27. - https://phabricator.wikimedia.org/T209234 (10Izno) [15:38:37] 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Backlog (Later), 10Technical-Debt (Deprecation): Deprecate Title::moveTo - https://phabricator.wikimedia.org/T208775 (10Izno) [15:44:11] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) @takidelfin the display is correct on mobile but it should look like this on tablet and desktop (>=72... [15:52:57] 10MediaWiki-ResourceLoader, 10Performance-Team, 10JavaScript, 10Proposal, and 2 others: RFC: Modernise our JavaScript with the goal that mediawiki global object should not depend on jQuery - https://phabricator.wikimedia.org/T200868 (10Esanders) It is also possible to migrate to ES6 promises while maintain... [15:55:24] :D [15:55:29] hello everyone! [15:59:31] Does anyone know d3r1ck's timezone? or jdlrobson's timezone? [16:00:42] d3r1ck timezone i think is either +0 or +1 (some where at least anyhithing 0+) [16:00:56] and jdlrobson is ones of the american timezones. (i think) [16:05:10] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Gopavasanth) @Shreyasminocha There are few minor things encountered after testing your patch, **Before testing: ** {F27185727} *... [16:05:58] (03CR) 10Gopavasanth: "Please follow my comments here https://phabricator.wikimedia.org/T205600#4738062" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/472788 (https://phabricator.wikimedia.org/T205600) (owner: 10Shreyasminocha) [16:07:53] Gopa: i'm assuming purgecache is some extension? [16:09:03] takidelfin_: if "signon" from /whois d3r1ck is the time in their tz, d3r1ck has "Thu Nov 8 07:23:45 2018" [16:10:33] shreyasminocha: It's not extension see https://www.mediawiki.org/wiki/Manual:Purge [16:13:38] 10InternetArchiveBot, 10Community-Wishlist-Survey-2016: Checking dead links on all projects - https://phabricator.wikimedia.org/T157273 (10Bencemac) @Cyberpower678 Can we say that this is resolved by IABot and close it? [16:13:56] takidelf-: Hello d3r1ck time zone is UTC +1:00, you can also find it over here https://www.mediawiki.org/wiki/Google_Code-in/2018 [16:14:13] Gopa: i don't see the "purge cache" option [16:15:13] shreyasminocha: Umm [16:16:00] (03CR) 1001tonythomas: Use a textbox for the summary on the announce page (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) (owner: 10LukBukkit) [16:16:19] umm [16:16:48] paladox, thanks :D [16:16:56] your welcome :) [16:25:36] (03CR) 10Takidelfin: "Could you please review my latest patch? I have also uploaded screenshots on phabricator issue." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [16:25:50] ;-; [16:31:10] because it is blocking me in GCI :/ [16:54:42] 10MediaWiki-Page-editing, 10WikiEditor: Merge WikiEditor into the MediaWiki Core - https://phabricator.wikimedia.org/T209217 (10stjn) >>! In T209217#4737560, @Legoktm wrote: > What problems exactly? My understanding is that the "classic toolbar" was removed for maintenance reasons. Given that we have to mainta... [16:57:41] 10MediaWiki-extensions-Lockdown, 10Patch-For-Review, 10User-MarcoAurelio: Lockdown.php is missing - https://phabricator.wikimedia.org/T206806 (10Cyber1000) Sorry for my late reply, I didn't know about the "extension registration", I just wanted to use the plugin in my docker-container without too much readin... [17:18:08] (03PS5) 10Arcayn: Split preferences from TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472777 (https://phabricator.wikimedia.org/T208680) [17:28:26] Gopa, shreyasminocha: are you sure the purge cache button what is misbehaving per the task (T205600) comes from MediaWiki? [17:28:27] T205600: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 [17:28:36] on enwiki, it's available as a gadget [17:32:55] Urbanecm: Oo can you send me any link if possible? [17:33:23] Gopa, sure. [17:33:31] https://martin.urbanec.cz/files/devwiki/index.php/Hlavn%C3%AD_str%C3%A1nka is my devwiki supporting Refreshed [17:33:58] and I cannot find anything like "Purge cache" button [17:35:00] (feel free to create an account if you want to) [17:35:01] Urbanecm: Umm wondering [17:35:07] me too [17:35:14] where did you test the patch? [17:35:32] Urbanecm: In my localsystem. [17:35:42] Urbanecm: with Refreshed skin installed [17:35:46] can you share MW version and Refreshed version please? [17:36:06] sure [17:36:52] as you can learn on Special:Version, c678fea is MW core and a6a2778 is Refreshed [17:37:24] MediaWiki 1.32.0-alpha (11e1ed9), Refreshed 3.4.2 (0db1b9e) [17:37:44] thx [17:38:44] Gopa, if you append ?safemode=1 to URL, do you still see the purge button? [17:39:01] * Gopa checking [17:39:50] Urbanecm: Yea, I am still seeing purge button. [17:40:22] Gopa, strange... Do you have any extensions enabled? [17:40:34] Urbanecm: nope [17:40:37] i am on mediawiki 1.33.0-alpha and refreshed 3.4.2 [17:40:48] no button [17:40:59] Urbanecm: Did you tested the patch ? [17:41:48] Gopa, I'm firstly trying to understand the issue [17:42:04] your screenshots on https://phabricator.wikimedia.org/T205600#4738062 contains links I don't see [17:43:15] 04(no projects): Mix-'n'-match-esque tool/game for editors to add secondary sources as references to Wikidata items, based on snippets from the sources and/or from their use in Wikipedia articles - https://phabricator.wikimedia.org/T209239 (10Jc86035) [17:43:31] * Urbanecm switched the wiki to shreyasminocha's patch [17:43:35] I' just wondering about Let me try [17:44:13] Gopa, I tested the patch and it does what it is supposed to do [17:44:15] 04(no projects): Mix-'n'-match-esque tool/game for editors to add secondary sources as references to Wikidata items, based on snippets from the sources and/or from their use in Wikipedia articles - https://phabricator.wikimedia.org/T209239 (10Jc86035) [17:44:38] (meaning the text isn't overlaping) [17:44:48] I cannot test Short URL nor purge cache, as I don't see the btns [17:44:52] and the CSS space? [17:45:08] Short URL is an mediawiki extension [17:45:22] so you _have_ enabled Short URL extension? [17:45:28] Gopa, strange... Do you have any extensions enabled? [17:45:28] Urbanecm: nope [17:45:31] (03PS13) 10VolkerE: Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [17:45:45] ^^^ from this I supposed you don't have any extensions enabled ^^^ [17:46:15] check this https://www.mediawiki.org/wiki/Extension:ShortUrl [17:46:27] (03CR) 10VolkerE: [C: 04-1] "@Mainframe98 Yes, late night mistake. Re-introduced in PS12. Thanks!" [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [17:46:34] (03CR) 10VolkerE: [C: 04-1] "*PS 13" [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [17:46:42] Urbanecm: Yes I have enabled short URL extensions [17:46:46] ok, will enable it as well [17:46:58] Urbanecm: Sure [17:48:39] Gopa, Short URL link is aligned correctly [17:48:47] 10MediaWiki-Page-protection, 10Wikidata: Protection of classes of Wikidata items based on attributes of their statements - https://phabricator.wikimedia.org/T209243 (10Jc86035) [17:49:14] Urbanecm: Yea after this patch. [17:49:18] yes [17:49:35] You can verify it on https://martin.urbanec.cz/files/devwiki/index.php/Test_page ofc [17:50:10] but still, I'm wondering where the Purge cache btn comes from [17:51:32] Yeah I'm out of ideas in this case. [17:52:15] Urbanecm: Okay if you are sure you can approve GCI task. [17:53:32] Urbanecm: https://codein.withgoogle.com/dashboard/task-instances/6551207976894464/ [17:53:51] hello! [17:54:09] thank you Gopa, I'll try to get the origin of Purge cache button firstly if you don't mind :) [17:54:25] what happened here? \( ͡° ͜ʖ ͡°)/ [17:54:25] can you append ?uselang=qqx to your URL and screenshot the menu for me? [17:54:28] hi takidelfin [17:54:46] Urbanecm: sure [17:55:16] hi takidelfin [17:55:43] Uh, you are testing something? How can I help? [17:56:41] yeah, we're testing https://phabricator.wikimedia.org/T205600 [17:56:44] Urbanecm: https://ibb.co/iOuniV [17:56:51] because my computer is 99% black magic and, then maybe it will show something that can help you :D [17:56:59] oops [17:56:59] Urbanecm and i don't see the "purge cache" button mentioned by Gopa in his last comment [17:57:02] :D [17:58:00] thank you Gopa [17:58:07] takidelfin: could you try my patch with Gopa's versions of mediawiki and refreshed and shorturl? [17:58:55] 'Gopa's versions of MediaWiki' where can I find it? [17:59:17] I think it isn't necessary [17:59:23] Gopa, do you have Cargo extension enabled? [17:59:24] takidelfin: You can find in Special:Version [17:59:36] Gopa, takidelfin asked about _your_ version [17:59:36] takidelfin he mentioned it some comments back [17:59:44] MediaWiki 1.32.0-alpha (11e1ed9), Refreshed 3.4.2 (0db1b9e) [18:00:06] Urbanecm: Uhh yes [18:00:06] takidelfin: to be more specific, do you see the "purge cache" button? [18:00:20] Gopa, can you please try to disable it temporarily and let me know if you still see the btn? [18:00:35] Urbanecm: sure [18:00:38] shreyasminocha: I'm pulling mediawiki 1.32 [18:00:48] because i'm on 1.33 [18:01:02] cool [18:01:06] even i'm on 1.33 [18:01:56] Urbanecm: Ooh ya Got it got disabled. [18:02:02] nice [18:02:06] 10Reading-Admin: Follow up with Aaron about Reading patterns - https://phabricator.wikimedia.org/T105974 (10Tbayer) Context: https://meta.wikimedia.org/wiki/Research:Directed_diabetes_info-seeking_behavior_in_Wikipedia [18:02:12] shreyasminocha, takidelfin: We have the source of the button [18:02:15] It's extension called "Cargo" [18:02:28] cool. let me try [18:02:40] how did you just guess it though Urbanecm? [18:03:10] Urbanecm: ^_^ [18:03:45] and .... I need to fix my mediawiki first [18:03:53] as always D: [18:04:02] Gopa, Urbanecm: i feel that any extension that adds buttons to that menu will have its buttons broken. we can merge my patch as a hotfix, but we need to come up with a longterm solution... [18:04:09] takidelfin: can relate :D [18:04:35] 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10Notifications, 10Patch-For-Review: Echo should provide notifications about your revision being approved or rejected on wikis with FlaggedRevs enabled - https://phabricator.wikimedia.org/T54510 (10Tbayer) I [[https://meta.wikimedia.org/wiki/Community_Wish... [18:06:37] Urbanecm: wait also did you notice any changes in the left margin I mean space between the icons and the buttons after this patch ? as I mentioned https://phabricator.wikimedia.org/T205600#4738062? [18:08:11] i hard resetted my version of my patch and git review -d isn't working, so i can't upload screenshots of my own [18:09:50] You can also download your patch from gerrit and send. [18:10:32] shreyasminocha: :D I had the same problem yesterday [18:11:12] takidelfin: we keep having the same problems :D [18:11:12] I had to delete my branch, pull it from Gerrit, and then it worked [18:11:21] *my local branch of course [18:12:08] Gopa: how can i pull my patch directly from gerrit? [18:12:09] shreyasminocha, you mean how I knew it's cargo? [18:12:13] yep [18:12:27] uselang=qqx displays "message codes" instead of messages [18:12:41] in i18n directory of all MW extensions there are JSON files with messages [18:12:46] and each message has one message code [18:13:07] and the purge button msg code was starting with cargo- [18:13:08] brb [18:13:30] oh okay [18:13:41] shreyasminocha: git pull ssh://@gerrit.wikimedia.org:29418/mediawiki/skins/Refreshed refs/changes/88/472788/3 [18:14:13] thanks [18:14:38] Gopa Vasanth Urbanecm: wait also did you notice any changes in the left margin I mean space between the icons and the buttons after this patch ? as I mentioned https://phabricator.wikimedia.org/T205600#4738062? [18:16:43] shreyasminocha: you can see "cargo" in this https://ibb.co/iOuniV image beside "purge cache" [18:17:50] takidelfin: i think i know why we were getting the errors: we had pulled after resetting [18:17:59] and git review couldn't rebase [18:18:23] shreyasminocha: actually I was pulling mediawiki rel1_32 :D [18:18:36] shreyasminocha: what errors? [18:18:45] git review -d is giving me errors [18:19:04] https://pastebin.com/Mt5s66Cn [18:20:30] shreyasminocha: did u clone u r patch ? [18:20:58] nah, for it was trying to push a commit to someones else patch. And then git review was rejected [18:21:42] o/ [18:21:46] shreyasminocha: So you must update your git remote first [18:21:54] ohk maybe that's why [18:21:57] hi d3r1ck [18:22:03] Hello d3r1ck [18:22:09] hello d3r1ck! [18:22:22] Hey! Did I miss the party? [18:22:49] black magic [18:22:50] I'm back [18:22:56] only [18:23:06] Urbanecm: cool [18:23:44] Gopa, I see https://ctrlv.cz/y7gp [18:23:51] d3r1ck: you didn't miss much :D [18:24:06] d3r1ck: jdlrobson Could you please review my task? https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/472701 [18:24:16] takidelfin: let me have a look! [18:24:31] Gopa, do you see anything unusual on my screenshot? [18:24:39] takidelfin, what do you call with black magic? [18:25:51] my computer and mediawiki versions [18:26:03] :) [18:26:06] Gopa: i see https://imgur.com/a/JcGNAkA. i think it's the same as Urbanecm's [18:26:13] Urbanecm: Okay then shall we approve the task ? [18:26:35] let me try fixing purge cache [18:26:42] but like i mentioned earlier, it's only a hotfix [18:26:54] 23:34 < shreyasminocha> Gopa, Urbanecm: i feel that any extension that adds [18:26:57] buttons to that menu will have its buttons broken. [18:27:00] we can merge my patch as a hotfix, but we need to [18:27:03] come up with a longterm solution... [18:27:11] I have no problem with approving it, but I'll leave the final decision to you Gopa [18:27:43] up to you Gopa. i have no issue with rejection [18:27:58] :D [18:28:25] (03CR) 10Gopavasanth: [C: 031] "Works well !" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/472788 (https://phabricator.wikimedia.org/T205600) (owner: 10Shreyasminocha) [18:28:41] https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/Refreshed/+/472788/ [18:28:45] ^ ^ [18:29:03] shreyasminocha, per Gopa's review on your patch, I think you only need to submit it. Ofc, if you want to try to fix Purge cache, it's nice! [18:30:02] (03CR) 10D3r1ck01: "It works on iPad and iPad Pro simulator. From Galaxy S5 to iPhone X (Google Chrome), it breaks on small screens." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [18:30:03] shreyasminocha: You can now, "Submit for review" in GCI [18:30:41] (03CR) 10D3r1ck01: [C: 04-1] "Make sure to resize your browser to the smallest size when testing your patch." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [18:31:17] (03PS4) 10Shreyasminocha: Fix styling of "Watch"/"Unwatch" and "Short URL" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/472788 (https://phabricator.wikimedia.org/T205600) [18:31:21] takidelfin: Sorry, I made a mistake somewhere, disregard my comments for now! [18:31:27] Gopa: fixed purge cache too. [18:31:54] shreyasminocha: Good make a patch [18:31:59] done. [18:32:04] take a look and lmk [18:32:13] (03CR) 10D3r1ck01: "Disregard my previous 2 comments, made a mistake somewhere!" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [18:32:36] (03CR) 10Urbanecm: [C: 031] "WFM" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/472788 (https://phabricator.wikimedia.org/T205600) (owner: 10Shreyasminocha) [18:32:51] d3r1ck: umm, what do you mean? [18:33:27] takidelfin: Never mind, was testing on MF extension not on MN skin :( [18:33:38] :D [18:33:53] So I downloaded the patch but didn't succeed and started testing without verifying, silly me :( [18:34:05] d3r1ck: which gerrit account do you *not* use? i'll remove that one from reviewer. [18:34:20] nothing happened :D [18:34:32] d3r1ck: "silly me" is exactly what i say when i mess up :D [18:34:47] takidelfin: okay, so I've reviewed now :) [18:35:01] And it's still needs some work! [18:35:06] shreyasminocha: I think that account without 01 on the end isn't used [18:35:14] d3r1ck: Okay ;D [18:35:17] So the space has disappeared now from default view and smaller screens [18:35:20] (03CR) 10Urbanecm: [C: 032] Split preferences from TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472777 (https://phabricator.wikimedia.org/T208680) (owner: 10Arcayn) [18:35:37] takidelfin: So the task is, the space needs to be there at all times and in all screen sizes [18:35:54] What I see now is just a tiny little line [18:36:10] (03Merged) 10jenkins-bot: Split preferences from TrackerProfile [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/472777 (https://phabricator.wikimedia.org/T208680) (owner: 10Arcayn) [18:36:18] that's what wikibugs seems to suggest. d3r1ck: can i remove D3rick from reviewer on gerrit? [18:36:20] (03CR) 10Gopavasanth: [C: 031] Fix styling of "Watch"/"Unwatch" and "Short URL" [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/472788 (https://phabricator.wikimedia.org/T205600) (owner: 10Shreyasminocha) [18:37:02] ty Gopa [18:37:06] (03CR) 10D3r1ck01: [C: 04-1] "Space is not gone for all screen sizes :(. Will put screen shots on the task." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [18:37:09] shreyasminocha: Yes! [18:37:22] I don't use that account. I've never used it. [18:37:30] "D3r1ck01" is the real one :) [18:37:34] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) umm, so that padding is expected? But I did it previously D: [18:37:51] shreyasminocha: :) [18:38:00] d3r1ck: yeah saw you mention it on irc earlier today, just wasn't sure which one it was [18:38:24] d3r1ck: Now I'm completly confused [18:38:33] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10D3r1ck01) This is what I see; {F27189236} {F27189235} [18:38:41] shreyasminocha: Sorry about the confusion. :( [18:38:47] takidelfin: Calm down. [18:38:53] takidelfin: Did you read the task? [18:39:01] np! [18:39:18] d3r1ck: My previous patch version had that padding on all views [18:39:20] takidelfin: Read the expected results part in the description [18:39:36] `The whitespace below the Reading preferences tagline should always be there.` [18:39:47] Yes it did takidelfin but Jon commented about the CSS [18:40:05] oh, sorry :( [18:40:34] Did you see his comments? [18:41:21] takidelfin: https://phabricator.wikimedia.org/T202557#4736182 [18:42:59] eh, okay [18:43:11] so I need to use border :( [18:49:02] it's okay, takidelfin! shouldn't be a problem for you! [18:56:32] but I think that padding is better than border-bottom: 1px solid transparent [18:56:51] * margin [18:56:58] but idk [18:58:11] umm... [19:06:22] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) yep, there is 1 px padding :/ I really don't understand what is the expected behavior. Do you want c... [19:10:00] (03CR) 10VolkerE: [C: 032] Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:15:31] (03Merged) 10jenkins-bot: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:15:44] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) | `>=1000px` | `>=720px` | `<720px` | | -------------- | ------------- | ----------- | | {F27190778}... [19:17:37] d3r1ck: jdlrobson https://phabricator.wikimedia.org/T202557#4738176 [19:18:41] (03CR) 10jenkins-bot: Minor code refactoring in MassMessage repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/459814 (owner: 10D3r1ck01) [19:28:51] hey ;-; [19:29:04] Could you please review these screenshots? [19:29:05] 04(no projects): Editing software version identifier in Wikidata does not work - https://phabricator.wikimedia.org/T209244 (10Trilemma2) [19:29:16] please ¯\_(`-`)_/¯ [19:40:13] (03CR) 10LukBukkit: "> Patch Set 1:" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) (owner: 10LukBukkit) [19:42:59] where is everyone ;( [19:43:42] sorry for me being impatient \ol [19:53:35] 10Repository-Admins: Add Zoranzoki21 as owner in tool-zoranzoki21bot - https://phabricator.wikimedia.org/T209245 (10Zoranzoki21) [19:56:19] takidelfin: what hap? [19:58:42] I'm waiting for d3r1ck and jdlrobson look at my screenshot on phabricator :( [20:00:30] d3r1ck: So? [20:01:50] * d3r1ck is very unstable this evening, let me have a look now r054l13 [20:02:08] Ops, takidelfin [20:02:16] c: [20:02:33] Never trust autocomplete :( [20:02:46] Instead of "t" I pressed "r" and then "tab" [20:02:55] :D [20:02:58] Sorry for pinging r054l13, was meant to ping takidelfin :) [20:03:16] takidelfin: Let me have a look at your comments, got some family related stuff so I'm very unstable, sorry! [20:04:09] d3r1ck: oh, sorry for impatience. Don't worry, this task has got two mentors :D [20:04:18] takidelfin: UI based, that is what should be done, the padding should be there always :) [20:04:32] ah :D [20:04:34] Now, let me look at the code, but did you apply Jon's comments? [20:04:43] border-bottom isn't workign [20:04:50] because it behaves like padding [20:05:22] and I couldn't apply padding to left and right sides, thats why he recommended me to use border (he probably missunderstood me) [20:05:35] because i meant centering the div :D [20:05:47] @d3r1ck: [20:06:03] Let me check the code now! [20:06:45] im pushing it to change [20:06:47] takidelfin: Seems you've not updated the patch? https://gerrit.wikimedia.org/r/c/mediawiki/skins/MinervaNeue/+/472701 [20:06:53] yup [20:06:53] Ahh okay, do that, thanks :) [20:07:40] (03PS10) 10Takidelfin: Special:MobileOptions: Consistent padding of heading [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) [20:08:24] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Shreyasminocha) Urbanecm and I couldn't reproduce Gopa's first bullet point (as discussed in #wikimedia-dev) and I addressed the sec... [20:08:43] 10Google-Code-in-2018, 10Refreshed, 10CSS, 10Patch-For-Review: Improper CSS of standard-toolbox-dropdown in wiki Skin Refreshed - https://phabricator.wikimedia.org/T205600 (10Shreyasminocha) a:05Shreyasminocha>03None [20:08:46] done! [20:08:56] wait [20:09:27] yeha [20:09:33] i pushed right thing [20:10:23] Okay! [20:10:51] (03CR) 10D3r1ck01: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [20:12:10] Thanks for the updated patch takidelfin :), I'll do a review and see how it goes but jdlrobson will have better comments :) [20:12:20] Travis checks should pass, I installed node packages so now my every commit is linted :D [20:12:29] ok! [20:12:44] it must be good now ough [20:12:57] I'm working on this task 4 days or something like that [20:15:58] takidelfin: So I've just checked the patch locally, UI, it works as wanted [20:16:16] So we have to check if it now works as expected :) + code review :) [20:16:19] Yes, finally! [20:18:45] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) No. The padding is different on mobile. Mobile needs to look like: {F27192162} (>=720px) like this:... [20:20:48] jdlrobson just dropped a comment, I'm reading now, seems there is a little issue with the task from my understanding [20:21:37] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10takidelfin) umm.... but that is how it looks actually. [20:22:44] umm [20:22:46] yep [20:22:52] but it is how it does look actually [20:23:51] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10D3r1ck01) @Jdlrobson, that means the actual behavior on the task description is not a bug right? Because that is... [20:29:40] If that 'bug' is a 'bug' (hah) then I have lost 4 days on trying to repair fixed thing xd [20:30:16] But i have learnt how to fight with css (like a water ( ͡° ͜ʖ ͡°)/ ) [20:31:00] takidelfin: So it's a decision issue here atm, let's hear from jdlrobson and phuedx [20:31:58] 10MediaWiki-User-preferences, 10Math: Consider removing the options from the Math extension - https://phabricator.wikimedia.org/T166367 (10Debenben) 05Open>03declined We really need an option that covers all use-cases (especially because you have to login to get to the options) but currently we don't and t... [20:32:15] ¯\_(`-`)_/¯ [20:32:55] (03PS1) 10Raimond Spekking: Add Eastern Pwo - kjp [extensions/cldr] - 10https://gerrit.wikimedia.org/r/472878 [20:33:12] (03CR) 1001tonythomas: [C: 031] "I will approve this now. However, I will merge it a little later (adding 1 or more other reviewers). I am not sure if we want the de.json " [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) (owner: 10LukBukkit) [20:33:49] 10MediaWiki-Codesniffer, 10Patch-For-Review: Disallow use of @private and @protected using MediaWiki.Commenting.FunctionAnnotations.UnrecognizedAnnotation - https://phabricator.wikimedia.org/T203980 (10Umherirrender) 05Open>03declined [20:33:54] and the task description says that padding should be consistend :thonk: [20:36:43] (03CR) 10jerkins-bot: [V: 04-1] Use a textbox for the summary on the announce page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) (owner: 10LukBukkit) [20:48:30] jdlrobson: so? what was the purpose of this task? [20:51:08] 10MediaWiki-User-preferences, 10Math: Migrate old Math options to current ones or delete them from the database - https://phabricator.wikimedia.org/T166369 (10Debenben) [20:55:12] 10MediaWiki-User-preferences, 10VisualEditor: Rephrase "Temporarily disable the visual editor while it is in beta" in Special:Preferences - https://phabricator.wikimedia.org/T197282 (10gh87) [20:57:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/472879 (owner: 10L10n-bot) [20:59:49] takidelfin: Jon is not online at the moment. But I'm pretty sure he'll reply you as soon as he gets online :) [21:00:02] takidelfin: I've added you time for the task as I see time was fast running out [21:00:28] So my advice is that, wait a little for Jon and Phuedx to finalize on how the UI will look like then you will code it out :) [21:00:33] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Split preferences from TrackerProfile model to simplify preferences logic - https://phabricator.wikimedia.org/T208680 (10Urbanecm) 05Open>03Resolved [21:00:47] takidelfin: Is that okay by you? But you've done some great work already, just the finishing needed now :) [21:01:47] um [21:01:58] It is okay [21:02:27] but now I will sleep 0 hours ¯\_(`-`)_/¯ [21:02:39] because i have got only 13 tasks done [21:02:57] I know, quality > quantity [21:03:04] but heh, I need to be on leaderboards [21:10:53] :/ [21:20:23] 10TimedMediaHandler-TimedText, 10Wikimedia-production-error: Multi-line timed text text broken - https://phabricator.wikimedia.org/T209247 (10Geertivp) [21:30:51] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Product-Analytics, 10Community-Tech-Sprint, and 2 others: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10gh87) Can edits made at eventually deleted pages be logged as well? [21:31:51] 10TimedMediaHandler-TimedText, 10Wikimedia-production-error: Multi-line timed text text broken - https://phabricator.wikimedia.org/T209247 (10Geertivp) [21:36:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/472882 (owner: 10L10n-bot) [21:39:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/472886 (owner: 10L10n-bot) [21:43:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/472890 (owner: 10L10n-bot) [21:46:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/472887 (owner: 10L10n-bot) [21:48:26] 10Tor: Allow editing Wikimedia projects via Tor using our user account - https://phabricator.wikimedia.org/T209248 (10Pamputt) [21:50:47] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) @Legoktm Can you mentor this too for #google-code-in-2018? [21:50:52] 10Google-Code-in-2018, 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10User-Zoranzoki21: Convert all extensions and skins on gerrit to use extension registration - https://phabricator.wikimedia.org/T98668 (10Zoranzoki21) [21:51:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472894 (owner: 10L10n-bot) [21:53:56] (03CR) 10Zoranzoki21: "Aklapper: Hi, can you abandon this change because user is not active >2 years, and I working on https://gerrit.wikimedia.org/r/#/c/mediawi" [skins/Tomas] - 10https://gerrit.wikimedia.org/r/266025 (owner: 10MtDu) [21:54:03] (03PS4) 10Zoranzoki21: Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) [21:56:43] (03CR) 10jerkins-bot: [V: 04-1] Convert Tomas to use skin registration [skins/Tomas] - 10https://gerrit.wikimedia.org/r/463578 (https://phabricator.wikimedia.org/T205767) (owner: 10Zoranzoki21) [22:02:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/472893 (owner: 10L10n-bot) [22:04:50] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/472898 (owner: 10L10n-bot) [22:06:01] (03PS2) 10LukBukkit: Use a textbox for the summary on the announce page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/472873 (https://phabricator.wikimedia.org/T175432) [22:10:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/472901 (owner: 10L10n-bot) [22:11:35] 10Tor: Allow editing Wikimedia projects via Tor using our user account - https://phabricator.wikimedia.org/T209248 (10Bawolff) 05Open>03declined This is more a political issue than a technical one. Phabricator is the place to discuss technical bugs not political/social problems. Basically, you need to show... [22:17:54] :( [22:22:13] 10WMCZ-Tracker: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) [22:27:37] takidelfin: If the :( is in response to the tor bug, it makes me sad too [22:28:23] But there is a long history there, and just opening the floodgates to tor editing without community approval isn't going to happen [22:29:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/472909 (owner: 10L10n-bot) [22:29:47] 10Google-Code-in-2018, 10WMCZ-Tracker: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) I imported the task as https://codein.withgoogle.com/tasks/6333808543531008/ and I will mentor it. [22:31:33] 10WMCZ-Tracker, 10goodfirstbug: Squash TicketWatcher and TopicWatcher classes - https://phabricator.wikimedia.org/T208659 (10Urbanecm) [22:38:21] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Do not display field description repeatedly in edit_ticket/create_ticket - https://phabricator.wikimedia.org/T206104 (10Urbanecm) I imported this as https://codein.withgoogle.com/tasks/5339191949918208/ and I will mentor it. [22:38:38] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Write tests for notifications - https://phabricator.wikimedia.org/T203979 (10Urbanecm) [22:39:08] 10Google-Code-in-2018, 10WMCZ-Tracker, 10Patch-For-Review, 10User-Urbanecm: Write tests for notifications - https://phabricator.wikimedia.org/T203979 (10Urbanecm) a:03Urbanecm Need to figure out why tests are failing. [22:39:29] 10Google-Code-in-2018, 10WMCZ-Tracker, 10User-Urbanecm: Add --no-pull option to support/deploy script - https://phabricator.wikimedia.org/T206617 (10Urbanecm) [22:39:54] bawolff: oh, no! I'm sad because of my GCI task :D [22:39:57] Its weird [22:40:36] bawolff, if you really _have_ a reason to edit via Tor, there's IPBE [22:41:00] Urbanecm: I know, i mentioned that on the bug [22:41:16] didn't read the comment [22:41:44] I think it's good compromise, not allowing vandals to easily bypass blocks, but allowing good faith users to edit via Tor if they really need to [22:41:50] I'd like a world where anyone could be anonoymous, but that aint happening anytime soon [22:42:25] Maybe, but I worry the people who really need anonoyminity aren't really in a place where they can request IPBE or build up the neccessary reputation [22:42:50] 10MediaWiki-extensions-Disambiguator: mw-disambig class doesn't appear near similar pages - https://phabricator.wikimedia.org/T209249 (10valerio.bozzolan) [22:42:54] And anonoyminity really works best when you can hide in the crowd. If only a select few are allowed it doesn't grant the greatest of anonoyminity [22:43:05] that's true [22:43:26] but if we're all 100% anonymous, you cannot get rid of bad guys [22:43:32] yup [22:43:42] takidelfin, what makes you sad? :-) [22:43:51] https://meta.wikimedia.org/wiki/Community_Wishlist_Survey_2019/Anti-harassment/Wikipedia_mirrored_in_Tor_.onion btw is where this discussion started from [22:44:02] bad guys like ones who push directly to master :D [22:44:10] lol [22:44:18] takidelfin, I'm not sure I understand you [22:44:25] uh [22:44:27] maybe [22:44:36] alternatively, consider http://www.meatballwiki.org/wiki/SoftSecurity [22:44:41] but i don't think that really scales [22:45:09] But anyways yeah, gci. Anything we can help with? [22:45:28] Urbanecm: umm, that is a joke [22:45:33] ok then [22:47:50] 10MediaWiki-extensions-Disambiguator: mw-disambig class doesn't appear near similar pages - https://phabricator.wikimedia.org/T209249 (10valerio.bozzolan) [22:48:12] I had one project with my friends and one of them was always pushing directly to master (untested code). He was constantly destroying our app by these commits :/ [22:48:41] so I said that he is a bad guy [22:48:47] requiring code review is nice tool to prevent it [22:49:00] :D [22:49:00] like your code must be approved by your friend and vica versa [22:49:21] yup, we knew. But he wasn [22:49:21] >ones who push directly to master [22:49:34] hi bjornskjald [22:49:37] takidelfin is he from the Discord i think about? xD [22:49:42] hello Urbanecm [22:49:44] :D [22:50:07] I think you know about who I'm talking about... [22:50:21] ...maybe? [22:50:21] takidelfin: Testing in production is the true hacker way :P [22:50:47] ^this [22:50:49] bawolff, do WM deployers do tests on WMF prod servers? [22:51:08] i push updates to production for around 200/300 people [22:51:25] because nobody uses beta versions [22:51:30] Depends if we want to get yelled at ;) [22:51:56] but hackers don't steal someone else code just to commit it and get more contributions on GitHub :C [22:52:05] (That's a joke. production is not for testing) [22:52:11] bawolff, and do you want to get yelled at? :D [22:52:23] of course, everybody know production is not for testing [22:52:33] knows* ? [22:52:50] good question, is everybody singular or plural? [22:52:58] * takidelfin opening grammarly.com [22:53:37] it should be everybody knows [22:53:41] everybody is singular [22:53:57] yup [22:53:58] singular [22:54:22] 10ContentTranslation, 10Language-Team (Language-2018-October-December), 10Patch-For-Review: CX2: User created content triggers too much unmodified text error when typing and pasting - https://phabricator.wikimedia.org/T207913 (10Petar.petkovic) a:03Petar.petkovic [22:54:29] It took me a while to figure out if knows with an s was the agreement for singular or plural [22:54:33] english is a stupid language [22:54:54] ^ [22:55:10] Its my native language, so i know when things look "wrong" but I sometimes have trouble articulating why it is wrong [22:55:14] grammarly protects the world from my grammar... Sadly it isn't available on IRC ;( [22:55:27] bawolff: :O [22:55:56] also my spelling and grammar is terrible [22:56:32] But polish is still 3rd hardest language in the world! [22:56:56] uh, * Polish [22:59:55] also, Polish has got a very strong accent. And because of that, it is so hard to speak English like a native speaker for me [23:00:01] but I need to learn grammar first :D [23:00:23] Polish have/has got ? @bawolff [23:02:38] I would say Polish has a very strong accent [23:03:00] If we're talking about the language [23:03:26] and "The Polish have a very strong accent" if we are talking about polish people [23:03:40] * bawolff should really not give grammar advice though, my grammar is really terrible [23:04:21] bawolff: yeah, I mean a language. Thanks! [23:05:00] Goodbye(good morning), everyone! I will go to sleep now :D [23:05:12] "has got" in my mind seems like something that's kind of slangy, like I wouldn't blink if someone said it, but I don't think its technically correct either [23:05:27] good night [23:08:34] 10Google-Code-in-2018, 10MobileFrontend, 10Mobile, 10Need-volunteer, and 3 others: [Bug] Special:MobileOptions heading padding should be consistent - https://phabricator.wikimedia.org/T202557 (10Jdlrobson) The bug only exists with tablet. The issue is the paddi ng under reading preferences. Mobile should s... [23:14:02] oh, I missed the "Polish language very hard" topic [23:18:50] (03PS2) 10Jayprakash12345: Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) [23:19:31] (03CR) 10Jdlrobson: "I will review Monday morning california time. Sorry this one is causing so much confusion. Let's check in on irc and make sure we all unde" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472701 (https://phabricator.wikimedia.org/T202557) (owner: 10Takidelfin) [23:20:59] (03PS3) 10Jayprakash12345: Convert Extension:SpamDiffTool to use OOUI [extensions/SpamDiffTool] - 10https://gerrit.wikimedia.org/r/472797 (https://phabricator.wikimedia.org/T209221) [23:23:00] 10MediaWiki-extensions-Other, 10UI-Standardization, 10Patch-For-Review, 10User-Jayprakash12345: Convert Extension:SpamDiffTool to use OOUI - https://phabricator.wikimedia.org/T209221 (10Jayprakash12345) [23:36:02] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10SEO: Identify pages to be bucketed in page schema linked data A/B test - https://phabricator.wikimedia.org/T208789 (10Niedzielski) Still blocked on T208909. The database updater script is merged but execution of said script... [23:37:18] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10SEO: Enable "PageRandomLookup" Logstash channel - https://phabricator.wikimedia.org/T208796 (10Niedzielski) a:03pmiazga [23:37:26] 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10SEO: Add Wikibase page schema system messages - https://phabricator.wikimedia.org/T207790 (10Niedzielski) a:03pmiazga [23:39:02] 10MediaWiki-General-or-Unknown, 10DBA, 10MW-1.33-notes (1.33.0-wmf.4; 2018-11-13), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Bug] Update old nonuniformly distributed page_random values - https://phabricator.wikimedia.org/T208909 (10Niedzielski) @tgr saved the day and merged the updat...