[20:24:51] 10GLAM, 10Wikistorm: Import data from the Monumenten Inventarisatie Project (MIP) - https://phabricator.wikimedia.org/T208127 (10Husky) @valhallasw that could be an interesting option, but would it also work if there are many monuments that are close to each other, like in the centre of Amsterdam? But indeed... [20:25:48] 10MediaWiki-Watchlist, 10Growth-Team, 10Performance-Team, 10Wikimedia-production-error: Spike of DBTransactionSizeError exceptions from /w/api.php from Special:Watchlist - https://phabricator.wikimedia.org/T207941 (10Krinkle) [20:26:21] 10MediaWiki-Watchlist, 10Growth-Team, 10Performance-Team, 10Wikimedia-production-error: Spike of DBTransactionSizeError exceptions from /w/api.php from Special:Watchlist - https://phabricator.wikimedia.org/T207941 (10Krinkle) Most of them seem to be from /w/api.php on either de.wikipedia.org or commons.wik... [20:26:41] (03PS1) 10Krinkle: Fix "Array to string conversion" error in SpecialVipsTest.php [extensions/VipsScaler] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472249 [20:27:17] 10StructuredDiscussions, 10Growth-Team (Current Sprint): Fix Flow random test failures - https://phabricator.wikimedia.org/T208988 (10JTannerWMF) [20:28:17] 10StructuredDiscussions, 10Growth-Team (Current Sprint): Fix Flow random test failures - https://phabricator.wikimedia.org/T208988 (10kostajh) a:03kostajh [20:29:37] (03CR) 10jerkins-bot: [V: 04-1] Fix "Array to string conversion" error in SpecialVipsTest.php [extensions/VipsScaler] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472249 (owner: 10Krinkle) [20:29:57] 10Growth-Team (Current Sprint): RC and Watchlist: url limit parameter allows to see more than 1000 results - https://phabricator.wikimedia.org/T206233 (10JTannerWMF) [20:30:21] 10Product-Analytics, 10Growth-Team (Current Sprint): Personalized first day: experiments - https://phabricator.wikimedia.org/T206380 (10MMiller_WMF) [20:30:55] 10MediaWiki-extensions-OpenStackManager, 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10thcipriani) p:05Triage>03Unbreak! [20:31:03] (03CR) 10Krinkle: Fix @param data type in TemplateHelper.php (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [20:31:14] 10Browser-Support-Internet-Explorer, 10Growth-Team (Current Sprint): IE11: AfC - sort order drop down displays all options for any filter state selection - https://phabricator.wikimedia.org/T205669 (10JTannerWMF) [20:32:14] 10Growth-Team (Current Sprint): Help desk: business rules on displaying the feature - https://phabricator.wikimedia.org/T206716 (10JTannerWMF) [20:32:20] (03CR) 10Krinkle: "recheck" [extensions/VipsScaler] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472249 (owner: 10Krinkle) [20:32:38] 10English-Wikipedia-New-Pages-Patrol, 10Documentation, 10Growth-Team (Current Sprint): New Pages Feed: update Mediawiki documentation - https://phabricator.wikimedia.org/T203828 (10JTannerWMF) [20:33:08] 10MediaWiki-extensions-OpenStackManager, 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10thcipriani) [20:33:36] (03CR) 10D3r1ck01: Fix @param data type in TemplateHelper.php (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [20:34:49] (03CR) 10Krinkle: [C: 032] Improve handling of invalid titles in RefreshLinksJob [core] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472047 (https://phabricator.wikimedia.org/T208147) (owner: 10Krinkle) [20:35:03] (03PS1) 10Krinkle: Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) [20:35:08] (03CR) 10Krinkle: [C: 032] Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [20:35:11] (03CR) 10Krinkle: [C: 032] Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472246 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [20:35:15] 10MediaWiki-extensions-OpenStackManager, 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10Jdforrester-WMF) No new patches in wmf.3 except the i18n update in https://... [20:35:30] (03Merged) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/472127 (https://phabricator.wikimedia.org/T208144) (owner: 10Daimona Eaytoy) [20:36:57] (03CR) 10Krinkle: [C: 032] Fix "Array to string conversion" error in SpecialVipsTest.php [extensions/VipsScaler] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472249 (owner: 10Krinkle) [20:37:25] (03PS5) 10D3r1ck01: Fix @param data type in TemplateHelper.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 [20:37:55] 10MediaWiki-General-or-Unknown, 10DBA, 10Readers-Web-Backlog: [Bug] Update old nonuniformly distributed page_random values - https://phabricator.wikimedia.org/T208909 (10Tbayer) [20:38:59] (03CR) 10Krinkle: Fix @param data type in TemplateHelper.php (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 (owner: 10D3r1ck01) [20:41:45] (03PS6) 10D3r1ck01: Fix @param data type in TemplateHelper.php [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468847 [20:43:38] (03CR) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/472127 (https://phabricator.wikimedia.org/T208144) (owner: 10Daimona Eaytoy) [20:44:19] 10MinervaNeue, 10MobileFrontend, 10Readers-Web-Backlog: MobileFrontend broken with sections - https://phabricator.wikimedia.org/T208983 (10Niedzielski) [20:48:07] MatmaRex: Acutally someone reviewed my patch on Gerrit. He told me to not use a fixed width. Could you review it now? I have just sent a fix for this :D [20:49:46] (03CR) 10Krinkle: [C: 032] "LGTM, one point for later consideration, but I'll post that on the task." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/463501 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [20:49:51] takidelfin: i've actually just been looking at the patch, and finding broken things in the existing code that i had no idea were broken [20:51:12] (03PS2) 10VolkerE: Remove obsolete Special:Preferences styles after its transformation to OOUI [skins/Vector] - 10https://gerrit.wikimedia.org/r/472088 (https://phabricator.wikimedia.org/T208923) [20:51:16] (03CR) 10VolkerE: Remove obsolete Special:Preferences styles after its transformation to OOUI (031 comment) [skins/Vector] - 10https://gerrit.wikimedia.org/r/472088 (https://phabricator.wikimedia.org/T208923) (owner: 10VolkerE) [20:51:17] takidelfin: i'm pretty sure that the '.ve-ui-linearContextItem-info' element is supposed to be completely hidden on desktop (with 'display: none'), as it is only used on mobile (where it replaces '.ve-ui-linearContextItem-description') [20:51:37] it is always empty on desktop, as far as i can tell [20:52:20] (correction: where it replaces '.ve-ui-linearContextItem-body') [20:52:47] and i think hiding it would make your patch a lot easier to do, right now the '.ve-ui-linearContextItem-info' exists there set to 99% width and messes things up [20:53:43] (03PS2) 10Nray: Add tests for Panel.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) [20:53:58] 10Page-Previews, 10Readers-Web-Backlog: [Bug] selenium-daily-beta-Popups Jenkins job failing acquiring DISPLAY port 94 - https://phabricator.wikimedia.org/T208997 (10Niedzielski) [20:54:21] (03PS2) 10VolkerE: Remove obsolete Special:Preferences styles after its transformation to OOUI [skins/MonoBook] - 10https://gerrit.wikimedia.org/r/472090 (https://phabricator.wikimedia.org/T208923) [20:55:59] 10GLAM, 10Wikistorm: Import data from the Monumenten Inventarisatie Project (MIP) - https://phabricator.wikimedia.org/T208127 (10valhallasw) That depends... I imagine the errors will be smaller in Amsterdam (I think in the case of this windmill, one database points to the windmill itself and one to the street)... [20:56:05] (03PS3) 10Nray: Add tests for Panel.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) [20:56:40] MatmaRex: umm... I edited the correct file? Because I found DesktopContext now... [20:57:20] takidelfin: yes, i think your approach is good, it's just that something else is broken [20:57:21] (03Merged) 10jenkins-bot: Improve handling of invalid titles in RefreshLinksJob [core] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472047 (https://phabricator.wikimedia.org/T208147) (owner: 10Krinkle) [20:57:23] (03CR) 10jerkins-bot: [V: 04-1] Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [20:57:24] i'm working on a patch for that [20:59:45] oh, okay. Should I add `display:none` to ve-ui-linearContextItem-info? [21:00:22] (03CR) 10Krinkle: [C: 032] Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [21:00:24] (03Merged) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472246 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [21:00:26] (03Merged) 10jenkins-bot: Fix "Array to string conversion" error in SpecialVipsTest.php [extensions/VipsScaler] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472249 (owner: 10Krinkle) [21:00:54] (03Merged) 10jenkins-bot: Move event validation to debug module (2/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/463501 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:02:52] 10MediaWiki-User-management, 10Anti-Harassment, 10CheckUser: CheckUser tool is inaccessible while partial-blocked - https://phabricator.wikimedia.org/T208512 (10dbarratt) [21:02:59] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 32), 10Patch-For-Review: Update User::isAllowed() to check the user's block with Block::prevents() - https://phabricator.wikimedia.org/T208563 (10dbarratt) 05Open>03declined After much discussion, we've decided that it is best to let extensions d... [21:03:07] (03CR) 10Nray: "> looks like the branch on line 49 inside the show method is not" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) (owner: 10Nray) [21:03:13] 10Discovery-Search (Current work), 10Patch-For-Review: Build pipeline to transform elastic explains into feature vectors and a tf graph - https://phabricator.wikimedia.org/T208917 (10EBernhardson) I've run this a few times with a few different settings. All inputs start with the set of all logged english wikid... [21:03:36] 10Growth-Team, 10StructuredDiscussions, 10MW-1.31-release, 10MW-1.32-release: Flow\Tests\Formatter\FormatterTest test failures: TypeError: Argument 1 passed to MediaWiki\Linker\LinkRenderer::makeLink() must implement interface MediaWiki\Linker\LinkTarget, null give... - https://phabricator.wikimedia.org/T206582 [21:03:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/472256 (owner: 10L10n-bot) [21:04:00] (03CR) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472246 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [21:04:18] (03CR) 10Jdlrobson: Add tests for Panel.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) (owner: 10Nray) [21:04:28] (03CR) 10Physikerwelt: [C: 032] Add PHPUnit @covers annotation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/471960 (https://phabricator.wikimedia.org/T195145) (owner: 10LukBukkit) [21:05:50] (03Merged) 10jenkins-bot: Add PHPUnit @covers annotation [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/471960 (https://phabricator.wikimedia.org/T195145) (owner: 10LukBukkit) [21:06:51] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Wikimedia-production-error: PHP Fatal Error from RefreshLinksJob: Argument to runForTitle() must be Title - https://phabricator.wikimedia.org/T208147 (10Krinkle) 05Open>03Resolved [21:06:54] (03CR) 10Jack Phoenix: [C: 04-1] "Mandatory disclaimer: I'm not overly familiar with MF, so I'm only commenting on the things I know (or think I know!)." (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451807 (https://phabricator.wikimedia.org/T173527) (owner: 10Jdlrobson) [21:07:32] 10MediaWiki-extensions-OpenStackManager, 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10bd808) Caused by {9f73202ae3c734070225e2af872b83a63d282661} [21:07:53] (03CR) 10Dbrant: [C: 04-1] "It looks like all the pieces in this patch are generally working correctly, but I'm rather concerned about having to manually evict connec" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852) (owner: 10Cooltey) [21:08:15] (03PS1) 10Kosta Harlan: Temporarily mark flaky tests as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472263 (https://phabricator.wikimedia.org/T208988) [21:08:21] takidelfin: i replied on https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/+/472229 now [21:08:21] (03CR) 10jenkins-bot: Move event validation to debug module (2/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/463501 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [21:08:49] (03CR) 10Jack Phoenix: [C: 04-2] "Code-wise this is fine, but as master targets current stable (which is still 1.31) let's not merge this just yet. :)" [extensions/Video] - 10https://gerrit.wikimedia.org/r/469015 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [21:10:08] (03PS4) 10Dbarratt: Check that the user block is sitewide when determining permissions [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/471480 (https://phabricator.wikimedia.org/T208621) (owner: 10Daimona Eaytoy) [21:11:48] Well... I really don't know why I changed width:99% to min-width:auto ... [21:12:37] I even don't remember to do it [21:13:16] maybe I'm too sleppy now ¯\_(`-`)_/¯ [21:14:03] (03CR) 10Nray: Add tests for Panel.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) (owner: 10Nray) [21:14:10] haha [21:14:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/472259 (owner: 10L10n-bot) [21:14:49] 10MediaWiki-Page-editing, 10JavaScript, 10MW-1.32-notes, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10stjn) Are statistics on toolbar usage still available for wikis not included in previous batches? Maybe in the form of ‘who doesn’t... [21:14:59] 10Mobile, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Brave browser: Unreadable text (line breaks at every character) for text next to an info box - https://phabricator.wikimedia.org/T208642 (10TheDJ) I dont have a web inspector here, but this looks like a typical case of where an info... [21:16:54] (03Merged) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [21:17:30] (03PS1) 10BryanDavis: Expose methods used by OpenStackManager [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/472265 (https://phabricator.wikimedia.org/T208995) [21:17:59] thcipriani: I think that patch will fix wikitech ^ [21:18:57] (03CR) 10VolkerE: Provide input label for screen readers (031 comment) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472097 (https://phabricator.wikimedia.org/T139426) (owner: 10VolkerE) [21:18:58] bd808: neat, thank you, that patch makes sense, dunno why it was suddenly triggered [21:19:24] (03CR) 10Jforrester: [C: 032] Expose methods used by OpenStackManager [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/472265 (https://phabricator.wikimedia.org/T208995) (owner: 10BryanDavis) [21:19:42] the method privacy was just added 5 days ago [21:20:23] umherirrender was cleaning up the method signatures and just didn't know about the OSM weirdness [21:20:32] I'm going to watch that repo in gerrit now :) [21:20:37] (03CR) 10jenkins-bot: Remove typehint to avoid fatal error [extensions/AbuseFilter] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472252 (https://phabricator.wikimedia.org/T208144) (owner: 10Krinkle) [21:21:07] takidelfin: i'll look at this again in the morning, i definitely underestimated how complicated our styles are for this. it looked easier… [21:21:19] thanks for working on it :) [21:21:38] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Incorrect thumbnail image may be shown on "continue reading" widget - https://phabricator.wikimedia.org/T208757 (10ABorbaWMF) Looks good to me on 2.7.264-alpha-2018-11-07 [21:21:59] (03CR) 10Jdlrobson: Add tests for Panel.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) (owner: 10Nray) [21:22:05] :D [21:22:32] (03CR) 10Jforrester: "Caused T208995 due to OpenStackManager re-using this code. I missed it in code review. :-(" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/471087 (owner: 10Umherirrender) [21:23:51] bd808: I don't know how I didn't spot that in code review. Sorry. [21:23:57] (03CR) 10Cooltey: [C: 032] Fix possible memory leak upon exit transition. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472169 (owner: 10Dbrant) [21:24:01] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/472275 (owner: 10L10n-bot) [21:24:07] James_F: meh. its weird [21:24:32] That's true. But that's the point of code review. :-) [21:24:46] 10AbuseFilter, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Wikimedia-production-error: Fatal error on file upload: "Argument to AbuseFilter::filterAction() must be Title, null given" - https://phabricator.wikimedia.org/T208144 (10Krinkle) 05Open>03Resolved a:03Krinkle Thanks! [21:24:52] someday™ we will kill off OSM. someday [21:25:12] (03PS1) 10VolkerE: Fix two ESLint comment errors [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/472333 [21:25:45] soon™ [21:25:59] I believe you.® [21:26:18] (03CR) 10Raimond Spekking: [V: 032 C: 032] "false positive" [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/472275 (owner: 10L10n-bot) [21:26:37] okay, goodnight (or good morning) everyone! [21:27:19] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/472332 (owner: 10L10n-bot) [21:27:46] (03CR) 10Yaron Koren: "@Samwilson - sorry for the long delay! I just haven't been able to bring myself to "pull the trigger" yet, but I do plan to check this in." [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/466840 (https://phabricator.wikimedia.org/T200054) (owner: 10Samwilson) [21:28:18] (03CR) 10Raimond Spekking: [V: 032 C: 032] "false posirive" [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/472332 (owner: 10L10n-bot) [21:28:51] 10MediaWiki-Page-editing, 10JavaScript, 10MW-1.32-notes, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Jdforrester-WMF) >>! In T30856#4730003, @stjn wrote: > Are statistics on toolbar usage still available for wikis not included in pr... [21:29:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/472277 (owner: 10L10n-bot) [21:29:50] 10Google-Code-in-2018, 10Audiences-QA, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10MinervaNeue (3rd party support), and 3 others: 3rd parties: Edit button shows as enabled to anonymous editors. - https://phabricator.wikimedia.org/T206823 (10ovasileva) 05Open>03Resolved Looks good, thanks all [21:30:05] (03CR) 10Cooltey: Follow-up to Rx lead and sections. (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472221 (owner: 10Dbrant) [21:30:09] 10Google-Code-in-2018, 10Audiences-QA, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10MinervaNeue (3rd party support), and 3 others: 3rd parties: Edit button shows as enabled to anonymous editors. - https://phabricator.wikimedia.org/T206823 (10ovasileva) [21:30:35] (03CR) 10Daimona Eaytoy: "> Uploaded patch set 4." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/471480 (https://phabricator.wikimedia.org/T208621) (owner: 10Daimona Eaytoy) [21:31:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/472304 (owner: 10L10n-bot) [21:31:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/472272 (owner: 10L10n-bot) [21:31:11] 10MobileFrontend, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Simplify anonymous editor CTA - https://phabricator.wikimedia.org/T206813 (10ovasileva) 05Open>03Resolved All done! [21:31:54] 10UI-Standardization, 10MobileFrontend, 10VisualEditor-MediaWiki-Mobile, 10Browser-Support-Android-Google-Chrome, and 4 others: MobileFrontend overlay toolbar can have no top border in Chrome 69 on Android - https://phabricator.wikimedia.org/T204691 (10Volker_E) [21:33:23] 10Google-Code-in-2018, 10Audiences-QA, 10MW-1.33-notes (1.33.0-wmf.2; 2018-10-30), 10MinervaNeue (Desktop), and 4 others: [Bug] No page margins for 1000px viewports - https://phabricator.wikimedia.org/T193061 (10ovasileva) 05Open>03Resolved looks good, resolving [21:33:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/472284 (owner: 10L10n-bot) [21:33:38] (03CR) 10Dbrant: Follow-up to Rx lead and sections. (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472221 (owner: 10Dbrant) [21:33:44] (03Merged) 10jenkins-bot: Fix possible memory leak upon exit transition. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472169 (owner: 10Dbrant) [21:35:47] (03CR) 10jenkins-bot: Fix possible memory leak upon exit transition. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472169 (owner: 10Dbrant) [21:35:49] 10MediaWiki-extensions-WikibaseMediaInfo, 10SDC Engineering, 10StructuredDataOnCommons, 10Wikidata: Concept URI appears in side bar even if the MediaInfo entity doesn't actually exist, and is wrong - https://phabricator.wikimedia.org/T205836 (10Jdforrester-WMF) Help me @addshore you're my only hope etc. [21:38:25] 10MediaWiki-Internationalization, 10I18n: [[MediaWiki:Tuesday/ga]] translation issue - https://phabricator.wikimedia.org/T208992 (10Framawiki) [21:38:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/472286 (owner: 10L10n-bot) [21:39:00] (03CR) 10Dbarratt: "> Patch Set 4:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/471480 (https://phabricator.wikimedia.org/T208621) (owner: 10Daimona Eaytoy) [21:41:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/472285 (owner: 10L10n-bot) [21:41:45] (03CR) 10Cooltey: [C: 032] Fix extraneous logcat messages in OnThisDay activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472178 (owner: 10Dbrant) [21:42:07] 10Anti-Harassment, 10ContentTranslation: Partially Blocked users cannot see entry points for Content Translation (but should!) - https://phabricator.wikimedia.org/T209001 (10TBolliger) [21:42:11] (03PS4) 10Jdlrobson: Allow users to change their mobile skin preference (take 2) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451807 (https://phabricator.wikimedia.org/T173527) [21:42:20] (03CR) 10Jdlrobson: "thanks for the review!" (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451807 (https://phabricator.wikimedia.org/T173527) (owner: 10Jdlrobson) [21:42:50] (03Merged) 10jenkins-bot: Expose methods used by OpenStackManager [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/472265 (https://phabricator.wikimedia.org/T208995) (owner: 10BryanDavis) [21:43:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/472291 (owner: 10L10n-bot) [21:43:32] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10dbarratt) [21:44:21] Finally. [21:44:28] (03PS1) 10Jforrester: Expose methods used by OpenStackManager [extensions/LdapAuthentication] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472336 (https://phabricator.wikimedia.org/T208995) [21:44:40] 10MediaWiki-General-or-Unknown, 10Tracking: Issues affecting translatewiki.net - https://phabricator.wikimedia.org/T41480 (10Yaron_Koren) [21:44:42] 10MediaWiki-extensions-Page_Forms, 10Technical-Debt: Calls to deprecated SpecialPage::getTitle (multiple cases) - https://phabricator.wikimedia.org/T208712 (10Yaron_Koren) 05Open>03Resolved a:03Yaron_Koren Thanks for letting me know about that - I just checked in a fix for all of of these. [21:45:27] (03PS1) 10Dbrant: Make isOnline() function a lot less expensive. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472337 [21:45:38] (03CR) 10jerkins-bot: [V: 04-1] Make isOnline() function a lot less expensive. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472337 (owner: 10Dbrant) [21:46:52] 10Growth-Team (Current Sprint): Help desk: button and pane - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) [21:47:10] (03PS2) 10Dbrant: Make isOnline() function a lot less expensive. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472337 [21:47:19] 10Growth-Team (Current Sprint): Help desk: button and pane - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) [21:47:43] 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Third-Party-Support, 10MinervaNeue (3rd party support): MobileFrontend broken with sections - https://phabricator.wikimedia.org/T208983 (10Jdlrobson) p:05Triage>03Low @Paladox this task is pretty vague - can you provide some clearer replication in... [21:47:49] 10Android-app-feature-Navigation, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): As a new user of the reading lists feature, I would like to be able to easily read the empty state text on my first visit to the Readin... - https://phabricator.wikimedia.org/T208057 [21:47:52] (03CR) 10Thcipriani: [C: 032] Expose methods used by OpenStackManager [extensions/LdapAuthentication] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472336 (https://phabricator.wikimedia.org/T208995) (owner: 10Jforrester) [21:49:17] 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Third-Party-Support, 10MinervaNeue (3rd party support): MobileFrontend broken with sections - https://phabricator.wikimedia.org/T208983 (10Paladox) The wikitext on this page is: ``` = Header 1 = {{#cargo_query: table=Items |fields=image=, name=Name,... [21:50:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472290 (owner: 10L10n-bot) [21:52:11] 10MediaWiki-User-management, 10Anti-Harassment: Extensions should be able to declare how blocks should handle their rights - https://phabricator.wikimedia.org/T209003 (10dbarratt) [21:52:13] (03Merged) 10jenkins-bot: Fix extraneous logcat messages in OnThisDay activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472178 (owner: 10Dbrant) [21:52:20] 10Growth-Team (Current Sprint): Help desk: button and pane - https://phabricator.wikimedia.org/T206717 (10MMiller_WMF) @kostajh @Catrope -- this is the task that we discussed today. @RHo -- I put minimal requirements on here so that engineering can start. Feel free to correct things, but you and I will talk ab... [21:52:32] (03PS1) 10XenoRyet: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/472338 [21:53:07] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Spike, 10Technical-Debt: [Spike, 8hrs] Views: You Gotta Keep 'em Separated - https://phabricator.wikimedia.org/T206036 (10Jdlrobson) [21:53:21] 10MediaWiki-User-management, 10Anti-Harassment: Extensions should be able to declare how blocks should handle their rights - https://phabricator.wikimedia.org/T209003 (10dbarratt) [21:53:23] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Split PageGateway - https://phabricator.wikimedia.org/T207770 (10Jdlrobson) 05Open>03stalled Stalling this one on completion of T206036 (which has a note to reopen) [21:54:07] 10MediaWiki-User-management, 10Anti-Harassment: Extensions should be able to declare how blocks should handle their rights - https://phabricator.wikimedia.org/T209003 (10dbarratt) [21:54:21] (03Merged) 10jenkins-bot: Expose methods used by OpenStackManager [extensions/LdapAuthentication] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472336 (https://phabricator.wikimedia.org/T208995) (owner: 10Jforrester) [21:55:00] (03CR) 10jenkins-bot: Fix extraneous logcat messages in OnThisDay activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472178 (owner: 10Dbrant) [21:56:30] (03CR) 10XenoRyet: [C: 032] Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/472338 (owner: 10XenoRyet) [21:56:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GrowthExperiments] - 10https://gerrit.wikimedia.org/r/472296 (owner: 10L10n-bot) [21:56:49] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2), 10SEO: Identify pages to be bucketed in page schema linked data A/B test - https://phabricator.wikimedia.org/T208789 (10Niedzielski) [21:57:06] 10MediaWiki-General-or-Unknown, 10DBA, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [Bug] Update old nonuniformly distributed page_random values - https://phabricator.wikimedia.org/T208909 (10Niedzielski) [21:57:42] 10MediaWiki-extensions-WikibaseRepository, 10Anti-Harassment, 10Wikidata: Partial Blocks are enforced as Sitewide blocks in Wikibase entities - https://phabricator.wikimedia.org/T207893 (10dbarratt) >>! In T207893#4718146, @Lucas_Werkmeister_WMDE wrote: > Note that `checkBlocked` is also used in `SpecialNewE... [21:58:46] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 32), 10Patch-For-Review: Update User::isAllowed() to check the user's block with Block::prevents() - https://phabricator.wikimedia.org/T208563 (10dbarratt) I've created T209003 to hopefully be able to do this in the future. [21:59:29] (03Merged) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/472338 (owner: 10XenoRyet) [22:00:50] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @tgr & @nuria - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [22:00:54] 10MediaWiki-User-management, 10Anti-Harassment: Update Extensions to properly handle Partial Blocks - https://phabricator.wikimedia.org/T208749 (10dbarratt) [22:00:56] 10Anti-Harassment, 10ContentTranslation: Partially Blocked users cannot see entry points for Content Translation (but should!) - https://phabricator.wikimedia.org/T209001 (10dbarratt) [22:01:12] (03CR) 10Daimona Eaytoy: "> > Patch Set 4:" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/471480 (https://phabricator.wikimedia.org/T208621) (owner: 10Daimona Eaytoy) [22:01:24] (03CR) 10Platonides: [C: 04-1] Add more information in requestaccount-email-body-admin message (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/471259 (https://phabricator.wikimedia.org/T181399) (owner: 10Stibba) [22:01:56] 10MediaWiki-extensions-OpenStackManager, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10Jdforrester-WMF) a:03bd808 [22:03:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472302 (owner: 10L10n-bot) [22:07:03] 10MediaWiki-General-or-Unknown, 10Anti-Harassment: TitlesMultiselectWidget for Partial blocks suggests and accepts special pages and other invalid namespaces - https://phabricator.wikimedia.org/T208355 (10TBolliger) [22:07:05] 10Anti-Harassment: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release - https://phabricator.wikimedia.org/T208613 (10TBolliger) [22:10:16] 10Anti-Harassment: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release - https://phabricator.wikimedia.org/T208613 (10TBolliger) [22:10:38] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): If a user is partially blocked they should be able to perform rollback on unrelated pages - https://phabricator.wikimedia.org/T208560 (10TBolliger) [22:10:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/472309 (owner: 10L10n-bot) [22:10:53] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): Partially blocked users should be able to rename/move pages (outside their block) - https://phabricator.wikimedia.org/T208273 (10TBolliger) [22:11:19] 10MediaWiki-HTMLForm, 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): Suppress browser triggered drop down and field highlighting for TitlesMultiselectWidget - https://phabricator.wikimedia.org/T208551 (10TBolliger) [22:11:21] 10MobileFrontend, 10Reading-Web-Third-Party-Support, 10Readers-Web-Backlog (Tracking): MobileFrontend broken with sections - https://phabricator.wikimedia.org/T208983 (10Jdlrobson) @paladox I don't know what cargo_query is doing but something in this page is moving the label outside of mw-headline (where it... [22:11:23] 10MobileFrontend, 10Reading-Web-Third-Party-Support, 10Readers-Web-Backlog (Tracking): MobileFrontend broken with sections - https://phabricator.wikimedia.org/T208983 (10Jdlrobson) [22:11:26] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): Do not display "this user is blocked" messages on user & user_talk pages for partial blocks - https://phabricator.wikimedia.org/T203171 (10TBolliger) [22:11:38] 10Anti-Harassment: 👩‍👦‍👦 Partial blocks complete blockers for ITWP release - https://phabricator.wikimedia.org/T208613 (10TBolliger) p:05Triage>03High [22:11:51] 10Anti-Harassment (AHT Sprint 33): 👩‍👦‍👦 Partial blocks complete blockers for ITWP release - https://phabricator.wikimedia.org/T208613 (10TBolliger) [22:12:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/472308 (owner: 10L10n-bot) [22:12:44] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10TBolliger) David, is this blocking us resolving any other defects on our backlog? [22:13:06] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): TitlesMultiselectWidget for Partial blocks suggests and accepts non-existent (aka redlink) pages - https://phabricator.wikimedia.org/T208626 (10TBolliger) [22:13:33] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): Change the partial block log entry for 'non-editing actions' to 'specified non-editing actions' - https://phabricator.wikimedia.org/T208806 (10TBolliger) [22:13:35] 10SDC Design and Spec Docs: Consider changes to search - https://phabricator.wikimedia.org/T208810 (10PDrouin-WMF) [22:14:16] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 32), 10Patch-For-Review: Title::checkUserBlock should call User::isBlockedFrom for every action - https://phabricator.wikimedia.org/T208862 (10dbarratt) [22:14:18] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): If a user is partially blocked they should be able to perform rollback on unrelated pages - https://phabricator.wikimedia.org/T208560 (10dbarratt) [22:14:36] (03PS1) 10Catrope: Add GrowthExperiments extension [core] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472340 (https://phabricator.wikimedia.org/T208449) [22:14:38] 10MediaWiki-User-management, 10Anti-Harassment (AHT Sprint 33): If a user is partially blocked they should be able to perform rollback on unrelated pages - https://phabricator.wikimedia.org/T208560 (10dbarratt) This should be resolved when T208862 is complete. [22:16:06] 10MediaWiki-User-management, 10Anti-Harassment: Remove the 'edit' action from Block::prevents() - https://phabricator.wikimedia.org/T209002 (10dbarratt) >>! In T209002#4730205, @TBolliger wrote: > David, is this blocking us resolving any other defects on our backlog? Nope. Just some clean up that I didn't wan... [22:16:20] (03CR) 10Jforrester: [C: 031] Add GrowthExperiments extension [core] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472340 (https://phabricator.wikimedia.org/T208449) (owner: 10Catrope) [22:16:29] 10MediaWiki-extensions-OpenStackManager, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Wikimedia-production-error: PHP Fatal Error: Call to private method LdapAuthenticationPlugin::bindAs() from context 'OpenStackNovaLdapConnection' - https://phabricator.wikimedia.org/T208995 (10thcipriani) 05Open>03Resol... [22:17:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/472316 (owner: 10L10n-bot) [22:17:36] 10Google-Code-in-2018, 10Contributors-Team, 10Ladies-That-FOSS-MediaWiki, 10goodfirstbug: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no - https://phabricator.wikimedia.org/T137067 (10Arcayn) Update: Looking through the version history, it would appear that thi... [22:17:39] (03CR) 10Cooltey: [C: 032] "Thanks, it makes sense!" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472221 (owner: 10Dbrant) [22:17:45] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Epic: QA mobile page issues modal - https://phabricator.wikimedia.org/T198113 (10ovasileva) | language | single issue | section issue | multiple issues | minerva desktop | notes | **English** | {F27100350} [[https://en.m.wikipedia.org/wiki/Microscop... [22:18:07] (03CR) 10Catrope: [C: 032] Replace two regular expressions with cheap string manipulations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/466205 (https://phabricator.wikimedia.org/T203930) (owner: 10Thiemo Kreuz (WMDE)) [22:18:45] 10Design, 10Page-Issue-Warnings, 10Epic, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): [EPIC] Improve page issues - https://phabricator.wikimedia.org/T159262 (10ovasileva) [22:18:48] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Epic: QA mobile page issues modal - https://phabricator.wikimedia.org/T198113 (10ovasileva) 05Open>03Resolved a:03ovasileva Modals working as expected. Resolving. @alexhollender where page issues styling is not applied, modals do not appear.... [22:22:47] (03CR) 10Platonides: [V: 031 C: 04-1] "Other than the noted minor changes, I think it's fine." (031 comment) [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/471259 (https://phabricator.wikimedia.org/T181399) (owner: 10Stibba) [22:22:54] (03PS1) 10D3r1ck01: Add MobileCollectionTest for MobileCollection::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472341 (https://phabricator.wikimedia.org/T208987) [22:23:30] (03CR) 10Jdlrobson: Add tests for Panel.js (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472197 (https://phabricator.wikimedia.org/T206699) (owner: 10Nray) [22:26:08] (03CR) 10Catrope: [C: 032] Add GrowthExperiments extension [core] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472340 (https://phabricator.wikimedia.org/T208449) (owner: 10Catrope) [22:26:20] (03PS2) 10D3r1ck01: Add MobileCollectionTest for MobileCollection::class [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472341 (https://phabricator.wikimedia.org/T208987) [22:26:48] (03PS8) 10Dbarratt: Title::checkUserBlock should call User::isBlockedFrom for every action [core] - 10https://gerrit.wikimedia.org/r/471993 (https://phabricator.wikimedia.org/T208862) [22:27:57] (03CR) 10Dbarratt: Title::checkUserBlock should call User::isBlockedFrom for every action (031 comment) [core] - 10https://gerrit.wikimedia.org/r/471993 (https://phabricator.wikimedia.org/T208862) (owner: 10Dbarratt) [22:28:32] 10GLAM, 10Wikistorm: Import data from the Monumenten Inventarisatie Project (MIP) - https://phabricator.wikimedia.org/T208127 (10Husky) @valhallasw thanks for trying out a couple of things, and indeed confirming that using the location won't work. I was pretty confused by the HNO / HNE columns as well, unfortu... [22:30:00] 10MediaWiki-Page-editing, 10MediaWiki-extensions-CodeMirror: Collapse templates in editor - https://phabricator.wikimedia.org/T30684 (10Quiddity) [22:31:42] 10Discovery-Search (Current work), 10Patch-For-Review: Build pipeline to transform elastic explains into feature vectors and a tf graph - https://phabricator.wikimedia.org/T208917 (10TJones) Very interesting stuff. Thanks for sharing the numbers. A few things come to mind. First is that a reduction from 6.7 t... [22:33:03] (03Merged) 10jenkins-bot: Follow-up to Rx lead and sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472221 (owner: 10Dbrant) [22:35:02] (03CR) 10jenkins-bot: Follow-up to Rx lead and sections. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/472221 (owner: 10Dbrant) [22:35:15] 10MediaWiki-User-management, 10Anti-Harassment: Ensure that anywhere BlockDisablesLogin is used, it does not effect partial blocks - https://phabricator.wikimedia.org/T208895 (10dbarratt) >>! In T208895#4726402, @dmaza wrote: > This is arguably working as intended. I would agree this is low priority. If you h... [22:36:09] (03CR) 10Tim Starling: [C: 032] Add docbook documentation (for php.net) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/467835 (https://phabricator.wikimedia.org/T206586) (owner: 10Anomie) [22:37:52] (03Merged) 10jenkins-bot: Add docbook documentation (for php.net) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/467835 (https://phabricator.wikimedia.org/T206586) (owner: 10Anomie) [22:37:58] (03Merged) 10jenkins-bot: Replace two regular expressions with cheap string manipulations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/466205 (https://phabricator.wikimedia.org/T203930) (owner: 10Thiemo Kreuz (WMDE)) [22:38:04] (03CR) 10jenkins-bot: Add docbook documentation (for php.net) [php/luasandbox] - 10https://gerrit.wikimedia.org/r/467835 (https://phabricator.wikimedia.org/T206586) (owner: 10Anomie) [22:38:38] 10MediaWiki-User-management, 10Anti-Harassment: Deprecate User::isBlocked() - https://phabricator.wikimedia.org/T209004 (10dbarratt) [22:39:21] (03Merged) 10jenkins-bot: Add GrowthExperiments extension [core] (wmf/1.33.0-wmf.2) - 10https://gerrit.wikimedia.org/r/472340 (https://phabricator.wikimedia.org/T208449) (owner: 10Catrope) [22:40:00] Anyone know where MW error logs go inside Vagrant? It's not apache2/error.log or syslog… [22:42:07] (03CR) 10Catrope: [C: 032] Temporarily mark flaky tests as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472263 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [22:43:29] (03PS20) 10Cooltey: Greyed out views if articles are not available offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852) [22:43:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/472320 (owner: 10L10n-bot) [22:44:08] (03PS2) 10VolkerE: Combine input and search button on intriniscally tied together widget [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/460185 [22:47:19] 10Dumps-Generation: Missing wikidatawiki-20181101-pages-articles.xml.bz2 in md5/sha1sums.txt - https://phabricator.wikimedia.org/T209006 (10charlesmwang_fb) [22:47:40] (03PS4) 10BPirkle: Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) [22:48:12] 10MediaWiki-User-management, 10Anti-Harassment: Update Special:Block to match the design - https://phabricator.wikimedia.org/T202773 (10TBolliger) [22:50:27] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @tgr & @nuria - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [22:52:21] 10Accessibility, 10Discovery, 10Wikimedia-Portals, 10Patch-For-Review: Portal search field missing accessibility label, button misses discernible text - https://phabricator.wikimedia.org/T139426 (10Volker_E) [22:54:31] (03CR) 10jenkins-bot: Replace two regular expressions with cheap string manipulations [extensions/Echo] - 10https://gerrit.wikimedia.org/r/466205 (https://phabricator.wikimedia.org/T203930) (owner: 10Thiemo Kreuz (WMDE)) [22:56:03] (03Merged) 10jenkins-bot: Temporarily mark flaky tests as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472263 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [22:58:48] (03CR) 10jerkins-bot: [V: 04-1] Create GuzzleHttpRequest class as new default for HttpRequestFactory [core] - 10https://gerrit.wikimedia.org/r/453408 (https://phabricator.wikimedia.org/T202110) (owner: 10BPirkle) [23:01:07] James_F: should be /vagrant/logs [23:01:30] 10MediaWiki-Special-pages, 10MW-1.33-notes (1.33.0-wmf.3; 2018-11-06), 10Patch-For-Review: Special:MyContributions does not accept start or end URL parameters - https://phabricator.wikimedia.org/T207895 (10Lucas_Werkmeister_WMDE) 05Open>03Resolved a:03Lucas_Werkmeister_WMDE The fix is merged and deploy... [23:01:40] which is also the logs directory inside the vagrant checkout on your host computer [23:01:57] (03CR) 10jenkins-bot: Temporarily mark flaky tests as broken [extensions/Flow] - 10https://gerrit.wikimedia.org/r/472263 (https://phabricator.wikimedia.org/T208988) (owner: 10Kosta Harlan) [23:01:58] Aha. Thanks bd808. [23:02:23] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Story: [Story] Make it impossible to use Special:NewItem with the same content for label and description - https://phabricator.wikimedia.org/T100933 (10abian) Maybe this isn't our most urgent issue about data quality, but I don't think it's hard to sol... [23:02:33] (03PS5) 10Cooltey: Provide clear indication of which articles in History are available whilst offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/471180 (https://phabricator.wikimedia.org/T157448) [23:04:16] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): View: Make isTemplateMode, isBorderBox and className passable options to the View class to reduce reliance on inheritance - https://phabricator.wikimedia.org/T209007 (10Jdlrobson) [23:04:27] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): View: Make isTemplateMode, isBorderBox and className passable options to the View class to reduce reliance on inheritance - https://phabricator.wikimedia.org/T209007 (10Jdlrobson) p:05Triage>03High [23:05:31] (03PS1) 10Catrope: ResourceLoader: Fail less hard when JSON serialization of config fails [core] - 10https://gerrit.wikimedia.org/r/472346 [23:06:00] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): View: Make isTemplateMode, isBorderBox and className passable options to the View class to reduce reliance on inheritance - https://phabricator.wikimedia.org/T209007 (10Jdlrobson) [23:08:09] (03PS6) 10Jdlrobson: Composition: The className of a View can be set directly by a property [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/468185 (https://phabricator.wikimedia.org/T209007) [23:08:26] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review: View: Make isTemplateMode, isBorderBox and className passable options to the View class to reduce reliance on inheritance - https://phabricator.wikimedia.org/T209007 (10Jdlrobson) [23:10:19] (03CR) 10Jdlrobson: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472069 (https://phabricator.wikimedia.org/T206698) (owner: 10Jdlrobson) [23:11:57] 10MediaWiki-Internationalization, 10I18n: [[MediaWiki:Tuesday/ga]] translation issue - https://phabricator.wikimedia.org/T208992 (10Aklapper) Could you provide examples for two 'contexts' which would have different translations in Gaelic? [23:12:50] 10MassMessage, 10MobileFrontend, 10Readers-Web-Backlog, 10Wikimedia-production-error: Unable to view certain mobile diffs "Exception: Cannot diff content types other than MassMessageListContent" - https://phabricator.wikimedia.org/T156293 (10CCicalese_WMF) From reading through the discussion, this does not... [23:13:29] 10MediaWiki-Page-editing, 10goodfirstbug: Add HTML class when the user can edit the page - https://phabricator.wikimedia.org/T208315 (10Jdforrester-WMF) Sounds good enough for me. Let's do it. [23:14:41] 10MediaWiki-API, 10MediaWiki-History-or-Diffs, 10Core Platform Team (MCR), 10Core Platform Team Kanban (Doing), and 3 others: RevisionAccessException from ApiComparePages.php: Could not determine title for page/revision ID - https://phabricator.wikimedia.org/T208929 (10CCicalese_WMF) [23:15:54] (03PS1) 10Jdlrobson: Hygiene: Drop unnecessary tagName properties [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472348 [23:15:56] (03PS1) 10Jdlrobson: Composition: TableOfContents is View w/ options + templates [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472349 [23:16:03] (03PS2) 10Jdlrobson: Hygiene: Drop unnecessary tagName properties [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472348 [23:16:40] 10MediaWiki-extensions-GrowthExperiments, 10Growth-Team: Add phan and seccheck to GrowthExperiments extension - https://phabricator.wikimedia.org/T208990 (10Aklapper) [23:16:55] 10Release, 10Train Deployments: 1.33.0-wmf.5 deployment blockers - https://phabricator.wikimedia.org/T206659 (10greg) 05Open>03declined This is the week of Thanksgiving in the US which means we won't be running the train. [23:18:17] 10Release, 10Train Deployments: 1.33.0-wmf.7 deployment blockers - https://phabricator.wikimedia.org/T206661 (10greg) 05Open>03declined This is the week of the Release Engineering team's offsite so we won't be running the train this week. [23:19:02] 10Growth-Team (Current Sprint): Understanding first day: testing and QA - https://phabricator.wikimedia.org/T207307 (10MMiller_WMF) [23:19:18] 10Release, 10Train Deployments: 1.33.0-wmf.10 deployment blockers - https://phabricator.wikimedia.org/T206664 (10greg) 05Open>03declined No train, Christmas holiday/end of year break. [23:19:38] 10MediaWiki-Configuration: Allow specification of version limits for optional dependencies - https://phabricator.wikimedia.org/T208962 (10MGChecker) This is similar to T182472 and might be resolved using the same mechanism. [23:19:40] 10Release, 10Train Deployments: 1.33.0-wmf.11 deployment blockers - https://phabricator.wikimedia.org/T206665 (10greg) 05Open>03declined No train, Christmas holiday/end of year break. [23:19:54] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review: View: Make isBorderBox and className passable options to the View class to reduce reliance on inheritance - https://phabricator.wikimedia.org/T209007 (10Jdlrobson) [23:20:01] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt: Deprecate User::isBlocked() - https://phabricator.wikimedia.org/T209004 (10Aklapper) ➞ #technical-debt [23:21:51] (03CR) 10Jforrester: [C: 032] "We can revert this later, when it's a less frequent issue." [core] - 10https://gerrit.wikimedia.org/r/472346 (owner: 10Catrope) [23:22:10] 10MediaWiki-User-management, 10Anti-Harassment, 10Technical-Debt (Deprecation): Deprecate User::isBlocked() - https://phabricator.wikimedia.org/T209004 (10MGChecker) [23:25:16] 10Growth-Team: Links in `anoneditwarning` are missing the `returnToQuery` parameters - https://phabricator.wikimedia.org/T208989 (10Aklapper) @SBisson: Could you please also add a code project tag, if possible? Thanks! [23:25:48] 10Release, 10Train Deployments: 1.33.0-wmf.15 deployment blockers - https://phabricator.wikimedia.org/T206669 (10greg) 05Open>03declined This is WMF All Hands week, no train. [23:28:05] (03PS1) 10Brion VIBBER: Bump TMH ver to 0.6.0 and update README for config changes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472350 (https://phabricator.wikimedia.org/T208710) [23:30:40] 10TimedMediaHandler: TimedMediaHandler is not fully configurable: Class 'WebVideoTranscode' not found - https://phabricator.wikimedia.org/T208643 (10brion) Yep, our bad -- we didn't document the breaking changes to config. :( Try this: ``` wfLoadExtension ('TimedMediaHandler'); ... $wgEnabledTranscodeSet['320p.... [23:31:33] (03CR) 10Jforrester: [C: 032] Bump TMH ver to 0.6.0 and update README for config changes (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472350 (https://phabricator.wikimedia.org/T208710) (owner: 10Brion VIBBER) [23:34:43] (03PS2) 10Arlolra: Quoted attributes don't need to be followed by a space [core] - 10https://gerrit.wikimedia.org/r/471363 [23:34:52] 10Growth-Team: Understanding first day: post-deployment QA - https://phabricator.wikimedia.org/T209009 (10MMiller_WMF) [23:35:18] 10Growth-Team, 10Product-Analytics: Understanding first day: post-deployment QA - https://phabricator.wikimedia.org/T209009 (10MMiller_WMF) [23:36:46] (03Merged) 10jenkins-bot: ResourceLoader: Fail less hard when JSON serialization of config fails [core] - 10https://gerrit.wikimedia.org/r/472346 (owner: 10Catrope) [23:39:25] (03CR) 10jenkins-bot: ResourceLoader: Fail less hard when JSON serialization of config fails [core] - 10https://gerrit.wikimedia.org/r/472346 (owner: 10Catrope) [23:43:46] 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q2): Add a share button to the mobile site (currently in beta on beta) - https://phabricator.wikimedia.org/T181195 (10Jdlrobson) @alexhollender given this task has been ling... [23:43:59] 10Wikimedia-Portals: Use non-output handlebar template comments over output ones - https://phabricator.wikimedia.org/T209010 (10Volker_E) [23:45:39] (03Merged) 10jenkins-bot: Bump TMH ver to 0.6.0 and update README for config changes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472350 (https://phabricator.wikimedia.org/T208710) (owner: 10Brion VIBBER) [23:46:43] 10TimedMediaHandler, 10Patch-For-Review: Raise version number of TMH - https://phabricator.wikimedia.org/T208710 (10brion) 05Open>03Resolved a:03brion Version bumped, and README includes a little info on the changes to config. [23:46:45] (03CR) 10Pmiazga: [C: 032] Hygiene: Drop unnecessary tagName properties [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/472348 (owner: 10Jdlrobson) [23:51:23] (03PS1) 10Brion VIBBER: Followup to README syntax for clarity [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472351 [23:52:04] (03CR) 10Jforrester: [C: 032] Followup to README syntax for clarity [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472351 (owner: 10Brion VIBBER) [23:55:15] (03PS1) 10Jforrester: Update extension authors to five highest direct contributors [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472353 [23:55:51] (03CR) 10Brion VIBBER: [C: 032] Update extension authors to five highest direct contributors [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/472353 (owner: 10Jforrester) [23:56:50] 10Google-Code-in-2018, 10Contributors-Team, 10Ladies-That-FOSS-MediaWiki, 10MobileFrontend, 10goodfirstbug: After editing redirects on mobile-web, you are linked to the target instead of &redirect=no - https://phabricator.wikimedia.org/T137067 (10Aklapper) [23:57:38] (03PS1) 10Catrope: ResourceLoader: Fail less hard when JSON serialization of config fails [core] (wmf/1.33.0-wmf.3) - 10https://gerrit.wikimedia.org/r/472354 [23:58:03] (03PS21) 10Cooltey: Greyed out views if articles are not available offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852)