[00:00:23] (03CR) 10VolkerE: [C: 04-1] "Bartosz' comment remains after rebase, so -1. Pointers appreciated." [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [00:02:16] 10Growth-Team, 10Product-Analytics: Personalized first day: instrument survey form - https://phabricator.wikimedia.org/T206379 (10MMiller_WMF) [00:03:03] 10MediaWiki-Installer, 10MediaWiki-ServiceContainer: Installer triggers disabled load balancer service when PHP can't write to session.save_path - https://phabricator.wikimedia.org/T157890 (10Niedzielski) If I understand correctly, this issue is also easily reproducible by running maintenance/install.php with... [00:06:13] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Integrating data into our products - https://phabricator.wikimedia.org/T206071 (10Quiddity) [00:06:54] (03PS1) 10Catrope: Various fixes and cleanup [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/468687 [00:07:52] (03PS1) 10Catrope: Update notification language to match what was requested on Phabricator [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/468688 (https://phabricator.wikimedia.org/T132084) [00:11:03] 10Anti-Harassment (AHT Sprint 31): Tracking blocks: Log when the mobile web editor block notice is displayed - https://phabricator.wikimedia.org/T201719 (10dmaza) Due to my limited familiarity with MobileFrontend I'm looking for some feedback/help on this before I submit the patch for review. I've created a pat... [00:11:10] 10MediaWiki-Database, 10MW-1.32-release: Dropping tables during a update should be made optional - https://phabricator.wikimedia.org/T207516 (10Paladox) p:05Triage>03High This would make it very hard to upgrade a wiki farm if you have thousands of wikis to upgrade so triaging as high. I propose a --no-dro... [00:12:04] (03CR) 10jerkins-bot: [V: 04-1] Convert Special:AllMessages to use OOUI [core] - 10https://gerrit.wikimedia.org/r/286944 (https://phabricator.wikimedia.org/T117749) (owner: 10Sethakill) [00:13:36] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Integrating machine learning into our products - https://phabricator.wikimedia.org/T206067 (10Quiddity) [00:14:49] (03PS1) 10Catrope: Simplify account age logic [extensions/TheWikipediaLibrary] - 10https://gerrit.wikimedia.org/r/468689 [00:21:52] 10MediaWiki-Releasing, 10MW-1.32-notes, 10MW-1.32-release, 10User-MacFan4000: Release MW 1.32 - https://phabricator.wikimedia.org/T207529 (10MacFan4000) [00:23:40] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Choosing installation methods and environments for 3rd party users - https://phabricator.wikimedia.org/T206059 (10Quiddity) [00:32:17] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Identifying and extracting data trapped in our content - https://phabricator.wikimedia.org/T206073 (10Quiddity) [00:35:56] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Determining use cases and requirements for the APIs that we build - https://phabricator.wikimedia.org/T206072 (10Quiddity) [00:41:30] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Choosing the technologies to build our APIs - https://phabricator.wikimedia.org/T206074 (10Quiddity) [00:45:35] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Identifying the requirements and goals for dependency tracking and events - https://phabricator.wikimedia.org/T206068 (10Quiddity) [00:48:46] 10Anti-Harassment (AHT Sprint 31): Tracking blocks: Log when the mobile web editor block notice is displayed - https://phabricator.wikimedia.org/T201719 (10Jdlrobson) I think you've got the right idea here. You can verify this by calling the counter locally and checking if it comes up in grafana (see these for... [00:49:27] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Improving frontend testing and logging - https://phabricator.wikimedia.org/T206077 (10Quiddity) [00:53:01] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Building our storage systems for flexibility and scale - https://phabricator.wikimedia.org/T206079 (10Quiddity) [00:57:20] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Standardizing frontend development tooling - https://phabricator.wikimedia.org/T206078 (10Quiddity) [01:00:11] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Architecting core: layers/components/libraries - https://phabricator.wikimedia.org/T206080 (10Quiddity) [01:03:58] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Architecting core: concepts - https://phabricator.wikimedia.org/T206084 (10Quiddity) [01:06:38] 10MediaWiki-Releasing, 10MW-1.32-notes, 10MW-1.32-release, 10User-MacFan4000: Release MW 1.32 - https://phabricator.wikimedia.org/T207529 (10Dinoguy1000) [01:07:19] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Architecting core: stand-alone services - https://phabricator.wikimedia.org/T206082 (10Quiddity) [01:09:43] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Architecting core: extension interfaces - https://phabricator.wikimedia.org/T206081 (10Quiddity) [01:14:41] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Applying the MediaWiki Platform Architecture Principles - https://phabricator.wikimedia.org/T206065 (10Quiddity) [01:17:14] 10Excimer, 10Core Platform Team (PHP7 (TEC4)), 10Documentation: Write documentation for Excimer - https://phabricator.wikimedia.org/T207499 (10CCicalese_WMF) [01:17:26] 10Excimer, 10Core Platform Team (PHP7 (TEC4)): ExcimerProfiler::start(), ExcimerTimer::start(), and so on should warn if starting fails - https://phabricator.wikimedia.org/T207498 (10CCicalese_WMF) [01:17:42] 10Excimer, 10Core Platform Team (PHP7 (TEC4)): Excimer: Expose event_count in ExcimerLogEntry - https://phabricator.wikimedia.org/T207497 (10CCicalese_WMF) [01:28:55] 10Wikimedia-Technical-Conference-2018: Wikimedia Technical Conference 2018 Session - Mapping our data and content pipeline - https://phabricator.wikimedia.org/T206070 (10Quiddity) [01:35:32] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Black background has excessive contrast with light checkered background applied to transparent images - https://phabricator.wikimedia.org/T161347 (10Isarra) [01:36:34] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Black background has excessive contrast with light checkered background applied to transparent images - https://phabricator.wikimedia.org/T161347 (10Isarra) I actually really like this idea - programmatically set the background to a colour calculated from... [03:17:34] 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools, 10Security: User right changes should require elevated security - https://phabricator.wikimedia.org/T197150 (10revi) >>! In T197150#4281032, @Rxy wrote: > I'm not sure, but If you assume this apply same logic as [... [03:21:04] 10Stewards-and-global-tools, 10Trust-and-Safety, 10Wikimedia-Site-requests, 10Patch-For-Review, and 2 others: Increase password policies for the 'steward' group - https://phabricator.wikimedia.org/T197577 (10revi) IIRC Stewards are admin on at least one wiki right now, so I'd assume admin's strict rule win... [03:33:05] 10Growth-Team: Personalized first day: translate and test copy - https://phabricator.wikimedia.org/T206376 (10revi) >>! In T206376#4679913, @Trizek-WMF wrote: > **Use translatewiki.net** > * Pros: > ** we can open Personalized First day to more wikis almost when we want because translations would be ready (the... [04:25:13] (03CR) 10Dbarratt: [C: 04-1] [WIP] - Log when mobile web editor block notice is displayed (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/468684 (owner: 10Dmaza) [04:53:35] 10Performance: Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 (10Fastily) [04:57:37] 10MediaWiki-Page-deletion, 10Performance: Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 (10Fastily) [05:08:52] 10WMSE-Riksarkivet-TORA: Nobel data for 2017 is missing - https://phabricator.wikimedia.org/T202034 (10Salgo60) [05:14:30] (03PS1) 10Aaron Schulz: Run runAutoMaintenance() more frequently and only on HTTP POST [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/468690 [05:49:37] 10MediaWiki-Debian, 10MediaWiki-Releasing, 10MW-1.31-release, 10PHP 7.3 support: MediaWiki 1.31.x should be compatible with PHP 7.3 - https://phabricator.wikimedia.org/T206988 (10Krinkle) [05:49:39] 10MediaWiki-Cache, 10MW-1.31-release, 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10PHP 7.3 support, 10Patch-For-Review: compact(): Undefined variable in LocalisationCache on PHP 7.3 - https://phabricator.wikimedia.org/T206979 (10Krinkle) 05Open>03Resolved a:03Legoktm [07:28:55] 10Discovery-Wikidata-Query-Service-Sprint, 10Patch-For-Review: Monitor query / request concurrency on Blazegraph - https://phabricator.wikimedia.org/T206123 (10Smalyshev) I have added a counter for `/ Query Engine / runningQueriesCount` - can be seen at wdq9 now and on other servers after deployment. Can we ge... [07:36:33] (03CR) 10Lokal Profil: [C: 031] "looks good but holding of the +2 until Igor has approved" [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/468582 (https://phabricator.wikimedia.org/T192683) (owner: 10Sebastian Berlin (WMSE)) [07:57:45] 10Growth-Team (Current Sprint): Identify most interesting external links and modify them for PageViews schema tracking on ko.wp and cs.wp - https://phabricator.wikimedia.org/T207306 (10revi) >>! In T207306#4679157, @MMiller_WMF wrote: > But the open question is for @revi: are there important external links to ne... [08:10:57] 10WMSE-Riksarkivet-TORA: familysearch.org create a Proof of Concept with a template - https://phabricator.wikimedia.org/T201404 (10Salgo60) Added example of lines to template to get dynamic extra rows if a NAD number is available.... https://www.familysearch.org/wiki/en/index.php?title=Template:Sweden-NAD2&acti... [08:25:06] (03CR) 10Umherirrender: [C: 032] build: run banana-checker [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/468391 (owner: 10Umherirrender) [08:30:22] (03Merged) 10jenkins-bot: build: run banana-checker [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/468391 (owner: 10Umherirrender) [09:11:20] (03PS2) 10Umherirrender: Add missing limits to explode() where possible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/468526 (owner: 10Thiemo Kreuz (WMDE)) [09:11:25] (03CR) 10Umherirrender: [C: 032] Add missing limits to explode() where possible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/468526 (owner: 10Thiemo Kreuz (WMDE)) [09:25:53] (03Merged) 10jenkins-bot: Add missing limits to explode() where possible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/468526 (owner: 10Thiemo Kreuz (WMDE)) [09:28:42] (03CR) 10Daimona Eaytoy: [C: 04-1] "I checked again, and the best way to do this is probably to create a temporary table with the new data type, copy the old table in there, " [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/467116 (https://phabricator.wikimedia.org/T199507) (owner: 10Matěj Suchánek) [09:32:23] (03CR) 10jenkins-bot: Add missing limits to explode() where possible [extensions/Echo] - 10https://gerrit.wikimedia.org/r/468526 (owner: 10Thiemo Kreuz (WMDE)) [09:33:54] (03PS1) 10Umherirrender: build: Move phpcs ignore to .phpcs.xml [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/468694 [09:41:40] 10MediaWiki-Page-deletion, 10Operations, 10Performance: Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 (10TTO) [09:58:38] 10Google-Code-in-2018, 10Wikimedia-Site-requests, 10User-Urbanecm: Remove redundant wgMetaNamespaceTalk definitions - https://phabricator.wikimedia.org/T206952 (10Framawiki) Good link for me: https://codein.withgoogle.com/dashboard/tasks/5470221453230080/ [09:59:44] 10Google-Code-in-2018, 10Wikimedia-Site-requests, 10User-Urbanecm: Remove redundant wgMetaNamespaceTalk definitions - https://phabricator.wikimedia.org/T206952 (10Urbanecm) >>! In T206952#4682320, @Framawiki wrote: > Good link for me: https://codein.withgoogle.com/dashboard/tasks/5470221453230080/ This ling... [10:00:16] 10Google-Code-in-2018, 10Wikimedia-Site-requests, 10User-Urbanecm: Remove redundant wgMetaNamespaceTalk definitions - https://phabricator.wikimedia.org/T206952 (10Framawiki) >>! In T206952#4682323, @Urbanecm wrote: > This ling is available only to GCI mentors. Aklapper's link will be public after the contest... [10:07:12] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.32-release, 10User-Daimona: Bundle AbuseFilter extension with MW 1.32 - https://phabricator.wikimedia.org/T191740 (10Daimona) [10:09:22] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.32-release, 10User-Daimona: Bundle AbuseFilter extension with MW 1.32 - https://phabricator.wikimedia.org/T191740 (10Daimona) Works with web installer. The DB part is dependent on several tasks, so it won't probably be completed too soon. As for the user rights,... [10:10:12] 10Google-Code-in-2018, 10Commons-Mass-Description, 10User-Urbanecm: Use new system of getting localized messages in Commons Mass Description - https://phabricator.wikimedia.org/T206852 (10Urbanecm) [10:10:14] 10Google-Code-in-2018, 10Map-of-monuments, 10User-Urbanecm: Use new system of getting localized messages in Map of Monuments - https://phabricator.wikimedia.org/T206850 (10Urbanecm) [10:10:17] 10Google-Code-in-2018, 10Weapon of Mass Description, 10User-Urbanecm: Use new system of getting localized messages in Weapon of Mass Description - https://phabricator.wikimedia.org/T206854 (10Urbanecm) [11:04:43] 10MediaWiki-Database, 10MW-1.32-release: Dropping tables during a update should be made optional - https://phabricator.wikimedia.org/T207516 (10Reedy) >We dropped DROP from wikiadmin for security reasons. Why? This is why we have a distinction of two different users.... ```lang=php /** * Database username... [11:47:00] (03PS3) 10Pwirth: build: Updating npm dependencies for security issues [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/465895 (owner: 10Libraryupgrader) [11:47:04] (03PS4) 10Pwirth: build: Updating npm dependencies for security issues [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/465877 (owner: 10Libraryupgrader) [12:03:31] (03PS1) 10Daimona Eaytoy: Rearrange config to provide better experience [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/468696 (https://phabricator.wikimedia.org/T191740) [12:11:07] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Need-volunteer, 10Regression: References aren't readable to logged-out users on Wikidata when an item is protected - https://phabricator.wikimedia.org/T186006 (10Liuxinyu970226) and even logged-in users also faced-to-faced this issue [12:17:18] (03CR) 10Legoktm: [C: 032] Minor formatting cleanups [php/excimer] - 10https://gerrit.wikimedia.org/r/468617 (owner: 10Anomie) [12:17:49] (03Merged) 10jenkins-bot: Minor formatting cleanups [php/excimer] - 10https://gerrit.wikimedia.org/r/468617 (owner: 10Anomie) [12:19:59] 10MediaWiki-General-or-Unknown: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10DonPaolo) [12:25:51] (03PS4) 10Pwirth: Remove bs_aftercontent readers, as is not supported by 3.0.0 skin... [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/468531 [12:28:47] 10MediaWiki-General-or-Unknown: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10DonPaolo) [12:32:16] 10MediaWiki-Email: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10Reedy) [12:33:11] (03PS1) 10Pwirth: Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 [12:33:23] 10Accessibility, 10Wikipedia-iOS-App-Backlog, 10iOS-app-Bugs, 10iOS-app-feature-Accessibility: In iOS the table of contents of Wikipedia or Wiktionary is not shown - https://phabricator.wikimedia.org/T207459 (10Yoshiciv) Thank you for the correction. [12:34:02] (03CR) 10jerkins-bot: [V: 04-1] Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 (owner: 10Pwirth) [12:34:46] (03PS2) 10Pwirth: Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 [12:35:34] (03CR) 10jerkins-bot: [V: 04-1] Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 (owner: 10Pwirth) [12:39:03] (03PS1) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] - 10https://gerrit.wikimedia.org/r/468699 (https://phabricator.wikimedia.org/T207541) [12:40:59] (03PS3) 10Pwirth: Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 [12:41:53] (03CR) 10jerkins-bot: [V: 04-1] Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 (owner: 10Pwirth) [12:45:00] (03PS4) 10Pwirth: Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 [12:45:35] (03PS4) 10D3r1ck01: Fix $IP value when directory is a symlink [core] - 10https://gerrit.wikimedia.org/r/466865 (https://phabricator.wikimedia.org/T203061) [12:46:06] (03PS5) 10D3r1ck01: [NOT TESTED] Fix $IP value when directory is a symlink [core] - 10https://gerrit.wikimedia.org/r/466865 (https://phabricator.wikimedia.org/T203061) [12:46:08] (03CR) 10jerkins-bot: [V: 04-1] Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 (owner: 10Pwirth) [12:48:44] (03PS6) 10D3r1ck01: [NOT TESTED] Fix $IP value when directory is a symlink [core] - 10https://gerrit.wikimedia.org/r/466865 (https://phabricator.wikimedia.org/T203061) [12:49:10] (03PS5) 10Pwirth: Move from gitlab to gerrit, as this is included in BS free [extensions/BlueSpiceUserSidebar] - 10https://gerrit.wikimedia.org/r/468698 [12:53:29] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/468306 (owner: 10Pwirth) [12:57:39] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) [12:57:52] (03CR) 10jerkins-bot: [V: 04-1] Replace usage of deprecated BsExtensionMW [extensions/BlueSpiceCountThings] - 10https://gerrit.wikimedia.org/r/468306 (owner: 10Pwirth) [12:58:32] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:02:43] (03PS2) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) [13:20:18] 10Wikimedia-Site-requests, 10Chinese-Sites: Create namespace aliases in zhwikiversity - https://phabricator.wikimedia.org/T207544 (10A2093064) [13:22:41] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:23:09] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468701 (https://phabricator.wikimedia.org/T207540) [13:23:22] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468702 (https://phabricator.wikimedia.org/T207540) [13:24:05] (03CR) 10Jforrester: [C: 032] Replace deprecated untidy OutputPage::addWikiText() method [extensions/Math] - 10https://gerrit.wikimedia.org/r/468039 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [13:24:43] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) [13:24:53] (03CR) 10Jforrester: [C: 032] Replace deprecated untidy OutputPage::addWikiText() method [extensions/Collection] - 10https://gerrit.wikimedia.org/r/468020 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [13:25:01] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468704 (https://phabricator.wikimedia.org/T207540) [13:25:57] (03PS2) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468704 (https://phabricator.wikimedia.org/T207540) [13:26:01] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468704 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:26:18] (03PS2) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) [13:26:23] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:26:45] (03PS2) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468702 (https://phabricator.wikimedia.org/T207540) [13:26:58] (03CR) 10Reedy: [C: 032] "No changelog as no release yet" [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468701 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:27:46] (03PS1) 10Reedy: Include IP address in "Login for $1 succeeded" log entry [core] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468705 (https://phabricator.wikimedia.org/T207540) [13:27:58] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468705 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:31:17] 10Phabricator: Remove/Reduce bug report header - https://phabricator.wikimedia.org/T207525 (10Krenair) I don't see that when editing this task. It's possible it goes away when you have certain permissions. [13:33:57] (03CR) 10Reedy: [C: 032] Include IP address in "Login for $1 succeeded" log entry [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468702 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:44:54] (03PS19) 10Daimona Eaytoy: Stop hardcoding the list of undeletable logs and effectively prevent their deletion [core] - 10https://gerrit.wikimedia.org/r/445999 [13:45:57] (03CR) 10jerkins-bot: [V: 04-1] Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:51:14] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468705 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:53:01] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:54:23] 10Excimer, 10Core Platform Team Kanban (Doing), 10PHP 7.1 support, 10Patch-For-Review, 10Performance-Team (Radar): Excimer: new profiler for PHP - https://phabricator.wikimedia.org/T205059 (10Legoktm) [13:55:06] (03Merged) 10jenkins-bot: Replace deprecated untidy OutputPage::addWikiText() method [extensions/Math] - 10https://gerrit.wikimedia.org/r/468039 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [13:55:08] (03Merged) 10jenkins-bot: Replace deprecated untidy OutputPage::addWikiText() method [extensions/Collection] - 10https://gerrit.wikimedia.org/r/468020 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [13:55:15] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468704 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:55:20] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:55:25] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468701 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:55:30] (03Merged) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468702 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:57:01] (03PS1) 10Daimona Eaytoy: Use string cast for Postgres compatibility [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/468706 (https://phabricator.wikimedia.org/T42757) [13:58:35] (03CR) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] - 10https://gerrit.wikimedia.org/r/468700 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [13:59:43] (03PS2) 10Daimona Eaytoy: Fix function name in doc comment [core] - 10https://gerrit.wikimedia.org/r/466841 [14:00:04] (03CR) 10jenkins-bot: Replace deprecated untidy OutputPage::addWikiText() method [extensions/Math] - 10https://gerrit.wikimedia.org/r/468039 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [14:01:42] (03CR) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468703 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [14:02:02] (03CR) 10jenkins-bot: Replace deprecated untidy OutputPage::addWikiText() method [extensions/Collection] - 10https://gerrit.wikimedia.org/r/468020 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [14:03:22] (03CR) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468704 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [14:05:13] (03CR) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468701 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [14:09:25] (03CR) 10jenkins-bot: Include IP address in "Login for $1 succeeded" log entry [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468702 (https://phabricator.wikimedia.org/T207540) (owner: 10Reedy) [14:09:54] (03PS1) 10Legoktm: Add LICENSE [php/excimer] - 10https://gerrit.wikimedia.org/r/468707 [14:19:14] 10MediaWiki-Database, 10MW-1.32-release: Dropping tables during a update should be made optional - https://phabricator.wikimedia.org/T207516 (10Paladox) 05Open>03declined Oh, didn't realise there's multiple configs for this. And the reason why is we have two groups mw-admins and ops, Ops should only be a... [14:22:17] 10AbuseFilter, 10PostgreSQL, 10SQLite: Add support for SQLite and postgre when searching patterns - https://phabricator.wikimedia.org/T193068 (10Daimona) I'm also wondering whether the cast to char needs to be rewritten to be DBMS-independent. [14:26:33] 10GraphQL: GraphQL service should redirect http to https - https://phabricator.wikimedia.org/T206932 (10dbarratt) a:03dbarratt [14:32:41] 10AbuseFilter, 10Wikimedia-production-error: BadMethodCallException when viewing some AbuseLog entries - https://phabricator.wikimedia.org/T207545 (10Daimona) [14:32:47] 10AbuseFilter, 10Wikimedia-production-error: BadMethodCallException when viewing some AbuseLog entries - https://phabricator.wikimedia.org/T207545 (10Daimona) p:05Triage>03High [14:36:52] 04(no projects): Exit curation mode not available - https://phabricator.wikimedia.org/T207546 (10Vexations) [14:40:44] 10MediaWiki-Email, 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10DonPaolo) In a similar way, in line 312: ``` $headers['Reply-To'] = $replyto->address; ``` [14:42:31] 10MediaWiki-Email, 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10DonPaolo) line 4101 too: ``` $headers['To'] = $to[0]->address; ``` line 291: ``` $headers['From'] = $from->address; ``` [14:42:58] 10Patch-For-Review, 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearDeleteKeyDownHandler - https://phabricator.wikimedia.org/T207078 (10Esanders) Coverage is at 90/98 (91.84%) after the above two patches. [14:59:06] 10Growth-Team (Current Sprint), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10Patch-For-Review: Use object stash for persisting last-use proprety to control curation toolbar display - https://phabricator.wikimedia.org/T206580 (10Xaosflux) @kostajh lo... [15:01:52] 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler - https://phabricator.wikimedia.org/T207079 (10Esanders) a:03Esanders [15:03:32] 10Patch-For-Review, 10VisualEditor (Current work): Increase unit test coverage in ve.ce.LinearEnterKeyDownHandler - https://phabricator.wikimedia.org/T207079 (10Esanders) Increases to 77/93 (82.8%) after the above patch. [15:07:44] (03PS1) 10Isarra: Set mw version requirement to 1.31 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/468716 [15:14:40] 10UniversalLanguageSelector: cursor conflict in inputfields with Firefox when IPA input method is enabled. - https://phabricator.wikimedia.org/T207547 (10TheDJ) [15:22:36] 10MediaWiki-Email, 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10Reedy) >>! In T207541#4682592, @DonPaolo wrote: > In a similar way, in line 312: > > > ``` > $headers['Reply-To'] = $replyto->address; > ``` In master, there i... [15:23:11] (03PS2) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] - 10https://gerrit.wikimedia.org/r/468699 (https://phabricator.wikimedia.org/T207541) [15:26:10] (03PS1) 10D3r1ck01: Correct to "MediaWiki" in en.json and v2.1 release [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468717 [15:31:28] (03CR) 10D3r1ck01: [C: 032] Correct to "MediaWiki" in en.json and v2.1 release [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468717 (owner: 10D3r1ck01) [15:37:11] (03Merged) 10jenkins-bot: Correct to "MediaWiki" in en.json and v2.1 release [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468717 (owner: 10D3r1ck01) [15:41:07] (03PS4) 10Ori.livneh: Keep break positions in a vector, rather than a set [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/467890 [15:41:49] 10Patch-For-Review, 10VisualEditor (Current work): Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter - https://phabricator.wikimedia.org/T207080 (10Esanders) [15:42:04] (03CR) 10Ori.livneh: "Thanks for looking" (031 comment) [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/467890 (owner: 10Ori.livneh) [15:42:15] 10MediaWiki-Email, 10MW-1.31-release, 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10Legoktm) [15:43:49] 10Patch-For-Review, 10VisualEditor (Current work): Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter - https://phabricator.wikimedia.org/T207080 (10Esanders) Coverage after above patches is 127/130 (97.69%). [15:52:54] (03PS1) 10D3r1ck01: Fix invalid namespace for @covers in SGHooksTest [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468721 [15:54:24] 10GraphQL: Pass errors/warnings from the Action API back to the user - https://phabricator.wikimedia.org/T207349 (10dbarratt) I don't see an obvious way to do this, so I'm asking: https://github.com/apollographql/apollo-server/issues/1839 [15:54:41] (03PS1) 10HerrTaschenbier: Adding separate option for local API login [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/468722 [15:54:44] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/468722 (owner: 10HerrTaschenbier) [16:01:58] 10VisualEditor (Current work): [EPIC] Increase test coverage for VE.ce code - https://phabricator.wikimedia.org/T206138 (10Esanders) [16:02:51] (03CR) 10D3r1ck01: [C: 032] Fix invalid namespace for @covers in SGHooksTest [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468721 (owner: 10D3r1ck01) [16:03:35] 10GraphQL: Implement claim & claims on Entity - https://phabricator.wikimedia.org/T206933 (10dbarratt) [16:03:50] 10GraphQL: Implement claim & claims on Entity - https://phabricator.wikimedia.org/T206933 (10dbarratt) a:03dbarratt [16:07:09] 10VisualEditor (Current work): [EPIC] Increase test coverage for VE.ce code - https://phabricator.wikimedia.org/T206138 (10Esanders) After keydown tests improvements, CE coverage is at 3695/4762 (77.59%) [16:08:01] (03Merged) 10jenkins-bot: Fix invalid namespace for @covers in SGHooksTest [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/468721 (owner: 10D3r1ck01) [16:08:05] (03CR) 10HerrTaschenbier: [C: 031] "With this change you can configure the extension to allow API users to login locally while restricting all other users (i.e. people using " [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/468722 (owner: 10HerrTaschenbier) [16:09:37] 10VisualEditor (Current work): [EPIC] Increase test coverage for VE.ce code - https://phabricator.wikimedia.org/T206138 (10Esanders) [16:10:22] 10Patch-For-Review, 10VisualEditor (Current work): Increase unit test coverage in ve/ce/KeyDownHandlers : LinearEscape, LinearTab, TableArrow, TableDelete, TableEnter - https://phabricator.wikimedia.org/T207080 (10Esanders) a:03Esanders [16:22:34] 10AbuseFilter: Validate the abusefilter false-positives - https://phabricator.wikimedia.org/T194011 (10He7d3r) [16:29:01] (03PS1) 10Fomafix: Remove loading of module 'mediawiki.toc' in special pages [core] - 10https://gerrit.wikimedia.org/r/468723 [16:34:38] 10AbuseFilter: Disabling abuse filter triggers internal error message - https://phabricator.wikimedia.org/T207553 (10Cyberpower678) [16:35:46] 10AbuseFilter: Disabling abuse filter triggers internal error message - https://phabricator.wikimedia.org/T207553 (10Cyberpower678) [16:57:19] 10MediaWiki-User-management: Add clear information you're creating another account to Special:CreateAccount - https://phabricator.wikimedia.org/T207555 (10Urbanecm) [16:58:52] 10AbuseFilter, 10Wikimedia-production-error: Disabling abuse filter triggers internal error message - https://phabricator.wikimedia.org/T207553 (10Daimona) p:05Triage>03Unbreak! Not being able to disable filters is a great deal. Let's wait for the stacktrace, although I suspect this is T203336, which is al... [17:08:50] 10AbuseFilter, 10Wikimedia-production-error: Disabling abuse filter triggers internal error message - https://phabricator.wikimedia.org/T207553 (10Krenair) [17:08:57] 10AbuseFilter, 10Core Platform Team, 10Patch-For-Review, 10Wikimedia-maintenance-script-run, 10Wikimedia-production-error: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null - https://phabricator.wikimedia.org/T203336 (10Krenair) [17:09:08] 10AbuseFilter, 10Wikimedia-production-error: Disabling abuse filter triggers internal error message - https://phabricator.wikimedia.org/T207553 (10Krenair) (Reedy confirms this is `Column 'afa_parameters' cannot be null`) [17:19:53] 10MediaWiki-extensions-PageCuration, 10Growth-Team: Exit curation mode not available - https://phabricator.wikimedia.org/T207546 (10Reedy) [17:20:34] 10MediaWiki-Authentication-and-authorization, 10Security: "Login for $1 succeeded" should include IP information - https://phabricator.wikimedia.org/T207540 (10Reedy) 05Open>03Resolved a:03Legoktm [17:20:39] 10MediaWiki-Authentication-and-authorization, 10Security: "Login for $1 succeeded" should include IP information - https://phabricator.wikimedia.org/T207540 (10Reedy) [17:32:48] 10GraphQL: Implement claims on Entity - https://phabricator.wikimedia.org/T206933 (10dbarratt) [17:35:35] (03PS1) 10D3r1ck01: File based checks and array invalidations [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/468725 [17:36:40] (03PS2) 10D3r1ck01: File based checks and array invalidations [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/468725 [17:38:53] (03CR) 10jerkins-bot: [V: 04-1] File based checks and array invalidations [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/468725 (owner: 10D3r1ck01) [17:39:53] (03PS3) 10D3r1ck01: File based checks and array invalidations [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/468725 [17:41:12] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (10Huji) [17:42:32] 10MediaWiki-extensions-PdfHandler, 10Commons, 10Multimedia, 10Thumbor: Non-rendering of thumbnail of compressed pdf in Commons - https://phabricator.wikimedia.org/T196961 (10Jan.Kamenicek) I have just experienced the same problem also with a djvu file: https://commons.wikimedia.org/wiki/File:Modernczechpoe... [17:52:14] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (10Huji) [17:54:29] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (10Huji) Importing the list of eligible voters can be done right now. Sunfyre has run the [[ https://quarry.wmflabs.org/query/30494 | query ]] and I am attaching a clean version of the output.{F26... [17:57:35] 10MinervaNeue, 10MobileFrontend: php warning Declaration of ... should be compatible with ... in skin Minerva - https://phabricator.wikimedia.org/T207561 (10Paladox) [18:02:27] 10MinervaNeue, 10MobileFrontend: php warning Declaration of ... should be compatible with ... in skin Minerva - https://phabricator.wikimedia.org/T207561 (10Paladox) 05Open>03declined Was on the wrong branch in the skin [18:08:09] 10MediaWiki-Logging: Implement "links-in-logs" user script in MediaWiki itself - https://phabricator.wikimedia.org/T207562 (10Legoktm) [18:08:18] 10MediaWiki-extensions-PdfHandler, 10Commons, 10Multimedia, 10Thumbor: Non-rendering of thumbnail of compressed pdf in Commons - https://phabricator.wikimedia.org/T196961 (10Jan.Kamenicek) I uploaded another version of the same djvu file, which is fine. The original problematic version (which worked well i... [18:09:20] 10Growth-Team, 10StructuredDiscussions, 10PHP 7.2 support: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php - https://phabricator.wikimedia.org/T207563 (10RazeSoldier) [18:10:59] 10Growth-Team, 10StructuredDiscussions, 10PHP 7.2 support: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php - https://phabricator.wikimedia.org/T207563 (10RazeSoldier) [18:11:16] 10Growth-Team, 10StructuredDiscussions, 10PHP 7.2 support: count(): Parameter must be an array or an object that implements Countable in Flow/includes/TemplateHelper.php - https://phabricator.wikimedia.org/T207563 (10RazeSoldier) [18:14:23] (03PS1) 10Urbanecm: [bugfix] Replace ticket.summary with ticket.name in ticket_table.html [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468726 [18:15:03] 10MediaWiki-History-or-Diffs: Implement "link-section-edits" user script in MediaWiki itself - https://phabricator.wikimedia.org/T207565 (10Legoktm) [18:24:13] 10MediaWiki-extension-requests: Implement "reply-link" user script in a MediaWiki extension - https://phabricator.wikimedia.org/T207567 (10Legoktm) [18:25:16] 10MediaWiki-General-or-Unknown: Integrate Enterprisey's user scripts into MediaWiki proper - https://phabricator.wikimedia.org/T207569 (10Legoktm) [18:25:39] 10MediaWiki-Logging: Implement "links-in-logs" user script in MediaWiki itself - https://phabricator.wikimedia.org/T207562 (10Legoktm) [18:25:41] 10MediaWiki-General-or-Unknown: Integrate Enterprisey's user scripts into MediaWiki proper - https://phabricator.wikimedia.org/T207569 (10Legoktm) [18:42:43] 10AbuseFilter, 10Core Platform Team, 10MW-1.32-release, 10Patch-For-Review, and 2 others: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null - https://phabricator.wikimedia.org/T203336 (10Paladox) [18:47:22] (03PS7) 10D3r1ck01: Fix Echo related namespace issue in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/465320 [18:47:45] (03CR) 10jerkins-bot: [V: 04-1] Fix Echo related namespace issue in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/465320 (owner: 10D3r1ck01) [18:47:48] (03CR) 10jerkins-bot: [V: 04-1] Fix Echo related namespace issue in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/465320 (owner: 10D3r1ck01) [18:52:15] (03PS1) 10Fomafix: Replace http://be-x-old. by https://be-tarask. [core] - 10https://gerrit.wikimedia.org/r/468729 [18:55:26] (03PS1) 10Jayprakash12345: Add COC.md [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468731 [18:56:20] (03CR) 10Jayprakash12345: [V: 031 C: 031] Add COC.md [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468731 (owner: 10Jayprakash12345) [18:58:47] (03PS1) 10Jayprakash12345: Init commit [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 [19:01:54] (03PS2) 10Jayprakash12345: Init commit [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 [19:03:56] (03CR) 10Urbanecm: [C: 032] [bugfix] Replace ticket.summary with ticket.name in ticket_table.html [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468726 (owner: 10Urbanecm) [19:04:06] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (104nn1l2) I have already contacted @Jrbs asking him to create an account for @revi on votewiki as the scrutineer of the elections and to unblock my own account there. I will serve as the coordina... [19:05:35] (03Merged) 10jenkins-bot: [bugfix] Replace ticket.summary with ticket.name in ticket_table.html [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468726 (owner: 10Urbanecm) [19:10:57] (03CR) 10Mainframe98: "The translation for the magic word for Dutch (nl) would be" (0311 comments) [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 (owner: 10Jayprakash12345) [19:16:29] (03PS1) 10Umherirrender: Use "." for string concat in JsonSchema.php [extensions/JsonData] - 10https://gerrit.wikimedia.org/r/468733 [19:19:13] 10Repository-Admins: wikimedia-cz-tracker is overspamming with X mentioned in commit Y - https://phabricator.wikimedia.org/T207422 (10Reedy) I can't [19:29:47] 10ContentTranslation: CX2: Translating a paragraph with a footnote shows only the footnote and not the text - https://phabricator.wikimedia.org/T207570 (10Amire80) [19:31:50] 10ContentTranslation: CX2: Translating a paragraph with a footnote shows only the footnote and not the text - https://phabricator.wikimedia.org/T207570 (10Amire80) [19:32:57] (03PS1) 10Umherirrender: Add alias file for special pages [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/468734 [19:33:29] 10Repository-Admins: wikimedia-cz-tracker is overspamming with X mentioned in commit Y - https://phabricator.wikimedia.org/T207422 (10Krenair) 05Open>03Resolved a:03Krenair Done, please verify [19:37:52] (03CR) 10Legoktm: Init commit (036 comments) [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 (owner: 10Jayprakash12345) [19:51:03] 10MediaWiki-Codesniffer, 10Patch-For-Review: Warn if using + to concat strings - https://phabricator.wikimedia.org/T195683 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [19:56:14] (03PS3) 10Umherirrender: Fix typo in includes/watcheditem/WatchItemStoreInterface.php [core] - 10https://gerrit.wikimedia.org/r/468671 (owner: 10D3r1ck01) [19:56:18] (03CR) 10Umherirrender: [C: 032] Fix typo in includes/watcheditem/WatchItemStoreInterface.php [core] - 10https://gerrit.wikimedia.org/r/468671 (owner: 10D3r1ck01) [20:01:42] 10Google-Code-in-2018, 10MediaWiki-extensions-ConfirmAccount: Edit requestaccount-email-body-admin to include more information - https://phabricator.wikimedia.org/T181399 (10Platonides) Assigned, @Aklapper [20:01:44] (03CR) 10Umherirrender: "I am not sure but it seems this is some doxygen magic to generate a paragraph - https://doc.wikimedia.org/mediawiki-core/master/php/classA" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/468553 (owner: 10D3r1ck01) [20:03:16] (03CR) 10D3r1ck01: Clean extra spaces in includes/Action.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/468553 (owner: 10D3r1ck01) [20:04:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/468737 (owner: 10L10n-bot) [20:06:25] 10Cleanup, 10MassAction, 10Repository-Admins: Archive MassAction mediawiki extension - https://phabricator.wikimedia.org/T207137 (10Krenair) #Repository-Admins is for Diffusion administration, I don't think this task is relevant unless you want rEMSA deactivated? [20:06:45] (03PS3) 10TheDJ: New account creation step to confirm registration without email [core] - 10https://gerrit.wikimedia.org/r/468474 (https://phabricator.wikimedia.org/T159837) [20:07:26] (03CR) 10TheDJ: New account creation step to confirm registration without email (034 comments) [core] - 10https://gerrit.wikimedia.org/r/468474 (https://phabricator.wikimedia.org/T159837) (owner: 10TheDJ) [20:08:12] 10Cleanup, 10MassAction, 10Repository-Admins: Archive MassAction mediawiki extension - https://phabricator.wikimedia.org/T207137 (10Krenair) {rEMSA} [20:14:08] 10MediaWiki-extensions-PropertySuggester, 10Diffusion, 10Repository-Admins, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627 (10Krenair) Doesn't link there anymore;... [20:14:40] (03PS1) 10Urbanecm: Add CODE_OF_CONDUCT [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/468738 [20:15:02] (03CR) 10Urbanecm: [C: 032] Add CODE_OF_CONDUCT [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/468738 (owner: 10Urbanecm) [20:15:45] (03PS1) 10Urbanecm: Add CODE_OF_CONDUCT.md [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468739 [20:16:10] (03CR) 10Urbanecm: [C: 032] Add CODE_OF_CONDUCT.md [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468739 (owner: 10Urbanecm) [20:16:18] (03Merged) 10jenkins-bot: Fix typo in includes/watcheditem/WatchItemStoreInterface.php [core] - 10https://gerrit.wikimedia.org/r/468671 (owner: 10D3r1ck01) [20:16:34] (03Merged) 10jenkins-bot: Add CODE_OF_CONDUCT.md [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468739 (owner: 10Urbanecm) [20:16:48] (03PS1) 10Urbanecm: Add CODE_OF_CONDUCT.md [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468740 [20:17:05] (03CR) 10jerkins-bot: [V: 04-1] New account creation step to confirm registration without email [core] - 10https://gerrit.wikimedia.org/r/468474 (https://phabricator.wikimedia.org/T159837) (owner: 10TheDJ) [20:17:13] (03CR) 10Urbanecm: [C: 032] Add CODE_OF_CONDUCT.md [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468740 (owner: 10Urbanecm) [20:17:45] (03CR) 10Urbanecm: [V: 032 C: 032] Add CODE_OF_CONDUCT [wikimedia-cz/mediawiki-config] - 10https://gerrit.wikimedia.org/r/468738 (owner: 10Urbanecm) [20:18:41] (03Merged) 10jenkins-bot: Add CODE_OF_CONDUCT.md [wikimedia-cz/tracker] - 10https://gerrit.wikimedia.org/r/468740 (owner: 10Urbanecm) [20:19:03] (03CR) 10jenkins-bot: Fix typo in includes/watcheditem/WatchItemStoreInterface.php [core] - 10https://gerrit.wikimedia.org/r/468671 (owner: 10D3r1ck01) [20:20:17] (03CR) 10Legoktm: [C: 032] Don't pass a MailAddress pass the email to mail() [core] - 10https://gerrit.wikimedia.org/r/468699 (https://phabricator.wikimedia.org/T207541) (owner: 10Reedy) [20:22:30] 10MediaWiki-extensions-PropertySuggester, 10Diffusion, 10Repository-Admins, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627 (10Krenair) https://www.mediawiki.org/wiki/Git/Creating_new_repositories#Step_6:_Setup_mirror_on... [20:23:33] (03PS3) 10D3r1ck01: Clean extra spaces in includes/Action.php [core] - 10https://gerrit.wikimedia.org/r/468553 [20:26:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10MW-1.32-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10goodfirstbug: [Bug] Special:SetSiteLink shows the form twice after an error - https://phabricator.wikimedia.org/T186788 (10Fomafix) [20:28:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/468743 (owner: 10L10n-bot) [20:32:32] 10MediaWiki-extensions-PropertySuggester, 10Diffusion, 10Repository-Admins, 10Wikidata: mediawiki.org browse file tree link for PropertySuggester to phabricator fails - https://phabricator.wikimedia.org/T183627 (10Krenair) 05Open>03Resolved a:03Krenair {rEPS} [20:34:27] (03Merged) 10jenkins-bot: Don't pass a MailAddress pass the email to mail() [core] - 10https://gerrit.wikimedia.org/r/468699 (https://phabricator.wikimedia.org/T207541) (owner: 10Reedy) [20:34:32] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (10Huji) [20:35:01] 10Wikimedia-Site-requests: Set up VoteWiki for the 2018 fawiki elections - https://phabricator.wikimedia.org/T207560 (10Huji) Sounds good. [20:35:26] 10Repository-Admins, 10Wikidata-Termbox-Iteration1, 10Wikidata-Termbox-Iteration-2: No repository URI(s) set for wikibase-termbox - https://phabricator.wikimedia.org/T207042 (10Krenair) 05Open>03Resolved a:03Krenair I have set https://phabricator.wikimedia.org/diffusion/WBTB/uri/view/20674/ to visible. [20:36:21] (03CR) 10jerkins-bot: [V: 04-1] Localisation updates from https://translatewiki.net. [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/468773 (owner: 10L10n-bot) [20:37:06] (03CR) 10jenkins-bot: Don't pass a MailAddress pass the email to mail() [core] - 10https://gerrit.wikimedia.org/r/468699 (https://phabricator.wikimedia.org/T207541) (owner: 10Reedy) [20:38:21] (03CR) 10D3r1ck01: "@Uhmerirrender, done!" [core] - 10https://gerrit.wikimedia.org/r/468553 (owner: 10D3r1ck01) [20:38:33] 10MediaWiki-Page-deletion, 10Core Platform Team ( Code Health (TEC13)), 10Core Platform Team Kanban (Doing), 10MW-1.32-notes (WMF-deploy-2018-10-16 (1.32.0-wmf.26)), and 2 others: Mediawiki page deletions should happen in batches of revisions - https://phabricator.wikimedia.org/T198176 (10Izno) This works... [20:39:05] 10MediaWiki-Page-deletion, 10Operations, 10Performance: Deleting pages on the English Wikipedia is very slow - https://phabricator.wikimedia.org/T207530 (10Izno) This might possibly be caused by the work for {T198176}. [20:41:15] (03PS1) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468774 (https://phabricator.wikimedia.org/T207541) [20:41:27] (03PS1) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468775 (https://phabricator.wikimedia.org/T207541) [20:41:40] (03PS1) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468776 (https://phabricator.wikimedia.org/T207541) [20:41:50] Reedy: I wasn't able to find the other issues that they reported that are fixed [20:41:51] (03PS1) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468777 (https://phabricator.wikimedia.org/T207541) [20:42:33] legoktm: I wondered if it was someone who wasn't a prorgammer and it just looks odd to them [20:43:02] 10Repository-Admins, 10Thumbor: Move Thumbor Plugins code review from Differential to Gerrit - https://phabricator.wikimedia.org/T204702 (10Krenair) a:03Krenair [20:44:23] (03PS2) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/468775 (https://phabricator.wikimedia.org/T207541) [20:44:27] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Patch-For-Review: function mw.toolbar.insertTags does not work with CodeMirror in Chrome and IE - https://phabricator.wikimedia.org/T164905 (10Perhelion) 05Resolved>03Open [20:44:40] (03PS2) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_30) - 10https://gerrit.wikimedia.org/r/468776 (https://phabricator.wikimedia.org/T207541) [20:44:58] (03PS2) 10Reedy: Don't pass a MailAddress pass the email to mail() [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/468777 (https://phabricator.wikimedia.org/T207541) [20:48:18] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Patch-For-Review: function mw.toolbar.insertTags does not work with CodeMirror in Chrome and IE - https://phabricator.wikimedia.org/T164905 (10Perhelion) I reopened this task as this is not resolved on [[https://de.wikipedia.org/wiki/Wikipedia:Fragen_zur... [20:48:54] 10Repository-Admins, 10Thumbor: Move Thumbor Plugins code review from Differential to Gerrit - https://phabricator.wikimedia.org/T204702 (10Krenair) I've done the admin part, just waiting for the Phabricator daemon to catch up and pull/import the latest commit from Gerrit. I did prioritise it. [20:50:18] (03PS3) 10Jayprakash12345: Init commit [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 [20:50:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/468753 (owner: 10L10n-bot) [20:51:32] 10Phabricator, 10Gerrit, 10Release-Engineering-Team (Someday): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10Krenair) [20:51:33] 10Repository-Admins, 10Thumbor: Move Thumbor Plugins code review from Differential to Gerrit - https://phabricator.wikimedia.org/T204702 (10Krenair) 05Open>03Resolved Well it's done, though Harbormaster is still running there. [20:54:18] 10Repository-Admins, 10Thumbor: Move Thumbor Plugins code review from Differential to Gerrit - https://phabricator.wikimedia.org/T204702 (10Krenair) I've removed #meta-ci-jessie from it so it shouldn't do that now. [20:56:53] (03CR) 10Jayprakash12345: Init commit (0314 comments) [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 (owner: 10Jayprakash12345) [20:58:11] (03PS4) 10Jayprakash12345: Init commit [extensions/CountDownClock] - 10https://gerrit.wikimedia.org/r/468732 [21:01:01] (03PS1) 10Urbanecm: Add fileOrganizer group [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468779 [21:01:06] (03PS1) 10Urbanecm: Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 [21:02:22] (03PS1) 10Urbanecm: [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 [21:02:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/468766 (owner: 10L10n-bot) [21:02:40] (03CR) 10jerkins-bot: [V: 04-1] [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 (owner: 10Urbanecm) [21:05:03] (03PS2) 10Urbanecm: [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 [21:05:14] (03PS2) 10Urbanecm: [update_teamdrive_list] Add fileOrganizer group [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468779 [21:05:50] (03PS2) 10Urbanecm: [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 [21:09:08] (03PS3) 10Urbanecm: [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 [21:09:26] (03CR) 10jerkins-bot: [V: 04-1] [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 (owner: 10Urbanecm) [21:15:35] (03PS4) 10Urbanecm: [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 [21:19:41] (03PS1) 10D3r1ck01: Fix countable PHP 7.2 error in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) [21:23:00] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) (owner: 10D3r1ck01) [21:23:43] (03PS2) 10D3r1ck01: Fix countable PHP 7.2 error in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) [21:25:36] (03CR) 10Urbanecm: [C: 032] [update_teamdrive_list] Add fileOrganizer group [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468779 (owner: 10Urbanecm) [21:25:43] (03CR) 10Urbanecm: [C: 032] [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 (owner: 10Urbanecm) [21:25:52] (03CR) 10Urbanecm: [C: 032] [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 (owner: 10Urbanecm) [21:25:54] (03Merged) 10jenkins-bot: [update_teamdrive_list] Add fileOrganizer group [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468779 (owner: 10Urbanecm) [21:26:02] (03Merged) 10jenkins-bot: [update_teamdrive_list] Update onwiki configuration on script run [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468781 (owner: 10Urbanecm) [21:26:04] (03CR) 10jerkins-bot: [V: 04-1] [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 (owner: 10Urbanecm) [21:30:51] (03PS3) 10Urbanecm: [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 [21:31:46] (03CR) 10Urbanecm: [C: 032] [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 (owner: 10Urbanecm) [21:32:11] (03Merged) 10jenkins-bot: [update_teamdrive_list] Update two user group names, to match new Google's terminology [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468780 (owner: 10Urbanecm) [21:33:03] (03PS1) 10Urbanecm: Revert "[update_teamdrive_list] Update onwiki configuration on script run" [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468783 [21:33:11] (03CR) 10Urbanecm: [V: 032 C: 032] Revert "[update_teamdrive_list] Update onwiki configuration on script run" [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468783 (owner: 10Urbanecm) [21:33:21] (03PS1) 10D3r1ck01: Explicit "use" namespace statement for MediaWikiTestCase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468784 [21:33:53] 10MediaWiki-Email, 10MW-1.31-release, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10DonPaolo) I'd like to be wrong, but the toString() method doesn't return the email address but... [21:36:51] 10MediaWiki-Email, 10MW-1.31-release, 10MW-1.33-notes (1.33.0-wmf.1; 2018-10-23), 10Patch-For-Review: php mail() to argument is MailAddress Object instead of string - https://phabricator.wikimedia.org/T207541 (10Reedy) ```lang=php /** * Return formatted and quoted address to insert into SMTP headers *... [21:37:56] (03PS1) 10Urbanecm: Revert "Revert "[update_teamdrive_list] Update onwiki configuration on script run"" [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468785 [21:38:18] (03CR) 10Urbanecm: [C: 04-2] "Currently: Nothing was actually fixed." [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468785 (owner: 10Urbanecm) [21:56:11] 10Google-Code-in-2018, 10WMCZ-Tracker: Add link to export/import to index page of Tracker - https://phabricator.wikimedia.org/T207575 (10Urbanecm) [21:56:34] 10MediaWiki-General-or-Unknown, 10MediaWiki-extension-requests: Integrate Enterprisey's user scripts into MediaWiki proper - https://phabricator.wikimedia.org/T207569 (10Izno) [21:58:24] 10Google-Code-in-2018, 10WMCZ-Tracker: Add link to export/import to index page of Tracker - https://phabricator.wikimedia.org/T207575 (10Urbanecm) [22:19:21] 10Wikimedia-SVG-rendering, 10Upstream: librsvg does not shift from bold to normal font-weight - https://phabricator.wikimedia.org/T207506 (10Perhelion) I could swear I saw this bug long time before, as every style property with **normal** is ignored. [22:31:26] (03PS1) 10Reedy: Reduce complexity of MailAddress->toString() [core] - 10https://gerrit.wikimedia.org/r/468786 [22:31:34] 10GitHub-Mirrors, 10Security-team-backlog: Dealing with GitHub security alerts - https://phabricator.wikimedia.org/T180877 (10Aklapper) When it comes to creating [non-public] tasks per email, T87611 comes to my mind... [22:33:09] 10Wikimedia-SVG-rendering, 10Upstream: SVG rendering may be "ignoring manual kerning" (TSpanElement attributes not fully supported)... - https://phabricator.wikimedia.org/T126175 (10Perhelion) This is a duplicate of T35245 [22:35:10] 10Wikimedia-SVG-rendering, 10Upstream: SVG rendering may be "ignoring manual kerning" (TSpanElement attributes not fully supported)... - https://phabricator.wikimedia.org/T126175 (10Perhelion) [22:35:16] 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning in SVG rasterization (text/tspan x/y attribute; upstream) - https://phabricator.wikimedia.org/T35245 (10Perhelion) [22:36:52] (03CR) 10Reedy: [C: 032] Add COALESCE for image deletion and imgcomment_description_id [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468478 (https://phabricator.wikimedia.org/T207419) (owner: 10Paladox) [22:38:16] 10Wikimedia-SVG-rendering, 10Upstream: librsvg does not shift from bold to normal font-weight - https://phabricator.wikimedia.org/T207506 (10Aklapper) [22:40:22] (03CR) 10Gergő Tisza: T184543: This fixes the parse error. (031 comment) [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/468383 (owner: 10Alexia) [22:40:42] 10Wikimedia-SVG-rendering, 10Upstream: Incorrect text positioning/kerning in SVG rendering (text/tspan x/y, dx/dy attribute; upstream) - https://phabricator.wikimedia.org/T35245 (10Perhelion) [22:46:34] 10MediaWiki-Maintenance-scripts, 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth: `resetUserEmail.php` not applying email change to CentralAuth - https://phabricator.wikimedia.org/T207556 (10Jalexander) FYI the "old" method of using eval.php ( see https://wikitech.wikimedia.org/wiki/Password_... [22:47:11] 10Cleanup, 10MassAction, 10Repository-Admins: Archive MassAction mediawiki extension - https://phabricator.wikimedia.org/T207137 (10Dinoguy1000) [22:48:29] 10Cleanup, 10MassAction, 10Repository-Admins: Archive MassAction mediawiki extension - https://phabricator.wikimedia.org/T207137 (10Dinoguy1000) I've added the #cleanup worklist to the OP, though I haven't filled in anything on it yet; @Addshore, could you please fill in the "rationale" section? [22:49:03] (03PS1) 10Reedy: Output Done! at end of resetUserEmail.php [core] - 10https://gerrit.wikimedia.org/r/468787 [22:49:19] (03Merged) 10jenkins-bot: Add COALESCE for image deletion and imgcomment_description_id [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468478 (https://phabricator.wikimedia.org/T207419) (owner: 10Paladox) [22:52:52] (03CR) 10jenkins-bot: Add COALESCE for image deletion and imgcomment_description_id [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468478 (https://phabricator.wikimedia.org/T207419) (owner: 10Paladox) [22:53:54] (03PS1) 10Paladox: Database: Allow selectFieldValues() to accept SQL fragments [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468788 (https://phabricator.wikimedia.org/T201781) [22:55:21] (03PS2) 10Paladox: Fix comment handling on image upload or deletion [core] (REL1_32) - 10https://gerrit.wikimedia.org/r/468476 (https://phabricator.wikimedia.org/T207419) (owner: 1020after4) [22:56:30] (03PS1) 10Reedy: Call CentralAuthUser->saveSettings() after setEmail() [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/468789 (https://phabricator.wikimedia.org/T207556) [22:58:18] (03PS1) 10Reedy: Call CentralAuthUser->saveSettings() after setEmail() [extensions/CentralAuth] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468790 (https://phabricator.wikimedia.org/T207556) [22:58:23] (03CR) 10Reedy: [C: 032] Call CentralAuthUser->saveSettings() after setEmail() [extensions/CentralAuth] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468790 (https://phabricator.wikimedia.org/T207556) (owner: 10Reedy) [23:03:20] (03Merged) 10jenkins-bot: Call CentralAuthUser->saveSettings() after setEmail() [extensions/CentralAuth] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468790 (https://phabricator.wikimedia.org/T207556) (owner: 10Reedy) [23:06:01] (03CR) 10jenkins-bot: Call CentralAuthUser->saveSettings() after setEmail() [extensions/CentralAuth] (wmf/1.32.0-wmf.26) - 10https://gerrit.wikimedia.org/r/468790 (https://phabricator.wikimedia.org/T207556) (owner: 10Reedy) [23:23:59] (03PS1) 10Urbanecm: [WIP] Add sendmails.py cmd utility [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468791 [23:24:17] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add sendmails.py cmd utility [wikimedia-cz/tools] - 10https://gerrit.wikimedia.org/r/468791 (owner: 10Urbanecm) [23:27:52] 10MediaWiki-Maintenance-scripts, 10MediaWiki-User-management, 10MediaWiki-extensions-CentralAuth, 10Patch-For-Review: `resetUserEmail.php` not applying email change to CentralAuth - https://phabricator.wikimedia.org/T207556 (10Reedy) It seems this hasn't helped... [23:34:42] (03CR) 10Krinkle: [C: 032] Fix countable PHP 7.2 error in Flow (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) (owner: 10D3r1ck01) [23:37:06] 10MediaWiki-General-or-Unknown, 10base_convert, 10Core Platform Team (PHP7 (TEC4)), 10PHP 7.2 support: base-convert no longer works under PHP 7.2 because dividend and divisor are no longer truncated to integer when bcmath is installed and gmp is not - https://phabricator.wikimedia.org/T194052 (10Krinkle) N... [23:37:16] (03PS1) 10Reedy: Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) [23:37:21] (03CR) 10Reedy: [C: 032] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:37:25] (03CR) 10Krinkle: [C: 032] Explicit "use" namespace statement for MediaWikiTestCase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468784 (owner: 10D3r1ck01) [23:37:30] (03PS1) 10Reedy: Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/468794 (https://phabricator.wikimedia.org/T207563) [23:37:35] (03CR) 10Reedy: [C: 032] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/468794 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:37:45] (03PS1) 10Reedy: Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_30) - 10https://gerrit.wikimedia.org/r/468795 (https://phabricator.wikimedia.org/T207563) [23:37:51] (03CR) 10Reedy: [C: 032] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_30) - 10https://gerrit.wikimedia.org/r/468795 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:38:30] 10Wikimedia-SVG-rendering, 10Upstream: librsvg does not shift from bold to normal font-weight - https://phabricator.wikimedia.org/T207506 (10Aklapper) I can confirm this locally for `librsvg2-2.42.6-1.fc28`. I cannot confirm this anymore for `librsvg2-2.44.7-1.fc29`. [23:41:34] (03CR) 10Krinkle: [C: 04-1] "I'm not sure what this addresses or improved. It is not a mistake, it is part of written English and typically used to denote significant " [core] - 10https://gerrit.wikimedia.org/r/468553 (owner: 10D3r1ck01) [23:43:18] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:43:46] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/468794 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:49:08] (03Merged) 10jenkins-bot: Fix countable PHP 7.2 error in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) (owner: 10D3r1ck01) [23:49:10] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_32) - 10https://gerrit.wikimedia.org/r/468793 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:54:08] 10MediaWiki-Redirects, 10JavaScript, 10Regression: Javascript redirects throw error and nosniff - https://phabricator.wikimedia.org/T207201 (10Aklapper) [23:57:39] (03CR) 10jenkins-bot: Fix countable PHP 7.2 error in Flow [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468782 (https://phabricator.wikimedia.org/T207563) (owner: 10D3r1ck01) [23:59:06] (03Merged) 10jenkins-bot: Explicit "use" namespace statement for MediaWikiTestCase [extensions/Flow] - 10https://gerrit.wikimedia.org/r/468784 (owner: 10D3r1ck01) [23:59:08] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_31) - 10https://gerrit.wikimedia.org/r/468794 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy) [23:59:11] (03CR) 10jerkins-bot: [V: 04-1] Fix countable PHP 7.2 error in Flow [extensions/Flow] (REL1_30) - 10https://gerrit.wikimedia.org/r/468795 (https://phabricator.wikimedia.org/T207563) (owner: 10Reedy)