[00:03:11] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10Niharika) >>! In T200970#4561306, @aezell wrote: > @Niharika There were discussions in the research for this task regarding saving a list of what was inserted and th... [00:05:35] (03PS3) 10Paladox: Set default license to GPL2.0 [All-Avatars] - 10https://gerrit.wikimedia.org/r/458332 [00:05:46] (03CR) 10Paladox: [V: 032 C: 032] Set default license to GPL2.0 [All-Avatars] - 10https://gerrit.wikimedia.org/r/458332 (owner: 10Paladox) [00:10:16] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10aezell) Maybe @Samwilson can explain it better? I was sort of transcribing the discussion and might have missed it. [00:12:33] 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check sometimes can't tell that the third arg to a tag hook is a Parser object unless there is a type hint - https://phabricator.wikimedia.org/T203308 (10Bawolff) 05Open>03Resolved a:03Bawolff [00:16:02] 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page, namespace, and/or action (Partial Blocks) - https://phabricator.wikimedia.org/T199917 (10kchapman) TechCom has approved this RFC. [00:16:05] 10phan-taint-check-plugin, 10Patch-For-Review: Make IDatabase::makeList safe for phan-taint-check-plugin - https://phabricator.wikimedia.org/T201987 (10Bawolff) It seems like there is still a problem when using things like $dbr->makeList( [ 'foo' => [ $evil1, $evil2 ] ], LIST_AND ); which should be safe (See B... [00:16:14] (03Abandoned) 10Ebe123: Revert "Revert "Add check for null audio lengths"" [extensions/Score] - 10https://gerrit.wikimedia.org/r/458331 (owner: 10Ebe123) [00:16:36] 10Anti-Harassment, 10TechCom-RFC (TechCom-Approved): RFC: Block users by page, namespace, and/or action (Partial Blocks) - https://phabricator.wikimedia.org/T199917 (10kchapman) [00:17:45] (03PS1) 10Brian Wolff: Fix some confusion over which group of taints to mask out in various places [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458334 (https://phabricator.wikimedia.org/T203490) [00:19:26] 10MediaWiki-Authentication-and-authorization, 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check-plugin false positive in AuthenticationRequest due to HTMLForm confusion - https://phabricator.wikimedia.org/T202112 (10Bawolff) 05Open>03Resolved a:03Bawolff [00:20:26] 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Blocked MobileFrontend merges: Calling method \ApiMobileView::parseSectionsData in \ApiMobileView::getData that is always unsafe - https://phabricator.wikimedia.org/T203490 (10Bawolff) >>! In T2034... [00:21:37] (03PS5) 10Jdlrobson: Hygiene: Discourage use of $.each [core] - 10https://gerrit.wikimedia.org/r/451888 (https://phabricator.wikimedia.org/T200877) [00:23:21] (03CR) 10Brian Wolff: "<3 Thank you for working on this. This has been one of my pet peeves with WikiEditor for a long time" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (owner: 10Jforrester) [00:24:19] (03PS1) 10VolkerE: Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458335 [00:25:17] (03PS2) 10Brian Wolff: Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [00:36:12] (03PS7) 10Cicalese: Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458285 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [00:40:54] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10Samwilson) Yeah, if multiple templates were inserted. My understanding is that we'll keep a track of each template that was inserted (including if the same one was... [00:47:04] (03PS8) 10Cicalese: Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458285 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [00:47:42] (03PS1) 10Cooltey: [WIP] Greyed out views if articles are not available offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852) [00:49:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Greyed out views if articles are not available offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852) (owner: 10Cooltey) [00:55:05] (03CR) 10Krinkle: [C: 032] Hygiene: Discourage use of $.each [core] - 10https://gerrit.wikimedia.org/r/451888 (https://phabricator.wikimedia.org/T200877) (owner: 10Jdlrobson) [01:02:08] (03CR) 10Krinkle: [C: 04-1] Fork autoMsg() with escaped autoSafeMsg(), replace where appropriate (039 comments) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458307 (https://phabricator.wikimedia.org/T154891) (owner: 10Jforrester) [01:02:20] 10MediaWiki-Database, 10Technical-Debt, 10Tracking: 1205: Lock wait timeout exceeded; try restarting transaction (tracking) - https://phabricator.wikimedia.org/T30499 (10Krinkle) [01:02:26] 10MediaWiki-Recent-changes, 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10Wikidata, and 2 others: FlaggedRevsHooks::autoMarkPatrolled shouldn't need to update the RC entry that has just been saved - https://phabricator.wikimedia.org/T130561 (10Krinkle) [01:05:16] 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10Wikidata, 10Wikimedia-production-error: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded" - https://phabricator.wikimedia.org/T130561 (10Krinkle) [01:05:18] 10FormWizard: Make sure OOUI styles are being used in FormWizard - https://phabricator.wikimedia.org/T203624 (10Harej) [01:05:42] 10Google-Summer-of-Code (2018): [Analytics] Improvements to Wikistats2 front-end - https://phabricator.wikimedia.org/T190799 (10srishakatux) 05Open>03declined [01:06:13] 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10Wikidata, 10Wikimedia-production-error: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded" - https://phabricator.wikimedia.org/T130561 (10Krinkle) Assuming the write isn't a no-op, it shoul... [01:10:12] 10MediaWiki-Database, 10Technical-Debt, 10Tracking: 1205: Lock wait timeout exceeded; try restarting transaction (tracking) - https://phabricator.wikimedia.org/T30499 (10Krinkle) [01:10:17] 10MediaWiki-extensions-FlaggedRevs, 10Growth-Team, 10Wikidata, 10Wikimedia-production-error: FlaggedRevsHooks::autoMarkPatrolled hook from RecentChange::save sometimes failed with "Lock wait timeout exceeded" - https://phabricator.wikimedia.org/T130561 (10Krinkle) 05Open>03declined Mistook it for anoth... [01:11:21] (03Merged) 10jenkins-bot: Hygiene: Discourage use of $.each [core] - 10https://gerrit.wikimedia.org/r/451888 (https://phabricator.wikimedia.org/T200877) (owner: 10Jdlrobson) [01:12:16] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Undefined index: watchlisttoken in User.php on line 2817 - https://phabricator.wikimedia.org/T93900 (10Krinkle) 05Open>03declined No results for `message:watchlisttoken AND channel:error` in 30 days on logstash/mediawiki-errors. [01:14:13] (03CR) 10jenkins-bot: Hygiene: Discourage use of $.each [core] - 10https://gerrit.wikimedia.org/r/451888 (https://phabricator.wikimedia.org/T200877) (owner: 10Jdlrobson) [01:17:59] 10MediaWiki-extensions-DoubleWiki, 10Technical-Debt, 10Wikimedia-production-error: Fix invalid access of missing $right_langcode in DoubleWiki_body.php:220 - https://phabricator.wikimedia.org/T78448 (10Krinkle) 05Open>03declined Not seen in 30 days on logstash/mediawiki-errors. [01:19:35] (03CR) 10Legoktm: [C: 032] Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458285 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [01:20:05] 10OCG-PDFRenderer, 10Wikimedia-production-error: Download as PDF: Rendering failed with non zero code - https://phabricator.wikimedia.org/T94308 (10Krinkle) 05Open>03Resolved a:03Krinkle The example in the task description seems to work as expected ("Download as PDF" from 10OCG-PDFRenderer, 10Wikimedia-production-error: Download as PDF: Rendering failed with non zero code - https://phabricator.wikimedia.org/T94308 (10Krinkle) a:05Krinkle>03None [01:20:21] (03CR) 10Legoktm: [C: 032] Fix privacy policy URL + update i18n [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458295 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [01:20:36] legoktm: btw, go or nogo on the root url? [01:21:07] Krinkle: I never had any time to test it [01:21:24] But you know, the best place to test it, is in production :) [01:21:27] (03CR) 10Legoktm: [C: 032] Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458335 (owner: 10VolkerE) [01:21:33] indeed! [01:22:00] (03CR) 10Legoktm: [C: 032] "Would also be good to set up stylelint on this repo..." [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458335 (owner: 10VolkerE) [01:22:12] I guess I'll play with it once I start the scap [01:25:41] (03Merged) 10jenkins-bot: Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458285 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [01:27:20] (03Merged) 10jenkins-bot: Fix privacy policy URL + update i18n [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458295 (https://phabricator.wikimedia.org/T203295) (owner: 10ItSpiderman) [01:29:18] (03PS1) 10Legoktm: Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458340 (https://phabricator.wikimedia.org/T203295) [01:29:20] (03CR) 10Legoktm: [C: 032] Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458340 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:29:22] (03Merged) 10jenkins-bot: Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458335 (owner: 10VolkerE) [01:29:24] (03PS1) 10Legoktm: Fix privacy policy URL + update i18n [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458341 (https://phabricator.wikimedia.org/T203295) [01:29:26] (03CR) 10Legoktm: [C: 032] Fix privacy policy URL + update i18n [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458341 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:29:28] (03PS1) 10Legoktm: Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458342 [01:29:30] (03CR) 10Legoktm: [C: 032] Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458342 (owner: 10Legoktm) [01:30:10] (03PS1) 10Cicalese: Adjust line height. [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458343 (https://phabricator.wikimedia.org/T203295) [01:30:36] 10Collection, 10Readers-Web-Backlog (Tracking), 10Wikimedia-production-error: Using Special:Book while blocked shouldn't result in an exception - https://phabricator.wikimedia.org/T56179 (10Krinkle) Steps to reproduce this issue: * Get your account blocked, e.g. ask a sysop to block it for 2 hours on test2.w... [01:30:59] (03CR) 10Legoktm: [C: 032] Adjust line height. [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458343 (https://phabricator.wikimedia.org/T203295) (owner: 10Cicalese) [01:31:02] (03PS1) 10Legoktm: Adjust line height. [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458344 (https://phabricator.wikimedia.org/T203295) [01:31:05] (03Merged) 10jenkins-bot: Do not escape labels for OO.ui widgets [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458340 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:31:20] legoktm: yeah, should be safe via mwdebug [01:32:14] (03CR) 10Legoktm: [C: 032] Adjust line height. [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458344 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:33:28] 10Google-Summer-of-Code (2018): GSoC 2018 Proposal: [Wikipedia Search] Predict relevance of search results from historical clicks using a Neural Click Model - https://phabricator.wikimedia.org/T190660 (10srishakatux) ping @EBernhardson @TJones @Kdhingra2210 Is there anything remaining in this task from GSoC'18?... [01:34:53] (03Merged) 10jenkins-bot: Fix privacy policy URL + update i18n [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458341 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:34:55] (03Merged) 10jenkins-bot: Align CSS closer to CSS Coding Guidelines [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458342 (owner: 10Legoktm) [01:35:14] (03Merged) 10jenkins-bot: Adjust line height. [skins/EUCopyrightCampaignSkin] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458344 (https://phabricator.wikimedia.org/T203295) (owner: 10Legoktm) [01:36:37] (03Merged) 10jenkins-bot: Adjust line height. [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/458343 (https://phabricator.wikimedia.org/T203295) (owner: 10Cicalese) [01:36:43] 10MediaWiki-extensions-Loops: Add tracking category to pages exceeding max loop count - https://phabricator.wikimedia.org/T203562 (10MGChecker) p:05Triage>03Low a:03MGChecker Turns out this is really easy to do. [01:37:10] 10The-Wikipedia-Library, 10Google-Summer-of-Code (2018): [#1Lib1Ref] Build a "worklist" tool for campaigns and in-person editing events. - https://phabricator.wikimedia.org/T187305 (10srishakatux) @Surlycyborg If there isn't anything remaining in this task from GSoC'18, then mark it as resolved! Same goes for... [01:37:51] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668 (10MGChecker) [01:37:53] 10MediaWiki-extensions-DeleteOwn, 10Patch-For-Review: Convert DeleteOwn to use extension registration - https://phabricator.wikimedia.org/T174884 (10MGChecker) 05Open>03stalled p:05Normal>03Lowest This is still awaiting review, but I'm unable to do anything about it. [01:38:55] 10MediaWiki-extensions-Loops, 10BlueSpice, 10Need-volunteer, 10WorkType-Maintenance: [Loops] Fix usage of deprecated ParserLimitReport hook - https://phabricator.wikimedia.org/T203015 (10MGChecker) p:05Triage>03Normal [01:44:04] 10MediaWiki-extensions-Page_Forms, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2018), 10Patch-For-Review: Add a spreadsheet interface for modifying multiple pages to the Page Forms extension - https://phabricator.wikimedia.org/T63989 (10srishakatux) ping @Yaron_Koren @Nischayn22 @yashdeep97 Is t... [02:01:09] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10MGChecker) Can we please just set something up here? I would like to add patches to a queue like that for sure. [02:13:43] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10MZMcBride) >>! In T200987#4561556, @MGChecker wrote: > Can we please just set something up here? I would like to add patches to a queue like that for sure. We already have www.mediawiki.org and phabricator.wi... [02:16:08] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10Krenair) Gerrit searches can be good for finding stuff to review but I've found some groups simply don't watch it. [02:17:33] 10Internet-Archive, 10InternetArchiveBot: IABot adds duplicate parameters to citation - https://phabricator.wikimedia.org/T203369 (10Krinkle) Not yet, but it'd be good to at least fix/revert the edits of this kind by the bot that were made in the past. [02:18:09] 10Research-Programs, 10Epic: [Objective 11.1.2] Research on citation/external link usage - https://phabricator.wikimedia.org/T171231 (10Krinkle) [02:18:15] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, 10Performance-Team (Radar), 10Research-2017-18-Q4: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10Krinkle) 05Resolved>03Open [02:24:27] (03CR) 10Legoktm: [C: 04-1] Add phan to composer (031 comment) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:24:29] (03PS7) 10Legoktm: Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:24:31] (03CR) 10jerkins-bot: [V: 04-1] Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:24:33] (03CR) 10Legoktm: "check experimental" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:24:35] (03CR) 10jerkins-bot: [V: 04-1] Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:26:07] (03PS8) 10Legoktm: Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:26:22] (03CR) 10Legoktm: "check experimental" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:26:48] (03CR) 10Legoktm: "(PS8 was just a rebase)" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [02:30:59] (03PS3) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [02:31:15] (03CR) 10Legoktm: [C: 032] "This is an improvement over the status quo, but I think MWDebug and the other global logging/debugging/warning functions also deserve a lo" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [02:32:18] (03PS4) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [02:35:07] (03CR) 10Legoktm: [C: 032] exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [02:35:24] 10MediaWiki-Core-Tests, 10Readers-Web-Backlog, 10Google-Code-in-2018, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 3 others: Forbid use of $.each, $.map, $.isArray in core JavaScript code - https://phabricator.wikimedia.org/T200877 (10Jdlrobson) [02:36:14] Krinkle: I think you have a syntax error [02:36:22] CI is 100% red for your patch [02:36:23] 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler, 10Commons, 10Multimedia, 10Wikimedia-production-error: If memcache of file object is out of sync with db record and img_metadata is large, causes fatal - https://phabricator.wikimedia.org/T100012 (10Krinkle) >>! In T100012#1304425, @Bawolff... [02:36:24] :p [02:36:41] 10MediaWiki-File-management, 10MediaWiki-extensions-PdfHandler, 10Commons, 10Multimedia, 10Wikimedia-production-error: If memcache of file object is out of sync with db record and img_metadata is large, causes fatal - https://phabricator.wikimedia.org/T100012 (10Krinkle) 05Open>03declined [02:37:44] (03CR) 10jerkins-bot: [V: 04-1] exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [02:38:06] legoktm: well, damn. [02:38:30] let me check it out locally just to sanity check anything else [02:41:22] (03CR) 10jerkins-bot: [V: 04-1] exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [02:41:27] (03PS5) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [02:41:29] (03PS6) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [02:42:24] legoktm: k, lgtm [02:42:55] (03PS7) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [02:43:00] that's it [03:04:17] (03PS34) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [03:14:41] 10Community-IdeaLab, 10FormWizard-Gadget: FormWizard Gadget can be configured to use revisionuser name as page title - https://phabricator.wikimedia.org/T90261 (10Harej) [03:15:59] 10FormWizard, 10FormWizard-Gadget: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Harej) [03:18:14] 10FormWizard-Gadget, 10Epic: Replace all uses of FormWizard gadget with the FormWizard extension - https://phabricator.wikimedia.org/T203627 (10Harej) [03:20:03] 10MediaWiki-extensions-Quiz: Infinite loop in quiz shuffleAnswers - https://phabricator.wikimedia.org/T203628 (10tstarling) [03:21:46] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [03:25:24] (03PS1) 10Tim Starling: Fix shuffleAnswers infinite loop [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/458348 (https://phabricator.wikimedia.org/T203628) [03:26:37] 10MediaWiki-API, 10Wikimedia-production-error: ApiQueryAllPages is slow on langlinks edgecase - https://phabricator.wikimedia.org/T97797 (10Krinkle) [03:27:22] (03CR) 10Tim Starling: "I tested it locally. The original version had an extra space at the start of $order, but there is an ltrim() right below which removes it." [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/458348 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:27:54] (03CR) 10Legoktm: [C: 032] Fix shuffleAnswers infinite loop [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/458348 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:31:13] 10MediaWiki-extensions-Score, 10Wikimedia-production-error: Notice: Undefined index: qb4tlxyr.ogg in /srv/mediawiki/php-1.32.0-wmf.19/extensions/Score/includes/Score.php on line 507 - https://phabricator.wikimedia.org/T203560 (10Krinkle) [03:32:15] 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Epic, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10CCicalese_WMF) [03:32:18] 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) 05Open>03Resolved [03:34:24] (03Merged) 10jenkins-bot: Fix shuffleAnswers infinite loop [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/458348 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:37:08] (03CR) 10jenkins-bot: Fix shuffleAnswers infinite loop [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/458348 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:37:54] 10MediaWiki-General-or-Unknown, 10HHVM, 10Wikimedia-production-error: "Unable to unserialize" error in hhvm logs repeatedly - https://phabricator.wikimedia.org/T78309 (10Krinkle) 05Open>03declined No longer seeing this in last 30 days for MessageCache values (which the original report was for). We may wa... [03:52:43] (03PS1) 10Tim Starling: Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/458349 (https://phabricator.wikimedia.org/T203628) [03:53:34] (03PS1) 10Tim Starling: [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) [03:54:14] (03CR) 10Tim Starling: [C: 032] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/458349 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:54:32] (03CR) 10Tim Starling: [C: 032] [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:54:47] (03CR) 10jerkins-bot: [V: 04-1] [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [03:55:30] legoktm: are you available right now and 1 hour from now? [03:56:03] Volker_E: probably [03:56:06] Volker_E: what's up? [03:58:28] (03CR) 10Tim Starling: [C: 032] "recheck" [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:00:18] 10WMF-Communications, 10wikimediafoundation.org: Redirects for new Wikimedia Foundation website - https://phabricator.wikimedia.org/T200754 (10Krinkle) [04:00:23] 10MediaWiki-extensions-General, 10Wikimedia-General-or-Unknown, 10wikimediafoundation.org, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: Update wikimediafoundation.org to foundation.wikimedia.org across numerous repos - https://phabricator.wikimedia.org/T199812 (10Kr... [04:00:54] (03Merged) 10jenkins-bot: Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/458349 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:00:56] (03Merged) 10jenkins-bot: [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:03:05] (03CR) 10jenkins-bot: [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:05:23] (03CR) 10jenkins-bot: Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/458349 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:06:36] (03CR) 10Legoktm: [C: 032] exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [04:07:52] (03CR) 10jenkins-bot: [1.32.0-wmf.20] Fix shuffleAnswers infinite loop [extensions/Quiz] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458350 (https://phabricator.wikimedia.org/T203628) (owner: 10Tim Starling) [04:16:11] 10Wikimedia-General-or-Unknown, 10Wikimedia-Site-requests, 10SEO: Change canonical URL of the main page to domain root - https://phabricator.wikimedia.org/T120085 (10Legoktm) We implemented this as a one-off thing for fixcopyrightwiki (https://gerrit.wikimedia.org/r/c/operations/mediawiki-config/+/458345). D... [04:17:18] 10MediaWiki-extensions-Quiz, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Infinite loop in quiz shuffleAnswers - https://phabricator.wikimedia.org/T203628 (10tstarling) 05Open>03Resolved a:03tstarling [04:18:08] 10MediaWiki-extensions-LoginNotify, 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.... - https://phabricator.wikimedia.org/T179765 [04:18:21] legoktm: it's for the EU campaign [04:18:21] 10MediaWiki-extensions-LoginNotify, 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.... - https://phabricator.wikimedia.org/T179765 [04:18:29] legoktm: was it deployed? [04:18:34] Volker_E: yep [04:18:46] any more deployments planned? [04:20:20] not really, but I'm expecting that it's not perfect and we'll probably have some stuff to push out tomorrow [04:25:12] 'k [04:25:46] Volker_E: I assume you want to change things? :) [04:25:50] (03Merged) 10jenkins-bot: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [04:26:04] legoktm: it's about minor accessibility measurements [04:26:39] :D [04:28:13] Volker_E: should be pretty straightforward to SWAT out those kinds of patches [04:28:37] (03CR) 10jenkins-bot: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [04:38:57] 10Repository-Ownership-Requests: +2 for Kghbln on Extension:UserExport - https://phabricator.wikimedia.org/T203375 (10Legoktm) 05Open>03Resolved a:03Legoktm >>! In T203375#4555046, @MarcoAurelio wrote: > Awesome! I'll add him (or do we need to wait?) Since there are no existing project owners there's not... [04:44:00] (03CR) 10Samwilson: "Looks good. Just a couple of questions about messages." (032 comments) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458286 (https://phabricator.wikimedia.org/T203600) (owner: 10Mooeypoo) [05:00:57] (03CR) 10Samwilson: [C: 04-1] Add tooltips to parameter buttons for accessibility (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458292 (https://phabricator.wikimedia.org/T203604) (owner: 10Mooeypoo) [05:01:34] (03CR) 10Krinkle: [C: 032] Allow a question with answer '0' [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/453989 (https://phabricator.wikimedia.org/T196684) (owner: 10Umherirrender) [05:06:26] (03Merged) 10jenkins-bot: Allow a question with answer '0' [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/453989 (https://phabricator.wikimedia.org/T196684) (owner: 10Umherirrender) [05:07:50] (03CR) 10Samwilson: [C: 032] Set initial focus on template load [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458279 (https://phabricator.wikimedia.org/T198926) (owner: 10Mooeypoo) [05:08:37] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10Samwilson) Merged. [05:08:39] 10MediaWiki-extensions-Page_Forms, 10Google-Summer-of-Code (2018): GSoC 2018 Proposal: Add a spreadsheet interface for modifying multiple pages to the Page Forms extension - https://phabricator.wikimedia.org/T189743 (10yashdeep97) 05Open>03Resolved The complete list of commits for this task can be found at... [05:09:00] (03CR) 10jenkins-bot: Allow a question with answer '0' [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/453989 (https://phabricator.wikimedia.org/T196684) (owner: 10Umherirrender) [05:11:27] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: "Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix - https://phabricator.wikimedia.org/T203284 (10Etonkovidova) Ch... [05:13:54] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Legoktm) p:05Unbreak!>03High >>! In T203587#4560333, @Daimona wrote: > Setting the priority to UBN because this action has lots of problems, ranging from no-harm to "... [05:14:46] (03Merged) 10jenkins-bot: Set initial focus on template load [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458279 (https://phabricator.wikimedia.org/T198926) (owner: 10Mooeypoo) [05:20:57] (03CR) 10Legoktm: [C: 04-1] "02:27:29 " [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [05:21:37] 10MediaWiki-extensions-Page_Forms, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2018), 10Patch-For-Review: Add a spreadsheet interface for modifying multiple pages to the Page Forms extension - https://phabricator.wikimedia.org/T63989 (10yashdeep97) 05Open>03Resolved a:03yashdeep97 The comp... [05:24:34] (03CR) 10Legoktm: [C: 032] "Note that I think we're moving away from rawrow because OOUI doesn't support it properly?" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457962 (https://phabricator.wikimedia.org/T201902) (owner: 10Brian Wolff) [05:25:26] 10MediaWiki-extensions-Other: [CongressLookup] Update senators.json - https://phabricator.wikimedia.org/T203611 (10kaldari) The only update that should be needed is replacing John McCain with Jon Kyl. [05:27:24] (03Merged) 10jenkins-bot: Treat htmlform type=info's 'rawrow' option like 'raw' [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457962 (https://phabricator.wikimedia.org/T201902) (owner: 10Brian Wolff) [05:27:48] (03CR) 10Legoktm: [C: 04-1] "This is used in on-wiki code, e.g. and 10MediaWiki-Core-Tests, 10phan-taint-check-plugin, 10Continuous-Integration-Config: Configure CI to run phan-taint-check-plugin for MediaWiki core - https://phabricator.wikimedia.org/T203630 (10Legoktm) [05:36:11] (03CR) 10Legoktm: [C: 032] "Thanks!" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [05:36:32] (03CR) 10Legoktm: [C: 032] Add recent pattern for ESLinting in repo [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/457473 (owner: 10D3r1ck01) [05:36:37] (03CR) 10Smalyshev: [C: 031] Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [05:36:40] (03CR) 10Legoktm: [C: 032] Add recent pattern for ESLinting to repo [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/457452 (owner: 10D3r1ck01) [05:36:50] (03CR) 10Legoktm: [C: 032] Add recent pattern for ESLinting in repo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/457453 (owner: 10D3r1ck01) [05:43:57] (03Merged) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [05:43:59] (03Merged) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/457473 (owner: 10D3r1ck01) [05:45:33] (03CR) 10Legoktm: [C: 032] "Would be good to have tests in the future ;)" [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 (owner: 10Nikerabbit) [05:47:40] 04(no projects): Test - https://phabricator.wikimedia.org/T203631 (10visualizeq) [05:48:55] (03CR) 10Legoktm: Fix a fatal during a misdetected HTMLForm specifier with empty class (031 comment) [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457087 (owner: 10Brian Wolff) [05:49:04] (03CR) 10Jonas Kress (WMDE): [C: 04-2] "I meant race condition." [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/458187 (https://phabricator.wikimedia.org/T202848) (owner: 10Jonas Kress (WMDE)) [05:52:07] (03CR) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/457473 (owner: 10D3r1ck01) [05:54:54] (03Merged) 10jenkins-bot: Add recent pattern for ESLinting to repo [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/457452 (owner: 10D3r1ck01) [05:54:56] (03Merged) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/457453 (owner: 10D3r1ck01) [05:54:58] (03Merged) 10jenkins-bot: Initial import from nikext from translatewiki repo [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 (owner: 10Nikerabbit) [05:55:55] (03CR) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/457451 (owner: 10D3r1ck01) [05:57:24] 10Design, 10TemplateData, 10VisualEditor, 10Patch-For-Review: Don't show Default, Example and Auto value section of the TemplateData description cell if no information is provided - https://phabricator.wikimedia.org/T125333 (10The_RedBurn) [05:58:47] (03CR) 10jenkins-bot: Add recent pattern for ESLinting in repo [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/457453 (owner: 10D3r1ck01) [06:02:02] (03CR) 10jenkins-bot: Add recent pattern for ESLinting to repo [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/457452 (owner: 10D3r1ck01) [06:08:05] (03CR) 10Legoktm: [C: 032] "OK, though I'm still a bit confused. I'll ask you on IRC tomorrow." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458334 (https://phabricator.wikimedia.org/T203490) (owner: 10Brian Wolff) [06:10:03] (03Merged) 10jenkins-bot: Fix some confusion over which group of taints to mask out in various places [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458334 (https://phabricator.wikimedia.org/T203490) (owner: 10Brian Wolff) [06:35:05] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Erfgoedbot categorisation statistics always indicate 0 - https://phabricator.wikimedia.org/T203428 (10Lokal_Profil) Is the cause as simple as forgetting a return statement on `categorizeImage()` when categorisation is successful? [06:43:46] (03PS1) 10VolkerE: Fix EU national flags size [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 [06:48:28] (03CR) 10Pwirth: [C: 04-1] Hide notification-options without permission (031 comment) [extensions/BlueSpiceEditNotifyConnector] (REL1_27) - 10https://gerrit.wikimedia.org/r/458199 (owner: 10Pmiguelpirzer) [06:56:38] 10Wiki-Loves-Monuments-Sources, 10Wiki-Loves-Monuments (2018): Help organisers repair broken coordinates - https://phabricator.wikimedia.org/T202677 (10Lokal_Profil) I've been fixing some of these manually. I'm sure we had some other mechanism for finding and highlighting these but cannot find it. [06:59:06] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Describe how to get off the categorisation blacklist - https://phabricator.wikimedia.org/T203338 (10Lokal_Profil) Yes that category should definitely be the first stop. As you say it remotes on template logic and I think moody templates only imple... [07:05:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/458361 (owner: 10L10n-bot) [07:10:02] 10Google-Summer-of-Code (2018): GSoC 2018 Proposal: [Wikipedia Search] Predict relevance of search results from historical clicks using a Neural Click Model - https://phabricator.wikimedia.org/T190660 (10Kdhingra2210) @srishakatux the model is complete but it is in testing over the complete data, so those patche... [07:10:22] 10WMSE-Riksarkivet-TORA: Swedish Historical maps - https://phabricator.wikimedia.org/T203390 (10Salgo60) [07:12:01] 10Discovery-Search, 10Outreach-Programs-Projects, 10Google-Summer-of-Code (2018): Predict relevance of search results from historical clicks using a Neural Click Model - https://phabricator.wikimedia.org/T186742 (10Kdhingra2210) @srishakatux yes, testing is ongoing and I think it should be finished in next w... [07:12:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/458411 (owner: 10L10n-bot) [07:12:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/458364 (owner: 10L10n-bot) [07:16:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458374 (owner: 10L10n-bot) [07:17:29] 10MediaWiki-API, 10Operations, 10Parsoid, 10RESTBase, and 6 others: HHVM request timeouts not working; support lowering the API request timeout per request - https://phabricator.wikimedia.org/T97192 (10tstarling) 05Resolved>03Open It's not fixed, or has regressed. I noticed this today due to T203628 an... [07:25:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/458376 (owner: 10L10n-bot) [07:28:27] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/458375 (owner: 10L10n-bot) [07:34:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/458377 (owner: 10L10n-bot) [07:36:40] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Different widths in NWE+CodeMirror can cause text and color to fall out of sync - https://phabricator.wikimedia.org/T203638 (10Schnark) [07:37:35] (03CR) 10Zfilipin: "> Patch Set 5: Code-Review+2" [core] - 10https://gerrit.wikimedia.org/r/457854 (https://phabricator.wikimedia.org/T185011) (owner: 10Zfilipin) [07:38:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/458387 (owner: 10L10n-bot) [07:41:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/458383 (owner: 10L10n-bot) [07:43:07] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) @Legoktm Well, I read that page on mw.org some time ago, however I can't easily say if the definition applies here. Summing up, this is what we have: - When cre... [07:43:44] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_filters_intitle_api_intitle_doesn_t_highlight_excluded_title, clean_highlight" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [07:44:42] 10WMSE-Development-Support-2018: Ask for community feedback on the results from 2017 DevSupport - https://phabricator.wikimedia.org/T199105 (10Sebastian_Berlin-WMSE) We've received feedback that it has been hard to follow the development process, especially for someone who doesn't have the technical know-how to... [07:48:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/458390 (owner: 10L10n-bot) [07:51:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458389 (owner: 10L10n-bot) [07:52:45] (03PS2) 10DCausse: Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [07:55:39] 10Repository-Ownership-Requests: +2 for Kghbln on Extension:UserExport - https://phabricator.wikimedia.org/T203375 (10Kghbln) Cool, they like it. :) Another off topic. Is there a way to see the project one is an owner of? [07:57:03] 10ContentTranslation, 10Language-2018-July-September, 10Patch-For-Review: CX2: Section alignment still sluggish and breakable - https://phabricator.wikimedia.org/T200323 (10santhosh) a:03santhosh [07:59:21] (03CR) 10Hashar: [C: 032] Selenium: add selenium-daily NPM script [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:01:41] (03CR) 10jerkins-bot: [V: 04-1] Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [08:01:44] (03CR) 10jerkins-bot: [V: 04-1] Selenium: add selenium-daily NPM script [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:01:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/458392 (owner: 10L10n-bot) [08:01:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/458405 (owner: 10L10n-bot) [08:01:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/458414 (owner: 10L10n-bot) [08:02:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458420 (owner: 10L10n-bot) [08:02:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/458428 (owner: 10L10n-bot) [08:02:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/458397 (owner: 10L10n-bot) [08:02:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458408 (owner: 10L10n-bot) [08:02:14] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/458419 (owner: 10L10n-bot) [08:02:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/458429 (owner: 10L10n-bot) [08:05:08] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [08:09:42] (03CR) 10DCausse: "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [08:10:41] (03CR) 10Hashar: [C: 032] "Jenkins got restarted" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:13:51] (03CR) 10Gergő Tisza: [C: 031] "Looks good, works as expected. Some notes below." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [08:15:45] 10MediaWiki-extensions-Arrays: Discuss future of the Arrays extension - https://phabricator.wikimedia.org/T203519 (10Kghbln) > Is there some way to query more complicated things to wikiapiary? It shows me that both Arrays and PageForms are quite popular, but I don't see any possibility to check for Arrays AND Pa... [08:17:42] (03CR) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [08:19:18] 10Design, 10UI-Standardization, 10Revision-Slider, 10TCB-Team: Use default framed buttons in the RevisionSlider expand/collaps bar - https://phabricator.wikimedia.org/T203553 (10WMDE-Fisch) >>! In T203553#4560038, @Gopavasanth wrote: > The ticket tittle looks >>Use default framed buttons in the RevisionSl... [08:20:06] (03Merged) 10jenkins-bot: Selenium: add selenium-daily NPM script [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:20:48] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10Trizek-WMF) [08:21:08] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10Trizek-WMF) I've created a table to see what is done or not. [08:22:47] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Erfgoedbot categorisation statistics always indicate 0 - https://phabricator.wikimedia.org/T203428 (10JeanFred) >>! In T203428#4561818, @Lokal_Profil wrote: > Is the cause as simple as forgetting a return statement on `categorizeImage()` when cate... [08:23:50] 10CX-cxserver, 10Language-2018-July-September: cxserver: Update packages with security vulnerabilities identified by npm audit - https://phabricator.wikimedia.org/T202933 (10Arrbee) 05Open>03Resolved [08:24:15] 10The-Wikipedia-Library, 10Google-Summer-of-Code (2018): [#1Lib1Ref] Build a "worklist" tool for campaigns and in-person editing events. - https://phabricator.wikimedia.org/T187305 (10Surlycyborg) 05Open>03Resolved [08:24:24] 10Google-Summer-of-Code (2018): Proposal: Develop a "worklist" tool for campaigns and in-person editing events. - https://phabricator.wikimedia.org/T190555 (10Surlycyborg) 05Open>03Resolved [08:25:19] (03CR) 10jenkins-bot: Selenium: add selenium-daily NPM script [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [08:26:48] 10Google-Summer-of-Code (2018), 10Patch-For-Review: [GSoC Proposal 2018] Emoji Twitter bot for Commons images from NYPL fork - https://phabricator.wikimedia.org/T190163 (10ArielGlenn) 05Open>03Resolved Still one thing from this proposal not done but it can be moved to a separate task. Maybe I'll file a few... [08:39:48] (03CR) 10Gergő Tisza: [C: 04-1] "> Works for page save, but not for preview where preSaveTransform() gets called from EditPage instead." [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [08:42:38] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10Aklapper) >>! In T200987#4561556, @MGChecker wrote: > Can we please just set something up here? @MGChecker: Nobody stops you from doing that, I'd say, but that's not a solution... The harder part is finding [... [08:43:10] (03CR) 10Gergő Tisza: [C: 04-1] "> I can reproduce preview showing the wrong user" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [08:44:25] (03PS1) 10VolkerE: Add corresponding label elements for screenreaders to all inputs [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458461 [08:46:29] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10VisualEditor (Current work): [Regression pre-wmf.7] Drop down for template search results appears to go over the dialog when the template description is too long and not wrapping - https://phabricator.wikimedia.org/T196117 (... [08:47:37] (03CR) 10VolkerE: [C: 04-1] "Hmm, must have mixed up with a before merged patch. Trying to rebase tomorrow morning." [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458461 (owner: 10VolkerE) [08:52:03] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Aklapper) @Daimona: "I'd like to have it fixed" is very different from "This must be fixed immediately" (UBN)... :) [08:55:02] (03CR) 10DCausse: [C: 032] Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [09:04:55] 10Repository-Ownership-Requests: +2 for Kghbln on Extension:UserExport - https://phabricator.wikimedia.org/T203375 (10MarcoAurelio) >>! In T203375#4561979, @Kghbln wrote: > Cool, they like it. :) Another off topic. Is there a way to see the project one is an owner of? Congratulations :) I'd say https://gerrit.... [09:06:45] 10MediaWiki-extensions-Other: [CongressLookup] Update senators.json - https://phabricator.wikimedia.org/T203611 (10MarcoAurelio) >>! In T203611#4561751, @kaldari wrote: > The only update that should be needed is replacing John McCain with Jon Kyl. Okay so 458297 can be merged and we just need to compile the dat... [09:09:34] (03Merged) 10jenkins-bot: Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [09:15:58] 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilip... [09:18:15] (03PS1) 10MarcoAurelio: build: Update npm dev dependencies [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/458466 [09:20:04] (03CR) 10jenkins-bot: Dont override SearchResultSet::numRows() [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458316 (https://phabricator.wikimedia.org/T71382) (owner: 10EBernhardson) [09:20:20] (03PS2) 10MarcoAurelio: build: Update npm dev dependencies [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/458466 [09:23:54] (03CR) 10MarcoAurelio: "> PhantomJS not found on PATH." [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/458466 (owner: 10MarcoAurelio) [09:29:36] 04(no projects): Add sub-domain sciencesource-query to expose Query Service endpoint - https://phabricator.wikimedia.org/T203644 (10Jkbr) [09:31:28] 10WMSE-Riksarkivet-TORA: Libris XL: is there an easy way of looking up the new identifier based on the old one - https://phabricator.wikimedia.org/T200710 (10Lokal_Profil) a:05Lokal_Profil>03None @Alicia_Fagerving_WMSE imported all of the new URIs so for the ids known to Wikidata it can be used as a hub for... [09:31:41] (03CR) 10Jakob: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [09:36:32] 04(no projects): Add sub-domain sciencesource-query to expose Query Service endpoint - https://phabricator.wikimedia.org/T203644 (10Aklapper) @Jkbr: Which project/tag is this about? [09:45:24] 10Design, 10UI-Standardization, 10Revision-Slider, 10TCB-Team, 10WMDE-Design: Use default framed buttons in the RevisionSlider expand/collaps bar - https://phabricator.wikimedia.org/T203553 (10WMDE-Fisch) [09:45:53] 10Design, 10UI-Standardization, 10Revision-Slider, 10TCB-Team, 10WMDE-Design: Use default framed buttons in the RevisionSlider expand/collaps bar - https://phabricator.wikimedia.org/T203553 (10WMDE-Fisch) @Charlie_WMDE Any opinion on that from UX? [10:05:00] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) @Aklapper of course :-) That's just my assessment, and after all one of the point of discussing here on phab is hearing other thoughts. Again, I can't say if thi... [10:10:18] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Nikerabbit) >>! In T203215#4547529, @Osnard wrote: > See https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/BlueSpiceSkin/+/456549/ If you do not le... [10:11:03] (03CR) 10Lokal Profil: [C: 031] "Looks good." (031 comment) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [10:13:48] (03CR) 10Physikerwelt: "recheck" [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [10:19:06] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Dinoguy1000) >>! In T203215#4562233, @Nikerabbit wrote: > In addition, I am displeased the patch was merged without pinging translatewiki.net people... [10:24:36] 04(no projects): Add sub-domain sciencesource-query to expose Query Service endpoint - https://phabricator.wikimedia.org/T203644 (10Jkbr) @Aklapper We will be moving our tasks planning here but don't yet have a project set up. This is the related task to set up the `sciencesource` site: [[ https://phabricator... [10:26:17] (03CR) 10Sebastian Berlin (WMSE): [C: 04-1] "> Patch Set 8: Code-Review+1" (031 comment) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [10:28:05] 10MediaWiki-Core-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Video recording for Selenium tests in Node.js - https://phabricator.wikimedia.org/T179188 (10Addshore) We have some more seemingly random failures going on with https://gerrit.wikimedia.org/r/c/mediawiki/... [10:28:14] (03PS1) 10Elhuyar Fundazioa: Add user setting for disabling Wikispeech [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458471 (https://phabricator.wikimedia.org/T192683) [10:30:32] (03CR) 10Jakob: "This change is ready for review." [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [10:32:36] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10Trizek-WMF) [10:35:59] 10MediaWiki-Core-Tests, 10Wikidata-Campsite-Iteration-∞, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review, and 2 others: Flaky Special:RecentChanges selenium test - https://phabricator.wikimedia.org/T199446 (10WMDE-leszek) [10:37:10] (03PS1) 10Mglaser: Fix less vars [extensions/BlueSpiceSignHere] - 10https://gerrit.wikimedia.org/r/458472 [10:39:06] (03CR) 10Brian Wolff: "0 wouldnt be a valid class name either." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457087 (owner: 10Brian Wolff) [10:39:36] (03CR) 10Physikerwelt: [C: 032] build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [10:40:28] (03Abandoned) 10Physikerwelt: Fix broken test in quibble [extensions/Math] - 10https://gerrit.wikimedia.org/r/455482 (https://phabricator.wikimedia.org/T202223) (owner: 10Physikerwelt) [10:40:53] (03PS6) 10Physikerwelt: Add tracking category for deprecated mhchem syntax [extensions/Math] - 10https://gerrit.wikimedia.org/r/442124 [10:41:50] (03CR) 10Pwirth: [C: 032] Fix less vars [extensions/BlueSpiceSignHere] - 10https://gerrit.wikimedia.org/r/458472 (owner: 10Mglaser) [10:42:40] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) [10:42:43] 10AbuseFilter, 10Technical-Debt: Throttle parameters may have an undesired comma inside - https://phabricator.wikimedia.org/T203585 (10Daimona) [10:42:46] 10Dumps-Generation: Clean up flow dump job problems for Sept 1 2018 dumps run - https://phabricator.wikimedia.org/T203647 (10ArielGlenn) p:05Triage>03Normal [10:43:03] (03PS1) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 [10:47:08] (03PS1) 10ArielGlenn: look for the BackupDumper class in the (new) correct place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/458477 (https://phabricator.wikimedia.org/T203647) [10:47:34] (03CR) 10jerkins-bot: [V: 04-1] Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [10:47:55] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) [10:48:00] (03CR) 10Sbisson: "You're right that changing the "type" parameter has complications. Maybe adding a "revType=edit|new" param would be simpler." [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/457969 (https://phabricator.wikimedia.org/T201507) (owner: 10Framawiki) [10:48:07] 10AbuseFilter: Should we log filter hits for actions that were only throttled? - https://phabricator.wikimedia.org/T196995 (10Daimona) [10:48:10] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) [10:49:27] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) [10:49:29] 10AbuseFilter: do not set throttle on warn action - https://phabricator.wikimedia.org/T24623 (10Daimona) [10:49:42] 10AbuseFilter, 10Core-Platform-Team, 10Technical-Debt: Major overhaul for "throttle" action - https://phabricator.wikimedia.org/T203587 (10Daimona) [10:49:45] 10AbuseFilter, 10Patch-For-Review: "Throttle" action seems to malfunction randomly - https://phabricator.wikimedia.org/T195699 (10Daimona) [10:50:19] (03CR) 10D3r1ck01: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [10:51:59] (03PS1) 10Elhuyar Fundazioa: Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) [10:52:54] (03CR) 10jerkins-bot: [V: 04-1] Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) (owner: 10Elhuyar Fundazioa) [10:54:23] 10MediaWiki-extensions-GettingStarted, 10Growth-Team, 10Patch-For-Review, 10User-Elukey: Improve GettingStarted data storage strategy - https://phabricator.wikimedia.org/T158239 (10JTannerWMF) [10:54:27] (03CR) 10Physikerwelt: [C: 032] "Can we add some documentation for this? I could not find any specification on how phpunits annotation parser works." [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [10:54:34] 10MediaWiki-extensions-GettingStarted, 10Growth-Team: Make GettingStarted functionality accessible at any time - https://phabricator.wikimedia.org/T163943 (10JTannerWMF) [10:55:53] 10MediaWiki-extensions-LoginNotify, 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.... - https://phabricator.wikimedia.org/T179765 [10:55:58] 10MediaWiki-extensions-GettingStarted, 10Growth-Team: Special:RandomInCategory doesn't work with GettingStarted - https://phabricator.wikimedia.org/T78213 (10JTannerWMF) [10:56:01] 10ContentTranslation, 10Language-2018-July-September: CX2: Add to a maintenance category when translation is published with too much unmodified text - https://phabricator.wikimedia.org/T190798 (10santhosh) @pginer-WMF, please clarify how this is not conflicting with {T190283} [10:56:47] (03CR) 10Brian Wolff: "My better explanation:" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458334 (https://phabricator.wikimedia.org/T203490) (owner: 10Brian Wolff) [10:56:59] (03CR) 10Elhuyar Fundazioa: "recheck" [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) (owner: 10Elhuyar Fundazioa) [10:57:44] (03CR) 10D3r1ck01: "recheck" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (owner: 10D3r1ck01) [10:57:57] (03CR) 10jerkins-bot: [V: 04-1] Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) (owner: 10Elhuyar Fundazioa) [11:00:30] (03CR) 10jerkins-bot: [V: 04-1] Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) (owner: 10Elhuyar Fundazioa) [11:00:33] (03PS7) 10Physikerwelt: Fix common typos in code [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:01:09] (03CR) 10Physikerwelt: [C: 032] Fix common typos in code [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:02:56] (03PS2) 10Physikerwelt: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [11:03:29] (03CR) 10Brian Wolff: "Specifically, the assert that was failing was:" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457087 (owner: 10Brian Wolff) [11:04:18] (03PS2) 10Jdrewniak: Improving jQuery selectors in Page.findChildInSectionLead [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) [11:04:31] (03PS1) 10Seb35: Property 'hashed' in Assertion must be a boolean [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/458480 [11:05:32] 10MediaWiki-extensions-GuidedTour, 10Growth-Team: Fix how tours are conditionally defined/started - https://phabricator.wikimedia.org/T69906 (10JTannerWMF) [11:05:56] (03CR) 10Seb35: "Validators like https://badgecheck.io trigger a warning without this patch." [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/458480 (owner: 10Seb35) [11:06:09] 10MediaWiki-extensions-GuidedTour, 10Growth-Team: Fix how tours are conditionally defined/started - https://phabricator.wikimedia.org/T69906 (10JTannerWMF) 05Open>03Resolved a:03JTannerWMF [11:06:22] (03CR) 10jerkins-bot: [V: 04-1] build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [11:06:38] 10MediaWiki-extensions-GuidedTour, 10Growth-Team: Fix how tours are conditionally defined/started - https://phabricator.wikimedia.org/T69906 (10JTannerWMF) 05Resolved>03Open [11:07:29] (03PS2) 10Elhuyar Fundazioa: Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) [11:08:12] (03CR) 10jerkins-bot: [V: 04-1] Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) (owner: 10Elhuyar Fundazioa) [11:10:08] (03PS3) 10Elhuyar Fundazioa: Fix correct handling of abbreviations when splitting sentences [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458478 (https://phabricator.wikimedia.org/T195031) [11:10:10] (03Abandoned) 10Jdrewniak: Fix multiple-issues template in page sections [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457688 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [11:11:19] (03CR) 10Gergő Tisza: "On second thought, that's problem, but not a problem with this patch per se. So if you prefer to merge it like this (in case we want a ba" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [11:11:21] 10ContentTranslation, 10Language-2018-July-September: CX2: Add to a maintenance category when translation is published with too much unmodified text - https://phabricator.wikimedia.org/T190798 (10Pginer-WMF) [11:12:09] (03PS2) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) [11:13:55] 10ContentTranslation, 10Language-2018-July-September: CX2: Warning about article having changed too much - https://phabricator.wikimedia.org/T168287 (10santhosh) [11:16:02] 10ContentTranslation, 10Language-2018-July-September: CX2: Add to a maintenance category when translation is published with too much unmodified text - https://phabricator.wikimedia.org/T190798 (10Pginer-WMF) >>! In T190798#4562328, @santhosh wrote: > @pginer-WMF, please clarify how this is not conflicting with... [11:16:35] 10MediaWiki-extensions-General, 10Patch-For-Review, 10User-D3r1ck01: Review and update MediaWiki extensions to use most recent ESLint pattern - https://phabricator.wikimedia.org/T203648 (10D3r1ck01) [11:20:26] (03Merged) 10jenkins-bot: Fix less vars [extensions/BlueSpiceSignHere] - 10https://gerrit.wikimedia.org/r/458472 (owner: 10Mglaser) [11:21:07] 10CommRel-Specialists-Support: Post-mortem on support for CE insights this year. - https://phabricator.wikimedia.org/T203650 (10Elitre) [11:21:17] 10CommRel-Specialists-Support: Post-mortem on support for CE insights this year. - https://phabricator.wikimedia.org/T203650 (10Elitre) p:05Triage>03Low [11:23:11] 10MediaWiki-extensions-Arrays: Discuss future of the Arrays extension - https://phabricator.wikimedia.org/T203519 (10MGChecker) >>! In T203519#4561992, @Kghbln wrote: >> I think it's a pity that there's no procedure in place to really maintain popular extensions on Gerrit if they aren't WMF-deployed. Many of the... [11:24:17] (03PS4) 10Jdrewniak: Fix page-issue icons for multiple issues in a single section [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457928 (https://phabricator.wikimedia.org/T202349) [11:24:24] (03PS2) 10Amire80: WIP Move exif messages to a separate i18n file [core] - 10https://gerrit.wikimedia.org/r/458165 (https://phabricator.wikimedia.org/T167762) [11:27:21] (03CR) 10Daniel Kinzler: "> Tested on vagrant by saving an empty page with User1, then previewing" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [11:27:27] (03CR) 10jerkins-bot: [V: 04-1] Ensure database tests run as part of --group Database [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [11:29:34] (03CR) 10Jdrewniak: [C: 04-1] Fix page-issue icons for multiple issues in a single section (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457928 (https://phabricator.wikimedia.org/T202349) (owner: 10Jdrewniak) [11:29:37] (03PS1) 10Elhuyar Fundazioa: Add Basque language support [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/458485 [11:30:58] (03Merged) 10jenkins-bot: Fix common typos in code [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:33:09] (03PS1) 10Brian Wolff: Fix IN list case for db conds when doing $conds['field'][] = $tainted [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458487 (https://phabricator.wikimedia.org/T201987) [11:34:36] (03CR) 10jerkins-bot: [V: 04-1] WIP Move exif messages to a separate i18n file [core] - 10https://gerrit.wikimedia.org/r/458165 (https://phabricator.wikimedia.org/T167762) (owner: 10Amire80) [11:34:50] 10MediaWiki-Core-Tests, 10phan-taint-check-plugin, 10Continuous-Integration-Config: Configure CI to run phan-taint-check-plugin for MediaWiki core - https://phabricator.wikimedia.org/T203630 (10Bawolff) Yes. There are still quite a few false positives to sort out, but its starting to get more manageable [11:35:07] 10MediaWiki-extensions-General, 10Patch-For-Review, 10User-D3r1ck01: Review and update MediaWiki extensions to use most recent ESLint pattern - https://phabricator.wikimedia.org/T203648 (10D3r1ck01) [11:37:02] 10phan-taint-check-plugin: Optimize phan-taint-check speed - https://phabricator.wikimedia.org/T203651 (10Bawolff) [11:37:41] (03CR) 10jenkins-bot: Fix common typos in code [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:38:11] 10phan-taint-check-plugin: Fix caused-by lines in phan-taint-check - https://phabricator.wikimedia.org/T203652 (10Bawolff) [11:39:02] 10ContentTranslation, 10Language-2018-July-September: CX2: Allow to switch between CX1 and CX2 from the dashboard - https://phabricator.wikimedia.org/T194387 (10Pginer-WMF) [11:40:14] 10MediaWiki-Internationalization, 10translatewiki.net, 10I18n, 10Patch-For-Review: Split core en.json to several files - https://phabricator.wikimedia.org/T167762 (10Bawolff) >>! In T167762#4559280, @gerritbot wrote: > Change 458165 had a related patch set uploaded (by Amire80; owner: Amire80): > [mediawik... [11:41:19] (03PS4) 10MGChecker: Move actual extension code to its own class [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/424863 (https://phabricator.wikimedia.org/T174884) [11:42:09] 10MediaWiki-General-or-Unknown, 10Documentation: Document data-mw="interface" - https://phabricator.wikimedia.org/T203653 (10Esanders) [11:42:28] (03CR) 10jerkins-bot: [V: 04-1] Move actual extension code to its own class [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/424863 (https://phabricator.wikimedia.org/T174884) (owner: 10MGChecker) [11:46:03] 10MediaWiki-General-or-Unknown, 10Documentation: Document data-mw="interface" - https://phabricator.wikimedia.org/T203653 (10Esanders) Actually there are a few comments: * In mediawiki.htmlform: "We can trust this value, 'data-mw-*' attributes are banned from user content in Sanitizer" * In SkinTemplate: "Set... [11:46:11] 10MediaWiki-General-or-Unknown, 10Documentation: Document data-mw="interface" consistently - https://phabricator.wikimedia.org/T203653 (10Esanders) [11:46:28] (03PS3) 10Physikerwelt: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [11:46:52] (03PS5) 10MGChecker: Move actual extension code to its own class [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/424863 (https://phabricator.wikimedia.org/T174884) [11:47:32] (03PS14) 10Esanders: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [11:48:26] (03PS2) 10Physikerwelt: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [11:48:30] (03CR) 10jerkins-bot: [V: 04-1] Move actual extension code to its own class [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/424863 (https://phabricator.wikimedia.org/T174884) (owner: 10MGChecker) [11:49:08] (03PS6) 10Physikerwelt: Ensure database tests run as part of --group Database [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [11:50:20] (03PS4) 10Esanders: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) [11:51:45] 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Esanders) [11:53:42] (03PS6) 10MGChecker: Move actual extension code to its own class [extensions/DeleteOwn] - 10https://gerrit.wikimedia.org/r/424863 (https://phabricator.wikimedia.org/T174884) [11:53:43] 10MediaWiki-Internationalization, 10translatewiki.net, 10I18n, 10Patch-For-Review: Split core en.json to several files - https://phabricator.wikimedia.org/T167762 (10Amire80) >>! In T167762#4562437, @Bawolff wrote: >>>! In T167762#4559280, @gerritbot wrote: >> Change 458165 had a related patch set uploaded... [11:53:55] 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Esanders) Looks like we are re-activating the surface, but due to the nature of dialog processes it doesn't happen in the same event cycle as the user click even... [11:59:30] 04(no projects): Add sub-domain sciencesource-query to expose Query Service endpoint - https://phabricator.wikimedia.org/T203644 (10Aklapper) > but don't yet have a project set up. Ah. [[ https://www.mediawiki.org/wiki/Phabricator/Creating_and_renaming_projects | Please request a project? ]] :) [12:02:14] 10MediaWiki-Internationalization, 10translatewiki.net, 10I18n, 10Patch-For-Review: Split core en.json to several files - https://phabricator.wikimedia.org/T167762 (10Bawolff) > Thanks for the comment! If I understand correctly, this sounds sensible, but I'm really not familiar with this. Who is develo... [12:04:10] 10MediaWiki-extensions-WikibaseClient, 10Readers-Web-Backlog, 10Wikidata, 10SEO: Add Schema property 'sameAs' pointing to Wikidata entries - https://phabricator.wikimedia.org/T198946 (10phuedx) OTOH [[ https://www.mediawiki.org/wiki/Extension:GoogleRichCards | the Google Rich Cards extension ]] seems to ad... [12:04:34] 10VisualEditor (Current work): Mobile VE: Show virtual keyboard when a dialog is closed without any edit - https://phabricator.wikimedia.org/T203517 (10Esanders) a:03Esanders [12:06:41] 10Discovery-Search (Current work): Evaluate adding an image quality score to media search result ranking - https://phabricator.wikimedia.org/T202339 (10Miriam) @EBernhardson from my previous work on in image search, there are two ways to evaluate search results: * Quantitavely: based on historical data, you see... [12:07:04] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata: Investigate way forward for item selectors - https://phabricator.wikimedia.org/T200767 (10Jan_Dittrich) Methodological suggestion: > Existing implementations: Identify usage domains. I would say * search * language selector/new lexeme * item... [12:07:36] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Wikimedia-Fundraising: Track when a CentralNotice banner was displayed to the user in NavTiming - https://phabricator.wikimedia.org/T195840 (10Gilles) @Ejegg when is the next CentralNotice deployment scheduled? If not scheduled or far in the futu... [12:08:54] (03PS13) 10Daimona Eaytoy: Code quality improvements [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/457860 [12:09:58] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata: Order of Forms - https://phabricator.wikimedia.org/T176405 (10Jan_Dittrich) 1) First fix would be getting away from alphabetical sorting of numbers 2) I think that sorting by meaning (here: grammatical features) makes the most sense. Caveat: We... [12:11:20] 10CX-cxserver, 10Language-2018-July-September, 10Performance: Performance analysis for translate API - https://phabricator.wikimedia.org/T203077 (10santhosh) I was not able to translate at all before https://gerrit.wikimedia.org/r/c/mediawiki/services/cxserver/+/458132 and https://gerrit.wikimedia.org/r/c/m... [12:11:32] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata: mis-x-Q1234: labels for mis spelling variants - https://phabricator.wikimedia.org/T201592 (10Jan_Dittrich) It would make sense if miss-spelling would be also a selectable option (or "flag"?), as far as I understand, you need to define it manually. [12:12:34] 10MediaWiki-Logging, 10MediaWiki-Recent-changes, 10Growth-Team, 10I18n: LogFormatter::getIRCActionText() incorrectly escaping messages - https://phabricator.wikimedia.org/T203655 (10Bawolff) [12:12:50] (03PS2) 10Pmiguelpirzer: Hide notification-options without permission [extensions/BlueSpiceEditNotifyConnector] (REL1_27) - 10https://gerrit.wikimedia.org/r/458199 [12:14:07] (03CR) 10Fomafix: [C: 04-1] Allow skins to place notification container for mw.notify (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [12:17:36] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata: Unify separator between language and lexical category - https://phabricator.wikimedia.org/T201808 (10Jan_Dittrich) Would that go through a function of some sort that renders the Word/Language combination? Or would this be defined in CSS what the... [12:20:55] 10MediaWiki-HTMLForm, 10OOUI: Use NumberInputWidget in HTMLFloatField - https://phabricator.wikimedia.org/T203656 (10Mainframe98) [12:22:24] 10phan-taint-check-plugin: phan-taint-check should avoid false positives with getQueryInfo() methods - https://phabricator.wikimedia.org/T203657 (10Bawolff) [12:24:29] 10Dumps-Generation, 10Patch-For-Review: Clean up flow dump job problems for Sept 1 2018 dumps run - https://phabricator.wikimedia.org/T203647 (10ArielGlenn) Small wikis with complete dumps have now been fixed up except for mediawikiwiki, which is in progress; those files will appear in due time on the web serv... [12:26:22] (03CR) 10Physikerwelt: [C: 032] "." [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [12:27:21] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Collect ResourceTiming data of top article image - https://phabricator.wikimedia.org/T197609 (10Gilles) Identifying the top image in the article (from the content meaningfulness perspective) is a bit tricky, because some infoboxes point directly to i... [12:30:03] 10Wikimedia-User-Group-Basque: Zientzia Astea - https://phabricator.wikimedia.org/T176660 (10Aklapper) @Theklan: As this has been //Unbreak now// ("needs to be fixed immediately, setting anything else aside") for seven months now I ask you to correct the priority of this task to reflect reality. Thanks. [12:31:50] 10Design, 10OOUI, 10VisualEditor: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) [12:32:27] (03PS1) 10Mainframe98: Use NumberInputWidget in HTMLFloatField [core] - 10https://gerrit.wikimedia.org/r/458492 (https://phabricator.wikimedia.org/T203656) [12:34:03] 10Design, 10OOUI, 10VisualEditor: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) [12:36:27] (03CR) 10Daniel Kinzler: "Analysis:" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [12:37:57] (03CR) 10jerkins-bot: [V: 04-1] Use NumberInputWidget in HTMLFloatField [core] - 10https://gerrit.wikimedia.org/r/458492 (https://phabricator.wikimedia.org/T203656) (owner: 10Mainframe98) [12:38:21] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10Tgr) >>! In T200987#4506270, @Aklapper wrote: > Hmm. Why is this supposed to work better than IRC code review hours, apart from not having to be around at a certain time? That and not pretending that code rev... [12:39:37] (03PS2) 10Mainframe98: Use NumberInputWidget in HTMLFloatField [core] - 10https://gerrit.wikimedia.org/r/458492 (https://phabricator.wikimedia.org/T203656) [12:40:22] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10Tgr) @Bmueller is this something volunteer dev support people at WMDE are interested in? (Tried to find the right project for that but got lost. Is it #WMDE-Tech-Communication?) [12:41:11] 10ContentTranslation, 10Language-2018-July-September: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Pginer-WMF) [12:42:33] 10ContentTranslation, 10Language-2018-July-September: CX2: Highlight (and skip) references with a template that could not be adapted - https://phabricator.wikimedia.org/T203160 (10Pginer-WMF) p:05Normal>03High [12:44:42] 10ContentTranslation, 10Language-2018-July-September: CX2: Reference template adapted as empty despite templateData - https://phabricator.wikimedia.org/T203550 (10Pginer-WMF) It seems that having templateData is not enough to guarantee the automatic mapping of parameters. The parameters need to have an alias t... [12:45:47] (03Merged) 10jenkins-bot: Ensure database tests run as part of --group Database [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [12:46:33] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Collect ResourceTiming data of top article image - https://phabricator.wikimedia.org/T197609 (10Gilles) This seems to do the trick: ``` var srcset, urls = [], img = $( '.mw-parser-output img' ).filter( function( idx, e ) { return e.width * e.height... [12:47:03] 10Design, 10Design-Research, 10VisualEditor (Current work): "Leave site?" message erroneously shown after user has saved an edit and is back in read mode - https://phabricator.wikimedia.org/T202587 (10Esanders) a:03Esanders [12:48:30] (03PS3) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [12:48:51] (03CR) 10Daniel Kinzler: [C: 04-1] "Parser behavior needs regression test" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [12:49:34] (03CR) 10jenkins-bot: Ensure database tests run as part of --group Database [extensions/Math] - 10https://gerrit.wikimedia.org/r/457886 (https://phabricator.wikimedia.org/T202223) (owner: 10Jakob) [12:54:29] 10Research: Test the model for eliciting new editor interests - https://phabricator.wikimedia.org/T190776 (10Trizek-WMF) That update hasn't raised pulblic feedback: https://en.wikipedia.org/wiki/Wikipedia:Village_pump_(miscellaneous)/Archive_59#Experiment:_Eliciting_New_Editor_Interests_[Update] I haven't heard... [12:54:36] (03CR) 10Daniel Kinzler: [C: 04-1] Provide new, unsaved revision to PST to fix magic words. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [12:55:01] 10MediaWiki-Cache, 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [12:58:25] 10MediaWiki-Cache, 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [12:58:37] 10MediaWiki-Cache, 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:02:42] (03PS1) 10Brian Wolff: Include syntax errors in the output of plugin. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 [13:02:44] (03PS1) 10Brian Wolff: Avoid false positive related to getQueryInfo() methods. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458499 (https://phabricator.wikimedia.org/T203657) [13:03:21] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10Tgr) Probably related to the MCR work on revision rendering. [13:07:39] (03CR) 10jerkins-bot: [V: 04-1] Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [13:08:04] 10MediaWiki-Cache, 10Wikimedia-production-error: Notice: serialize(): "" returned as member variable from __sleep() but does not exist - https://phabricator.wikimedia.org/T203566 (10hashar) Ditto when promoting all wikis: 84 Notice: serialize(): "" returned as member variable from __sleep() but does not... [13:08:22] (03CR) 10jerkins-bot: [V: 04-1] Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [13:09:43] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) I am sorry about the confusion. And I want to explicitly apologize to the TWN people. When we started to archive extensions there was a misco... [13:11:16] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:12:02] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:12:23] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10hashar) I have rolled the t... [13:12:51] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:13:38] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:21:18] (03PS1) 10Ebe123: Add checks for length of generated audio files [extensions/Score] - 10https://gerrit.wikimedia.org/r/458503 (https://phabricator.wikimedia.org/T203560) [13:22:21] (03CR) 10Ebe123: "More holistic solution." [extensions/Score] - 10https://gerrit.wikimedia.org/r/458503 (https://phabricator.wikimedia.org/T203560) (owner: 10Ebe123) [13:24:00] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Move advanced contributions prototype to labs - https://phabricator.wikimedia.org/T203480 (10Niedzielski) @alexhollender / @ovasileva, would you attach any files you want hosted to this task? [13:24:55] 10MediaWiki-Cache, 10Wikimedia-production-error: Notice: serialize(): "" returned as member variable from __sleep() but does not exist - https://phabricator.wikimedia.org/T203566 (10hashar) That might be related to {T156541}. The cache has a serialized object of a class at version n-1 and that has some side e... [13:25:01] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10hashar) That might be relat... [13:25:34] 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Technical-Debt: Simplify CategoryOverlay for readability - https://phabricator.wikimedia.org/T191987 (10Niedzielski) a:03Niedzielski [13:25:48] 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Improve alignment in visual editor table dialog - https://phabricator.wikimedia.org/T203467 (10Esanders) After: {F25677938} [13:27:04] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [13:28:59] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, 10Performance-Team (Radar), 10Research-2017-18-Q4: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10bmansurov) @Krinkle thanks! Looking [[ https://gi... [13:29:22] 10Design, 10Lexicographical data, 10WMDE-Design, 10Wikidata: mis-x-Q1234: labels for mis spelling variants - https://phabricator.wikimedia.org/T201592 (10Lea_Lacroix_WMDE) I think this ticket is only about display/reading, but yes, we should also think about a better way to select "mis" and then select the... [13:31:50] 10MediaWiki-extensions-NavigationTiming, 10Performance-Team: Collect ResourceTiming data of top article image - https://phabricator.wikimedia.org/T197609 (10Gilles) Created the schema to collect the ResourceTiming data: https://meta.wikimedia.org/wiki/Schema:ResourceTiming I ended up making it generic and not... [13:33:57] 10donate.wikimedia.org: Current language should appear first on donor support pages - https://phabricator.wikimedia.org/T201013 (10Pcoombe) 05Open>03Resolved Done, although it might be worth re-writing in Lua at some point to make the code a bit clearer. [13:35:39] 10Design, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) [13:36:00] 10Research-Programs, 10Epic, 10Research-2017-18-Q4: Analyze the first round of data about readers' usage of references - https://phabricator.wikimedia.org/T190437 (10bmansurov) [13:36:03] 10Research, 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)): Schema:CitationUsage improvements - https://phabricator.wikimedia.org/T199807 (10bmansurov) 05Resolved>03Open [13:36:26] 10Design, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) >>! In T202278#4548191, @Esanders wrote: > It may actually be the case that with the browsers than we want t... [13:39:22] (03CR) 10Foxtrott: [C: 04-1] "The composer installer for the mediawiki-extension type converts the first character of the name and all characters following a hyphen to " [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [13:41:33] 10Design, 10VisualEditor-MediaWiki-Mobile, 10VisualEditor (Current work): Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Esanders) [13:41:59] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10TheDJ) I don't have enough... [13:43:01] 10VisualEditor (Current work): [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Esanders) > Now place the cursor at the end of line There shouldn't be a place to put your cursor, as hiero is a block level element. [13:45:22] (03PS35) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [13:45:33] 10VisualEditor (Current work): [Regression pre-wmf.18] Toolbar does not get activated after pressing return - https://phabricator.wikimedia.org/T202359 (10Esanders) I note that in FF this is different, and you can put your cursor there. [13:53:43] (03PS2) 10Mglaser: Initial commit [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/458141 (owner: 10Robert Vogel) [13:54:23] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/458141 (owner: 10Robert Vogel) [13:54:25] (03CR) 10Niedzielski: [C: 04-1] Begin webpack + test transition of mobile.startup (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458299 (https://phabricator.wikimedia.org/T203100) (owner: 10Nray) [13:57:59] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [13:59:49] (03CR) 10MGChecker: "I think this is the path to move forward for now, but I am willing to convert these to use the proper way ($parser->getOutput()->setExtens" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [14:00:59] (03PS9) 10MGChecker: Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) [14:01:23] (03PS3) 10Mglaser: Initial commit [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/458141 (owner: 10Robert Vogel) [14:02:02] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/458141 (owner: 10Robert Vogel) [14:02:05] (03PS10) 10MGChecker: Add phan to composer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) [14:02:26] 10Repository-Ownership-Requests: +2 for Kghbln on Extension:UserExport - https://phabricator.wikimedia.org/T203375 (10Kghbln) > I'd say https://gerrit.wikimedia.org/r/#/groups/self is what you're looking for. Thanks a bunch. I have spread more than expected I guess. ;) [14:06:42] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10Anomie) For this particular... [14:08:04] (03PS10) 10Kosta Harlan: Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) [14:08:52] (03PS1) 10Hashar: QA: add missing wdio-junit-reporter [extensions/Popups] - 10https://gerrit.wikimedia.org/r/458509 (https://phabricator.wikimedia.org/T203591) [14:09:50] (03CR) 10Hashar: "So we can do:" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/458509 (https://phabricator.wikimedia.org/T203591) (owner: 10Hashar) [14:12:06] (03CR) 10MGChecker: "check experimental" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/457101 (https://phabricator.wikimedia.org/T203364) (owner: 10MGChecker) [14:15:59] 10WMSE-Connected-Open-Heritage-2018: Name change COH2 project - https://phabricator.wikimedia.org/T198782 (10Jopparn) [14:16:42] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10Niharika) [14:17:20] 10WMSE-Connected-Open-Heritage-2018: Name change COH2 project - https://phabricator.wikimedia.org/T198782 (10Jopparn) [14:19:25] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10IKhitron) [14:19:40] 10BlueSpice: Key 8:bs-ooui-field-tagmultiselect-input-placeholder already belongs to ext-bs, conflict with ext-bs-ooui - https://phabricator.wikimedia.org/T203672 (10Nikerabbit) [14:22:25] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10Niharika) > My understanding is that we'll keep a track of each template that was inserted (including if the same one was inserted multiple times) and then on the 'p... [14:23:45] (03CR) 10Pyro853: "Hi Foxtrott," [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [14:25:10] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10greg) [14:27:27] (03CR) 10Foxtrott: [C: 031] "Oops, I missed it down there, sorry. I blame it on gerrit hiding the require section. :)" [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [14:27:53] 10Connected-Open-Heritage-Batch-uploads (SMVK-mexiko_2016-12), 10WMSE-GLAM-2018 (WMSE-National-Museums-of-World-Culture-2017-WiR): Handle images with bad metadata images from SMVK - https://phabricator.wikimedia.org/T154981 (10Jopparn) >>! In T154981#4381376, @Lokal_Profil wrote: > @AxelPettersson_WMSE Dependi... [14:28:24] (03PS4) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [14:28:43] (03CR) 10Kosta Harlan: [C: 04-1] "Looks good except for one comment that needs to be updated." (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456392 (https://phabricator.wikimedia.org/T202998) (owner: 10Sbisson) [14:29:05] (03CR) 10Niedzielski: [C: 032] QA: add missing wdio-junit-reporter [extensions/Popups] - 10https://gerrit.wikimedia.org/r/458509 (https://phabricator.wikimedia.org/T203591) (owner: 10Hashar) [14:29:54] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, 10Performance-Team (Radar), 10Research-2017-18-Q4: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10Nuria) @bmansurov we get data via varnish that do... [14:30:33] (03PS5) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [14:32:11] 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Epic, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10Nemo_bis) The extension (and skin) needs a dedicated component in Phabricator for bug rep... [14:36:10] (03CR) 10Anomie: "> This works with the code in DerivedPageDataUpdater since it makes the parser use a Revision object for PST that has a user and timestamp" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [14:37:12] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint): Value of 0 for "Days to show in watchlist" or "Maximum number of changes to show in watchlist" setting breaks watchlists; should instead be interpreted as maximum or no limit - https://phabricator.wikimedia.org/T199049 (10kos... [14:37:51] (03CR) 10Lucas Werkmeister: Initial commit (031 comment) [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [14:39:42] (03Merged) 10jenkins-bot: QA: add missing wdio-junit-reporter [extensions/Popups] - 10https://gerrit.wikimedia.org/r/458509 (https://phabricator.wikimedia.org/T203591) (owner: 10Hashar) [14:39:55] 10MediaWiki-extensions-Variables: Bring RELEASE-NOTES up to date - https://phabricator.wikimedia.org/T202953 (10MGChecker) p:05Normal>03High [14:40:54] 10MediaWiki-Internationalization, 10translatewiki.net, 10I18n, 10Patch-For-Review: Split core en.json to several files - https://phabricator.wikimedia.org/T167762 (10Nikerabbit) If you can keep the format of the i18n files, all that is needed to use them in MediaWiki is to have them registered in $wgMessag... [14:41:07] 10MediaWiki-extensions-Variables: Split ExtVariables in multiple classes - https://phabricator.wikimedia.org/T202421 (10MGChecker) To make a start, we could move the hook functions to a seperate file. After the MW 1.32 branching point, we could split the parser functions and the actual Variables store as well. [14:41:14] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10Patch-For-Review: Remove current time from edit conflict header - https://phabricator.wikimedia.org/T202053 (10Hanna_Petruschat_WMDE) Thanks for pointing this pout. These are very valid usability issues. I made a mock to adapt your... [14:41:18] (03PS6) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [14:42:37] (03CR) 10Anomie: Fix undeletion write-both/read-old mode. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/455630 (https://phabricator.wikimedia.org/T174024) (owner: 10Daniel Kinzler) [14:43:33] (03CR) 10jenkins-bot: QA: add missing wdio-junit-reporter [extensions/Popups] - 10https://gerrit.wikimedia.org/r/458509 (https://phabricator.wikimedia.org/T203591) (owner: 10Hashar) [14:44:21] (03CR) 10Daniel Kinzler: "> Note it's not exactly "no content", it's inheriting all slots from the current revision." [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [14:45:53] 10MediaWiki-extensions-Variables: Set PPFrame volatile inside functions accessing the Variables store - https://phabricator.wikimedia.org/T203677 (10MGChecker) [14:45:56] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Nikerabbit) > (On a related note, what's the preferred method of notifying TWN people of these archivals? Currently [as you can see] the to-do list d... [14:46:41] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Regression: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision - https://phabricator.wikimedia.org/T203583 (10... [14:47:39] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Page moving does not work properly any more - https://phabricator.wikimedia.org/T203661 (10daniel) Confirming that this is broken on master, and worked in wmf.19. [14:48:38] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) I [[ https://youtu.be/1Mt8B_Q17mI | recorded the test ]] as I did it on m... [14:50:06] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Old page title is displayed after renaming a page - https://phabricator.wikimedia.org/T203661 (10daniel) [14:50:13] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Old page title is displayed after renaming a page - https://phabricator.wikimedia.org/T203661 (10daniel) a:03daniel [14:52:34] (03PS3) 10Niedzielski: Hygiene: update Webpack output comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458191 [14:56:09] (03CR) 10jerkins-bot: [V: 04-1] Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [14:56:49] (03PS1) 10Kosta Harlan: Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) [14:58:38] (03PS1) 10MGChecker: Refactor initFunction [extensions/Variables] - 10https://gerrit.wikimedia.org/r/458518 [15:01:12] (03CR) 10jerkins-bot: [V: 04-1] Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [15:04:11] (03PS7) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [15:06:14] 10ContentTranslation, 10UniversalLanguageSelector: CX2: autofill for 'gu' (gujarati) displays some underlying text - https://phabricator.wikimedia.org/T203269 (10KartikMistry) [15:06:16] (03PS15) 10Esanders: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [15:08:22] (03PS1) 10Daimona Eaytoy: Add italian translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458521 (https://phabricator.wikimedia.org/T203297) [15:08:40] 10CX-cxserver, 10Language-2018-July-September, 10Performance: Performance analysis for translate API - https://phabricator.wikimedia.org/T203077 (10Nikerabbit) 1. Is the table translatable with cold caches? It doesn't really mean anything if it is translatable with warm caches, as users will see a failure (a... [15:10:57] 10Design, 10OOUI, 10VisualEditor: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Jdforrester-WMF) > If it's possible on mobile devices to detect that a physical keyboard is being used It isn't. [15:12:42] (03CR) 10Jdlrobson: [C: 032] Hygiene: update Webpack output comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458191 (owner: 10Niedzielski) [15:13:52] (03CR) 10Jdlrobson: Begin webpack + test transition of mobile.startup (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458299 (https://phabricator.wikimedia.org/T203100) (owner: 10Nray) [15:19:27] 10Design, 10Design-Research, 10VisualEditor-MediaWiki, 10VisualEditor (Current work): "Leave site?" message erroneously shown after user has saved an edit and is back in read mode - https://phabricator.wikimedia.org/T202587 (10Jdforrester-WMF) [15:20:52] (03CR) 10Jforrester: [C: 032] "…" [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [15:27:24] (03Merged) 10jenkins-bot: Hygiene: update Webpack output comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458191 (owner: 10Niedzielski) [15:28:31] (03CR) 10DCausse: "can it be a failure activated in jenkins config?" [core] - 10https://gerrit.wikimedia.org/r/458312 (owner: 10Smalyshev) [15:29:52] (03CR) 10Nemo bis: [C: 031] "Ok, some things to fix but better do it on the wiki." [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458521 (https://phabricator.wikimedia.org/T203297) (owner: 10Daimona Eaytoy) [15:30:41] (03CR) 10Daimona Eaytoy: "> Ok, some things to fix but better do it on the wiki." [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458521 (https://phabricator.wikimedia.org/T203297) (owner: 10Daimona Eaytoy) [15:31:52] (03CR) 10jenkins-bot: Hygiene: update Webpack output comments [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458191 (owner: 10Niedzielski) [15:32:03] (03CR) 10Anomie: "> > Probably also ApiComparePages is similarly broken, and various extensions that do a PST." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [15:32:46] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Old page title is displayed after renaming a page until the page is subsequently edited/null edited - https://phabricator.wikimedia.org/T203661 (10Jdforrester-WMF) [15:34:58] 10AbuseFilter, 10PostgreSQL, 10SQLite: Make AbuseFilter work on PostgreSQL and SQLite (tracking) - https://phabricator.wikimedia.org/T199544 (10Daimona) p:05Triage>03Normal [15:35:46] (03CR) 10D3r1ck01: Revert "Revert "add extension name in composer.json"" (032 comments) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/423612 (https://phabricator.wikimedia.org/T191003) (owner: 10Pyro) [15:35:48] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: erreur - https://phabricator.wikimedia.org/T203681 (10Jeremyleriche) [15:36:40] (03CR) 10D3r1ck01: Revert "Revert "add extension name in composer.json"" (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/423612 (https://phabricator.wikimedia.org/T191003) (owner: 10Pyro) [15:37:29] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: erreur - https://phabricator.wikimedia.org/T203682 (10Jeremyleriche) [15:40:23] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a last synced status indicator on reading lists - https://phabricator.wikimedia.org/T196577 (10cooltey) Thanks, @RHo. Will do it. [15:40:38] (03PS36) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [15:42:37] (03CR) 10D3r1ck01: "No need for that here!" (031 comment) [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/423612 (https://phabricator.wikimedia.org/T191003) (owner: 10Pyro) [15:43:07] 10Anti-Harassment, 10TechCom-RFC (TechCom-Approved): RFC: Block users by page, namespace, and/or action (Partial Blocks) - https://phabricator.wikimedia.org/T199917 (10TBolliger) Thank you! [15:43:24] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Product-Analytics: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10nettrom_WMF) [15:43:37] (03CR) 10D3r1ck01: fix composer package name to match conventions (031 comment) [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/454560 (owner: 10Pyro) [15:43:54] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Product-Analytics: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10aezell) Correct. We are going to provide the statistics in the description. We did not interpret the description to include the scenario that... [15:43:57] (03CR) 10D3r1ck01: "recheck" [extensions/MyVariables] - 10https://gerrit.wikimedia.org/r/454427 (owner: 10ValeryanM) [15:45:35] 10Library-Card-Platform: Ensure that logs are saved even when the environment is recreated - https://phabricator.wikimedia.org/T203685 (10Samwalton9) [15:45:52] 10Library-Card-Platform: Ensure that logs are saved even when the environment is recreated - https://phabricator.wikimedia.org/T203685 (10Samwalton9) p:05Triage>03High [15:46:55] 10Library-Card-Platform: Update Github READMEs - https://phabricator.wikimedia.org/T203686 (10Samwalton9) [15:47:10] 10Library-Card-Platform: Update Github READMEs - https://phabricator.wikimedia.org/T203686 (10Samwalton9) p:05Triage>03Normal [15:48:44] 10Library-Card-Platform: Add translation support notes to a README (blocktrans trimmed, # Translators comment) - https://phabricator.wikimedia.org/T203687 (10Samwalton9) [15:48:57] 10Library-Card-Platform: Add translation support notes to a README (blocktrans trimmed, # Translators comment) - https://phabricator.wikimedia.org/T203687 (10Samwalton9) p:05Triage>03Normal [15:53:01] (03CR) 10Nray: [C: 04-1] Begin webpack + test transition of mobile.startup (037 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458299 (https://phabricator.wikimedia.org/T203100) (owner: 10Nray) [15:53:15] (03Merged) 10jenkins-bot: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [15:53:42] 10Developer-Advocacy: Set up volunteer code review queue - https://phabricator.wikimedia.org/T200987 (10MarcoAurelio) [nitpick] There's no Verified-2 label; only V+1/+2/-1. Thanks. [15:54:33] (03CR) 10Jdlrobson: [C: 032] Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [15:54:44] (03PS2) 10Jforrester: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/457297 (owner: 10Libraryupgrader) [15:55:09] (03PS3) 10Jforrester: Code of Conduct: Update link to use Special:MyLanguage (T202047) [extensions/Math] - 10https://gerrit.wikimedia.org/r/457297 (owner: 10Libraryupgrader) [15:55:16] (03CR) 10Jforrester: [C: 032] Code of Conduct: Update link to use Special:MyLanguage (T202047) [extensions/Math] - 10https://gerrit.wikimedia.org/r/457297 (owner: 10Libraryupgrader) [15:55:25] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Product-Analytics: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10Niharika) That works for me. 👍 [15:56:04] (03PS4) 10Jforrester: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [15:56:06] (03PS2) 10Umherirrender: Add missing types to @param PHPDoc tags [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457834 (owner: 10Thiemo Kreuz (WMDE)) [15:56:08] (03CR) 10Umherirrender: [C: 032] Add missing types to @param PHPDoc tags [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457834 (owner: 10Thiemo Kreuz (WMDE)) [15:56:11] (03PS5) 10Jforrester: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [15:56:15] (03CR) 10Jforrester: [C: 032] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [15:57:02] (03CR) 10jenkins-bot: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/458320 (owner: 10Jforrester) [15:58:02] (03CR) 10Jdlrobson: [C: 032] Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [15:58:24] (03PS1) 10Daniel Kinzler: Require a Title as context for rendering. [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203583) [15:59:13] 04(no projects): REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Vort) [15:59:40] 10MediaWiki-General-or-Unknown, 10Documentation: Document data-mw="interface" consistently - https://phabricator.wikimedia.org/T203653 (10Jdlrobson) Maybe https://www.mediawiki.org/wiki/HTML_restriction is a good place? Right now searching for data-mw produces no useful search results. [16:00:15] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/457347 (owner: 10Libraryupgrader) [16:00:18] (03CR) 10Umherirrender: [V: 032] "T201745" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/457347 (owner: 10Libraryupgrader) [16:00:22] (03PS2) 10Daniel Kinzler: Require a Title as context for rendering. [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203583) [16:00:38] (03PS2) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/458321 (owner: 10Jforrester) [16:00:43] (03Abandoned) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/458321 (owner: 10Jforrester) [16:00:45] (03PS3) 10Daniel Kinzler: Require a Title as context for rendering. [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) [16:01:12] 10MediaWiki-Releasing, 10AbuseFilter, 10MW-1.32-release: Bundle AbuseFilter extension with MW 1.32 - https://phabricator.wikimedia.org/T191740 (10Daimona) Looking at WMF config, these are my thoughts about default configuration: # Regarding available actions (AbuseFilterActions), I think we should remove bl... [16:01:31] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: add commit-message-validator to ci - https://phabricator.wikimedia.org/T203309 (10Lokal_Profil) 05Open>03Resolved a:03Lokal_Profil [16:01:39] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/457153 (owner: 10Libraryupgrader) [16:01:44] (03CR) 10Umherirrender: [V: 032] "T202455" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/457153 (owner: 10Libraryupgrader) [16:01:58] (03PS2) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/458317 (owner: 10Jforrester) [16:02:05] (03Abandoned) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/458317 (owner: 10Jforrester) [16:02:43] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/457468 (owner: 10Libraryupgrader) [16:02:47] (03CR) 10Umherirrender: [V: 032] "T203346" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/457468 (owner: 10Libraryupgrader) [16:02:57] (03PS2) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/458322 (owner: 10Jforrester) [16:03:06] (03Abandoned) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/458322 (owner: 10Jforrester) [16:03:29] (03PS2) 10Umherirrender: Fix incorrect usage in RenameUserJob [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/443474 (https://phabricator.wikimedia.org/T198285) (owner: 10Anomie) [16:03:42] (03CR) 10Umherirrender: [V: 032 C: 031] "T203346" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/443474 (https://phabricator.wikimedia.org/T198285) (owner: 10Anomie) [16:04:16] 10MediaWiki-General-or-Unknown, 10Tracking: Issues affecting translatewiki.net - https://phabricator.wikimedia.org/T41480 (10Umherirrender) [16:04:19] 10MediaWiki-extensions-Renameuser, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Patch-For-Review: Renameuser producing a lot of errors - https://phabricator.wikimedia.org/T198285 (10Umherirrender) 05Open>03Resolved p:05Triage>03Normal a:03Anomie [16:04:37] (03PS8) 10Umherirrender: Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [16:05:38] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Regression: Old page title is displayed after renaming a page until the page is subsequently edited/null edited - https://phabricator.wikimedia.org/T203661 (10daniel) Fix is up. When I recently intr... [16:06:34] 10Collection, 10Wikimedia-Logstash, 10Wikimedia-production-error: Logstash Notice: Undefined variable: subtitle in Collection extension - https://phabricator.wikimedia.org/T203594 (10Jdlrobson) [16:06:58] 10MediaWiki-extensions-Quiz, 10Editing-team, 10VisualEditor, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 3 others: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Umherirrender) 05Open>03Resolved p:05Tria... [16:07:41] 10MediaWiki-Parser, 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Aklapper) Confirming for my sandbox page on mediawiki.org [16:08:18] 10Wiki-Loves-Monuments-Database, 10Patch-For-Review, 10Wiki-Loves-Monuments (2018): Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Xqt) p:05Triage>03High Get it too recently [16:08:27] 10MediaWiki-extensions-CategoryTree, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Wikimedia-production-error: BadMethodCallException from line 98 of ApiCategoryTree.php: Call to... - https://phabricator.wikimedia.org/T202057 [16:10:33] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/457153 (owner: 10Libraryupgrader) [16:10:49] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/457286 (owner: 10Libraryupgrader) [16:10:54] (03CR) 10Umherirrender: [V: 032] "T203281" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/457286 (owner: 10Libraryupgrader) [16:11:19] (03PS2) 10Umherirrender: build: Bump mediawiki-codesniffer to 22.0.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458319 (owner: 10Jforrester) [16:11:23] (03CR) 10Bartosz Dziewoński: [C: 04-1] "Yes, I can do it. I had some troubles too but I think I got it working. I'll document them on T203616." [vendor] - 10https://gerrit.wikimedia.org/r/458270 (owner: 10VolkerE) [16:11:42] (03CR) 10Jforrester: [C: 031] Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) (owner: 10Kosta Harlan) [16:12:14] 10Collection, 10Wikimedia-Logstash, 10Wikimedia-production-error: Logstash Notice: Undefined variable: subtitle in Collection extension - https://phabricator.wikimedia.org/T203594 (10Jdlrobson) Do notices have a stack trace? I can't seem to find one.. [16:12:22] (03PS3) 10Umherirrender: build: Enable Squiz.PHP.NonExecutableCode.Unreachable [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458319 (owner: 10Jforrester) [16:12:57] (03CR) 10Jforrester: [C: 031] "That works. :-)" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458319 (owner: 10Jforrester) [16:13:19] (03CR) 10Umherirrender: [V: 032] "T203329" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/457175 (owner: 10Libraryupgrader) [16:14:55] (03PS4) 10Daniel Kinzler: Require a Title as context for rendering. [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) [16:15:19] (03Merged) 10jenkins-bot: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [16:15:22] (03CR) 10jerkins-bot: [V: 04-1] Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [16:17:01] 10MediaWiki-extensions-LiquidThreads, 10phan-taint-check-plugin: phan-taint-check-plugin failing for LiquidThreads extension - https://phabricator.wikimedia.org/T203690 (10Umherirrender) [16:17:48] (03CR) 10Jdlrobson: "@krinkle is there a phab task where this was standardised before?" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457958 (owner: 10Niedzielski) [16:18:54] (03CR) 10jenkins-bot: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [16:19:38] (03PS1) 10Bartosz Dziewoński: Update OOUI to v0.28.1 [core] - 10https://gerrit.wikimedia.org/r/458528 [16:20:33] (03CR) 10jerkins-bot: [V: 04-1] build: Enable Squiz.PHP.NonExecutableCode.Unreachable [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458319 (owner: 10Jforrester) [16:21:01] 10MediaWiki-General-or-Unknown, 10OOUI: How to make maintenance script for managing foreign resources work (Vagrant/non-Vagrant) - https://phabricator.wikimedia.org/T203616 (10matmarex) The script works for me, but I had to solve two problems to get it to run: * Enable PHP fileinfo extension (duh) * Run with... [16:21:17] (03CR) 10Bartosz Dziewoński: "Done in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/458528" [vendor] - 10https://gerrit.wikimedia.org/r/458270 (owner: 10VolkerE) [16:22:21] (03CR) 10Daniel Kinzler: "> Patch Set 7:" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [16:22:23] (03CR) 10Umherirrender: [V: 032 C: 032] "T203690" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458319 (owner: 10Jforrester) [16:22:41] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/457153 (owner: 10Libraryupgrader) [16:23:22] 10MediaWiki-extensions-LiquidThreads, 10phan-taint-check-plugin: phan-taint-check-plugin failing for LiquidThreads extension - https://phabricator.wikimedia.org/T203690 (10Umherirrender) [16:25:09] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: "Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix - https://phabricator.wikimedia.org/T203284 (10MMiller_WMF) @Et... [16:25:20] (03PS5) 10Jdlrobson: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [16:25:24] (03Abandoned) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/MOOC] - 10https://gerrit.wikimedia.org/r/457292 (owner: 10Libraryupgrader) [16:25:27] (03CR) 10Jdlrobson: [C: 032] Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [16:26:04] (03CR) 10Umherirrender: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/PhpTagsMaps] - 10https://gerrit.wikimedia.org/r/457383 (owner: 10Libraryupgrader) [16:26:45] 10MediaWiki-Parser, 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10greg) When did this stop working? [16:26:50] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/457727 (owner: 10Libraryupgrader) [16:26:54] (03CR) 10Umherirrender: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/WikiLexicalData] - 10https://gerrit.wikimedia.org/r/457727 (owner: 10Libraryupgrader) [16:28:35] (03PS2) 10Bartosz Dziewoński: Update OOUI to v0.28.1 [core] - 10https://gerrit.wikimedia.org/r/458528 [16:29:08] 10Epic, 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Technical-Debt (RW-Tech-Debt): [EPIC] Build entire mobile.startup module using webpack bundler - https://phabricator.wikimedia.org/T155802 (10Jdlrobson) This is the current goal relating to T1954... [16:29:17] (03Merged) 10jenkins-bot: Add missing types to @param PHPDoc tags [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457834 (owner: 10Thiemo Kreuz (WMDE)) [16:29:39] (03CR) 10Krinkle: "FSG is an informal group. There is a phab workboard and a weekly Hangout led by Volker currently. It's basically tagging it and/or adding " [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457958 (owner: 10Niedzielski) [16:29:49] (03CR) 10Umherirrender: [V: 032] "T201449" [extensions/OpenID] - 10https://gerrit.wikimedia.org/r/457344 (owner: 10Libraryupgrader) [16:29:59] 10MediaWiki-General-or-Unknown, 10OOUI: How to make maintenance script for managing foreign resources work (Vagrant/non-Vagrant) - https://phabricator.wikimedia.org/T203616 (10matmarex) …And I forgot to run `composer require oojs/oojs-ui 0.28.1`. I think bringing back a script like the old update-ooui.sh to au... [16:31:07] 10MediaWiki-Parser, 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Vort) First report was made ~3 hours ago (13:46 UTC) at ruwiki forum. [16:31:48] 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Begin webpack + test transition of mobile.startup - https://phabricator.wikimedia.org/T203100 (10Jdlrobson) [16:31:51] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Jdlrobson) [16:31:53] 10Epic, 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Technical-Debt (RW-Tech-Debt): [EPIC] Build entire mobile.startup module using webpack bundler - https://phabricator.wikimedia.org/T155802 (10Jdlrobson) [16:31:59] (03CR) 10Umherirrender: "recheck" [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/457535 (owner: 10Libraryupgrader) [16:32:38] 10Epic, 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Technical-Debt (RW-Tech-Debt): [EPIC] Build entire mobile.startup module using webpack bundler - https://phabricator.wikimedia.org/T155802 (10Jdlrobson) [16:32:48] (03CR) 10Bartosz Dziewoński: Update OOUI to v0.28.1 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [16:33:23] (03CR) 10Umherirrender: [V: 032] "The failure is since I94a0c7c20f78c31149685c4443564be240ddad50" [extensions/Contest] - 10https://gerrit.wikimedia.org/r/457191 (owner: 10Libraryupgrader) [16:33:34] (03PS8) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [16:33:51] (03PS9) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) [16:33:59] (03CR) 10Daniel Kinzler: Provide new, unsaved revision to PST to fix magic words. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [16:34:38] 10MediaWiki-ResourceLoader, 10Performance-Team: Audit modules (2018) - https://phabricator.wikimedia.org/T202154 (10Krinkle) [16:35:08] 10SVG Translate Tool, 10I18n: Way to change word order? - https://phabricator.wikimedia.org/T203444 (10Glrx) I'd close this a dup of T201207 and T202771. In general, search T201207 for "mare". The case mentioned there was "Ionian Sea" to "Mare Ionio". If the words are isolated, then they should be merged into... [16:35:38] (03CR) 10jenkins-bot: Code of Conduct: Update link to use Special:MyLanguage (T202047) [extensions/Math] - 10https://gerrit.wikimedia.org/r/457297 (owner: 10Libraryupgrader) [16:36:11] (03PS7) 10Daniel Kinzler: Cover incomplete revision case in RenderedRevision. [core] - 10https://gerrit.wikimedia.org/r/457450 (https://phabricator.wikimedia.org/T174035) [16:36:23] (03PS26) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [16:36:33] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/457535 (owner: 10Libraryupgrader) [16:37:36] (03PS8) 10Daniel Kinzler: Cover incomplete revision case in RenderedRevision. [core] - 10https://gerrit.wikimedia.org/r/457450 (https://phabricator.wikimedia.org/T174035) [16:37:39] (03PS27) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [16:38:13] (03PS1) 10EBernhardson: Bump mjolnir to latest master [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/458532 [16:39:10] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [16:39:58] (03CR) 10Gehel: [C: 032] "LGTM" [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/458532 (owner: 10EBernhardson) [16:40:10] (03CR) 10Gehel: [V: 032 C: 032] Bump mjolnir to latest master [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/458532 (owner: 10EBernhardson) [16:40:12] (03CR) 10Umherirrender: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 22.0.0 [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/457535 (owner: 10Libraryupgrader) [16:40:32] (03CR) 10Jdlrobson: [C: 04-1] "The createBanner function feels very verbose and mysterious to me now. I strongly feel we should break this up to show its separate concer" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457928 (https://phabricator.wikimedia.org/T202349) (owner: 10Jdrewniak) [16:40:34] (03Merged) 10jenkins-bot: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [16:40:44] (03PS28) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [16:40:48] (03CR) 10Umherirrender: [V: 032 C: 032] Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [16:41:35] (03PS1) 10Krinkle: Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 [16:42:54] (03CR) 10EBernhardson: [V: 032 C: 032] Update spark.yaml for latest mjolnir [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/454895 (owner: 10EBernhardson) [16:42:58] (03CR) 10jenkins-bot: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [16:44:14] (03PS2) 10Jforrester: Bump qunit from 2.6.0 to 2.6.2 [core] - 10https://gerrit.wikimedia.org/r/458326 [16:44:38] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Jdlrobson) a:05Esanders>03alexhollender [16:44:39] (03PS2) 10Umherirrender: Remove obsolete "constructor" comments documenting constructors as such [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457835 (owner: 10Thiemo Kreuz (WMDE)) [16:44:50] (03CR) 10Umherirrender: [C: 032] Remove obsolete "constructor" comments documenting constructors as such [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457835 (owner: 10Thiemo Kreuz (WMDE)) [16:44:52] 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Jdlrobson) @alexhollender this is ready for testing on https://reading-web-staging.wmfl... [16:44:54] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [16:45:26] (03PS3) 10Umherirrender: Set allowedPrefixes PHPCS property only where needed [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456085 (owner: 10Thiemo Kreuz (WMDE)) [16:45:30] (03CR) 10Umherirrender: [C: 032] Set allowedPrefixes PHPCS property only where needed [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456085 (owner: 10Thiemo Kreuz (WMDE)) [16:49:37] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10daniel) > tests indicate th... [16:50:52] 10MediaWiki-Logging, 10MediaWiki-Recent-changes, 10Growth-Team, 10I18n: LogFormatter::getIRCActionText() incorrectly escaping messages - https://phabricator.wikimedia.org/T203655 (10Krinkle) Can you provide a few before/after examples of the exact output? Then I'll run it by a few IRC processors to see whe... [16:50:56] (03PS2) 10Jdlrobson: Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [16:51:10] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10daniel) btw, I just realize... [16:51:18] 10MediaWiki-Parser, 10Multi-Content-Revisions, 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Umherirrender) [16:51:56] (03CR) 10Krinkle: "recheck" [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [16:54:35] 10Audiences-QA, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10alexholl... [16:54:45] (03Merged) 10jenkins-bot: Remove obsolete "constructor" comments documenting constructors as such [extensions/DataTable2] - 10https://gerrit.wikimedia.org/r/457835 (owner: 10Thiemo Kreuz (WMDE)) [16:54:51] (03Merged) 10jenkins-bot: Set allowedPrefixes PHPCS property only where needed [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456085 (owner: 10Thiemo Kreuz (WMDE)) [16:56:06] (03PS2) 10Umherirrender: Remove unused "return true" from hook handlers [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456352 (owner: 10Thiemo Kreuz (WMDE)) [16:56:10] (03CR) 10Umherirrender: [C: 032] Remove unused "return true" from hook handlers [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456352 (owner: 10Thiemo Kreuz (WMDE)) [16:57:40] 10MediaWiki-extensions-General, 10VPS-project-libraryupgrader, 10I18n: CODE_OF_CONDUCT.md should link to the mediawiki.org page in user's preferred language - https://phabricator.wikimedia.org/T202047 (10Petar.petkovic) [16:57:49] (03CR) 10jerkins-bot: [V: 04-1] Bump qunit from 2.6.0 to 2.6.2 [core] - 10https://gerrit.wikimedia.org/r/458326 (owner: 10Jforrester) [16:57:53] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Continuous-Integration-Config: Run `maintenance/resources/manageForeignResources.php verify` as a test on MediaWiki core - https://phabricator.wikimedia.org/T203694 (10Jdforrester-WMF) [16:58:39] (03PS1) 10VolkerE: Improve German translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458537 [17:01:26] 10MediaWiki-General-or-Unknown, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Patch-For-Review, 10Release-Engineering-Team (Kanban), and 2 others: `npm audit` for mediawiki/core found 24 vulnerabilities - https://phabricator.wikimedia.org/T194280 (10Jdforrester-WMF) State after https:/... [17:01:50] (03PS3) 10Jforrester: build: Bump most devDependencies to latest [core] - 10https://gerrit.wikimedia.org/r/458197 (https://phabricator.wikimedia.org/T194280) [17:02:13] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Move advanced contributions prototype to labs - https://phabricator.wikimedia.org/T203480 (10pmiazga) a:03pmiazga [17:02:27] (03PS2) 10VolkerE: Improve German translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458537 [17:02:29] (03PS3) 10Jforrester: Bump qunit from 2.6.0 to 2.6.2 [core] - 10https://gerrit.wikimedia.org/r/458326 [17:02:56] 10MediaWiki-Parser, 10Multi-Content-Revisions, 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Umherirrender) Maybe fixed with T203583 [17:04:46] MatmaRex: dang, thanks for digging [17:05:18] Volker_E: does that help you? no idea what the problem you're experiencing is [17:05:54] MatmaRex: well, I'll try to follow your steps next [17:06:02] 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10Jdlrobson) [17:06:35] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Continuous-Integration-Config: Run `maintenance/resources/manageForeignResources.php verify` as a test on MediaWiki core - https://phabricator.wikimedia.org/T203694 (10Krinkle) Yeah, sounds good to me! * The urls are expected to be immutable. The main value... [17:07:18] 10Audiences-QA, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10alexholl... [17:07:30] won't be any earlier than later afternoon though, which is fine, as you've done the most important work already :) [17:07:34] MatmaRex: ^ [17:07:48] (03Merged) 10jenkins-bot: Remove unused "return true" from hook handlers [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456352 (owner: 10Thiemo Kreuz (WMDE)) [17:07:55] sure [17:09:32] (03CR) 10VolkerE: [C: 032] Update OOUI to v0.28.1 [vendor] - 10https://gerrit.wikimedia.org/r/458270 (owner: 10VolkerE) [17:09:55] 10English-Wikipedia-New-Pages-Patrol, 10Epic, 10Growth-Team (Current Sprint): New Pages Feed: copyvio addition - https://phabricator.wikimedia.org/T199359 (10Etonkovidova) [17:09:59] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: "Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix - https://phabricator.wikimedia.org/T203284 (10Etonkovidova) 0... [17:10:14] MatmaRex: I actually shouldn't +2 https://gerrit.wikimedia.org/r/#/c/mediawiki/vendor/+/458270/, would you? [17:10:58] MatmaRex: let's be very bureaucratic here [17:11:00] ;) [17:11:14] yeah [17:11:34] Volker_E: if you +2 the other one. because if we merge only one, everything will break [17:11:44] that was my plan [17:11:56] (03CR) 10Bartosz Dziewoński: [C: 032] Update OOUI to v0.28.1 [vendor] - 10https://gerrit.wikimedia.org/r/458270 (owner: 10VolkerE) [17:12:01] (03CR) 10VolkerE: [C: 032] Update OOUI to v0.28.1 [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [17:13:15] (03PS2) 10Umherirrender: Add missing strict array type hints [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456351 (owner: 10Thiemo Kreuz (WMDE)) [17:13:18] (03CR) 10Umherirrender: [C: 032] Add missing strict array type hints [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456351 (owner: 10Thiemo Kreuz (WMDE)) [17:14:35] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Move advanced contributions prototype to labs - https://phabricator.wikimedia.org/T203480 (10alexhollender) Can we move this to blocked on others temporarily? I need 1-2 more days to finalize the prototype. [17:14:57] (03CR) 10jerkins-bot: [V: 04-1] Bump qunit from 2.6.0 to 2.6.2 [core] - 10https://gerrit.wikimedia.org/r/458326 (owner: 10Jforrester) [17:15:12] 10CirrusSearch, 10Discovery-Search: Cindy-the-test-browser-bot should provide more helpful output (file names, line numbers) instead of one long line - https://phabricator.wikimedia.org/T202807 (10EBjune) p:05Triage>03Low To really address this, we need to figure out how to get Cindy into CI, which is goin... [17:15:23] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Move advanced contributions prototype to labs - https://phabricator.wikimedia.org/T203480 (10pmiazga) ok, I'll do a quick research where to put it and comment in the task. [17:17:26] (03PS2) 10Kosta Harlan: Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) [17:19:37] (03PS4) 10Umherirrender: Linker: more consistent whitespace parsing in formatLinksInComment [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [17:19:39] (03CR) 10Umherirrender: [C: 032] Linker: more consistent whitespace parsing in formatLinksInComment [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [17:21:52] 10Design-Research, 10New-Editor-Experiences: Ask all communities with an help project about questions they are used to - https://phabricator.wikimedia.org/T192569 (10aripstra) 05Open>03Resolved p:05Triage>03Normal [17:23:08] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Regression: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision - https://phabricator.wikimedia.org/T203583 (10... [17:24:47] (03Merged) 10jenkins-bot: Update OOUI to v0.28.1 [vendor] - 10https://gerrit.wikimedia.org/r/458270 (owner: 10VolkerE) [17:25:24] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): New Pages Feed: potential issues sometimes wrap to next line - https://phabricator.wikimedia.org/T203116 (10kostajh) a:03kostajh [17:25:57] (03CR) 10Jdlrobson: [C: 032] Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [17:26:03] (03PS5) 10Umherirrender: Fixed typo in word "unnecessary" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/458057 (https://phabricator.wikimedia.org/T201491) (owner: 10Acamicamacaraca) [17:26:04] (03CR) 10Jforrester: [C: 032] Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [17:26:08] (03PS6) 10Umherirrender: Fixed typo in word "unnecessary" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/458057 (https://phabricator.wikimedia.org/T201491) (owner: 10Acamicamacaraca) [17:26:21] (03CR) 10Krinkle: [C: 032] build: Bump most devDependencies to latest [core] - 10https://gerrit.wikimedia.org/r/458197 (https://phabricator.wikimedia.org/T194280) (owner: 10Jforrester) [17:26:26] (03CR) 10Umherirrender: [V: 032 C: 032] "T201745" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/458057 (https://phabricator.wikimedia.org/T201491) (owner: 10Acamicamacaraca) [17:29:25] (03CR) 10Umherirrender: [C: 032] "no space left on device" [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [17:30:17] (03CR) 10Krinkle: [C: 032] Drop reference to wgDisableCounters, always true since MW1.25 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/458080 (owner: 10Jforrester) [17:31:28] (03Merged) 10jenkins-bot: Update OOUI to v0.28.1 [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [17:31:30] (03Merged) 10jenkins-bot: Add missing strict array type hints [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456351 (owner: 10Thiemo Kreuz (WMDE)) [17:32:08] (03CR) 10jerkins-bot: [V: 04-1] Linker: more consistent whitespace parsing in formatLinksInComment [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [17:32:31] 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Jdforrester-WMF) [17:32:36] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10Notifications, and 2 others: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837 (10Jdforrester-WMF) [17:32:50] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10Notifications, and 2 others: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837 (10Jdforrester-WMF) [17:33:04] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Growth-Team, 10Notifications, and 2 others: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837 (10Jdforrester-WMF) [17:33:31] 10Design, 10OOUI, 10VisualEditor: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Volker_E) Adding to 'it isn't'. Two further reading resources: 1. CSS media feature only providing device specific feedback via browser on keyboard... [17:33:38] 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Jdforrester-WMF) [17:33:44] 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Jdforrester-WMF) [17:34:14] (03CR) 10jenkins-bot: Update OOUI to v0.28.1 [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [17:34:27] (03CR) 10Smalyshev: "> Patch Set 2:" [core] - 10https://gerrit.wikimedia.org/r/458312 (owner: 10Smalyshev) [17:34:35] 10MediaWiki-ResourceLoader, 10Performance-Team: Audit modules (2018) - https://phabricator.wikimedia.org/T202154 (10Jdforrester-WMF) [17:36:31] (03CR) 10Jforrester: "Oh, whoops. We forgot the step of tagging the commit with the tasks…" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [17:37:34] (03CR) 10Jforrester: "Specifically:" [core] - 10https://gerrit.wikimedia.org/r/458528 (owner: 10Bartosz Dziewoński) [17:37:52] (03PS1) 10EBernhardson: Align msearch daemon arguments [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458542 [17:38:30] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Regression: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision - https://phabricator.wikimedia.org/T203583 (10... [17:38:34] 10UniversalLanguageSelector, 10Language-2018-October-December: wgULSGeoService and https://freegeoip.net/ out of service - https://phabricator.wikimedia.org/T199106 (10Valeryan_M) The latest firefox and chrome browser flags any secure wiki site using this as insecure and stops script execution because freegeoi... [17:38:45] 10Design, 10Advanced-Search, 10TCB-Team, 10WMDE-Design, and 2 others: [Investigate] Should some OOUI-icons be different on ar-wiki? - https://phabricator.wikimedia.org/T178568 (10Jdforrester-WMF) Merged into MediaWiki via https://gerrit.wikimedia.org/r/c/mediawiki/core/+/458528 and so in 1.32.0-wmf.22. [17:39:40] 10Design, 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10OOUI (OOUI-0.28.1), 10UI-Standardization-Kanban: Bring VE extension icons to OOUI packs and further align them - https://phabricator.wikimedia.org/T195480 (10Jdforrester-WMF) Merged into MediaWiki via https... [17:41:23] (03CR) 10jerkins-bot: [V: 04-1] Align msearch daemon arguments [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458542 (owner: 10EBernhardson) [17:42:11] (03Merged) 10jenkins-bot: Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [17:42:13] (03Merged) 10jenkins-bot: Drop reference to wgDisableCounters, always true since MW1.25 [extensions/intersection] - 10https://gerrit.wikimedia.org/r/458080 (owner: 10Jforrester) [17:42:23] (03CR) 10Anomie: [C: 032] "I agree, the Parser should be getting all this information from the ParserOptions: revision ID, title, user, target language, and so on. B" [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [17:42:55] (03CR) 10jerkins-bot: [V: 04-1] build: Bump most devDependencies to latest [core] - 10https://gerrit.wikimedia.org/r/458197 (https://phabricator.wikimedia.org/T194280) (owner: 10Jforrester) [17:43:51] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: erreur - https://phabricator.wikimedia.org/T203682 (10Aklapper) [17:43:53] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: erreur - https://phabricator.wikimedia.org/T203681 (10Aklapper) [17:44:06] (03CR) 10jenkins-bot: Remove redundant closure aliases [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/458533 (owner: 10Krinkle) [17:44:25] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: erreur - https://phabricator.wikimedia.org/T203681 (10Aklapper) 05Open>03Invalid Please report wikifab problems to wikifab so wikifab can fix their broken website and add CORS headers to images. See https://enable-cors.org/server.html [17:44:48] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Images not displayed on wikifab.org due to missing CORS - https://phabricator.wikimedia.org/T203681 (10Aklapper) [17:47:18] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, and 2 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name, but the username of the last revision - https://phabricator.wikimedia.org/T203583 (10Kr... [17:47:43] (03PS1) 10Sbisson: Fix tests locally by clearing the cache between them [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458543 [17:47:50] 10Design, 10OOUI, 10VisualEditor: Font formatting keyboard shortcuts are shown in Visual Editor on mobile devices - https://phabricator.wikimedia.org/T203659 (10Amire80) Thanks for the replies. As I said, it's not a thing that gets in the way very badly. More like a thing that came up as part of exploratory... [17:47:58] (03PS1) 10Sbisson: Ensure a valid AfC sort option is selected [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458544 (https://phabricator.wikimedia.org/T202917) [17:48:09] (03PS2) 10EBernhardson: Align msearch daemon arguments [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458542 [17:51:21] (03CR) 10jerkins-bot: [V: 04-1] Align msearch daemon arguments [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458542 (owner: 10EBernhardson) [17:53:29] (03CR) 10Jdlrobson: [C: 04-1] Improving jQuery selectors in Page.findChildInSectionLead (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [17:57:16] (03Merged) 10jenkins-bot: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [17:57:18] (03CR) 10Jdlrobson: [C: 04-1] Improving jQuery selectors in Page.findChildInSectionLead (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [17:58:58] (03PS1) 10Jforrester: Provide new, unsaved revision to PST to fix magic words. [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458545 (https://phabricator.wikimedia.org/T203583) [17:59:48] (03CR) 10jenkins-bot: Provide new, unsaved revision to PST to fix magic words. [core] - 10https://gerrit.wikimedia.org/r/458251 (https://phabricator.wikimedia.org/T203583) (owner: 10Daniel Kinzler) [18:00:22] (03CR) 10Anomie: "It looks like this will work to fix T203661, but I think in the long run it's not the right fix. Instead the code calling this after the p" [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) (owner: 10Daniel Kinzler) [18:00:45] (03PS2) 10Krinkle: Provide new, unsaved revision to PST to fix magic words. [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458545 (https://phabricator.wikimedia.org/T203583) (owner: 10Jforrester) [18:00:48] (03CR) 10Krinkle: [C: 032] Provide new, unsaved revision to PST to fix magic words. [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458545 (https://phabricator.wikimedia.org/T203583) (owner: 10Jforrester) [18:06:54] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Regression: Old page title is displayed after renaming a page until the page is subsequently edited/null edited - https://phabricator.wikimedia.org/T203661 (10greg) [18:07:48] (03PS1) 10Nikerabbit: Support renaming pages from CLI [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/458546 [18:09:11] (03CR) 10Anomie: "> although we should watch for new DB deadlocks in that case in case the ordering matters in that respect." [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) (owner: 10Daniel Kinzler) [18:09:16] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:09:20] (03PS1) 10Anomie: Provide a RevisionRecord with the correct title after a move [core] - 10https://gerrit.wikimedia.org/r/458547 (https://phabricator.wikimedia.org/T203661) [18:09:38] (03CR) 10Anomie: "I submitted my alternative proposal as I9ebdcbc566b11dea3a9bdd402ea4418c4e51b096." [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) (owner: 10Daniel Kinzler) [18:10:36] (03CR) 10jerkins-bot: [V: 04-1] Support renaming pages from CLI [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/458546 (owner: 10Nikerabbit) [18:12:06] (03PS3) 10D3r1ck01: Add recent pattern for ESLinting to repo [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) [18:13:40] (03CR) 10Kosta Harlan: "This change is ready for review." [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) (owner: 10Kosta Harlan) [18:13:52] (03PS1) 10Dbrant: [HYPER WIP]: Further experiments with tabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458548 (https://phabricator.wikimedia.org/T198473) [18:15:19] (03PS2) 10Dbrant: [HYPER WIP]: Further experiments with tabs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458548 (https://phabricator.wikimedia.org/T198473) [18:16:57] (03CR) 10Krinkle: [C: 032] look for the BackupDumper class in the (new) correct place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/458477 (https://phabricator.wikimedia.org/T203647) (owner: 10ArielGlenn) [18:17:05] (03PS1) 10Krinkle: look for the BackupDumper class in the (new) correct place [extensions/Flow] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458549 (https://phabricator.wikimedia.org/T203647) [18:17:22] 10Dumps-Generation, 10Patch-For-Review: Clean up flow dump job problems for Sept 1 2018 dumps run - https://phabricator.wikimedia.org/T203647 (10Krinkle) [18:17:30] (03CR) 10Krinkle: [C: 032] look for the BackupDumper class in the (new) correct place [extensions/Flow] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458549 (https://phabricator.wikimedia.org/T203647) (owner: 10Krinkle) [18:17:47] (03PS1) 10Kosta Harlan: WIP: Use localStorage for tracking PageTriage last use [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458550 (https://phabricator.wikimedia.org/T203273) [18:17:50] (03Merged) 10jenkins-bot: Provide new, unsaved revision to PST to fix magic words. [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458545 (https://phabricator.wikimedia.org/T203583) (owner: 10Jforrester) [18:18:15] (03PS2) 10Cooltey: Greyed out views if articles are not available offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458337 (https://phabricator.wikimedia.org/T158852) [18:19:09] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:19:41] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:20:18] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Regression: PageTriage last use not persisted properly for user session - https://phabricator.wikimedia.org/T203273 (10kostajh) 05Open>03stalled Per discussion with @MMiller_WMF today, submitting my WIP patch for... [18:20:28] (03CR) 10EBernhardson: [V: 032 C: 032] "Test failure is unrelated, fallout from test deployment of Ibdb56ed495361f to tox jobs" [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458542 (owner: 10EBernhardson) [18:20:37] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review, 10Regression: PageTriage last use not persisted properly for user session - https://phabricator.wikimedia.org/T203273 (10kostajh) a:05kostajh>03None [18:21:10] (03CR) 10jenkins-bot: Provide new, unsaved revision to PST to fix magic words. [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458545 (https://phabricator.wikimedia.org/T203583) (owner: 10Jforrester) [18:21:27] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10RHo) Nice one @iamjessklein – btw I plan to use an app called [[ http://www.duapps.com/... [18:22:46] (03PS1) 10EBernhardson: Fix cli argument parsing [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/458551 [18:23:01] (03CR) 10EBernhardson: [V: 032 C: 032] Fix cli argument parsing [search/MjoLniR/deploy] - 10https://gerrit.wikimedia.org/r/458551 (owner: 10EBernhardson) [18:23:09] (03CR) 10Jforrester: [C: 04-1] "Per task." [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/458474 (https://phabricator.wikimedia.org/T203648) (owner: 10D3r1ck01) [18:23:30] (03CR) 10Gergő Tisza: [C: 032] "Tested, works as expected." [core] - 10https://gerrit.wikimedia.org/r/458547 (https://phabricator.wikimedia.org/T203661) (owner: 10Anomie) [18:24:11] 10MediaWiki-extensions-General, 10Patch-For-Review, 10User-D3r1ck01: Review and update MediaWiki extensions to use most recent ESLint pattern - https://phabricator.wikimedia.org/T203648 (10Jdforrester-WMF) This is really ugly. I think we should do the reverse; linting file configuration should be as much as... [18:24:17] 04(no projects): Refresh the Production Deployment Review Process (aka Review Queue) - https://phabricator.wikimedia.org/T203697 (10Jrbranaa) [18:26:41] (03CR) 10Dbrant: [C: 032] Follow up: show the RHS edge of overflow menus in the reading list items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458082 (owner: 10Cooltey) [18:27:51] (03PS1) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458552 [18:29:30] 10MediaWiki-Database, 10Wikimedia-production-error: Fix "Transaction round stage must be 'cursory' (not 'within-rollback')" from LBFactory/DeferredUpdates - https://phabricator.wikimedia.org/T203700 (10Jdforrester-WMF) [18:29:46] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10CKoerner_WMF) [18:30:12] (03CR) 10Jforrester: [C: 032] Add checks for length of generated audio files [extensions/Score] - 10https://gerrit.wikimedia.org/r/458503 (https://phabricator.wikimedia.org/T203560) (owner: 10Ebe123) [18:30:54] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:31:04] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:31:08] (03CR) 10Dbrant: [C: 032] Fix: Add Serializable to child objects to avoid crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456518 (owner: 10Cooltey) [18:32:11] (03PS2) 10Nikerabbit: Support renaming pages from CLI [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/458546 [18:33:38] (03Abandoned) 10Dbrant: Prelude: move network clients to 'dataclient' package: A through D [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456504 (owner: 10Dbrant) [18:33:45] 10MediaWiki-extensions-LoginNotify, 10Notifications, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review: Can't dismiss failed login attempt notification (or other notifications from login.wikimedia.... - https://phabricator.wikimedia.org/T179765 [18:34:39] (03CR) 10jerkins-bot: [V: 04-1] Support renaming pages from CLI [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/458546 (owner: 10Nikerabbit) [18:35:57] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:36:09] (03CR) 10Gergő Tisza: "> It looks like this will work to fix T203661, but I think in the long run it's not the right fix." [core] - 10https://gerrit.wikimedia.org/r/458526 (https://phabricator.wikimedia.org/T203661) (owner: 10Daniel Kinzler) [18:36:19] (03Merged) 10jenkins-bot: look for the BackupDumper class in the (new) correct place [extensions/Flow] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458549 (https://phabricator.wikimedia.org/T203647) (owner: 10Krinkle) [18:37:17] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Improve the display of link previews for disambiguation pages - https://phabricator.wikimedia.org/T202369 (10ABorbaWMF) Looks good to me on 2.7.239-alpha-2018-09-04 @RHo may want... [18:38:44] (03CR) 10VolkerE: [C: 031] HTMLInfoField: Support 'rawrow' in OOUI mode [core] - 10https://gerrit.wikimedia.org/r/457510 (https://phabricator.wikimedia.org/T203202) (owner: 10Bartosz Dziewoński) [18:40:57] (03CR) 10jerkins-bot: [V: 04-1] exception: Do not log PHP errors with severity DEBUG or INFO [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458552 (owner: 10Krinkle) [18:41:42] (03Merged) 10jenkins-bot: Follow up: show the RHS edge of overflow menus in the reading list items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458082 (owner: 10Cooltey) [18:42:26] (03PS1) 10Niedzielski: Hygiene: move page issue group parsing to parser [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458557 (https://phabricator.wikimedia.org/T203449) [18:42:31] (03Merged) 10jenkins-bot: look for the BackupDumper class in the (new) correct place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/458477 (https://phabricator.wikimedia.org/T203647) (owner: 10ArielGlenn) [18:42:36] (03Merged) 10jenkins-bot: Provide a RevisionRecord with the correct title after a move [core] - 10https://gerrit.wikimedia.org/r/458547 (https://phabricator.wikimedia.org/T203661) (owner: 10Anomie) [18:42:38] (03Merged) 10jenkins-bot: Add checks for length of generated audio files [extensions/Score] - 10https://gerrit.wikimedia.org/r/458503 (https://phabricator.wikimedia.org/T203560) (owner: 10Ebe123) [18:42:44] (03CR) 10jenkins-bot: look for the BackupDumper class in the (new) correct place [extensions/Flow] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458549 (https://phabricator.wikimedia.org/T203647) (owner: 10Krinkle) [18:43:10] (03CR) 10Niedzielski: [C: 04-1] "I don't see an icon for new treatment issues at the top of" (033 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457928 (https://phabricator.wikimedia.org/T202349) (owner: 10Jdrewniak) [18:43:18] (03PS1) 10Jforrester: Add checks for length of generated audio files [extensions/Score] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458558 (https://phabricator.wikimedia.org/T203560) [18:44:35] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Provide option to expand tables and infoxes in the Android app - https://phabricator.wikimedia.org/T131348 (10ABorbaWMF) Working for me on 2.7.239-alpha-2018-09-04 [18:44:38] (03CR) 10jenkins-bot: Follow up: show the RHS edge of overflow menus in the reading list items. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458082 (owner: 10Cooltey) [18:44:42] (03CR) 10Catrope: [C: 032] Fix tests locally by clearing the cache between them [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458543 (owner: 10Sbisson) [18:45:11] (03CR) 10jenkins-bot: Provide a RevisionRecord with the correct title after a move [core] - 10https://gerrit.wikimedia.org/r/458547 (https://phabricator.wikimedia.org/T203661) (owner: 10Anomie) [18:45:50] (03CR) 10Catrope: [C: 032] Ensure a valid AfC sort option is selected [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458544 (https://phabricator.wikimedia.org/T202917) (owner: 10Sbisson) [18:45:51] 04(no projects): Create production code deployment management process - https://phabricator.wikimedia.org/T203703 (10Jrbranaa) [18:46:18] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: [betalabs] AfC - Sort order options not in sync with State options - https://phabricator.wikimedia.org/T202917 (10Catrope) [18:46:26] 10MediaWiki-Special-pages: Make Special:Log/rights easier to understand - https://phabricator.wikimedia.org/T203174 (10Superyetkin) I can go ahead with this if there is an agreement on the proposed layout. [18:46:32] 04(no projects): Create production code deployment management process - https://phabricator.wikimedia.org/T203703 (10Jrbranaa) [18:46:48] (03Merged) 10jenkins-bot: Fix: Add Serializable to child objects to avoid crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456518 (owner: 10Cooltey) [18:46:56] (03PS1) 10Jforrester: Provide a RevisionRecord with the correct title after a move [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458559 (https://phabricator.wikimedia.org/T203661) [18:47:42] (03CR) 10Jforrester: "recheck" [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458552 (owner: 10Krinkle) [18:48:23] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [18:48:30] (03CR) 10Catrope: [C: 032] Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) (owner: 10Kosta Harlan) [18:48:50] (03CR) 10jenkins-bot: look for the BackupDumper class in the (new) correct place [extensions/Flow] - 10https://gerrit.wikimedia.org/r/458477 (https://phabricator.wikimedia.org/T203647) (owner: 10ArielGlenn) [18:48:55] 04(no projects): Create production code deployment management process - https://phabricator.wikimedia.org/T203703 (10Jrbranaa) [18:49:44] (03CR) 10jenkins-bot: Fix: Add Serializable to child objects to avoid crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456518 (owner: 10Cooltey) [18:50:54] 10Dumps-Generation, 10Patch-For-Review: Clean up flow dump job problems for Sept 1 2018 dumps run - https://phabricator.wikimedia.org/T203647 (10ArielGlenn) This is now deployed on the cluster so running dumps should rerun the failed flow jobs at the end and clean them up automatically. We should see some of t... [18:51:30] 10MediaWiki-extensions-General, 10Patch-For-Review, 10User-D3r1ck01: Review and update MediaWiki extensions to use most recent ESLint pattern - https://phabricator.wikimedia.org/T203648 (10Krinkle) @Jdforrester-WMF I don't think the file patterns belong in Gruntfile. It's non-standard from the tools perspect... [18:53:16] (03Merged) 10jenkins-bot: Fix tests locally by clearing the cache between them [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458543 (owner: 10Sbisson) [18:53:22] (03Merged) 10jenkins-bot: Ensure a valid AfC sort option is selected [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458544 (https://phabricator.wikimedia.org/T202917) (owner: 10Sbisson) [18:55:25] (03PS4) 10Krinkle: resourceloader: Remove support for `addSource(id, url)` [core] - 10https://gerrit.wikimedia.org/r/457720 [18:56:38] (03CR) 10jenkins-bot: Fix tests locally by clearing the cache between them [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458543 (owner: 10Sbisson) [18:57:03] (03CR) 10Krinkle: "I consider that very hacky abuse of mw.loader, certainly not a public API nor documented/encouraged anywhere. But, should be easy too supp" [core] - 10https://gerrit.wikimedia.org/r/457720 (owner: 10Krinkle) [18:57:13] (03CR) 10Dbrant: [C: 04-1] "I don't see the progress indicator at all... there seems to be a blank space where the progress indicator should be." [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) (owner: 10Sharvaniharan) [18:59:56] (03CR) 10jenkins-bot: Ensure a valid AfC sort option is selected [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458544 (https://phabricator.wikimedia.org/T202917) (owner: 10Sbisson) [19:00:45] (03CR) 10Catrope: [C: 032] Schema change for reading ct_tag_id instead of ct_tag [core] - 10https://gerrit.wikimedia.org/r/456027 (https://phabricator.wikimedia.org/T193874) (owner: 10Ladsgroup) [19:02:52] (03CR) 10Catrope: [C: 032] Update API tests to comply with the new backend for change tags [core] - 10https://gerrit.wikimedia.org/r/457978 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:04:08] (03PS1) 10Kosta Harlan: Define min width for potential issues cell to avoid line wrapping [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) [19:04:49] (03Merged) 10jenkins-bot: Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) (owner: 10Kosta Harlan) [19:06:48] (03CR) 10Catrope: [C: 032] API: Use ct_tag_id in queries when applicable (031 comment) [core] - 10https://gerrit.wikimedia.org/r/457974 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:07:03] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:07:09] (03PS5) 10Krinkle: resourceloader: Deprecate support for `addSource(id, url)` [core] - 10https://gerrit.wikimedia.org/r/457720 [19:07:22] (03CR) 10jenkins-bot: Watchlist preferences: Disallow zero value for days/limit [core] - 10https://gerrit.wikimedia.org/r/458517 (https://phabricator.wikimedia.org/T199049) (owner: 10Kosta Harlan) [19:11:09] (03PS6) 10Krinkle: resourceloader: Remove support for `addSource(id, url)` [core] - 10https://gerrit.wikimedia.org/r/457720 [19:11:36] 10Discovery-Search, 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, and 2 others: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10bmansurov) [19:12:00] 10MediaWiki-Installer, 10Math, 10Quibble, 10Continuous-Integration-Config, and 2 others: MathHooks: table creation yields warnings on quibble - https://phabricator.wikimedia.org/T202266 (10Physikerwelt) p:05High>03Normal [19:13:32] 10Research-Archive, 10Discovery-Search (Current work), 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, and 2 others: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10bmansurov) [19:13:36] 10MediaWiki-Special-pages, 10Toolforge: Special page listing recently expired blocks - https://phabricator.wikimedia.org/T201281 (10Superyetkin) I would be interested in building a tool for this in case there is some hesitation to do the job on Mediawiki. [19:14:20] 10Research-Archive, 10Discovery-Search (Current work), 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, and 2 others: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10bmansurov) @EBernhardson would you please review T191... [19:14:23] 10MediaWiki-extensions-OATHAuth, 10Patch-For-Review: Degrade/temporarily remove user rights/groups if 2FA isn't enabled - https://phabricator.wikimedia.org/T199118 (10MR70) p:05Triage>03High a:03MR70 [19:16:49] (03Merged) 10jenkins-bot: Schema change for reading ct_tag_id instead of ct_tag [core] - 10https://gerrit.wikimedia.org/r/456027 (https://phabricator.wikimedia.org/T193874) (owner: 10Ladsgroup) [19:18:57] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10Whatamidoing-WMF) [19:19:06] (03CR) 10Sbisson: Define min width for potential issues cell to avoid line wrapping (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) (owner: 10Kosta Harlan) [19:19:24] (03CR) 10jenkins-bot: Schema change for reading ct_tag_id instead of ct_tag [core] - 10https://gerrit.wikimedia.org/r/456027 (https://phabricator.wikimedia.org/T193874) (owner: 10Ladsgroup) [19:20:31] 10MediaWiki-Special-pages, 10Tools: Special page listing recently expired blocks - https://phabricator.wikimedia.org/T201281 (10JJMC89) [19:21:58] (03PS7) 10Krinkle: resourceloader: Remove support for `addSource(id, url)` [core] - 10https://gerrit.wikimedia.org/r/457720 [19:25:48] (03Merged) 10jenkins-bot: Update API tests to comply with the new backend for change tags [core] - 10https://gerrit.wikimedia.org/r/457978 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:25:54] (03Merged) 10jenkins-bot: API: Use ct_tag_id in queries when applicable [core] - 10https://gerrit.wikimedia.org/r/457974 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:26:14] 10MediaWiki-extensions-General, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10User-D3r1ck01: Review and update MediaWiki extensions to use most recent ESLint pattern - https://phabricator.wikimedia.org/T203648 (10Jdforrester-WMF) I don't think hacking around poor su... [19:26:55] 10MediaWiki-User-preferences, 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint): Value of 0 for "Days to show in watchlist" or "Maximum number of changes to show in watchlist" setting breaks watchlists; should instead be interpreted as maximum or no limit - https://phabricator.wikimedia.org/T199049 (10Jdf... [19:27:07] 10MediaWiki-Watchlist, 10Growth-Team (Current Sprint), 10Regression: Watchlist param days=30 doesn't override user preference 'watchlistdays' = 0 - https://phabricator.wikimedia.org/T176033 (10Jdforrester-WMF) [19:27:09] 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Tgr) This is about the initial rendering of the page, not the substed wikitext, so definitely a different bug. [19:28:03] (03CR) 10Jforrester: [C: 032] "…" [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [19:28:11] 10MediaWiki-Special-pages: Special:BrokenRedirects lists user pages that have a version on meta-wiki - https://phabricator.wikimedia.org/T203707 (10Superyetkin) [19:28:12] (03CR) 10jenkins-bot: API: Use ct_tag_id in queries when applicable [core] - 10https://gerrit.wikimedia.org/r/457974 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:29:45] (03PS2) 10Kosta Harlan: Prevent unwanted line wrapping in potential issues cell [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) [19:29:56] (03CR) 10jenkins-bot: Update API tests to comply with the new backend for change tags [core] - 10https://gerrit.wikimedia.org/r/457978 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [19:30:27] (03CR) 10Kosta Harlan: Prevent unwanted line wrapping in potential issues cell (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) (owner: 10Kosta Harlan) [19:32:35] 10InternetArchiveBot (v2.0): Do not add — as default, but — - https://phabricator.wikimedia.org/T202959 (10Cirdan) The check which is triggered is [[https://tools.wmflabs.org/checkwiki/cgi-bin/checkwiki.cgi?project=dewiki&view=only&id=50|this one]], virtually all results there are due to IABot edits. [19:32:56] 10MediaWiki-Special-pages: Special:BrokenRedirects lists user pages that have a version on meta-wiki - https://phabricator.wikimedia.org/T203707 (10MarcoAurelio) [19:33:00] 10MediaWiki-Special-pages, 10GlobalUserPage: Redirects to global user pages are broken, and added to Special:BrokenRedirects - https://phabricator.wikimedia.org/T90978 (10MarcoAurelio) [19:33:28] (03CR) 10Cicalese: [C: 032] Add italian translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458521 (https://phabricator.wikimedia.org/T203297) (owner: 10Daimona Eaytoy) [19:33:41] 10Wiki-Loves-Monuments-Database: clean up requirements-dev - https://phabricator.wikimedia.org/T203708 (10Lokal_Profil) [19:37:04] (03CR) 10Sbisson: [C: 032] Prevent unwanted line wrapping in potential issues cell [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) (owner: 10Kosta Harlan) [19:37:24] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:37:41] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:42:03] (03Merged) 10jenkins-bot: Linker: more consistent whitespace parsing in formatLinksInComment [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [19:42:05] (03Merged) 10jenkins-bot: Add italian translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458521 (https://phabricator.wikimedia.org/T203297) (owner: 10Daimona Eaytoy) [19:42:58] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:44:16] (03CR) 10jenkins-bot: Linker: more consistent whitespace parsing in formatLinksInComment [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [19:44:42] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:44:52] (03Merged) 10jenkins-bot: Prevent unwanted line wrapping in potential issues cell [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) (owner: 10Kosta Harlan) [19:45:26] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata-Campsite, 10Blocked-on-schema-change, 10User-Ladsgroup: Schema change for adding indexes of ct_tag_id - https://phabricator.wikimedia.org/T203709 (10Ladsgroup) [19:45:59] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata-Campsite, 10Blocked-on-schema-change, 10User-Ladsgroup: Schema change for adding indexes of ct_tag_id - https://phabricator.wikimedia.org/T203709 (10Marostegui) p:05Triage>03Normal [19:48:19] (03CR) 10jenkins-bot: Prevent unwanted line wrapping in potential issues cell [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458562 (https://phabricator.wikimedia.org/T203116) (owner: 10Kosta Harlan) [19:48:24] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata-Campsite, 10Blocked-on-schema-change, 10User-Ladsgroup: Schema change for adding indexes of ct_tag_id - https://phabricator.wikimedia.org/T203709 (10Ladsgroup) a:05Ladsgroup>03None [19:54:17] 10MediaWiki-Watchlist, 10Bot-Frameworks, 10Community-Wishlist-Survey-2016, 10Epic, and 2 others: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790 (10kostajh) > I have now adjusted my watch list preferences such that bot edits do not... [19:54:55] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [19:55:14] (03PS1) 10Sbisson: Show "by bots" at the right place in the filters summary [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458578 (https://phabricator.wikimedia.org/T203125) [19:55:33] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Dinoguy1000) >>! In T203215#4563079, @Nikerabbit wrote: > The simplest way is to slap #translatewiki.net tag on a relevant task and we'll take care... [19:56:52] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Patch-For-Review: New Pages Feed: filter logic inconsistent for "Were created by bots" - https://phabricator.wikimedia.org/T203125 (10SBisson) a:05Catrope>03SBisson Sorry, I know this cookie was licked but I came across this while wor... [19:57:50] (03CR) 10Ejegg: "recheck" [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448605 (owner: 10Ejegg) [20:01:23] 10MediaWiki-Watchlist, 10Bot-Frameworks, 10Community-Wishlist-Survey-2016, 10Epic, and 2 others: Watchlist doesn't show earlier normal edits when hiding bot edits or minor edits - https://phabricator.wikimedia.org/T11790 (10Doc_James) Will do so in a few days when I am home [20:02:23] (03CR) 10Legoktm: [C: 032] Fix IN list case for db conds when doing $conds['field'][] = $tainted [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458487 (https://phabricator.wikimedia.org/T201987) (owner: 10Brian Wolff) [20:03:11] (03CR) 10Legoktm: [C: 032] Fix a fatal during a misdetected HTMLForm specifier with empty class [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457087 (owner: 10Brian Wolff) [20:04:06] (03Merged) 10jenkins-bot: Fix IN list case for db conds when doing $conds['field'][] = $tainted [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458487 (https://phabricator.wikimedia.org/T201987) (owner: 10Brian Wolff) [20:04:53] (03Merged) 10jenkins-bot: Fix a fatal during a misdetected HTMLForm specifier with empty class [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/457087 (owner: 10Brian Wolff) [20:06:37] (03CR) 10Legoktm: [C: 032] Avoid false positive related to getQueryInfo() methods. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458499 (https://phabricator.wikimedia.org/T203657) (owner: 10Brian Wolff) [20:07:28] (03CR) 10Legoktm: [C: 032] Include syntax errors in the output of plugin. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 (owner: 10Brian Wolff) [20:07:34] (03CR) 10jerkins-bot: [V: 04-1] Include syntax errors in the output of plugin. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 (owner: 10Brian Wolff) [20:07:36] (03CR) 10jerkins-bot: [V: 04-1] Avoid false positive related to getQueryInfo() methods. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458499 (https://phabricator.wikimedia.org/T203657) (owner: 10Brian Wolff) [20:08:35] (03PS1) 10Jforrester: Follow-up 05b6c9788: Add possessive to CA account link [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458580 [20:08:37] (03PS1) 10Jforrester: [DNM] Make the preferences links into OOUI buttons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 [20:10:06] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Make the preferences links into OOUI buttons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [20:11:22] (03CR) 10jerkins-bot: [V: 04-1] [DNM] Make the preferences links into OOUI buttons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [20:11:51] (03CR) 10Jforrester: "This change is ready for review." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [20:12:21] (03CR) 10Nray: Measure code coverage inside MobileFrontend (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456325 (owner: 10Jdlrobson) [20:12:24] (03PS3) 10Sbisson: Rename wp10 to articlequality [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456392 (https://phabricator.wikimedia.org/T202998) [20:12:42] (03CR) 10Sbisson: [C: 04-2] Rename wp10 to articlequality (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456392 (https://phabricator.wikimedia.org/T202998) (owner: 10Sbisson) [20:13:00] (03PS1) 10EBernhardson: [DNM] test jenkins [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458582 [20:13:16] (03PS2) 10Jforrester: [DNM] Make the preferences links into OOUI buttons [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 [20:13:30] 10MediaWiki-General-or-Unknown, 10phan-taint-check-plugin: Formalize getQueryInfo() usage - https://phabricator.wikimedia.org/T203712 (10Legoktm) [20:14:39] (03CR) 10Jforrester: "Ha. One fewer use of wgLang." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [20:15:12] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Refresh the Explore feed after logged in - https://phabricator.wikimedia.org/T196004 (10ABorbaWMF) LGTM on 2.7.239-alpha-2018-09-04 [20:16:04] (03CR) 10jerkins-bot: [V: 04-1] [DNM] test jenkins [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458582 (owner: 10EBernhardson) [20:17:15] (03CR) 10Dbrant: [C: 04-1] Show in progress activity when an article in a reading list is being downloaded for offline (0312 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) (owner: 10Sharvaniharan) [20:17:40] 10MediaWiki-Parser, 10MediaWiki-extensions-Arrays, 10MediaWiki-extensions-Other, 10MediaWiki-extensions-Variables: Create a library for extensions using global parser state - https://phabricator.wikimedia.org/T203523 (10Legoktm) >>! In T203523#4558410, @MGChecker wrote: > However, this proposal isn't targe... [20:18:23] 10MediaWiki-extensions-PageCuration, 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team, 10Patch-For-Review: Deploy PageTriage AfC to production - https://phabricator.wikimedia.org/T203184 (10SBisson) a:03SBisson [20:20:26] 10fixcopyright.wikimedia.org, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Epic, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10Legoktm) [20:25:50] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Start using the `page/related` REST endpoint instead of `morelike` query. - https://phabricator.wikimedia.org/T199465 (10ABorbaWMF) @cooltey is there any specific to check here (like test steps). I've been looki... [20:25:56] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458576 (owner: 10L10n-bot) [20:27:10] (03PS2) 10Brian Wolff: Include syntax errors in the output of plugin. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 [20:27:12] (03PS2) 10Brian Wolff: Avoid false positive related to getQueryInfo() methods. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458499 (https://phabricator.wikimedia.org/T203657) [20:27:40] (03CR) 10Brian Wolff: [C: 032] "Rebased version of already +2'd thing" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 (owner: 10Brian Wolff) [20:28:53] (03PS2) 10EBernhardson: Remove spurious whitespace [search/MjoLniR] - 10https://gerrit.wikimedia.org/r/458582 [20:29:20] (03Merged) 10jenkins-bot: Include syntax errors in the output of plugin. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458498 (owner: 10Brian Wolff) [20:29:23] (03Merged) 10jenkins-bot: Avoid false positive related to getQueryInfo() methods. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/458499 (https://phabricator.wikimedia.org/T203657) (owner: 10Brian Wolff) [20:29:41] (03PS2) 10Jdlrobson: Measure code coverage inside MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456325 [20:29:56] (03CR) 10jerkins-bot: [V: 04-1] Measure code coverage inside MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456325 (owner: 10Jdlrobson) [20:30:30] (03CR) 10Jdlrobson: Measure code coverage inside MobileFrontend (036 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456325 (owner: 10Jdlrobson) [20:31:12] 10Collection, 10Wikimedia-Logstash, 10Wikimedia-production-error: Logstash Notice: Undefined variable: subtitle in Collection extension - https://phabricator.wikimedia.org/T203594 (10Krinkle) >>! In T203594#4563444, @Jdlrobson wrote: > Do notices have a stack trace? I can't seem to find one.. Yes, all notic... [20:31:51] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): The disabled indicator of toggle switch is not clear for themes other than Light theme - https://phabricator.wikimedia.org/T184546 (10Sharvaniharan) @RHo We can only set an alpha... [20:33:52] (03PS1) 10Cicalese: Add italian translation [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458586 (https://phabricator.wikimedia.org/T203297) [20:38:32] 10MediaWiki-Interface, 10MediaWiki-jQuery-Tablesorter, 10JavaScript: jquery.tablesorter: Add support for a "fixed" column of row numbers. - https://phabricator.wikimedia.org/T42618 (10The_Equalizer) p:05Low>03High Team Phabricator, will there be any traction on this? This is such a core function of any t... [20:41:23] 10HHVM: Stack traces in HHVM debugger on terbium not working - https://phabricator.wikimedia.org/T147527 (10Krinkle) 05Open>03Resolved a:03Krinkle ```name=eval mwmaint1001.eqiad.wmnet$ mwscript eval.php --wiki test2wiki > new MapCacheLRU( 'x' ); Caught exception Wikimedia\Assert\ParameterTypeException: Bad... [20:41:38] (03CR) 10Dbrant: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458576 (owner: 10L10n-bot) [20:42:28] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): [Spike] Investigate ChromeLikeTabSwitcher component - https://phabricator.wikimedia.org/T198473 (10cooltey) Found another example: https://github.com/nilsi/CardCarousel It uses ViewPager + CardViews + Fragments [20:43:15] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): [Spike] Investigate ChromeLikeTabSwitcher component - https://phabricator.wikimedia.org/T198473 (10Dbrant) ^^ pls check out my patch. [20:43:34] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a download on WiFi only setting for reading list users - https://phabricator.wikimedia.org/T193027 (10ABorbaWMF) Works for me on 2.7.239-alpha-2018-09-04 [20:43:37] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a last synced status indicator on reading lists - https://phabricator.wikimedia.org/T196577 (10Dbrant) The date format should work, since it will automatically pass through An... [20:44:20] 10MediaWiki-Configuration, 10MediaWiki-extensions-General: [Task] Remove support for old extension registration/loading endpoint - https://phabricator.wikimedia.org/T88567 (10Jdforrester-WMF) This task was originally about Wikibase. Was it intentionally changed? It now reads like it's meant to be "drop support... [20:45:05] (03CR) 10Reedy: [C: 04-1] Temporarily disable certain rights if 2FA isn't enabled for the user (033 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [20:50:57] (03PS1) 10Jdlrobson: Hygiene: Move constants and explicit dependencies to top of errorLogging [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458588 (https://phabricator.wikimedia.org/T202026) [20:50:59] (03PS1) 10Jdlrobson: Hygiene: Consistent error naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458589 (https://phabricator.wikimedia.org/T202026) [20:51:01] (03PS1) 10Jdlrobson: Hygiene: Load errorLogger earlier in stack [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458590 (https://phabricator.wikimedia.org/T202026) [20:51:03] (03PS1) 10Jdlrobson: Log a character limited stack trace in error reports [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458591 (https://phabricator.wikimedia.org/T202026) [20:51:51] (03CR) 10Jdlrobson: Client side error reporting for Minerva+MobileFrontend (0313 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455064 (https://phabricator.wikimedia.org/T202026) (owner: 10Jdlrobson) [20:53:08] 10MediaWiki-Export-or-Import, 10Core-Platform-Team: Replace the WikiExporter backup dump streaming mode with batched queries - https://phabricator.wikimedia.org/T203424 (10BPirkle) I notice that WikiExporter::STREAM is also used in SpecialExport.php, for the Special:Export page, which provides similar function... [20:55:40] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a last synced status indicator on reading lists - https://phabricator.wikimedia.org/T196577 (10RHo) Ahh that is not ideal. @cooltey @dbrant , can we use an existing timestamp... [20:55:52] 10Design, 10Design-Research, 10VisualEditor-MediaWiki, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), and 2 others: "Leave site?" message erroneously shown after user has saved an edit and is back in read mode - https://phabricator.wikimedia.org/T202587 (10Ryasmeen) [20:59:42] (03CR) 10Krinkle: [C: 032] exception: Do not log PHP errors with severity DEBUG or INFO [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458552 (owner: 10Krinkle) [20:59:59] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/458576 (owner: 10L10n-bot) [21:01:31] 10MediaWiki-API, 10MediaWiki-Parser: Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Jdlrobson) [21:01:35] (03PS3) 10Jdrewniak: Change Page.findChildInSectionLead to return nested elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) [21:01:51] 10MediaWiki-API, 10MediaWiki-Parser: Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Jdlrobson) [21:03:27] (03CR) 10Jdlrobson: "Possibly causing https://phabricator.wikimedia.org/T203716 ?" [core] - 10https://gerrit.wikimedia.org/r/455865 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [21:04:05] (03CR) 10Krinkle: Hygiene: Move constants and explicit dependencies to top of errorLogging (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458588 (https://phabricator.wikimedia.org/T202026) (owner: 10Jdlrobson) [21:04:14] 10MediaWiki-Change-tagging, 10Wikidata-Campsite, 10Wikidata-Campsite-Iteration-∞, 10User-Ladsgroup, 10Wikimedia-maintenance-script-run: Run maintenance script to populate change_tag_def on WMF production (all wikis) - https://phabricator.wikimedia.org/T193873 (10Ladsgroup) [21:04:46] 10MediaWiki-Change-tagging, 10Wikidata-Campsite, 10Wikidata-Campsite-Iteration-∞, 10User-Ladsgroup, 10Wikimedia-maintenance-script-run: Run maintenance script to populate change_tag_def on WMF production (all wikis) - https://phabricator.wikimedia.org/T193873 (10Ladsgroup) 05Open>03Resolved It's all... [21:04:49] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Wikidata-Campsite, 10Wikidata-Campsite-Iteration-∞, and 4 others: Normalize change tag schema - https://phabricator.wikimedia.org/T185355 (10Ladsgroup) [21:04:54] (03PS2) 10Jdlrobson: Hygiene: Consistent error naming [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458589 (https://phabricator.wikimedia.org/T202026) [21:05:00] (03PS2) 10Jdlrobson: Hygiene: Load errorLogger earlier in stack [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458590 (https://phabricator.wikimedia.org/T202026) [21:06:48] (03CR) 10Krinkle: [C: 032] Provide a RevisionRecord with the correct title after a move [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458559 (https://phabricator.wikimedia.org/T203661) (owner: 10Jforrester) [21:07:55] (03CR) 10Krinkle: [C: 031] Hygiene: Load errorLogger earlier in stack [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458590 (https://phabricator.wikimedia.org/T202026) (owner: 10Jdlrobson) [21:08:28] (03CR) 10Jdlrobson: Change Page.findChildInSectionLead to return nested elements (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [21:09:02] (03CR) 10Krinkle: [C: 04-1] "Needs figuring out." [core] - 10https://gerrit.wikimedia.org/r/451641 (https://phabricator.wikimedia.org/T201278) (owner: 10simetrical) [21:10:14] (03CR) 10Krinkle: Add PRIMARY KEY to user_newtalk (031 comment) [core] - 10https://gerrit.wikimedia.org/r/376068 (https://phabricator.wikimedia.org/T146585) (owner: 10Reedy) [21:11:14] 10MediaWiki-API, 10MediaWiki-Parser: Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Jdlrobson) [21:11:25] 10MediaWiki-API, 10MediaWiki-Parser: Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Jdlrobson) p:05Triage>03High [21:12:18] 10MediaWiki-Cache, 10Wikimedia-production-error: Notice: serialize(): "" returned as member variable from __sleep() but does not exist - https://phabricator.wikimedia.org/T203566 (10hashar) [21:12:20] 10MediaWiki-Cache, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Technical-Debt: BagOStuff should detect obsolete serialization or an unserialization resulting in a "wrong" object - https://phabricator.wikimedia.org/T156541 (10hashar) [21:12:46] 10MediaWiki-Cache, 10Wikimedia-production-error: Notice: serialize(): "" returned as member variable from __sleep() but does not exist - https://phabricator.wikimedia.org/T203566 (10hashar) That is a dupe of T156541 which has a nice description about serialize / unserialize when the class has changed. [21:13:31] 10MediaWiki-Cache, 10Continuous-Integration-Infrastructure, 10Patch-For-Review, 10Technical-Debt: BagOStuff should detect obsolete serialization or an unserialization resulting in a "wrong" object - https://phabricator.wikimedia.org/T156541 (10hashar) That has hit us when deploying 1.32.0-wmf.20 (T203566). [21:15:10] (03PS23) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) [21:15:38] (03CR) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user (032 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [21:17:37] (03Merged) 10jenkins-bot: exception: Do not log PHP errors with severity DEBUG or INFO [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458552 (owner: 10Krinkle) [21:19:29] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Product-Analytics: Add logging to gauge TemplateWizard usage - https://phabricator.wikimedia.org/T200970 (10nettrom_WMF) One thought I had is whether we are also interested in parameter usage, for instance whether only a small set of parameters is us... [21:22:01] (03Merged) 10jenkins-bot: Provide a RevisionRecord with the correct title after a move [core] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458559 (https://phabricator.wikimedia.org/T203661) (owner: 10Jforrester) [21:23:06] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10Tgr) >>! In T203567#4563613... [21:23:08] 10MediaWiki-Cache, 10Wikimedia-production-error: Notice: serialize(): "" returned as member variable from __sleep() but does not exist - https://phabricator.wikimedia.org/T203566 (10Krinkle) 05duplicate>03Open @hashar There is not going to be a way to automatically make breaking changes not break. I believ... [21:25:02] 10MediaWiki-Cache, 10Wikimedia-production-error: ParserOutput cache incompatibility ("PHP Notice: serialize() '' returned as member variable from __sleep() but does not exist) - https://phabricator.wikimedia.org/T203566 (10Krinkle) [21:27:48] 10MediaWiki-Cache, 10Wikimedia-production-error: ParserOutput cache incompatibility ("PHP Notice: serialize() '' returned as member variable from __sleep() but does not exist) - https://phabricator.wikimedia.org/T203566 (10Krinkle) p:05Triage>03Unbreak! Due to PHP Notices not being fatal, execution continu... [21:28:07] 10MediaWiki-Cache, 10MediaWiki-Parser, 10Multi-Content-Revisions, 10Wikimedia-production-error: ParserOutput cache incompatibility ("PHP Notice: serialize() '' returned as member variable from __sleep() but does not exist) - https://phabricator.wikimedia.org/T203566 (10Krinkle) [21:29:21] 10MediaWiki-API, 10MediaWiki-Parser: Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Tgr) Got cached slightly before the deploy (20180906110544). Pre {0dc7ba0} the wrapper div was added on render and removed on `getText()` if unwrap=false was specif... [21:29:38] 10MediaWiki-API, 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2): Duplicate mw-parser-output elements in action=parse API output - https://phabricator.wikimedia.org/T203716 (10Tgr) [21:31:33] 10MediaWiki-Page-editing, 10MediaWiki-Parser, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), and 3 others: {{subst:REVISIONUSER}} no longer substitutes into the current user name,... - https://phabricator.wikimedia.org/T203583 [21:32:43] 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10Verified-in-Phase2, 10VisualEditor (Current work): Edit interface loaded with double toolbar on mobile web - https://phabricator.wikimedia.org/T202513 (10Ryasmeen) Not seeing two toolbars anymore. Verified. [21:32:53] 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10Verified-in-Phase2, 10VisualEditor (Current work): Edit interface loaded with double toolbar on mobile web - https://phabricator.wikimedia.org/T202513 (10Ryasmeen) [21:33:35] 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check should avoid false positives with getQueryInfo() methods - https://phabricator.wikimedia.org/T203657 (10Bawolff) 05Open>03Resolved a:03Bawolff [21:34:13] (03CR) 10Reedy: [C: 04-1] Temporarily disable certain rights if 2FA isn't enabled for the user (032 comments) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [21:39:09] (03PS1) 10Brian Wolff: Update phan-taint-check to 1.5.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) [21:39:59] (03CR) 10Reedy: "CR-1 this is broken" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456027 (https://phabricator.wikimedia.org/T193874) (owner: 10Ladsgroup) [21:40:35] (03Abandoned) 10Brian Wolff: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/456880 (owner: 10Libraryupgrader) [21:41:36] (03PS1) 10Reedy: Fix table prefixing in patch-change_tag-change_tag_rc_tag_id.sql [core] - 10https://gerrit.wikimedia.org/r/458597 [21:41:38] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: QA: TemplateWizard - https://phabricator.wikimedia.org/T203052 (10Etonkovidova) >>! In T203052#4559464, @Niharika wrote: > @Etonkovidova For #2, which browser do you see this on? I see this: {F25664514} > It flips upwards if there isn't any space below b... [21:41:40] 10CirrusSearch, 10Discovery-Search (Current work): Add handler to super detect noop to update a field only if other updates are applied - https://phabricator.wikimedia.org/T203622 (10EBernhardson) Sample Indexed Document: ``` { field1: 10, version:3 indexTimestamp:3 }``` assumi... [21:42:26] (03PS2) 10Mooeypoo: Add tooltips to parameter buttons for accessibility [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458292 (https://phabricator.wikimedia.org/T203604) [21:42:37] (03CR) 10Reedy: "https://gerrit.wikimedia.org/r/458597" [core] - 10https://gerrit.wikimedia.org/r/456027 (https://phabricator.wikimedia.org/T193874) (owner: 10Ladsgroup) [21:42:44] (03CR) 10Mooeypoo: Add tooltips to parameter buttons for accessibility (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458292 (https://phabricator.wikimedia.org/T203604) (owner: 10Mooeypoo) [21:42:46] (03PS1) 10Jdlrobson: MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 [21:42:48] (03CR) 10Brian Wolff: "Huh. It worked locally..." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [21:43:16] (03CR) 10jerkins-bot: [V: 04-1] Update phan-taint-check to 1.5.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [21:46:57] 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run tests daily targeting beta cluster for all repositories with Selenium tests - https://phabricator.wikimedia.org/T188742 (10hashar) ht... [21:48:05] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Start using the `page/related` REST endpoint instead of `morelike` query. - https://phabricator.wikimedia.org/T199465 (10cooltey) [21:48:08] (03CR) 10jerkins-bot: [V: 04-1] MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 (owner: 10Jdlrobson) [21:48:41] (03PS4) 10Jdlrobson: Change Page.findChildInSectionLead to return nested elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [21:48:42] (03PS2) 10Jdlrobson: MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 [21:48:55] (03CR) 10Jdlrobson: [C: 032] Change Page.findChildInSectionLead to return nested elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [21:48:56] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Start using the `page/related` REST endpoint instead of `morelike` query. - https://phabricator.wikimedia.org/T199465 (10cooltey) @ABorbaWMF Yes, I've updated the test steps, please let me know if you have any q... [21:49:39] 10ConfirmEdit (CAPTCHA extension): Text input for the CAPTCHA when editing (adding a link) is tiny and ugly - https://phabricator.wikimedia.org/T203718 (10matmarex) [21:50:00] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: QA: TemplateWizard - https://phabricator.wikimedia.org/T203052 (10Niharika) Nice catch, @Etonkovidova. I can replicate it on beta labs with other templates without any parameters but I cannot replicate it on testwiki. So it seems like the problem is spec... [21:50:36] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Start using the `page/related` REST endpoint instead of `morelike` query. - https://phabricator.wikimedia.org/T199465 (10cooltey) [21:50:48] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Dzahn) Could we at least _triage_ this ticket to lowest or get some kind of response? [21:50:56] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Wikimedia-maintenance-script-run: Delete rows for 'pagetriage-lastuse' preference - https://phabricator.wikimedia.org/T202175 (10Catrope) 05Open>03Resolved [21:51:11] 10MediaWiki-extensions-DonationInterface, 10Fr-Ingenico-integration_2017-18, 10Fundraising-Backlog, 10Fundraising Sprint Raw data can give you salmonella, 10Patch-For-Review: Deal with Ingenico Connect code 300620: MerchantReference XXXX already exists - https://phabricator.wikimedia.org/T201773 (10Ejegg... [21:51:36] (03CR) 10Jdlrobson: "I may be wrong, but I don't think this is needed." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457688 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [21:52:54] (03PS3) 10Jdlrobson: Measure code coverage inside MobileFrontend [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456325 [21:53:22] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Dzahn) >>! In T200742#4463769, @Varnent wrote: > No - this is a soft launch - the other languages are coming soon. More info in email coming out shortly. It's... [21:53:52] (03PS2) 10Brian Wolff: Update phan-taint-check to 1.5.0 and suppress 2 errors [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) [21:53:54] (03CR) 10jerkins-bot: [V: 04-1] MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 (owner: 10Jdlrobson) [21:54:25] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: Warning: Invalid operand type was used: implode() expects a container as one of the arguments in /srv/mediawiki/php-1.32.0-wmf.20/includes/parser/ParserOutput.php on line 428 - https://phabricator.wikimedia.org/T203567 (10hashar) >>! In T203567#4563... [21:54:29] (03PS3) 10Brian Wolff: Update phan-taint-check to 1.5.0 and suppress 2 errors [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) [21:55:43] (03PS1) 10Bartosz Dziewoński: FancyCaptcha: Actually load styles for the CAPTCHA input [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458599 (https://phabricator.wikimedia.org/T203718) [21:56:29] 10ConfirmEdit (CAPTCHA extension), 10Patch-For-Review: Text input for the CAPTCHA when editing (adding a link) is tiny and ugly - https://phabricator.wikimedia.org/T203718 (10matmarex) Screenshots from my test wiki: | Before | After | | -- | -- | {F25681395} | {F25681391} I don't think this task is solved by... [21:57:06] (03CR) 10jerkins-bot: [V: 04-1] Update phan-taint-check to 1.5.0 and suppress 2 errors [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [21:57:16] (03CR) 10Ladsgroup: [C: 032] Fix table prefixing in patch-change_tag-change_tag_rc_tag_id.sql [core] - 10https://gerrit.wikimedia.org/r/458597 (owner: 10Reedy) [22:01:04] (03PS1) 10Brian Wolff: Add support for fractional weights [extensions/RandomSelection] - 10https://gerrit.wikimedia.org/r/458600 [22:02:06] 10MediaWiki-Interface, 10MediaWiki-jQuery-Tablesorter, 10JavaScript: jquery.tablesorter: Add support for a "fixed" column of row numbers. - https://phabricator.wikimedia.org/T42618 (10Aklapper) p:05High>03Low @The_Equalizer: Welcome to Phabricator! I'm resetting the priority as you don't seem to [[ https... [22:04:46] 10MediaWiki-Parser, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: REVISIONYEAR magic word returns empty result - https://phabricator.wikimedia.org/T203689 (10Aklapper) p:05Triage>03High [22:06:32] (03PS1) 10Jforrester: Hide LQT preferences on frozen wikis [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) [22:08:23] (03PS1) 10Catrope: SpecialORESModels: Remove workaround for Mustache parent scope bug [extensions/ORES] - 10https://gerrit.wikimedia.org/r/458602 [22:09:22] (03CR) 10Catrope: [C: 032] Hide LQT preferences on frozen wikis [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) (owner: 10Jforrester) [22:09:24] (03CR) 10Jforrester: [C: 032] FancyCaptcha: Actually load styles for the CAPTCHA input [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458599 (https://phabricator.wikimedia.org/T203718) (owner: 10Bartosz Dziewoński) [22:09:46] 10MediaWiki-extensions-LiquidThreads, 10Growth-Team, 10StructuredDiscussions, 10Easy, 10Patch-For-Review: Hide LQT preferences on frozen (wmgLiquidThreadsFrozen) wikis - https://phabricator.wikimedia.org/T112012 (10Catrope) 05Open>03Resolved a:03Catrope [22:09:55] 10MediaWiki-extensions-LiquidThreads, 10Growth-Team, 10StructuredDiscussions, 10Easy, 10Patch-For-Review: Hide LQT preferences on frozen (wmgLiquidThreadsFrozen) wikis - https://phabricator.wikimedia.org/T112012 (10Catrope) a:05Catrope>03Jdforrester-WMF [22:10:42] (03CR) 10jerkins-bot: [V: 04-1] Hide LQT preferences on frozen wikis [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) (owner: 10Jforrester) [22:13:38] (03CR) 10jenkins-bot: Change Page.findChildInSectionLead to return nested elements [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457897 (https://phabricator.wikimedia.org/T203386) (owner: 10Jdrewniak) [22:13:59] 10MediaWiki-extensions-ORES, 10ORES-Support-Checklist, 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Change mentions of wp10 to articlequality in products - https://phabricator.wikimedia.org/T203080 (10Catrope) I see, your ORES patch adds articlequality but does not remove wp10... [22:15:37] (03PS4) 10Jforrester: Update phan-taint-check to 1.5.0 and suppress 2 errors [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [22:15:46] (03CR) 10Catrope: [C: 032] Remove superfluous parameter from AbuseFilter call [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454292 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [22:16:01] (03CR) 10Jforrester: [C: 032] "PS4: Slapped in some phpdoc so it can be merged." [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [22:16:06] (03CR) 10Ladsgroup: [C: 032] SpecialORESModels: Remove workaround for Mustache parent scope bug [extensions/ORES] - 10https://gerrit.wikimedia.org/r/458602 (owner: 10Catrope) [22:17:06] (03PS2) 10Jforrester: Hide LQT preferences on frozen wikis [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) [22:17:23] (03CR) 10Jforrester: [C: 032] "…" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) (owner: 10Jforrester) [22:17:26] (03CR) 10Catrope: [C: 032] Use new syntax for AbuseFilter variables and deprecate the old ones [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454274 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [22:18:14] bawolff_: Fastest way to get your code merged is to be unbreaking the repo so I can merge mine. ;-) [22:19:10] James_F: yeah, sorry about the breakage. Still a few kinks to work out in the plugin i guess [22:19:27] It happens. [22:19:48] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Catrope) I have +2ed both 4A (which should be merged by Jenkins soon) and 8 (wh... [22:20:27] 10MediaWiki-extensions-LiquidThreads, 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check-plugin failing for LiquidThreads extension - https://phabricator.wikimedia.org/T203690 (10Bawolff) Leaving this bug open as there were additional failures I surpressed. They seemed reasonable, except they do... [22:21:34] 10VisualEditor (Current work): Dropdown menus are misaligned too far away from buttons on mediawiki.org and the beta cluster - https://phabricator.wikimedia.org/T203720 (10Deskana) [22:21:49] (03PS1) 10Bartosz Dziewoński: Pass $context to 'GetPreferences' hook [core] - 10https://gerrit.wikimedia.org/r/458605 [22:21:50] 10VisualEditor (Current work): Dropdown menus are misaligned too far away from buttons on mediawiki.org and the beta cluster - https://phabricator.wikimedia.org/T203720 (10Deskana) p:05Triage>03High Not impacting production yet... [22:22:09] (03CR) 10Bartosz Dziewoński: [C: 04-1] "I think we should make it work if the preferences form is loaded in non-OOUI mode. You can do that like in https://gerrit.wikimedia.org/r/" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [22:27:19] (03PS3) 10Jdlrobson: MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 [22:27:51] (03PS37) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [22:28:27] 10Page-Issue-Warnings, 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Multiple-issues templates in page sections don't render in modal - https://phabricator.wikimedia.org/T203386 (10Jdlrobson) a:05Jdrewniak>03Tbayer [22:28:47] (03CR) 10Jforrester: "> I think we should make it work if the preferences form is loaded in non-OOUI mode." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [22:28:52] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: TemplateWizard: Only fallback to focus on 'add all' button if it actually exists - https://phabricator.wikimedia.org/T203722 (10Mooeypoo) [22:29:09] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [22:29:10] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: QA: TemplateWizard - https://phabricator.wikimedia.org/T203052 (10Mooeypoo) Whoops, it looks like we may have overlooked the focus when there are no fields. I opened this {T203722} to follow up. [22:29:38] (03CR) 10Jdlrobson: [C: 032] FancyCaptcha: Actually load styles for the CAPTCHA input [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458599 (https://phabricator.wikimedia.org/T203718) (owner: 10Bartosz Dziewoński) [22:29:41] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [22:30:45] (03CR) 10Jdlrobson: [C: 04-1] Hygiene: Move constants and explicit dependencies to top of errorLogging (032 comments) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/458588 (https://phabricator.wikimedia.org/T202026) (owner: 10Jdlrobson) [22:30:51] (03Merged) 10jenkins-bot: Fix table prefixing in patch-change_tag-change_tag_rc_tag_id.sql [core] - 10https://gerrit.wikimedia.org/r/458597 (owner: 10Reedy) [22:30:53] (03Merged) 10jenkins-bot: FancyCaptcha: Actually load styles for the CAPTCHA input [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458599 (https://phabricator.wikimedia.org/T203718) (owner: 10Bartosz Dziewoński) [22:30:55] (03Merged) 10jenkins-bot: Update phan-taint-check to 1.5.0 and suppress 2 errors [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458596 (https://phabricator.wikimedia.org/T203690) (owner: 10Brian Wolff) [22:31:22] 10MediaWiki-extensions-LiquidThreads, 10phan-taint-check-plugin: phan-taint-check-plugin failing for LiquidThreads extension - https://phabricator.wikimedia.org/T203690 (10Jdforrester-WMF) [22:31:47] (03CR) 10jerkins-bot: [V: 04-1] MobileLinterFixerTransform [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/458598 (owner: 10Jdlrobson) [22:32:27] 10MediaWiki-User-preferences: Hook GetPreferences adds empty td - https://phabricator.wikimedia.org/T33231 (10matmarex) 05Open>03Resolved This is no longer a problem these days. I tested by adding this to my LocalSettings: ```lang=php $wgHooks['GetPreferences'][] = function ( $user, &$preferences ) {... [22:32:33] (03PS1) 10Mooeypoo: Only focus on 'add/remove all' if it actually exists [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/458606 (https://phabricator.wikimedia.org/T203722) [22:33:21] 10MediaWiki-User-preferences: Hook GetPreferences adds empty td - https://phabricator.wikimedia.org/T33231 (10matmarex) [22:33:32] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: TemplateWizard: Only fallback to focus on 'add all' button if it actually exists - https://phabricator.wikimedia.org/T203722 (10Mooeypoo) a:03Mooeypoo [22:35:16] (03CR) 10jenkins-bot: FancyCaptcha: Actually load styles for the CAPTCHA input [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/458599 (https://phabricator.wikimedia.org/T203718) (owner: 10Bartosz Dziewoński) [22:35:20] (03CR) 10jenkins-bot: Fix table prefixing in patch-change_tag-change_tag_rc_tag_id.sql [core] - 10https://gerrit.wikimedia.org/r/458597 (owner: 10Reedy) [22:37:14] (03PS3) 10Jforrester: Make the preferences links into OOUI buttons when available [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 [22:38:03] (03CR) 10Catrope: [C: 032] Show "by bots" at the right place in the filters summary [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458578 (https://phabricator.wikimedia.org/T203125) (owner: 10Sbisson) [22:38:10] (03Merged) 10jenkins-bot: SpecialORESModels: Remove workaround for Mustache parent scope bug [extensions/ORES] - 10https://gerrit.wikimedia.org/r/458602 (owner: 10Catrope) [22:38:12] (03Merged) 10jenkins-bot: Hide LQT preferences on frozen wikis [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/458601 (https://phabricator.wikimedia.org/T112012) (owner: 10Jforrester) [22:38:20] (03CR) 10jerkins-bot: [V: 04-1] Make the preferences links into OOUI buttons when available [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [22:38:31] (03CR) 10jerkins-bot: [V: 04-1] Make the preferences links into OOUI buttons when available [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [22:39:40] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)): CX2: Undoing "Add translation" breaks saving - https://phabricator.wikimedia.org/T202442 (10Etonkovidova) 05Open>03Resolved [22:40:24] (03CR) 10jenkins-bot: SpecialORESModels: Remove workaround for Mustache parent scope bug [extensions/ORES] - 10https://gerrit.wikimedia.org/r/458602 (owner: 10Catrope) [22:41:17] (03PS4) 10Jforrester: Make the preferences links into OOUI buttons when available [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 [22:42:13] 10VisualEditor (Current work): Dropdown menus are misaligned too far away from buttons on mediawiki.org and the beta cluster - https://phabricator.wikimedia.org/T203720 (10matmarex) I can't reproduce. [22:42:31] (03CR) 10Ejegg: [C: 032] Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448605 (owner: 10Ejegg) [22:42:52] (03CR) 10Ejegg: [C: 032] "recheck" [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448607 (owner: 10Ejegg) [22:43:26] 10ConfirmEdit (CAPTCHA extension), 10VisualEditor (Current work): Text input for the CAPTCHA when editing (adding a link) is tiny and ugly - https://phabricator.wikimedia.org/T203718 (10Jdforrester-WMF) Now not-tiny, but still a bit ugly? @Deskana sign-off? [22:44:33] (03Merged) 10jenkins-bot: Use new syntax for AbuseFilter variables and deprecate the old ones [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454274 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [22:45:39] (03Merged) 10jenkins-bot: Show "by bots" at the right place in the filters summary [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458578 (https://phabricator.wikimedia.org/T203125) (owner: 10Sbisson) [22:45:44] (03Merged) 10jenkins-bot: Add form_variants from fr/REL1_27 branch [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448605 (owner: 10Ejegg) [22:45:48] (03Merged) 10jenkins-bot: Fix .gitmodules branch for vendor [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448607 (owner: 10Ejegg) [22:45:53] (03Merged) 10jenkins-bot: Update fundraising extensions [core] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/448784 (owner: 10Ejegg) [22:49:09] 10ContentTranslation, 10Language-2018-July-September, 10Tracking: CX2: Support for References - https://phabricator.wikimedia.org/T200786 (10Etonkovidova) [22:49:12] 10ContentTranslation, 10Language-2018-July-September: CX2: Improve support for different types of references - https://phabricator.wikimedia.org/T199512 (10Etonkovidova) 05Open>03Resolved Checked different types of references - they all display their different types (Book, News, Website etc)accordingly; w... [22:50:57] (03CR) 10jenkins-bot: Use new syntax for AbuseFilter variables and deprecate the old ones [extensions/Flow] - 10https://gerrit.wikimedia.org/r/454274 (https://phabricator.wikimedia.org/T173889) (owner: 10Daimona Eaytoy) [22:53:06] (03CR) 10Cicalese: [C: 032] Improve German translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458537 (owner: 10VolkerE) [22:54:11] (03CR) 10jenkins-bot: Show "by bots" at the right place in the filters summary [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/458578 (https://phabricator.wikimedia.org/T203125) (owner: 10Sbisson) [22:57:31] (03Merged) 10jenkins-bot: Improve German translation [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458537 (owner: 10VolkerE) [22:57:57] (03PS1) 10Cicalese: Improve German translation [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458609 [23:00:58] 10AbuseFilter, 10TestMe, 10Turkish-Sites, 10Wikimedia-production-error: UserGroupMembership::insert() needs a positive user ID exception breaking AbuseFilter block function - https://phabricator.wikimedia.org/T163032 (10Krinkle) 05Open>03Resolved a:03Anomie Only 4 instances of `UnexpectedValueExcepti... [23:01:00] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Turkish-Sites: Enable the blocking feature of AbuseFilter on trwiki - https://phabricator.wikimedia.org/T161960 (10Krinkle) [23:02:16] (03PS2) 10VolkerE: Add corresponding label elements for screenreaders to all inputs [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458461 [23:03:01] (03PS1) 10EBernhardson: Add missing tab character [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458611 [23:04:33] (03CR) 10Krinkle: [C: 032] Add missing tab character [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458611 (owner: 10EBernhardson) [23:05:33] (03PS3) 10VolkerE: Add corresponding label elements for screenreaders to all inputs [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458461 [23:06:19] (03PS2) 10Krinkle: Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:06:29] (03CR) 10Krinkle: [C: 032] Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:07:34] 10MediaWiki-extensions-LiquidThreads, 10Wikimedia-production-error: LQT: Fatal error: Call to a member function getPrefixedText() on a non-object in ApiThreadAction.php on line 68 - https://phabricator.wikimedia.org/T57739 (10Krinkle) 05Open>03declined Not seen in Logstash for 30 days [23:08:08] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458586 (https://phabricator.wikimedia.org/T203297) (owner: 10Cicalese) [23:08:24] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458609 (owner: 10Cicalese) [23:08:52] (03PS24) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) [23:10:19] 10MediaWiki-User-preferences, 10UI-Standardization: Improve Special:Preferences UI/UX - https://phabricator.wikimedia.org/T180538 (10matmarex) I think these of the remaining tasks should be blockers to switching the default mode to OOUI: * {T195986} * {T181844} * {T186842} [23:11:08] (03CR) 10Bartosz Dziewoński: "> > I think we should make it work if the preferences form is loaded in non-OOUI mode." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [23:11:10] (03CR) 10jerkins-bot: [V: 04-1] Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [23:11:33] (03PS25) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) [23:13:08] (03Merged) 10jenkins-bot: Add italian translation [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458586 (https://phabricator.wikimedia.org/T203297) (owner: 10Cicalese) [23:13:38] (03PS1) 10VolkerE: German translation: Replace 'Vertreter' by 'EU-Abgeordnete' [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458616 [23:13:40] (03CR) 10jerkins-bot: [V: 04-1] Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [23:14:18] (03Merged) 10jenkins-bot: Improve German translation [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458609 (owner: 10Cicalese) [23:15:42] (03CR) 10VolkerE: "Just saw that again, will make a follow-up now…" [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:16:17] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458611 (owner: 10EBernhardson) [23:17:59] 10MediaWiki-Change-tagging: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def', - https://phabricator.wikimedia.org/T203724 (10mwjames) [23:18:22] (03CR) 10Cicalese: [C: 032] German translation: Replace 'Vertreter' by 'EU-Abgeordnete' [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458616 (owner: 10VolkerE) [23:18:34] 10MediaWiki-Change-tagging: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def', - https://phabricator.wikimedia.org/T203724 (10mwjames) @Ladsgroup I believe this is caused by one of your changes. [23:19:01] 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10Tracking: GuidedTour refactor and API improvements (tracking) - https://phabricator.wikimedia.org/T92095 (10JTannerWMF) [23:19:07] 10MediaWiki-Change-tagging: NameTableAccessException: Expected unused ID from database insert for 'mw-changed-redirect-target' into 'change_tag_def', - https://phabricator.wikimedia.org/T203724 (10mwjames) [23:19:47] (03Merged) 10jenkins-bot: Add missing tab character [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458611 (owner: 10EBernhardson) [23:19:53] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/Score] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458558 (https://phabricator.wikimedia.org/T203560) (owner: 10Jforrester) [23:20:10] 10Tracking: GuidedTour refactor and API improvements (tracking) - https://phabricator.wikimedia.org/T92095 (10JTannerWMF) [23:20:57] (03CR) 10Cooltey: "Everything looks good! Have a minor question below:" (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456689 (owner: 10Dbrant) [23:21:25] (03PS1) 10Thcipriani: German translation: Replace 'Vertreter' by 'EU-Abgeordnete' [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458617 [23:22:01] (03CR) 10Bartosz Dziewoński: [C: 04-1] Make the preferences links into OOUI buttons when available (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/458581 (owner: 10Jforrester) [23:22:27] (03CR) 10Mooeypoo: OOUI'fy Special:GlobalPreferences (031 comment) [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/450262 (https://phabricator.wikimedia.org/T186842) (owner: 10Mooeypoo) [23:22:42] (03CR) 10Krinkle: "recheck" [extensions/SyntaxHighlight_GeSHi] (REL1_30) - 10https://gerrit.wikimedia.org/r/440874 (https://phabricator.wikimedia.org/T197601) (owner: 10Reedy) [23:23:40] 10wikimediafoundation.org: Misleading link about annual reports - https://phabricator.wikimedia.org/T201050 (10Varnent) 05Open>03Resolved This has been updated and [[ https://wikimediafoundation.org/about/annual-reports/ | links to a page ]] which lists all past reports. Thank you for reporting! [23:24:18] (03Merged) 10jenkins-bot: Improve keyboard focus outline appearance [skins/Vector] - 10https://gerrit.wikimedia.org/r/434897 (owner: 10VolkerE) [23:24:23] (03Merged) 10jenkins-bot: German translation: Replace 'Vertreter' by 'EU-Abgeordnete' [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458616 (owner: 10VolkerE) [23:24:48] (03CR) 10Thcipriani: [C: 032] "SWAT" [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458617 (owner: 10Thcipriani) [23:26:18] (03Merged) 10jenkins-bot: Add checks for length of generated audio files [extensions/Score] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458558 (https://phabricator.wikimedia.org/T203560) (owner: 10Jforrester) [23:28:28] 10MediaWiki-General-or-Unknown, 10Wikimedia-production-error: WebRequest->checkUrlExtension() should not cause logged exception on action=raw - https://phabricator.wikimedia.org/T89377 (10Krinkle) 05Open>03Resolved The error is still show at the example url (which is fine, since we don't want to support th... [23:29:33] (03CR) 10jenkins-bot: Add missing tab character [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/458611 (owner: 10EBernhardson) [23:30:58] (03Merged) 10jenkins-bot: German translation: Replace 'Vertreter' by 'EU-Abgeordnete' [extensions/EUCopyrightCampaign] (wmf/1.32.0-wmf.20) - 10https://gerrit.wikimedia.org/r/458617 (owner: 10Thcipriani) [23:32:42] (03PS2) 10VolkerE: Fix EU national flags size [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 [23:32:56] (03PS3) 10VolkerE: Fix EU national flags size [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 [23:33:09] (03CR) 10Krinkle: Fix EU national flags size (031 comment) [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 (owner: 10VolkerE) [23:35:05] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Remove articles from reading lists does not remove the articles' offline data - https://phabricator.wikimedia.org/T201879 (10cooltey) a:03cooltey [23:36:58] (03PS26) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) [23:38:46] 10MediaWiki-User-preferences, 10UI-Standardization: Adjust UI elements for number entry on Preferences tabs for Recent Changes and Watchlist - https://phabricator.wikimedia.org/T181844 (10Volker_E) [23:39:21] 10MediaWiki-User-preferences, 10UI-Standardization: Adjust UI elements for number entry on Preferences tabs for Recent Changes and Watchlist - https://phabricator.wikimedia.org/T181844 (10Volker_E) Updated task description after conversation with @jmatazzoni to 7 digits max. [23:41:14] (03CR) 10VolkerE: "Before (blurry and in some weirdly scaled as in losing aspect ratio): https://phabricator.wikimedia.org/F25681839" [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 (owner: 10VolkerE) [23:41:46] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Icon correct but issuesSeverity in instrumentation is wrong - https://phabricator.wikimedia.org/T203725 (10Jdlrobson) [23:42:49] (03CR) 10VolkerE: "@Krinkle I took (one of) the largest as calculation base. The `background-size: contain` of our SVG OOUI icons was the real issue here." [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/458355 (owner: 10VolkerE) [23:46:01] (03PS27) 10MR70: Temporarily disable certain rights if 2FA isn't enabled for the user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) [23:47:58] 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Icon correct but issuesSeverity in instrumentation is wrong - https://phabricator.wikimedia.org/T203725 (10Tbayer) [23:52:34] 10MediaWiki-extensions-Translate, 10Wikimedia-production-error: TranslateRenderJob.php: Cannot render translation page - https://phabricator.wikimedia.org/T200417 (10Krinkle) @Nikerabbit The outcome I would hope for is for there not to be exceptions triggered from user actions or job queue that result in an ex... [23:56:58] 10Page-Previews, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Page previews should use mw.user.getPageviewToken() - https://phabricator.wikimedia.org/T203013 (10Jdlrobson) [23:57:00] 10Page-Previews, 10MW-1.32-release-notes (WMF-deploy-2018-09-18 (1.32.0-wmf.22)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Page previews should use mw.user.getPageviewToken() - https://phabricator.wikimedia.org/T203013 (10Jdlrobson) 05Open>03Resolved a:03Jdlr... [23:57:09] 10MediaWiki-ResourceLoader, 10Performance-Team, 10JavaScript, 10MW-1.27-release-notes: mw.loader.store should not occupy all of localStorage - https://phabricator.wikimedia.org/T66721 (10Krinkle) [23:58:10] 10WMF-Legal, 10Privacy: Privacy policy FAQ links to https://bits.wikimedia.org/geoiplookup which is long dead - https://phabricator.wikimedia.org/T203726 (10Bawolff)