[00:01:26] 10Trust-and-Safety: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10jrbs) @VWBot Can you make some kind of edit to your user talk page assuming you're still logged in? [00:02:19] (03PS1) 10Krinkle: Hygiene: Use early returns in a few places for special cases [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456775 [00:03:45] (03CR) 10Krinkle: "Apologies for the lengthy commit message, this isn't a big deal or anything dramatic like that. Got carried away and decided I'll bookmark" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456775 (owner: 10Krinkle) [00:04:23] 10Trust-and-Safety: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10jrbs) p:05Triage>03High [00:05:00] 10Trust-and-Safety, 10Wikimedia-Site-requests: Disable 2FA for user Yarl - https://phabricator.wikimedia.org/T201964 (10jrbs) Hi @Yarl, sorry for the delay - could you make an edit to your user talk page referencing this task? [00:05:32] 10Trust-and-Safety, 10Wikimedia-Site-requests: Disable 2FA for user Yarl - https://phabricator.wikimedia.org/T201964 (10jrbs) >>! In T201964#4549976, @jrbs wrote: > Hi @Yarl, sorry for the delay - could you make an edit to your user talk page referencing this task? And could you please email ca@wikimedia.org... [00:05:53] (03Merged) 10jenkins-bot: Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [00:12:41] (03PS6) 10Cicalese: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [00:14:38] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [00:14:43] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [00:15:48] (03PS3) 10Krinkle: mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [00:15:58] (03Abandoned) 10Krinkle: mediawiki.user: Update Crypto-fallback test to actually test the fallback [core] - 10https://gerrit.wikimedia.org/r/456678 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:16:06] (03CR) 10Krinkle: [C: 032] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [00:22:10] (03PS7) 10Cicalese: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [00:22:38] (03CR) 10Krinkle: resourceloader: Remove module stringification from execute path (033 comments) [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [00:22:44] (03PS3) 10Krinkle: resourceloader: Remove module stringification from execute path [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) [00:22:49] (03PS4) 10Krinkle: resourceloader: Remove module stringification from execute path [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) [00:24:22] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Patch-For-Review, 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) a:05Nuria>03Krinkle (continuing assignment, I'll review and deploy this.) [00:27:19] (03CR) 10Krinkle: [C: 031] "recheck" [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [00:27:44] 10Research: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10diego) Beyond my subjective opinion about these rankings, I'm not sure what I should evaluate here. I understand that in the paper there is already an evaluation methodology. Are you trying to me... [00:28:26] 10MediaWiki-Page-editing, 10Verified, 10VisualEditor (Current work): VisualEditor not switching to edit conflict interface - https://phabricator.wikimedia.org/T201210 (10Ryasmeen) [00:28:59] (03PS1) 10Krinkle: mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) [00:29:05] (03CR) 10Krinkle: [C: 032] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:29:12] (03CR) 10Krinkle: [C: 032] resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 (owner: 10Krinkle) [00:29:40] (03CR) 10Krinkle: "recheck" [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [00:29:55] (03CR) 10Cicalese: "check experimental" [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [00:33:32] (03PS1) 10Cooltey: [WIP] Add a last synced status indicator on reading lists [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456777 (https://phabricator.wikimedia.org/T196577) [00:36:32] (03PS2) 10Krinkle: resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 [00:37:14] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:37:19] (03CR) 10Krinkle: [C: 032] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:37:25] (03CR) 10Krinkle: [C: 032] resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 (owner: 10Krinkle) [00:38:52] (03Merged) 10jenkins-bot: mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [00:40:57] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:40:59] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 (owner: 10Krinkle) [00:41:16] (03CR) 10Krinkle: [C: 032] mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [00:41:22] (03CR) 10Krinkle: [C: 032] resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 (owner: 10Krinkle) [00:41:32] (03CR) 10Krinkle: [C: 032] resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [00:41:50] (03CR) 10jenkins-bot: mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [00:44:20] (03CR) 10Krinkle: [C: 04-1] Avoid constructing Title objects in data providers [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [00:46:31] (03CR) 10jerkins-bot: [V: 04-1] TemplateParser: Pass FLAG_MUSTACHELOOKUP to enable parent context access [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [01:01:37] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [01:05:13] (03CR) 10Samwilson: Extend browser tests to include full workflow (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/454479 (https://phabricator.wikimedia.org/T199580) (owner: 10Samwilson) [01:07:30] (03CR) 10Krinkle: [C: 032] resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [01:18:54] 10Trust-and-Safety: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10VWBot) Yeah, it'll have to wait until Tuesday when I'm back at work, though. [01:23:17] 10MediaWiki-JobQueue, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Wikimedia-log-errors: Could not acquire lock 'LinksUpdate:job:pageid:xxx' - https://phabricator.wikimedia.org/T170596 (10Krinkle) 05Open>03Resolved Logstash results for `me... [01:23:27] 10MediaWiki-JobQueue, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Wikimedia-log-errors: Could not acquire lock 'LinksUpdate:job:pageid:xxx' - https://phabricator.wikimedia.org/T170596 (10Krinkle) [01:25:06] 10Core-Platform-Team, 10Multi-Content-Revisions, 10Wikimedia-log-errors: Warning: MediaWiki\Storage\SqlBlobStore::fetchBlob: Bad data in text row 5191150 - https://phabricator.wikimedia.org/T203075 (10Krinkle) Might be related to T203255. Tagging with CPT for further investigation. [01:29:06] 10Wikipedia-Android-App-Backlog: {{Row indexer}} completely fails on the Android app - https://phabricator.wikimedia.org/T203293 (10Ravenpuff) [01:36:52] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team, 10Wikimedia-log-errors: gzinflate() data error from SqlBlobStore - https://phabricator.wikimedia.org/T175313 (10Krinkle) [01:38:23] 10MediaWiki-Special-pages: Special page listing recently expired blocks - https://phabricator.wikimedia.org/T201281 (10Binksternet) Thinking some more about this, it makes sense to list previously blocked IPs, ranges and users only if they have resumed editing. If they have not resumed editing, they are not any... [01:41:32] (03Merged) 10jenkins-bot: mediawiki.user: Fix missing array initialization in generateRandomSessionId [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456776 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [01:41:38] (03Merged) 10jenkins-bot: resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774 (owner: 10Krinkle) [01:43:01] (03PS17) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [02:04:37] (03Merged) 10jenkins-bot: resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 (owner: 10Krinkle) [02:09:48] (03CR) 10Jack Phoenix: [C: 032] "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [02:11:25] (03CR) 10Legoktm: [C: 04-1] Initial import from nikext from translatewiki repo (031 comment) [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 (owner: 10Nikerabbit) [02:12:58] (03CR) 10Smalyshev: [C: 031] Improve Analysis Config Test Coverage and Update Russian Configs [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456443 (owner: 10Tjones) [02:13:15] 10MediaWiki-Interface: Text "reviewWrapped" on diffs - https://phabricator.wikimedia.org/T203294 (10MaxBioHazard) [02:17:06] (03Merged) 10jenkins-bot: Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [02:18:15] 10MediaWiki-Interface: Text "reviewWrapped" on diffs - https://phabricator.wikimedia.org/T203294 (10MaxBioHazard) Broken this https://github.com/wikimedia/mediawiki-extensions-FlaggedRevs/commit/ec676efb12a282546073c83f159ff2f77da5ef6a#diff-22555fc81409d98c10de28ff0d434009 [02:23:03] 10Trust-and-Safety: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10jrbs) >>! In T203270#4550033, @VWBot wrote: > Yeah, it'll have to wait until Tuesday when I'm back at work, though. It'd also be helpful for you to email into ca@wikimedia.org from the email attached to your ac... [02:31:46] 10Core-Platform-Team: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) [02:36:06] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10CCicalese_WMF) [02:36:08] 10Core-Platform-Team: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) [02:36:34] (03PS18) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [02:37:07] (03PS8) 10Cicalese: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [02:40:17] 10Core-Platform-Team: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10CCicalese_WMF) [02:41:07] 10Core-Platform-Team, 10Patch-For-Review: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) [02:41:10] 10Core-Platform-Team: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10CCicalese_WMF) [02:42:39] 10Core-Platform-Team: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10CCicalese_WMF) [02:47:54] (03PS2) 10Aaron Schulz: Drop the transcache table from the schema [core] - 10https://gerrit.wikimedia.org/r/455875 (https://phabricator.wikimedia.org/T189702) [02:50:15] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10Legoktm) p:05Normal>03High [02:51:46] (03PS3) 10Aaron Schulz: Drop the transcache table from the schema [core] - 10https://gerrit.wikimedia.org/r/455875 (https://phabricator.wikimedia.org/T189702) [02:54:56] 10Core-Platform-Team: Manage translations for fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203297 (10CCicalese_WMF) [02:58:10] 10Core-Platform-Team, 10Patch-For-Review: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) a:03Osnard [02:58:35] 10Core-Platform-Team, 10Epic: Deploy fixcopyright.wikimedia.org - https://phabricator.wikimedia.org/T203296 (10CCicalese_WMF) [02:59:11] 10Core-Platform-Team, 10Patch-For-Review: Develop extension/skin for fixcopyright.wikimedia.org campaign - https://phabricator.wikimedia.org/T203295 (10CCicalese_WMF) p:05Triage>03High [03:04:34] 04(no projects): Broken pipe for session storage to redis when 'persistent' => true, - https://phabricator.wikimedia.org/T203298 (10Zoglun) [03:08:48] 10MediaWiki-extension-requests, 10Security-Team, 10Patch-For-Review: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Krinkle) In response to T203236 and https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Blackout/+/444363/12 (Patch S... [03:09:36] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Design an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [03:09:44] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Design an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [03:09:51] 10MediaWiki-extensions-Other, 10Performance-Team: Performance review for Extension:Blackout - https://phabricator.wikimedia.org/T203236 (10Krinkle) [03:09:54] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Design an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [03:11:54] 10Design, 10Community-Tech, 10Grant-Metrics: Behavior on category save/pre-population - https://phabricator.wikimedia.org/T202762 (10MusikAnimal) Pull request to store titles instead of IDs: https://github.com/wikimedia/grantmetrics/pull/109 [03:13:10] 10MediaWiki-extensions-Other, 10Performance-Team: Performance review for Extension:Blackout - https://phabricator.wikimedia.org/T203236 (10Krinkle) I have added the #Performance-Team tag to task T198890 because this extension requires a completely different architecture to be compliant with operational require... [03:13:28] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Krinkle) [03:13:31] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Design an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [03:13:42] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Develop an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Krinkle) [03:16:04] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Krinkle) >>! In T203228#4548587, @Bawolff wrote: >>>! In T203228#4548494, @MarcoAurelio wrote: >> Just to mention that Blackout wa... [03:16:51] (03CR) 10Legoktm: [C: 032] "Still needs some work, see inline comments, but let's get some code in the repo for now." (035 comments) [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [03:23:05] (03Merged) 10jenkins-bot: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [03:46:44] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Investigate unexpected flushWrites (mw.loader.store) before arrival of first module response - https://phabricator.wikimedia.org/T202598 (10Krinkle) 05Resolved>03Open Still not quite right. I... [03:57:18] (03PS1) 10Krinkle: resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) [03:57:42] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Develop an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Bawolff) I think we should think carefully around the social & technical requirements of blackouts first, and th... [04:00:52] (03CR) 10Krinkle: "On https://en.wikipedia.org/wiki/Special:BlankPage I measure 89ms being spent in clearTimeout and 88ms in setTimeout. That's 177ms spent j" [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [04:05:04] 04(no projects): Broken pipe when redis set to 'persistent' => true, - https://phabricator.wikimedia.org/T203298 (10Zoglun) [04:15:10] 10Library-Card-Platform, 10The-Wikipedia-Library: Update Newspapers.com contact information for the wikipedia library - https://phabricator.wikimedia.org/T203300 (10Cameron11598) [04:16:33] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [04:26:05] 10MediaWiki-General-or-Unknown: Broken pipe when redis set to 'persistent' => true, - https://phabricator.wikimedia.org/T203298 (10Liuxinyu970226) [04:28:10] 10MediaWiki-extensions-OpenStackManager, 10Cloud-Services: Reconsider WMCS user creation workflow w/out OSM - https://phabricator.wikimedia.org/T165343 (10Liuxinyu970226) [04:28:35] 10MediaWiki-extensions-OpenStackManager, 10Striker: Reconsider WMCS user creation workflow w/out OSM - https://phabricator.wikimedia.org/T165343 (10Liuxinyu970226) [04:32:20] 10MediaWiki-extensions-CodeMirror, 10Russian-Sites: Comments after template name broke template highlighting in CodeMirror - https://phabricator.wikimedia.org/T201713 (10Liuxinyu970226) [04:51:48] 10MediaWiki-extensions-FlaggedRevs: Ability to cascade pages by stability setting - https://phabricator.wikimedia.org/T201326 (10Leaderboard) Reminder to this request of cascading viewing stability [04:55:01] (03CR) 10Legoktm: TemplateParser: Pass FLAG_MUSTACHELOOKUP to enable parent context access (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [05:05:30] (03PS1) 10Legoktm: Configure phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456783 [05:05:32] (03CR) 10Legoktm: [C: 032] Configure phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456783 (owner: 10Legoktm) [05:11:14] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Legoktm) 05Open>03Resolved a:03Bawolff [05:16:06] (03Merged) 10jenkins-bot: Configure phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456783 (owner: 10Legoktm) [05:17:14] (03PS2) 10Legoktm: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/456784 (owner: 10Libraryupgrader) [05:17:20] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/456784 (owner: 10Libraryupgrader) [05:22:26] 10MediaWiki-extensions-FundraiserLandingPage, 10Fundraising-Backlog, 10phan-taint-check-plugin: Add phan-taint-check-plugin to FundraiserLandingPage extension - https://phabricator.wikimedia.org/T202385 (10Legoktm) 05Open>03Resolved a:03Legoktm [05:22:34] 10MediaWiki-extensions-FundraiserLandingPage, 10Fundraising-Backlog, 10phan-taint-check-plugin: Add phan-taint-check-plugin to FundraiserLandingPage extension - https://phabricator.wikimedia.org/T202385 (10Legoktm) Added in {a2f7a1a4790ede562413cf5cd04ccb936d50fcc1}. [05:24:48] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2018), 10Documentation, 10Goal: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10srishakatux) Update: @srodlund and I are in the process of moving content from our Sandbox to Mainspace which entails a se... [05:26:00] 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Piramidion) The IABot interface provides strange edit description, see [[https://uk.wikipedia.org/w/index.php?diff=23240602&oldid=19... [05:31:30] (03CR) 10jenkins-bot: Configure phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456783 (owner: 10Legoktm) [05:35:55] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Linter] - 10https://gerrit.wikimedia.org/r/456784 (owner: 10Libraryupgrader) [05:42:10] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/456786 (owner: 10Libraryupgrader) [05:47:33] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456790 (owner: 10Libraryupgrader) [05:48:28] (03CR) 10Legoktm: [C: 032] "Should we have a follow-up ticket to have these test work with temporary tables?" [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (https://phabricator.wikimedia.org/T202485) (owner: 10Umherirrender) [05:52:08] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456789 (owner: 10Libraryupgrader) [05:53:19] 10MediaWiki-ResourceLoader, 10GlobalCssJs, 10Performance-Team: Preview of global.js generates syntax error when "&" is in the content - https://phabricator.wikimedia.org/T202849 (10Fomafix) Fixed by rMW693d7af0ecc0 (https://gerrit.wikimedia.org/r/456765) and verified on https://meta.wikimedia.org/w/index.php... [05:58:24] (03Merged) 10jenkins-bot: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (https://phabricator.wikimedia.org/T202485) (owner: 10Umherirrender) [05:58:29] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/AntiSpoof] - 10https://gerrit.wikimedia.org/r/456792 (owner: 10Libraryupgrader) [06:02:38] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ArticleCreationWorkflow] - 10https://gerrit.wikimedia.org/r/456794 (owner: 10Libraryupgrader) [06:09:23] (03CR) 10TTO: Switch to output HTML
 instead of 
(033 comments) [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [06:09:30] (03PS10) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [06:11:16] (03CR) 10jerkins-bot: [V: 04-1] Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [06:13:13] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Previewing a non-style-only gadget that you already have enabled causes a syntax error - https://phabricator.wikimedia.org/T200506 (10Fomafix) [06:18:46] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/456798 (owner: 10Libraryupgrader) [06:20:03] (03PS11) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [06:22:30] (03CR) 10jerkins-bot: [V: 04-1] Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [06:23:49] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456796 (owner: 10Libraryupgrader) [06:26:39] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/456797 (owner: 10Libraryupgrader) [06:26:50] (03PS12) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [06:32:24] (03PS1) 10Legoktm: Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) [06:33:57] 10MediaWiki-extensions-EducationProgram, 10phan-taint-check-plugin, 10Patch-For-Review: Add phan-taint-check-plugin to EducationProgram extension - https://phabricator.wikimedia.org/T202376 (10Legoktm) a:03Legoktm [06:34:46] (03CR) 10jerkins-bot: [V: 04-1] Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) (owner: 10Legoktm) [06:35:49] (03CR) 10Krinkle: [C: 04-1] "The unit test will need some updating with regards to how it mocks setTimeout. Right now it's assuming that each call creates a new timer," [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [06:36:17] (03PS2) 10Legoktm: Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) [06:39:48] 10phan-taint-check-plugin, 10Patch-For-Review: phan-taint-check should detect unescaped msg output in Listings but doesn't - https://phabricator.wikimedia.org/T203214 (10Bawolff) 05Open>03Resolved a:03Bawolff [06:39:52] (03CR) 10Krinkle: Switch to output HTML
 instead of 
(031 comment) [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [06:40:30] 10phan-taint-check-plugin: Make Pager::getNavigationBar safe for phan-taint-check-plugin - https://phabricator.wikimedia.org/T201811 (10Legoktm) [06:40:32] 10MediaWiki-extensions-FlaggedRevs, 10phan-taint-check-plugin: Add phan-taint-check-plugin to FlaggedRevs extension - https://phabricator.wikimedia.org/T202375 (10Legoktm) [06:42:05] 10InternetArchiveBot: Link job in edit summary, not just user name - https://phabricator.wikimedia.org/T203301 (10Cirdan) a:03Cyberpower678 [06:42:37] (03PS1) 10Legoktm: Don't double escape message [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) [06:43:11] (03PS13) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [06:44:27] (03CR) 10Brian Wolff: [C: 032] Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) (owner: 10Legoktm) [06:46:35] (03CR) 10Brian Wolff: [C: 04-1] "That's the third arg to the function not the second" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) (owner: 10Legoktm) [06:47:03] 10InternetArchiveBot: consoleversion variable is not replaced in job notification - https://phabricator.wikimedia.org/T203302 (10Cirdan) a:03Cyberpower678 [06:48:02] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/456804 (owner: 10Libraryupgrader) [06:48:39] (03CR) 10Brian Wolff: [C: 04-1] "I think the phan error is likely because the entire $options array is being treated as a unit, so it maybe thinks label-message is being s" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) (owner: 10Legoktm) [06:49:28] (03CR) 10Legoktm: "The specific error btw is:" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) (owner: 10Legoktm) [06:49:45] (03CR) 10Legoktm: [C: 04-1] Don't double escape message [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) (owner: 10Legoktm) [06:49:49] 10Wiki-Loves-Monuments: Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10Bodhisattwa) [06:49:52] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/456806 (owner: 10Libraryupgrader) [06:51:03] 10InternetArchiveBot: When the bot is set to disabled for a wiki, pause all jobs on that wiki - https://phabricator.wikimedia.org/T203304 (10Cirdan) a:03Cyberpower678 [06:56:06] 10InternetArchiveBot: Citation templates – spaces - https://phabricator.wikimedia.org/T203159 (10Cirdan) [06:57:52] 10InternetArchiveBot (v2.0): IABot adds nothing but a single whitespace, claims to have marked a link as dead - https://phabricator.wikimedia.org/T203306 (10Cirdan) a:03Cyberpower678 [06:57:54] (03CR) 10Legoktm: [C: 032] Add @covers to unit tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/455125 (https://phabricator.wikimedia.org/T195129) (owner: 10Umherirrender) [06:57:58] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456790 (owner: 10Libraryupgrader) [06:58:45] (03Merged) 10jenkins-bot: Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) (owner: 10Legoktm) [06:58:47] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/456814 (owner: 10Libraryupgrader) [07:05:42] 10InternetArchiveBot: Do not mark a link as dead simply because the redirect target URL contains 404 - https://phabricator.wikimedia.org/T203307 (10Cirdan) a:03Cyberpower678 [07:08:40] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456805 (owner: 10Libraryupgrader) [07:09:49] (03PS1) 10Brian Wolff: Make this extension pass phan-taint-check [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/456816 [07:11:32] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/456813 (owner: 10Libraryupgrader) [07:12:40] (03CR) 10Brian Wolff: [C: 032] Suppress warning for legitimate case of double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 (owner: 10Legoktm) [07:13:56] 10Readers-Web-Backlog (Tracking): Sampling sanity check for Schema:Popups pageview events - https://phabricator.wikimedia.org/T148850 (10Tbayer) 05Open>03Resolved The Popups instrumentation and the page previews feature in general subsequently went through various rewrites and bug fixes, making this task obs... [07:14:10] (03Merged) 10jenkins-bot: Add @covers to unit tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/455125 (https://phabricator.wikimedia.org/T195129) (owner: 10Umherirrender) [07:14:47] (03CR) 10jenkins-bot: Fix phan-taint-check-plugin issues [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/456808 (https://phabricator.wikimedia.org/T202376) (owner: 10Legoktm) [07:15:38] (03PS1) 10Brian Wolff: Fix minor double escaping for phan-taint-check [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/456819 [07:18:29] 10MediaWiki-extensions-Translate, 10phan-taint-check-plugin, 10Patch-For-Review, 10User-Nikerabbit: Add phan-taint-check-plugin to Translate extension - https://phabricator.wikimedia.org/T202379 (10Legoktm) 05Open>03Resolved a:03Bawolff [07:22:00] 10MediaWiki-extensions-FlaggedRevs: Ability to cascade pages by stability setting - https://phabricator.wikimedia.org/T201326 (10Aklapper) @Leaderboard: I don't understand who you "remind" and what you expect. :) There are way more tickets than developers. If you'd strongly like to see this feature implemented,... [07:23:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Replace bool default values with their string casts [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 (owner: 10MGChecker) [07:27:34] (03PS1) 10Brian Wolff: SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/456820 [07:28:07] (03Merged) 10jenkins-bot: Suppress warning for legitimate case of double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 (owner: 10Legoktm) [07:28:09] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/456820 (owner: 10Brian Wolff) [07:28:11] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add further parser tests [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455061 (https://phabricator.wikimedia.org/T193036) (owner: 10MGChecker) [07:33:57] (03Merged) 10jenkins-bot: Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 (owner: 10Legoktm) [07:33:59] (03CR) 10jerkins-bot: [V: 04-1] Replace bool default values with their string casts [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 (owner: 10MGChecker) [07:34:02] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: TemplateWizard buttons (-/+ fields and 'add/remove all') do not activate on "enter" - https://phabricator.wikimedia.org/T203287 (10Aklapper) [07:34:25] (03Merged) 10jenkins-bot: SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] - 10https://gerrit.wikimedia.org/r/456820 (owner: 10Brian Wolff) [07:34:27] (03Merged) 10jenkins-bot: Add further parser tests [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455061 (https://phabricator.wikimedia.org/T193036) (owner: 10MGChecker) [07:34:42] (03PS1) 10Brian Wolff: SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] (REL1_31) - 10https://gerrit.wikimedia.org/r/456825 [07:35:25] 10MediaWiki-Interface, 10Regression: Text "reviewWrapped" on diffs - https://phabricator.wikimedia.org/T203294 (10Aklapper) [07:35:51] 10MediaWiki-History-or-Diffs, 10Regression: Text "reviewWrapped" is displayed above diffs - https://phabricator.wikimedia.org/T203294 (10Aklapper) [07:36:48] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] (REL1_31) - 10https://gerrit.wikimedia.org/r/456825 (owner: 10Brian Wolff) [07:36:58] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/456818 (owner: 10Libraryupgrader) [07:40:15] (03PS1) 10Brian Wolff: SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_30) - 10https://gerrit.wikimedia.org/r/456827 [07:40:44] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Collection] - 10https://gerrit.wikimedia.org/r/456822 (owner: 10Libraryupgrader) [07:40:46] (03CR) 10Brian Wolff: [C: 032] SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_30) - 10https://gerrit.wikimedia.org/r/456827 (owner: 10Brian Wolff) [07:42:36] (03PS1) 10Brian Wolff: SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 [07:42:50] (03CR) 10Brian Wolff: [C: 032] SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [07:54:55] (03Merged) 10jenkins-bot: SECURITY: Fix XSS in this extension [extensions/GoogleDocTag] (REL1_31) - 10https://gerrit.wikimedia.org/r/456825 (owner: 10Brian Wolff) [07:54:57] (03Merged) 10jenkins-bot: SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_30) - 10https://gerrit.wikimedia.org/r/456827 (owner: 10Brian Wolff) [07:59:06] (03CR) 10jerkins-bot: [V: 04-1] SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [07:59:25] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/456824 (owner: 10Libraryupgrader) [08:06:34] 10MediaWiki-User-preferences, 10UI-Standardization: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI - https://phabricator.wikimedia.org/T203202 (10Umherirrender) The code is also used in Gadgets extension. The whole preference tab is a table with two columns. When the text... [08:09:51] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10Bodhisattwa) [08:09:56] 10ActiveAbstract, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10Test-Coverage: ActiveAbstract extension is missing @covers tags - https://phabricator.wikimedia.org/T195129 (10Umherirrender) 05Open>03Resolved p:05Triage>03High a:03Umherirrender [08:14:12] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10JeanFred) @Emijrp Will your awesome tools be working this year too? :) (Wanted to ask you last month and forgot >_<) [08:15:31] 10MediaWiki-History-or-Diffs, 10Regression: Text "reviewWrapped" is displayed above diffs - https://phabricator.wikimedia.org/T203294 (10Umherirrender) a:03PeterBowman Fixed by https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/FlaggedRevs/+/456759/ Backport would be nice [08:15:54] 10MediaWiki-History-or-Diffs, 10Regression: Text "reviewWrapped" is displayed above diffs - https://phabricator.wikimedia.org/T203294 (10Umherirrender) [08:17:50] (03PS1) 10Brian Wolff: Fix escaping order with Language::convert. [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456835 [08:26:43] (03PS1) 10Brian Wolff: Add taint annotation and warnings to Language::convert() et al [core] - 10https://gerrit.wikimedia.org/r/456836 [08:27:33] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10MichaelMaggs) Just to support that. We'd **love** to see this working again this year! [08:28:51] (03PS6) 10Mh-3110: Add return back link on Thanks extension success page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) [08:34:59] (03CR) 10Mh-3110: "> @Mh-3110, have you tested this patch locally and it's working?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [08:39:42] (03CR) 10Umherirrender: "There is already a bug about version 1.2.0" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/456806 (owner: 10Libraryupgrader) [08:39:52] (03Abandoned) 10Umherirrender: build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 [extensions/Cite] - 10https://gerrit.wikimedia.org/r/453336 (owner: 10Libraryupgrader) [08:41:01] (03PS1) 10Brian Wolff: Suppress double escape warning. It is a false positive [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/456845 [08:41:08] (03CR) 10Umherirrender: [V: 032] "T202455" [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/456798 (owner: 10Libraryupgrader) [08:42:07] 10donate.wikimedia.org: Add email opt-in to donatewiki forms - https://phabricator.wikimedia.org/T202327 (10Aklapper) >>! In T202327#4549505, @MNoorWMF wrote: > I dug around inside donatewiki for a couple of days but wasn't able to find where the DonationInterface translations were to be able to make the transla... [08:42:44] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/456822 (owner: 10Libraryupgrader) [08:45:45] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/BounceHandler] - 10https://gerrit.wikimedia.org/r/456798 (owner: 10Libraryupgrader) [08:49:38] (03CR) 10Umherirrender: "recheck" [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [08:52:13] (03CR) 10Umherirrender: "check php" [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [08:54:36] 04(no projects): phan-taint-check sometimes can't tell that the third arg to a tag hook is a Parser object unless there is a type hint - https://phabricator.wikimedia.org/T203308 (10Bawolff) [08:54:48] 10phan-taint-check-plugin: phan-taint-check sometimes can't tell that the third arg to a tag hook is a Parser object unless there is a type hint - https://phabricator.wikimedia.org/T203308 (10Bawolff) [08:56:03] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [08:56:22] (03PS1) 10Brian Wolff: Add type hints (To work around phan-taint-check issue) [extensions/I18nTags] - 10https://gerrit.wikimedia.org/r/456849 [08:58:31] (03CR) 10Umherirrender: [C: 032] Make this extension pass phan-taint-check [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/456816 (owner: 10Brian Wolff) [09:00:23] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/456843 (owner: 10Libraryupgrader) [09:02:52] (03Merged) 10jenkins-bot: SECURITY: Backport XSS fix b259bf725e79e [extensions/GoogleDocTag] (REL1_27) - 10https://gerrit.wikimedia.org/r/456828 (owner: 10Brian Wolff) [09:03:39] (03Merged) 10jenkins-bot: Make this extension pass phan-taint-check [extensions/GlobalContributions] - 10https://gerrit.wikimedia.org/r/456816 (owner: 10Brian Wolff) [09:05:34] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/456844 (owner: 10Libraryupgrader) [09:06:05] (03CR) 10Umherirrender: Don't double escape message (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456809 (https://phabricator.wikimedia.org/T202375) (owner: 10Legoktm) [09:08:27] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ExtensionDistributor] - 10https://gerrit.wikimedia.org/r/456846 (owner: 10Libraryupgrader) [09:11:00] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Collection] - 10https://gerrit.wikimedia.org/r/456822 (owner: 10Libraryupgrader) [09:14:45] 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Solve ErfgoedBot categorisation problem - https://phabricator.wikimedia.org/T174871 (10Lokal_Profil) Typo meant that https://gerrit.wikimedia.org/r/#/c/labs/tools/heritage/+/456758/ did not get picked up. It blacklists another 8 countries. [09:15:17] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/456853 (owner: 10Libraryupgrader) [09:17:03] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/456854 (owner: 10Libraryupgrader) [09:25:28] 10Wiki-Loves-Monuments-Database: add commit-message-validator to ci - https://phabricator.wikimedia.org/T203309 (10Lokal_Profil) [09:29:36] 10Wiki-Loves-Monuments-Database: add commit-message-validator to ci - https://phabricator.wikimedia.org/T203309 (10Lokal_Profil) This //should// new add easy add adding `- name: commit-message-validator` to the `template` section of `labs/tools/heritage` in [[https://github.com/wikimedia/integration-config/blob/... [09:34:40] 10Wiki-Loves-Monuments-Database: add commit-message-validator to ci - https://phabricator.wikimedia.org/T203309 (10Lokal_Profil) [09:46:44] (03CR) 10Raimond Spekking: [C: 032] Fix common typos in code [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:47:29] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/456856 (owner: 10Libraryupgrader) [09:50:10] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/456860 (owner: 10Libraryupgrader) [09:50:23] 10MediaWiki-extension-requests, 10Performance-Team, 10Security-Team, 10Patch-For-Review: Develop an easy way for wikis to create a blackout protest - https://phabricator.wikimedia.org/T198890 (10Daimona) @Krinkle thanks for the deep review; here are my thoughts/replies: - Reading from a wg variable is wha... [09:50:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/456861 (owner: 10Libraryupgrader) [09:52:44] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GlobalCssJs] - 10https://gerrit.wikimedia.org/r/456859 (owner: 10Libraryupgrader) [09:53:06] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Daimona) [09:56:58] (03Merged) 10jenkins-bot: Fix common typos in code [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:58:05] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Raymond) [10:06:38] (03PS1) 10Fomafix: Use Array.prototype.indexOf instead of $.inArray [core] - 10https://gerrit.wikimedia.org/r/456870 (https://phabricator.wikimedia.org/T200877) [10:14:14] (03CR) 10Raimond Spekking: [C: 032] Move MwEmbed- and EmbedPlayer-related i18n to i18n/ [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 (owner: 10Jforrester) [10:23:24] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/456865 (owner: 10Libraryupgrader) [10:23:54] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10JeanFred) See also T203305 − another set of stats is available at https://tools.wmflabs.org/wikiloves/monuments/2018 [10:24:02] (03CR) 10Umherirrender: "recheck" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/456861 (owner: 10Libraryupgrader) [10:25:35] (03CR) 10jerkins-bot: [V: 04-1] Use Array.prototype.indexOf instead of $.inArray [core] - 10https://gerrit.wikimedia.org/r/456870 (https://phabricator.wikimedia.org/T200877) (owner: 10Fomafix) [10:30:32] (03PS3) 10Zoranzoki21: Fix "occured" typo in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [10:30:50] (03PS4) 10Zoranzoki21: Fix "occured" typo in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [10:31:12] (03PS5) 10Zoranzoki21: Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [10:31:28] (03Abandoned) 10Zoranzoki21: Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/455019 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:31:58] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/456861 (owner: 10Libraryupgrader) [10:34:41] (03PS1) 10Brian Wolff: Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) [10:39:15] (03Abandoned) 10Fomafix: Use Array.prototype.indexOf instead of $.inArray [core] - 10https://gerrit.wikimedia.org/r/456870 (https://phabricator.wikimedia.org/T200877) (owner: 10Fomafix) [10:40:00] (03PS3) 10Fomafix: Remove jQuery.inArray usages [core] - 10https://gerrit.wikimedia.org/r/455255 (owner: 10Petar.petkovic) [10:42:13] (03CR) 10jerkins-bot: [V: 04-1] Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) (owner: 10Brian Wolff) [10:42:23] (03PS4) 10Fomafix: Remove jQuery.inArray usages [core] - 10https://gerrit.wikimedia.org/r/455255 (https://phabricator.wikimedia.org/T200877) (owner: 10Petar.petkovic) [10:44:05] (03CR) 10Brian Wolff: [C: 032] Add a hook to allow changing the query of Special:AncientPages in extensions [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) (owner: 10Agabi10) [10:48:23] (03PS6) 10Zoranzoki21: Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) [10:49:12] (03CR) 10Fomafix: Remove jQuery.inArray usages (032 comments) [core] - 10https://gerrit.wikimedia.org/r/455255 (https://phabricator.wikimedia.org/T200877) (owner: 10Petar.petkovic) [10:51:00] (03CR) 10jerkins-bot: [V: 04-1] Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:51:49] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/456880 (owner: 10Libraryupgrader) [10:52:24] (03CR) 10jerkins-bot: [V: 04-1] Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:52:43] (03CR) 10jerkins-bot: [V: 04-1] Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:52:49] (03CR) 10Mxn: [C: 032] Fix "aricles" label [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456617 (https://phabricator.wikimedia.org/T183058) (owner: 10Jdrewniak) [10:55:03] (03Merged) 10jenkins-bot: Fix "aricles" label [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456617 (https://phabricator.wikimedia.org/T183058) (owner: 10Jdrewniak) [11:08:30] (03Merged) 10jenkins-bot: Add a hook to allow changing the query of Special:AncientPages in extensions [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) (owner: 10Agabi10) [11:09:09] (03CR) 10jerkins-bot: [V: 04-1] Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) (owner: 10Brian Wolff) [11:12:11] (03CR) 10jenkins-bot: Add a hook to allow changing the query of Special:AncientPages in extensions [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) (owner: 10Agabi10) [11:13:01] (03PS2) 10Brian Wolff: Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) [11:13:21] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/456883 (owner: 10Libraryupgrader) [11:17:29] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Aklapper) [11:18:43] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10Bawolff) So some other things: * What is the lifecycle plan for this (Will it be deployed forever? When will it be undeployed? Will the wiki be deleted after this is all done? ) * The silv... [11:21:23] (03CR) 10jerkins-bot: [V: 04-1] Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) (owner: 10Brian Wolff) [11:21:26] (03CR) 10jerkins-bot: [V: 04-1] Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) (owner: 10Brian Wolff) [11:22:27] (03CR) 10Brian Wolff: [C: 04-1] "Note, I'm also leaving my comments that aren't specific to a particular line of code at https://phabricator.wikimedia.org/T203095" (032 comments) [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:22:38] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [11:26:36] (03PS3) 10Brian Wolff: Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) [11:31:26] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10MarcoAurelio) >>! In T203095#4550467, @Bawolff wrote: > * I just tried signing my email up - I got a success message, but no confirmation email. Does this mean anyone can sign anybody up to... [11:31:34] (03PS4) 10Brian Wolff: Split UserGroupMembership::getLink into 2 functions [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) [11:34:49] (03PS6) 10Zoranzoki21: Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [11:34:56] (03PS7) 10Zoranzoki21: Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [11:34:58] (03PS19) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:37:00] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:38:36] (03PS20) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:40:33] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:41:30] (03PS21) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [11:44:18] (03CR) 10Raimond Spekking: [C: 032] "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 (owner: 10Jforrester) [11:50:36] (03CR) 10Umherirrender: "Test failures are T202223" [extensions/Math] - 10https://gerrit.wikimedia.org/r/456885 (owner: 10Libraryupgrader) [11:50:55] (03Abandoned) 10Umherirrender: build: Updating mediawiki/phan-taint-check-plugin to 1.3.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/453741 (owner: 10Libraryupgrader) [11:50:59] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10Emijrp) 05Open>03Resolved a:03Emijrp wlm-stats and wlm-maps are updated now. Regards! [11:51:59] 10MediaWiki-extensions-Other, 10Security, 10Vuln-XSS: XSS in YotpoReviews tag hook - https://phabricator.wikimedia.org/T202249 (10Bawolff) [11:52:34] (03PS1) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) [11:52:48] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456888 (owner: 10Libraryupgrader) [11:53:01] (03CR) 10jerkins-bot: [V: 04-1] Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:54:34] (03PS1) 10Esanders: Scope styling of kbd/samp/code/pre to content areas [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456894 [11:54:36] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/456889 (owner: 10Libraryupgrader) [11:54:57] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [11:56:31] 10MediaWiki-Codesniffer: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10Umherirrender) [11:58:29] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10CCicalese_WMF) > The actual dates and deadlines are confusing to me. Is the extension finished now? If not, when will it be "done". When is the target date for this all to go live? We are... [11:58:55] (03PS2) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) [12:00:07] (03CR) 10Brian Wolff: "whoops did not mean to push PS2" [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:01:05] (03PS3) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) [12:01:20] (03CR) 10jerkins-bot: [V: 04-1] Fix common typos in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:01:22] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:01:42] (03PS1) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_31) - 10https://gerrit.wikimedia.org/r/456897 (https://phabricator.wikimedia.org/T202249) [12:02:00] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_31) - 10https://gerrit.wikimedia.org/r/456897 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:04:13] bawolff: not sure if the commit-message-validator will complain because you didn't leave an empty line between commit desc and Bug:xxx [12:04:32] * bawolff getting sleepy [12:04:45] and doing stupid things [12:04:58] go to sleep :) [12:05:15] Well jenkins seems to have not complained [12:05:39] I still have to do REL1_30 and REL1_27! [12:05:44] and maybe send an email [12:06:45] (03PS1) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_30) - 10https://gerrit.wikimedia.org/r/456898 (https://phabricator.wikimedia.org/T202249) [12:06:50] it's just +2 for 30 and 27 ? [12:07:26] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_30) - 10https://gerrit.wikimedia.org/r/456898 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:08:28] (03Merged) 10jenkins-bot: SECURITY: Fix XSS [extensions/YotpoReviews] - 10https://gerrit.wikimedia.org/r/456892 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:08:30] (03Merged) 10jenkins-bot: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_31) - 10https://gerrit.wikimedia.org/r/456897 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:08:41] (03PS1) 10Brian Wolff: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_27) - 10https://gerrit.wikimedia.org/r/456899 (https://phabricator.wikimedia.org/T202249) [12:09:03] (03CR) 10Brian Wolff: [C: 032] SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_27) - 10https://gerrit.wikimedia.org/r/456899 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:10:36] dumb-noob-question: what happens when you push a change to a REL branch? Is a new tarball generated? If yes, by whom/what? [12:12:14] (03Merged) 10jenkins-bot: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_30) - 10https://gerrit.wikimedia.org/r/456898 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:16:45] Hauskatze: no [12:16:58] but if you pull a extesnion via ED it will get it [12:17:07] ED? [12:17:24] but it will be ready to go next time there is a tarball (non extensions) [12:17:41] Extension Distributor [12:18:08] (03Merged) 10jenkins-bot: SECURITY: Fix XSS [extensions/YotpoReviews] (REL1_27) - 10https://gerrit.wikimedia.org/r/456899 (https://phabricator.wikimedia.org/T202249) (owner: 10Brian Wolff) [12:18:09] (The download service on the mw extension pages that generates tarballs in realtime) [12:18:38] (03CR) 10Esanders: Allow skins to place notification container for mw.notify (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [12:19:07] https://lists.wikimedia.org/pipermail/mediawiki-l/2018-September/047605.html email sent [12:19:34] ah, ExtDist, yep I know that :) Didn't associated it with ED, sorry :) [12:19:52] Hauskatze: Some people also directly clone release branches from git [12:20:08] or download archives from github [12:20:11] (I do, when I want to do something there) [12:20:27] rather, I clone the repo and git checkout to it [12:20:31] Hauskatze: If you directly get the extension from Katherine, I'm unsure if it will be up to date ;) [12:20:54] (03PS2) 10Esanders: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) [12:21:13] * bawolff not really happy with procedures around extension security updates [12:21:48] Its not consistently enforced, there's no central list of what versions are vulnerable, no cve's, very difficult for someone to be able to figure out if they are up to date [12:21:55] half the extensions don't even use version numbers [12:22:10] * bawolff imagines a world where Special:Version would check for any vulnerable extensions and highlight them in red [12:22:13] (03PS10) 10Esanders: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [12:22:20] (03CR) 10jerkins-bot: [V: 04-1] Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) (owner: 10Esanders) [12:22:53] (03CR) 10jerkins-bot: [V: 04-1] Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [12:23:31] bawolff: I get nothing from Katherine but an email or two a year :) [12:23:32] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10Security, 10Vuln-XSS: XSS in YotpoReviews tag hook - https://phabricator.wikimedia.org/T202249 (10Bawolff) 05Open>03Resolved a:03Bawolff [12:23:39] (03CR) 10jerkins-bot: [V: 04-1] Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [12:25:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/456904 (owner: 10Libraryupgrader) [12:27:02] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10MichaelMaggs) 05Resolved>03Open The detailed per-country pages such as https://stats.wikilovesmonuments.cl/2017/unitedkingdom are still based on 2017 data. [12:27:31] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/456905 (owner: 10Libraryupgrader) [12:31:37] 10MediaWiki-Vagrant: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment - https://phabricator.wikimedia.org/T203289 (10Reedy) They do love their breaking changes in point releases... [12:32:38] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/456904 (owner: 10Libraryupgrader) [12:34:45] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/456907 (owner: 10Libraryupgrader) [12:36:45] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ORES] - 10https://gerrit.wikimedia.org/r/456906 (owner: 10Libraryupgrader) [12:38:45] How can I restart jenkins gate-and-submit jobs? [12:38:58] Remove CR+2 and reapply it? [12:39:10] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Unblock stuck global rename of Nouminouna to Bnhassin - https://phabricator.wikimedia.org/T163622 (10MarcoAurelio) - #patch-for-review [12:39:39] Oh, didn't know about that. [12:42:31] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10Aklapper) [offtopic] >>! In T203095#4550530, @CCicalese_WMF wrote: > The text is also not final, but is getting close. Does it make sense to file "content bugs" for stuff on https://wmfeu... [12:42:33] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/456910 (owner: 10Libraryupgrader) [12:42:57] (03CR) 10Umherirrender: [V: 032] "T201745" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/456907 (owner: 10Libraryupgrader) [12:44:06] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10MarcoAurelio) >>! In T203095#4550599, @Aklapper wrote: > [offtopic] > >>>! In T203095#4550530, @CCicalese_WMF wrote: >> The text is also not final, but is getting close. > > Does it make... [12:45:07] (03PS1) 10Umherirrender: Pass delimiter to preg_quote [core] - 10https://gerrit.wikimedia.org/r/456916 [12:46:27] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456911 (owner: 10Libraryupgrader) [12:48:39] 10MediaWiki-Codesniffer, 10Patch-For-Review: Add sniff that preg_quote should not be used with 1 argument - https://phabricator.wikimedia.org/T203312 (10Umherirrender) The expaned sniff does not detect the function at location where callables are allowed: ``` array_map( 'preg_quote', array_keys( $config[ApiB... [12:49:38] (03PS22) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [12:50:15] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [12:50:41] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [12:52:45] (03PS2) 10Umherirrender: Pass delimiter to preg_quote [core] - 10https://gerrit.wikimedia.org/r/456916 [12:54:42] (03CR) 10Umherirrender: "See also T202361" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/456905 (owner: 10Libraryupgrader) [12:54:59] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/456912 (owner: 10Libraryupgrader) [12:55:07] (03CR) 10jerkins-bot: [V: 04-1] Add return back link on Thanks extension success page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [12:55:51] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review, 10User-D3r1ck01: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10D3r1ck01) [13:00:51] 04(no projects): 5 - https://phabricator.wikimedia.org/T203317 (10Oppenede) [13:02:40] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/456914 (owner: 10Libraryupgrader) [13:04:28] 04(no projects): Along with the "more languages" button there should be a button to expand the - https://phabricator.wikimedia.org/T203318 (10Oppenede) [13:04:48] 04(no projects): Along with the "more languages" button there should be a button to expand the list of languages - https://phabricator.wikimedia.org/T203318 (10Oppenede) [13:06:39] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review, 10User-D3r1ck01: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10D3r1ck01) [13:07:59] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Session is not saved across all Wikimedia sites - https://phabricator.wikimedia.org/T203264 (10Amire80) >>! In T203264#4549152, @Aklapper wrote: > Also see and follow https://www.mediawiki.org/wiki/Manual:How_to_debug/... [13:08:27] 04(no projects): Along with the "more languages" button there should be a button to expand the list of languages - https://phabricator.wikimedia.org/T203318 (10Aklapper) 05Open>03Invalid Hi @Oppenede, thanks for taking the time to report this! Assuming this is about the side bar on some Wikimedia site, yo... [13:11:05] 10FormWizard, 10Easy: Link to extension documentation in extension configuration is wrong - https://phabricator.wikimedia.org/T203089 (10D3r1ck01) [13:36:00] (03CR) 10Sophivorus: [C: 032] Suppress double escape warning. It is a false positive [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/456845 (owner: 10Brian Wolff) [13:42:22] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456924 (owner: 10Libraryupgrader) [13:44:50] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Popups] - 10https://gerrit.wikimedia.org/r/456923 (owner: 10Libraryupgrader) [13:45:35] (03Merged) 10jenkins-bot: Suppress double escape warning. It is a false positive [extensions/HoverGallery] - 10https://gerrit.wikimedia.org/r/456845 (owner: 10Brian Wolff) [13:59:32] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/456926 (owner: 10Libraryupgrader) [14:01:05] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/456927 (owner: 10Libraryupgrader) [14:21:11] (03PS1) 10Fomafix: resourceloader: Avoid duplicate existence check [core] - 10https://gerrit.wikimedia.org/r/456944 [14:25:34] 10Growth-Team, 10StructuredDiscussions: StructuredDiscussions does not show the contents of the fragment after the change - https://phabricator.wikimedia.org/T203322 (10Zoranzoki21) [14:30:29] (03PS1) 10MarcoAurelio: build: Add mediawiki/mediawiki-codesniffer [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 [14:30:31] (03PS1) 10MarcoAurelio: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456947 [14:30:33] (03PS1) 10MarcoAurelio: Autofixing Generic.ControlStructures.InlineControlStructure.NotAllowed errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456948 [14:30:35] (03PS1) 10MarcoAurelio: Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456949 [14:30:37] (03PS1) 10MarcoAurelio: Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 [14:30:39] (03PS1) 10MarcoAurelio: Autofixing MediaWiki.WhiteSpace.* errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456951 [14:30:41] (03PS1) 10MarcoAurelio: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456952 [14:33:18] 10MediaWiki-Vagrant, 10User-zeljkofilipin: NameError: uninitialized constant MediaWikiVagrant::Environment - https://phabricator.wikimedia.org/T203145 (10zeljkofilipin) [14:33:20] 10MediaWiki-Vagrant: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment - https://phabricator.wikimedia.org/T203289 (10zeljkofilipin) [14:34:28] (03CR) 10MarcoAurelio: Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors (031 comment) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [14:36:49] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10CCicalese_WMF) Thanks for mentioning that! Maybe file those as subtasks of T203295 for now? [14:40:00] 04(no projects): EUCopyrightCampaign lists incorrect MEPs per country and has encoding issues - https://phabricator.wikimedia.org/T203323 (10MarcoAurelio) [14:41:13] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10MarcoAurelio) >>! In T203095#4550737, @CCicalese_WMF wrote: > Thanks for mentioning that! Maybe file those as subtasks of T203295 for now? Filed as {T203323}. Feel free to amend the task... [14:46:07] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/SpamBlacklist] - 10https://gerrit.wikimedia.org/r/456941 (owner: 10Libraryupgrader) [14:48:10] (03PS1) 10MarcoAurelio: build: Update jsonlint and banana-checker [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456958 [14:49:00] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/456942 (owner: 10Libraryupgrader) [14:49:44] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10CCicalese_WMF) Thank you! [14:52:43] (03PS7) 10Mh-3110: Add return back link on Thanks extension success page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) [14:54:35] (03PS2) 10MarcoAurelio: build: Update grunt, jsonlint and banana-checker to their latests versions [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456958 [14:58:45] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/456957 (owner: 10Libraryupgrader) [15:03:12] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/TextExtracts] - 10https://gerrit.wikimedia.org/r/456960 (owner: 10Libraryupgrader) [15:04:59] (03CR) 10MarcoAurelio: "Maybe I can try to update much more than just this." [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456958 (owner: 10MarcoAurelio) [15:13:14] (03PS3) 10MarcoAurelio: build: Update grunt, jsonlint and banana-checker to their latests versions [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456958 [15:16:31] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/456963 (owner: 10Libraryupgrader) [15:19:50] 10Trust-and-Safety, 10Wikimedia-Site-requests: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10Framawiki) [15:31:43] (03PS23) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [15:31:51] (03CR) 10MarcoAurelio: "Unsure about this patch set wrt the inline comments I've left." [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [15:32:24] (03CR) 10MGChecker: [C: 032] "Can I trigger Jenkins to run again this way?" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 (owner: 10MGChecker) [15:33:06] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [15:35:50] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Zoranzoki21: Convert Loops to use extension registration - https://phabricator.wikimedia.org/T192113 (10MGChecker) @Zoranzoki21 This patch isn't done, there are still mistakes in your code. [15:40:58] (03Merged) 10jenkins-bot: Replace bool default values with their string casts [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 (owner: 10MGChecker) [15:42:06] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/456972 (owner: 10Libraryupgrader) [15:43:25] 10MediaWiki-extensions-TorBlock, 10Technical-Debt (Deprecation): Deprecate loadExitNodes.php - https://phabricator.wikimedia.org/T203324 (10MarcoAurelio) [15:45:42] (03PS1) 10MarcoAurelio: Soft-deprecate loadExitNodes.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/456979 (https://phabricator.wikimedia.org/T203324) [15:47:04] 10MediaWiki-Authentication-and-authorization: BotPasswords right selection form shows plain-text html - https://phabricator.wikimedia.org/T203325 (10Framawiki) p:05Triage>03High [15:47:05] (03PS2) 10MarcoAurelio: Soft-deprecate loadExitNodes.php [extensions/TorBlock] - 10https://gerrit.wikimedia.org/r/456979 (https://phabricator.wikimedia.org/T203324) [15:48:21] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/456973 (owner: 10Libraryupgrader) [15:57:06] 10InternetArchiveBot (v2.0): IABot removes link while fixing another - https://phabricator.wikimedia.org/T190647 (10Cyberpower678) I'll see to getting this fixed in beta10. [15:58:45] 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on Cantonese Wikipedia (zh-yuewiki) - https://phabricator.wikimedia.org/T188206 (10Cyberpower678) Bot is approved. [15:59:00] 10MediaWiki-extensions-Other: EUCopyrightCampaign lists incorrect MEPs per country and has encoding issues - https://phabricator.wikimedia.org/T203323 (10MarcoAurelio) [15:59:46] 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Cyberpower678) >>! In T151446#4550254, @Piramidion wrote: > The IABot interface provides strange edit description, see [[https://uk.... [15:59:56] 10MediaWiki-extensions-Other, 10Core-Platform-Team: EUCopyrightCampaign lists incorrect MEPs per country and has encoding issues - https://phabricator.wikimedia.org/T203323 (10MarcoAurelio) [16:00:00] 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Cyberpower678) Bot is approved. [16:00:31] 10Bengali-Sites, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Bengali Wikipedia (bnwiki) - https://phabricator.wikimedia.org/T169482 (10Cyberpower678) Bot is approved. [16:02:58] 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10Emijrp) adding Dennis for that tool [16:25:44] 10MediaWiki-extensions-Other, 10Core-Platform-Team: EUCopyrightCampaign lists incorrect MEPs per country and has encoding issues - https://phabricator.wikimedia.org/T203323 (10Aklapper) To provide one specific example, Scottà is IT and not CZ. Plus `à` not `a'`. {F25596858} [16:46:04] (03CR) 10Umherirrender: [C: 032] build: Add mediawiki/mediawiki-codesniffer [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [16:47:06] 10Developer-Advocacy, 10Documentation: Improve documentation on Phab / Gerrit notification settings and mail filtering recommendations - https://phabricator.wikimedia.org/T202153 (10Aklapper) [16:47:38] 10Developer-Advocacy, 10Documentation: Improve documentation on Phab / Gerrit notification settings and mail filtering recommendations - https://phabricator.wikimedia.org/T202153 (10Aklapper) [16:47:48] (03CR) 10Umherirrender: [C: 032] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456947 (owner: 10MarcoAurelio) [16:49:15] (03CR) 10Umherirrender: [C: 032] Autofixing Generic.ControlStructures.InlineControlStructure.NotAllowed errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456948 (owner: 10MarcoAurelio) [16:49:32] (03CR) 10Umherirrender: [C: 032] Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456949 (owner: 10MarcoAurelio) [16:50:44] (03PS2) 10Umherirrender: Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [16:51:03] (03CR) 10Umherirrender: [C: 032] Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors (031 comment) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [16:51:50] (03PS2) 10Umherirrender: Autofixing MediaWiki.WhiteSpace.* errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456951 (owner: 10MarcoAurelio) [16:52:03] (03CR) 10Umherirrender: [C: 032] Autofixing MediaWiki.WhiteSpace.* errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456951 (owner: 10MarcoAurelio) [16:52:10] 10Phabricator: Reduce or eliminate bracketed labels to shorten phabricator emails subjects - https://phabricator.wikimedia.org/T650 (10Aklapper) 05Open>03declined Users who'd like to not see stuff like `[Changed Project Column]` in the subject line of mail notifications can disable "Vary Subjects" under http... [16:53:33] (03PS2) 10Umherirrender: Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456949 (owner: 10MarcoAurelio) [16:54:35] (03CR) 10Umherirrender: "check php" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [16:55:33] (03CR) 10MarcoAurelio: Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors (031 comment) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [16:55:40] (03Abandoned) 10Umherirrender: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456952 (owner: 10MarcoAurelio) [16:56:11] (03CR) 10Umherirrender: "check php" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [16:59:56] (03CR) 10jerkins-bot: [V: 04-1] build: Add mediawiki/mediawiki-codesniffer [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [16:59:58] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456947 (owner: 10MarcoAurelio) [17:00:00] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Generic.ControlStructures.InlineControlStructure.NotAllowed errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456948 (owner: 10MarcoAurelio) [17:00:02] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Generic.Files.LineEndings.InvalidEOLChar errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456949 (owner: 10MarcoAurelio) [17:00:04] (03CR) 10jerkins-bot: [V: 04-1] Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [17:00:06] (03CR) 10jerkins-bot: [V: 04-1] Autofixing MediaWiki.WhiteSpace.* errors [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456951 (owner: 10MarcoAurelio) [17:01:01] (03CR) 10jerkins-bot: [V: 04-1] build: Add mediawiki/mediawiki-codesniffer [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:01:17] (03PS2) 10Umherirrender: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456994 (owner: 10Libraryupgrader) [17:02:46] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/456990 (owner: 10Libraryupgrader) [17:04:15] (03CR) 10Umherirrender: "extension needs a fix for php7. I have no reason why it is failing on the new version" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:05:11] (03CR) 10jenkins-bot: build: Updating mediawiki/phan-taint-check-plugin to 1.4.0 [extensions/timeline] - 10https://gerrit.wikimedia.org/r/456992 (owner: 10Libraryupgrader) [17:05:27] (03CR) 10Umherirrender: "check experimental" [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456994 (owner: 10Libraryupgrader) [17:05:57] (03CR) 10Umherirrender: "It seems seccheck jobs are not running here" [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456994 (owner: 10Libraryupgrader) [17:06:47] (03CR) 10MarcoAurelio: "Reading the jenkins output, I have no idea either. Could it be the hack that hashar made at d66235c and 466a685 ?" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:12:17] 10MediaWiki-Recent-changes, 10MediaWiki-Watchlist, 10Growth-Team: Provide a link that opens all pages with changes since last visit in new tabs - https://phabricator.wikimedia.org/T202632 (10Bear336) All You Would Need To Do Is To Change Subscribers. Then By submitting It, It Would Keep Everything Up To Date. [17:12:19] 10MediaWiki-extensions-Other: [CloseWikis] CI fails on 'check php' with unknown reason - https://phabricator.wikimedia.org/T203329 (10MarcoAurelio) [17:12:42] (03CR) 10MarcoAurelio: "Reported at T203329." [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:19:18] 04(no projects): Large Font display on iPad app - https://phabricator.wikimedia.org/T203330 (10Tinoargentino) [17:20:38] 04(no projects): Large Font display on iPad app - https://phabricator.wikimedia.org/T203330 (10Tinoargentino) [17:25:59] 10MediaWiki-Authentication-and-authorization: BotPasswords right selection form shows plain-text html - https://phabricator.wikimedia.org/T203325 (10MarcoAurelio) Confirmed. [17:27:54] 10MediaWiki-Authentication-and-authorization: BotPasswords right selection form shows plain-text html - https://phabricator.wikimedia.org/T203325 (10MarcoAurelio) https://gerrit.wikimedia.org/g/mediawiki/core/+/master/includes/specials/SpecialBotPasswords.php#133 ? [17:29:19] framawiki: ^^ broken indeed [17:29:29] love it [17:33:16] 04(no projects): View history across devices - https://phabricator.wikimedia.org/T203332 (10Tinoargentino) [17:36:57] though I'm unable to determine where the "broken" stuff comes from [17:39:54] 10MediaWiki-Authentication-and-authorization: BotPasswords right selection form shows plain-text html - https://phabricator.wikimedia.org/T203325 (10MarcoAurelio) [offtopic] How many minutes does MediaWiki let you see that page without having to fully reauthenticate again and again (password + TOTP)? [17:44:46] (03CR) 10MarcoAurelio: "On the other hand, if not wrong, we could just merge these build changes and try to find a fix for that 'check php' later if that's okay. " [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:44:57] (03CR) 10Umherirrender: Autofixing Generic.Formatting.DisallowMultipleStatements.SameLine errors (031 comment) [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456950 (owner: 10MarcoAurelio) [17:45:01] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: "Add links" should support search by Wikidata title and links to Commons - https://phabricator.wikimedia.org/T203333 (10SJu) [17:46:56] (03CR) 10Umherirrender: "The php7 is failing on gate-and-submit (and on check php). That means the patch sets must merged bypassing jenkins" [extensions/CloseWikis] - 10https://gerrit.wikimedia.org/r/456946 (owner: 10MarcoAurelio) [17:51:31] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: add links widget only allows connecting pages between language editions of the same project - should also allow connecting to other projects - https://phabricator.wikimedia.org/T71735 (10Sjoerddebruin) [17:51:33] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: "Add links" should support search by Wikidata title and links to Commons - https://phabricator.wikimedia.org/T203333 (10Sjoerddebruin) [17:54:09] (03PS14) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:55:07] (03PS15) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:55:12] (03PS16) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:55:15] (03CR) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" (032 comments) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [18:07:10] (03CR) 10Legoktm: "Jenkins doesn't support seccheck for skins yet IIRC, I'll work on that." [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456994 (owner: 10Libraryupgrader) [18:09:30] (03PS1) 10MR70: List of permissions should not be shown for non-existent global groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456997 [18:11:00] (03PS2) 10Legoktm: Add taint annotation and warnings to Language::convert() et al [core] - 10https://gerrit.wikimedia.org/r/456836 (https://phabricator.wikimedia.org/T202571) (owner: 10Brian Wolff) [18:11:26] (03CR) 10Legoktm: [C: 032] ":|" [core] - 10https://gerrit.wikimedia.org/r/456836 (https://phabricator.wikimedia.org/T202571) (owner: 10Brian Wolff) [18:15:38] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Zoglun) >>! In T203061#4549478, @Krinkle wrote: > I'm not sure such structure was officially supported. (The documen... [18:16:03] 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Piramidion) > In T151446#4550808, @Cyberpower678 wrote: > Templates are not advised in edit summaries. Can you replace that with su... [18:17:03] (03CR) 10Legoktm: [C: 04-1] "LGTM, but can you add tests for the new functions? There's a coverage drop." [core] - 10https://gerrit.wikimedia.org/r/456879 (https://phabricator.wikimedia.org/T183174) (owner: 10Brian Wolff) [18:18:35] 10Internet-Archive, 10WMUA-Hackathons, 10InternetArchiveBot (v2.0): Deploy InternetArchiveBot on the Ukrainian Wikipedia (ukwiki) - https://phabricator.wikimedia.org/T151446 (10Cyberpower678) Done. [18:21:57] 10MediaWiki-extensions-OAuth, 10phan-taint-check-plugin: OAuth extension needs phan-taint-check update to version 1.3.0 - https://phabricator.wikimedia.org/T202361 (10Legoktm) a:03Legoktm I tracked this down last night, there's a super convoluted code flow of returning a Message object without setting an out... [18:32:56] (03Merged) 10jenkins-bot: Add taint annotation and warnings to Language::convert() et al [core] - 10https://gerrit.wikimedia.org/r/456836 (https://phabricator.wikimedia.org/T202571) (owner: 10Brian Wolff) [18:35:39] 10MediaWiki-General-or-Unknown: Broken pipe when redis set to 'persistent' => true, - https://phabricator.wikimedia.org/T203298 (10Zoglun) With further test, same problem could be reproduced with Mediawiki 1.30. The problem is not limited to session storage, it happened when $wgMainCacheType = redis too. What m... [18:35:58] (03CR) 10jenkins-bot: Add taint annotation and warnings to Language::convert() et al [core] - 10https://gerrit.wikimedia.org/r/456836 (https://phabricator.wikimedia.org/T202571) (owner: 10Brian Wolff) [18:43:48] (03PS24) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (https://phabricator.wikimedia.org/T203295) (owner: 10Robert Vogel) [19:18:36] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Krinkle) >>! In T203061#4550948, @Zoglun wrote: >>>! In T203061#4549478, @Krinkle wrote: >> I'm not sure such struct... [19:21:36] (03PS2) 10MR70: List of permissions should not be shown for non-existent global groups [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456997 (https://phabricator.wikimedia.org/T201723) [19:31:32] (03CR) 10Krinkle: [C: 032] Drop the transcache table from the schema [core] - 10https://gerrit.wikimedia.org/r/455875 (https://phabricator.wikimedia.org/T189702) (owner: 10Aaron Schulz) [19:50:34] (03PS1) 10Krinkle: RELEASE-NOTES: Use 'New/Changed/Removed' pattern for more sections [core] - 10https://gerrit.wikimedia.org/r/457000 [19:51:06] (03PS2) 10Krinkle: RELEASE-NOTES: Use New/Changed/Removed pattern for Configuration section [core] - 10https://gerrit.wikimedia.org/r/457000 [19:54:15] 10AbuseFilter: Fatal exception of type when editing an abuse filter - https://phabricator.wikimedia.org/T203336 (10He7d3r) [19:56:37] (03Merged) 10jenkins-bot: Drop the transcache table from the schema [core] - 10https://gerrit.wikimedia.org/r/455875 (https://phabricator.wikimedia.org/T189702) (owner: 10Aaron Schulz) [19:57:58] (03PS3) 10Krinkle: RELEASE-NOTES: Use 'New/Changed/Removed' pattern for more sections [core] - 10https://gerrit.wikimedia.org/r/457000 [19:58:14] (03PS4) 10Krinkle: RELEASE-NOTES: Use New/Changed/Removed pattern for Configuration section [core] - 10https://gerrit.wikimedia.org/r/457000 [19:58:36] legoktm: would appreciate a quick review on ^ before it starts to conflict :-) [19:59:19] (03CR) 10jenkins-bot: Drop the transcache table from the schema [core] - 10https://gerrit.wikimedia.org/r/455875 (https://phabricator.wikimedia.org/T189702) (owner: 10Aaron Schulz) [19:59:35] (03PS5) 10Krinkle: RELEASE-NOTES: Use New/Changed/Removed pattern for Configuration section [core] - 10https://gerrit.wikimedia.org/r/457000 [20:01:08] 10MediaWiki-extensions-Variables: Make subst:#var work - https://phabricator.wikimedia.org/T201857 (10MGChecker) 05Open>03declined This is interesting, I didn't know about that. I guess this behavior doesn't really come into play if you aren't using extensions that are storing persistent data over a parse.... [20:01:58] 10MediaWiki-extensions-Variables: Don't parse subst:#var before parsing other Variables functions on a page - https://phabricator.wikimedia.org/T201857 (10MGChecker) p:05Triage>03Lowest [20:02:08] (03CR) 10Krinkle: [C: 04-1] Fix escaping order with Language::convert. (031 comment) [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456835 (owner: 10Brian Wolff) [20:02:23] (03PS1) 10Umherirrender: Add EUCopyrightCampaignSkin [skins] - 10https://gerrit.wikimedia.org/r/457001 [20:03:18] 10MediaWiki-extensions-Variables, 10Patch-For-Review: Improve test coverage - https://phabricator.wikimedia.org/T193036 (10MGChecker) p:05High>03Low a:05MGChecker>03None Further tests, perhaps for internal functions as well, would be nice, but aren't a priority right now. [20:03:27] 10MediaWiki-extensions-Variables: Improve test coverage - https://phabricator.wikimedia.org/T193036 (10MGChecker) [20:03:28] (03CR) 10Umherirrender: [V: 032 C: 032] Add EUCopyrightCampaignSkin [skins] - 10https://gerrit.wikimedia.org/r/457001 (owner: 10Umherirrender) [20:05:12] (03PS1) 10Umherirrender: Add EUCopyrightCampaign [extensions] - 10https://gerrit.wikimedia.org/r/457002 [20:05:37] 10AbuseFilter: Fatal exception of type when editing an abuse filter - https://phabricator.wikimedia.org/T203336 (10He7d3r) Same problem happened at https://pt.wikipedia.org/wiki/Especial:Filtro_de_abusos/91 > MediaWiki internal error. > Original exception: [W4rwzQpAAEMAAIGF9IIAAABI] 2018-09-01 20:04:29: Fatal ex... [20:05:50] (03CR) 10Umherirrender: [V: 032 C: 032] Add EUCopyrightCampaign [extensions] - 10https://gerrit.wikimedia.org/r/457002 (owner: 10Umherirrender) [20:10:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/457003 (owner: 10L10n-bot) [20:14:15] (03CR) 10jerkins-bot: [V: 04-1] RELEASE-NOTES: Use New/Changed/Removed pattern for Configuration section [core] - 10https://gerrit.wikimedia.org/r/457000 (owner: 10Krinkle) [20:15:34] (03PS2) 10Krinkle: resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) [20:16:13] (03CR) 10Krinkle: "T182266" [core] - 10https://gerrit.wikimedia.org/r/457000 (owner: 10Krinkle) [20:16:16] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/457000 (owner: 10Krinkle) [20:17:50] (03CR) 10Krinkle: [C: 032] Split AuthManagerAuthPluginUser into a separate file [core] - 10https://gerrit.wikimedia.org/r/456031 (owner: 10Legoktm) [20:18:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/457016 (owner: 10L10n-bot) [20:18:24] (03CR) 10Brian Wolff: "@krinkle LanguageConverter is scary. The parser does call convert as the (almost) last step of the parsing process after everything has be" [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456835 (owner: 10Brian Wolff) [20:19:28] (03CR) 10Krinkle: [C: 032] "Hm.. I see. So the replacement pairs are also html escaped effectively during the parse run? I couldn't find that right away, but OK." [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456835 (owner: 10Brian Wolff) [20:19:49] (03PS6) 10Brian Wolff: Fix html for exceptions during message parsing. [core] - 10https://gerrit.wikimedia.org/r/384927 [20:19:54] <wikibugs> (03CR) 10Krinkle: [C: 032] Fix minor double escaping for phan-taint-check [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/456819 (owner: 10Brian Wolff) [20:24:13] <wikibugs> (03PS4) 10Seb35: Convert DebugMode to use extension registration [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/402627 (https://phabricator.wikimedia.org/T184363) (owner: 10Gabrielchihonglee) [20:24:53] <wikibugs> (03PS1) 10Umherirrender: Add BlueSpiceCalumma [skins] - 10https://gerrit.wikimedia.org/r/457029 [20:25:13] <wikibugs> (03CR) 10Umherirrender: [V: 032 C: 032] Add BlueSpiceCalumma [skins] - 10https://gerrit.wikimedia.org/r/457029 (owner: 10Umherirrender) [20:28:05] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Convert DebugMode to use extension registration [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/402627 (https://phabricator.wikimedia.org/T184363) (owner: 10Gabrielchihonglee) [20:28:32] <wikibugs> (03CR) 10Krinkle: [C: 031] Add api error 'invalidtitle' for invalid category param [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/453432 (https://phabricator.wikimedia.org/T202057) (owner: 10Umherirrender) [20:28:51] <wikibugs> 10MediaWiki-extensions-CategoryTree, 10Core-Platform-Team, 10Patch-For-Review, 10Wikimedia-log-errors: BadMethodCallException from line 98 of ApiCategoryTree.php: Call to a member function getDBkey() on a non-object - https://phabricator.wikimedia.org/T202057 (10Krinkle) [20:29:35] <wikibugs> 10MediaWiki-extensions-CategoryTree, 10Core-Platform-Team, 10Patch-For-Review, 10Wikimedia-log-errors: BadMethodCallException from line 98 of ApiCategoryTree.php: Call to a member function getDBkey() on a non-object - https://phabricator.wikimedia.org/T202057 (10Krinkle) @Umherirrender already started a pa... [20:30:09] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments-Sources, 10Patch-For-Review, 10Wiki-Loves-Monuments (2018): Import UAE monuments into monuments database - https://phabricator.wikimedia.org/T202037 (10Lokal_Profil) This change has been deployed. (Don't know why the task wasn't parsed from the commit... [20:37:20] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [20:37:54] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments-Sources, 10Patch-For-Review, 10Wiki-Loves-Monuments (2018): Import UAE monuments into monuments database - https://phabricator.wikimedia.org/T202037 (10Lokal_Profil) @Saqib I'm going to remove the invalid commonscat entries again as they it will cause... [20:39:02] <wikibugs> (03PS3) 10Krinkle: resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) [20:40:27] <wikibugs> (03Merged) 10jenkins-bot: Split AuthManagerAuthPluginUser into a separate file [core] - 10https://gerrit.wikimedia.org/r/456031 (owner: 10Legoktm) [20:40:29] <wikibugs> (03Merged) 10jenkins-bot: Fix escaping order with Language::convert. [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456835 (owner: 10Brian Wolff) [20:40:31] <wikibugs> (03Merged) 10jenkins-bot: Fix minor double escaping for phan-taint-check [extensions/GoogleCustomWikiSearch] - 10https://gerrit.wikimedia.org/r/456819 (owner: 10Brian Wolff) [20:43:12] <wikibugs> (03CR) 10jenkins-bot: Split AuthManagerAuthPluginUser into a separate file [core] - 10https://gerrit.wikimedia.org/r/456031 (owner: 10Legoktm) [20:48:41] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/457035 (owner: 10L10n-bot) [20:51:39] <wikibugs> (03CR) 10Umherirrender: "Okay, it seems this skin runs phan instead of seccheck, because it does not contains conifg for phan, but for taint-check" [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456994 (owner: 10Libraryupgrader) [20:54:05] <wikibugs> 10AbuseFilter, 10Wikimedia-log-errors: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null (10.64.0.110) - https://phabricator.wikimedia.org/T203336 (10Aklapper) [20:54:23] <wikibugs> (03PS4) 10Krinkle: resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) [20:55:56] <wikibugs> (03PS3) 10Krinkle: Use PSR-4 autoloader for includes/auth/ [core] - 10https://gerrit.wikimedia.org/r/456032 (owner: 10Legoktm) [20:56:00] <wikibugs> (03CR) 10Krinkle: [C: 032] Use PSR-4 autoloader for includes/auth/ [core] - 10https://gerrit.wikimedia.org/r/456032 (owner: 10Legoktm) [20:58:00] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/457037 (owner: 10L10n-bot) [20:59:10] <wikibugs> (03PS1) 10Krinkle: Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/457067 (https://phabricator.wikimedia.org/T203154) [20:59:15] <wikibugs> 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Copyvio: Make Eranbot call PageTriage with copyvio info - https://phabricator.wikimedia.org/T201073 (10eranroz) @Etonkovidova can you please grant EranCopyvioTest this right... [20:59:23] <wikibugs> (03Abandoned) 10Krinkle: Revert "rdbms: Disable DBConnRef::selectDB() for sanity" [core] - 10https://gerrit.wikimedia.org/r/456382 (https://phabricator.wikimedia.org/T203154) (owner: 10Reedy) [20:59:52] <wikibugs> 10MediaWiki-Database, 10MediaWiki-extensions-WikimediaMaintenance, 10Core-Platform-Team, 10Performance-Team, and 2 others: addWiki.php is broken due to "Database selection is disallowed to enable reuse." - https://phabricator.wikimedia.org/T203154 (10Krinkle) a:03aaron [21:00:00] <wikibugs> 10MediaWiki-extensions-WikimediaMaintenance, 10Core-Platform-Team, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: addWiki.php is broken due to "Database selection is disallowed to enable reuse." - https://phabricator.wikimedia.org/T203154 (10Krinkl... [21:02:59] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments-Sources, 10Patch-For-Review, 10Wiki-Loves-Monuments (2018): Import UAE monuments into monuments database - https://phabricator.wikimedia.org/T202037 (10Lokal_Profil) >>! In T202037#4551133, @Lokal_Profil wrote: > @Saqib > I'm going to remove the inval... [21:04:29] <wikibugs> 10AbuseFilter, 10Wikimedia-log-errors: Fatal exception when editing an abuse filter: Error: 1048 Column 'afa_parameters' cannot be null - https://phabricator.wikimedia.org/T203336 (10Reedy) [21:04:46] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/457043 (owner: 10L10n-bot) [21:05:01] <wikibugs> 10WikiApiary: WikiApiary: too many emails about utf8 errors - https://phabricator.wikimedia.org/T202903 (10MarkAHershberger) >>! In T202903#4535050, @MarkAHershberger wrote: > Did this, now seeing if we get more emails. Got more emails, asked @DeepBlue to look into `SET NAMEs 'utf8mb4'` [21:09:56] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/457040 (owner: 10L10n-bot) [21:12:31] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/457046 (owner: 10L10n-bot) [21:15:39] <wikibugs> 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: The wbeditentity API does not support setting aliases to an empty set - https://phabricator.wikimedia.org/T203337 (10Danmichaelo) [21:19:12] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/457049 (owner: 10L10n-bot) [21:19:39] <wikibugs> (03Merged) 10jenkins-bot: Use PSR-4 autoloader for includes/auth/ [core] - 10https://gerrit.wikimedia.org/r/456032 (owner: 10Legoktm) [21:19:49] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [21:21:43] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/457048 (owner: 10L10n-bot) [21:22:16] <wikibugs> (03CR) 10jenkins-bot: Use PSR-4 autoloader for includes/auth/ [core] - 10https://gerrit.wikimedia.org/r/456032 (owner: 10Legoktm) [21:24:36] <wikibugs> 10Wiki-Loves-Monuments-Database: Describe how to get off the categorisation blacklist - https://phabricator.wikimedia.org/T203338 (10Lokal_Profil) [21:24:52] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Solve ErfgoedBot categorisation problem - https://phabricator.wikimedia.org/T174871 (10Lokal_Profil) >>! In T174871#4528302, @Lokal_Profil wrote: > Adding to 2018 since we are likely blacklisting more countries but still haven't pinged organisers... [21:25:08] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Describe how to get off the categorisation blacklist - https://phabricator.wikimedia.org/T203338 (10Lokal_Profil) [21:26:35] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/457051 (owner: 10L10n-bot) [21:30:31] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/457050 (owner: 10L10n-bot) [21:37:41] <wikibugs> (03CR) 10Krinkle: [C: 032] Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/457067 (https://phabricator.wikimedia.org/T203154) (owner: 10Krinkle) [21:40:59] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Describe how to get off the categorisation blacklist - https://phabricator.wikimedia.org/T203338 (10Lokal_Profil) Some quick brainstorming of what causes countries to end up here. * No one in the organising team knows Commons well enough to care a... [21:44:44] <wikibugs> (03Merged) 10jenkins-bot: Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/457067 (https://phabricator.wikimedia.org/T203154) (owner: 10Krinkle) [21:51:06] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) > ++ pip install -r /data/project/heritage/heritage/requirements.txt ``` Exception: Traceback (most recent call last): File "/mnt/nfs/labst... [21:51:54] <wikibugs> 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Copyvio: make it so that all new pages are scanned, regardless of size - https://phabricator.wikimedia.org/T203012 (10eranroz) We can't scan all new pages regardless of the size, for 2 main concerns: many of the edits are minor and this is wa... [21:54:16] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) Oh noes... ``` (.venv)tools.heritage@tools-bastion-03:~$ tail -n 100 -f logs/categorize_images.log 2018-09-01_21:51:49 Categorize images...... [21:54:33] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Lokal_Profil) S**t. So emergency patch changing that first line of the requirements.txt file followed by an upstream task for bumping pip? [21:55:26] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) >>! In T202378#4551192, @Lokal_Profil wrote: > S**t. So emergency patch changing that first line of the requirements.txt file followed by an... [21:56:28] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Lokal_Profil) I'm guessing that second one is because pywikibot didn't update but the change to the new parameter names did? [21:57:01] <wikibugs> (03Abandoned) 10MR70: Users without (2FA) Enabled shouldn't be able to use checkuser rights [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/450292 (https://phabricator.wikimedia.org/T197501) (owner: 10MR70) [21:57:03] <wikibugs> (03Abandoned) 10MR70: Bug: T197501 [core] - 10https://gerrit.wikimedia.org/r/450293 (https://phabricator.wikimedia.org/T197501) (owner: 10MR70) [21:57:32] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) … ``` Installing Python requirements... + pip install -r /data/project/heritage/heritage/requirements.txt Requirement already satisfied (use... [22:02:07] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Lokal_Profil) Have we been doing a local git update to the /pywikbot directory? [22:03:29] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) >>! In T202378#4551198, @Lokal_Profil wrote: > Have we been doing a local git update to the /pywikbot directory? Not sure I follow − everyth... [22:04:51] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Lokal_Profil) From the log at T202378#4551191 it looks like its running `/data/project/heritage/pywikibot/pywikibot/` [22:06:32] <wikibugs> (03PS5) 10Krinkle: resourceloader: Avoid clear/set timer overhead in mw.loader.store.add [core] - 10https://gerrit.wikimedia.org/r/456781 (https://phabricator.wikimedia.org/T202598) [22:07:02] <wikibugs> 10Developer-Advocacy, 10Documentation: Improve documentation on Phab / Gerrit notification settings and mail filtering recommendations - https://phabricator.wikimedia.org/T202153 (10Aklapper) [22:09:10] <wikibugs> (03PS1) 10Legoktm: Configure phan-taint-check-plugin [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/457069 [22:09:12] <wikibugs> (03CR) 10Legoktm: [C: 032] Configure phan-taint-check-plugin [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/457069 (owner: 10Legoktm) [22:11:59] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) Very good call @Lokal_Profil :) I updated pywikibot (`git fetch && git checkout 3.0.20180823`) and things are going through now. Pfew! [22:14:21] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10JeanFred) I totally don’t understand how come that pywkibot is used, but oh well :) [22:16:53] <wikibugs> (03CR) 10Seb35: "The Selenium test fails because of the DebugToolbar in foreground." [extensions/DebugMode] - 10https://gerrit.wikimedia.org/r/402627 (https://phabricator.wikimedia.org/T184363) (owner: 10Gabrielchihonglee) [22:18:09] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Patch-For-Review: Erfgoedbot bot runs triggers lots of 'rvslots' API warnings - https://phabricator.wikimedia.org/T202378 (10Lokal_Profil) >>! In T202378#4551205, @JeanFred wrote: > I totally don’t understand how come that pywkibot is used, but oh well :) Same as on my machi... [22:18:56] <wikibugs> (03Merged) 10jenkins-bot: Configure phan-taint-check-plugin [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/457069 (owner: 10Legoktm) [22:21:00] <wikibugs> 10MediaWiki-extensions-EducationProgram, 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review: Add phan-taint-check-plugin to EducationProgram extension - https://phabricator.wikimedia.org/T202376 (10Legoktm) 05Open>03Resolved [22:22:13] <wikibugs> (03CR) 10jenkins-bot: Configure phan-taint-check-plugin [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/457069 (owner: 10Legoktm) [22:29:23] <wikibugs> 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Spike: How long does it take for a newly created article or draft to be scored by Eranbot/Turnitin - https://phabricator.wikimedia.org/T202914 (10eranroz) I think we should have a UI indicating it hasn't checked yet The time to process is so... [22:48:25] <wikibugs> 10phan-taint-check-plugin: Re-consider value of running phan-taint-check plugin against maintenance scripts - https://phabricator.wikimedia.org/T203340 (10Legoktm) [22:51:19] <wikibugs> 10MediaWiki-extensions-ContactPage, 10phan-taint-check-plugin, 10Security: Default SpecialContact 'FromInfo' has raw HTML message - https://phabricator.wikimedia.org/T200992 (10Legoktm) 05Open>03Resolved a:03Umherirrender 01b2486fcabc9c9dc917b524f9fc904717fbb275 [22:51:23] <wikibugs> 10MediaWiki-extensions-ContactPage, 10phan-taint-check-plugin, 10Security: Default SpecialContact 'FromInfo' has raw HTML message - https://phabricator.wikimedia.org/T200992 (10Legoktm) [22:53:35] <wikibugs> 10MediaWiki-extensions-Other, 10PHP 7.0 support: [CloseWikis] Extension tests fail on PHP 7 - https://phabricator.wikimedia.org/T203329 (10Legoktm) [23:05:10] <wikibugs> 10Wiki-Loves-Monuments (2018): Update stats for WLM 2018 - https://phabricator.wikimedia.org/T203303 (10Superzerocool) Done in Wikimedia Chile server. The link https://stats.wikilovesmonuments.cl it's working again this year! Thank for ping me @Emijrp [23:05:51] <wikibugs> (03CR) 10Krinkle: [C: 04-1] Remove jQuery.inArray usages (031 comment) [core] - 10https://gerrit.wikimedia.org/r/455255 (https://phabricator.wikimedia.org/T200877) (owner: 10Petar.petkovic) [23:09:58] <wikibugs> (03PS1) 10Agabi10: Remove disambiguation pages from Special:AncientPages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/457071 [23:16:44] <wikibugs> 10Wiki-Loves-Monuments-Database, 10Wiki-Loves-Monuments (2018): Describe how to get off the categorisation blacklist - https://phabricator.wikimedia.org/T203338 (10Effeietsanders) I think the reasons should be a bit more constructive :) * The categorization structure does not seem set up (link to documentatio... [23:17:26] <wikibugs> (03PS2) 10Agabi10: Remove disambiguation pages from Special:AncientPages [extensions/Disambiguator] - 10https://gerrit.wikimedia.org/r/457071 (https://phabricator.wikimedia.org/T76287) [23:31:40] <wikibugs> 10Trust-and-Safety, 10Wikimedia-Site-requests: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10VWBot) I sent an email, and it turns out that I'm actually logged in on a second computer that I had forgotten about. So I made a post on my talk page at https://en.wikipedia.org/w/i... [23:34:16] <wikibugs> 10Design, 10TemplateData, 10VisualEditor: Don't show Default, Example and Auto value section of the TemplateData description cell if no information is provided - https://phabricator.wikimedia.org/T125333 (10Agabi10) a:03Agabi10 [23:36:16] <legoktm> I'm playing with CI right now, it's possible stuff will break [23:44:13] <legoktm> 17 minutes -> 10 minutes whee [23:44:13] <wikibugs> 10Wikimedia-Site-requests: Create HiDPI logos for Wikimedia Commons - https://phabricator.wikimedia.org/T203342 (10putnik) [23:45:22] <wikibugs> 10Wikimedia-Site-requests, 10Goal: Ensure all site logos support HiDPI screens to avoid pixelated/blurry look - https://phabricator.wikimedia.org/T37337 (10putnik) [23:45:24] <wikibugs> 10Wikimedia-Site-requests: Create HiDPI logos for Wikimedia Commons - https://phabricator.wikimedia.org/T203342 (10putnik) [23:47:43] <wikibugs> 10Wikimedia-Site-requests: Create HiDPI logos for Russian Wikisource - https://phabricator.wikimedia.org/T203343 (10putnik) [23:47:57] <wikibugs> 10Wikimedia-Site-requests: Create HiDPI logos for Russian Wikisource - https://phabricator.wikimedia.org/T203343 (10putnik) [23:48:06] <wikibugs> 10Wikimedia-Site-requests, 10Goal: Ensure all site logos support HiDPI screens to avoid pixelated/blurry look - https://phabricator.wikimedia.org/T37337 (10putnik) [23:53:31] <wikibugs> (03Restored) 10Legoktm: [DNM] jenkins test [core] - 10https://gerrit.wikimedia.org/r/449662 (owner: 10Legoktm) [23:53:38] <wikibugs> (03PS2) 10Legoktm: [DNM] jenkins test [core] - 10https://gerrit.wikimedia.org/r/449662 [23:54:04] <wikibugs> (03CR) 10Legoktm: "check sqlite" [core] - 10https://gerrit.wikimedia.org/r/449662 (owner: 10Legoktm)