[00:07:47] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team: Copyvio: backfilling on existing pages - https://phabricator.wikimedia.org/T203207 (10MMiller_WMF) [00:08:15] (03CR) 10Tim Starling: "Never mind, getNewTempDirectory() is non-static and wants to automatically delete files on teardown, which wouldn't work here." [core] - 10https://gerrit.wikimedia.org/r/456315 (owner: 10Tim Starling) [00:09:32] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review: New Pages Feed: backfill ORES scores for unscored drafts (3.3) - https://phabricator.wikimedia.org/T198982 (10MMiller_WMF) @SBisson -- just double-check... [00:09:59] 10Readers-Web-Backlog (Design): Add a share button to the mobile site - https://phabricator.wikimedia.org/T181195 (10Jdlrobson) Looks like this might be hitting Safari soon.. https://twitter.com/tomayac/status/1035055755978846208 [00:10:55] 10wikimediafoundation.org, 10Privacy: Third party resources loaded by wikimediafoundation.org - https://phabricator.wikimedia.org/T201022 (10kaldari) >I would still agree that they are a privacy concern if they were third party, but as discussed above, they are not. Got it. Even though they're not "3rd party"... [00:12:24] (03CR) 10Catrope: [C: 032] Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [00:19:08] 10MediaWiki-extensions-OpenStackManager, 10Cloud-Services, 10User-Addshore: Add "GoranSMilovanovic" to labs "bastion" project - https://phabricator.wikimedia.org/T165294 (10bd808) [00:24:04] (03CR) 10Aaron Schulz: [C: 031] resourceloader: Use 'enableModuleContentVersion' for startup module [core] - 10https://gerrit.wikimedia.org/r/456327 (https://phabricator.wikimedia.org/T201686) (owner: 10Krinkle) [00:24:37] (03PS2) 10Aaron Schulz: resourceloader: Use 'enableModuleContentVersion' for startup module [core] - 10https://gerrit.wikimedia.org/r/456327 (https://phabricator.wikimedia.org/T201686) (owner: 10Krinkle) [00:29:32] (03CR) 10Aaron Schulz: [C: 032] Allow tests to run with a non-writable source tree [core] - 10https://gerrit.wikimedia.org/r/456315 (owner: 10Tim Starling) [00:31:42] 10MediaWiki-extensions-ORES, 10ORES-Support-Checklist, 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Change mentions of wp10 to articlequality in products - https://phabricator.wikimedia.org/T203080 (10Catrope) >>! In T203080#4545743, @SBisson wrote: > There's probably config p... [00:33:39] (03Merged) 10jenkins-bot: Drop secondary 'Mvpcf' skin for EmbedPlayer [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/453172 (owner: 10Jforrester) [00:35:04] 10Product-Analytics: Update Audiences page and Key Product Metrics with July 2018 Readers data - https://phabricator.wikimedia.org/T202788 (10Tbayer) [00:48:38] (03Merged) 10jenkins-bot: Allow tests to run with a non-writable source tree [core] - 10https://gerrit.wikimedia.org/r/456315 (owner: 10Tim Starling) [00:51:39] (03CR) 10jenkins-bot: Allow tests to run with a non-writable source tree [core] - 10https://gerrit.wikimedia.org/r/456315 (owner: 10Tim Starling) [00:53:21] 10MediaWiki-extensions-Other, 10BlueSpice, 10Need-volunteer, 10WorkType-Maintenance: [Loops] Fix usage of deprecated ParserLimitReport hook - https://phabricator.wikimedia.org/T203015 (10MGChecker) [00:59:31] (03PS9) 10Catrope: [WIP] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 [01:01:03] (03CR) 10Catrope: [WIP] Add special page with model statistics (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [01:01:24] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [01:03:41] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Patch-For-Review: Audit use of @embed and remove where not needed - https://phabricator.wikimedia.org/T121730 (10Krinkle) ### WikimediaBadges Visual comparison | Before (idle) | After (idle) | After (idle; IE10) |--|--|-- | {F25536584} |{F25536585} | {F... [01:04:03] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [01:06:52] (03CR) 10Krinkle: [C: 04-1] "Per Aaron. LGTM otherwise." [core] - 10https://gerrit.wikimedia.org/r/453091 (https://phabricator.wikimedia.org/T201482) (owner: 10Tim Starling) [01:27:14] (03CR) 10Samwilson: [C: 032] build: Update devDependencies [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456421 (owner: 10Esanders) [01:34:21] (03Merged) 10jenkins-bot: build: Update devDependencies [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456421 (owner: 10Esanders) [01:41:56] 10English-Wikipedia-New-Pages-Patrol, 10Epic, 10Growth-Team (Current Sprint): New Pages Feed: copyvio addition - https://phabricator.wikimedia.org/T199359 (10MMiller_WMF) [01:42:35] (03PS1) 10Krinkle: resourceloader: Reduce memory cost of mw.config.set() [core] - 10https://gerrit.wikimedia.org/r/456525 [01:43:56] (03PS2) 10Krinkle: resourceloader: Reduce memory cost of mw.config.set() [core] - 10https://gerrit.wikimedia.org/r/456525 (https://phabricator.wikimedia.org/T127328) [01:50:04] 10MediaWiki-extensions-Other, 10BlueSpice, 10Need-volunteer, 10WorkType-Maintenance: [Loops] Fix usage of deprecated ParserLimitReport hook - https://phabricator.wikimedia.org/T203015 (10MGChecker) a:03MGChecker I'll provide a patch for this as soon as Loops is converted to extension registration. ([[ ht... [01:51:53] (03PS1) 10Krinkle: resourceloader: Remove redundant '!!' from startup.js [core] - 10https://gerrit.wikimedia.org/r/456526 [02:11:33] 10Wikimedia-Planet, 10monitoring: Add monitoring for planet updating - https://phabricator.wikimedia.org/T203208 (10Legoktm) [02:23:26] (03PS1) 10Krinkle: resourceloader: Use 'this' to access the mw.loader.store internally [core] - 10https://gerrit.wikimedia.org/r/456527 [02:26:27] 10MediaWiki-API, 10Patch-For-Review: Introduce a new "strict-boolean" MediaWiki API parameter type for better validation and semantics? - https://phabricator.wikimedia.org/T203133 (10awight) >>! In T203133#4546475, @Anomie wrote: >>> "strict-boolean" doesn't strike me as a particularly good name either. "Stric... [02:27:10] (03PS1) 10Legoktm: Configure phan-taint-check-plugin [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456529 [02:27:11] (03CR) 10Legoktm: [C: 032] Configure phan-taint-check-plugin [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456529 (owner: 10Legoktm) [02:35:35] (03Merged) 10jenkins-bot: Configure phan-taint-check-plugin [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456529 (owner: 10Legoktm) [02:35:45] 10MediaWiki-API, 10Patch-For-Review: Introduce a new "strict-boolean" MediaWiki API parameter type for better validation and semantics? - https://phabricator.wikimedia.org/T203133 (10Legoktm) I'm +1 to the general concept of this. I do think it will be confusing in the long run to have two boolean types though... [02:43:06] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [02:49:28] (03CR) 10Legoktm: Mark getCachedVersion() as returning HTML escaped content (031 comment) [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/455376 (owner: 10Legoktm) [02:49:58] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [02:54:31] (03CR) 10jenkins-bot: Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [02:54:47] (03PS2) 10Legoktm: Mark getCachedVersion() as returning HTML escaped content [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/455376 [02:54:49] (03PS7) 10Legoktm: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [02:55:51] Krinkle: does https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GoogleNewsSitemap/+/455376 look good to you? [02:55:52] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [02:56:33] (03CR) 10Krinkle: [C: 032] Mark getCachedVersion() as returning HTML escaped content [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/455376 (owner: 10Legoktm) [02:56:37] legoktm: yeah [02:56:41] ty :) [02:57:04] (03PS10) 10Catrope: Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 [02:57:23] (03CR) 10Legoktm: "check experimental" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [02:58:58] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [02:59:26] (03CR) 10Krinkle: "T182266" [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [02:59:30] (03CR) 10Krinkle: [C: 031] "recheck" [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [03:02:15] (03Merged) 10jenkins-bot: Mark getCachedVersion() as returning HTML escaped content [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/455376 (owner: 10Legoktm) [03:02:30] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [03:02:46] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [03:05:05] (03CR) 10Catrope: Add special page with model statistics (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [03:09:35] (03CR) 10Legoktm: [C: 032] "PS7 I rebased onto my @return-taint patch and then removed the @suppress :)" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [03:11:35] foreach ( array_keys( $item ) as $info ) { [03:11:35] if ( $item[$info] != "" ) { [03:11:37] this is a new one [03:12:00] iterate over the keys only and then immediately look up the value?? [03:16:03] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [03:16:38] (03CR) 10jerkins-bot: [V: 04-1] Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [03:17:47] (03PS1) 10Krinkle: resourceloader: Remove module stringification from execute path [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) [03:18:09] 10MediaWiki-General-or-Unknown: Allow parent scope variables to be used in Mustache / TemplateParser - https://phabricator.wikimedia.org/T203209 (10Catrope) [03:18:20] (03PS25) 10Dmaza: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) [03:18:31] (03PS11) 10Catrope: Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 [03:18:36] 10MediaWiki-HTML-Templating: Allow parent scope variables to be used in Mustache / TemplateParser - https://phabricator.wikimedia.org/T203209 (10Legoktm) [03:20:02] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [03:20:05] (03CR) 10Krinkle: Add special page with model statistics (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [03:20:36] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [03:20:40] (03PS1) 10Catrope: TemplateParser: Pass FLAG_MUSTACHELOOKUP to enable parent context access [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) [03:21:33] legoktm: where did you find that? [03:21:50] 10MediaWiki-HTML-Templating, 10Patch-For-Review: Allow parent scope variables to be used in Mustache / TemplateParser - https://phabricator.wikimedia.org/T203209 (10Catrope) >>! In T203209#4547407, @gerritbot wrote: > Change 456533 had a related patch set uploaded (by Catrope; owner: Catrope): > [mediawiki/cor... [03:21:56] Krinkle: E:RSS, RSSParser.php [03:22:06] (03CR) 10Catrope: "See discussion on task about possible performance concerns" [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [03:22:16] trying to track down a phan-taint-check failure... [03:23:00] 10MediaWiki-HTML-Templating: Have TemplateParser use a list of secret keys for authentication - https://phabricator.wikimedia.org/T91138 (10Catrope) [03:24:23] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [03:25:42] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [03:26:37] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove module stringification from execute path [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [03:33:49] (03CR) 10Krinkle: [C: 031] "Aside from performance, another reason for conservative flags here is parity with Mustache.js. Can you check if this is enabled there by d" [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [03:38:38] (03CR) 10jerkins-bot: [V: 04-1] TemplateParser: Pass FLAG_MUSTACHELOOKUP to enable parent context access [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [03:49:59] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10Krinkle) >>! In T203095#4545654, @CCicalese_WMF wrote: >> I'm not sure why this is needed, given the wiki will only have one page, so all pages could use the skin. > > This allows the main... [04:01:57] 10MediaWiki-extensions-RSS, 10I18n: Localising RSS date format - https://phabricator.wikimedia.org/T45521 (10Legoktm) 05Open>03Resolved a:03Wikinaut Linked patch was merged, and AFAICT RSS dates are localized in the current version. [04:03:20] (03CR) 10Dbarratt: [C: 04-1] Add block restriction classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:03:49] 10MediaWiki-extensions-RSS, 10Security, 10Technical-Debt: Extension:RSS shouldn't invent its own way to escape and parse things - https://phabricator.wikimedia.org/T203210 (10Legoktm) [04:04:19] 10MediaWiki-extensions-RSS, 10phan-taint-check-plugin, 10Security: Raw HTML message in RSS extension - https://phabricator.wikimedia.org/T201108 (10Legoktm) 05Open>03Resolved a:03Legoktm Filed T203210 for follow-up on the remaining issue. [04:04:22] 10MediaWiki-extensions-RSS, 10phan-taint-check-plugin, 10Security: Raw HTML message in RSS extension - https://phabricator.wikimedia.org/T201108 (10Legoktm) [04:04:47] (03CR) 10Dmaza: Add block restriction classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:05:27] (03PS6) 10Legoktm: Add phan-taint-check-plugin [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [04:08:34] 10ContentTranslation, 10WorkType-Maintenance: Grayed out link that can't be edited in ContentTranslation - https://phabricator.wikimedia.org/T137339 (10Etonkovidova) 05Open>03Resolved There were some UI improvements for adding/editing missing links in cx2: {F25532827} {F25533033} I am closing this task f... [04:09:49] (03CR) 10Legoktm: [C: 032] "I spent roughly two hours trying to track down the remaining failure and eventually gave up. Filed T203210 because the escaping for this e" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [04:10:36] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 (owner: 10Umherirrender) [04:14:50] 10ContentTranslation: [wmf.19] Inaccurate percentage count for translation - https://phabricator.wikimedia.org/T203201 (10santhosh) Note: This is CX1 translation as per @Etonkovidova [04:15:12] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [04:16:53] (03PS26) 10Dmaza: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) [04:17:08] (03PS2) 10Krinkle: resourceloader: Remove module stringification from execute path [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) [04:18:15] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:19:11] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:19:32] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 (owner: 10Umherirrender) [04:19:35] (03CR) 10Legoktm: [C: 032] "..." [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [04:25:27] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [04:26:26] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [04:32:17] (03PS27) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:34:52] (03PS1) 10Tim Starling: Minor cleanup in backup test cases [core] - 10https://gerrit.wikimedia.org/r/456536 [04:36:07] (03CR) 10Tim Starling: "These are some irrelevant changes backed out of NameTableStoreFactory squashed commit. I set the git author to Daniel." [core] - 10https://gerrit.wikimedia.org/r/456536 (owner: 10Tim Starling) [04:36:45] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [04:41:05] (03CR) 10jenkins-bot: Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [04:42:48] (03PS1) 10Cicalese: Add support for visualeditor-enable user preference. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/456537 [04:48:50] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [04:49:48] (03PS1) 10Legoktm: Set @param-taint for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/456538 [04:56:25] (03PS6) 10Legoktm: Add phan-taint-check-plugin [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [04:56:27] (03PS1) 10Legoktm: Properly escape listings-position message [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 [04:58:22] (03CR) 10Legoktm: "FWIW this was *not* spotted by the phan-taint-check plugin :)" [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 (owner: 10Legoktm) [04:58:25] (03CR) 10jerkins-bot: [V: 04-1] Properly escape listings-position message [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 (owner: 10Legoktm) [04:58:48] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [04:59:13] (03PS2) 10Legoktm: Properly escape listings-position message [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 [04:59:15] (03PS7) 10Legoktm: Add phan-taint-check-plugin [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [04:59:35] (03CR) 10Legoktm: "check experimental" [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [05:03:24] (03PS1) 10Tim Starling: Fix wfDebug() test so that it works with overridden SPI [core] - 10https://gerrit.wikimedia.org/r/456540 [05:15:11] (03PS11) 10Tim Starling: Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) [05:15:13] (03PS1) 10Tim Starling: Reduce memory usage on ServiceContainer destruction [core] - 10https://gerrit.wikimedia.org/r/456541 [05:15:15] (03PS1) 10Tim Starling: Avoid constructing Title objects in data providers [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) [05:15:17] (03PS1) 10Tim Starling: Reset services before every test [core] - 10https://gerrit.wikimedia.org/r/456543 [05:21:33] (03CR) 10jerkins-bot: [V: 04-1] Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [05:28:26] (03PS12) 10Tim Starling: Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) [05:29:43] 10Wiktionary, 10InternetArchiveBot (v2.0): InternetArchiveBot Wiktionary support - https://phabricator.wikimedia.org/T181879 (10jberkel) Bot approval vote [[ https://en.wiktionary.org/w/index.php?title=Wiktionary:Votes/bt-2018-08/User:InternetArchiveBot&diff=50234825&oldid=50234479&diffmode=source | passes 11-... [05:30:02] (03CR) 10jerkins-bot: [V: 04-1] Reset services before every test [core] - 10https://gerrit.wikimedia.org/r/456543 (owner: 10Tim Starling) [05:31:06] (03CR) 10Tim Starling: "These changes were written by Daniel, I set him as the git author. They were split out of Ic0f2d1d94bad9dcc047ff19a1f92db89b7e014ce after " [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [05:36:13] (03CR) 10jerkins-bot: [V: 04-1] Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [05:41:09] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Pamputt) [05:42:26] 10Timeless, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review: Better category handling in Timeless - https://phabricator.wikimedia.org/T160645 (10Pamputt) [05:42:28] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Pamputt) [05:45:27] (03PS2) 10Tim Starling: Reset services before every test [core] - 10https://gerrit.wikimedia.org/r/456543 [05:45:29] (03PS13) 10Tim Starling: Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) [05:51:38] (03CR) 10Brian Wolff: [C: 032] Set @param-taint for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/456538 (owner: 10Legoktm) [05:51:40] (03CR) 10jerkins-bot: [V: 04-1] Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [05:58:41] (03PS2) 10Brian Wolff: Make seccheck-mwext and seccheck-fast-mwext work with skins [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456397 [05:59:17] (03CR) 10Brian Wolff: "> I'm not actually sure about this patch, as it might break support" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456397 (owner: 10Brian Wolff) [06:01:30] (03CR) 10Legoktm: [C: 032] Add support for reading skin.json in addition to extension.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456393 (owner: 10Brian Wolff) [06:02:19] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Evad37) It's working for me on that page: {F25553088} [06:03:51] (03Merged) 10jenkins-bot: Add support for reading skin.json in addition to extension.json [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456393 (owner: 10Brian Wolff) [06:04:10] (03CR) 10Brian Wolff: [C: 032] Properly escape listings-position message [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 (owner: 10Legoktm) [06:04:49] (03CR) 10jerkins-bot: [V: 04-1] Reset services before every test [core] - 10https://gerrit.wikimedia.org/r/456543 (owner: 10Tim Starling) [06:05:35] (03CR) 10jerkins-bot: [V: 04-1] Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [06:06:32] 10phan-taint-check-plugin: phan-taint-check should detect unescaped msg output in Listings but doesn't - https://phabricator.wikimedia.org/T203214 (10Bawolff) [06:11:59] (03CR) 10jerkins-bot: [V: 04-1] Set @param-taint for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/456538 (owner: 10Legoktm) [06:12:52] (03CR) 10Legoktm: [C: 032] "..." [core] - 10https://gerrit.wikimedia.org/r/456538 (owner: 10Legoktm) [06:19:24] 10phan-taint-check-plugin: phan-taint-check should detect unescaped msg output in Listings but doesn't - https://phabricator.wikimedia.org/T203214 (10Bawolff) Seems to be that phan is having trouble with the layer of indirection where the parser tag calls another static function to handle the tag. It correctly d... [06:25:11] (03CR) 10jerkins-bot: [V: 04-1] Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [06:26:38] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Reading-Web-Local-Wiki-Issues: Remove background colors in mobile page issue banners - https://phabricator.wikimedia.org/T202024 (10Ryasmeen) Verified {F25553769} {F25553772} [06:32:26] (03PS1) 10Robert Vogel: Add README and remove files [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 [06:33:53] (03CR) 10jerkins-bot: [V: 04-1] Add README and remove files [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 (owner: 10Robert Vogel) [06:34:48] 10BlueSpice, 10Cleanup, 10Repository-Admins: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) [06:36:28] (03PS14) 10Tim Starling: Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) [06:36:31] (03PS2) 10Robert Vogel: Add README and remove files [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 (https://phabricator.wikimedia.org/T203215) [06:36:53] 10BlueSpice, 10Cleanup, 10Repository-Admins: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) See https://gerrit.wikimedia.org/r/#/c/mediawiki/skins/BlueSpiceSkin/+/456549/ [06:37:05] 10MediaWiki-extensions-RSS, 10phan-taint-check-plugin, 10Security, 10Technical-Debt: Extension:RSS shouldn't invent its own way to escape and parse things - https://phabricator.wikimedia.org/T203210 (10Bawolff) [06:38:00] 10BlueSpice, 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) [06:38:02] 10Audiences-QA, 10MinervaNeue, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), and 2 others: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Ryasmeen) >>! In T197497#4535774, @Jdlrobson wrote: >> Verify section headings are hidden in... [06:38:19] (03Merged) 10jenkins-bot: Properly escape listings-position message [extensions/Listings] - 10https://gerrit.wikimedia.org/r/456539 (owner: 10Legoktm) [06:38:22] (03Merged) 10jenkins-bot: Set @param-taint for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/456538 (owner: 10Legoktm) [06:38:29] 10BlueSpice, 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) [06:39:12] (03CR) 10jerkins-bot: [V: 04-1] Add README and remove files [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 (https://phabricator.wikimedia.org/T203215) (owner: 10Robert Vogel) [06:41:07] (03CR) 10jenkins-bot: Set @param-taint for Parser::internalParse() [core] - 10https://gerrit.wikimedia.org/r/456538 (owner: 10Legoktm) [06:42:27] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [06:43:17] 10BlueSpice, 10Cleanup, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Osnard) [06:45:55] (03CR) 10Thiemo Kreuz (WMDE): "I was thinking along the same lines. Yes, it looks like it's possible that some code feeds things other than strings in here. However, all" (031 comment) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456355 (owner: 10Thiemo Kreuz (WMDE)) [06:46:57] (03PS15) 10Tim Starling: Introduce NameTableStoreFactory [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) [06:48:47] 04(no projects): Change dashboards using navtiming to navtiming2 - https://phabricator.wikimedia.org/T203216 (10Peter) [06:49:08] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/Listings] - 10https://gerrit.wikimedia.org/r/451349 (owner: 10Umherirrender) [06:50:12] (03PS1) 10Thiemo Kreuz (WMDE): Remove not needed "return true" from hook handlers [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456550 [06:50:19] (03CR) 10Legoktm: "Do we want base64_decode to unescape?" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456388 (https://phabricator.wikimedia.org/T202250) (owner: 10Brian Wolff) [06:52:21] (03PS1) 10Aaron Schulz: Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 [06:53:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "I was sure I uploaded this exact same patch yesterday. But "git review" failed, and I didn't noticed. The good thing is, I can +2 this now" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456445 (owner: 10MGChecker) [06:54:14] (03CR) 10Tim Starling: "PS14: now with tests" [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [06:54:16] (03Abandoned) 10Thiemo Kreuz (WMDE): Remove not needed "return true" from hook handlers [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456550 (owner: 10Thiemo Kreuz (WMDE)) [06:56:21] (03CR) 10Thiemo Kreuz (WMDE): "I intentionally did not touched any of the pfObj_… and pf_… functions in this patch. These are the actual parser function hook handlers, a" [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456351 (owner: 10Thiemo Kreuz (WMDE)) [06:56:53] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Bawolff) [07:00:03] (03Merged) 10jenkins-bot: Remove obsolete "return true" from hook handlers [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456445 (owner: 10MGChecker) [07:01:45] (03PS1) 10Jack Phoenix: Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 [07:03:44] (03CR) 10Brian Wolff: [C: 04-1] Version 0.4.7: change message output type (031 comment) [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 (owner: 10Jack Phoenix) [07:07:44] (03CR) 10Robert Vogel: [C: 032] Load user before doing permission check [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/456386 (owner: 10Robert Vogel) [07:07:51] (03PS1) 10Robert Vogel: Load user before doing permission check [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456553 [07:07:59] (03PS2) 10Jack Phoenix: Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 [07:08:01] (03CR) 10Robert Vogel: [C: 032] Load user before doing permission check [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456553 (owner: 10Robert Vogel) [07:08:24] 10Wikispeech, 10Wikispeech-Editor, 10Wikispeech-Player, 10Wikispeech-WMSE: Use OOUI for the player controls - https://phabricator.wikimedia.org/T181780 (10Sebastian_Berlin-WMSE) This means we won't have to add dependencies for FA, which was brought up in [[ https://gerrit.wikimedia.org/r/c/mediawiki/extens... [07:08:59] (03Merged) 10jenkins-bot: Load user before doing permission check [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/456386 (owner: 10Robert Vogel) [07:09:09] (03Merged) 10jenkins-bot: Load user before doing permission check [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456553 (owner: 10Robert Vogel) [07:10:27] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Daimona) [07:11:28] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Legoktm) [07:11:30] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Daimona) @Raymond the `abusefilter-edit-builder-vars-article-views` message fro... [07:12:03] (03CR) 10jenkins-bot: Load user before doing permission check [extensions/NSFileRepo] (REL1_27) - 10https://gerrit.wikimedia.org/r/456386 (owner: 10Robert Vogel) [07:12:18] (03CR) 10Brian Wolff: Version 0.4.7: change message output type (031 comment) [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 (owner: 10Jack Phoenix) [07:12:37] (03CR) 10jenkins-bot: Load user before doing permission check [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456553 (owner: 10Robert Vogel) [07:13:37] (03PS1) 10Aaron Schulz: Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456554 (https://phabricator.wikimedia.org/T203154) [07:14:40] (03PS2) 10Thiemo Kreuz (WMDE): Execute expand as late as possible [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456346 [07:14:56] (03CR) 10jenkins-bot: Load user before doing permission check [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456553 (owner: 10Robert Vogel) [07:15:37] (03PS6) 10Sebastian Berlin (WMSE): Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) [07:15:43] (03CR) 10jerkins-bot: [V: 04-1] Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [07:15:45] (03CR) 10jerkins-bot: [V: 04-1] Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [07:15:58] (03CR) 10Thiemo Kreuz (WMDE): "As with the other patch where we discussed this, this change here can also make actual wiki pages behave differently. That's true. However" (031 comment) [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456346 (owner: 10Thiemo Kreuz (WMDE)) [07:18:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix case of description message and url [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/456441 (owner: 10Umherirrender) [07:19:16] (03PS3) 10Jack Phoenix: Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 [07:24:49] (03Merged) 10jenkins-bot: Fix case of description message and url [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/456441 (owner: 10Umherirrender) [07:24:58] (03CR) 10Daimona Eaytoy: "> I'm sorry, I don't know how it should work. Maybe?" [core] - 10https://gerrit.wikimedia.org/r/445999 (owner: 10Daimona Eaytoy) [07:27:44] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): CX2: Bullet points are missing when rendered inside Content Translation - https://phabricator.wikimedia.org/T202441 (10Pginer-WMF) 05Open>03Resolved I tried the example article in produc... [07:31:44] (03PS1) 10Legoktm: SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 [07:31:47] (03PS1) 10Legoktm: Suppress phan-taint-check warnings in job debugging [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 [07:31:50] (03PS1) 10Legoktm: Add a FIXME for double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 [07:31:53] (03PS1) 10Legoktm: Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 [07:32:16] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10WMF-Legal: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871 (10Gilles) Ah, indeed, but that's probably just an accident that an XMP field has that name. The original task description mentions ImageDesc... [07:32:45] (03CR) 10Brian Wolff: [C: 04-1] Version 0.4.7: change message output type (031 comment) [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 (owner: 10Jack Phoenix) [07:33:49] (03PS4) 10Jack Phoenix: Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 [07:34:54] (03CR) 10Aaron Schulz: "I made https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikimediaMaintenance/+/456554/ instead" [core] - 10https://gerrit.wikimedia.org/r/456382 (https://phabricator.wikimedia.org/T203154) (owner: 10Reedy) [07:35:26] (03PS1) 10Daimona Eaytoy: Update AbuseFilter hook signature [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/456562 [07:37:33] (03PS1) 10Jack Phoenix: Linker -> LinkRenderer [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456563 [07:38:33] (03PS3) 10Nikerabbit: resourceloader: Reduce memory cost of mw.config.set() [core] - 10https://gerrit.wikimedia.org/r/456525 (https://phabricator.wikimedia.org/T127328) (owner: 10Krinkle) [07:38:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "As argued before I would like us to update the RELEASE-NOTES file, which already exists in this codebase. But we can do this any time late" (032 comments) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455174 (https://phabricator.wikimedia.org/T202679) (owner: 10MGChecker) [07:40:08] (03CR) 10Legoktm: [C: 032] Linker -> LinkRenderer [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456563 (owner: 10Jack Phoenix) [07:43:38] (03CR) 10Brian Wolff: [C: 032] Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 (owner: 10Jack Phoenix) [07:45:16] (03PS1) 10Daimona Eaytoy: Use the right prefix for AbuseFilter variables! [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/456564 (https://phabricator.wikimedia.org/T173889) [07:47:10] (03Merged) 10jenkins-bot: Linker -> LinkRenderer [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456563 (owner: 10Jack Phoenix) [07:47:29] (03CR) 10Brian Wolff: "I'm unsure if this is safe if $wgRunJobsAsync = false; $wgJobRunRate > 0 and register_postsend_function() is not available and fastcgi_fin" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [07:50:05] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Reading-Web-Local-Wiki-Issues: Remove background colors in mobile page issue banners - https://phabricator.wikimedia.org/T202024 (10ovasileva) 05Open>03Resolved Looks good, thanks all! [07:50:10] (03Merged) 10jenkins-bot: Version 0.4.7: change message output type [extensions/ShoutWikiAds] - 10https://gerrit.wikimedia.org/r/456552 (owner: 10Jack Phoenix) [07:50:20] 10MediaWiki-extensions-HitCounters, 10AbuseFilter, 10Growth-Team, 10StructuredDiscussions, and 3 others: Rename article_ and _(prefixed)text variables to page_ and _(prefixed)title - https://phabricator.wikimedia.org/T173889 (10Daimona) [07:51:24] 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Begin webpack + test transition of mobile.startup - https://phabricator.wikimedia.org/T203100 (10ovasileva) [07:51:45] (03PS5) 10Daimona Eaytoy: Remove workaround to complete phase 1 of variables migration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/454279 (https://phabricator.wikimedia.org/T173889) [07:52:04] 10MinervaNeue, 10MobileFrontend, 10Easy, 10Need-volunteer, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Bug: Thumbnails are incorrectly given the view-border-box class causing a minor on-load reflow (FOUC) - https://phabricator.wikimedia.org/T202701 (10ovasileva) [07:52:30] 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1), 10Technical-Debt: Simplify CategoryOverlay for readability - https://phabricator.wikimedia.org/T191987 (10ovasileva) [07:56:14] (03PS1) 10Jack Phoenix: Escaping fixes and stuff [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 [07:57:56] (03PS4) 10Daimona Eaytoy: Update AbuseFilter hook for user_mobile variable [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456408 (https://phabricator.wikimedia.org/T203166) [08:02:53] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Good job!" (031 comment) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/456438 (owner: 10Umherirrender) [08:06:22] (03PS7) 10Sebastian Berlin (WMSE): Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) [08:07:22] (03PS4) 10Robert Vogel: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 [08:07:49] (03CR) 10jerkins-bot: [V: 04-1] Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [08:08:29] (03CR) 10Robert Vogel: Initial commit (034 comments) [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [08:10:17] (03PS8) 10Sebastian Berlin (WMSE): Add preference for speech rate [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) [08:13:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Check return of preg_match before processing matches (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/453534 (https://phabricator.wikimedia.org/T123258) (owner: 10Umherirrender) [08:13:29] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [08:13:43] (03CR) 10Brian Wolff: [C: 04-1] Escaping fixes and stuff (032 comments) [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 (owner: 10Jack Phoenix) [08:14:33] (03CR) 10Brian Wolff: [C: 04-1] "check experimental" [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 (owner: 10Jack Phoenix) [08:15:21] (03CR) 10Sebastian Berlin (WMSE): [C: 04-1] "> Patch Set 5:" (033 comments) [extensions/Wikispeech] - 10https://gerrit.wikimedia.org/r/427325 (https://phabricator.wikimedia.org/T133686) (owner: 10Sebastian Berlin (WMSE)) [08:21:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Good job!" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456464 (owner: 10Umherirrender) [08:24:57] (03Merged) 10jenkins-bot: Split long lines over 140 chars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/456438 (owner: 10Umherirrender) [08:25:00] (03Merged) 10jenkins-bot: Check return of preg_match before processing matches [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/453534 (https://phabricator.wikimedia.org/T123258) (owner: 10Umherirrender) [08:29:15] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles can the everyday Wikipedia user such as myself help in the process of purging these PNGs? The us... [08:30:41] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) That's action=purge yes. After you've done that, you need to make sure that you clear your browser cache or to shif... [08:33:14] (03CR) 10jenkins-bot: Split long lines over 140 chars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/456438 (owner: 10Umherirrender) [08:33:15] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles I should also clarify, just as I had already said earlier, the opaque backgrounds still appear e... [08:36:14] 10CommRel-Internals: Submit the team's proposal for CE Insights in September - https://phabricator.wikimedia.org/T202436 (10Qgil) p:05Triage>03High The deadline is today. Maybe it has been submitted, maybe not. @Whatamidoing-WMF please confirm. [08:37:17] (03PS2) 10Jack Phoenix: Escaping fixes and stuff [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 [08:38:23] (03CR) 10Brian Wolff: [C: 032] Escaping fixes and stuff [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 (owner: 10Jack Phoenix) [08:38:29] 10Wikimedia-Hackathon-2018: Discuss property creation on Wikidata for Structured Data on Commons - https://phabricator.wikimedia.org/T194933 (10Elitre) (Work on this task was evaluated in Q4.) [08:39:12] (03CR) 10jenkins-bot: Check return of preg_match before processing matches [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/453534 (https://phabricator.wikimedia.org/T123258) (owner: 10Umherirrender) [08:41:53] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10WMF-Legal: Include at least some EXIF metadata in resized pictures - https://phabricator.wikimedia.org/T20871 (10Gilles) [08:42:17] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Aklapper) >>! In T198370#4547673, @PhilipTerryGraham wrote: > @Gilles I should also clarify, just as I had already said ear... [08:43:03] 10Mitmachen: Discuss where users should go for help (footer text) - https://phabricator.wikimedia.org/T199598 (10sonkiki) I got the text for the template from @Jan_Dittrich. Thank you Jan! ---- Jan has this form currently [[ https://phabricator.wikimedia.org/maniphest/task/edit/form/1/?description=%0A**User%20... [08:44:00] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:44:19] 10Page-Previews, 10Readers-Community-Engagement, 10CommRel-Specialists-Support (Jul-Sep-2018), 10Readers-Web-Backlog (Tracking): Inform enwiki and dewiki communities of feature improvements to Page Previews, then discuss upcoming feature release - https://phabricator.wikimedia.org/T182317 (10Elitre) Work o... [08:46:02] (03PS9) 10Daimona Eaytoy: Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) [08:47:26] (03Merged) 10jenkins-bot: Split long lines over 140 chars [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456464 (owner: 10Umherirrender) [08:48:28] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Aklapper Firefox Nightly 63.0, Windows 10 version 1803, Ctrl+F5 doesn't work either; I've been trying o... [08:48:39] (03PS1) 10Gilles: Preserve EXIF ImageDescription instead of XMP Description [vagrant] - 10https://gerrit.wikimedia.org/r/456577 (https://phabricator.wikimedia.org/T20871) [08:48:55] 04(no projects): Add "Tag-android app edit" and "Tag-ios app edit" to i18n - https://phabricator.wikimedia.org/T203223 (10A2093064) [08:50:11] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10Gilles) Ah, you need to purge the file itself, not the article it appears in. I.e. https://en.wikipedia.org/wiki/File:Micro... [08:50:54] (03CR) 10Gilles: [C: 032] Preserve EXIF ImageDescription instead of XMP Description [vagrant] - 10https://gerrit.wikimedia.org/r/456577 (https://phabricator.wikimedia.org/T20871) (owner: 10Gilles) [08:52:05] (03Merged) 10jenkins-bot: Preserve EXIF ImageDescription instead of XMP Description [vagrant] - 10https://gerrit.wikimedia.org/r/456577 (https://phabricator.wikimedia.org/T20871) (owner: 10Gilles) [08:53:34] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10PhilipTerryGraham) @Gilles This works! Thanks for the tip; I'll go ahead and purge as many PNGs as I can! [08:55:33] (03Merged) 10jenkins-bot: Escaping fixes and stuff [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/456570 (owner: 10Jack Phoenix) [08:55:58] (03CR) 10jenkins-bot: Preserve EXIF ImageDescription instead of XMP Description [vagrant] - 10https://gerrit.wikimedia.org/r/456577 (https://phabricator.wikimedia.org/T20871) (owner: 10Gilles) [09:04:43] (03CR) 10jenkins-bot: Split long lines over 140 chars [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456464 (owner: 10Umherirrender) [09:10:49] 04(no projects): Add "Tag-android app edit" and "Tag-ios app edit" to i18n - https://phabricator.wikimedia.org/T203223 (10Aklapper) @A2093064: Please associate at least one [[ https://phabricator.wikimedia.org/project/query/G9vp6zKs.IfE/#R | project ]] with this task. This will allow others to find this task wh... [09:14:28] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [09:16:04] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)): CX2: Reduce duplicate code between trackers for issues and content modifications - https://phabricator.wikimedia.org/T200251 (10Petar.petkovic) [09:18:12] (03CR) 10Robert Vogel: [C: 032] Moved initialization to new Foundation class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/455844 (owner: 10Pwirth) [09:20:19] 10Extension-MobileApp, 10Wikipedia-Android-App-Backlog: Add "Tag-android app edit" and "Tag-ios app edit" to i18n - https://phabricator.wikimedia.org/T203223 (10A2093064) [09:23:27] 10MediaWiki-extensions-Translate, 10Wikimedia-log-errors: TranslateRenderJob.php: Cannot render translation page - https://phabricator.wikimedia.org/T200417 (10Pginer-WMF) [09:24:23] 10UniversalLanguageSelector, 10Patch-For-Review, 10Technical-Debt: ULS is using deprecated 'mediawiki.api.options' in code - https://phabricator.wikimedia.org/T200168 (10Pginer-WMF) [09:25:32] (03Merged) 10jenkins-bot: Moved initialization to new Foundation class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/455844 (owner: 10Pwirth) [09:28:55] (03PS5) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [09:29:46] (03PS6) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [09:35:42] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [09:40:57] 10ContentTranslation, 10Language-2018-July-September: Make the PHP classes testable - https://phabricator.wikimedia.org/T203225 (10santhosh) [09:44:33] (03PS6) 10Sharvaniharan: [WIP] Show in progress activity when an article in a reading list is being downloaded for offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) [09:47:02] (03PS1) 10Brian Wolff: Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) [09:49:03] (03PS1) 10Brian Wolff: Change @return-taint to use onlysafefor_html instad of escapes_html [core] - 10https://gerrit.wikimedia.org/r/456582 (https://phabricator.wikimedia.org/T202797) [09:49:40] 10Library-Card-Platform: Ensure that renewals from partner pages attempt to renew the correct (latest) application. - https://phabricator.wikimedia.org/T203164 (10Samwalton9) [09:51:09] 10MediaWiki-extensions-Translate, 10phan-taint-check-plugin, 10User-Nikerabbit: Add phan-taint-check-plugin to Translate extension - https://phabricator.wikimedia.org/T202379 (10Bawolff) Once https://gerrit.wikimedia.org/r/#/c/mediawiki/tools/phan/SecurityCheckPlugin/+/456581/ and https://gerrit.wikimedia.or... [09:54:43] 10Library-Card-Platform: Add support for access code tracking - https://phabricator.wikimedia.org/T202615 (10Samwalton9) [09:56:14] 10Property-P906, 10WMSE-Library-Data-2018: Duplicated LIBRIS values - https://phabricator.wikimedia.org/T202652 (10Lokal_Profil) Since it is not directly part of the funded project at this point [09:58:16] (03PS1) 10Brian Wolff: Fix error in argument handling in test script [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456583 [10:04:01] 10I18n, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Deskana) Needs urgent attention. [10:04:36] 10I18n, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Deskana) @Ryasmeen We should figure out how this slipped through QA. [10:04:41] (03CR) 10Brian Wolff: [C: 032] Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 (owner: 10Legoktm) [10:06:39] 10Library-Card-Platform: Provide a link or form for suggesting new partners - https://phabricator.wikimedia.org/T201156 (10Samwalton9) After the access code PR (T202615) has gone through we can pull this to staging for review. [10:06:50] (03CR) 10Brian Wolff: "I think the double escaping is correct here, so maybe it shouldn't be marked as FIXME (TMH is putting a blob of html in an attribute for l" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 (owner: 10Legoktm) [10:07:33] (03CR) 10Brian Wolff: [C: 032] SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 (owner: 10Legoktm) [10:08:29] 10MediaWiki-Gallery, 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: "Slideshow" mode for gallery doesn't look like a slideshow when editing - https://phabricator.wikimedia.org/T151471 (10Deskana) p:05Normal>03Low [10:09:14] (03PS4) 10Seb35: Empty Monolog loggers are now real blackholes [core] - 10https://gerrit.wikimedia.org/r/439870 (https://phabricator.wikimedia.org/T196906) [10:09:35] (03PS5) 10Seb35: Define a default Monolog logger if inexistant [core] - 10https://gerrit.wikimedia.org/r/439874 (https://phabricator.wikimedia.org/T196906) [10:10:49] 10Design, 10Multimedia, 10VisualEditor: Make it clear in VE (hover state?) when a media file is being dragged in that shows it will do something - https://phabricator.wikimedia.org/T115859 (10Deskana) p:05Normal>03Low [10:11:28] (03CR) 10Brian Wolff: [C: 032] "Merging this as it fixes most of the things. The remaining thing that the inline comments are about could be fixed in a follow-up" (031 comment) [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/453909 (owner: 10Legoktm) [10:12:48] 10MediaWiki-Gallery, 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-Media: Images in galleries are scaled up, instead of being re-fetched at the correct size - https://phabricator.wikimedia.org/T151551 (10Deskana) p:05Normal>03Low [10:12:51] 10Design, 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Insert image in content immediately after it's uploaded, skipping the "General settings" step - https://phabricator.wikimedia.org/T115865 (10Deskana) p:05Normal>03Low [10:13:01] 10Library-Card-Platform: Add support for access code tracking - https://phabricator.wikimedia.org/T202615 (10Samwalton9) [10:15:31] (03CR) 10Seb35: "recheck" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:15:41] (03CR) 10jerkins-bot: [V: 04-1] Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:15:42] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata-Campsite, and 2 others: Beta feature for constraint suggestions - https://phabricator.wikimedia.org/T202712 (10Jonas) [10:16:04] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata-Campsite, and 2 others: Beta feature for constraint suggestions - https://phabricator.wikimedia.org/T202712 (10Jonas) I put the patch for enabling it on beta to the European Mid-day SWAT on Monday, September 03 [10:19:23] (03CR) 10Daniel Kinzler: "Thanks for finding this, Tim! As often, it seems so obvious in retrospect. But I completely failed to put together the pieces in my mind." [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [10:20:04] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [10:20:15] (03CR) 10Daniel Kinzler: "We have a phab task that would probably be obsoleted by this:" [core] - 10https://gerrit.wikimedia.org/r/456543 (owner: 10Tim Starling) [10:21:23] (03CR) 10Daniel Kinzler: Reduce memory usage on ServiceContainer destruction (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456541 (owner: 10Tim Starling) [10:22:35] (03Merged) 10jenkins-bot: SpecialOrphanedTimedText: Remove some dead code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456556 (owner: 10Legoktm) [10:22:37] (03Merged) 10jenkins-bot: Fix most instances of raw HTML messages [extensions/NewsBox] - 10https://gerrit.wikimedia.org/r/453909 (owner: 10Legoktm) [10:22:52] 10Developer-Advocacy (Jul-Sep 2018), 10Google-Code-in-2018: Apply as an organization for Google Code-in 2018 between 2018-09-06 and 2018-09-17 - https://phabricator.wikimedia.org/T203229 (10Aklapper) p:05Triage>03High [10:23:56] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Bawolff) What are we planning to blackout for? [10:24:03] 10Developer-Advocacy (Jul-Sep 2018), 10Google-Code-in-2018: Recruit Google Code-in 2018 mentors - https://phabricator.wikimedia.org/T203230 (10Aklapper) p:05Triage>03Normal [10:24:09] 10MediaWiki-extensions-Variables: Make subst:#var work - https://phabricator.wikimedia.org/T201857 (10thiemowmde) I'm not that much of an expert, but from all I know about the parser it works in two passes. Parser functions prefixed with `subst:` are processed in an earlier, entirely separate pass than then ones... [10:25:49] 10Developer-Advocacy (Jul-Sep 2018), 10Google-Code-in-2018: Find Google Code-in co-admins - https://phabricator.wikimedia.org/T203231 (10Aklapper) p:05Triage>03High [10:26:12] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) >>! In T203228#4547923, @Bawolff wrote: > What are we planning to blackout for? @Bawolff Nothing. But I guess this exten... [10:27:10] 10Developer-Advocacy, 10Google-Code-in-2018: Organize/ prepare content for an informational google hangout session for new Google Code-In mentors - https://phabricator.wikimedia.org/T203232 (10Aklapper) p:05Triage>03Low [10:27:11] (03CR) 10Daniel Kinzler: [C: 031] "Since this is code I wrote for Ic0f2d1d94bad9d in PS6, i can only give a +1 on this. But by the same token, I think it's ok for Tim to giv" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [10:28:41] (03PS3) 10Seb35: Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:28:50] (03CR) 10jerkins-bot: [V: 04-1] Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:30:41] 10phan-taint-check-plugin: phan-taint-check should detect unescaped msg output in Listings but doesn't - https://phabricator.wikimedia.org/T203214 (10Bawolff) This appears to be a regression caused by 303c9e09cac If I checkout 303c9e09cac^ I get ``` ./Listings.body.php:23 SecurityCheck-XSS Outputting user cont... [10:31:02] 10MediaWiki-extensions-Other, 10Security-Reviews: Security review ... - https://phabricator.wikimedia.org/T203233 (10Daimona) [10:31:35] 10MediaWiki-extensions-Other, 10Security-Reviews: Security review Extension:Blackout - https://phabricator.wikimedia.org/T203233 (10Daimona) [10:31:47] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [10:31:49] 10MediaWiki-extensions-Other, 10Security-Reviews: Security review Extension:Blackout - https://phabricator.wikimedia.org/T203233 (10Daimona) [10:32:01] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [10:33:45] (03PS1) 10Seb35: Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456591 (https://phabricator.wikimedia.org/T201491) [10:33:55] (03CR) 10jerkins-bot: [V: 04-1] Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456591 (https://phabricator.wikimedia.org/T201491) (owner: 10Seb35) [10:35:43] (03CR) 10Seb35: "I tried creating another Gerrit change on I0f2f7e688d9b1a10ac47718abfcf5176cbbd9065, but it doesn’t work either -- I abandon this other on" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:36:00] (03Abandoned) 10Seb35: Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456591 (https://phabricator.wikimedia.org/T201491) (owner: 10Seb35) [10:37:50] (03CR) 10Daniel Kinzler: [MCR][WIP] Move getSecondaryDataUpdates to the page level (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456204 (owner: 10Gergő Tisza) [10:38:19] (03Abandoned) 10Daniel Kinzler: MCR WIP Replace calls to Content::getSecondaryDataUpdates [core] - 10https://gerrit.wikimedia.org/r/456182 (https://phabricator.wikimedia.org/T194043) (owner: 10Daniel Kinzler) [10:38:22] 10Library-Card-Platform-Discovery: Integrate Unpaywall oaDOI links or dissem.in free-to-read users - https://phabricator.wikimedia.org/T178469 (10martin.monperrus) 05Open>03Resolved a:03martin.monperrus Duplicate of T174540? [10:38:25] (03Abandoned) 10Daniel Kinzler: [MCR][DNM] Replace calls to Content::getSecondaryDataUpdates [core] - 10https://gerrit.wikimedia.org/r/418075 (https://phabricator.wikimedia.org/T194037) (owner: 10Daniel Kinzler) [10:39:14] 10Library-Card-Platform-Discovery: Consider integration of an OA link resolver - https://phabricator.wikimedia.org/T166224 (10martin.monperrus) Duplicate of T174540? [10:39:38] 10Library-Card-Platform-Discovery: Integrate Unpaywall oaDOI links or dissem.in free-to-read users - https://phabricator.wikimedia.org/T178469 (10martin.monperrus) Something happened, I didn't mean to change this task' s status. [10:40:23] (03PS4) 10Agabi10: Add a hook to allow changing the query of Special:AncientPages in extensions [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) [10:40:34] 10MediaWiki-extensions-Other, 10Performance-Team: Performance review for Extension:Blackout - https://phabricator.wikimedia.org/T203236 (10Daimona) [10:40:49] (03CR) 10Brian Wolff: Refactor: add on-wiki configuration (034 comments) [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [10:40:59] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [10:41:01] 10MediaWiki-extensions-Other, 10Performance-Team: Performance review for Extension:Blackout - https://phabricator.wikimedia.org/T203236 (10Daimona) [10:41:50] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Bawolff) Well I agree that having things ready for a blackout ahead of time would be very nice (Cough last minute review of EUCopy... [10:42:37] 10I18n, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Amire80) >>! In T203213#4547836, @Deskana wrote: > Needs urgent attention. Thanks for confirming! :) >>! In T203213#4547838, @Deskana wrote: > @Ryasmeen We sho... [10:42:42] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [10:45:10] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Fix the jump when opening the mobile context - https://phabricator.wikimedia.org/T96289 (10Deskana) p:05Normal>03Low [10:45:49] (03CR) 10Gergő Tisza: [C: 04-1] "Per IRL discussion with Daniel:" [core] - 10https://gerrit.wikimedia.org/r/456204 (owner: 10Gergő Tisza) [10:46:14] 10Design, 10VisualEditor, 10VisualEditor-MediaWiki-Mobile: Come up with a way to move/remove/duplicate focusable nodes in mobile - https://phabricator.wikimedia.org/T101113 (10Deskana) p:05Normal>03Low [10:47:08] (03PS1) 10ItSpiderman: Bugfixes on A/C [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456594 [10:47:20] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) >>! In T203228#4548082, @Bawolff wrote: > Well I agree that having things ready for a blackout ahead of time would be ver... [10:48:45] (03PS13) 10Gergő Tisza: Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [10:50:27] (03PS1) 10Daniel Kinzler: Add test for {{subst:REVISIONUSER}} [core] - 10https://gerrit.wikimedia.org/r/456595 [10:50:40] 10Design, 10MediaWiki-User-preferences, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: Re-design the Editing preferences to make it easier to pick the editing environment that you want to use - https://phabricator.wikimedia.org/T202921 (10Deskana) I discussed this with Jess today and we went... [10:50:48] 10Library-Card-Platform-Discovery: Integrate Unpaywall oaDOI links or dissem.in free-to-read users - https://phabricator.wikimedia.org/T178469 (10Samwalton9) 05Resolved>03Open a:05martin.monperrus>03None [10:51:07] (03PS10) 10Jdrewniak: Update package.json to ensure assets get built on every commit [extensions/Popups] - 10https://gerrit.wikimedia.org/r/456028 (https://phabricator.wikimedia.org/T202748) (owner: 10Jdlrobson) [10:51:11] 10Design, 10Android-app-feature-Description-Editing, 10Design-Research, 10VisualEditor, 10Wikipedia-Android-App-Backlog: What are the current best UI practices for mobile editing? - https://phabricator.wikimedia.org/T201877 (10Deskana) p:05Triage>03Normal [10:51:39] (03CR) 10Jdrewniak: "just removing extra white-space" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/456028 (https://phabricator.wikimedia.org/T202748) (owner: 10Jdlrobson) [10:56:53] (03PS10) 10Daimona Eaytoy: Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) [10:57:22] (03CR) 10Daimona Eaytoy: ">" (034 comments) [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [10:57:27] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [10:57:31] (03CR) 10Mglaser: [C: 032] Bugfixes on A/C [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456594 (owner: 10ItSpiderman) [10:57:34] 10Developer-Advocacy (Jul-Sep 2018), 10Google-Code-in-2018: Organize and coordinate Wikimedia's participation in Google Code-In 2018 - https://phabricator.wikimedia.org/T203200 (10Aklapper) [10:57:58] 10MediaWiki-extensions-Other, 10Security-Reviews: Security review Extension:Blackout - https://phabricator.wikimedia.org/T203233 (10Daimona) [10:58:04] (03Merged) 10jenkins-bot: Bugfixes on A/C [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456594 (owner: 10ItSpiderman) [10:58:09] 10MediaWiki-extensions-Other, 10Performance-Team: Performance review for Extension:Blackout - https://phabricator.wikimedia.org/T203236 (10Daimona) [10:58:12] (03CR) 10jerkins-bot: [V: 04-1] Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [10:58:22] (03CR) 10Gergő Tisza: [C: 032] "Looks good and works in manual testing (including subst)." [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:00:36] (03CR) 10jerkins-bot: [V: 04-1] Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [11:03:20] (03CR) 10Tim Starling: "> Patch Set 15:" [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [11:04:32] (03CR) 10Mglaser: "recheck" [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 (https://phabricator.wikimedia.org/T203215) (owner: 10Robert Vogel) [11:05:40] (03CR) 10jerkins-bot: [V: 04-1] Add README and remove files [skins/BlueSpiceSkin] - 10https://gerrit.wikimedia.org/r/456549 (https://phabricator.wikimedia.org/T203215) (owner: 10Robert Vogel) [11:06:03] (03CR) 10Gergő Tisza: "Related: T194029" [core] - 10https://gerrit.wikimedia.org/r/456595 (owner: 10Daniel Kinzler) [11:06:26] (03PS1) 10Brian Wolff: Add an indirect test case to taghook test [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456597 [11:07:08] (03PS2) 10Brian Wolff: Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) [11:07:45] (03CR) 10jerkins-bot: [V: 04-1] Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) (owner: 10Brian Wolff) [11:09:11] 10MediaWiki-extensions-ORES, 10ORES-Support-Checklist, 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Change mentions of wp10 to articlequality in products - https://phabricator.wikimedia.org/T203080 (10Ladsgroup) >>! In T203080#4547340, @Catrope wrote: >>>! In T203080#4545743,... [11:13:23] (03CR) 10Jdrewniak: [C: 032] Add for CSS background image (sprite.svg) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456462 (https://phabricator.wikimedia.org/T203187) (owner: 10Krinkle) [11:14:52] (03CR) 10Zoranzoki21: "recheck" [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:15:02] (03CR) 10jerkins-bot: [V: 04-1] Fix 'accross' typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:15:07] (03CR) 10Gergő Tisza: [C: 032] Add test for {{subst:REVISIONUSER}} [core] - 10https://gerrit.wikimedia.org/r/456595 (owner: 10Daniel Kinzler) [11:15:23] (03CR) 10Gergő Tisza: [C: 032] Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:15:30] (03Merged) 10jenkins-bot: Add for CSS background image (sprite.svg) [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456462 (https://phabricator.wikimedia.org/T203187) (owner: 10Krinkle) [11:16:00] (03CR) 10Zoranzoki21: "> I tried creating another Gerrit change on I0f2f7e688d9b1a10ac47718abfcf5176cbbd9065," [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:16:52] (03PS15) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [11:16:57] (03PS16) 10Zoranzoki21: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) [11:17:31] (03CR) 10Zoranzoki21: Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:18:39] 10MediaWiki-extensions-MediaWikiFarm: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) - https://phabricator.wikimedia.org/T202224 (10Zoranzoki21) I really no know why zuul so much boring with https://gerrit.wikimedia.org/r/#/c/wikidata/query/gui/+/431713/ [11:21:34] 10QRpedia-General: Apostrophes in URL titles causing problems - https://phabricator.wikimedia.org/T62526 (10Aklapper) a:05Kelson>03None [11:21:36] 10QRpedia-General, 10I18n: QRpedia web site should be localized - https://phabricator.wikimedia.org/T60204 (10Aklapper) a:05Kelson>03None [11:21:38] 10QRpedia-General: Make statistic related code optional (plugin) - https://phabricator.wikimedia.org/T53869 (10Aklapper) a:05Kelson>03None [11:21:40] 10QRpedia-General: Language is not displayed on language links - https://phabricator.wikimedia.org/T73643 (10Aklapper) a:05Kelson>03None [11:21:42] 10QRpedia-General: qrpedia.org should provide a SVG-file - https://phabricator.wikimedia.org/T65464 (10Aklapper) a:05Kelson>03None [11:21:46] 10QRpedia-General: Create a QRpedia test suite - https://phabricator.wikimedia.org/T62525 (10Aklapper) a:05Kelson>03None [11:21:48] 10QRpedia-General: QRpedia stats grouped per project - https://phabricator.wikimedia.org/T61728 (10Aklapper) a:05Kelson>03None [11:21:50] 10QRpedia-General: QRPedia doesn't recognize converttitles option - https://phabricator.wikimedia.org/T61727 (10Aklapper) a:05Kelson>03None [11:21:52] 10QRpedia-General: Add Wikipedia logo to QR code - https://phabricator.wikimedia.org/T61726 (10Aklapper) a:05Kelson>03None [11:25:19] (03Merged) 10jenkins-bot: [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:28:45] (03CR) 10jenkins-bot: [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:30:23] (03PS1) 10ItSpiderman: Fix (somewhat) icon alignment [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456598 [11:30:46] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10WMDE-QWERTY-Team, 10wikidiff2, 10WMDE-QWERTY-Sprint-2018-08-29: Release and deploy wikidiff2 v1.8.0 with changed signature - https://phabricator.wikimedia.org/T203069 (10WMDE-Fisch) [11:31:23] 10MediaWiki-History-or-Diffs, 10TCB-Team, 10WMDE-QWERTY-Team, 10wikidiff2, 10WMDE-QWERTY-Sprint-2018-08-29: Release and deploy wikidiff2 v1.8.0 with changed signature - https://phabricator.wikimedia.org/T203069 (10WMDE-Fisch) Since the deployment of this version is a bit more time consuming and should ha... [11:31:29] (03PS1) 10Seb35: Typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456599 (https://phabricator.wikimedia.org/T202224) [11:31:38] (03CR) 10jerkins-bot: [V: 04-1] Typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456599 (https://phabricator.wikimedia.org/T202224) (owner: 10Seb35) [11:35:30] (03PS1) 10Jdrewniak: Remove old AB integration testing code from repo. [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456600 (https://phabricator.wikimedia.org/T194136) [11:36:00] (03PS1) 10Nikerabbit: Scan newest page firsts [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/456601 [11:38:14] (03Merged) 10jenkins-bot: Add test for {{subst:REVISIONUSER}} [core] - 10https://gerrit.wikimedia.org/r/456595 (owner: 10Daniel Kinzler) [11:38:16] (03PS11) 10Daimona Eaytoy: Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) [11:38:19] (03Merged) 10jenkins-bot: Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:39:17] (03PS11) 10Petar.petkovic: Add aliases for Bosnian, Croatian, Serbian languages and fix typos in code [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/453660 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:39:19] (03CR) 10jerkins-bot: [V: 04-1] Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [11:40:08] (03PS1) 10Daimona Eaytoy: Bump taint-check plugin to 1.3.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456603 [11:41:17] (03CR) 10jenkins-bot: Add test for {{subst:REVISIONUSER}} [core] - 10https://gerrit.wikimedia.org/r/456595 (owner: 10Daniel Kinzler) [11:44:44] (03CR) 10jenkins-bot: Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:45:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix typos in code (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:46:19] (03CR) 10Gergő Tisza: "Turns out the REVISIONUSER thing was broken in core, so this patch fixed T174163; possibly T146283 as well." [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:47:07] 10MediaWiki-Parser: MagicWord {{REVISIONUSER}} is not displayed in Wikipage - https://phabricator.wikimedia.org/T174163 (10Tgr) 05Open>03Resolved a:03Tgr Should be fixed by the recent revision rendering rewrite in https://gerrit.wikimedia.org/r/c/mediawiki/core/+/451025 [11:49:55] 10AbuseFilter: REVISIONUSER magic word shows as empty string in abuse filter - https://phabricator.wikimedia.org/T146283 (10Tgr) [11:49:57] 10MediaWiki-Parser: MagicWord {{REVISIONUSER}} is not displayed in Wikipage - https://phabricator.wikimedia.org/T174163 (10Tgr) [11:50:26] (03PS2) 10Seb35: Typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456599 (https://phabricator.wikimedia.org/T202224) [11:50:33] (03CR) 10jerkins-bot: [V: 04-1] Typo [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/456599 (https://phabricator.wikimedia.org/T202224) (owner: 10Seb35) [11:57:29] (03PS1) 10Jdrewniak: Removing JSHint [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456606 (https://phabricator.wikimedia.org/T199825) [11:58:11] (03PS15) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [11:58:21] (03CR) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [11:58:52] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [11:59:15] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [12:02:31] (03CR) 10Gergő Tisza: Use RevisionRenderer for rendering ParserOutput (0313 comments) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [12:02:49] (03CR) 10Huji: [C: 032] Bump taint-check plugin to 1.3.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456603 (owner: 10Daimona Eaytoy) [12:03:12] (03Merged) 10jenkins-bot: Fix typos in code [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:04:47] (03PS12) 10Daimona Eaytoy: Refactor: add on-wiki configuration [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) [12:05:06] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Sorry, this file cannot be displayed - Error Message when clicking on image with MediaViewer enabled - https://phabricator.wikimedia.org/T203189 (10Stevensi1018) No, should I ? And how can I do it in MediaWiki to make it works? [12:07:53] 10I18n, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Esanders) a:03Esanders [12:08:00] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Aklapper) [12:08:28] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Daimona) [12:08:47] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/444363 (https://phabricator.wikimedia.org/T198890) (owner: 10Daimona Eaytoy) [12:10:10] (03CR) 10Polybuildr: [C: 032] Scan newest page firsts [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/456601 (owner: 10Nikerabbit) [12:11:35] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Tgr) Yeah, either [[https://enable-cors.org/server.html|enable CORS]] on your upload domain or make sur... [12:13:04] 10MediaWiki-extensions-MediaWikiFarm, 10Patch-For-Review: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) - https://phabricator.wikimedia.org/T202224 (10Seb35) The message is triggered by Zuul, see https://git.openstack.org/cgit/openstack-infra/zuul/tree/zuul/configloader.py#n1068... [12:13:56] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Need-volunteer, 10Patch-For-Review: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10RazeSoldier) [12:15:49] (03PS1) 10ItSpiderman: Fix broken param in notifications [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/456609 [12:18:14] (03Restored) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [12:18:16] (03PS2) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 [12:19:08] (03CR) 10Hashar: "check experimental" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [12:19:58] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10Thumbor, and 3 others: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10IKhitron) >>! In T198370#4547738, @PhilipTerryGraham wrote: > @Gilles This works! Thanks for the tip; I'll go ahead and pur... [12:20:39] (03Merged) 10jenkins-bot: Bump taint-check plugin to 1.3.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456603 (owner: 10Daimona Eaytoy) [12:20:43] (03Merged) 10jenkins-bot: Scan newest page firsts [extensions/SmiteSpam] - 10https://gerrit.wikimedia.org/r/456601 (owner: 10Nikerabbit) [12:21:25] 10Extension-MobileApp, 10Wikipedia-Android-App-Backlog: Add "Tag-android app edit" and "Tag-ios app edit" to i18n - https://phabricator.wikimedia.org/T203223 (10Dbrant) 05Open>03declined These strings are used by analytics across different wiki projects, and should not be translated. [12:23:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Minor cleanup in backup test cases [core] - 10https://gerrit.wikimedia.org/r/456536 (owner: 10Tim Starling) [12:24:26] (03CR) 10jenkins-bot: Bump taint-check plugin to 1.3.1 [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456603 (owner: 10Daimona Eaytoy) [12:28:28] (03CR) 10Mglaser: [C: 032] Fix (somewhat) icon alignment [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456598 (owner: 10ItSpiderman) [12:29:03] (03CR) 10Robert Vogel: [V: 032] Fix (somewhat) icon alignment [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456598 (owner: 10ItSpiderman) [12:29:18] 10MediaWiki-General-or-Unknown, 10Performance-Team, 10Patch-For-Review: Audit use of @embed and remove where not needed - https://phabricator.wikimedia.org/T121730 (10Ladsgroup) https://netmarketshare.com/browser-market-share.aspx says IE is still used in 10% of traffic in the internet. That's quite signific... [12:29:34] (03CR) 10Robert Vogel: [C: 032] Fix broken param in notifications [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/456609 (owner: 10ItSpiderman) [12:31:17] 10MediaWiki-extensions-MediaWikiFarm, 10Patch-For-Review: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) - https://phabricator.wikimedia.org/T202224 (10Seb35) Well, see also T134062 where pywikibot repo was corrupted, the symptoms are the same. I can however download all refs fro... [12:32:43] 10ContentTranslation: CX2: Coordinates break alignment - https://phabricator.wikimedia.org/T203243 (10Petar.petkovic) [12:32:51] (03CR) 10Daniel Kinzler: [MCR][WIP] Move getSecondaryDataUpdates to the page level (0315 comments) [core] - 10https://gerrit.wikimedia.org/r/456204 (owner: 10Gergő Tisza) [12:33:44] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Write script for Expert Reviewers to follow - https://phabricator.wikimedia.org/T202645 (10Deskana) Looks good to me! The tiniest of nitpicks: I would swap the ordering of two and three, to emphasise that... [12:34:34] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) - https://phabricator.wikimedia.org/T203189 (10Stevensi1018) I added : Header set Access-Control-Allow-Origin "*" in my apache2.conf under in the 10CirrusSearch, 10Discovery, 10Discovery-Search: CirrusSearch hastemplate can't find Translatable template - https://phabricator.wikimedia.org/T125926 (10Deskana) a:05Deskana>03None [12:44:58] (03Merged) 10jenkins-bot: Minor cleanup in backup test cases [core] - 10https://gerrit.wikimedia.org/r/456536 (owner: 10Tim Starling) [12:47:42] (03CR) 10Hashar: "check experimental" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [12:47:49] (03PS1) 10Jdrewniak: Fix "aricles" label [wikimedia/portals] - 10https://gerrit.wikimedia.org/r/456617 (https://phabricator.wikimedia.org/T183058) [12:47:51] (03CR) 10jenkins-bot: Minor cleanup in backup test cases [core] - 10https://gerrit.wikimedia.org/r/456536 (owner: 10Tim Starling) [12:48:28] (03CR) 10Seb35: "It seems the git repository is corrupted, see https://phabricator.wikimedia.org/T134062." [extensions/MediaWikiFarm] - 10https://gerrit.wikimedia.org/r/453669 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:48:33] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10Paladox) [12:51:48] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Wikidata-Campsite-Iteration-∞, and 2 others: Declare Wikibase JavaScript hooks stable - https://phabricator.wikimedia.org/T169775 (10Jonas) **Text for the wiki and the announcement on the mailing list:** To allow better gadget in... [12:51:50] 10Discovery, 10Wikimedia-Portals, 10Browser-Support-Firefox, 10Patch-For-Review: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox - https://phabricator.wikimedia.org/T199337 (10Jdrewniak) The issue here was that the page was not rendering the //english// label for the wo... [12:55:08] 10MediaWiki-extensions-Other, 10BlueSpice, 10ConfirmEdit (CAPTCHA extension): TinyMCE doesn't show ConfirmEdit captcha confusing users - https://phabricator.wikimedia.org/T203247 (10Bawolff) [12:55:43] (03Merged) 10jenkins-bot: Fix (somewhat) icon alignment [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/456598 (owner: 10ItSpiderman) [12:55:45] (03Merged) 10jenkins-bot: Fix broken param in notifications [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/456609 (owner: 10ItSpiderman) [13:02:14] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: "Nominated for deletion" filter doesn't work - https://phabricator.wikimedia.org/T202582 (10SBisson) >>! In T202582#4546949, @MMiller_WMF wrote: > Thanks... [13:02:42] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10MarcoAurelio) Just to mention that Blackout was deployed briefly to WMF sites when the SOPA/PIPA protest. It was later undeployed... [13:05:15] 10CommRel-Internals: Close the Technical Collaboration's Community Health group - https://phabricator.wikimedia.org/T199086 (10Qgil) p:05Normal>03Low I have pinged the CoC Committee. Meanwhile, there is nothing I can actively do. Lowering priority. [13:06:38] (03CR) 10Hashar: "check experimental" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [13:08:08] 10ContentTranslation, 10Language-2018-July-September: CX2: Adjust when to check warnings for a paragraph - https://phabricator.wikimedia.org/T200683 (10Petar.petkovic) [[https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/ContentTranslation/+/454798/|Merged patch]] only deals with the first proposed edit -... [13:10:36] (03PS1) 10DCausse: Add image thumb url to runSearhc output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 [13:10:40] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review: New Pages Feed: backfill ORES scores for unscored drafts (3.3) - https://phabricator.wikimedia.org/T198982 (10SBisson) >>! In T198982#4547301, @MMiller_... [13:10:50] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10MarcoAurelio) I don't understand. The task for archiving the MwEmbedSupport extension with the item "delete github mirror" was opened for months (T197918). Nobody objected.... [13:11:00] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors, 10User-MarcoAurelio: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10MarcoAurelio) a:03MarcoAurelio [13:11:18] (03PS2) 10DCausse: Add image thumb url to runSearch output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 [13:12:04] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors, 10User-MarcoAurelio: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10MarcoAurelio) On the other hand, can't we just ask users to clone from elsewhere? GitHub was never suposed to be our official code repository. They ca... [13:12:34] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10hashar) [13:16:15] (03CR) 10jerkins-bot: [V: 04-1] Add image thumb url to runSearch output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [13:16:28] 10MediaWiki-extensions-MediaWikiFarm, 10Gerrit, 10Patch-For-Review: CI failure for MediaWikiFarm (says unable to merge, but change is up to date) - https://phabricator.wikimedia.org/T202224 (10Seb35) Could a Gerrit admin clear the git repo mediawiki/extensions/MediaWikiFarm? It was the action solving the iss... [13:17:27] (03PS3) 10DCausse: Add image thumb url to runSearch output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 [13:19:37] (03PS1) 10Robert Vogel: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/456623 [13:19:39] (03CR) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput (035 comments) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [13:19:53] 10MediaWiki-extensions-Score, 10Patch-For-Review: Enable Score MP3 support for Wikimedia wikis - https://phabricator.wikimedia.org/T184598 (10Ebe123) [13:19:55] 10MediaWiki-extensions-Score, 10Security-Reviews, 10Security-Team: Security review for fluidsynth - https://phabricator.wikimedia.org/T199511 (10Ebe123) 05Open>03Resolved a:03Ebe123 As fluidsynth is now in puppet and the comments above, think this can be set as resolved. Didn't hear of Philip's Music... [13:20:11] 10MediaWiki-extensions-Score, 10Security-Reviews, 10Security-Team: Security review for fluidsynth - https://phabricator.wikimedia.org/T199511 (10Ebe123) a:05Ebe123>03None [13:21:28] 10phan-taint-check-plugin: phan-taint-check should detect unescaped msg output in Listings but doesn't - https://phabricator.wikimedia.org/T203214 (10Bawolff) It seems like NO_OVERRIDE flag was being propagated on assignment/return, meaning that only the first return statement was being taken into account not th... [13:22:52] (03CR) 10Yaron Koren: [C: 032] Add support for visualeditor-enable user preference. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/456537 (owner: 10Cicalese) [13:22:55] (03PS2) 10Sbisson: Maintenance: fix ptrp_deleted [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456364 (https://phabricator.wikimedia.org/T202582) [13:23:31] 10I18n, 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Deskana) We should get this backported and deployed today, since it's a really bad breakage that we don't want hanging around over the weekend. [13:23:33] 10Wikimedia-Planet, 10monitoring: Add monitoring for planet updating - https://phabricator.wikimedia.org/T203208 (10Dzahn) a:03Dzahn [13:23:50] (03CR) 10Sbisson: Maintenance: fix ptrp_deleted (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456364 (https://phabricator.wikimedia.org/T202582) (owner: 10Sbisson) [13:24:59] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [13:28:25] (03Merged) 10jenkins-bot: Add support for visualeditor-enable user preference. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/456537 (owner: 10Cicalese) [13:29:09] 10Library-Card-Platform: SUL Info link does not appear to work on any application - https://phabricator.wikimedia.org/T202837 (10AVasanth_WMF) a:05AVasanth_WMF>03None [13:29:23] 10Library-Card-Platform: SUL Info link does not appear to work on any application - https://phabricator.wikimedia.org/T202837 (10AVasanth_WMF) a:03AVasanth_WMF [13:31:01] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10hashar) [13:31:24] (03PS1) 10Brian Wolff: Prevent NO_OVERRIDE flag from being propagated during assignment [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456626 (https://phabricator.wikimedia.org/T203214) [13:32:18] (03CR) 10jerkins-bot: [V: 04-1] Add image thumb url to runSearch output [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [13:33:14] (03PS16) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [13:33:34] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Bawolff) [13:33:36] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Bawolff) [13:34:03] (03CR) 10Gergő Tisza: Use RevisionRenderer for rendering ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [13:34:10] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Bawolff) [13:34:35] (03PS11) 10Daniel Kinzler: DNM: Fail when accessing the live DB during tests. [core] - 10https://gerrit.wikimedia.org/r/455633 (https://phabricator.wikimedia.org/T202641) [13:34:39] (03CR) 10Hashar: "check experimental" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/323216 (owner: 10Hashar) [13:34:48] (03PS2) 10Gergő Tisza: [MCR][WIP] Move getSecondaryDataUpdates to the page level [core] - 10https://gerrit.wikimedia.org/r/456204 [13:34:52] (03PS13) 10Daniel Kinzler: [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) [13:35:12] (03Abandoned) 10Daniel Kinzler: DNM Add tracking to NameTableStore to find bad state change. [core] - 10https://gerrit.wikimedia.org/r/456172 (https://phabricator.wikimedia.org/T202641) (owner: 10Daniel Kinzler) [13:35:35] (03CR) 10Seb35: "Don’t worry about the extension MediaWikiFarm, it is only used in some cases for old MediaWiki versions, nothing important." [core] - 10https://gerrit.wikimedia.org/r/451636 (owner: 10simetrical) [13:37:05] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Write script for Expert Reviewers to follow - https://phabricator.wikimedia.org/T202645 (10Esanders) +1 [13:38:01] 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Recruit for WMF instead of Automattic in X-Hacker value of blog.wikimedia.org - https://phabricator.wikimedia.org/T70982 (10Bawolff) @JBennett just pointed out that this also applies to wikimediafoundation.org [13:38:03] (03PS1) 10Nikerabbit: Initial import from nikext from translatewiki repo [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 [13:39:22] (03PS2) 10Nikerabbit: Initial import from nikext from translatewiki repo [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 [13:40:34] Hi, where I can provide fixes for en.json? [13:40:49] 10MediaWiki-extensions-Other, 10Wikimedia-Extension-setup, 10Wikimedia-extension-review-queue: Review and deploy Blackout extension - https://phabricator.wikimedia.org/T203228 (10Bawolff) >>! In T203228#4548494, @MarcoAurelio wrote: > Just to mention that Blackout was deployed briefly to WMF sites when the S... [13:43:44] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Need-volunteer, 10Patch-For-Review: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) [13:44:05] (03PS1) 10Robert Vogel: Add revision ids to recent changes store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456628 [13:44:23] (03CR) 10jerkins-bot: [V: 04-1] [MCR][WIP] Move getSecondaryDataUpdates to the page level [core] - 10https://gerrit.wikimedia.org/r/456204 (owner: 10Gergő Tisza) [13:45:49] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [13:47:39] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Anomie) Note that the files in `includes/engines/LuaCommon/lualib/ustring/` are intended to be able to be ex... [13:47:42] 10I18n, 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Esanders) Definitely. I've also added unit tests in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/VisualEditor/+/456629/ to cover... [13:48:14] (03CR) 10MGChecker: [C: 031] "Okay, fine for me." [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456351 (owner: 10Thiemo Kreuz (WMDE)) [13:48:22] (03CR) 10Mglaser: [C: 032] Remove dependency to Extension:Lockdown [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/456623 (owner: 10Robert Vogel) [13:49:48] (03CR) 10Jpond: "This is just a pat on the back. And a suggestion. Agree with the lockdown dependencies - thought it would be a good idea at inception. " [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/456623 (owner: 10Robert Vogel) [13:50:20] (03Merged) 10jenkins-bot: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/456623 (owner: 10Robert Vogel) [13:50:57] 10I18n, 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Esanders) Verified on beta: https://fa.wikipedia.beta.wmflabs.org/wiki/تغییر_مسیر?veaction=edit [13:53:05] 10I18n, 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Amire80) >>! In T203213#4548555, @Deskana wrote: > We should get this backported and deployed today, since it's a really bad breakage that w... [13:53:20] (03CR) 10jenkins-bot: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] (REL1_31) - 10https://gerrit.wikimedia.org/r/456623 (owner: 10Robert Vogel) [13:54:12] (03CR) 10MGChecker: Fix varexists parsing and improve documentation (031 comment) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455174 (https://phabricator.wikimedia.org/T202679) (owner: 10MGChecker) [13:54:26] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors, 10User-MarcoAurelio: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10Paladox) Though having users going through phab or gerrit could cause high load due to the amount of users that could clone it. [13:54:28] (03PS1) 10Zoranzoki21: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) [13:54:43] 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Recruit for WMF instead of Automattic in X-Hacker value of blog.wikimedia.org and wikimediafoundation.org - https://phabricator.wikimedia.org/T70982 (10Krenair) [13:55:01] (03CR) 10jerkins-bot: [V: 04-1] [MCR][WIP] Move getSecondaryDataUpdates to the page level [core] - 10https://gerrit.wikimedia.org/r/456204 (owner: 10Gergő Tisza) [13:55:21] (03CR) 10jerkins-bot: [V: 04-1] DNM: Fail when accessing the live DB during tests. [core] - 10https://gerrit.wikimedia.org/r/455633 (https://phabricator.wikimedia.org/T202641) (owner: 10Daniel Kinzler) [13:55:29] (03PS2) 10Zoranzoki21: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) [13:57:04] (03PS1) 10Robert Vogel: Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 [13:57:11] (03CR) 10Zoranzoki21: Fix typos in code (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455053 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [13:59:46] (03PS1) 10Zoranzoki21: Fix "perfomed" typo in i18n/api/en.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) [13:59:50] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) (owner: 10Daniel Kinzler) [14:00:23] (03PS2) 10Zoranzoki21: Fix "perfomed" typo in i18n/api/en.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) [14:00:34] (03CR) 10Zoranzoki21: "DNM until I no say." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:01:30] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) (owner: 10Daniel Kinzler) [14:02:08] (03CR) 10Cicalese: "recheck" [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/456052 (https://phabricator.wikimedia.org/T202515) (owner: 10Cicalese) [14:03:05] 10I18n, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Deskana) [14:03:56] (03PS1) 10Daniel Kinzler: Test data providers should never access the database. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/456636 [14:06:21] (03CR) 10jerkins-bot: [V: 04-1] Include libphutil as a submodule [extensions/PhabTaskGraph] - 10https://gerrit.wikimedia.org/r/456052 (https://phabricator.wikimedia.org/T202515) (owner: 10Cicalese) [14:10:41] (03CR) 10Zoranzoki21: "You can merge that now." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:13:15] (03PS1) 10Zoranzoki21: Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 [14:13:33] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) p:05Triage>03High [14:13:42] (03PS2) 10Zoranzoki21: Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) [14:14:17] (03CR) 10Tpt: [C: 04-1] "you have probably forgotten to add your changes to the commit" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:14:26] 10Research-Programs, 10Epic: [Objective 11.1.2] Research on citation/external link usage - https://phabricator.wikimedia.org/T171231 (10Miriam) [14:14:28] (03CR) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [14:14:29] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) [14:14:53] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Patch-For-Review, 10Performance-Team (Radar), 10Research-2017-18-Q4: Instrument and collect data via CitationUsage schema - https://phabricator.wikimedia.org/T191086 (10Miriam) [14:14:55] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) [14:15:07] (03CR) 10Tpt: [C: 032] Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:15:20] (03CR) 10Zoranzoki21: "Thanks Petar!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/453660 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:15:23] 10MediaWiki-API, 10Patch-For-Review: Introduce a new "strict-boolean" MediaWiki API parameter type for better validation and semantics? - https://phabricator.wikimedia.org/T203133 (10Anomie) >>! In T203133#4547384, @awight wrote: > It's more about the new type being explicit, "true" and "false" being about as... [14:16:36] (03CR) 10Zoranzoki21: "> you have probably forgotten to add your changes to the commit" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:16:37] 10Research-Programs, 10Epic, 10Research-2017-18-Q4: Analyze the first round of data about readers' usage of references - https://phabricator.wikimedia.org/T190437 (10Miriam) [14:17:15] (03CR) 10Seb35: "recheck" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:17:51] 10Research-Programs, 10Epic, 10Research-2017-18-Q4: Analyze the first round of data about readers' usage of references - https://phabricator.wikimedia.org/T190437 (10Miriam) [14:18:18] (03PS4) 10Zoranzoki21: Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) [14:18:22] 10Research-Programs, 10Epic, 10Research-2017-18-Q4: Analyze the first round of data about readers' usage of references - https://phabricator.wikimedia.org/T190437 (10Miriam) Code for analysis: https://github.com/epfl-dlab/WikipediaCitationUsage/blob/master/MetaPageQueries.ipynb Meta page with results: https:... [14:19:02] (03CR) 10MGChecker: [C: 031] "Okay. I just noticed the "wrong type" problem thought about in my first comment isn't really happening, so everything is fine here." [extensions/Arrays] - 10https://gerrit.wikimedia.org/r/456346 (owner: 10Thiemo Kreuz (WMDE)) [14:19:04] (03CR) 10Mglaser: [C: 032] Add revision ids to recent changes store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456628 (owner: 10Robert Vogel) [14:19:54] (03CR) 10Mglaser: [C: 032] Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 (owner: 10Robert Vogel) [14:20:02] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) Proposal of the second round of data collection: https://meta.wikimedia.org/wi... [14:20:58] (03PS1) 10Daimona Eaytoy: Only select needed columns in queries [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456640 [14:21:15] (03PS4) 10DCausse: Various runSearch fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 [14:21:23] (03Merged) 10jenkins-bot: Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:22:53] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) [14:23:09] 10Discovery, 10Discovery-Portal-Backlog, 10Wikimedia-Portals, 10Patch-For-Review: Beta cluster portal reports uncaught JavaScript TypeError - https://phabricator.wikimedia.org/T184079 (10Jdrewniak) 05Open>03Resolved [14:23:12] 10Research: Perform early analysis of the data collected via CitationUsage schema - https://phabricator.wikimedia.org/T199457 (10Miriam) [14:23:16] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), 10Patch-For-Review: Schema:CitationUsage improvements - https://phabricator.wikimedia.org/T199807 (10Miriam) [14:23:46] (03CR) 10Pwirth: [C: 04-1] "The Extensions Name is BlueSpiceUEModulePDF Not URModulePDF" [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 (owner: 10Robert Vogel) [14:23:54] 10Research: Perform early analysis of the data collected via CitationUsage schema - https://phabricator.wikimedia.org/T199457 (10Miriam) [14:23:56] 10Research-Programs, 10Epic, 10Research-2017-18-Q4: Analyze the first round of data about readers' usage of references - https://phabricator.wikimedia.org/T190437 (10Miriam) [14:24:59] (03PS14) 10Daniel Kinzler: [MCR][WIP] Introduce ContentHandler::getSecondaryLinksUpdates. [core] - 10https://gerrit.wikimedia.org/r/418134 (https://phabricator.wikimedia.org/T194038) [14:25:01] (03CR) 10jenkins-bot: Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:25:02] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) [14:25:07] (03CR) 10jerkins-bot: [V: 04-1] Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:25:35] 10Research-Archive, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Performance-Team (Radar), 10Research-2017-18-Q4: Run a Second Round of Data Collection - https://phabricator.wikimedia.org/T203253 (10Miriam) [14:25:56] (03CR) 10Zoranzoki21: "I would like to try something in that patch. If my idea works, I will make in new patch." [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:26:12] (03PS5) 10Zoranzoki21: Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) [14:28:41] 10Library-Card-Platform: Ensure that renewals from partner pages attempt to renew the correct (latest) application. - https://phabricator.wikimedia.org/T203164 (10Samwalton9) a:03Samwalton9 In a shocking turn of events, that line wasn't ordering correctly, and is reversed in https://github.com/WikipediaLibrary... [14:29:36] (03Merged) 10jenkins-bot: Add revision ids to recent changes store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456628 (owner: 10Robert Vogel) [14:29:42] (03CR) 10jerkins-bot: [V: 04-1] [MCR][WIP] Introduce ContentHandler::getSecondaryLinksUpdates. [core] - 10https://gerrit.wikimedia.org/r/418134 (https://phabricator.wikimedia.org/T194038) (owner: 10Daniel Kinzler) [14:29:51] (03CR) 10Raimond Spekking: [C: 032] Fix "perfomed" typo in i18n/api/en.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:31:03] (03CR) 10Seb35: "Ok. I saw the failure in 28/08 20:03 was an intermittent failure, hence my re check." [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:32:22] 10Library-Card-Platform: Ensure that renewals from partner pages attempt to renew the correct (latest) application. - https://phabricator.wikimedia.org/T203164 (10Samwalton9) 05Open>03Resolved [14:32:26] (03CR) 10Zoranzoki21: "> Ok. I saw the failure in 28/08 20:03 was an intermittent failure," [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:35:13] (03CR) 10jerkins-bot: [V: 04-1] Fix "the the" typos in RenameuserSQL.php file [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/455318 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:36:41] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [14:37:03] (03CR) 10Pwirth: [C: 04-1] Fix config definition paths (031 comment) [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 (owner: 10Robert Vogel) [14:37:29] (03PS2) 10Robert Vogel: Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 [14:37:50] (03PS3) 10Robert Vogel: Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 [14:38:38] 10Discovery, 10Wikimedia-Portals: Establish a merge and deploy workflow for wikimedia/portals repository - https://phabricator.wikimedia.org/T136185 (10Jdrewniak) 05Open>03Resolved a:03Jdrewniak Closing this out since in late 2017 we created a "deploy" repo for the Portals project, which contains only th... [14:39:01] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Write script for Expert Reviewers to follow - https://phabricator.wikimedia.org/T202645 (10iamjessklein) Thanks @Deskana and @Esanders, closing this task. [14:39:16] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [14:39:35] (03CR) 10jenkins-bot: Fix "perfomed" typo in SpecialProofreadPages.php file [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/456638 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:39:36] 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Recruit for WMF instead of Automattic in X-Hacker value of blog.wikimedia.org and wikimediafoundation.org - https://phabricator.wikimedia.org/T70982 (10chasemp) [14:39:49] 10Security-Team, 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Recruit for WMF instead of Automattic in X-Hacker value of blog.wikimedia.org and wikimediafoundation.org - https://phabricator.wikimedia.org/T70982 (10chasemp) [14:41:43] (03Merged) 10jenkins-bot: Fix "perfomed" typo in i18n/api/en.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456634 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [14:42:35] (03CR) 10Mglaser: [C: 032] Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 (owner: 10Robert Vogel) [14:44:11] (03PS1) 10Mepps: Test to see if this fixes the build [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456645 [14:46:41] (03CR) 10Gergő Tisza: Use RevisionRenderer for rendering ParserOutput (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [14:48:11] (03PS1) 10Petar.petkovic: Use 1.30 as minimum required version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456647 [14:48:16] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Evaluate the effectiveness of the current Visual Editor user interface - https://phabricator.wikimedia.org/T201547 (10iamjessklein) [14:48:23] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Determine questions for the mobile web Visual Editor usability test - https://phabricator.wikimedia.org/T201553 (10iamjessklein) 05Open>03Resolved T202645 is closed so that closes this task as well. [14:48:26] 10MediaWiki-API: MediaWiki\\Storage\\RevisionAccessException in API action=compare - https://phabricator.wikimedia.org/T203255 (10MER-C) [14:49:53] 10MediaWiki-API, 10Wikimedia-log-errors: MediaWiki\\Storage\\RevisionAccessException in API action=compare - https://phabricator.wikimedia.org/T203255 (10Krenair) [14:50:10] 10MediaWiki-extensions-OATHAuth: OATH (2FA) needs an option to remember device but not keep user logged in - https://phabricator.wikimedia.org/T203256 (10deryckchan) [14:50:37] (03PS1) 10Robert Vogel: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456648 [14:53:13] (03CR) 10Mglaser: [C: 032] Remove dependency to Extension:Lockdown [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456648 (owner: 10Robert Vogel) [14:55:26] (03PS4) 10Mepps: Updates to make question creation and editing work [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456165 [14:56:03] (03PS6) 10Mepps: Update fancybox and JSON to get survey front-end working [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456166 [14:58:29] (03Merged) 10jenkins-bot: Fix config definition paths [extensions/BlueSpiceUEModulePDF] - 10https://gerrit.wikimedia.org/r/456633 (owner: 10Robert Vogel) [14:58:31] 10MediaWiki-API, 10Wikimedia-log-errors: MediaWiki\\Storage\\RevisionAccessException in API action=compare - https://phabricator.wikimedia.org/T203255 (10Anomie) a:03Anomie Exception is ``` 2018-08-31 14:56:44 [W4lXLApAAE4AADEg@44AAAAT] mw1283 enwiki 1.32.0-wmf.19 exception ERROR: [W4lXLApAAE4AADEg@44AAAAT]... [14:58:32] (03Merged) 10jenkins-bot: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456648 (owner: 10Robert Vogel) [15:01:17] (03CR) 10Pmiazga: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/455895 (https://phabricator.wikimedia.org/T202374) (owner: 10Pmiazga) [15:01:28] (03PS3) 10Pmiazga: Show error-conflict message when someone edited given article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/455895 (https://phabricator.wikimedia.org/T202374) [15:02:28] (03CR) 10jenkins-bot: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456648 (owner: 10Robert Vogel) [15:02:45] 10MediaWiki-API, 10Wikimedia-log-errors: MediaWiki\\Storage\\RevisionAccessException - "No such slot: main" in API action=compare - https://phabricator.wikimedia.org/T203255 (10Bawolff) [15:03:02] 10MediaWiki-API, 10Wikimedia-log-errors: MediaWiki\\Storage\\RevisionAccessException - "No such slot: main" in API action=compare - https://phabricator.wikimedia.org/T203255 (10Anomie) When you specify `toslots=main` without `totext-main` it's previewing the revision as if the main slot were deleted (this is d... [15:04:08] (03CR) 10MGChecker: [C: 032] "While it is possible to abuse the ExtVariables object as temporary storage for objects that can't be cast to string, it isn't allowed cons" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456355 (owner: 10Thiemo Kreuz (WMDE)) [15:05:00] 10MediaWiki-API, 10Multi-Content-Revisions, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Wikimedia-log-errors: MediaWiki\\Storage\\RevisionAccessException - "No such slot: main" in API action=compare - https://phabricator.wikimedia.org/T203255 (10Anomie) [15:08:40] (03CR) 10jenkins-bot: Remove dependency to Extension:Lockdown [extensions/NSFileRepo] - 10https://gerrit.wikimedia.org/r/456648 (owner: 10Robert Vogel) [15:08:46] (03PS3) 10Rxy: Add suppress related permissions to $wgGrantPermissionGroups [core] - 10https://gerrit.wikimedia.org/r/456305 (https://phabricator.wikimedia.org/T203129) [15:09:24] (03Merged) 10jenkins-bot: Improve type hints in PHPDoc tags [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456355 (owner: 10Thiemo Kreuz (WMDE)) [15:11:26] (03PS1) 10Rxy: Add suppress related permissions to $wgGrantPermissionGroups [core] - 10https://gerrit.wikimedia.org/r/456651 (https://phabricator.wikimedia.org/T203129) [15:11:36] (03CR) 10Brian Wolff: [C: 04-1] Add a hook to allow changing the query of Special:AncientPages in extensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) (owner: 10Agabi10) [15:13:44] 10I18n, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10RTL, 10VisualEditor (Current work): Visual Editor works as LTR in all RTL Wikimedia wikis - https://phabricator.wikimedia.org/T203213 (10Esanders) [15:16:11] 10Readers-Web-Backlog: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Esanders) Is this the cause of T202620? [15:18:14] (03PS3) 10Thiemo Kreuz (WMDE): Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [15:18:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [15:18:49] (03CR) 10MGChecker: "I'd prefer updating the RELEASE-NOTES later on, as I would like to add the last few years before." [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455174 (https://phabricator.wikimedia.org/T202679) (owner: 10MGChecker) [15:18:54] (03CR) 10Esanders: "Not a specific task, but the style guide advises against using IDs (https://www.mediawiki.org/wiki/Manual:Coding_conventions/CSS), and as " [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455848 (owner: 10Esanders) [15:19:58] 10MediaWiki-API, 10Analytics, 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10Milimetric) ping @anomie or @Tgr: were either of you interested in finishing this change https://gerrit.wikimedia.org/r/#/c/anal... [15:20:56] (03Abandoned) 10Rxy: Add suppress related permissions to $wgGrantPermissionGroups [core] - 10https://gerrit.wikimedia.org/r/456651 (https://phabricator.wikimedia.org/T203129) (owner: 10Rxy) [15:21:34] (03PS4) 10Rxy: Add suppress related permissions to $wgGrantPermissionGroups [core] - 10https://gerrit.wikimedia.org/r/456305 (https://phabricator.wikimedia.org/T203129) [15:21:57] 10MediaWiki-General-or-Unknown: Deprecate #mw-notification-area in favour of .mw-notification-area - https://phabricator.wikimedia.org/T203259 (10Esanders) [15:22:17] (03PS2) 10Esanders: Replace ID selector with class selector (mw-notification-area) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455848 (https://phabricator.wikimedia.org/T203259) [15:22:24] (03CR) 10Esanders: "Filed." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455848 (https://phabricator.wikimedia.org/T203259) (owner: 10Esanders) [15:22:55] 10MediaWiki-General-or-Unknown, 10Patch-For-Review: Deprecate #mw-notification-area in favour of .mw-notification-area - https://phabricator.wikimedia.org/T203259 (10Esanders) https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/455849/ (merged) [15:23:06] (03PS3) 10Esanders: Replace ID selector with class selector (mw-notification-area) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455848 (https://phabricator.wikimedia.org/T203259) [15:23:38] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Bawolff) [15:23:40] 10MediaWiki-extensions-Scribunto, 10Easy: convert scribunto's ustring maintenance scripts (e.g. make-normalization-table.php) to use MW's maintenance class - https://phabricator.wikimedia.org/T203217 (10Bawolff) 05Open>03declined >>! In T203217#4548596, @Anomie wrote: > Note that the files in `includes/eng... [15:25:14] (03CR) 10Bartosz Dziewoński: [C: 032] resourceloader: Remove redundant '!!' from startup.js [core] - 10https://gerrit.wikimedia.org/r/456526 (owner: 10Krinkle) [15:26:28] 10Security-Team, 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Remove inappropriate X-Hacker HTTP header served on sites hosted by Automattic - https://phabricator.wikimedia.org/T70982 (10chasemp) [15:26:46] (03PS1) 10Anomie: ApiComparePages: Clean up handling of slot deletion [core] - 10https://gerrit.wikimedia.org/r/456652 (https://phabricator.wikimedia.org/T203255) [15:27:43] (03PS6) 10MGChecker: Add further parser tests [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455061 (https://phabricator.wikimedia.org/T193036) [15:29:24] 10Security-Team, 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Remove inappropriate X-Hacker HTTP header served on sites hosted by Automattic - https://phabricator.wikimedia.org/T70982 (10chasemp) Is this gone now? I can no longer reproduce atm. [15:29:40] (03PS4) 10Kosta Harlan: Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) [15:33:51] (03CR) 10jerkins-bot: [V: 04-1] Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) (owner: 10Kosta Harlan) [15:34:23] (03PS5) 10Kosta Harlan: Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) [15:34:59] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Lets move on. Thanks a lot for the helpful conversation!" (031 comment) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455174 (https://phabricator.wikimedia.org/T202679) (owner: 10MGChecker) [15:35:02] (03PS2) 10Bartosz Dziewoński: Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [15:35:39] (03CR) 10Bartosz Dziewoński: [C: 032] "PS2: Added a doc comment per Gergő." [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [15:36:35] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Isarra) Timeles displays the hidden categories below the regular categories depending on the user preference to show hidden categories - is there another behaviour you're expecting to also enabl... [15:36:38] I guess you're gone? [15:36:39] er [15:36:44] EWINDOW :) [15:37:40] (03Merged) 10jenkins-bot: Fix "nto" typo in MwEmbedModules/TimedText/resources/mw.TimedText.js [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456632 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [15:37:41] 10MediaWiki-Page-editing, 10VisualEditor, 10VisualEditor-CopyPaste, 10VisualEditor-MediaWiki: The read HTML should have hinting to allow full DOM copying (as opposed to just rich copying) from read mode into VE surfaces - https://phabricator.wikimedia.org/T54091 (10matmarex) [15:38:29] (03CR) 10jerkins-bot: [V: 04-1] Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) (owner: 10Kosta Harlan) [15:38:39] (03CR) 10jerkins-bot: [V: 04-1] Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) (owner: 10Kosta Harlan) [15:39:18] (03CR) 10Pmiazga: [C: 032] Show error-conflict message when someone edited given article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/455895 (https://phabricator.wikimedia.org/T202374) (owner: 10Pmiazga) [15:45:19] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [core] - 10https://gerrit.wikimedia.org/r/456305 (https://phabricator.wikimedia.org/T203129) (owner: 10Rxy) [15:46:06] (03CR) 10jenkins-bot: Show error-conflict message when someone edited given article [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/455895 (https://phabricator.wikimedia.org/T202374) (owner: 10Pmiazga) [15:46:13] (03PS1) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [15:46:30] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Technical-Debt: Deprecate #mw-notification-area in favour of .mw-notification-area - https://phabricator.wikimedia.org/T203259 (10Aklapper) [15:49:02] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [15:53:48] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [15:53:50] (03CR) 10jerkins-bot: [V: 04-1] Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [15:55:27] 10Developer Productivity, 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Deskana) 05Open>03Resolved So, this is sat in QA, but it's not really clear what "QA" means for this task. From my testing, I think the test insta... [15:55:54] (03PS5) 10Agabi10: Add a hook to allow changing the query of Special:AncientPages in extensions [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) [15:56:46] (03Merged) 10jenkins-bot: resourceloader: Remove redundant '!!' from startup.js [core] - 10https://gerrit.wikimedia.org/r/456526 (owner: 10Krinkle) [15:56:48] (03CR) 10Agabi10: Add a hook to allow changing the query of Special:AncientPages in extensions (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456389 (https://phabricator.wikimedia.org/T76287) (owner: 10Agabi10) [15:56:50] (03Merged) 10jenkins-bot: Fix varexists parsing and improve documentation [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455174 (https://phabricator.wikimedia.org/T202679) (owner: 10MGChecker) [15:58:27] (03CR) 10jerkins-bot: [V: 04-1] Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [15:59:40] (03CR) 10jenkins-bot: resourceloader: Remove redundant '!!' from startup.js [core] - 10https://gerrit.wikimedia.org/r/456526 (owner: 10Krinkle) [16:02:30] (03PS2) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [16:02:57] (03CR) 10Brian Wolff: "Looks like I forgot to test first time around. I did test more carefully PS2" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:03:12] 10Readers-Web-Backlog: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Esanders) And this is possibly a duplicate of T143837 [16:04:13] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:05:16] 10Security-Team, 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Remove inappropriate X-Hacker HTTP header served on sites hosted by Automattic - https://phabricator.wikimedia.org/T70982 (10Jgreen) >>! In T70982#4548927, @chasemp wrote: > Is this gone now? I can no longer reproduce atm. I see i... [16:05:38] 10Developer-Advocacy (Jul-Sep 2018), 10Google-Code-in-2018: Recruit Google Code-in 2018 mentors - https://phabricator.wikimedia.org/T203230 (10Aklapper) [16:06:37] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:09:31] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Voice & Tone: Replace words "Blacklist" by "Denylist" and "Whitelist" by "Allowlist" - https://phabricator.wikimedia.org/T173080 (10Aklapper) [16:13:18] (03PS1) 10Rxy: Namespace translations for Japanese [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456658 [16:13:43] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: File cannot be displayed error when clicking on image with MediaViewer enabled (server URL vs IP address) due to missing CORS - https://phabricator.wikimedia.org/T203189 (10Aklapper) 05Open>03Invalid [16:15:20] (03CR) 10Anomie: [C: 032] "It's a little silly to have to do this, but it's straightforward enough." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:15:23] 10Technical Program Management: Phab training and board set up for Editing design - https://phabricator.wikimedia.org/T202422 (10MBinder_WMF) 05Open>03Resolved @iamjessklein Resolving this because we met. Two possible followups: - If you want to change your Phab username, I believe @Aklapper can help wit... [16:16:26] 10Technical Program Management: Update Team Practices Group site to indicate current status - https://phabricator.wikimedia.org/T200484 (10MBinder_WMF) No bites yet. Might end up doing this manually, or wait until the offsites start and I can snag someone for a few minutes. Will wait in the meantime. :) [16:17:16] (03PS3) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [16:19:10] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:19:46] 10Technical Program Management: Phab training and board set up for Editing design - https://phabricator.wikimedia.org/T202422 (10Aklapper) >>! In T202422#4549035, @MBinder_WMF wrote: > - If you want to change your Phab username See https://www.mediawiki.org/wiki/Phabricator/Help#Troubleshooting :) [16:19:55] (03CR) 10Jforrester: [C: 032] resourceloader: Use 'this' to access the mw.loader.store internally [core] - 10https://gerrit.wikimedia.org/r/456527 (owner: 10Krinkle) [16:20:34] (03PS6) 10Kosta Harlan: Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) [16:22:13] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:23:12] 10Technical Program Management: Phab training and board set up for Editing design - https://phabricator.wikimedia.org/T202422 (10MBinder_WMF) Thanks, @Aklapper . I think https://www.mediawiki.org/wiki/Talk:Phabricator/Help is generally a good place to make requests for things not covered in documentation? :) [16:25:35] 10MediaWiki-extension-requests, 10Security-Team, 10Patch-For-Review: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Daimona) a:03Daimona [16:27:24] (03CR) 10jerkins-bot: [V: 04-1] Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) (owner: 10Kosta Harlan) [16:29:03] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10pmiazga) [16:29:24] 10MediaWiki-API, 10Analytics, 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10Anomie) Feel free as far as I'm concerned. I don't know anything about Oozie. [16:31:20] 10Design, 10Design-Research, 10Editing Q1 2018-19 mobile improvements, 10VisualEditor (Current work): Determine questions for the mobile web Visual Editor usability test - https://phabricator.wikimedia.org/T201553 (10dchen) confirmed :) [16:32:30] (03CR) 10jerkins-bot: [V: 04-1] Ensure retrieval and storage of page metadata [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/455870 (https://phabricator.wikimedia.org/T203008) (owner: 10Kosta Harlan) [16:35:30] 10Epic, 10Test-Coverage, 10VisualEditor (Current work): Two week sprint: improve UI test coverage in VisualEditor - https://phabricator.wikimedia.org/T198971 (10Deskana) [16:35:32] 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Technical-Debt, 10VisualEditor (Current work): Create tests for PreviewElement - https://phabricator.wikimedia.org/T198871 (10Deskana) 05Open>03Resolved This probably shouldn't be in QA, as I don't think it's really something that Rummana... [16:38:19] 10VisualEditor (Current work): Description link message missing from gallery dialog in mobile - https://phabricator.wikimedia.org/T203262 (10Tchanders) [16:41:19] (03Merged) 10jenkins-bot: resourceloader: Use 'this' to access the mw.loader.store internally [core] - 10https://gerrit.wikimedia.org/r/456527 (owner: 10Krinkle) [16:42:49] (03PS4) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [16:44:18] (03CR) 10jenkins-bot: resourceloader: Use 'this' to access the mw.loader.store internally [core] - 10https://gerrit.wikimedia.org/r/456527 (owner: 10Krinkle) [16:44:25] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Voice & Tone: Replace words "Blacklist" by "Denylist" and "Whitelist" by "Allowlist" - https://phabricator.wikimedia.org/T173080 (10Anomie) > And for completeness, Greylist could become something like Blurrylist. Or such. Although that isn't... [16:45:35] (03PS3) 10Jforrester: Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [16:45:50] MatmaRex: Whoops: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/455910/2..3 [16:46:39] oof [16:46:49] (03PS9) 10Esanders: Allow skins to place notification container for mw.notify [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [16:46:52] (03CR) 10Anomie: [C: 031] "This is getting to be a lot of stuff to suppress one bogus warning..." (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [16:47:28] (03CR) 10Bartosz Dziewoński: [C: 031] "Oof, good thing we added these tests." [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [16:48:04] 10BlueSpice, 10Cleanup, 10Other-skins, 10Repository-Admins, 10Patch-For-Review: Archive "BlueSpiceSkin" skin - https://phabricator.wikimedia.org/T203215 (10Dinoguy1000) [16:48:48] 10Research, 10address-knowledge-gaps: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10bmansurov) p:05Triage>03Normal [16:49:16] 10Technical Program Management: Phab training and board set up for Editing design - https://phabricator.wikimedia.org/T202422 (10Aklapper) The default [[ https://phabricator.wikimedia.org/ | Phab frontpage ]] says "Ask any questions about Phabricator itself!" by linking to https://www.mediawiki.org/wiki/Talk:Pha... [16:50:39] 10Research, 10address-knowledge-gaps: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10bmansurov) @leila and @diego I pinged you because you speak Persian and Spanish. ;) [16:50:42] 10MediaWiki-User-login-and-signup, 10MediaWiki-extensions-OATHAuth, 10Security: Session is not saved across all Wikimedia sites - https://phabricator.wikimedia.org/T203264 (10Amire80) [16:52:50] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin, 10Patch-For-Review: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Bawolff) So the last warning is about throwing Html::rawElement() into Parser::parse. (Since Html::rawElement is outputting escape... [16:54:02] (03PS5) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [16:54:29] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Pamputt) Indeed, I am sorry. Hidden categories were not displayed because of my settings. If I enable this option, hidden categories are shown. This report can be closed. [16:58:44] 10Readers-Web-Backlog: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Esanders) [16:58:48] 10MediaWiki-General-or-Unknown, 10UI-Standardization, 10Notifications, 10Patch-For-Review, 10UI-Standardization-Kanban: Append mw.notify div to the body instead of content so it is always on top - https://phabricator.wikimedia.org/T143837 (10Esanders) [16:58:51] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin, 10Patch-For-Review: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Anomie) >>! In T202380#4549116, @Bawolff wrote: > Since Html::rawElement is outputting escaped html, It escapes the stuff that go... [16:59:05] 10Readers-Web-Backlog: [Bug] toast messages not visible in overlays - errors caused by talk overlay are not visible - https://phabricator.wikimedia.org/T202466 (10Esanders) [17:00:28] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Log sectionNumbers in PageIssues schema - https://phabricator.wikimedia.org/T202098 (10Tbayer) [17:00:30] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Section number in issues is reported incorrectly. - https://phabricator.wikimedia.org/T202651 (10Tbayer) 05Open>03Resolved [17:00:39] 10CommRel-Specialists-Support (Jul-Sep-2018): Copyediting CE Insights report - https://phabricator.wikimedia.org/T203014 (10Whatamidoing-WMF) We've run through everything that's been posted. We're still waiting for the pages about the Community Engagement Department, Community Programs, and Support & Safety que... [17:00:51] (03PS1) 10Esanders: Add a notifications overlay container to the skin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456665 (https://phabricator.wikimedia.org/T202466) [17:00:58] (03CR) 10Anomie: [C: 031] "The code works. I'll leave it to someone else to decide whether all the different ignoring going on here is a net positive or not." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [17:01:46] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): sectionNumbers and issuesSeverity should always be consistent in length - https://phabricator.wikimedia.org/T203050 (10Jdrewniak) Noticed an error in todays rev... [17:01:47] (03PS1) 10Dmaza: [WIP] Add enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) [17:02:05] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Section number in issues is reported incorrectly. - https://phabricator.wikimedia.org/T202651 (10Tbayer) @Jdrewniak and I double-check... [17:03:09] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:03:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:05:26] (03PS2) 10Dmaza: Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) [17:06:54] (03CR) 10jerkins-bot: [V: 04-1] Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:07:44] (03CR) 10jerkins-bot: [V: 04-1] Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:12:46] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Session is not saved across all Wikimedia sites - https://phabricator.wikimedia.org/T203264 (10Aklapper) Also see and follow https://www.mediawiki.org/wiki/Manual:How_to_debug/Login_problems [17:13:02] (03CR) 10Anomie: [C: 031] "Looks sane. A comment in the code like "break circular references" wouldn't hurt." [core] - 10https://gerrit.wikimedia.org/r/456541 (owner: 10Tim Starling) [17:15:40] tgr|away, legoktm, MatmaRex: OK, so… that bug means that https://en.wikipedia.org/wiki/Copyright and other NS0 pages which match wgRawHtmlMessages (that's likely the only one) are currently IAdmin protected in production. [17:16:01] MatmaRex: Merge so we can emergency-backport? [17:16:25] tgr: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/455910/2..3 [17:16:34] lol [17:17:04] hm [17:17:23] 10MediaWiki-API, 10Analytics, 10Patch-For-Review, 10User-Addshore: Run ETL for wmf_raw.ActionApi into wmf.action_* aggregate tables - https://phabricator.wikimedia.org/T137321 (10Nuria) To be fair I do not think we will have any time to work on this soon and I am really of the opinion that it would be bes... [17:18:00] (03CR) 10Bartosz Dziewoński: [C: 032] Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [17:18:04] huh [17:18:13] I remember fixing that missing negation [17:18:32] That's really unfortunate. [17:18:33] did I mess up something in git? [17:18:42] James_F: i wonder if we should backport a revert instead, but this should be fine [17:19:09] tgr: Rebase error, perhaps? [17:19:29] MatmaRex: I'd rather forward-port. [17:21:27] (03CR) 10Anomie: [C: 031] "Seems sane, at least for now. Not +2ing in case Daniel's comments need more discussion." [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [17:24:42] anyway, thanks for catching! I can do the deploy, or are you already doing it? [17:25:06] I'll do it. [17:29:43] (03PS34) 10Martineznovo: Add support for file backend for avatar, award and gift images [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:31:34] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): sectionNumbers and issuesSeverity should always be consistent in length - https://phabricator.wikimedia.org/T203050 (10Tbayer) [17:31:36] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Log sectionNumbers in PageIssues schema - https://phabricator.wikimedia.org/T202098 (10Tbayer) [17:33:57] 10Timeless, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review: Better category handling in Timeless - https://phabricator.wikimedia.org/T160645 (10Isarra) [17:33:59] 10Timeless: Add a way to display hidden category with the Timeless skin - https://phabricator.wikimedia.org/T203212 (10Isarra) 05Open>03Invalid All right, no worries. Thanks for taking the time to sort it out! [17:34:10] (03CR) 10Anomie: "Seems sane, although I'm not too familiar with the services stuff." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/456543 (owner: 10Tim Starling) [17:35:09] 10MediaWiki-extensions-Scribunto, 10phan-taint-check-plugin, 10Patch-For-Review: Add phan-taint-check-plugin to Scribunto extension - https://phabricator.wikimedia.org/T202380 (10Bawolff) > It escapes the stuff that goes into the tag's attributes, but anything in the $contents isn't touched. What I meant wa... [17:35:36] (03CR) 10Krinkle: [C: 031] Reduce memory usage on ServiceContainer destruction [core] - 10https://gerrit.wikimedia.org/r/456541 (owner: 10Tim Starling) [17:35:43] 10Security-Team, 10WMF-Legal, 10Wikimedia-Blog, 10wikimediafoundation.org: Remove inappropriate X-Hacker HTTP header served on sites hosted by Automattic - https://phabricator.wikimedia.org/T70982 (10chasemp) >>! In T70982#4549007, @Jgreen wrote: >>>! In T70982#4548927, @chasemp wrote: >> Is this gone now?... [17:37:00] (03CR) 10Krinkle: [C: 032] Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [17:37:02] (03CR) 10Martineznovo: [C: 04-1] "This is a manual rebase due to merge conflicts" (032 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/444441 (https://phabricator.wikimedia.org/T88033) (owner: 10Paladox) [17:39:35] (03CR) 10Krinkle: [C: 031] Fix use of selectDB() on DBConnRef in addWiki.php (031 comment) [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456554 (https://phabricator.wikimedia.org/T203154) (owner: 10Aaron Schulz) [17:39:55] (03Merged) 10jenkins-bot: Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [17:41:47] (03CR) 10jerkins-bot: [V: 04-1] Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [17:43:16] (03CR) 10jenkins-bot: Title: Fix isRawHtmlMessage() for messages with underscores [core] - 10https://gerrit.wikimedia.org/r/455910 (owner: 10Legoktm) [17:43:33] (03PS1) 10Jforrester: Title: Fix isRawHtmlMessage() for messages with underscores [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456668 [17:44:05] (03CR) 10Jforrester: [C: 032] Title: Fix isRawHtmlMessage() for messages with underscores [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456668 (owner: 10Jforrester) [17:44:11] (03Abandoned) 10Anomie: CloneDatabase: Populate site_stats when cloning it [core] - 10https://gerrit.wikimedia.org/r/335387 (https://phabricator.wikimedia.org/T156881) (owner: 10Anomie) [17:44:28] (03CR) 10Anomie: Introduce NameTableStoreFactory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [17:46:34] 10MediaWiki-Core-Tests, 10Patch-For-Review: Can't run Scribunto unit tests with $wgMiserMode because site_stats table isn't initialized - https://phabricator.wikimedia.org/T156881 (10Anomie) 05Open>03Resolved a:03aaron {3f05f34} probably fixed this. [17:49:11] (03PS6) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [17:49:43] (03PS1) 10Brian Wolff: Use annotations for taint in Parser & ParserOutput. [core] - 10https://gerrit.wikimedia.org/r/456669 (https://phabricator.wikimedia.org/T202380) [17:50:10] (03CR) 10Smalyshev: [C: 032] Various runSearch fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [17:50:13] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Log sectionNumbers in PageIssues schema - https://phabricator.wikimedia.org/T202098 (10Jdrewniak) [17:50:20] 10Page-Issue-Warnings, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review, 10Readers-Web-Backlog (Readers-Web-Kanbanana-Board-2018-19-Q1): Mobile page issues - instrument page issues - https://phabricator.wikimedia.org/T191532 (10Jdrewniak) [17:51:19] (03PS1) 10Brian Wolff: Move builtin taints for Parser&ParserOutput into inline annotations [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456670 (https://phabricator.wikimedia.org/T202380) [17:53:26] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Session is not saved across all Wikimedia sites - https://phabricator.wikimedia.org/T203264 (10Anomie) Seconding what @Aklapper posted. > For example, I log in to the English Wikipedia. If I go to the Italian Wikipedi... [17:53:27] (03CR) 10Brian Wolff: "PS6: Moved back to using globals, since providing as arguments changed it so that the warning was at time of function call instead of the " [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [17:53:29] (03CR) 10Smalyshev: [C: 031] Strip Empty Tokens After ICU Folding [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456428 (https://phabricator.wikimedia.org/T192502) (owner: 10Tjones) [17:54:05] (03PS3) 10Dmaza: Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) [17:55:18] (03CR) 10jerkins-bot: [V: 04-1] Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:55:43] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [17:55:48] (03CR) 10jerkins-bot: [V: 04-1] Enforce partial blocks [core] - 10https://gerrit.wikimedia.org/r/456666 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [17:57:58] 10Anti-Harassment (AHT Sprint 28): ANI data: Links per case - https://phabricator.wikimedia.org/T202474 (10dmaza) a:03dmaza [18:00:48] (03PS7) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [18:01:24] (03CR) 10Brian Wolff: "PS7: Fixing me being stupid" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:05:21] (03CR) 10Jforrester: [C: 031] Replace ID selector with class selector (mw-notification-area) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455848 (https://phabricator.wikimedia.org/T203259) (owner: 10Esanders) [18:06:32] (03Merged) 10jenkins-bot: Title: Fix isRawHtmlMessage() for messages with underscores [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456668 (owner: 10Jforrester) [18:07:28] 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions, 10Growth-Team (Current Sprint): Talk page links on small number of pages are broken on the Portuguese Wikibooks - https://phabricator.wikimedia.org/T195126 (10SBisson) Hi @He7d3r, I'm trying to understand what's going on with the broken talk page... [18:08:02] James_F: tgr: I think we still have ~10 extensions outputting raw HTML messages fwiw. I think we'll be able to get through them by the end of next week [18:09:06] legoktm: are you finding those with the taint check plugin? or just by hand? [18:09:51] tgr: using the plugin mostly. In a few cases if the extension is sketchy I'll do a further manual review [18:10:20] But so far I've only come across one false negative that the plugin missed [18:10:36] Nice. [18:10:45] tgr: (Deployed.) [18:10:56] oh, and caveat that the plugin can only spot PHP raw HTML messages, so if it gets output as raw by JS then... [18:12:42] It's a start, at least. [18:13:08] (03Merged) 10jenkins-bot: Various runSearch fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [18:13:37] Maybe we could have mw.message refuse to output as plain() unless a message is in wgRawHtmlMessages? [18:14:19] Or have rawMsg()? Eh. [18:14:20] (03PS8) 10Brian Wolff: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) [18:14:44] James_F: .plain() is ok if you use $obj.text(...) [18:14:49] (03CR) 10Brian Wolff: "PS8: per lego, be specific about phpcs suppressions." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:15:11] The problem would be $obj.html( .plain() ) [18:15:53] (03PS7) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [18:15:59] I meant breaking .msg() so it always returned parsed content, rather than relied on making the decision. [18:16:12] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:16:29] (Or replacing existing methods with new ones, which are either explicitly raw or not.) [18:17:24] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [18:17:28] 10MediaWiki-extensions-General, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10Technical-Debt (Deprecation): Remove deprecated dieUsage, dieUsageMsg, dieUsageMsgOrDebug methods from Extensions - https://phabricator.wikimedia.org/T189222 (10Petar.petkovic) [18:18:17] (03CR) 10jerkins-bot: [V: 04-1] Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:18:32] (03PS8) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [18:19:44] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [18:23:09] (03PS9) 10Legoktm: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:25:19] (03CR) 10jenkins-bot: Various runSearch fixes [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456621 (owner: 10DCausse) [18:25:56] (03PS7) 10Sharvaniharan: [WIP] Show in progress activity when an article in a reading list is being downloaded for offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) [18:27:08] (03CR) 10Legoktm: [C: 032] Use annotations for taint in Parser & ParserOutput. [core] - 10https://gerrit.wikimedia.org/r/456669 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:27:34] (03CR) 10Legoktm: [C: 032] Move builtin taints for Parser&ParserOutput into inline annotations [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456670 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:27:49] (03PS2) 10Legoktm: Prevent NO_OVERRIDE flag from being propagated during assignment [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456626 (https://phabricator.wikimedia.org/T203214) (owner: 10Brian Wolff) [18:28:20] (03CR) 10Legoktm: [C: 032] Prevent NO_OVERRIDE flag from being propagated during assignment [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456626 (https://phabricator.wikimedia.org/T203214) (owner: 10Brian Wolff) [18:29:29] (03PS2) 10Legoktm: Move builtin taints for Parser&ParserOutput into inline annotations [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456670 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:29:36] (03CR) 10Legoktm: [C: 032] "!" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456670 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:30:05] (03CR) 10Legoktm: [C: 032] Add an indirect test case to taghook test [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456597 (owner: 10Brian Wolff) [18:30:12] (03Merged) 10jenkins-bot: Prevent NO_OVERRIDE flag from being propagated during assignment [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456626 (https://phabricator.wikimedia.org/T203214) (owner: 10Brian Wolff) [18:30:34] (03CR) 10Nikerabbit: [C: 032] Namespace translations for Japanese [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456658 (owner: 10Rxy) [18:30:39] (03CR) 10Legoktm: [C: 032] "I don't like bash" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456583 (owner: 10Brian Wolff) [18:31:39] (03PS3) 10Legoktm: Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) (owner: 10Brian Wolff) [18:32:47] (03PS4) 10Brian Wolff: Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) [18:33:30] (03Merged) 10jenkins-bot: Move builtin taints for Parser&ParserOutput into inline annotations [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456670 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:33:32] (03Merged) 10jenkins-bot: Add an indirect test case to taghook test [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456597 (owner: 10Brian Wolff) [18:33:41] (03Merged) 10jenkins-bot: Fix error in argument handling in test script [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456583 (owner: 10Brian Wolff) [18:35:16] (03CR) 10Brian Wolff: "We could make base64_decode mark things as tainted, but we really don't know where it came from, so that could have lots of false positive" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456388 (https://phabricator.wikimedia.org/T202250) (owner: 10Brian Wolff) [18:35:45] (03CR) 10Legoktm: [C: 032] "Sounds good." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456388 (https://phabricator.wikimedia.org/T202250) (owner: 10Brian Wolff) [18:37:18] (03CR) 10Legoktm: [C: 032] Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) (owner: 10Brian Wolff) [18:37:41] (03Merged) 10jenkins-bot: Mark base64_encode as escaping taint. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456388 (https://phabricator.wikimedia.org/T202250) (owner: 10Brian Wolff) [18:38:09] (03CR) 10Legoktm: [C: 032] "PS9: Tweaked the PHPCS exclusions to make it pass." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:40:06] (03Merged) 10jenkins-bot: Make onlysafefor_html not mark things as exec_escaped. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456581 (https://phabricator.wikimedia.org/T201565) (owner: 10Brian Wolff) [18:41:45] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10MarcoAurelio) a:05MarcoAurelio>03None Unnasigning from myself. If it really needs to be done then I can do it, but it's not like recreating it will put the code there ba... [18:41:51] (03CR) 10Umherirrender: Check return of preg_match before processing matches (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/453534 (https://phabricator.wikimedia.org/T123258) (owner: 10Umherirrender) [18:41:58] (03PS8) 10Sharvaniharan: [WIP] Show in progress activity when an article in a reading list is being downloaded for offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) [18:42:50] 10ContentTranslation: CX2: autofill for 'gu' (gujarati) displays some underlying text - https://phabricator.wikimedia.org/T203269 (10Etonkovidova) [18:43:35] (03CR) 10Legoktm: [C: 032] Change @return-taint to use onlysafefor_html instad of escapes_html [core] - 10https://gerrit.wikimedia.org/r/456582 (https://phabricator.wikimedia.org/T202797) (owner: 10Brian Wolff) [18:43:42] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10Paladox) I think that we should at least wait 2+ releases before deleting a mirror as users use it because it reduces stress on the gerrit server [18:46:27] 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions, 10Growth-Team (Current Sprint): Talk page links on small number of pages are broken on the Portuguese Wikibooks - https://phabricator.wikimedia.org/T195126 (10SBisson) I have found [[ https://pt.wikibooks.org/wiki/Utilizador_Discuss%C3%A3o:Raylto... [18:51:27] (03CR) 10Legoktm: [C: 032] "The regex stuff scares me. I would feel a lot more comfortable with a PHP script or something to post-process the checkstyle output." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456397 (owner: 10Brian Wolff) [18:53:48] (03Merged) 10jenkins-bot: Use annotations for taint in Parser & ParserOutput. [core] - 10https://gerrit.wikimedia.org/r/456669 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:53:50] (03Merged) 10jenkins-bot: Namespace translations for Japanese [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456658 (owner: 10Rxy) [18:53:52] (03Merged) 10jenkins-bot: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:53:54] (03Merged) 10jenkins-bot: Make seccheck-mwext and seccheck-fast-mwext work with skins [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/456397 (owner: 10Brian Wolff) [18:54:26] 04(no projects): I fail at 2FA - https://phabricator.wikimedia.org/T203270 (10VWBot) [18:55:59] 10Trust-and-Safety: Reset on-wiki 2FA for VernoWhitney - https://phabricator.wikimedia.org/T203270 (10Aklapper) [18:56:33] (03PS1) 10Smalyshev: Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 [18:56:59] (03CR) 10jenkins-bot: Use annotations for taint in Parser & ParserOutput. [core] - 10https://gerrit.wikimedia.org/r/456669 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [18:57:33] (03CR) 10jerkins-bot: [V: 04-1] Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 (owner: 10Smalyshev) [18:57:57] 10UniversalLanguageSelector: CX2: autofill for 'gu' (gujarati) displays some underlying text - https://phabricator.wikimedia.org/T203269 (10Petar.petkovic) [18:58:10] (03CR) 10jenkins-bot: Namespace translations for Japanese [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456658 (owner: 10Rxy) [18:58:15] (03PS2) 10Smalyshev: Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 [18:58:47] (03PS28) 10Dbarratt: Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [18:58:52] (03PS1) 10Isarra: Less: Linebreaks everywhere, some cleanup [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456674 [19:02:00] 10MediaWiki-extensions-LiquidThreads, 10StructuredDiscussions, 10Growth-Team (Current Sprint): Talk page links on small number of pages are broken on the Portuguese Wikibooks - https://phabricator.wikimedia.org/T195126 (10SBisson) I've edited both pages to remove the invalid redirect and they became valid LQ... [19:04:28] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Jalexander) >>! In T200559#4505772, @Iislucas wrote: > @PEarleyWMF: we discussed privacy implications; can you comment further on this, and if/... [19:04:30] 10MediaWiki-extensions-InputBox, 10VisualEditor, 10VisualEditor-MediaWiki, 10User-Ryasmeen: VE Clickjacking vs Inputbox in editintro - https://phabricator.wikimedia.org/T132145 (10eranroz) 05Open>03Resolved a:03eranroz someone, Somehow, somewhen, has already solved it and it works. [19:04:56] (03PS3) 10Smalyshev: Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 [19:05:33] (03CR) 10jerkins-bot: [V: 04-1] Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 (owner: 10Smalyshev) [19:06:04] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10Regression: PageTriage last use not persisted properly for user session - https://phabricator.wikimedia.org/T203273 (10kostajh) [19:06:12] (03PS4) 10Smalyshev: Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 [19:06:51] (03CR) 10jerkins-bot: [V: 04-1] Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 (owner: 10Smalyshev) [19:08:55] 10Discovery, 10Wikimedia-Portals, 10Browser-Support-Firefox, 10Patch-For-Review: Article-counts on www.wikipedia.org have extra spaces and are not visible on Firefox - https://phabricator.wikimedia.org/T199337 (10Niridya) Thanks for the fix @Jdrewniak ! I test and it works perfect in latest Chrome. When th... [19:10:39] 10Research, 10address-knowledge-gaps: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10bmansurov) [19:12:29] 10MediaWiki-General-or-Unknown, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Krinkle) > We are loading wiki farms in following method: > * /www/mediawiki (all MW code, no config file, no web access) > * /www/a (web acc... [19:12:54] (03CR) 10jenkins-bot: Suppress phan-taint-check false positives in make-normalization-table.php [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/456653 (https://phabricator.wikimedia.org/T202380) (owner: 10Brian Wolff) [19:13:31] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-General, 10Voice & Tone: Replace words "Blacklist" by "Denylist" and "Whitelist" by "Allowlist" - https://phabricator.wikimedia.org/T173080 (10Isarra) 'Blacklist' and 'whitelist' //are// the generic terms. Based on these, 'greylist' is probably about as... [19:13:42] 10MediaWiki-Codesniffer: Add sniff to detect spaces before comma in argument lists - https://phabricator.wikimedia.org/T168970 (10Umherirrender) 05Open>03Resolved a:03Umherirrender > It seems there is no standard sniff for the comma in implements or even a sniff to check for spacing around implements PSR2... [19:14:17] (03Merged) 10jenkins-bot: Change @return-taint to use onlysafefor_html instad of escapes_html [core] - 10https://gerrit.wikimedia.org/r/456582 (https://phabricator.wikimedia.org/T202797) (owner: 10Brian Wolff) [19:15:00] 10MediaWiki-User-management: Entries in Block list are not accurate - https://phabricator.wikimedia.org/T203274 (10Automatik) [19:15:02] 10UniversalLanguageSelector: CX2: autofill for 'gu' (gujarati) displays some underlying text - https://phabricator.wikimedia.org/T203269 (10Etonkovidova) [19:17:43] 10Research, 10address-knowledge-gaps: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10bmansurov) Cursory glance over ru-uz results reveals that the current API is biased towards Russia specific articles and the new API shows results that could very well b... [19:17:46] (03CR) 10jenkins-bot: Change @return-taint to use onlysafefor_html instad of escapes_html [core] - 10https://gerrit.wikimedia.org/r/456582 (https://phabricator.wikimedia.org/T202797) (owner: 10Brian Wolff) [19:18:51] (03CR) 10jerkins-bot: [V: 04-1] Add block restriction classes [core] - 10https://gerrit.wikimedia.org/r/453081 (https://phabricator.wikimedia.org/T202036) (owner: 10Dmaza) [19:20:49] (03PS1) 10Isarra: Make mw-echo-alert (yellow new message link) line up properly with rest of user dropdown things [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456675 [19:21:13] (03CR) 10Smalyshev: Improve Analysis Config Test Coverage and Update Russian Configs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456443 (owner: 10Tjones) [19:24:30] (03PS9) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [19:25:10] 10Research, 10address-knowledge-gaps: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10leila) @bmansurov we discussed this in IRC, a summary for archive happiness re en-fa: * @Ladsgroup will have a look at this pair. * I did some eye-balling and the second... [19:25:54] 10Research: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10leila) [19:28:33] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [19:28:36] 10FormWizard: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Umherirrender) [19:30:28] (03CR) 10BryanDavis: [C: 04-1] Create temp directory too for dumps (031 comment) [vagrant] - 10https://gerrit.wikimedia.org/r/456673 (owner: 10Smalyshev) [19:33:38] (03PS1) 10Brian Wolff: Add taint annotation to HtmlForm::getHTML() [core] - 10https://gerrit.wikimedia.org/r/456676 [19:33:59] (03PS1) 10Krinkle: resources: Use official SRI metadata for qunitjs [core] - 10https://gerrit.wikimedia.org/r/456677 [19:34:16] 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10PerfektesChaos) [19:34:22] (03CR) 10Krinkle: "Test Plan: php manageForeignResources.php verify qunitjs" [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [19:35:13] (03CR) 10Legoktm: [C: 032] Add taint annotation to HtmlForm::getHTML() [core] - 10https://gerrit.wikimedia.org/r/456676 (owner: 10Brian Wolff) [19:35:43] 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) @PerfektesChaos Thanks for reporting. Which browser did you find this issue in? [19:35:57] 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10PerfektesChaos) An older one, I am afraid. [19:37:12] 10MediaWiki-General-or-Unknown, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Zoglun) www.a.com point to /www/a. /www/a contain LocalSettings.php and symlink to each file/folder under /www/mediawiki. Such structure wer... [19:39:26] (03PS10) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [19:40:26] (03CR) 10BryanDavis: [C: 031] Define a default Monolog logger if inexistant [core] - 10https://gerrit.wikimedia.org/r/439874 (https://phabricator.wikimedia.org/T196906) (owner: 10Seb35) [19:41:08] 10MediaWiki-General-or-Unknown, 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) p:05Triage>03Unbreak! Follows-up T201124 and 29c803227f0daea. The unit test should have caught this, but I see now that the unit test for testing the "Math.ran... [19:41:32] 10MediaWiki-General-or-Unknown, 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) >>! In T203275#4549436, @PerfektesChaos wrote: > An older one, I am afraid. Can you be more specific please? Name and numbers :) [19:43:40] 10MediaWiki-General-or-Unknown, 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Nuria) Fix on the way. One Sec. [19:44:22] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [19:45:42] (03PS1) 10Krinkle: mediawiki.user: Update Crypto-fallback test to actually test the fallback [core] - 10https://gerrit.wikimedia.org/r/456678 (https://phabricator.wikimedia.org/T203275) [19:46:31] (03PS1) 10Fomafix: Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 [19:47:18] 10MediaWiki-User-management: Entries in Block list are not accurate - https://phabricator.wikimedia.org/T203274 (10Umherirrender) [19:47:21] 10MediaWiki-User-management: Special:BlockList gives faulty results after an admin changes another admin's block - https://phabricator.wikimedia.org/T199174 (10Umherirrender) [19:48:00] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) [19:48:15] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Performance-Team (Radar), 10Regression: JS crash in mw.user.generateRandomSessionId() - https://phabricator.wikimedia.org/T203275 (10Krinkle) a:05Jdlrobson>03Nuria [19:49:09] 10MediaWiki-Special-pages, 10MediaWiki-User-management: Defect: Special:BlockList incorrectly reports blocking admin on autoblock where block was changed by another admin - https://phabricator.wikimedia.org/T173636 (10JJMC89) [19:49:11] 10MediaWiki-User-management: Special:BlockList gives faulty results after an admin changes another admin's block - https://phabricator.wikimedia.org/T199174 (10JJMC89) [19:51:32] 10Timeless, 10Chinese-Sites: Timeless skin: Echo badges cause header layout problem on Chinese interface - https://phabricator.wikimedia.org/T173811 (10Isarra) Is this resolved? If not, couple you please provide links to where it can still be reproduced? [19:52:16] (03PS1) 10Isarra: Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 [19:52:19] (03CR) 10Legoktm: [C: 04-1] Initial import from nikext from translatewiki repo (036 comments) [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 (owner: 10Nikerabbit) [19:54:21] (03CR) 10jerkins-bot: [V: 04-1] Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [19:54:31] 10MediaWiki-Codesniffer: Add sniff to prevent using config globals when Config is available - https://phabricator.wikimedia.org/T200679 (10Umherirrender) This could be tricky, because the sniff has to decide between config globals and objects/non-config globals. That means the sniff needs the way to set globals... [19:54:50] 10MediaWiki-General-or-Unknown, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Krinkle) >>! In T203061#4549437, @Zoglun wrote: > www.a.com point to /www/a. > /www/a contain LocalSettings.php and symlink to each file/fold... [19:54:53] (03Merged) 10jenkins-bot: Add taint annotation to HtmlForm::getHTML() [core] - 10https://gerrit.wikimedia.org/r/456676 (owner: 10Brian Wolff) [19:55:03] 10MediaWiki-General-or-Unknown, 10MediaWiki-Installer, 10MW-1.31-release: Mediawiki 1.31 break symlinked, cause LocalSettings.php failed to load. - https://phabricator.wikimedia.org/T203061 (10Krinkle) p:05Triage>03High [19:56:12] (03CR) 10jerkins-bot: [V: 04-1] resources: Use official SRI metadata for qunitjs [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [19:56:24] (03PS1) 10Nuria: Proper initialization of array on generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) [19:56:46] (03CR) 10Krinkle: "T182266" [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [19:56:50] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [19:57:09] (03PS2) 10Isarra: Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 [19:57:53] (03CR) 10jenkins-bot: Add taint annotation to HtmlForm::getHTML() [core] - 10https://gerrit.wikimedia.org/r/456676 (owner: 10Brian Wolff) [19:58:00] (03CR) 10Krinkle: [C: 031] Test data providers should never access the database. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/456636 (owner: 10Daniel Kinzler) [19:58:26] (03Abandoned) 10Krinkle: Assets build - 2018-08-20 09:39:13+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/453979 (owner: 10PortalsBuilder) [19:58:28] (03CR) 10jerkins-bot: [V: 04-1] mediawiki.user: Update Crypto-fallback test to actually test the fallback [core] - 10https://gerrit.wikimedia.org/r/456678 (https://phabricator.wikimedia.org/T203275) (owner: 10Krinkle) [19:59:38] (03CR) 10Krinkle: Proper initialization of array on generateRandomSessionId (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [20:00:00] (03CR) 10Isarra: [C: 032] "Ah, whatever." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/441749 (https://phabricator.wikimedia.org/T181491) (owner: 10Jack Phoenix) [20:00:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/456681 (owner: 10L10n-bot) [20:00:35] (03PS1) 10MGChecker: Replace bool default vlaues with their string casts [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 [20:01:27] 10donate.wikimedia.org: Add email opt-in to donatewiki forms - https://phabricator.wikimedia.org/T202327 (10MNoorWMF) I dug around inside donatewiki for a couple of days but wasn't able to find where the DonationInterface translations were to be able to make the translation changes :( Curious if @spatton or m... [20:01:35] (03PS7) 10Milimetric: Move event validation to debug module (1/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) [20:01:44] (03CR) 10Milimetric: Move event validation to debug module (1/2) (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [20:02:20] (03PS1) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 [20:02:42] (03CR) 10Krinkle: Use "break" instead of "continue" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/454852 (https://phabricator.wikimedia.org/T200595) (owner: 10星耀晨曦) [20:03:08] (03PS2) 10Legoktm: Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 [20:03:11] (03PS2) 10Legoktm: Suppress warning for legitimate case of double escaping [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456558 [20:03:14] (03PS2) 10Legoktm: Add extra shell escaping for paranoia [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456559 [20:03:16] (03PS3) 10Isarra: Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 [20:03:25] (03CR) 10Krinkle: [C: 031] "Not a particularly unimportant feature, viewing pages. Better late than never?" [core] - 10https://gerrit.wikimedia.org/r/453190 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [20:03:54] (03PS7) 10MGChecker: Add further parser tests [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455061 (https://phabricator.wikimedia.org/T193036) [20:04:06] (03PS1) 10Krinkle: jobqueue: Use explicit retry when refreshLinks can't get a lock [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456688 (https://phabricator.wikimedia.org/T170596) [20:04:51] (03CR) 10jerkins-bot: [V: 04-1] Move event validation to debug module (1/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [20:05:10] (03CR) 10Legoktm: "OK, I'm now having it send the logs through the debug logger (totally safe), which people can manually configure to go to stdout if they w" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:05:26] (03PS2) 10MGChecker: Replace bool default values with their string casts [extensions/Variables] - 10https://gerrit.wikimedia.org/r/456686 [20:05:30] (03PS1) 10Dbrant: WIP: Huge optimization: rework Retrofit network layer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456689 [20:05:52] 10MediaWiki-extensions-Variables, 10Patch-For-Review: Fix issues because of early-expanded arguments - https://phabricator.wikimedia.org/T202679 (10MGChecker) 05Open>03Resolved [20:06:05] (03PS5) 10Smalyshev: Create temp directory too for dumps [vagrant] - 10https://gerrit.wikimedia.org/r/456673 [20:06:09] 10MediaWiki-extensions-Variables: Fix issues because of early-expanded arguments - https://phabricator.wikimedia.org/T202679 (10MGChecker) [20:06:15] (03CR) 10Jforrester: [C: 031] Send WebVideoTranscodeJob debugging through the normal logger (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:07:16] (03Merged) 10jenkins-bot: Language links box should not have an unnecessary scrollbar [skins/Timeless] - 10https://gerrit.wikimedia.org/r/441749 (https://phabricator.wikimedia.org/T181491) (owner: 10Jack Phoenix) [20:07:33] 10Security-Reviews, 10Security-Team: Security review of EU copyright stuff - https://phabricator.wikimedia.org/T203095 (10CCicalese_WMF) > If this is for a single page only, then it might significantly simplify things to not build a skin for it, but instead merge the skin and the special page this wiki uses as... [20:07:45] (03CR) 10Umherirrender: [C: 032] Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 (owner: 10Fomafix) [20:08:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456685 (owner: 10L10n-bot) [20:09:13] (03CR) 10jerkins-bot: [V: 04-1] WIP: Huge optimization: rework Retrofit network layer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456689 (owner: 10Dbrant) [20:09:25] (03CR) 10jerkins-bot: [V: 04-1] Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (owner: 10Umherirrender) [20:09:27] (03CR) 10jerkins-bot: [V: 04-1] Proper initialization of array on generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [20:09:55] (03PS8) 10MGChecker: Add further parser tests [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455061 (https://phabricator.wikimedia.org/T193036) [20:10:58] (03PS11) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [20:11:30] (03PS16) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [20:11:55] (03CR) 10Jack Phoenix: [C: 032] Make navigation block text stay inside blocks/break-word [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450279 (owner: 10Isarra) [20:12:09] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [20:12:39] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [20:12:55] (03CR) 10Jack Phoenix: [C: 032] "Consistency is good to have, yes, and it's no doubt what the users expect as well." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450283 (owner: 10Isarra) [20:13:40] 10MediaWiki-API, 10Developer-Advocacy, 10Web-APIs-Hub, 10Documentation: Improve discoverability of MediaWiki API - https://phabricator.wikimedia.org/T98904 (10srodlund) @srishakatux and I were discussing changing the name for https://www.mediawiki.org/wiki/API:Main_page to MediaWiki Action API to more accu... [20:15:23] (03CR) 10Jack Phoenix: [C: 032] "Yay for readability!" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456674 (owner: 10Isarra) [20:15:31] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [20:16:17] 10ContentTranslation: CX2: Vertical timeline is enormous - https://phabricator.wikimedia.org/T203277 (10Petar.petkovic) [20:17:58] (03PS18) 10Jforrester: Drop ResourceLoaderRegisterModules, scrap NewMwEmbedResourceManager [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 [20:18:01] (03PS7) 10Jforrester: Move MwEmbed static resources into the static resources directory [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454922 [20:18:17] (03PS4) 10Jforrester: build: Pin stylelint to 9.2.0 as required by stylelint-config-wikimedia 0.4.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 [20:18:27] (03PS4) 10Jforrester: Drop duplicate NewMwEmbedSupport i18n registration [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455907 [20:18:41] (03CR) 10Legoktm: [C: 032] Fix wfDebug() test so that it works with overridden SPI [core] - 10https://gerrit.wikimedia.org/r/456540 (owner: 10Tim Starling) [20:19:34] 10MediaWiki-API, 10Developer-Advocacy, 10Web-APIs-Hub, 10Documentation: Improve discoverability of MediaWiki API - https://phabricator.wikimedia.org/T98904 (10bd808) >>! In T98904#4549517, @srodlund wrote: > @srishakatux and I were discussing changing the name for https://www.mediawiki.org/wiki/API:Main_pa... [20:20:48] (03CR) 10jerkins-bot: [V: 04-1] jobqueue: Use explicit retry when refreshLinks can't get a lock [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456688 (https://phabricator.wikimedia.org/T170596) (owner: 10Krinkle) [20:22:04] (03CR) 10Krinkle: "recheck" [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456688 (https://phabricator.wikimedia.org/T170596) (owner: 10Krinkle) [20:22:54] 10ContentTranslation, 10Easy, 10MW-1.29-release (WMF-deploy-2017-02-07_(1.29.0-wmf.11)), 10Technical-Debt, 10WorkType-Maintenance: Multi word articles use spaces instead of underscores in link card inks - https://phabricator.wikimedia.org/T147625 (10Petar.petkovic) [20:23:28] 10ContentTranslation, 10Easy, 10I18n, 10MW-1.29-release (WMF-deploy-2016-12-13_(1.29.0-wmf.6)), 10WorkType-Maintenance: the header text at Special:ContentTranslation and Special:ContentTranslationStats is the same - https://phabricator.wikimedia.org/T117191 (10Petar.petkovic) [20:23:48] 10ContentTranslation, 10MW-1.27-release (WMF-deploy-2016-04-05_(1.27.0-wmf.20)), 10WorkType-Maintenance: Add user-agent header in your requests to VirtualRestService - https://phabricator.wikimedia.org/T131172 (10Petar.petkovic) [20:24:16] 10ContentTranslation, 10Easy, 10WorkType-Maintenance: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546 (10Petar.petkovic) [20:24:32] (03CR) 10Jforrester: "PS18: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [20:24:43] (03CR) 10Jforrester: "PS7: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454922 (owner: 10Jforrester) [20:24:46] (03PS4) 10Jforrester: Move MwEmbed- and EmbedPlayer-related i18n to i18n/ [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 [20:24:54] 10ContentTranslation, 10Unplanned-Sprint-Work, 10WorkType-Maintenance: Show ULS trigger at personal toolbar in Special:CX - https://phabricator.wikimedia.org/T96648 (10Petar.petkovic) [20:25:08] (03CR) 10Jforrester: "PS4: Manual rebase over interceding patch." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455908 (owner: 10Jforrester) [20:25:16] (03PS2) 10Jforrester: .phpcs.xml: Drop exemption for now-deleted MwEmbedModules dir [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456018 [20:25:35] (03CR) 10Daniel Kinzler: [C: 031] "> For some unspecified future it'd be nice if we could figure out how to get the testing DBs set up before PHPUnit does the data providers" [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [20:25:38] 10ContentTranslation, 10MW-1.27-release (WMF-deploy-2016-03-29_(1.27.0-wmf.19)), 10WorkType-Maintenance: cxserver does not send normalized titles to restbase - https://phabricator.wikimedia.org/T130580 (10Petar.petkovic) [20:26:11] (03PS17) 10Daniel Kinzler: Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) [20:26:13] 10ContentTranslation, 10WorkType-NewFunctionality: Enable machine translation for English<->Dutch - https://phabricator.wikimedia.org/T129190 (10Petar.petkovic) [20:26:33] 10ContentTranslation, 10WorkType-NewFunctionality: Make daily CX failures report more detailed by failures type - https://phabricator.wikimedia.org/T127283 (10Petar.petkovic) [20:26:42] (03CR) 10Krinkle: "As I understand it, that was the case when they were written in Ruby, and in fact depended on Beta and didn't work against plain master or" [core] - 10https://gerrit.wikimedia.org/r/446543 (https://phabricator.wikimedia.org/T199446) (owner: 10Pablo Grass (WMDE)) [20:27:47] (03CR) 10BryanDavis: [C: 031] "The puppet changes are fine. I'll leave it to those of you who are working with this role to decide if the actual change it makes is a goo" [vagrant] - 10https://gerrit.wikimedia.org/r/456673 (owner: 10Smalyshev) [20:27:51] (03CR) 10Krinkle: WIP Selenium: add selenium-daily NPM script (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/449485 (https://phabricator.wikimedia.org/T188742) (owner: 10Zfilipin) [20:27:55] 10ContentTranslation: Sanitize MT service output HTML - https://phabricator.wikimedia.org/T169295 (10Petar.petkovic) [20:28:31] 10ContentTranslation, 10WorkType-Maintenance: Special:ContentTranslation three-dots menu overflows the Notifications fly-out - https://phabricator.wikimedia.org/T124873 (10Petar.petkovic) [20:29:01] 10Editing Q1 2018-19 mobile improvements, 10Patch-For-Review, 10VisualEditor (Current work): Edit interface loaded with double toolbar on mobile web - https://phabricator.wikimedia.org/T202513 (10Ryasmeen) This is going to be moved to "Done" column, once it's verified on production next week. [20:29:32] (03Merged) 10jenkins-bot: Start showing warning for deprecated PHP entry point [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456679 (owner: 10Fomafix) [20:29:34] (03Merged) 10jenkins-bot: Make navigation block text stay inside blocks/break-word [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450279 (owner: 10Isarra) [20:29:36] (03Merged) 10jenkins-bot: More consistent .center and toc alignment rules with other skins [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450283 (owner: 10Isarra) [20:29:41] (03Merged) 10jenkins-bot: Less: Linebreaks everywhere, some cleanup [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456674 (owner: 10Isarra) [20:29:47] (03CR) 10Legoktm: Send WebVideoTranscodeJob debugging through the normal logger (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:29:55] (03CR) 10Tjones: Improve Analysis Config Test Coverage and Update Russian Configs (031 comment) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456443 (owner: 10Tjones) [20:30:13] (03CR) 10Milimetric: "I'm running into this problem testing on vagrant. If I try to set debug mode from MainPage, I get an error. And if I try to set it from " [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [20:30:16] 10ContentTranslation, 10MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)), 10Technical-Debt, 10WorkType-Maintenance: Update ContentTranslation mediawiki_selenium Ruby gem to version 1.x - https://phabricator.wikimedia.org/T115319 (10Petar.petkovic) [20:30:45] (03CR) 10Jforrester: [C: 032] Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:30:52] 10MediaWiki-Core-Tests: Prevent database access in phpunit data providers - https://phabricator.wikimedia.org/T203279 (10daniel) [20:31:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/456696 (owner: 10L10n-bot) [20:31:42] (03CR) 10jerkins-bot: [V: 04-1] build: Pin stylelint to 9.2.0 as required by stylelint-config-wikimedia 0.4.3 [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 (owner: 10Jforrester) [20:32:38] 10ContentTranslation, 10GapFinder, 10Language-Team, 10Research, 10Article-Recommendation: Article recommendation experiment: French Wikipedia - https://phabricator.wikimedia.org/T101944 (10Petar.petkovic) [20:33:51] (03CR) 10Krinkle: Move event validation to debug module (1/2) (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [20:34:07] (03PS2) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 [20:34:30] 10MediaWiki-extensions-MwEmbedSupport, 10GitHub-Mirrors: Recreate MwEmbedSupport on github - https://phabricator.wikimedia.org/T203245 (10Legoktm) 05Open>03declined Please update your clones to use Gerrit instead. If Gerrit performance is an issue, we should have a separate bug tracking that, because GitH... [20:35:10] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/456705 (owner: 10L10n-bot) [20:35:32] 10MediaWiki-Core-Tests: Prevent database access in phpunit data providers - https://phabricator.wikimedia.org/T203279 (10daniel) [20:36:38] (03CR) 10Krinkle: [C: 032] Update JavaScript task runner to use recent pattern [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/454791 (owner: 10D3r1ck01) [20:36:42] (03PS2) 10Daniel Kinzler: Avoid constructing Title objects in data providers [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [20:37:08] (03CR) 10Krinkle: [C: 031] "Untested. Code LGTM." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/454356 (owner: 10Jforrester) [20:37:54] (03CR) 10jerkins-bot: [V: 04-1] Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (owner: 10Umherirrender) [20:38:24] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [20:38:32] (03CR) 10Daniel Kinzler: [C: 031] "PS2 addresses my own comments from PS1, improving two comments. Restoring CR+1." [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [20:39:02] (03CR) 10Daniel Kinzler: [C: 031] Avoid constructing Title objects in data providers (032 comments) [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [20:39:37] (03CR) 10Krinkle: Avoid constructing Title objects in data providers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [20:40:11] 10ContentTranslation, 10WorkType-Maintenance: Publishing fails when publish target is User namespace - https://phabricator.wikimedia.org/T174792 (10Petar.petkovic) a:05Arrbee>03KartikMistry [20:40:21] (03CR) 10Jforrester: [C: 032] resources: Use official SRI metadata for qunitjs [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [20:40:43] 10ContentTranslation: CX requires Node 6 because of JSDOM - https://phabricator.wikimedia.org/T176212 (10Petar.petkovic) [20:41:21] 10ContentTranslation: Update apertium-cat, apertium-srd, apertium-ita and apertium-srd-ita packages - https://phabricator.wikimedia.org/T174988 (10Petar.petkovic) [20:41:25] (03PS9) 10Sharvaniharan: Show in progress activity when an article in a reading list is being downloaded for offline [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/455048 (https://phabricator.wikimedia.org/T166398) [20:41:36] (03PS3) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 [20:42:20] (03CR) 10Krinkle: [C: 032] jobqueue: Use explicit retry when refreshLinks can't get a lock [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456688 (https://phabricator.wikimedia.org/T170596) (owner: 10Krinkle) [20:42:30] (03PS1) 10Zoranzoki21: Remove space before the end of the sentence and the interruption sign in message bs-upload-upload-waitmessage [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 [20:42:47] (03Merged) 10jenkins-bot: Fix wfDebug() test so that it works with overridden SPI [core] - 10https://gerrit.wikimedia.org/r/456540 (owner: 10Tim Starling) [20:42:50] (03PS2) 10Zoranzoki21: Remove space before the end of the sentence and the interruption sign in message bs-upload-upload-waitmessage [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 [20:42:58] (03PS3) 10Zoranzoki21: Remove space before the end of the sentence and the interruption sign in message bs-upload-upload-waitmessage [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 [20:43:12] 10MediaWiki-extensions-LiquidThreads, 10phan-taint-check-plugin: phan-taint-check regression in LiquidThreads - https://phabricator.wikimedia.org/T203281 (10Legoktm) [20:43:46] Krinkle: So I think the idea is that when "examples" extension is loaded, it loads all the extensions inside it right? Or should it be that each and every extesion in the "examples" folder be loaded in the LocalSettings.php? [20:44:37] (03CR) 10Jforrester: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/455906 (owner: 10Jforrester) [20:45:32] d3r1ck: it should enable all three automatically, yes [20:45:44] (03CR) 10Zoranzoki21: "This currently can not be merged because I no want to conflict happen with my bot and this patch. I will say when this can be merged." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (owner: 10Zoranzoki21) [20:45:54] d3r1ck: but the parameter of wfLoadExtension is relative to mediawiki/extensions; -not relative to current directory. [20:45:55] Perfect. In that case, my comment on the patch is right Krinkle :) [20:46:17] so it looks like the patch breaks them. [20:46:20] Krinkle: Yeah, I saw your comment but both don't work yet. But will fix it in upcoming patches [20:46:20] but I'll check again later. [20:46:21] Thanks! [20:46:36] (03CR) 10jerkins-bot: [V: 04-1] Use RevisionRenderer for rendering ParserOutput [core] - 10https://gerrit.wikimedia.org/r/452708 (https://phabricator.wikimedia.org/T174035) (owner: 10Daniel Kinzler) [20:46:43] Krinkle: Okay, thanks! :) [20:47:00] (03CR) 10Jack Phoenix: [C: 032] Prevent page indicators from interfering with firstheading and causing overflow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450284 (owner: 10Isarra) [20:47:53] (03CR) 10jenkins-bot: Fix wfDebug() test so that it works with overridden SPI [core] - 10https://gerrit.wikimedia.org/r/456540 (owner: 10Tim Starling) [20:47:58] (03PS2) 10Mepps: Fix build by removing json requirement--only makes sense for 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456645 [20:48:00] (03PS5) 10Mepps: Updates to make question creation and editing work [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456165 [20:48:02] (03PS7) 10Mepps: Update fancybox and JSON to get survey front-end working [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456166 [20:48:04] (03PS4) 10Zoranzoki21: Fix typos in bs-upload-upload-waitmessage and bs-upload-uploadwarningdialog-intro messages in i18n/upload/en.json [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 [20:49:27] (03CR) 10Jack Phoenix: [C: 032] Make mw-echo-alert (yellow new message link) line up properly with rest of user dropdown things [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456675 (owner: 10Isarra) [20:49:43] (03CR) 10jerkins-bot: [V: 04-1] Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (owner: 10Umherirrender) [20:49:45] (03CR) 10Nikerabbit: Initial import from nikext from translatewiki repo (035 comments) [extensions/UILangCode] - 10https://gerrit.wikimedia.org/r/456627 (owner: 10Nikerabbit) [20:49:47] (03CR) 10Jack Phoenix: [C: 032] "Oh Echo..." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [20:49:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/456702 (owner: 10L10n-bot) [20:50:02] (03Merged) 10jenkins-bot: Send WebVideoTranscodeJob debugging through the normal logger [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/456557 (owner: 10Legoktm) [20:50:04] (03Merged) 10jenkins-bot: Update JavaScript task runner to use recent pattern [extensions/BoilerPlate] - 10https://gerrit.wikimedia.org/r/454791 (owner: 10D3r1ck01) [20:51:22] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Need-volunteer, 10Patch-For-Review: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) [20:51:33] (03PS1) 10Nikerabbit: COPYING: Trim unnecessary custom preamble [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456747 [20:51:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/456710 (owner: 10L10n-bot) [20:52:05] (03PS2) 10Dbrant: WIP: Huge optimization: rework Retrofit network layer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456689 [20:53:45] (03PS14) 10Daniel Kinzler: [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) [20:53:49] 10Accessibility, 10VisualEditor-Tables, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Verified, 10VisualEditor (Current work): Cursor into and out of table captions correctly with up/down arrow - https://phabricator.wikimedia.org/T201870 (10Ryasmeen) [20:54:27] (03PS9) 10Mepps: New version 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/424865 (https://phabricator.wikimedia.org/T189687) (owner: 10Zoranzoki21) [20:54:29] (03PS1) 10Mepps: Test if this fixes build for 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456748 [20:54:51] (03Abandoned) 10Mepps: Fix build by removing json requirement--only makes sense for 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456645 (owner: 10Mepps) [20:56:07] (03CR) 10jerkins-bot: [V: 04-1] WIP: Huge optimization: rework Retrofit network layer. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456689 (owner: 10Dbrant) [20:58:19] (03CR) 10Daniel Kinzler: [C: 031] "I agree that this is the right thing to do, and the code looks good at a glance. I'd give this a few more days for people to look at it, b" [core] - 10https://gerrit.wikimedia.org/r/456543 (owner: 10Tim Starling) [20:58:39] (03CR) 10Nikerabbit: [C: 032] Use 1.30 as minimum required version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456647 (owner: 10Petar.petkovic) [21:00:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/456715 (owner: 10L10n-bot) [21:00:17] (03Merged) 10jenkins-bot: resources: Use official SRI metadata for qunitjs [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [21:00:19] (03PS15) 10Daniel Kinzler: [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) [21:00:21] (03Merged) 10jenkins-bot: Prevent page indicators from interfering with firstheading and causing overflow [skins/Timeless] - 10https://gerrit.wikimedia.org/r/450284 (owner: 10Isarra) [21:00:23] (03Merged) 10jenkins-bot: Make mw-echo-alert (yellow new message link) line up properly with rest of user dropdown things [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456675 (owner: 10Isarra) [21:00:26] (03CR) 10jerkins-bot: [V: 04-1] Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [21:00:42] 10MediaWiki-API, 10Developer-Advocacy, 10Web-APIs-Hub, 10Documentation: Improve discoverability of MediaWiki API - https://phabricator.wikimedia.org/T98904 (10srodlund) I believe it is still our intent to keep it in the API namespace: API: MediaWiki Action API . This is a suggested title -- so any feedback... [21:01:36] (03CR) 10jerkins-bot: [V: 04-1] New version 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/424865 (https://phabricator.wikimedia.org/T189687) (owner: 10Zoranzoki21) [21:01:41] (03CR) 10jerkins-bot: [V: 04-1] Test if this fixes build for 0.4.0 [extensions/Survey] - 10https://gerrit.wikimedia.org/r/456748 (owner: 10Mepps) [21:02:30] (03PS12) 10Mglaser: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:02:59] (03CR) 10jenkins-bot: resources: Use official SRI metadata for qunitjs [core] - 10https://gerrit.wikimedia.org/r/456677 (owner: 10Krinkle) [21:04:51] (03Merged) 10jenkins-bot: jobqueue: Use explicit retry when refreshLinks can't get a lock [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456688 (https://phabricator.wikimedia.org/T170596) (owner: 10Krinkle) [21:04:55] (03PS5) 10Zoranzoki21: i18n/upload/en.json: Fix typos in bs-upload-upload-waitmessage and bs-upload-uploadwarningdialog-intro messages [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) [21:05:10] (03CR) 10Zoranzoki21: "You can merge that now." [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [21:05:27] (03CR) 10Petar.petkovic: [C: 032] COPYING: Trim unnecessary custom preamble [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456747 (owner: 10Nikerabbit) [21:06:06] 10donate.wikimedia.org: Add email opt-in to donatewiki forms - https://phabricator.wikimedia.org/T202327 (10TSkaff) I tried to find it and failed. Will document for the banner team when I learn where it's located :) [21:06:36] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/456718 (owner: 10L10n-bot) [21:08:12] (03PS1) 10Zoranzoki21: Fix "occured" typo in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [21:08:20] (03CR) 10jerkins-bot: [V: 04-1] WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:11:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/456716 (owner: 10L10n-bot) [21:11:21] (03PS2) 10Zoranzoki21: Fix "occured" typo in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) [21:13:33] (03PS6) 10Zoranzoki21: Fix common typos in code [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) [21:17:12] (03Merged) 10jenkins-bot: Use 1.30 as minimum required version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456647 (owner: 10Petar.petkovic) [21:18:17] (03PS13) 10ItSpiderman: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:18:20] (03CR) 10Nikerabbit: [C: 032] Expand special page aliases for Serbian [core] - 10https://gerrit.wikimedia.org/r/453477 (owner: 10Petar.petkovic) [21:18:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/456721 (owner: 10L10n-bot) [21:19:35] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) (owner: 10Daniel Kinzler) [21:20:12] (03CR) 10Jack Phoenix: [C: 032] "recheck" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [21:20:14] (03CR) 10Zoranzoki21: [C: 031] Expand special page aliases for Serbian [core] - 10https://gerrit.wikimedia.org/r/453477 (owner: 10Petar.petkovic) [21:21:55] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-log-errors: Special:CreateAccount causes ApiValidatePassword to log a DBPerformance warning from CentralAuth - https://phabricator.wikimedia.org/T203283 (10Krinkle) [21:23:07] 10Developer-Advocacy, 10Wikispeech, 10Documentation, 10Epic: Work with Wikispeech towards their production deployment goal and generate documentation - https://phabricator.wikimedia.org/T200735 (10bd808) @Lokal_Profil, @Sebastian_Berlin-WMSE, @Jopparn, and I met on 2018-09-30 to discuss next steps for this... [21:23:36] (03PS14) 10Mglaser: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:23:58] 10MediaWiki-User-preferences, 10UI-Standardization: Beta features tab lead message in Special:Preferences doesn't play nicely with OOUI - https://phabricator.wikimedia.org/T203202 (10matmarex) This was caused by 2a706f4dec30ed5ff13f5421c75b400731b79202 and fixed by 2a92d52a6185fffea20723089aaa437db55739d2. App... [21:24:30] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10Wikimedia-log-errors: Special:CreateAccount causes ApiValidatePassword to log a DBPerformance warning from CentralAuth - https://phabricator.wikimedia.org/T203283 (10Krinkle) [21:24:38] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10Core-Platform-Team, 10Wikimedia-log-errors: Special:CreateAccount causes ApiValidatePassword to log a DBPerformance warning from CentralAuth - https://phabricator.wikimedia.org/T203283 (10Krinkle) [21:25:41] 10MediaWiki-API, 10MediaWiki-extensions-CentralAuth, 10Core-Platform-Team, 10Wikimedia-log-errors: Special:CreateAccount causes ApiValidatePassword to log a DBPerformance warning from CentralAuth - https://phabricator.wikimedia.org/T203283 (10Krinkle) [21:27:28] (03CR) 10Mooeypoo: [C: 04-1] "I might be missing something, I couldn't immediately find it in the code -- where are we adding this test template so that it's found in t" (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/454479 (https://phabricator.wikimedia.org/T199580) (owner: 10Samwilson) [21:27:39] (03CR) 10Mglaser: [C: 031] "ok for me, waiting for i18n" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/456746 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [21:28:07] (03Merged) 10jenkins-bot: COPYING: Trim unnecessary custom preamble [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456747 (owner: 10Nikerabbit) [21:30:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/456724 (owner: 10L10n-bot) [21:31:04] 10Patch-For-Review, 10Technical-Debt, 10VisualEditor (Current work): Don't assume commands exist when building CommandHelpDialog - https://phabricator.wikimedia.org/T203282 (10Esanders) [21:31:40] (03CR) 10Mooeypoo: [C: 04-1] "Sorry, I was apparently not in current master, so I missed the 'fixture' for the template that was added in a previous commit." [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/454479 (https://phabricator.wikimedia.org/T199580) (owner: 10Samwilson) [21:32:04] (03CR) 10jerkins-bot: [V: 04-1] Fix "occured" typo in code [core] - 10https://gerrit.wikimedia.org/r/456750 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [21:33:53] (03CR) 10jerkins-bot: [V: 04-1] Expand special page aliases for Serbian [core] - 10https://gerrit.wikimedia.org/r/453477 (owner: 10Petar.petkovic) [21:34:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/UserMerge] - 10https://gerrit.wikimedia.org/r/456731 (owner: 10L10n-bot) [21:39:02] (03PS15) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:39:02] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10Mooeypoo) Where should the focus be when you just load the template? I'd think it should be c... [21:39:20] (03CR) 10Mooeypoo: [C: 032] When removing a field, focus top-most empty field or the add-all button [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/453896 (https://phabricator.wikimedia.org/T198926) (owner: 10Samwilson) [21:39:37] (03Merged) 10jenkins-bot: Expand special page aliases for Serbian [core] - 10https://gerrit.wikimedia.org/r/453477 (owner: 10Petar.petkovic) [21:41:25] (03PS16) 10Cicalese: WIP: Initial commit [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:41:45] (03CR) 10jerkins-bot: [V: 04-1] Prevent echo labels from overflowing over the personal dropdown and interfering with the hover activation [skins/Timeless] - 10https://gerrit.wikimedia.org/r/456680 (owner: 10Isarra) [21:43:02] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix - https://phabricator.wikimedia.org/T203284 (10Catrope) [21:44:17] 10English-Wikipedia-New-Pages-Patrol, 10Epic, 10Growth-Team (Current Sprint): New Pages Feed: copyvio addition - https://phabricator.wikimedia.org/T199359 (10MMiller_WMF) [21:44:19] 10MediaWiki-extensions-PageCuration, 10Growth-Team: "Copyvio" link to CopyPatrol doesn't work for drafts, should drop Draft: namespace prefix - https://phabricator.wikimedia.org/T203284 (10MMiller_WMF) [21:44:48] 10ContentTranslation: CX2: Previously blanked section not saved when switched to MT - https://phabricator.wikimedia.org/T203285 (10Petar.petkovic) [21:46:03] (03CR) 10jenkins-bot: Expand special page aliases for Serbian [core] - 10https://gerrit.wikimedia.org/r/453477 (owner: 10Petar.petkovic) [21:48:43] 10ContentTranslation, 10Product-Analytics, 10Language-2018-July-September: Apply a distinct tag to edits made using Content Translation 2 during its beta - https://phabricator.wikimedia.org/T201539 (10Petar.petkovic) [21:51:16] (03Merged) 10jenkins-bot: When removing a field, focus top-most empty field or the add-all button [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/453896 (https://phabricator.wikimedia.org/T198926) (owner: 10Samwilson) [21:51:26] (03CR) 10Cicalese: "check experimental" [extensions/EUCopyrightCampaign] - 10https://gerrit.wikimedia.org/r/456122 (owner: 10Robert Vogel) [21:51:44] (03PS9) 10Fomafix: Allow and use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/447504 [21:51:46] (03PS9) 10Fomafix: [REL-1.33] Force type Language for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/447505 [21:51:58] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Copyvio: prepare Test Wiki for community testing - https://phabricator.wikimedia.org/T203119 (10Catrope) I have created 3 pages in NPP and 3 pages in AFC. One each with: - Only one revision, which is marked copyvio - Two revisions, both of wh... [21:52:01] (03PS6) 10Fomafix: Deprecate other types than Language for $lang of tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/445959 [21:52:03] (03PS8) 10Fomafix: [REL-1.33] Force type Language for $lang in tocList and generateTOC [core] - 10https://gerrit.wikimedia.org/r/437488 [21:53:45] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team: New Pages Feed: run ORES backfill script in English Wikipedia - https://phabricator.wikimedia.org/T203286 (10MMiller_WMF) [21:53:57] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review: New Pages Feed: backfill ORES scores for unscored drafts (3.3) - https://phabricator.wikimedia.org/T198982 (10MMiller_WMF) @SBisson -- got it. So we'll... [21:54:14] 04(no projects): TemplateWizard buttons (-/+ fields and 'add/remove all') do not activate on "enter" - https://phabricator.wikimedia.org/T203287 (10Mooeypoo) [21:54:48] (03PS1) 10Mooeypoo: Listen to click event instead of overriding 'onClick' [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/456756 (https://phabricator.wikimedia.org/T203287) [21:55:34] 10MediaWiki-extensions-RelatedSites, 10Community-Tech, 10CommRel-Specialists-Support (Jul-Sep-2018): Contact wikivoyages with fewer than 500 pages using RelatedSites about deprecation - https://phabricator.wikimedia.org/T201536 (10Keegan) @Niharika bumped the translator request for one more round, I only hav... [21:56:57] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10Mooeypoo) The use of keyboard actions (once we're already on any button) is solved through th... [21:58:11] (03PS3) 10Cooltey: Fix: Add Serializable to child objects to avoid crashes [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456518 [21:58:28] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team: [EPIC] Prioritization tools for AfC and NPP - https://phabricator.wikimedia.org/T193782 (10MMiller_WMF) [21:58:31] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), 10Patch-For-Review: "Nominated for deletion" filter doesn't work - https://phabricator.wikimedia.org/T202582 (10MMiller_WMF) [22:05:19] (03CR) 10Daniel Kinzler: [C: 031] Avoid constructing Title objects in data providers (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456542 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [22:08:01] 10MW-1.32-release-notes (WMF-deploy-2018-09-04 (1.32.0-wmf.20)), 10Patch-For-Review, 10Verified, 10VisualEditor (Current work): Description link message missing from gallery dialog in mobile - https://phabricator.wikimedia.org/T203262 (10Ryasmeen) [22:15:48] (03CR) 10Tim Starling: Introduce NameTableStoreFactory (032 comments) [core] - 10https://gerrit.wikimedia.org/r/455487 (https://phabricator.wikimedia.org/T202641) (owner: 10Tim Starling) [22:17:10] (03CR) 10Milimetric: Move event validation to debug module (1/2) (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:17:37] (03PS8) 10Milimetric: Move event validation to debug module (1/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) [22:17:58] (03PS2) 10Aaron Schulz: Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456554 (https://phabricator.wikimedia.org/T203154) [22:18:34] (03PS5) 10Cicalese: Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [22:18:49] (03CR) 10jenkins-bot: Use 1.30 as minimum required version [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456647 (owner: 10Petar.petkovic) [22:20:15] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [skins/EUCopyrightCampaignSkin] - 10https://gerrit.wikimedia.org/r/456123 (owner: 10Robert Vogel) [22:20:19] (03CR) 10jerkins-bot: [V: 04-1] Move event validation to debug module (1/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:20:25] (03PS4) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 [22:21:13] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Technical-Debt: Deprecate $wgTitle completely - https://phabricator.wikimedia.org/T159284 (10Izno) [22:21:19] (03CR) 10Umherirrender: "Last pass was on Ida53c8673c6e292bd5f645c411b8d2317624c5c1 which is 5 weeks ago. This repo now used quibble and maybe something in core ch" [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (owner: 10Umherirrender) [22:21:31] (03CR) 10jerkins-bot: [V: 04-1] Move event validation to debug module (1/2) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:22:17] (03CR) 10jerkins-bot: [V: 04-1] Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (owner: 10Umherirrender) [22:22:19] (03PS5) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (https://phabricator.wikimedia.org/T202485) [22:22:51] (03PS6) 10Mooeypoo: Add a warning when action=options changes a globally overridden setting [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/447731 (https://phabricator.wikimedia.org/T198913) (owner: 10MaxSem) [22:23:52] (03CR) 10jerkins-bot: [V: 04-1] Add a warning when action=options changes a globally overridden setting [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/447731 (https://phabricator.wikimedia.org/T198913) (owner: 10MaxSem) [22:24:05] (03CR) 10jerkins-bot: [V: 04-1] Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (https://phabricator.wikimedia.org/T202485) (owner: 10Umherirrender) [22:24:21] (03CR) 10jerkins-bot: [V: 04-1] Add a warning when action=options changes a globally overridden setting [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/447731 (https://phabricator.wikimedia.org/T198913) (owner: 10MaxSem) [22:24:30] (03CR) 10Krinkle: Move event validation to debug module (1/2) (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:28:03] (03PS6) 10Umherirrender: Change abstract BackupDumper to DumpBackup in tests [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/456687 (https://phabricator.wikimedia.org/T202485) [22:28:32] 10Wiki-Loves-Monuments-Database: no jstop command available in a GridEngine job - https://phabricator.wikimedia.org/T202281 (10JeanFred) Could somebody from #toolforge please advise on this? We are quite positive that this used to work but not anymore. [22:29:22] (03CR) 10jenkins-bot: COPYING: Trim unnecessary custom preamble [extensions/Babel] - 10https://gerrit.wikimedia.org/r/456747 (owner: 10Nikerabbit) [22:29:43] (03CR) 10Krinkle: "Regarding the error you got whilst trying to enable debug mode, I'm unable to reproduce that locally." [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:31:05] (03CR) 10Krinkle: Move event validation to debug module (1/2) (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/453457 (https://phabricator.wikimedia.org/T187207) (owner: 10Milimetric) [22:31:28] (03PS1) 10Peter Bowman: Add missing dollar sign to variable [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456759 [22:33:23] 10Wiki-Loves-Monuments: WMDE banners are bad in RTL wikis - https://phabricator.wikimedia.org/T203288 (10Platonides) [22:33:27] 10Wiki-Loves-Monuments: WMDE banners are bad in RTL wikis - https://phabricator.wikimedia.org/T203288 (10Platonides) This is a Wiki Loves Monuments banner Campaign. Seems it would benefit from having a `
` around it. [22:33:51] (03PS2) 10Krinkle: Fixup: Add missing dollar sign to variable name [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456759 (owner: 10Peter Bowman) [22:34:03] (03CR) 10Krinkle: [C: 032] Fixup: Add missing dollar sign to variable name [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456759 (owner: 10Peter Bowman) [22:34:18] (03CR) 10Krinkle: Fix escaping of messages used in html (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/453106 (owner: 10Umherirrender) [22:38:24] (03CR) 10Peter Bowman: "Small regression introduced in Ica26168c5e3f4a9e00d9aaca68838c7616560986, causes a "reviewWrapped" line to show up whenever two unreviewed" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456759 (owner: 10Peter Bowman) [22:39:32] (03CR) 10Sharvaniharan: "Everything looks fine other than the really minor naming change which will make it more readable." (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456309 (https://phabricator.wikimedia.org/T156092) (owner: 10Cooltey) [22:41:30] 10MediaWiki-Vagrant: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment - https://phabricator.wikimedia.org/T203289 (10brion) [22:43:01] (03PS1) 10QChris: Add .gitreview [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/456761 [22:43:03] (03CR) 10QChris: [V: 032 C: 032] Add .gitreview [skins/BlueSpiceCalumma] - 10https://gerrit.wikimedia.org/r/456761 (owner: 10QChris) [22:44:03] (03PS2) 10Nuria: Proper initialization of array on generateRandomSessionId [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) [22:44:12] (03Merged) 10jenkins-bot: Fixup: Add missing dollar sign to variable name [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/456759 (owner: 10Peter Bowman) [22:45:12] (03CR) 10Nuria: "Fixed linting too." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/456682 (https://phabricator.wikimedia.org/T203275) (owner: 10Nuria) [22:46:56] 10MediaWiki-Vagrant: Vagrant 2.1.4 incompatibility: uninitialized constant MediaWikiVagrant::Environment - https://phabricator.wikimedia.org/T203289 (10brion) Seems to be a change in how plugins are loaded in 2.1.3/2.1.4. Yay semver! See https://github.com/hashicorp/vagrant/issues/10161 [22:53:33] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): Copyvio: prepare Test Wiki for community testing - https://phabricator.wikimedia.org/T203119 (10Catrope) As follow-up to this, @MMiller_WMF said he would put the draft pages in different categories so they have different AFC statuses. [22:56:08] (03PS12) 10Catrope: Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 [22:59:17] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [22:59:46] (03CR) 10Catrope: "The phan failure is weird, it's complaining about one of the flags that's already there. Does phan only check modified files, and does thi" [core] - 10https://gerrit.wikimedia.org/r/456533 (https://phabricator.wikimedia.org/T203209) (owner: 10Catrope) [23:01:08] (03CR) 10jerkins-bot: [V: 04-1] Add special page with model statistics [extensions/ORES] - 10https://gerrit.wikimedia.org/r/433956 (owner: 10Catrope) [23:01:21] 10MediaWiki-Maintenance-scripts, 10TechCom-RFC, 10Patch-For-Review: RfC: ParallelMaintenance helper class for multi-process maintenance scripts - https://phabricator.wikimedia.org/T201970 (10kchapman) TechCom is hosting a IRC meeting next week on 5 September 2pm PST(21:00 UTC, 23:00 CET) in #wikimedia-office [23:02:34] (03PS1) 10Jdrewniak: page-issues sectionNumbers consistency on modalClose event [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456764 (https://phabricator.wikimedia.org/T203050) [23:10:02] (03PS1) 10Krinkle: Html: Reject from inlineScript() and leave rest unescaped [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456765 (https://phabricator.wikimedia.org/T200506) [23:10:13] (03CR) 10Krinkle: [C: 032] Html: Reject from inlineScript() and leave rest unescaped [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456765 (https://phabricator.wikimedia.org/T200506) (owner: 10Krinkle) [23:11:58] (03CR) 10Cooltey: Add actions to overflow menus on feed lists (031 comment) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456309 (https://phabricator.wikimedia.org/T156092) (owner: 10Cooltey) [23:14:28] (03CR) 10jerkins-bot: [V: 04-1] page-issues sectionNumbers consistency on modalClose event [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/456764 (https://phabricator.wikimedia.org/T203050) (owner: 10Jdrewniak) [23:31:41] (03Merged) 10jenkins-bot: Html: Reject from inlineScript() and leave rest unescaped [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456765 (https://phabricator.wikimedia.org/T200506) (owner: 10Krinkle) [23:35:53] (03CR) 10Cooltey: [C: 032] Prelude: decouple Prefs from WikiSite. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456427 (owner: 10Dbrant) [23:42:58] (03CR) 10Krinkle: [C: 032] Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456554 (https://phabricator.wikimedia.org/T203154) (owner: 10Aaron Schulz) [23:43:17] (03CR) 10Krinkle: [C: 032] Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [23:44:59] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Communicate session has expired on dashboard when switching between lists - https://phabricator.wikimedia.org/T200646 (10Etonkovidova) @Pginer-WMF - please take a quick look. The screenshot... [23:49:43] (03Merged) 10jenkins-bot: Fix use of selectDB() on DBConnRef in addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456554 (https://phabricator.wikimedia.org/T203154) (owner: 10Aaron Schulz) [23:49:45] (03CR) 10jerkins-bot: [V: 04-1] Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [23:49:47] (03CR) 10Aaron Schulz: resourceloader: Remove module stringification from execute path (033 comments) [core] - 10https://gerrit.wikimedia.org/r/456532 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [23:50:26] (03Merged) 10jenkins-bot: Prelude: decouple Prefs from WikiSite. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456427 (owner: 10Dbrant) [23:51:02] (03CR) 10Krinkle: [C: 04-1] "Hm.. my bad. should've merged them the other way around. Needs a conflict resolution now." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [23:53:11] (03CR) 10jenkins-bot: Prelude: decouple Prefs from WikiSite. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/456427 (owner: 10Dbrant) [23:55:33] (03CR) 10Krinkle: [C: 04-1] "Okay, I'm up for reviewing this." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/306560 (https://phabricator.wikimedia.org/T143837) (owner: 10Mooeypoo) [23:58:48] (03PS2) 10Aaron Schulz: Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 [23:58:50] 10Research: Measure translation recommendations against the baseline - https://phabricator.wikimedia.org/T203263 (10leila) @bmansurov some feedback for en-es: * diego checked en-es and while generally both API outputs look fine to him, none are exciting for him. ;) He expects the recommendations to be more es sp... [23:58:59] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Communicate session has expired on dashboard when switching between lists - https://phabricator.wikimedia.org/T200646 (10Petar.petkovic) >>! In T200646#4549951, @Etonkovidova wrote: > @Pgine... [23:59:13] (03CR) 10Krinkle: [C: 032] Remove old $wgExternalServers hack from addWiki.php [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/456551 (owner: 10Aaron Schulz) [23:59:40] (03PS1) 10Krinkle: resourceloader: Remove redundant '!!' from startup.js [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456773 [23:59:47] (03PS1) 10Krinkle: resourceloader: Use 'this' to access the mw.loader.store internally [core] (wmf/1.32.0-wmf.19) - 10https://gerrit.wikimedia.org/r/456774