[00:16:56] (03CR) 10Yaron Koren: [C: 032] Fix common typos in code [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/455309 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [01:05:27] (03CR) 10Ppchelko: [C: 032] Use getCauseAgent() instead of getTriggeringUser() (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/455274 (owner: 10Catrope) [01:08:28] (03CR) 10jenkins-bot: Use getCauseAgent() instead of getTriggeringUser() [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/455274 (owner: 10Catrope) [01:14:55] 10Wikimedia-Site-requests, 10Chinese-Sites: Allow subpages in main namespace in zhwikiversity - https://phabricator.wikimedia.org/T202007 (10RazeSoldier) [01:17:49] 04(no projects): Create namespace aliases in zhwikiversity - https://phabricator.wikimedia.org/T202821 (10Dcljr) [01:22:50] 04(no projects): Create namespace aliases in zhwikiversity - https://phabricator.wikimedia.org/T202821 (10Dcljr) I have split this request off from {T201675}, since the 2 requests that were in that task can be completed separately, AFAICT, once community consensus for either of them is recognized. [01:46:55] 04(no projects): db2088 rebooted itself and came back sick - https://phabricator.wikimedia.org/T202822 (10Andrew) [01:54:07] 10FormWizard: Page using FormWizard parser function results in errors - https://phabricator.wikimedia.org/T202823 (10Harej) [02:09:20] (03PS2) 10Krinkle: objectcache: Improve WANObjectCache doc for update strategies [core] - 10https://gerrit.wikimedia.org/r/454726 [02:09:48] (03PS2) 10Krinkle: Remove support for StartProfiler.php [core] - 10https://gerrit.wikimedia.org/r/453893 (https://phabricator.wikimedia.org/T201782) [02:12:55] (03CR) 10Krinkle: "CC-ed Brad and Tim for review. I don't feel experienced or comfortable enough to approve change in this code, hoping your expertise may he" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/394430 (https://phabricator.wikimedia.org/T180918) (owner: 10Aaron Schulz) [02:16:23] (03CR) 10Krinkle: [C: 032] LinksUpdate: Remove triggeringUser propagation and deprecate getter [core] - 10https://gerrit.wikimedia.org/r/455275 (owner: 10Catrope) [02:17:02] (03CR) 10Krinkle: [C: 031] LinksUpdate: Remove triggeringUser propagation and deprecate getter [core] - 10https://gerrit.wikimedia.org/r/455275 (owner: 10Catrope) [02:50:40] (03CR) 10Krinkle: resourceloader: Restore mw.loader.store update postponing logic (031 comment) [core] - 10https://gerrit.wikimedia.org/r/454739 (https://phabricator.wikimedia.org/T202598) (owner: 10Krinkle) [03:17:04] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Headbomb) +1 support for this feature. Would be very, very useful for scripts and external APIs. [03:28:04] 10MediaWiki-ResourceLoader, 10Performance-Team: CSS minification breaking rule with attribute selector if contains a space - https://phabricator.wikimedia.org/T202816 (10Krinkle) @Tractopelle-jaune Thanks for reporting this issue. I understand the issue and I can reproduce it. This is indeed a minification bug... [03:47:08] 10MediaWiki-ResourceLoader, 10Performance-Team: Simplify internals of handlePending() and execute() to reduce stack depth - https://phabricator.wikimedia.org/T202703 (10Krinkle) [03:57:10] 10MediaWiki-ResourceLoader, 10Performance-Team: Simplify internals of handlePending() and execute() to reduce stack depth - https://phabricator.wikimedia.org/T202703 (10Krinkle) [04:18:10] (03PS2) 10Krinkle: resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) [04:18:12] (03PS1) 10Krinkle: resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) [04:18:44] (03PS2) 10Krinkle: resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) [04:18:51] (03PS3) 10Krinkle: resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) [04:19:26] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Simplify internals of handlePending() and execute() to reduce stack depth - https://phabricator.wikimedia.org/T202703 (10Krinkle) p:05Triage>03Low [04:19:56] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Investigate source of 404 Not Found responses from load.php - https://phabricator.wikimedia.org/T202479 (10Krinkle) p:05Triage>03Low [04:20:03] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: Investigate source of 404 Not Found responses from load.php - https://phabricator.wikimedia.org/T202479 (10Krinkle) a:03Krinkle [04:21:23] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:21:29] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:22:06] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:22:12] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:22:49] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:23:26] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:25:22] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) (owner: 10Krinkle) [04:25:46] (03PS2) 10Krinkle: resourceloader: Remove unused code in private mw.loader#enqueue() [core] - 10https://gerrit.wikimedia.org/r/455070 [04:25:48] (03PS2) 10Krinkle: resourceloader: Remove unused code from mw.loader.register() [core] - 10https://gerrit.wikimedia.org/r/455071 [04:25:50] (03PS3) 10Krinkle: resourceloader: Remove redundant calls to getState() in mw.loader.enqueue() [core] - 10https://gerrit.wikimedia.org/r/455072 [04:25:52] (03PS3) 10Krinkle: resourceloader: Remove redundant check in mw.loader.store for Opera 12 [core] - 10https://gerrit.wikimedia.org/r/455074 [04:25:54] (03PS3) 10Krinkle: resourceloader: Simplify addEmbeddedCSS by using object refs [core] - 10https://gerrit.wikimedia.org/r/455381 (https://phabricator.wikimedia.org/T202703) [04:25:56] (03PS4) 10Krinkle: resourceloader: Remove checkCssHandles for modules without styles [core] - 10https://gerrit.wikimedia.org/r/455075 (https://phabricator.wikimedia.org/T202703) [04:27:01] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Dinoguy1000) @Headbomb Is there a reason existing methods for getting the current user's name via Javascript are insufficient for those uses? [04:29:52] (03CR) 10Krinkle: [C: 031] Fix page-linked notifications (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/455259 (https://phabricator.wikimedia.org/T200119) (owner: 10Catrope) [04:41:05] (03CR) 10Krinkle: Page issues instrumentation: log sections as array of numbers (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/455215 (https://phabricator.wikimedia.org/T191532) (owner: 10Jdlrobson) [04:46:39] (03CR) 10Krinkle: Hygiene: introduce Webpack bundling (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/455014 (https://phabricator.wikimedia.org/T199452) (owner: 10Niedzielski) [04:47:59] (03PS3) 10Legoktm: Add README and COPYING [services/poolcounter] - 10https://gerrit.wikimedia.org/r/455374 [04:48:01] (03PS2) 10Legoktm: Remove debian/ from master [services/poolcounter] - 10https://gerrit.wikimedia.org/r/455373 [04:48:03] (03PS1) 10Legoktm: Add .gitignore [services/poolcounter] - 10https://gerrit.wikimedia.org/r/455382 [04:50:03] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove redundant calls to getState() in mw.loader.enqueue() [core] - 10https://gerrit.wikimedia.org/r/455072 (owner: 10Krinkle) [05:39:28] 10FormWizard: Page using FormWizard parser function results in errors - https://phabricator.wikimedia.org/T202823 (10Eugene233) According to [[ https://www.mediawiki.org/wiki/Extension:FormWizard#Basic_setup | documentation ]], I could have the button from the below image @Harej {F25372135} [05:40:30] 10FormWizard: Page using FormWizard parser function results in errors - https://phabricator.wikimedia.org/T202823 (10Eugene233) a:03Eugene233 [05:41:51] 10FormWizard: Page using FormWizard parser function results in errors - https://phabricator.wikimedia.org/T202823 (10Eugene233) Primarily I can say that the log shows that all the arguments were not given to the parser function as required. [05:50:49] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Headbomb) @Dinoguy1000 To my knowledge, JavaScripts need to be installed, which means templates can't make use of them. See https://en.wikiped... [06:11:22] (03PS1) 10Legoktm: [WIP] Port test suite to Python [services/poolcounter] - 10https://gerrit.wikimedia.org/r/455385 [07:14:47] 10MediaWiki-Page-editing, 10JavaScript, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Perhelion) @Commons should be done on 2018-02-28 https://commons.wikimedia.org/wiki/Special:Diff/280636787/289473902?title=MediaWiki:Edittools.js [07:24:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Remove count() of null value (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/454847 (owner: 10Umherirrender) [07:35:34] (03CR) 10Legoktm: [C: 032] Add @covers to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/455301 (https://phabricator.wikimedia.org/T195134) (owner: 10Umherirrender) [07:36:58] (03PS2) 10Legoktm: [WIP] Port test suite to Python [services/poolcounter] - 10https://gerrit.wikimedia.org/r/455385 [07:42:36] (03Merged) 10jenkins-bot: Remove count() of null value [extensions/Echo] - 10https://gerrit.wikimedia.org/r/454847 (owner: 10Umherirrender) [07:50:45] (03CR) 10jenkins-bot: Remove count() of null value [extensions/Echo] - 10https://gerrit.wikimedia.org/r/454847 (owner: 10Umherirrender) [07:51:12] (03Merged) 10jenkins-bot: Add @covers to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/455301 (https://phabricator.wikimedia.org/T195134) (owner: 10Umherirrender) [08:04:22] (03CR) 10jenkins-bot: Add @covers to unit tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/455301 (https://phabricator.wikimedia.org/T195134) (owner: 10Umherirrender) [08:14:10] 10MediaWiki-Page-editing, 10JavaScript, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Perhelion) PS: It is hard to find a documentation for **mw.toolbar** replacement for this absolutely core function. It is also very hard to understan... [08:36:42] (03PS1) 10Daimona Eaytoy: Replace double-equals with triple-equals [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455387 [09:09:47] 10AbuseFilter: AbuseFilter-contentToString hook help? - https://phabricator.wikimedia.org/T202813 (10Daimona) @SpookyGhost8 what do you mean with "enforcements of abusefilters"? The contentToString hook is used to change how AF converts a content object to a string, which happens before trying to filter the edit... [09:27:18] (03CR) 10Daimona Eaytoy: "Not even close to be able to review this code, but found two minor errors while looking at it." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) (owner: 10Daniel Kinzler) [10:15:23] (03CR) 10D3r1ck01: Add return back link on Thanks extension success page (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [10:23:05] 04(no projects): gu_home_db is NULL - https://phabricator.wikimedia.org/T202829 (10Steinsplitter) [10:48:18] 10MediaWiki-API, 10MediaWiki-Recent-changes, 10Editing-team, 10Growth-Team, and 2 others: Edits with API by users with "flood" user right are always set with rc_bot=0 in table recent changes if bot field not set - https://phabricator.wikimedia.org/T200089 (10Vajotwo) >>! In T200089#4530459, @Jdlrobson wrot... [11:28:19] 04(no projects): Change the name of the Page Mover user right from گوێزەرەوە بەبێ ڕەوانەکەر to گوێزەرەوەی پەڕە on ckb - https://phabricator.wikimedia.org/T202831 (10Epine) [11:37:48] 04(no projects): Change the name of the Page Mover user right from گوێزەرەوە بەبێ ڕەوانەکەر to گوێزەرەوەی پەڕە on ckb - https://phabricator.wikimedia.org/T202831 (10Calak) You should change it here: https://ckb.wikipedia.org/wiki/Mediawiki:Group-suppressredirect-member [11:41:06] 04(no projects): Change the name of the Page Mover user right from گوێزەرەوە بەبێ ڕەوانەکەر to گوێزەرەوەی پەڕە on ckb - https://phabricator.wikimedia.org/T202831 (10Epine) @Calak thanks! [11:41:21] 04(no projects): Change the name of the Page Mover user right from گوێزەرەوە بەبێ ڕەوانەکەر to گوێزەرەوەی پەڕە on ckb - https://phabricator.wikimedia.org/T202831 (10Epine) 05Open>03Resolved [11:41:47] (03CR) 10Martineznovo: [C: 04-1] "Looks okay except for the condition. Another option would be to update the displaySection function to not explode, by checking if the elem" (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455357 (owner: 10Jack Phoenix) [11:41:57] (03CR) 10Yaron Koren: [C: 032] "." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/455309 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:42:28] 04(no projects): Change the name of the Page Mover user right from گوێزەرەوە بەبێ ڕەوانەکەر to گوێزەرەوەی پەڕە on ckb - https://phabricator.wikimedia.org/T202831 (10Aklapper) 05Resolved>03Invalid [11:44:27] 10MediaWiki-Interface, 10MediaWiki-Special-pages, 10MediaWiki-User-login-and-signup: specialpagesgroup-login should depend on $wgUser->isAllowed( 'createaccount' ) - https://phabricator.wikimedia.org/T34448 (10Tgr) [11:45:33] (03CR) 10Yaron Koren: [C: 032] Fix common typos in code [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/455165 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:48:24] (03Merged) 10jenkins-bot: Fix common typos in code [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/455309 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:49:50] (03CR) 10Yaron Koren: [C: 04-1] "This is an impressive number of "the the"s found! Still, I don't think this particular set of fixes makes sense - this is all 3rd-party co" [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/455298 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:50:15] (03Merged) 10jenkins-bot: Fix common typos in code [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/455165 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:57:36] (03CR) 10Mh-3110: "> > Patch Set 5:" (0311 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [11:58:21] (03CR) 10Mh-3110: ">" (031 comment) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [12:01:41] (03CR) 10D3r1ck01: "@Mh-3110, have you tested this patch locally and it's working? Maybe you should double check?" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [12:07:27] 10MediaWiki-extensions-Cargo, 10Patch-For-Review: Make purge link work in one click - https://phabricator.wikimedia.org/T200054 (10Yaron_Koren) Sorry, no. It should just work automatically... [12:18:42] 10MediaWiki-extensions-Other, 10I18n: Add message documentation to TinyMCE - https://phabricator.wikimedia.org/T202126 (10Yaron_Koren) @Aklapper - sorry for not responding before. At this point, just the mediawiki.org talk page is the place for bug reports, etc. I should request a Phabricator tag - actually, I... [12:24:55] (03CR) 10Martineznovo: [C: 04-1] "It doesn't work for me on Firefox 61 on Linux:" (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455358 (https://phabricator.wikimedia.org/T202289) (owner: 10Jack Phoenix) [12:33:54] 10MediaWiki-Cache, 10Commons, 10Category: Wrong file count for category - https://phabricator.wikimedia.org/T202833 (10Steinsplitter) [13:04:14] 10MediaWiki-Cache, 10Commons: Wrong file count for category - https://phabricator.wikimedia.org/T202833 (10Aklapper) [14:02:47] (03PS2) 10Daimona Eaytoy: Remove _age variables from cache keys [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/455343 [14:30:03] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Variables, 10Patch-For-Review: Create a Scribunto interface - https://phabricator.wikimedia.org/T201171 (10MGChecker) >>! In T201171#4490693, @Litzsch wrote: >> I don't think the extension should allow to do something via Lua that it doesn't allow othe... [14:48:50] (03PS1) 10MGChecker: Bump version number [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455397 [16:19:02] (03PS2) 10MGChecker: Bump version number [extensions/Variables] - 10https://gerrit.wikimedia.org/r/455397 [16:31:42] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Dinoguy1000) Aah, so by "scripts" you meant Lua modules and wikitext templates. [16:38:35] 10Library-Card-Platform: SUL Info link does not appear to work on any application - https://phabricator.wikimedia.org/T202837 (10Nikkimaria) [16:45:25] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable Wikilove extension on zh_yuewiki - https://phabricator.wikimedia.org/T202548 (10deryckchan) 05Open>03Resolved a:03deryckchan WikiLove is now turned on. I'm marking this as resolved. Thanks everyone for the work. [16:46:11] 10MediaWiki-extensions-Translate, 10Multi-Content-Revisions, 10Wikimedia-log-errors: BadMethodCallException on editing units: Call to a member function getRevisionRecord() on a non-object (boolean) - https://phabricator.wikimedia.org/T202809 (10Legoktm) p:05Triage>03Unbreak! Adding MCR since the tracebac... [16:46:21] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review: Enable Wikilove extension on zh_yuewiki - https://phabricator.wikimedia.org/T202548 (10Urbanecm) a:05deryckchan>03Framawiki [16:48:09] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)), and 2 others: CirrusSearch extension is missing @covers tags - https://phabricator.wikimedia.org/T195134 (10Legoktm) 05Open>03Resolved a:03Umherirrender [16:48:29] 10MediaWiki-extensions-Translate, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-08-28 (1.32.0-wmf.19)): Special:AggregateGroups@metawiki fails to load properly - https://phabricator.wikimedia.org/T201819 (10Petar.petkovic) [16:51:24] 10Social-Tools, 10SocialProfile, 10JavaScript: When changing the visibility of a field, the drop down/button no longer works until the page is refreshed - https://phabricator.wikimedia.org/T202838 (10Ciencia_Al_Poder) [16:53:14] 10Library-Card-Platform: Flag duplicate requests - https://phabricator.wikimedia.org/T202839 (10Nikkimaria) [16:53:26] 10Library-Card-Platform: Flag duplicate requests - https://phabricator.wikimedia.org/T202839 (10Nikkimaria) p:05Triage>03Low [16:56:39] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Headbomb) Yes, clarified the original post, although I'm sure there would be uses for JavaScripts as well. [17:13:04] 10Social-Tools, 10SocialProfile, 10JavaScript: When changing the visibility of a field, the drop down/button no longer works until the page is refreshed - https://phabricator.wikimedia.org/T202838 (10Ciencia_Al_Poder) If fixing this is not quick and easy, it may be worth doing T158620 [17:21:40] (03CR) 10Reedy: "I wonder if this should be attribute rather than config due to loading orders.. Even more so if an extension wants to have it in extension" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T199118) (owner: 10MR70) [17:26:21] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/453980 (owner: 10Robert Vogel) [17:31:41] (03PS2) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO [core] - 10https://gerrit.wikimedia.org/r/455229 [17:35:24] (03PS1) 10Jack Phoenix: Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) [17:37:26] 10MediaWiki-Core-Tests, 10MediaWiki-Database, 10User-Addshore: LoadBalancer opening extra connections in different connection categories doesn't work with PHPUnit & temporary tables - https://phabricator.wikimedia.org/T202116 (10Daimona) I was going to open a new task for this problem and noticed this task j... [17:39:19] 10AbuseFilter: AbuseFilter-contentToString hook help? - https://phabricator.wikimedia.org/T202813 (10SpookyGhost8) "enforcement of abusefilters", I mean to actually filter new threads/replies to WikiForum or new comments in MediaWikiChat. The main purposes would be: 1. to allow a bad word filter for WikiForums... [17:40:36] 10AbuseFilter, 10MediaWikiChat, 10Social-Tools, 10WikiForum: AbuseFilter-contentToString hook help? - https://phabricator.wikimedia.org/T202813 (10SpookyGhost8) [17:45:48] 10AbuseFilter, 10MediaWikiChat, 10Social-Tools, 10WikiForum: AbuseFilter-contentToString hook help? - https://phabricator.wikimedia.org/T202813 (10Daimona) @SpookyGhost8 so you mean to filter edits coming from either [[https://www.mediawiki.org/wiki/Extension:WikiForum|WikiForum]] or [[https://www.mediawik... [17:49:52] (03PS2) 10Jack Phoenix: Don't show the US state selector on any other pages than [[Special:UpdateProfile]] and [[Special:EditProfile]] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455357 [17:52:07] (03CR) 10Martineznovo: [C: 031] Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable (031 comment) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) (owner: 10Jack Phoenix) [17:52:25] (03PS1) 10Umherirrender: Swap arguments of Title::makeName to fix Special:Export [core] - 10https://gerrit.wikimedia.org/r/455400 (https://phabricator.wikimedia.org/T202817) [17:52:50] (03CR) 10Martineznovo: [C: 031] Don't show the US state selector on any other pages than [[Special:UpdateProfile]] and [[Special:EditProfile]] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455357 (owner: 10Jack Phoenix) [17:53:32] (03PS2) 10Jack Phoenix: Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) [17:54:35] (03CR) 10Martineznovo: [C: 031] Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) (owner: 10Jack Phoenix) [17:57:36] (03CR) 10Jack Phoenix: [C: 032] Don't show the US state selector on any other pages than [[Special:UpdateProfile]] and [[Special:EditProfile]] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455357 (owner: 10Jack Phoenix) [17:57:42] (03CR) 10Jack Phoenix: [C: 032] Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) (owner: 10Jack Phoenix) [18:00:03] (03CR) 10Krinkle: exception: Do not log PHP errors with severity DEBUG or INFO (031 comment) [core] - 10https://gerrit.wikimedia.org/r/455229 (owner: 10Krinkle) [18:00:30] (03CR) 10Krinkle: "recheck" [core] - 10https://gerrit.wikimedia.org/r/455072 (owner: 10Krinkle) [18:01:32] (03PS9) 10Krinkle: Html: Reject from inlineScript() and leave rest unescaped [core] - 10https://gerrit.wikimedia.org/r/451011 (https://phabricator.wikimedia.org/T200506) [18:02:43] (03CR) 10Krinkle: Html: Reject from inlineScript() and leave rest unescaped (031 comment) [core] - 10https://gerrit.wikimedia.org/r/451011 (https://phabricator.wikimedia.org/T200506) (owner: 10Krinkle) [18:03:26] (03Merged) 10jenkins-bot: Don't show the US state selector on any other pages than [[Special:UpdateProfile]] and [[Special:EditProfile]] [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455357 (owner: 10Jack Phoenix) [18:03:45] 10MediaWiki-Parser: New user-specific variable (magic word, parser function) giving {{USERNAME}} ({{CURRENTUSER}} {{USER}}) - https://phabricator.wikimedia.org/T6196 (10Dinoguy1000) As was pointed out in https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&diff=856639028&oldid=856636613,... [18:04:43] (03PS10) 10Krinkle: Html: Reject from inlineScript() and leave rest unescaped [core] - 10https://gerrit.wikimedia.org/r/451011 (https://phabricator.wikimedia.org/T200506) [18:04:53] (03PS2) 10Krinkle: resourceloader: Refuse to preview content with [core] - 10https://gerrit.wikimedia.org/r/453892 (https://phabricator.wikimedia.org/T200506) [18:06:26] (03Merged) 10jenkins-bot: Better JS selectors so that you can change the visibility of a profile field multiple times, the way it's supposed to be usable [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/455399 (https://phabricator.wikimedia.org/T202838) (owner: 10Jack Phoenix) [18:08:46] 10Social-Tools, 10SocialProfile, 10JavaScript, 10Patch-For-Review: When changing the visibility of a field, the drop down/button no longer works until the page is refreshed - https://phabricator.wikimedia.org/T202838 (10ashley) 05Open>03Resolved a:03ashley [18:10:38] 10UI-Standardization, 10OOUI (OOUI-0.26.0), 10UI-Standardization-Kanban, 10User-Ryasmeen, 10User-notice: Unify and refine WikimediaUI icon set - https://phabricator.wikimedia.org/T177432 (10Perhelion) Short question (not from me) the **ltr **icon https://commons.wikimedia.org/wiki/File:OOjs_UI_icon_strip... [18:11:05] (03PS2) 10Krinkle: Swap arguments of Title::makeName to fix Special:Export [core] - 10https://gerrit.wikimedia.org/r/455400 (https://phabricator.wikimedia.org/T202817) (owner: 10Umherirrender) [18:11:08] (03CR) 10Krinkle: [C: 032] Swap arguments of Title::makeName to fix Special:Export [core] - 10https://gerrit.wikimedia.org/r/455400 (https://phabricator.wikimedia.org/T202817) (owner: 10Umherirrender) [18:12:31] (03CR) 10Krinkle: Swap arguments of Title::makeName to fix Special:Export (031 comment) [core] - 10https://gerrit.wikimedia.org/r/455400 (https://phabricator.wikimedia.org/T202817) (owner: 10Umherirrender) [18:13:36] (03CR) 10Krinkle: [C: 032] Split long lines over 140 chars [extensions/Echo] - 10https://gerrit.wikimedia.org/r/455305 (owner: 10Umherirrender) [18:13:52] (03CR) 10Krinkle: [C: 032] Split long lines over 170 chars [extensions/Flow] - 10https://gerrit.wikimedia.org/r/455306 (owner: 10Umherirrender) [18:24:04] ashley: are you aware of https://phabricator.wikimedia.org/T201698 ? (I have the patch applied to my servers) I don't think it can be exploited, but anyway... If you prefer me to submit it to gerrit, just let me know [18:25:45] Vulpix: ah, yes, nice catch -- saw it a few days ago and was gonna bug legoktm & co. about it; tl,dr: patch LGTM, feel free to submit it to gerrit and we can then merge it. in the long term that crappy code *really* needs to be rethought from the ground and replaced with something somewhat saner and preferably something that *doesn't* rely that much on regexes :D (the code sucked back in 2007, nowadays it sucks even more) [18:26:06] okay! [18:27:52] (03PS1) 10Gergő Tisza: Restore passing of triggering user in edit updates [core] - 10https://gerrit.wikimedia.org/r/455401 (https://phabricator.wikimedia.org/T200119) [18:28:39] I took a look at your comments on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/SocialProfile/+/455358/ and I've made *some* progress locally but now I have the issue that selecting a (different) state doesn't activate the "Update" button and I'm not sure why...I mean, it probably boils down to "old code is old and ugly" and "I'm doing *something* wrong", but... >.> [18:31:28] ashley: ah, the selector $( 'form[name="profile"] div:not(.visualClear) input,form[name="profile"] div:not(.visualClear) textarea' ) does not include