[00:00:59] (03CR) 10jenkins-bot: password: Move commonpasswords.cdb to includes/password/ [core] - 10https://gerrit.wikimedia.org/r/447018 (owner: 10Krinkle) [00:01:09] wikimedia/mediawiki#21744 (master - be74c82 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416148319 [00:01:59] 10MediaWiki-API, 10Core-Platform-Team, 10Reading-Infrastructure-Team-Backlog: Deprecation of API "action=query&prop=revisions&!rvslots" - https://phabricator.wikimedia.org/T201974 (10Krinkle) [00:02:04] (03CR) 10Catrope: [C: 032] Remove $wgEchoNewMsgAlert and 'echo-show-alert' preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [00:03:34] (03Merged) 10jenkins-bot: RemexDriver: improved tracing [core] - 10https://gerrit.wikimedia.org/r/450491 (owner: 10Tim Starling) [00:05:09] 10MediaWiki-General-or-Unknown, 10Performance-Team (Radar): Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10Krinkle) p:05Triage>03Normal [00:05:32] (03Merged) 10jenkins-bot: Fast manual restart for populateContentTables.php [core] - 10https://gerrit.wikimedia.org/r/452599 (owner: 10Tim Starling) [00:05:47] 10MediaWiki-ResourceLoader, 10Performance-Team: ResourceLoader 2018 Review - https://phabricator.wikimedia.org/T192623 (10Krinkle) [00:06:04] (03CR) 10jenkins-bot: RemexDriver: improved tracing [core] - 10https://gerrit.wikimedia.org/r/450491 (owner: 10Tim Starling) [00:06:27] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog: Make page issue class names configurable so we are not English-Wikipedia centric - https://phabricator.wikimedia.org/T201975 (10Jdlrobson) p:05Triage>03Normal [00:06:33] (03CR) 10jerkins-bot: [V: 04-1] resourceloader: Remove $wgResourceLoaderLESSVars support [core] - 10https://gerrit.wikimedia.org/r/451648 (https://phabricator.wikimedia.org/T140804) (owner: 10Krinkle) [00:08:30] (03Merged) 10jenkins-bot: Always show creation date for AfC drafts [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452856 (https://phabricator.wikimedia.org/T201373) (owner: 10Catrope) [00:08:33] (03Merged) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452857 (https://phabricator.wikimedia.org/T201253) (owner: 10Catrope) [00:08:44] 10MediaWiki-Core-Tests, 10MediaWiki-Special-pages, 10Wikimedia-log-errors (Shared Build Failure): Flaky unit test MergeHistoryTest::testIsValidMerge - https://phabricator.wikimedia.org/T201976 (10Krinkle) [00:08:46] (03CR) 10Krinkle: "Filed T201976 for the flaky test" [core] - 10https://gerrit.wikimedia.org/r/451648 (https://phabricator.wikimedia.org/T140804) (owner: 10Krinkle) [00:08:59] (03CR) 10jenkins-bot: Fast manual restart for populateContentTables.php [core] - 10https://gerrit.wikimedia.org/r/452599 (owner: 10Tim Starling) [00:09:18] (03PS1) 10VolkerE: Update OOUI to v0.28.0 [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) [00:09:52] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [00:10:24] 10MediaWiki-API: Action API module GeoSearch documentation is not available for transclusion via Special:ApiHelp on MediaWiki - https://phabricator.wikimedia.org/T201977 (10srishakatux) [00:10:33] 10MediaWiki-API: Action API module GeoSearch documentation is not available for transclusion via Special:ApiHelp on MediaWiki - https://phabricator.wikimedia.org/T201977 (10srishakatux) [00:11:40] 10MediaWiki-API: Action API module GeoSearch documentation is not available for transclusion via Special:ApiHelp on MediaWiki - https://phabricator.wikimedia.org/T201977 (10srishakatux) [00:13:32] 10MediaWiki-API: Action API module GeoSearch documentation is not available for transclusion via Special:ApiHelp on MediaWiki - https://phabricator.wikimedia.org/T201977 (10Reedy) >Not sure why, but I'm wondering if it has something to do with the fact that GeoData extension is not installed on MediaWiki.. Exac... [00:18:40] (03PS1) 10Krinkle: MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) [00:19:17] 10MediaWiki-API: Action API module GeoSearch documentation is not available for transclusion via Special:ApiHelp on MediaWiki - https://phabricator.wikimedia.org/T201977 (10srishakatux) @Reedy Okay, make sense :) In the process of improving API docs as part of T198916 and using Special:ApiHelp to embed API doc... [00:19:56] (03CR) 10Krinkle: [C: 032] "let's try that again" [core] - 10https://gerrit.wikimedia.org/r/451648 (https://phabricator.wikimedia.org/T140804) (owner: 10Krinkle) [00:21:10] (03Merged) 10jenkins-bot: Doc: fix typo [extensions/Popups] - 10https://gerrit.wikimedia.org/r/452693 (owner: 10Niedzielski) [00:21:26] 10InternetArchiveBot (v2.0): IABot adds invalid accessdates - https://phabricator.wikimedia.org/T200286 (10Cyberpower678) The old access dates issue is easily fixed as those are just being copied from the archive timestamps. I can't replicate what's causing the 2028 timestamp. My only suggestion is to fix thes... [00:24:16] (03CR) 10Jforrester: [C: 031] Add release notes for $wgContLang deprecation [core] - 10https://gerrit.wikimedia.org/r/452865 (https://phabricator.wikimedia.org/T160815) (owner: 10Legoktm) [00:24:18] (03PS7) 10Dbrant: [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) [00:24:31] wikimedia/mediawiki#21745 (master - a0b490b jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416156400 [00:24:40] (03CR) 10Jforrester: [C: 031] "Same as parent commit comment from Timo." [core] - 10https://gerrit.wikimedia.org/r/452866 (https://phabricator.wikimedia.org/T160811) (owner: 10Legoktm) [00:25:18] (03CR) 10Jforrester: [C: 032] Deprecate wfGetCache() and wfGetMainCache() [core] - 10https://gerrit.wikimedia.org/r/452870 (owner: 10Legoktm) [00:25:40] 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801 (10Volker_E) [00:27:06] (03PS1) 10Jdlrobson: Drop portal styles in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452874 [00:29:58] 10OOUI (OOUI-0.28.0), 10Patch-For-Review: Move inline help after field when align=top - https://phabricator.wikimedia.org/T197004 (10Volker_E) Repeating myself from patch set comment: @Rho brought up at another design discussion, that Material design is positioning assistive text besides the label as positione... [00:30:32] (03CR) 10Jforrester: [C: 032] MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [00:31:15] 10UI-Standardization, 10OOUI (OOUI-0.28.0): Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar' - https://phabricator.wikimedia.org/T190441 (10Volker_E) 05Open>03Resolved p:05Triage>03Low a:03Volker_E [00:31:18] 10UI-Standardization, 10OOUI (OOUI-0.28.0): Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar' - https://phabricator.wikimedia.org/T190441 (10Volker_E) [00:32:12] 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801 (10Volker_E) [00:32:15] 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Deprecate and remove 'comment' icon from 'alerts' pack - https://phabricator.wikimedia.org/T183600 (10Volker_E) 05Open>03Resolved [00:34:29] (03CR) 10Valerie: [C: 032] "Good enough for now." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452665 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [00:35:47] 10MediaWiki-extensions-WikibaseClient, 10Wikidata, 10Performance, 10User-Smalyshev: Make PropertyLabelResolver that uses ElasticSearch - https://phabricator.wikimedia.org/T194143 (10Smalyshev) [00:35:56] (03PS2) 10Jforrester: Update OOUI to v0.28.0 [vendor] - 10https://gerrit.wikimedia.org/r/452869 (owner: 10VolkerE) [00:36:02] (03CR) 10jerkins-bot: [V: 04-1] Update OOUI to v0.28.0 [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) (owner: 10VolkerE) [00:36:05] (03CR) 10jerkins-bot: [V: 04-1] Update OOUI to v0.28.0 [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) (owner: 10VolkerE) [00:36:27] (03CR) 10Jforrester: "PS2: Bump the composer.lock hash from `composer update`." [vendor] - 10https://gerrit.wikimedia.org/r/452869 (owner: 10VolkerE) [00:36:36] (03PS11) 10Cooltey: [READY] PCS Media endpoint for Android [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/449914 (https://phabricator.wikimedia.org/T193275) [00:36:52] Krinkle: Could we finally push the basic support for IE to 8 in browser support matrix? [00:37:36] (03CR) 10jerkins-bot: [V: 04-1] [READY] PCS Media endpoint for Android [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/449914 (https://phabricator.wikimedia.org/T193275) (owner: 10Cooltey) [00:38:06] (03CR) 10Jforrester: "recheck" [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) (owner: 10VolkerE) [00:40:39] (03PS12) 10Cooltey: [READY] PCS Media endpoint for Android [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/449914 (https://phabricator.wikimedia.org/T193275) [00:41:02] 10Product-Analytics: Determine ratio of wikitext edits made from mobile devices that use the desktop interface - https://phabricator.wikimedia.org/T201973 (10Tbayer) Here is a quick and dirty query for a related question: The ratio of wikitext edits using the desktop interface made from iOS and Android devices (... [00:43:51] (03CR) 10Legoktm: Don't call SpecialPageFactory methods statically (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/450951 (owner: 10simetrical) [00:43:57] (03PS4) 10Legoktm: Don't call SpecialPageFactory methods statically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/450951 (owner: 10simetrical) [00:47:29] Volker_E: I'm not sure exactly what you mean. [00:48:23] (03CR) 10Krinkle: Don't call SpecialPageFactory methods statically (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/450951 (owner: 10simetrical) [00:49:25] (03CR) 10Samwilson: Fix global settings overriding local ones (031 comment) [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452026 (https://phabricator.wikimedia.org/T201340) (owner: 10MaxSem) [00:49:44] (03Merged) 10jenkins-bot: Parser: Call firstCallInit() in getTags/getFunctionHooks [core] - 10https://gerrit.wikimedia.org/r/452601 (owner: 10Legoktm) [00:49:46] (03Merged) 10jenkins-bot: Hygiene: move page issues A/B test logging to file [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452573 (https://phabricator.wikimedia.org/T191528) (owner: 10Niedzielski) [00:49:48] (03CR) 10jerkins-bot: [V: 04-1] Read from the new column of change_tag [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/452063 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [00:51:28] (03PS6) 10Legoktm: Don't call SpecialPageFactory methods statically [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/450948 (owner: 10simetrical) [00:51:30] (03PS13) 10Legoktm: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [00:53:03] (03CR) 10jenkins-bot: Parser: Call firstCallInit() in getTags/getFunctionHooks [core] - 10https://gerrit.wikimedia.org/r/452601 (owner: 10Legoktm) [00:53:54] (03PS2) 10Jforrester: DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base [core] - 10https://gerrit.wikimedia.org/r/452023 (owner: 10VolkerE) [00:54:00] (03CR) 10Jforrester: [C: 032] DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base [core] - 10https://gerrit.wikimedia.org/r/452023 (owner: 10VolkerE) [00:54:50] 10MediaWiki-Categories, 10Wikimedia-General-or-Unknown, 10Chinese-Sites: File from Commons still listed in category of local project (Chinese Wikipedia) though the file is actually not uploaded locally - https://phabricator.wikimedia.org/T178789 (10A2093064) 05Open>03Resolved a:03A2093064 [[File:Cow on... [00:56:35] (03CR) 10jenkins-bot: Hygiene: move page issues A/B test logging to file [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452573 (https://phabricator.wikimedia.org/T191528) (owner: 10Niedzielski) [01:00:49] wikimedia/mediawiki#21747 (master - 27b6c5f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416159436 [01:03:13] 10MediaWiki-extensions-Maintenance: Make deleteAutopatrolLogs.php a logged update - https://phabricator.wikimedia.org/T201978 (10GeoffreyT2000) [01:03:31] 10MediaWiki-Maintenance-scripts: Make deleteAutopatrolLogs.php a logged update - https://phabricator.wikimedia.org/T201978 (10GeoffreyT2000) [01:03:54] 10MediaWiki-Maintenance-scripts: Make deleteAutopatrolLogs.php a logged update - https://phabricator.wikimedia.org/T201978 (10GeoffreyT2000) [01:04:54] wikimedia/mediawiki#21747 (master - 27b6c5f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416159436 [01:05:07] (03PS6) 10Samwilson: Fix global settings overriding local ones [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452026 (https://phabricator.wikimedia.org/T201340) (owner: 10MaxSem) [01:06:12] (03CR) 10Anomie: mw.widgets.datetime.DateTimeInputWidget: Add directionality support (031 comment) [core] - 10https://gerrit.wikimedia.org/r/436829 (https://phabricator.wikimedia.org/T196061) (owner: 10Anomie) [01:12:22] (03PS3) 10Legoktm: Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [01:12:24] (03PS1) 10Legoktm: Inject SpecialPageFactory into Parser [core] - 10https://gerrit.wikimedia.org/r/452876 [01:13:24] 10InternetArchiveBot (v2.0): It took IABot two edits to tag a link as dead - https://phabricator.wikimedia.org/T200601 (10Green_Cardamom) The dead link checker has a delay to due to transient network errors it won't determine a link is dead until after multiple checks and time [01:15:57] wikimedia/mediawiki#21746 (master - e08a85f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416158869 [01:16:10] (03PS2) 10Krinkle: MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) [01:16:37] (03CR) 10Krinkle: "Updated to match the commit message – forgot to stage part of it." [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [01:19:40] (03Merged) 10jenkins-bot: Remove $wgEchoNewMsgAlert and 'echo-show-alert' preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [01:24:40] (03Merged) 10jenkins-bot: resourceloader: Remove $wgResourceLoaderLESSVars support [core] - 10https://gerrit.wikimedia.org/r/451648 (https://phabricator.wikimedia.org/T140804) (owner: 10Krinkle) [01:27:08] (03PS8) 10Dbrant: [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) [01:27:32] (03CR) 10jenkins-bot: resourceloader: Remove $wgResourceLoaderLESSVars support [core] - 10https://gerrit.wikimedia.org/r/451648 (https://phabricator.wikimedia.org/T140804) (owner: 10Krinkle) [01:29:13] 10MediaWiki-Maintenance-scripts, 10Core-Platform-Team, 10User-Nikerabbit: edit.php and rollbackEdits.php scripts failing with MWException "CAS update failed on user_touched" - https://phabricator.wikimedia.org/T197472 (10Anomie) >>! In T197472#4501481, @Nikerabbit wrote: > ``` > MariaDB [dev_translatewiki_ne... [01:30:31] (03Merged) 10jenkins-bot: Exclude Drafts from daily cleanup of PageTriage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452665 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [01:30:38] 10Internet-Archive, 10InternetArchiveBot: InternetArchiveBot breaking references using {{webarchive}} - https://phabricator.wikimedia.org/T201807 (10Green_Cardamom) It looks like IABot is trying to merge the templates. If so, that should not occur. ```{{webarchive |format=addlarchives``` is a special form of... [01:34:50] 10MediaWiki-extensions-WikibaseRepository, 10Discovery-Search, 10Wikidata: Searching for QID of deleted item should open it, not showing useless search results - https://phabricator.wikimedia.org/T129779 (10Smalyshev) [01:35:37] (03CR) 10Legoktm: [C: 031] "LGTM, just a question inline." (031 comment) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/452049 (https://phabricator.wikimedia.org/T197617) (owner: 10Gergő Tisza) [01:37:56] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Smalyshev: property search in entity selector should not be prefix-only - https://phabricator.wikimedia.org/T46773 (10Smalyshev) [01:38:14] 10MediaWiki-API, 10Core-Platform-Team, 10Reading-Infrastructure-Team-Backlog (Kanban): Deprecation of API "action=query&prop=revisions&!rvslots" - https://phabricator.wikimedia.org/T201974 (10Mholloway) [01:40:15] (03PS1) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [01:42:59] 10Refreshed: Refreshed skin: thoughts on the future (Refreshed 4?) - https://phabricator.wikimedia.org/T200303 (10MtMNC) Switched to click dropdowns as of the latest commit. Another issue not touched on earlier is how to deal with header categories on mobile. Some ideas: Medium: Replace the header category dro... [01:43:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/452775 (owner: 10L10n-bot) [01:44:39] 10MediaWiki-API, 10Core-Platform-Team, 10Reading-Infrastructure-Team-Backlog: Deprecation of API "action=query&prop=revisions&!rvslots" - https://phabricator.wikimedia.org/T201974 (10Mholloway) [01:45:10] (03CR) 10jerkins-bot: [V: 04-1] Drop portal styles in Minerva [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452874 (owner: 10Jdlrobson) [01:46:32] (03PS1) 10Samwilson: Add Australian English en-au to language name list [core] - 10https://gerrit.wikimedia.org/r/452879 [01:47:42] (03PS1) 10Aaron Schulz: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 [01:47:53] wikimedia/mediawiki#21748 (master - c1d7412 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416170700 [01:49:25] (03PS1) 10Aaron Schulz: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452881 [01:50:09] (03CR) 10jerkins-bot: [V: 04-1] Don't call SpecialPageFactory methods statically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/450951 (owner: 10simetrical) [01:52:59] (03Merged) 10jenkins-bot: DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base [core] - 10https://gerrit.wikimedia.org/r/452023 (owner: 10VolkerE) [01:53:01] (03CR) 10jerkins-bot: [V: 04-1] Update OOUI to v0.28.0 [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) (owner: 10VolkerE) [01:53:47] wikimedia/mediawiki#21749 (master - 329a721 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416177388 [01:53:54] (03PS1) 10Ejegg: Update DonationInterface [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452883 [01:53:56] (03CR) 10Ejegg: [C: 032] Update DonationInterface [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452883 (owner: 10Ejegg) [01:55:53] (03CR) 10jenkins-bot: DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base [core] - 10https://gerrit.wikimedia.org/r/452023 (owner: 10VolkerE) [01:57:23] (03Merged) 10jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452883 (owner: 10Ejegg) [02:02:02] wikimedia/mediawiki#21749 (master - 329a721 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416177388 [02:03:32] wikimedia/mediawiki#21749 (master - 329a721 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416177388 [02:07:28] (03PS5) 10Legoktm: Don't call SpecialPageFactory methods statically [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/450951 (owner: 10simetrical) [02:07:32] (03CR) 10jerkins-bot: [V: 04-1] Don't call SpecialPageFactory methods statically [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/450948 (owner: 10simetrical) [02:07:35] (03CR) 10jerkins-bot: [V: 04-1] Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [02:07:36] (03CR) 10jerkins-bot: [V: 04-1] Inject SpecialPageFactory into Parser [core] - 10https://gerrit.wikimedia.org/r/452876 (owner: 10Legoktm) [02:07:41] (03CR) 10jerkins-bot: [V: 04-1] Don't call SpecialPageFactory methods statically [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/450948 (owner: 10simetrical) [02:07:43] (03CR) 10jerkins-bot: [V: 04-1] Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [02:07:45] (03CR) 10jerkins-bot: [V: 04-1] Inject SpecialPageFactory into Parser [core] - 10https://gerrit.wikimedia.org/r/452876 (owner: 10Legoktm) [02:08:10] 10Trust-and-Safety, 10Wikimedia-Site-requests: Request for password reset for CentralAuth User:Textorus - https://phabricator.wikimedia.org/T201612 (10Textorus2) **Thank you so much**, jrbs. I've just logged back in to the old account with a new password and looks like I'm good to go now. Consider yourself t... [02:08:45] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Technical-Debt (Deprecation): Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook - https://phabricator.wikimedia.org/T140804 (10Krinkle) 05Open>03Resolved [02:12:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/452778 (owner: 10L10n-bot) [02:17:46] wikimedia/mediawiki#21748 (master - c1d7412 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416170700 [02:18:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [02:18:15] Krinkle: https://www.mediawiki.org/wiki/Compatibility#Browser_support_matrix in contrast to https://phabricator.wikimedia.org/T124905 [02:25:08] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review, 10User-D3r1ck01: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10Aklapper) Not something that Qgil is invoked with hence removing. Thanks for working o... [02:25:40] (03PS1) 10Aaron Schulz: Add domain sanity check to LoadBalancer::openForeignConnection [core] - 10https://gerrit.wikimedia.org/r/452885 [02:26:59] wikimedia/mediawiki#21750 (master - 7bf08b1 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416183235 [02:33:18] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452777 (owner: 10L10n-bot) [02:34:06] (03CR) 10jenkins-bot: Upgrade wikimedia/remex-html to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/452823 (owner: 10Legoktm) [02:36:57] (03CR) 10jenkins-bot: Follow-up fc88eea: Add new oojs-ui.styles.icons-editing-citation pack [core] - 10https://gerrit.wikimedia.org/r/452752 (owner: 10Jforrester) [02:37:41] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) (owner: 10Sbisson) [02:41:34] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/452781 (owner: 10L10n-bot) [02:45:14] Volker_E: Hm.. I see. [02:45:17] You mean Grade C [02:45:43] So far we've only dropped Grade C for <0.1% browsers afaik [02:45:47] IE 7 is in that range now [02:45:53] but oddly enough, IE 6 is not [02:46:01] I think we could make an exception here [02:46:17] But for other reasons, it might be worth also thinking about https://phabricator.wikimedia.org/T124932 [02:46:20] In production we already make an exception in some places [02:46:24] For the long term. [02:46:44] what you think of? [02:48:23] Grade C is a superset of Grade A because intermittent connections, syntax errors, time outs and other issues on the client and server side, any user can end up in Grade C. [02:48:39] That means we have a single stylesheet served as basis for Grade A, that also has to support all of Grade C. [02:48:54] While we can drop IE6/IE7 from that, I think it would still be nice to not have to support all the browsers in that [02:49:16] E.g. by investing in a fallback mode with a mostly semantic/universal styles-only experience. [02:49:29] I don't know if that actually makes sense for us, but I find the idea appealing. [02:50:04] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Aklapper) @PerfektesChaos: Wiki vs Not-Wiki is off-topic here. See task summary and use https://meta.wikimedia.org/wiki/Talk:Wikimedia_Foundation_website instead. [02:51:02] Krinkle: If I understand you correctly, there should be a subset of our styles providing default universal support for some fundamental layout? [02:51:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452782 (owner: 10L10n-bot) [02:52:36] Volker_E: I'm not sure whether it'd have to be a subset, it could just be an alternate one; pretty much just "not Times New Roman", basically. [02:52:50] It's an old idea, popularised as "Universal IE6 IE7 stylesheet" a few years back. [02:53:05] But it would allow OOUI to drop browser support sooner than overall Grade C. [02:53:09] Assuming semantic HTML is used. [02:53:16] Krinkle: but you know it yourself very well, that we would need to go back wide in CSS time for such [02:53:38] Krinkle: because which browser should fall under these? [02:53:42] (03PS14) 10Legoktm: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [02:53:44] (03PS4) 10Legoktm: Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [02:53:46] (03PS2) 10Legoktm: Inject SpecialPageFactory into Parser [core] - 10https://gerrit.wikimedia.org/r/452876 [02:53:54] IE6/7 or any basic CSS capable browser [02:53:55] (03CR) 10jenkins-bot: Exclude Drafts from daily cleanup of PageTriage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452665 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [02:54:07] (03PS7) 10Legoktm: Don't call SpecialPageFactory methods statically [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/450948 (owner: 10simetrical) [02:54:34] that would bring us to extremely limited things like basic hex colors, generic font-families, px sizes [02:54:47] don't think that's really worth the effort [02:55:02] I think we've gotten out of sync. What would be limited? [02:55:30] I'm proposing this so as to allow you to adopt modern CSS features earlier and faster. [02:55:45] by not having to support all of Grade C in OOUI's no-js mode. [02:56:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452791 (owner: 10L10n-bot) [02:56:08] are we talking about serving only ie6/7 [02:56:10] ? [02:56:23] like here: https://css-tricks.com/snippets/html/universal-ie6-css/ [02:56:33] 10InternetArchiveBot (v2.0): It took IABot two edits to tag a link as dead - https://phabricator.wikimedia.org/T200601 (10Cyberpower678) Nope, this is a bug. [02:56:54] Up to you. But yes, that could be a starting point. We could expand it to other browsers for which we don't want to support the primary stylesheets. [02:57:33] Krinkle: how would you expand that, the approach makes use of conditional comments (which I would not want in our source code any more) [02:57:57] (03CR) 10jenkins-bot: Group filters in the filter list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451815 (https://phabricator.wikimedia.org/T199277) (owner: 10Catrope) [02:57:59] (03CR) 10Legoktm: [C: 032] "lol" [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [02:59:57] Volker_E: I haven't settled on a particular approach, but there's lots of ways we could do it. Conditional comments is one way, but not so pretty and limited to old IE. Another way could be a custom classname set inline (like we do with client-js, so no FOUC), and then target that early on. So the same way that .client-js can be in the main stylesheet, but only applies to Grade A with JS, we could have .client-oldcss and target that. [03:00:39] (03CR) 10Legoktm: [C: 032] SpecialGadgetUsage: Add and in the table [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/449278 (owner: 10Fomafix) [03:01:00] Then we'd need to find a creative way to let the rest of the styles not apply. Maybe with @supports (which is invalid and silently ignored in old browsers), or some other technique. [03:01:43] But before we get into the ugly details, I'm more interested in knowing whether youd want such a system, from a design/product/maintenance perspective. Just presume for now that it'll be delivered by ResourceLoader in magical and pretty ways :) [03:02:45] (03CR) 10Krinkle: [C: 032] Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 (owner: 10Aaron Schulz) [03:03:02] (03PS2) 10Krinkle: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [03:03:28] (03PS2) 10Krinkle: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452881 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [03:04:05] (03PS2) 10Krinkle: rdbms: Add domain sanity check to LoadBalancer::openForeignConnection [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:04:13] (03PS3) 10Krinkle: rdbms: Disable DBConnRef::selectDB() for sanity [core] - 10https://gerrit.wikimedia.org/r/452616 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:05:04] Krinkle: I don't see it done in a reasonably time frame that really provides benefit from design perspective over not serving CSS to incapable browsers [03:05:34] that was what my 'bring us to extremely limited things' was about [03:05:43] (03CR) 10jenkins-bot: Parser: Call firstCallInit() in getTags/getFunctionHooks [core] - 10https://gerrit.wikimedia.org/r/452601 (owner: 10Legoktm) [03:05:48] (03CR) 10Legoktm: [C: 04-1] New version 1.0.0 (034 comments) [extensions/Spark] - 10https://gerrit.wikimedia.org/r/424605 (https://phabricator.wikimedia.org/T189687) (owner: 10Zoranzoki21) [03:07:09] why even coming up with such solution, when such browsers (and I don't settle on IE6/7 then) only can consume basic CSS [03:09:05] we would still need to test it, it wouldn't provide useful branding and layout – or if so it were to take much more time in design, implementation and testing [03:16:10] tl;dr I don't think it's worth the effort [03:27:52] (03Merged) 10jenkins-bot: MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [03:28:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/452798 (owner: 10L10n-bot) [03:30:26] (03CR) 10jenkins-bot: MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [03:38:50] 10InternetArchiveBot (v2.0): Investigate cause of chained dead link tags - https://phabricator.wikimedia.org/T195794 (10Cyberpower678) 05Open>03Resolved [03:40:05] wikimedia/mediawiki#21751 (master - 757e552 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416200539 [03:40:56] 10MediaWiki-Parser, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018): Move CoreParserFunctions and CoreTagHooks away from using global/static state - https://phabricator.wikimedia.org/T201980 (10Legoktm) [03:41:12] James_F: ^^ [03:43:08] 10InternetArchiveBot: IABot does not correctly handle link labels containing an internal link or a template - https://phabricator.wikimedia.org/T191140 (10Cyberpower678) >>! In T191140#4146479, @Cirdan wrote: > Using links within link labels is definitely not valid wikitext and should be cleaned up, even though... [03:45:53] (03CR) 10jenkins-bot: Fix common typo "MediWiki" in MW core [core] - 10https://gerrit.wikimedia.org/r/452820 (https://phabricator.wikimedia.org/T201491) (owner: 10D3r1ck01) [03:46:53] (03PS2) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [03:46:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/452795 (owner: 10L10n-bot) [03:48:42] (03PS3) 10Aaron Schulz: rdbms: Add domain sanity check to LoadBalancer::openForeignConnection [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [03:48:49] (03PS3) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [03:49:29] (03PS4) 10Aaron Schulz: rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [03:49:54] (03PS4) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [03:50:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/452802 (owner: 10L10n-bot) [03:50:57] wikimedia/mediawiki#21751 (master - 757e552 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416200539 [03:50:58] (03CR) 10jenkins-bot: registration: Don't initialize MWServices super early [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/452838 (https://phabricator.wikimedia.org/T154960) (owner: 10Legoktm) [03:52:40] (03CR) 10jenkins-bot: Merge branch 'REL1_27' into fundraising/REL1_27 [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452853 (owner: 10Ejegg) [03:53:22] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/452799 (owner: 10L10n-bot) [03:55:33] (03CR) 10jerkins-bot: [V: 04-1] rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:55:52] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:56:56] 10InternetArchiveBot, 10Tracking: IABot template parsing and handling - https://phabricator.wikimedia.org/T199859 (10Cyberpower678) [03:56:58] 10InternetArchiveBot: IABot does not correctly recognize the start and end of templates - https://phabricator.wikimedia.org/T194246 (10Cyberpower678) 05Open>03Resolved [03:57:20] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:57:25] (03PS5) 10Aaron Schulz: rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [03:57:27] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [03:59:04] (03CR) 10jenkins-bot: Update DonationInterface submodule [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452855 (owner: 10Ejegg) [04:00:00] (03PS1) 10Legoktm: Have TitleParser::parseTitle() default to NS_MAIN to match Title [core] - 10https://gerrit.wikimedia.org/r/452886 [04:01:13] (03CR) 10jerkins-bot: [V: 04-1] rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [04:08:25] legoktm: Thanks. [04:08:55] (03CR) 10jenkins-bot: Group filters in the filter list [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451815 (https://phabricator.wikimedia.org/T199277) (owner: 10Catrope) [04:14:16] (03CR) 10Jforrester: Add `toolbar` and `tool` variables (031 comment) [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452753 (owner: 10VolkerE) [04:14:55] (03PS1) 10Legoktm: TitleValue: Don't use Assert for basic type checks [core] - 10https://gerrit.wikimedia.org/r/452887 (https://phabricator.wikimedia.org/T201801) [04:18:42] (03CR) 10jenkins-bot: Score 'draftquality' and 'wp10' for new revs of pages in queue [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452850 (https://phabricator.wikimedia.org/T199357) (owner: 10Catrope) [04:18:52] wikimedia/mediawiki#21751 (master - 757e552 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416200539 [04:18:57] 10New-Readers, 10Proton, 10Readers-Web-Backlog (Design): Add the print button to mobile browsers other than Chrome - https://phabricator.wikimedia.org/T201954 (10phuedx) >>! In T201954#4502632, @Jdlrobson wrote: > Prioritise as necessary! Understanding that: - The deployment of the Proton service is blocke... [04:22:07] (03CR) 10jenkins-bot: Always show creation date for AfC drafts [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452856 (https://phabricator.wikimedia.org/T201373) (owner: 10Catrope) [04:22:46] (03PS1) 10Aaron Schulz: Split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 [04:26:25] (03CR) 10jenkins-bot: DateTimeInputWidget: Rename LESS var to align with WikimediaUI Base [core] - 10https://gerrit.wikimedia.org/r/452023 (owner: 10VolkerE) [04:29:18] (03CR) 10jenkins-bot: Only join with ORES tables if we're filtering [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452852 (https://phabricator.wikimedia.org/T201560) (owner: 10Catrope) [04:30:51] (03CR) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452851 (https://phabricator.wikimedia.org/T201812) (owner: 10Catrope) [04:33:57] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-General, 10Developer-Wishlist (2017), 10Documentation, 10User-Tgr: Document extensions' MediaWiki version compatibility better - https://phabricator.wikimedia.org/T156500 (10Aklapper) [04:34:17] (03CR) 10jenkins-bot: Score 'draftquality' and 'wp10' for new revs of pages in queue [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452850 (https://phabricator.wikimedia.org/T199357) (owner: 10Catrope) [04:34:20] (03PS6) 10Aaron Schulz: rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [04:34:37] (03PS2) 10Aaron Schulz: rdbms: split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 [04:34:41] (03CR) 10jenkins-bot: MergeHistory: Fix flaky test due to relative timestamp [core] - 10https://gerrit.wikimedia.org/r/452873 (https://phabricator.wikimedia.org/T201976) (owner: 10Krinkle) [04:35:26] (03PS7) 10Aaron Schulz: rdbms: Add domain sanity check to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [04:35:38] (03CR) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452851 (https://phabricator.wikimedia.org/T201812) (owner: 10Catrope) [04:35:49] (03PS5) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [04:37:44] (03CR) 10jenkins-bot: Always show creation date for AfC drafts [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452856 (https://phabricator.wikimedia.org/T201373) (owner: 10Catrope) [04:39:21] (03PS8) 10Aaron Schulz: rdbms: add domain sanity checks to LoadBalancer connection methods [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) [04:40:42] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452857 (https://phabricator.wikimedia.org/T201253) (owner: 10Catrope) [04:43:12] (03CR) 10Jforrester: Update OOUI to v0.28.0 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452872 (https://phabricator.wikimedia.org/T109529) (owner: 10VolkerE) [04:43:33] (03CR) 10jenkins-bot: Only join with ORES tables if we're filtering [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452852 (https://phabricator.wikimedia.org/T201560) (owner: 10Catrope) [04:44:16] (03CR) 10Jforrester: [C: 031] Have TitleParser::parseTitle() default to NS_MAIN to match Title [core] - 10https://gerrit.wikimedia.org/r/452886 (owner: 10Legoktm) [04:45:07] (03CR) 10Jforrester: [C: 031] "Neat." [core] - 10https://gerrit.wikimedia.org/r/452887 (https://phabricator.wikimedia.org/T201801) (owner: 10Legoktm) [04:46:43] (03CR) 10Jforrester: [C: 031] Replace deprecated Linker::link() with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/452726 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [04:49:51] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [04:49:57] (03CR) 10jenkins-bot: Doc: fix typo [extensions/Popups] - 10https://gerrit.wikimedia.org/r/452693 (owner: 10Niedzielski) [04:52:13] (03CR) 10jenkins-bot: Update DonationInterface [core] (fundraising/REL1_27) - 10https://gerrit.wikimedia.org/r/452883 (owner: 10Ejegg) [04:53:16] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452857 (https://phabricator.wikimedia.org/T201253) (owner: 10Catrope) [04:56:45] (03CR) 10jenkins-bot: Exclude Drafts from daily cleanup of PageTriage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452665 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [05:00:25] (03Merged) 10jenkins-bot: SpecialGadgetUsage: Add and in the table [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/449278 (owner: 10Fomafix) [05:00:33] 10Wikimedia-Extension-setup, 10Patch-For-Review, 10Tracking: Extensions needing to be removed from Wikimedia wikis - https://phabricator.wikimedia.org/T106123 (10Aklapper) [05:00:36] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Technical-Debt: Undeploy UnicodeConverter - https://phabricator.wikimedia.org/T195941 (10Aklapper) [05:00:42] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Technical-Debt: Undeploy UnicodeConverter - https://phabricator.wikimedia.org/T195941 (10Aklapper) I removed `{{TNT|OnWikimedia}}` from https://www.mediawiki.org/wiki/Extension:UnicodeConverter . `status` on that page says `stabl... [05:01:25] (03CR) 10jenkins-bot: Remove $wgEchoNewMsgAlert and 'echo-show-alert' preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [05:01:59] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-General, 10Developer-Wishlist (2017), 10Documentation, 10User-Tgr: Document extensions' MediaWiki version compatibility better - https://phabricator.wikimedia.org/T156500 (10Aklapper) There has been a `MediaWiki` (=supported MW core versions) field i... [05:03:27] (03CR) 10Aaron Schulz: [C: 032] JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [05:04:43] (03CR) 10jenkins-bot: SpecialGadgetUsage: Add and in the table [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/449278 (owner: 10Fomafix) [05:04:45] 10MediaWiki-Maintenance-scripts, 10Core-Platform-Team, 10User-Nikerabbit: edit.php and rollbackEdits.php scripts failing with MWException "CAS update failed on user_touched" - https://phabricator.wikimedia.org/T197472 (10Nemo_bis) >>! In T197472#4503986, @Anomie wrote: > Did some bug result in an empty user_... [05:04:46] (03CR) 10Aaron Schulz: [C: 032] "ping jenkins" [core] - 10https://gerrit.wikimedia.org/r/452880 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [05:07:51] (03PS6) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [05:13:31] (03PS1) 10Legoktm: Remove dead code from Title::secureAndSplit() [core] - 10https://gerrit.wikimedia.org/r/452889 [05:18:10] (03CR) 10Jforrester: [C: 032] Remove dead code from Title::secureAndSplit() [core] - 10https://gerrit.wikimedia.org/r/452889 (owner: 10Legoktm) [05:20:49] 10MediaWiki-extensions-Quiz, 10Editing-team, 10VisualEditor, 10Wikimedia-log-errors: PHP Notice: Undefined index from extensions/Quiz/Question.php on line 380 - https://phabricator.wikimedia.org/T196684 (10Krinkle) [05:23:50] (03Merged) 10jenkins-bot: JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [05:25:24] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Aklapper) @Nemo_bis: It is irrelevant which software is used to show a string on the website. This task is about showing a potentially confusing string on a Wik... [05:26:32] (03CR) 10jenkins-bot: JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [05:29:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [05:34:06] (03PS1) 10Legoktm: Title: Access properties directly instead of wrapper functions [core] - 10https://gerrit.wikimedia.org/r/452890 [05:34:19] (03Merged) 10jenkins-bot: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [05:37:31] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Nemo_bis) > @Nemo_bis: It is irrelevant which software is used to show a string on the website. Indeed, so why do you insist that people go discuss that instea... [05:37:36] wikimedia/mediawiki#21752 (master - 1666a9d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416221401 [05:37:53] (03CR) 10jenkins-bot: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [05:39:52] (03CR) 10Tim Starling: [C: 032] rdbms: split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 (owner: 10Aaron Schulz) [05:43:23] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Spike: [4 hours] Spike: How hard would it be to track number of edits saved that used TemplateWizard? - https://phabricator.wikimedia.org/T201476 (10Samwilson) a:03Samwilson One not-too-complicated way to do it could be to log whenever someone clic... [05:44:21] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Spike: [4 hours] Spike: How hard would it be to track number of edits saved that used TemplateWizard? - https://phabricator.wikimedia.org/T201476 (10Samwilson) [05:47:17] wikimedia/mediawiki#21752 (master - 1666a9d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416221401 [05:47:20] (03CR) 10Tim Starling: [C: 031] "I guess it's harmless, but it doesn't help to address the issue we discussed on IRC, and it probably doesn't help to fix the referenced bu" [core] - 10https://gerrit.wikimedia.org/r/452885 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [05:51:32] 04(no projects): Creating Cyrillic to Latin transliteration for Kumyk language - https://phabricator.wikimedia.org/T201982 (10Arsenekoumyk) [05:52:01] wikimedia/mediawiki#21753 (master - d792e31 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416223244 [05:56:49] (03PS2) 10Legoktm: Title: Access properties directly instead of wrapper functions [core] - 10https://gerrit.wikimedia.org/r/452890 [05:56:51] (03PS1) 10Legoktm: Have LinkCache::getMutableCacheKeys() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/452892 [05:57:25] 04(no projects): Creating Cyrillic to Latin transliteration for Kumyk language - https://phabricator.wikimedia.org/T201982 (10Arsenekoumyk) [05:58:11] 04(no projects): Creating Cyrillic to Latin transliteration for Kumyk language - https://phabricator.wikimedia.org/T201982 (10Aklapper) Hi @Arsenekoumyk, thanks for taking the time to report this! Is this about #mediawiki-language-converter ? [05:59:14] wikimedia/mediawiki#21753 (master - d792e31 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416223244 [06:00:06] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Technical-Debt: Undeploy UnicodeConverter - https://phabricator.wikimedia.org/T195941 (10Legoktm) I don't see any reason to archive it. It's an example extension. It could use a bit of cleanup though to meet modern standards. [06:00:34] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10Aklapper) @Nemo_bis: I never wrote that incorrect HTML is not a bug. You may want to read my comment again and which aspect I referred to. [06:01:55] (03CR) 10jenkins-bot: Make ExternalStoreDB "wiki" context override the server "dbname" field [core] - 10https://gerrit.wikimedia.org/r/452880 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [06:02:09] 10Wikimedia-Extension-setup, 10Wikimedia-Site-requests, 10Patch-For-Review, 10Technical-Debt: Undeploy UnicodeConverter - https://phabricator.wikimedia.org/T195941 (10Aklapper) Sounds pretty similar to https://www.mediawiki.org/wiki/Extension:Example and {T156568} instead. [06:03:53] wikimedia/mediawiki#21753 (master - d792e31 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416223244 [06:06:06] (03Merged) 10jenkins-bot: rdbms: split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 (owner: 10Aaron Schulz) [06:08:49] (03CR) 10jenkins-bot: rdbms: split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 (owner: 10Aaron Schulz) [06:19:50] wikimedia/mediawiki#21754 (master - cadd656 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416229445 [06:20:16] wikimedia/mediawiki#21754 (master - cadd656 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416229445 [06:20:56] 04(no projects): Creating Cyrillic to Latin transliteration for Kumyk language - https://phabricator.wikimedia.org/T201982 (10Arsenekoumyk) @Aklapper yes it is indeed [06:22:36] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint): Copyvio: Create extension page and help page on mediawiki.org - https://phabricator.wikimedia.org/T201500 (10Aklapper) [06:23:23] 10MediaWiki-Language-converter: Creating Cyrillic to Latin transliteration for Kumyk language - https://phabricator.wikimedia.org/T201982 (10Aklapper) [06:29:57] wikimedia/mediawiki#21754 (master - cadd656 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416229445 [06:31:21] wikimedia/mediawiki#21754 (master - cadd656 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416229445 [06:32:47] wikimedia/mediawiki#21754 (master - cadd656 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416229445 [06:35:21] 10WMSE-Riksarkivet-TORA: Define TORA as an endpoint in Wikidata - https://phabricator.wikimedia.org/T200066 (10Salgo60) @MatthiasPalmer nu har vi testat med NobelData se {{T200668}} så får vi nedanstående info till TORA eller annan db som bygger på samma teknik så kan vi starta testa == Information needed === F... [06:37:12] (03PS6) 10WMDE-Fisch: Add PHPUnit tests for extension Mailgun [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [06:37:19] wikimedia/mediawiki#21753 (master - d792e31 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416223244 [06:37:41] 10MediaWiki-extensions-WikimediaBadges, 10Wikidata, 10Wikidata.org, 10WikimediaMessages: Investigate whether Wikidata.org extension can be merged into other extensions - https://phabricator.wikimedia.org/T201226 (10Legoktm) Confusingly, Wikidata.org and WikimediaBadges have very similarly named images (res... [06:39:20] (03CR) 10jenkins-bot: rdbms: split out private LoadBalancer::openLocalConnection method [core] - 10https://gerrit.wikimedia.org/r/452888 (owner: 10Aaron Schulz) [06:40:05] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit tests for extension Mailgun [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [06:45:55] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [06:49:58] (03CR) 10Tim Starling: [C: 04-1] "I think Database::selectDB() should throw instead of returning false on failure. mysqli::select_db() does not even raise a warning if you " (036 comments) [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [06:52:56] (03CR) 10Tpt: Guess that the Page: serialization is in JSON only if it an array or an object (031 comment) [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451834 (https://phabricator.wikimedia.org/T201506) (owner: 10Tpt) [06:56:32] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Database::selectDB() update the domain field and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [07:02:51] 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)): ContentTranslation page: Dashboard link "More about this tool" should point to lang specific page? - https://phabricator.wikimedia.org/T185061 (10Petar.petkovic) [07:06:16] 10wikimediafoundation.org: Publish Source Code for wikimediafoundation.org - https://phabricator.wikimedia.org/T201572 (10Varnent) >>! In T201572#4495561, @Bawolff wrote: >> Additionally, Gerrit would be a mirror and not the primary location of the code. It is more to make the code available for use and review t... [07:18:09] (03PS3) 10ItSpiderman: Require newer version of oojs-ui [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452672 [07:25:21] (03CR) 10jerkins-bot: [V: 04-1] Require newer version of oojs-ui [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452672 (owner: 10ItSpiderman) [07:49:29] (03PS1) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/452893 (https://phabricator.wikimedia.org/T201491) [07:49:53] (03PS2) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/452893 (https://phabricator.wikimedia.org/T201491) [07:51:12] (03PS1) 10PleaseStand: Various cleanup changes in DiffHistoryBlob [core] - 10https://gerrit.wikimedia.org/r/452894 [07:52:17] (03CR) 10Umherirrender: "Passed" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/451358 (owner: 10Umherirrender) [07:53:13] 10CX-cxserver, 10Language-2018-July-September: CXServer translation APIs cannot be tested via generated documentation - https://phabricator.wikimedia.org/T201984 (10Nikerabbit) [07:54:18] (03CR) 10Thiemo Kreuz (WMDE): "Uh, sorry? Almost all code type-hints against the interface now, not against a specific implementation. What a caller is able to know is w" [core] - 10https://gerrit.wikimedia.org/r/452631 (owner: 10Thiemo Kreuz (WMDE)) [07:55:11] (03PS1) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) [07:55:57] (03PS2) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) [07:57:08] (03PS1) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452896 (https://phabricator.wikimedia.org/T201491) [07:57:49] (03PS2) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452896 (https://phabricator.wikimedia.org/T201491) [07:58:49] (03PS1) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) [07:58:53] 10Wikimedia-Site-requests: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Aykhan_Zayedzadeh) @Dcljr Yes, and it would be great if phabricator users changed that. [07:59:12] 10BetaFeatures, 10phan-taint-check-plugin: BetaFeaturesHooks double escaping of message - https://phabricator.wikimedia.org/T200990 (10Umherirrender) 05Open>03Resolved a:03Umherirrender >>! In T200990#4495656, @Umherirrender wrote: > Code is refactored in https://gerrit.wikimedia.org/r/#/c/mediawiki/exte... [07:59:22] (03PS2) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) [08:03:27] (03CR) 10Raimond Spekking: [C: 031] Add Australian English en-au to language name list [core] - 10https://gerrit.wikimedia.org/r/452879 (owner: 10Samwilson) [08:04:05] (03CR) 10Raimond Spekking: [C: 031] "Pls add the addition to the RELEASE NOTES too." [core] - 10https://gerrit.wikimedia.org/r/452879 (owner: 10Samwilson) [08:04:27] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 [08:04:35] (03CR) 10Umherirrender: "check experimental" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 (owner: 10Umherirrender) [08:06:55] (03CR) 10Aaron Schulz: [WIP] Database::selectDB() update the domain field and handle failure better (034 comments) [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [08:09:15] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) [08:09:52] 10MediaWiki-Internationalization: Add Australian English to list of language names - https://phabricator.wikimedia.org/T201985 (10Samwilson) [08:10:27] (03PS2) 10Samwilson: Add Australian English en-au to language name list [core] - 10https://gerrit.wikimedia.org/r/452879 (https://phabricator.wikimedia.org/T201985) [08:10:54] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Zoranzoki21) WIki is done. https://github.com/SemanticMediaWiki/SemanticMediaWiki/pull/3... [08:14:20] 10MediaWiki-Maintenance-scripts, 10Core-Platform-Team, 10User-Nikerabbit: edit.php and rollbackEdits.php scripts failing with MWException "CAS update failed on user_touched" - https://phabricator.wikimedia.org/T197472 (10Nikerabbit) I have three such accounts at translatewiki.net where `user_touched` is not... [08:15:25] 10phan-taint-check-plugin: Make IDatabase::makeList safe for phan-taint-check-plugin - https://phabricator.wikimedia.org/T201987 (10Umherirrender) [08:15:56] (03PS5) 10Umherirrender: Add phan-taint-check-plugin [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 [08:15:58] (03PS1) 10Litzsch: Added a Scribunto Lua interface [extensions/Variables] - 10https://gerrit.wikimedia.org/r/452899 [08:16:00] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/Variables] - 10https://gerrit.wikimedia.org/r/452899 (owner: 10Litzsch) [08:16:02] (03PS6) 10Umherirrender: Add phan-taint-check-plugin [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 [08:16:06] (03CR) 10Umherirrender: "check experimental" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 (owner: 10Umherirrender) [08:16:31] (03CR) 10Umherirrender: "Passed now, added a task for suppression to track the issue" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/451357 (owner: 10Umherirrender) [08:18:04] 10MediaWiki-Internationalization: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Aklapper) You or anyone else is very welcome to [[ https://www.mediawiki.org/wiki/Gerrit/Tutorial | propose a software patch ]] if you are interested to get thi... [08:18:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Nice and clean. Personally, I would go much more crazy, as shown in T201801#4497755. Should I? ;-)" [core] - 10https://gerrit.wikimedia.org/r/452887 (https://phabricator.wikimedia.org/T201801) (owner: 10Legoktm) [08:18:41] (03CR) 10PleaseStand: Various cleanup changes in DiffHistoryBlob (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452894 (owner: 10PleaseStand) [08:19:03] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 [08:19:10] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 (owner: 10Umherirrender) [08:23:24] (03CR) 10Mglaser: [C: 032] Fix 'MediWiki' typo [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/452893 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:23:54] (03Merged) 10jenkins-bot: Fix 'MediWiki' typo [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/452893 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:24:44] 10MediaWiki-extensions-Translate: Special:AggregateGroups@metawiki fails to load properly - https://phabricator.wikimedia.org/T201819 (10Nikerabbit) I cannot reproduce. There is no indication of bug in Translate. It looks like some JavaScript failed to load, which can be explained by a connectivity issue. The s... [08:26:30] (03CR) 10Aaron Schulz: "Isn't the main bug << $this->conns[$connInUseKey][$i][$conn->getDomainId()] = $conn; >> not working due to selectDB() having no effect on " [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) (owner: 10Aaron Schulz) [08:28:21] (03CR) 10jerkins-bot: [V: 04-1] Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:28:23] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Variables: Create a Scribunto interface - https://phabricator.wikimedia.org/T201171 (10Litzsch) I've just pushed a possible patch to [[https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Variables/+/452899/|Gerrit]]. There's a small issue with indent... [08:29:46] (03PS1) 10Aaron Schulz: rdbms: use Database::getDomainId for transaction logging calls [core] - 10https://gerrit.wikimedia.org/r/452900 [08:29:57] 10WMSE-Riksarkivet-TORA: Property proposal/Related parish - https://phabricator.wikimedia.org/T201074 (10Salgo60) p:05Normal>03Lowest [08:31:57] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix 'MediWiki' typo [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452896 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:32:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:33:49] (03CR) 10Gergő Tisza: Add hoisting option to StyleRuleSanitizer selector handling (032 comments) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/452049 (https://phabricator.wikimedia.org/T197617) (owner: 10Gergő Tisza) [08:34:41] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 [08:34:46] (03PS5) 10Umherirrender: Add phan-taint-check-plugin [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 [08:34:55] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 (owner: 10Umherirrender) [08:35:03] (03PS1) 10Legoktm: Actually inject InterwikiLookup into MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/452902 [08:35:05] (03PS1) 10Legoktm: Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 [08:35:06] (03PS1) 10Legoktm: Have LinkTarget be responsible for tracking usage of leading colons [core] - 10https://gerrit.wikimedia.org/r/452904 [08:41:12] (03PS1) 10Umherirrender: Escape date in non-gallery mode [extensions/intersection] - 10https://gerrit.wikimedia.org/r/452905 [08:41:32] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/intersection] - 10https://gerrit.wikimedia.org/r/451347 [08:41:38] (03CR) 10Umherirrender: "check experimental" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/451347 (owner: 10Umherirrender) [08:42:19] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 [08:42:21] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 [08:42:29] (03CR) 10Umherirrender: "check experimental" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [08:43:55] (03CR) 10Thiemo Kreuz (WMDE): Fix 'MediWiki' typo (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [08:45:33] 10MediaWiki-Internationalization: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Tulsi_Bhagat) >>! In T201770#4504282, @Aklapper wrote: > You or anyone else is very welcome to [[ https://www.mediawiki.org/wiki/Gerrit/Tutorial | propose a sof... [08:51:08] 10ContentTranslation, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)): ContentTranslation page: Dashboard link "More about this tool" should point to lang specific page? - https://phabricator.wikimedia.org/T185061 (10Petar.petkovic) 05Open>03Resolved a:03Petar.petkovic [08:53:55] (03PS7) 10Aaron Schulz: rdbms: Database::selectDB() update the domain and handle failure better [core] - 10https://gerrit.wikimedia.org/r/452878 (https://phabricator.wikimedia.org/T193565) [08:58:19] (03PS1) 10Nikerabbit: Make LinkBatch::setCaller chainable [core] - 10https://gerrit.wikimedia.org/r/452907 [08:59:35] 10MediaWiki-extensions-Translate, 10Language-2018-July-September, 10Patch-For-Review: Special:AggregateGroups@metawiki fails to load properly - https://phabricator.wikimedia.org/T201819 (10Nikerabbit) a:03Nikerabbit [09:02:46] 10Mitmachen: add instructional text - https://phabricator.wikimedia.org/T201989 (10sonkiki) [09:03:35] (03PS2) 10Umherirrender: Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [09:03:38] (03CR) 10Umherirrender: [C: 032] Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [09:04:30] (03Merged) 10jenkins-bot: Fix 'MediWiki' typo [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452896 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:04:32] (03CR) 10jerkins-bot: [V: 04-1] Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:05:11] (03CR) 10Nikerabbit: [C: 04-1] "Why (in this order)? There are no en-AU translations in core, it's not exported from or even supported at translatewiki.net, and it's not " [core] - 10https://gerrit.wikimedia.org/r/452879 (https://phabricator.wikimedia.org/T201985) (owner: 10Samwilson) [09:06:54] (03CR) 10jerkins-bot: [V: 04-1] Have LinkTarget be responsible for tracking usage of leading colons [core] - 10https://gerrit.wikimedia.org/r/452904 (owner: 10Legoktm) [09:07:06] 10New-Readers, 10Proton, 10Readers-Web-Backlog (Design): Add the print button to mobile browsers other than Chrome - https://phabricator.wikimedia.org/T201954 (10ovasileva) Agreed. @alexhollender - if you do get a chance to look this week, for the latest version we decided not to include the file size. So... [09:09:52] (03CR) 10jerkins-bot: [V: 04-1] Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 (owner: 10Legoktm) [09:10:00] (03CR) 10Umherirrender: [C: 04-1] "The extra parameter should be removed from tests (EchoAttributeManagerTest) to match the same count of parameters there." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:13:47] (03PS4) 10Aaron Schulz: [WIP] Serialize values in HashBagOStuff for consistency with other stores [core] - 10https://gerrit.wikimedia.org/r/445158 [09:16:18] 10Product-Analytics: Determine ratio of wikitext edits made from mobile devices that use the desktop interface - https://phabricator.wikimedia.org/T201973 (10ovasileva) p:05Triage>03High [09:16:41] (03PS2) 10Legoktm: Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 [09:16:43] (03PS2) 10Legoktm: Have LinkTarget be responsible for tracking usage of leading colons [core] - 10https://gerrit.wikimedia.org/r/452904 [09:20:12] (03PS2) 10Thiemo Kreuz (WMDE): Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 [09:20:40] (03CR) 10Thiemo Kreuz (WMDE): "How did I missed these? Thanks!" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:23:11] 10Mitmachen: Revise language, terms and text (including mouseover help texts) - https://phabricator.wikimedia.org/T199017 (10sonkiki) [09:23:46] 10MediaWiki-Internationalization: Add Shawiya (Latin script) to list of language names - https://phabricator.wikimedia.org/T201990 (10Vikoula5) [09:23:57] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Patch-For-Review, 10Performance, 10User-Daniel: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title - https://phabricator.wikimedia.org/T201801 (10Legoktm) The above patch makes the TitleValue cons... [09:24:01] (03Merged) 10jenkins-bot: Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [09:27:23] (03CR) 10Umherirrender: "Passed" [extensions/intersection] - 10https://gerrit.wikimedia.org/r/451347 (owner: 10Umherirrender) [09:28:29] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/451333 [09:28:37] (03CR) 10Umherirrender: "check experimental" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/451333 (owner: 10Umherirrender) [09:29:55] (03PS3) 10Umherirrender: Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:29:57] (03CR) 10Zoranzoki21: "Can anyone to set +2 again? Jenkins again no work correctly. I no know why -1. I only changed README file which is not included in code of" [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:30:01] (03CR) 10Umherirrender: [C: 032] Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:30:34] (03PS1) 10Legoktm: Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/452910 [09:30:37] 10wikimediafoundation.org: partial German translation shows up in English text on wikimediafoundation.org - https://phabricator.wikimedia.org/T200742 (10PerfektesChaos) >>! In T200742#4502407, @PerfektesChaos wrote: > And not to remedy that within one or two days. Does anybody recall the meaning of //wiki//? *... [09:32:13] (03CR) 10Umherirrender: [C: 032] Actually inject InterwikiLookup into MediaWikiTitleCodec [core] - 10https://gerrit.wikimedia.org/r/452902 (owner: 10Legoktm) [09:36:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "The error is unrelated to this change. The +2 is set, and will not go away. But I will not manually merge this without the error being fix" [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:37:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Serialize values in HashBagOStuff for consistency with other stores [core] - 10https://gerrit.wikimedia.org/r/445158 (owner: 10Aaron Schulz) [09:39:37] (03CR) 10Zoranzoki21: "> The error is unrelated to this change. The +2 is set, and will not" [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:40:48] 10MediaWiki-Maintenance-scripts: Benchmarker should support per-iteration non-counted setup - https://phabricator.wikimedia.org/T201992 (10Legoktm) [09:41:36] (03CR) 10jerkins-bot: [V: 04-1] Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 (owner: 10Legoktm) [09:44:41] (03CR) 10jerkins-bot: [V: 04-1] Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:45:56] (03PS3) 10Zoranzoki21: Fix 'MediWiki' typo [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) [09:46:05] (03CR) 10jenkins-bot: Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [09:47:04] (03CR) 10Zoranzoki21: Fix 'MediWiki' typo (031 comment) [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:47:21] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, 10WMDE-Design (WMDE-Design-Workboard Doing): Move field for email address out of address section - https://phabricator.wikimedia.org/T188516 (10kai.nissen) [09:49:59] (03Merged) 10jenkins-bot: Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:51:35] (03PS1) 10Umherirrender: Update expected html in CollaborationHubContentTest to pass tests [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/452911 (https://phabricator.wikimedia.org/T201312) [09:52:35] (03CR) 10jenkins-bot: Fix 'MediWiki' typo [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452896 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [09:52:58] 10Mitmachen: Select where in our current onboarding materials the tool should be embedded/ linked - https://phabricator.wikimedia.org/T201619 (10sonkiki) On Wikipediaday in October, ask community for their expertise on where to embed / link the tool. [09:53:43] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 [09:53:49] (03CR) 10Umherirrender: "check experimental" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [09:54:04] (03PS4) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [09:55:19] (03CR) 10jerkins-bot: [V: 04-1] Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 (owner: 10Legoktm) [09:55:27] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, 10WMDE-Design (WMDE-Design-Workboard Doing): Move field for email address out of address section - https://phabricator.wikimedia.org/T188516 (10kai.nissen) [09:55:44] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/451333 [09:55:50] (03CR) 10Umherirrender: "check experimental" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/451333 (owner: 10Umherirrender) [09:56:33] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [09:56:58] (03PS2) 10Umherirrender: Escape some messages used as html [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451306 [09:57:07] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451288 [09:57:16] (03CR) 10Umherirrender: "check experimental" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451288 (owner: 10Umherirrender) [09:59:05] (03CR) 10jenkins-bot: Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [09:59:16] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review, 10User-D3r1ck01: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10D3r1ck01) Okay @Aklapper, so could you give a helping hand with the naming? Should we... [09:59:21] 10MediaWiki-JobQueue, 10User-Zoranzoki21: 1.31 / TypeError from line 35 of ...\includes\jobqueue\utils\PurgeJobUtils.php: Argument 3 passed to PurgeJobUtils::invalidatePages() must be of the type array, null given, called in ...\includes\deferred\LinksUpdate.php on lin... - https://phabricator.wikimedia.org/T188840 [10:00:06] 10Mitmachen: Consider renaming and/or changing the tagline - https://phabricator.wikimedia.org/T199102 (10Stefan_Schneider_WMDE) @sonkiki I'm only creative at times regarding those names. I'll keep that in mind and will get back as sonn I have a creative burst on that :) [10:00:51] (03PS5) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:03:19] (03PS1) 10Zoranzoki21: Fix TypeError from line 35 [core] - 10https://gerrit.wikimedia.org/r/452913 (https://phabricator.wikimedia.org/T188840) [10:03:52] (03PS2) 10Zoranzoki21: Fix TypeError from line 35 [core] - 10https://gerrit.wikimedia.org/r/452913 (https://phabricator.wikimedia.org/T188840) [10:04:44] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [10:05:33] 10Mitmachen: Discuss analytics for Mitmachen - https://phabricator.wikimedia.org/T198938 (10Stefan_Schneider_WMDE) From my perspective I have the following datapoint, that would be interesting: - URL they came from (in case we do another campaign and want to know from which source they came) - Which task did the... [10:05:47] (03PS6) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:05:49] 10MobileFrontend, 10Readers-Web-Backlog, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Use ContentHandler to obtain DifferenceEngine in MobileFrontend - https://phabricator.wikimedia.org/T201842 (10phuedx) p:05Triage>03High Quot... [10:06:22] 10MediaWiki-Internationalization, 10User-Zoranzoki21: Add Shawiya (Latin script) to list of language names - https://phabricator.wikimedia.org/T201990 (10Zoranzoki21) a:03Zoranzoki21 Sure, will do. [10:06:40] (03CR) 10jenkins-bot: Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [10:08:08] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [10:09:39] 10MediaWiki-Stakeholders-Group, 10MediaWiki-extensions-Examples, 10Developer-Wishlist (2017), 10Patch-For-Review, 10User-D3r1ck01: Review and update the Examples extension - https://phabricator.wikimedia.org/T156568 (10D3r1ck01) Looking at the current state of the extension, one can see a trend. It seems... [10:09:58] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/450234 (owner: 10Pboehm) [10:10:27] 10WMSE-Organisational-Development-2018: Investigate 2FA for WMSE nextcloud - https://phabricator.wikimedia.org/T187781 (10Sebastian_Berlin-WMSE) There seems to be several apps for this, among them one official [[ https://github.com/nextcloud/twofactor_totp#readme | Two Factor TOTP Provider ]]. [10:12:12] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Serialize values in HashBagOStuff for consistency with other stores [core] - 10https://gerrit.wikimedia.org/r/445158 (owner: 10Aaron Schulz) [10:12:22] (03PS1) 10Zoranzoki21: Add Shawiya (Latin script) to list of language names [core] - 10https://gerrit.wikimedia.org/r/452914 (https://phabricator.wikimedia.org/T201990) [10:12:37] (03CR) 10Umherirrender: "Passed" [extensions/DismissableSiteNotice] - 10https://gerrit.wikimedia.org/r/451333 (owner: 10Umherirrender) [10:13:03] (03CR) 10Samwilson: "There are no en-au translations in core because there's no point in adding them if the language variant isn't in this list, is my understa" [core] - 10https://gerrit.wikimedia.org/r/452879 (https://phabricator.wikimedia.org/T201985) (owner: 10Samwilson) [10:13:23] (03PS2) 10Zoranzoki21: Add Shawiya (Latin script) to list of language names [core] - 10https://gerrit.wikimedia.org/r/452914 (https://phabricator.wikimedia.org/T201990) [10:13:40] (03PS5) 10Umherirrender: Add phan-taint-check-plugin [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 [10:13:42] 10Contributors-Analysis, 10Product-Analytics: Explore high-level patterns in mobile editing - https://phabricator.wikimedia.org/T157617 (10Neil_P._Quinn_WMF) p:05Low>03High [10:13:44] (03PS7) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:13:46] (03CR) 10Umherirrender: "check experimental" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [10:14:06] (03CR) 10jerkins-bot: [V: 04-1] Repairing Deletion of Interwikilinks [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/450234 (owner: 10Pboehm) [10:14:41] (03CR) 10jerkins-bot: [V: 04-1] Fix 'MediWiki' typo [extensions/Math] - 10https://gerrit.wikimedia.org/r/452897 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:15:06] (03CR) 10Pwirth: [C: 04-1] "I dont think that changing the oojs-ui version is a good idea. For BS3 we target MW1.31. We should not change the versions of the requirem" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452672 (owner: 10ItSpiderman) [10:15:21] 10Contributors-Analysis, 10Product-Analytics: Report on high-level patterns in mobile editing - https://phabricator.wikimedia.org/T157617 (10Neil_P._Quinn_WMF) [10:16:03] 10Contributors-Analysis, 10Product-Analytics: Report on high-level patterns in mobile editing - https://phabricator.wikimedia.org/T157617 (10Neil_P._Quinn_WMF) A number of stakeholders, including @Deskana and @DannyH, have identified this as a key priority for the next few months, so I'm raising the priority a... [10:16:21] 10Contributors-Analysis, 10Product-Analytics: Report on high-level patterns in mobile editing - https://phabricator.wikimedia.org/T157617 (10Neil_P._Quinn_WMF) p:05High>03Triage [10:16:25] 10Contributors-Analysis, 10Product-Analytics: Report on high-level patterns in mobile editing - https://phabricator.wikimedia.org/T157617 (10Neil_P._Quinn_WMF) p:05Triage>03High [10:17:13] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [10:17:18] (03CR) 10Pwirth: [C: 032] "interwikilink tests pass now." [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/450234 (owner: 10Pboehm) [10:17:26] (03CR) 10Pwirth: [V: 032 C: 032] Repairing Deletion of Interwikilinks [extensions/BlueSpiceInterWikiLinks] - 10https://gerrit.wikimedia.org/r/450234 (owner: 10Pboehm) [10:18:39] Hi, I need help with T201990 [10:18:40] T201990: Add Shawiya (Latin script) to list of language names - https://phabricator.wikimedia.org/T201990 [10:18:55] (03PS8) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:19:06] User requested adding shy-latn to list of language names, but in file I saw to it is already done [10:19:34] I made patch (changed word from source to word which is requested in task) [10:19:45] Is it ok? [10:21:09] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/451366 [10:21:14] (03CR) 10Umherirrender: "check experimental" [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/451366 (owner: 10Umherirrender) [10:21:59] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [10:24:33] (03CR) 10Umherirrender: "Passed" [extensions/GoogleNewsSitemap] - 10https://gerrit.wikimedia.org/r/451345 (owner: 10Umherirrender) [10:27:45] (03PS9) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:27:58] (03CR) 10Aaron Schulz: [C: 04-1] "This seems like a problem with some caller of the method." [core] - 10https://gerrit.wikimedia.org/r/452913 (https://phabricator.wikimedia.org/T188840) (owner: 10Zoranzoki21) [10:28:14] 10Wiki-Loves-Monuments-Sources, 10Wiki-Loves-Monuments (2017): Import Croatia in Croatian into the monuments database - https://phabricator.wikimedia.org/T174505 (10Petar.petkovic) [10:29:30] (03CR) 10jerkins-bot: [V: 04-1] Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) (owner: 10D3r1ck01) [10:31:02] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Addshore: Special:NewItem and Special:NewProperty allow creation of items with term language as any string - https://phabricator.wikimedia.org/T138725 (10Petar.petkovic) [10:31:49] 10WMSE-Organisational-Development-2018: Use Nextcloud for storing passwords? - https://phabricator.wikimedia.org/T201997 (10Sebastian_Berlin-WMSE) [10:31:51] (03CR) 10jenkins-bot: Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 (owner: 10Thiemo Kreuz (WMDE)) [10:31:53] (03CR) 10Zoranzoki21: "https://github.com/wikimedia/mediawiki/commit/2e3dcdab2b69b1d1e166727e12f478f265ac293d" [core] - 10https://gerrit.wikimedia.org/r/452913 (https://phabricator.wikimedia.org/T188840) (owner: 10Zoranzoki21) [10:34:03] (03PS10) 10D3r1ck01: Update Example extension to mordern coding practice of MW extensions [extensions/examples] - 10https://gerrit.wikimedia.org/r/452854 (https://phabricator.wikimedia.org/T156568) [10:34:24] 10ContentTranslation: Add Machine Translation support for Bosnian - https://phabricator.wikimedia.org/T129330 (10Petar.petkovic) [10:34:32] (03PS4) 10Sbisson: [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) [10:35:24] 10WMSE-Organisational-Development-2018: Use Nextcloud for storing passwords? - https://phabricator.wikimedia.org/T201997 (10Sebastian_Berlin-WMSE) [10:35:30] 10Wikimedia-Language-setup, 10I18n, 10MW-1.27-release (WMF-deploy-2016-03-22_(1.27.0-wmf.18)): 'Wikipedia' in Bosnian should be 's Wikipedijom' in instrumental case - https://phabricator.wikimedia.org/T130141 (10Petar.petkovic) [10:35:42] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) (owner: 10Sbisson) [10:36:05] 10Wikimedia-Site-requests, 10I18n: $wgCategoryCollation for bs.wikipedia.org - https://phabricator.wikimedia.org/T116527 (10Petar.petkovic) [10:36:18] (03CR) 10jerkins-bot: [V: 04-1] Add InterwikiLookup::isLocalInterwiki() [core] - 10https://gerrit.wikimedia.org/r/452903 (owner: 10Legoktm) [10:36:47] (03CR) 10Raimond Spekking: [C: 04-1] "Please make changes to qqq in translatewiki.net only. Otherwise edit conflicts between a patch set and an edit on translatewiki.net can ha" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:37:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "I was mostly asking because qqq.json files contain instructions for the translators on Translatewiki, not actual translations." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:39:14] (03CR) 10Aklapper: "The commit message says "Add..." but the patch instead seems to change the name of an existing language entry (instead of adding one)?" [core] - 10https://gerrit.wikimedia.org/r/452914 (https://phabricator.wikimedia.org/T201990) (owner: 10Zoranzoki21) [10:40:11] (03CR) 10Raimond Spekking: [C: 04-1] "@Thiemo: Right. But translatewiki editors edit qqq too. And conflicts such as described can happen." [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [10:42:56] (03PS1) 10Umherirrender: Remove htmlspecialchars from input value [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/452916 [10:43:36] 10Library-Card-Platform: Add fields for excerpt limits - https://phabricator.wikimedia.org/T201155 (10Samwalton9) 05Open>03Resolved [10:43:38] 10Library-Card-Platform: Migrate all remaining information from old on-wiki signup pages - https://phabricator.wikimedia.org/T201151 (10Samwalton9) [10:43:53] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 [10:44:00] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 [10:44:07] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [10:45:56] (03PS5) 10Sbisson: [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) [10:49:14] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10Samwalton9) [10:49:25] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10Samwalton9) p:05Triage>03Low [10:49:48] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10Samwalton9) [10:49:52] 10ContentTranslation: Add Serbian alias for ContentTranslation - https://phabricator.wikimedia.org/T201999 (10Petar.petkovic) [10:50:03] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 [10:50:05] 10Library-Card-Platform: Fix partner detail graphs being blank if partner was created less than a month ago - https://phabricator.wikimedia.org/T201998 (10Samwalton9) I think I prefer the 2nd option, but would need to see what it looks like in practice. [10:50:08] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [10:51:39] 10phan-taint-check-plugin: Using multi dimensions array in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Umherirrender) [10:52:13] (03CR) 10Jack Phoenix: [C: 032] Remove htmlspecialchars from input value [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/452916 (owner: 10Umherirrender) [10:53:16] 10phan-taint-check-plugin: Using multi dimensions array in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Umherirrender) Another code is: ``` $revisions = $db->select( $query['tables'], $query['fields'], $query['conds'], __METHOD__, $query['options'],... [10:53:22] 10Library-Card-Platform: Move collections requirement out of special requirements and into the collections section - https://phabricator.wikimedia.org/T202000 (10Samwalton9) [10:53:42] (03CR) 10Umherirrender: "Passed" [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/451287 (owner: 10Umherirrender) [10:53:43] 10Library-Card-Platform: Move collections requirement out of special requirements and into the collections section - https://phabricator.wikimedia.org/T202000 (10Samwalton9) p:05Triage>03Low [10:53:50] 10Library-Card-Platform: Move collections requirement text out of special requirements and into the collections section - https://phabricator.wikimedia.org/T202000 (10Samwalton9) [10:54:05] 10Library-Card-Platform: Move collections requirement text out of special requirements and into the collections section - https://phabricator.wikimedia.org/T202000 (10Samwalton9) [10:59:54] (03Abandoned) 10Edward Chernenko: Don't create the test DB if the test doesn't need it. [core] - 10https://gerrit.wikimedia.org/r/328718 (owner: 10Edward Chernenko) [11:02:20] (03CR) 10Edward Chernenko: "'page_namespace AS namespace', etc. is just for uniform code style - all other select()s use this." [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/452328 (https://phabricator.wikimedia.org/T201805) (owner: 10Edward Chernenko) [11:02:48] (03CR) 10Edward Chernenko: [C: 032] Avoid $dbw->insertSelect() with GROUP BY - this syntax is supported only by MySQL [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/452328 (https://phabricator.wikimedia.org/T201805) (owner: 10Edward Chernenko) [11:03:37] (03PS1) 10Pwirth: Remove forced ssl on re-auth on secured specialpages + move to namespace [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452919 [11:03:53] (03Merged) 10jenkins-bot: Fix 'MediWiki' typo [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [11:04:44] (03PS2) 10Pwirth: Remove forced ssl on re-auth on secured specialpages + move to namespace [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452919 [11:05:15] (03Merged) 10jenkins-bot: Remove htmlspecialchars from input value [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/452916 (owner: 10Umherirrender) [11:05:27] (03CR) 10jenkins-bot: Remove htmlspecialchars from input value [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/452916 (owner: 10Umherirrender) [11:05:36] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Urbanecm) @Petrb I read your proposal and I consider it useless, because what I wrote. I do... [11:07:38] 10MediaWiki-Change-tagging, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, and 2 others: Duplicate entry 'emoji' for key 'ctd_name' - https://phabricator.wikimedia.org/T201934 (10Ladsgroup) p:05Triage>03Unbreak! [11:09:26] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 [11:09:34] (03CR) 10Umherirrender: "check experimental" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [11:11:35] (03CR) 10jerkins-bot: [V: 04-1] Remove forced ssl on re-auth on secured specialpages + move to namespace [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452919 (owner: 10Pwirth) [11:11:46] (03CR) 10jenkins-bot: Remove htmlspecialchars from input value [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/452916 (owner: 10Umherirrender) [11:17:36] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 [11:17:43] (03CR) 10Umherirrender: "check experimental" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [11:19:09] (03CR) 10Nikerabbit: [C: 04-1] "We have well established process for adding languages to MediaWiki core:" [core] - 10https://gerrit.wikimedia.org/r/452879 (https://phabricator.wikimedia.org/T201985) (owner: 10Samwilson) [11:19:58] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, and 2 others: Display information on bank account data of WMFG - https://phabricator.wikimedia.org/T188489 (10kai.nissen) 05Open>03Resolved [11:21:53] (03PS1) 10Ladsgroup: Swap SET and WHERE statements in ChangeTags::undefineTag [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452921 (https://phabricator.wikimedia.org/T201934) [11:22:01] (03CR) 10Ladsgroup: [C: 032] Swap SET and WHERE statements in ChangeTags::undefineTag [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452921 (https://phabricator.wikimedia.org/T201934) (owner: 10Ladsgroup) [11:23:05] 10MediaWiki-Internationalization, 10Patch-For-Review: Add Australian English to list of language names - https://phabricator.wikimedia.org/T201985 (10Nemo_bis) (As noted in code review, this request is currently invalid.) [11:23:25] (03CR) 10Umherirrender: "Passed" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [11:23:39] (03PS1) 10Pwirth: Remove deprecated code [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452922 [11:25:22] (03CR) 10Nikerabbit: "Can we avoid this and have the factory functions set the code directly instead?" [core] - 10https://gerrit.wikimedia.org/r/452563 (owner: 10Fomafix) [11:28:44] 10Wikimedia-Site-requests: Wikimedia-Site-request for event in Ireland - https://phabricator.wikimedia.org/T202003 (10Smirkybec) [11:30:01] 10Wikimedia-Site-requests: Throttle exemption for event in Ireland - https://phabricator.wikimedia.org/T202003 (10Reedy) [11:34:59] (03CR) 10Nikerabbit: Make HTML generation in RenderedRevision optional (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:36:08] (03PS3) 10Thiemo Kreuz (WMDE): Fix misplaced ordering of lines in some diffs [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/450024 (https://phabricator.wikimedia.org/T197157) (owner: 10Jkroll) [11:36:23] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated code [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452922 (owner: 10Pwirth) [11:37:24] 10Library-Card-Platform: Example data script should set mutually_exclusive for partners with streams. - https://phabricator.wikimedia.org/T201688 (10Samwalton9) 05Open>03Resolved [11:37:59] 10Library-Card-Platform: Create a sample data set and use it for all development - https://phabricator.wikimedia.org/T178921 (10Samwalton9) [11:38:22] 10Library-Card-Platform: Create a sample data set and use it for all development - https://phabricator.wikimedia.org/T178921 (10Samwalton9) [11:39:16] (03PS1) 10Umherirrender: Use HTMLForm label-message feature to simplify code [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/452924 [11:39:49] 10Library-Card-Platform: Add hovertext for waitlisted tag - https://phabricator.wikimedia.org/T170116 (10Samwalton9) 05Open>03declined [11:40:40] 10Library-Card-Platform: Comment sections are blocked by some extensions (e.g. 1Blocker) - https://phabricator.wikimedia.org/T196888 (10Samwalton9) 05Open>03declined Closing this per the above. The extension is supposed to block comments and we shouldn't need to work around that. [11:42:39] 10Library-Card-Platform: Pageviews download as csv button doesn't work, maybe others - https://phabricator.wikimedia.org/T187486 (10Samwalton9) [11:42:42] 10Library-Card-Platform: Rework pageviews data - https://phabricator.wikimedia.org/T195570 (10Samwalton9) [11:42:53] 10MediaWiki-Parser, 10TemplateStyles, 10Performance: Omit `` from page view HTML - https://phabricator.wikimedia.org/T200206 (10Pikne) I came across another use case where omitting `` could be desirable. English Wikipedia has style `.navbox+.navbox{margin-top:... [11:45:08] 10MediaWiki-extensions-Newsletter: Error in edit newsletter page - https://phabricator.wikimedia.org/T202002 (10D3r1ck01) [11:46:53] 10MediaWiki-extensions-Newsletter: Error in edit newsletter page - https://phabricator.wikimedia.org/T202002 (10Aklapper) Please provide MediaWiki version and extension version information. [11:48:15] (03Merged) 10jenkins-bot: Avoid $dbw->insertSelect() with GROUP BY - this syntax is supported only by MySQL [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/452328 (https://phabricator.wikimedia.org/T201805) (owner: 10Edward Chernenko) [11:52:23] (03PS1) 10Thiemo Kreuz (WMDE): Streamline and document detectDissimilarChanges implementation [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/452925 (https://phabricator.wikimedia.org/T197157) [11:54:09] (03PS4) 10Thiemo Kreuz (WMDE): Fix misplaced ordering of lines in some diffs [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/450024 (https://phabricator.wikimedia.org/T197157) (owner: 10Jkroll) [11:55:17] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I added two of the smaller, easy to understand test cases mentioned in T201914. I also uploaded a follow up patch that simplifies this cod" [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/450024 (https://phabricator.wikimedia.org/T197157) (owner: 10Jkroll) [11:55:35] (03CR) 10Fomafix: "> Is this just for easier reading of the code, or do you see it being" [core] - 10https://gerrit.wikimedia.org/r/452563 (owner: 10Fomafix) [11:57:24] (03Merged) 10jenkins-bot: Swap SET and WHERE statements in ChangeTags::undefineTag [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452921 (https://phabricator.wikimedia.org/T201934) (owner: 10Ladsgroup) [12:05:55] 10MediaWiki-Change-tagging, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review, and 2 others: Duplicate entry 'emoji' for key 'ctd_name' - https://phabricator.wikimedia.org/T201934 (10Ladsgroup) 05Open>03Resolved I will write regression tests for th... [12:07:10] 10MediaWiki-extensions-SecureLinkFixer, 10Wikimedia-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018): Automatically rewrite HTTP links to HTTPS for sites in the HSTS preload list - https://phabricator.wikimedia.org/T200745 (10spinda) Hi Cyde - I filed the bug over on the Mozilla side. Updating... [12:09:19] (03PS2) 10Jdrewniak: Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) [12:09:31] 10CX-deployments, 10Language-2018-July-September: Third manual run of unpublished draft purge script - https://phabricator.wikimedia.org/T201895 (10Nikerabbit) 1150 days was used in the last run, so needs to be updated. We want to get reasonably close to 456 days before enabling cron jobs. We could target for... [12:11:37] (03CR) 10Jdrewniak: Disable edit icon in read-only mode (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [12:15:40] 10Mitmachen: Link (anchor) every task to the Wartungsbaustein in the article - https://phabricator.wikimedia.org/T202004 (10sonkiki) [12:15:52] 10Mitmachen: Link (anchor) every task to the Wartungsbaustein in the article - https://phabricator.wikimedia.org/T202004 (10sonkiki) p:05Triage>03Normal [12:16:02] 10Mitmachen: Link (anchor) every task to the Wartungsbaustein in the article - https://phabricator.wikimedia.org/T202004 (10sonkiki) p:05Normal>03Triage [12:16:36] 10Mitmachen: Link (anchor) every task to the Wartungsbaustein in the article - https://phabricator.wikimedia.org/T202004 (10sonkiki) Thanks for this suggestion! I personally can not tell how complex this would be to implement. With Cirdan on vacation, could you, @RazShuty, help in giving us an idea whether this... [12:17:39] 10InternetArchiveBot: The tool is not working for me - https://phabricator.wikimedia.org/T202005 (10Saqib) [12:18:02] 10InternetArchiveBot: The tool is not working for me - https://phabricator.wikimedia.org/T202005 (10Saqib) [12:18:53] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech, 10Community-Tech-Sprint, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Create an API module to allow apps to set global preference - https://phabricator.wikimedia.org/T62856 (10Petar.petkovic) [12:20:03] (03CR) 10jerkins-bot: [V: 04-1] Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [12:27:48] 10Wikimedia-Site-requests, 10Chinese-Sites: Allow subpages in main namespace in zhwikiversity - https://phabricator.wikimedia.org/T202007 (10Bugreporter) [12:45:59] (03PS3) 10Jdrewniak: Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) [12:52:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "We (as the software developers who are creating this code) write and update qqq.json files all the time. I clearly consider them part of t" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [12:52:39] 10Discovery, 10Discovery-Search (Current work): [Recurring task] CirrusSearch: what is updated during re-indexing - https://phabricator.wikimedia.org/T147505 (10TJones) [12:55:00] (03CR) 10jerkins-bot: [V: 04-1] Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [12:57:32] 10InternetArchiveBot: IABot Management Interface doesn't seem to work on some pages - https://phabricator.wikimedia.org/T202008 (10Ravenpuff) [13:07:56] 10InternetArchiveBot (v2.0): Creating invalid dates in rescued references - https://phabricator.wikimedia.org/T200045 (10Cyberpower678) I added a sanity check to the timestamp handler in the subroutines. This should be fixed in beta7 now. [13:11:10] 10New-Readers, 10Proton, 10Readers-Web-Backlog (Design): Add the print button to mobile browsers other than Chrome - https://phabricator.wikimedia.org/T201954 (10alexhollender) a:03alexhollender [13:15:32] (03CR) 10Zoranzoki21: "> We (as the software developers who are creating this code) write" [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/452895 (https://phabricator.wikimedia.org/T201491) (owner: 10Zoranzoki21) [13:16:13] 10Product-Analytics: Determine ratio of wikitext edits made from mobile devices that use the desktop interface - https://phabricator.wikimedia.org/T201973 (10alexhollender) >Here is a quick and dirty query for a related question: The ratio of wikitext edits using the desktop interface made from iOS and Android d... [13:25:01] 10MediaWiki-Parser, 10TemplateStyles, 10Performance: Omit `` from page view HTML - https://phabricator.wikimedia.org/T200206 (10Anomie) >>! In T200206#4462013, @Jack_who_built_the_house wrote: > Can't the `

` - https://phabricator.wikimedia.org/T186965 (10ssastry) Sorry .. I shouldn't have untagged those other projects since the original bug report was for both parsers. [16:27:28] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Community-consensus-needed: Allow subpages in main namespace in zhwikiversity - https://phabricator.wikimedia.org/T202007 (10Framawiki) Hello @Bugreporter, as always please create a community consensus for this (https://meta.wikimedia.org/wiki/Requesting_wiki_con... [16:31:01] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Russian-Sites: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10Framawiki) a:03Framawiki [16:35:47] 10Wikimedia-Site-requests: Set $wmgUseFooterContactLink = true on frwiki - https://phabricator.wikimedia.org/T202014 (10Framawiki) p:05Triage>03Low [16:36:36] 10Wikimedia-Site-requests, 10Community-consensus-needed: Set $wmgUseFooterContactLink = true on frwiki - https://phabricator.wikimedia.org/T202014 (10Framawiki) a:03Framawiki Created a discussion: https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Le_Bistro/15_ao%C3%BBt_2018#Ajouter_un_lien_%22Contact%22_en_bas_de... [16:37:57] 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Run A/B test on page issues - https://phabricator.wikimedia.org/T200792 (10Jdlrobson) [16:37:59] 10Wikimedia-Site-requests, 10Patch-For-Review, 10Russian-Sites: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10Framawiki) p:05Triage>03Low [16:38:45] 10MediaWiki-Parser, 10Parsoid, 10RemexHtml, 10TemplateStyles, 10Patch-For-Review: Output HTML should not contain `

` - https://phabricator.wikimedia.org/T186965 (10ssastry) [16:39:24] 10Trust-and-Safety, 10Wikimedia-Site-requests: Request for password reset for CentralAuth User:Textorus - https://phabricator.wikimedia.org/T201612 (10Framawiki) 05Open>03Resolved p:05Triage>03Normal a:03jrbs User is happy, looks that this task can be closed. [16:43:28] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10MobileFrontend (MobileFrontend.js), 10Patch-For-Review, and 2 others: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10Jdlrobson) [16:44:20] 10MediaWiki-Releasing, 10Service-Architecture, 10Services (later): Distribution strategy option: Use Debian packages - https://phabricator.wikimedia.org/T88154 (10Arlolra) [16:45:22] 10Readers-Web-Backlog, 10Easy, 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Migrate mobile editor to CSRF from edit token in TalkSectionAddOverlay - https://phabricator.wikimedia.org/T188451 (10Jdlrobson) [16:45:29] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Technical-Debt: Simplify CategoryOverlay for readability - https://phabricator.wikimedia.org/T191987 (10Jdlrobson) [16:55:53] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10Analytics-EventLogging, 10Page-Issue-Warnings, and 6 others: Provide standard/reproducible way to access a PageToken - https://phabricator.wikimedia.org/T201124 (10Niedzielski) > @Ottomata, it's not clear if we should make these changes now to EventLog... [17:00:45] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10Analytics-EventLogging, 10Page-Issue-Warnings, and 6 others: Provide standard/reproducible way to access a PageToken - https://phabricator.wikimedia.org/T201124 (10Ottomata) Yeah that makes sense. Likely the logic you guys come up with here will be us... [17:05:53] 10TemplateStyles, 10Patch-For-Review, 10Performance-Team (Radar), 10Technical-Debt: CSS is duplicated on each template usage - https://phabricator.wikimedia.org/T168333 (10ssastry) I am starting to look at this from the Parsoid angle. Does the core parser de-duping relying on serialized text order of T to... [17:16:27] 10MediaWiki-JobQueue, 10Analytics, 10EventBus, 10Discovery-Search (Current work), 10Services (designing): Huge messages in eqiad.mediawiki.job.cirrusSearchElasticaWrite (and other?) topics - https://phabricator.wikimedia.org/T196032 (10Ottomata) p:05Normal>03Low [17:35:15] 10MediaWiki-Cache, 10MediaWiki-Parser, 10Internet-Archive, 10Math, and 9 others: Lua module Module:Internet_Archive is causing parser cache pollution - ext.math.styles is sometimes loaded - https://phabricator.wikimedia.org/T173949 (10Niedzielski) The latest Barack Obama CSS size graph: {F24976898} [17:46:58] 10UI-Standardization, 10VisualEditor: [Regression pre-wmf.8] No spacing between "Add template" button and the template search field - https://phabricator.wikimedia.org/T196686 (10Volker_E) 05Open>03declined Seconding @iamjessklein. The current way the input+search combination is sufficiently working – auto... [17:48:46] 10Anti-Harassment: Tracking blocks: Log when the mobile web editor block notice is displayed - https://phabricator.wikimedia.org/T201719 (10TBolliger) That's good to know in advance, Alex. Thank you. We won't need 100% perfect data on this first implementation, just directional. There is room for an acceptable... [17:55:00] 10TemplateStyles, 10Patch-For-Review, 10Performance-Team (Radar), 10Technical-Debt: CSS is duplicated on each template usage - https://phabricator.wikimedia.org/T168333 (10ssastry) >>! In T168333#4505228, @ssastry wrote: > I am starting to look at this from the Parsoid angle. Does the core parser de-duping... [18:05:25] 10TemplateStyles, 10Patch-For-Review, 10Performance-Team (Radar), 10Technical-Debt: CSS is duplicated on each template usage - https://phabricator.wikimedia.org/T168333 (10Anomie) >>! In T168333#4505228, @ssastry wrote: > Does the core parser de-duping rely on serialized text order to determine which one i... [18:08:41] 10Anti-Harassment: Tracking blocks: Log when the mobile web editor block notice is displayed - https://phabricator.wikimedia.org/T201719 (10dbarratt) I don't know anything about our logging. :) but it does look like you //can// use Graphite, or you can also use the schema (db?) logging from the client. So we sho... [18:13:25] 10UI-Standardization, 10OOUI (OOUI-0.28.0): 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive' - https://phabricator.wikimedia.org/T189113 (10Petar.petkovic) [18:14:49] 10Social-Tools, 10SocialProfile: Legacy User: pages still have tracked links, categories, images, etc that can't be edited - https://phabricator.wikimedia.org/T202018 (10Ciencia_Al_Poder) [18:15:19] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Variables, 10Patch-For-Review: Create a Scribunto interface - https://phabricator.wikimedia.org/T201171 (10Anomie) >>! In T201171#4498706, @MGChecker wrote: > Cite is an example of an extension that doesn't always work as it should if you parse only pa... [18:15:39] wikimedia/mediawiki#21759 (master - c1c76c3 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416469265 [18:18:41] 10ContentTranslation, 10Language-2018-July-September: CX2: Allow marking warnings as resolved - https://phabricator.wikimedia.org/T198188 (10Petar.petkovic) Marking issues as resolved works across one session. Persistence of resolved state isn't yet implemented, so going back to the dashboard and opening the d... [18:24:06] wikimedia/mediawiki#21759 (master - c1c76c3 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416469265 [18:25:07] wikimedia/mediawiki#21759 (master - c1c76c3 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416469265 [18:31:12] 10Anti-Harassment (AHT Sprint 27), 10Patch-For-Review: Update Block APIs to list partial blocks - https://phabricator.wikimedia.org/T197141 (10TBolliger) [18:31:15] 10Wikimedia-Takedown-Tools, 10Anti-Harassment (AHT Sprint 27): Takedown tool should use UTC everywhere (including datepicker) - https://phabricator.wikimedia.org/T197836 (10TBolliger) [18:31:27] 10Anti-Harassment (AHT Sprint 27), 10Patch-For-Review: Create Schema for Partial Blocks - https://phabricator.wikimedia.org/T197144 (10TBolliger) [18:31:39] 10Anti-Harassment (AHT Sprint 27), 10Patch-For-Review: Update Special:BlockList with partial block info - https://phabricator.wikimedia.org/T197143 (10TBolliger) [18:31:59] 10Anti-Harassment (AHT Sprint 27): Update PHP APIs to set Partial Blocks - https://phabricator.wikimedia.org/T197114 (10TBolliger) [18:32:05] 10Anti-Harassment (AHT Sprint 27), 10Patch-For-Review: Enforce Partial Blocks from Database and Update Block Notices - https://phabricator.wikimedia.org/T197117 (10TBolliger) [18:32:10] 10Anti-Harassment (AHT Sprint 27): Update API:Block to set Partial Blocks - https://phabricator.wikimedia.org/T197111 (10TBolliger) [18:32:12] 10Anti-Harassment (AHT Sprint 27): Update Special:Block to set Partial Blocks - https://phabricator.wikimedia.org/T197109 (10TBolliger) [18:32:14] 10Anti-Harassment (AHT Sprint 27): Update block logs with partial block details - https://phabricator.wikimedia.org/T197108 (10TBolliger) [18:32:17] 10Anti-Harassment (AHT Sprint 27): MVP for partial blocks (block a user from pages only) - https://phabricator.wikimedia.org/T196578 (10TBolliger) [18:33:42] 10Anti-Harassment (AHT Sprint 27): Determine plan for Partial Blocks feature flag - https://phabricator.wikimedia.org/T201722 (10TBolliger) [18:33:46] 10Anti-Harassment (AHT Sprint 27): Prepare a technical plan for Multi-blocks - https://phabricator.wikimedia.org/T201692 (10TBolliger) [18:36:56] 10Anti-Harassment (AHT Sprint 27): Evaluate summer 2018 IdeaLab submissions - https://phabricator.wikimedia.org/T202019 (10TBolliger) [18:49:01] 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page/namespace - https://phabricator.wikimedia.org/T199917 (10TBolliger) >>! In T199917#4503174, @kchapman wrote: > @TBolliger TechCom can review again at our next meeting and then determine if it is ready for Last Call. (Next meeting is August 21) Thank y... [18:49:42] 10Social-Tools, 10SocialProfile: Visiting any profile, it only displays your own friends, not the friends of the profile you're visiting - https://phabricator.wikimedia.org/T202020 (10Ciencia_Al_Poder) [18:49:49] 10Anti-Harassment (AHT Sprint 27): Prepare a technical plan for Multi-blocks - https://phabricator.wikimedia.org/T201692 (10TBolliger) [19:00:55] 10MinervaNeue: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) [19:01:01] 10MinervaNeue: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) p:05Triage>03Unbreak! [19:01:41] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Technical-Debt (Deprecation): Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook - https://phabricator.wikimedia.org/T140804 (10Jdlrobson) This has caused a serious regression... [19:01:49] 10MinervaNeue, 10Readers-Web-Backlog, 10Readers-Web-Kanbanana-Board: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) [19:06:15] 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Update Readers Web coding convention for test filenames (and update violators) - https://phabricator.wikimedia.org/T197884 (10Jdlrobson) The team estimated a 2. I was the sole 3 pointer due to this line - > https://github.com/wikimedia/mediawiki-exte... [19:11:50] Krinkle: do I understand correctly that there's a renewed interest in using tree-caching filter parser due to CPU usage concerns? [19:12:05] a wild vvv appeared! [19:12:14] Hello! [19:12:42] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint): AfC: [minor] Make capitalization filters names consistent - https://phabricator.wikimedia.org/T200582 (10SBisson) a:03Catrope This was done as part of the parent task. [19:12:43] vvv: For AbuseFilter? Yes, we (perf team) finds significant spent during the saving of edits in AbuseFilter rules. Anything to speed that up would be great. [19:12:58] vvv: Note that the CachedParser that was written is, unfortunately, still not enabled. [19:13:21] I know, it had bunch of compatibility issues I never got around to nailing down [19:13:39] I don't particularly care for the CPUs of the servers, we've got more than enough of head room there. More about wall clock time spent in responding to saving an edit. [19:13:47] But I know what you mean :) [19:14:06] There's also other gotcha is that I'm not certain on what specific performance properties it has compared to the original in HHVM world [19:15:15] My original idea was that generating parsing trees in PHP is more expensive than just calling unserialize() on a bunch of PHP objects, i.e. that's where I expected the gains to come from [19:16:37] vvv: Let me get you a flame graph. [19:16:57] Now, I expect that for a huge quantity of filters that are a large and-clause that terminates early, having a tree will speed things up by allowing you to ignore that the rest of expression exists [19:17:02] Oooooh, a flame graph [19:18:26] 10Zero: Verify and update list of currently active WP0 Carriers - https://phabricator.wikimedia.org/T202022 (10Reedy) [19:19:40] vvv: I got two captures. one from index.php?action=submit, one from api.php for stash edit. It seems the work is divided between so you'll need to check both. [19:19:43] https://performance.wikimedia.org/xhgui/run/view?id=5b747c74bb8544b8155818bf [19:19:47] https://performance.wikimedia.org/xhgui/run/view?id=5b747c75bb8544b815069d1e [19:19:57] click "Flame Graph" to see visually [19:20:05] "View Flamegraph" * [19:20:50] you'll want this one - https://performance.wikimedia.org/xhgui/run/flamegraph?id=5b747c75bb8544b815069d1e [19:22:55] Is that... a 20 second request? [19:23:00] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601 (10Jdforrester-WMF) The OOUI release landed in MediaWi... [19:23:16] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Deprecate and remove 'find' icon - https://phabricator.wikimedia.org/T183645 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:23:23] vvv: Ignore the time values. There's something wrong with XHGui, it's adding up each chunk recursively, mistaking it for self time. [19:23:27] 10OOUI, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)): Support $overlay on DropdownInputWidget - https://phabricator.wikimedia.org/T185751 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:23:28] So the total is way off. [19:23:35] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive' - https://phabricator.wikimedia.org/T189113 (10Jdforrester-WMF) The OOUI release landed in MediaWiki... [19:24:08] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar' - https://phabricator.wikimedia.org/T190441 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:24:26] 10OOUI, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)): Clarify 'settings' and 'advanced' icon names - https://phabricator.wikimedia.org/T190581 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:24:29] 10MediaWiki-extensions-Semantic-MediaWiki, 10I18n: Multilingual SemanticMediaWiki - https://phabricator.wikimedia.org/T48522 (10Kghbln) [19:24:33] 10MediaWiki-extensions-Page_Forms, 10I18n, 10Patch-For-Review: Unable to use {{int}} inside {{for template}} - https://phabricator.wikimedia.org/T49736 (10Kghbln) 05Open>03Resolved a:03Thai Thanks @Thai for working on this! [19:24:51] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): Deprecate & remove citations icons from 'content' pack - https://phabricator.wikimedia.org/T194104 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:24:59] vvv: The text based version at https://performance.wikimedia.org/xhgui/run/symbol?id=5b747c75bb8544b815069d1e&symbol=AbuseFilterHooks%3A%3A__invoke does not have this defect [19:25:05] 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): Move inline help after field when align=top - https://phabricator.wikimedia.org/T197004 (10Jdforrester-WMF) The OOUI release landed in MediaWiki 1.32.0-wmf.18. [19:25:20] But is harder to visualise, anyway, just beware that the proportions may be over emphasised in the flame graph [19:26:45] 10FormWizard: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Eugene233) [19:26:47] 10FormWizard, 10Patch-For-Review: Implement IdeaLab Page content display based parser function configuration - https://phabricator.wikimedia.org/T201899 (10Eugene233) 05Open>03Resolved Issue solved. [19:28:18] I mean, the parser itself is kind of hard to read because it's recursive [19:28:33] But it does look like most of the time is taken in small chunks by parsing itself [19:30:02] Yeah, the majority of time is spent parsing the rule syntax it seems. [19:30:28] I know very little about AbuseFilter, and even less about the CachedParser that was written. But off-hand that parsing pass seems cacheable as it only changes when an admin changes the filter itself. [19:30:53] Passing over it and producing an array of int constants and caching that, then iterating over it might work. [19:31:11] That would be my first attempt, but again, it probably makes sense to also re-use what you wrote already, so feel free to ignore that idea. [19:35:18] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: ORES blocking itself on insert and delete - https://phabricator.wikimedia.org/T201918 (10Ladsgroup) I see what's going on here now. It's because the logic for score storage has been duplicated several places and they are gettin... [19:36:25] 10TemplateStyles: mw-deduplicated-inline-style showing up in article - https://phabricator.wikimedia.org/T202023 (10Jdlrobson) [19:38:23] 10TemplateStyles: mw-deduplicated-inline-style showing up in article - https://phabricator.wikimedia.org/T202023 (10Jdlrobson) [19:42:40] 10Audiences-QA, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) p:05Unbreak!>03High a:03Ryasmeen [19:43:15] 10Audiences-QA, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) [19:43:34] 10Audiences-QA, 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review, and 3 others: Regression: Notifications, Special:MobileOptions broken! - https://phabricator.wikimedia.org/T202021 (10Jdlrobson) [19:47:50] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Technical-Debt (Deprecation): Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook - https://phabricator.wikimedia.org/T140804 (10Krinkle) >>! In T140804#4505465, @Jdlrobson wro... [19:54:56] 10MobileFrontend, 10Readers-Web-Backlog: Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Niedzielski) p:05Triage>03Normal [19:55:42] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Spike: [4 hours] Spike: How hard would it be to track number of edits saved that used TemplateWizard? - https://phabricator.wikimedia.org/T201476 (10aezell) @Samwilson I agree that having 100% perfectly correct numbers is w... [19:56:33] 10MinervaNeue, 10MobileFrontend, 10Readers-Web-Backlog, 10Goal: [GOAL] Invest in the MobileFrontend & MinervaNeue frontend architecture - https://phabricator.wikimedia.org/T195473 (10Niedzielski) [19:56:35] 10MobileFrontend, 10Readers-Web-Backlog: Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Niedzielski) [19:56:54] 10MobileFrontend, 10Readers-Web-Backlog: [EPIC] Enable JS error reporting in the mobile website - https://phabricator.wikimedia.org/T167699 (10Niedzielski) @jdlrobson, that's right. Done in T202026. [20:03:56] 10MediaWiki-extensions-CollaborationKit, 10OOUI, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10Wikimedia-log-errors (Shared Build Failure): Changes in OOUI results in unit test failure of extension CollaborationKit - https://phabricator.wikimedia.org/T201312 (10Umh... [20:04:53] 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review: Assign "suppressredirect" to patroller and rollbacker on zhwiki - https://phabricator.wikimedia.org/T201160 (10Rxy) >>! In T201160#4489014, @Framawiki wrote: > If I understand correctly this right every patroller or rollbacker on this wiki can n... [20:05:21] 10Wikipedia-Android-App-Backlog, 10I18n: [[Wikimedia:Wikipedia-android-strings-onboarding explore text/en]] suggestion - https://phabricator.wikimedia.org/T201465 (10Danmichaelo) Users already familiar with the Random Article feature of Wikipedia will for sure get it. But new users? All of them? Not so sure. [20:05:26] 10MobileFrontend, 10Readers-Web-Backlog: Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Niedzielski) [20:08:34] 10MobileFrontend, 10Readers-Web-Backlog: Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Niedzielski) [20:14:29] 10MobileFrontend, 10Readers-Web-Backlog: Report client-side JavaScript errors in MobileFrontend practically - https://phabricator.wikimedia.org/T202026 (10Krinkle) Two quick notes: >>! @Niedzielski wrote >The fields will be transmitted in the event property [..] > Which itself is already ~650 characters. > [.... [20:18:47] 10MediaWiki-Interface, 10TechCom: Create a hook like AfterFinalPageOutput with the cacheability of the page - https://phabricator.wikimedia.org/T194396 (10Krinkle) 05Open>03Resolved [20:21:56] 10Audiences-QA, 10Page-Previews, 10Readers-Web-Backlog, 10Easy, and 3 others: Popups triggers "deprecated ResourceLoader module jquery.hidpi" on several pages - https://phabricator.wikimedia.org/T198579 (10ABorbaWMF) Looks good to me across a number of browsers/devices, including a retina display. Tested i... [20:24:19] 10TemplateStyles: mw-deduplicated-inline-style showing up in article - https://phabricator.wikimedia.org/T202023 (10Jdlrobson) Apparently moving the style definition after the module call fixed this issue https://en.m.wikipedia.org/wiki/Template_talk:Multiple_image?markasread=143275969#mobile_(stop_using_inline... [20:24:31] wikimedia/mediawiki#21760 (master - c7585a5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416516579 [20:24:54] wikimedia/mediawiki#21760 (master - c7585a5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416516579 [20:31:35] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Petar.petkovic) [20:35:51] wikimedia/mediawiki#21761 (master - 4636405 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416518934 [20:38:58] wikimedia/mediawiki#21761 (master - 4636405 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416518934 [20:41:24] wikimedia/mediawiki#21761 (master - 4636405 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416518934 [20:42:15] 10MinervaNeue, 10Readers-Web-Backlog, 10Easy, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Jdlrobson) [20:45:45] 10MinervaNeue, 10Readers-Web-Backlog, 10Easy, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Jdlrobson) [20:50:50] wikimedia/mediawiki#21762 (master - f93b298 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416522654 [20:51:07] 10TemplateStyles: mw-deduplicated-inline-style showing up in article - https://phabricator.wikimedia.org/T202023 (10Tgr) Workaround is to not put the templatestyles tag on a separate line. [20:56:40] (03CR) 10Fomafix: Add support for using geoip2 (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/435689 (https://phabricator.wikimedia.org/T195695) (owner: 10Paladox) [21:00:12] (03CR) 10MarcoAurelio: [C: 032] Add special page alias for Serbian in latin variant [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452937 (owner: 10Petar.petkovic) [21:00:52] (03Merged) 10jenkins-bot: Fix "vaule" typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/453056 (owner: 10Petar.petkovic) [21:00:52] wikimedia/mediawiki#21762 (master - f93b298 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416522654 [21:00:59] 10Design, 10Parsoid: Create a new, nice logo for Parsoid - https://phabricator.wikimedia.org/T58656 (10cscott) https://www.zazzle.com/collections/parsoid_team_shirts-119825369932819057 Note: zazzle's indexer is slow; it will probably take 24hrs (from 2018-08-15 2100 UTC) before the above URL has non-broken li... [21:01:29] (03CR) 10Paladox: Add support for using geoip2 (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/435689 (https://phabricator.wikimedia.org/T195695) (owner: 10Paladox) [21:01:52] 10MediaWiki-extensions-CentralAuth: Central auth fails when using "site isolation" in Google or "first-party isolation" in Firefox - https://phabricator.wikimedia.org/T202028 (10jeblad) [21:02:37] wikimedia/mediawiki#21762 (master - f93b298 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416522654 [21:03:30] (03CR) 10MarcoAurelio: Expand special page aliases for Serbian (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/452969 (owner: 10Petar.petkovic) [21:04:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/453005 (owner: 10L10n-bot) [21:04:17] wikimedia/mediawiki#21762 (master - f93b298 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416522654 [21:06:31] (03Merged) 10jenkins-bot: Replace .done with .then in CategoryOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452834 (https://phabricator.wikimedia.org/T188937) (owner: 10Nray) [21:06:34] (03Merged) 10jenkins-bot: Replace .done with .then in uploads.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452849 (https://phabricator.wikimedia.org/T188937) (owner: 10Nray) [21:06:40] (03Merged) 10jenkins-bot: Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [21:08:53] (03CR) 10Huji: [C: 032] Add special page alias for Serbian [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452970 (owner: 10Petar.petkovic) [21:09:36] (03CR) 10MarcoAurelio: [C: 032] Add special page alias for Serbian [extensions/Linter] - 10https://gerrit.wikimedia.org/r/452992 (owner: 10Petar.petkovic) [21:10:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CodeReview] - 10https://gerrit.wikimedia.org/r/453012 (owner: 10L10n-bot) [21:10:27] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Readers-Web-Kanbanana-Board: Mobile page issues - instrument page issues - https://phabricator.wikimedia.org/T191532 (10Jdlrobson) a:05Ryasmeen>03None Looks like https://gerrit.wikimedia.org... [21:10:56] 10TemplateStyles: mw-deduplicated-inline-style showing up in article - https://phabricator.wikimedia.org/T202023 (10Anomie) 05Open>03Invalid There is also an extraneous space before the invocation of the template in the article, which causes MediaWiki to try to display the line as preformatted text, but only... [21:11:26] (03CR) 10jenkins-bot: Add special page alias for Serbian [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/452998 (owner: 10Petar.petkovic) [21:12:23] (03CR) 10VolkerE: [C: 032] Update usage of 'book' OOUI icon to use from 'editing-citation' pack [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/452735 (https://phabricator.wikimedia.org/T194104) (owner: 10Jforrester) [21:15:02] (03PS3) 10MarcoAurelio: Add Czech aliases to Massmessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/449395 (owner: 10Urbanecm) [21:16:09] (03CR) 10Mholloway: [C: 032] Add maintenance script to get a list of enabled WP0 providers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/452988 (https://phabricator.wikimedia.org/T202022) (owner: 10Reedy) [21:17:08] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Please unblock stuck global rename: EricEnfermero to Larry Hockett - https://phabricator.wikimedia.org/T201314 (10MarcoAurelio) @Legoktm Could you have a look at this one? Thanks. [21:17:11] 10MediaWiki-extensions-CentralAuth, 10Security: Central auth fails when using "site isolation" in Google or "first-party isolation" in Firefox - https://phabricator.wikimedia.org/T202028 (10Reedy) [21:17:27] (03CR) 10jenkins-bot: Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [21:17:52] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/453015 (owner: 10L10n-bot) [21:20:37] (03CR) 10Umherirrender: "I want to fix some security issues, see one example in the comments." (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender) [21:21:12] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Spike: [4 hours] Spike: How hard would it be to track number of edits saved that used TemplateWizard? - https://phabricator.wikimedia.org/T201476 (10Niharika) > Also, I don't think the complexities around tracking the actua... [21:22:40] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Iislucas) @PEarleyWMF: we discussed privacy implications; can you comment further on this, and if/who you think should be looped in. [21:22:45] (03CR) 10jerkins-bot: [V: 04-1] Add Czech aliases to Massmessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/449395 (owner: 10Urbanecm) [21:23:11] (03CR) 10Umherirrender: "Passed" [extensions/RSS] - 10https://gerrit.wikimedia.org/r/451372 (owner: 10Umherirrender) [21:23:20] (03CR) 10Umherirrender: "Passed" [extensions/Score] - 10https://gerrit.wikimedia.org/r/451373 (owner: 10Umherirrender) [21:23:30] (03CR) 10Umherirrender: "Passed" [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/451380 (owner: 10Umherirrender) [21:25:47] (03CR) 10jerkins-bot: [V: 04-1] Add special page alias for Serbian [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/452994 (owner: 10Petar.petkovic) [21:26:11] 10MediaWiki-Maintenance-scripts, 10MediaWiki-Recent-changes, 10Growth-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review: Use log_page for rc_cur_id in rebuildrecentchanges.php - https://phabricator.wikimedia.org/T186840 (10GeoffreyT2000) 05Open>03Resolved a:03... [21:27:48] 10MediaWiki-extensions-CentralAuth, 10Security: Central auth fails when using "site isolation" in Google or "first-party isolation" in Firefox - https://phabricator.wikimedia.org/T202028 (10Legoktm) What does "fail" mean? Is it outputting error messages? Or just failing to log you in? [21:28:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/453013 (owner: 10L10n-bot) [21:29:04] (03Merged) 10jenkins-bot: Add special page alias for Serbian in latin variant [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452937 (owner: 10Petar.petkovic) [21:29:24] (03CR) 10Umherirrender: Fix escaping of messages used in html (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender) [21:29:57] (03CR) 10Catrope: "There's a unit test failure in this extension that seems unrelated to this commit:" [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/452063 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [21:30:20] wikimedia/mediawiki#21763 (master - 5f48905 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416530447 [21:30:49] (03CR) 10Catrope: [C: 032] Migrate EchoLocalCache to MapCacheLRU [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452986 (owner: 10Aaron Schulz) [21:33:37] (03CR) 10Catrope: [C: 032] Replace deprecated Linker::link() with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/452726 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [21:34:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/453018 (owner: 10L10n-bot) [21:35:45] wikimedia/mediawiki#21763 (master - 5f48905 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416530447 [21:36:49] (03Merged) 10jenkins-bot: Add special page alias for Serbian [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452970 (owner: 10Petar.petkovic) [21:36:51] (03Merged) 10jenkins-bot: Add special page alias for Serbian [extensions/Linter] - 10https://gerrit.wikimedia.org/r/452992 (owner: 10Petar.petkovic) [21:36:53] (03Merged) 10jenkins-bot: Update usage of 'book' OOUI icon to use from 'editing-citation' pack [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/452735 (https://phabricator.wikimedia.org/T194104) (owner: 10Jforrester) [21:36:55] (03Merged) 10jenkins-bot: Add maintenance script to get a list of enabled WP0 providers [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/452988 (https://phabricator.wikimedia.org/T202022) (owner: 10Reedy) [21:38:09] (03CR) 10Legoktm: [C: 031] "There's also some more modules in TMHHooks's register() that don't appear to be conditional either." (032 comments) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [21:38:39] 10MediaWiki-extensions-CentralAuth, 10Security: Central auth fails when using "site isolation" in Google or "first-party isolation" in Firefox - https://phabricator.wikimedia.org/T202028 (10jeblad) Fail to log in. I've double checked in Firefox and there are no error messages in the browser. I would have been... [21:38:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/453016 (owner: 10L10n-bot) [21:40:30] (03CR) 10Krinkle: Move simple module registration from hook to extension.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [21:41:11] wikimedia/mediawiki#21763 (master - 5f48905 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416530447 [21:42:02] (03CR) 10Krinkle: Move simple module registration from hook to extension.json (031 comment) [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [21:42:53] (03CR) 10Krinkle: "RE: modules in TMHHooks::register(), I noticed those, but wasn't sure whether it's completely safe due to the timing difference. But that " [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [21:45:04] (03Merged) 10jenkins-bot: Migrate EchoLocalCache to MapCacheLRU [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452986 (owner: 10Aaron Schulz) [21:45:37] (03CR) 10jenkins-bot: Fix "vaule" typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/453056 (owner: 10Petar.petkovic) [21:47:08] 10Research, 10WikiCite: WikiCite roadmap discussion: Report from Wikimania - https://phabricator.wikimedia.org/T201209 (10DarTar) [[ https://www.wikidata.org/wiki/Wikidata:WikiCite/Roadmap | Published ]] and announced it on the lists. [21:47:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/453020 (owner: 10L10n-bot) [21:49:40] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 [21:49:45] (03CR) 10Umherirrender: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [21:50:11] (03CR) 10Umherirrender: "No idea how to get this passed" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/433903 (owner: 10Umherirrender) [21:50:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/453019 (owner: 10L10n-bot) [21:51:11] (03CR) 10Jdlrobson: [C: 04-1] New: add mw.eventLog.pageviewToken and newPageInteractionToken() (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) (owner: 10Niedzielski) [21:52:01] 10Accessibility, 10Audiences-QA, 10MinervaNeue, 10Readers-Web-Backlog, and 5 others: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility - https://phabricator.wikimedia.org/T198947 (10ABorbaWMF) Tested using some real and some simulated devices... [21:56:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/453021 (owner: 10L10n-bot) [21:57:43] (03CR) 10Catrope: [C: 032] Make use of inline {@see …} tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452307 (owner: 10Thiemo Kreuz (WMDE)) [21:59:54] (03Merged) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/452726 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [22:00:29] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @leszek_wmde & @jakob_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [22:00:40] (03PS2) 10Krinkle: Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) [22:00:43] (03CR) 10Krinkle: "(done)" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [22:01:53] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/451348 [22:01:59] (03CR) 10Umherirrender: "check experimental" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/451348 (owner: 10Umherirrender) [22:02:03] (03PS3) 10Krinkle: NewMwEmbedResourceManager: Remove non-standard 'messageDir' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452993 (https://phabricator.wikimedia.org/T202017) [22:02:07] (03CR) 10Ladsgroup: "Yup, so master of OAuth is broken..." [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/452063 (https://phabricator.wikimedia.org/T194162) (owner: 10Ladsgroup) [22:02:32] (03PS3) 10Krinkle: NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) [22:02:46] (03CR) 10jerkins-bot: [V: 04-1] Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [22:03:25] (03CR) 10Umherirrender: "Passed (except one which is not part of code running on server side)" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [22:05:58] (03CR) 10jerkins-bot: [V: 04-1] NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) (owner: 10Krinkle) [22:06:31] (03PS1) 10D3r1ck01: Refactor SendGrid to fix onAlternateMailerHook() hook [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 [22:06:49] (03PS3) 10Krinkle: Move simple module registration from hooks to extension.json [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452965 (https://phabricator.wikimedia.org/T202017) [22:06:53] (03PS4) 10Krinkle: NewMwEmbedResourceManager: Remove unused 'messageFile' option [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452973 (https://phabricator.wikimedia.org/T202017) [22:07:05] (03CR) 10jerkins-bot: [V: 04-1] Add Czech aliases to Massmessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/449395 (owner: 10Urbanecm) [22:07:37] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/451348 [22:07:44] (03CR) 10Umherirrender: "check experimental" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/451348 (owner: 10Umherirrender) [22:08:23] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/453030 (owner: 10L10n-bot) [22:10:14] (03PS2) 10D3r1ck01: Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 [22:12:49] (03CR) 10Umherirrender: "Passed" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/451348 (owner: 10Umherirrender) [22:12:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/453028 (owner: 10L10n-bot) [22:15:35] (03CR) 10Krinkle: [C: 032] Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/452910 (owner: 10Legoktm) [22:16:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/453032 (owner: 10L10n-bot) [22:17:48] (03Abandoned) 10Jdlrobson: Avoid abrupt and jarring white flash in media viewer [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/448019 (https://phabricator.wikimedia.org/T197110) (owner: 10Jdlrobson) [22:18:57] (03Merged) 10jenkins-bot: Make use of inline {@see …} tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452307 (owner: 10Thiemo Kreuz (WMDE)) [22:20:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/453031 (owner: 10L10n-bot) [22:22:51] (03CR) 10Krinkle: [C: 04-1] Add InterwikiLookup::isLocalInterwiki() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452903 (owner: 10Legoktm) [22:23:09] (03PS3) 10D3r1ck01: Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 [22:24:16] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/453040 (owner: 10L10n-bot) [22:25:40] 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10OOUI (OOUI-0.28.0): Deprecate & remove citations icons from 'content' pack - https://phabricator.wikimedia.org/T194104 (10Volker_E) [22:27:07] (03CR) 10jerkins-bot: [V: 04-1] Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 (owner: 10D3r1ck01) [22:27:34] (03CR) 10Krinkle: Have LinkTarget be responsible for tracking usage of leading colons (031 comment) [core] - 10https://gerrit.wikimedia.org/r/452904 (owner: 10Legoktm) [22:29:27] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 [22:29:30] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 [22:29:35] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 (owner: 10Umherirrender) [22:30:34] (03Restored) 10Jdlrobson: Avoid abrupt and jarring white flash in media viewer [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/448019 (https://phabricator.wikimedia.org/T197110) (owner: 10Jdlrobson) [22:33:30] (03CR) 10Krinkle: [C: 04-1] New: add mw.eventLog.pageviewToken and newPageInteractionToken() (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) (owner: 10Niedzielski) [22:33:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/453035 (owner: 10L10n-bot) [22:34:22] (03Merged) 10jenkins-bot: Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/452910 (owner: 10Legoktm) [22:35:05] (03PS4) 10Jdlrobson: Avoid abrupt and jarring white flash in media viewer [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/448019 (https://phabricator.wikimedia.org/T197110) [22:35:53] (03PS4) 10D3r1ck01: Refactor ext to fix onAlternateMailerHook() hook handler [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/453065 [22:36:54] (03CR) 10jenkins-bot: Have WANCacheReapUpdate::getEventAffectedKeys() accept LinkTarget [core] - 10https://gerrit.wikimedia.org/r/452910 (owner: 10Legoktm) [22:37:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/453043 (owner: 10L10n-bot) [22:41:42] (03PS1) 10Umherirrender: Explicit parse messages in CollectionSuggestTemplate [extensions/Collection] - 10https://gerrit.wikimedia.org/r/453068 [22:42:07] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 [22:42:12] (03PS5) 10Umherirrender: Add phan-taint-check-plugin [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 [22:42:19] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 (owner: 10Umherirrender) [22:43:05] 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10Jdlrobson) [22:44:03] (03CR) 10Samwilson: [C: 032] Add special page alias for Serbian [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452932 (owner: 10Petar.petkovic) [22:44:05] 10MinervaNeue, 10Readers-Web-Backlog: [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10Jdlrobson) Since there was initial confusion on this ticket, I've had a go at adding more detail. I've removed the points so it can be estimated again. [22:46:26] 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues: Remove background colors in mobile page issue banners - https://phabricator.wikimedia.org/T202024 (10Jdlrobson) [22:46:52] (03PS6) 10Umherirrender: Add phan-taint-check-plugin [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 [22:46:59] (03CR) 10Umherirrender: [C: 04-2] "check experimental" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 (owner: 10Umherirrender) [22:50:13] 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues: Remove background colors in mobile page issue banners - https://phabricator.wikimedia.org/T202024 (10Jdlrobson) [22:50:19] Technical Advice IRC meeting starting in 10 minutes in channel #wikimedia-tech, hosts: @leszek_wmde & @jakob_WMDE - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [22:50:45] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Reading-Web-Local-Wiki-Issues: Remove background colors in mobile page issue banners - https://phabricator.wikimedia.org/T202024 (10Jdlrobson) Removed Wikify - that's not a page issue, that's just an error in the article. [22:51:43] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog: [Bug] Page issues sometimes reopens dialog - https://phabricator.wikimedia.org/T201852 (10Jdlrobson) [22:52:43] (03CR) 10Umherirrender: "Passed" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/451289 (owner: 10Umherirrender) [22:52:55] (03CR) 10jenkins-bot: Replace .done/.fail with .then in CategoryAddOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452846 (https://phabricator.wikimedia.org/T188937) (owner: 10Nray) [22:53:00] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10Analytics-EventLogging, 10Page-Issue-Warnings, and 6 others: Provide standard/reproducible way to access a PageToken - https://phabricator.wikimedia.org/T201124 (10Krinkle) @Tbayer Is it important for the consumption of the Popups schema and other even... [22:53:13] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Spike: [4 hours] Spike: How hard would it be to track number of edits saved that used TemplateWizard? - https://phabricator.wikimedia.org/T201476 (10Samwilson) @aezell yes, I think you're right. And if there //is// an issue... [22:59:09] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451288 [22:59:13] wikimedia/mediawiki#21764 (master - 765ebe5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/416575529 [22:59:17] (03CR) 10Umherirrender: "check experimental" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451288 (owner: 10Umherirrender) [23:00:11] (03CR) 10Krinkle: [C: 032] Use new Parser accessors [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452603 (owner: 10Legoktm) [23:01:06] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog: [Bug] Page issues sometimes reopens dialog - https://phabricator.wikimedia.org/T201852 (10Jdlrobson) [23:01:12] (03PS4) 10Petar.petkovic: Fix some of the common typos [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) [23:04:14] (03PS1) 10Krinkle: title: Disable the failing tests from TitlePermissionTest [core] - 10https://gerrit.wikimedia.org/r/453069 (https://phabricator.wikimedia.org/T201776) [23:04:23] (03Merged) 10jenkins-bot: Add special page alias for Serbian [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452932 (owner: 10Petar.petkovic) [23:06:37] (03CR) 10Umherirrender: "Passed" [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/451288 (owner: 10Umherirrender) [23:08:03] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js): [Bug] Page issues sometimes reopens dialog - https://phabricator.wikimedia.org/T201852 (10Jdlrobson) > The parenthetical, "...(In the old treatment, this will cause the browser to leave the site!)" is T178414... [23:08:10] (03Merged) 10jenkins-bot: Use new Parser accessors [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452603 (owner: 10Legoktm) [23:09:40] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 [23:09:43] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 [23:09:49] (03CR) 10Umherirrender: "check experimental" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 (owner: 10Umherirrender) [23:10:03] 10Readers-Web-Backlog, 10Readers-Web-Kanbanana-Board, 10Spike: [Spike, 5hrs] Minerva browser test "Reference popup drawer.Closing the reference drawer" failing for 4 builds - https://phabricator.wikimedia.org/T201956 (10Jdlrobson) a:03Jdlrobson [23:10:56] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10Jdlrobson) [23:11:23] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10Krinkle) >>! In T188937#4027902, @Jdlrob... [23:12:57] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/451366 [23:13:07] (03CR) 10Umherirrender: "check experimental" [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/451366 (owner: 10Umherirrender) [23:13:47] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10Jdlrobson) @krinkle sure. This was a cla... [23:14:22] (03PS1) 10Jdlrobson: QA: Run references test per commit [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/453071 [23:14:24] (03CR) 10jenkins-bot: Fix "vaule" typo [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/453056 (owner: 10Petar.petkovic) [23:15:39] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10Jdlrobson) [23:17:59] (03CR) 10jenkins-bot: Add special page alias for Serbian [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/452998 (owner: 10Petar.petkovic) [23:18:36] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/451284 [23:18:41] (03CR) 10Umherirrender: Add phan-taint-check-plugin [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/451284 (owner: 10Umherirrender) [23:18:43] (03CR) 10Umherirrender: "check experimental" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/451284 (owner: 10Umherirrender) [23:19:07] (03CR) 10Umherirrender: "Passed" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 (owner: 10Umherirrender) [23:20:18] (03CR) 10Krinkle: [C: 04-1] Increase OutputPage code coverage to 44.06% (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450075 (owner: 10simetrical) [23:20:21] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 [23:20:27] (03CR) 10Umherirrender: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [23:20:45] 10Wikimedia-Takedown-Tools, 10Anti-Harassment (AHT Sprint 27): Takedown tool should use UTC everywhere (including datepicker) - https://phabricator.wikimedia.org/T197836 (10dbarratt) @Jalexander & @jrbs What timezone should https://foundation.wikimedia.org/wiki/Template:DMCA_email be in? UTC? or should it re... [23:21:26] 10MediaWiki-extensions-GlobalPreferences, 10UI-Standardization, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Convert Special:GlobalPreferences to OOUI - https://phabricator.wikimedia.org/T186842 (10Niharika) Poke. This ticket has been in this column for quite long now. It seems like the... [23:23:53] (03CR) 10jerkins-bot: [V: 04-1] QA: Run references test per commit [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/453071 (owner: 10Jdlrobson) [23:24:11] (03CR) 10jenkins-bot: Replace .done with .then in uploads.js [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452849 (https://phabricator.wikimedia.org/T188937) (owner: 10Nray) [23:24:34] (03CR) 10Umherirrender: [C: 032] "Please avoid rebase and amend in one patch set. That makes it harder to find the changes between two patch sets" [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [23:24:36] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Petar.petkovic) [23:28:47] (03CR) 10jenkins-bot: Replace .done with .then in CategoryOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452834 (https://phabricator.wikimedia.org/T188937) (owner: 10Nray) [23:29:52] 10Design, 10InteractionTimeline, 10Readers-Web-Backlog (Design): Bring consistency to visual design of Interaction Timeline - https://phabricator.wikimedia.org/T188435 (10Prtksxna) There is a #patch-for-review for some of these changes https://github.com/wikimedia/InteractionTimeline/pull/85 [23:30:33] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-21 (1.32.0-wmf.18)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Petar.petkovic) [23:31:02] (03CR) 10Umherirrender: "Passed" [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/451366 (owner: 10Umherirrender) [23:31:33] 10Anti-Harassment (AHT Sprint 27): Update Special:Block to set Partial Blocks - https://phabricator.wikimedia.org/T197109 (10dbarratt) a:03dbarratt [23:34:03] (03PS1) 10Petar.petkovic: Fix spelling of word "necessary" [core] - 10https://gerrit.wikimedia.org/r/453073 (https://phabricator.wikimedia.org/T201491) [23:34:53] (03CR) 10jenkins-bot: Add special page alias for Serbian in latin variant [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452937 (owner: 10Petar.petkovic) [23:35:49] (03PS2) 10Petar.petkovic: Fix spelling of word "necessary" [core] - 10https://gerrit.wikimedia.org/r/453073 (https://phabricator.wikimedia.org/T201491) [23:46:33] (03CR) 10jenkins-bot: Add special page alias for Serbian [extensions/Linter] - 10https://gerrit.wikimedia.org/r/452992 (owner: 10Petar.petkovic) [23:49:59] (03CR) 10jenkins-bot: Add special page alias for Serbian [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452970 (owner: 10Petar.petkovic) [23:51:11] (03Merged) 10jenkins-bot: Fix some of the common typos [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [23:51:37] 10Anti-Harassment: Tracking blocks: Log when the mobile web editor block notice is displayed - https://phabricator.wikimedia.org/T201719 (10Krinkle) >>! In T201719#4505087, @aezell wrote: > One thing to note about Graphite [..] is that over time the completeness and and correctness of the data it has degrades. [... [23:52:11] (03PS2) 10Jdlrobson: QA: Run references test per commit [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/453071 (https://phabricator.wikimedia.org/T201956) [23:54:13] (03CR) 10jenkins-bot: Fix some of the common typos [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [23:56:56] (03CR) 10Krinkle: [C: 032] Escape message used in html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452319 (owner: 10Umherirrender) [23:57:44] (03CR) 10Krinkle: Add phan-taint-check-plugin (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/451334 (owner: 10Umherirrender) [23:58:39] 10MediaWiki-Internationalization, 10Patch-For-Review, 10User-notice: Preferences and lang codes should distinguish "English" from "American English"/"U.S. English" - https://phabricator.wikimedia.org/T33874 (10Samwilson) Do the language codes in MediaWiki's list match ICU locale codes? They certainly appear... [23:58:57] (03CR) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Flow] - 10https://gerrit.wikimedia.org/r/452726 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [23:59:55] (03PS4) 10Jdlrobson: Fix escaping of messages used in html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender)