[00:06:01] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/451359 (owner: 10Umherirrender) [00:10:20] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/451370 (owner: 10Umherirrender) [00:12:40] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/451355 (owner: 10Umherirrender) [00:15:24] 10MediaWiki-Parser, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018): Should ParserFactory call firstCallInit()? - https://phabricator.wikimedia.org/T201799 (10Legoktm) [00:18:10] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/451377 (owner: 10Umherirrender) [00:18:12] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/451365 (owner: 10Umherirrender) [00:19:15] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/451290 (owner: 10Umherirrender) [00:26:32] 10MediaWiki-Documentation, 10TechCom-RFC: RfC: Release notes automation - https://phabricator.wikimedia.org/T200392 (10Legoktm) >>! In T200392#4488468, @Tgr wrote: > Ideally this would run on gerrit, not developers' machines. That [[https://bugs.eclipse.org/bugs/show_bug.cgi?id=418149|does not seem to be case]... [00:46:38] 10ContentTranslation, 10Language-2018-July-September: CX2: Show issue cards when they are relevant - https://phabricator.wikimedia.org/T198187 (10Etonkovidova) @Petar.petkovic - regarding the following spec > The issue summary card should be visible when there are errors. The purpose of such card is to communi... [01:23:48] (03PS4) 10MGChecker: Add and run MediaWiki-Codesniffer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/451533 (https://phabricator.wikimedia.org/T191811) [02:00:18] (03PS1) 10Legoktm: Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 [02:09:00] (03CR) 10jerkins-bot: [V: 04-1] Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 (owner: 10Legoktm) [02:14:55] (03CR) 10Prtksxna: Add `border-style-base` variable (031 comment) [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [02:15:53] (03PS2) 10Legoktm: Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 [02:17:11] (03PS3) 10Legoktm: Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 [02:20:04] (03PS7) 10Brion VIBBER: ParallelMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [02:37:07] (03CR) 10jerkins-bot: [V: 04-1] ParallelMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 (owner: 10Brion VIBBER) [02:46:00] (03PS8) 10Brion VIBBER: ParallelMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [02:46:43] (03PS1) 10Legoktm: Call overrideMwServices() in TitlePermissionTest [core] - 10https://gerrit.wikimedia.org/r/452279 (https://phabricator.wikimedia.org/T201776) [02:49:31] 10MediaWiki-Core-Tests, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Patch-For-Review, 10Wikimedia-log-errors (Shared Build Failure): TitlePermissionTest failing on travis-ci after ContentLanguage service conversion - https://phabricator.wikimedia.org/T201776 (10Legoktm) [02:49:59] (03CR) 10Legoktm: [C: 032] "Filed T201799 for the firstCallInit question" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [02:57:56] (03Merged) 10jenkins-bot: Get Parser from service instead of global $wgParser [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [03:00:59] (03CR) 10jenkins-bot: Get Parser from service instead of global $wgParser [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [03:05:23] 10MediaWiki-Configuration, 10MediaWiki-Installer, 10MW-1.30-release: Config script still sets "en_US.utf8" to "$wgShellLocale" for MW 1.30+ - https://phabricator.wikimedia.org/T201749 (10Legoktm) 05Open>03Invalid I tested this out and it properly defaulted to C.UTF-8. I suspect @Cavila doesn't have the C... [03:26:05] (03PS3) 10Legoktm: Remove $wgEchoNewMsgAlert and 'echo-show-alert' preference [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) [03:27:49] (03CR) 10VolkerE: Add `border-style-base` variable (031 comment) [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [03:30:23] (03CR) 10Legoktm: "PS3: Rebased." [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm) [03:36:43] (03CR) 10Legoktm: [C: 04-1] "Please add release notes for the deprecation, and then this looks ready to me." [core] - 10https://gerrit.wikimedia.org/r/444348 (owner: 10Fomafix) [03:44:42] (03CR) 10Legoktm: [C: 032] Add type hint Language where possible [core] - 10https://gerrit.wikimedia.org/r/443288 (owner: 10Fomafix) [03:45:39] (03CR) 10Legoktm: "Shouldn't these brackets be localized anyways? Is it possible to do that in CSS?" [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447671 (owner: 10Fomafix) [03:47:39] (03CR) 10Legoktm: "Please see T201405 (which I cc'd you on) about introducing a LanguageFactory class and moving away from new static methods on Language." [core] - 10https://gerrit.wikimedia.org/r/441528 (owner: 10Fomafix) [04:01:15] (03CR) 10Thiemo Kreuz (WMDE): Linker: more consistent whitespace parsing in formatLinksInComment (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [04:15:17] 10MediaWiki-Parser, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018): Should ParserFactory call firstCallInit()? - https://phabricator.wikimedia.org/T201799 (10tstarling) It's important to avoid running it on requests that don't need it. In particular, requests that only call $wgParser->setHook() but not Parser::par... [04:16:49] (03Merged) 10jenkins-bot: Add type hint Language where possible [core] - 10https://gerrit.wikimedia.org/r/443288 (owner: 10Fomafix) [04:19:51] (03CR) 10jenkins-bot: Add type hint Language where possible [core] - 10https://gerrit.wikimedia.org/r/443288 (owner: 10Fomafix) [04:29:29] wikimedia/mediawiki#21713 (master - e0b544e jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415284862 [04:31:18] wikimedia/mediawiki#21713 (master - e0b544e jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415284862 [04:39:04] wikimedia/mediawiki#21713 (master - e0b544e jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415284862 [04:39:27] wikimedia/mediawiki#21713 (master - e0b544e jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415284862 [04:44:40] (03PS1) 10Legoktm: Don't use deprecated MagicWord methods [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452284 [04:46:35] (03CR) 10Prtksxna: Add `border-style-base` variable (031 comment) [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [04:48:24] (03CR) 10Samwilson: [C: 04-1] "Looks great. One tiny typo." (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/451799 (owner: 10Eranroz) [04:50:17] 10InteractionTimeline, 10Anti-Harassment (AHT Sprint 26): Update node-sass to clear out security warning on github - https://phabricator.wikimedia.org/T201720 (10dbarratt) 05Open>03Resolved [04:52:27] 10Anti-Harassment (AHT Sprint 26): Update block logs with partial block details - https://phabricator.wikimedia.org/T197108 (10dbarratt) @dmaza I think T197117 is the next task in the graph, but if you can complete this one before it's subtasks than go for it, but I think we figured that wouldn't be possible for... [04:56:37] (03PS3) 10Eranroz: TemplateWizard: Hooks for cusomtizations [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/451799 [04:57:27] 10Anti-Harassment: Determine plan for Partial Blocks feature flag - https://phabricator.wikimedia.org/T201722 (10dbarratt) All that makes sense to me, and I agree that I don't think disabling the feature should mess with the database. [05:01:22] (03PS1) 10MtMNC: Have dropdowns/sidebar toggle on click without JS, change style, etc. [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/452285 [05:03:36] (03CR) 10Eranroz: TemplateWizard: Hooks for cusomtizations (031 comment) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/451799 (owner: 10Eranroz) [05:05:59] (03PS2) 10MtMNC: Have dropdowns/sidebar toggle on click without JS, change style, etc. [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/452285 [05:17:11] (03CR) 10Samwilson: [C: 032] TemplateWizard: Hooks for cusomtizations [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/451799 (owner: 10Eranroz) [05:23:26] (03Merged) 10jenkins-bot: TemplateWizard: Hooks for cusomtizations [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/451799 (owner: 10Eranroz) [05:25:10] (03CR) 10Tim Starling: [C: 032] "Yup. It shouldn't be surprising that 6 Assert::* calls have a cost, and it looks like Title::getPrefixedText() here is hitting the in-obje" [core] - 10https://gerrit.wikimedia.org/r/452278 (owner: 10Legoktm) [05:31:02] 10MediaWiki-Logging, 10Browser-Support-Internet-Explorer: Date box on Special:Log shows "0000-00-00" by default in Internet Explorer - https://phabricator.wikimedia.org/T201125 (10GeoffreyT2000) [05:38:16] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10Samwilson) When T194436 is done, we'll have a method for focusing the top empty field. [05:40:36] 10CX-deployments, 10Language-2018-July-September: Update cxserver2.wmflabs.org instance - https://phabricator.wikimedia.org/T199295 (10KartikMistry) cxserver2.wmflabs.org has been deleted after observing no issues with cxserver and Labs instances of CX. [05:45:07] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Performance: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title - https://phabricator.wikimedia.org/T201801 (10Legoktm) [05:45:39] (03PS1) 10Pwirth: Removed unused message key from extension BlueSpiceRSSFeeder. T199714 [extensions/BlueSpiceDashboards] - 10https://gerrit.wikimedia.org/r/452289 [05:45:54] (03Merged) 10jenkins-bot: Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 (owner: 10Legoktm) [05:46:18] (03CR) 10Gergő Tisza: Permissions of a specific groups should be temporarily removed if Two-Factor-Auth isn't enabled for a user (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T150562) (owner: 10MR70) [05:46:23] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Performance: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title - https://phabricator.wikimedia.org/T201801 (10Legoktm) Some notes from IRC with @tstarling: ```lang=irc [22:30:25] TimStarlin... [05:48:36] (03CR) 10jenkins-bot: Add benchmark script demonstrating TitleValue is slower than Title [core] - 10https://gerrit.wikimedia.org/r/452278 (owner: 10Legoktm) [05:55:29] 10MediaWiki-Authentication-and-authorization, 10Epic, 10Security-General, 10User-Tgr: All security-sensitive MediaWiki functionality should require elevated security - https://phabricator.wikimedia.org/T197160 (10Tgr) [05:55:32] 10MediaWiki-User-management, 10Security-Core: Tie certain user rights to elevated security - https://phabricator.wikimedia.org/T197136 (10Tgr) [05:55:59] (03PS1) 10Pwirth: TEST [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/452291 [05:57:21] 10MediaWiki-General-or-Unknown, 10Performance-Team: Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10Legoktm) [05:58:41] wikimedia/mediawiki#21714 (master - 4fe7d04 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415300613 [06:00:21] 10Wikimedia-General-or-Unknown, 10Developer-Wishlist (2017), 10HHVM, 10Upstream: Can't enter unicode into eval.php in production ? - https://phabricator.wikimedia.org/T69924 (10Tgr) 05Open>03Resolved a:03Tgr Works fine these days, our HHVM version has been upgraded presumably. [06:00:46] (03PS2) 10Pwirth: Add missing GroupPermission registration for right permissionmanager-viewspecialpage [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/452291 [06:00:47] wikimedia/mediawiki#21714 (master - 4fe7d04 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415300613 [06:01:18] (03PS3) 10Pwirth: Add missing GroupPermission registration for right permissionmanager-viewspecialpage T197900 [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/452291 [06:01:57] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Tgr) This is basically {T197136} plus {T197153}, with extra configuration options for OATHA... [06:03:11] 10Patch-For-Review, 10Zuul: Patches submitted by L10n-bot to apps/android/wikipedia ain't checked nor autosubmitted - https://phabricator.wikimedia.org/T201586 (10Nikerabbit) This is intentional. For android the l10n updates can break the build, so they have opted in for a manual merge. [06:08:32] wikimedia/mediawiki#21714 (master - 4fe7d04 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415300613 [06:09:45] wikimedia/mediawiki#21714 (master - 4fe7d04 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415300613 [06:15:33] (03PS9) 10Pwirth: [WIP] Refactoring [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/451393 [06:34:24] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Liuxinyu970226) The [[https://www.wikidata.org/wiki/Wikidata:Notability|WD:N]] mentioned that > To be valid, a link must not be a talk page, MediaWiki page, special page, file, translations... [06:34:43] 10Dumps-Generation: wikidata dumps broken with 'unexpected option: --full!' for revision history content dumps - https://phabricator.wikimedia.org/T201803 (10ArielGlenn) [06:35:39] (03PS1) 10ArielGlenn: Add the 'full' option explicitly to dumpTextPass.php. [core] - 10https://gerrit.wikimedia.org/r/452303 (https://phabricator.wikimedia.org/T201803) [06:40:11] 10Dumps-Generation, 10Patch-For-Review: wikidata dumps broken with 'unexpected option: --full!' for revision history content dumps - https://phabricator.wikimedia.org/T201803 (10ArielGlenn) 2bd7259a2c88a2bcc30a9217770a64268e161305 is the commit which changed the behavior of maintenance scripts, merged on Aug... [06:44:41] (03CR) 10Legoktm: [C: 032] Add the 'full' option explicitly to dumpTextPass.php. [core] - 10https://gerrit.wikimedia.org/r/452303 (https://phabricator.wikimedia.org/T201803) (owner: 10ArielGlenn) [06:47:12] (03PS1) 10Legoktm: Add the 'full' option explicitly to dumpTextPass.php. [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452304 (https://phabricator.wikimedia.org/T201803) [06:47:36] (03CR) 10Legoktm: [C: 032] Add the 'full' option explicitly to dumpTextPass.php. [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452304 (https://phabricator.wikimedia.org/T201803) (owner: 10Legoktm) [06:49:03] 10Library-Card-Platform: Provide a link or form for suggesting new partners - https://phabricator.wikimedia.org/T201156 (10AVasanth_WMF) a:03AVasanth_WMF [06:54:53] 10MediaWiki-Database, 10Core-Platform-Team, 10Wikimedia-log-errors: Foreign query for metawiki fails with "Table 'centralauth.page' doesn't exist" (DBConnRef mixup?) - https://phabricator.wikimedia.org/T193565 (10tstarling) It doesn't have to be a LoadBalancer bug, it could just be some other extension calli... [07:00:47] 10MediaWiki-General-or-Unknown: mediawiki/extensions/CreatedPagesList failing unit tests - https://phabricator.wikimedia.org/T201805 (10Umherirrender) [07:00:53] (03CR) 10Umherirrender: [V: 032 C: 032] "Created T201805 for the failure" [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/451070 (owner: 10Umherirrender) [07:03:07] (03PS4) 10Umherirrender: Add phan-taint-check-plugin [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/451359 [07:03:11] (03CR) 10Umherirrender: [V: 032] "T201745" [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/451359 (owner: 10Umherirrender) [07:10:47] (03Merged) 10jenkins-bot: Add the 'full' option explicitly to dumpTextPass.php. [core] - 10https://gerrit.wikimedia.org/r/452303 (https://phabricator.wikimedia.org/T201803) (owner: 10ArielGlenn) [07:13:19] (03Merged) 10jenkins-bot: Add the 'full' option explicitly to dumpTextPass.php. [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452304 (https://phabricator.wikimedia.org/T201803) (owner: 10Legoktm) [07:13:44] (03CR) 10jenkins-bot: Add the 'full' option explicitly to dumpTextPass.php. [core] - 10https://gerrit.wikimedia.org/r/452303 (https://phabricator.wikimedia.org/T201803) (owner: 10ArielGlenn) [07:14:20] (03CR) 10jenkins-bot: Add the 'full' option explicitly to dumpTextPass.php. [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452304 (https://phabricator.wikimedia.org/T201803) (owner: 10Legoktm) [07:16:20] (03PS1) 10Umherirrender: Expand documentation about options in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/452306 [07:18:19] (03PS1) 10Thiemo Kreuz (WMDE): Make use of inline {@see …} tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452307 [07:19:31] 10MediaWiki-Maintenance-scripts, 10Dumps-Generation, 10Patch-For-Review: wikidata dumps broken with 'unexpected option: --full!' for revision history content dumps - https://phabricator.wikimedia.org/T201803 (10Legoktm) [07:21:58] 10WMSE-Riksarkivet-TORA: Use P3842 - located in present-day administrative territorial entity - https://phabricator.wikimedia.org/T199793 (10Salgo60) [07:22:15] (03PS1) 10Thiemo Kreuz (WMDE): Remove two unused properties from AttributeManager [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452308 [07:24:43] wikimedia/mediawiki#21715 (master - 5081fe5 Ariel T. Glenn): The build has errored. - https://travis-ci.org/wikimedia/mediawiki/builds/415319868 [07:27:42] (03PS1) 10Thiemo Kreuz (WMDE): Make "@… array" type hints more specific [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452309 [07:29:47] (03PS1) 10Thiemo Kreuz (WMDE): Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 [07:31:30] (03PS1) 10Thiemo Kreuz (WMDE): Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 [07:32:13] (03PS1) 10Umherirrender: Use Html::rawElement for parsed message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/452312 [07:33:24] (03PS1) 10Thiemo Kreuz (WMDE): Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 [07:33:43] (03PS2) 10VolkerE: Add `border-style-base` variable [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 [07:34:32] 10MediaWiki-Maintenance-scripts, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review, 10Wikimedia-Incident: Maintenance scripts should fail on unknown parameters - https://phabricator.wikimedia.org/T110209 (10Joe) There was one c... [07:35:34] (03PS1) 10Thiemo Kreuz (WMDE): Fix missing/mismatching type hints PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 [07:36:27] (03CR) 10VolkerE: Add `border-style-base` variable (031 comment) [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [07:39:12] (03PS1) 10Umherirrender: Use raw message in title attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 [07:39:48] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/451845 (owner: 10ItSpiderman) [07:42:37] (03CR) 10jerkins-bot: [V: 04-1] Use raw message in title attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [07:43:53] (03CR) 10Brion VIBBER: [C: 032] "Note the tests currently fail due to an unrelated bit of code that probably was a change in the style checker. Lemme see if can fix that." [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [07:45:51] 10phan-taint-check-plugin: Using message text in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Umherirrender) [07:45:58] (03CR) 10Umherirrender: "Created T201806" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [07:47:02] (03PS1) 10Brion VIBBER: Fix some js indent issues that are killing tests [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452316 [07:47:15] (03CR) 10jerkins-bot: [V: 04-1] Use raw message in title attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [07:47:51] (03PS1) 10Thiemo Kreuz (WMDE): Make use of the …::class feature instead of string copies [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/452317 [07:50:34] 10Internet-Archive, 10InternetArchiveBot: InternetArchiveBot breaking references using {{webarchive}} - https://phabricator.wikimedia.org/T201807 (10Evad37) [07:52:23] 10Internet-Archive, 10InternetArchiveBot: InternetArchiveBot breaking references using {{webarchive}} - https://phabricator.wikimedia.org/T201807 (10Evad37) [07:52:25] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 [07:52:32] (03CR) 10Umherirrender: "Include changes from I534aba6ef822590d7e914ed0c1e71692e7768ef7" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [07:52:38] (03CR) 10Umherirrender: "check experimental" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [07:58:13] (03CR) 10Umherirrender: "" [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451346 (owner: 10Umherirrender) [07:59:11] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10thiemowmde) I reviewed patch set 6 of the patch https://gerrit.wikimedia.org/r/451611, and can confirm that it successful... [08:01:36] 10Wikipedia-Android-App-Backlog, 10I18n, 10Patch-For-Review, 10Zuul: Patches submitted by L10n-bot to apps/android/wikipedia ain't checked nor autosubmitted - https://phabricator.wikimedia.org/T201586 (10Nemo_bis) [08:03:51] 10Wikidata-Editor-Experience-Improvements-Iteration4, 10Wikidata-Editor-Experience-Improvements-Iteration5: Document quibble learnings - https://phabricator.wikimedia.org/T200991 (10Pablo-WMDE) https://gerrit.wikimedia.org/r/451599 https://gerrit.wikimedia.org/r/451294 [08:04:14] (03PS1) 10Umherirrender: Do not use GWTException::getMessage as raw html [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/452318 [08:04:51] 10Repository-Ownership-Requests: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10Nemo_bis) > If there are not any, what's holding this? I don't know about other people, but personally I fail to see in the task description the usual info... [08:06:07] (03CR) 10Brion VIBBER: [C: 032] Fix some js indent issues that are killing tests [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452316 (owner: 10Brion VIBBER) [08:17:20] 10MediaWiki-General-or-Unknown, 10Performance-Team: Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10thiemowmde) From the header of [Assert.php](https://github.com/wikimedia/Assert/blob/master/src/Assert.php#L9): > Note that assertions evaluate expressions and add function c... [08:23:56] (03PS1) 10Umherirrender: Escape message used in html [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452319 [08:26:51] 10MediaWiki-General-or-Unknown, 10Performance-Team: Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10daniel) > Requesting a performance review, mostly for how the library is used, and whether we should change the way we're using it. If I recall correctly, we opted against u... [08:28:46] (03Merged) 10jenkins-bot: Fix some js indent issues that are killing tests [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452316 (owner: 10Brion VIBBER) [08:28:49] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Performance, 10User-Daniel: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title - https://phabricator.wikimedia.org/T201801 (10daniel) [08:28:56] 04(no projects): No warning issued over the use of the "santisation" of non-permited HTML. - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) [08:30:04] 10JADE, 10Wikimedia-log-errors: Notice: Use of undefined constant NS_JADE_TALK - assumed 'NS_JADE_TALK' in /srv/mediawiki-staging/php-1.32.0-wmf.15/extensions/JADE/JADE.namespaces.php on line 15 - https://phabricator.wikimedia.org/T200978 (10Nikerabbit) a:05Nikerabbit>03Legoktm [08:30:19] (03PS2) 10Brion VIBBER: Use raw message in title attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [08:30:38] 04(no projects): No warning issued when non-permissable HTML was "santised"... - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) [08:30:54] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Performance, 10User-Daniel: Improve TitleValue, TitleFactory, TitleParser performance to be on-par with Title - https://phabricator.wikimedia.org/T201801 (10thiemowmde) > not that anyone cares if an integer is passed as a float [... [08:31:09] 10MediaWiki-Parser, 10RemexHtml: No warning issued when non-permissable HTML was "santised"... - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) [08:44:08] 10MediaWiki-Configuration, 10MediaWiki-Installer, 10MW-1.30-release: Config script still sets "en_US.utf8" to "$wgShellLocale" for MW 1.30+ - https://phabricator.wikimedia.org/T201749 (10Kghbln) > I tested this out and it properly defaulted to C.UTF-8. I suspect @Cavila doesn't have the C.UTF-8 locale instal... [08:50:02] 10phan-taint-check-plugin: Make Pager::getNavigationBar safe for phan-taint-check-plugin - https://phabricator.wikimedia.org/T201811 (10Umherirrender) [08:50:28] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [08:51:31] (03CR) 10Umherirrender: [C: 032] Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [08:53:04] (03CR) 10Umherirrender: [C: 031] Make use of the …::class feature instead of string copies (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/452317 (owner: 10Thiemo Kreuz (WMDE)) [08:55:23] 10MediaWiki-General-or-Unknown: mediawiki/extensions/CreatedPagesList failing unit tests - https://phabricator.wikimedia.org/T201805 (10edwardspec) Investigating. But it uses standard ``` $rev = new Revision( ... ) $rev->insertOn( $dbw ); ``` from MediaWiki core. I'll probably just replace it with $dbw->insert... [08:56:35] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Gopavasanth) Yes I agree @thiemowmde that the Icon is not centered yet and I will try to fix it. >The slider UI bel... [09:00:34] 10MediaWiki-Parser, 10RemexHtml: No warning issued when non-permissable HTML was "santised"... - https://phabricator.wikimedia.org/T201809 (10Aklapper) 05Open>03stalled Please follow https://www.mediawiki.org/wiki/How_to_report_a_bug and structure your tasks by providing 1) a clear list of specific steps... [09:06:49] 10MediaWiki-General-or-Unknown: mediawiki/extensions/CreatedPagesList failing unit tests - https://phabricator.wikimedia.org/T201805 (10Umherirrender) It is in recalculateSqlTable which used an insertSelect with GROUP BY ``` $dbw->insertSelect( 'createdpageslist', [ 'page', 'revision', ],... [09:08:52] (03Merged) 10jenkins-bot: Use raw message in title attributes [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452315 (owner: 10Umherirrender) [09:14:02] (03Merged) 10jenkins-bot: Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [09:14:05] 10MediaWiki-Parser, 10RemexHtml: No warning issued when non-permissable HTML was "santised"... - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) [09:15:26] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Notifications: Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10Umherirrender) [09:15:32] 10phan-taint-check-plugin: Using message text in Database::select shows false positive on taint-check-plugin - https://phabricator.wikimedia.org/T201806 (10Bawolff) Its saying arg1 & arg2 are unsafe. Probably a false positive due to the entire $query array being treated as a single unit, which is currently a lim... [09:15:35] (03CR) 10Umherirrender: "Created T201812 for the failure" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [09:16:59] 10phan-taint-check-plugin: Make Pager::getNavigationBar safe for phan-taint-check-plugin - https://phabricator.wikimedia.org/T201811 (10Bawolff) It complains about this in core too. I think there is a bug in the plugin but i havent been able to track it down yet. [09:18:11] (03PS11) 10Legoktm: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [09:20:01] (03CR) 10jenkins-bot: Add missing newlines before "use" sections [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452310 (owner: 10Thiemo Kreuz (WMDE)) [09:20:23] 10MediaWiki-Parser, 10RemexHtml: Provide an additional warning for non-permitted HTML sequences in wikitext to get sanitized - https://phabricator.wikimedia.org/T201809 (10Aklapper) 05stalled>03Open [09:21:51] 10Contributors-Analysis, 10Product-Analytics: Review the draft Community Engagement Insights report for the Contributors team - https://phabricator.wikimedia.org/T198924 (10Neil_P._Quinn_WMF) 05Open>03Resolved [09:21:57] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/451384 [09:22:00] 10Contributors-Analysis, 10Product-Analytics: Prepare presentation on outcomes of the CE Insights survey - https://phabricator.wikimedia.org/T201543 (10Neil_P._Quinn_WMF) 05Open>03Resolved [09:22:02] (03CR) 10Umherirrender: "check experimental" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/451384 (owner: 10Umherirrender) [09:22:28] 10MediaWiki-Parser, 10MediaWiki-extensions-Linter, 10RemexHtml: Provide an additional warning for non-permitted HTML sequences in wikitext to get sanitized - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) [09:23:27] 10MediaWiki-Parser, 10MediaWiki-extensions-Linter, 10RemexHtml: Provide an additional warning for non-permitted HTML sequences in wikitext to get sanitized - https://phabricator.wikimedia.org/T201809 (10ShakespeareFan00) Adding Linter extension, as non-permitted sequences are something that it could look for... [09:25:56] (03PS1) 10PortalsBuilder: Assets build - 2018-08-13 09:25:54+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/452326 [09:27:29] 10Contributors-Analysis, 10Product-Analytics: Share CE Insights survey findings with product managers, analysts, and designers in Audiences - https://phabricator.wikimedia.org/T201813 (10Neil_P._Quinn_WMF) [09:28:05] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Jayprakash12345) @Gopavasanth Are you using MediaWiki 1.30? (As I can see in your screenshot) Note:- All the developmen... [09:28:11] (03PS1) 10Umherirrender: Escape messages used in error html [extensions/timeline] - 10https://gerrit.wikimedia.org/r/452327 [09:30:12] (03PS1) 10Edward Chernenko: Avoid $dbw->insertSelect() with GROUP BY - this syntax is supported only by MySQL [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/452328 (https://phabricator.wikimedia.org/T201805) [09:31:24] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Gopavasanth) I am using Mediawiki 1.32.0-alpha (b8a29aa) I didn't rename the folder name.{F24891351} [09:33:21] 10MediaWiki-extensions-Pluggable-Auth: Returning to page after login broken while using SimpleSAMLphp - https://phabricator.wikimedia.org/T188228 (10Aklapper) 05Open>03stalled @Poikilotherm: Could you please reply? [09:34:37] 10glam2commons: Date parsing into the required format for image upload to Commons - https://phabricator.wikimedia.org/T161945 (10Aklapper) a:05Kamsuri5>03None @Kamsuri5: I am resetting the assignee of this task because there has not been progress lately (please correct me if I am wrong!). Resetting the assi... [09:34:40] 10Wikimedia-Site-requests: Enable translate extension on oldwikisource - https://phabricator.wikimedia.org/T201814 (10jhsoby) [09:36:17] 10MediaWiki-extensions-GuidedTour, 10Growth-Team, 10Easy, 10Patch-For-Review, 10User-D3r1ck01: Wrong wording in Wikipedia editor tip popup - says "Save Page", should say "Publish Changes" - https://phabricator.wikimedia.org/T201589 (10D3r1ck01) [09:36:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10jcrespo) 05Resolved>03Open dumpJson.php... [09:36:27] 10ContentTranslation, 10Language-2018-July-September: CX2: Communicate template could not be adapted - https://phabricator.wikimedia.org/T192271 (10santhosh) You are correct about the implication of `ve.dm.MWTransclusionNode.static.matchFunction`. Adding any rel to Transclusion won't fix the issue. The reason... [09:37:34] 10Wikimedia-Site-requests: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Aklapper) @Serkanland: Please do not assign people to tasks without their explicit consent. See https://mediawiki.org/wiki/How_to_report_a_bug . Thanks! [09:38:09] 10MediaWiki-extensions-WikibaseView, 10Africa-Wikimedia-Developers, 10Wikidata, 10Need-volunteer, and 2 others: Deleting a Wikipedia link with Backspace key causes deleting another links - https://phabricator.wikimedia.org/T153204 (10D3r1ck01) [09:50:52] (03CR) 10ArielGlenn: "On a read-through (no testing) it looks ok; how much extra overhead is this going to add?" [core] - 10https://gerrit.wikimedia.org/r/451230 (owner: 10Smalyshev) [09:57:52] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 [09:58:00] (03CR) 10Umherirrender: "check experimental" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [09:58:39] 10AbuseFilter: Implement partial blocks in AbuseFilter as they'll be available - https://phabricator.wikimedia.org/T201815 (10Daimona) [09:59:08] 10AbuseFilter: Implement partial blocks in AbuseFilter as they'll be available - https://phabricator.wikimedia.org/T201815 (10Daimona) [09:59:17] 10AbuseFilter: Implement partial blocks in AbuseFilter as they'll be available - https://phabricator.wikimedia.org/T201815 (10Daimona) 05Open>03stalled [10:00:31] 04(no projects): Onboarding Effie Mouzeli - https://phabricator.wikimedia.org/T201816 (10Joe) [10:02:04] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [10:02:53] (03PS3) 10Umherirrender: Add phan-taint-check-plugin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 [10:03:06] (03CR) 10Umherirrender: "Passed (with suppression)" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [10:06:01] 10FormWizard: Rewrite FormWizard as an extension - https://phabricator.wikimedia.org/T198769 (10Eugene233) [10:06:05] 10FormWizard, 10Patch-For-Review: Fix Errors which comes with Gerrit Repo - https://phabricator.wikimedia.org/T201726 (10Eugene233) 05Open>03Resolved Issues Resolved. [10:07:50] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [10:09:58] 10MediaWiki-Parser, 10MediaWiki-extensions-LabeledSectionTransclusion, 10Tidy:
tag name collides with HTML 5
tag - https://phabricator.wikimedia.org/T32597 (10ShakespeareFan00)
meaning LST is widely used on Wikisource. Is the tag used anywhere else in HTML5? Other p... [10:14:53] 10Contributors-Analysis, 10Product-Analytics, 10Epic: Submit Audiences questions to the 2018-19 CE Insights survey - https://phabricator.wikimedia.org/T201817 (10Neil_P._Quinn_WMF) [10:16:35] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/451369 (owner: 10Umherirrender) [10:16:54] (03PS1) 10Umherirrender: Escape error messages used in html [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/452331 [10:16:56] 10Wikipedia-Android-App-Backlog, 10I18n, 10Patch-For-Review, 10Zuul: Patches submitted by L10n-bot to apps/android/wikipedia ain't checked nor autosubmitted - https://phabricator.wikimedia.org/T201586 (10MarcoAurelio) >>! In T201586#4497597, @Nikerabbit wrote: > This is intentional. For android the l10n up... [10:17:03] 10Wikipedia-Android-App-Backlog, 10I18n, 10Zuul: Patches submitted by L10n-bot to apps/android/wikipedia ain't checked nor autosubmitted - https://phabricator.wikimedia.org/T201586 (10MarcoAurelio) [10:17:14] (03PS12) 10Legoktm: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [10:18:46] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Please unblock stuck global rename: EricEnfermero to Larry Hockett - https://phabricator.wikimedia.org/T201314 (10MarcoAurelio) I'd like to echo what @Trijnstel said. Could somebody please have a look at that rename and unblock it... [10:21:24] (03PS1) 10Legoktm: Avoid $wgUser fallback in SpecialPageFactory::getUsablePages() [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/452333 [10:21:53] (03CR) 10Umherirrender: "This breaks the ProofreadPage extensions because 'hadSignature' is different" [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [10:23:59] (03CR) 10Umherirrender: [C: 032] Be compatible with wikimedia/timestamp ^2.0 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [10:25:02] (03Merged) 10jenkins-bot: Be compatible with wikimedia/timestamp ^2.0 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [10:25:06] (03Merged) 10jenkins-bot: Drop PHP < 7.0 support [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452029 (owner: 10Legoktm) [10:25:13] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, 10WMDE-Design (WMDE-Design-Workboard Doing): find a solution to accept email adresses only - https://phabricator.wikimedia.org/T188516 (10Tobias_Schumann_WMDE) For the record: We decided to go with the solution to have a separated eMail form wi... [10:25:19] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/451378 [10:25:26] (03CR) 10Umherirrender: "check experimental" [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/451378 (owner: 10Umherirrender) [10:25:38] (03CR) 10jenkins-bot: Be compatible with wikimedia/timestamp ^2.0 [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [10:25:55] (03CR) 10jenkins-bot: Drop PHP < 7.0 support [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452029 (owner: 10Legoktm) [10:28:27] (03CR) 10Legoktm: "PS12: I dropped the need for $wgUser by requiring the callers to provide a user object." [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [10:30:50] (03CR) 10Umherirrender: [C: 032] Avoid $wgUser fallback in SpecialPageFactory::getUsablePages() [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/452333 (owner: 10Legoktm) [10:31:00] (03CR) 10Jdrewniak: New: add mw.eventLog.pageviewToken and newPageInteractionToken() (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) (owner: 10Niedzielski) [10:31:18] (03CR) 10Umherirrender: "Passed" [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/451378 (owner: 10Umherirrender) [10:32:58] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10ArielGlenn) I didn't get a chance to check t... [10:34:00] (03CR) 10Umherirrender: [C: 031] Avoid $dbw->insertSelect() with GROUP BY - this syntax is supported only by MySQL (031 comment) [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/452328 (https://phabricator.wikimedia.org/T201805) (owner: 10Edward Chernenko) [10:34:12] (03PS12) 10Daniel Kinzler: [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) [10:34:49] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [10:35:17] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [10:35:25] (03CR) 10Jdrewniak: [C: 032] Rename non-base transition var and add `transition-ease-out-medium` var [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452018 (owner: 10VolkerE) [10:36:13] (03Merged) 10jenkins-bot: Rename non-base transition var and add `transition-ease-out-medium` var [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452018 (owner: 10VolkerE) [10:37:16] (03Merged) 10jenkins-bot: Avoid $wgUser fallback in SpecialPageFactory::getUsablePages() [skins/Nostalgia] - 10https://gerrit.wikimedia.org/r/452333 (owner: 10Legoktm) [10:38:05] (03CR) 10Jdrewniak: [C: 032] Assets build - 2018-08-13 09:25:54+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/452326 (owner: 10PortalsBuilder) [10:38:25] (03PS1) 10D3r1ck01: Use of Interwiki mediawiki link where necessary [core] - 10https://gerrit.wikimedia.org/r/452336 [10:39:17] (03Merged) 10jenkins-bot: Assets build - 2018-08-13 09:25:54+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/452326 (owner: 10PortalsBuilder) [10:40:13] (03PS2) 10D3r1ck01: Use of Interwiki mediawiki link where necessary [core] - 10https://gerrit.wikimedia.org/r/452336 [10:43:17] 10WMSE-Riksarkivet-TORA: Speak with Arkiv Digital - https://phabricator.wikimedia.org/T199907 (10Salgo60) [10:44:05] 10WMSE-Riksarkivet-TORA: Speak with Arkiv Digital - https://phabricator.wikimedia.org/T199907 (10Salgo60) [10:46:48] (03PS1) 10Ladsgroup: Add option to populateChangeTagDef not to update the count [core] - 10https://gerrit.wikimedia.org/r/452337 [10:48:53] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10SBisson) @Etonkovidova it is NOT the de... [10:51:29] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10ArielGlenn) I will hazard a guess that the s... [10:52:04] (03PS13) 10Daniel Kinzler: [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) [10:52:33] (03PS1) 10Sbisson: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) [10:54:28] (03Abandoned) 10MarcoAurelio: General maintenance [extensions/OpenBadges] - 10https://gerrit.wikimedia.org/r/445620 (owner: 10Seb35) [10:54:40] (03PS1) 10Legoktm: Upgrade wikimedia/xmp-reader to 0.6.0 [vendor] - 10https://gerrit.wikimedia.org/r/452339 [10:54:42] (03PS1) 10Legoktm: Upgrade wikimedia/timestamp to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/452340 [10:54:51] (03PS5) 10Legoktm: Increase OutputPage code coverage to 44.06% [core] - 10https://gerrit.wikimedia.org/r/450075 (owner: 10simetrical) [10:54:53] (03PS1) 10Legoktm: Upgrade wikimedia/xmp-reader to 0.6.0 [core] - 10https://gerrit.wikimedia.org/r/452341 [10:54:55] (03PS1) 10Legoktm: Upgrade wikimedia/timestamp to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/452342 [10:57:55] 10Repository-Ownership-Requests: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10Legoktm) What Nemo said, as well as my reading of T193049#4162917 gave me the impression that MGChecker wasn't interested in serving as the maintainer. [11:03:59] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Readers-Web-Kanbanana-Board: Mobile page issues - instrument page issues - https://phabricator.wikimedia.org/T191532 (10phuedx) @Tbayer: Did you want to set up a meeting with a... [11:06:53] 10BlueSpice: Convert BlueSpiceTagCloud to use extension registration - https://phabricator.wikimedia.org/T190880 (10Pwirth) 05Open>03Resolved a:03Pwirth Resolved in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/BlueSpiceTagCloud/+/435732/ [11:06:55] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668 (10Pwirth) [11:06:57] 10Repository-Ownership-Requests: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10MarcoAurelio) If @MGChecker could confirm whether (s)he is still interested I think we could move forward faster I think? Thanks. [11:08:08] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [11:09:49] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10jcrespo) > does not try to refresh it period... [11:11:27] (03PS14) 10Daniel Kinzler: [MCR] Introduce RevisionRenderer [core] - 10https://gerrit.wikimedia.org/r/451025 (https://phabricator.wikimedia.org/T194048) [11:12:17] 10MediaWiki-extensions-Translate: Special:AggregateGroups@metawiki fails to load properly - https://phabricator.wikimedia.org/T201819 (10MarcoAurelio) [11:13:24] 10Mitmachen: Select tutorials for the right-hand column - https://phabricator.wikimedia.org/T198885 (10Christine_Domgoergen_WMDE) Hello everyone, thank you @Cirdan I am happy to support this project and think it can be very useful for new editors! We should display tutorials or videos - or even better specific... [11:16:11] 10Mitmachen: Discuss where users should go for help (footer text) - https://phabricator.wikimedia.org/T199598 (10sonkiki) For both these points: > Where do you send users with questions on the contents of the tutorial? (Unfortunately, the Teestube never took off due to lack of community resources/interest, thi... [11:17:57] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10WMDE-Fisch) >>! In T194613#4497719, @thiemowmde wrote: > I reviewed patch set 6 of the patch https://gerrit.wikimedia.org... [11:18:02] 10Mitmachen: Select tutorials for the right-hand column - https://phabricator.wikimedia.org/T198885 (10sonkiki) Hey @Christine_Domgoergen_WMDE, thx for you input! In this project we use only the materials we already have, it's out of scope to develop something new. But if we have something new in the future, I a... [11:18:10] 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Esanders) a:03Esanders [11:18:28] 10Mitmachen: Revise language, terms and text - https://phabricator.wikimedia.org/T199017 (10Christine_Domgoergen_WMDE) I would suggest renaming the tasks into an active form: Link prüfen instead of ungeprüfter Link so that the user knows what he or she is expected to do. Is this possible? Also it would be nice... [11:18:43] 10MediaWiki-extensions-General, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)): Older skins no longer bold Self links - https://phabricator.wikimedia.org/T192033 (10Aklapper) [11:19:18] 10MediaWiki-General-or-Unknown: Overflowing table on Opera Mini Wikipedia page when browsing with Opera Mini client with Data Savings mode set to Extreme. - https://phabricator.wikimedia.org/T201820 (10mkrawczuk) [11:19:51] 10MediaWiki-General-or-Unknown: Overflowing table on Opera Mini Wikipedia page when browsing with Opera Mini client with Data Savings mode set to Extreme. - https://phabricator.wikimedia.org/T201820 (10mkrawczuk) [11:21:22] 10Mitmachen: Select tutorials for the right-hand column - https://phabricator.wikimedia.org/T198885 (10sonkiki) Since Cirdan is on vacation right now, let's work with these 4 tasks for now: - Belege ergänzen - Link prüfen - Inhalte ergänzen - Überarbeiten I'll check and get back to you if there is som... [11:21:54] 10ContentTranslation, 10Language-2018-July-September: CX2: Show issue cards when they are relevant - https://phabricator.wikimedia.org/T198187 (10Petar.petkovic) >>! In T198187#4497484, @Etonkovidova wrote: > The question is: too much MT content warning is not an error message and it's treated differently? The... [11:22:34] (03CR) 10MarcoAurelio: [C: 032] Escape error messages used in html [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/452331 (owner: 10Umherirrender) [11:22:39] (03CR) 10MarcoAurelio: [C: 032] Add phan-taint-check-plugin [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/451378 (owner: 10Umherirrender) [11:27:59] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Iislucas) Oh, I see, thanks, I was too quick in reading the documentation - when it said that `log_deleted` was comparable to `rev_deleted`, I... [11:31:32] 10MobileFrontend, 10Browser-Support-Opera: Overflowing table on Opera Mini Wikipedia page when browsing with Opera Mini client with Data Savings mode set to Extreme. - https://phabricator.wikimedia.org/T201820 (10Aklapper) [11:32:39] 10Wikimedia-Site-requests, 10Patch-For-Review: Use the correct Pashto Wikivoyage wordmark on mobile site - https://phabricator.wikimedia.org/T200152 (10zeljkofilipin) ``` zfilipin@mwmaint1001:~$ echo "https://en.wikipedia.org/static/images/mobile/copyright/wikipedia-wordmark-ps.png" | mwscript purgeList.php Pu... [11:33:18] 10Mitmachen: Revise language, terms and text - https://phabricator.wikimedia.org/T199017 (10sonkiki) > Also it would be nice, if the link of every task would use the Wartungsbaustein or the unchecked link as an anchor. Like this the user is guided to the specific place where he or she is expected to edit and doe... [11:34:09] (03Merged) 10jenkins-bot: Escape error messages used in html [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/452331 (owner: 10Umherirrender) [11:34:11] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/SubPageList3] - 10https://gerrit.wikimedia.org/r/451378 (owner: 10Umherirrender) [11:36:07] (03PS1) 10Pboehm: Remove "Search by default" in NamespaceManager [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/452346 [11:39:59] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Iislucas) OK, so while I managed to find deletions in recent changes (hurray!), I think, from reading this: https://en.wikipedia.org/wiki/Wikip... [11:44:55] (03CR) 10Mglaser: [C: 032] Add missing GroupPermission registration for right permissionmanager-viewspecialpage T197900 [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/452291 (owner: 10Pwirth) [11:46:23] (03CR) 10Umherirrender: [C: 032] Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [11:48:18] 10Wikimedia-Site-requests, 10Patch-For-Review: Enable translate extension on oldwikisource - https://phabricator.wikimedia.org/T201814 (10zeljkofilipin) ``` zfilipin@mwmaint1001:~$ mwscript extensions/WikimediaMaintenance/createExtensionTables.php sourceswiki translate Creating translate tables...done! ``` [11:48:47] (03Merged) 10jenkins-bot: Add missing GroupPermission registration for right permissionmanager-viewspecialpage T197900 [extensions/BlueSpicePermissionManager] - 10https://gerrit.wikimedia.org/r/452291 (owner: 10Pwirth) [11:56:19] (03Merged) 10jenkins-bot: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [11:58:19] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Readers-Web-Kanbanana-Board: Mobile page issues - instrument page issues - https://phabricator.wikimedia.org/T191532 (10Tbayer) >>! In T191532#4497993, @phuedx wrote: > @Tbayer... [12:01:19] (03PS7) 10Amire80: Move all apihelp translatable messages to separate files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [12:03:20] 10Wikimedia-Site-requests, 10Patch-For-Review: Enable translate extension on oldwikisource - https://phabricator.wikimedia.org/T201814 (10jhsoby) 05Open>03Resolved Thanks @zeljkofilipin , all seems to be in order! [12:05:42] 10Wikimedia-Site-requests, 10Patch-For-Review: Use the correct Pashto Wikivoyage wordmark on mobile site - https://phabricator.wikimedia.org/T200152 (10jhsoby) 05Open>03Resolved All done now, please have a look @Baloch007 ! [12:05:52] 10BlueSpice, 10Patch-For-Review: BlueSpicePermissionManager: missing rights in $wgAvailableRights - https://phabricator.wikimedia.org/T197900 (10Pwirth) 05Open>03Resolved [12:12:12] (03CR) 10jerkins-bot: [V: 04-1] Move all apihelp translatable messages to separate files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [12:18:50] 10Library-Card-Platform: Example data script should set mutually_exclusive for partners with streams. - https://phabricator.wikimedia.org/T201688 (10Samwalton9) a:03Samwalton9 [12:19:26] (03PS8) 10Amire80: Move all apihelp translatable messages to separate files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [12:19:42] 10WMSE-Riksarkivet-TORA: WD: Decide how to connect a "församling" and a "socken" parish - https://phabricator.wikimedia.org/T199893 (10Salgo60) p:05Normal>03Lowest Looks like a minor problem see {T199907} who says a map is enough [12:19:49] (03CR) 10jenkins-bot: Fix indentation [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452338 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [12:21:21] 10WMSE-Riksarkivet-TORA: Speak with Arkiv Digital - https://phabricator.wikimedia.org/T199907 (10Salgo60) [12:21:38] (03CR) 10Thiemo Kreuz (WMDE): "> let's drop this everywhere." [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/449004 (owner: 10Thiemo Kreuz (WMDE)) [12:24:02] 10Readers-Web-Backlog, 10MobileFrontend (MobileFrontend.js), 10Readers-Web-Kanbanana-Board: Introduce webpack config/node-qunit and port ModuleLoader - https://phabricator.wikimedia.org/T199452 (10Niedzielski) a:03Niedzielski [12:39:46] (03CR) 10Anomie: Make SpecialPageFactory a service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [12:41:27] (03CR) 10Amire80: "recheck" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [12:42:07] 10Mitmachen: Signal to the user that search is progressing - https://phabricator.wikimedia.org/T201325 (10Jan_Dittrich) > Quick solution: Display an animated symbol to signal that the tool is indeed working Indeed. A simple spinner might be already helpful. For the stopping ideas: I think, if the user has a... [12:44:08] 10MediaWiki-extensions-Translate: Special:AggregateGroups@metawiki fails to load properly - https://phabricator.wikimedia.org/T201819 (10D3r1ck01) [13:14:46] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452301 (owner: 10L10n-bot) [13:16:07] (03CR) 10Nuria: New: add mw.eventLog.pageviewToken and newPageInteractionToken() (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) (owner: 10Niedzielski) [13:17:30] 10MediaWiki-Interface, 10TechCom: Create a hook like AfterFinalPageOutput with the cacheability of the page - https://phabricator.wikimedia.org/T194396 (10dbarratt) >>! In T194396#4495919, @Krinkle wrote: > This implies there exists logic that obtained information about the current user in a way that was insuf... [13:18:11] 10Design, 10UI-Standardization, 10Revision-Slider, 10Season of RevisionSlider, and 6 others: Replace custom pin icon with OOUI's 'pushPin' - https://phabricator.wikimedia.org/T194613 (10Jayprakash12345) >>! In T194613#4498033, @WMDE-Fisch wrote: > it also looks fine for me. me too [13:18:14] 10WMSE-Riksarkivet-TORA: SOFI new register - https://phabricator.wikimedia.org/T201256 (10Salgo60) [13:21:01] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10Analytics-EventLogging, 10Page-Issue-Warnings, and 6 others: Provide standard/reproducible way to access a PageToken - https://phabricator.wikimedia.org/T201124 (10Niedzielski) > Can someone now document the difference between mw.eventLog.pageviewToken... [13:26:30] 10Wikipedia-Android-App-Backlog: Add Wiktionary branding and/or attribution to "Define" popups - https://phabricator.wikimedia.org/T180868 (10Charlotte) p:05Triage>03Low [13:27:19] (03PS2) 10ItSpiderman: [WIP] Autocomplete improvements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/451855 [13:27:25] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Autocomplete improvements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/451855 (owner: 10ItSpiderman) [13:27:40] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10ArielGlenn) >>! In T147169#4498019, @jcrespo... [13:28:58] 10Android-app-feature-Navigation, 10Epic, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): Remove Explore feed overflow and place options in a side drawer - https://phabricator.wikimedia.org/T197100 (10Charlotte) [13:29:44] (03PS3) 10ItSpiderman: [WIP] Autocomplete improvements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/451855 [13:29:53] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Urbanecm) >>! In T201784#4497347, @Petrb wrote: > It's definitely interesting to see this i... [13:30:10] (03PS4) 10ItSpiderman: Autocomplete improvements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/451855 [13:30:39] 04(no projects): Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) [13:30:58] 10Growth-Team (Current Sprint): [betalabs] AfC - Declined date displayed as the date of the most recent draft update - https://phabricator.wikimedia.org/T201644 (10SBisson) I can reproduce it locally and I see it in the [[ https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/PageTriage/+/442979/11/includes/Ar... [13:32:15] 04(no projects): Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) 1. Update Mediawiki 2. Click on a Category 3. Get Internal Error [13:32:59] 04(no projects): Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) p:05Triage>03Unbreak! [13:34:46] 10ContributionScores: SQL error - https://phabricator.wikimedia.org/T121103 (10Aretni) since i just discovered this bug when trying to use the ContributionScores extension with sqlite, here my findings. ContributionScores_body.php defines the sql that leads to the error, listed above in the original post. sqlit... [13:36:51] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Reedy) >>! In T201829#4498326, @Jidanni wrote: > 1. Update Mediawiki To what version? It works fine on master (50... [13:38:56] (03PS5) 10ItSpiderman: Autocomplete improvements [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/451855 [13:40:29] (03PS1) 10Pwirth: Removed expiry of maintenance user, cause this could end in deadlocks for the user group table [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452362 [13:40:43] (03CR) 10Dbrant: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452301 (owner: 10L10n-bot) [13:41:36] (03PS2) 10Pwirth: Removed expiry of maintenance user, cause this could end in deadlocks for the user group table [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452362 [13:41:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Special:Search doesn't use labels and descriptions for suggestions but just the item ID - https://phabricator.wikimedia.org/T55652 (10Greta_Doci_WMDE) [13:42:46] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Reedy) It looks related to some extension. 667 is ```lang=php $policy = $this->getRobotPolicy( 'view', $pOutput )... [13:43:21] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Reedy) [13:44:18] (03PS5) 10Mglaser: Add KeyValueInputWidget [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/451845 (owner: 10ItSpiderman) [13:44:46] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Make sure Wikibase dump maintenance scripts solely use the "dump" db group - https://phabricator.wikimedia.org/T147169 (10jcrespo) No need to be sorry, could this be... [13:45:59] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Aklapper) @Jidanni: Please always include exact version information in bug reports and structure your tasks. See h... [13:46:31] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Aklapper) p:05Unbreak!>03Triage [13:46:54] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Aklapper) Rsetting priority as per https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_prio... [13:47:18] 10CX-cxserver, 10Language-2018-July-September: CX2: Images missing in source article - https://phabricator.wikimedia.org/T201085 (10KartikMistry) Deployed and verified in Production. Thanks! [13:49:47] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Reedy) None of the code has changed recently... I'm betting it's related to an extension [13:51:10] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, 10WMDE-Design (WMDE-Design-Workboard Doing): find a solution to accept email adresses only - https://phabricator.wikimedia.org/T188516 (10tmletzko) apart from the exact copy, @kai.nissen anything FUN-ops has to do before Fun-Tech puts hand on it? [13:53:08] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Growth-Team (Current Sprint): Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10SBisson) [13:53:24] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-PageCuration, 10Notifications, 10Growth-Team (Current Sprint): Running Echo as dependency of PageTriage fails unit tests - https://phabricator.wikimedia.org/T201812 (10SBisson) a:03SBisson [13:53:37] (03PS1) 10Sbisson: Unset external hooks to test in isolation [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452363 (https://phabricator.wikimedia.org/T201812) [13:55:45] (03PS1) 10Sbisson: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) [13:57:30] (03CR) 10Mglaser: [C: 032] Removed expiry of maintenance user, cause this could end in deadlocks for the user group table [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452362 (owner: 10Pwirth) [13:58:43] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452301 (owner: 10L10n-bot) [14:00:25] (03CR) 10Thcipriani: [C: 032] "Awesome!" [blubber] - 10https://gerrit.wikimedia.org/r/449637 (https://phabricator.wikimedia.org/T200452) (owner: 10Dduvall) [14:00:44] 10Wikipedia-Android-App-Backlog, 10I18n, 10Zuul: Patches submitted by L10n-bot to apps/android/wikipedia ain't checked nor autosubmitted - https://phabricator.wikimedia.org/T201586 (10Nikerabbit) >>! In T201586#4497959, @MarcoAurelio wrote: >>>! In T201586#4497597, @Nikerabbit wrote: >> This is intentional.... [14:00:49] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Bawolff) >>! In T200559#4498083, @Iislucas wrote: > OK, so while I managed to find deletions in recent changes (hurray!), I think, from reading... [14:02:01] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) I commented any extension out of LocalSettings.php. Problem still there. Installed software Product Ver... [14:03:21] (03CR) 10Thcipriani: [V: 032 C: 032] "TIL go vet" [blubber] - 10https://gerrit.wikimedia.org/r/451687 (owner: 10Dduvall) [14:03:47] 10MediaWiki-Interface, 10TechCom: Create a hook like AfterFinalPageOutput with the cacheability of the page - https://phabricator.wikimedia.org/T194396 (10Krinkle) >>! In T194396#4498276, @dbarratt wrote: > Do anonymous users have sessions? Yes, they can. Most write actions start a session, including when ano... [14:04:48] (03CR) 10Mglaser: [C: 032] Add KeyValueInputWidget (031 comment) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/451845 (owner: 10ItSpiderman) [14:05:03] (03CR) 10Thcipriani: Test Blubber in CI using Blubber [blubber] - 10https://gerrit.wikimedia.org/r/449637 (https://phabricator.wikimedia.org/T200452) (owner: 10Dduvall) [14:05:11] (03CR) 10Thcipriani: [C: 032] Test Blubber in CI using Blubber [blubber] - 10https://gerrit.wikimedia.org/r/449637 (https://phabricator.wikimedia.org/T200452) (owner: 10Dduvall) [14:05:59] 10MediaWiki-Interface, 10TechCom: Create a hook like AfterFinalPageOutput with the cacheability of the page - https://phabricator.wikimedia.org/T194396 (10dbarratt) @Krinkle oh. that's fascinating. Is there a standard way to determine if the user has a session? [14:06:28] (03Merged) 10jenkins-bot: Removed expiry of maintenance user, cause this could end in deadlocks for the user group table [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452362 (owner: 10Pwirth) [14:07:22] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Reedy) From what I can see, only extensions would cause this... ```lang=php, lines=25 while ( !$outputDone && +... [14:10:07] 10MediaWiki-Interface, 10TechCom: Create a hook like AfterFinalPageOutput with the cacheability of the page - https://phabricator.wikimedia.org/T194396 (10Krinkle) Yes. I believe it is now under `Session::isPersistent` as part of SessionManager – used in `OutputPage::sendCacheControl`. [14:11:45] (03PS4) 10Niedzielski: New: add mw.eventLog.pageviewToken and newPageInteractionToken() [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) [14:12:16] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) Oops. I see. I can no longer use this in LocalSettings: ``` function JidanniDontInviteEdit(&$article,&$... [14:12:41] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) 05Open>03Invalid [14:13:07] (03PS5) 10Niedzielski: New: add mw.eventLog.pageviewToken and newPageInteractionToken() [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) [14:15:20] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) I don't think there is much chance I would be able to figure out how to make my function work again. [14:15:31] 10InternetArchiveBot (v2.0): Both "Page modified: No" and "Modifications made" can't be true - https://phabricator.wikimedia.org/T201840 (10Josve05a) a:03Cyberpower678 [14:15:34] (03Merged) 10jenkins-bot: Add KeyValueInputWidget [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/451845 (owner: 10ItSpiderman) [14:17:16] 10MediaWiki-General-or-Unknown: Article.php: Argument 2 passed to Article::getRobotPolicy() must be an instance of ParserOutput or null, boolean given, - https://phabricator.wikimedia.org/T201829 (10Jidanni) On my wiki users are not supposed to mistakenly edit categories. [14:18:08] 10MediaWiki-User-management, 10Trust-and-Safety, 10Anti-Harassment (AHT Sprint 21/22), 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)), 10Patch-For-Review: Add cookie when blocking anonymous users - https://phabricator.wikimedia.org/T152462 (10dbarratt) @dmaza In hindsight, we should have... [14:19:19] (03PS2) 10Lucas Werkmeister (WMDE): data-values/geo (2.1.1 => 3.0.1) [vendor] - 10https://gerrit.wikimedia.org/r/450047 (owner: 10Addshore) [14:19:35] (03CR) 10Niedzielski: "> Would be good to clarify whether or not the Popups use case is meant to use this, and if so, whether (per @TBayer on the task) whether i" (032 comments) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/451885 (https://phabricator.wikimedia.org/T201124) (owner: 10Niedzielski) [14:20:16] (03CR) 10jerkins-bot: [V: 04-1] data-values/geo (2.1.1 => 3.0.1) [vendor] - 10https://gerrit.wikimedia.org/r/450047 (owner: 10Addshore) [14:23:47] (03PS3) 10Lucas Werkmeister (WMDE): data-values/geo (2.1.1 => 3.0.1) [vendor] - 10https://gerrit.wikimedia.org/r/450047 (owner: 10Addshore) [14:25:02] (03CR) 10Lucas Werkmeister (WMDE): "I’ve tried to fix the unrelated changes (though I’m not sure I have the latest version either – I applied `git add -p` liberally), please " [vendor] - 10https://gerrit.wikimedia.org/r/450047 (owner: 10Addshore) [14:27:36] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Iislucas) Thanks, ok digging into code... ! So, reading the code: https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/master/inclu... [14:29:29] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Pluto is still a planet: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (10Pcoombe) @AndyRussG This just happened again for me with https://en.wikipedia.org/wiki/Bricolage?banner=spatton_d... [14:30:35] (03PS1) 10Jdrewniak: Disable edit icon in read-only mode [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) [14:34:10] (03CR) 10Pablo Grass (WMDE): selenium: invoke jobs to enforce eventual consistency (031 comment) [core] - 10https://gerrit.wikimedia.org/r/446543 (https://phabricator.wikimedia.org/T199446) (owner: 10Pablo Grass (WMDE)) [14:34:47] 10MediaWiki-extensions-WikimediaEvents, 10Analytics, 10Analytics-EventLogging, 10Page-Issue-Warnings, and 6 others: Provide standard/reproducible way to access a PageToken - https://phabricator.wikimedia.org/T201124 (10Niedzielski) @tbayer, the following came up in @Krinkle's code review and I was hoping t... [14:35:38] 10MediaWiki-Codesniffer, 10MediaWiki-extensions-Variables, 10Patch-For-Review: Add MediaWiki Codesniffer to Variables extension - https://phabricator.wikimedia.org/T191811 (10MGChecker) This task is now waiting for review. [14:44:10] (03CR) 10Umherirrender: [C: 032] Make use of the …::class feature instead of string copies [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/452317 (owner: 10Thiemo Kreuz (WMDE)) [14:46:58] 10MobileFrontend, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2): Use ContentHandler to obtain DifferenceEngine in MobileFrontend - https://phabricator.wikimedia.org/T201842 (10Tgr) [14:48:50] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Looks good for me. I can't say much about the longer comments this patch adds, that's why I leave this open for somebody more familiar wit" (032 comments) [extensions/Variables] - 10https://gerrit.wikimedia.org/r/451533 (https://phabricator.wikimedia.org/T191811) (owner: 10MGChecker) [14:49:04] (03CR) 10GeorgeBarnick: "Search box looks a bit out of alignment in this change but other than that it checks out good. I've added these changes into our test envi" [skins/Refreshed] (refreshed4-beta) - 10https://gerrit.wikimedia.org/r/452285 (owner: 10MtMNC) [14:50:35] (03Merged) 10jenkins-bot: Make use of the …::class feature instead of string copies [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/452317 (owner: 10Thiemo Kreuz (WMDE)) [14:51:58] 10TimedMediaHandler, 10Technical-Debt: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled - https://phabricator.wikimedia.org/T201843 (10Niedzielski) [14:54:12] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Variables: Create a Scribunto interface - https://phabricator.wikimedia.org/T201171 (10MGChecker) >>! In T201171#4490693, @Litzsch wrote: >> I think there should be something like `local vars = mw.ext.Variables.vars` needed before? > Yes, that would be n... [14:54:35] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Build full-screen Notifications activity. - https://phabricator.wikimedia.org/T201427 (10Dbrant) a:03Dbrant [14:54:55] (03PS1) 10Pwirth: Fixed missing not in comparison in ListValue filter [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452386 [14:55:00] (03PS1) 10Dbrant: [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) [14:55:13] (03CR) 10jenkins-bot: Make use of the …::class feature instead of string copies [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/452317 (owner: 10Thiemo Kreuz (WMDE)) [14:55:39] (03PS2) 10Pwirth: Fixed missing not in comparison in ListValue filter [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452386 [14:55:45] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, and 2 others: Display information on bank account data of WMFG - https://phabricator.wikimedia.org/T188489 (10kai.nissen) @tmletzko No objections. [14:58:37] (03CR) 10jerkins-bot: [V: 04-1] [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) (owner: 10Dbrant) [14:59:07] 10MediaWiki-Vagrant, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found - https://phabricator.wikimedia.org/T201615 (10WMDE-leszek) I tried to figure out what could have happened wrong here, but I am actually not sure. both wikibase_... [14:59:11] (03PS3) 10Umherirrender: Replace HTMLTextBlockField by HTMLInfoField [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/451344 [14:59:19] (03PS10) 10Pwirth: Refactoring to BS3 architecture ERM:10378, ERM:9862, ERM:10376 [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/451393 [14:59:22] (03CR) 10Umherirrender: "Rebased" [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/451344 (owner: 10Umherirrender) [15:01:47] (03CR) 10Umherirrender: "interwiki are not the same across installs, so I would keep the external links and not use interwiki links here. That should not a blocker" [core] - 10https://gerrit.wikimedia.org/r/452336 (owner: 10D3r1ck01) [15:01:54] (03CR) 10Thiemo Kreuz (WMDE): "Thanks for the rebase!" (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/451344 (owner: 10Umherirrender) [15:03:20] (03PS9) 10Umherirrender: Move all apihelp translatable messages to separate files [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [15:03:24] 10MediaWiki-History-or-Diffs, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2), 10Regression: Viewing page's first revision via diff gives error - https://phabricator.wikimedia.org/T201218 (10Tgr) [15:03:38] (03CR) 10Umherirrender: [C: 031] "Added folder to banana" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/420371 (https://phabricator.wikimedia.org/T189982) (owner: 10Jayprakash12345) [15:06:38] 04(no projects): [Variables] Allow fallback/default values for `#vardefine`/`#vardefineecho` - https://phabricator.wikimedia.org/T201846 (10Dinoguy1000) [15:06:43] 10FormWizard, 10Security-Reviews: Security review for FormWizard extension - https://phabricator.wikimedia.org/T201492 (10Eugene233) [15:06:47] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Petar.petkovic) [15:06:55] 10MediaWiki-extensions-Variables: [Variables] Allow fallback/default values for `#vardefine`/`#vardefineecho` - https://phabricator.wikimedia.org/T201846 (10Dinoguy1000) [15:07:18] 10Browser-Support-Firefox: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Lockethot) [15:07:23] 10MediaWiki-extensions-Variables: [Variables] Allow fallback/default values for #vardefine / #vardefineecho - https://phabricator.wikimedia.org/T201846 (10Dinoguy1000) [15:08:08] (03CR) 10Jdrewniak: "recheck" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452380 (https://phabricator.wikimedia.org/T197497) (owner: 10Jdrewniak) [15:09:35] 10Repository-Ownership-Requests: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10MGChecker) As I stated before, if I got these rights, I would use them to merge patches I can judge with my knowledge of the parser and similar extensions.... [15:10:38] 10MediaWiki-extensions-ContactPage: Facilitate sending to an arbitrary email address - https://phabricator.wikimedia.org/T201764 (10ahmad) By "arbitary address" I meant one set by the form administrator, instead of having to be that of a wikiuser account as currently is the case. Not one entered by the form user... [15:12:41] 10MediaWiki-extensions-ContactPage: Facilitate sending to an arbitrary email address - https://phabricator.wikimedia.org/T201764 (10Reedy) >>! In T201764#4498765, @ahmad wrote: > By "arbitary address" I meant one set by the form administrator, instead of having to be that of a wikiuser account as currently is th... [15:13:04] 10MediaWiki-extensions-ContactPage: Facilitate sending to an arbitrary email address rather than a user account - https://phabricator.wikimedia.org/T201764 (10Reedy) [15:14:27] 10MediaWiki-extensions-Widgets: Convert Widgets to use extension registration - https://phabricator.wikimedia.org/T191721 (10MGChecker) If you are interested: I think I will be able to write a patch for this in a week. However, if someone else wants to try, please, I'll happy to review a given patch as well. [15:15:47] 10MediaWiki-extensions-Widgets: Widget Namespace gets included in Search - https://phabricator.wikimedia.org/T135260 (10MGChecker) @Lommes Can you still reproduce this error? Otherwise, this task should be closed as invalid. [15:17:24] 10MediaWiki-History-or-Diffs, 10Multi-Content-Revisions (MCR Deployment): Make DifferenceEngine callers pass revisions, not contents - https://phabricator.wikimedia.org/T201848 (10Tgr) [15:17:58] 10MediaWiki-extensions-ContactPage: Facilitate sending to an arbitrary email address rather than a user account - https://phabricator.wikimedia.org/T201764 (10ahmad) >>>! In T201764#4498765, @ahmad wrote: >> But there's also the usecase of having a workflow for handling received form submissions by one or more p... [15:19:09] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog, 10Fundraising Sprint Pluto is still a planet: Banner previews occasionally fail to load - https://phabricator.wikimedia.org/T200853 (10AndyRussG) Fantastic, thanks @Pcoombe!!! [15:20:14] 10Browser-Support-Firefox: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Lockethot) Hey and another note... I tried to talk to developers on #WIkipedia IRC. Never joined it before, but I was banned automatically. Could use help with this, thanks! [15:21:25] 10MobileFrontend, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2): Use ContentHandler to obtain DifferenceEngine in MobileFrontend - https://phabricator.wikimedia.org/T201842 (10Tgr) This is not really an MCR problem (trying to show mobile diffs of Wikidata edits has the same issue) but will... [15:21:59] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Lockethot) [15:22:24] 10MediaWiki-extensions-ContactPage: Facilitate sending to an arbitrary email address rather than a user account - https://phabricator.wikimedia.org/T201764 (10Reedy) Yeah, "dummy" accounts are used. Often with an appropriate name/username, so the leaking you were mentioning is less of a problem [15:22:43] 10WMSE-Riksarkivet-TORA: Fornsök future/framtid - email webb@raa.se (borde varit registrator@raa.se) - https://phabricator.wikimedia.org/T200253 (10Salgo60) Asked at Anbytarforum if someone else heard anything [[ https://forum.genealogi.se/index.php?topic=154606.msg1475645#msg1475645 | link ]] [15:23:52] (03PS1) 10Pwirth: Fix "Undefined offset" notice [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452395 [15:24:44] (03CR) 10Krinkle: Use "false" as type hint in PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 (owner: 10Thiemo Kreuz (WMDE)) [15:24:46] (03PS2) 10Pwirth: Fix "Undefined offset" notice [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452395 [15:30:57] (03CR) 10Krinkle: "This change in particular seems fine, but it is worth noting that edit summary formatting and wikitext parsing are meant to be separate an" [core] - 10https://gerrit.wikimedia.org/r/442043 (owner: 10Thiemo Kreuz (WMDE)) [15:31:00] 10MobileFrontend, 10Readers-Web-Backlog, 10Browser-Support-Opera: Overflowing table on Opera Mini Wikipedia page when browsing with Opera Mini client with Data Savings mode set to Extreme. - https://phabricator.wikimedia.org/T201820 (10nray) [15:31:19] (03PS2) 10Thiemo Kreuz (WMDE): Use "false" as type hint in PHPDoc tags [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452313 [15:31:32] (03PS2) 10Pboehm: Remove "Search by default" in NamespaceManager [extensions/BlueSpiceNamespaceManager] - 10https://gerrit.wikimedia.org/r/452346 [15:32:57] (03CR) 10Krinkle: Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [15:33:48] (03CR) 10Krinkle: Fix missing/mismatching type hints PHPDoc tags (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452314 (owner: 10Thiemo Kreuz (WMDE)) [15:33:58] (03CR) 10Krinkle: [C: 031] Add missing strict "array" type hints to DiscussionParser [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452311 (owner: 10Thiemo Kreuz (WMDE)) [15:34:08] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Don't use freegeoip service by default anymore - https://phabricator.wikimedia.org/T201753 (10DStrine) [15:34:21] 10MobileFrontend, 10Readers-Web-Backlog, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2): Use ContentHandler to obtain DifferenceEngine in MobileFrontend - https://phabricator.wikimedia.org/T201842 (10nray) [15:34:58] 10MobileFrontend, 10Readers-Web-Backlog, 10Documentation, 10Epic, and 5 others: [MobileFrontend] Replace JSDuck with JSDoc - https://phabricator.wikimedia.org/T188261 (10Niedzielski) @jdlrobson, thanks! I've rebased the patch. [15:36:21] 10MediaWiki-Vagrant, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wikibase on Vagrant: Class 'Wikibase\DataModel\Entity\ItemId' not found - https://phabricator.wikimedia.org/T201615 (10Tgr) Vagrant throws this every time it tries to do something with MediaWiki (that is, run some maintenance script)... [15:40:29] (03PS2) 10Brion VIBBER: Update ogv.js to 1.5.8 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/451564 [15:41:00] 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10nray) >>! In T197110#4489154, @Jdlrobson wrote: > I'll follow up with @Niedzielski to make sure this task is well defined/scoped and... [15:49:25] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Convert WikibaseClient, WikibaseLib and WikibaseRepository to use extension registration - https://phabricator.wikimedia.org/T88258 (10WMDE-leszek) also related T201615 [15:51:45] 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Wikipedia-android-strings-events count text/ja]] translation issue - https://phabricator.wikimedia.org/T201851 (10Takot) [15:52:49] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Reedy) [15:53:05] 10Wikimedia-General-or-Unknown, 10I18n: [[Wikimedia:Wikipedia-android-strings-events count text/ja]] translation issue - https://phabricator.wikimedia.org/T201851 (10Takot) [15:53:59] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10I18n: [[Wikimedia:Wikipedia-android-strings-events count text/ja]] translation issue - https://phabricator.wikimedia.org/T201851 (10Liuxinyu970226) [15:54:06] 10Wikimedia-Site-requests: Support at least one editable open slides format on Commons - https://phabricator.wikimedia.org/T200187 (10Bawolff) >>! In T200187#4444907, @Reedy wrote: > The problem is highlighted here... https://github.com/wikimedia/mediawiki/blob/master/includes/DefaultSettings.php#L923-L930 > >... [15:54:13] 10MediaWiki-General-or-Unknown, 10Front-end-Standards-Group, 10Security-Team, 10Security, 10WorkType-NewFunctionality: Content Security Policy (CSP) - https://phabricator.wikimedia.org/T28508 (10Bawolff) >>! In T28508#4212646, @Nirmos wrote: > Will I as a gadget author have access to the violation report... [15:55:36] 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Esanders) >>! In T201538#4496763, @DLynch wrote: > I've been using vagrant as my dev environment for years now, and the most common issue with it is preserving continuity. If I'm... [15:55:39] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Aklapper) @Lockethot: Can you please attach a screenshot of the problem, and/or tell us your screen width plus browser zoom level? [15:56:21] 10MinervaNeue, 10Page-Issue-Warnings, 10Readers-Web-Backlog: [Bug] Page issues sometimes reopens dialog - https://phabricator.wikimedia.org/T201852 (10Niedzielski) [15:57:09] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever - https://phabricator.wikimedia.org/T193172 (10alexholl... [15:58:04] 10TimedMediaHandler-Player, 10Technical-Debt: TimedMediaHandler has verbose output when ResourceLoader debugging is enabled - https://phabricator.wikimedia.org/T201843 (10brion) [16:03:00] 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Deskana) When I was on the search team, we used test instances all the time for testing things that were really difficult to test in production, such as features that required a... [16:04:53] 10MobileFrontend, 10Readers-Web-Backlog, 10Multi-Content-Revisions (MCR-SDC File Caption Support - phase 2): Use ContentHandler to obtain DifferenceEngine in MobileFrontend - https://phabricator.wikimedia.org/T201842 (10CCicalese_WMF) [16:05:56] (03PS22) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [16:06:23] (03CR) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. (039 comments) [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [16:06:26] (03CR) 10MGChecker: "The longer comments I added just describe the behavior of the parser function also documented on." [extensions/Variables] - 10https://gerrit.wikimedia.org/r/451533 (https://phabricator.wikimedia.org/T191811) (owner: 10MGChecker) [16:08:10] (03CR) 10Brion VIBBER: [C: 032] Update ogv.js to 1.5.8 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/451564 (owner: 10Brion VIBBER) [16:10:46] (03PS5) 10MGChecker: Add and run MediaWiki-Codesniffer [extensions/Variables] - 10https://gerrit.wikimedia.org/r/451533 (https://phabricator.wikimedia.org/T191811) [16:12:37] (03PS2) 10Dbrant: [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) [16:13:42] 10WMF-Communications, 10wikimediafoundation.org: Launch of new Wikimedia Foundation website (Tracking task) - https://phabricator.wikimedia.org/T188774 (10Varnent) [16:14:41] (03PS1) 10Krinkle: benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 [16:15:09] 10ContentTranslation: CX2: Sections aren't keyboard navigable - https://phabricator.wikimedia.org/T199687 (10Petar.petkovic) 05Open>03Resolved a:03Petar.petkovic Navigating through sections using keyboard arrows is now possible. [16:15:48] 10MediaWiki-User-management, 10Anti-Harassment: Allow users to be blocked from creating a specific page (e.g. redlink blocking) - https://phabricator.wikimedia.org/T201853 (10TBolliger) [16:18:24] (03CR) 10Krinkle: [C: 032] Call overrideMwServices() in TitlePermissionTest [core] - 10https://gerrit.wikimedia.org/r/452279 (https://phabricator.wikimedia.org/T201776) (owner: 10Legoktm) [16:18:37] (03CR) 10Umherirrender: Replace HTMLTextBlockField by HTMLInfoField (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/451344 (owner: 10Umherirrender) [16:20:15] 10Phabricator, 10Release-Engineering-Team (Kanban): Unable to log in to Phabricator via MediaWiki on mobile (CSP error) - https://phabricator.wikimedia.org/T201460 (10mmodell) [16:21:55] 10Phabricator, 10Release-Engineering-Team (Kanban): Unable to log in to Phabricator via MediaWiki on mobile (CSP error) - https://phabricator.wikimedia.org/T201460 (10mmodell) @jhsoby: Can you test and let me know if this is still a problem? [16:22:55] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Truncate page issues - https://phabricator.wikimedia.org/T197931 (10alexhollender) [16:23:09] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Lockethot) Here is a snip: {F24899936} My screen has a strange aspect ratio. Resolution is 2560x1080, aspect is 21:9. Perhaps this is one of the reasons for this issue, good poin... [16:23:24] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Truncate page issues - https://phabricator.wikimedia.org/T197931 (10alexhollender) 👍 moving right along [16:24:44] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), and 2 others: Truncate page issues - https://phabricator.wikimedia.org/T197931 (10alexhollender) a:05alexhollender>03Ryasmeen [16:25:10] 10MediaWiki-User-management, 10Anti-Harassment: Allow users to be blocked from creating a specific page (e.g. redlink blocking) - https://phabricator.wikimedia.org/T201853 (10dbarratt) @TBolliger Do we have any idea how many admins are looking for this feature? [16:25:50] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, and 2 others: Display information on bank account data of WMFG - https://phabricator.wikimedia.org/T188489 (10tmletzko) wonderful. I take this as an "I will put it on the list and add it to the repository for the upcoming test." [16:26:25] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Lockethot) [16:26:43] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Bug: Order of some paragraphs is flipped on mobile - https://phabricator.wikimedia.org/T201131 (10alexhollender) Unable to reproduce. Passing along... [16:27:17] 10Audiences-QA, 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), and 2 others: Bug: Order of some paragraphs is flipped on mobile - https://phabricator.wikimedia.org/T201131 (10alexhollender) a:05alexhollender>03Ryasmeen [16:28:06] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/451380 [16:28:08] 10MediaWiki-User-management, 10Anti-Harassment: Allow users to be blocked from creating a specific page (e.g. redlink blocking) - https://phabricator.wikimedia.org/T201853 (10TBolliger) p:05Triage>03Low It was recently raised on Meta: https://meta.wikimedia.org/wiki/Talk:Community_health_initiative/Per-use... [16:28:12] (03CR) 10Umherirrender: "check experimental" [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/451380 (owner: 10Umherirrender) [16:28:14] 10Design, 10Design-Research, 10VisualEditor (Current work): Identify what heuristics we will be evaluating - https://phabricator.wikimedia.org/T201549 (10iamjessklein) I'm at a good place in drafting this document to start getting feedback. I'd love feedback on the [[ https://docs.google.com/document/d/1dO... [16:29:08] (03CR) 10Dduvall: [C: 032] Test Blubber in CI using Blubber [blubber] - 10https://gerrit.wikimedia.org/r/449637 (https://phabricator.wikimedia.org/T200452) (owner: 10Dduvall) [16:29:47] (03Merged) 10jenkins-bot: Test Blubber in CI using Blubber [blubber] - 10https://gerrit.wikimedia.org/r/449637 (https://phabricator.wikimedia.org/T200452) (owner: 10Dduvall) [16:29:58] (03Abandoned) 10Gergő Tisza: [WIP][MCR] Show diffs for all slots [core] - 10https://gerrit.wikimedia.org/r/441925 (https://phabricator.wikimedia.org/T194731) (owner: 10Gergő Tisza) [16:31:50] 10Accessibility, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), and 4 others: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility - https://phabricator.wikimedia.org/T198947 (10alexhollender... [16:33:48] (03Merged) 10jenkins-bot: Update ogv.js to 1.5.8 release [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/451564 (owner: 10Brion VIBBER) [16:33:53] 10MediaWiki-User-management, 10Anti-Harassment: Allow users to be blocked from creating a specific page (e.g. redlink blocking) - https://phabricator.wikimedia.org/T201853 (10dbarratt) >>! In T201853#4499045, @TBolliger wrote: > This may be an insurmountable blocker for database reasons. Nothing is insurmoun... [16:34:10] (03PS2) 10Lucas Werkmeister (WMDE): Update data-values/geo to 2.1.2 [vendor] - 10https://gerrit.wikimedia.org/r/449737 (https://phabricator.wikimedia.org/T173026) [16:34:11] 10Accessibility, 10Audiences-QA, 10MinervaNeue, 10Readers-Web-Backlog, and 5 others: There should not be multiple h1 tags on mobile page HTML: Restructure mobile web header for SEO and accessibility - https://phabricator.wikimedia.org/T198947 (10alexhollender) a:05alexhollender>03Ryasmeen [16:34:48] (03PS1) 10Gergő Tisza: Use GetDifferenceEngine to inject InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452413 (https://phabricator.wikimedia.org/T201842) [16:37:40] (03PS4) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 [16:37:45] (03PS5) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 [16:38:43] (03CR) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [16:39:35] (03CR) 10jerkins-bot: [V: 04-1] benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 (owner: 10Krinkle) [16:40:18] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Petrb) >>! In T201784#4498305, @Urbanecm wrote: >>>! In T201784#4497347, @Petrb wrote: >> I... [16:40:48] (03PS1) 10Umherirrender: Escape error messages used as html [extensions/RSS] - 10https://gerrit.wikimedia.org/r/452417 [16:45:02] (03Merged) 10jenkins-bot: Call overrideMwServices() in TitlePermissionTest [core] - 10https://gerrit.wikimedia.org/r/452279 (https://phabricator.wikimedia.org/T201776) (owner: 10Legoktm) [16:45:24] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Refresh the Explore feed after logged in - https://phabricator.wikimedia.org/T196004 (10Charlotte) [16:45:51] (03PS2) 10Krinkle: benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 [16:46:52] (03CR) 10Jforrester: [C: 032] Don't use deprecated MagicWord methods [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452284 (owner: 10Legoktm) [16:47:08] 10Research-Programs, 10Epic: [Objective 11.1.1] Research on citation/source quality - https://phabricator.wikimedia.org/T171230 (10Capt_Swing) [16:47:59] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team, 10MW-1.29-release: Formalise and Announce REL1_29 EOL - https://phabricator.wikimedia.org/T197669 (10thcipriani) p:05Triage>03Normal This is something #together generally does, but this is another in the long list of tasks @demon used to quietly... [16:48:07] (03CR) 10Jforrester: [C: 032] Upgrade wikimedia/xmp-reader to 0.6.0 [core] - 10https://gerrit.wikimedia.org/r/452341 (owner: 10Legoktm) [16:48:09] (03CR) 10Jforrester: [C: 032] Upgrade wikimedia/xmp-reader to 0.6.0 [vendor] - 10https://gerrit.wikimedia.org/r/452339 (owner: 10Legoktm) [16:48:24] 10MediaWiki-General-or-Unknown, 10MW-1.29-release, 10Release-Engineering-Team (Next): Formalise and Announce REL1_29 EOL - https://phabricator.wikimedia.org/T197669 (10thcipriani) [16:48:32] (03CR) 10jenkins-bot: Call overrideMwServices() in TitlePermissionTest [core] - 10https://gerrit.wikimedia.org/r/452279 (https://phabricator.wikimedia.org/T201776) (owner: 10Legoktm) [16:49:02] 10MediaWiki-User-management, 10Anti-Harassment: Allow users to be blocked from creating a specific page (e.g. redlink blocking) - https://phabricator.wikimedia.org/T201853 (10TBolliger) I love your optimism. :) Let me rephrase: "The prioritization of this task will rely on the technical estimation. If this re... [16:51:06] 10MediaWiki-Internationalization, 10I18n, 10User-MarcoAurelio: Add MessagesSco.php - https://phabricator.wikimedia.org/T201462 (10AmaryllisGardener) I'm not sure I know the translations for some of these, but I do know that "User" needs to be "Uiser". [16:52:43] 10Wikipedia-Android-App-Backlog, 10Reading Epics (Synchronized Reading Lists): Show a message to users about sync the first 3 time(s) they add an article to a reading list - https://phabricator.wikimedia.org/T188404 (10Charlotte) [16:54:23] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Show a message to users about sync the first 3 time(s) they add an article to a reading list - https://phabricator.wikimedia.org/T188404 (10Charlotte) [16:55:20] 10MediaWiki-General-or-Unknown, 10Easy, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10User-Zoranzoki21: Fix common typos in code - https://phabricator.wikimedia.org/T201491 (10Petar.petkovic) [16:58:10] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Readers-Web-Kanbanana-Board: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens - https://phabricator.wikimedia.org/T200518 (10alexhollender) {F2490... [16:58:22] 10Design, 10Design-Research, 10VisualEditor (Current work): Identify what heuristics (principles) we will be evaluating against - https://phabricator.wikimedia.org/T201549 (10iamjessklein) [16:58:26] 10MediaWiki-General-or-Unknown, 10Release-Engineering-Team, 10Scap, 10Wikimedia-Incident: Detect missing extension dependencies before production - https://phabricator.wikimedia.org/T200944 (10thcipriani) p:05Triage>03Normal [16:58:38] 10Audiences-QA, 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-07 (1.32.0-wmf.16)), 10Readers-Web-Kanbanana-Board: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens - https://phabricator.wikimedia.org/T200518 (10alex... [16:59:45] 10MediaWiki-General-or-Unknown, 10Scap, 10Release-Engineering-Team (Someday), 10Wikimedia-Incident: Detect missing extension dependencies before production - https://phabricator.wikimedia.org/T200944 (10thcipriani) [17:01:42] wikimedia/mediawiki#21716 (master - 5965377 jenkins-bot): The build failed. - https://travis-ci.org/wikimedia/mediawiki/builds/415538025 [17:02:15] 10MediaWiki-Maintenance-scripts, 10Dumps-Generation, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: wikidata dumps broken with 'unexpected option: --full!' for revision history content dumps - https://phabricator.wikimedia.org/T201803 (10ArielGlenn) 05Open>03Resolve... [17:02:56] 10Design, 10Design-Research, 10VisualEditor (Current work): Identify what heuristics (principles) we will be evaluating against - https://phabricator.wikimedia.org/T201549 (10Amire80) [17:03:42] 10Anti-Harassment (AHT Sprint 26): Update block logs with partial block details - https://phabricator.wikimedia.org/T197108 (10dmaza) @dbarratt you are right.. I'll start on T197117 first. [17:09:04] (03Merged) 10jenkins-bot: Don't use deprecated MagicWord methods [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452284 (owner: 10Legoktm) [17:09:49] 10Anti-Harassment (AHT Sprint 26), 10Patch-For-Review: Enforce Partial Blocks from Database and Update Block Notices - https://phabricator.wikimedia.org/T197117 (10dmaza) a:03dmaza [17:11:31] (03PS1) 10Petar.petkovic: Fix some of the common typos [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) [17:11:57] 10MobileFrontend, 10Readers-Web-Backlog, 10Easy, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Jdrewniak) a:03Jdrewniak [17:12:10] 10I18n: [[MediaWiki:Ipboptions/mni]] translation issue - https://phabricator.wikimedia.org/T201854 (10Awangba_Mangang) [17:13:08] wikimedia/mediawiki#21716 (master - 5965377 jenkins-bot): The build failed. - https://travis-ci.org/wikimedia/mediawiki/builds/415538025 [17:13:44] (03Merged) 10jenkins-bot: Upgrade wikimedia/xmp-reader to 0.6.0 [vendor] - 10https://gerrit.wikimedia.org/r/452339 (owner: 10Legoktm) [17:13:46] 10Android-app-Bugs, 10Chinese-Sites, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Showing incorrect cache contents when switching Chinese variants - https://phabricator.wikimedia.org/T191550 (10Charlotte) [17:14:11] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: "No results found" message not visible when keyboard active when triggered from the **Article** view - https://phabricator.wikimedia.org/T166151 (10Charlotte) [17:14:18] wikimedia/mediawiki#21716 (master - 5965377 jenkins-bot): The build failed. - https://travis-ci.org/wikimedia/mediawiki/builds/415538025 [17:14:33] 10Patch-For-Review, 10Technical-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Replace Otto event bus - https://phabricator.wikimedia.org/T166903 (10Charlotte) [17:14:56] 04(no projects): onboarding Effie Mouzeli - https://phabricator.wikimedia.org/T201855 (10Dzahn) [17:15:00] 10Android-app-feature-Offline, 10Android-app-feature-UX-Debt, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): UX-enhancement - when there is no connectivity, disable articles list items that are not available offline - https://phabricator.wikimedia.org/T158852 (10Charlotte) [17:15:10] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:15:30] 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Move to GitHub. - https://phabricator.wikimedia.org/T191642 (10Charlotte) [17:15:39] (03PS3) 10Dbrant: Update/replace wikimediafoundation.org URLs. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/450587 (https://phabricator.wikimedia.org/T201212) [17:16:24] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a download on WiFi only setting for reading list users - https://phabricator.wikimedia.org/T193027 (10Charlotte) [17:16:40] 04(no projects): onboarding Effie Mouzeli - https://phabricator.wikimedia.org/T201855 (10Dzahn) [17:16:44] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: renamed this task from [BUG] Editing view has incorrect styling - https://phabricator.wikimedia.org/T195608 (10Charlotte) [17:17:01] 10Patch-For-Review, 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a setting to disable auto-downloading reading list articles - https://phabricator.wikimedia.org/T193492 (10Charlotte) [17:17:16] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Show complete license info for images shown in full screen - https://phabricator.wikimedia.org/T164957 (10Charlotte) [17:18:07] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review, 10Regression: [BUG] [REGRESSION] Incorrect font styling on text-fields in the reading list name and description dialog - https://phabricator.wikimedia.org/T201030 (10Charlotte) [17:18:20] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever - https://phabricator.wikimedia.org/T193172 (10alexholl... [17:18:24] 10Android-app-feature-UX-Debt, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Improve the ease of viewing individual citations references grouped together - https://phabricator.wikimedia.org/T172283 (10Charlotte) [17:19:10] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Regression: Edit buttons appear for non-editable sections - https://phabricator.wikimedia.org/T198088 (10Charlotte) [17:19:14] 10Audiences-QA, 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), and 2 others: [Bug] Visiting a missing image or connection dropping causes the ImageOverlay to load forever - https://phabricator.wikimedia.org/T193172 (10alexhollender) a:05alexhollen... [17:19:30] 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): Add a toast notifying users when a manual sync is completed - https://phabricator.wikimedia.org/T197620 (10Charlotte) [17:20:21] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [BUG] Onboarding language add/edit button hidden on 4" devices - https://phabricator.wikimedia.org/T198263 (10Charlotte) [17:20:39] 10Android-app-Bugs, 10Patch-For-Review, 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.26x-K-Krispy-Kreme): [BUG] Invisible texts in Popup Dialog in Dark Mode - https://phabricator.wikimedia.org/T177129 (10Charlotte) [17:21:48] (03Merged) 10jenkins-bot: Upgrade wikimedia/xmp-reader to 0.6.0 [core] - 10https://gerrit.wikimedia.org/r/452341 (owner: 10Legoktm) [17:22:04] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Bad newline after return statement by JavaScript minifier - https://phabricator.wikimedia.org/T201606 (10Krinkle) >>! In T201606#4497334, @gerritbot wrote: > [mediawiki/core@... [17:22:16] 10I18n: [[MediaWiki:Ipboptions/mni]] translation issue - https://phabricator.wikimedia.org/T201854 (10Awangba_Mangang) In our languages such as * 1 Day = ꯅꯨꯃꯤꯠ ꯱ or ꯅꯣꯡꯃ (NUMIT AMA) * 2 Days = ꯅꯨꯃꯤꯠ ꯲ ꯅꯤ (meaning two days) * 3 Months = ꯊꯥ ꯳ But in our language for plural we add (Sing or Mayam Sing added as... [17:23:28] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Display section issues modal - https://phabricator.wikimedia.org/T197932 (10nray) I reviewed this and added a +1 but didn't feel comfortable wi... [17:25:21] (03CR) 10jenkins-bot: Upgrade wikimedia/xmp-reader to 0.6.0 [core] - 10https://gerrit.wikimedia.org/r/452341 (owner: 10Legoktm) [17:26:45] 10WikiApiary: Update MediaWiki to 1.31 - https://phabricator.wikimedia.org/T199472 (10DeepBlue) @Kghbln Would you happen to know what needs to be done and changed to get us running on 1.31? [17:27:54] 10MediaWiki-Core-Tests, 10MediaWiki-Vagrant, 10Release-Engineering-Team (Someday), 10User-zeljkofilipin: Running selenium inside Vagrant with xvfb or X11 does not work - https://phabricator.wikimedia.org/T196646 (10zeljkofilipin) [17:29:35] petan: <3 [17:30:12] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10TechCom-RFC: RFC: Overhaul the undelete feature with a "pagearchive" table - https://phabricator.wikimedia.org/T193690 (10GeoffreyT2000) [17:30:16] (03CR) 10jenkins-bot: Don't use deprecated MagicWord methods [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/452284 (owner: 10Legoktm) [17:34:33] 10VisualEditor (Current work): Clicking to the left of a line moves the cursor few lines above in some cases - https://phabricator.wikimedia.org/T200819 (10Deskana) 05Open>03declined Declining per the above. [17:36:56] (03Merged) 10jenkins-bot: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:37:25] wikimedia/mediawiki#21717 (master - 5ea79a9 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415552903 [17:38:07] wikimedia/mediawiki#21717 (master - 5ea79a9 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415552903 [17:39:15] 10Page-Previews, 10Readers-Web-Backlog, 10Technical-Debt: Update test filenames to use Readers Web coding convention - https://phabricator.wikimedia.org/T197884 (10Niedzielski) After discussion today, no one could or would speak on behalf of test_. The current proposal is to move forward with .test.js naming... [17:40:15] (03PS1) 10Amire80: Move all apihelp translatable messages to separate files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452429 (https://phabricator.wikimedia.org/T189982) [17:43:42] (03CR) 10jerkins-bot: [V: 04-1] Fix some of the common typos [core] - 10https://gerrit.wikimedia.org/r/452423 (https://phabricator.wikimedia.org/T201491) (owner: 10Petar.petkovic) [17:44:07] (03CR) 10jerkins-bot: [V: 04-1] Move all apihelp translatable messages to separate files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452429 (https://phabricator.wikimedia.org/T189982) (owner: 10Amire80) [17:46:56] (03CR) 10jenkins-bot: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/444422 (owner: 10Paladox) [17:47:32] 10MediaWiki-General-or-Unknown, 10MW-1.29-release, 10Release-Engineering-Team (Next): Formalise and Announce REL1_29 EOL - https://phabricator.wikimedia.org/T197669 (10Reedy) >>! In T197669#4499105, @thcipriani wrote: > This is something #together generally does, but this is another in the long list of tasks... [17:48:33] wikimedia/mediawiki#21717 (master - 5ea79a9 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415552903 [17:49:11] who broke the build? [17:50:13] (03PS1) 10Paladox: Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 [17:50:52] 10MediaWiki-extensions-Variables: Make subst:#var work - https://phabricator.wikimedia.org/T201857 (10MGChecker) [17:51:31] (03CR) 10jerkins-bot: [V: 04-1] Use GetDifferenceEngine to inject InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452413 (https://phabricator.wikimedia.org/T201842) (owner: 10Gergő Tisza) [17:51:39] (03PS2) 10Amire80: Move all apihelp translatable messages to separate files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452429 (https://phabricator.wikimedia.org/T189982) [17:51:44] (03CR) 10Jforrester: [C: 032] Upgrade wikimedia/timestamp to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/452342 (owner: 10Legoktm) [17:51:46] (03CR) 10Jforrester: [C: 032] Upgrade wikimedia/timestamp to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/452340 (owner: 10Legoktm) [17:51:52] 10MediaWiki-extensions-Variables: Make subst:#var work - https://phabricator.wikimedia.org/T201857 (10MGChecker) There's a similar issue reported at the [[ https://www.mediawiki.org/wiki/Extension_talk:Variables/Archive#Substitution | extension talk page ]]. [17:51:53] (03PS1) 10Krinkle: benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) [17:51:55] (03PS1) 10Krinkle: JavaScriptMinifier: Turn $goto into a generic $model [core] - 10https://gerrit.wikimedia.org/r/452432 (https://phabricator.wikimedia.org/T201606) [17:51:58] (03PS1) 10Krinkle: JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) [17:52:00] (03PS1) 10Krinkle: JavaScriptMinifier: Fix bad state after ternary in object literal [core] - 10https://gerrit.wikimedia.org/r/452434 (https://phabricator.wikimedia.org/T201606) [17:53:03] (03PS2) 10Krinkle: benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) [17:53:12] (03PS2) 10Krinkle: JavaScriptMinifier: Turn $goto into a generic $model [core] - 10https://gerrit.wikimedia.org/r/452432 (https://phabricator.wikimedia.org/T201606) [17:53:23] (03PS2) 10Krinkle: JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) [17:53:35] (03PS2) 10Krinkle: JavaScriptMinifier: Fix bad state after ternary in object literal [core] - 10https://gerrit.wikimedia.org/r/452434 (https://phabricator.wikimedia.org/T201606) [17:54:48] 10MinervaNeue, 10Readers-Web-Backlog, 10Patch-For-Review: [Bug] Changing gallery images causes an abrupt and jarring white flash - https://phabricator.wikimedia.org/T197110 (10Niedzielski) @nray, I don't think so. I'm just as frustrated as anyone with the state of some of our fundamental UI components on mob... [17:55:36] (03CR) 10Krinkle: "Used newly added benchmark earlier in the stack to check impact of $goto change and this change, and found no meaningful impact." [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [17:56:16] (03PS2) 10Krinkle: resourceloader: Increase minification cache version [core] - 10https://gerrit.wikimedia.org/r/452045 (https://phabricator.wikimedia.org/T201606) [17:56:45] (03CR) 10Krinkle: "Rebased on top of the second bug fix. We may find more later, but these two should suffice for now to unblock the train." [core] - 10https://gerrit.wikimedia.org/r/452045 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [17:57:09] 10WMSE-Riksarkivet-TORA: Change to start date from P571 - https://phabricator.wikimedia.org/T201738 (10Salgo60) [[ https://sv.wikipedia.org/wiki/Anv%C3%A4ndardiskussion:Yger#F%C3%B6rsamlingen_har_medeltida_ursprung | Todays idea ]] is that we use something like Year = 1300 Precision = 100 år earliest date ([[... [17:59:31] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Bad newline after return statement by JavaScript minifier - https://phabricator.wikimedia.org/T201606 (10Krinkle) [18:02:29] (03PS5) 10Phantom42: Add PHPUnit tests for extension Mailgun [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) [18:03:04] 10Anti-Harassment (AHT Sprint 26): Update block logs with partial block details - https://phabricator.wikimedia.org/T197108 (10dbarratt) a:05dmaza>03None [18:05:29] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10MarkAHershberger) [18:06:28] (03Merged) 10jenkins-bot: Upgrade wikimedia/timestamp to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/452340 (owner: 10Legoktm) [18:06:39] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10MarkAHershberger) [18:06:57] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10MarkAHershberger) [18:09:11] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10MarkAHershberger) [18:10:52] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Turn $goto into a generic $model [core] - 10https://gerrit.wikimedia.org/r/452432 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:10:59] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:11:01] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Fix bad state after ternary in object literal [core] - 10https://gerrit.wikimedia.org/r/452434 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:11:03] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Turn $goto into a generic $model [core] - 10https://gerrit.wikimedia.org/r/452432 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:11:05] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:11:07] (03CR) 10jerkins-bot: [V: 04-1] JavaScriptMinifier: Fix bad state after ternary in object literal [core] - 10https://gerrit.wikimedia.org/r/452434 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [18:11:32] (03CR) 10Martineznovo: "This is going to be difficult to backport to 1.31, because LoadBalancer doesn't contain getServerInfo(), added in I240d8d4e65ce46680cac25" [core] - 10https://gerrit.wikimedia.org/r/448618 (https://phabricator.wikimedia.org/T200471) (owner: 10Martineznovo) [18:12:27] (03PS3) 10Krinkle: benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) [18:12:38] 10MediaWiki-extensions-Scribunto, 10MediaWiki-extensions-Variables: Create a Scribunto interface - https://phabricator.wikimedia.org/T201171 (10MGChecker) In general, I think this is a good idea and would like to see you work on it. [18:12:39] (03PS3) 10Krinkle: JavaScriptMinifier: Turn $goto into a generic $model [core] - 10https://gerrit.wikimedia.org/r/452432 (https://phabricator.wikimedia.org/T201606) [18:12:47] (03PS3) 10Krinkle: JavaScriptMinifier: Merge $push and $pop into $model [core] - 10https://gerrit.wikimedia.org/r/452433 (https://phabricator.wikimedia.org/T201606) [18:12:56] (03PS3) 10Krinkle: JavaScriptMinifier: Fix bad state after ternary in object literal [core] - 10https://gerrit.wikimedia.org/r/452434 (https://phabricator.wikimedia.org/T201606) [18:13:04] (03PS3) 10Krinkle: resourceloader: Increase minification cache version [core] - 10https://gerrit.wikimedia.org/r/452045 (https://phabricator.wikimedia.org/T201606) [18:13:43] (03PS3) 10Amire80: Move all apihelp translatable messages to separate files [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/452429 (https://phabricator.wikimedia.org/T189982) [18:16:37] 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Deprecate and remove 'comment' icon from 'alerts' pack - https://phabricator.wikimedia.org/T183600 (10Jdforrester-WMF) [18:16:39] 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10Patch-For-Review, 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601 (10Jdforrester-WMF) [18:16:42] 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10Patch-For-Review, 10UI-Standardization-Kanban: Deprecate and remove 'find' icon - https://phabricator.wikimedia.org/T183645 (10Jdforrester-WMF) [18:16:45] 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10Patch-For-Review: Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar' - https://phabricator.wikimedia.org/T190441 (10Jdforrester-WMF) [18:16:48] 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10Patch-For-Review: 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive' - https://phabricator.wikimedia.org/T189113 (10Jdforrester-WMF) [18:16:53] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Catrope) @SBisson ARGH you're right, I... [18:17:15] (03PS1) 10Catrope: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 [18:17:31] (03PS2) 10Catrope: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 [18:17:36] (03CR) 10Catrope: [C: 032] Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:17:41] (03Restored) 10Catrope: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:17:48] (03PS2) 10Catrope: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:17:53] (03CR) 10Catrope: [C: 032] Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:18:55] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit tests for extension Mailgun [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:19:13] (03CR) 10Martineznovo: [C: 031] "It works if I also merge I240d8d4e65ce46680cac257ee376a9b026c13f92 on REL1_31." [core] - 10https://gerrit.wikimedia.org/r/448618 (https://phabricator.wikimedia.org/T200471) (owner: 10Martineznovo) [18:19:18] (03Merged) 10jenkins-bot: Upgrade wikimedia/timestamp to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/452342 (owner: 10Legoktm) [18:19:29] (03CR) 10Catrope: [C: 032] Unset external hooks to test in isolation [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452363 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:19:52] (03CR) 10Catrope: [C: 032] Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:19:54] 10MediaWiki-Internationalization, 10I18n, 10User-MarcoAurelio: Add MessagesSco.php - https://phabricator.wikimedia.org/T201462 (10jrbs) Because Scots is primarily a spoken (not written) language, translations vary from place to place. It's also hard to really have a direct translation for a lot of these sinc... [18:20:36] 10MediaWiki-extensions-Variables: [Variables] Allow fallback/default values for #vardefine / #vardefineecho - https://phabricator.wikimedia.org/T201846 (10MGChecker) While this could be easily done, I agree with @Danwe that it adds some complexity that would probably be better suited in a seperate `#or:` parser... [18:22:00] 10OOUI (OOUI-0.28.0), 10Patch-For-Review: Deprecate & remove citations icons from 'content' pack - https://phabricator.wikimedia.org/T194104 (10Jdforrester-WMF) [18:23:17] 10Design, 10Design-Research, 10VisualEditor (Current work): Recruit 1- 3 additional evaluators for Heuristic Evaluation - https://phabricator.wikimedia.org/T201550 (10iamjessklein) [18:27:24] (03CR) 10jenkins-bot: Upgrade wikimedia/timestamp to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/452342 (owner: 10Legoktm) [18:37:28] (03CR) 10Phantom42: "> Patch Set 4:" (031 comment) [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:38:47] (03CR) 10Phantom42: "> Patch Set 4:" (031 comment) [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:39:01] (03CR) 10Phantom42: "recheck" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:40:25] wikimedia/mediawiki#21718 (master - c957e96 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415576505 [18:44:08] apergos: Hello [18:44:12] d3r1ck: Hello [18:44:27] Dereckson: Hello [18:44:39] waiting 5 minutes ... [18:46:15] wikimedia/mediawiki#21718 (master - c957e96 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415576505 [18:46:16] (03PS1) 10Umherirrender: Format edit count on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 [18:46:49] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10MarkAHershberger) @cicalese suggests putting the category assignment in a template so that it isn't evaluated initially when the #if is evaluated. She has said she mana... [18:46:54] (03Merged) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:46:56] wikimedia/mediawiki#21718 (master - c957e96 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415576505 [18:46:57] (03Merged) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [18:47:00] (03Merged) 10jenkins-bot: Unset external hooks to test in isolation [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452363 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:47:08] (03Merged) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:48:08] (03CR) 10Huji: [C: 031] "Totally!" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [18:48:42] (03CR) 10Huji: [C: 031] "Also, we need to see how this information is returned in the API output, and whether we need to format that or not" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [18:49:07] and there's the bell! [18:49:14] ok [18:49:16] r054l13: d3r1ck Dereckson, shall we get started? [18:49:23] yes [18:49:27] sweet! [18:49:32] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10MvGulik) Update: Seems the "populateRevisionSha1" maintenance script needed to be run with some "--force" op... [18:49:38] how is everyone? there's only one (1) day left for work!! woooo [18:49:46] Hey! [18:49:54] apergos: Well, just there [18:50:07] one day for gsoc work, I mean [18:50:12] I am good [18:50:21] how is everyone's sleep?? [18:50:32] (03PS1) 10Aaron Schulz: Use LB server configuration to force DB domains in ExternalStorageDB [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) [18:50:54] good [18:51:07] 10MediaWiki-Core-Tests, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Wikimedia-log-errors (Shared Build Failure): TitlePermissionTest failing on travis-ci after ContentLanguage service conversion - https://phabricator.wikimedia.org/T201776 (10Krinkle) [18:51:09] d3r1ck: ? [18:51:27] (03CR) 10Aaron Schulz: "I moved my change to https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/452453" [core] - 10https://gerrit.wikimedia.org/r/448618 (https://phabricator.wikimedia.org/T200471) (owner: 10Martineznovo) [18:51:44] 10MediaWiki-Core-Tests, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Wikimedia-log-errors (Shared Build Failure): TitlePermissionTest failing on travis-ci after ContentLanguage service conversion - https://phabricator.wikimedia.org/T201776 (10Krinkle) @Simetrical Unfortunately, it is still failing –  well we'll find out about his sleep soon enough :-) [18:51:52] how is work going on the project? [18:52:21] (03CR) 10jerkins-bot: [V: 04-1] Add PHPUnit tests for extension Mailgun [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:52:29] not very smooth [18:52:53] what's left and where are you blocked? [18:53:03] apergos: Getting back into the routine, so getting better [18:53:16] d3r1ck: that's what we like to hear! [18:53:22] apergos: :D, okay! [18:53:43] apergos: I get errors using grideng on toolforge and have not fixed them yet [18:53:50] ok [18:54:02] well we can look at that together with whoever else is in the channel [18:54:12] (03CR) 10Umherirrender: "API always output raw numbers, when not parsing the special page format line there is no problem" [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [18:54:15] ok [18:54:16] how about the other things on your todo list? [18:54:44] I have updated the docs from the comments I got [18:54:57] and have updated the devManual too [18:55:11] will submit the patch this evening [18:55:11] ok great [18:55:19] good because we have to review it tonight [18:55:23] 10Security-Team: Puppetize drupal7 on a Cloud host - https://phabricator.wikimedia.org/T201861 (10chasemp) p:05Triage>03Normal [18:55:26] (03CR) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [18:55:26] in case there are any changes because [18:55:31] tomorrow is literally the last day [18:55:45] like there are no extensions to the day after tomorrow, AND [18:55:51] yea [18:55:53] ok [18:55:57] 16:00 UTC is the last possible second and you don't want to wait til then [18:56:03] it's all google's schedule so there's no flex [18:56:12] ok [18:56:25] I looked at the changes to the google doc, the one thing I would say there is [18:56:38] when they mentioned challenges, I think they meant things that were hard about the project [18:56:52] aah ok [18:56:56] I think it's fine to mention the other stuff too but I have the impression that they meant [18:57:06] well this was hard and I had to work around it [18:57:08] (03CR) 10jerkins-bot: [V: 04-1] Fix "PHP Warning: count(): Parameter must be an array or an object that implements Countable" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 (owner: 10Paladox) [18:57:09] that kind of thing [18:57:22] yeah [18:57:23] (03CR) 10Phantom42: "Hm, I cannot understand why CI fails. Tests pass on my local environment. Any tips?" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [18:57:29] (because most people hopefully do not have your kind of extra challenges!) [18:57:36] (03CR) 10Paladox: "recheck" [extensions/Echo] (REL1_31) - 10https://gerrit.wikimedia.org/r/452430 (owner: 10Paladox) [18:57:39] 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) [18:57:40] ok [18:57:41] (03CR) 10Krinkle: [C: 032] rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 (owner: 10Aaron Schulz) [18:57:41] I haven't seen the dev manual yet because no patch [18:58:00] ah also uh, I still think it would be nice to have a screenshot of a tweet to the bot and a reply, right in the google report [18:58:14] I know you link, but that way it's just there without having to click through [18:58:15] I added that [18:58:25] few mins before the meeting :) [18:58:28] oh? maybe I looked too early! heh [18:58:35] (03PS2) 10Krinkle: Use LB server configuration to force DB domains in ExternalStorageDB [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [18:58:59] ok, so you probably do not now have to say in uh [18:59:12] in the project details, the list of everything the reply tweet has [18:59:29] because, it's shown in the screenshot, you can just say see below for an example, or something [18:59:30] ok [18:59:39] (03CR) 10jenkins-bot: Unset external hooks to test in isolation [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452363 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [18:59:44] alright [19:00:25] that's the only comments I have on the google report [19:00:36] d3r1ck might have others (do you?) [19:01:06] (03CR) 10D3r1ck01: "> Patch Set 5:" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [19:01:19] (03CR) 10Martineznovo: [C: 031] "Re-adding my comments from I5c3fd2813f1f56771d5eca7780fb716cac5a452c" [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [19:01:23] apergos: None, I've given all comments already, I reviewed it yesterday [19:01:23] (03PS1) 10Aaron Schulz: Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) [19:01:32] ok. how does it look with the changes? [19:01:36] But I can do 1 last run on it after the meeting to see if all changes have been applied [19:01:41] ok, that's fine [19:01:48] apergos: Let me look now, quickly [19:01:54] so we'll hope for the dev manual fixups soon [19:02:05] 10WikiApiary: Template:Orphaned_page_check added un-orphaned pages to the list of orphaned pages - https://phabricator.wikimedia.org/T201859 (10cicalese) Actually, my past experience was for properties, not categories, but I think the same logic may apply. [19:02:12] and what's left is toolforge-related, right? [19:02:23] yes [19:03:42] what other things would you like to bring up? formally there is no checkin tomorrow evening because your submission will have already been sent in before then [19:03:53] apergos: So I've had a quick look and it's just the webservice part which will be updated I think and your feedback [19:03:53] so maybe this is your last checkin [19:04:12] (03CR) 10Mglaser: [C: 032] Fix "Undefined offset" notice [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452395 (owner: 10Pwirth) [19:05:03] tomorrow I will be around earlier in the day if you are working still on the toolforge issue, but tomorrow at 15:00 or so UTC I am gone, and not reachable for several days [19:05:18] I will send mail to everyone when I return [19:05:24] (03CR) 10Mglaser: [C: 032] Fixed missing not in comparison in ListValue filter [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452386 (owner: 10Pwirth) [19:05:39] d3r1ck: thanks for checking! [19:05:45] wow! [19:05:52] ok [19:05:54] (03PS1) 10Aaron Schulz: Add @since to LoadBalancer getServerInfo() per a3096440627 [core] - 10https://gerrit.wikimedia.org/r/452456 [19:06:17] so: last topics? last questions comments complaints suggestions rants or anything else?? [19:06:21] apergos: Okay, thanks a lot and happy unreachability, whatever that word means :D [19:06:23] hmm! I have no special comment [19:06:25] from anyone! now is the time [19:06:45] d3r1ck: I plan to have a very nice time being unreachable. phone only! [19:06:59] apergos: Then I'll poke you privately :) [19:07:07] heh [19:07:07] apergos: Thanks a lot for your availability always during the summer [19:07:15] you're very welcome [19:07:32] note that end of the project doesn't mean 'and now we stop talking' or 'and there's no code to work on if you like' [19:07:48] yeah of course :) [19:07:50] :-) [19:08:02] well... d3r1ck anything you want to bring up? [19:08:04] last chance! [19:08:05] It simply mean another level of work [19:08:09] indeed [19:08:24] apergos: None for now until I poke you :D [19:08:24] 10Design, 10Design-Research, 10VisualEditor (Current work): Recruit 1- 3 additional evaluators for Heuristic Evaluation - https://phabricator.wikimedia.org/T201550 (10iamjessklein) In the [[ https://docs.google.com/document/d/1dOhbuQtPElIgyJS07S17aW9CJxX49cPufxnkadH5yPk/edit | planning doc ]], I wrote these... [19:08:26] ok! [19:08:44] in that case: r054l13 let's go chat in the -cloud channel and see what's happening with the grid engine, shall we? [19:08:56] yeah [19:09:00] d3r1ck: feel free to join us or not, depending on your energy level and your routine! [19:09:01] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) [19:09:19] 10MediaWiki-extensions-OpenID: SpecialOpenIDLogin.body.php:154 - get_class() expects parameter 1 to be object, null given - https://phabricator.wikimedia.org/T201864 (10MilkMiruku) [19:10:03] * d3r1ck nods [19:10:08] 10Security: this is my subtask of the epic task - https://phabricator.wikimedia.org/T201865 (10debt) p:05Triage>03High [19:10:41] 10Security: task #2 - https://phabricator.wikimedia.org/T201866 (10debt) p:05Triage>03High [19:10:57] 10Epic, 10Security: tree task - https://phabricator.wikimedia.org/T201867 (10debt) [19:11:37] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) [19:11:39] 10Security: task #2 - https://phabricator.wikimedia.org/T201866 (10debt) [19:11:42] 10Epic, 10Security: tree task - https://phabricator.wikimedia.org/T201867 (10debt) [19:12:56] (03PS1) 10Umherirrender: Fix escaping of messages used in html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 [19:13:15] (03CR) 10D3r1ck01: Add PHPUnit tests for extension Mailgun (031 comment) [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [19:13:38] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 [19:13:44] (03CR) 10Umherirrender: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:13:47] 10Security: task #2 - https://phabricator.wikimedia.org/T201866 (10debt) [19:13:49] 10Epic, 10Security: tree task - https://phabricator.wikimedia.org/T201867 (10debt) 05Open>03Invalid this was just a test [19:15:18] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) 05Open>03declined [19:16:30] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) [19:16:34] 10Security: this is my subtask of the epic task - https://phabricator.wikimedia.org/T201865 (10debt) 05Open>03declined this is a test [19:17:02] 10Design, 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, and 3 others: Mobile page issues - allow page issues to display different severity levels - https://phabricator.wikimedia.org/T191528 (10alexhollender) === Issue 1 Alas, there seems to be a snag with multiple issues icons. The logic, a... [19:17:05] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) 05declined>03Open testing again [19:17:09] (03CR) 10Fomafix: "> Shouldn't these brackets be localized anyways? Is it possible to do" [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447671 (owner: 10Fomafix) [19:17:38] 10Design, 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, and 3 others: Mobile page issues - allow page issues to display different severity levels - https://phabricator.wikimedia.org/T191528 (10alexhollender) a:05alexhollender>03None [19:18:05] 10Design, 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, and 3 others: Mobile page issues - allow page issues to display different severity levels - https://phabricator.wikimedia.org/T191528 (10alexhollender) a:03Niedzielski [19:18:14] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [19:18:19] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) p:05Triage>03Normal [19:18:44] (03PS24) 10Dbarratt: Update Special:BlockList to present Partial Block details from the database [core] - 10https://gerrit.wikimedia.org/r/441093 (https://phabricator.wikimedia.org/T197143) [19:19:26] 10Epic, 10Security: (TEST) We want to create this ticket as a default style of reporting - https://phabricator.wikimedia.org/T201862 (10debt) 05Open>03declined just a test [19:20:44] (03CR) 10Dbarratt: Update Special:BlockList to present Partial Block details from the database (033 comments) [core] - 10https://gerrit.wikimedia.org/r/441093 (https://phabricator.wikimedia.org/T197143) (owner: 10Dbarratt) [19:22:23] (03PS2) 10Sharvaniharan: Link to an Accessible alternative to account creation [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451779 (https://phabricator.wikimedia.org/T159451) [19:28:21] (03Merged) 10jenkins-bot: Fix "Undefined offset" notice [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452395 (owner: 10Pwirth) [19:28:25] (03Merged) 10jenkins-bot: Fixed missing not in comparison in ListValue filter [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/452386 (owner: 10Pwirth) [19:28:45] 10Trust-and-Safety: Request to set email address for en.wp user account Vmars22 - https://phabricator.wikimedia.org/T201280 (10jrbs) >>! In T201280#4495929, @Interestingedits wrote: > It's been almost a week! Any one able to help? Sorry for the delay here. I'm a little confused. It [[ https://en.wikipedia.org/w... [19:29:13] (03CR) 10jerkins-bot: [V: 04-1] Fix escaping of messages used in html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender) [19:29:37] 10Trust-and-Safety: Request to set email address for en.wp user account Vmars22 - https://phabricator.wikimedia.org/T201280 (10jrbs) p:05Triage>03High [19:30:07] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:31:08] 10MediaWiki-Page-editing, 10CommRel-Specialists-Support (Jul-Sep-2018): Support the Editing team in their changes to classic edit toolbar - https://phabricator.wikimedia.org/T163929 (10Whatamidoing-WMF) 05stalled>03Open [19:31:12] 10MediaWiki-Page-editing, 10JavaScript, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Whatamidoing-WMF) [19:32:08] (03CR) 10jenkins-bot: Check for irrelevant rc_types first in hooks [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452364 (https://phabricator.wikimedia.org/T201812) (owner: 10Sbisson) [19:32:11] 10MediaWiki-Page-editing, 10JavaScript, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Whatamidoing-WMF) > I don't have global interface permissions @TheDJ, this sounds like a problem report. Do you want that to change? @Arkanosis (an... [19:32:45] (03PS2) 10Jkroll: [WiP] Fix ordering of lines in some diffs [php/wikidiff2] - 10https://gerrit.wikimedia.org/r/450024 (https://phabricator.wikimedia.org/T197157) [19:34:04] 10MediaWiki-extensions-DonationInterface, 10Fr-Ingenico-integration_2017-18, 10Fundraising-Backlog, 10Fundraising Sprint Pluto is still a planet: Deal with Ingenico Connect code 300620: MerchantReference XXXX already exists - https://phabricator.wikimedia.org/T201773 (10DStrine) [19:35:50] 10MediaWiki-extensions-CentralNotice, 10Fundraising-Backlog: Don't use freegeoip service by default anymore - https://phabricator.wikimedia.org/T201753 (10Ejegg) Looks like https://ipstack.com/ has a free tier [19:37:21] (03CR) 10Ejegg: [C: 032] Update libraries, fix erroneous submodules [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/451352 (https://phabricator.wikimedia.org/T185547) (owner: 10Ejegg) [19:37:39] (03PS2) 10Umherirrender: Fix escaping of messages used in html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 [19:37:45] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:37:47] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:37:55] (03CR) 10Umherirrender: "Break long line" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender) [19:38:13] 10MediaWiki-extensions-PageCuration, 10Availability, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), 10Growth-Team (Current Sprint), and 2 others: PageTriage opens master connection on GET for ArticleMetadata cache misses - https://phabricator.wikimedia.org/T154719 (10Krinkle) [19:38:34] (03CR) 10Umherirrender: "check experimental" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:39:07] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 (owner: 10Aaron Schulz) [19:39:09] (03CR) 10jerkins-bot: [V: 04-1] Update libraries, fix erroneous submodules [vendor] (fundraising/REL1_31) - 10https://gerrit.wikimedia.org/r/451352 (https://phabricator.wikimedia.org/T185547) (owner: 10Ejegg) [19:41:06] 10Accessibility, 10VisualEditor, 10VisualEditor-Tables: Cursor into and out of table captions correctly with up/down arrow - https://phabricator.wikimedia.org/T201870 (10Esanders) [19:41:51] 10UI-Standardization, 10OOUI (OOUI-0.28.0): 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive' - https://phabricator.wikimedia.org/T189113 (10Petar.petkovic) [19:42:05] 10UI-Standardization, 10OOUI (OOUI-0.28.0): Deprecate and remove 'userActive', as it's a duplicate of 'userAvatar' - https://phabricator.wikimedia.org/T190441 (10Petar.petkovic) [19:42:49] 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Smalyshev) For me at least the following worked pretty fine: * For smaller tests, just spin up new VPS instance and install mediawiki-vagrant, possibly importing or manually crea... [19:42:50] (03CR) 10Bartosz Dziewoński: [C: 032] "Huh." [core] - 10https://gerrit.wikimedia.org/r/452192 (owner: 10TheDJ) [19:44:19] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/451356 (owner: 10Umherirrender) [19:46:42] (03CR) 10Jforrester: [C: 031] Add `border-style-base` variable [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [19:50:16] 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Catrope) >>! In T201253#4495808, @Etonk... [19:51:35] 10TemplateStyles: Allow template parameters to provide CSS to a templatestyles stylesheet - https://phabricator.wikimedia.org/T200632 (10ShakespeareFan00) I have a set of 'monster' templates at English Wikisource , cl-act-paragraph (and related) , which currently use a considerable amount of inline CSS, or param... [19:52:47] (03CR) 10jenkins-bot: Revert "Keep patrolled drafts in the feed" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452443 (owner: 10Catrope) [19:55:41] (03CR) 10Krinkle: Make MapCacheLRU throw errors for bad $field arguments (031 comment) [core] - 10https://gerrit.wikimedia.org/r/446771 (owner: 10Aaron Schulz) [19:56:25] (03CR) 10Huji: [C: 032] Format edit count on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [19:57:05] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/452466 (owner: 10L10n-bot) [20:03:07] (03CR) 10jenkins-bot: Keep patrolled drafts in the feed [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451182 (https://phabricator.wikimedia.org/T201253) (owner: 10Sbisson) [20:03:10] 10MediaWiki-extensions-LabeledSectionTransclusion, 10ProofreadPage, 10TemplateStyles: Extend TemplateStyles so there can be per-work styles with Proofreadpage/LST constructed works... - https://phabricator.wikimedia.org/T201872 (10ShakespeareFan00) [20:04:49] 04(no projects): [EventLoggingToDruid] Allow ingestion of simple-type arrays by converting them to strings - https://phabricator.wikimedia.org/T201873 (10mforns) [20:05:56] 10MediaWiki-General-or-Unknown, 10Performance-Team: Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10Imarlier) @Legoktm @tstarling Let us know if you need anything from the Performance team [20:06:15] (03PS25) 10Dbarratt: Update Special:BlockList to present Partial Block details from the database [core] - 10https://gerrit.wikimedia.org/r/441093 (https://phabricator.wikimedia.org/T197143) [20:06:22] 10MediaWiki-General-or-Unknown, 10Performance-Team (Radar): Performance review for Assert library - https://phabricator.wikimedia.org/T201802 (10Imarlier) [20:06:24] (03Merged) 10jenkins-bot: Legacy: remove unused style rules for floatleft/right [core] - 10https://gerrit.wikimedia.org/r/452192 (owner: 10TheDJ) [20:07:10] (03PS3) 10Umherirrender: Fix escaping of messages used in html [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 [20:07:39] (03CR) 10Umherirrender: "More fixes" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452459 (owner: 10Umherirrender) [20:09:17] 10CommRel-Internals: Archive or update Technical Collaboration pages in Meta and Office Wiki - https://phabricator.wikimedia.org/T199084 (10Qgil) a:03Quiddity [20:10:33] 10MediaWiki-Database, 10Core-Platform-Team, 10Performance-Team: LinksUpdate fails, spams exception logs, whenever replication lag on any server rises above 10s - https://phabricator.wikimedia.org/T201482 (10Imarlier) @tstarling Safe to assume that you're planning to tackle this? [20:10:43] (03CR) 10jenkins-bot: Legacy: remove unused style rules for floatleft/right [core] - 10https://gerrit.wikimedia.org/r/452192 (owner: 10TheDJ) [20:10:50] 10MediaWiki-Database, 10Core-Platform-Team, 10Performance-Team (Radar): LinksUpdate fails, spams exception logs, whenever replication lag on any server rises above 10s - https://phabricator.wikimedia.org/T201482 (10Imarlier) [20:10:55] (03PS1) 10Gergő Tisza: Create DifferenceEngine before calling GetDifferenceEngine [core] - 10https://gerrit.wikimedia.org/r/452470 [20:11:24] (03PS2) 10Gergő Tisza: Use GetDifferenceEngine to inject InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452413 (https://phabricator.wikimedia.org/T201842) [20:12:28] 10MediaWiki-extensions-OpenID, 10PHP 7.2 support: SpecialOpenIDLogin.body.php:154 - get_class() expects parameter 1 to be object, null given - https://phabricator.wikimedia.org/T201864 (10Aklapper) Thanks for taking a look at the code and reporting this! You are very welcome to use [[ https://www.mediawiki.o... [20:12:51] wikimedia/mediawiki#21719 (master - 1b3b29f Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415612526 [20:14:03] (03CR) 10TheDJ: "starting to really come together brion. Nice !" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [20:14:24] (03CR) 10Esanders: "ping" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/450580 (https://phabricator.wikimedia.org/T190596) (owner: 10Esanders) [20:16:29] (03Merged) 10jenkins-bot: Format edit count on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [20:16:50] 10MediaWiki-Database, 10Performance-Team, 10MW-1.31-release, 10Patch-For-Review, 10Regression: [regression] LBFactorySimple breaks ExternalStorage, trying to connect to external server with local database name - https://phabricator.wikimedia.org/T200471 (10aaron) a:03aaron [20:17:47] 10TemplateStyles: TemplateStyles for tables ... - https://phabricator.wikimedia.org/T201876 (10ShakespeareFan00) [20:19:12] wikimedia/mediawiki#21719 (master - 1b3b29f Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415612526 [20:19:19] (03PS1) 10Sbisson: [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) [20:20:38] 10TemplateStyles: Decide on what to recommend for table style usecase - https://phabricator.wikimedia.org/T176272 (10Izno) [20:20:41] 10TemplateStyles: TemplateStyles for tables ... - https://phabricator.wikimedia.org/T201876 (10Izno) [20:20:41] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) (owner: 10Sbisson) [20:20:42] wikimedia/mediawiki#21719 (master - 1b3b29f Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415612526 [20:22:43] (03PS1) 10Fomafix: Language: Create new private static fuction getCodeFromClass [core] - 10https://gerrit.wikimedia.org/r/452563 [20:23:41] 10MediaWiki-User-management, 10I18n: [[MediaWiki:Ipboptions/mni]] translation issue - https://phabricator.wikimedia.org/T201854 (10Aklapper) > Why this translation becomes outdated? What makes you think that this translation becomes outdated? I'm afraid I don't understand the problem. Please see and follow ht... [20:25:10] (03PS7) 10Aaron Schulz: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 [20:25:50] (03CR) 10jerkins-bot: [V: 04-1] Use GetDifferenceEngine to inject InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452413 (https://phabricator.wikimedia.org/T201842) (owner: 10Gergő Tisza) [20:26:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/452522 (owner: 10L10n-bot) [20:28:36] wikimedia/mediawiki#21720 (master - 6129d1d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415618004 [20:28:43] (03CR) 10jerkins-bot: [V: 04-1] Use GetDifferenceEngine to inject InlineDifferenceEngine [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452413 (https://phabricator.wikimedia.org/T201842) (owner: 10Gergő Tisza) [20:29:40] 10Browser-Support-Firefox, 10Browser-Support-Opera: HTML5 Bullet Point Rendering Bug - https://phabricator.wikimedia.org/T201847 (10Aklapper) So far I have not managed to reproduce in Firefox... Which specific HTML5 aspect is involved here, as you explicitly mentioned HTML5 in the task summary? Is there some... [20:30:15] (03PS8) 10Aaron Schulz: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 [20:32:17] wikimedia/mediawiki#21720 (master - 6129d1d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415618004 [20:33:07] (03CR) 10Qdinar: "i am going to make some reinstall, then i will fix it, if god wants." [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) (owner: 10Qdinar) [20:33:28] wikimedia/mediawiki#21720 (master - 6129d1d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415618004 [20:34:22] (03CR) 10Brian Wolff: Fix some warnings from phan-taint-check (031 comment) [core] - 10https://gerrit.wikimedia.org/r/445846 (owner: 10Brian Wolff) [20:34:46] wikimedia/mediawiki#21720 (master - 6129d1d jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415618004 [20:35:07] (03PS1) 10Daniel Kinzler: Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) [20:35:46] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/452479 (owner: 10L10n-bot) [20:37:49] (03CR) 10Gergő Tisza: [C: 032] Use Html::rawElement for parsed message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/452312 (owner: 10Umherirrender) [20:38:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Ithenticate Scoring provider [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452562 (https://phabricator.wikimedia.org/T201071) (owner: 10Sbisson) [20:39:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/452490 (owner: 10L10n-bot) [20:40:01] (03PS2) 10Brian Wolff: Fix some warnings from phan-taint-check [core] - 10https://gerrit.wikimedia.org/r/445846 [20:41:21] (03CR) 10Brian Wolff: "PS2: add an explanatory comment" [core] - 10https://gerrit.wikimedia.org/r/445846 (owner: 10Brian Wolff) [20:43:04] 10MediaWiki-Page-editing, 10JavaScript, 10Technical-Debt, 10User-notice: Remove classic edit toolbar from core - https://phabricator.wikimedia.org/T30856 (10Arkanosis) >>! In T30856#4499678, @Whatamidoing-WMF wrote: > @Arkanosis (and others), I think we're ready to talk about re-re-re-scheduling this. Do... [20:46:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452489 (owner: 10L10n-bot) [20:47:14] (03PS3) 10Brian Wolff: Improve tracking of outputting class members [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/443356 [20:47:32] 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page/namespace - https://phabricator.wikimedia.org/T199917 (10TBolliger) Based on the minutes from the IRC meeting last Wednesday and the rest of the comments on this ticket, it appears the only topic we need to resolve is around Tim's question of unique in... [20:50:29] (03PS4) 10Smalyshev: Fix handling categorization changes [core] - 10https://gerrit.wikimedia.org/r/451230 (https://phabricator.wikimedia.org/T201216) [20:52:44] (03PS5) 10Brian Wolff: Fix html for exceptions during message parsing. [core] - 10https://gerrit.wikimedia.org/r/384927 [20:54:45] <wikibugs_> 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page/namespace - https://phabricator.wikimedia.org/T199917 (10dbarratt) >>! In T199917#4499867, @TBolliger wrote: >Tim's question of unique index (which are currently used to address the situation when two admins attempt to set a block at the same time.)... [20:55:21] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [20:57:44] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/452493 (owner: 10L10n-bot) [20:59:20] <wikibugs_> (03CR) 10Cooltey: [C: 032] Hygiene: remove unnecessary callback and indirection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451878 (owner: 10Dbrant) [20:59:22] <wikibugs_> (03CR) 10Cooltey: [C: 032] Optimization: remove unnecessary javascript bridge message. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451877 (owner: 10Dbrant) [20:59:26] <wikibugs_> (03CR) 10Cooltey: [C: 032] Optimization: Remove unnecessary javascript bridge handshake. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451876 (owner: 10Dbrant) [20:59:59] <wikibugs_> (03CR) 10Brian Wolff: "Mostly for completeness, so that its possible to specify explicitly what the implicit default value is." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [21:05:37] <wikibugs_> (03Merged) 10jenkins-bot: Use Html::rawElement for parsed message [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/452312 (owner: 10Umherirrender) [21:08:57] <wikibugs_> (03CR) 10Aaron Schulz: [C: 032] benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [21:08:57] <wikibugs_> (03CR) 10jenkins-bot: Format edit count on Special:CheckUser [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452452 (owner: 10Umherirrender) [21:11:21] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452497 (owner: 10L10n-bot) [21:12:16] <wikibugs_> (03CR) 10Jforrester: "Tsk, dupe of my Ib035168131256 WIP. ;-)" [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [21:14:23] <wikibugs_> (03Merged) 10jenkins-bot: Optimization: Remove unnecessary javascript bridge handshake. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451876 (owner: 10Dbrant) [21:14:54] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452508 (owner: 10L10n-bot) [21:14:56] <wikibugs_> (03CR) 10Cooltey: "Few comments" (032 comments) [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451779 (https://phabricator.wikimedia.org/T159451) (owner: 10Sharvaniharan) [21:17:08] <wikibugs_> (03Merged) 10jenkins-bot: Optimization: remove unnecessary javascript bridge message. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451877 (owner: 10Dbrant) [21:17:10] <wikibugs_> (03Merged) 10jenkins-bot: Hygiene: remove unnecessary callback and indirection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451878 (owner: 10Dbrant) [21:17:28] <wikibugs_> (03CR) 10Legoktm: Fix some warnings from phan-taint-check (031 comment) [core] - 10https://gerrit.wikimedia.org/r/445846 (owner: 10Brian Wolff) [21:17:35] <wikibugs_> (03CR) 10jenkins-bot: Optimization: Remove unnecessary javascript bridge handshake. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451876 (owner: 10Dbrant) [21:19:11] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/452505 (owner: 10L10n-bot) [21:19:53] <wikibugs_> (03CR) 10Aaron Schulz: [C: 032] benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 (owner: 10Krinkle) [21:20:06] <wikibugs_> (03CR) 10jenkins-bot: Optimization: remove unnecessary javascript bridge message. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451877 (owner: 10Dbrant) [21:20:10] <wikibugs_> 10Anti-Harassment (AHT Sprint 26): Update PHP APIs to set Partial Blocks - https://phabricator.wikimedia.org/T197114 (10dbarratt) a:03dbarratt [21:20:25] <wikibugs_> (03CR) 10jenkins-bot: Hygiene: remove unnecessary callback and indirection. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/451878 (owner: 10Dbrant) [21:20:27] <wikibugs_> (03PS2) 10Jforrester: [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS [core] - 10https://gerrit.wikimedia.org/r/411387 [21:22:16] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/452513 (owner: 10L10n-bot) [21:24:40] <wikibugs_> (03CR) 10Legoktm: [C: 032] Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [21:26:18] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [21:26:20] <wikibugs_> 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: [BUG] Onboarding language add/edit button hidden on 4" devices - https://phabricator.wikimedia.org/T198263 (10Nicholas.tsg) @Kaartic @ABorbaWMF that was a typo I had been using the app 2018-08-06. I tried to test again today with BLU Da... [21:26:28] <wikibugs_> 10Design, 10Android-app-feature-Description-Editing, 10Design-Research, 10VisualEditor, 10Wikipedia-Android-App-Backlog: Perform comparative analysis of mobile editing UIs - https://phabricator.wikimedia.org/T201877 (10iamjessklein) [21:27:17] <wikibugs_> 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Remove ratelimit from Wikidata for some groups again - https://phabricator.wikimedia.org/T198396 (10Bugreporter) Personally we can remove the current rate limit completely as the default 90 edits/minute limit in {T56515} is probably... [21:27:47] <wikibugs_> 10Design, 10Android-app-feature-Description-Editing, 10Design-Research, 10VisualEditor, 10Wikipedia-Android-App-Backlog: Perform comparative analysis of mobile editing UIs - https://phabricator.wikimedia.org/T201877 (10iamjessklein) [21:29:10] <wikibugs_> 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801 (10Volker_E) [21:29:13] <wikibugs_> 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Deprecate and remove 'find' icon - https://phabricator.wikimedia.org/T183645 (10Volker_E) 05Open>03Resolved [21:30:07] <wikibugs_> (03CR) 10Cooltey: [C: 031] PCS CSS endpoint fallback [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/450897 (https://phabricator.wikimedia.org/T193277) (owner: 10Sharvaniharan) [21:30:09] <wikibugs_> 10UI-Standardization, 10OOUI (OOUI-0.28.0): 'userInactive' icon not available on Apex theme – add 'userAnonymous' and deprecate 'userInactive' - https://phabricator.wikimedia.org/T189113 (10Volker_E) 05Open>03Resolved a:03Volker_E [21:33:28] <wikibugs_> (03PS1) 10Fomafix: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 [21:33:57] <wikibugs_> 10Anti-Harassment (AHT Sprint 26): Update PHP APIs to get & set Partial Blocks - https://phabricator.wikimedia.org/T197114 (10dbarratt) [21:37:56] <wikibugs_> 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint), 10Patch-For-Review: New Pages Feed: showing the filter logic (3.3) - https://phabricator.wikimedia.org/T199277 (10MMiller_WMF) @Catrope -- here are a couple options: # Since the "That:" group is all radio buttons, the user can't select mo... [21:39:19] <wikibugs_> (03PS1) 10Fomafix: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) [21:45:48] <wikibugs_> (03PS4) 10Brian Wolff: Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 [21:46:15] <wikibugs_> (03CR) 10Legoktm: [C: 032] Improve tracking of outputting class members [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/443356 (owner: 10Brian Wolff) [21:47:21] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [21:47:35] <wikibugs_> (03Merged) 10jenkins-bot: benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 (owner: 10Krinkle) [21:47:46] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/452524 (owner: 10L10n-bot) [21:48:02] <wikibugs_> (03Merged) 10jenkins-bot: Improve tracking of outputting class members [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/443356 (owner: 10Brian Wolff) [21:50:14] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS [core] - 10https://gerrit.wikimedia.org/r/411387 (owner: 10Jforrester) [21:50:50] <wikibugs_> (03CR) 10jenkins-bot: benchmarks: Add a default to the 'file' option of benchmarkTidy.php [core] - 10https://gerrit.wikimedia.org/r/452408 (owner: 10Krinkle) [21:51:38] <wikibugs_> (03Merged) 10jenkins-bot: benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [21:51:40] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452521 (owner: 10L10n-bot) [21:52:21] <wikibugs_> (03PS1) 10Brian Wolff: resourceloader: Give module eval the ContentSecurityPolicy nonce [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452572 (https://phabricator.wikimedia.org/T196923) [21:52:37] <wikibugs_> (03CR) 10Brian Wolff: [C: 032] resourceloader: Give module eval the ContentSecurityPolicy nonce [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452572 (https://phabricator.wikimedia.org/T196923) (owner: 10Brian Wolff) [21:54:48] <wikibugs_> (03CR) 10jenkins-bot: benchmarks: Add benchmark for JavaScriptMinifier [core] - 10https://gerrit.wikimedia.org/r/452431 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [21:54:54] <wikibugs_> 10MediaWiki-extensions-PageCuration, 10Growth-Team: New pages feed filter Nominated for deletion doesn't work - https://phabricator.wikimedia.org/T169244 (10MMiller_WMF) This was brought up again in community testing related to [[ https://phabricator.wikimedia.org/T193782 | this project ]]. Moving to Growth t... [21:57:21] <wikibugs_> (03PS3) 10Dbrant: [SUPER WIP] Notification activity. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/452387 (https://phabricator.wikimedia.org/T201427) [21:58:57] <wikibugs_> 10Knowledge-Integrity, 10Epic: [2.11] Integrate Citoid in Wikidata - https://phabricator.wikimedia.org/T199197 (10Ocaasi_WMF) a:03Mvolz [21:59:00] <wikibugs_> (03PS1) 10Niedzielski: Hygiene: move page issues A/B test logging to file [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/452573 (https://phabricator.wikimedia.org/T191528) [22:00:21] <wikibugs_> (03CR) 10Krinkle: [C: 032] Add @since to LoadBalancer getServerInfo() per a3096440627 [core] - 10https://gerrit.wikimedia.org/r/452456 (owner: 10Aaron Schulz) [22:00:37] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/452525 (owner: 10L10n-bot) [22:01:27] <wikibugs_> 10Design, 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, and 3 others: Mobile page issues - allow page issues to display different severity levels - https://phabricator.wikimedia.org/T191528 (10Niedzielski) @alexhollender, I'm still digging through the code to respond to your feedback. I've... [22:01:54] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Make HTML generation in RenderedRevision optional [core] - 10https://gerrit.wikimedia.org/r/452567 (https://phabricator.wikimedia.org/T194048) (owner: 10Daniel Kinzler) [22:03:44] <wikibugs_> 10FormWizard: Create a homepage for the FormWizard extension - https://phabricator.wikimedia.org/T201678 (10Eugene233) Created at https://www.mediawiki.org/wiki/Extension:FormWizard [22:05:23] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/452529 (owner: 10L10n-bot) [22:05:34] <wikibugs_> (03CR) 10Krinkle: Use LB server configuration to force DB domains in ExternalStorageDB (031 comment) [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:05:52] <wikibugs_> (03CR) 10Krinkle: [C: 032] Use LB server configuration to force DB domains in ExternalStorageDB [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:14:20] <wikibugs_> 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10nray) Moving this onto the kanbanana-board even though it is... [22:15:46] <wikibugs_> 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801 (10Volker_E) [22:15:49] <wikibugs_> 10UI-Standardization, 10OOUI (OOUI-0.28.0), 10UI-Standardization-Kanban: Rename 'clip' and 'unClip' icons into 'bookmarkOutline' and 'bookmark' - https://phabricator.wikimedia.org/T183601 (10Volker_E) 05Open>03Resolved [22:17:23] <wikibugs_> (03PS2) 10Aaron Schulz: Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) [22:17:31] <wikibugs_> (03CR) 10Phantom42: "Hm, I think CI template should be changed from `extension-quibble` to `extension-quibble-composer`. I will submit a patch to config for th" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [22:18:07] <travis-ci> wikimedia/mediawiki#21721 (master - 0530be5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415659789 [22:19:56] <wikibugs_> 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Replace jQuery.Deferred.done/fail/always() - https://phabricator.wikimedia.org/T188937 (10nray) a:03nray [22:22:46] <wikibugs_> 10Design, 10UI-Standardization, 10WMF-Design, 10OOUI, and 2 others: OOUI/WikimediaUI icon inventory (tracking) - https://phabricator.wikimedia.org/T141801 (10Volker_E) [22:22:53] <wikibugs_> (03CR) 10Legoktm: [C: 032] Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [22:23:21] <wikibugs_> (03Merged) 10jenkins-bot: Add @since to LoadBalancer getServerInfo() per a3096440627 [core] - 10https://gerrit.wikimedia.org/r/452456 (owner: 10Aaron Schulz) [22:23:37] <travis-ci> wikimedia/mediawiki#21722 (master - afcd5b1 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415661841 [22:24:52] <wikibugs_> 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page/namespace - https://phabricator.wikimedia.org/T199917 (10aezell) >! In T199917#4499879, @dbarratt wrote: > > That question looks like it's related to T194697. We have no plans to change the UNIQUE index in this project. @dbarratt or @dmaza correct me... [22:25:47] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452528 (owner: 10L10n-bot) [22:26:30] <wikibugs_> 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10MarkAHershberger) 05Open>03Resolved a:03MarkAHershberger [22:27:17] <wikibugs_> 10MediaWiki-extensions-ParserFunctions: Add `#or:` parser function - https://phabricator.wikimedia.org/T201878 (10MGChecker) [22:27:57] <wikibugs_> 10MediaWiki-extensions-Variables: [Variables] Allow fallback/default values for #vardefine / #vardefineecho - https://phabricator.wikimedia.org/T201846 (10MGChecker) I just created T201878, proposing an `#or` parser function. [22:28:57] <wikibugs_> 10MediaWiki-Templates, 10MediaWiki-extensions-ParserFunctions: Add `#or:` parser function - https://phabricator.wikimedia.org/T201878 (10MGChecker) [22:30:48] <wikibugs_> (03Merged) 10jenkins-bot: Use LB server configuration to force DB domains in ExternalStorageDB [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:31:00] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/452536 (owner: 10L10n-bot) [22:31:10] <travis-ci> wikimedia/mediawiki#21722 (master - afcd5b1 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415661841 [22:31:37] <travis-ci> wikimedia/mediawiki#21722 (master - afcd5b1 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415661841 [22:33:18] <wikibugs_> 10Anti-Harassment (AHT Sprint 26): Update PHP APIs to set Partial Blocks - https://phabricator.wikimedia.org/T197114 (10dbarratt) [22:34:54] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/452534 (owner: 10L10n-bot) [22:36:58] <wikibugs_> (03CR) 10jenkins-bot: Add @since to LoadBalancer getServerInfo() per a3096440627 [core] - 10https://gerrit.wikimedia.org/r/452456 (owner: 10Aaron Schulz) [22:37:44] <wikibugs_> (03PS6) 10Smalyshev: Use separate insert/delete statements to work around Blazegraph bug [core] - 10https://gerrit.wikimedia.org/r/450880 (https://phabricator.wikimedia.org/T201217) [22:37:55] <wikibugs_> 10Core-Platform-Team, 10Security-Team, 10TechCom-RFC, 10Epic, 10Patch-For-Review: Add support for Content-Security-Policy (CSP) headers in MediaWiki - https://phabricator.wikimedia.org/T135963 (10Bawolff) Ok, so status update. We are now testing what we intend to be the initial deployment (Still allow in... [22:38:12] <wikibugs_> (03PS4) 10Dduvall: Refactor builder to support file requirements and run pre-install [blubber] - 10https://gerrit.wikimedia.org/r/451688 [22:39:34] <wikibugs_> (03CR) 10jenkins-bot: Use LB server configuration to force DB domains in ExternalStorageDB [core] - 10https://gerrit.wikimedia.org/r/452453 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:40:13] <wikibugs_> (03CR) 10Krinkle: Use LB server configuration to force DB domains in ExternalStorageDB (031 comment) [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:40:19] <wikibugs_> 10Anti-Harassment, 10TechCom-RFC: RFC: Block users by page/namespace - https://phabricator.wikimedia.org/T199917 (10TBolliger) >>! In T199917#4500009, @aezell wrote: >>! In T199917#4499879, @dbarratt wrote: >> >> That question looks like it's related to T194697. We have no plans to change the UNIQUE index in t... [22:40:29] <wikibugs_> 10MediaWiki-extensions-PageCuration, 10Growth-Team: [betalabs] Special:NewPagesFeed not updated - https://phabricator.wikimedia.org/T201661 (10Etonkovidova) 05Open>03Resolved a:03Etonkovidova Closed as Resolved with the patch from T201253 in place. [22:40:34] <wikibugs_> (03PS3) 10Krinkle: Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:40:52] <wikibugs_> (03CR) 10Krinkle: [C: 032] Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [22:41:50] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/452541 (owner: 10L10n-bot) [22:42:55] <travis-ci> wikimedia/mediawiki#21723 (master - 86c5969 jenkins-bot): The build has errored. - https://travis-ci.org/wikimedia/mediawiki/builds/415672359 [22:43:48] <wikibugs_> 10Phabricator, 10Release-Engineering-Team (Kanban): Unable to log in to Phabricator via MediaWiki on mobile (CSP error) - https://phabricator.wikimedia.org/T201460 (10mmodell) 05Open>03Resolved I'm going to mark this resolved because I believe the issue has been patched by rPHEX55ebacf7f022, please reopen... [22:46:42] <wikibugs_> 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10EBernhardson) I'll echo smalyshev, for experimentation the most important thing was to make sure mediawiki-vagrant works for our use case. There is maintenance work to keep it mw... [22:46:44] <wikibugs_> 04(no projects): Remove articles from reading lists does not remove the articles' offline data - https://phabricator.wikimedia.org/T201879 (10cooltey) [22:47:59] <wikibugs_> (03PS3) 10Mooeypoo: Fix global settings overriding local ones [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452026 (https://phabricator.wikimedia.org/T201340) (owner: 10MaxSem) [22:49:00] <wikibugs_> 10MediaWiki-extensions-PageCuration, 10Growth-Team (Current Sprint), 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review: Special:NewPagesFeed should ignore ptrp_reviewed status for Drafts - https://phabricator.wikimedia.org/T201253 (10Etonkovidova) 05Open>03Resolved Yes... [22:49:24] <wikibugs_> (03CR) 10EBernhardson: [C: 032] Use separate insert/delete statements to work around Blazegraph bug [core] - 10https://gerrit.wikimedia.org/r/450880 (https://phabricator.wikimedia.org/T201217) (owner: 10Smalyshev) [22:51:29] <wikibugs_> 10Phabricator, 10Release-Engineering-Team (Kanban): Unable to log in to Phabricator via MediaWiki on mobile (CSP error) - https://phabricator.wikimedia.org/T201460 (10Krinkle) >>! In T201460#4500052, @mmodell wrote: > I'm going to mark this resolved because I believe the issue has been patched by rPHEX55ebacf7... [22:53:33] <wikibugs_> (03Merged) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [22:53:35] <wikibugs_> 10MediaWiki-User-management, 10I18n: [[MediaWiki:Ipboptions/mni]] translation issue - https://phabricator.wikimedia.org/T201854 (10MarcoAurelio) [22:53:38] <wikibugs_> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/452547 (owner: 10L10n-bot) [22:54:04] <wikibugs_> 04(no projects): Able to schedule a time of switching the app theme automatically - https://phabricator.wikimedia.org/T201880 (10cooltey) [22:54:45] <wikibugs_> 10Phabricator, 10Gerrit, 10Release-Engineering-Team (Someday): Stop using Differential for code review - https://phabricator.wikimedia.org/T191182 (10dduvall) [22:56:32] <wikibugs_> (03CR) 10Krinkle: [C: 032] rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 (owner: 10Aaron Schulz) [22:57:01] <wikibugs_> 10MediaWiki-User-management, 10I18n: [[MediaWiki:Ipboptions/mni]] translation issue - https://phabricator.wikimedia.org/T201854 (10MarcoAurelio) I think the user [[ https://translatewiki.net/w/i.php?title=MediaWiki:Ipboptions/mni&diff=prev&oldid=8273932 | manually added the `!!FUZZY!!` word ]] hence the system... [22:57:29] <wikibugs_> 10Community-IdeaLab, 10FormWizard: FormWizard Gadget can be configured to use revisionuser name as page title - https://phabricator.wikimedia.org/T90261 (10Harej) [22:58:40] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] [DNM] Benchmark comparing JavaScriptMinifier and MinifyJS [core] - 10https://gerrit.wikimedia.org/r/411387 (owner: 10Jforrester) [22:59:18] <wikibugs_> (03CR) 10Brian Wolff: "yes you are right" [core] - 10https://gerrit.wikimedia.org/r/445846 (owner: 10Brian Wolff) [22:59:22] <wikibugs_> (03CR) 10Thcipriani: [C: 031] "nit: blubber.example.yaml no longer unmarshals" [blubber] - 10https://gerrit.wikimedia.org/r/451688 (owner: 10Dduvall) [23:00:00] <wikibugs_> (03Merged) 10jenkins-bot: Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [23:00:13] <wikibugs_> (03PS3) 10Brian Wolff: Fix some warnings from phan-taint-check [core] - 10https://gerrit.wikimedia.org/r/445846 [23:00:53] <wikibugs_> (03CR) 10Jforrester: [C: 032] Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:01:10] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Fix global settings overriding local ones [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452026 (https://phabricator.wikimedia.org/T201340) (owner: 10MaxSem) [23:02:49] <travis-ci> wikimedia/mediawiki#21724 (master - 28f6e2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415674620 [23:03:00] <wikibugs_> (03CR) 10Phantom42: "Done. See https://gerrit.wikimedia.org/r/c/integration/config/+/452580" [extensions/Mailgun] - 10https://gerrit.wikimedia.org/r/440118 (https://phabricator.wikimedia.org/T185906) (owner: 10Phantom42) [23:04:13] <wikibugs_> 04(no projects): Texts in collapsed tables are not searchable - https://phabricator.wikimedia.org/T201882 (10cooltey) [23:04:27] <travis-ci> wikimedia/mediawiki#21724 (master - 28f6e2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415674620 [23:04:44] <wikibugs_> (03CR) 10jenkins-bot: Use LB server configuration to force DB domains in ExternalStorageDB [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/452455 (https://phabricator.wikimedia.org/T200471) (owner: 10Aaron Schulz) [23:04:58] <wikibugs_> (03CR) 10Prtksxna: [C: 032] Add `border-style-base` variable [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [23:05:40] <wikibugs_> (03Merged) 10jenkins-bot: Add `border-style-base` variable [wikimedia-ui-base] - 10https://gerrit.wikimedia.org/r/452025 (owner: 10VolkerE) [23:07:24] <travis-ci> wikimedia/mediawiki#21724 (master - 28f6e2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415674620 [23:09:39] <travis-ci> wikimedia/mediawiki#21724 (master - 28f6e2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415674620 [23:14:05] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Use separate insert/delete statements to work around Blazegraph bug [core] - 10https://gerrit.wikimedia.org/r/450880 (https://phabricator.wikimedia.org/T201217) (owner: 10Smalyshev) [23:15:22] <wikibugs_> 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10DarTar) Adding @Ottomata for visibility on the EventStream side of things. [23:15:53] <wikibugs_> 10WMSE-Riksarkivet-TORA: Get Libris <-> Wikidata in LOD - Linked Open Data Cloud - https://phabricator.wikimedia.org/T201268 (10Salgo60) [23:15:54] <wikibugs_> (03CR) 10Jforrester: [C: 031] Don't have different cache TTL for ~~~ [core] - 10https://gerrit.wikimedia.org/r/450632 (owner: 10simetrical) [23:16:21] <wikibugs_> (03CR) 10Jforrester: [C: 031] Improve test coverage for ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/425528 (owner: 10simetrical) [23:17:04] <wikibugs_> 04(no projects): Flag icons do not show in certain article - https://phabricator.wikimedia.org/T201884 (10cooltey) [23:17:28] <wikibugs_> (03PS2) 10Jforrester: Language: Create new private static function getCodeFromClass [core] - 10https://gerrit.wikimedia.org/r/452563 (owner: 10Fomafix) [23:17:50] <wikibugs_> (03CR) 10Jforrester: "Is this just for easier reading of the code, or do you see it being re-used elsewhere?" [core] - 10https://gerrit.wikimedia.org/r/452563 (owner: 10Fomafix) [23:18:24] <wikibugs_> 10MediaWiki-Internationalization, 10I18n, 10User-MarcoAurelio: Add MessagesSco.php - https://phabricator.wikimedia.org/T201462 (10MarcoAurelio) Thanks for the translations @jrbs I've found, for example that User, according to http://www.dsl.ac.uk/entry/dost/usar should be Usar? Collogue is recognized by th... [23:18:42] <wikibugs_> 10MediaWiki-Internationalization, 10I18n, 10User-MarcoAurelio: Add MessagesSco.php - https://phabricator.wikimedia.org/T201462 (10MarcoAurelio) [23:20:05] <wikibugs_> 10MediaWiki-Internationalization, 10I18n, 10User-MarcoAurelio: Add MessagesSco.php - https://phabricator.wikimedia.org/T201462 (10MarcoAurelio) [23:20:57] <wikibugs_> (03CR) 10Brian Wolff: "Ok, change in unit tests caused by aae41b4d86, which causes no_override to no longer propagate during markAllDependentMethodsExec(), so it" [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [23:21:14] <wikibugs_> (03PS1) 10MarcoAurelio: [WIP] Add MessagesSco.php [core] - 10https://gerrit.wikimedia.org/r/452582 (https://phabricator.wikimedia.org/T201462) [23:22:00] <wikibugs_> (03CR) 10Jforrester: "recheck" [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/451263 (owner: 10simetrical) [23:22:11] <wikibugs_> (03CR) 10Jforrester: "recheck" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/451262 (owner: 10simetrical) [23:23:13] <wikibugs_> (03PS5) 10Brian Wolff: Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 [23:23:43] <wikibugs_> 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [2.1.143-alpha-2016-03-18] 'Find in page' cannot search collapsed tables - https://phabricator.wikimedia.org/T130403 (10Dbrant) [23:23:47] <wikibugs_> 04(no projects): Texts in collapsed tables are not searchable - https://phabricator.wikimedia.org/T201882 (10Dbrant) [23:24:51] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [23:24:55] <wikibugs_> (03PS7) 10Smalyshev: Use separate insert/delete statements to work around Blazegraph bug [core] - 10https://gerrit.wikimedia.org/r/450880 (https://phabricator.wikimedia.org/T201217) [23:25:15] <wikibugs_> 10Wikipedia-Android-App-Backlog: Add support for auto night mode - https://phabricator.wikimedia.org/T128044 (10Dbrant) [23:25:17] <wikibugs_> 04(no projects): Able to schedule a time of switching the app theme automatically - https://phabricator.wikimedia.org/T201880 (10Dbrant) [23:26:09] <wikibugs_> (03CR) 10Jforrester: "This is a breaking change which is marked as depending on the two patches (in TitleBlacklist and Scribunto) which can't be merged until th" [core] - 10https://gerrit.wikimedia.org/r/451261 (owner: 10simetrical) [23:26:41] <wikibugs_> (03Merged) 10jenkins-bot: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 (owner: 10Aaron Schulz) [23:26:44] <wikibugs_> (03CR) 10jenkins-bot: Replace deprecated Linker::link() with LinkRenderer [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452571 (https://phabricator.wikimedia.org/T149346) (owner: 10Fomafix) [23:28:06] <wikibugs_> (03PS2) 10Jforrester: Don't call static methods on CoreParserFunctions [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/451263 (owner: 10simetrical) [23:28:27] <wikibugs_> (03CR) 10Jforrester: "PS2: Update MW version dependency in extension.json." [extensions/TitleBlacklist] - 10https://gerrit.wikimedia.org/r/451263 (owner: 10simetrical) [23:30:01] <wikibugs_> (03CR) 10jenkins-bot: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 (owner: 10Aaron Schulz) [23:31:14] <wikibugs_> (03PS3) 10Brian Wolff: Paranoia, escape image alignment parameters before outputting. [core] - 10https://gerrit.wikimedia.org/r/440141 [23:32:33] <wikibugs_> (03CR) 10Brian Wolff: "I went with concatenation instead of string interopolation because I thought it looked easier to read, but I don't have any actual prefere" [core] - 10https://gerrit.wikimedia.org/r/440141 (owner: 10Brian Wolff) [23:33:10] <wikibugs_> (03PS5) 10Dduvall: Refactor builder to support file requirements and run pre-install [blubber] - 10https://gerrit.wikimedia.org/r/451688 [23:34:13] <wikibugs_> (03PS6) 10Brian Wolff: Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 [23:35:45] <wikibugs_> (03CR) 10jerkins-bot: [V: 04-1] Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [23:39:29] <wikibugs_> (03Merged) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:40:54] <travis-ci> wikimedia/mediawiki#21725 (master - b678edc jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415690352 [23:44:53] <wikibugs_> (03PS7) 10Brian Wolff: Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 [23:47:22] <wikibugs_> (03CR) 10jenkins-bot: resourceloader: Give module eval the ContentSecurityPolicy nonce [core] (wmf/1.32.0-wmf.16) - 10https://gerrit.wikimedia.org/r/452572 (https://phabricator.wikimedia.org/T196923) (owner: 10Brian Wolff) [23:48:13] <wikibugs_> (03CR) 10Brian Wolff: [C: 032] "Legoktm already +2'd it earlier, just fixed some unit tests broken by recently merged patches." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [23:48:57] <wikibugs_> (03PS5) 10Jforrester: Convert CoreParserFunctions to service [core] - 10https://gerrit.wikimedia.org/r/451261 (owner: 10simetrical) [23:49:06] <wikibugs_> (03CR) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452570 (owner: 10Fomafix) [23:49:31] <wikibugs_> (03CR) 10Jforrester: "PS5: Quick rebase; re-written the commit message to be the "right" way around, I think?" [core] - 10https://gerrit.wikimedia.org/r/451261 (owner: 10simetrical) [23:50:20] <wikibugs_> (03Merged) 10jenkins-bot: Refactor docblock taint annotation to support docblocks on interfaces [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/445848 (owner: 10Brian Wolff) [23:50:31] <wikibugs_> (03PS6) 10Jforrester: Convert CoreParserFunctions to service [core] - 10https://gerrit.wikimedia.org/r/451261 (owner: 10simetrical) [23:50:54] <wikibugs_> (03CR) 10Jforrester: "PS6: Oops, didn't mean to change the alpha sorting in ServiceWiring. Fixed." [core] - 10https://gerrit.wikimedia.org/r/451261 (owner: 10simetrical) [23:51:12] <legoktm> James_F: I think we might do the CoreParserFunctions/CoreTagHooks patches differently, I talked with Aryeh a bit about it [23:51:41] <travis-ci> wikimedia/mediawiki#21725 (master - b678edc jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415690352 [23:51:46] <James_F> legoktm: Ah, is there a task? [23:53:35] <James_F> legoktm: Or just IRC chat? [23:53:48] <legoktm> James_F: just IRC right now, I can file a task in a bit [23:54:02] <legoktm> mostly it was "I don't think this is the right approach, but I'm not sure what the right one is" [23:54:04] <James_F> No worries. [23:54:32] <James_F> I thought rebasing this might be a good way to remind myself how this code works. :-) [23:54:56] <legoktm> I need to rebase and re-review the SpecialPageFactory stack, but those should be ready for review+merge tonight [23:55:14] <James_F> Kk. [23:57:40] <wikibugs_> (03PS1) 10Brian Wolff: Update phan-taint-check to 1.3.0. Hopefully should pass now [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/452587 (https://phabricator.wikimedia.org/T197002) [23:58:08] <wikibugs_> (03PS1) 10Krinkle: resourceloader: Remove support for `state(name, state)` signature [core] - 10https://gerrit.wikimedia.org/r/452588 [23:58:54] <wikibugs_> 10MediaWiki-extensions-NavigationTiming, 10Performance-Team, 10Patch-For-Review: Reduce overhead of navtiming beacon - https://phabricator.wikimedia.org/T192862 (10Krinkle) [23:59:43] <wikibugs_> (03CR) 10Jforrester: "> Patch Set 1: Code-Review-2" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/223213 (https://phabricator.wikimedia.org/T58845) (owner: 10Legoktm)