[00:11:02] 10VisualEditor (Current work): Set up test instance for user testing editing prototypes - https://phabricator.wikimedia.org/T201538 (10Krinkle) I recently stumbled upon [[ https://en.wikipedia.org/wiki/Special:ExpandTemplates?wpContextTitle=Barack_Obama&wpInput={{:Barack_Obama}} | Special:ExpandTemplates]] as an... [00:50:21] (03PS3) 10Brion VIBBER: ForkableMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [00:57:53] (03CR) 10jerkins-bot: [V: 04-1] ForkableMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 (owner: 10Brion VIBBER) [01:08:11] (03PS4) 10Brion VIBBER: ForkableMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [01:10:50] 10MediaWiki-extensions-DonationInterface, 10Fr-Ingenico-integration_2017-18, 10Fundraising-Backlog: Deal with Ingenico Connect code 300620: MerchantReference XXXX already exists - https://phabricator.wikimedia.org/T201773 (10Ejegg) [01:11:19] (03PS5) 10Brion VIBBER: ForkableMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [01:20:47] 10Refreshed: Refreshed skin: thoughts on the future (Refreshed 4?) - https://phabricator.wikimedia.org/T200303 (10georgebarnick) @MtMNC I agree completely, personally I don't like the header dropdowns being triggered on-hover. Clicking seems much more intuitive and less annoying, and like you said translates to... [01:29:50] brion: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Score/+/451873 ? Why doesn't the codec declaration work (and in the meantime review)? [01:30:01] Thanks! [01:49:47] (03CR) 10Brion VIBBER: [C: 032] "Let's re-check this in future after removing the old kaltura frontend, but this should be fine for now." [extensions/Score] - 10https://gerrit.wikimedia.org/r/451873 (owner: 10Ebe123) [01:51:10] What's this about the new frontend? Will T135501 be solved as a result? [01:51:11] T135501: Formalize how TMH provides a player for Score generated ogg/vorbis files - https://phabricator.wikimedia.org/T135501 [01:54:38] Ebe123: once some more things get fixed we'll move from the kaltura frontend to videojs frontend [01:54:53] doesn't directly solve making sure the interface is consistent for score but it'll help [01:55:00] since we can more aggressively trim out the old stuff :D [01:55:23] (03Merged) 10jenkins-bot: Remove codec declaration from MIME type [extensions/Score] - 10https://gerrit.wikimedia.org/r/451873 (owner: 10Ebe123) [01:56:23] Great! Hope we'll be able to repeat the audio then! (T201689...) [01:56:24] T201689: Playing midi again after listening all the way to the end doesn't work on chrome - https://phabricator.wikimedia.org/T201689 [02:41:46] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Marshallsumter) [03:36:17] (03CR) 10Legoktm: "> is there another reason to support both?" [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [04:07:41] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Legoktm) @Eugene233 as far as I can see, you're already an owner of the FormWizard extension. Can you explain what you're trying to do and what error/problem you... [04:36:32] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Eugene233) >>! In T201771#4496806, @Legoktm wrote: > @Eugene233 as far as I can see, you're already an owner of the FormWizard extension. Can you explain what you... [04:43:40] (03CR) 10TTO: [C: 031] Require editsitecss/editsitejs for editing raw messages [core] - 10https://gerrit.wikimedia.org/r/449626 (https://phabricator.wikimedia.org/T45646) (owner: 10Gergő Tisza) [04:45:21] (03PS25) 10Legoktm: Mass conversion of $wgContLang to service [core] - 10https://gerrit.wikimedia.org/r/448094 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [04:47:51] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Legoktm) Click "Reply...", and that will open up the review actions so that you can add Code-Review +2. [04:49:35] (03CR) 10Eugene233: [V: 032 C: 032] "Code-Review +2" [extensions/FormWizard] - 10https://gerrit.wikimedia.org/r/452034 (https://phabricator.wikimedia.org/T201726) (owner: 10Eugene233) [04:50:19] (03CR) 10Legoktm: [C: 032] Use ContentLanguage service instead of global $wgContLang [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/450416 (owner: 10Fomafix) [04:50:42] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Eugene233) >>! In T201771#4496816, @Legoktm wrote: > Click "Reply...", and that will open up the review actions so that you can add Code-Review +2. This makes a... [04:50:59] (03CR) 10Legoktm: [C: 032] Use ContentLanguage service instead of global $wgContLang [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450415 (owner: 10Fomafix) [04:51:16] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Eugene233) 05Open>03declined p:05Triage>03Lowest [04:51:50] (03CR) 10Legoktm: "recheck" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [04:56:27] (03Merged) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/450416 (owner: 10Fomafix) [04:58:20] (03CR) 10jerkins-bot: [V: 04-1] Get Parser from service instead of global $wgParser [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [04:58:54] (03CR) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/450416 (owner: 10Fomafix) [05:00:53] (03Merged) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450415 (owner: 10Fomafix) [05:01:44] (03CR) 10Legoktm: "The way this module interacts with the Parser is really ugly (accessing member variables directly). I can't think of anything obvious as t" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [05:03:22] (03CR) 10jenkins-bot: Use ContentLanguage service instead of global $wgContLang [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450415 (owner: 10Fomafix) [05:27:51] 10WMF-Legal, 10Wikimedia-Blog, 10Software-Licensing: Publish Wikimedia's WordPress blog theme in Git - https://phabricator.wikimedia.org/T95129 (10Legoktm) Just to clarify the current status, the only thing missing here is an explicit license on the published code. https://wordpress.org/news/2009/07/themes-a... [05:55:22] 10Wikimedia-Site-requests: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Dcljr) In case anyone is confused by the description (since X falls later in the English alphabet than H): What @Serkanland means is that X // immediately // follows H... [06:07:32] (03CR) 10Legoktm: "After sitting on it a bit, I'm still pretty uncomfortable with E_DEPRECATED right away. Since we still want to keep the function names the" [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [06:08:24] 10Wikimedia-Site-requests: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Serkanland) Yeap [06:16:35] (03CR) 10Legoktm: [C: 032] Mass conversion of $wgContLang to service [core] - 10https://gerrit.wikimedia.org/r/448094 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [06:19:55] (03PS4) 10Legoktm: Give pages with ~~~~ a different cache TTL [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [06:20:11] (03CR) 10Legoktm: [C: 032] "Per Aaron" [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [06:22:16] (03CR) 10Legoktm: [C: 032] SpecialMyLanguage: Get content language from service [core] - 10https://gerrit.wikimedia.org/r/450246 (owner: 10Fomafix) [06:24:05] (03CR) 10Legoktm: [C: 032] Add type hint for ParserOutput [core] - 10https://gerrit.wikimedia.org/r/448745 (owner: 10Fomafix) [06:24:37] (03CR) 10Legoktm: [C: 04-1] "Per inline comments" [core] - 10https://gerrit.wikimedia.org/r/443961 (owner: 10Awight) [06:25:17] (03CR) 10Legoktm: [C: 04-1] "At the very least, this needs a much better commit message than one word: (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/450068 (https://phabricator.wikimedia.org/T183885) (owner: 10Darien cot) [06:29:03] (03CR) 10Legoktm: Only use "*Test.php" for actual PHPUnit tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/451641 (https://phabricator.wikimedia.org/T201278) (owner: 10simetrical) [06:30:20] (03CR) 10Legoktm: "I've tagged wikimedia/timestamp 2.0.0, so this is ready to merge now." [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [06:30:42] (03CR) 10Legoktm: "recheck" [libs/XMPReader] - 10https://gerrit.wikimedia.org/r/452028 (owner: 10Legoktm) [06:32:40] (03PS8) 10Legoktm: Update comment [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [06:34:08] (03CR) 10Legoktm: [C: 04-1] "This comment should be removed entirely now that 1174776e47c764c0aa84c5eb3d93e22c27790619 was merged." [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [06:34:55] (03Merged) 10jenkins-bot: Mass conversion of $wgContLang to service [core] - 10https://gerrit.wikimedia.org/r/448094 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [06:37:48] (03CR) 10jenkins-bot: Mass conversion of $wgContLang to service [core] - 10https://gerrit.wikimedia.org/r/448094 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [06:39:01] (03CR) 10Legoktm: NamespaceServices service to replace MWNamespace (032 comments) [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [06:43:03] (03CR) 10Legoktm: [C: 04-1] "Code looks fine, -1 is for the naming." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [06:43:55] (03Merged) 10jenkins-bot: Give pages with ~~~~ a different cache TTL [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [06:44:58] 10WMSE-Riksarkivet-TORA: Church parish "församling" is changing name - https://phabricator.wikimedia.org/T200500 (10Salgo60) [06:46:36] (03CR) 10jenkins-bot: Give pages with ~~~~ a different cache TTL [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [06:47:18] (03CR) 10Legoktm: [C: 04-1] "> Instead of from" [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [06:47:19] wikimedia/mediawiki#21702 (master - 90d4f56 Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038012 [06:48:17] (03PS2) 10Legoktm: Combine the two modules to one module [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450089 (owner: 10Fomafix) [06:48:44] (03CR) 10Legoktm: [C: 032] Combine the two modules to one module [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450089 (owner: 10Fomafix) [06:49:05] (03PS2) 10Legoktm: Use mw.Title.makeTitle( 14, cat ) instead of new mw.Title( cat, 14 ) [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450459 (owner: 10Fomafix) [06:49:14] wikimedia/mediawiki#21702 (master - 90d4f56 Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038012 [06:50:10] (03Merged) 10jenkins-bot: SpecialMyLanguage: Get content language from service [core] - 10https://gerrit.wikimedia.org/r/450246 (owner: 10Fomafix) [06:50:30] (03CR) 10Legoktm: "> Patch Set 1:" [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450459 (owner: 10Fomafix) [06:52:51] (03CR) 10jenkins-bot: SpecialMyLanguage: Get content language from service [core] - 10https://gerrit.wikimedia.org/r/450246 (owner: 10Fomafix) [06:55:57] wikimedia/mediawiki#21702 (master - 90d4f56 Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038012 [06:57:07] wikimedia/mediawiki#21702 (master - 90d4f56 Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038012 [06:59:22] 10WMSE-Riksarkivet-NAD: When is new archives created - https://phabricator.wikimedia.org/T201775 (10Salgo60) [06:59:54] 10MediaWiki-Core-Tests, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Wikimedia-log-errors (Shared Build Failure): TitlePermissionTest failing on travis-ci after ParserFactory? service conversion - https://phabricator.wikimedia.org/T201776 (10Legoktm) [07:00:41] 10WMSE-Riksarkivet-NAD: When is new archives created - https://phabricator.wikimedia.org/T201775 (10Salgo60) [07:00:54] 10WMSE-Riksarkivet-NAD: When is new archives created at Riksarkivet with unique NADs - https://phabricator.wikimedia.org/T201775 (10Salgo60) [07:01:55] 10MediaWiki-extensions-Page_Forms, 10I18n, 10Patch-For-Review: Unable to use {{int}} inside {{for template}} - https://phabricator.wikimedia.org/T49736 (10Thai) >>! In T49736#3975539, @Nikerabbit wrote: > > `label` is still not accepting `{{int}}`, but `add button text` is fixed. Above patch should solve t... [07:03:24] (03Merged) 10jenkins-bot: Add type hint for ParserOutput [core] - 10https://gerrit.wikimedia.org/r/448745 (owner: 10Fomafix) [07:03:26] (03Merged) 10jenkins-bot: Combine the two modules to one module [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450089 (owner: 10Fomafix) [07:04:05] (03CR) 10jenkins-bot: Give pages with ~~~~ a different cache TTL [core] - 10https://gerrit.wikimedia.org/r/450631 (owner: 10simetrical) [07:06:22] (03CR) 10jenkins-bot: Add type hint for ParserOutput [core] - 10https://gerrit.wikimedia.org/r/448745 (owner: 10Fomafix) [07:06:31] wikimedia/mediawiki#21703 (master - 3e5be2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038940 [07:06:53] 10MediaWiki-extensions-Page_Forms, 10Patch-For-Review: for template tag does not support {{int:}} in the label - https://phabricator.wikimedia.org/T123469 (10Thai) >>! In T123469#1974252, @Fannon wrote: > > The previous patch didn't fix the problem. It seems that $sub_components[0] is not correctly split when... [07:07:09] wikimedia/mediawiki#21703 (master - 3e5be2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038940 [07:07:42] wikimedia/mediawiki#21703 (master - 3e5be2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038940 [07:08:26] wikimedia/mediawiki#21703 (master - 3e5be2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415038940 [07:11:25] (03PS8) 10simetrical: Factor Setup config initialization into function [core] - 10https://gerrit.wikimedia.org/r/451637 [07:11:27] (03PS8) 10simetrical: Reset all settings to default for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/451638 [07:15:43] (03CR) 10Legoktm: [C: 032] "CI should be fixed with T201777." [core] - 10https://gerrit.wikimedia.org/r/451681 (https://phabricator.wikimedia.org/T173899) (owner: 10simetrical) [07:17:46] wikimedia/mediawiki#21704 (master - 9bd9b2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415039540 [07:18:49] wikimedia/mediawiki#21704 (master - 9bd9b2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415039540 [07:19:22] wikimedia/mediawiki#21704 (master - 9bd9b2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415039540 [07:21:17] wikimedia/mediawiki#21704 (master - 9bd9b2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415039540 [07:22:09] this is gonna be annoying [07:28:37] wikimedia/mediawiki#21704 (master - 9bd9b2f jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415039540 [07:29:08] (03CR) 10simetrical: Get Parser from service instead of global $wgParser (031 comment) [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 (owner: 10Fomafix) [07:30:20] wikimedia/mediawiki#21705 (master - fe25fde jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415041758 [07:32:03] (03CR) 10Legoktm: "Impact to extensions (via codesearch): as far as I can tell, this will affect the MediaWikiFarm and UserGroups extensions. Only the former" [core] - 10https://gerrit.wikimedia.org/r/451636 (owner: 10simetrical) [07:32:15] (03CR) 10jerkins-bot: [V: 04-1] Reset all settings to default for PHPUnit tests [core] - 10https://gerrit.wikimedia.org/r/451638 (owner: 10simetrical) [07:32:42] (03CR) 10jerkins-bot: [V: 04-1] Factor Setup config initialization into function [core] - 10https://gerrit.wikimedia.org/r/451637 (owner: 10simetrical) [07:33:27] wikimedia/mediawiki#21705 (master - fe25fde jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415041758 [07:36:38] (03Merged) 10jenkins-bot: Delete autoload.ide.php [core] - 10https://gerrit.wikimedia.org/r/451681 (https://phabricator.wikimedia.org/T173899) (owner: 10simetrical) [07:38:25] wikimedia/mediawiki#21705 (master - fe25fde jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415041758 [07:38:55] wikimedia/mediawiki#21705 (master - fe25fde jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415041758 [07:39:03] 10Core-Platform-Team: Add pre-commit hook that does basic checks like php -l - https://phabricator.wikimedia.org/T201778 (10Simetrical) [07:39:09] (03CR) 10jenkins-bot: Delete autoload.ide.php [core] - 10https://gerrit.wikimedia.org/r/451681 (https://phabricator.wikimedia.org/T173899) (owner: 10simetrical) [07:44:26] 10WMSE-Riksarkivet-NAD: When is new archives created at Riksarkivet with unique NADs - https://phabricator.wikimedia.org/T201775 (10Salgo60) [07:47:56] (03PS9) 10simetrical: Update comment [core] - 10https://gerrit.wikimedia.org/r/450432 [07:47:58] (03PS10) 10simetrical: NamespaceServices service to replace MWNamespace [core] - 10https://gerrit.wikimedia.org/r/450433 [07:48:00] (03PS9) 10simetrical: Update LinkRenderer to use NamespaceServices [core] - 10https://gerrit.wikimedia.org/r/450454 [07:48:02] (03PS9) 10simetrical: Update Parser to use NamespaceServices [core] - 10https://gerrit.wikimedia.org/r/450455 [07:48:04] (03PS8) 10simetrical: Update DefaultPreferencesFactory to use NamespaceServices [core] - 10https://gerrit.wikimedia.org/r/450456 [07:48:06] (03PS10) 10simetrical: Update MediaWikiTitleCodec to use NamespaceServices [core] - 10https://gerrit.wikimedia.org/r/450457 [07:48:57] wikimedia/mediawiki#21706 (master - 6c2a31b jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415045898 [07:49:20] wikimedia/mediawiki#21706 (master - 6c2a31b jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415045898 [07:50:30] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Daniel, 10User-Smalyshev: Provide another way to surface usage instructions besides tacking them onto descriptions - https://phabricator.wikimedia.org/T97566 (10Smalyshev) I think the way to solve the issue is to use `P2559`. For this to happen,... [07:51:54] 10MediaWiki-extensions-EducationProgram, 10Education-Program-Dashboard, 10Epic: Remove the EducationProgram extension from individual wikis - https://phabricator.wikimedia.org/T188411 (10Amire80) [07:54:13] (03CR) 10simetrical: NamespaceServices service to replace MWNamespace (033 comments) [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [07:58:03] wikimedia/mediawiki#21706 (master - 6c2a31b jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415045898 [07:58:21] wikimedia/mediawiki#21706 (master - 6c2a31b jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415045898 [08:01:46] (03PS10) 10simetrical: Remove outdated comment [core] - 10https://gerrit.wikimedia.org/r/450432 [08:01:48] (03PS11) 10simetrical: NamespaceInfo service to replace MWNamespace [core] - 10https://gerrit.wikimedia.org/r/450433 [08:01:50] (03PS10) 10simetrical: Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 [08:01:52] (03PS10) 10simetrical: Update Parser to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450455 [08:01:54] (03PS9) 10simetrical: Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 [08:01:56] (03PS11) 10simetrical: Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 [08:02:51] 10FormWizard, 10Repository-Ownership-Requests: Request repository ownership for FormWizard Extension, - https://phabricator.wikimedia.org/T201771 (10Aklapper) @Peachey88: That does not answer my question - security is just one factor [08:06:31] 10Core-Platform-Team: Add pre-commit hook that does basic checks like php -l - https://phabricator.wikimedia.org/T201778 (10Aklapper) @Simetrical: Has the #Core-Platform-Team agreed that this should be on their team's workboard? Furthermore, I don't see any relation to that team in this task. This sounds like #... [08:08:21] 10WMSE-Riksarkivet-TORA: Church parish "församling" is changing name - https://phabricator.wikimedia.org/T200500 (10Salgo60) [08:08:52] (03CR) 10Legoktm: [C: 032] Remove outdated comment [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [08:13:04] 10MediaWiki-Core-Tests, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Technical-Debt: autoload.ide.php needs to be updated or removed - https://phabricator.wikimedia.org/T173899 (10Legoktm) 05Open>03Resolved a:03Simetrical [08:14:40] (03CR) 10simetrical: "> Patch Set 7:" [core] - 10https://gerrit.wikimedia.org/r/451011 (https://phabricator.wikimedia.org/T200506) (owner: 10Krinkle) [08:19:19] legoktm: So you want what, MediaWiki\SpecialPage\SpecialPageFactory? [08:19:25] Or MediaWiki\Special\SpecialPageFactory? [08:21:22] legoktm: Also, do you want the same change in the CoreParserFunctions patch, or is that okay because there are so few callers? [08:22:01] (03PS3) 10simetrical: Don't have different cache TTL for ~~~ [core] - 10https://gerrit.wikimedia.org/r/450632 [08:22:03] (03PS13) 10simetrical: Improve test coverage for ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/425528 [08:22:12] (03PS5) 10Fomafix: Add type hint Language where possible [core] - 10https://gerrit.wikimedia.org/r/443288 [08:23:14] (03CR) 10jerkins-bot: [V: 04-1] NamespaceInfo service to replace MWNamespace [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [08:24:18] (03CR) 10Fomafix: "Rebased after merge conflict." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443288 (owner: 10Fomafix) [08:25:20] AryehGregor: MediaWiki\Special\SpecialPageFactory based on the proposed layout in https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/tools/namespaceizer/+/master/src/CoreAliases.php#104 [08:25:56] legoktm: Okay. [08:26:14] (03PS4) 10simetrical: Don't have different cache TTL for ~~~ [core] - 10https://gerrit.wikimedia.org/r/450632 [08:26:16] (03PS14) 10simetrical: Improve test coverage for ApiStashEdit [core] - 10https://gerrit.wikimedia.org/r/425528 [08:27:18] AryehGregor: And I'm not really sure about whether CoreParserFunctions/TagHooks make sense as services. [08:27:49] legoktm: Hmm, okay. Where should the static state go, then? [08:27:54] * AryehGregor double-check that they have any [08:27:55] 10MediaWiki-extensions-Html2Wiki: Internal error during upload - https://phabricator.wikimedia.org/T201296 (10jmt) Hello all, the first error: [6cba77a0bcf0886c9b5d5352] /index.php?title=Special:Html2Wiki&action=submit Error from line 711 of /var/www/mediawiki/extensions/Html2Wiki/specials/SpecialHtml2Wiki.php:... [08:28:23] Yeah, they use services and config. [08:28:31] 10MediaWiki-extensions-Html2Wiki: Internal error during upload - https://phabricator.wikimedia.org/T201296 (10jmt) 05Open>03Resolved [08:28:40] Although they could maybe slurp that off the parser? [08:28:47] That probably makes more sense. [08:29:45] we haven't really figured out how to get rid of static state from hooks yet [08:29:57] there are a few different approaches in extensions, and a few phab tasks discussing different ideas [08:30:20] legoktm: The hooks are all passed a Parser object, so it makes sense to just use the state of the parser, right? [08:30:36] 10ContentTranslation, 10WorkType-Maintenance: In some articles ContentTranslation shows the reference card only the first instance of a repeated named reference - https://phabricator.wikimedia.org/T111634 (10Amire80) 05Open>03Resolved Cannot reproduce in CX2. Tried in Achilles tendon rupture and several ot... [08:30:53] (03CR) 10jerkins-bot: [V: 04-1] Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 (owner: 10simetrical) [08:31:11] AryehGregor: yeah. but does the parser have all the state that the parser functions need? [08:32:41] (03Merged) 10jenkins-bot: Remove outdated comment [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [08:32:43] legoktm: CoreParserFunctions need three config options, GenderCache, and LinkCache. CoreTagHooks need only one config option. Parser does use config and should have it injected instead of using globals. [08:32:54] LinkCache and GenderCache aren't currently used directly by Parser. [08:33:13] Oh, yes they are. [08:33:16] LinkCache is, anyway. [08:33:25] GenderCache isn't. [08:34:09] So everything but GenderCache could be extracted from the Parser, at least. [08:35:16] (03CR) 10jenkins-bot: Remove outdated comment [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [08:35:32] https://gerrit.wikimedia.org/g/mediawiki/extensions/ArticlePlaceholder/+/master/includes/BaseTemplateToolboxHookHandler.php is a decent example of the hook handler class / newFromGlobalState pattern [08:36:40] and there's another bug asking for a way to provide a list of wanted services in hook registration in extension.json/$wgHooks that then get passed to the hook handler function (obviously parser function hooks/tag hooks are different, but I imagine we'd use a similar pattern) [08:36:59] (03PS8) 10simetrical: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 [08:37:09] (ignore PS8, it's just a rebase) [08:37:20] legoktm: I thought we don't want declarative dependencies? [08:37:21] AryehGregor: I only see LinkCache used in static function statelessFetchTemplate() [08:37:32] Ah, never mind then. [08:37:39] (03CR) 10jerkins-bot: [V: 04-1] Update Parser to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450455 (owner: 10simetrical) [08:38:10] AryehGregor: which is probably why it's still only a feature request in a bug :) [08:39:07] https://phabricator.wikimedia.org/T171515 is the ticket [08:39:38] legoktm: Did you look at the extension test failures (Flow/Wikibase) for the NamespaceInfo patches? [08:39:39] (03PS2) 10Fomafix: Get Parser from service instead of global $wgParser [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/450453 [08:39:46] I couldn't figure out exactly what was going wrong. [08:40:00] I didn't, let me do that now [08:42:30] legoktm: Should ParserFactory return a parser that has firstCallInit() already called on it? Is there a reason a caller would want a Parser that isn't already initialized? [08:43:22] (03CR) 10Fomafix: "->getNamespaceFactory()->getNamespace( NS_FOO )->isHappy() has the advantage to store the object instead of the integer in variables and p" [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [08:43:47] (03CR) 10jerkins-bot: [V: 04-1] Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [08:45:44] wikimedia/mediawiki#21707 (master - f15eedf Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415054458 [08:47:12] AryehGregor: on https://www.mediawiki.org/wiki/Manual:Parser#State Tim just wrote "The configuration aspect of the Parser object is initialised when clearState() calls Parser::firstCallInit(). This sets up extensions and core built-ins, and builds regexes and hashtables. It is quite slow (~10ms) so multiple calls should be avoided if possible." which doesn't really help [08:47:36] I'm guessing it was just to lazy-load the Parser initialization? [08:48:22] legoktm: If someone uses ParserFactory to create a Parser, it's a pretty reasonable guess that they want to use it? [08:48:37] (03CR) 10jerkins-bot: [V: 04-1] Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 (owner: 10simetrical) [08:48:52] Or if they don't, they still presumably think they do, so they'll probably call firstCallInit() anyway. [08:49:02] It seems like a bit of a footgun to return an uninitialized parser. [08:49:16] Pre-services it's not as big a deal, since there's a good chance $wgParser was already initialized. [08:49:33] Although, if init is so expensive, maybe callers shouldn't be using ParserFactory and should instead find an existing Parser to use. :) [08:49:57] (03CR) 10Fomafix: [C: 04-1] "> > Patch Set 1:" [extensions/InlineCategorizer] - 10https://gerrit.wikimedia.org/r/450459 (owner: 10Fomafix) [08:52:23] AryehGregor: I think it should be fine if ParserFactory does it, but I'd want Tim to review that [08:52:35] legoktm: Okay. [08:53:49] wikimedia/mediawiki#21707 (master - f15eedf Aryeh Gregor): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415054458 [08:55:06] AryehGregor: for the Wikibase\Client\Tests\NamespaceCheckerTest failure, I suspect it has something to do with MWNamespace::getValidNamespaces() being called in the data provider, and that not matching when it's called in the test itself (via NamespaceChecker) [08:55:43] legoktm: Yes, that's certainly true, and I had a patch that worked around it by moving the call. But that doesn't seem to explain the Flow failures, and anyway it doesn't seem to address the root problem. [08:55:55] The namespace list should be the same. [08:59:12] (03CR) 10jenkins-bot: Remove outdated comment [core] - 10https://gerrit.wikimedia.org/r/450432 (owner: 10simetrical) [08:59:14] AryehGregor: on https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/450471 what does $wgExtensionMessagesFiles have to do with this? [09:00:13] legoktm: That's what causes the NS_TOPIC namespace (2600) to be loaded, AFAICT, and it's available at the provider-evaluation stage, but then when the NamespaceInfo service gets reset, it doesn't seem to pick it up the second time. [09:00:21] That's my theory, anyway. [09:01:08] NS_TOPIC is loaded because of "namespaces" in Flow's extension.json [09:01:28] Hmm, okay. [09:01:32] which eventually turns into [09:01:33] // Add extension namespaces [09:01:33] self::$canonicalNamespaces += [09:01:33] ExtensionRegistry::getInstance()->getAttribute( 'ExtensionNamespaces' ); [09:01:46] Right, that's the line that seemed not to be running again. [09:04:39] (03CR) 10jerkins-bot: [V: 04-1] Update LinkRenderer to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450454 (owner: 10simetrical) [09:06:00] * legoktm sets up Flow to test [09:06:26] (03CR) 10jerkins-bot: [V: 04-1] NamespaceInfo service to replace MWNamespace [core] - 10https://gerrit.wikimedia.org/r/450433 (owner: 10simetrical) [09:17:44] 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Run A/B test on page issues - https://phabricator.wikimedia.org/T200792 (10Tbayer) >>! In T200792#4495304, @Jdlrobson wrote: >> We decided to run the test everywhere but I don't see any harm in running it for a bit longer on one wiki. > My choice of words with... [09:19:25] 10Readers-Web-Backlog, 10Wikimedia-Site-requests: Run A/B test on page issues - https://phabricator.wikimedia.org/T200792 (10Tbayer) [09:19:57] (03PS5) 10Legoktm: Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [09:21:40] (03CR) 10jerkins-bot: [V: 04-1] Update Parser to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450455 (owner: 10simetrical) [09:24:27] (03CR) 10simetrical: Make SpecialPageFactory a service (031 comment) [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [09:27:04] (03CR) 10jerkins-bot: [V: 04-1] Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [09:27:31] (03CR) 10Aaron Schulz: [C: 032] JavaScriptMinifier: Move test case for 'x++' to provideLineBreaker() [core] - 10https://gerrit.wikimedia.org/r/452175 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [09:31:33] (03PS5) 10Aaron Schulz: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 [09:31:36] (03CR) 10jerkins-bot: [V: 04-1] Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [09:31:39] (03PS6) 10Aaron Schulz: rdbms: add "maxReadRows" limit to TransactionProfiler [core] - 10https://gerrit.wikimedia.org/r/443405 [09:32:11] (03PS9) 10simetrical: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 [09:32:13] (03PS1) 10simetrical: Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 [09:32:20] (03PS13) 10Aaron Schulz: Make ExternalStore wrap ExternalStoreFactory [core] - 10https://gerrit.wikimedia.org/r/414968 [09:33:05] (03CR) 10jerkins-bot: [V: 04-1] Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 (owner: 10simetrical) [09:34:09] (03PS6) 10Legoktm: Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [09:35:06] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Aklapper) @Marshallsumter: Do you plan tow fix this yourself, as you set yourself as assignee? If not, please provide example links and follow https://mediawiki.org/wiki/How_to_report_a_bug... [09:35:52] (03PS1) 10simetrical: Disallow overriding services that were set [core] - 10https://gerrit.wikimedia.org/r/452188 [09:37:01] (03CR) 10jerkins-bot: [V: 04-1] Make ExternalStore wrap ExternalStoreFactory [core] - 10https://gerrit.wikimedia.org/r/414968 (owner: 10Aaron Schulz) [09:37:22] (03PS5) 10Fomafix: Add new factory Language::newFromValidCode [core] - 10https://gerrit.wikimedia.org/r/441528 [09:37:35] (03PS3) 10Fomafix: Title: Introduce getDbPageLanguage() [core] - 10https://gerrit.wikimedia.org/r/441529 [09:37:58] (03PS10) 10simetrical: Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 [09:38:00] (03PS12) 10simetrical: Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 [09:43:42] (03CR) 10jerkins-bot: [V: 04-1] Make ExternalStore wrap ExternalStoreFactory [core] - 10https://gerrit.wikimedia.org/r/414968 (owner: 10Aaron Schulz) [09:44:48] (03CR) 10jerkins-bot: [V: 04-1] Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [09:46:01] (03Merged) 10jenkins-bot: JavaScriptMinifier: Move test case for 'x++' to provideLineBreaker() [core] - 10https://gerrit.wikimedia.org/r/452175 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [09:46:07] (03PS3) 10Fomafix: LoginSignupSpecialPage: Fallback to content language on invalid language code [core] - 10https://gerrit.wikimedia.org/r/441771 (https://phabricator.wikimedia.org/T198054) [09:46:45] (03CR) 10jerkins-bot: [V: 04-1] Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [09:46:55] (03CR) 10jerkins-bot: [V: 04-1] Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [09:49:12] (03CR) 10jenkins-bot: JavaScriptMinifier: Move test case for 'x++' to provideLineBreaker() [core] - 10https://gerrit.wikimedia.org/r/452175 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [09:52:51] (03CR) 10jerkins-bot: [V: 04-1] Disallow overriding services that were set [core] - 10https://gerrit.wikimedia.org/r/452188 (owner: 10simetrical) [09:59:59] (03PS10) 10Fomafix: [WIP] Introduce LanguageSet [core] - 10https://gerrit.wikimedia.org/r/442337 [10:00:07] (03PS7) 10Legoktm: Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [10:00:08] (03PS10) 10simetrical: Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 [10:00:10] (03PS2) 10simetrical: Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 [10:00:43] wikimedia/mediawiki#21708 (master - d2db6c2 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415065894 [10:00:53] (03CR) 10simetrical: "I think AutoLoaderStructureTest::parseFile() doesn't like my namespace with curly braces. Maybe this should be done not using regexes, sp" [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [10:03:51] AryehGregor: we should only have one class per file, really [10:04:09] legoktm: Hmm, okay. [10:04:26] legoktm: I don't know if I'll have time to do any more work today. Perhaps a bit. [10:05:20] legoktm: Oh, I have a single-digit number of minutes left on my contract anyway, apparently. [10:05:48] AryehGregor: heh, no worries then :) [10:07:19] AryehGregor: I really enjoyed working with you for the past few weeks :) [10:07:30] legoktm: Likewise! :) [10:07:35] 10Repository-Ownership-Requests: Make MGChecker maintainer of Extension:LanguageTag & InteractiveBlockMessage - https://phabricator.wikimedia.org/T193049 (10MarcoAurelio) Hello. This ticket is opened since **April**. If there are any concerns about the request, please voice them. If there are not any, what's hol... [10:07:38] Hope to work with you again in a while. [10:08:02] :) [10:09:02] wikimedia/mediawiki#21708 (master - d2db6c2 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415065894 [10:10:04] wikimedia/mediawiki#21708 (master - d2db6c2 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415065894 [10:14:09] 10MediaWiki-extensions-Html2Wiki: Internal error during upload due to missing PHP zip extension - https://phabricator.wikimedia.org/T201296 (10Aklapper) 05Resolved>03Invalid [10:14:35] (03CR) 10jerkins-bot: [V: 04-1] Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [10:15:46] (03CR) 10jerkins-bot: [V: 04-1] Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 (owner: 10simetrical) [10:16:32] (03CR) 10jerkins-bot: [V: 04-1] Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [10:19:38] (03CR) 10jerkins-bot: [V: 04-1] Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [10:21:14] (03CR) 10jerkins-bot: [V: 04-1] Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [10:26:15] 10WMSE-Riksarkivet-TORA: Change to start date from P571 - https://phabricator.wikimedia.org/T201738 (10Salgo60) [10:29:40] (03PS1) 10Legoktm: [DNM] testing [core] - 10https://gerrit.wikimedia.org/r/452190 [10:29:45] (03PS8) 10Legoktm: Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [10:40:33] (03CR) 10jerkins-bot: [V: 04-1] Try to fix 450433 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/450564 (owner: 10simetrical) [10:42:31] (03PS2) 10Aaron Schulz: Fix DatabaseDomain for ExternalStorage in LBFactorySimple [core] - 10https://gerrit.wikimedia.org/r/448618 (https://phabricator.wikimedia.org/T200471) (owner: 10Martineznovo) [10:44:26] 10WMSE-Riksarkivet-NAD: When is new archives created at Riksarkivet with unique NADs - https://phabricator.wikimedia.org/T201775 (10Salgo60) [10:45:43] (03CR) 10jerkins-bot: [V: 04-1] Disallow overriding services that were set [core] - 10https://gerrit.wikimedia.org/r/452188 (owner: 10simetrical) [10:49:30] (03CR) 10jerkins-bot: [V: 04-1] [DNM] testing [core] - 10https://gerrit.wikimedia.org/r/452190 (owner: 10Legoktm) [10:49:53] (03CR) 10Raimond Spekking: [C: 04-1] Change linkstoimage and related messages from "link" to "use" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/423519 (owner: 10Amire80) [10:53:59] 04(no projects): Undefined property: stdClass::$actor_rev_user.actor_name in /includes/libs/rdbms/database/Database.php on line 1513 - https://phabricator.wikimedia.org/T201781 (10Joergi123) [11:02:17] 10MediaWiki-extensions-Html2Wiki: Internal error during upload due to missing PHP zip extension - https://phabricator.wikimedia.org/T201296 (10jmt) Hello Aklapper, I opened this task with 2 separate issues when uploading files via the HTML2Wiki extension, namely: [1df88fba928db599003715c5] /index.php?title=Spe... [11:03:05] 10MediaWiki-Database: Undefined property: stdClass::$actor_rev_user.actor_name in /includes/libs/rdbms/database/Database.php on line 1513 - https://phabricator.wikimedia.org/T201781 (10Mainframe98) It seems more likely that a query failed to join with the actor table, or that fails to include the `actor_name` fi... [11:04:28] (03PS2) 10Amire80: A major update to MessagesSah.php from HalanTul [core] - 10https://gerrit.wikimedia.org/r/447047 [11:09:38] (03PS2) 10Amire80: Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 [11:10:04] (03PS3) 10Amire80: Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 [11:15:40] (03PS1) 10TheDJ: Legacy: remove unused style rules for floatleft/right [core] - 10https://gerrit.wikimedia.org/r/452192 [11:16:44] (03CR) 10jerkins-bot: [V: 04-1] Update MediaWikiTitleCodec to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450457 (owner: 10simetrical) [11:23:01] (03CR) 10jerkins-bot: [V: 04-1] Update DefaultPreferencesFactory to use NamespaceInfo [core] - 10https://gerrit.wikimedia.org/r/450456 (owner: 10simetrical) [11:32:31] (03CR) 10Raimond Spekking: [C: 032] Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 (owner: 10Amire80) [11:33:19] 10MediaWiki-extensions-Html2Wiki: Internal error during upload due to missing PHP zip extension - https://phabricator.wikimedia.org/T201296 (10Aklapper) Feel free to do so - You can edit the task by clicking {nav icon=pencil, name=Edit Task}. [11:43:17] 10MediaWiki-Database: Undefined property: stdClass::$actor_rev_user.actor_name in /includes/libs/rdbms/database/Database.php on line 1513 - https://phabricator.wikimedia.org/T201781 (10Anomie) It looks like `Database::selectFieldValues()` doesn't properly handle the case where `$var` is not a field name. [11:51:12] (03Merged) 10jenkins-bot: Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 (owner: 10Amire80) [11:53:23] (03CR) 10jenkins-bot: Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 (owner: 10Amire80) [12:04:50] wikimedia/mediawiki#21709 (master - c7c271e Amire80): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415087154 [12:04:59] (03CR) 10jerkins-bot: [V: 04-1] Mass conversion to SpecialPageFactory service [core] - 10https://gerrit.wikimedia.org/r/452186 (owner: 10simetrical) [12:06:54] (03CR) 10jerkins-bot: [V: 04-1] Make SpecialPageFactory a service [core] - 10https://gerrit.wikimedia.org/r/450947 (owner: 10simetrical) [12:13:50] wikimedia/mediawiki#21709 (master - c7c271e Amire80): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415087154 [12:13:58] (03CR) 10jerkins-bot: [V: 04-1] [DNM] testing [core] - 10https://gerrit.wikimedia.org/r/452190 (owner: 10Legoktm) [12:17:36] (03CR) 10jenkins-bot: Change linkstoimage and related messages from "link" to "use" [core] - 10https://gerrit.wikimedia.org/r/423519 (owner: 10Amire80) [12:17:57] wikimedia/mediawiki#21709 (master - c7c271e Amire80): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415087154 [12:24:59] (03PS6) 10Fomafix: Add new factory Language::newFromValidCode [core] - 10https://gerrit.wikimedia.org/r/441528 [12:25:13] (03PS4) 10Fomafix: LoginSignupSpecialPage: Fallback to content language on invalid language code [core] - 10https://gerrit.wikimedia.org/r/441771 (https://phabricator.wikimedia.org/T198054) [12:25:34] (03PS4) 10Fomafix: Title: Introduce getDbPageLanguage() [core] - 10https://gerrit.wikimedia.org/r/441529 [12:26:22] 10MediaWiki-extensions-CentralAuth, 10GlobalRename, 10Wikimedia-Site-requests: Please unblock stuck global rename: EricEnfermero to Larry Hockett - https://phabricator.wikimedia.org/T201314 (10Trijnstel) It's been six days since the rename now, and nothing has happened. Could someone please look at it asap?... [12:40:26] (03CR) 10Krinkle: [C: 04-1] CSSMin: Re-introduce improved quote encoding in embedded SVGs [core] - 10https://gerrit.wikimedia.org/r/403577 (https://phabricator.wikimedia.org/T175318) (owner: 10VolkerE) [12:41:39] 10MediaWiki-ResourceLoader, 10Performance-Team: Remove internal handling of 'raw' module - https://phabricator.wikimedia.org/T201483 (10Krinkle) 05stalled>03Open [12:44:11] 10MediaWiki-Internationalization, 10I18n: Move as much grammar transformation code as possible from PHP and JS to separate generic data files - https://phabricator.wikimedia.org/T115217 (10Krinkle) [12:46:49] 10MediaWiki-extensions-Html2Wiki: Internal error during upload due to missing PHP zip extension and error in Language.php - https://phabricator.wikimedia.org/T201296 (10jmt) [12:49:30] 10ContentTranslation, 10WorkType-Maintenance: A link to an article that doesn't exist in the source language but exists under the same title in the target language is silently not inserted - https://phabricator.wikimedia.org/T143997 (10Amire80) Yes, still happens in CX2. [12:49:59] 10ContentTranslation, 10WorkType-Maintenance: A link to an article that doesn't exist in the source language but exists under the same title in the target language is silently not inserted - https://phabricator.wikimedia.org/T143997 (10Amire80) a:05Amire80>03None [12:50:13] 10ContentTranslation, 10WorkType-Maintenance: CX2: A link to an article that doesn't exist in the source language but exists under the same title in the target language is silently not inserted - https://phabricator.wikimedia.org/T143997 (10Amire80) [12:52:03] 10MediaWiki-ResourceLoader, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-08-14 (1.32.0-wmf.17)), 10Patch-For-Review, 10Technical-Debt (Deprecation): Remove $wgResourceLoaderLESSVars and ResourceLoaderGetLessVars hook - https://phabricator.wikimedia.org/T140804 (10Krinkle) a:03Krinkle [12:54:35] 10MediaWiki-Cache, 10Performance-Team, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), 10Patch-For-Review: Consider using APC for the individually cached keys (e.g. 'TOO BIG') in MessageCache - https://phabricator.wikimedia.org/T118893 (10Krinkle) a:03aaron [12:57:29] (03CR) 10Krinkle: [C: 032] Remove CSS selector #toc and remain .toc [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447675 (owner: 10Fomafix) [12:57:58] (03CR) 10Krinkle: [C: 032] Rename variable $toggleLink in $toggleSymbol [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447666 (owner: 10Fomafix) [13:03:13] 10ContentTranslation, 10WorkType-Maintenance: Content Translation treats machine translation of links that begin in the middle of a word incorrectly - https://phabricator.wikimedia.org/T139914 (10Amire80) 05Open>03Invalid I tested it further, and found that the issue is in Yandex.Translate and not in CX. [13:03:14] (03Merged) 10jenkins-bot: Remove CSS selector #toc and remain .toc [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447675 (owner: 10Fomafix) [13:04:40] (03Merged) 10jenkins-bot: Rename variable $toggleLink in $toggleSymbol [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447666 (owner: 10Fomafix) [13:05:39] 10ContentTranslation, 10WorkType-Maintenance: "Cross-Origin Request Blocked" JS errors when translating into be-tarask - https://phabricator.wikimedia.org/T163917 (10Amire80) a:05Amire80>03None Still happens in CX2, most likely related to the domain renaming. [13:09:52] (03CR) 10VolkerE: [C: 031] Legacy: remove unused style rules for floatleft/right [core] - 10https://gerrit.wikimedia.org/r/452192 (owner: 10TheDJ) [13:14:48] 10Wikimedia-Site-requests, 10Russian-Sites: Enable ‘Contact us’ link in Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10stjn) [13:20:05] (03PS2) 10Fomafix: Move brackets from JavaScript to CSS [extensions/TocTree] - 10https://gerrit.wikimedia.org/r/447671 [13:31:36] (03CR) 10Yaron Koren: [C: 032] Fixes for definition lists and indents in lists [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/452043 (owner: 10Duncancrane) [13:35:23] (03PS7) 10Fomafix: OutputPage: Use getPageViewLanguage() for Content-language [core] - 10https://gerrit.wikimedia.org/r/255178 (owner: 10Gerrit Patch Uploader) [13:36:11] (03Merged) 10jenkins-bot: Fixes for definition lists and indents in lists [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/452043 (owner: 10Duncancrane) [14:05:23] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Marshallsumter) @Aklapper: Assignee? Oops! No! Although I would like to learn how! Here's an example link: WikiData mineral (Q7946) for en:Wikiversity [[v:Draft:Minerals]] or https://en.wik... [14:06:55] 10Library-Card-Platform: Give partners 'short' and 'long' descriptions - https://phabricator.wikimedia.org/T169618 (10AVasanth_WMF) a:03AVasanth_WMF [14:07:32] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Marshallsumter) a:05Marshallsumter>03None [14:34:23] hey r054l13! [14:34:35] I've been looking at the proposed google report [14:34:47] ah perhaps I'll ping d3r1ck too so he can weigh in/follow along [14:35:00] ok [14:35:16] https://developers.google.com/open-source/gsoc/help/work-product The crucial bits are in here [14:35:34] The target of the link should contain a short description of what work was done, what code got merged, what code didn't get merged, and what's left to do. [14:35:36] The best examples of this we saw in past years were "final reports" that made it easy to find the code, summarized the current state of the project, and enumerated challenges and learnings. [14:35:54] * d3r1ck lurks [14:37:06] also note under 'Bad examples': [14:37:09] Don't do these things. [14:37:28] Link to the top of the project's primary source repository. [14:38:24] ok [14:38:59] although this is all your work, in the future others may contribute to it; so it's best if you can link to the merged patchsets with a (very short!) phrase describing each one [14:39:36] I included that [14:40:15] ah the merged patches! [14:40:35] I could not tell they were gerrit links, because of the google doc format [14:40:53] can you make the link addresses visible there? [14:41:05] ok [14:42:01] I don't know if you need to go into all of the implementation details there. But as the google guidelines say, it's nice f you can enumerate challenges and learnings [14:42:48] ok [14:43:34] the project details are ok but it might be even shorter to just include a sample tweet to the bot (a screenshot!) and a sample reply [14:43:50] instead of the list of things the reply tweet must have [14:44:30] also there are places where it says 'this will' 'the implementation will'... it's done so you can just say it *is* :-) [14:44:51] ok [14:45:19] you don't need to describe the json table stuff there [14:46:10] ok [14:46:11] a link to the phab ticket would be good in the list of project links (like the repo, I see that's in a separate place from the patches so it's actually fine) and the bot on twitter... [14:46:16] well these are my thoughts [14:46:41] d3r1ck: what do you think about any of these things? [14:46:50] have you had a look at the google guidelines [14:46:57] ? \ [14:47:08] yes [14:47:29] ah, sorry that question was for d3r1ck [14:47:35] ops [14:47:42] eh I was not clear [14:49:19] apergos: You're on point [14:49:23] I like your feedbac [14:49:29] *feedback [14:49:38] anything you disagree with? anything you want to add? [14:49:47] I'll do a detail review this evening around the Google doc after looking at the guidelines again [14:49:58] ah ok [14:50:03] I'll add this evening apergos [14:50:09] After the check-in [14:51:35] r054l13: do you have questions/comments/complaints/disagreements? it is your report after all [14:51:44] same for the developer manual for that matter [14:52:22] I just want to be sure I understood your comments for me report [14:52:52] So you sujest I should remove the link to NYPL bot [14:53:18] add the link to the phabricator ticket with my proposal [14:53:37] add challenges and learning [14:54:00] also add what is left to be done [14:54:25] no you can leave the link to the nypl bot [14:54:47] oh ok [14:55:01] noted then [14:55:18] the link to the gerrit repo should make plain that it's the repo for cloning code, not that all the code in there is yours (find some nice wat to say that with a phrase) [14:55:28] it can stay though [14:55:40] make the link addresses visible generally [14:56:24] ok [14:56:46] instead of having the whole list of implementation things, put challenges and learnings, so we know what the hard/interesting bits were for you, what you learned from the project [14:57:03] (so in place of the 'steps') [14:57:23] ok [14:57:38] * r054l13 making some notes [14:58:00] and one more thing, I wouldn't use blue for the subtitle of the report, it makes me think it's a link :-P [14:58:21] oh yea [14:58:27] AH one more thing!! you refer a lot to 'commons' [14:58:39] but at least somewhere early on you should say what that is [14:58:47] and probably give a url [14:58:53] just one short sentence is enough [14:59:39] ok [14:59:42] I do't know what you want in the conclusion at all. maybe you don't need one, heh [14:59:58] and [15:00:40] in the prject details where there's the list of what a tweet reply has, just put instead a sample tweet and reply (screenshot) and [15:00:54] that's a nice visual aid to the reader plus a nice litle break from all the text [15:00:58] *little [15:01:15] again if you do all these and you don't like it, feel free to change things around [15:01:17] alright [15:01:24] as long as you meet the google guidelines [15:02:14] are we good? do you have more questions, or maybe you have comments or complaints (also very ok to bring them up!)? [15:02:48] ok, am good [15:02:53] all right! [15:03:01] if you want another review, feel free to poke us [15:03:09] ok [15:36:24] (03PS5) 10GeoffreyT2000: Exclude 'renameuser' from the 'logTypesOnUser' variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/449351 (https://phabricator.wikimedia.org/T200731) [15:39:07] (03PS6) 10GeoffreyT2000: Exclude 'renameuser' from the 'logTypesOnUser' variable [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/449351 (https://phabricator.wikimedia.org/T200731) [15:40:31] 10VisualEditor (Current work): [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not tags) - https://phabricator.wikimedia.org/T198477 (10eranroz) [15:44:49] 10VisualEditor (Current work): [he.wiki] Reference list is emptied when adding a new reference on a wiki that uses template generated references (not tags) - https://phabricator.wikimedia.org/T198477 (10eranroz) It worth to fix the issue independently of T30980 Sometimes templates adds references for other... [15:48:47] (03PS6) 10Brion VIBBER: ParallelMaintenance, QueueingForkController [core] - 10https://gerrit.wikimedia.org/r/451099 [15:49:06] (03PS29) 10Brion VIBBER: Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [15:53:46] (03CR) 10jerkins-bot: [V: 04-1] Subtitles served through API, with WebVTT conversion [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/232214 (https://phabricator.wikimedia.org/T111552) (owner: 10TheDJ) [16:34:19] (03CR) 10Nikerabbit: "Why does this need an i18n change? Can't the existing parameter be updated?" [extensions/UrlShortener] - 10https://gerrit.wikimedia.org/r/418869 (https://phabricator.wikimedia.org/T141705) (owner: 10Rg4amia) [16:40:58] 10MediaWiki-Authentication-and-authorization, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Petrb) [16:54:31] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Report - https://phabricator.wikimedia.org/T201785 (10SuperShadow666) [17:01:56] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Aklapper) Where to see "the wikidata item number" when not in the Draft space? An example of expected behavior would be welcome. [17:05:48] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Report - https://phabricator.wikimedia.org/T201785 (10Aklapper) [17:05:51] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: "encyclopediadramatica.rs" does not set CORS headers on images, so MultimediaViewer cannot load images on that website - https://phabricator.wikimedia.org/T195536 (10Aklapper) [17:06:06] 10MediaWiki-extensions-MultimediaViewer, 10Multimedia: Report - https://phabricator.wikimedia.org/T201785 (10Aklapper) Please report ED problems to ED so ED can fix their broken website. [17:19:56] (03CR) 10Umherirrender: Do not use PNG for thanks button (032 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440258 (https://phabricator.wikimedia.org/T198151) (owner: 10Jdlrobson) [17:21:38] (03CR) 10Umherirrender: Show copyvio scores in Special:NewPagesFeed (031 comment) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451318 (https://phabricator.wikimedia.org/T201070) (owner: 10Sbisson) [17:23:44] (03CR) 10Umherirrender: Updated manifest to v2 and added AutoloadNamespaces (031 comment) [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/451361 (owner: 10Pwirth) [17:34:56] (03CR) 10Imarlier: [C: 032] JavaScriptMinifier: Add test case for another line-break bug [core] - 10https://gerrit.wikimedia.org/r/452176 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [17:37:31] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10User-Daniel, 10User-Smalyshev: Provide another way to surface usage instructions besides tacking them onto descriptions - https://phabricator.wikimedia.org/T97566 (10DarTar) >>! In T97566#4496912, @Smalyshev wrote: > I think the way to solve the issu... [17:41:27] (03PS1) 10Umherirrender: Avoid variable reuse under same name [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/452200 [17:51:59] (03Merged) 10jenkins-bot: JavaScriptMinifier: Add test case for another line-break bug [core] - 10https://gerrit.wikimedia.org/r/452176 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [17:52:24] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Bawolff) This is sort of similar to (but definitely not the same) as T199118 / T197501. Per... [17:54:46] (03CR) 10jenkins-bot: JavaScriptMinifier: Add test case for another line-break bug [core] - 10https://gerrit.wikimedia.org/r/452176 (https://phabricator.wikimedia.org/T201606) (owner: 10Krinkle) [17:56:05] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Anomie) Most people will have to use 2-factor auth very rarely: * When logging in, once ev... [17:58:15] (03PS1) 10Rwalle61: Just added a comment to test and learn about committing. [extensions/examples] - 10https://gerrit.wikimedia.org/r/452201 [17:58:17] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/452201 (owner: 10Rwalle61) [18:00:56] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Bawolff) Its important to keep in mind here that threat models differ for different users.... [18:01:05] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10IKhitron) Hi. Here are my two cents. I'm an interface admin. I never mark on mobile "keep m... [18:04:37] (03PS2) 10Umherirrender: Add phan-taint-check-plugin [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 [18:04:50] (03CR) 10Umherirrender: "Some fixes with I29906f26af9ee6a752e9ee3d6420f505f85ecf38" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 (owner: 10Umherirrender) [18:04:57] (03CR) 10Umherirrender: "check experimental" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 (owner: 10Umherirrender) [18:05:57] wikimedia/mediawiki#21710 (master - cd789d7 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415163493 [18:06:08] wikimedia/mediawiki#21710 (master - cd789d7 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415163493 [18:10:30] (03CR) 10Umherirrender: "" [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/451390 (owner: 10Umherirrender) [18:11:40] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Anomie) >>! In T201784#4497336, @Bawolff wrote: > This is sort of similar to (but definitel... [18:15:43] (03CR) 10Aklapper: "Hi Rwalle61, please abandon this change as it seems to be a test commit. If you would like to play with Gerrit, please use http://gerrit-t" [extensions/examples] - 10https://gerrit.wikimedia.org/r/452201 (owner: 10Rwalle61) [18:16:07] wikimedia/mediawiki#21710 (master - cd789d7 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415163493 [18:16:35] wikimedia/mediawiki#21710 (master - cd789d7 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415163493 [18:22:06] (03PS8) 10Pwirth: [WIP] Refactoring [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/451393 [18:25:11] (03Abandoned) 10Rwalle61: Just added a comment to test and learn about committing. [extensions/examples] - 10https://gerrit.wikimedia.org/r/452201 (owner: 10Rwalle61) [18:31:34] (03CR) 10TheDJ: "hmm." [extensions/Score] - 10https://gerrit.wikimedia.org/r/451873 (owner: 10Ebe123) [18:32:11] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Petrb) Now this is interesting. I use my account on multiple various devices (more than 10... [18:37:21] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10Security: Implement option "require two-factor authentication only for dangerous actions" - https://phabricator.wikimedia.org/T201784 (10Petrb) [18:40:58] 10phan-taint-check-plugin: phan-taint-check-plugin should ignore /extensions/ folder - https://phabricator.wikimedia.org/T201794 (10Umherirrender) [18:47:40] (03CR) 10TheDJ: "tried investigating a little bit further, but the files lilypond generators on macosx are just plain garbage for me. Don't even want to pl" [extensions/Score] - 10https://gerrit.wikimedia.org/r/451873 (owner: 10Ebe123) [18:56:09] (03PS1) 10Umherirrender: Escape message used in html [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/452204 [19:01:28] apergos: Hello [19:01:33] d3r1ck: Hello [19:01:48] Dereckson: Hello [19:01:55] hello [19:02:05] I think I'm facilitating today so I'll set the 5 minute alarm [19:02:12] ok [19:02:19] warning: commands will be executed using /bin/sh [19:02:19] job 285 at Sun Aug 12 22:07:00 2018 [19:02:32] just in case people think I don't actually set an alarm, I do! :-D [19:02:58] hihih! [19:05:24] (03CR) 10Reedy: [C: 04-1] "Still various things from the previous PS that aren't fixed" (031 comment) [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T150562) (owner: 10MR70) [19:05:28] (03CR) 10Reedy: [C: 04-1] "recheck" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T150562) (owner: 10MR70) [19:06:18] Hello World :) [19:07:04] ding! [19:07:31] (03CR) 10jerkins-bot: [V: 04-1] Permissions of a specific groups should be temporarily removed if Two-Factor-Auth isn't enabled for a user [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T150562) (owner: 10MR70) [19:07:33] r054l13: d3r1ck hm I would ask Dereckson but he's actually not even logged in... [19:07:37] shall we get started? [19:07:46] apergos: Yes [19:07:49] * d3r1ck lurks [19:08:12] yes [19:09:04] okay! how is everyone today on this last week (last two days!) of the student part of the project? [19:10:03] apergos: Actually sick :( [19:10:04] I am fine [19:10:10] Tired and fatigue :( [19:10:15] d3r1ck: please get some rest [19:10:22] apergos: Thank you! [19:10:23] d3r1ck: Sorry to hear that [19:10:24] I hope you feel better soon [19:10:31] r054l13: Thanks [19:10:33] apergos: Okay! [19:10:54] how is work going on the project, r054l13 ? [19:11:39] good [19:12:01] I am updating the docs as the meeting is going [19:12:06] great! [19:12:16] what will be next after that? [19:12:45] I had something to sugest concerning the authomatic run of the bot [19:13:10] yes? [19:13:33] I could start a screen process on toolforge and run the bot manually insid. [19:13:48] so long as the server is on the bot will be running [19:13:57] well I supose not tested yet [19:14:01] that's ok temporarily but it's not a permanent solution of course [19:14:15] and it also means resources are used on the bastion that .. maybe shouldn't be [19:14:25] ok [19:14:27] ordinarily the tools run on other hosts [19:14:47] which are dedicated for the purpose of being the tools back end. [19:14:58] ok [19:16:13] during my discusion in -cloud the last sugestion was to write a script so that K8 service start actually runs the bot from the virtual env. [19:16:29] did they point you to an example? [19:16:41] No, [19:17:06] I was thinking that may take some more time so I tried looking for an alternative [19:17:24] but if that's the only way out then .. [19:17:37] weeeeelll [19:18:14] the problem with using a nodejs image is that nodejs will already be running in the instance, so you don't want to do that.. and there's not a nice way to run a generic service on kube, as far as I know [19:18:28] but we can talk about this in the cloud channel in a bit, if that's what's next [19:18:47] do you have any questions/comments/complaints/needs/topics to bring up besides the toolforge issue? [19:19:31] no nothing else. [19:20:24] d3r1ck: anyhing you want to bring up, comments/questions/complaints? [19:21:43] apergos: I've read the guide lines again [19:21:50] ok [19:21:52] I'll review the Google Doc after the meeting [19:22:04] there will be a new version by then I think, or soon after [19:22:08] And post comments here tagging, you and rosalie + Dereckson [19:22:15] apergos: Okay! [19:22:19] except that I may be tealing r054l13 for a discussion in -cloud [19:22:24] *stealing [19:22:50] what else you have on your plate? [19:23:08] I think that's it for now and maybe a few more comments on the patch? [19:23:21] about the developer manual etc [19:23:24] ok [19:23:28] That's it for now [19:23:38] Ohhh and then lurk around in -cloud [19:23:45] in that case, go get some rest, r054l13 let's cht in -cloud and see what happens! [19:23:47] Maybe if some ideas come in [19:23:49] *chat [19:23:58] ok [19:23:59] apergos: Thanks [19:34:52] 10phan-taint-check-plugin: phan-taint-check-plugin should ignore /extensions/ folder - https://phabricator.wikimedia.org/T201794 (10Bawolff) We could add it to `exclude_analysis_directory_list` in scripts/mwext-fast-config.php in phan-taint-plugin (Like how `vendor` currently is excluded) But is it something we... [19:56:57] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/452206 (owner: 10L10n-bot) [20:12:09] wikimedia/mediawiki#21711 (master - 3246689 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415191216 [20:12:26] 10Library-Card-Platform: Give partners 'short' and 'long' descriptions - https://phabricator.wikimedia.org/T169618 (10AVasanth_WMF) https://github.com/WikipediaLibrary/TWLight/pull/133 [20:14:45] 10Library-Card-Platform: Migrate all remaining information from old on-wiki signup pages - https://phabricator.wikimedia.org/T201151 (10AVasanth_WMF) a:03AVasanth_WMF [20:18:09] 10Wikimedia-Site-requests: Add a contact us link into the english wikipedia footer - https://phabricator.wikimedia.org/T48392 (10Reedy) [20:19:15] wikimedia/mediawiki#21711 (master - 3246689 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415191216 [20:19:16] 10Wikimedia-Site-requests, 10Russian-Sites: Enable ‘Contact us’ link in Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10Reedy) > Make sure 'MediaWiki:Contact' and 'MediaWiki:Contact-url' are defined. [20:19:33] 10Wikimedia-Site-requests, 10Russian-Sites: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10Reedy) [20:20:34] 10Wikimedia-Site-requests: Azerbaijani Wikipedia: Alphabetical order in the categories (collation) - https://phabricator.wikimedia.org/T201770 (10Reedy) a:05Aklapper>03None [20:22:07] wikimedia/mediawiki#21711 (master - 3246689 Translation updater bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415191216 [20:24:04] 10MediaWiki-General-or-Unknown: Opening PDF file pages on Android Chrome browser, results in an attempt to download, instead of viewing the page - https://phabricator.wikimedia.org/T201191 (10TheDJ) @Sadads which platform level ours ? I don't think we can solve this in MediaWiki. It's not so long since there fin... [20:26:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/452217 (owner: 10L10n-bot) [20:32:41] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Copyvio] - 10https://gerrit.wikimedia.org/r/452224 (owner: 10L10n-bot) [20:37:14] 10MediaWiki-Categories, 10Wikimedia-General-or-Unknown: Category count inaccurate on enwp - https://phabricator.wikimedia.org/T200402 (10Fastily) Another example: [[ https://en.wikipedia.org/wiki/Category:Candidates_for_speedy_deletion | Category:Candidates for speedy deletion ]]; at the time of writing, here... [20:38:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CheckUser] - 10https://gerrit.wikimedia.org/r/452227 (owner: 10L10n-bot) [20:40:03] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Iislucas) Ah, I see. So, from reading this: https://www.mediawiki.org/wiki/Manual:Logging_table#log_params I think log_type probably wants to b... [20:47:20] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/452232 (owner: 10L10n-bot) [20:50:25] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/452228 (owner: 10L10n-bot) [20:53:28] 04(no projects): Adding WikiData item number to resource in en.wikiversity - https://phabricator.wikimedia.org/T201774 (10Marshallsumter) Here's an example [[v:Agronomy]] or https://en.wikiversity.org/wiki/Agronomy under Page information or https://en.wikiversity.org/w/index.php?title=Agronomy&action=info. It o... [20:57:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/452233 (owner: 10L10n-bot) [20:59:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/452238 (owner: 10L10n-bot) [21:02:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/452236 (owner: 10L10n-bot) [21:04:03] 10ContentTranslation, 10Language-2018-July-September: CX2: Better support for Wikidata-based templates - https://phabricator.wikimedia.org/T199310 (10eranroz) @Amire80 showed me a scenario in hewiki where this functionality may be important. In order to support this we need: 1. The Qid of the page being trans... [21:09:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/452239 (owner: 10L10n-bot) [21:10:36] 10Wikimedia-Site-requests, 10Russian-Sites: Set `$wmgUseFooterContactLink = true` on Russian Wikipedia - https://phabricator.wikimedia.org/T201783 (10stjn) Done both pages, thanks for the reminder: * https://ru.wikipedia.org/wiki/MediaWiki:Contact * https://ru.wikipedia.org/wiki/MediaWiki:Contact-url [21:12:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Linter] - 10https://gerrit.wikimedia.org/r/452244 (owner: 10L10n-bot) [21:17:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/452246 (owner: 10L10n-bot) [21:21:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/452245 (owner: 10L10n-bot) [21:22:55] (03CR) 10Pwirth: "@Umherirrender: Thats true, sry, i did not know, that it is not ok to have the Namespace declared without having an actual class in it. Th" [extensions/BlueSpiceTagCloud] - 10https://gerrit.wikimedia.org/r/451361 (owner: 10Pwirth) [21:24:30] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/452255 (owner: 10L10n-bot) [21:28:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/452249 (owner: 10L10n-bot) [21:30:16] (03CR) 10Gergő Tisza: "> Removing all the permissions related to certain group doesn't" [extensions/OATHAuth] - 10https://gerrit.wikimedia.org/r/452020 (https://phabricator.wikimedia.org/T150562) (owner: 10MR70) [21:31:17] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/452259 (owner: 10L10n-bot) [21:34:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/452257 (owner: 10L10n-bot) [21:46:24] 10MediaWiki-Database: Undefined property: stdClass::$actor_rev_user.actor_name in /includes/libs/rdbms/database/Database.php on line 1513 - https://phabricator.wikimedia.org/T201781 (10Joergi123) `$wgActorTableSchemaMigrationStage` is set to `MIGRATION_NEW` as recommended by https://www.mediawiki.org/wiki/Manual... [21:47:41] (03PS1) 10Mh-3110: add return back link on Thanks extension sucess page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) [21:52:03] 10ContentTranslation, 10Language-2018-July-September: CX2: Better support for Wikidata-based templates - https://phabricator.wikimedia.org/T199310 (10Izno) This is {T69659}. [21:53:32] (03CR) 10D3r1ck01: "This looks like a work in progress? And also I've left a few comments" (036 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [21:53:39] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [21:59:05] (03CR) 10jerkins-bot: [V: 04-1] add return back link on Thanks extension sucess page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [22:09:31] (03CR) 10Legoktm: [C: 032] Avoid variable reuse under same name [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/452200 (owner: 10Umherirrender) [22:12:01] 10MediaWiki-File-management, 10Commons, 10Multimedia, 10media-storage, 10Regression: Transparent background renders as white in PNG thumbnails - https://phabricator.wikimedia.org/T198370 (10XYZtSpace) (unsure if this is related) This image is in .png and has a transparent background when the original is... [22:14:44] (03CR) 10Legoktm: [C: 032] Avoid variable reuse under same name [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/452012 (owner: 10Umherirrender) [22:15:00] (03CR) 10Legoktm: [C: 032] Avoid double escape of html attributes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451868 (owner: 10Umherirrender) [22:16:19] (03Merged) 10jenkins-bot: Avoid variable reuse under same name [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/452200 (owner: 10Umherirrender) [22:19:14] (03CR) 10jenkins-bot: Avoid variable reuse under same name [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/452200 (owner: 10Umherirrender) [22:19:49] (03CR) 10Legoktm: [C: 032] Use getMessageParameters in PageTriageLogFormatter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451249 (owner: 10Umherirrender) [22:21:19] (03Merged) 10jenkins-bot: Avoid variable reuse under same name [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/452012 (owner: 10Umherirrender) [22:24:08] (03Merged) 10jenkins-bot: Avoid double escape of html attributes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451868 (owner: 10Umherirrender) [22:25:54] (03CR) 10jenkins-bot: Avoid variable reuse under same name [extensions/TemplateStyles] - 10https://gerrit.wikimedia.org/r/452012 (owner: 10Umherirrender) [22:27:08] (03Merged) 10jenkins-bot: Use getMessageParameters in PageTriageLogFormatter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451249 (owner: 10Umherirrender) [22:28:36] (03CR) 10jenkins-bot: Avoid double escape of html attributes [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/451868 (owner: 10Umherirrender) [22:30:06] (03CR) 10Legoktm: "recheck" [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/451070 (owner: 10Umherirrender) [22:30:11] (03CR) 10Legoktm: "recheck" [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/451071 (owner: 10Umherirrender) [22:31:57] (03CR) 10Legoktm: [C: 032] "Great, thanks :))" [core] - 10https://gerrit.wikimedia.org/r/450068 (https://phabricator.wikimedia.org/T183885) (owner: 10Darien cot) [22:32:27] (03CR) 10jenkins-bot: Use getMessageParameters in PageTriageLogFormatter [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/451249 (owner: 10Umherirrender) [22:33:53] (03CR) 10jerkins-bot: [V: 04-1] build: Add php-parallel-lint, MinusX, jsonlint and banana-checker [extensions/CreatedPagesList] - 10https://gerrit.wikimedia.org/r/451070 (owner: 10Umherirrender) [22:36:22] (03CR) 10Legoktm: [C: 032] build: Add php-parallel-lint, MinusX, jsonlint and banana-checker [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/451071 (owner: 10Umherirrender) [22:39:24] 10MediaWiki-extensions-WikimediaIncubator, 10phan-taint-check-plugin, 10Security: WikimediaIncubator raw HTML messages - https://phabricator.wikimedia.org/T201099 (10Legoktm) 05Open>03Resolved a:03Umherirrender https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikimediaIncubator/+/451404 [22:39:27] 10MediaWiki-extensions-WikimediaIncubator, 10phan-taint-check-plugin, 10Security: WikimediaIncubator raw HTML messages - https://phabricator.wikimedia.org/T201099 (10Legoktm) [22:44:59] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [22:50:08] (03CR) 10Legoktm: [C: 032] Removed duplicate and unused message from en.json [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/451276 (owner: 10Umherirrender) [22:50:18] (03Merged) 10jenkins-bot: Add PHPUnit test to ApiQueryDisabled [core] - 10https://gerrit.wikimedia.org/r/450068 (https://phabricator.wikimedia.org/T183885) (owner: 10Darien cot) [22:50:20] (03Merged) 10jenkins-bot: build: Add php-parallel-lint, MinusX, jsonlint and banana-checker [extensions/SplitPrivateWiki] - 10https://gerrit.wikimedia.org/r/451071 (owner: 10Umherirrender) [22:50:47] (03CR) 10Legoktm: [C: 032] Escape message used in html [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/452204 (owner: 10Umherirrender) [22:52:16] 10WikimediaMessages: Use Creative Commons wording for MediaWiki:Wm-license-cc-conditions-attribution-text - https://phabricator.wikimedia.org/T201797 (10bjh21) [22:52:52] (03CR) 10jerkins-bot: [V: 04-1] Add phan-taint-check-plugin [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [22:53:11] (03CR) 10jenkins-bot: Add PHPUnit test to ApiQueryDisabled [core] - 10https://gerrit.wikimedia.org/r/450068 (https://phabricator.wikimedia.org/T183885) (owner: 10Darien cot) [22:53:20] 10MediaWiki-API, 10MediaWiki-Core-Tests, 10Easy, 10Patch-For-Review: ApiDisabled and ApiQueryDisabled should have PHPUnit tests - https://phabricator.wikimedia.org/T183885 (10Legoktm) 05Open>03Resolved [22:54:43] 10MediaWiki-Codesniffer, 10MediaWiki-Core-Tests, 10PHP 7.1 support: Function mcrypt_list_algorithms() has been deprecated - https://phabricator.wikimedia.org/T201524 (10Legoktm) We should probably disable `Generic.PHP.DeprecatedFunctions.Deprecated`. It depends on the specific PHP version being used to run t... [22:56:46] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Bawolff) log_deleted is if the log entry itself is deleted not about if the target of the log entry is. It controls whether or not the log entr... [22:58:41] (03Merged) 10jenkins-bot: Removed duplicate and unused message from en.json [extensions/TinyMCE] - 10https://gerrit.wikimedia.org/r/451276 (owner: 10Umherirrender) [22:59:48] (03Merged) 10jenkins-bot: Escape message used in html [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/452204 (owner: 10Umherirrender) [23:02:42] wikimedia/mediawiki#21712 (master - 8d91ac5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415228886 [23:03:03] wikimedia/mediawiki#21712 (master - 8d91ac5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415228886 [23:05:01] wikimedia/mediawiki#21712 (master - 8d91ac5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415228886 [23:12:18] wikimedia/mediawiki#21712 (master - 8d91ac5 jenkins-bot): The build is still failing. - https://travis-ci.org/wikimedia/mediawiki/builds/415228886 [23:13:39] (03CR) 10Legoktm: [C: 032] "..." [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [23:14:16] (03PS2) 10Mh-3110: Add return back link on Thanks extension success page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) [23:15:53] (03CR) 10Mh-3110: "> Patch Set 1:" (036 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [23:16:39] 10Anti-Harassment, 10Research, 10Trust-and-Safety, 10Privacy: Exposing revIDs of deleted edits for research purposes - https://phabricator.wikimedia.org/T200559 (10Bawolff) So these log entries are for deleting a full page (as opposed to revision delete which deletes a specific revision), so theres no spec... [23:19:35] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [23:21:43] (03CR) 10D3r1ck01: "I've not yet tested, still looking at issues around indentation and convention, also seem you need to write unit test for the code?" (0313 comments) [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [23:21:50] (03CR) 10D3r1ck01: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [23:24:12] (03CR) 10jenkins-bot: Add phan-taint-check-plugin [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444345 (owner: 10Umherirrender) [23:27:31] (03CR) 10jerkins-bot: [V: 04-1] Add return back link on Thanks extension success page [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/452275 (https://phabricator.wikimedia.org/T188326) (owner: 10Mh-3110) [23:56:18] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/451359 (owner: 10Umherirrender) [23:56:18] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/RelatedSites] - 10https://gerrit.wikimedia.org/r/451370 (owner: 10Umherirrender) [23:56:20] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/451355 (owner: 10Umherirrender) [23:56:22] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/SiteMatrix] - 10https://gerrit.wikimedia.org/r/451377 (owner: 10Umherirrender) [23:56:24] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/PageAssessments] - 10https://gerrit.wikimedia.org/r/451365 (owner: 10Umherirrender) [23:56:26] (03CR) 10Legoktm: [C: 032] Add phan-taint-check-plugin [extensions/ContactPage] - 10https://gerrit.wikimedia.org/r/451290 (owner: 10Umherirrender)