[00:04:47] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/449066 (owner: 10L10n-bot) [00:05:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ParserFunctions] - 10https://gerrit.wikimedia.org/r/449072 (owner: 10L10n-bot) [00:08:16] (03CR) 10Krinkle: [C: 031] Fix skins option to use currently displayed skin, rather than user preference (031 comment) [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/299950 (https://phabricator.wikimedia.org/T199478) (owner: 10Majr) [00:09:00] (03CR) 10Krinkle: [C: 031] RL: Simplify userrights check of Gadgets [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/449009 (owner: 10TheDJ) [00:21:16] (03CR) 10Legoktm: [C: 04-1] "This doesn't actually check anything as is...the default phan config requires the AbsenteeLandlord.class.php file to be in includes/." [extensions/AbsenteeLandlord] - 10https://gerrit.wikimedia.org/r/447142 (owner: 10MarcoAurelio) [00:28:30] (03CR) 10Reedy: Initial commit (032 comments) [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 (owner: 10Legoktm) [00:32:11] (03CR) 10Reedy: Initial commit (031 comment) [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 (owner: 10Legoktm) [00:38:07] (03PS5) 10Reedy: PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [00:38:23] (03CR) 10Reedy: [C: 032] PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [00:39:28] (03Abandoned) 10Reedy: Fix loading deps from vendor [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/443661 (owner: 10Paladox) [00:39:33] (03Abandoned) 10Reedy: Fix loading deps from vendor [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/443664 (owner: 10Paladox) [00:50:26] (03Merged) 10jenkins-bot: PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [00:53:11] (03CR) 10jenkins-bot: PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [00:54:06] (03PS2) 10Paladox: Guard against uncountable tag values [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/448976 (https://phabricator.wikimedia.org/T182377) [00:55:39] (03PS3) 10Paladox: Guard against uncountable tag values [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/448976 (https://phabricator.wikimedia.org/T182377) [00:55:51] (03CR) 10Paladox: "@Reedy Done." [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/448976 (https://phabricator.wikimedia.org/T182377) (owner: 10Paladox) [01:05:46] (03PS4) 10Paladox: Guard against uncountable tag values [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/448976 (https://phabricator.wikimedia.org/T182377) [01:13:16] 10MediaWiki-Watchlist, 10Growth-Team: View watchlist link different from expected link (on-hover) - https://phabricator.wikimedia.org/T200656 (10D3r1ck01) [01:16:07] 10MediaWiki-Watchlist, 10Growth-Team: View watchlist link different from expected link (on-hover) - https://phabricator.wikimedia.org/T200656 (10D3r1ck01) [01:17:09] 10MediaWiki-Watchlist, 10Growth-Team, 10wikitech.wikimedia.org: View watchlist link different from expected link (on-hover) - https://phabricator.wikimedia.org/T200656 (10D3r1ck01) [01:26:44] (03CR) 10Jforrester: "> Patch Set 1:" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/449018 (owner: 10MarcoAurelio) [01:27:29] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 10Growth-Team: Nullify ct_rc_id and ts_rc_id when recent changes entries are being deleted - https://phabricator.wikimedia.org/T191581 (10TTO) [01:27:33] 10MediaWiki-Database, 10DBA, 10Operations: Preserve InnoDB table auto_increment on restart - https://phabricator.wikimedia.org/T135851 (10TTO) [01:27:44] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 10Growth-Team: Nullify ct_rc_id and ts_rc_id when recent changes entries are being deleted - https://phabricator.wikimedia.org/T191581 (10TTO) Merging per Jaime's suggestion. [01:28:23] (03CR) 10MZMcBride: "Having a giant domains.php file seems kind of crazy. I would consider at least splitting the file into smaller chunks or perhaps switching" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 (owner: 10Legoktm) [01:40:32] 10MediaWiki-Logging, 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-notice: Convert Special:Log to OOUI - https://phabricator.wikimedia.org/T117737 (10Prtksxna) [01:40:37] 04(no projects): Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021) - https://phabricator.wikimedia.org/T200657 (10Prtksxna) [01:40:39] 10MediaWiki-Logging, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)): Convert log-show-hide-{$type} messages to logeventslist-{$type}-log - https://phabricator.wikimedia.org/T199657 (10Prtksxna) 05Open>03Resolved a:03Prtksxna [01:41:29] 10MediaWiki-Logging: Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021) - https://phabricator.wikimedia.org/T200657 (10Prtksxna) [01:41:54] 10MediaWiki-Logging, 10Easy: Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021) - https://phabricator.wikimedia.org/T200657 (10Prtksxna) p:05Triage>03Low [02:01:12] (03PS6) 10Legoktm: Initial commit [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 [02:01:22] (03CR) 10Legoktm: Initial commit (032 comments) [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 (owner: 10Legoktm) [02:02:52] (03CR) 10Legoktm: "> Patch Set 5:" [extensions/SecureLinkFixer] - 10https://gerrit.wikimedia.org/r/448987 (owner: 10Legoktm) [02:16:58] 10MobileFrontend, 10Readers-Web-Backlog (Design): Make lazy loading images resilient - https://phabricator.wikimedia.org/T136693 (10Jdlrobson) a:05Nirzar>03alexhollender @alexhollender can you pick up where nirzar left off? https://phabricator.wikimedia.org/T136693#3423361 This is mostly ready to be worked... [02:22:34] (03CR) 10BPirkle: "As someone still fairly new to the code, this is a discussion I’m very much interested in having, as it informs me of the design philosoph" [core] - 10https://gerrit.wikimedia.org/r/448566 (https://phabricator.wikimedia.org/T200524) (owner: 10Imarlier) [02:25:10] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Display section issues modal - https://phabricator.wikimedia.org/T197932 (10Jdlrobson) a:05alexhollender>03None Need code review! (https://... [02:25:14] 10MediaWiki-Database, 10DBA, 10Operations: Preserve InnoDB table auto_increment on restart - https://phabricator.wikimedia.org/T135851 (10GeoffreyT2000) >>! In T135851#2312924, @jcrespo wrote: > -1 disagreeing with the solution. > > This can happen also on master failover-which your solution will not protec... [02:29:53] 10Page-Previews, 10Readers-Web-Backlog: Page Preview does not appear when hovering over a link that spans multiple lines - https://phabricator.wikimedia.org/T199508 (10Jdlrobson) It would be worthwhile organising a spike/feasibility analysis before addressing this problem as it's risky, so we can expect this t... [02:32:44] 10Audiences-QA, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-17 (1.32.0-wmf.13)), and 2 others: Talk overlay "issues" are not visible in A/B test - https://phabricator.wikimedia.org/T199005 (10Jdlrobson) a:05Ryasmeen>03ovasileva [02:38:30] (03PS12) 10Samwilson: Add button to add or remove all parameter fields [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) [02:38:36] (03CR) 10Samwilson: Add button to add or remove all parameter fields (033 comments) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) (owner: 10Samwilson) [02:48:19] 10MediaWiki-Logging, 10Easy: Remove old log-show-hide-[type] messages in extensions (after 1.31 LTS is over - June 2021) - https://phabricator.wikimedia.org/T200657 (10Prtksxna) [02:58:33] (03CR) 10Tim Starling: "PS2 addressed Thiemo's comments." [core] - 10https://gerrit.wikimedia.org/r/447845 (owner: 10simetrical) [02:58:48] (03CR) 10Tim Starling: [C: 032] Use array_merge() for OutputPage::$mLanguageLinks, not + [core] - 10https://gerrit.wikimedia.org/r/447845 (owner: 10simetrical) [03:01:05] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Lazy loaded image placeholders cause horizontal scrollbar on small screens - https://phabricator.wikimedia.org/T200518 (10Jdlrobson) [03:01:43] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Lazy loaded image placeholders larger than viewport cause horizontal scrollbar on small screens - https://phabricator.wikimedia.org/T200518 (10Jdlrobson) [03:02:33] 10MobileFrontend, 10Readers-Web-Backlog: [Bug] Lazily loaded inline images cause reflow - should retain thumbborder - https://phabricator.wikimedia.org/T199351 (10Jdlrobson) [03:08:06] 10Contributors-Analysis, 10Product-Analytics: Get onboarded to the Product Analytics team - https://phabricator.wikimedia.org/T194336 (10JKatzWMF) [03:08:31] 10Contributors-Analysis, 10Product-Analytics: Get onboarded to the Product Analytics team - https://phabricator.wikimedia.org/T194336 (10JKatzWMF) [03:13:00] 10Contributors-Analysis, 10Product-Analytics: Onboard Morten Warncke-Wang to the Product Analytics team - https://phabricator.wikimedia.org/T193269 (10JKatzWMF) [03:14:38] (03Merged) 10jenkins-bot: Use array_merge() for OutputPage::$mLanguageLinks, not + [core] - 10https://gerrit.wikimedia.org/r/447845 (owner: 10simetrical) [03:17:17] (03CR) 10jenkins-bot: Use array_merge() for OutputPage::$mLanguageLinks, not + [core] - 10https://gerrit.wikimedia.org/r/447845 (owner: 10simetrical) [03:44:34] (03CR) 10Smalyshev: [C: 032] Add phan-taint-check-plugin [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/433893 (owner: 10Umherirrender) [03:51:06] 10MediaWiki-Database, 10Technical-Debt, 10Tracking: 1205: Lock wait timeout exceeded; try restarting transaction (tracking) - https://phabricator.wikimedia.org/T30499 (10aaron) [03:51:08] 10MediaWiki-Database, 10Core-Platform-Team, 10Performance-Team, 10Wikimedia-log-errors: WikiPage::updateCategoryCounts causing Lock wait timeout exceeded - https://phabricator.wikimedia.org/T199762 (10aaron) 05Open>03Resolved [03:58:57] (03CR) 10Yaron Koren: "James - great, thanks. I'm happy to talk about the star thing at any point." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/447011 (owner: 10Jamesmontalvo3) [03:59:19] (03PS1) 10Samwilson: Focus top empty field when adding all parameters [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/449108 (https://phabricator.wikimedia.org/T194436) [04:03:49] (03CR) 10Revi: "Hi lego, newbie waiting for CR :-)" [extensions/YouTube] - 10https://gerrit.wikimedia.org/r/449028 (owner: 10NessunKim) [04:07:16] (03CR) 10Jamesmontalvo3: [C: 04-1] "NS_FILE is not enabled by default. You'll need to enable it. Or use #approvable_by." [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/447011 (owner: 10Jamesmontalvo3) [04:08:17] (03Merged) 10jenkins-bot: Add phan-taint-check-plugin [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/433893 (owner: 10Umherirrender) [04:15:56] (03CR) 10Yaron Koren: "Oh, okay. How do I enable it? I added this to LocalSettings.php (after the inclusion of Approved Revs), but it didn't seem to have an impa" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/447011 (owner: 10Jamesmontalvo3) [04:20:37] (03CR) 10jenkins-bot: Add phan-taint-check-plugin [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/433893 (owner: 10Umherirrender) [04:21:44] (03CR) 10Jamesmontalvo3: [C: 04-1] "$egApprovedRevsEnabledNamespaces[NS_FILE] = true;" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/447011 (owner: 10Jamesmontalvo3) [04:32:14] 10MediaWiki-Database, 10DBA, 10Operations: Preserve InnoDB table auto_increment on restart - https://phabricator.wikimedia.org/T135851 (10GeoffreyT2000) 05Open>03Resolved a:03GeoffreyT2000 This is more of a MySQL bug than a MediaWiki bug. Anyway, this bug was actually originally reported in 2003 as [[h... [04:44:56] (03PS2) 10Samwilson: Focus top empty field when adding all parameters [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/449108 (https://phabricator.wikimedia.org/T194436) [04:57:21] 10Research-Archive, 10Research-collaborations, 10Research-management: Create a formal collaboration for WDQS research - https://phabricator.wikimedia.org/T135083 (10Smalyshev) [04:57:38] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Special:NewPage: Use an HTMLMultiSelectField instead of text links for filters - https://phabricator.wikimedia.org/T200659 (10Prtksxna) p:05Triage>03Normal [05:04:41] (03PS13) 10Prtksxna: Special:NewPages: Change to use OOUI [core] - 10https://gerrit.wikimedia.org/r/276946 (https://phabricator.wikimedia.org/T117739) (owner: 10Pankajeshkr) [05:06:23] 10MediaWiki-Logging, 10MediaWiki-Special-pages: Special:NewPage: Use an HTMLMultiSelectField instead of text links for filters - https://phabricator.wikimedia.org/T200659 (10Prtksxna) [05:06:48] (03CR) 10Prtksxna: Special:NewPages: Change to use OOUI (032 comments) [core] - 10https://gerrit.wikimedia.org/r/276946 (https://phabricator.wikimedia.org/T117739) (owner: 10Pankajeshkr) [05:12:47] (03PS1) 10Jack Phoenix: Don't double-escape the displayed link title [extensions/DPLforum] - 10https://gerrit.wikimedia.org/r/449110 (https://phabricator.wikimedia.org/T200652) [05:22:32] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 10Growth-Team: Nullify ct_rc_id and ts_rc_id when recent changes entries are being deleted - https://phabricator.wikimedia.org/T191581 (10GeoffreyT2000) 05duplicate>03Open This is not quite the same as T135851, which was about a MySQL bug that had b... [05:23:10] 10MediaWiki-Change-tagging, 10MediaWiki-Recent-changes, 10Growth-Team: Nullify ct_rc_id and ts_rc_id when recent changes entries are being deleted - https://phabricator.wikimedia.org/T191581 (10GeoffreyT2000) 05Open>03declined Per TTO and Ladsgroup (originally closed as a duplicate of T135851). [05:27:34] 10Design, 10Page-Previews, 10Wikimedia-Israel-Hackers, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Implement Citation Previews - https://phabricator.wikimedia.org/T67114 (10eranroz) @Jack_who_built_the_house thank you for the update in ruwiki. Would you like to submit it as a patch to gerrit? [05:35:18] (03CR) 10tosfos: "recheck" [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/399772 (owner: 10tosfos) [05:36:27] (03CR) 10jerkins-bot: [V: 04-1] Initial commit [extensions/PreferencesList] - 10https://gerrit.wikimedia.org/r/399772 (owner: 10tosfos) [05:38:27] 10Design, 10Page-Previews, 10Wikimedia-Israel-Hackers, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Implement Citation Previews - https://phabricator.wikimedia.org/T67114 (10Yair_rand) >>! In T67114#4460573, @eranroz wrote: > Would you like to submit it as a patch to gerrit? ReferenceTooltips is... [05:40:41] (03CR) 10Tim Starling: "> Patch Set 4:" [core] - 10https://gerrit.wikimedia.org/r/447647 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [05:49:49] 10Commons-Datasets: Provide a way to notate the format of dataset - https://phabricator.wikimedia.org/T200661 (10Bugreporter) [06:06:30] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Uploading, 10Multimedia: Upload to Wikimedia Commons fails with error "mustBeLoggedIn" - https://phabricator.wikimedia.org/T200560 (10maskaravivek) So does it suggest that we are not sending the session cookies with our POST request or is there a poss... [06:13:29] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Unable to cancel (close) dialog after starting search without selecting template - https://phabricator.wikimedia.org/T200662 (10Samwilson) [06:15:36] (03PS1) 10Samwilson: Fix bug with closing dialog before selecting any template [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/449112 (https://phabricator.wikimedia.org/T200662) [06:19:49] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Unable to cancel (close) dialog after starting search without selecting template - https://phabricator.wikimedia.org/T200662 (10Samwilson) This is a tiny thing; moving into the current sprint. Hope that's... [06:22:17] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Patch-For-Review: Unable to cancel (close) dialog after starting search without selecting template - https://phabricator.wikimedia.org/T200662 (10Samwilson) [06:24:44] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10GitHub-Mirrors: Mirror TemplateWizard on Github - https://phabricator.wikimedia.org/T200663 (10Samwilson) [06:34:32] (03PS1) 10Elukey: [WIP] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) [06:37:00] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) (owner: 10Elukey) [06:54:07] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add missing parameter types: content and boolean - https://phabricator.wikimedia.org/T200664 (10Samwilson) [06:55:45] 10Design, 10Page-Previews, 10Wikimedia-Israel-Hackers, 10Patch-For-Review, 10Readers-Web-Backlog (Design): Implement Citation Previews - https://phabricator.wikimedia.org/T67114 (10eranroz) >>! In T67114#4460578, @Yair_rand wrote: >>>! In T67114#4460573, @eranroz wrote: >> Would you like to submit it as... [06:56:11] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add missing parameter types: content and boolean - https://phabricator.wikimedia.org/T200664 (10Samwilson) [06:56:44] (03PS1) 10Jack Phoenix: Functionality and style fixes for Special:UserBoxes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/449125 [06:57:21] (03PS2) 10Elukey: [WIP] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) [06:57:46] (03CR) 10jerkins-bot: [V: 04-1] Functionality and style fixes for Special:UserBoxes [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/449125 (owner: 10Jack Phoenix) [06:57:48] (03CR) 10Robert Vogel: [C: 032] Autofixing MediaWiki.WhiteSpace.* errors [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/448278 (owner: 10Legoktm) [06:57:49] 10Wiki-Loves-Monuments-Sources: Add missing cs fields - https://phabricator.wikimedia.org/T200428 (10Lokal_Profil) Thanks. Ill do a patch later but adding the following to `fields` should do it. ``` { "dest": "monument_until", "source": "Památkou_do" }, {... [06:57:50] (03CR) 10Volans: "My 2 cents inline :)" (032 comments) [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) (owner: 10Elukey) [06:58:20] (03Merged) 10jenkins-bot: Autofixing MediaWiki.WhiteSpace.* errors [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/448278 (owner: 10Legoktm) [06:58:32] (03Merged) 10jenkins-bot: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/448279 (owner: 10Legoktm) [06:58:34] (03Merged) 10jenkins-bot: Autofixing PSR2.Namespaces.NamespaceDeclaration.BlankLineAfter errors [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/448280 (owner: 10Legoktm) [06:58:36] (03Merged) 10jenkins-bot: Autofixing Squiz.WhiteSpace.* errors [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/448281 (owner: 10Legoktm) [07:01:39] 10MediaWiki-Watchlist, 10Growth-Team: View watchlist link different from expected link (on-hover) - https://phabricator.wikimedia.org/T200656 (10Aklapper) How does this create a problem (while loading, the default URL filter parameters for that wiki get added to the URL)? [07:09:18] (03PS3) 10Elukey: [WIP] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) [07:12:59] (03PS4) 10Elukey: [WIP] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) [07:14:22] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Community-Tech-Sprint, 10Documentation: Create a help page for TemplateWizard - https://phabricator.wikimedia.org/T189908 (10Samwilson) Yes, I think a video is a good idea, and better screenshots. Should we just leave this task for the time being,... [07:14:59] (03PS1) 10Jack Phoenix: Make Comments play ball with MobileFrontend/MinervaNeue [extensions/Comments] - 10https://gerrit.wikimedia.org/r/449126 [07:15:34] (03PS7) 10ItSpiderman: Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 [07:15:41] (03CR) 10jerkins-bot: [V: 04-1] Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 (owner: 10ItSpiderman) [07:16:45] (03CR) 10Volans: "I'm not familiar with the eventlogging code, but the change looks good to me." (032 comments) [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) (owner: 10Elukey) [07:23:52] (03PS5) 10Elukey: Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) [07:23:55] (03PS1) 10ItSpiderman: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceEchoConnector into review/itspiderman/445355 [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449127 [07:23:57] 10Wiki-Loves-Monuments-Sources: Add missing cz fields - https://phabricator.wikimedia.org/T200428 (10Lokal_Profil) [07:24:04] (03CR) 10jerkins-bot: [V: 04-1] Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceEchoConnector into review/itspiderman/445355 [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449127 (owner: 10ItSpiderman) [07:24:06] (03CR) 10Nikerabbit: "> Patch Set 2: Code-Review-1" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/445059 (https://phabricator.wikimedia.org/T198173) (owner: 10Legoktm) [07:24:33] 10MediaWiki-Logging: Special:Log Warnings when changing log type - https://phabricator.wikimedia.org/T200174 (10Prtksxna) 05Open>03Invalid [07:24:47] 10MediaWiki-Logging, 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-notice: Convert Special:Log to OOUI - https://phabricator.wikimedia.org/T117737 (10Prtksxna) [07:26:12] (03PS1) 10Samwilson: Add 'content' type for parameters [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/449128 (https://phabricator.wikimedia.org/T200664) [07:26:41] 10MediaWiki-extensions-Translate, 10Language-2018-July-September, 10Patch-For-Review: Extension:Translate's languages box should look like interwiki language links - https://phabricator.wikimedia.org/T64702 (10Nikerabbit) >>! In T64702#4408764, @Jdlrobson wrote: > Minerva doesn't have this menu These langua... [07:30:03] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-Uploading, 10Multimedia: Upload to Wikimedia Commons fails with error "mustBeLoggedIn" - https://phabricator.wikimedia.org/T200560 (10Tgr) I'm not experienced with org.apache.http but it seems unlikely that it would print some cookies but not all. [07:32:37] (03PS8) 10ItSpiderman: Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 [07:33:15] 10WMSE-Riksarkivet-TORA: Define Libris and Tora as endpoints in Wikidata - https://phabricator.wikimedia.org/T200065 (10Salgo60) [07:34:20] (03PS3) 10Fomafix: Add type hint for ParserOutput [core] - 10https://gerrit.wikimedia.org/r/448745 [07:34:54] (03Abandoned) 10ItSpiderman: Merge branch 'master' of ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/BlueSpiceEchoConnector into review/itspiderman/445355 [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449127 (owner: 10ItSpiderman) [07:35:03] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/448745 (owner: 10Fomafix) [07:37:01] 10WMSE-Riksarkivet-TORA: Define Libris and Tora as endpoints in Wikidata - https://phabricator.wikimedia.org/T200065 (10Salgo60) [07:37:39] 10ContentTranslation, 10Language-2018-July-September: Cite tags are repeated in the MT output - https://phabricator.wikimedia.org/T200665 (10santhosh) [07:41:19] 10WMSE-Association-Involvement-2018 (Zynatic): Create standard message for started member - https://phabricator.wikimedia.org/T198486 (10Lokal_Profil) >>! In T198486#4453181, @Evelina-Bang-WMSE wrote: >>>! In T198486#4453148, @Lokal_Profil wrote: >> I noticed that "Ditt och andras medlemsengagemang stärker fören... [07:42:53] (03PS9) 10ItSpiderman: Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 [07:46:09] (03CR) 10Mforns: [C: 032] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) (owner: 10Elukey) [07:46:41] (03CR) 10Mforns: [V: 032 C: 032] Discard events with long user agents [eventlogging] - 10https://gerrit.wikimedia.org/r/449121 (https://phabricator.wikimedia.org/T200630) (owner: 10Elukey) [07:48:20] (03PS2) 10ItSpiderman: Phpunit tests [extensions/BlueSpiceInsertTemplate] - 10https://gerrit.wikimedia.org/r/448036 [07:50:59] (03CR) 10jerkins-bot: [V: 04-1] Phpunit tests [extensions/BlueSpiceInsertTemplate] - 10https://gerrit.wikimedia.org/r/448036 (owner: 10ItSpiderman) [07:51:40] (03CR) 10Jdlrobson: [C: 031] "Shame there's no easier way, but we should push ahead to unblock other work. We can hopefully find a better way in future - am a little co" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/448606 (https://phabricator.wikimedia.org/T188261) (owner: 10Niedzielski) [07:54:14] (03CR) 10Jdlrobson: [C: 031] Treat p nodes with mw-empty-elt as empty paragraphs (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/448060 (https://phabricator.wikimedia.org/T199282) (owner: 10Pmiazga) [07:55:09] (03CR) 10Jdlrobson: [C: 04-1] "Want to understand if normalize-space can be used here. I don't like the reliance on classes defined in core. Seems very brittle." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/448060 (https://phabricator.wikimedia.org/T199282) (owner: 10Pmiazga) [07:56:44] 10Wikimania-Hackathon-2017: Wikimania Hackathon 2017 Volunteer Group: Help work with or teach newcomers - https://phabricator.wikimedia.org/T168756 (10Aklapper) 05Open>03Resolved @halfak, rfarrand: T168756#3533585 could be incorporated in T169128. Closing this task as it was a year ago. [07:56:46] 10Developer-Advocacy (Jul-Sep 2017): Organize the Wikimania Hackathon 2017 in Montreal - https://phabricator.wikimedia.org/T170226 (10Aklapper) [07:59:18] (03CR) 10Jdlrobson: Refactor revision check out of formatRow (032 comments) [core] - 10https://gerrit.wikimedia.org/r/448001 (https://phabricator.wikimedia.org/T199066) (owner: 10Jdlrobson) [08:00:07] 10Documentation: Documentation sprint @Hackathon 2018 - https://phabricator.wikimedia.org/T187319 (10Aklapper) [08:01:11] (03PS5) 10Jdlrobson: Special:MobileContributions should use ContribsPager [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/447612 (https://phabricator.wikimedia.org/T199066) [08:01:39] 10Wikimedia-Hackathon-2018: Security training session at hackathon for MediaWiki extension developers and gadget authors. - https://phabricator.wikimedia.org/T194713 (10Aklapper) 05Open>03Resolved a:03Bawolff @Bawolff: AFAIK this took place, hence closing task as resolved [08:07:55] 10Operations-Software-Development, 10Beta-Cluster-reproducible, 10Patch-For-Review: Cumin JSON output format broken - https://phabricator.wikimedia.org/T200622 (10Volans) @Krenair Thanks for reporting this issue, I'm sending a separate patch to fix both `json` and `txt` choices of the `-o/--output` option an... [08:13:21] (03CR) 10Jdlrobson: Separate the LazyLoadedImages transform from MobileFormatter (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/448415 (https://phabricator.wikimedia.org/T186823) (owner: 10Jdlrobson) [08:14:49] 10WMSE-Riksarkivet-TORA: Define Libris and Tora as endpoints in Wikidata - https://phabricator.wikimedia.org/T200065 (10Salgo60) [08:16:28] 10MediaWiki-Change-tagging, 10Wikidata-Campsite, 10User-Ladsgroup, 10Wikimedia-maintenance-script-run: Run maintenance script to populate change_tag_def on WMF production (all wikis) - https://phabricator.wikimedia.org/T193873 (10Ladsgroup) [08:27:01] (03CR) 10Legoktm: "I uncommented the disabled setTemporaryHook related tests and couldn't trigger any failures. What errors were you seeing?" [core] - 10https://gerrit.wikimedia.org/r/447631 (owner: 10simetrical) [08:29:44] 10New-Readers: [EPIC] Wikipedia offline medical pilot - https://phabricator.wikimedia.org/T193297 (10JRabah) [08:31:26] 10Dumps-Generation: generate and email monthly stats to xmldumps mailing list - https://phabricator.wikimedia.org/T142435 (10ArielGlenn) 05Open>03Resolved The mail arrived and looks fine, closing this. [08:32:16] 10ContentTranslation: Infobox templates are being parsed and substituted with Content Translation - https://phabricator.wikimedia.org/T200615 (10Pginer-WMF) Thanks for the feedback and examples, @stjn Content Translation uses the standard editing surface that browsers provide, which is not always reliable when... [08:35:31] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:37:00] 10Dumps-Generation: Check for slow meta-history runs for small wikis and see about speedups - https://phabricator.wikimedia.org/T199204 (10ArielGlenn) [08:37:02] 10Dumps-Generation, 10Patch-For-Review: add hewiki to 'big wikis' for xml/sql dumps - https://phabricator.wikimedia.org/T200146 (10ArielGlenn) 05Open>03Resolved This is deployed. [08:38:33] 10Design, 10WMDE-FUN-Team, 10WMDE-Fundraising-Tech, 10Story, and 2 others: Display information on bank account data of WMFG - https://phabricator.wikimedia.org/T188489 (10Tonina_Zhelyazkova_WMDE) a:03Tonina_Zhelyazkova_WMDE [08:38:41] (03CR) 10Nikerabbit: [C: 032] "There seems to be a slight difference that isset returns false for null value, for which previous code returned true. I don't think it mat" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/449097 (owner: 10Legoktm) [08:38:46] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10GitHub-Mirrors: Mirror TemplateWizard on Github - https://phabricator.wikimedia.org/T200663 (10MarcoAurelio) IIRC this is done automatically by the Gerrit's `replication` plugin, right? [08:39:21] (03CR) 10Legoktm: [C: 032] Declare missing $this->user properties in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/449014 (owner: 10Thiemo Kreuz (WMDE)) [08:39:23] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:39:36] 10Contributors-Analysis, 10Product-Analytics: Get up to speed on the Product Analytics team - https://phabricator.wikimedia.org/T194336 (10Neil_P._Quinn_WMF) [08:40:06] (03PS4) 10DCausse: Setup es6 branch [extensions/CirrusSearch] (wmf/es6) - 10https://gerrit.wikimedia.org/r/448546 (https://phabricator.wikimedia.org/T199256) [08:40:08] (03PS3) 10DCausse: Drop support for the '_all' field (already disabled by default) [extensions/CirrusSearch] (wmf/es6) - 10https://gerrit.wikimedia.org/r/448547 [08:42:17] (03CR) 10MarcoAurelio: "> So...should we have the test also check for action-* messages?" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/449018 (owner: 10MarcoAurelio) [08:42:44] 10Readers-Web-Backlog (Design): External links inside ReferenceDrawer do not show the external link icon - https://phabricator.wikimedia.org/T200491 (10ovasileva) p:05Triage>03Normal [08:42:45] (03CR) 10Legoktm: [C: 04-1] "Looks fine, but see inline comment" (031 comment) [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/449004 (owner: 10Thiemo Kreuz (WMDE)) [08:43:22] (03CR) 10WMDE-Fisch: [C: 031] Remove long-dead OutputPage methods set/getPageTitleActionText() [core] - 10https://gerrit.wikimedia.org/r/449022 (https://phabricator.wikimedia.org/T200643) (owner: 10simetrical) [08:44:51] 10Design, 10UI-Standardization, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), and 3 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10ovasileva) 05Open>03stalled rollback done. Removing this fr... [08:45:59] (03Merged) 10jenkins-bot: Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/449097 (owner: 10Legoktm) [08:46:05] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:46:28] (03Merged) 10jenkins-bot: Declare missing $this->user properties in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/449014 (owner: 10Thiemo Kreuz (WMDE)) [08:47:49] (03CR) 10jenkins-bot: Declare missing $this->user properties in tests [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/449014 (owner: 10Thiemo Kreuz (WMDE)) [08:47:50] 10Contributors-Analysis, 10Product-Analytics: Onboard Morten Warncke-Wang to the Product Analytics team - https://phabricator.wikimedia.org/T193269 (10Neil_P._Quinn_WMF) [08:48:53] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Gerrit, 10GitHub-Mirrors: Mirror TemplateWizard on Github - https://phabricator.wikimedia.org/T200663 (10MarcoAurelio) [08:50:14] (03CR) 10MarcoAurelio: [C: 032] Document 'right-sa-access' [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/448997 (https://phabricator.wikimedia.org/T200617) (owner: 10Jayprakash12345) [08:50:24] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:51:01] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [08:51:34] (03CR) 10Legoktm: [C: 032] "Overall seems reasonable for now." [core] - 10https://gerrit.wikimedia.org/r/447630 (owner: 10simetrical) [08:54:17] (03CR) 10Jack Phoenix: "> > So...should we have the test also check for action-* messages?" [extensions/StopForumSpam] - 10https://gerrit.wikimedia.org/r/449018 (owner: 10MarcoAurelio) [08:56:43] 10Contributors-Analysis, 10Product-Analytics: Get up to speed on the Product Analytics team - https://phabricator.wikimedia.org/T194336 (10Neil_P._Quinn_WMF) [08:57:32] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/447821 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [08:57:33] 10ContentTranslation, 10Language-2018-July-September: CX2: Auto-save the content when navigating away with unsaved changes using the browser back button - https://phabricator.wikimedia.org/T200502 (10Pginer-WMF) p:05Triage>03Normal [09:02:03] (03Abandoned) 10Jdlrobson: Add span inside lazy image placeholder to cope with image resizes [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/447765 (https://phabricator.wikimedia.org/T197188) (owner: 10Jdlrobson) [09:04:00] (03CR) 10Legoktm: [C: 04-1] "I reviewed a few files, the main thing that stood out to me was that it doesn't make sense to repeatedly call MediaWikiServices::getInstan" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/448094 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [09:04:50] 10MediaWiki-General-or-Unknown, 10Goal, 10Patch-For-Review, 10User-MarcoAurelio, 10WorkType-Maintenance: Several extensions affected by AvailableRightsTest::testAllRightsWithMessage PHPUnit test failure - https://phabricator.wikimedia.org/T200565 (10MarcoAurelio) [09:05:25] 10Design, 10MinervaNeue, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-05-29 (1.32.0-wmf.6)): Enable mediawiki.page.ready on Minerva (collapsible templates (including infoboxes) - https://phabricator.wikimedia.org/T111565 (10Jdlrobson) [09:06:41] (03Merged) 10jenkins-bot: Document 'right-sa-access' [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/448997 (https://phabricator.wikimedia.org/T200617) (owner: 10Jayprakash12345) [09:06:46] (03Merged) 10jenkins-bot: Move utility methods from ApiTestCase to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/447630 (owner: 10simetrical) [09:07:14] 10MediaWiki-extensions-SecureAuth, 10Easy, 10User-Jayprakash12345: Document 'right-sa-access' - https://phabricator.wikimedia.org/T200617 (10MarcoAurelio) 05Open>03Resolved [09:07:22] (03CR) 10MarcoAurelio: "recheck" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/448602 (owner: 10Libraryupgrader) [09:07:29] (03PS2) 10MarcoAurelio: build: Updating mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/448602 (owner: 10Libraryupgrader) [09:09:10] (03CR) 10Pablo Grass (WMDE): selenium: invoke jobs to enforce eventual consistency (031 comment) [core] - 10https://gerrit.wikimedia.org/r/446543 (https://phabricator.wikimedia.org/T199446) (owner: 10Pablo Grass (WMDE)) [09:09:51] (03CR) 10jenkins-bot: Move utility methods from ApiTestCase to MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/447630 (owner: 10simetrical) [09:12:30] (03CR) 10DCausse: [C: 04-1] "marking as -1 to make it clear that something needs to be changed:" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/447571 (owner: 10Jack Phoenix) [09:12:33] (03CR) 10MarcoAurelio: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 21.0.0 [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/448602 (owner: 10Libraryupgrader) [09:13:31] (03CR) 10jerkins-bot: [V: 04-1] Introduce ContLang service to replace $wgContLang [core] - 10https://gerrit.wikimedia.org/r/447821 (https://phabricator.wikimedia.org/T200246) (owner: 10simetrical) [09:16:09] (03CR) 10MarcoAurelio: [C: 032] build: Add mediawiki/mediawiki-codesniffer [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449088 (owner: 10Legoktm) [09:16:32] (03CR) 10MarcoAurelio: [C: 032] Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449089 (owner: 10Legoktm) [09:17:14] (03CR) 10MarcoAurelio: [C: 032] Autofixing MediaWiki.WhiteSpace.* errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449090 (owner: 10Legoktm) [09:17:23] (03CR) 10MarcoAurelio: [C: 032] Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449091 (owner: 10Legoktm) [09:18:53] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Patch-For-Review: Introduce MagicWordFactory service - https://phabricator.wikimedia.org/T200247 (10Legoktm) >>! In T200247#4454163, @Simetrical wrote: > Or, if there's anyone in a more compatible timezone who understands what I'm... [09:18:53] (03CR) 10Robert Vogel: [C: 032] Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 (owner: 10ItSpiderman) [09:18:56] 10MobileFrontend, 10Readers-Web-Backlog: Wikitext editor error handling broken in read only mode - https://phabricator.wikimedia.org/T197499 (10Jdlrobson) Looking like a 3. Confirmation to follow! [09:20:39] (03CR) 10Jdlrobson: [C: 031] "LGTM but cannot vouch for the Wikidata code." [extensions/Math] - 10https://gerrit.wikimedia.org/r/443941 (https://phabricator.wikimedia.org/T173949) (owner: 10Physikerwelt) [09:20:50] (03CR) 10Legoktm: [C: 04-1] MagicWordFactory to replace MagicWord static members/methods (034 comments) [core] - 10https://gerrit.wikimedia.org/r/447647 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [09:20:58] (03CR) 10Robert Vogel: [V: 032] Added missing message for right "wikiadmin" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448491 (owner: 10Pwirth) [09:21:37] (03CR) 10Robert Vogel: [C: 032] Add permission message [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/448520 (owner: 10ItSpiderman) [09:23:20] (03Merged) 10jenkins-bot: build: Add mediawiki/mediawiki-codesniffer [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449088 (owner: 10Legoktm) [09:23:22] (03Merged) 10jenkins-bot: Autofixing Generic.Arrays.DisallowLongArraySyntax.Found errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449089 (owner: 10Legoktm) [09:23:25] (03Merged) 10jenkins-bot: Autofixing MediaWiki.WhiteSpace.* errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449090 (owner: 10Legoktm) [09:24:28] (03PS1) 10PortalsBuilder: Assets build - 2018-07-30 09:24:27+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/449135 [09:24:51] (03Merged) 10jenkins-bot: Autofixing PSR2.Files.EndFileNewline.NoneFound errors [extensions/AutoCreateCategoryPages] - 10https://gerrit.wikimedia.org/r/449091 (owner: 10Legoktm) [09:24:54] (03Merged) 10jenkins-bot: Move param logic to Notification objects [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/445355 (owner: 10ItSpiderman) [09:26:19] (03CR) 10Robert Vogel: [C: 032] Add CategoryList param + add permission to $wgAvailableRights [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448446 (owner: 10ItSpiderman) [09:29:29] (03PS7) 10ItSpiderman: Add CategoryList param + add permission to $wgAvailableRights [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448446 [09:29:56] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions: Problem on restoring/undeleting revisions on updated wiki - https://phabricator.wikimedia.org/T200653 (10Ciencia_Al_Poder) It may be another instance of {T195692}, but this one is on a different field The [[ https://www.mediawiki.org/wiki/Manual:Revisi... [09:30:04] (03CR) 10Robert Vogel: [C: 032] Add CategoryList param + add permission to $wgAvailableRights [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448446 (owner: 10ItSpiderman) [09:30:45] (03CR) 10Robert Vogel: [V: 032 C: 032] Added message for right "pagetemplatesadmin-viewspecialpage" [extensions/BlueSpicePageTemplates] - 10https://gerrit.wikimedia.org/r/448497 (owner: 10Pwirth) [09:31:16] (03CR) 10Robert Vogel: [C: 032] Add search history tracking, preferred namespaces [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/448417 (owner: 10ItSpiderman) [09:31:23] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Ciencia_Al_Poder) [09:32:14] 10MediaWiki-Revision-deletion, 10Multi-Content-Revisions, 10MW-1.31-release: Error undeleting page: IncompleteRevisionException: sha1 field must not be ! - https://phabricator.wikimedia.org/T200653 (10Ciencia_Al_Poder) [09:33:32] (03CR) 10jerkins-bot: [V: 04-1] Add CategoryList param + add permission to $wgAvailableRights [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448446 (owner: 10ItSpiderman) [09:37:10] 10MediaWiki-General-or-Unknown, 10Core-Platform-Team (CPT-Q1-Jul-Sep-2018), 10Patch-For-Review: Introduce MagicWordFactory service - https://phabricator.wikimedia.org/T200247 (10Legoktm) >>! In T200247#4454163, @Simetrical wrote: > So I think I need an explanation of exactly how you want classes to access th... [09:37:41] (03CR) 10Legoktm: "I left a comment on T200247#4460958 regarding this patch." [core] - 10https://gerrit.wikimedia.org/r/447786 (https://phabricator.wikimedia.org/T200247) (owner: 10simetrical) [09:38:23] (03CR) 10Matěj Suchánek: "Rebase please" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/375531 (https://phabricator.wikimedia.org/T159069) (owner: 10Huji) [09:39:37] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [09:40:28] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Salgo60) [09:41:08] (03CR) 10Pwirth: "recheck" [extensions/BlueSpiceInsertTemplate] - 10https://gerrit.wikimedia.org/r/448036 (owner: 10ItSpiderman) [09:42:43] 10Design, 10Front-end-Standards-Group, 10Wikidata, 10Wikidocumentaries, and 3 others: CONSULTATION/PLAN: Managing Complex State and GUI on MediaWiki (e.g. for Wikidata/Wikibase UI) - https://phabricator.wikimedia.org/T157014 (10Addshore) >>! In T157014#4458720, @Lydia_Pintscher wrote: >>>! In T157014#44563... [09:43:52] (03CR) 10jerkins-bot: [V: 04-1] Phpunit tests [extensions/BlueSpiceInsertTemplate] - 10https://gerrit.wikimedia.org/r/448036 (owner: 10ItSpiderman) [09:48:18] (03CR) 10jerkins-bot: [V: 04-1] Add permission message [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/448520 (owner: 10ItSpiderman) [09:48:20] (03CR) 10jerkins-bot: [V: 04-1] Add CategoryList param + add permission to $wgAvailableRights [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/448446 (owner: 10ItSpiderman) [09:48:22] (03Merged) 10jenkins-bot: Add search history tracking, preferred namespaces [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/448417 (owner: 10ItSpiderman) [09:50:33] 10Design, 10UI-Standardization, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), and 3 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10ovasileva) [09:51:24] 10Design, 10UI-Standardization, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), and 3 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10ovasileva) >>! In T190549#4460881, @Jdlrobson wrote: > Please co... [09:58:08] (03PS3) 10ItSpiderman: Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 [10:00:25] (03CR) 10jerkins-bot: [V: 04-1] Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 (owner: 10ItSpiderman) [10:00:47] 10Phabricator, 10Regression: Creating subtasks sets more restrictive edit permissions than parent task: Others cannot edit such subtasks anymore - https://phabricator.wikimedia.org/T199122 (10MGChecker) I can confirm this is not only confusing but *really* annoying and disturbing in daily work on Phabricator.... [10:01:47] (03PS4) 10ItSpiderman: Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 [10:01:52] (03PS1) 10Addshore: Add @since tag for MediawikiServices::getConfigRepository [core] - 10https://gerrit.wikimedia.org/r/449138 [10:02:19] (03PS1) 10Prtksxna: Special:NewPage: Use an HTMLMultiSelectField for filters [core] - 10https://gerrit.wikimedia.org/r/449139 (https://phabricator.wikimedia.org/T200659) [10:03:59] 10WMSE-Riksarkivet-TORA: Design how the TORA object should be mapped in Wikidata - https://phabricator.wikimedia.org/T199794 (10Salgo60) [10:05:29] 10MediaWiki-extensions-ORES, 10MediaWiki-extensions-PageAssessments, 10Community-Tech, 10Scoring-platform-team: Implement ORES wp10 predictions in PageAssessments tool - https://phabricator.wikimedia.org/T156820 (10Ladsgroup) The data is now stored in ores_classification table. Whether it should be used in... [10:05:48] (03CR) 10jerkins-bot: [V: 04-1] Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 (owner: 10ItSpiderman) [10:07:30] 10WMSE-Riksarkivet-TORA: Design how the TORA object should be mapped in Wikidata - https://phabricator.wikimedia.org/T199794 (10Salgo60) [10:09:13] (03CR) 10Prtksxna: "Oops, didn't mean to do that, sorry" [core] - 10https://gerrit.wikimedia.org/r/327039 (owner: 10VolkerE) [10:11:18] 10WMSE-Riksarkivet-TORA: Set up Nobel Data as federated search with Wikidata? - https://phabricator.wikimedia.org/T200668 (10Fnielsen) In Scholia, we have an aspect for awards. For the Nobel Prize in Physics it is available here: https://tools.wmflabs.org/scholia/award/Q38104 [10:12:30] (03PS2) 10Legoktm: Add @since tag for MediaWikiServices::getConfigRepository [core] - 10https://gerrit.wikimedia.org/r/449138 (owner: 10Addshore) [10:12:38] (03CR) 10Legoktm: [C: 032] Add @since tag for MediaWikiServices::getConfigRepository [core] - 10https://gerrit.wikimedia.org/r/449138 (owner: 10Addshore) [10:12:47] 10Design, 10UI-Standardization, 10MinervaNeue, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)), and 3 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10Jdlrobson) [10:13:34] (03CR) 10Prtksxna: "I am a bit confused, is this required?" [core] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/447466 (https://phabricator.wikimedia.org/T200136) (owner: 10Greg Grossmeier) [10:19:13] (03CR) 10Prtksxna: [C: 032] Prefill date in form on Special:Log when calling with old parameters [core] - 10https://gerrit.wikimedia.org/r/448147 (https://phabricator.wikimedia.org/T199856) (owner: 10Bartosz Dziewoński) [10:19:36] 10Design, 10Front-end-Standards-Group, 10Wikidata, 10Wikidocumentaries, and 3 others: CONSULTATION/PLAN: Managing Complex State and GUI on MediaWiki (e.g. for Wikidata/Wikibase UI) - https://phabricator.wikimedia.org/T157014 (10Jdlrobson) My team (reading web) as part of T195473 is planning to use webpack... [10:19:49] 10MediaWiki-Codesniffer: Look for @parma typo (should be @param) - https://phabricator.wikimedia.org/T182057 (10matej_suchanek) 05Open>03Resolved [10:19:51] 10MediaWiki-Logging, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10Regression: Special:Log form should be using GET not POST - https://phabricator.wikimedia.org/T199856 (10Prtksxna) [10:19:53] 10AbuseFilter, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)): Remove coding standard rule exclusions in AbuseFilter and fix the coding standards - https://phabricator.wikimedia.org/T178007 (10Daimona) [10:20:06] 10MediaWiki-Logging, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10Regression: Special:Log form should be using GET not POST - https://phabricator.wikimedia.org/T199856 (10Prtksxna) 05Open>03Resolved a:03Prtksxna [10:20:09] 10MediaWiki-Logging, 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-notice: Convert Special:Log to OOUI - https://phabricator.wikimedia.org/T117737 (10Prtksxna) [10:20:13] (03CR) 10jerkins-bot: [V: 04-1] Special:NewPage: Use an HTMLMultiSelectField for filters [core] - 10https://gerrit.wikimedia.org/r/449139 (https://phabricator.wikimedia.org/T200659) (owner: 10Prtksxna) [10:21:03] 10MediaWiki-Logging, 10UI-Standardization, 10MW-1.32-release-notes (WMF-deploy-2018-07-24 (1.32.0-wmf.14)), 10Patch-For-Review, 10User-notice: Convert Special:Log to OOUI - https://phabricator.wikimedia.org/T117737 (10Prtksxna) [10:25:17] (03PS2) 10Prtksxna: Special:NewPage: Use an HTMLMultiSelectField for filters [core] - 10https://gerrit.wikimedia.org/r/449139 (https://phabricator.wikimedia.org/T200659) [10:25:52] 10GoogleLogin: GoogleLogin login button should take precedence over username/password - https://phabricator.wikimedia.org/T199999 (10Petar.petkovic) [10:26:19] (03PS2) 10Jdlrobson: WIP: Hygiene: forbid location and history manipulation [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/447422 (owner: 10Niedzielski) [10:28:02] (03CR) 10Jdlrobson: [C: 04-1] "Note, we do this in MobileFrontend as most of the time we'll dealing with reusable classes." [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/447422 (owner: 10Niedzielski) [10:28:32] (03CR) 10Jdlrobson: [C: 04-1] "Ping. Can this be explained or abandoned? (136 days old!)" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/419964 (https://phabricator.wikimedia.org/T189754) (owner: 10VolkerE) [10:30:40] (03Abandoned) 10Jdlrobson: WIP: TODOs and possible savings - Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 (owner: 10Jdlrobson) [10:31:42] (03Merged) 10jenkins-bot: Add @since tag for MediaWikiServices::getConfigRepository [core] - 10https://gerrit.wikimedia.org/r/449138 (owner: 10Addshore) [10:31:44] 10MobileFrontend, 10Readers-Web-Backlog: Restore Watchlist functionality to grade C browsers e.g. Windows Phone 8 - https://phabricator.wikimedia.org/T196893 (10Jdlrobson) [10:32:05] (03Abandoned) 10Jdlrobson: [POC] fade for placing learn-more button on same line as content. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/440556 (https://phabricator.wikimedia.org/T191303) (owner: 10Jdrewniak) [10:34:30] (03CR) 10jenkins-bot: Add @since tag for MediaWikiServices::getConfigRepository [core] - 10https://gerrit.wikimedia.org/r/449138 (owner: 10Addshore) [10:35:55] 10Page-Previews, 10Readers-Web-Backlog (Design): [Bug] Middle and control clicking popup footer doesn't open new tab - https://phabricator.wikimedia.org/T198708 (10ovasileva) >>! In T198708#4449683, @Jdlrobson wrote: > @alexhollender @ovasileva has suggested this is normal priority and am trying to work out if... [10:36:40] (03CR) 10jerkins-bot: [V: 04-1] WIP: Hygiene: forbid location and history manipulation [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/447422 (owner: 10Niedzielski) [10:37:10] 10Page-Previews, 10Readers-Web-Backlog, 10Epic, 10Readers-Web-Kanbanana-Board: [EPIC] Page previews post-deploy cleanup - https://phabricator.wikimedia.org/T192622 (10ovasileva) [10:39:58] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Mobile page issues - instrument page issues - https://phabricator.wikimedia.org/T191532 (10Jdlrobson) Update. There are 4 unmerged patches all with -1s. Wikimedia Events: * [[ https://gerrit.wikimedia.org/r/4... [10:42:43] (03CR) 10Ladsgroup: [C: 04-1] "> Patch Set 3:" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/447082 (https://phabricator.wikimedia.org/T198982) (owner: 10Sbisson) [10:46:18] 10MediaWiki-extensions-ORES, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Scoring-platform-team, and 3 others: Index on oresc_probability, temporarily or permanently - https://phabricator.wikimedia.org/T175778 (10Ladsgroup) a:03Ladsgroup I'm officially picking this up but first, I need a maintena... [10:46:56] 10MediaWiki-Codesniffer: Add sniff to prevent using config globals when Config is available - https://phabricator.wikimedia.org/T200679 (10matej_suchanek) [10:49:14] 10MediaWiki-extensions-ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Rework PurgeScoreCache.php - https://phabricator.wikimedia.org/T200680 (10Ladsgroup) p:05Triage>03High [10:52:14] (03PS1) 10Gergő Tisza: Segregate right to edit sitewide CSS/JS [core] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/449153 (https://phabricator.wikimedia.org/T120886) [10:56:36] (03PS9) 10Jdlrobson: Reading depth hook should send additional sampling bucket parameter [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) (owner: 10Jdrewniak) [10:57:27] (03CR) 10TheDJ: [C: 04-1] RL: Only add gadget if it supports the target [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/449005 (https://phabricator.wikimedia.org/T171180) (owner: 10TheDJ) [11:00:29] (03CR) 10simetrical: "https://integration.wikimedia.org/ci/job/mediawiki-quibble-composer-mysql-php70-docker/3063/console" [core] - 10https://gerrit.wikimedia.org/r/447631 (owner: 10simetrical) [11:01:38] legoktm: Ping. [11:01:43] AryehGregor: pong! [11:02:20] legoktm: You're UTC-0700? [11:02:38] yes [11:02:44] You're just nocturnal? :) [11:02:49] Anyway. [11:02:55] (03CR) 10Gergő Tisza: [C: 032] Segregate right to edit sitewide CSS/JS [core] (wmf/1.32.0-wmf.14) - 10https://gerrit.wikimedia.org/r/448168 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [11:03:03] (03CR) 10Gergő Tisza: [C: 032] Segregate right to edit sitewide CSS/JS [core] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/449153 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [11:03:11] Let me just read your comments. [11:03:16] I don't identify with any specific timezone ;) [11:04:32] legoktm: So when Parser is finally a service, whatever that means, how will it get its MagicWordFactory? In its constructor, which is only called by MediaWikiServices? [11:06:24] By the way, very few places construct a Parser, so I could feasibly convert them all to work however we want. [11:06:37] Basically, yeah. At that point most callers would be getting the Parser from MWServices or injected, and the in ServiceWiring, the Parser constructor would get the MagicWordFactory [11:06:37] (well, I guess you could see how many there are from my patch) [11:07:58] https://codesearch.wmflabs.org/extensions/?q=ParserConf&i=nope&files=php&repos= there's a decent amount [11:08:37] legoktm: Well, we can leave a default value for the second parameter and get it from MWS, soft- or hard-deprecated. [11:08:39] 10WMSE-Riksarkivet-TORA: Define Libris XL as an endpoint in Wikidata - https://phabricator.wikimedia.org/T200067 (10Lokal_Profil) Per https://www.kb.se/libris/Oppna-data/ //svensk nationalbibliografi// and //svenska auktoritetsposter// are CC0 [11:08:45] right [11:08:52] 10Operations-Software-Development, 10Beta-Cluster-reproducible: Cumin JSON output format broken - https://phabricator.wikimedia.org/T200622 (10Volans) 05Open>03Resolved Cumin 3.0.2 has been released and includes a fix for this bug. Thanks a lot for reporting it. I'll take care of upgrading production, but... [11:08:53] (03CR) 10Mglaser: [C: 04-1] Add notification base class (033 comments) [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 (owner: 10ItSpiderman) [11:09:23] legoktm: So the problem seems to be more that I shouldn't convert call sites to pass in a MagicWordFactory, but rather I should update them to get the Parser from MWS, right? [11:09:55] legoktm: What should they do if they need a new parser for tests, not the existing ones? [11:10:10] (I could look at the code that already exists for that in the unit tests) [11:12:50] AryehGregor: Yeah, having things use Parser from MWS would be good, but that's also an increase in scope as well / more work. From my POV, the refactoring of static methods -> MagicWordFactory is worthwhile on its own, and then the question of how much/where DI happens is another thing [11:12:59] 10Design, 10Front-end-Standards-Group, 10Wikidata, 10Wikidocumentaries, and 3 others: CONSULTATION/PLAN: Managing Complex State and GUI on MediaWiki (e.g. for Wikidata/Wikibase UI) - https://phabricator.wikimedia.org/T157014 (10TheDJ) >>! In T157014#4460961, @Addshore wrote: > I seem to remember @daniel ha... [11:13:45] AryehGregor: there's Parser::getFreshParser(), but I suppose it depends on how clean of a parser they need. Maybe we need a ParserFactory then [11:14:03] legoktm: Well, I made switching Parser to MWF a new patch, right? :) The work is basically done AFAICT, I'd just have to go over the call sites and change them to stop using new Parser(). [11:16:36] The fact that extensions are having to do: `$class = $wgParserConf['class']; $parser = new $class( $wgParserConf );` means that we really need something better [11:16:51] AryehGregor: right :) [11:17:41] legoktm: So my patch is fine if I just change all the call sites to use the existing global parser? And if that causes test failures, have them reset the parser service beforehand? [11:19:14] (03PS1) 10Pwirth: Article preview: Added revision id as a param ERM:10236 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/449156 [11:19:37] (I don't actually understand what the benefit of this is relative to sticking with a global and just modifying $wgParser, though) [11:20:31] (03Merged) 10jenkins-bot: Segregate right to edit sitewide CSS/JS [core] (wmf/1.32.0-wmf.14) - 10https://gerrit.wikimedia.org/r/448168 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [11:20:43] modifying the $wgParser construction in Setup.php you mean? [11:21:16] legoktm: No, I mean what's the point of DI if everything ultimately winds up using a parser from MWS anyway? I'd understand if you needed multiple things using different Parsers at the same time. [11:21:54] (03CR) 10Reedy: [C: 032] Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449093 (owner: 10Legoktm) [11:22:08] (03CR) 10Reedy: [C: 032] Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/449094 (owner: 10Legoktm) [11:22:28] in the long run everything wouldn't get the parser from MWS, they'd have it injected [11:22:33] (03PS1) 10PleaseStand: Add parentheses around nested inline IF statements [core] - 10https://gerrit.wikimedia.org/r/449157 [11:22:55] (03PS2) 10Pwirth: Article preview: Added revision id as a param ERM:10236 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/449156 [11:23:32] legoktm: But it still winds up being everything using the same parser object (except if one took a reference before it was reset to a new object)? [11:24:12] Maybe for some reason we'd want to support different callers transparently getting different objects when they need a parser, but I don't see how that's useful for testing. [11:24:33] (03PS5) 10ItSpiderman: Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 [11:24:57] (03Merged) 10jenkins-bot: Segregate right to edit sitewide CSS/JS [core] (wmf/1.32.0-wmf.13) - 10https://gerrit.wikimedia.org/r/449153 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [11:25:06] hmmm [11:25:43] I tried reading a bunch of stuff about DI, but I didn't understand this point. [11:25:50] (I didn't read the Google Testing Blog yet, though) [11:25:55] (03CR) 10Mglaser: [C: 031] "good for me, waiting for i18n review" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 (owner: 10ItSpiderman) [11:26:17] re: your patch, I think it's fine. I was going to suggest adding a Parser->getMagicWordFactory() for parser functions but I looked another patch ahead and see that you already did that [11:26:56] Yes. [11:27:21] (03CR) 10Zfilipin: [C: 031] Fix jQuery selector when editing filters [extensions/AbuseFilter] (wmf/1.32.0-wmf.14) - 10https://gerrit.wikimedia.org/r/448856 (https://phabricator.wikimedia.org/T200604) (owner: 10Daimona Eaytoy) [11:27:25] tgr: Do we not have any interface messages that get output as raw HTML anymore? If there's even one out there somewhere, there's still a hole. [11:27:29] (03PS1) 10ItSpiderman: Change getImmediateEmail -> sendImmediateEmail + delete unused class [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449158 [11:27:49] one hole at a time [11:28:07] tgr: Just checking that that's on the agenda. :) [11:29:28] (03CR) 10jerkins-bot: [V: 04-1] Add notification base class [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/445578 (owner: 10ItSpiderman) [11:29:42] legoktm: I think I understand now what I should do, I just don't understand what the point is of doing it. :) [11:29:54] (other than to make our code look more professional and up-to-date) [11:29:59] (nothing wrong with that) [11:30:12] (:P) [11:30:15] heh [11:30:29] I'm trying to come up with a reason/use case for turning parser into a service [11:30:45] (03CR) 10jerkins-bot: [V: 04-1] Article preview: Added revision id as a param ERM:10236 [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/449156 (owner: 10Pwirth) [11:30:54] MagicWordFactory and the other ones that already exist are much easier to justify if that would help you [11:31:30] I could where you might want magic words with different languages, say, but you could always make a language-setting switch. [11:31:38] (03CR) 10Mglaser: [C: 032] Change getImmediateEmail -> sendImmediateEmail + delete unused class [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449158 (owner: 10ItSpiderman) [11:31:42] It seems simpler than making a whole separate service. [11:31:43] (03Merged) 10jenkins-bot: Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449093 (owner: 10Legoktm) [11:31:44] (03Merged) 10jenkins-bot: Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/449094 (owner: 10Legoktm) [11:32:07] (03Merged) 10jenkins-bot: Change getImmediateEmail -> sendImmediateEmail + delete unused class [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/449158 (owner: 10ItSpiderman) [11:32:11] legoktm: So yeah, if you could explain for MagicWordFactory that would help. [11:32:25] 10ContentTranslation, 10Language-2018-July-September: CX2: Adjust when to show warnings for a paragraph - https://phabricator.wikimedia.org/T200683 (10Pginer-WMF) [11:32:38] 10ContentTranslation, 10Language-2018-July-September: CX2: Adjust when to show warnings for a paragraph - https://phabricator.wikimedia.org/T200683 (10Pginer-WMF) p:05Triage>03Normal [11:32:40] Although it should be an explanation for why it shouldn't be a global, not why it shouldn't be static methods. [11:32:55] It's not hard to come up with reasons why something should be stateful or possible to have multiple instances of. [11:33:01] oh [11:33:20] you just want an explanation of why it shouldn't be a global? that's easy! [11:33:32] Okay, why? [11:34:22] .oO(it would be so useful if we could locally parse wikitext of another wiki) [11:35:17] So I can see why you wouldn't want Parser to *depend* on globals, because then you can't easily parse things in a different language/different config/whatever. [11:35:25] I think the main problem with globals is that they're direct, public access. It's impossible to monitor changes to them (to update other dependent state for example). You can't really sanity check them either (e.g. type hints), the callers can do whatever they want [11:35:29] AryehGregor: yeah, T2212 is the task for the generic issue, T45646 is the one where discussion has been happening recently [11:35:30] T2212: Some MediaWiki: messages not safe in HTML (tracking) - https://phabricator.wikimedia.org/T2212 [11:35:30] T45646: "MediaWiki:Copyright" message allows raw HTML - https://phabricator.wikimedia.org/T45646 [11:36:06] (03CR) 10jenkins-bot: Fix MediaWiki.Usage.InArrayUsage.Found issue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/449093 (owner: 10Legoktm) [11:36:21] legoktm: So like more specifically, what would be a problem? [11:36:48] AryehGregor: also, access to globals is basically an undeclared dependency. One advantage of DI is that ir forces all dependencies to be declared in the constructor or setters. Globals bypass that. [11:36:50] $wgContLang, for instance, I can definitely see that as a bad thing, because it's not good to hard-code the fact that a function is working with the language of the current wiki. [11:37:13] that makes testing nasty, and is a source of errors when managing multiple instances with different config [11:37:16] DanielK_WMDE: That's a nice point. I only realized when working on this that User::isValidUserName() depends on $wgContLang. I'm not sure that's a good idea. :) [11:37:43] No dependency on any global is ever a good idea in my mind [11:37:44] 10Documentation: Documentation sprint @Hackathon 2018 - https://phabricator.wikimedia.org/T187319 (10Nikerabbit) [11:38:46] ftr, I see no problem with static methods. only with global state. [11:38:48] DanielK_WMDE: Sometimes it makes no difference, e.g., a singleton object that has no meaningful state but is cached to avoid setup overhead. [11:39:09] the classic argument is uncoupling: any two classes using the same global are coupled to each other [11:39:10] singletons lie. there are no true singletons. [11:39:23] you cannot make them use different implementations, for example [11:39:40] Global default instances are ok as a stepping stone towards DI, but should be avoided when possible. [11:40:27] tgr: Yes, I can certainly see all this for e.g. ContLang, I'm just not sure for Parser specifically. But I guess it doesn't matter so much. [11:41:06] DanielK_WMDE: An example of a true singleton is an object whose member variables are immutable once initialized, and it has no variability in their initialization. I.e., it just needs to compute something fixed during initialization. I grant that's not likely to be common. [11:41:20] 10ContentTranslation, 10Language-2018-July-September, 10MW-1.32-release-notes (WMF-deploy-2018-07-31 (1.32.0-wmf.15)): CX2: Too much unmodified content warning - https://phabricator.wikimedia.org/T190279 (10Pginer-WMF) >>! In T190279#4459122, @Petar.petkovic wrote: >>>! In T190279#4458266, @Etonkovidova wrot... [11:41:28] if they change state (which all globals do, at least in the setup phase) the code using the global needs to now what stage the code changing the global is at, which can be suprisingly hard in hooks [11:41:47] tgr: That's not an issue for services? [11:42:05] it's not an issue for dependency injection [11:42:07] Because the hook will just force everything to initialize when it wants it? [11:42:39] you can use services in other ways, e.g. with a service registry, and then it is definitely an issue [11:42:56] I'm not sure it would be that simple in practice, because sometimes the reason something isn't initialized is because we can't initialize it yet, which in DI terms means that we're in the middle of initializing something that the thing we want depends on. [11:43:14] of course right now hooks punt on dependency injection entirely [11:43:36] With pure DI, hooks that run too early could still create circular dependencies. [11:43:50] If a hook runs in the constructor of A and requests B, but B depends on A, it's not going to work. [11:44:18] The early setup phases are exactly when we're setting up the stuff that everything else depends on, so I don't think DI would make the problem go away. [11:44:35] with pure DI there would be a hook runner which gets the dependencies injected into it, and that would be injected into classes which now call Hooks::run [11:44:53] Oh, I see. [11:45:14] So the hook itself wouldn't be able to even try to run until the things it wanted were available. [11:45:18] Now I think I get the picture. [11:45:46] the core idea behind DI / inversion of control is that managing dependencies should be the responsibility of a dedicated class (the DI container, usually) instead of being scattered around the codebase [11:45:58] It's like using systemd instead of old-school init. [11:46:09] Yes, now I think it all makes sense. [11:47:18] 10MediaWiki-Codesniffer, 10Patch-For-Review: add or create sniff to detect unreachable code after break in switch - https://phabricator.wikimedia.org/T168465 (10matej_suchanek) a:03matej_suchanek [11:47:20] 10ContentTranslation, 10Language-2018-July-September, 10Patch-For-Review: CX2: Show issue cards when they are relevant - https://phabricator.wikimedia.org/T198187 (10Pginer-WMF) As part of the investigation for T200683, I found out that the "too much unmodified content" warning (T190279) was not showing the... [11:48:23] legoktm: Do you have any ideas about https://gerrit.wikimedia.org/r/447821 ? [11:49:12] (03CR) 10Zfilipin: [C: 032] "SWAT" [extensions/AbuseFilter] (wmf/1.32.0-wmf.14) - 10https://gerrit.wikimedia.org/r/448856 (https://phabricator.wikimedia.org/T200604) (owner: 10Daimona Eaytoy) [11:49:26]