[01:11:15] (03CR) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. (0312 comments) [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [01:11:16] (03PS13) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [01:22:37] (03PS14) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [01:28:21] (03CR) 10tosfos: [C: 031] "Very awesome." [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 (owner: 10Cicalese) [01:32:09] (03CR) 10jerkins-bot: [V: 04-1] List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [01:36:40] (03PS15) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [01:37:46] (03CR) 10Dbarratt: [C: 04-1] "I need to add a test to BlockTest so the code coverage doesn't decrease. :)" [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [01:37:48] (03CR) 10Dbarratt: [C: 04-1] "Giving myself a -1 until I add the test. :)" [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [02:06:12] (03CR) 10Samwilson: [C: 04-1] "Looks good, works in my testing. Just a few comments, mostly stylistic." (037 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) (owner: 10MusikAnimal) [02:25:53] 10InternetArchiveBot: PDF URL not recognized as dead - https://phabricator.wikimedia.org/T198827 (10JFG) [02:49:23] 10MediaWiki-extensions-ExternalData, 10WikiApiary: Undefined variable: mappings in extensions/ExternalData/ED_ParserFunctions.php on line 535 - https://phabricator.wikimedia.org/T197261 (10Yaron_Koren) @Samwilson - I still think it might be just a matter of them needing to upgrade External Data to the latest c... [02:51:44] 10MediaWiki-Recent-changes, 10Edit-Review-Improvements-RC-Page, 10Growth-Team, 10Collaboration-Team-Triage (Collab-Team-This-Quarter), and 2 others: Retire $wgStructuredChangeFiltersShowPreference - https://phabricator.wikimedia.org/T195029 (10JTannerWMF) [02:52:05] 10MediaWiki-extensions-PageCuration, 10Growth-Team, 10Availability, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): PageTriage opens master connection on GET for ArticleMetadata cache misses - https://phabricator.wikimedia.org/T154719 (10JTannerWMF) [02:52:30] 10Accessibility, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Show last 250 changes and period selection dropdowns are not keyboard accessible - https://phabricator.wikimedia.org/T174819 (10JTannerWMF) [02:52:55] 10Accessibility, 10Edit-Review-Improvements-Integrated-Filters, 10Growth-Team, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Buttons in FilterMenuHeaderWidget like “Highlight results“ are not keyboard accessible - https://phabricator.wikimedia.org/T191860 (10JTannerWMF) [03:27:39] 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Readers-Web-Kanbanana-Board: Truncate page issues - https://phabricator.wikimedia.org/T197931 (10Niedzielski) a:05Niedzielski>03Jdrewniak Oops, didn't realize you had something cooking on this! Assigning to you! [03:33:05] 10MediaWiki-extensions-PageCuration, 10Beta-Cluster-Infrastructure, 10Growth-Team, 10Collaboration-Team-Triage (Collab-Team-Next-Quarter): [betalabs]: Page triage: "Uncaught TypeError: Cannot read property 'getLogPageTitle' of undefined" for 'Redirects for discussi... - https://phabricator.wikimedia.org/T196954 [03:49:27] (03CR) 10Samwilson: [C: 032] Add an API module to set global preferences [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/442219 (https://phabricator.wikimedia.org/T62856) (owner: 10MaxSem) [04:45:41] (03PS16) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [04:50:07] (03CR) 10Fomafix: [C: 04-1] Accept BCP 47 codes as aliases for nonstandard variants (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443687 (owner: 10C. Scott Ananian) [04:50:28] (03CR) 10Fomafix: Ensure LanguageCode::bcp47() returns a valid BCP 47 language code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442200 (https://phabricator.wikimedia.org/T34483) (owner: 10C. Scott Ananian) [05:04:35] (03PS17) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [05:15:52] (03CR) 10jerkins-bot: [V: 04-1] List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [05:20:55] (03CR) 10Fomafix: [C: 04-1] registration: Use the correct key for skin dependencies (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) (owner: 10Florianschmidtwelzow) [05:42:37] 10MediaWiki-Database, 10Blocked-on-schema-change, 10Patch-For-Review: Add a primary key to l10n_cache - https://phabricator.wikimedia.org/T146591 (10Marostegui) [05:58:08] (03CR) 10Samwilson: "> Patch Set 3: Code-Review-1" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442777 (https://phabricator.wikimedia.org/T196181) (owner: 10Samwilson) [06:00:35] 10MediaWiki-extension-requests: Allow hiding certain (NSFW etc) images by default and letting users explicitly expand them - https://phabricator.wikimedia.org/T198550 (10Batreeq) I reviewed the documents, however, they were long and somewhat confusing. In a few sentences, can someone explain why this idea was di... [06:02:27] (03PS3) 10ItSpiderman: Filtering ES over SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 [06:08:11] (03CR) 10ItSpiderman: [C: 032] Upgraded to BS3 ... [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443800 (owner: 10Pwirth) [06:08:44] (03Merged) 10jenkins-bot: Upgraded to BS3 ... [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443800 (owner: 10Pwirth) [06:11:26] (03PS1) 10KartikMistry: Update version before MLEB release [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443892 [06:17:33] (03PS1) 10KartikMistry: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/443895 (https://phabricator.wikimedia.org/T196220) [06:44:00] (03CR) 10Mglaser: [C: 032] Filtering ES over SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [06:44:30] (03Merged) 10jenkins-bot: Filtering ES over SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [06:58:01] 10ContentTranslation, 10Language-2018-Apr-June: CX2: Progress calculation - https://phabricator.wikimedia.org/T162113 (10Nikerabbit) I have been reading the ve code trying to understand where we could hook. I can imagine two possible approaches. == Diffing We store the original text [1][2] in an attribute o... [07:30:45] (03CR) 10Nikerabbit: [C: 032] "Using the planned release date." [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443892 (owner: 10KartikMistry) [07:39:52] (03PS1) 10Cicalese: Fixed issue adding breadcrumbs to trail. [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 [07:40:35] (03PS4) 10Fomafix: Add new factory Language::newFromValidCode [core] - 10https://gerrit.wikimedia.org/r/441528 [07:40:55] (03CR) 10Cicalese: "Hopefully this will fix the issue you have been seeing." [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 (owner: 10Cicalese) [07:41:22] (03PS2) 10Gergő Tisza: shell.php: prevent permission error [core] - 10https://gerrit.wikimedia.org/r/441597 [07:42:37] (03Merged) 10jenkins-bot: Update version before MLEB release [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443892 (owner: 10KartikMistry) [07:48:10] (03CR) 10Samwilson: [C: 032] Add quickfixes for RTL alignment [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) (owner: 10Mooeypoo) [07:54:42] (03Merged) 10jenkins-bot: Add quickfixes for RTL alignment [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) (owner: 10Mooeypoo) [08:04:19] 10CX-cxserver: Apertium translation fails with sections with references - https://phabricator.wikimedia.org/T198830 (10KartikMistry) May be happens after deployment of 5ed7dc1b9f33dd27f1a4a411d230226c4c7c0b07 (code points there) but I can't produce it in Local with given example. [08:11:05] (03CR) 10Nikerabbit: [C: 032] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/443895 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [08:12:08] (03PS1) 10Nasty: Fix file repo cache. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443910 [08:17:21] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Show edit buttons for changed paragraphs - js version (No. 7) - https://phabricator.wikimedia.org/T195721 (10Lea_WMDE) [08:18:27] (03CR) 10Mglaser: [C: 032] Fix file repo cache. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443910 (owner: 10Nasty) [08:18:52] (03Merged) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/LocalisationUpdate] - 10https://gerrit.wikimedia.org/r/443895 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [08:21:21] (03PS4) 10DCausse: [WIP] Move SearchEngine::prefix support in searchText [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/442288 (https://phabricator.wikimedia.org/T198318) [08:22:09] (03PS3) 10DCausse: [WIP] Deprecate usage of SearchEngine:transformSearchTerm [core] - 10https://gerrit.wikimedia.org/r/442289 (https://phabricator.wikimedia.org/T198318) [08:24:25] (03Merged) 10jenkins-bot: Fix file repo cache. [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443910 (owner: 10Nasty) [08:35:12] (03PS1) 10ItSpiderman: Fix for actions column width in flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443914 [08:36:21] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/442288 (https://phabricator.wikimedia.org/T198318) (owner: 10DCausse) [08:37:34] (03CR) 10Hashar: "check experimental" [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/430660 (owner: 10Hashar) [08:38:57] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Deprecate usage of SearchEngine:transformSearchTerm [core] - 10https://gerrit.wikimedia.org/r/442289 (https://phabricator.wikimedia.org/T198318) (owner: 10DCausse) [08:39:34] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Tooltip for unselected paragraphs (No. 7) - https://phabricator.wikimedia.org/T195722 (10WMDE-Fisch) [08:40:06] (03PS3) 10Fomafix: [WIP] Add type hint Language where possible [core] - 10https://gerrit.wikimedia.org/r/443288 [08:41:06] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Show edit buttons for changed paragraphs - js version (No. 7) - https://phabricator.wikimedia.org/T195721 (10WMDE-Fisch) [08:41:12] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Make unchanged text editable (No. 4) - https://phabricator.wikimedia.org/T195714 (10Lea_WMDE) p:05Triage>03Normal [08:43:12] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/430660 (owner: 10Hashar) [08:53:36] (03PS1) 10Hashar: In composer.json require ldap PHP extension [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/443917 [08:55:02] (03CR) 10Hashar: "check experimental" [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/443917 (owner: 10Hashar) [08:55:19] 10MediaWiki-extensions-Other: [InviteSignup] users not authorised to conclude the procedure to accept an invitation - https://phabricator.wikimedia.org/T198786 (10Peachey88) [08:58:43] (03CR) 10Mglaser: [C: 032] Fix for actions column width in flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443914 (owner: 10ItSpiderman) [09:00:08] (03Abandoned) 10Hashar: In composer.json require ldap PHP extension [extensions/LdapAuthentication] - 10https://gerrit.wikimedia.org/r/443917 (owner: 10Hashar) [09:00:43] (03Merged) 10jenkins-bot: Fix for actions column width in flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443914 (owner: 10ItSpiderman) [09:00:57] (03PS1) 10Ppchelko: Don't specify the comment if it is an empty string. [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 [09:04:01] (03PS1) 10ItSpiderman: Fix for non-existing titles when indexing SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443921 [09:05:43] (03CR) 10Ppchelko: Send the Accept-Language header when calling API (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [09:14:15] (03CR) 10Mglaser: [C: 032] Fix for non-existing titles when indexing SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443921 (owner: 10ItSpiderman) [09:14:46] (03Merged) 10jenkins-bot: Fix for non-existing titles when indexing SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443921 (owner: 10ItSpiderman) [09:22:23] (03PS8) 10Fomafix: [WIP] Introduce LanguageSet [core] - 10https://gerrit.wikimedia.org/r/442337 [09:23:15] 10WMSE-Organisational-Development-2018 (GSuite migration): Set up default email signature - https://phabricator.wikimedia.org/T198835 (10Lokal_Profil) [09:23:53] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/442337 (owner: 10Fomafix) [09:24:17] 10Community-Relations-Support: Post feedback to all suggestions on CEP Process Ideas page - https://phabricator.wikimedia.org/T97187 (10Qgil) 05Open>03declined I am declining this task. It doesn't make much sense at this point. [09:24:20] (03CR) 10Mobrovac: [V: 032 C: 032] "@PPchelko, should we SWAT this?" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 (owner: 10Ppchelko) [09:25:25] (03CR) 10Ppchelko: "hm... Ye, I think we should. I will put it on EU mid-day SWAT" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 (owner: 10Ppchelko) [09:25:38] (03CR) 10jenkins-bot: Don't specify the comment if it is an empty string. [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 (owner: 10Ppchelko) [09:34:21] 10MediaWiki-extensions-Disambiguator, 10Community-Relations-Support: Help communities to learn about and use Disambiguator extension - https://phabricator.wikimedia.org/T146484 (10Qgil) [09:34:37] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: [Bug] Precision of a quantity value changed when only editing the unit - https://phabricator.wikimedia.org/T136528 (10Jonas) Is this still a problem? For me it seems to be solved, so I would like to close this ticket. [09:34:51] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite, 10Technical-Debt: [Bug] Special:NewItem does not validate maximum label length - https://phabricator.wikimedia.org/T145932 (10Jonas) a:05hoo>03None [09:35:52] 10Community-Relations, 10Technical-Collaboration-Guidance, 10Documentation: Update the Product Documentation help pages - https://phabricator.wikimedia.org/T155663 (10Qgil) [09:35:59] 10Phabricator, 10Security: Trusted contributors cannot escalate tasks as security issues - https://phabricator.wikimedia.org/T198831 (10MarcoAurelio) Not sure if D1075 could fix this though. [09:36:50] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [Bug] False positive error in detecting same label-description in Wikidata - https://phabricator.wikimedia.org/T194770 (10Greta_Doci_WMDE) [09:37:29] 10Toolhub, 10Community-Relations-Support (Apr-Jun-2018): Community Liaison support for Cloud services Tool Catalogue project - https://phabricator.wikimedia.org/T184472 (10Qgil) The description says > Mainly a time-tracking task. Helping as needed with {T183106} However, that milestone is completed. Is ther... [09:38:06] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: [Bug] Precision of a quantity value changed when only editing the unit - https://phabricator.wikimedia.org/T136528 (10RazShuty) @Greta_Doci_WMDE , I think you were reproducing this, can you give Jonas a scenario to reproduce this bug? [09:43:53] (03CR) 10Ppchelko: "@mobrovac Unfortunately, I think we can't SWAT it. It depends on the previous one, I58efb0215046505f167de74a8fae8a69fd9fabdd that was a pr" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 (owner: 10Ppchelko) [09:47:52] (03CR) 10Mobrovac: [V: 032 C: 032] "> @mobrovac Unfortunately, I think we can't SWAT it. It depends on" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/443920 (owner: 10Ppchelko) [09:52:04] (03PS4) 10Fomafix: Simplify PHP by using ?? and ?: [core] - 10https://gerrit.wikimedia.org/r/442299 [09:53:53] (03CR) 10Fomafix: "Rebased to trigger Jenkins again." [core] - 10https://gerrit.wikimedia.org/r/442299 (owner: 10Fomafix) [09:54:33] (03CR) 10Phuedx: Send the Accept-Language header when calling API (031 comment) [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [09:57:00] (03PS1) 10Ppchelko: Don't specify the comment if it is an empty string. [extensions/EventBus] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443932 [09:58:37] (03CR) 10jerkins-bot: [V: 04-1] Simplify PHP by using ?? and ?: [core] - 10https://gerrit.wikimedia.org/r/442299 (owner: 10Fomafix) [10:04:24] 10Research, 10Community-Relations-Support (Jul-Sep 2018): Support getting community involved section translation - https://phabricator.wikimedia.org/T195001 (10diego) @Trizek-WMF , thanks for your efforts. Can we push more for translators from/to Japanese? This is the main missing piece. [10:15:42] 10Phabricator, 10Security: Trusted contributors cannot escalate tasks as security issues - https://phabricator.wikimedia.org/T198831 (10MarcoAurelio) [10:16:53] (03CR) 10Aaron Schulz: Use consistent caching strategy in Revision storage classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [10:23:15] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Third-Party-Support: Special:MobileOptions is empty for third parties - https://phabricator.wikimedia.org/T198265 (10ovasileva) [10:24:51] 10Wikidata-Campsite, 10Epic: Blubber: Web From: Generate a Wikibase Docker Compose file - https://phabricator.wikimedia.org/T198840 (10RazShuty) [10:28:41] 10Wikidata-Campsite, 10Epic: Blubber: Web From: Choose specific elements from the UI a user wants to have in his/hers docker compose file - Step 1 - https://phabricator.wikimedia.org/T198841 (10RazShuty) [10:34:25] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10Blocked-on-schema-change, 10Patch-For-Review: Schema change for ct_tag_id field to change_tag - https://phabricator.wikimedia.org/T195193 (10Ladsgroup) Thank you! [10:35:06] 10Wikidata-Campsite, 10Epic: Blubber: Web From: Choose specific elements from the UI a user wants to have in his/hers docker compose file - Step 2 - https://phabricator.wikimedia.org/T198842 (10RazShuty) [10:38:59] (03PS1) 10Aaron Schulz: Avoid use of deprecated getWikiID() method [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/443940 [10:42:24] 10ContentTranslation, 10Language-2018-Apr-June, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): CX2: Changing the MT options cause sudden page scroll - https://phabricator.wikimedia.org/T198284 (10santhosh) [10:42:26] 10ContentTranslation, 10Language-2018-July-September: CX2: Avoid jumps in the document position when machine translation is applied - https://phabricator.wikimedia.org/T198184 (10santhosh) [10:45:17] (03PS2) 10Aaron Schulz: rdbms: add IDatabase::lockForUpdate() convenience method [core] - 10https://gerrit.wikimedia.org/r/443477 [10:46:25] (03PS2) 10Aaron Schulz: Remove outdated transition code [core] - 10https://gerrit.wikimedia.org/r/443867 (owner: 10Awight) [10:46:31] (03CR) 10Aaron Schulz: [C: 032] Remove outdated transition code [core] - 10https://gerrit.wikimedia.org/r/443867 (owner: 10Awight) [10:50:09] (03CR) 10Aaron Schulz: [C: 032] Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [10:50:14] (03PS1) 10Physikerwelt: Add math related styles and script via appropriate hook [extensions/Math] - 10https://gerrit.wikimedia.org/r/443941 (https://phabricator.wikimedia.org/T173949) [10:57:07] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add IDatabase::lockForUpdate() convenience method [core] - 10https://gerrit.wikimedia.org/r/443477 (owner: 10Aaron Schulz) [10:58:15] (03PS1) 10Pboehm: Fix for template tags with pipes in wikilinks in VE ERM9372 [extensions/BlueSpiceExtensions] (REL1_27) - 10https://gerrit.wikimedia.org/r/443942 [11:05:11] (03Merged) 10jenkins-bot: Remove outdated transition code [core] - 10https://gerrit.wikimedia.org/r/443867 (owner: 10Awight) [11:05:16] (03Merged) 10jenkins-bot: Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [11:06:48] (03CR) 10jenkins-bot: Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [11:07:48] 10Technical-Collaboration-Guidance, 10Community-Relations-Support (Apr-Jun-2018): Cleanup Technical Collaboration Guidance text - https://phabricator.wikimedia.org/T176275 (10Qgil) [11:07:50] 10Technical-Collaboration-Guidance, 10Community-Relations-Support (Apr-Jun-2018), 10Goal: First review of the Technical Collaboration Guidance by Foundation Product teams and most active technical volunteers - https://phabricator.wikimedia.org/T144625 (10Qgil) [11:08:26] 10Technical-Collaboration-Guidance, 10Community-Relations-Support (Apr-Jun-2018): Technical Collaboration Guidance design - https://phabricator.wikimedia.org/T176276 (10Qgil) 05Open>03declined [11:08:28] 10Technical-Collaboration-Guidance, 10Community-Relations-Support (Apr-Jun-2018), 10Goal: Improve and finalize TCG based on P&T and community feedback - https://phabricator.wikimedia.org/T176274 (10Qgil) [11:18:52] 10MediaWiki-Core-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run selenium-EXTENSION-jessie for all repositores with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [11:19:27] 10Community-Relations: Are messages from the WMF negatively affecting small Village Pumps? - https://phabricator.wikimedia.org/T130602 (10Qgil) [11:20:11] 10Community-Relations: Recommendations to publish Product updates - https://phabricator.wikimedia.org/T137088 (10Qgil) a:05Keegan>03None [11:20:13] 10Readers-Community-Engagement, 10Specialists-Support (Jul-Sep-2018): Support Readers department with in-person user testing during Wikimania - https://phabricator.wikimedia.org/T198767 (10Elitre) [11:25:51] 10Page-Previews, 10Readers-Web-Backlog (Tracking), 10Specialists-Support (Jul-Sep-2018): Conduct conversations with communities on page previews configuration changes - https://phabricator.wikimedia.org/T197939 (10Elitre) [11:26:00] 10MediaWiki-Core-Tests, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Run selenium-EXTENSION-jessie for all repositores with Selenium tests - https://phabricator.wikimedia.org/T188742 (10zeljkofilipin) [11:26:26] 10Specialists-Support (Jul-Sep-2018): Community liaison support for Growth team - https://phabricator.wikimedia.org/T197826 (10Elitre) [11:46:14] 10Specialists-Support (Jul-Sep-2018): CL support for AfC improvements - https://phabricator.wikimedia.org/T193431 (10Elitre) [11:47:57] 10Team-Internals: Bootstrap Community Relations - https://phabricator.wikimedia.org/T198848 (10Qgil) [11:48:16] 10Team-Internals: Bootstrap Community Relations - https://phabricator.wikimedia.org/T198848 (10Qgil) p:05Triage>03High [11:48:18] (03PS5) 10Fomafix: Simplify PHP by using ?? and ?: [core] - 10https://gerrit.wikimedia.org/r/442299 [11:48:26] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Tracking: new monolingual language code requests for Wikidata (tracking) - https://phabricator.wikimedia.org/T144272 (10Amire80) >>! In T144272#4399315, @Nikki wrote: >>>! In T144272#4399198, @Amire80 wrote: >> The criteria for adding a language to thi... [11:48:53] 10Developer-Advocacy (Jul-Sep 2018): Rename / update / redirect "Developer Relations" wiki pages to "Developer Advocacy" - https://phabricator.wikimedia.org/T198596 (10Qgil) Thank you! TODO copied to {T198848}. [12:05:15] (03PS1) 10Aaron Schulz: [WIP] Move l10n_cache table to a separate DB for sqlite via the installer [core] - 10https://gerrit.wikimedia.org/r/443951 (https://phabricator.wikimedia.org/T93097) [12:12:41] (03PS1) 10Pboehm: two more Hooks for ERM9862 - refactoring of extensions [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443954 [12:14:38] 10Readers-Community-Engagement, 10Specialists-Support (Jul-Sep-2018): Community Liaison support for page issues on mobile - https://phabricator.wikimedia.org/T186058 (10Elitre) [12:16:10] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Move l10n_cache table to a separate DB for sqlite via the installer [core] - 10https://gerrit.wikimedia.org/r/443951 (https://phabricator.wikimedia.org/T93097) (owner: 10Aaron Schulz) [12:18:06] 10Phabricator, 10Diffusion: Turn off 'blame' by default on Diffusion - https://phabricator.wikimedia.org/T198838 (10Aklapper) According to https://secure.phabricator.com/rPafc3099ee785c0f9cb86c702fc1d04d2be9f6af5 there is a "Hide Blame" option in the "View Options" dropdown so it can be toggled off? [12:21:29] (03CR) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [12:21:34] AaronSchulz: --^ [12:23:11] (03PS1) 10Dvogel hallowelt: Flyout: modify grid size to fit flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443955 [12:25:04] DanielK_WMDE: why would you inject the DBConnRef if you already have an LB that has a method to get a lazy ref? [12:28:15] AaronSchulz: because to get the lazy I need to know a wikiId! And that's the only reason to have the wikiId there. It would eb *so* much nicer to just have a factory that already knows all the parameters (domain, group, etc) [12:30:24] I wasn't sure if you were just wanting to avoid the ternary of wikiId ?: >getDomainID() [12:30:37] AaronSchulz: I guess it's ok to construct a DBConnRef from the LoadBalancer, using $this-wikiId, just to ask it for the domain ID. It just seems awkward and wasteful. [12:30:51] I also want to avoid that ternary, yes [12:31:14] But ideally, I also want to avoid havign to inject the wikiId in the first place [12:31:31] (03PS1) 10ItSpiderman: Add formatted date to RecentChanges API store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443956 [12:32:38] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Have an option to clear the browsing history when you turn off the app - https://phabricator.wikimedia.org/T198836 (10Feldo) [12:32:55] (03CR) 10Mglaser: [C: 032] Add formatted date to RecentChanges API store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443956 (owner: 10ItSpiderman) [12:33:15] DanielK_WMDE: maybe LB::resolveDomainID( $domain = false ) would be a bit less roundabout [12:33:17] (03CR) 10Mglaser: [C: 032] Flyout: modify grid size to fit flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443955 (owner: 10Dvogel hallowelt) [12:34:07] AaronSchulz: yes [12:35:21] it would be useful to see some mock pattern of what you want (e.g. just having an LB somehow and no $wikiId param to BlobStore or what not) [12:35:43] not an LB. Just a ConnectionFactory. [12:36:18] It should generally be unnecessary to inject an LB. [12:36:24] I can make a mock. [12:36:52] AaronSchulz: btw, resolveDomainID would also fix the mess that is checkDatabaseWikiId()... maybe? [12:37:18] we poekd at this when I was in SF a while ago. [12:37:56] resolveDomainId would need to *guarantee* that it returns a string. [12:40:20] (03Merged) 10jenkins-bot: Add formatted date to RecentChanges API store [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443956 (owner: 10ItSpiderman) [12:40:24] (03Merged) 10jenkins-bot: Flyout: modify grid size to fit flyout [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443955 (owner: 10Dvogel hallowelt) [12:42:10] 10Specialists-Support (Jul-Sep-2018): CL support for Collab Team Maps engagement - https://phabricator.wikimedia.org/T186651 (10Elitre) [12:42:26] 10Phabricator, 10WMSE-Bug-Reporting-and-Translation-2018: "Create Task" in favorites menu should be called "Create Task (Simple)" - https://phabricator.wikimedia.org/T198837 (10Lokal_Profil) >>! In T198837#4399050, @Aklapper wrote: > Thanks. Done. Wow that was quick!. Thanks [12:46:41] (03PS1) 10Awight: Remove dubious self-conflict clause [core] - 10https://gerrit.wikimedia.org/r/443958 [12:46:43] (03PS1) 10Awight: Remove deprecated userWasLastToEdit method [core] - 10https://gerrit.wikimedia.org/r/443959 [12:46:45] (03PS1) 10Awight: Cleanup [core] - 10https://gerrit.wikimedia.org/r/443960 [12:46:47] (03PS1) 10Awight: Remove redundant assignments [core] - 10https://gerrit.wikimedia.org/r/443961 [12:46:49] (03PS1) 10Awight: Give a bit of love to EditPage docstrings [core] - 10https://gerrit.wikimedia.org/r/443962 [12:46:51] (03PS1) 10Awight: Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) [12:46:53] (03PS1) 10Awight: Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 [12:48:38] 10Community-Relations-Support: Announce CodeMirror graduation from beta in LTR wikis - https://phabricator.wikimedia.org/T191045 (10Elitre) [12:56:43] (03PS1) 10Aaron Schulz: rdbms: add resolveDomainID() method to LBFactory/LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/443965 [13:02:51] (03CR) 10Daniel Kinzler: [C: 04-1] rdbms: add resolveDomainID() method to LBFactory/LoadBalancer (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443965 (owner: 10Aaron Schulz) [13:03:11] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated userWasLastToEdit method [core] - 10https://gerrit.wikimedia.org/r/443959 (owner: 10Awight) [13:03:32] (03CR) 10jerkins-bot: [V: 04-1] Cleanup [core] - 10https://gerrit.wikimedia.org/r/443960 (owner: 10Awight) [13:04:03] (03PS9) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [13:06:28] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant assignments [core] - 10https://gerrit.wikimedia.org/r/443961 (owner: 10Awight) [13:07:12] (03PS2) 10Aaron Schulz: rdbms: add resolveDomainID() method to LBFactory/LoadBalancer [core] - 10https://gerrit.wikimedia.org/r/443965 [13:07:56] (03CR) 10jerkins-bot: [V: 04-1] Give a bit of love to EditPage docstrings [core] - 10https://gerrit.wikimedia.org/r/443962 (owner: 10Awight) [13:08:47] (03PS1) 10Kosta Harlan: WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) [13:09:21] (03PS2) 10Awight: Remove deprecated userWasLastToEdit method [core] - 10https://gerrit.wikimedia.org/r/443959 [13:10:23] (03CR) 10jerkins-bot: [V: 04-1] WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) (owner: 10Kosta Harlan) [13:10:51] (03CR) 10jerkins-bot: [V: 04-1] Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight) [13:11:47] (03CR) 10jerkins-bot: [V: 04-1] WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) (owner: 10Kosta Harlan) [13:12:35] (03CR) 10jerkins-bot: [V: 04-1] Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 (owner: 10Awight) [13:14:30] 10International-Developer-Events, 10Wikimania-Hackathon-2018, 10Wikimania-Hackathon-2018-Organization: Wikimania 2018 Hackathon Opening Session - https://phabricator.wikimedia.org/T196491 (10Qgil) [13:16:43] 10Community-Relations-Support, 10Discovery: Discuss improvements to non-content searches - https://phabricator.wikimedia.org/T142635 (10Elitre) This isn't really a request for support at this point. Please evaluate closing! [13:16:56] 10Community-Relations, 10Discovery: Discuss improvements to non-content searches - https://phabricator.wikimedia.org/T142635 (10Elitre) [13:18:41] 10MediaWiki-extensions-NewUserActions, 10Collaboration-Community-Engagement, 10Community-Relations: Identify how communities welcome new users to define NewUserActions features - https://phabricator.wikimedia.org/T130356 (10Elitre) This doesn't look like a request for support and lots of things have changed... [13:18:59] (03PS10) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [13:19:21] (03PS11) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [13:26:35] (03PS2) 10Kosta Harlan: WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) [13:28:27] (03CR) 10jerkins-bot: [V: 04-1] Cleanup [core] - 10https://gerrit.wikimedia.org/r/443960 (owner: 10Awight) [13:29:36] (03PS1) 10Daniel Kinzler: DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 [13:29:42] (03PS1) 10ItSpiderman: Add conditions to showing Flyout button [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443969 [13:29:54] (03CR) 10jerkins-bot: [V: 04-1] WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) (owner: 10Kosta Harlan) [13:32:26] (03CR) 10Aklapper: [C: 04-1] "I'm adding a CR-1 as per last comment by Thiemo." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [13:33:41] (03CR) 10jerkins-bot: [V: 04-1] DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 (owner: 10Daniel Kinzler) [13:38:29] (03CR) 10Zfilipin: [C: 032] "SWAT" [extensions/EventBus] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443932 (owner: 10Ppchelko) [13:40:24] (03CR) 10Mglaser: [C: 032] Add conditions to showing Flyout button [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443969 (owner: 10ItSpiderman) [13:41:14] (03Merged) 10jenkins-bot: Add conditions to showing Flyout button [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443969 (owner: 10ItSpiderman) [13:41:50] (03PS1) 10WMDE-leszek: DNM Added psr/simple-cache 1.0.1 [vendor] - 10https://gerrit.wikimedia.org/r/443972 (https://phabricator.wikimedia.org/T198857) [13:43:24] (03CR) 10WMDE-leszek: [C: 04-2] "Needs security review" [vendor] - 10https://gerrit.wikimedia.org/r/443972 (https://phabricator.wikimedia.org/T198857) (owner: 10WMDE-leszek) [13:43:58] (03Merged) 10jenkins-bot: Don't specify the comment if it is an empty string. [extensions/EventBus] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443932 (owner: 10Ppchelko) [13:44:49] (03CR) 10jenkins-bot: Don't specify the comment if it is an empty string. [extensions/EventBus] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443932 (owner: 10Ppchelko) [13:45:47] 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-EducationProgram, 10Education-Program-Dashboard, 10Education-Program-Design-Research, 10Education-Dashboard-Course-Pages: WikiEd courses link above every page started to show even if the preferences' option i... - https://phabricator.wikimedia.org/T198859 [13:46:00] 10Community-Relations: Transfer Community Liaisons skills map to a wiki page - https://phabricator.wikimedia.org/T167122 (10Elitre) [13:47:03] (03CR) 10Your1: "> Patch Set 1: Code-Review-1" [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [13:47:15] 10Community-Relations-Support: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML - https://phabricator.wikimedia.org/T166895 (10Elitre) @ssastry Please let me know about your plans here (when you can). TYVM! [13:47:47] 10CommRel-Specialists-Support: CL support for adding wiki-specific CSS for styling citations output in Parsoid HTML - https://phabricator.wikimedia.org/T166895 (10Elitre) a:05Elitre>03None [13:48:05] (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated userWasLastToEdit method [core] - 10https://gerrit.wikimedia.org/r/443959 (owner: 10Awight) [13:52:06] (03PS2) 10Awight: Cleanup [core] - 10https://gerrit.wikimedia.org/r/443960 [13:52:08] (03PS2) 10Awight: Remove redundant assignments [core] - 10https://gerrit.wikimedia.org/r/443961 [13:52:10] (03PS2) 10Awight: Give a bit of love to EditPage docstrings [core] - 10https://gerrit.wikimedia.org/r/443962 [13:54:56] (03PS3) 10Aaron Schulz: rdbms: add IDatabase::lockForUpdate() convenience method [core] - 10https://gerrit.wikimedia.org/r/443477 [13:58:58] (03CR) 10jerkins-bot: [V: 04-1] Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight) [14:01:54] (03PS3) 10Kosta Harlan: WIP: Implement front-end code for ORES filters [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443966 (https://phabricator.wikimedia.org/T198747) [14:07:28] (03CR) 10jerkins-bot: [V: 04-1] Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 (owner: 10Awight) [14:11:49] 10Community-Relations: A CRM for Technical Collaboration - https://phabricator.wikimedia.org/T177583 (10Qgil) 05Open>03declined We are not giving up on the idea of setting up a CRM but this require proper planning beforehand. I'm closing this task as declined for now. [14:12:42] 10Community-Relations, 10Discovery: Discuss improvements to non-content searches - https://phabricator.wikimedia.org/T142635 (10Qgil) 05Open>03Invalid [14:14:47] 10MediaWiki-Interface, 10MediaWiki-extensions-CentralNotice, 10I18n: Local i18n for MediaWiki:Centralnotice-summary - https://phabricator.wikimedia.org/T138284 (10Steinsplitter) [14:15:01] 10MediaWiki-extensions-NewUserActions, 10MediaWiki-extensions-NewUserMessage: Add new NS_USER page creation - https://phabricator.wikimedia.org/T117957 (10Qgil) [14:15:03] 10MediaWiki-extensions-NewUserActions, 10Collaboration-Community-Engagement, 10Community-Relations: Identify how communities welcome new users to define NewUserActions features - https://phabricator.wikimedia.org/T130356 (10Qgil) 05Open>03declined @Trizek-WMF , maybe the growth team is interested in at l... [14:19:43] (03CR) 10Thiemo Kreuz (WMDE): "I'm always happy to see patches improving the language support for MediaWiki. But I fear this particular patch shows to many issues to eve" [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) (owner: 10Qdinar) [14:20:23] (03CR) 10Aaron Schulz: Use consistent caching strategy in Revision storage classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [14:24:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Cast the variable to an array to prevent PHP warnings (031 comment) [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [14:26:20] 10MediaWiki-extensions-Contributors, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins: Archive the ContributorsAddon extension - https://phabricator.wikimedia.org/T198864 (10hashar) [14:29:44] (03PS2) 10Aaron Schulz: [WIP] Move l10n_cache table to a separate DB for sqlite via the installer [core] - 10https://gerrit.wikimedia.org/r/443951 (https://phabricator.wikimedia.org/T93097) [14:30:54] (03PS3) 10Aaron Schulz: [WIP] Move l10n_cache table to a separate DB for sqlite via the installer [core] - 10https://gerrit.wikimedia.org/r/443951 (https://phabricator.wikimedia.org/T93097) [14:33:27] (03CR) 10Hashar: [C: 032] Move links fro content-text to contentSub [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/442303 (https://phabricator.wikimedia.org/T198329) (owner: 10Hashar) [14:36:09] (03CR) 10jerkins-bot: [V: 04-1] DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 (owner: 10Daniel Kinzler) [14:37:24] (03PS2) 10Awight: Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) [14:38:45] (03Merged) 10jenkins-bot: Move links fro content-text to contentSub [extensions/BreadCrumbs] - 10https://gerrit.wikimedia.org/r/442303 (https://phabricator.wikimedia.org/T198329) (owner: 10Hashar) [14:39:28] 10Epic: Uses of wb_terms SQL table to be migrated away - https://phabricator.wikimedia.org/T198866 (10WMDE-leszek) [14:39:46] (03PS2) 10Daniel Kinzler: DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 [14:42:03] (03PS1) 10Hashar: Replace removed method getLaggedSlaveMode() [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/443979 (https://phabricator.wikimedia.org/T193808) [14:43:43] (03CR) 10jerkins-bot: [V: 04-1] DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 (owner: 10Daniel Kinzler) [14:44:47] (03CR) 10Your1: "> Patch Set 1: Code-Review-1" (031 comment) [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [14:45:23] (03PS1) 10Hashar: Release note for getLaggedSlaveMode() removal [core] - 10https://gerrit.wikimedia.org/r/443980 [14:45:45] (03CR) 10Hashar: "1.32 release note added by https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/443980/" [core] - 10https://gerrit.wikimedia.org/r/428268 (owner: 10Aaron Schulz) [14:47:39] (03PS18) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [14:47:59] (03PS1) 10Niedzielski: POC: hack out auto-inlining SVGs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443982 (https://phabricator.wikimedia.org/T191528) [14:49:31] (03CR) 10Hashar: [C: 032] "The other failure is T159058" [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/443979 (https://phabricator.wikimedia.org/T193808) (owner: 10Hashar) [14:50:15] (03Merged) 10jenkins-bot: Replace removed method getLaggedSlaveMode() [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/443979 (https://phabricator.wikimedia.org/T193808) (owner: 10Hashar) [14:53:41] (03CR) 10Daniel Kinzler: [C: 032] Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [14:55:45] (03PS1) 10Daniel Kinzler: Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) [14:56:19] (03CR) 10jerkins-bot: [V: 04-1] Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [14:56:35] (03CR) 10jerkins-bot: [V: 04-1] Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [14:57:00] (03CR) 10Daniel Kinzler: [C: 04-1] "CR-1 as per T198701:" [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [14:57:17] (03PS1) 10Dbrant: Prepare for Kotlin support. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443986 [14:57:38] (03CR) 10Aaron Schulz: [C: 032] Release note for getLaggedSlaveMode() removal [core] - 10https://gerrit.wikimedia.org/r/443980 (owner: 10Hashar) [14:57:49] (03CR) 10jerkins-bot: [V: 04-1] POC: hack out auto-inlining SVGs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443982 (https://phabricator.wikimedia.org/T191528) (owner: 10Niedzielski) [14:57:51] (03CR) 10Dbrant: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443950 (owner: 10L10n-bot) [15:02:36] (03PS1) 10Awight: Stop using $originalRevId incorrectly [core] - 10https://gerrit.wikimedia.org/r/443987 [15:08:40] (03Merged) 10jenkins-bot: Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [15:11:29] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/443990 [15:11:44] (03PS4) 10Dbarratt: Enforce Partial Blocks by determing the blocked page dynamiclly. [core] - 10https://gerrit.wikimedia.org/r/443024 (https://phabricator.wikimedia.org/T197117) [15:11:50] (03CR) 10Hashar: "check experimental" [extensions/TwitterLogin] - 10https://gerrit.wikimedia.org/r/443990 (owner: 10Hashar) [15:12:00] (03Merged) 10jenkins-bot: Release note for getLaggedSlaveMode() removal [core] - 10https://gerrit.wikimedia.org/r/443980 (owner: 10Hashar) [15:12:10] (03PS1) 10Ladsgroup: Append new line character to output of populateChangeTagDef.php [core] - 10https://gerrit.wikimedia.org/r/443992 [15:12:53] (03CR) 10jenkins-bot: Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [15:14:39] (03CR) 10WMDE-leszek: [C: 032] Append new line character to output of populateChangeTagDef.php [core] - 10https://gerrit.wikimedia.org/r/443992 (owner: 10Ladsgroup) [15:15:59] (03CR) 10jenkins-bot: Release note for getLaggedSlaveMode() removal [core] - 10https://gerrit.wikimedia.org/r/443980 (owner: 10Hashar) [15:17:28] (03CR) 10jerkins-bot: [V: 04-1] Stop using $originalRevId incorrectly [core] - 10https://gerrit.wikimedia.org/r/443987 (owner: 10Awight) [15:19:22] (03PS3) 10Awight: Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) [15:19:31] (03PS2) 10Awight: Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 [15:19:33] (03PS1) 10Awight: Drop "starttime" parameter [core] - 10https://gerrit.wikimedia.org/r/443998 [15:19:48] cssjanus/cssjanus#27 (master - 569d68a Timo Tijhof): The build passed. - https://travis-ci.com/cssjanus/cssjanus/builds/78198467 [15:24:34] 10MediaWiki-extensions-Disambiguator: Help communities to learn about and use Disambiguator extension - https://phabricator.wikimedia.org/T146484 (10Quiddity) a:05Quiddity>03None [15:24:54] (03CR) 10jerkins-bot: [V: 04-1] Enforce Partial Blocks by determing the blocked page dynamiclly. [core] - 10https://gerrit.wikimedia.org/r/443024 (https://phabricator.wikimedia.org/T197117) (owner: 10Dbarratt) [15:25:00] 10MediaWiki-Database, 10DBA, 10MW-1.32-release-notes (WMF-deploy-2018-06-26 (1.32.0-wmf.10)), 10Multi-Content-Revisions (MCR-SDC phase 1), and 2 others: Rising lock wait timeout SQL errors upon 1.32.0-wmf.10 group1 deployment - https://phabricator.wikimedia.org/T198350 (10Marostegui) +1 to get it closed [15:27:06] (03Merged) 10jenkins-bot: Append new line character to output of populateChangeTagDef.php [core] - 10https://gerrit.wikimedia.org/r/443992 (owner: 10Ladsgroup) [15:30:44] (03CR) 10jenkins-bot: Append new line character to output of populateChangeTagDef.php [core] - 10https://gerrit.wikimedia.org/r/443992 (owner: 10Ladsgroup) [15:32:31] (03CR) 10jerkins-bot: [V: 04-1] Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 (owner: 10Awight) [15:32:37] 10MobileFrontend, 10Category, 10Epic, 10Readers-Web-Backlog (Tracking): [EPIC]: Use core watchlist code for mobile experience - https://phabricator.wikimedia.org/T109277 (10Jdlrobson) [15:32:40] (03PS2) 10Daniel Kinzler: Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) [15:32:57] (03PS2) 10Awight: Stop using $originalRevId incorrectly [core] - 10https://gerrit.wikimedia.org/r/443987 [15:33:16] (03CR) 10jerkins-bot: [V: 04-1] Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [15:33:37] 10MediaWiki-Watchlist, 10MobileFrontend, 10Readers-Web-Backlog (Design): Unseen changes on the Watchlist are not highlighted/bold on mobile site - https://phabricator.wikimedia.org/T198807 (10Jdlrobson) Note: T109277 was the proposed fix for this. It's considerably less work than updating our version of the... [15:34:59] (03CR) 10jerkins-bot: [V: 04-1] Introduce RevisionStoreFactory & Tests [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [15:35:10] (03PS4) 10Awight: Drop "edittime" parameter [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) [15:36:25] (03CR) 10jerkins-bot: [V: 04-1] Drop "starttime" parameter [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [15:36:33] (03CR) 10jerkins-bot: [V: 04-1] DNM MOCK: COnnectionFactory usage pattern [core] - 10https://gerrit.wikimedia.org/r/443968 (owner: 10Daniel Kinzler) [15:37:10] (03PS1) 10Pboehm: Prototype of refactored styles for searchresults ERM8624 [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/444001 [15:37:51] (03PS4) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [15:38:49] (03CR) 10Your1: "> Patch Set 1:" (031 comment) [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [15:39:02] (03PS5) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [15:39:31] (03CR) 10Anomie: [C: 04-2] "No, it does not serve the same purpose. This would reopen T17647." [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [15:39:46] (03CR) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [15:41:24] (03CR) 10Jforrester: [C: 04-1] Adding code standards configuration for phpcs to drafts. (031 comment) [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/443128 (owner: 10ValeryanM) [15:42:01] (03CR) 10Jforrester: [C: 032] "Given no-one else is merging this, I will. :-)" [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:42:51] (03CR) 10Awight: "I agree--just looking at it now and I see that it fails for a new page." [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [15:42:55] (03Abandoned) 10Awight: Drop "starttime" parameter [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [15:43:28] (03PS3) 10Awight: Pedantic strict equals. [core] - 10https://gerrit.wikimedia.org/r/443964 [15:44:05] (03CR) 10Jforrester: [C: 032] Remove $wgBrowserBlacklist setting (deprecated, no-op) [core] - 10https://gerrit.wikimedia.org/r/443759 (owner: 10Krinkle) [15:44:34] (03PS12) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [15:44:41] (03CR) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [15:48:51] (03CR) 10jerkins-bot: [V: 04-1] Enforce Partial Blocks by determing the blocked page dynamiclly. [core] - 10https://gerrit.wikimedia.org/r/443024 (https://phabricator.wikimedia.org/T197117) (owner: 10Dbarratt) [15:49:36] (03Abandoned) 10Niedzielski: POC: hack out auto-inlining SVGs [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443982 (https://phabricator.wikimedia.org/T191528) (owner: 10Niedzielski) [15:50:21] (03CR) 10Anomie: [C: 04-1] Introduce RevisionStoreFactory & Tests (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [15:50:56] (03CR) 10Esanders: [C: 031] "ping" [core] - 10https://gerrit.wikimedia.org/r/378251 (owner: 10Esanders) [15:50:58] (03CR) 10jerkins-bot: [V: 04-1] Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [15:51:00] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/444006 [15:51:02] (03CR) 10Hashar: "check experimental" [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/444006 (owner: 10Hashar) [15:51:09] (03CR) 10Dbrant: [C: 032] Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443950 (owner: 10L10n-bot) [15:51:16] (03CR) 10Yaron Koren: "@Thiemo Kreuz - great catch on the extension.json thing. A "config" section, including a setting for $edgStringReplacements, was actually " [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [15:51:50] (03CR) 10Kghbln: [C: 031] "Refs: https://www.mediawiki.org/wiki/Topic:Ufwji4425rqprbje" [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 (owner: 10Cicalese) [15:53:47] (03PS6) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [15:56:29] (03CR) 10Kghbln: [C: 031] "This one is ready to be merged and tagged. :) Thanks a ton for looking into this!" [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 (owner: 10Cicalese) [15:57:44] (03Merged) 10jenkins-bot: build: Introduce mediawiki-codesniffer [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:58:08] (03PS19) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [16:00:30] (03CR) 10jenkins-bot: Append new line character to output of populateChangeTagDef.php [core] - 10https://gerrit.wikimedia.org/r/443992 (owner: 10Ladsgroup) [16:02:33] (03CR) 10Anomie: [C: 04-1] "More detailed commentary in T198701#4400178." [core] - 10https://gerrit.wikimedia.org/r/443985 (https://phabricator.wikimedia.org/T198701) (owner: 10Daniel Kinzler) [16:04:06] (03CR) 10Awight: "Aha, and the undeleted page still has revid = editRevId, I had missed that earlier." [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [16:08:51] (03Merged) 10jenkins-bot: Remove $wgBrowserBlacklist setting (deprecated, no-op) [core] - 10https://gerrit.wikimedia.org/r/443759 (owner: 10Krinkle) [16:11:55] (03CR) 10jenkins-bot: Remove $wgBrowserBlacklist setting (deprecated, no-op) [core] - 10https://gerrit.wikimedia.org/r/443759 (owner: 10Krinkle) [16:14:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443950 (owner: 10L10n-bot) [16:17:00] 10OOUI, 10Patch-For-Review, 10VisualEditor (Current work): Category drop down list gets sticky when it's open while closing the dialog - https://phabricator.wikimedia.org/T185944 (10matmarex) p:05Triage>03Normal [16:17:09] 10MobileFrontend, 10Readers-Web-Backlog, 10Easy: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Jdlrobson) [16:17:40] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Transition mw-node-qunit and resource-modules to wikimedia/ - https://phabricator.wikimedia.org/T197251 (10Niedzielski) @Jdlrobson, done! Please try... [16:19:30] (03CR) 10jerkins-bot: [V: 04-1] List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [16:20:01] 10MediaWiki-extensions-LinkedWiki, 10Upstream: LinkedWiki extension requires php 7.1 due to bordercloud/sparql - https://phabricator.wikimedia.org/T198874 (10hashar) [16:22:37] 10Design-Research, 10New-Editor-Experiences, 10CommRel-Specialists-Support (Jul-Sep-2018): Learn about new editors questions and challenges from mentors - https://phabricator.wikimedia.org/T197177 (10Trizek-WMF) While more questions are requested, the deadline is postponed to until we decide that task is com... [16:24:21] (03CR) 10D3r1ck01: "recheck" [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/436272 (https://phabricator.wikimedia.org/T195162) (owner: 10D3r1ck01) [16:25:09] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags to SendGrid's PHPUnit tests [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/436272 (https://phabricator.wikimedia.org/T195162) (owner: 10D3r1ck01) [16:29:03] 10MediaWiki-Page-editing, 10Epic, 10MW-1.27-release (WMF-deploy-2015-12-08_(1.27.0-wmf.8)), 10MW-1.27-release-notes, and 2 others: Edit conflict detection by timestamp should be deprecated - https://phabricator.wikimedia.org/T58849 (10awight) [16:33:09] (03CR) 10Cooltey: [C: 032] Prepare for Kotlin support. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443986 (owner: 10Dbrant) [16:33:23] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/444016 [16:33:44] (03CR) 10Hashar: "check experimental" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/444016 (owner: 10Hashar) [16:34:26] (03PS1) 10Brian Wolff: Add code to force type for MW globals [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/444017 (https://phabricator.wikimedia.org/T195010) [16:36:54] (03CR) 10jerkins-bot: [V: 04-1] Add code to force type for MW globals [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/444017 (https://phabricator.wikimedia.org/T195010) (owner: 10Brian Wolff) [16:40:37] (03PS2) 10Brian Wolff: Add code to force type for MW globals [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/444017 (https://phabricator.wikimedia.org/T195010) [16:48:27] (03Merged) 10jenkins-bot: Prepare for Kotlin support. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443986 (owner: 10Dbrant) [16:50:24] (03CR) 10jerkins-bot: [V: 04-1] List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [16:51:34] (03PS1) 10Brian Wolff: Fix some raw html messages [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/444019 (https://phabricator.wikimedia.org/T195010) [16:51:47] (03CR) 10jenkins-bot: Prepare for Kotlin support. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/443986 (owner: 10Dbrant) [16:52:46] (03PS1) 10Brian Wolff: Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) [16:54:14] (03CR) 10Jdlrobson: [C: 031] "Lego?" [extensions/Collection] - 10https://gerrit.wikimedia.org/r/332929 (owner: 10Paladox) [16:54:47] (03CR) 10jerkins-bot: [V: 04-1] Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [16:55:26] (03PS9) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [16:56:36] (03PS1) 10D3r1ck01: Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444022 [16:56:55] (03CR) 10Brian Wolff: "Note, this is very similar to Daimona Eaytoy's WIP patch https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/AbuseFilter/+/439918/" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [16:57:20] (03CR) 10jerkins-bot: [V: 04-1] Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) (owner: 10Daimona Eaytoy) [16:57:25] (03CR) 10jerkins-bot: [V: 04-1] Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) (owner: 10Daimona Eaytoy) [16:57:39] (03CR) 10jerkins-bot: [V: 04-1] Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444022 (owner: 10D3r1ck01) [16:58:04] (03PS10) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [16:59:35] (03CR) 10Brian Wolff: "Ok, so I was wrong here - it is due to incorrect taint information in this file." [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/431300 (https://phabricator.wikimedia.org/T193837) (owner: 10Daimona Eaytoy) [17:02:49] (03Abandoned) 10D3r1ck01: Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444022 (owner: 10D3r1ck01) [17:03:27] (03Abandoned) 10D3r1ck01: Add @covers tags to SendGrid's PHPUnit tests [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/436272 (https://phabricator.wikimedia.org/T195162) (owner: 10D3r1ck01) [17:09:27] (03PS1) 10D3r1ck01: Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 [17:10:02] (03CR) 10jerkins-bot: [V: 04-1] Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 (owner: 10D3r1ck01) [17:10:24] (03PS2) 10D3r1ck01: Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 [17:11:50] (03PS1) 10Paladox: Replace .delegate to .on [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/444029 [17:12:18] (03PS2) 10Paladox: Replace .delegate to .on [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/444029 [17:12:56] (03CR) 10jerkins-bot: [V: 04-1] Upgrading sendgrid to v7.0, sendgrid's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 (owner: 10D3r1ck01) [17:12:58] (03CR) 10Paladox: [C: 032] Replace .delegate to .on [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/444029 (owner: 10Paladox) [17:13:01] (03PS1) 10Paladox: Replace .delegate to .on [extensions/CollapsibleVector] (REL1_31) - 10https://gerrit.wikimedia.org/r/444030 [17:13:05] (03CR) 10Paladox: [C: 032] Replace .delegate to .on [extensions/CollapsibleVector] (REL1_31) - 10https://gerrit.wikimedia.org/r/444030 (owner: 10Paladox) [17:14:11] (03CR) 10Paladox: [V: 032 C: 032] Replace .delegate to .on [extensions/CollapsibleVector] (REL1_31) - 10https://gerrit.wikimedia.org/r/444030 (owner: 10Paladox) [17:15:23] (03CR) 10Brian Wolff: [C: 032] Add phan seccheck to composer and remove deprecated module [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/439907 (owner: 10Daimona Eaytoy) [17:15:47] (03PS20) 10Dbarratt: List Partial Block details in ApiQueryBlocks and ApiQueryUserinfo. [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) [17:15:49] (03CR) 10Daimona Eaytoy: "> Note, this is very similar to Daimona Eaytoy's WIP patch" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [17:19:05] (03Merged) 10jenkins-bot: Replace .delegate to .on [extensions/CollapsibleVector] - 10https://gerrit.wikimedia.org/r/444029 (owner: 10Paladox) [17:19:38] (03PS8) 10Dbrant: Turn ToC into a sliding scrollable controller. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/442164 (https://phabricator.wikimedia.org/T165964) [17:23:05] (03CR) 10Daimona Eaytoy: [C: 031] "LGTM and no visual problems." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [17:26:06] (03PS1) 10Dbrant: Turn ToC into a sliding scrollable controller. [apps/android/wikipedia] (toc_scroller) - 10https://gerrit.wikimedia.org/r/444031 (https://phabricator.wikimedia.org/T165964) [17:28:11] (03Abandoned) 10Dbrant: Turn ToC into a sliding scrollable controller. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/442164 (https://phabricator.wikimedia.org/T165964) (owner: 10Dbrant) [17:31:43] (03CR) 10Anomie: [C: 04-1] "While we might want to do this (see discussion on T175745, which is currently unresolved and might want community consultation), the reaso" (035 comments) [core] - 10https://gerrit.wikimedia.org/r/443958 (owner: 10Awight) [17:33:32] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Growth-Team, 10Patch-For-Review: Implement front-end code for ORES filters - https://phabricator.wikimedia.org/T198747 (10Catrope) [17:33:48] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Growth-Team (Current Sprint), 10Patch-For-Review: Implement front-end code for ORES filters - https://phabricator.wikimedia.org/T198747 (10JTannerWMF) [17:34:24] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Growth-Team: Implement back-end code for ORES filters - https://phabricator.wikimedia.org/T198748 (10Catrope) [17:34:31] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Growth-Team (Current Sprint): Implement back-end code for ORES filters - https://phabricator.wikimedia.org/T198748 (10JTannerWMF) [17:34:39] (03Merged) 10jenkins-bot: Add phan seccheck to composer and remove deprecated module [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/439907 (owner: 10Daimona Eaytoy) [17:35:01] (03CR) 10C. Scott Ananian: "Fomafix and Nikerabbit both make good points. I'm not strongly for or against this current patch, I just thought the issue should be sepa" [core] - 10https://gerrit.wikimedia.org/r/443129 (owner: 10C. Scott Ananian) [17:35:48] (03CR) 10jenkins-bot: Add phan seccheck to composer and remove deprecated module [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/439907 (owner: 10Daimona Eaytoy) [17:46:26] (03CR) 10C. Scott Ananian: Hard-deprecate the $wgUseTidy option (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442104 (https://phabricator.wikimedia.org/T198214) (owner: 10C. Scott Ananian) [17:51:53] (03CR) 10Anomie: "> But now I'm surprised because the block we're talking about in wasDeletedSinceLastEdit is protected by !$this->mTitle->exists(), so we'l" [core] - 10https://gerrit.wikimedia.org/r/443998 (owner: 10Awight) [17:53:13] 10MediaWiki-extensions-PageCuration, 10Beta-Cluster-Infrastructure, 10Growth-Team, 10Collaboration-Team-Triage (Collab-Team-Next-Quarter): [betalabs]: Page triage: "Uncaught TypeError: Cannot read property 'getLogPageTitle' of undefined" for 'Redirects for discussi... - https://phabricator.wikimedia.org/T196954 [17:58:18] (03PS1) 10Daimona Eaytoy: Don't use globals for filter validation [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444034 [18:00:51] (03PS3) 10D3r1ck01: [WIP] Upgrading SG to v7.0, SG's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 [18:01:01] (03CR) 10Anomie: "When I was recently working on my own patch for T34037, I discovered that there are still some other things depending on wpEdittime or ->e" [core] - 10https://gerrit.wikimedia.org/r/443963 (https://phabricator.wikimedia.org/T58849) (owner: 10Awight) [18:01:27] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "> […] casting provides a simple and clean way to ensure that the foreach behaves deterministically for all possible inputs." [extensions/ExternalData] - 10https://gerrit.wikimedia.org/r/421525 (owner: 10Your1) [18:04:30] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Upgrading SG to v7.0, SG's php-http-client + refactoring [extensions/SendGrid] - 10https://gerrit.wikimedia.org/r/444026 (owner: 10D3r1ck01) [18:04:32] (03Abandoned) 10Jdlrobson: Freely floating tables and images [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/430098 (https://phabricator.wikimedia.org/T193418) (owner: 10Jdlrobson) [18:05:08] (03PS4) 10Jdlrobson: Do not restrict images to 320px at tablet resolution [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/430108 [18:08:47] (03CR) 10Jdrewniak: [C: 032] Do not restrict images to 320px at tablet resolution [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/430108 (owner: 10Jdlrobson) [18:09:54] 10Design, 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog, and 4 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10stjn) There are also some issue in a more global way with interwiki links, since you can write `[[google:t... [18:10:14] (03PS12) 10Jdlrobson: Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 [18:16:22] (03CR) 10Jdlrobson: [C: 032] Links should not be clickable in mobile page issue element [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/442996 (https://phabricator.wikimedia.org/T198115) (owner: 10Niedzielski) [18:17:32] (03PS2) 10Jdlrobson: Use wgPageContentLanguage instead of custom config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443751 [18:20:32] (03CR) 10jerkins-bot: [V: 04-1] Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 (owner: 10Jdlrobson) [18:22:37] (03Merged) 10jenkins-bot: Do not restrict images to 320px at tablet resolution [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/430108 (owner: 10Jdlrobson) [18:25:07] 10MediaWiki-Page-editing, 10Commons, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile: Cannot enter talk page on mobile Commons site - https://phabricator.wikimedia.org/T198555 (10Jdlrobson) @Aschroet the talk link will only work if you are logged in. There is a longstanding bug dating back to the 2015... [18:25:12] 10Design, 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog, and 4 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10Quiddity) >>! In T190549#4400913, @stjn wrote: > There are also some issue in a more global way with inter... [18:26:03] (03Merged) 10jenkins-bot: Links should not be clickable in mobile page issue element [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/442996 (https://phabricator.wikimedia.org/T198115) (owner: 10Niedzielski) [18:26:05] (03CR) 10Physikerwelt: "After adding the php class to the search path... I got stuck because I didn't figure out how to register the functionality with wikibase. " [extensions/Math] - 10https://gerrit.wikimedia.org/r/443941 (https://phabricator.wikimedia.org/T173949) (owner: 10Physikerwelt) [18:27:52] 10Phabricator, 10Release-Engineering-Team (Kanban): Make sure elasticsearch 6 is supported in phabricator - https://phabricator.wikimedia.org/T181393 (10greg) p:05Lowest>03Normal Re-prioritizing. @EBernhardson still no date yet, right? And from what you said in T192614#4249710 are we actually OK with curr... [18:28:29] (03CR) 10jenkins-bot: Do not restrict images to 320px at tablet resolution [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/430108 (owner: 10Jdlrobson) [18:28:42] (03PS1) 10Brian Wolff: rm the hardcoded OOUI taints. They were wrong. [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/444037 [18:30:19] (03CR) 10Anomie: Introduce new schema flags and use them in RevisionStore. (032 comments) [core] - 10https://gerrit.wikimedia.org/r/442153 (https://phabricator.wikimedia.org/T197619) (owner: 10Daniel Kinzler) [18:31:56] (03CR) 10jenkins-bot: Links should not be clickable in mobile page issue element [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/442996 (https://phabricator.wikimedia.org/T198115) (owner: 10Niedzielski) [18:33:01] 10MediaWiki-extensions-CentralNotice: CentralNotice banner button need to apply Design Style Guide button properties - https://phabricator.wikimedia.org/T195471 (10Pcoombe) 05Open>03Resolved Good catches, thanks! While editing I also [brought the other colors in-line with the styleguide](https://meta.wikimed... [18:33:57] 10MediaWiki-extensions-Renameuser, 10phan-taint-check-plugin: Renameuser extension does not pass phan-taint-check 1.2.0 - https://phabricator.wikimedia.org/T195017 (10Bawolff) 05Open>03Resolved a:03Bawolff Not sure what this is about, but after https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Rena... [18:34:03] 10phan-taint-check-plugin, 10MW-1.32-release-notes (WMF-deploy-2018-05-08 (1.32.0-wmf.3)), 10Patch-For-Review: update phan-taint-check to 1.2.0 - https://phabricator.wikimedia.org/T193909 (10Bawolff) [18:34:38] 10MediaWiki-API, 10MediaWiki-Database, 10DBA, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), and 3 others: ApiQueryExtLinksUsage::run query has crazy limit - https://phabricator.wikimedia.org/T59176 (10Anomie) [18:34:41] 10MediaWiki-API, 10MediaWiki-Database, 10DBA, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), and 3 others: ApiQueryExtLinksUsage::run query has crazy limit - https://phabricator.wikimedia.org/T59176 (10Anomie) Yes. I forgot there was a checklist in here. [18:37:09] (03PS2) 10Jdlrobson: Send the Accept-Language header when calling API [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [18:39:02] (03CR) 10Jdlrobson: [C: 032] Send the Accept-Language header when calling API [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [18:39:19] (03PS1) 10Bartosz Dziewoński: Avoid duplicate IDs on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/444038 (https://phabricator.wikimedia.org/T198875) [18:45:10] 04(no projects): Ops access request - https://phabricator.wikimedia.org/T198899 (10Cirdan) [18:47:48] (03Abandoned) 10Brian Wolff: Add some OOUI widgets [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/431300 (https://phabricator.wikimedia.org/T193837) (owner: 10Daimona Eaytoy) [18:48:07] (03Merged) 10jenkins-bot: Send the Accept-Language header when calling API [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [18:49:05] (03CR) 10jenkins-bot: Send the Accept-Language header when calling API [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [18:51:44] (03PS2) 10Brian Wolff: Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) [18:53:51] (03CR) 10Brian Wolff: "Any particular reason to use a hook instead of just adding it to the config variable in extension.json?" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443833 (owner: 10Jack Phoenix) [18:56:40] (03CR) 10Valerie: [C: 032] "This particular change has already been discussed at https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/399897/ where there was consensus" [core] - 10https://gerrit.wikimedia.org/r/443299 (https://phabricator.wikimedia.org/T196400) (owner: 10Valerie) [18:57:01] (03CR) 10Brian Wolff: "PS2: Fix one more instance of double escaping. And fix phpcs failures." [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [18:58:09] (03CR) 10Brian Wolff: [C: 032] Add Phan-taint-check-plugin security tests [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/443232 (owner: 10MarcoAurelio) [18:58:56] (03CR) 10Brian Wolff: [C: 032] Add Phan configuration [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/443231 (owner: 10MarcoAurelio) [19:01:08] (03CR) 10Jack Phoenix: "> Any particular reason to use a hook instead of just adding it to" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443833 (owner: 10Jack Phoenix) [19:03:43] (03CR) 10Brian Wolff: [C: 04-1] "> I'm not sure what kind of error we may want to show. Maybe, making it clear that landing has priority over skin in the manual could do i" (031 comment) [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/443596 (owner: 10Daimona Eaytoy) [19:05:48] (03CR) 10Brian Wolff: [C: 04-1] "In addition to checking if both skin and landing page are set, it should maybe check for the condition that neither are set and throw an e" [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/443596 (owner: 10Daimona Eaytoy) [19:08:07] (03PS1) 10Jdlrobson: Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) [19:11:16] (03Merged) 10jenkins-bot: Changing the default for $wgPageCreationLog to true [core] - 10https://gerrit.wikimedia.org/r/443299 (https://phabricator.wikimedia.org/T196400) (owner: 10Valerie) [19:11:18] (03Merged) 10jenkins-bot: Add Phan configuration [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/443231 (owner: 10MarcoAurelio) [19:11:20] (03Merged) 10jenkins-bot: Add Phan-taint-check-plugin security tests [extensions/NukeDPL] - 10https://gerrit.wikimedia.org/r/443232 (owner: 10MarcoAurelio) [19:12:23] (03PS1) 10Jdlrobson: Replace usage of `done` in EditorOverlay [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444041 (https://phabricator.wikimedia.org/T188937) [19:13:48] (03CR) 10Dbarratt: "I have no idea why the test coverage has decreased on Block. If someone else has any ideas, that would be awesome. :)" [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [19:14:53] (03CR) 10jenkins-bot: Changing the default for $wgPageCreationLog to true [core] - 10https://gerrit.wikimedia.org/r/443299 (https://phabricator.wikimedia.org/T196400) (owner: 10Valerie) [19:17:08] (03PS1) 10Cooltey: [READY] Prototype 1: Add floating queue element [apps/android/wikipedia] (prototype_floating_queue) - 10https://gerrit.wikimedia.org/r/444042 (https://phabricator.wikimedia.org/T197811) [19:20:03] (03Abandoned) 10Cooltey: [READY] Prototype 1: Add floating queue element [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441516 (https://phabricator.wikimedia.org/T197811) (owner: 10Cooltey) [19:44:27] (03CR) 10Awight: Do not ignore edit conflicts with oneself. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/377813 (https://phabricator.wikimedia.org/T175745) (owner: 10Daniel Kinzler) [19:44:37] (03CR) 10Anomie: [C: 04-1] [MCR] Make PageArchive aware of MCR (0310 comments) [core] - 10https://gerrit.wikimedia.org/r/426009 (https://phabricator.wikimedia.org/T194015) (owner: 10Daniel Kinzler) [19:46:00] (03Abandoned) 10Awight: Remove dubious self-conflict clause [core] - 10https://gerrit.wikimedia.org/r/443958 (owner: 10Awight) [19:46:02] (03Abandoned) 10Awight: Remove deprecated userWasLastToEdit method [core] - 10https://gerrit.wikimedia.org/r/443959 (owner: 10Awight) [19:46:36] (03CR) 10Anomie: [C: 031] "This seems sane to me. But Aaron understands the caching stuff much better than I do." [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [19:51:31] (03CR) 10Anomie: [C: 031] Allow extra slots in write-both/read-new mode. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442903 (https://phabricator.wikimedia.org/T198413) (owner: 10Daniel Kinzler) [19:57:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/444045 (owner: 10L10n-bot) [20:00:27] (03PS2) 10Cooltey: Add floating queue element [apps/android/wikipedia] (prototype_floating_queue) - 10https://gerrit.wikimedia.org/r/444042 (https://phabricator.wikimedia.org/T197811) [20:03:44] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444047 (owner: 10L10n-bot) [20:14:49] (03CR) 10Pmiazga: Use wgPageContentLanguage instead of custom config (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443751 (owner: 10Jdlrobson) [20:15:37] (03CR) 10Anomie: [C: 031] "* Schemas themselves look sane." [core] - 10https://gerrit.wikimedia.org/r/440871 (https://phabricator.wikimedia.org/T197144) (owner: 10Dbarratt) [20:18:31] (03CR) 10Huji: [C: 032] Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [20:19:15] (03CR) 10Huji: "Should we abandon this now that I7fd1798030d83292ce46543e25c0c431ec345a11 is merged?" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/439918 (https://phabricator.wikimedia.org/T197002) (owner: 10Daimona Eaytoy) [20:23:09] (03Abandoned) 10Daimona Eaytoy: [WIP] Make AbuseFilter pass phan taint-check [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/439918 (https://phabricator.wikimedia.org/T197002) (owner: 10Daimona Eaytoy) [20:28:26] (03Merged) 10jenkins-bot: Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [20:29:55] (03CR) 10jenkins-bot: Minor escaping fixes [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444020 (https://phabricator.wikimedia.org/T197002) (owner: 10Brian Wolff) [20:31:16] (03PS6) 10Jdlrobson: Tie issues to sections [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443514 (https://phabricator.wikimedia.org/T197932) [20:31:26] (03CR) 10jerkins-bot: [V: 04-1] Tie issues to sections [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443514 (https://phabricator.wikimedia.org/T197932) (owner: 10Jdlrobson) [20:34:12] (03CR) 10Jdlrobson: Tie issues to sections (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443514 (https://phabricator.wikimedia.org/T197932) (owner: 10Jdlrobson) [20:35:43] (03PS7) 10Jdlrobson: Tie issues to sections [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443514 (https://phabricator.wikimedia.org/T197932) [20:40:01] (03CR) 10Pmiazga: [C: 032] Use wgPageContentLanguage instead of custom config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443751 (owner: 10Jdlrobson) [20:48:26] 10MobileFrontend, 10Readers-Web-Backlog, 10Easy: In readonly mode edit icon should show as locked - https://phabricator.wikimedia.org/T197497 (10Framawiki) Can you confirm me that there won't be cache problems ? As I know desktop site doesn't change the read page (link to edit page is still present), only bl... [20:48:31] (03CR) 10Anomie: Convert UNIQUE INDEX to PRIMARY KEY (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [20:50:27] (03CR) 10Reedy: "Why? We don't re-run postgres' tables.sql on an existing wiki do we?" [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [20:51:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/444090 (owner: 10L10n-bot) [20:53:16] (03Merged) 10jenkins-bot: Use wgPageContentLanguage instead of custom config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443751 (owner: 10Jdlrobson) [20:57:53] 10English-Wikipedia-New-Pages-Patrol, 10Growth-Team (Current Sprint): New Pages Feed: generate ORES scores (3.1) - https://phabricator.wikimedia.org/T195796 (10MMiller_WMF) Reassigning this to @SBisson, who is working on it now. [20:58:12] (03PS2) 10Krinkle: Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) (owner: 10Jdlrobson) [20:58:17] (03CR) 10Krinkle: [C: 031] Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) (owner: 10Jdlrobson) [20:58:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/444070 (owner: 10L10n-bot) [20:59:32] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/444062 (owner: 10L10n-bot) [20:59:36] (03CR) 10Krinkle: Replace usage of `done` in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444041 (https://phabricator.wikimedia.org/T188937) (owner: 10Jdlrobson) [21:01:21] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/444073 (owner: 10L10n-bot) [21:03:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Collection] - 10https://gerrit.wikimedia.org/r/444077 (owner: 10L10n-bot) [21:03:55] (03CR) 10Jdlrobson: Replace usage of `done` in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444041 (https://phabricator.wikimedia.org/T188937) (owner: 10Jdlrobson) [21:06:26] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/444080 (owner: 10L10n-bot) [21:07:17] (03PS10) 10MusikAnimal: Allow sorting of AfC drafts by submission date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) [21:09:01] (03CR) 10MusikAnimal: Allow sorting of AfC drafts by submission date (033 comments) [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) (owner: 10MusikAnimal) [21:10:21] (03PS11) 10Reedy: Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [21:11:25] (03PS1) 10Bearloga: 0.5.0 (various formatting and visualization functions) [wikimedia/discovery/wmf] - 10https://gerrit.wikimedia.org/r/444125 [21:11:31] (03CR) 10jerkins-bot: [V: 04-1] Allow sorting of AfC drafts by submission date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) (owner: 10MusikAnimal) [21:11:59] (03CR) 10Bearloga: [V: 032 C: 032] 0.5.0 (various formatting and visualization functions) [wikimedia/discovery/wmf] - 10https://gerrit.wikimedia.org/r/444125 (owner: 10Bearloga) [21:13:42] (03CR) 10Hashar: "recheck" [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/444006 (owner: 10Hashar) [21:13:48] (03CR) 10Hashar: "check experimental" [extensions/LinkedWiki] - 10https://gerrit.wikimedia.org/r/444006 (owner: 10Hashar) [21:13:55] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/444081 (owner: 10L10n-bot) [21:15:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/444083 (owner: 10L10n-bot) [21:17:03] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GeoData] - 10https://gerrit.wikimedia.org/r/444086 (owner: 10L10n-bot) [21:17:24] 10MediaWiki-Platform-Team, 10MediaWiki-ResourceLoader, 10Performance-Team, 10Security-Team, and 3 others: CSP Report: Triggered by mediawiki.js's domEval() function in Chrome and Safari (but not Firefox) - https://phabricator.wikimedia.org/T196923 (10Krinkle) [21:20:23] (03PS12) 10Reedy: Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [21:20:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/444088 (owner: 10L10n-bot) [21:21:16] (03CR) 10Anomie: "(replied on PS11, haven't reviewed later patchsets)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442222 (https://phabricator.wikimedia.org/T197141) (owner: 10Dbarratt) [21:21:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/LoginNotify] - 10https://gerrit.wikimedia.org/r/444087 (owner: 10L10n-bot) [21:22:49] (03CR) 10Anomie: "> Or are you meaning for migration patches?" [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [21:23:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/444092 (owner: 10L10n-bot) [21:26:11] 10Android-app-feature-Navigation, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): Visual design updates to the Explore feed and "Add floating queue element" mode - https://phabricator.wikimedia.org/T197812 (10cooltey) a:03cooltey [21:26:18] 10MediaWiki-Database, 10Wikimedia-Site-requests: Server-side deletion of User:LorenzoMilano/sandbox - https://phabricator.wikimedia.org/T198156 (10Krinkle) >>! In T198156#4397945, @MarcoAurelio wrote: > @aaron So, in theory, would it be possible to run deleteBatch.php or whichever other script that deletes a p... [21:26:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444091 (owner: 10L10n-bot) [21:27:58] 10Phabricator, 10Wikibugs: Exclude wiki bugs from phabricator rate limit - https://phabricator.wikimedia.org/T198915 (10Krenair) wikibugs runs on labs and I don't think that's going to get whitelisted. [21:28:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Math] - 10https://gerrit.wikimedia.org/r/444095 (owner: 10L10n-bot) [21:29:15] (03PS13) 10Reedy: Convert numerous UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [21:29:22] (03CR) 10Reedy: "That should be all the patches done..." [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [21:29:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/444094 (owner: 10L10n-bot) [21:30:17] (03CR) 10Krinkle: "We've been killing off a few cache-like tables over the past 2-3 years in favour of 'objectcache' table (directly) and/or WANObjectCache (" [core] - 10https://gerrit.wikimedia.org/r/443951 (https://phabricator.wikimedia.org/T93097) (owner: 10Aaron Schulz) [21:30:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/444100 (owner: 10L10n-bot) [21:31:56] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/444096 (owner: 10L10n-bot) [21:33:08] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/444107 (owner: 10L10n-bot) [21:33:10] 10Design, 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog, and 4 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10alexhollender) Re: consistent link styling across Minerva & Vector - Minerva uses `#36c` for all links, wh... [21:36:31] (03CR) 10Krinkle: "Release notes :)" [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [21:38:10] 10Android-app-feature-Navigation, 10Wikipedia-Android-App-Backlog ( Android-app-release-v2.7.25x-J-Jaffa-Cake): Visual design updates to the Explore feed and "Add floating queue element" mode - https://phabricator.wikimedia.org/T197812 (10cooltey) [21:39:08] (03PS1) 10Mglaser: Enable visualeditor on pageforms [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/444129 [21:40:33] (03CR) 10jerkins-bot: [V: 04-1] Enable visualeditor on pageforms [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/444129 (owner: 10Mglaser) [21:42:16] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2018), 10Documentation: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10Anomie) There are currently 26 open tasks tagged with #mediawiki-api and #documentation, but most don't seem relevant to the scope o... [21:43:23] (03CR) 10Krinkle: [C: 031] Parser: Remove style and script tags' content from TOC [core] - 10https://gerrit.wikimedia.org/r/443440 (https://phabricator.wikimedia.org/T198618) (owner: 10Anomie) [21:48:49] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Switch TemplateWizard dialog to smaller size - https://phabricator.wikimedia.org/T198920 (10Niharika) [21:51:45] (03CR) 10Daniel Kinzler: Introduce new schema flags and use them in RevisionStore. (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442153 (https://phabricator.wikimedia.org/T197619) (owner: 10Daniel Kinzler) [21:54:54] (03CR) 10jenkins-bot: Use wgPageContentLanguage instead of custom config [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443751 (owner: 10Jdlrobson) [21:57:59] 10Readers-Community-Engagement, 10CommRel-Specialists-Support (Jul-Sep-2018): Support Readers department with in-person user testing during Wikimania - https://phabricator.wikimedia.org/T198767 (10CKoerner_WMF) p:05Triage>03Normal [22:00:26] 10WMF-Communications: New Wikimedia Foundation website (Tracking task) - https://phabricator.wikimedia.org/T188774 (10Varnent) [22:01:14] 10Page-Previews, 10CommRel-Specialists-Support (Jul-Sep-2018), 10Readers-Web-Backlog (Tracking): Conduct conversations with communities on page previews configuration changes - https://phabricator.wikimedia.org/T197939 (10CKoerner_WMF) I've sent the following communication out to the wikitech-l mailing list,... [22:02:34] (03CR) 10Mooeypoo: [C: 04-1] "This looks great! fairly minor comments inline." (035 comments) [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) (owner: 10Samwilson) [22:02:40] 10Phabricator: Attempting to create a new Conpherence room produces an internal server error - https://phabricator.wikimedia.org/T198923 (10Dinoguy1000) [22:03:24] (03CR) 10Daniel Kinzler: "I haven't looked at this corner of Wikibase in more than a year, so I'm perhaps a bit rusty." (031 comment) [extensions/Math] - 10https://gerrit.wikimedia.org/r/443941 (https://phabricator.wikimedia.org/T173949) (owner: 10Physikerwelt) [22:03:34] 10Phabricator: Attempting to create a new Conpherence room produces an internal server error - https://phabricator.wikimedia.org/T198923 (10Krenair) I doubt it was you I think you just had unfortunate timing: ```18<bd80818> twentyafterfour: 500 errors for me from Phab following that !log 18<bd80818>... [22:04:42] 10Design, 10Page-Issue-Warnings, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Mobile page issues - allow page issues to display different severity levels - https://phabricator.wikimedia.org/T191528 (10Niedzielski) @alexhollender, I'm struggling a little bit understanding the... [22:10:11] 10MediaWiki-extension-requests, 10Wikimedia-Site-requests: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Dinoguy1000) The titleblacklist case probably bears looking at, but JS at least isn't going to be the case once {T190015} is resolved. [22:12:09] (03PS1) 10Tjones: Update Analysis Analysis Tools [wikimedia/discovery/relevanceForge] - 10https://gerrit.wikimedia.org/r/444130 [22:13:10] 10Phabricator: Attempting to create a new Conpherence room produces an internal server error - https://phabricator.wikimedia.org/T198923 (10Dinoguy1000) I'd be really happy with it being unfortunate timing. I guess I'll retry creating the room and see what happens, then. [22:14:57] 10Phabricator: Attempting to create a new Conpherence room produces an internal server error - https://phabricator.wikimedia.org/T198923 (10Dinoguy1000) 05Open>03Invalid Room created successfully; closing as invalid. Thanks for the explanation, @Krenair! =) [22:22:54] (03CR) 10EBernhardson: Add support for elastic 6.3.0 (034 comments) [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) (owner: 10DCausse) [22:23:06] (03CR) 10Jdlrobson: "<3 thank you Physikerwelt for taking a look at this.Sending you some wikilove. I really appreciate this bug is getting attention." [extensions/Math] - 10https://gerrit.wikimedia.org/r/443941 (https://phabricator.wikimedia.org/T173949) (owner: 10Physikerwelt) [22:24:50] 10MediaWiki-extension-requests, 10Wikimedia-Site-requests: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Daimona) @Dinoguy1000 Premising that I didn't read the whole other task. If its contents are what the title and the initial message s... [22:30:44] 10MediaWiki-extensions-Translate, 10Discovery, 10Discovery-Search, 10Elasticsearch, and 2 others: TTMServer performance and coverage issues - https://phabricator.wikimedia.org/T101236 (10EBernhardson) I pulled latency numbers from the apiaction logs. Overall it doesn't look like performance has changed in... [22:33:24] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Add all the overlays required for TemplateWizard - https://phabricator.wikimedia.org/T190231 (10Niharika) [22:34:38] 10MediaWiki-extensions-SphinxSearch, 10Upstream: [SphinxSearch] neutron/sphinxsearch-api uses deprecated class contructor - https://phabricator.wikimedia.org/T196174 (10hashar) [22:35:02] (03CR) 10VolkerE: [C: 031] Avoid duplicate IDs on Special:Preferences [core] - 10https://gerrit.wikimedia.org/r/444038 (https://phabricator.wikimedia.org/T198875) (owner: 10Bartosz Dziewoński) [22:38:35] (03CR) 10Krinkle: Replace usage of `done` in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444041 (https://phabricator.wikimedia.org/T188937) (owner: 10Jdlrobson) [22:38:46] (03CR) 10Krinkle: [C: 032] Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) (owner: 10Jdlrobson) [22:39:43] 10Contributors-Analysis, 10Product-Analytics: Review the draft Community Engagement Insights report for the Contributors team - https://phabricator.wikimedia.org/T198924 (10Neil_P._Quinn_WMF) [22:39:56] 10MediaWiki-extension-requests, 10Wikimedia-Site-requests: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Dinoguy1000) Yes, compromised accounts are always going to be a potential issue, but there are potential techniques to mitigate that... [22:40:09] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Cursor should appear at the end after template insertion - https://phabricator.wikimedia.org/T198925 (10Niharika) [22:41:36] 10Phabricator, 10Trusted-Contributors: Whitelist the Trusted-Contributors group from rate limit - https://phabricator.wikimedia.org/T198614 (10mmodell) This isn't technically feasible. The rate limit is based on IP and the throttle doesn't necessarily know which user is associated with an IP. [22:43:30] (03CR) 10MarkAHershberger: [C: 032] Fixed issue adding breadcrumbs to trail. [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 (owner: 10Cicalese) [22:44:07] (03CR) 10MarkAHershberger: [C: 032] Add support for VEForAll extension. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 (owner: 10Cicalese) [22:46:10] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: The input fields should not be focused when the field is removed - https://phabricator.wikimedia.org/T198926 (10Niharika) [22:46:23] 10MediaWiki-extension-requests, 10Wikimedia-Site-requests: Provide administrators a tool to enable a serverside blackout on a wiki - https://phabricator.wikimedia.org/T198890 (10Daimona) @Dinoguy good point. Maybe the same group as JS editors, once it'll be implemented? Could possibly be fine if such a group w... [22:49:29] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: In absence of any fields we should show an appropriate message to the user - https://phabricator.wikimedia.org/T198927 (10Niharika) [22:49:52] (03PS13) 10Jdlrobson: Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 [22:49:54] (03PS1) 10Jdlrobson: Limit editor text area styles to where they are needed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444131 [22:49:56] (03PS1) 10Jdlrobson: WIP: Simplify page actions selectors [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444132 (https://phabricator.wikimedia.org/T196893) [22:49:58] (03PS1) 10Jdlrobson: Hygiene: Document why selectors are needed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444133 [22:50:00] (03PS1) 10Jdlrobson: Cleanup: Last modified active color should be loaded via JS [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444134 [22:50:02] (03PS1) 10Jdlrobson: Hygiene: lazy loading animations do not need to be render blocking [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444135 [22:50:11] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: In absence of any fields we should show an appropriate message to the user - https://phabricator.wikimedia.org/T198927 (10Niharika) @cmadeo I'd like to have your thoughts on this ticket. Thanks! [22:50:26] 10Phabricator, 10Release-Engineering-Team (Kanban): Make sure elasticsearch 6 is supported in phabricator - https://phabricator.wikimedia.org/T181393 (10mmodell) a:03mmodell [22:53:13] 10Phabricator, 10Diffusion: Turn off 'blame' by default on Diffusion - https://phabricator.wikimedia.org/T198838 (10mmodell) I'm not sure why this is happening. [22:54:49] (03Merged) 10jenkins-bot: Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) (owner: 10Jdlrobson) [22:54:51] (03Merged) 10jenkins-bot: Fixed issue adding breadcrumbs to trail. [extensions/JSBreadCrumbs] - 10https://gerrit.wikimedia.org/r/443901 (owner: 10Cicalese) [22:54:53] (03Merged) 10jenkins-bot: Add support for VEForAll extension. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 (owner: 10Cicalese) [22:55:01] (03PS1) 10Catrope: Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) [22:55:44] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: In absence of any fields we should show an appropriate message to the user - https://phabricator.wikimedia.org/T198927 (10cmadeo) Since there are no fields, should we also remove the separator line? If removing the line is hard to do, then we might want... [22:57:46] (03CR) 10jenkins-bot: Replace $.Deferred() with assert.async() [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444040 (https://phabricator.wikimedia.org/T193069) (owner: 10Jdlrobson) [22:58:51] (03CR) 10jerkins-bot: [V: 04-1] WIP: Simplify page actions selectors [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444132 (https://phabricator.wikimedia.org/T196893) (owner: 10Jdlrobson) [23:02:37] (03CR) 10jerkins-bot: [V: 04-1] Cleanup: Last modified active color should be loaded via JS [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444134 (owner: 10Jdlrobson) [23:02:58] (03CR) 10jerkins-bot: [V: 04-1] Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 (owner: 10Jdlrobson) [23:03:05] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: Document why selectors are needed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444133 (owner: 10Jdlrobson) [23:03:32] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: lazy loading animations do not need to be render blocking [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444135 (owner: 10Jdlrobson) [23:05:05] 10Phabricator: Replace project names by PHIDs in our Phab extensions - https://phabricator.wikimedia.org/T198589 (10mmodell) The problem with using PHIDs is that it makes testing difficult - on my test instance the PHIDs differ from production. I suppose I could fix it manually in the database though. [23:06:11] (03PS2) 10Jdlrobson: Hygiene: Document why selectors are needed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444133 [23:06:13] (03PS2) 10Jdlrobson: Cleanup: Last modified active color should be loaded via JS [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444134 [23:06:15] (03PS2) 10Jdlrobson: Hygiene: lazy loading animations do not need to be render blocking [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444135 [23:06:17] (03PS2) 10Jdlrobson: WIP: Simplify page actions selectors [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444132 (https://phabricator.wikimedia.org/T196893) [23:06:19] (03PS1) 10Jdlrobson: Remove unnecessary skins.minerva.base.styles [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444137 [23:06:21] (03PS1) 10Jdlrobson: Move overlay-header styles to Overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444138 [23:06:32] 10MediaWiki-API, 10Developer-Advocacy (Jul-Sep 2018), 10Documentation: Investigate and improve MediaWiki Action API documentation - https://phabricator.wikimedia.org/T198916 (10srishakatux) [23:08:44] (03CR) 10Jdlrobson: Replace usage of `done` in EditorOverlay (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/444041 (https://phabricator.wikimedia.org/T188937) (owner: 10Jdlrobson) [23:10:11] (03CR) 10Catrope: [C: 032] Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:10:40] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Patch-For-Review, and 2 others: Replace $.Deferred() with assert.async() in tests that assert failure - https://phabricator.wikimedia.org/T193069 (10Jdlrobson) a:05Jdlrobson>03None Looking for a... [23:12:18] 10MediaWiki-extensions-Auth_remoteuser: First Save bug (2018) - https://phabricator.wikimedia.org/T198928 (10Revansx) [23:13:06] (03PS14) 10Jdlrobson: WIP: TODOs and possible savings - Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 [23:13:09] 10MediaWiki-extensions-Auth_remoteuser: First Save bug (2018) - https://phabricator.wikimedia.org/T198928 (10Revansx) a:03Tgr [23:14:07] (03CR) 10Catrope: Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:14:10] (03CR) 10Catrope: [C: 032] Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:16:11] (03CR) 10jerkins-bot: [V: 04-1] Move overlay-header styles to Overlay [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444138 (owner: 10Jdlrobson) [23:16:35] (03PS1) 10Cooltey: [WIP] Visual design updates for the prototype floating queue [apps/android/wikipedia] (prototype_floating_queue) - 10https://gerrit.wikimedia.org/r/444140 (https://phabricator.wikimedia.org/T197812) [23:16:59] (03CR) 10jerkins-bot: [V: 04-1] WIP: Simplify page actions selectors [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444132 (https://phabricator.wikimedia.org/T196893) (owner: 10Jdlrobson) [23:17:24] (03CR) 10jerkins-bot: [V: 04-1] Hygiene: lazy loading animations do not need to be render blocking [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444135 (owner: 10Jdlrobson) [23:18:27] (03CR) 10jerkins-bot: [V: 04-1] Remove unnecessary skins.minerva.base.styles [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444137 (owner: 10Jdlrobson) [23:21:24] (03CR) 10jerkins-bot: [V: 04-1] WIP: TODOs and possible savings - Move js-only css off critical path [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/425934 (owner: 10Jdlrobson) [23:24:29] (03CR) 10Nray: [C: 031] "Couldn't get the eslints to pass, but node tests pass and verified that header is being sent" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/443746 (https://phabricator.wikimedia.org/T198619) (owner: 10Pmiazga) [23:25:50] (03PS2) 10Jforrester: Fix error in various deprecated selectFields() methods [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [23:27:16] (03CR) 10jerkins-bot: [V: 04-1] Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:27:51] (03CR) 10Catrope: [C: 032] Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:28:03] (03PS3) 10Jforrester: Fix error in various deprecated selectFields() methods [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [23:29:40] (03PS3) 10Jforrester: GitInfo: Don't try shelling out if it's disabled [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/441746 (https://phabricator.wikimedia.org/T198037) (owner: 10Krinkle) [23:29:53] (03PS4) 10Jforrester: GitInfo: Don't try shelling out if it's disabled [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/441746 (https://phabricator.wikimedia.org/T198037) (owner: 10Krinkle) [23:30:34] (03CR) 10Jforrester: "PS2: Added the proper cherry-pick notice now that it's landed in master." [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [23:31:02] (03CR) 10Jforrester: "PS3: Rebase onto another REL1_31 patch for simplicity." [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/441746 (https://phabricator.wikimedia.org/T198037) (owner: 10Krinkle) [23:31:52] (03PS3) 10Jforrester: PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [23:34:10] (03PS4) 10Jforrester: PHPSessionHandler: Suppress warnings in initialize() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [23:34:29] (03CR) 10Jforrester: "PS3: Rebase onto another REL1_31 patch for simplicity." [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/440281 (https://phabricator.wikimedia.org/T197030) (owner: 10Paladox) [23:36:00] (03PS1) 10Jdlrobson: Don't ship 2 magnifying glass icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444141 [23:38:59] (03PS3) 10Dbarratt: Add a request for feedback on proposed changes to SpecialBlock. [core] - 10https://gerrit.wikimedia.org/r/443648 (https://phabricator.wikimedia.org/T194301) [23:40:32] (03CR) 10Krinkle: [C: 032] Fix error in various deprecated selectFields() methods [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [23:41:06] (03Merged) 10jenkins-bot: Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:43:55] (03CR) 10jenkins-bot: Handle missing presentation model [extensions/Echo] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/444136 (https://phabricator.wikimedia.org/T195253) (owner: 10Catrope) [23:43:58] (03PS11) 10Daimona Eaytoy: Add phpunit tests for creating and editing filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [23:47:39] (03CR) 10jerkins-bot: [V: 04-1] Don't ship 2 magnifying glass icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444141 (owner: 10Jdlrobson) [23:52:01] (03PS1) 10Jdlrobson: Allow ResourceLoaderImage modules without data URIs [core] - 10https://gerrit.wikimedia.org/r/444142 (https://phabricator.wikimedia.org/T198930) [23:52:47] (03PS1) 10Jdlrobson: Reduce render blocking styles by deferring loading of icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444143 (https://phabricator.wikimedia.org/T198930) [23:53:48] (03CR) 10Ori.livneh: [C: 031] Deprecate EventLoggingRegisterSchemas hook (031 comment) [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/441581 (owner: 10Legoktm) [23:54:03] (03PS2) 10Jdlrobson: Don't ship 2 magnifying glass icons [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444141 [23:54:53] (03PS3) 10Jdlrobson: Hygiene: Document why selectors are needed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444133 [23:56:59] (03PS3) 10Jdlrobson: Hygiene: lazy loading animations do not need to be render blocking [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444135 [23:57:59] 10MediaWiki-Database, 10Wikimedia-log-errors: Unable to jump to row 0 on MySQL result index N - https://phabricator.wikimedia.org/T97046 (10Krinkle) 05Open>03declined No hits in Wikimedia production Logstash for 30 days. Closing for now. [23:58:01] 10MediaWiki-Database, 10Wikimedia-log-errors: Unable to jump to row 0 on MySQL result index N - https://phabricator.wikimedia.org/T97046 (10Krinkle) 05Open>03declined No hits in Wikimedia production Logstash for 30 days. Closing for now. [23:58:30] (03Merged) 10jenkins-bot: Fix error in various deprecated selectFields() methods [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/443662 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [23:58:39] (03CR) 10jerkins-bot: [V: 04-1] Allow ResourceLoaderImage modules without data URIs [core] - 10https://gerrit.wikimedia.org/r/444142 (https://phabricator.wikimedia.org/T198930) (owner: 10Jdlrobson) [23:58:51] (03PS2) 10Jdlrobson: Remove unnecessary skins.minerva.base.styles [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/444137 [23:58:54] (03PS2) 10Jforrester: build: Upgrade eslint to 5.x [core] - 10https://gerrit.wikimedia.org/r/443750 [23:58:56] (03CR) 10jerkins-bot: [V: 04-1] Allow ResourceLoaderImage modules without data URIs [core] - 10https://gerrit.wikimedia.org/r/444142 (https://phabricator.wikimedia.org/T198930) (owner: 10Jdlrobson)