[00:21:05] [13cssjanus] 15Krinkle created 06site (+1 new commit): 02https://github.com/cssjanus/cssjanus/commit/5f5061b18f9b [00:21:06] 13cssjanus/06site 145f5061b 15Timo Tijhof: site: Remove now-redundant fake require() in index.html... [00:21:59] cssjanus/cssjanus#25 (site - 5f5061b Timo Tijhof): The build passed. - https://travis-ci.com/cssjanus/cssjanus/builds/78039030 [00:22:10] [13cssjanus] 15Krinkle opened pull request #67: site: Remove now-redundant fake require() in index.html (06master...06site) 02https://github.com/cssjanus/cssjanus/pull/67 [00:28:12] (03PS11) 10Cooltey: [READY] Prototype 1: Add floating queue element [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441516 (https://phabricator.wikimedia.org/T197811) [00:29:17] (03CR) 10jerkins-bot: [V: 04-1] [READY] Prototype 1: Add floating queue element [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441516 (https://phabricator.wikimedia.org/T197811) (owner: 10Cooltey) [00:32:48] (03CR) 10Krinkle: [C: 032] Add missing use statements [core] - 10https://gerrit.wikimedia.org/r/442367 (owner: 10Umherirrender) [00:35:36] (03PS12) 10Cooltey: [READY] Prototype 1: Add floating queue element [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441516 (https://phabricator.wikimedia.org/T197811) [00:40:29] (03CR) 10Krinkle: [C: 031] Document return of void in Maintenance::execute [core] - 10https://gerrit.wikimedia.org/r/441647 (owner: 10Umherirrender) [00:44:32] (03Merged) 10jenkins-bot: Add missing use statements [core] - 10https://gerrit.wikimedia.org/r/442367 (owner: 10Umherirrender) [00:47:13] (03CR) 10jenkins-bot: Add missing use statements [core] - 10https://gerrit.wikimedia.org/r/442367 (owner: 10Umherirrender) [00:49:45] (03CR) 10MusikAnimal: [C: 032] "Works! I checked for the bug that I saw when I tried to do this (basically the "unreviewed" filter was no longer sticky), and no bug was f" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442980 (https://phabricator.wikimedia.org/T198364) (owner: 10Mooeypoo) [00:54:59] (03Merged) 10jenkins-bot: Sanity-check NPP API filter values and add default [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442980 (https://phabricator.wikimedia.org/T198364) (owner: 10Mooeypoo) [00:55:53] 10Contributors-Analysis, 10Product-Analytics: Set up data infrastructure for program metrics - https://phabricator.wikimedia.org/T198776 (10Neil_P._Quinn_WMF) a:03Neil_P._Quinn_WMF [00:56:15] (03CR) 10jenkins-bot: Sanity-check NPP API filter values and add default [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442980 (https://phabricator.wikimedia.org/T198364) (owner: 10Mooeypoo) [01:00:27] (03CR) 10Huji: "This is not urgent, it can wait." [extensions/AbuseFilter] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/442162 (https://phabricator.wikimedia.org/T198182) (owner: 10Mikepipo) [01:00:40] (03Abandoned) 10Huji: Use content language for the revdel dropdown [extensions/AbuseFilter] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/442162 (https://phabricator.wikimedia.org/T198182) (owner: 10Mikepipo) [01:04:01] (03CR) 10Tim Starling: [C: 04-1] Migrate HistoryBlob to alternatives without PHP serialization (031 comment) [core] - 10https://gerrit.wikimedia.org/r/397632 (https://phabricator.wikimedia.org/T181555) (owner: 10Anomie) [01:08:53] (03CR) 10TerraCodes: [C: 04-1] Remove "viewmywatchlist" user right from anonymous users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) (owner: 10Eugene233) [01:49:44] (03CR) 10Prtksxna: [C: 032] "Thanks Bartosz" [core] - 10https://gerrit.wikimedia.org/r/443519 (owner: 10Bartosz Dziewoński) [01:57:01] (03CR) 10Krinkle: [C: 032] Fix PhanTypeMismatchDeclaredParam (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442201 (owner: 10Umherirrender) [01:57:26] (03CR) 10Krinkle: "Hm.. need conflict resolution." [core] - 10https://gerrit.wikimedia.org/r/442201 (owner: 10Umherirrender) [02:01:03] (03Merged) 10jenkins-bot: mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars [core] - 10https://gerrit.wikimedia.org/r/443519 (owner: 10Bartosz Dziewoński) [02:01:04] (03CR) 10jerkins-bot: [V: 04-1] Fix PhanTypeMismatchDeclaredParam [core] - 10https://gerrit.wikimedia.org/r/442201 (owner: 10Umherirrender) [02:03:41] (03CR) 10jenkins-bot: mw.Upload.BookletLayout: Update padding/margin to match OOUI to avoid scrollbars [core] - 10https://gerrit.wikimedia.org/r/443519 (owner: 10Bartosz Dziewoński) [02:10:53] (03CR) 10Samwilson: "> Patch Set 3: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/443206 (https://phabricator.wikimedia.org/T182377) (owner: 10Samwilson) [02:18:44] (03PS6) 10MaxSem: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 [02:20:43] 10MediaWiki-Platform-Team, 10Structured-Data-Commons, 10Wikidata, 10Epic, and 2 others: DB schema migration for MCR - https://phabricator.wikimedia.org/T174045 (10CCicalese_WMF) [02:24:43] (03CR) 10jerkins-bot: [V: 04-1] Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [02:36:54] (03PS1) 10Krinkle: Remove $wgBrowserBlacklist setting (deprecated, no-op) [core] - 10https://gerrit.wikimedia.org/r/443759 [02:37:50] (03PS7) 10MaxSem: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 [02:40:42] (03PS2) 10MaxSem: Get rid of call_user_func_array() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 [02:40:43] (03CR) 10MaxSem: Get rid of call_user_func_array() (031 comment) [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [02:43:50] (03CR) 10jerkins-bot: [V: 04-1] Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [02:49:49] (03PS25) 10Prtksxna: Special:Log: Convert to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) [02:51:04] (03CR) 10Prtksxna: Special:Log: Convert to HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [03:51:12] (03CR) 10Krinkle: [C: 032] Get rid of call_user_func_array() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [03:52:10] (03PS2) 10Krinkle: Add method visibilities and remove phpcs exclusion [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440653 (owner: 10Samwilson) [03:52:18] (03CR) 10Krinkle: [C: 032] Add method visibilities and remove phpcs exclusion [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440653 (owner: 10Samwilson) [03:58:20] (03Merged) 10jenkins-bot: Get rid of call_user_func_array() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [03:58:32] (03Merged) 10jenkins-bot: Add method visibilities and remove phpcs exclusion [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440653 (owner: 10Samwilson) [04:04:54] (03CR) 10jenkins-bot: Get rid of call_user_func_array() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [04:25:50] 10MediaWiki-Debug-Logger: Improve logging of MediaWiki DB errors - https://phabricator.wikimedia.org/T198750 (10jcrespo) Technically a different ticket, but very related T165675 [04:31:56] (03CR) 10Jcrespo: "I have never seen implicit joins being useful, and they are discouraged on any (my)SQL coding style guide as explicit ones are way more le" [core] - 10https://gerrit.wikimedia.org/r/443083 (https://phabricator.wikimedia.org/T198350) (owner: 10Daniel Kinzler) [04:46:23] (03PS4) 10Cicalese: Add support for VEForAll extension. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 [05:01:30] (03PS1) 10Dvogel hallowelt: Add icon class to AddNavLink [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/443765 [05:10:08] (03PS1) 10Cicalese: Fix PluggableAuthPopulateGroups to take affect for new users. [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/443768 (https://phabricator.wikimedia.org/T184736) [05:15:27] (03CR) 10MarkAHershberger: [C: 032] Fix PluggableAuthPopulateGroups to take affect for new users. [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/443768 (https://phabricator.wikimedia.org/T184736) (owner: 10Cicalese) [05:17:08] (03Merged) 10jenkins-bot: Fix PluggableAuthPopulateGroups to take affect for new users. [extensions/PluggableAuth] - 10https://gerrit.wikimedia.org/r/443768 (https://phabricator.wikimedia.org/T184736) (owner: 10Cicalese) [05:25:29] (03CR) 10tosfos: "Some nitpicks. Code works great!" (034 comments) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 (owner: 10Cicalese) [05:48:31] (03PS5) 10Cicalese: Add support for VEForAll extension. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 [06:01:04] (03PS6) 10Cicalese: Add support for VEForAll extension. [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 [06:03:15] (03CR) 10Cicalese: "> Patch Set 4:" (034 comments) [extensions/CommentStreams] - 10https://gerrit.wikimedia.org/r/437003 (owner: 10Cicalese) [06:04:36] (03PS1) 10Veeru: welcome to gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 [06:24:53] (03CR) 10Veeru: [C: 031] "its good to me" [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 (owner: 10Veeru) [06:30:18] (03PS2) 10Veeru: welcome to gerrit [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 [06:37:25] (03PS3) 10Veeru: welcome to gerrit repository [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 [06:43:01] (03Abandoned) 10Veeru: welcome to gerrit repository [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 (owner: 10Veeru) [06:51:04] (03CR) 10Mglaser: [C: 032] Add icon class to AddNavLink [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/443765 (owner: 10Dvogel hallowelt) [06:52:15] (03Merged) 10jenkins-bot: Add icon class to AddNavLink [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/443765 (owner: 10Dvogel hallowelt) [06:59:59] (03CR) 10Nikerabbit: "Simple query on codesearch shows that this would break a lot of things, including translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/443747 (owner: 10Jforrester) [07:06:54] (03PS2) 10Sebastian Berlin (WMSE): Update translator for Sveriges Radio to make it compatible with Citoid [services/zotero/translators] - 10https://gerrit.wikimedia.org/r/423675 (https://phabricator.wikimedia.org/T187023) [07:08:41] (03CR) 10Sebastian Berlin (WMSE): Update translator for Sveriges Radio to make it compatible with Citoid (031 comment) [services/zotero/translators] - 10https://gerrit.wikimedia.org/r/423675 (https://phabricator.wikimedia.org/T187023) (owner: 10Sebastian Berlin (WMSE)) [07:16:39] 10InternetArchiveBot: HTTP ERROR 500 - https://phabricator.wikimedia.org/T196677 (10Cirdan) [07:16:41] 10InternetArchiveBot: attempt to remove archive link using "Modify URL Data" tool results in HTTP 500 error - https://phabricator.wikimedia.org/T196814 (10Cirdan) [07:18:13] (03PS1) 10Matthias Mullie: Unload 3D adjustments when leaving 3D images in MMV [extensions/3D] - 10https://gerrit.wikimedia.org/r/443775 (https://phabricator.wikimedia.org/T198448) [07:21:01] (03PS1) 10Aaron Schulz: Fix CONCAT assertions in some MCR tests [core] - 10https://gerrit.wikimedia.org/r/443776 [07:25:28] (03PS1) 10Dvogel hallowelt: Remove old graphicalList implementation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443777 [07:28:26] (03PS1) 10ItSpiderman: Fix the Flyout [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443778 [07:41:59] (03PS3) 10Samwilson: Add button to add or remove all parameter fields [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) [07:42:05] (03CR) 10jerkins-bot: [V: 04-1] Add button to add or remove all parameter fields [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) (owner: 10Samwilson) [07:43:57] (03PS4) 10Samwilson: Add button to add or remove all parameter fields [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443040 (https://phabricator.wikimedia.org/T194436) [07:44:38] (03CR) 10Hashar: "recheck" [extensions/MintyDocs] - 10https://gerrit.wikimedia.org/r/443017 (owner: 10Yaron Koren) [08:12:01] (03PS1) 10KartikMistry: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/Babel] - 10https://gerrit.wikimedia.org/r/443784 (https://phabricator.wikimedia.org/T196220) [08:13:07] (03PS1) 10KartikMistry: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443786 (https://phabricator.wikimedia.org/T196220) [08:13:29] (03CR) 10Mobrovac: [V: 032 C: 032] Update translator for Sveriges Radio to make it compatible with Citoid [services/zotero/translators] - 10https://gerrit.wikimedia.org/r/423675 (https://phabricator.wikimedia.org/T187023) (owner: 10Sebastian Berlin (WMSE)) [08:13:49] (03PS1) 10KartikMistry: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) [08:19:54] (03CR) 10jerkins-bot: [V: 04-1] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [08:28:40] 10ContentTranslation, 10Language-2018-Apr-June, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)): Characters appear after a delay when typing in larget article translation - https://phabricator.wikimedia.org/T198459 (10Petar.petkovic) [08:40:05] 10Accessibility, 10OOUI (OOUI-0.27.5), 10Patch-For-Review: OOUI indexed dialogs / tabbed navigation is not accessible - https://phabricator.wikimedia.org/T148030 (10Volker_E) [08:40:49] 10Accessibility, 10OOUI (OOUI-0.27.5): OOUI indexed dialogs (IndexLayout) / tabbed navigation (TabPanelLayout) is not accessible - https://phabricator.wikimedia.org/T148030 (10Volker_E) a:03Volker_E [08:41:34] 10ContentTranslation, 10ContentTranslation-CXserver, 10Language-2018-July-September, 10Patch-For-Review: Matxin MT outputs the delimiters used in the MT client - https://phabricator.wikimedia.org/T198779 (10santhosh) p:05Triage>03Normal [09:02:50] (03CR) 10Nikerabbit: [C: 032] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/Babel] - 10https://gerrit.wikimedia.org/r/443784 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:03:11] (03CR) 10Nikerabbit: [C: 032] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443786 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:03:49] (03CR) 10Nikerabbit: "recheck" [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:07:26] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix CONCAT assertions in some MCR tests [core] - 10https://gerrit.wikimedia.org/r/443776 (owner: 10Aaron Schulz) [09:10:41] (03CR) 10jerkins-bot: [V: 04-1] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:15:07] (03Merged) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/Babel] - 10https://gerrit.wikimedia.org/r/443784 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:16:25] (03CR) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/Babel] - 10https://gerrit.wikimedia.org/r/443784 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:19:26] (03Merged) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443786 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:20:52] (03CR) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443786 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [09:21:29] 10MediaWiki-Categories: Allow filtering categories by namespace - https://phabricator.wikimedia.org/T197489 (10Dinoguy1000) [09:21:35] (03Merged) 10jenkins-bot: Fix CONCAT assertions in some MCR tests [core] - 10https://gerrit.wikimedia.org/r/443776 (owner: 10Aaron Schulz) [09:24:16] (03CR) 10jenkins-bot: Fix CONCAT assertions in some MCR tests [core] - 10https://gerrit.wikimedia.org/r/443776 (owner: 10Aaron Schulz) [09:26:58] 10MediaWiki-User-preferences, 10UI-Standardization: Special:Preferences-OOUI: distinguish titles and the values - https://phabricator.wikimedia.org/T194535 (10Volker_E) @Kaartic would you provide a closer insight in what is problematic to you? Even after revisiting, I really don't think that the position is pr... [09:30:51] (03PS1) 10Pwirth: Upgraded to BS3 ... [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443800 [10:03:29] (03PS8) 10Reedy: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [10:07:47] (03CR) 10Gehel: "Looks good for the part I understand. Minor comments inline." (033 comments) [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) (owner: 10DCausse) [10:08:16] (03CR) 10jerkins-bot: [V: 04-1] Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [10:12:45] (03CR) 10Ladsgroup: [C: 04-1] "I want to disagree about this. My point is about times that we switch a model from aggregated to non-aggregated. Then we'll have both sco" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443641 (owner: 10Sbisson) [10:14:23] (03PS9) 10Reedy: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [10:23:44] (03CR) 10jerkins-bot: [V: 04-1] Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [10:25:41] (03CR) 10Sbisson: "> I want to disagree about this. My point is about times that we" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443641 (owner: 10Sbisson) [10:26:03] (03PS10) 10Reedy: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [10:29:09] (03CR) 10WMDE-leszek: [C: 031] "Code looks fine. Tests could probably be structured/organized differently, but I am not going to bother you with discussion on personal pr" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/413891 (https://phabricator.wikimedia.org/T135155) (owner: 10Ladsgroup) [10:36:54] (03CR) 10VolkerE: [C: 031] Special:Log: Convert to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [10:40:07] 10WikimediaUI Style Guide: Color section: Make images and swatches clearer - https://phabricator.wikimedia.org/T167190 (10Pginer-WMF) I illustrated two proposals where the order of the colors is not altered: **A) Emphasise the 50s** An outer circle is used to emphasise the representative colors of each group (5... [11:28:17] (03CR) 10Ladsgroup: [C: 04-1] "> Patch Set 1:" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443641 (owner: 10Sbisson) [11:31:49] (03PS1) 10Nikerabbit: WIP: Testing tests [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443820 [11:36:20] 10Design, 10Move-Files-To-Commons, 10TCB-Team, 10WMDE-Design: Rename misleading "Submit" buttons on title/wikitext edit forms - https://phabricator.wikimedia.org/T198709 (10Charlie_WMDE) I think the difficulty with "preview" is that this label is already used for a specific functionality on wikis and here... [11:36:25] (03CR) 10jerkins-bot: [V: 04-1] WIP: Testing tests [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443820 (owner: 10Nikerabbit) [12:11:41] 10WikimediaUI Style Guide: Color section: Make images and swatches clearer - https://phabricator.wikimedia.org/T167190 (10Volker_E) …and a last one from me: A1) Increase 50s size slightly to provide (only) a subtle emphasis: {F23306894} [12:12:48] 10WikimediaUI Style Guide, 10Patch-For-Review: Color section: Make images and swatches clearer - https://phabricator.wikimedia.org/T167190 (10Volker_E) Patch is provided at https://github.com/wikimedia/WikimediaUI-Style-Guide/pull/129 [12:15:06] (03CR) 10Aklapper: "Veeru: Please read my last comment on https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/examples/+/443548/" [extensions/examples] - 10https://gerrit.wikimedia.org/r/443771 (owner: 10Veeru) [12:22:01] (03PS2) 10Nikerabbit: Enable CCFiltersOnly by default [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443820 [12:23:26] 10Multi-Content-Revisions (MCR Deployment): Set testwiki to use the new MCR-only schema - https://phabricator.wikimedia.org/T198558 (10daniel) [12:34:52] (03CR) 10KartikMistry: [C: 032] Enable CCFiltersOnly by default [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443820 (owner: 10Nikerabbit) [12:39:53] (03Merged) 10jenkins-bot: Enable CCFiltersOnly by default [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443820 (owner: 10Nikerabbit) [12:40:30] (03PS2) 10KartikMistry: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) [12:58:14] 10Design-Research, 10New-Editor-Experiences, 10Community-Liaisons (Jul-Sep 2018): Learn about new editors questions and challenges from mentors - https://phabricator.wikimedia.org/T197177 (10Trizek-WMF) [12:58:34] (03CR) 10Daniel Kinzler: [MCR] Make PageArchive aware of MCR (037 comments) [core] - 10https://gerrit.wikimedia.org/r/426009 (https://phabricator.wikimedia.org/T194015) (owner: 10Daniel Kinzler) [13:00:01] (03CR) 10Nikerabbit: [C: 032] Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [13:04:04] (03CR) 10DCausse: Add support for elastic 6.3.0 (033 comments) [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) (owner: 10DCausse) [13:04:11] (03PS5) 10DCausse: Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) [13:05:27] (03Merged) 10jenkins-bot: Downgrade mediawiki-codesniffer to 19 for MLEB extensions [extensions/CleanChanges] - 10https://gerrit.wikimedia.org/r/443788 (https://phabricator.wikimedia.org/T196220) (owner: 10KartikMistry) [13:10:41] 10Technical-Collaboration-Guidance: Conduct a Gather extension postmortem - https://phabricator.wikimedia.org/T130470 (10Qgil) [13:19:14] (03PS2) 10ItSpiderman: Filtering ES over SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 [13:19:27] (03Abandoned) 10Daniel Kinzler: Inject InterwikiLookup into ApiQuerySiteinfo [core] - 10https://gerrit.wikimedia.org/r/250151 (owner: 10Daniel Kinzler) [13:19:38] (03Abandoned) 10Daniel Kinzler: Conveniance function for positional parameters. [core] - 10https://gerrit.wikimedia.org/r/167405 (owner: 10Daniel Kinzler) [13:19:47] (03Abandoned) 10Daniel Kinzler: Provide parameters to HTML transclusion [WIP] [core] - 10https://gerrit.wikimedia.org/r/166400 (owner: 10Daniel Kinzler) [13:21:01] (03PS14) 10Daniel Kinzler: [MCR] [DNM] Set MCR migration stage to MIGRATION_WRITE_BOTH. [core] - 10https://gerrit.wikimedia.org/r/425519 (https://phabricator.wikimedia.org/T198563) [13:21:03] (03PS3) 10ItSpiderman: Changes to incorporate filterCfg modification and filter grouping [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 [13:24:46] (03CR) 10jerkins-bot: [V: 04-1] [MCR] [DNM] Set MCR migration stage to MIGRATION_WRITE_BOTH. [core] - 10https://gerrit.wikimedia.org/r/425519 (https://phabricator.wikimedia.org/T198563) (owner: 10Daniel Kinzler) [13:27:47] (03PS15) 10Daniel Kinzler: [MCR] Make PageArchive aware of MCR [core] - 10https://gerrit.wikimedia.org/r/426009 (https://phabricator.wikimedia.org/T194015) [13:33:30] (03PS4) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [13:34:43] 10Community-Engagement-Insights, 10Community-Relations, 10Goal: Review CE Insights results and future questions for Technical Collaboration - https://phabricator.wikimedia.org/T170516 (10Qgil) [13:36:23] (03PS15) 10Daniel Kinzler: [MCR] [DNM] Set MCR migration stage to MIGRATION_WRITE_BOTH. [core] - 10https://gerrit.wikimedia.org/r/425519 (https://phabricator.wikimedia.org/T198563) [13:38:14] (03PS16) 10Daniel Kinzler: [MCR] [DNM] Set MCR migration stage to write-both/read-old. [core] - 10https://gerrit.wikimedia.org/r/425519 (https://phabricator.wikimedia.org/T198563) [13:40:30] (03PS1) 10Daniel Kinzler: [MCR] [DNM] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) [13:42:10] (03PS2) 10Daniel Kinzler: Introduce makeCrossWikiKey(). [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) [13:42:35] (03PS5) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [13:43:16] 10Community-Relations, 10Developer-Relations: One place for Wikimedia technical support (discuss) - https://phabricator.wikimedia.org/T194951 (10Qgil) [13:46:52] (03PS1) 10Jack Phoenix: Implement a UserGetReservedNames hook subscriber to prevent users from registering the account called "Delete page script" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443833 [13:49:47] (03CR) 10jerkins-bot: [V: 04-1] [MCR] [DNM] Set MCR migration stage to write-both/read-new. [core] - 10https://gerrit.wikimedia.org/r/443831 (https://phabricator.wikimedia.org/T198561) (owner: 10Daniel Kinzler) [13:59:29] (03PS4) 10ItSpiderman: Changes to incorporate filterCfg modification and filter grouping [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 [14:01:40] (03CR) 10Mglaser: [C: 032] Fix the Flyout [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443778 (owner: 10ItSpiderman) [14:02:58] (03CR) 10Mglaser: [C: 031] "ok for me, waiting for i18n review" [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443800 (owner: 10Pwirth) [14:03:52] Technical Advice IRC meeting starting in 60 minutes in channel #wikimedia-tech, hosts: @chiborg & @amir1 - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:07:16] 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10Analytics, 10EventBus, and 4 others: ORESFetchScoreJob fails quite a lot - https://phabricator.wikimedia.org/T196076 (10Ladsgroup) hmm, yeah. I think we should make another phabricator ticket because that's about the ores service and not the extension wa... [14:13:09] (03Merged) 10jenkins-bot: Fix the Flyout [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443778 (owner: 10ItSpiderman) [14:15:06] 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Patch-For-Review, 10Readers-Web-Kanbanana-Board, 10Technical-Debt: Transition mw-node-qunit and resource-modules to wikimedia/ - https://phabricator.wikimedia.org/T197251 (10Niedzielski) Thanks @jhernandez. @jdlrobs... [14:17:18] 10Design, 10Move-Files-To-Commons, 10TCB-Team, 10WMDE-Design: Remove blue text color from buttons - https://phabricator.wikimedia.org/T198796 (10thiemowmde) [14:17:41] 10Design, 10Move-Files-To-Commons, 10TCB-Team, 10WMDE-Design: Remove blue text color from buttons - https://phabricator.wikimedia.org/T198796 (10thiemowmde) p:05Triage>03Low [14:27:47] (03CR) 10DCausse: [C: 032] OtherIndex support multiple clusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443009 (https://phabricator.wikimedia.org/T194678) (owner: 10EBernhardson) [14:40:15] 10MediaWiki-Page-editing, 10Commons, 10MobileFrontend, 10Readers-Web-Backlog, 10Mobile: Cannot enter talk page on mobile Commons site - https://phabricator.wikimedia.org/T198555 (10Niedzielski) [14:40:44] (03CR) 10Aaron Schulz: "Why not just use wiki ID qualified global keys via makeGlobalKey()? That also makes it a bit clearer that the key is intended to be global" [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [14:41:09] (03PS1) 10Jack Phoenix: Add hook handler for purging memcache keys when the relevant interface message page is edited [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/443839 (https://phabricator.wikimedia.org/T166943) [14:41:59] (03Merged) 10jenkins-bot: OtherIndex support multiple clusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443009 (https://phabricator.wikimedia.org/T194678) (owner: 10EBernhardson) [14:42:20] (03PS2) 10Jack Phoenix: Add hook handler for purging memcache keys when the relevant interface message page is edited [skins/Refreshed] - 10https://gerrit.wikimedia.org/r/443839 (https://phabricator.wikimedia.org/T166943) [14:43:15] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [14:43:39] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 (owner: 10ItSpiderman) [14:44:42] Technical Advice IRC meeting starting in 15 minutes in channel #wikimedia-tech, hosts: @chiborg & @amir1 - all questions welcome, more infos: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting [14:46:31] (03CR) 10Jack Phoenix: [C: 04-1] "I think you can safely remove these calls as the buildStats() method merely SELECTs data for output, it does not actually *touch* the data" [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/441609 (https://phabricator.wikimedia.org/T198023) (owner: 10Paladox) [14:48:30] (03PS3) 10Paladox: Remove begin/commit from buildStats [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/441609 (https://phabricator.wikimedia.org/T198023) [14:49:00] (03PS2) 10Paladox: Remove begin/commit from buildStats [extensions/AJAXPoll] (REL1_31) - 10https://gerrit.wikimedia.org/r/441610 (https://phabricator.wikimedia.org/T198023) [14:49:17] (03PS4) 10Paladox: Remove begin/commit from buildStats [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/441609 (https://phabricator.wikimedia.org/T198023) [14:50:41] 10MediaWiki-extensions-WikimediaIncubator, 10Release-Engineering-Team, 10Epic, 10I18n: Make creating a new Language project easier - https://phabricator.wikimedia.org/T165585 (10Amire80) [14:56:50] (03CR) 10jenkins-bot: OtherIndex support multiple clusters [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443009 (https://phabricator.wikimedia.org/T194678) (owner: 10EBernhardson) [14:59:24] (03Abandoned) 10Sbisson: Store prediction for aggregated scores [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443641 (owner: 10Sbisson) [15:09:33] (03CR) 10Jack Phoenix: [C: 032] Remove begin/commit from buildStats [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/441609 (https://phabricator.wikimedia.org/T198023) (owner: 10Paladox) [15:09:47] (03CR) 10Jack Phoenix: [C: 032] Remove begin/commit from buildStats [extensions/AJAXPoll] (REL1_31) - 10https://gerrit.wikimedia.org/r/441610 (https://phabricator.wikimedia.org/T198023) (owner: 10Paladox) [15:13:29] (03CR) 10Jack Phoenix: "Seems sane enough, but I'm not a guru when it comes to these things so I've added a few reviewers who should know better. :)" [extensions/Drafts] - 10https://gerrit.wikimedia.org/r/443128 (owner: 10ValeryanM) [15:15:52] (03Merged) 10jenkins-bot: Remove begin/commit from buildStats [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/441609 (https://phabricator.wikimedia.org/T198023) (owner: 10Paladox) [15:15:54] (03Merged) 10jenkins-bot: Remove begin/commit from buildStats [extensions/AJAXPoll] (REL1_31) - 10https://gerrit.wikimedia.org/r/441610 (https://phabricator.wikimedia.org/T198023) (owner: 10Paladox) [15:23:14] (03PS1) 10Daniel Kinzler: Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 [15:23:55] (03PS2) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [15:24:35] (03PS3) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [15:28:45] 10ContentTranslation, 10Language-2018-Apr-June: Every odd section has too small "Add translation" placeholder - https://phabricator.wikimedia.org/T198789 (10Pginer-WMF) [15:34:54] (03CR) 10jerkins-bot: [V: 04-1] Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [15:38:03] (03CR) 10jerkins-bot: [V: 04-1] Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) (owner: 10Daniel Kinzler) [15:39:22] (03CR) 10Daniel Kinzler: "> Why not just use wiki ID qualified global keys via makeGlobalKey()? That also makes it a bit clearer that the key is intended to be glob" [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [15:39:34] AaronSchulz: --^ [15:40:39] (03CR) 10Daniel Kinzler: "@aaron ...and yes, that's exactly what I started out with: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/443646/5/includes/Storage/Rev" [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [15:55:13] (03CR) 10Aaron Schulz: "If a key is not "global" then why do you need to access it from another wiki? To me, that means it is "global". In either case, you need t" [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [16:10:07] (03CR) 10Daniel Kinzler: "> If a key is not "global" then why do you need to access it from another wiki? To me, that means it is "global"." [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [16:10:14] AaronSchulz: --^ [16:12:20] (03CR) 10Aaron Schulz: Add support for extra database connections in unit tests. (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [16:13:05] (03CR) 10Aaron Schulz: "I do like the idea of being able to clone from the base connection/DB to more than one connection." [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [16:14:07] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Patch-For-Review: Provide a feature flagged way for logged in users to disable mobile optimisations - https://phabricator.wikimedia.org/T186760 (10ovasileva) [16:16:13] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Readers-Web-Kanbanana-Board: [Bug] Table of contents causes reflow - https://phabricator.wikimedia.org/T193517 (10alexhollender) Looks good on Safari desktop. https://en.m.wikipedia.beta.wmflabs.org/... [16:16:21] 10MobileFrontend, 10Readers-Web-Backlog, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Readers-Web-Kanbanana-Board: [Bug] Table of contents causes reflow - https://phabricator.wikimedia.org/T193517 (10alexhollender) a:05alexhollender>03ABorbaWMF [16:17:07] DanielK_WMDE: to me, I don't see much use in having two different categories of shared caches with "wikiID" in it. If it's a simple common-case "private per wiki" cache, then makeKey() is fine, if reads or purges are need cross-wiki, then it is "global" (with the wiki ID in it). Any concepts beyond that are things I'd rather leave to the calling code. WAN cache is already fairly complex as is. [16:19:12] it's horribly complex :) [16:20:45] AaronSchulz: the problem wit hthat is the boiler plate code needed for reliably getting a wiki ID that is actually a string, and not empty. [16:20:58] There seems to be no obvious and reliable way to do that [16:21:18] if LoadBalancer::getLocalDomainID() was guaranteed to return a string, this would be a lot easier. [16:21:25] per documentation, it is [16:21:32] but it doesn't [16:23:27] is there a task for that? [16:24:46] LB::getLocalDomainID() => DatabaseDomain::getID() => DD::convertToString() should always return a string [16:25:48] AaronSchulz: is it possible to do something via JobQueue to unblock T198156 ? [16:25:49] T198156: Server-side deletion of User:LorenzoMilano/sandbox - https://phabricator.wikimedia.org/T198156 [16:27:44] (03PS1) 10Jack Phoenix: Make documentation great again [core] - 10https://gerrit.wikimedia.org/r/443853 [16:31:26] 10MediaWiki-Page-editing, 10MinervaNeue, 10Readers-Web-Backlog, 10Mobile: Transcluded section edit links are broken in Minerva - https://phabricator.wikimedia.org/T198011 (10ovasileva) [16:33:35] 10WMSE-Exchange-of-Experiences-2018: Create WikiNEM template for Affiliate's profile - https://phabricator.wikimedia.org/T198804 (10SaraMortsell) [16:38:23] DanielK_WMDE: anyway, purely in terms of a convenience method for "make a key w/ default domain if null", I'd still be a tad weary that code written for global access (given domain IDs) would rely on WAN cache's default DB domain. In those cases, where code isn't simply hard-coding the current wiki in it's DB access (e.g. relying on LBFactory using its default domain), it seems less mistake-prone to be explicit. [16:45:13] AaronSchulz: ok, I make the callers use LoadBalancer::getLocalDomainID(), and you make it so that that always returns something?... [16:47:39] Possibly [16:49:19] (03PS1) 10Daimona Eaytoy: Apply PST when trying to determine if the edit will be saved [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443854 (https://phabricator.wikimedia.org/T198651) [16:50:36] (03PS2) 10Daniel Kinzler: Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 [16:50:51] (03PS4) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [16:52:38] (03PS5) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [16:52:55] (03Abandoned) 10Daniel Kinzler: Introduce makeCrossWikiKey(). [core] - 10https://gerrit.wikimedia.org/r/443653 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [16:53:07] (03PS6) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [16:53:31] (03CR) 10Robert Vogel: "Shouldn't this be implemented within BlueSpiceSMWConnector?" [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [16:53:56] (03CR) 10Robert Vogel: [C: 032] Remove old graphicalList implementation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443777 (owner: 10Dvogel hallowelt) [16:54:43] (03CR) 10Robert Vogel: "Oh, sorry, now seeing :)" [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [16:56:29] (03Merged) 10jenkins-bot: Remove old graphicalList implementation [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/443777 (owner: 10Dvogel hallowelt) [16:56:31] (03CR) 10Robert Vogel: [C: 04-1] Filtering ES over SMW properties (033 comments) [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 (owner: 10ItSpiderman) [16:57:37] (03CR) 10jerkins-bot: [V: 04-1] Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [17:01:14] (03PS7) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [17:04:43] (03CR) 10jerkins-bot: [V: 04-1] Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 (owner: 10Daniel Kinzler) [17:07:53] (03PS3) 10Daniel Kinzler: Add support for extra database connections in unit tests. [core] - 10https://gerrit.wikimedia.org/r/443841 [17:09:06] 10Design, 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog, and 4 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10alexhollender) a:05ovasileva>03alexhollender [17:09:54] (03CR) 10jerkins-bot: [V: 04-1] Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [17:14:11] (03CR) 10jerkins-bot: [V: 04-1] Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [17:15:56] (03PS8) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) [17:18:43] (03PS1) 10Kosta Harlan: WIP: Move HTML into Mustache templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443856 (https://phabricator.wikimedia.org/T198747) [17:25:05] (03CR) 10jerkins-bot: [V: 04-1] WIP: Move HTML into Mustache templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443856 (https://phabricator.wikimedia.org/T198747) (owner: 10Kosta Harlan) [17:25:28] (03CR) 10Kosta Harlan: "A few comments" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443856 (https://phabricator.wikimedia.org/T198747) (owner: 10Kosta Harlan) [17:35:47] (03PS2) 10Kosta Harlan: WIP: Move HTML into Mustache templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443856 (https://phabricator.wikimedia.org/T198747) [17:44:06] (03CR) 10Pmiazga: [C: 032] "The discussion happend and Tilman is happy with changes we're proposing, the task is ready to merge. There will be a follow-up work relate" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) (owner: 10Niedzielski) [17:57:57] (03PS1) 10Jack Phoenix: Swap Database#begin/commit to Database#startAtomic/endAtomic for MW 1.31+ compatibility [extensions/ChangeAuthor] - 10https://gerrit.wikimedia.org/r/443857 [18:37:09] (03PS3) 10Kosta Harlan: WIP: Move HTML into Mustache templates [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/443856 (https://phabricator.wikimedia.org/T198747) [18:38:37] (03CR) 10Aaron Schulz: Use consistent caching strategy in Revision storage classes (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [18:43:25] (03PS2) 10Niedzielski: Links should not be clickable in mobile page issue element [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/442996 (https://phabricator.wikimedia.org/T198115) [18:48:22] (03PS5) 10Niedzielski: Update: cancel unused HTTP requests in flight [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) [18:48:47] (03CR) 10Niedzielski: "This patchset required manual rebasing." [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) (owner: 10Niedzielski) [19:01:40] (03CR) 10Pmiazga: [V: 031 C: 032] Update: cancel unused HTTP requests in flight [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) (owner: 10Niedzielski) [19:10:00] (03Merged) 10jenkins-bot: Update: cancel unused HTTP requests in flight [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) (owner: 10Niedzielski) [19:11:17] (03CR) 10Niedzielski: [C: 04-1] Tie issues to sections (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443514 (https://phabricator.wikimedia.org/T197932) (owner: 10Jdlrobson) [19:11:24] (03CR) 10jenkins-bot: Update: cancel unused HTTP requests in flight [extensions/Popups] - 10https://gerrit.wikimedia.org/r/442755 (https://phabricator.wikimedia.org/T197700) (owner: 10Niedzielski) [19:14:22] (03PS1) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:18:58] (03CR) 10Daniel Kinzler: Use consistent caching strategy in Revision storage classes (032 comments) [core] - 10https://gerrit.wikimedia.org/r/443646 (https://phabricator.wikimedia.org/T198704) (owner: 10Daniel Kinzler) [19:22:59] (03PS2) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:26:01] 10Design, 10UI-Standardization, 10MinervaNeue, 10Readers-Web-Backlog, and 4 others: Differentiate between internal, interwiki and external links visually - https://phabricator.wikimedia.org/T190549 (10alexhollender) Reading through the comments here, as well the comments on T191405 and T178862 it seems lik... [19:30:17] (03PS3) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:37:03] (03CR) 10Reedy: "Changes to postgres not needed for page_props" [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [19:42:53] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) (owner: 10Reedy) [19:44:31] (03PS4) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:45:30] (03PS5) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:50:21] (03PS6) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [19:51:01] (03CR) 10Isarra: [C: 032] Don't render the "edit" button for Special: pages, they're not editable [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443122 (owner: 10Jack Phoenix) [19:51:26] (03CR) 10Isarra: [C: 032] Update the

generation code by copypasting it from Vector [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443123 (owner: 10Jack Phoenix) [19:51:30] (03CR) 10Isarra: [C: 032] Fix jQuery warning about .bind() being deprecated [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443121 (owner: 10Jack Phoenix) [19:56:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/443861 (owner: 10L10n-bot) [19:56:57] (03Merged) 10jenkins-bot: Fix jQuery warning about .bind() being deprecated [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443121 (owner: 10Jack Phoenix) [19:57:08] (03Merged) 10jenkins-bot: Don't render the "edit" button for Special: pages, they're not editable [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443122 (owner: 10Jack Phoenix) [19:57:34] (03Merged) 10jenkins-bot: Update the

generation code by copypasting it from Vector [skins/webplatform] - 10https://gerrit.wikimedia.org/r/443123 (owner: 10Jack Phoenix) [20:01:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443862 (owner: 10L10n-bot) [20:02:15] (03PS7) 10Reedy: [WIP] Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [20:02:40] apergos: Hello [20:02:45] d3r1ck: Hello [20:02:51] Dereckson: Hello [20:03:03] hey [20:03:12] 11 pm.. it's pretty late for me [20:03:21] I hope there is a d3r1ck who can take over [20:03:59] ok, sorry I wasn't able to make it before now [20:04:48] I just need one of my co-mentors to be able to handle the later shifts [20:04:59] I'm really pretty tired by now, even by 10 pm tbh [20:05:13] wait 3 more minutes and then start Iguess [20:05:27] ok [20:09:19] ding [20:09:29] let's get started, r054l13 d3r1ck Dereckson! [20:09:36] how is everyone today? [20:10:38] (03PS8) 10Reedy: Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [20:12:09] (03PS1) 10Robert Vogel: Expand last node of path [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443863 [20:12:53] I am fine [20:13:10] just had a tiring day, but am good :) [20:13:16] and you? [20:13:38] a very long annoying day [20:13:43] but fortunately it is coming to a close [20:14:00] how is your sleep? [20:14:12] It is good [20:14:42] excellent news! [20:15:07] how is work on the project coming along? [20:16:30] I created a virtuelenv on my pc and ran the bot, it gave these server hangup error [20:16:48] but when I installed the most recent version of npm it worked fine [20:16:52] good [20:17:06] at this point as long as it's working o your laptop that's all I care about [20:17:13] so what's next? [20:17:26] what does the reply script do now? [20:18:23] I will place the comons bot in that enviroment and work on it [20:18:24] the bot [20:18:27] i mentioned earlier in the NYPL clone please [20:18:59] I don't understand exactly, sorry? [20:20:43] you asked my to creat a diferent enviroment with recent versions of npm and node and then clone the NYPL code back and try to run it on that environment [20:21:19] that's what i did and it worked so i will use that to debug commons bot [20:24:06] ah so right now the NYPL bot is back to working [20:24:07] got it [20:24:17] so next is getting your emoji bot back to running [20:24:19] ok! [20:24:23] yes [20:24:43] do you have any questions or concerns or things you want to bring up tonight? [20:25:01] no nothing [20:26:09] ok, then I think we are good [20:26:14] so... [20:26:35] happy hacking! hope you get everything fixed up! [20:26:42] I just ran the emoji bot from the virtual env and the hang up error wasn't again [20:26:53] so I can proceed from there [20:26:54] thanks [20:27:47] ok! talk to you tomorrow then! [20:28:02] ok [21:13:58] 04(no projects): Please fix Pagebanner on PsWikivoyage - https://phabricator.wikimedia.org/T198818 (10Baloch007) [21:15:42] 10MediaWiki-JobQueue, 10MediaWiki-extensions-ORES, 10Analytics, 10EventBus, and 4 others: ORESFetchScoreJob fails quite a lot - https://phabricator.wikimedia.org/T196076 (10Ladsgroup) Made {T198819} [21:18:38] (03PS2) 10Jdrewniak: Reading depth hook should send additional sampling bucket parameter [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) [21:19:23] (03CR) 10Jdrewniak: [C: 04-1] Reading depth hook should send additional sampling bucket parameter (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) (owner: 10Jdrewniak) [21:31:51] (03PS9) 10Reedy: Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [21:38:15] 10MediaWiki-extensions-Babel, 10GlobalUserPage: In global user pages babel don't add user to a language category - https://phabricator.wikimedia.org/T198820 (10Stryn) [21:40:46] (03PS10) 10Reedy: Convert UNIQUE INDEX to PRIMARY KEY [core] - 10https://gerrit.wikimedia.org/r/443858 (https://phabricator.wikimedia.org/T198811) [21:43:20] (03PS2) 10Krinkle: Remove $wgBrowserBlacklist setting (deprecated, no-op) [core] - 10https://gerrit.wikimedia.org/r/443759 [21:54:19] (03CR) 10Mglaser: [C: 032] Expand last node of path [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443863 (owner: 10Robert Vogel) [21:58:51] (03PS1) 10Daimona Eaytoy: Two minor fixes to make code testable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443864 [22:00:35] (03Merged) 10jenkins-bot: Expand last node of path [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443863 (owner: 10Robert Vogel) [22:05:09] (03CR) 10Mglaser: [C: 032] Changes to incorporate filterCfg modification and filter grouping [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 (owner: 10ItSpiderman) [22:05:39] (03Merged) 10jenkins-bot: Changes to incorporate filterCfg modification and filter grouping [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 (owner: 10ItSpiderman) [22:06:38] (03CR) 10Krinkle: [C: 032] Limit the number of cached languages in MessageCache via MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/441842 (owner: 10Aaron Schulz) [22:08:00] (03PS2) 10Daimona Eaytoy: Two minor fixes to make code testable [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443864 [22:09:57] (03CR) 10Krinkle: [C: 04-1] rdbms: add IDatabase::lockForUpdate() convenience method (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443477 (owner: 10Aaron Schulz) [22:12:37] (03PS6) 10Florianschmidtwelzow: Change path to $IP when using extension-dir too [core] - 10https://gerrit.wikimedia.org/r/399219 [22:18:12] (03Merged) 10jenkins-bot: Limit the number of cached languages in MessageCache via MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/441842 (owner: 10Aaron Schulz) [22:20:50] (03CR) 10jenkins-bot: Limit the number of cached languages in MessageCache via MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/441842 (owner: 10Aaron Schulz) [22:23:12] (03PS7) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [22:25:20] (03PS8) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [22:35:19] (03PS4) 10Florianschmidtwelzow: registration: Use the correct key for skin dependencies [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) [22:35:28] (03CR) 10Florianschmidtwelzow: "PS4 is a automatic reformat of the code in IntelliJ :)" [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) (owner: 10Florianschmidtwelzow) [22:35:58] (03PS5) 10Florianschmidtwelzow: registration: Use the correct key for skin dependencies [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) [22:42:24] (03PS5) 10Florianschmidtwelzow: Add key conflict check to extension.json validation [core] - 10https://gerrit.wikimedia.org/r/333502 (https://phabricator.wikimedia.org/T153507) [22:45:24] (03PS10) 10Florianschmidtwelzow: Expose config array to ExtensionRegistry [core] - 10https://gerrit.wikimedia.org/r/331956 (https://phabricator.wikimedia.org/T155908) [22:46:08] (03CR) 10Florianschmidtwelzow: "PS10 is a rebase only." [core] - 10https://gerrit.wikimedia.org/r/331956 (https://phabricator.wikimedia.org/T155908) (owner: 10Florianschmidtwelzow) [22:48:49] (03PS1) 10Awight: Remove outdated transition code [core] - 10https://gerrit.wikimedia.org/r/443867 [22:50:24] (03CR) 10jerkins-bot: [V: 04-1] Add key conflict check to extension.json validation [core] - 10https://gerrit.wikimedia.org/r/333502 (https://phabricator.wikimedia.org/T153507) (owner: 10Florianschmidtwelzow) [22:51:31] (03PS23) 10Florianschmidtwelzow: Config: Add new ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327312 [22:52:04] (03CR) 10Florianschmidtwelzow: "PS23 is a rebase and changes the version number of ConfigRepository from 1.29 to 1.32." [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [22:52:13] (03PS21) 10Florianschmidtwelzow: ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 [22:55:44] (03CR) 10jerkins-bot: [V: 04-1] ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [22:58:53] (03PS10) 10Florianschmidtwelzow: Config: Add new special page Special:Configurations to view configs [core] - 10https://gerrit.wikimedia.org/r/327314 [23:02:15] (03CR) 10jerkins-bot: [V: 04-1] Config: Add new special page Special:Configurations to view configs [core] - 10https://gerrit.wikimedia.org/r/327314 (owner: 10Florianschmidtwelzow) [23:02:25] (03CR) 10jerkins-bot: [V: 04-1] ConfigRepository: Add extension configurations [core] - 10https://gerrit.wikimedia.org/r/327313 (owner: 10Florianschmidtwelzow) [23:05:29] (03CR) 10jerkins-bot: [V: 04-1] Config: Add new ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [23:05:40] (03CR) 10jerkins-bot: [V: 04-1] Config: Add new ConfigRepository [core] - 10https://gerrit.wikimedia.org/r/327312 (owner: 10Florianschmidtwelzow) [23:05:53] (03CR) 10Reedy: "Why is it needed?" [extensions/Push] - 10https://gerrit.wikimedia.org/r/441492 (owner: 10Reedy) [23:12:03] (03CR) 10jerkins-bot: [V: 04-1] Config: Add new special page Special:Configurations to view configs [core] - 10https://gerrit.wikimedia.org/r/327314 (owner: 10Florianschmidtwelzow)