[00:00:57] (03PS10) 10Cooltey: [WIP] Prototype 1: Add floating queue element [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441516 (https://phabricator.wikimedia.org/T197811) [00:15:06] (03PS1) 10Jdlrobson: Lead paragraph transform should not log if the page is already mobile friendly [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443523 (https://phabricator.wikimedia.org/T196767) [00:17:50] 10Page-Previews: Extension:Popups should allow for enabling/disabling on arbitrary namespaces - https://phabricator.wikimedia.org/T198637 (10Jdlrobson) [00:18:42] (03CR) 10Samwilson: "recheck" [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442777 (https://phabricator.wikimedia.org/T196181) (owner: 10Samwilson) [00:18:49] 10Design, 10MediaWiki-Interface, 10UI-Standardization, 10WMF-Design, and 4 others: Mobile should equip blockquote with language dependent quotation marks - https://phabricator.wikimedia.org/T114885 (10Krinkle) [00:18:54] 10MediaWiki-ResourceLoader, 10Performance-Team, 10I18n: Allow styles to be language-dependent - https://phabricator.wikimedia.org/T101936 (10Krinkle) 05Open>03declined Declining for now. The use case for MonoBook is interesting, but I don't think it justifies the development and maintenance of an additio... [00:19:36] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech, 10Security-Reviews: Security review for TemplateWizard extension - https://phabricator.wikimedia.org/T198666 (10Niharika) p:05Triage>03Normal [00:23:33] (03CR) 10jerkins-bot: [V: 04-1] Add maintenance script to backfull Draft NS pages in the triage queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442777 (https://phabricator.wikimedia.org/T196181) (owner: 10Samwilson) [00:40:06] 10MediaWiki-extensions-WikibaseRepository, 10Mobile-Content-Service, 10Page-Previews, 10Reading-Infrastructure-Team-Backlog, and 8 others: Page previews for Wikidata - https://phabricator.wikimedia.org/T111231 (10Jdlrobson) Happy to chat through this. No rush. Please let me know if you would like me to att... [00:41:33] (03CR) 10Jdlrobson: [C: 04-1] Recreate Babel tower to div block instead of table (031 comment) [extensions/Babel] - 10https://gerrit.wikimedia.org/r/442816 (https://phabricator.wikimedia.org/T198382) (owner: 10Iniquity) [00:54:20] (03PS1) 10Krinkle: Remove redundant 'return true' from hooks that are not abortable [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/443524 [00:55:12] (03CR) 10jerkins-bot: [V: 04-1] Remove redundant 'return true' from hooks that are not abortable [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/443524 (owner: 10Krinkle) [00:55:57] (03CR) 10Tim Starling: RESTBagOStuff: improve timeouts and logging (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440519 (owner: 10Tim Starling) [01:05:04] (03PS1) 10Krinkle: resourceloader: Simplify ResourceLoader::isFileModule() [core] - 10https://gerrit.wikimedia.org/r/443525 [01:05:55] (03Abandoned) 10Krinkle: Revert "Localisation updates from https://translatewiki.net." [core] - 10https://gerrit.wikimedia.org/r/443341 (owner: 10Krinkle) [01:11:21] (03PS1) 10Catrope: ScoreStorage: Move $modelsToClean parameter up to the interface [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443526 [01:11:48] (03CR) 10Catrope: "This is very much a suggestion that I don't feel strongly about, feel free to decline :)" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443526 (owner: 10Catrope) [01:13:28] (03PS1) 10Krinkle: build: Set Travis conf to "allow failure" for long-failing builds [core] - 10https://gerrit.wikimedia.org/r/443527 [01:13:52] (03CR) 10Krinkle: "Example of this running at https://travis-ci.org/Krinkle/mediawiki/builds/399386991 (to validate the allow_failures syntax)." [core] - 10https://gerrit.wikimedia.org/r/443527 (owner: 10Krinkle) [01:25:17] Krinkle/mediawiki#11 (travis-ci/allow - ee5eb48 Timo Tijhof): The build passed. - https://travis-ci.org/Krinkle/mediawiki/builds/399386991 [01:34:00] Krinkle/mediawiki#11 (travis-ci/allow - ee5eb48 Timo Tijhof): The build passed. - https://travis-ci.org/Krinkle/mediawiki/builds/399386991 [01:36:55] (03CR) 10Krinkle: NotificationMapper: Use batching in deleteByUserEventOffset() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/442982 (owner: 10Catrope) [01:53:49] (03PS4) 10Kosta Harlan: WIP: Watchlist/RecentChanges: Load chrome and filters, then data [core] - 10https://gerrit.wikimedia.org/r/443233 (https://phabricator.wikimedia.org/T198539) [01:58:41] (03CR) 10Kosta Harlan: "> Patch Set 3: Code-Review-1" [core] - 10https://gerrit.wikimedia.org/r/443233 (https://phabricator.wikimedia.org/T198539) (owner: 10Kosta Harlan) [01:59:07] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: [hhvm] MemcachedPeclBagOStuff.php: Error at offset 0 of 6 bytes - https://phabricator.wikimedia.org/T73461 (10Krinkle) [02:00:09] (03CR) 10jerkins-bot: [V: 04-1] WIP: Watchlist/RecentChanges: Load chrome and filters, then data [core] - 10https://gerrit.wikimedia.org/r/443233 (https://phabricator.wikimedia.org/T198539) (owner: 10Kosta Harlan) [02:33:51] (03CR) 10Prtksxna: [C: 031] "Could you add a comment about the new number?" [core] - 10https://gerrit.wikimedia.org/r/443519 (owner: 10Bartosz Dziewoński) [02:34:22] (03PS1) 10Krinkle: API: Fix siteinfo/rightsinfo output when wgRightsPage is used [core] - 10https://gerrit.wikimedia.org/r/443528 [02:36:54] (03PS2) 10Krinkle: API: Fix siteinfo/rightsinfo output when wgRightsPage is used [core] - 10https://gerrit.wikimedia.org/r/443528 [02:54:50] (03CR) 10Samwilson: Add an API module to read global prefs/local overrides (031 comment) [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/442983 (https://phabricator.wikimedia.org/T197259) (owner: 10MaxSem) [03:07:12] (03CR) 10MaxSem: Add an API module to read global prefs/local overrides (031 comment) [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/442983 (https://phabricator.wikimedia.org/T197259) (owner: 10MaxSem) [03:45:21] 10Phabricator, 10Cleanup: Vandalism on Phabricator: Undo changes made (2018-07-01) - https://phabricator.wikimedia.org/T198552 (10MusikAnimal) The bot has re-ran through most if not all tasks and restored the triage level. In the process it fixed a few other things (missing tags, subscribers, etc.) that the bo... [03:55:49] (03PS1) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [04:00:59] (03PS2) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [04:04:00] (03CR) 10Samwilson: [C: 04-1] "This looks good and works in my testing. The only thing I see wrong is that array-type preferences (i.e. `email-blacklist` and `echo-notif" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/442983 (https://phabricator.wikimedia.org/T197259) (owner: 10MaxSem) [04:07:06] (03PS3) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) [04:08:10] (03PS23) 10Prtksxna: Special:Log: Convert to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) [04:09:18] (03CR) 10Prtksxna: "Please review Iba3c6aa5ac40dcdee0792c2d045b238b02d76521. It makes some changes to this too." [core] - 10https://gerrit.wikimedia.org/r/438244 (https://phabricator.wikimedia.org/T194616) (owner: 10Matěj Suchánek) [04:10:08] (03CR) 10MaxSem: Add SpecialBlockTest to test SpecialBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [04:12:25] (03CR) 10Prtksxna: Special:NewPages: Change to use OOUI (031 comment) [core] - 10https://gerrit.wikimedia.org/r/276946 (https://phabricator.wikimedia.org/T117739) (owner: 10Pankajeshkr) [04:13:39] (03CR) 10Dbarratt: Add SpecialBlockTest to test SpecialBlock (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443536 (https://phabricator.wikimedia.org/T194301) (owner: 10Dbarratt) [04:19:41] 10Developer-Relations: Suggested improvements to annoying little bugs page - https://phabricator.wikimedia.org/T194556 (10srishakatux) >>! In T194556#4392802, @srishakatux wrote: > Copying @Aklapper comments from https://www.mediawiki.org/wiki/User:SSethi_(WMF)/Sandbox/Suggested_improvements_to_annoying_little_b... [04:27:38] 10Developer-Relations: Organize a developer workshop for university students in India at the end of 2018 or beginning of 2019 - https://phabricator.wikimedia.org/T183187 (10srishakatux) a:05srishakatux>03None [04:31:51] Krinkle: Is there a reason why oojs uses "oo" internally but exposes "OO"? [04:32:20] Asking because its causing some linking issues in https://gerrit.wikimedia.org/r/#/c/oojs/core/+/405544/ [04:32:57] prtksxna: All @class and @link should use OO. The local variable shouldn't be used. [04:33:12] If one of them is defined as oo, that would be the cause of the bug. [04:33:20] Where exactly is it going wrong? [04:34:42] The reason for the difference is mainly just to differentiate between the local and public object reference, but we can remove that difference. [04:35:13] Krinkle: For some reason, that I am yet to understand, JSDoc creates the links using the lowercase "oo" [04:35:28] However neither jsduck or jsdoc should be looking at that name, given it is always given explicitly everywhere, so not sure [04:35:41] Krinkle: So, like - file:///Users/psaxena/wmf/core/docs/oo.EmitterList.html, and because of that other links get messed up [04:35:49] prtksxna: Hm.. can you see if this is one link in particular? I guess most are working fine. [04:36:01] Krinkle: Yup, it shouldn't be, especially when we are mentioning it in @class [04:37:19] Krinkle: I just pushed to that patch, if you run 'grunt doc', you'll get - https://phabricator.wikimedia.org/P7324 [04:40:24] It might be happening because we aren't passing anything to @constructor (which is an alias to @class) in EmitterList [04:41:10] Yep, that was it, will fix :D [04:41:11] Thanks [04:42:48] (03PS3) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [04:48:06] prtksxna: Ha, I wasn't quite there yet, but I did notice that on the generated docs the classes have no prefix [04:48:11] e.g. "Class: EventEmitter" [04:48:23] with "OO.EventEmitter" only used as description paragraph [04:48:31] realised it when changing to "foobar_EventEmitter" [04:49:04] But yeah, removing @constructor fixes it [04:49:05] Nice catch [04:49:45] Krinkle: Now we have some issues with the method names though, they aren't 'attaching' themselves to the class. Hoping they don't all need a @method thing now… [04:50:51] Hm.. yeah, it is odd that is suddenly stopped parsing the methods [04:51:20] Krinkle: Yeah, adding " * @method OO.SortedEmitterList.onItemSortChange" for example makes it show up [04:51:39] Right, but it clearly has the ability to automatically do that, which worked until @constructor was removed [04:51:58] Because they were all on lowercase "oo", I suppose [04:52:23] We'll have to explicitly name all properties too, we already do that with events iirc [04:55:47] Krinkle: Would it be better to make everything OO? [05:00:58] prtksxna: Yeah, let's do that. [05:01:08] Also found a few other issues and fixed them locally. But will comment instead. [05:01:19] Krinkle: Cool, will make a separate patch for that [05:02:55] (03PS1) 10Mooeypoo: Add quickfixes for RTL alignment [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) [05:04:31] prtksxna: CC me and I'll get it merged. [05:04:39] * prtksxna nods [05:05:48] (03PS1) 10Mooeypoo: Add @cfg documentation [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443540 [05:18:15] [13cssjanus] 15Krinkle created 06build (+2 new commits): 02https://github.com/cssjanus/cssjanus/compare/8e6a5b7aea2d^...28c615a8f8e1 [05:18:15] 13cssjanus/06build 148e6a5b7 15Timo Tijhof: build: Require Node 6 (drop Node 4 support)... [05:18:15] 13cssjanus/06build 1428c615a 15Timo Tijhof: build: Bump devDependencies... [05:18:53] [13cssjanus] 15Krinkle opened pull request #64: Require Node 6 & build dev dependencies (06master...06build) 02https://github.com/cssjanus/cssjanus/pull/64 [05:19:08] cssjanus/cssjanus#16 (build - 28c615a Timo Tijhof): The build passed. - https://travis-ci.com/cssjanus/cssjanus/builds/77930489 [05:22:35] (03PS1) 10Mooeypoo: Decouple dialog and template form and use events instead [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443543 [05:24:24] (03PS2) 10Mooeypoo: Decouple dialog and template form and use events instead [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443543 [05:29:11] (03CR) 10Tim Starling: [C: 032] rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR [core] - 10https://gerrit.wikimedia.org/r/437866 (owner: 10Aaron Schulz) [05:32:19] (03CR) 10Samwilson: [C: 032] "So that's what that's for! Thanks. :) I added to https://www.mediawiki.org/wiki/Manual:Coding_conventions/JavaScript#Tags" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443540 (owner: 10Mooeypoo) [05:40:08] (03Merged) 10jenkins-bot: rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR [core] - 10https://gerrit.wikimedia.org/r/437866 (owner: 10Aaron Schulz) [05:40:10] (03Merged) 10jenkins-bot: Add @cfg documentation [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443540 (owner: 10Mooeypoo) [05:42:56] (03CR) 10jenkins-bot: rdbms: fix Sqlite::tableExists() method to avoid STATUS_TRX_ERROR [core] - 10https://gerrit.wikimedia.org/r/437866 (owner: 10Aaron Schulz) [06:02:44] (03PS3) 10ItSpiderman: Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 [06:07:43] (03CR) 10ItSpiderman: [C: 032] "I was wondering about why not all fields names filled by the PrimaryDataProvider are made into constants, but i guess its ok since they wo" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 (owner: 10Dvogel hallowelt) [06:08:24] (03PS4) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [06:11:23] (03PS5) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [06:29:51] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [06:32:01] (03CR) 10jerkins-bot: [V: 04-1] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [06:34:54] (03CR) 10Raimond Spekking: [C: 031] "18n review" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/443503 (https://phabricator.wikimedia.org/T196104) (owner: 10Bartosz Dziewoński) [06:39:02] (03CR) 10Samwilson: "I'm still e.g. getting right-aligned English text in an Arabic wiki with the user language set to English (and left-aligned Arabic in an E" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) (owner: 10Mooeypoo) [06:47:40] (03PS1) 10Veeru: adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 [06:47:42] (03CR) 10Welcome, new contributor!: "Thank you for making your first contribution to Wikimedia! :) To learn how to get your code changes reviewed faster and more likely to get" [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 (owner: 10Veeru) [06:50:15] 10MediaWiki-Internationalization, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), 10Wikimedia-log-errors: Attempting to edit MediaWiki.org page produces PHP fatal error: Call to undefined method LanguageCode::getCode() - https://phabricator.wikimedia.org/T198518 (10Nikerabbit) 05Open>03Re... [06:54:57] (03PS1) 10Cicalese: Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 [06:55:47] (03CR) 10jerkins-bot: [V: 04-1] Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 (owner: 10Cicalese) [06:56:06] (03PS2) 10Veeru: adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 [06:56:13] (03CR) 10jerkins-bot: [V: 04-1] adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 (owner: 10Veeru) [06:57:07] (03PS3) 10Veeru: adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 [06:57:12] (03PS2) 10Cicalese: Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 [06:58:34] (03CR) 10jerkins-bot: [V: 04-1] Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 (owner: 10Cicalese) [07:00:45] 10ContentTranslation, 10Language-2018-Apr-June: CX2: Content isn't properly divided into sections - https://phabricator.wikimedia.org/T191124 (10Petar.petkovic) [07:02:24] (03PS3) 10Cicalese: Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 [07:03:44] (03CR) 10Veeru: [C: 031] adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 (owner: 10Veeru) [07:09:24] (03PS4) 10Cicalese: Streamlined code and improved error handling. [extensions/VEForAll] - 10https://gerrit.wikimedia.org/r/443552 [07:12:13] (03CR) 10Mooeypoo: [C: 04-2] "> I'm still e.g. getting right-aligned English text in an Arabic wiki" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) (owner: 10Mooeypoo) [07:15:51] (03CR) 10Samwilson: "Yeah, that's how I was testing it: with a template description in a language that doesn't match either the content or the user language. A" [extensions/TemplateWizard] - 10https://gerrit.wikimedia.org/r/443539 (https://phabricator.wikimedia.org/T193262) (owner: 10Mooeypoo) [07:17:37] (03PS1) 10ItSpiderman: Add categories and templates to graphical list [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443556 [07:20:11] (03Abandoned) 10Aklapper: adding newthings [extensions/examples] - 10https://gerrit.wikimedia.org/r/443548 (owner: 10Veeru) [07:21:54] 10Connected-Open-Heritage-Wikidata-migration, 10WMSE-Project-leftovers: Create a checklist of things to do before importing a dataset - https://phabricator.wikimedia.org/T156889 (10Lokal_Profil) [07:22:45] 10MediaWiki Language Extension Bundle: [MLEB] Sign releases - https://phabricator.wikimedia.org/T49005 (10Nikerabbit) [07:24:30] (03PS4) 10ItSpiderman: Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 [07:26:38] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Change border of radio button outline when selected (No. 6) - https://phabricator.wikimedia.org/T195720 (10Lea_WMDE) [07:26:42] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Allow to select versions of the diff - https://phabricator.wikimedia.org/T198212 (10Lea_WMDE) [07:37:11] (03PS1) 10ItSpiderman: Fixes for strict php [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/443561 [07:38:15] (03CR) 10Mglaser: [C: 032] Fixes for strict php [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/443561 (owner: 10ItSpiderman) [07:38:22] (03CR) 10Matěj Suchánek: [C: 04-1] Special:Log: Convert to HTMLForm (037 comments) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [07:38:32] 10Design, 10TCB-Team, 10Two-Column-Edit-Conflict-Merge, 10WMDE-Design, 10WMDE-QWERTY-Team: Save version consisting of selected lines - https://phabricator.wikimedia.org/T198213 (10Lea_WMDE) [07:38:44] (03Merged) 10jenkins-bot: Fixes for strict php [extensions/BlueSpiceEchoConnector] - 10https://gerrit.wikimedia.org/r/443561 (owner: 10ItSpiderman) [07:39:04] (03CR) 10Mglaser: [C: 032] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [07:40:11] 10MediaWiki Language Extension Bundle, 10Language-2018-July-September: MediaWiki Language Extension Bundle - 2018.07 - https://phabricator.wikimedia.org/T198678 (10Arrbee) [07:41:03] (03CR) 10jerkins-bot: [V: 04-1] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [07:41:51] (03CR) 10Mglaser: [C: 031] "Looks good, waiting for i18n review" [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443556 (owner: 10ItSpiderman) [07:42:39] (03CR) 10Iniquity: Recreate Babel tower to div block instead of table (031 comment) [extensions/Babel] - 10https://gerrit.wikimedia.org/r/442816 (https://phabricator.wikimedia.org/T198382) (owner: 10Iniquity) [07:42:46] (03CR) 10WMDE-leszek: [C: 032] Add MediaWikiService::getPerDbNameStatsdDataFactory [core] - 10https://gerrit.wikimedia.org/r/443467 (https://phabricator.wikimedia.org/T196609) (owner: 10Addshore) [07:43:32] (03CR) 10Iniquity: Recreate Babel tower to div block instead of table (031 comment) [extensions/Babel] - 10https://gerrit.wikimedia.org/r/442816 (https://phabricator.wikimedia.org/T198382) (owner: 10Iniquity) [07:46:24] (03PS1) 10Robert Vogel: Fix composer package name [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443563 [07:47:33] 10MediaWiki Language Extension Bundle: [MLEB] Sign releases - https://phabricator.wikimedia.org/T49005 (10KartikMistry) a:03KartikMistry [07:48:27] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443556 (owner: 10ItSpiderman) [07:49:51] (03PS1) 10ItSpiderman: Swith Special:SearchAdmin to single backend mode [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 [07:50:17] (03CR) 10Prtksxna: "Thanks for looking at this Matěj!" [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [07:52:41] (03PS2) 10Robert Vogel: Fix composer package name [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443563 [07:54:00] 10WMSE-Organisational-Development-2018: Investigate switching internal mailing list over to GSuite group - https://phabricator.wikimedia.org/T198679 (10Lokal_Profil) I've added a quick initial analysis. It would be good with more usage scenarios which we could compare. @Historiker If the board has any special n... [07:54:41] 10Wikimedia-Planet: URL incorrect in link element - https://phabricator.wikimedia.org/T198680 (10Samwilson) [07:54:59] 10WMSE-Organisational-Development-2018: Investigate switching internal mailing list over to GSuite group - https://phabricator.wikimedia.org/T198679 (10Lokal_Profil) [07:56:29] 10MediaWiki-extensions-Translate, 10Discovery, 10Discovery-Search, 10Elasticsearch, and 2 others: TTMServer performance and coverage issues - https://phabricator.wikimedia.org/T101236 (10dcausse) [07:57:04] 10MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), 10Data-Services, 10Patch-For-Review: Create views for the schema change for refactored actor storage - https://phabricator.wikimedia.org/T195747 (10Marostegui) The `img_actor` column isn't present on the masters yet (T187089) as that is blocked on the DC fail... [07:58:43] (03Merged) 10jenkins-bot: Add MediaWikiService::getPerDbNameStatsdDataFactory [core] - 10https://gerrit.wikimedia.org/r/443467 (https://phabricator.wikimedia.org/T196609) (owner: 10Addshore) [08:01:13] (03CR) 10jenkins-bot: Add MediaWikiService::getPerDbNameStatsdDataFactory [core] - 10https://gerrit.wikimedia.org/r/443467 (https://phabricator.wikimedia.org/T196609) (owner: 10Addshore) [08:04:45] (03PS1) 10Robert Vogel: bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 [08:06:11] 10WMSE-Project-leftovers, 10WMSE-WFD-data-to-Wikidata-2016: [wfd] Connect the CA back to the RBD - https://phabricator.wikimedia.org/T168174 (10Lokal_Profil) [08:07:01] (03CR) 10jerkins-bot: [V: 04-1] bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [08:07:26] 10WMSE-Project-leftovers, 10WMSE-WFD-data-to-Wikidata-2016: Handle measurement/data collection dates (WFD) - https://phabricator.wikimedia.org/T167660 (10Lokal_Profil) [08:07:45] (03PS6) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [08:16:28] (03PS7) 10Sharvaniharan: [WIP] Merge page activity to main activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441938 (https://phabricator.wikimedia.org/T197703) [08:16:41] (03PS6) 10Fomafix: Force type Language for $lang of DifferenceEngine::setTextLanguage [core] - 10https://gerrit.wikimedia.org/r/441098 [08:21:58] (03PS7) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [08:29:35] (03PS2) 10Mglaser: Switch Special:SearchAdmin to single backend mode [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 (owner: 10ItSpiderman) [08:30:44] (03CR) 10Mglaser: [C: 031] "Looks good, waiting for i18n" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 (owner: 10ItSpiderman) [08:31:05] (03PS1) 10Jdrewniak: WIP: Reading depth hook should send additional sampling bucket parameter [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) [08:35:56] 10Phabricator: Create more Phabricator administrators - https://phabricator.wikimedia.org/T198578 (10Aklapper) 05Open>03declined >>! In T198578#4375222, @zhuyifei1999 wrote: > Redundant to T198576? Yes, I'd say so. (If other functionality apart from disabling user accounts was the intention to create this t... [08:36:19] 10WMSE-Organisational-Development-2018: Improve script sharing/discoverability in Drive - https://phabricator.wikimedia.org/T198684 (10Lokal_Profil) [08:36:39] (03PS5) 10ItSpiderman: Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 [08:41:22] 10WMSE-Organisational-Development-2018: Improve script sharing/discoverability in Drive - https://phabricator.wikimedia.org/T198684 (10Lokal_Profil) Of course scripts can also be published on e.g. gist but that serves more of a back-up purpose than anything else. The background to this was me discovering that w... [08:41:40] 10WMSE-Organisational-Development-2018: Improve script sharing/discoverability in Drive/GSuite - https://phabricator.wikimedia.org/T198684 (10Lokal_Profil) [08:45:01] (03PS1) 10ItSpiderman: Adapt to switch to single backend in ES [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443571 [08:46:55] (03CR) 10Mglaser: [C: 032] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [08:48:13] (03CR) 10Fomafix: Ensure LanguageCode::bcp47() returns a valid BCP 47 language code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/442200 (https://phabricator.wikimedia.org/T34483) (owner: 10C. Scott Ananian) [08:48:28] 10Page-Previews, 10Readers-Web-Backlog (Tracking): Extension:Popups could allow for enabling/disabling on arbitrary namespaces - https://phabricator.wikimedia.org/T198637 (10ovasileva) p:05Triage>03Low [08:48:51] (03CR) 10Jdrewniak: [C: 04-1] WIP: Reading depth hook should send additional sampling bucket parameter (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) (owner: 10Jdrewniak) [08:49:17] (03CR) 10jerkins-bot: [V: 04-1] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [08:50:53] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Wikidata-Campsite: Remove ratelimit from Wikidata - https://phabricator.wikimedia.org/T198396 (10Ladsgroup) >>! In T198396#4391279, @Addshore wrote: > Marking as stalled as we don't quite want to do this yet.. AFAIK right now we haven't turned our maxl... [09:02:55] (03PS6) 10ItSpiderman: Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 [09:04:33] (03PS8) 10Sharvaniharan: [WIP] Merge page activity to main activity [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/441938 (https://phabricator.wikimedia.org/T197703) [09:09:37] (03CR) 10MarcoAurelio: Convert BreadCrumbs2 to use extension registration (032 comments) [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/440170 (https://phabricator.wikimedia.org/T197154) (owner: 10MarcoAurelio) [09:10:51] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 (owner: 10ItSpiderman) [09:12:08] 10MediaWiki-ResourceLoader, 10Performance-Team, 10I18n: Allow styles to be language-dependent - https://phabricator.wikimedia.org/T101936 (10Tgr) >>! In T101936#4392336, @Krinkle wrote: > Its use case in a nut shell: There are anchor links in MonoBook's output HTML with an interface label that is stylistical... [09:13:03] (03CR) 10Mglaser: [C: 032] Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [09:15:01] (03Merged) 10jenkins-bot: Add readers to ArticleInfo flyout [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/443417 (owner: 10ItSpiderman) [09:16:01] (03CR) 10Ppchelko: Tighten the MW request (031 comment) [services/chromium-render] - 10https://gerrit.wikimedia.org/r/443465 (https://phabricator.wikimedia.org/T198461) (owner: 10Mobrovac) [09:17:36] (03CR) 10Mglaser: [C: 032] Fix composer package name [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443563 (owner: 10Robert Vogel) [09:18:03] (03Merged) 10jenkins-bot: Fix composer package name [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443563 (owner: 10Robert Vogel) [09:19:24] (03CR) 10Mglaser: [C: 032] Adapt to switch to single backend in ES [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443571 (owner: 10ItSpiderman) [09:19:40] (03CR) 10Mglaser: [C: 032] Switch Special:SearchAdmin to single backend mode [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 (owner: 10ItSpiderman) [09:19:53] (03Merged) 10jenkins-bot: Adapt to switch to single backend in ES [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443571 (owner: 10ItSpiderman) [09:20:16] (03Merged) 10jenkins-bot: Switch Special:SearchAdmin to single backend mode [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443564 (owner: 10ItSpiderman) [09:26:44] (03CR) 10Prtksxna: Special:Log: Convert to HTMLForm (036 comments) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [09:26:48] (03PS24) 10Prtksxna: Special:Log: Convert to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) [09:30:01] (03CR) 10Ladsgroup: [C: 032] "I wanted to do it for a very long time. Thanks for taking care of it." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443526 (owner: 10Catrope) [09:30:35] (03PS8) 10Dvogel hallowelt: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 [09:31:22] (03CR) 10Nikerabbit: "> From my perspective, using strict BCP-47 makes our UX dependent on a slow ISO process" [core] - 10https://gerrit.wikimedia.org/r/443129 (owner: 10C. Scott Ananian) [09:32:55] (03Merged) 10jenkins-bot: ScoreStorage: Move $modelsToClean parameter up to the interface [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443526 (owner: 10Catrope) [09:34:02] (03CR) 10Raimond Spekking: [C: 031] "i18n review" [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 (owner: 10Dvogel hallowelt) [09:34:05] (03CR) 10jenkins-bot: ScoreStorage: Move $modelsToClean parameter up to the interface [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443526 (owner: 10Catrope) [09:41:09] (03CR) 10Mglaser: [C: 032] Add categories and templates to graphical list [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443556 (owner: 10ItSpiderman) [09:41:39] (03Merged) 10jenkins-bot: Add categories and templates to graphical list [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/443556 (owner: 10ItSpiderman) [10:04:57] 10Android-app-feature-Compilations: Android mobile App needs a way to implement a community blocking as the one currently ongoin on the web version of itwiki. - https://phabricator.wikimedia.org/T198692 (10CristianCantoro) [10:05:55] (03PS1) 10DCausse: Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) [10:06:24] (03CR) 10jerkins-bot: [V: 04-1] Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) (owner: 10DCausse) [10:06:38] 10Android-app-feature-Compilations: Android mobile App needs a way to implement a community blocking as the one currently ongoin on the web version of itwiki. - https://phabricator.wikimedia.org/T198692 (10CristianCantoro) Sibling iOS bug [[ https://phabricator.wikimedia.org/T198693 | T198693 ]] [10:10:35] (03CR) 10Gehel: [C: 032] "> Seems fine, i wonder if we could convince CI to run other repo's against this to verify changes here don't break builds elsewhere." [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443091 (owner: 10DCausse) [10:10:52] (03PS1) 10Ppchelko: Decrease checker concurrency to 6. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/443586 (https://phabricator.wikimedia.org/T198462) [10:11:11] (03CR) 10Ppchelko: [V: 032 C: 032] Decrease checker concurrency to 6. [services/change-propagation/jobqueue-deploy] - 10https://gerrit.wikimedia.org/r/443586 (https://phabricator.wikimedia.org/T198462) (owner: 10Ppchelko) [10:11:17] (03CR) 10jenkins-bot: Bump jacoco version to 0.8.1 [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443091 (owner: 10DCausse) [10:13:33] (03CR) 10Mglaser: [C: 032] Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 (owner: 10Dvogel hallowelt) [10:16:03] 10Wikipedia-Android-App-Backlog: Android mobile App needs a way to implement a community blocking as the one currently ongoin on the web version of itwiki. - https://phabricator.wikimedia.org/T198692 (10Aklapper) [10:19:25] (03Merged) 10jenkins-bot: Add RecentChangesStore to BlueSpice/Api and required implementation to BlueSpice/Data/RecentChanges [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443406 (owner: 10Dvogel hallowelt) [10:20:12] (03PS2) 10Thiemo Kreuz (WMDE): Remove redundant 'return true' from hooks that are not abortable [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/443524 (owner: 10Krinkle) [10:24:06] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Remove redundant 'return true' from hooks that are not abortable (033 comments) [extensions/WikimediaMessages] - 10https://gerrit.wikimedia.org/r/443524 (owner: 10Krinkle) [10:33:38] (03CR) 10Fomafix: Ensure LanguageCode::bcp47() returns a valid BCP 47 language code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/442200 (https://phabricator.wikimedia.org/T34483) (owner: 10C. Scott Ananian) [10:34:06] (03CR) 10Matěj Suchánek: [C: 04-1] Special:Log: Convert to HTMLForm (031 comment) [core] - 10https://gerrit.wikimedia.org/r/428871 (https://phabricator.wikimedia.org/T117737) (owner: 10Prtksxna) [10:36:11] 04(no projects): Navigation boxes and categories don't display (English Wikipedia) - https://phabricator.wikimedia.org/T198686 (10DonTrung) There's really not much to it, at the bottom of every page 📃 there simply aren't any categories or navigation templates, just look at an article like https://en.m.wikipedia... [10:41:30] 10MediaWiki-Core-Tests, 10Lexicographical data, 10Wikidata, 10MW-1.32-release-notes (WMF-deploy-2018-07-10 (1.32.0-wmf.12)), and 2 others: Configure the CI job that runs WikibaseLexeme's browser tests against beta wikidata - https://phabricator.wikimedia.org/T194252 (10zeljkofilipin) [10:55:17] (03CR) 10Addshore: [MCR] Introduce BlobStoreFactory (034 comments) [core] - 10https://gerrit.wikimedia.org/r/399996 (https://phabricator.wikimedia.org/T183634) (owner: 10Addshore) [10:55:45] (03PS1) 10Addshore: WIP Use BlobStoreFactory in RevisionStoreFactory [core] - 10https://gerrit.wikimedia.org/r/443589 [10:57:55] 10MediaWiki-extensions-Translate, 10TimedMediaHandler, 10Continuous-Integration-Config, 10Patch-For-Review: CI no more inject extensions dependencies on REL branches - https://phabricator.wikimedia.org/T197933 (10hashar) [11:01:01] (03CR) 10Aaron Schulz: [C: 032] resourceloader: Simplify ResourceLoader::isFileModule() [core] - 10https://gerrit.wikimedia.org/r/443525 (owner: 10Krinkle) [11:03:21] (03PS5) 10Aaron Schulz: Limit the number of cached languages in MessageCache via MapCacheLRU [core] - 10https://gerrit.wikimedia.org/r/441842 [11:03:39] (03CR) 10jerkins-bot: [V: 04-1] WIP Use BlobStoreFactory in RevisionStoreFactory [core] - 10https://gerrit.wikimedia.org/r/443589 (owner: 10Addshore) [11:04:08] (03CR) 10Aaron Schulz: [C: 032] RESTBagOStuff: improve timeouts and logging [core] - 10https://gerrit.wikimedia.org/r/440519 (owner: 10Tim Starling) [11:06:39] 10ContentTranslation, 10ContentTranslation-CXserver: cxserver: Matxin (es->eu) MT is not working - https://phabricator.wikimedia.org/T198698 (10KartikMistry) [11:12:14] (03Merged) 10jenkins-bot: resourceloader: Simplify ResourceLoader::isFileModule() [core] - 10https://gerrit.wikimedia.org/r/443525 (owner: 10Krinkle) [11:14:34] (03CR) 10Daniel Kinzler: WIP Use BlobStoreFactory in RevisionStoreFactory (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443589 (owner: 10Addshore) [11:15:33] (03CR) 10jenkins-bot: resourceloader: Simplify ResourceLoader::isFileModule() [core] - 10https://gerrit.wikimedia.org/r/443525 (owner: 10Krinkle) [11:18:47] (03Merged) 10jenkins-bot: RESTBagOStuff: improve timeouts and logging [core] - 10https://gerrit.wikimedia.org/r/440519 (owner: 10Tim Starling) [11:20:29] (03PS3) 10Mobrovac: Tighten the MW request [services/chromium-render] - 10https://gerrit.wikimedia.org/r/443465 (https://phabricator.wikimedia.org/T198461) [11:21:19] (03CR) 10jenkins-bot: RESTBagOStuff: improve timeouts and logging [core] - 10https://gerrit.wikimedia.org/r/440519 (owner: 10Tim Starling) [11:21:25] (03CR) 10Addshore: WIP Use BlobStoreFactory in RevisionStoreFactory (033 comments) [core] - 10https://gerrit.wikimedia.org/r/443589 (owner: 10Addshore) [11:25:15] (03CR) 10Mobrovac: "> +1 but would be nice to add it depends on I0fa60f16187bf25d6561db2f3bf87cf106ca9c66" (032 comments) [services/chromium-render] - 10https://gerrit.wikimedia.org/r/443465 (https://phabricator.wikimedia.org/T198461) (owner: 10Mobrovac) [11:49:29] (03PS1) 10Addshore: Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 [11:50:03] (03CR) 10jerkins-bot: [V: 04-1] Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [11:50:28] (03CR) 10jerkins-bot: [V: 04-1] Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [11:51:11] (03PS2) 10Addshore: Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 [11:53:54] (03CR) 10jerkins-bot: [V: 04-1] Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [12:00:41] (03PS1) 10Daimona Eaytoy: Add more customization options [extensions/Blackout] - 10https://gerrit.wikimedia.org/r/443596 [12:04:04] (03PS1) 10Aaron Schulz: Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias [core] - 10https://gerrit.wikimedia.org/r/443598 [12:04:06] (03PS1) 10Aaron Schulz: Remove deprecated CONN_TRX_AUTO alias [core] - 10https://gerrit.wikimedia.org/r/443599 [12:09:33] (03CR) 10Ppchelko: [C: 031] Tighten the MW request [services/chromium-render] - 10https://gerrit.wikimedia.org/r/443465 (https://phabricator.wikimedia.org/T198461) (owner: 10Mobrovac) [12:13:42] (03PS2) 10Pwirth: bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [12:14:23] (03PS2) 10DCausse: Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) [12:15:58] (03CR) 10jerkins-bot: [V: 04-1] bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [12:19:50] (03PS1) 10Gehel: update dependencies to latest versions [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443601 [12:40:42] (03PS3) 10Mglaser: bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [12:41:37] (03PS1) 10Dvogel hallowelt: Modify TabbedDataViewBase [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443605 [12:45:41] (03PS1) 10Aaron Schulz: rdbms: add more comments and sanity checks for CONN_TRX_AUTOCOMMIT [core] - 10https://gerrit.wikimedia.org/r/443607 [12:46:09] (03CR) 10Ppchelko: [C: 031] Config: Improve the MW request template [services/chromium-render/deploy] - 10https://gerrit.wikimedia.org/r/443468 (https://phabricator.wikimedia.org/T198461) (owner: 10Mobrovac) [12:48:09] (03CR) 10Mglaser: [C: 032] bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [12:48:11] (03CR) 10Addshore: "recheck" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [12:48:30] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add more comments and sanity checks for CONN_TRX_AUTOCOMMIT [core] - 10https://gerrit.wikimedia.org/r/443607 (owner: 10Aaron Schulz) [12:49:35] (03CR) 10Aaron Schulz: "recheck" [core] - 10https://gerrit.wikimedia.org/r/443607 (owner: 10Aaron Schulz) [12:49:45] 10Design, 10WMDE-Design, 10Wikibase-Quality, 10Wikibase-Quality-Constraints, and 2 others: Standard UI for including statements in constraint violation messages - https://phabricator.wikimedia.org/T167127 (10Lydia_Pintscher) [12:50:29] (03PS4) 10Dbrant: [GETTING THERE] Experiments with the ToC. [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/442164 (https://phabricator.wikimedia.org/T165964) [12:51:59] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add more comments and sanity checks for CONN_TRX_AUTOCOMMIT [core] - 10https://gerrit.wikimedia.org/r/443607 (owner: 10Aaron Schulz) [12:52:01] (03CR) 10jerkins-bot: [V: 04-1] Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 (owner: 10Addshore) [12:52:37] (03CR) 10Esanders: [C: 032] mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty [core] - 10https://gerrit.wikimedia.org/r/443204 (https://phabricator.wikimedia.org/T198402) (owner: 10Bartosz Dziewoński) [12:52:46] (03PS1) 10Daniel Kinzler: Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) [12:53:03] (03CR) 10jerkins-bot: [V: 04-1] rdbms: add more comments and sanity checks for CONN_TRX_AUTOCOMMIT [core] - 10https://gerrit.wikimedia.org/r/443607 (owner: 10Aaron Schulz) [12:54:12] 10Community-Liaisons (Apr-Jun-2018): Top 25 wiki projects in terms of active contributors have at least one active tech ambassadors and one translator identified - https://phabricator.wikimedia.org/T176475 (10Johan) [12:54:56] 10MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), 10DBA, 10Patch-For-Review, 10Schema-change: Schema change to make archive.ar_rev_id NOT NULL - https://phabricator.wikimedia.org/T191316 (10Marostegui) [12:55:17] (03CR) 10Mglaser: [C: 032] Modify TabbedDataViewBase [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443605 (owner: 10Dvogel hallowelt) [12:56:48] (03PS13) 10Ppchelko: Use RevisionRecordInserted hook for EventBus revision-create records [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/407863 (https://phabricator.wikimedia.org/T186228) [12:57:01] (03CR) 10Ppchelko: Use RevisionRecordInserted hook for EventBus revision-create records (031 comment) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/407863 (https://phabricator.wikimedia.org/T186228) (owner: 10Ppchelko) [12:57:14] (03CR) 10Niedzielski: [C: 032] Add special pages preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/408938 (https://phabricator.wikimedia.org/T186760) (owner: 10Jdlrobson) [13:02:04] (03Merged) 10jenkins-bot: bs.util: Add timestamp conversion methods [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443565 (owner: 10Robert Vogel) [13:06:38] (03Merged) 10jenkins-bot: mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty [core] - 10https://gerrit.wikimedia.org/r/443204 (https://phabricator.wikimedia.org/T198402) (owner: 10Bartosz Dziewoński) [13:06:40] (03Merged) 10jenkins-bot: Modify TabbedDataViewBase [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443605 (owner: 10Dvogel hallowelt) [13:06:48] (03CR) 10jerkins-bot: [V: 04-1] Make BackupDumper MCR compatible (main slot only) [core] - 10https://gerrit.wikimedia.org/r/443608 (https://phabricator.wikimedia.org/T198706) (owner: 10Daniel Kinzler) [13:08:43] (03CR) 10Niedzielski: [C: 031] Diff title should link to revision [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/441146 (owner: 10Jdlrobson) [13:09:25] (03CR) 10jenkins-bot: mw.widgets.TitleWidget: Don't mark optional fields as invalid when empty [core] - 10https://gerrit.wikimedia.org/r/443204 (https://phabricator.wikimedia.org/T198402) (owner: 10Bartosz Dziewoński) [13:09:43] 10Hashtags: Hashtag search tools is down - https://phabricator.wikimedia.org/T198707 (10Shyamal) [13:10:26] (03Merged) 10jenkins-bot: Add special pages preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/408938 (https://phabricator.wikimedia.org/T186760) (owner: 10Jdlrobson) [13:10:41] 10MediaWiki-extensions-TemplateWizard, 10Community-Tech: Improve usability of TemplateWizard - https://phabricator.wikimedia.org/T190348 (10Volker_E) @Mooeypoo I agree with your decent estimation of work (“non-trivial”) needed. Would you clarify with @cmadeo what the default would result in and also please bot... [13:11:27] how do I remove the WIP flag in Gerrit again? [13:13:23] (03CR) 10jenkins-bot: Add special pages preferences [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/408938 (https://phabricator.wikimedia.org/T186760) (owner: 10Jdlrobson) [13:16:03] Volker_E__: hit the big blue "Start Review" button that shows instead of the "Comment" button [13:16:20] DanielK_WMDE: thx :) [13:21:36] 10Page-Previews, 10Readers-Web-Backlog: Page preview margins should be consistent - https://phabricator.wikimedia.org/T198663 (10Niedzielski) [13:21:47] 10MediaWiki-extensions-FlaggedRevs: FlaggedRevs causes query error in LocalFile::getHistory - https://phabricator.wikimedia.org/T198687 (10Reedy) [13:21:51] 10Design, 10Move-Files-To-Commons, 10TCB-Team, 10WMDE-Design: Rename misleading "Submit" buttons on title/wikitext edit forms - https://phabricator.wikimedia.org/T198709 (10thiemowmde) [13:24:27] (03PS1) 10Reedy: Prevent SQL query error in FlaggedRevsUIHooks::addToFileHistQuery [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/443618 (https://phabricator.wikimedia.org/T198687) [13:25:34] (03PS1) 10Esanders: Fix toolbar group names [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443619 (https://phabricator.wikimedia.org/T198583) [13:25:57] (03CR) 10jerkins-bot: [V: 04-1] Prevent SQL query error in FlaggedRevsUIHooks::addToFileHistQuery [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/443618 (https://phabricator.wikimedia.org/T198687) (owner: 10Reedy) [13:26:42] 10MediaWiki-Platform-Team (MWPT-Q4-Apr-Jun-2018), 10DBA, 10Patch-For-Review, 10Schema-change: Schema change to make archive.ar_rev_id NOT NULL - https://phabricator.wikimedia.org/T191316 (10Marostegui) [13:27:08] (03PS2) 10Reedy: Prevent SQL query error in FlaggedRevsUIHooks::addToFileHistQuery [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/443618 (https://phabricator.wikimedia.org/T198687) [13:30:49] 10MediaWiki-extensions-Translate, 10Patch-For-Review: [Translate] Error: 1283 Column 'tmf_text' cannot be part of FULLTEXT index - https://phabricator.wikimedia.org/T197721 (10hashar) 05Resolved>03Open It is still broken on REL1_31, and I guess on REL1_30 as well. [13:31:00] (03CR) 10Hashar: "recheck" [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/441522 (https://phabricator.wikimedia.org/T197914) (owner: 10Paladox) [13:31:16] (03CR) 10Hashar: "check php" [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/441522 (https://phabricator.wikimedia.org/T197914) (owner: 10Paladox) [13:32:00] (03CR) 10Hashar: "That was failling due to dependencies no more being injected." [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/441522 (https://phabricator.wikimedia.org/T197914) (owner: 10Paladox) [13:32:21] (03PS1) 10DCausse: [maven-release-plugin] prepare release discovery-parent-pom-1.13 [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443621 [13:32:23] (03PS1) 10DCausse: [maven-release-plugin] prepare for next development iteration [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443622 [13:32:43] (03CR) 10DCausse: [V: 032 C: 032] [maven-release-plugin] prepare release discovery-parent-pom-1.13 [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443621 (owner: 10DCausse) [13:32:49] * Reedy notes pom != porn [13:32:56] (03PS3) 10Addshore: Revert "Introduce RevisionStoreFactory & Tests" [core] - 10https://gerrit.wikimedia.org/r/443593 [13:32:58] (03CR) 10DCausse: [V: 032 C: 032] [maven-release-plugin] prepare for next development iteration [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443622 (owner: 10DCausse) [13:33:50] (03CR) 10Hashar: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/92621 (owner: 10Hashar) [13:33:57] (03Merged) 10jenkins-bot: [maven-release-plugin] prepare release discovery-parent-pom-1.13 [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443621 (owner: 10DCausse) [13:34:23] (03Merged) 10jenkins-bot: [maven-release-plugin] prepare for next development iteration [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443622 (owner: 10DCausse) [13:34:38] (03CR) 10jenkins-bot: [maven-release-plugin] prepare release discovery-parent-pom-1.13 [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443621 (owner: 10DCausse) [13:35:11] (03CR) 10jenkins-bot: [maven-release-plugin] prepare for next development iteration [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443622 (owner: 10DCausse) [13:36:29] (03CR) 10jerkins-bot: [V: 04-1] Fix video playback regression in Safari 12 [extensions/TimedMediaHandler] (REL1_31) - 10https://gerrit.wikimedia.org/r/441522 (https://phabricator.wikimedia.org/T197914) (owner: 10Paladox) [13:36:31] (03PS2) 10DCausse: update dependencies to latest versions [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443601 (owner: 10Gehel) [13:38:06] (03CR) 10DCausse: [C: 032] update dependencies to latest versions [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443601 (owner: 10Gehel) [13:38:39] (03Merged) 10jenkins-bot: update dependencies to latest versions [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443601 (owner: 10Gehel) [13:39:15] (03CR) 10jenkins-bot: update dependencies to latest versions [wikimedia/discovery/discovery-parent-pom] - 10https://gerrit.wikimedia.org/r/443601 (owner: 10Gehel) [13:39:58] (03CR) 10Hashar: "recheck" [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/443412 (https://phabricator.wikimedia.org/T189560) (owner: 10Daimona Eaytoy) [13:40:29] (03CR) 10Hashar: "recheck" [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/429714 (owner: 10Daimona Eaytoy) [13:41:08] (03CR) 10Hashar: "recheck" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/436199 (owner: 10Legoktm) [13:41:12] (03CR) 10Hashar: "check php" [core] (REL1_27) - 10https://gerrit.wikimedia.org/r/436199 (owner: 10Legoktm) [13:43:47] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Technical-Debt: [Bug] Special:NewItem does not validate maximum label length - https://phabricator.wikimedia.org/T145932 (10daniel) Isn't that validation in the ChangeOp? Or is the ChangeOp not used? [13:44:28] (03CR) 10jerkins-bot: [V: 04-1] Bump equivset to 1.3 to avoid PHP fatal error [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/443412 (https://phabricator.wikimedia.org/T189560) (owner: 10Daimona Eaytoy) [13:44:34] (03CR) 10jerkins-bot: [V: 04-1] Fix an undeclared variable in block options [extensions/AbuseFilter] (REL1_31) - 10https://gerrit.wikimedia.org/r/429714 (owner: 10Daimona Eaytoy) [13:47:59] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC phase 1), 10User-Addshore: Use a consistent caching strategy within Revision storage classes - https://phabricator.wikimedia.org/T198704 (10daniel) a:03daniel [13:48:47] (03PS1) 10Pwirth: TabbedDataView: Fixed makeDataViewItemLinkUrl [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443626 [13:48:53] (03CR) 10DCausse: [C: 032] Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [13:49:27] (03CR) 10Mglaser: [C: 032] TabbedDataView: Fixed makeDataViewItemLinkUrl [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443626 (owner: 10Pwirth) [13:50:55] 10MediaWiki-Cache, 10Multi-Content-Revisions (MCR-SDC phase 1), 10User-Addshore: Use a consistent caching strategy within Revision storage classes - https://phabricator.wikimedia.org/T198704 (10daniel) I'm going for option two, which is already used by RevisionStore: //"NameTableStore & SqlBlobStore should s... [13:52:00] (03CR) 10Ppchelko: "Should we go ahead with this? @mobrovac @ottomata" [event-schemas] - 10https://gerrit.wikimedia.org/r/422938 (https://phabricator.wikimedia.org/T190958) (owner: 10Ppchelko) [13:52:07] p/win 24 [13:53:42] (03PS1) 10ItSpiderman: Changes to incorporate filterCfg modification and filter grouping [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/443627 [13:56:01] (03PS1) 10ItSpiderman: [WIP] Filtering ES over SMW properties [extensions/BlueSpiceSMWConnector] - 10https://gerrit.wikimedia.org/r/443628 [13:58:16] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443630 [13:58:33] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] (REL1_31) - 10https://gerrit.wikimedia.org/r/443631 [13:58:46] (03PS1) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443632 [13:58:58] (03CR) 10Hashar: "check php" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443630 (owner: 10Hashar) [13:59:01] (03CR) 10Hashar: "check php" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443630 (owner: 10Hashar) [13:59:27] (03CR) 10Hashar: "check php" [extensions/cldr] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443632 (owner: 10Hashar) [13:59:32] (03CR) 10Hashar: "check php" [extensions/cldr] (REL1_31) - 10https://gerrit.wikimedia.org/r/443631 (owner: 10Hashar) [14:01:49] (03CR) 10Tjones: "I see that I'm too late to the party, but there are two @covers tags that don't seem to do anything." (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:04:03] (03CR) 10DCausse: [C: 032] "thanks for catching this! :)" (032 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:04:48] (03PS3) 10C. Scott Ananian: Hard deprecate wfBCP47, which was soft deprecated in 1.31 [core] - 10https://gerrit.wikimedia.org/r/442161 [14:05:17] (03CR) 10DCausse: [C: 04-2] Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:05:34] (03CR) 10C. Scott Ananian: "Removing C-2, since all the dependent extensions have now been patched & those patches merged." [core] - 10https://gerrit.wikimedia.org/r/442161 (owner: 10C. Scott Ananian) [14:08:14] 10MediaWiki-API, 10ChangeProp, 10Services (done), 10User-mobrovac: Long API requests from ChangeProp - https://phabricator.wikimedia.org/T144989 (10Pchelolo) 05Open>03Resolved We haven't seen an issue like this with other queries for a very long time now. Resolving. [14:10:37] (03PS2) 10DCausse: Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:15:40] (03Merged) 10jenkins-bot: TabbedDataView: Fixed makeDataViewItemLinkUrl [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/443626 (owner: 10Pwirth) [14:21:33] (03CR) 10Hashar: "recheck" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443630 (owner: 10Hashar) [14:21:36] (03CR) 10Hashar: "recheck" [extensions/cldr] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443632 (owner: 10Hashar) [14:21:40] (03CR) 10Hashar: "recheck" [extensions/cldr] (REL1_31) - 10https://gerrit.wikimedia.org/r/443631 (owner: 10Hashar) [14:21:58] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] - 10https://gerrit.wikimedia.org/r/443630 (owner: 10Hashar) [14:22:00] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] (wmf/1.32.0-wmf.10) - 10https://gerrit.wikimedia.org/r/443632 (owner: 10Hashar) [14:22:03] (03Abandoned) 10Hashar: Jenkins job validation (DO NOT SUBMIT) [extensions/cldr] (REL1_31) - 10https://gerrit.wikimedia.org/r/443631 (owner: 10Hashar) [14:22:48] (03PS1) 10Pmiazga: Revert "Add special pages preferences" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443638 [14:23:51] (03CR) 10Pmiazga: [C: 032] Revert "Add special pages preferences" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443638 (owner: 10Pmiazga) [14:24:40] (03CR) 10Niedzielski: [C: 032] "Observable on https://en.m.wikipedia.beta.wmflabs.org/wiki/Barack_Obama:" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443638 (owner: 10Pmiazga) [14:25:30] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:25:44] (03PS3) 10DCausse: Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:28:14] (03CR) 10Mholloway: "recheck" [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/442136 (https://phabricator.wikimedia.org/T198495) (owner: 10Mholloway) [14:30:54] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:31:46] 10MediaWiki-extensions-FlaggedRevs, 10Patch-For-Review: FlaggedRevs causes query error in LocalFile::getHistory - https://phabricator.wikimedia.org/T198687 (10Topsnet-holgerd) Dear Reedy, dear gerritbot, sorry, no success. The array $groupBy builded by OldLocalFile::selectFields() contains an empty key. There... [14:34:49] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Third-Party-Support: Special:MobileOptions is empty for third parties - https://phabricator.wikimedia.org/T198265 (10Jdlrobson) (We can also disable the settings link if there are no settings which may make more sense) [14:37:11] (03CR) 10DCausse: [C: 031] Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:41:44] 10MediaWiki-File-management, 10MediaWiki-extensions-FlaggedRevs, 10Commons, 10Multimedia, 10Patch-For-Review: FlaggedRevs causes query error in LocalFile::getHistory - https://phabricator.wikimedia.org/T198687 (10Reedy) @Anomie looks like it's probably another bug relating to array() + array() ```lang=p... [14:45:16] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias (031 comment) [core] - 10https://gerrit.wikimedia.org/r/443598 (owner: 10Aaron Schulz) [14:45:55] (03Merged) 10jenkins-bot: Revert "Add special pages preferences" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443638 (owner: 10Pmiazga) [14:47:39] (03PS1) 10Zoranzoki21: Test [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 [14:48:36] (03PS3) 10DCausse: Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) [14:49:20] (03CR) 10jenkins-bot: Revert "Add special pages preferences" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/443638 (owner: 10Pmiazga) [14:51:02] (03CR) 10C. Scott Ananian: "It is worth comparing these mappings with those already done by Wikibase in https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/Wikiba" (036 comments) [core] - 10https://gerrit.wikimedia.org/r/442200 (https://phabricator.wikimedia.org/T34483) (owner: 10C. Scott Ananian) [14:51:52] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [14:52:57] (03CR) 10jerkins-bot: [V: 04-1] Add support for elastic 6.3.0 [search/extra] - 10https://gerrit.wikimedia.org/r/443584 (https://phabricator.wikimedia.org/T198067) (owner: 10DCausse) [14:53:26] (03CR) 10Jack Phoenix: "recheck" [extensions/ConfirmAccount] - 10https://gerrit.wikimedia.org/r/443223 (owner: 10Jack Phoenix) [14:53:28] 10Page-Previews, 10Readers-Web-Backlog, 10Patch-For-Review, 10Readers-Web-Kanbanana-Board: Do not fire/abort AJAX request when it is not necessary - https://phabricator.wikimedia.org/T197700 (10Tbayer) From a data perspective, and as far as I understand the implications here, this change should be fine. Th... [14:55:22] (03CR) 10Brian Wolff: [C: 032] Some basic housekeeping [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443488 (owner: 10Jack Phoenix) [14:55:47] (03CR) 10Brian Wolff: [C: 032] Add missing i18n message [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443489 (owner: 10Jack Phoenix) [14:56:17] (03CR) 10C. Scott Ananian: "...ping @Nikerabbit..." [core] - 10https://gerrit.wikimedia.org/r/442161 (owner: 10C. Scott Ananian) [14:57:21] (03CR) 10Brian Wolff: [C: 032] Allow users to set a default deletion reason (e.g. "Spam", "Vandalism", etc.) [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443507 (owner: 10Jack Phoenix) [14:58:27] (03PS2) 10Zoranzoki21: Tag for adding new row is wrong in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) [14:59:49] (03CR) 10Brian Wolff: [C: 04-1] Introduce a new user right, deletebatch-spoof, which allows to delete pages as "Delete page script" (031 comment) [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443504 (owner: 10Jack Phoenix) [15:00:40] (03CR) 10DCausse: OtherIndex support multiple clusters (033 comments) [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443009 (https://phabricator.wikimedia.org/T194678) (owner: 10EBernhardson) [15:01:08] (03Merged) 10jenkins-bot: Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias [core] - 10https://gerrit.wikimedia.org/r/443598 (owner: 10Aaron Schulz) [15:01:38] (03PS1) 10Sbisson: Store prediction for aggregated scores [extensions/ORES] - 10https://gerrit.wikimedia.org/r/443641 [15:02:54] (03CR) 10Anomie: [C: 04-1] "The code itself looks like it will do something sane, although I haven't tested it." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/443528 (owner: 10Krinkle) [15:04:06] (03CR) 10Aklapper: "-1 as per https://phabricator.wikimedia.org/T198720#4394445" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [15:04:11] (03CR) 10Brian Wolff: [C: 032] "After discussion on irc, we're going to leave that as a future TODO" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443504 (owner: 10Jack Phoenix) [15:04:34] (03CR) 10jenkins-bot: Use CONN_TRX_AUTOCOMMIT instead of deprecated CONN_TRX_AUTO alias [core] - 10https://gerrit.wikimedia.org/r/443598 (owner: 10Aaron Schulz) [15:04:49] (03CR) 10Aklapper: "For future reference, please also follow https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines . The current commit message does" [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [15:05:50] (03Abandoned) 10Zoranzoki21: Tag for adding new row is wrong in WikiEditor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/443639 (https://phabricator.wikimedia.org/T198720) (owner: 10Zoranzoki21) [15:06:56] (03PS2) 10Brian Wolff: Improve tracking of outputting class members [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/443356 [15:10:23] (03Merged) 10jenkins-bot: Some basic housekeeping [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443488 (owner: 10Jack Phoenix) [15:10:25] (03Merged) 10jenkins-bot: Add missing i18n message [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443489 (owner: 10Jack Phoenix) [15:10:27] (03Merged) 10jenkins-bot: Introduce a new user right, deletebatch-spoof, which allows to delete pages as "Delete page script" [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443504 (owner: 10Jack Phoenix) [15:12:50] (03CR) 10Brian Wolff: [C: 032] Add username autocompletion to the form on Special:Sudo [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443199 (owner: 10Jack Phoenix) [15:13:37] (03CR) 10Brian Wolff: [C: 032] Extension registration support [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443200 (owner: 10Jack Phoenix) [15:14:27] (03Merged) 10jenkins-bot: Allow users to set a default deletion reason (e.g. "Spam", "Vandalism", etc.) [extensions/DeleteBatch] - 10https://gerrit.wikimedia.org/r/443507 (owner: 10Jack Phoenix) [15:14:53] 10Mobile-Web-Settings, 10MobileFrontend, 10Readers-Web-Backlog, 10Reading-Web-Third-Party-Support: Special:MobileOptions is empty for third parties - https://phabricator.wikimedia.org/T198265 (10Jdlrobson) [15:15:03] (03CR) 10Brian Wolff: [C: 032] "This is almost certainly going to conflict, but here goes a +2" [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:16:06] (03PS2) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [15:18:13] (03CR) 10jerkins-bot: [V: 04-1] Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) (owner: 10Daimona Eaytoy) [15:18:32] (03Merged) 10jenkins-bot: Add username autocompletion to the form on Special:Sudo [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443199 (owner: 10Jack Phoenix) [15:19:29] (03Merged) 10jenkins-bot: Extension registration support [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443200 (owner: 10Jack Phoenix) [15:19:31] (03CR) 10jerkins-bot: [V: 04-1] build: Introduce mediawiki-codesnifer [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:22:07] (03PS2) 10Jack Phoenix: build: Introduce mediawiki-codesnifer [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:22:13] (03CR) 10jerkins-bot: [V: 04-1] build: Introduce mediawiki-codesnifer [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:23:22] (03CR) 10Jforrester: [C: 032] "Sad that we need this." [core] - 10https://gerrit.wikimedia.org/r/443527 (owner: 10Krinkle) [15:24:55] (03PS3) 10Daimona Eaytoy: Add phpunit tests for creating filters [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/443520 (https://phabricator.wikimedia.org/T42478) [15:25:06] (03CR) 10Tjones: [C: 032] Add @covers tags to a few tests [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/443515 (owner: 10EBernhardson) [15:29:09] (03PS3) 10Jack Phoenix: build: Introduce mediawiki-codesniffer [extensions/Sudo] - 10https://gerrit.wikimedia.org/r/443481 (owner: 10Jforrester) [15:29:47] (03CR) 10Anomie: [MCR] Make PageArchive aware of MCR (037 comments) [core] - 10https://gerrit.wikimedia.org/r/426009 (https://phabricator.wikimedia.org/T194015) (owner: 10Daniel Kinzler) [15:29:52] (03CR) 10Anomie: "check experimental" [core] - 10https://gerrit.wikimedia.org/r/426009 (https://phabricator.wikimedia.org/T194015) (owner: 10Daniel Kinzler) [15:30:58] (03PS3) 10MusikAnimal: Allow sorting of AfC drafts by submission date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) [15:31:05] (03CR) 10jerkins-bot: [V: 04-1] Allow sorting of AfC drafts by submission date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) (owner: 10MusikAnimal) [15:31:08] (03CR) 10jerkins-bot: [V: 04-1] Allow sorting of AfC drafts by submission date [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/442979 (https://phabricator.wikimedia.org/T195547) (owner: 10MusikAnimal) [15:31:45] (03CR) 10Jdlrobson: WIP: Reading depth hook should send additional sampling bucket parameter (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/443568 (https://phabricator.wikimedia.org/T191532) (owner: 10Jdrewniak) [15:35:29]