[00:18:56] 10Modern, 10Timeless, 10MW-1.32-release-notes (WMF-deploy-2018-05-22 (1.32.0-wmf.5)), 10Patch-For-Review: Older skins no longer bold Self links - https://phabricator.wikimedia.org/T192033#4125137 (10Isarra) May also want to check all the other skins in gerrit... [00:23:25] 10Timeless: Do something about crappy Timeless VE editsection icons - https://phabricator.wikimedia.org/T197521#4295047 (10Peachey88) [00:30:00] 10WMF-CTO-Team-Backlog: Q1 goals -- get on wiki and reviewed (FY18/19) - https://phabricator.wikimedia.org/T197152#4295048 (10debt) 05Open>03Resolved closing as it has been confirmed by C Levels that we will not do QCIs for Q4 2018. [01:25:03] 10MediaWiki-Special-pages, 10IPv6, 10Patch-For-Review: Create new Special:RangeContributions page to support viewing contributions across an IP range - https://phabricator.wikimedia.org/T145912#4295058 (10jeblad) >>! In T145912#3917963, @MusikAnimal wrote: >>>! In T145912#3914928, @jeblad wrote: >> How would... [03:44:26] 10Discovery, 10Discovery-Search (Current work), 10I18n: Re-index Croatian, Serbo-Croatian, and Bosnian Wikis - https://phabricator.wikimedia.org/T196658#4295081 (10TJones) Croatian is done. [04:22:24] 10Discovery, 10Discovery-Search (Current work), 10Esperanto-Sites, 10I18n: Review Esperanto Morphological Libraries - https://phabricator.wikimedia.org/T197240#4295090 (10Liuxinyu970226) [04:57:15] 10Wikimedia Australia: Close WordPress site blog.wikimedia.org.au - https://phabricator.wikimedia.org/T185880#4295105 (10Samwilson) There are 14 posts in the old blog. The redirections (for Apache) will be: ``` Redirect permanent /2015-08-august-melbourne-meetup/ https://www.wiki... [05:08:46] 10Wikimedia Australia, 10Wikimedia-Planet, 10Patch-For-Review: Error 404 while updating feed http://blog.wikimedia.org.au/category/wikimedia/feed/ - https://phabricator.wikimedia.org/T133620#4295108 (10Peachey88) [05:09:11] 10Wikimedia Australia, 10Wikimedia-Planet, 10Patch-For-Review: Error 404 while updating feed http://blog.wikimedia.org.au/category/wikimedia/feed/ - https://phabricator.wikimedia.org/T133620#2237553 (10Peachey88) [05:42:56] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ClientSide extension - https://phabricator.wikimedia.org/T196617#4295110 (10Dinoguy1000) [07:37:25] (03CR) 10MarcoAurelio: [C: 04-1] Add es-419 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) (owner: 10Nikerabbit) [07:42:13] (03CR) 10MarcoAurelio: [C: 04-1] Add es-419 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) (owner: 10Nikerabbit) [07:56:15] 10MediaWiki-Configuration, 10DBA, 10Operations: Data model for dbconfig - https://phabricator.wikimedia.org/T197531#4295158 (10Joe) p:05Triage>03Normal [08:10:30] 10MediaWiki-extensions-PropertySuggester, 10Wikidata: process user onwiki feedback for Wikidata property suggestor - https://phabricator.wikimedia.org/T197532#4295185 (10Esc3300) [08:28:14] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ClientSide extension - https://phabricator.wikimedia.org/T196617#4263344 (10MarcoAurelio) [08:28:23] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, and 2 others: Archive the ClientSide extension - https://phabricator.wikimedia.org/T196617#4263344 (10MarcoAurelio) [08:29:11] (03PS1) 10MarcoAurelio: Archive the ClientSide extension [extensions] - 10https://gerrit.wikimedia.org/r/440723 (https://phabricator.wikimedia.org/T196617) [08:29:59] (03PS2) 10MarcoAurelio: Archive the ClientSide extension [extensions] - 10https://gerrit.wikimedia.org/r/440723 (https://phabricator.wikimedia.org/T196617) [08:51:56] (03CR) 10MarcoAurelio: "Strangely jenkins-bot didn't started gate-and-submit jobs here." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/440351 (owner: 10Niedzielski) [08:52:43] 10MediaWiki-extensions-Other, 10User-MarcoAurelio: SpecialPage::getTitle Deprecation warning in UserExport - https://phabricator.wikimedia.org/T197533#4295206 (10Mainframe98) [08:53:09] 10MediaWiki-extensions-Other, 10User-MarcoAurelio: SpecialPage::getTitle Deprecation warning in UserExport - https://phabricator.wikimedia.org/T197533#4295219 (10Mainframe98) [08:53:27] (03CR) 10Mainframe98: [C: 031] "> Patch Set 1:" [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/440392 (https://phabricator.wikimedia.org/T197226) (owner: 10MarcoAurelio) [08:53:36] 10MediaWiki-extensions-Other, 10User-MarcoAurelio: SpecialPage::getTitle Deprecation warning in UserExport - https://phabricator.wikimedia.org/T197533#4295222 (10MarcoAurelio) Thanks! I'll try to get those fixed once the patches I upload for ExtReg and PHPCS are merged :-) [09:02:52] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Wrong parsing of centuries and millennia - https://phabricator.wikimedia.org/T73459#758045 (10Jc86035) Would it be difficult to display this as a range, like "some point in time between 1 January 2001 and 31 December 2100"? Or is there something in the way... [09:07:13] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 2 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295230 (10PerfektesChaos) [09:11:50] (03PS2) 10Florianschmidtwelzow: registration: Use the correct key for skin dependencies [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) [09:12:04] (03CR) 10Florianschmidtwelzow: "See PS2 :)" [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) (owner: 10Florianschmidtwelzow) [09:13:03] (03CR) 10Pastakhov: [C: 032] Add extension.json file and use composer for Mpdf library ver 6.1 (v0.9) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/435971 (https://phabricator.wikimedia.org/T188523) (owner: 10Pastakhov) [09:15:41] (03PS1) 10MarcoAurelio: Archive the CustomPage extension [extensions/CustomPage] - 10https://gerrit.wikimedia.org/r/440726 (https://phabricator.wikimedia.org/T197102) [09:15:47] (03CR) 10jerkins-bot: [V: 04-1] Archive the CustomPage extension [extensions/CustomPage] - 10https://gerrit.wikimedia.org/r/440726 (https://phabricator.wikimedia.org/T197102) (owner: 10MarcoAurelio) [09:19:11] (03Merged) 10jenkins-bot: Add extension.json file and use composer for Mpdf library ver 6.1 (v0.9) [extensions/Mpdf] - 10https://gerrit.wikimedia.org/r/435971 (https://phabricator.wikimedia.org/T188523) (owner: 10Pastakhov) [09:19:56] 10Repository-Admins: Maintainer access for Wikimedia Commons Android Tools project - https://phabricator.wikimedia.org/T197204#4295258 (10MarcoAurelio) a:05MarcoAurelio>03mmodell Fix. [09:25:01] (03CR) 10MarcoAurelio: "Oh, sorry then :-(" [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/440397 (owner: 10MarcoAurelio) [09:27:09] (03PS3) 10MarcoAurelio: Add PHPCS and fix some found sniffs [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/440397 [09:27:49] 10MediaWiki-extensions-Other, 10User-MarcoAurelio: SpecialPage::getTitle Deprecation warning in UserExport - https://phabricator.wikimedia.org/T197533#4295261 (10MarcoAurelio) @Mainframe98 Fixing at https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/UserExport/+/440397/2..3/UserExport.body.php I think. [09:41:13] 10MediaWiki-Configuration, 10DBA, 10Operations: Data model for dbconfig - https://phabricator.wikimedia.org/T197531#4295263 (10Joe) [09:41:52] 10MediaWiki-Configuration, 10DBA, 10Operations: Data model for dbconfig - https://phabricator.wikimedia.org/T197531#4295158 (10Joe) [10:02:59] 10MediaWiki-Configuration: extension.json should be able to express dependency on PHP version / PHP extension version - https://phabricator.wikimedia.org/T197535#4295268 (10Tgr) [10:04:46] (03PS1) 10Thiemo Kreuz (WMDE): Avoid counting where not necessary [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/440730 [10:30:02] (03CR) 10Thiemo Kreuz (WMDE): Add strict "array" and other type hints to method headers (032 comments) [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437195 (owner: 10Thiemo Kreuz (WMDE)) [10:31:49] 10MediaWiki-extensions-Score, 10Wikisource, 10Bengali-Sites, 10Upstream: Support Hindustani traditional musical notation (Swaralipi) in Extension:Score - https://phabricator.wikimedia.org/T58087#4295299 (10Bodhisattwa) >>! In T58087#625272, @Aklapper wrote: > Is there a Wikipedia article where one could re... [10:34:11] (03CR) 10Fomafix: [C: 04-1] registration: Use the correct key for skin dependencies (032 comments) [core] - 10https://gerrit.wikimedia.org/r/440545 (https://phabricator.wikimedia.org/T197478) (owner: 10Florianschmidtwelzow) [10:54:19] (03PS1) 10Nischayn22: Escape Shell Commands [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/440734 [11:04:30] (03PS2) 10Nischayn22: Escape Shell Commands [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/440734 [11:05:56] (03CR) 10Nischayn22: [V: 032 C: 032] Escape Shell Commands [extensions/DocBookExport] - 10https://gerrit.wikimedia.org/r/440734 (owner: 10Nischayn22) [11:11:43] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10CheckUser, 10Stewards-and-global-tools: Make users without 2FA setup not have checkuser right regardless of their groups - https://phabricator.wikimedia.org/T197501#4295316 (10MarcoAurelio) [11:12:28] 10MediaWiki-extensions-OATHAuth, 10Stewards-and-global-tools: Be able to force OATHAuth for certain user groups - https://phabricator.wikimedia.org/T150562#4295318 (10MarcoAurelio) [11:13:05] 10MediaWiki-User-login-and-signup, 10Stewards-and-global-tools, 10Wikimedia-Site-requests, 10Security: Force OATHAuth (2FA) for certain user groups in Wikimedia production - https://phabricator.wikimedia.org/T150898#4295319 (10MarcoAurelio) [11:23:08] (03PS1) 10Nischayn22: Fixed bug in handling imports [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/440736 [11:23:41] (03PS2) 10Nischayn22: Fixed bug in handling imports [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/440736 [11:23:56] (03PS1) 10Debenben: removed problematic texvc from VE suggestions [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) [11:24:04] (03CR) 10Nischayn22: [V: 032 C: 032] Fixed bug in handling imports [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/440736 (owner: 10Nischayn22) [11:28:52] (03CR) 10MarcoAurelio: "recheck" [extensions/Renameuser] - 10https://gerrit.wikimedia.org/r/355178 (owner: 10GeoffreyT2000) [11:42:50] 10UniversalLanguageSelector: Update font name and size on the Divehi Wikipedia (dv.wikipedia.org) - https://phabricator.wikimedia.org/T197538#4295340 (10Amire80) [11:43:02] 10UniversalLanguageSelector, 10I18n: Update font name and size on the Divehi Wikipedia (dv.wikipedia.org) - https://phabricator.wikimedia.org/T197538#4295351 (10Amire80) [11:50:18] (03PS1) 10Nischayn22: Added caching for sidebar HTML [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/440738 [11:50:50] (03CR) 10Nischayn22: [V: 032 C: 032] Added caching for sidebar HTML [extensions/CloneDiff] - 10https://gerrit.wikimedia.org/r/440738 (owner: 10Nischayn22) [11:53:41] (03PS2) 10Nischayn22: Switched cache to MW inbuilt [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/437177 [11:54:49] (03PS1) 10Tuxin: Ajout du fichier README [extensions/examples] - 10https://gerrit.wikimedia.org/r/440739 [12:07:38] (03CR) 10Physikerwelt: "Thank you for your contribution." [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [12:24:15] (03CR) 10Debenben: "Thanks for the suggestions. I was hoping that someone could simply run node makeSvgsAndCss.js and then it is ready for review. I would hav" [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [12:37:05] (03PS1) 10Physikerwelt: Cleanup: Remove Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/440742 (https://phabricator.wikimedia.org/T195847) [12:39:04] 10CX-deployments, 10Language-2018-Apr-June, 10Patch-For-Review: Update apertium-apy - https://phabricator.wikimedia.org/T194342#4295389 (10KartikMistry) Scheduled on 26th June for deployment in Production. [12:42:01] (03PS2) 10Physikerwelt: removed problematic texvc from VE suggestions [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [12:46:21] (03CR) 10Physikerwelt: "mh. I started mathoid in a seperate window and clicked on the script;-)" [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [12:55:22] 10MediaWiki-Vagrant, 10Math, 10Patch-For-Review: Unable to install Math extension with MediaWiki-Vagrant on labs - https://phabricator.wikimedia.org/T196590#4262588 (10Physikerwelt) @brion do you have a suggestion, where and how to document how this decision was made? [12:57:13] (03CR) 10Debenben: [C: 031] "I think it did what it was supposed to do, so should be working now" [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [13:00:27] (03CR) 10Physikerwelt: [C: 04-1] "The commit message needs to be updated and the patch needs to be tested." [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) (owner: 10Debenben) [13:08:54] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: [Suggestion] Change when the first-time user education screen for reading list is shown - https://phabricator.wikimedia.org/T197539#4295393 (10Kaartic) [13:09:19] r054l13 or r054l13_: are you around? how do things look? [13:16:06] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4294977 (10Izno) This is intended behavior. There is an intermediate size between "icons" and "2 column view". [13:24:44] note that we are having some quite intense storms; if I disappear it will be because the power went out [13:28:21] r054l13 and or r054l13_? [13:40:35] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 2 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295408 (10PerfektesChaos) [13:40:42] 10Phabricator, 10Discourse, 10Developer-Relations (Apr-Jun-2018): Enable Wikimedia Phabricator login in discourse-mediawiki.wmflabs.org - https://phabricator.wikimedia.org/T184987#3902356 (10Sau226) @yana_agun If you want to transfer it I think you should give it to @Tgr. He will probably find a way to move... [13:43:00] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Syntax highlighting interacts badly with magnify on Android - https://phabricator.wikimedia.org/T197540#4295411 (10RoySmith) [13:45:57] r054l13: [13:46:02] you there? [13:50:34] r054l13_? [13:50:38] yes [13:52:21] ah! you are there [13:52:33] ready to look together are some code? [13:52:49] r054l13_ [13:53:21] yes [13:53:37] ok! [13:53:47] so I've had a look at the code without the promises [13:53:54] ok [13:54:22] and as I understand it, the problem is in images.js, with the request() call. is that right? [13:54:31] yes [13:54:34] ok [13:54:52] I see you've got some debugging statements in there. do any of them print anything? [13:55:03] yes [13:55:21] can you give me a quick pastebin and show me what the output looks like? [13:55:43] ok [14:03:19] whenever you're ready :-) [14:15:08] r054l13_? [14:15:43] 10MediaWiki-Watchlist, 10Wikimedia-Site-requests: Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) - https://phabricator.wikimedia.org/T197541#4295427 (10Bencemac) [14:16:20] https://pastebin.com/hibrwWez [14:17:38] apergos: sorry! I was trying fix some errors. [14:17:43] ok! [14:19:11] all right. so we see something is undefined in there [14:19:39] yea [14:19:47] JSON.parse is whining, it says [14:19:55] so the first thing you could do is [14:20:03] don't say json = true [14:20:18] and just console.log the contents you get back, to see that you get that far [14:20:32] the you can look at the contents and see where the problem is [14:20:46] let me do it now [14:20:49] ok! [14:24:52] apergos: https://pastebin.com/CPhFcWz8 [14:26:10] well you don't want to try to dig the url out of a text response [14:26:16] you want to just display what you got; [14:26:18] 10ContentTranslation, 10ContentTranslation-Release10, 10Language-Engineering July-September 2016, 10WorkType-Maintenance: Using "Do not use machine translation" option for a table causes all sections below go out of alignment - https://phabricator.wikimedia.org/T143384#2566676 (10Bencemac) [[ https://en.wi... [14:26:50] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4295441 (10Paladox) >>! In T197520#4295404, @Izno wrote: > This is intended behavior. There is an intermediate size between "icons" and "2 column view". But if you make it a bit bigger it has icons and w... [14:26:55] yea [14:27:12] so just try logging the body as it is and let's see what's in tere [14:27:13] ther [14:27:14] e [14:29:32] https://pastebin.com/gDzNaA9j [14:30:29] https://commons.wikimedia.org/w/api.php?action=query&format=json&formatversion=2&prop=imageinfo&iiprop=url&iiurlwidth=500&iiurlheight=500&titles=File:undefined [14:30:30] hmm [14:30:36] that ttles is a bit suspicious [14:31:26] try again with a good file? [14:31:42] I think it is because It got a image from the json file which is not from commons, It is from digital collection [14:32:11] apergos: It is randomly selected [14:32:30] well let's sot that out so you aren't battling your own code [14:32:35] *sort out [14:32:52] this is because not all emojies have been maped to commons pictures yet [14:32:58] just use one thta has [14:33:14] it doesn't matter if you use the same one over and over for our debugging [14:34:01] I can't tweet the same emoji in twice in one day [14:34:16] but well I try something [14:34:22] in the previous run, as I look at the utrl it got from the json file, there's something weird there too: [14:34:28] https://commons.wikimedia.org/wiki/File:Zebra_2013_10_06_1274.jpge that e on the end [14:34:33] any idea what that is about? [14:35:01] hmm [14:35:08] let me check please [14:35:10] sure [14:36:05] "https://commons.wikimedia.org/wiki/File:Zebra_2013_10_06_1274.jpge", [14:36:11] it's in the json file [14:36:16] so you want to clean that up :-) [14:37:09] it's not, I have tried searching [14:38:07] the other thing is you can try to send a tweet with the emoji somewhere in the text, instead of the emoji as the entire tweet. if you vary your sentence you might be fine for twitter [14:38:15] it is in the json file [14:38:22] I mean, I got the line above from there [14:39:44] so in order: let's get the e off the end of that line... then try sending that emoji as part of a sentence and see if twitter takes it [14:39:49] oh I've seen it corrected [14:40:05] ok [14:44:43] https://pastebin.com/zgW8KurT [14:46:55] ah id you try the same emoji again and see if it took it as part of a sentence? [14:46:59] the zebra one [14:48:34] r054l13_ [14:48:40] yes [14:48:44] am there [14:50:04] did you try the zebra emoji again as part of a sentence and see if twitter accepted it? [14:51:18] I did not have Zebra emoji on my phone to test it [14:51:39] the previous zebra was random from the code itself it was not me [14:52:03] ok but [14:52:10] but I tried the cry face emoji. which i had tried before [14:52:13] ok [14:52:19] and you tried that in a sentence? [14:52:25] yes [14:52:31] and di twitter take it? [14:52:38] let me paste the out put [14:52:39] yes [14:52:42] ok good [14:52:52] so we can stick to that emoji over and over for testing for this session [14:53:02] and know that every time we are going to be looking at related output [14:53:29] https://pastebin.com/yXfFUJGs [14:53:56] yep [14:55:22] ok [14:55:35] so now I' like to just see what query has in it [14:55:45] can we console.log that please, right after you set it? [14:56:08] ok [14:58:40] apergos: https://pastebin.com/qJj0FnXz [14:59:11] ok; the query look sgood [15:00:14] so next, I guess that one of those undefineds is the console.log of query from within the callback [15:00:23] can you put something else in there instead, like [15:00:23] yes [15:00:35] "in the callback" ? [15:00:42] and let's see what that output looks like [15:01:12] query isn't going to be var available to the callback, since it's not a global [15:02:33] ok, I see [15:04:51] apergos: https://pastebin.com/iCDieZYt [15:05:52] an can you paste real quick what the current code for getImage looks like? [15:06:24] ok [15:07:06] https://pastebin.com/Di7DijAs [15:09:04] let me try once more [15:10:06] it ooks like it never even gets to the callback [15:10:12] still get the same output [15:10:13] ok [15:10:16] so I'm going to have a look at the twit library next [15:10:28] are you using the latest version of that? [15:16:07] apergos: [15:16:11] yes [15:16:28] (06:10:16 μμ) apergos: so I'm going to have a look at the twit library next [15:16:30] (06:10:28 μμ) apergos: are you using the latest version of that? [15:16:43] yea [15:16:43] (03PS1) 10Edward Chernenko: Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 [15:17:02] ok [15:19:35] ok before I look at libraries, let's try two more things [15:19:42] ok [15:20:12] one is: to see if you get output from a console.log statement after the request() call. [15:20:34] so right after this commented out lne [15:20:59] /var image_path = path.join(__dirname, '../data/ImagesDownloaded/' + image_name[2]), [15:21:01] that one [15:21:15] let's put a console.log 'after the request' or something [15:21:23] an run and see if that displays or not [15:22:20] 10MediaWiki-extensions-LoginNotify, 10Wikimedia-General-or-Unknown: security emails to users immediately - https://phabricator.wikimedia.org/T197524#4295461 (10Aklapper) @Nick_Levinson: Hi! It's unclear what this task exactly asks for. Please see and follow https://mediawiki.org/wiki/How_to_report_a_bug to str... [15:22:22] I trust nothing at this point so, step by step [15:24:00] apergos: It displays [15:24:19] I noticed something just now. [15:24:25] let's hear it [15:24:53] when I run npm run status it enters the request and callback perfectly [15:25:01] ok [15:25:14] but npm run reply doen't [15:25:24] so next I want, but we may get nothing useful, a try/catch around the request function there [15:25:40] (and you might as well put the {json: true} or whatever it is back in) [15:25:58] ok [15:26:03] and in the catch, console.log the error [15:26:17] and let's see if it thinks there is one somehow [15:26:22] I'm doubtful but whatever [15:27:09] atfer that the next thing to do is to set this: require('request').debug = true before the request, and see what that does [15:27:27] the require module docs recommend that for debgging [15:28:13] ok [15:28:25] so am puting the request in a try [15:28:28] ok [15:28:33] let's see how that goes first [15:28:59] if it was going to be that broken we should have herd about it before it got to the next logging statement but whatever [15:29:01] always worth a try [15:34:04] TypeError: request is not a function [15:34:24] is there a particular way I should put it in try? [15:34:38] can I see the snippet? [15:36:37] https://pastebin.com/wBEGLj05 [15:40:47] hm. asking google [15:47:08] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 2 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295230 (10TheDJ) > With CodeMirror enabled, ⇥ in edit textarea has another effect and does not naviga... [15:48:09] 10InternetArchiveBot: Support for Public Web Archive Lists - https://phabricator.wikimedia.org/T197543#4295470 (10Green_Cardamom) a:03Cyberpower678 [15:51:06] (03PS1) 10TheDJ: Accessibility: Disable both directions of tabbing in CodeMirror [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440749 (https://phabricator.wikimedia.org/T197534) [15:51:47] 10InternetArchiveBot: Support for Public Web Archive Lists - https://phabricator.wikimedia.org/T197543#4295485 (10Green_Cardamom) [15:56:32] r054l13 [15:56:37] yes [15:56:42] can you do me one more favor :-D [15:56:56] sure [15:57:12] before that try catch [15:57:26] can you console log the type of request? [15:57:30] let's see what it thnks it is [15:57:40] if it's not a function [15:58:09] ok [15:59:11] https://medium.com/adobetech/how-to-combine-rest-api-calls-with-javascript-promises-in-node-js-or-openwhisk-d96cbc10f299 [15:59:11] it might think it's an object, meh [15:59:24] paladox, we're trying not to do promises just yet [15:59:34] the request module is the vanilla one, not the promise one [15:59:53] apergos hmm, though i doin't think a function called "request" exists without promise [16:00:15] we might have to go for request.get(), i'll be looking at that shortly [16:00:40] i hope that's consiered a function for try-catch [16:01:09] (03PS3) 10Debenben: removed problematic texvc from VE suggestions [extensions/Math] - 10https://gerrit.wikimedia.org/r/440737 (https://phabricator.wikimedia.org/T195861) [16:01:47] but the docs and all the examples on the module's page have you just call the instantiated object with some args, and it is supposed to DTRT [16:02:33] there's a function 'request' right in index.js which sets everything up [16:02:39] (in the package) [16:03:22] it returns boolean' [16:03:37] boolean [16:03:49] well. that's certainly unexpected [16:04:09] well so I don't think it's a try-catch issue [16:04:17] 10MediaWiki-Authentication-and-authorization: Make it possible to prefill Special:BotPasswords form - https://phabricator.wikimedia.org/T197544#4295486 (10Petrb) [16:04:31] 10MediaWiki-Authentication-and-authorization, 10Huggle: Make it possible to prefill Special:BotPasswords form - https://phabricator.wikimedia.org/T197544#4295496 (10Petrb) [16:05:30] 10MediaWiki-Authentication-and-authorization, 10Huggle: Make it possible to prefill Special:BotPasswords form - https://phabricator.wikimedia.org/T197544#4295498 (10Petrb) p:05Triage>03Low [16:05:51] can you [16:05:58] this is going to sound really dumb but [16:06:44] righ tnow you have request = require('request'); [16:06:53] can you toss a 'var' or a 'const' in front of that? [16:07:36] right now i have request = require('request').debug = true; [16:07:42] ok [16:08:16] oh uh [16:08:19] wait wait wait [16:08:39] ok [16:08:47] first [16:08:56] put const request = require('request'); [16:08:57] second [16:10:36] not it returns function [16:10:47] after removing the debug [16:10:53] now* [16:10:56] (03PS1) 10TheDJ: Focus before setting the cursor/selection [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440750 (https://phabricator.wikimedia.org/T197263) [16:11:39] require('request').debug = true put that on a later line [16:11:55] that will turn on debugging [16:12:03] then let's run it again :-D [16:12:55] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10Patch-For-Review: insertTags shift cursor position to start of the line - https://phabricator.wikimedia.org/T197263#4295502 (10TheDJ) p:05Triage>03Low [16:13:51] oh you might be able to just say request.debug = true [16:13:53] anyways [16:14:03] ok [16:14:45] so we should have a try catch and have that request.debug on [16:14:49] and see what the output looks like [16:18:36] https://pastebin.com/5mQPgXjk [16:19:34] File:undefined [16:21:00] please use the emoji you know has an entry... [16:21:09] oops ok [16:21:39] (03PS4) 10Nikerabbit: Add es-419 [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) [16:22:18] I do see lots of nice dbeuggin output from requests, which means at least it is getting called [16:23:18] https://pastebin.com/7yPU5TH1 [16:23:43] apergos: hmm I ran npm run status at first [16:24:03] when? [16:24:31] the paste with debg output [16:25:30] ah [16:25:38] apergos: https://pastebin.com/7yPU5TH1 this is the paste from reply [16:25:43] ok [16:28:24] (03PS1) 10Nikerabbit: Only use languages with localisation in the installer [core] - 10https://gerrit.wikimedia.org/r/440751 [16:34:03] 10MediaWiki-Watchlist: Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) - https://phabricator.wikimedia.org/T197541#4295507 (10matej_suchanek) [16:39:19] apergos: I wan't to go and have a meal please. [16:39:27] please do [16:39:39] holler when you're done (no rush it's still early for me) [16:40:09] ok [16:40:14] :) [16:40:16] I'm walking through the code now from the reply entry point so it might take a bit [16:40:22] enjoy your dinner! [16:40:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "Confirmed. Both Makefiles this one refers to have been removed in Ic57d83f." [extensions/Math] - 10https://gerrit.wikimedia.org/r/440742 (https://phabricator.wikimedia.org/T195847) (owner: 10Physikerwelt) [16:40:30] thank you [16:41:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Improve test coverage for MathSource [extensions/Math] - 10https://gerrit.wikimedia.org/r/438246 (owner: 10Physikerwelt) [16:47:06] 10MediaWiki-extensions-Translate: subproject popup closes immediatly after display preventing rereader from selecting a subproject - https://phabricator.wikimedia.org/T184162#4295542 (10Nikerabbit) [16:48:34] 10MediaWiki-extensions-Translate, 10Security: Use the message group description as a tooltip for the links in the Translation statistics - https://phabricator.wikimedia.org/T184325#4295544 (10Nikerabbit) 05Open>03declined [16:49:06] 10MediaWiki-Interface, 10translatewiki.net, 10I18n: "Translate" links on Special:AllMessages should link directly to the respective messages at translatewiki.net - https://phabricator.wikimedia.org/T162190#4295547 (10Nikerabbit) [16:51:29] (03Merged) 10jenkins-bot: Cleanup: Remove Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/440742 (https://phabricator.wikimedia.org/T195847) (owner: 10Physikerwelt) [16:52:52] (03Merged) 10jenkins-bot: Improve test coverage for MathSource [extensions/Math] - 10https://gerrit.wikimedia.org/r/438246 (owner: 10Physikerwelt) [16:53:59] (03CR) 10jenkins-bot: Cleanup: Remove Makefile [extensions/Math] - 10https://gerrit.wikimedia.org/r/440742 (https://phabricator.wikimedia.org/T195847) (owner: 10Physikerwelt) [16:54:46] (03PS1) 10Thiemo Kreuz (WMDE): Make use of PHP's …::class feature [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440752 [16:55:33] 10MediaWiki-Watchlist: Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) - https://phabricator.wikimedia.org/T197541#4295561 (10Urbanecm) What cames to my mind: Try to disable "new filters for edit review" in Beta preferences, if it will change anything. [16:57:16] (03CR) 10jenkins-bot: Improve test coverage for MathSource [extensions/Math] - 10https://gerrit.wikimedia.org/r/438246 (owner: 10Physikerwelt) [16:58:10] (03PS1) 10Thiemo Kreuz (WMDE): Remove some non-helpful lines of documentation [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440753 [16:59:27] (03PS1) 10Thiemo Kreuz (WMDE): Avoid counting where not necessary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440754 [17:00:51] (03PS1) 10Thiemo Kreuz (WMDE): Update some PHPDoc tags for improved type safety [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440755 [17:00:54] (03CR) 10jerkins-bot: [V: 04-1] Update some PHPDoc tags for improved type safety [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440755 (owner: 10Thiemo Kreuz (WMDE)) [17:00:57] (03CR) 10jerkins-bot: [V: 04-1] Update some PHPDoc tags for improved type safety [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440755 (owner: 10Thiemo Kreuz (WMDE)) [17:01:00] (03PS2) 10Thiemo Kreuz (WMDE): Avoid counting where not necessary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440754 [17:04:59] (03PS2) 10Thiemo Kreuz (WMDE): Update some PHPDoc tags for improved type safety [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440755 [17:07:07] 10MediaWiki-Watchlist: Delete actions do dot appear on watchlist (Hungarian Wikipedia issue) - https://phabricator.wikimedia.org/T197541#4295564 (10Bencemac) @Urbanecm It doesn't help. It affects every editor, no matter they are using the old or the new watchlist. [17:11:54] (03CR) 10jerkins-bot: [V: 04-1] Avoid counting where not necessary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440754 (owner: 10Thiemo Kreuz (WMDE)) [17:13:22] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "From all my experience with very similar code this makes a lot of sense to me. No +2 yet because I have not tried this particular one myse" [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440750 (https://phabricator.wikimedia.org/T197263) (owner: 10TheDJ) [17:14:14] (03CR) 10jerkins-bot: [V: 04-1] Avoid counting where not necessary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440754 (owner: 10Thiemo Kreuz (WMDE)) [17:15:24] (03Abandoned) 10Thiemo Kreuz (WMDE): Ajout du fichier README [extensions/examples] - 10https://gerrit.wikimedia.org/r/440739 (owner: 10Tuxin) [17:19:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Given this is public it might be called anywhere. But I could not find a caller other than the one in the Minerva skin you already took ca" [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [17:24:19] (03PS3) 10Thiemo Kreuz (WMDE): Avoid counting where not necessary [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440754 [17:24:21] (03PS2) 10TheDJ: Accessibility: Disable both directions of tabbing in CodeMirror [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440749 (https://phabricator.wikimedia.org/T197534) [17:32:20] (03CR) 10MarcoAurelio: "Thank you." [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/440392 (https://phabricator.wikimedia.org/T197226) (owner: 10MarcoAurelio) [17:37:47] 10MediaWiki-Authentication-and-authorization, 10Huggle, 10Security: Make it possible to prefill Special:BotPasswords form - https://phabricator.wikimedia.org/T197544#4295577 (10Framawiki) Adding #security tag as this task is about prefilling a form that generate login tokens. [17:41:51] 10MediaWiki-History-or-Diffs, 10MediaWiki-Page-deletion, 10TechCom-RFC: RFC: Use ar_page_id to determine the parent IDs for undeleted revisions - https://phabricator.wikimedia.org/T193690#4295581 (10GeoffreyT2000) [17:54:09] 10ContributionScores, 10Patch-For-Review: Convert ContributionScores to use extension registration - https://phabricator.wikimedia.org/T174046#4295583 (10MarcoAurelio) [17:54:41] 10ContributionScores, 10Patch-For-Review: Convert ContributionScores to use extension registration - https://phabricator.wikimedia.org/T174046#3549184 (10MarcoAurelio) The tool that keeps track of the remaining work to do enforces a naming on the tasks. [17:55:25] 10ContributionScores, 10Patch-For-Review: Convert ContributionScores to use extension registration - https://phabricator.wikimedia.org/T174046#4295587 (10MarcoAurelio) [17:55:31] 10MediaWiki-Configuration, 10MediaWiki-extensions-General, 10Goal, 10Patch-For-Review: Convert all extensions and skins on git to use extension registration - https://phabricator.wikimedia.org/T98668#4295586 (10MarcoAurelio) [17:56:15] 10MediaWiki-extensions-Other: Convert BreadCrumbs2 to use extension registration - https://phabricator.wikimedia.org/T197546#4295588 (10MarcoAurelio) [17:56:36] 10Wikidata-Campsite: Minor adjustments in https://software.wikimedia.de/department - https://phabricator.wikimedia.org/T197094#4295599 (10hoo) Moving this back to "to do" as this isn't fully addressed AFAICT. [18:00:41] 10MediaWiki-extensions-Other: Convert BreadCrumbs2 to use extension registration - https://phabricator.wikimedia.org/T197546#4295602 (10MarcoAurelio) [18:00:58] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-MarcoAurelio: Convert BreadCrumbs2 to use extension registration - https://phabricator.wikimedia.org/T197154#4295604 (10MarcoAurelio) [18:05:43] (03CR) 10Hoo man: [C: 031] Make ChangeTag use NameTableStore for change_tag_def table (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440367 (https://phabricator.wikimedia.org/T193868) (owner: 10Ladsgroup) [18:12:04] (03CR) 10Legoktm: [C: 04-1] "It's a real bummer that they renamed it :( The patch looks good, thanks :) I left two inline suggestions." (032 comments) [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [18:23:43] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: Cannot switch between main pages using the language selector in the Android Wikipedia app - https://phabricator.wikimedia.org/T197547#4295615 (10Amire80) [18:34:05] <21WAALW9C> apergos: hi [18:34:39] Dereckson: hi [18:34:44] d3r1ck: hi [18:35:44] ah you are back [18:35:49] I was just writing an email [18:35:54] perhaps I will send it anyways [18:36:19] the short story is that the request module is async, which is the cause for the annoying undef [18:36:43] but you can sort of skirt around the promise mess; there's a module request-promise [18:36:53] and there is the await keyword [18:36:55] yes [18:37:03] it means ripping out the callbacks and this is a good thing [18:37:14] yes yes yes [18:37:15] alright [18:37:23] what you had there was one callback calling request with another clalback [18:37:32] you don't want to troll your own promises for that [18:37:39] or roll them either :-D [18:37:50] ok [18:37:59] let me give you a couple of links [18:38:04] and then I'll get this email written [18:38:23] https://www.npmjs.com/package/request-promise here's this [18:38:47] https://stackoverflow.com/questions/38428027/why-await-is-not-working-for-node-request-module here's the simplest await ever [18:38:50] but you will get the idea [18:38:58] more to come shortly [18:39:06] ok thanks [18:39:14] of course if anyone else is in here that wants to jump in and discuss this, feel free (especially co-mentors) [18:39:48] let me write this email and then I will be around if you want to chat about it/try things out [18:41:09] 10MobileFrontend, 10Wikimedia-Interwiki-links: Mobile Frontend shows interlanguage links differently on the main page - https://phabricator.wikimedia.org/T197548#4295633 (10Amire80) [18:42:51] ok am looking at the links then [18:52:20] email sent [18:58:34] (03CR) 10Jforrester: [C: 031] Replace uses of deprecated Language::truncate() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [18:59:55] (03CR) 10Jforrester: [C: 032] Replace uses of deprecated Language::truncate() [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/440610 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:00:29] (03CR) 10Jforrester: [C: 032] Replace uses of deprecated Language::truncate() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/440609 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:00:48] (03PS1) 10Eranroz: Fixing alignment of infoboxes for RTL/LTR [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/440759 (https://phabricator.wikimedia.org/T161399) [19:00:53] (03CR) 10Jforrester: [C: 032] Replace uses of deprecated Language::truncate() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/440575 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:00:56] (03CR) 10Jforrester: [C: 032] Replace uses of deprecated Language::truncate() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:06:01] (03CR) 10jerkins-bot: [V: 04-1] Fixing alignment of infoboxes for RTL/LTR [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/440759 (https://phabricator.wikimedia.org/T161399) (owner: 10Eranroz) [19:07:50] 10Wikimedia-Site-requests: Please update the interwiki cache - https://phabricator.wikimedia.org/T197549#4295658 (10MarcoAurelio) [19:08:21] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/OAuth] - 10https://gerrit.wikimedia.org/r/440610 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:09:35] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/440609 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:13:44] 10InternetArchiveBot: Support for Public Web Archive Lists - https://phabricator.wikimedia.org/T197543#4295671 (10Cyberpower678) It doesn’t seem to work. All I get is a blank page. [19:14:08] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/440575 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:14:11] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:14:20] 10Wikimedia-Site-requests: Please update the interwiki cache - https://phabricator.wikimedia.org/T197549#4295676 (10MarcoAurelio) p:05Triage>03Low [19:14:22] (03PS2) 10Eranroz: Fixing alignment of infoboxes for RTL/LTR [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/440759 (https://phabricator.wikimedia.org/T161399) [19:14:40] seen [19:16:32] 10Phabricator: Cannot view pages when logged into Phabricator under a not-yet-approved account. - https://phabricator.wikimedia.org/T197550#4295677 (10Ruakh) [19:19:06] r054l13: do you want to try to work with that for awhile? [19:19:10] or would you [19:19:11] hmm [19:19:17] it's almot 10:30 pm for me [19:19:31] that would be why my brain feels a bit tired now [19:19:52] but is there anything you would want to discuss for our check-in? [19:20:04] (03CR) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/440575 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:24:34] (03CR) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [19:26:01] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295690 (10PerfektesChaos) Well, the blind user did report that and I could reproduce it with Firefox... [19:31:28] 10MediaWiki-Parser, 10MediaWiki-extensions-Scribunto: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4295706 (10Krenair) Thanks, I did https://wikitech.wikimedia.org/w/index.php?title=Module:String&diff=1794872&oldid=120277 and then null-edited the page it showed on. L... [19:31:44] (03PS2) 10Edward Chernenko: Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 [19:32:51] (03CR) 10jerkins-bot: [V: 04-1] Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [19:36:51] I will take that as a no :-) [19:41:49] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295707 (10TheDJ) Just tried it again in FF on my mac, and for me tab moves to the editsummary. This m... [19:49:37] (03CR) 10Alex Monk: [C: 032] Get rid of call_user_func(_array)() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439385 (owner: 10MaxSem) [19:51:41] (03CR) 10Chasse20: "@Yaron Koren" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/434052 (owner: 10Chasse20) [19:52:17] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295718 (10PerfektesChaos) Well, might be OS/browser issue for unknown reason, interaction with other... [19:52:23] (03CR) 10Alex Monk: "good to go when inline comment is addressed" [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [19:55:19] (03CR) 10Jack Phoenix: "The UploadVerifyFile hook isn't marked as deprecated or otherwise obsolete, as far as I can see, but otherwise LGTM." [core] - 10https://gerrit.wikimedia.org/r/436325 (owner: 10Edward Chernenko) [19:56:57] (03Merged) 10jenkins-bot: Get rid of call_user_func(_array)() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439385 (owner: 10MaxSem) [20:01:27] (03CR) 10jenkins-bot: Get rid of call_user_func(_array)() [extensions/Flow] - 10https://gerrit.wikimedia.org/r/439385 (owner: 10MaxSem) [20:01:29] (03Abandoned) 10MarcoAurelio: Convert BreadCrumbs2 to use extension registration [extensions/BreadCrumbs2] - 10https://gerrit.wikimedia.org/r/440170 (https://phabricator.wikimedia.org/T197154) (owner: 10MarcoAurelio) [20:01:58] 10MediaWiki-extensions-Other: Convert BreadCrumbs2 to use extension registration - https://phabricator.wikimedia.org/T197154#4295721 (10MarcoAurelio) a:05MarcoAurelio>03None [20:03:56] 10Wikidata Mobile, 10Story: Select/unselect filter for languages - https://phabricator.wikimedia.org/T197124#4295724 (10Jonas) Reopen filter part is still missing. [20:03:58] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/440760 (owner: 10L10n-bot) [20:07:30] (03PS1) 10TheDJ: Accessibility: mark syntaxhighlight button as a switch [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440761 (https://phabricator.wikimedia.org/T197534) [20:09:25] (03CR) 10jerkins-bot: [V: 04-1] Accessibility: mark syntaxhighlight button as a switch [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440761 (https://phabricator.wikimedia.org/T197534) (owner: 10TheDJ) [20:11:34] (03CR) 10Jack Phoenix: [C: 031] "Yeah, seems only appropriate to use POST here since we're inside a special page which does writes." [core] - 10https://gerrit.wikimedia.org/r/440256 (https://phabricator.wikimedia.org/T196514) (owner: 10Bartosz Dziewoński) [20:12:31] (03CR) 10Jforrester: [C: 032] Remove all BetaFeatures support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440254 (https://phabricator.wikimedia.org/T185030) (owner: 10MaxSem) [20:14:58] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295738 (10TheDJ) Hmm, this proved more annoying than i figured. Notes 1: Old toolbar isn't accessibl... [20:15:15] (03CR) 10Krinkle: [C: 032] Add strict "array" and other type hints to method headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437195 (owner: 10Thiemo Kreuz (WMDE)) [20:16:50] (03CR) 10Krinkle: [C: 031] "Agreed. Although per the deprecation policy, we should still announce it to wikitech-l, and a breaking change release notes. Simply statin" [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [20:19:46] (03Merged) 10jenkins-bot: Remove all BetaFeatures support [extensions/CodeMirror] - 10https://gerrit.wikimedia.org/r/440254 (https://phabricator.wikimedia.org/T185030) (owner: 10MaxSem) [20:20:00] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Do we need to worry about these search results? https://github.com/search?q=doEditSectionLink&type=Code" [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [20:22:40] (03Merged) 10jenkins-bot: Add strict "array" and other type hints to method headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437195 (owner: 10Thiemo Kreuz (WMDE)) [20:23:10] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295740 (10TheDJ) p:05Triage>03Normal [20:25:03] 10MediaWiki-extensions-CodeMirror, 10Upstream: Middle-click to paste text doesn't work in CodeMirror on Linux - https://phabricator.wikimedia.org/T174635#4295742 (10TheDJ) 05Open>03stalled This ticket is stalled on the upstream issue. [20:25:39] 10Discovery, 10Wikimedia-Portals: ps.wikivoyage not appearing in www.wikivoyage.org - https://phabricator.wikimedia.org/T197061#4295756 (10Xaosflux) a:03Xaosflux [20:26:16] 10Discovery, 10Wikimedia-Portals: ps.wikivoyage not appearing in www.wikivoyage.org - https://phabricator.wikimedia.org/T197061#4277829 (10Xaosflux) Updated meta page, pending replication [20:26:36] 10Discovery, 10Wikimedia-Portals: ps.wikivoyage not appearing in www.wikivoyage.org - https://phabricator.wikimedia.org/T197061#4295759 (10Xaosflux) p:05Triage>03Normal [20:28:07] (03PS3) 10Edward Chernenko: Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 [20:28:33] (03CR) 10jenkins-bot: Add strict "array" and other type hints to method headers [extensions/Flow] - 10https://gerrit.wikimedia.org/r/437195 (owner: 10Thiemo Kreuz (WMDE)) [20:29:06] 10Design, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Change syntaxhighlight icon to something else than a previously signature pensil - https://phabricator.wikimedia.org/T197555#4295760 (10Base) [20:29:20] (03PS4) 10Fomafix: Use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/436216 [20:29:32] (03CR) 10Fomafix: "I added RELEASE-NOTES in PS4. Should the change split up to have a deprecation phase?" [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [20:29:44] (03CR) 10Edward Chernenko: "HHVM doesn't seem to like ...$args in call_user_func." [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [20:29:56] (03CR) 10jerkins-bot: [V: 04-1] Use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [20:30:04] (03CR) 10jerkins-bot: [V: 04-1] Use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [20:32:37] (03PS2) 10Ladsgroup: Make ChangeTag use NameTableStore for change_tag_def table [core] - 10https://gerrit.wikimedia.org/r/440367 (https://phabricator.wikimedia.org/T193868) [20:32:55] (03CR) 10Ladsgroup: Make ChangeTag use NameTableStore for change_tag_def table (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440367 (https://phabricator.wikimedia.org/T193868) (owner: 10Ladsgroup) [20:34:53] (03Abandoned) 10Jack Phoenix: New class for parsing MediaWiki:Sidebar-like messages into modern, nested navigation menus. [core] - 10https://gerrit.wikimedia.org/r/108045 (owner: 10Jack Phoenix) [20:35:43] (03Abandoned) 10Jack Phoenix: Use #mw-content-text instead of #content and #bodyContent [core] - 10https://gerrit.wikimedia.org/r/213601 (owner: 10Jack Phoenix) [20:35:56] 10Design, 10MediaWiki-General-or-Unknown, 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Change syntaxhighlight icon to something else than a previously signature pensil - https://phabricator.wikimedia.org/T197555#4295760 (10MusikAnimal) It's actually a [[ https://en.wiktionary.org/wiki/highlighter |... [20:36:07] (03Abandoned) 10Jack Phoenix: Convert the argument to a named option [core] - 10https://gerrit.wikimedia.org/r/302090 (owner: 10Jack Phoenix) [20:36:46] 10Discovery, 10Wikimedia-Portals: ps.wikivoyage not appearing in www.wikivoyage.org - https://phabricator.wikimedia.org/T197061#4295773 (10Xaosflux) [20:37:07] 10Discovery, 10Wikimedia-Portals: ps.wikivoyage not appearing in www.wikivoyage.org - https://phabricator.wikimedia.org/T197061#4277829 (10Xaosflux) [20:37:18] (03Abandoned) 10Jack Phoenix: PHP 7+ fixes for DifferenceEngine hooks which allow the hooked function(s) to access the DifferenceEngine object ($this) [core] - 10https://gerrit.wikimedia.org/r/367337 (owner: 10Jack Phoenix) [20:37:44] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: CodeMirror load breaks at $button.toggleClass(...) - https://phabricator.wikimedia.org/T196512#4259204 (10TheDJ) Ah, I found this too. This is https://github.com/wikimedia/mediawiki-extensions-CodeMirror/blob/master/resources/ext.CodeMirror.js#L194 .data( '... [20:37:47] (03Abandoned) 10Jack Phoenix: IGNORE duplicate key errors [extensions/AJAXPoll] - 10https://gerrit.wikimedia.org/r/363181 (https://phabricator.wikimedia.org/T163625) (owner: 10Jack Phoenix) [20:37:56] 10MediaWiki-extensions-CodeMirror, 10Community-Tech: CodeMirror load breaks at $button.toggleClass(...) - https://phabricator.wikimedia.org/T196512#4295778 (10TheDJ) p:05Triage>03Low [20:38:01] (03PS4) 10Edward Chernenko: Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 [20:44:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/440765 (owner: 10L10n-bot) [20:47:14] 10Timeless: Subsection/section distinction should be clearer - https://phabricator.wikimedia.org/T197522#4295779 (10Isarra) Possibilities: * add underline to h3, but smaller than h2/h1 * lose serifs for h3-h6 or h4-h6 [20:47:40] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/440767 (owner: 10L10n-bot) [20:48:05] 10Timeless: Subsection/section distinction should be clearer - https://phabricator.wikimedia.org/T197522#4295780 (10Isarra) Other issue: using serifs for all can be a bit jarring for users if they are used to vector, as that only uses serifs on headers with an underline. [20:51:02] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/440770 (owner: 10L10n-bot) [20:52:48] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/440774 (owner: 10L10n-bot) [20:55:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440776 (owner: 10L10n-bot) [20:55:44] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10WikiEditor: CodeMirror – icon extends from bar - https://phabricator.wikimedia.org/T197239#4295782 (10TheDJ) I've checked. The other buttons have the same issue, it's just that they don't have an outline and backgroundcolor set as this button does in the... [20:56:11] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageViewInfo] - 10https://gerrit.wikimedia.org/r/440775 (owner: 10L10n-bot) [20:57:09] (03PS5) 10Fomafix: Use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/436216 [20:57:55] 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, and 3 others: CodeMirror syntax highlighting shows overlapping text when word-wrap (hyphens, word-break) is overridden - https://phabricator.wikimedia.org/T192019#4124623 (10TheDJ) So is this f... [20:59:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/440779 (owner: 10L10n-bot) [21:03:50] 10MediaWiki-extensions-CodeMirror, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor, 10User-Ryasmeen: CodeMirror on NWE: pasting problems from one surface to another - line size? - https://phabricator.wikimedia.org/T175961#4295788 (10TheDJ) 05Open>03Resolved a:03TheDJ i'm pretty sure this... [21:05:50] 10MediaWiki-extensions-CodeMirror, 10Patch-For-Review: Implement syntax highlight for U+00A0 (no-break space, nbsp) - https://phabricator.wikimedia.org/T181677#3797992 (10TheDJ) https://github.com/coderaiser/cm-show-invisibles [21:06:10] 10InternetArchiveBot: Support for Public Web Archive Lists - https://phabricator.wikimedia.org/T197543#4295794 (10Green_Cardamom) For the mementoweb.org link? Try view source, different browser or wget or curl GET [21:10:09] (03CR) 10Krinkle: [C: 031] Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [21:10:13] (03PS5) 10Krinkle: Xhprof: support tideways-xhprof extension [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [21:11:12] (03CR) 10Chasse20: "@Yaron Koren" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/434052 (owner: 10Chasse20) [21:11:44] (03CR) 10Krinkle: [C: 04-1] Get rid of call_user_func_array() [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/438194 (owner: 10MaxSem) [21:12:56] 10MediaWiki-Page-editing, 10MediaWiki-extensions-CodeMirror, 10Community-Tech: Collapse templates in editor - https://phabricator.wikimedia.org/T30684#4295796 (10TheDJ) [21:13:00] 10MediaWiki-Page-editing, 10MediaWiki-Templates, 10MediaWiki-extensions-CodeMirror: Syntax sensitive and highlighting source code editor for template code wanted - https://phabricator.wikimedia.org/T166098#4295795 (10TheDJ) [21:16:51] 10MediaWiki-extensions-CodeMirror, 10I18n, 10RTL: Support CodeMirror syntax highlighting on RTL wikis - https://phabricator.wikimedia.org/T170001#4295798 (10TheDJ) [21:16:53] 10MediaWiki-extensions-CodeMirror: Syntax Highlighting: Translated magic words aren't recognized in Hebrew - https://phabricator.wikimedia.org/T170004#4295797 (10TheDJ) [21:18:09] 10Design, 10VisualEditor, 10VisualEditor-ContentLanguage, 10VisualEditor-EditingTools: Allow editors to add and see existing soft hypen (­) non-visible characters where needed - https://phabricator.wikimedia.org/T134269#2260354 (10TheDJ) Relates to {T181677} [21:22:55] 10Timeless: Font stack is dumb - https://phabricator.wikimedia.org/T173228#4295803 (10Isarra) Also the content fonts are dumb. [21:23:54] 10MediaWiki-Page-editing: Add syntax highlighting to Edit box - https://phabricator.wikimedia.org/T13627#4295805 (10TheDJ) 05Open>03Resolved a:03Pastakhov With #mediawiki-extensions-codemirror now deployed, I'm calling this fixed. [21:26:36] 10Timeless: Rethink font stack for Timeless skin - https://phabricator.wikimedia.org/T173228#4295808 (10Krinkle) [21:27:27] 10Timeless: Rethink font stack for Timeless skin - https://phabricator.wikimedia.org/T173228#4295809 (10Isarra) Another idea: Why not use times or something for the article title, and just use sans-serif for the rest [21:34:37] (03PS2) 10Edward Chernenko: docs/hooks.txt: fix incorrect description of UploadForm:* hooks [core] - 10https://gerrit.wikimedia.org/r/436325 [21:39:24] 10MediaWiki-extensions-OATHAuth, 10Stewards-and-global-tools, 10Trust-and-Safety: Be able to force OATHAuth for certain user groups - https://phabricator.wikimedia.org/T150562#4295810 (10jrbs) Adding T&S since resetting these is presently a responsibility we've been taking on. [21:48:30] (03CR) 10Krinkle: [C: 031] Xhprof: support tideways-xhprof extension (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440747 (owner: 10Edward Chernenko) [22:11:03] 10Community-Liaisons, 10Readers-Community-Engagement, 10Readers-Web-Backlog, 10Hindi-Sites, 10Reading-Web-Local-Wiki-Issues: Hindi MainPage should use Template Styles (migrate all MediaWiki:Mobile.css and MediaWiki:MobileMainPage.css styles to templates) - https://phabricator.wikimedia.org/T195813#4295815... [22:25:25] (03PS1) 10Paladox: Do not call class functions in magic i18n file [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/440806 [22:27:29] (03PS2) 10Paladox: Do not call class functions in magic i18n file [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/440806 [22:28:54] (03CR) 10Paladox: "This change is ready for review." [extensions/SubpageFun] - 10https://gerrit.wikimedia.org/r/440806 (owner: 10Paladox) [22:32:35] (03PS1) 10Paladox: Do not call class functions in magic i18n file [extensions/SubpageFun] (REL1_31) - 10https://gerrit.wikimedia.org/r/440807 [22:41:42] 10Accessibility, 10MediaWiki-extensions-CodeMirror, 10Community-Tech, 10VisualEditor, and 3 others: CodeMirror toggle buttons need to indicate the current state - https://phabricator.wikimedia.org/T197534#4295820 (10PerfektesChaos) Thank you for your work until here. Old trappers overcome the single butto... [22:50:32] 10Phabricator: Cannot view pages when logged into Phabricator under a not-yet-approved account. - https://phabricator.wikimedia.org/T197550#4295824 (10MZMcBride) p:05Triage>03High [22:55:17] (03PS1) 10Paladox: Only create table globalblocks if it does not exist [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/440808 [22:58:20] (03Abandoned) 10Paladox: Only create table globalblocks if it does not exist [extensions/GlobalBlocking] - 10https://gerrit.wikimedia.org/r/440808 (owner: 10Paladox) [23:07:13] 10Phabricator: Cannot view pages when logged into Phabricator under a not-yet-approved account. - https://phabricator.wikimedia.org/T197550#4295825 (10Aklapper) p:05High>03Triage @MzMcBride: Resetting priority - if you think this is high priority please explain why. [23:18:58] (03CR) 10Krinkle: [V: 032 C: 032] Archive the ClientSide extension [extensions] - 10https://gerrit.wikimedia.org/r/440723 (https://phabricator.wikimedia.org/T196617) (owner: 10MarcoAurelio) [23:19:18] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10User-MarcoAurelio: Archive the ClientSide extension - https://phabricator.wikimedia.org/T196617#4295828 (10Krinkle) [23:19:30] 10MediaWiki-extensions-Other, 10Cleanup, 10GitHub-Mirrors, 10Repository-Admins, 10User-MarcoAurelio: Archive the ClientSide extension - https://phabricator.wikimedia.org/T196617#4263344 (10Krinkle) 05Open>03Resolved Thanks @MarcoAurelio ! [23:23:11] 10MediaWiki-extensions-CodeReview, 10Code-Stewardship-Reviews, 10Wikimedia-Site-requests, 10Technical-Debt: Undeploy CodeReview - https://phabricator.wikimedia.org/T116948#4295834 (10Krinkle) [23:23:13] 10MediaWiki-extensions-CodeReview, 10Code-Stewardship-Reviews, 10Wikimedia-Site-requests, 10Technical-Debt: Undeploy CodeReview - https://phabricator.wikimedia.org/T116948#1762776 (10Krinkle) [23:32:49] 10MediaWiki-Parser: Create a / tag - https://phabricator.wikimedia.org/T195222#4219805 (10Pppery) Unnecessary feature bloat [23:36:02] 10Timeless: Maybe move sidebar to bottom when editing? - https://phabricator.wikimedia.org/T197556#4295839 (10RileyBugz) [23:38:14] 10Timeless: Decrease margin size for headings. - https://phabricator.wikimedia.org/T197557#4295848 (10RileyBugz) [23:42:49] (03CR) 10TerraCodes: "Succeed by Ia148d7036007f31800be3170238b2045bcd6a822" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/432768 (owner: 10Cirdan)