[00:00:01] 10Page-Previews, 10Readers-Web-Backlog: Popups leave a large margin between thumbnail and description when thumbnail is narrow - https://phabricator.wikimedia.org/T192928#4154148 (10Jdlrobson) [00:00:03] 10Page-Previews, 10Readers-Web-Backlog: Blank or white background images look abruptly cut off in Page Previews - https://phabricator.wikimedia.org/T191267#4294414 (10Jdlrobson) [00:01:19] (03PS1) 10Jdlrobson: Add SVG border using polyline element [extensions/Popups] - 10https://gerrit.wikimedia.org/r/440645 (https://phabricator.wikimedia.org/T192928) [00:01:28] (03CR) 10jerkins-bot: [V: 04-1] Add SVG border using polyline element [extensions/Popups] - 10https://gerrit.wikimedia.org/r/440645 (https://phabricator.wikimedia.org/T192928) (owner: 10Jdlrobson) [00:01:47] 10Page-Previews, 10Readers-Web-Backlog, 10Patch-For-Review: Popups leave a large margin between thumbnail and description when thumbnail is narrow - https://phabricator.wikimedia.org/T192928#4294417 (10Jdlrobson) Okay, I spent an afternoon looking into this and I've come up with a solution using SVG polyline... [00:04:43] 10Cleanup: Archive operations/puppet/varnishkafka repository - https://phabricator.wikimedia.org/T197503#4294420 (10Krinkle) [00:14:38] (03PS4) 10MaxSem: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 [00:16:43] (03CR) 10Reedy: [C: 04-1] Clean up some phpcs problems (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [00:17:03] (03CR) 10jenkins-bot: Move 2 directories to PSR-4 autoloading [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/439827 (owner: 10Legoktm) [00:17:35] (03PS15) 10MusikAnimal: Add Draft namespace pages to the queue [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/436472 (owner: 10Samwilson) [00:17:38] (03PS14) 10MusikAnimal: [WIP] Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) [00:18:28] (03PS5) 10MaxSem: Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 [00:18:30] (03CR) 10MaxSem: Clean up some phpcs problems (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [00:19:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [00:23:09] (03CR) 10jerkins-bot: [V: 04-1] Clean up some phpcs problems [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440607 (owner: 10MaxSem) [00:23:56] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Add AfC state filters for drafts [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440018 (https://phabricator.wikimedia.org/T195924) (owner: 10MusikAnimal) [00:24:52] (03PS1) 10C. Scott Ananian: Replace uses of deprecated Language::truncate() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440648 (https://phabricator.wikimedia.org/T197492) [00:36:20] (03CR) 10jerkins-bot: [V: 04-1] Replace uses of deprecated Language::truncate() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440648 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [00:44:28] (03CR) 10C. Scott Ananian: "recheck" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440648 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:11:56] (03PS2) 10C. Scott Ananian: Hard deprecate Language::truncate() [core] - 10https://gerrit.wikimedia.org/r/440173 (https://phabricator.wikimedia.org/T197492) [01:15:43] (03CR) 10C. Scott Ananian: [C: 04-2] "Self C-2 to prevent merge to core before more of the truncate-deprecation topic patches are merged." [core] - 10https://gerrit.wikimedia.org/r/440173 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:16:41] (03CR) 10Krinkle: [C: 032] Record performance.now on survey impressions [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/439304 (https://phabricator.wikimedia.org/T196775) (owner: 10Gilles) [01:23:03] (03CR) 10Krinkle: [C: 031] Depend upon EventLogging in the proper way [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/439822 (owner: 10Legoktm) [01:23:15] (03Merged) 10jenkins-bot: Record performance.now on survey impressions [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/439304 (https://phabricator.wikimedia.org/T196775) (owner: 10Gilles) [01:23:20] (03CR) 10Krinkle: [C: 031] Register EventLogging schemas in extension.json [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/439823 (owner: 10Legoktm) [01:24:07] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Language::truncate() [core] - 10https://gerrit.wikimedia.org/r/440173 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:24:55] (03CR) 10Krinkle: [C: 032] Register EventLogging schema in extension.json [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/439819 (owner: 10Legoktm) [01:25:24] (03CR) 10Krinkle: [C: 032] Switch to PSR-4 autoloader [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/439821 (owner: 10Legoktm) [01:25:28] (03CR) 10jenkins-bot: Record performance.now on survey impressions [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/439304 (https://phabricator.wikimedia.org/T196775) (owner: 10Gilles) [01:32:09] (03CR) 10Krinkle: [C: 04-1] Replace uses of deprecated Language::truncate() (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:32:17] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/440635 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:32:49] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/440631 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:33:12] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/440620 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:33:50] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/440616 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:34:04] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440648 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:36:30] (03Merged) 10jenkins-bot: Register EventLogging schema in extension.json [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/439819 (owner: 10Legoktm) [01:36:32] (03Merged) 10jenkins-bot: Switch to PSR-4 autoloader [extensions/RelatedArticles] - 10https://gerrit.wikimedia.org/r/439821 (owner: 10Legoktm) [01:49:28] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/OpenStackManager] - 10https://gerrit.wikimedia.org/r/440635 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:49:30] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/440631 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:49:32] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/DisableAccount] - 10https://gerrit.wikimedia.org/r/440620 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:49:35] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/ArticleFeedbackv5] - 10https://gerrit.wikimedia.org/r/440616 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [01:49:38] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/440648 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [05:03:11] 10MediaWiki-Language-converter, 10I18n: LanguageConverter for Javanese (from jv-Latn to jv-Java) - https://phabricator.wikimedia.org/T47779#4294465 (10Bennylin) Thanks Trey. I'm interested in the last option, but I'd like to hear others chimed in first. [06:47:23] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#4294472 (10Dalba) 05Resolved>03Open Sorry for reviving an old task. But I can't create any new tasks and I'm getting the s... [06:51:09] 10UI-Standardization, 10Advanced-Search, 10TCB-Team, 10MW-1.32-release-notes (WMF-deploy-2018-06-05 (1.32.0-wmf.7)), and 2 others: Reposition the info (i) to match the standard OOUI look - https://phabricator.wikimedia.org/T182125#4294484 (10Lea_WMDE) [07:04:13] 10CirrusSearch, 10Discovery, 10Discovery-Search: CirrusSearch don't find exact called title (redirect) - https://phabricator.wikimedia.org/T196820#4294502 (10Lea_WMDE) [08:02:53] 10MediaWiki-History-or-Diffs, 10WMDE-QWERTY-Team, 10Patch-For-Review: Show changes in moved paragraphs for mobile - https://phabricator.wikimedia.org/T191310#4294531 (10Lea_WMDE) [08:02:58] 10MediaWiki-History-or-Diffs, 10WMDE-QWERTY-Team, 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10WMDE-QWERTY-Sprint-2018-05-16: Change config to disable new mobile behavior on all wikis except beta - https://phabricator.wikimedia.org/T194271#4294530 (10Lea_WMDE) 05Open>03Resolved [09:15:03] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata: Evaluate Special:ItemDisambiguation usages - https://phabricator.wikimedia.org/T196935#4273339 (10waldyrious) Just for completeness, I'm copying the comment I added in T195754: >>! In T195754#4238412, @waldyrious wrote: > FWIW, I use this quite often (man... [09:19:57] 10ULS-CompactLinks, 10UniversalLanguageSelector: ULS panel may hide some languages in the search results - https://phabricator.wikimedia.org/T197504#4294542 (10Amire80) [09:21:46] (03PS24) 10Matěj Suchánek: HistoryAction: Implement HistoryPageToolLinks hook for adding more links [core] - 10https://gerrit.wikimedia.org/r/120811 (https://phabricator.wikimedia.org/T28934) (owner: 10Tinaj1234) [09:22:34] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294556 (10RazeSoldier) [09:27:11] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294558 (10RazeSoldier) Please assign windows and monitor the deployment process, thanks! [09:28:25] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294561 (10Urbanecm) a:03RazeSoldier Can do. [09:28:32] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294563 (10Urbanecm) p:05Triage>03Normal [09:29:07] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#2037755 (10Peachey88) >>! In T127271#4294472, @Dalba wrote: > Sorry for reviving an old task. But I can't create any new tasks... [09:36:28] (03CR) 10Samwilson: [C: 032] "Works in my testing." [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440606 (owner: 10MaxSem) [09:36:48] 10MediaWiki-extensions-Translate, 10UniversalLanguageSelector: ULS language selector tooltip displays titles written in original languages - https://phabricator.wikimedia.org/T195803#4294576 (10Amire80) I can reproduce this. The reason is that we don't have the name of the language in user's language in all c... [09:41:52] (03PS1) 10Samwilson: Add method visibilities and remove phpcs exclusion [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440653 [09:42:22] (03Merged) 10jenkins-bot: Adapt to core changes, fix deprecation warnings [extensions/EditUser] - 10https://gerrit.wikimedia.org/r/440606 (owner: 10MaxSem) [09:44:57] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4141442 (10Psuranas) I want to work on this issue where can i see the code and start working on it [10:06:26] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294591 (10Sanmosa) >>! In T193983#4294561, @Urbanecm wrote: > Can do. "zh-my" is still... [10:07:02] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4141442 (10RazeSoldier) It's [[ https://github.com/wikimedia/mediawiki-extensions-Thanks | here ]]. [10:07:35] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294594 (10Urbanecm) The change wasn't enabled. It was just proposed. We must wait for a... [10:12:35] 10MediaWiki-Language-converter, 10Wikimedia-Site-requests, 10Chinese-Sites, 10Patch-For-Review, 10User-Urbanecm: Enable zh-my language localization at the Chinese Wikipedia - https://phabricator.wikimedia.org/T193983#4294606 (10RazeSoldier) >>! In T193983#4294591, @Sanmosa wrote: >>>! In T193983#4294561,... [10:27:10] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#4294619 (10Dalba) Thank you, @Peachey88! I can create new tasks now. I'm leaving this task open for Phab admins to decide if i... [10:33:03] 10Repository-Admins: Maintainer access for Wikimedia Commons Android Tools project - https://phabricator.wikimedia.org/T197204#4294621 (10mmodell) @maskaravivek you should be able to push now. [10:38:03] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4294622 (10Psuranas) Ok, but exactly which file do I need to modify or which file contains the css of this button. >>! In T192513#4294592, @RazeSoldier wrote: > >... [10:39:29] 10InternetArchiveBot: Bot changed a link that works - https://phabricator.wikimedia.org/T196539#4294623 (10FranzGall) Has there been any progress regarding the fact that InternetArchiveBot changes links that actually work? That's the first issue. The second issue is that the code {{cbignore}} obviously doesn't d... [10:52:04] 04(no projects): Add namespace alias on ps.wikivoyage - https://phabricator.wikimedia.org/T197507#4294624 (10Baloch007) [10:52:39] 10Developer-Relations (Apr-Jun-2018): Release "New Developers Quarterly Report" for April-June 2018 in early July 2018 - https://phabricator.wikimedia.org/T193819#4294635 (10Aklapper) [10:52:41] 10Developer-Relations (Apr-Jun-2018): Andre to provide "New Authors" data from March, April, May 2018 to Srishti in June - https://phabricator.wikimedia.org/T196408#4294633 (10Aklapper) 05Open>03Resolved Alright... * https://gitlab.com/Bitergia/c/Wikimedia/support/issues/33 got fixed. * Now https://wikimedia... [10:57:42] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4294636 (10RazeSoldier) >>! In T192513#4294622, @Psuranas wrote: > Ok, but exactly which file do I need to modify or which file contains the css of this button. ht... [10:58:55] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#4294637 (10Aklapper) @Dalba: Can you please provide exact steps to reproduce and explicitly include full URL links? I don't h... [11:02:55] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#2037755 (10Legoktm) Others reported this issue as well. From `#mediawiki`: ```lang=irc [11:16:56] Hallo. [11:17:06]... [11:09:28] (03PS7) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [11:09:36] (03CR) 10jerkins-bot: [V: 04-1] Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:14:50] (03CR) 10Legoktm: [C: 04-1] Switch to output HTML
 instead of 
(031 comment) [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:17:00] (03PS8) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [11:18:34] (03CR) 10jerkins-bot: [V: 04-1] Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:19:28] (03PS9) 10TTO: Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) [11:21:09] (03CR) 10jerkins-bot: [V: 04-1] Switch to output HTML
 instead of 
[extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:24:05] (03CR) 10TTO: Switch to output HTML
 instead of 
(031 comment) [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:24:29] (03CR) 10TTO: Switch to output HTML
 instead of 
(031 comment) [extensions/Poem] - 10https://gerrit.wikimedia.org/r/328887 (https://phabricator.wikimedia.org/T194651) (owner: 10TTO) [11:25:22] 10MediaWiki-extensions-Poem, 10Patch-For-Review: Smooth out quirks in the tag to ease consistent rendering across parsers - https://phabricator.wikimedia.org/T194651#4294645 (10TTO) @cscott @ssastry Here is what I have come up with: My latest reimplementation of `` is indent-pre with the followin... [11:26:47] legoktm: Aren't you meant to be on vacationnnnnnnn? [11:27:31] tto: maybe >.< [11:28:08] but the lure of nasty parsing code is irresistible, isn't it? :) [11:33:38] 10Wikimedia-Site-requests: Add namespace alias on ps.wikivoyage - https://phabricator.wikimedia.org/T197507#4294676 (10Aklapper) @Baloch007: Please follow https://meta.wikimedia.org/wiki/Requesting_wiki_configuration_changes when filing such requests. Adding #wikimedia-site-requests [11:34:11] 10Wikimedia-Site-requests: Add namespace alias on ps.wikivoyage - https://phabricator.wikimedia.org/T197507#4294678 (10Urbanecm) [11:34:46] 10Wikimedia-Site-requests, 10Community-consensus-needed: Add namespace alias on ps.wikivoyage - https://phabricator.wikimedia.org/T197507#4294624 (10Urbanecm) Community consensus wanted. Please link to your local discussion. [11:34:55] 10Wikimedia-Site-requests, 10Community-consensus-needed: Add namespace alias on ps.wikivoyage - https://phabricator.wikimedia.org/T197507#4294683 (10Urbanecm) p:05Triage>03Low [11:37:08] tto: the internet here is too slow to do anything but code review :p [11:37:46] anyways, bye :) [11:39:53] 10Phabricator, 10Release-Engineering-Team (Kanban), 10WorkType-Maintenance: Phabricator errors when filing (creating) a new Maniphest task - https://phabricator.wikimedia.org/T127271#4294685 (10Dalba) @Aklapper, I cannot reproduce it now that I am in #Trusted-Contributors group, but before that, I could easi... [12:31:37] 10MediaWiki-General-or-Unknown, 10Patch-For-Review, 10Technical-Debt: Deprecate and remove Language::truncate() - https://phabricator.wikimedia.org/T197492#4294696 (10Aklapper) [12:45:09] (03CR) 10Hoo man: [C: 032] Add maintenance to populate change_tag_def table and ct_tag_id field [core] - 10https://gerrit.wikimedia.org/r/437642 (https://phabricator.wikimedia.org/T193871) (owner: 10Ladsgroup) [12:49:14] 10MediaWiki-Parser: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294698 (10Krenair) [12:49:59] 10MediaWiki-Parser: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294708 (10Krenair) {F22295347} [12:52:12] 10MediaWiki-Parser: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294709 (10Krenair) Interestingly if I dump the page wikitext into Special:ExpandTemplates it doesn't do this [12:52:53] 10MediaWiki-extensions-WikibaseClient, 10Wikibase-Lua, 10Wikidata, 10Wikidata-Campsite, and 3 others: Find a better solution for dewiki's Modul:Wikidata isParent - https://phabricator.wikimedia.org/T179155#4294710 (10hoo) >>! In T179155#4293641, @Lydia_Pintscher wrote: > Has it been added to the Lua docume... [12:52:55] 10InternetArchiveBot: Bot changed a link that works - https://phabricator.wikimedia.org/T196539#4294711 (10Cyberpower678) Hi, and sorry for the delayed response. The reason why {{cbignore}} does nothing on svwiki is because the templates didn't exist when IABot was deployed there and thus never added in the con... [12:56:25] 10MediaWiki-Parser: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294724 (10Krenair) The template it's using creates this bit with a `{{#invoke:String`, don't know if that Scribunto code is supposed to be able to get at parser internals like this. [12:57:21] 10InternetArchiveBot: Bot changed a link that works - https://phabricator.wikimedia.org/T196539#4294725 (10Cyberpower678) Also as for the original question as to whether or not you left the report in the right place, the answer is yes, you did. Phabricator is the official bug reporting tool of the WMF. All Wik... [12:59:29] (03Merged) 10jenkins-bot: Add maintenance to populate change_tag_def table and ct_tag_id field [core] - 10https://gerrit.wikimedia.org/r/437642 (https://phabricator.wikimedia.org/T193871) (owner: 10Ladsgroup) [13:02:44] (03CR) 10jenkins-bot: Add maintenance to populate change_tag_def table and ct_tag_id field [core] - 10https://gerrit.wikimedia.org/r/437642 (https://phabricator.wikimedia.org/T193871) (owner: 10Ladsgroup) [13:09:50] 10MediaWiki-Special-pages, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: VisualEditor's 2017 Wikitext Editor shouldn't appear when an article fails to be moved - https://phabricator.wikimedia.org/T197512#4294728 (10Numbermaniac) [13:12:19] 10MediaWiki-Debug-Logger, 10MediaWiki-Parser, 10MediaWiki-extensions-Scribunto, 10I18n: Incorrect formatting of "Lua - minnesanvändning" ("Lua memory usage") in Parser Profiling Data in Swedish Wikipedia - https://phabricator.wikimedia.org/T197451#4294740 (10Nirmos) The relevant messages here are `scribunt... [13:20:38] 10MinervaNeue (Tracking), 10Patch-For-Review, 10Readers-Web-Backlog (Tracking), 10VisualEditor (Current work): VisualEditor error message for read only mode not loading on mobile - https://phabricator.wikimedia.org/T197498#4294748 (10Esanders) [13:20:41] 10MediaWiki-Special-pages, 10VisualEditor, 10VisualEditor-MediaWiki-2017WikitextEditor: VisualEditor's 2017 Wikitext Editor shouldn't appear when an article fails to be moved - https://phabricator.wikimedia.org/T197512#4294749 (10Numbermaniac) [13:25:10] (03CR) 10C. Scott Ananian: Replace uses of deprecated Language::truncate() (031 comment) [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [13:25:29] (03PS2) 10C. Scott Ananian: Replace uses of deprecated Language::truncate() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) [13:30:24] (03CR) 10C. Scott Ananian: Replace uses of deprecated Language::truncate() (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [13:30:44] (03PS2) 10C. Scott Ananian: Replace uses of deprecated Language::truncate() [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440574 (https://phabricator.wikimedia.org/T197492) [13:33:06] 10MediaWiki-Special-pages, 10VisualEditor, 10VisualEditor-MediaWiki, 10VisualEditor-MediaWiki-2017WikitextEditor: VisualEditor's 2017 Wikitext Editor shouldn't appear when an article fails to be moved - https://phabricator.wikimedia.org/T197512#4294753 (10Numbermaniac) [13:46:30] (03CR) 10Nikerabbit: "I suppose it needs a similar fix what you did for Special:Preferences." [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) (owner: 10Nikerabbit) [13:53:32] 10MediaWiki-Parser: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294763 (10Aklapper) [13:57:47] 10Phabricator: Username change: Phantom42 -> nikitavbv (on Phabricator) - https://phabricator.wikimedia.org/T197513#4294766 (10Phantom42) [14:01:29] 10MediaWiki-Parser, 10MediaWiki-extensions-Scribunto: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294777 (10Krenair) To be honest I'm not sure how to tell if this is actually a MW parser problem, Scribunto extension problem, or a problem with the String module on w... [14:06:04] 10Phabricator: Username change: Phantom42 -> nikitavbv (on Phabricator) - https://phabricator.wikimedia.org/T197513#4294779 (10Aklapper) 05Open>03Resolved a:03Aklapper Sure! Done [14:11:20] 04(no projects): Write blog post about changes in PAWS with JupyterHub 0.9 deployment - https://phabricator.wikimedia.org/T197514#4294783 (10Chicocvenancio) [14:12:10] 10PAWS (JupyterHub 0.9): Write blog post about changes in PAWS with JupyterHub 0.9 deployment - https://phabricator.wikimedia.org/T197514#4294793 (10Chicocvenancio) p:05Triage>03Normal [14:17:35] 10Android-app-feature-Multilingual, 10Wikipedia-Android-App-Backlog, 10Epic: Translate image captions from Commons within the Android app - https://phabricator.wikimedia.org/T197155#4280279 (10Kaartic) Hi @RHo. Stumbled upon this task task recently. Sounds very interesting! Just leaving a little thought I ha... [14:24:23] 10Repository-Admins: Maintainer access for Wikimedia Commons Android Tools project - https://phabricator.wikimedia.org/T197204#4294807 (10maskaravivek) Yes, now I am able to push to the repo. Thanks a lot, @mmodell. [14:34:14] 10Page-Previews, 10Readers-Web-Backlog (Design): Clickable area on the panel is strange - https://phabricator.wikimedia.org/T192773#4294812 (10alexhollender) @Jdlrobson I think this is good to go? Design notes in the description describe what the UX should be. [14:36:30] 10MobileFrontend, 10Readers-Web-Backlog (Design): Wikitext editor error handling broken in read only mode - https://phabricator.wikimedia.org/T197499#4294813 (10alexhollender) @Jdlrobson the red error inside of the editing space looks good 👍 [14:39:25] 10Wikimedia-Site-requests, 10Community-consensus-needed, 10Russian-Sites: Abbreviations for namespaces to ruwikiquote - https://phabricator.wikimedia.org/T197058#4294815 (10Liuxinyu970226) [15:06:15] 10MediaWiki-extensions-Scribunto: pairs() doesn't preserve the order of parameters passed to the module - https://phabricator.wikimedia.org/T197516#4294816 (10Jack_who_built_the_house) [15:39:07] 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team: Gadget CSS should be applied after Site styles - https://phabricator.wikimedia.org/T191941#4294826 (10Krinkle) @Dispenser Please specify the wiki+page and/or full url at which you can consistently see this, and whether it applies to logged-in, logged... [15:39:17] 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team: Gadget CSS should be applied after Site styles - https://phabricator.wikimedia.org/T191941#4294828 (10Krinkle) 05stalled>03Open [15:39:26] 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team, 10Regression: Gadget CSS should be applied after Site styles - https://phabricator.wikimedia.org/T191941#4122043 (10Krinkle) p:05Triage>03High [15:55:55] 10UI-Standardization, 10ContentTranslation, 10Patch-For-Review, 10UI-Standardization-Kanban: Use 14px font size in ContentTranslation - https://phabricator.wikimedia.org/T191432#4294838 (10Esanders) Where is the task discussing increasing the default font size to 16px, and what is the timeline for it? It s... [16:05:03] (03PS1) 10Physikerwelt: Fix ContentMathFormatter [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/440668 [16:47:49] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4294853 (10kaldari) [16:49:41] 10Design, 10Collaboration-Team-Triage, 10Thanks, 10Easy: Icon misalignment in mobile Thanks button - https://phabricator.wikimedia.org/T192513#4141442 (10kaldari) @Psuranas: Sorry, this just got fixed by someone else earlier this week (but in a duplicate bug). [17:19:26] (03CR) 10Krinkle: [C: 032] Replace uses of deprecated Language::truncate() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [17:29:11] (03CR) 10Krinkle: [C: 04-1] Fix "count(): Parameter must be an array or an object that implements Countable" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:29:19] (03Merged) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [17:30:15] (03CR) 10jenkins-bot: Replace uses of deprecated Language::truncate() [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/440637 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [17:30:16] (03CR) 10Krinkle: [C: 032] Remove inadequate render-blocking styles for jquery.tablesorter [core] - 10https://gerrit.wikimedia.org/r/435934 (https://phabricator.wikimedia.org/T195108) (owner: 10Bartosz Dziewoński) [17:30:57] (03CR) 10Krinkle: [C: 032] "Unfortunate, but we'll have to revisit later to see if there's a way to safely match at least a subset of scenarios (without causing incor" [core] - 10https://gerrit.wikimedia.org/r/435934 (https://phabricator.wikimedia.org/T195108) (owner: 10Bartosz Dziewoński) [17:31:19] (03PS5) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:31:42] (03PS6) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:32:17] (03CR) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" (031 comment) [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:33:30] (03PS7) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:33:37] (03PS8) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) [17:35:08] (03PS9) 10Krinkle: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:35:12] (03CR) 10Krinkle: [C: 032] Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:35:44] (03PS1) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/440670 (https://phabricator.wikimedia.org/T196412) [17:42:16] (03CR) 10Krinkle: [C: 032] "@Paladox I wonder if you've given thought to my earlier question, which is: How is it possible that $val is sometimes not an array?" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:43:08] 10MediaWiki-extensions-FlaggedRevs, 10PHP 7.2 support, 10Patch-For-Review: Fix "PHP Warning: count(): Parameter must be an array or Countable" in FlaggedRevs/backend/FRUserActivity.php - https://phabricator.wikimedia.org/T196412#4294866 (10Krinkle) [17:43:13] (03CR) 10jerkins-bot: [V: 04-1] Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:43:18] (03CR) 10jerkins-bot: [V: 04-1] Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/440670 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:43:36] (03CR) 10Paladox: "> Patch Set 9:" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:44:07] (03Merged) 10jenkins-bot: Remove inadequate render-blocking styles for jquery.tablesorter [core] - 10https://gerrit.wikimedia.org/r/435934 (https://phabricator.wikimedia.org/T195108) (owner: 10Bartosz Dziewoński) [17:44:39] (03CR) 10jerkins-bot: [V: 04-1] Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:44:46] (03PS2) 10Paladox: Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/440670 (https://phabricator.wikimedia.org/T196412) [17:47:38] (03CR) 10jenkins-bot: Remove inadequate render-blocking styles for jquery.tablesorter [core] - 10https://gerrit.wikimedia.org/r/435934 (https://phabricator.wikimedia.org/T195108) (owner: 10Bartosz Dziewoński) [17:51:51] (03CR) 10Krinkle: "The reason $val can be non-array is because it is taken from cache (BagOStuff). If value has been computed before and exists in the cache," [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:52:31] (03CR) 10jerkins-bot: [V: 04-1] Fix "count(): Parameter must be an array or an object that implements Countable" [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/440670 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:53:09] (03CR) 10Paladox: "Im not sure if the failure is related? Dosen't fail on 1.31 branch." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:53:36] (03CR) 10Paladox: "^^ there's other failures on 1.31 but the error in https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-php70-docker/5648/console" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:55:37] (03CR) 10Paladox: "recheck" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/418974 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [17:56:07] (03Abandoned) 10Paladox: Update for the actor table change [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/437372 (https://phabricator.wikimedia.org/T167246) (owner: 10Paladox) [17:56:44] (03CR) 10Krinkle: "In the rest of this class, you can find two cases where the cache key is created. It is the code that uses getMainStashInstance()->merge()" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [17:58:08] (03CR) 10Krinkle: "Let's focus on the master branch first. Backports should be created only after the master change lands." [extensions/FlaggedRevs] (REL1_31) - 10https://gerrit.wikimedia.org/r/440670 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [18:02:20] 10Readers-Web-Backlog, 10Patch-For-Review, 10Performance-Team (Radar), 10Readers-Web-Kanbanana-Board: resource-modules linter fails because mw.track is defined twice - https://phabricator.wikimedia.org/T197273#4294875 (10Krinkle) [18:04:14] (03CR) 10Paladox: "It dosen't seem my change is causing it as it fails on (https://integration.wikimedia.org/ci/job/quibble-vendor-mysql-hhvm-docker/5322/con" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/437364 (https://phabricator.wikimedia.org/T196412) (owner: 10Paladox) [18:07:32] 10Toolforge-standards-committee: Adoption request for "tools-info" - https://phabricator.wikimedia.org/T196396#4294877 (10zhuyifei1999) Let's go ahead with this? Or is there other concerns? I think @Ladsgroup can add @MusikAnimal to the maintainer list. [18:15:39] 10MediaWiki-Parser, 10Tracking: Strip marker (UNIQ / QINU) issues (tracking) - https://phabricator.wikimedia.org/T28213#4294881 (10Anomie) [18:15:40] 10MediaWiki-Parser, 10MediaWiki-extensions-Scribunto: Wikitech page is showing parser strip marker - https://phabricator.wikimedia.org/T197510#4294879 (10Anomie) 05Open>03Invalid It's not an issue in Scribunto. What's going on is that the code in [[https://wikitech.wikimedia.org/wiki/Template:Nova_Project... [18:25:12] 10MediaWiki-Database, 10MediaWiki-Installer, 10MW-1.31-release-notes, 10MW-1.32-release, and 4 others: Drop $wgDBmysql5 from MediaWiki - https://phabricator.wikimedia.org/T196185#4294882 (10Krinkle) >>! In T196185#4284496, @Prod wrote: >>>! In T196185#4284484, @Krinkle wrote: >> Most likely, you will not h... [18:29:45] 10MediaWiki-Codesniffer: remove [optional] from parameter docs - https://phabricator.wikimedia.org/T196773#4294883 (10Krinkle) Indeed. It is a purely textual convention with no run-time impact on any of the tooling involved. Within the objectcache and rdbms libs, @aaron and I have been (loosely) following the co... [18:30:46] 10MediaWiki-Codesniffer: Add sniff to disallow use of "[optional]" in places that break Phan (e.g. among @param type hints) - https://phabricator.wikimedia.org/T196773#4294885 (10Krinkle) p:05Triage>03Normal [18:33:24] (03CR) 10Krinkle: [C: 031] Use type Language instead of string for $lang of doEditSectionLink [core] - 10https://gerrit.wikimedia.org/r/436216 (owner: 10Fomafix) [18:50:02] (03CR) 10Noloader: "I believe this update broke mediaWiki 1.30." [debian] - 10https://gerrit.wikimedia.org/r/440302 (owner: 10Legoktm) [19:07:40] apergos: Hello [19:07:46] d3r1ck: Hello [19:07:48] hello! [19:07:54] we'll wait the usual 5 minutes of course [19:07:56] Dereckson: Hello [19:07:59] apergos: [19:08:03] apergos: ok [19:11:59] Hello :) [19:12:06] hey! [19:12:19] would you like to facilitate the meetin this time? [19:12:28] we've waited the 5 minutes :-0 [19:12:31] er, ;-) [19:12:38] bah, I mean :-) [19:13:06] Dereckson: [19:15:23] apergos: BTW I didn't get back to you soon cuz I had to go to school so I tought of mentioning the outcome during the meeting [19:15:34] sure! [19:16:42] well I hope Dereckson returns momentarily, let's start but I'll hand over to him if possible [19:16:51] d3r1ck: if you show up late just hop in [19:16:52] ok [19:16:55] how is everyone? [19:17:10] I am fine [19:17:17] how about you? [19:17:27] toay it rained a lot and cooled off, so it's been nice [19:17:43] did I understand right you had classes today, a Saturday? [19:17:51] is there any day they do not schedule classes? [19:18:25] yeah [19:18:28] Sundays [19:18:51] one day [19:19:06] they should do better [19:19:10] really school 6 days a week? [19:19:12] how is your sleep schedule? [19:19:28] yea, Monday as well I don't have classes from my timetable but it a schoolday [19:19:55] at least you mnged to keep two days clear [19:20:09] *managed [19:20:11] apergos: It is getting better [19:20:18] apergos: yeah [19:20:30] are you getting 7 hours yet? [19:21:42] apergos: hmmm, I won't want to lie. I will soon get to 7 hours a day promise, [19:22:11] Or I can sleep more that 7hrs on free days to compensate other days [19:22:12] ok! I expect a then() call from that promise soon! [19:22:16] does that count? [19:22:24] if you miss a day it does [19:22:32] if you miss several days, [19:22:33] ok [19:22:35] not so much [19:22:45] ok noted [19:22:45] it's a matter of your health, see [19:22:55] yea [19:23:17] well, having that in the back of our minds... [19:23:22] how is the project going? [19:23:29] not so well [19:23:58] I wish to have a call with you and other mentors if possible [19:24:27] not necesarily now [19:25:04] ok [19:25:20] what parts are you having trouble with? [19:26:11] having the image downloaded before the twit function executes [19:26:44] ok [19:27:19] do you have a patch that shows the current state of the code? you can put it in another branch than master if you like [19:27:30] this way we can all look at it later [19:27:44] Ok, [19:28:13] what is your work schedule like for tomorrow? [19:28:22] around when do you think you might start? [19:28:23] I will make a patch after the meeting [19:28:51] most probably after the meeting [19:29:08] 10PAWS (JupyterHub 0.9), 10Upstream: Force HTTPS use in PAWS - https://phabricator.wikimedia.org/T197248#4294895 (10Chicocvenancio) Adding ``` location-snippet: | if ($http_x_forwarded_proto = "http") { return 301 https://paws-beta.wmflabs.org$request_uri; } ``` to the `nginx-proxy-confi... [19:29:25] tomorrow not today [19:29:40] for me it is already 10:30 pm... and I should try to eat [19:29:55] ah but you don't want to be stuck all night [19:30:03] I will work today till tomorow morning and then after the meeting [19:30:26] yeah I won't want that [19:30:38] are there any other parts you can work on tonight [19:30:40] I have something in mind to try this night [19:30:44] ok [19:31:07] is there a time tomorrow before late in the evening that you might be around? [19:31:39] I can make it at 2pm UTC [19:31:49] that's much better for me [19:32:05] ok [19:32:06] if you're around then and you've put a patch up so we can look at the coe [19:32:08] code [19:32:15] ok [19:32:37] and the other two comentors haven't shown up who for some reason are always more awake at this hour (but it's earlier for them) [19:32:49] then ping me and we'll have a look together, ok? [19:32:56] ok [19:33:09] just to double check [19:33:14] right now what time is it there? [19:33:29] 8:33pm [19:33:35] yep I'm two hours later [19:33:36] ok [19:34:26] do you know if the function that gets the download url is even called? [19:34:37] i mean, suppose you just hardcode it to return a fixed string: does that happen? [19:34:52] yes It does [19:35:18] but only when used as a promise [19:35:27] that's suspicious [19:35:36] otherwise it gets skiped [19:35:40] ok I will wait to see what the non-promise code looks like [19:35:49] and the promise version too, if you don't mind it [19:36:15] just make sure the patches apply cleanly to whatever is already merged in the epo [19:36:16] repo [19:36:20] okay? [19:36:26] I think the non promise version is already on gerrit [19:36:45] there are no changes since that last patch? [19:36:54] I will push a promise version [19:36:57] if so then just toss up the [19:36:58] yeah. [19:36:59] excellent [19:37:38] what wil you be working on tonight? [19:38:06] I will contact #-cloud for my bot problem on toolsforge [19:38:32] ok! [19:38:41] I'll be interested to know how that goes [19:38:56] ok [19:39:09] I have to go now; phone call with my dad! but we'll talk tomorrow, ping me :-0 [19:39:09] I will keep u updated [19:39:10] er [19:39:14] :-) [19:39:18] ok [19:48:50] 10MediaWiki-ResourceLoader, 10Gadgets, 10Performance-Team, 10Regression: Gadget CSS should be applied after Site styles - https://phabricator.wikimedia.org/T191941#4294903 (10Dispenser) From the [[https://en.wikipedia.org/wiki/Wikipedia:Green_on_black_skin|Green on black skin]], it was [[https://en.wikiped... [19:56:04] 10PAWS (JupyterHub 0.9), 10Upstream: Force HTTPS use in PAWS - https://phabricator.wikimedia.org/T197248#4294911 (10Chicocvenancio) In the PAWS outage that gave rise to T195217, I set the nodePort directly to the chp container, bypassing the nginx container for PAWS. To allow the above snippet to work in PAWS... [19:56:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/440672 (owner: 10L10n-bot) [20:01:17] (03PS17) 10Gergő Tisza: Segregate right to edit sitewide CSS/JS [core] - 10https://gerrit.wikimedia.org/r/421121 (https://phabricator.wikimedia.org/T120886) [20:01:35] (03CR) 10jerkins-bot: [V: 04-1] Segregate right to edit sitewide CSS/JS [core] - 10https://gerrit.wikimedia.org/r/421121 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [20:01:42] (03CR) 10jerkins-bot: [V: 04-1] Segregate right to edit sitewide CSS/JS [core] - 10https://gerrit.wikimedia.org/r/421121 (https://phabricator.wikimedia.org/T120886) (owner: 10Gergő Tisza) [20:02:13] (03PS2) 10Hagar Shilo: Align loading animation above results on first load and on later reloads [core] - 10https://gerrit.wikimedia.org/r/440075 (https://phabricator.wikimedia.org/T192210) [20:12:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/440674 (owner: 10L10n-bot) [20:36:02] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294927 (10Noloader) [20:40:00] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/440679 (owner: 10L10n-bot) [20:40:36] (03CR) 10MarcoAurelio: "Thanks for testing. Could you please post the deprecation warnings you get in a Task so I can work on fixing those later? Thank you." [extensions/UserExport] - 10https://gerrit.wikimedia.org/r/440392 (https://phabricator.wikimedia.org/T197226) (owner: 10MarcoAurelio) [20:40:56] (03PS2) 10Hagar Shilo: Adjust layout for saved filters empty state [core] - 10https://gerrit.wikimedia.org/r/440072 (https://phabricator.wikimedia.org/T191534) [20:41:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/440684 (owner: 10L10n-bot) [20:41:15] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294936 (10Noloader) [20:42:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/440682 (owner: 10L10n-bot) [20:45:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/440688 (owner: 10L10n-bot) [20:46:52] (03CR) 10MarcoAurelio: [C: 04-1] "Typo." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) (owner: 10Nikerabbit) [20:48:53] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/440691 (owner: 10L10n-bot) [20:50:43] (03CR) 10MarcoAurelio: "recheck" [core] - 10https://gerrit.wikimedia.org/r/435644 (owner: 10Suriyaa Kudo) [20:52:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/440693 (owner: 10L10n-bot) [20:53:51] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/440692 (owner: 10L10n-bot) [20:55:07] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/PageTriage] - 10https://gerrit.wikimedia.org/r/440698 (owner: 10L10n-bot) [20:56:31] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ORES] - 10https://gerrit.wikimedia.org/r/440697 (owner: 10L10n-bot) [20:57:39] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/440703 (owner: 10L10n-bot) [20:58:35] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294927 (10Reedy) ``` Sams-MBP:mediawiki-1.31.0 reedy$ grep oojs composer.json "oojs/oojs-ui": "v0.26.4", Sams-MBP:mediawiki-1.31.0 reedy$ grep oojs vendor/composer.json "oojs/oojs-ui": "0.2... [20:59:52] (03CR) 10jerkins-bot: [V: 04-1] Replace HTTP by HTTPS in 'tests/phpunit/includes/libs/composer/ComposerLockTest.php' [core] - 10https://gerrit.wikimedia.org/r/435644 (owner: 10Suriyaa Kudo) [21:05:56] (03CR) 10Reedy: "20:53:53 1) ComposerLockTest::testGetInstalledDependencies" [core] - 10https://gerrit.wikimedia.org/r/435644 (owner: 10Suriyaa Kudo) [21:06:29] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/440706 (owner: 10L10n-bot) [21:08:15] (03CR) 10Reedy: [C: 04-1] "https://github.com/leafo/lessphp/blob/master/composer.json#L5" [core] - 10https://gerrit.wikimedia.org/r/435644 (owner: 10Suriyaa Kudo) [21:18:26] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294941 (10Noloader) Thanks. I don't believe I installed something called oojs. So do we delete all those files? Can we simply delete all the composer files so things will succeed? [21:26:57] (03CR) 10Nikerabbit: Add es-419 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/440280 (https://phabricator.wikimedia.org/T112889) (owner: 10Nikerabbit) [21:27:23] (03PS1) 10Paladox: Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) [21:27:54] (03PS2) 10Paladox: Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) [21:28:10] (03CR) 10Paladox: "This change is ready for review." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:29:20] (03CR) 10jerkins-bot: [V: 04-1] Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:30:52] (03PS3) 10Paladox: Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) [21:35:00] (03CR) 10Isarra: [C: 032] Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:35:12] (03PS1) 10Paladox: Fix sidebar closing on iOS [skins/Timeless] (REL1_31) - 10https://gerrit.wikimedia.org/r/440719 (https://phabricator.wikimedia.org/T161470) [21:36:14] (03CR) 10Isarra: [C: 032] "Might as well…" [skins/Timeless] (REL1_31) - 10https://gerrit.wikimedia.org/r/440719 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:37:10] (03CR) 10Legoktm: "> I believe this update broke mediaWiki 1.30." [debian] - 10https://gerrit.wikimedia.org/r/440302 (owner: 10Legoktm) [21:38:34] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294946 (10Reedy) oojs is a javascript library that's been with MediaWiki for a few versions now I'd suggest replacing the whole vendor folder from the tarball (delete the one in your MW dir, the... [21:39:55] (03Merged) 10jenkins-bot: Fix sidebar closing on iOS [skins/Timeless] - 10https://gerrit.wikimedia.org/r/440718 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:41:45] (03Merged) 10jenkins-bot: Fix sidebar closing on iOS [skins/Timeless] (REL1_31) - 10https://gerrit.wikimedia.org/r/440719 (https://phabricator.wikimedia.org/T161470) (owner: 10Paladox) [21:43:01] (03CR) 10jerkins-bot: [V: 04-1] phpunit: does it support running in isolation? [core] - 10https://gerrit.wikimedia.org/r/440565 (owner: 10Hashar) [21:44:37] 10Timeless, 10Mobile, 10Patch-For-Review: Tapping outside an open menu should close the opened menu on iOS - https://phabricator.wikimedia.org/T161470#4294949 (10Paladox) 05Open>03Resolved Tested the new fix and it fixes my issue now! [21:45:17] 10Timeless, 10Mobile: Tapping outside an open menu should close the opened menu on iOS - https://phabricator.wikimedia.org/T161470#4294952 (10Paladox) a:05SamanthaNguyen>03Paladox [21:47:14] (03CR) 10jerkins-bot: [V: 04-1] [WIP] resourceloader: Embed 'mediawiki' directly in startup response [core] - 10https://gerrit.wikimedia.org/r/440605 (https://phabricator.wikimedia.org/T192623) (owner: 10Krinkle) [21:48:15] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294955 (10Noloader) >>! In T197518#4294946, @Reedy wrote: > ... > I'd suggest replacing the whole vendor folder from the tarball (delete the one in your MW dir, then copy the one out of the tarba... [21:52:05] (03CR) 10jenkins-bot: stats: Hard-deprecate BufferingStatsdDataFactory::getBuffer() [core] - 10https://gerrit.wikimedia.org/r/440621 (owner: 10Krinkle) [21:53:19] 10MediaWiki-Authentication-and-authorization, 10MediaWiki-extensions-OATHAuth, 10CheckUser: Make users without 2FA setup not have checkuser right regardless of their groups - https://phabricator.wikimedia.org/T197501#4294968 (10Bawolff) >>! In T197501#4294400, @Huji wrote: > @Bawolff from what I understand,... [21:56:57] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294969 (10Noloader) Does anyone know if MediaWiki 1.31 works with CentOS 7 and PHP 7.1? [21:59:33] (03CR) 10jerkins-bot: [V: 04-1] Hard deprecate Language::truncate() [core] - 10https://gerrit.wikimedia.org/r/440173 (https://phabricator.wikimedia.org/T197492) (owner: 10C. Scott Ananian) [22:01:27] 10ContentTranslation, 10Language-2018-Jan-Mar: cx-header__personal-menu oo-ui-dropdownWidget displays all options as active - https://phabricator.wikimedia.org/T184571#4294970 (10Nikerabbit) [22:11:47] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294976 (10Reedy) >>! In T197518#4294969, @Noloader wrote: > Does anyone know if MediaWiki 1.31 works with CentOS 7 and PHP 7.1? Why? What is that going to fix? [22:15:33] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4294977 (10Paladox) [22:16:01] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4294977 (10Paladox) [22:16:17] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294987 (10Noloader) >>! In T197518#4294976, @Reedy wrote: >>>! In T197518#4294969, @Noloader wrote: >> Does anyone know if MediaWiki 1.31 works with CentOS 7 and PHP 7.1? > > Why? What is that g... [22:17:42] 10Timeless: Tabs on preferences page scroll to multiple lines - https://phabricator.wikimedia.org/T173470#3529455 (10Isarra) Current tabs layout also just kind of messy in general, according to users. Perhaps in order to re-evaluate design in general? [22:18:59] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4294991 (10Paladox) [22:19:21] 04(no projects): MediaWiki 1.31 does not include all the files it needs - https://phabricator.wikimedia.org/T197518#4294992 (10Reedy) I don't think that's the case, the error isn't related to anything installed with your OS MW is complaining because your vendor folder/repo is mismatched again the composer.json... [22:26:08] 10MediaWiki-Change-tagging, 10MediaWiki-Database, 10MediaWiki-Recent-changes: Nullify ct_rc_id and ts_rc_id when recent changes entries are being deleted - https://phabricator.wikimedia.org/T191581#4294993 (10Ladsgroup) I agree with @TTO Performance-wise and storage-wise, It doesn't matter. We have proper in... [22:33:23] 10Timeless: Do something about crappy Timeless VE editsection icons - https://phabricator.wikimedia.org/T197521#4294994 (10Isarra) [22:34:10] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4295004 (10Isarra) What's the difference between expected and actual behaviour, again? [22:35:02] 10Timeless: Text shown instead of icons at certain browser sizes - https://phabricator.wikimedia.org/T197520#4295005 (10Paladox) @Isarra on the top bar you see "Navigation" and all along there other text too, those are icons if you spread the browser or make it small. [22:37:33] 10Timeless: Subsection/section distinction should be clearer - https://phabricator.wikimedia.org/T197522#4295007 (10Isarra) [22:38:17] 10MediaWiki-Database, 10Performance-Team: Explicitly providing a database index to LoadBalancer::getConnection() should return the selected connection. - https://phabricator.wikimedia.org/T184525#4295017 (10Krinkle) [22:38:31] 10MediaWiki-Database, 10MediaWiki-File-management, 10Multimedia, 10Performance-Team, and 3 others: File moves throw error when using postgres - https://phabricator.wikimedia.org/T160910#4295018 (10Krinkle) [23:18:26] 04(no projects): security emails to users immediately - https://phabricator.wikimedia.org/T197524#4295035 (10Nick_Levinson) [23:25:40] 10MediaWiki-extensions-LoginNotify, 10Wikimedia-General-or-Unknown: security emails to users immediately - https://phabricator.wikimedia.org/T197524#4295044 (10Reedy)