[00:02:53] (03PS26) 10Krinkle: Generalize ResourceLoader 'excludepage' functionality [core] - 10https://gerrit.wikimedia.org/r/340768 (https://phabricator.wikimedia.org/T112474) (owner: 10Anomie) [00:03:11] (03CR) 10Krinkle: "Rebased to resolve conflict with dfb754cbc633b7b653ae94bf9d64a88d6adad7c7." [core] - 10https://gerrit.wikimedia.org/r/340768 (https://phabricator.wikimedia.org/T112474) (owner: 10Anomie) [00:07:17] (03CR) 10Krinkle: [C: 031] "LGTM and confirmed that the new group=user system is working well for the core user module now. It gets preset to state "loading", and get" [core] - 10https://gerrit.wikimedia.org/r/340768 (https://phabricator.wikimedia.org/T112474) (owner: 10Anomie) [00:08:31] (03CR) 10Krinkle: [C: 032] Hard-deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/427584 (owner: 10MaxSem) [00:08:44] (03PS1) 10Krinkle: Hard-deprecate wfUsePHP() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/428038 [00:08:48] (03CR) 10Krinkle: [C: 032] Hard-deprecate wfUsePHP() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/428038 (owner: 10Krinkle) [00:09:50] (03PS10) 10Krinkle: MailAddress should always be quoting the name otherwise whitespace in the username will break break email headers. [core] - 10https://gerrit.wikimedia.org/r/425433 (https://phabricator.wikimedia.org/T191931) (owner: 10Alexia) [00:14:21] (03PS5) 10Krinkle: Add newlines for consistency and clarity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399166 (owner: 10Thiemo Kreuz (WMDE)) [00:14:48] (03CR) 10Krinkle: [C: 032] Add newlines for consistency and clarity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399166 (owner: 10Thiemo Kreuz (WMDE)) [00:16:59] (03CR) 10Krinkle: "recheck" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [00:17:46] (03CR) 10Krinkle: [C: 04-1] "The simplification of isLocalUrl() and comment changes LGTM. But the other two changes need to be reversed, and there's 1 issue flagged by" [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [00:25:48] (03Merged) 10jenkins-bot: Hard-deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/427584 (owner: 10MaxSem) [00:25:51] (03Merged) 10jenkins-bot: Hard-deprecate wfUsePHP() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/428038 (owner: 10Krinkle) [00:25:53] (03Merged) 10jenkins-bot: Add newlines for consistency and clarity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399166 (owner: 10Thiemo Kreuz (WMDE)) [00:27:46] (03CR) 10jenkins-bot: Add newlines for consistency and clarity [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/399166 (owner: 10Thiemo Kreuz (WMDE)) [00:28:10] (03CR) 10jenkins-bot: Hard-deprecate wfUsePHP() [core] (REL1_31) - 10https://gerrit.wikimedia.org/r/428038 (owner: 10Krinkle) [00:29:32] (03PS5) 10Cooltey: [WIP] Add multiple language selection to app Settings [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/426323 (https://phabricator.wikimedia.org/T190838) [00:29:46] (03CR) 10jenkins-bot: Hard-deprecate wfUsePHP() [core] - 10https://gerrit.wikimedia.org/r/427584 (owner: 10MaxSem) [00:50:34] (03PS3) 10Jdlrobson: Introduce ResourceLoaderLessVarFileModule [core] - 10https://gerrit.wikimedia.org/r/427949 (https://phabricator.wikimedia.org/T42812) [00:50:36] (03PS4) 10Jdlrobson: Skins: getDefaultModules can now define render blocking CSS [core] - 10https://gerrit.wikimedia.org/r/425211 (https://phabricator.wikimedia.org/T42792) [00:50:38] (03PS16) 10Jdlrobson: sortable tables/mw-collapsible no longer causes page jump [core] - 10https://gerrit.wikimedia.org/r/424165 (https://phabricator.wikimedia.org/T42792) [00:53:14] (03CR) 10Jdlrobson: Introduce ResourceLoaderLessVarFileModule (032 comments) [core] - 10https://gerrit.wikimedia.org/r/427949 (https://phabricator.wikimedia.org/T42812) (owner: 10Jdlrobson) [00:55:20] (03CR) 10Jdlrobson: "(Rebased somewhat so that this can me merged without waiting on the more complicated patchsets. Feel free to cherry pick and plus 2 to mas" [core] - 10https://gerrit.wikimedia.org/r/425211 (https://phabricator.wikimedia.org/T42792) (owner: 10Jdlrobson) [01:03:24] (03CR) 10Krinkle: Introduce ResourceLoaderLessVarFileModule (031 comment) [core] - 10https://gerrit.wikimedia.org/r/427949 (https://phabricator.wikimedia.org/T42812) (owner: 10Jdlrobson) [01:08:59] (03PS4) 10Krinkle: selenium: Clean up wdio.conf.js [core] - 10https://gerrit.wikimedia.org/r/426833 [01:11:51] (03PS1) 10Krinkle: selenium: Run wdio directly without grunt [core] - 10https://gerrit.wikimedia.org/r/428039 [01:19:03] (03CR) 10jerkins-bot: [V: 04-1] selenium: Run wdio directly without grunt [core] - 10https://gerrit.wikimedia.org/r/428039 (owner: 10Krinkle) [01:19:33] (03CR) 10jerkins-bot: [V: 04-1] selenium: Clean up wdio.conf.js [core] - 10https://gerrit.wikimedia.org/r/426833 (owner: 10Krinkle) [01:23:34] 10MediaWiki-HTMLForm, 10Patch-For-Review, 10Technical-Debt, 10User-Jayprakash12345: Remove applications of and deprecate HTMLForm::setSubmitProgressive - https://phabricator.wikimedia.org/T191586#4147300 (10Volker_E) [01:25:56] 10MediaWiki-HTMLForm, 10Patch-For-Review, 10Technical-Debt, 10User-Jayprakash12345: Remove applications of and deprecate HTMLForm::setSubmitProgressive - https://phabricator.wikimedia.org/T191586#4147301 (10Volker_E) [01:26:59] (03PS3) 10VolkerE: HTMLForm: Remove usage of HTMLForm::setSubmitProgressive [core] - 10https://gerrit.wikimedia.org/r/424504 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:27:06] (03CR) 10VolkerE: [C: 032] HTMLForm: Remove usage of HTMLForm::setSubmitProgressive [core] - 10https://gerrit.wikimedia.org/r/424504 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:33:03] (03PS2) 10Sharvaniharan: Resize edit icons in the headers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/425606 (https://phabricator.wikimedia.org/T183018) [01:35:04] 10MediaWiki-Documentation, 10MediaWiki-General-or-Unknown, 10MediaWiki-Vendor, 10Security-Team, and 3 others: Remove requirement for security review of well maintained third party libraries - https://phabricator.wikimedia.org/T192453#4139274 (10Bawolff) I would say additionally, that it should depend on th... [01:36:31] (03PS8) 10Dbarratt: [WIP] Use a Drawer for Block Notices [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426641 (https://phabricator.wikimedia.org/T165535) [01:38:28] (03PS3) 10Sharvaniharan: Resize edit icons in the headers [apps/android/wikipedia] - 10https://gerrit.wikimedia.org/r/425606 (https://phabricator.wikimedia.org/T183018) [01:41:29] (03PS4) 10Jdlrobson: Introduce ResourceLoaderLessVarFileModule [core] - 10https://gerrit.wikimedia.org/r/427949 (https://phabricator.wikimedia.org/T42812) [01:41:48] (03CR) 10Jdlrobson: Introduce ResourceLoaderLessVarFileModule (031 comment) [core] - 10https://gerrit.wikimedia.org/r/427949 (https://phabricator.wikimedia.org/T42812) (owner: 10Jdlrobson) [01:42:31] (03Merged) 10jenkins-bot: HTMLForm: Remove usage of HTMLForm::setSubmitProgressive [core] - 10https://gerrit.wikimedia.org/r/424504 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:42:52] (03PS5) 10Jdlrobson: Skins: getDefaultModules can now define render blocking CSS [core] - 10https://gerrit.wikimedia.org/r/425211 (https://phabricator.wikimedia.org/T42792) [01:43:00] (03PS17) 10Jdlrobson: sortable tables/mw-collapsible no longer causes page jump [core] - 10https://gerrit.wikimedia.org/r/424165 (https://phabricator.wikimedia.org/T42792) [01:43:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Use a Drawer for Block Notices [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426641 (https://phabricator.wikimedia.org/T165535) (owner: 10Dbarratt) [01:44:34] (03CR) 10jenkins-bot: HTMLForm: Remove usage of HTMLForm::setSubmitProgressive [core] - 10https://gerrit.wikimedia.org/r/424504 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:45:53] (03PS18) 10Jdlrobson: sortable tables/mw-collapsible no longer causes page jump [core] - 10https://gerrit.wikimedia.org/r/424165 (https://phabricator.wikimedia.org/T42792) [01:47:48] (03PS3) 10VolkerE: Remove usage of HTMLForm::setSubmitProgressive [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/424505 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:48:01] (03CR) 10VolkerE: [C: 032] Remove usage of HTMLForm::setSubmitProgressive [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/424505 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:50:26] (03Merged) 10jenkins-bot: Remove usage of HTMLForm::setSubmitProgressive [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/424505 (https://phabricator.wikimedia.org/T191586) (owner: 10Jayprakash12345) [01:53:56] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: ResourceLoader 2018 Review - https://phabricator.wikimedia.org/T192623#4147309 (10Krinkle) [01:54:29] (03CR) 10Brian Wolff: Added checks for $wgCompressRevisions, $wgExternalStores (031 comment) [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/426977 (owner: 10Yaron Koren) [01:55:37] (03PS1) 10Krinkle: wikibits: Remove redundant stubs for document.write [core] - 10https://gerrit.wikimedia.org/r/428041 (https://phabricator.wikimedia.org/T192623) [02:09:01] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: ResourceLoader 2018 Review - https://phabricator.wikimedia.org/T192623#4147312 (10Krinkle) [02:09:59] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Patch-For-Review: ResourceLoader 2018 Review - https://phabricator.wikimedia.org/T192623#4144928 (10Krinkle) [02:12:54] (03CR) 10Krinkle: Skins: getDefaultModules can now define render blocking CSS (031 comment) [core] - 10https://gerrit.wikimedia.org/r/425211 (https://phabricator.wikimedia.org/T42792) (owner: 10Jdlrobson) [02:13:35] (03CR) 10Krinkle: "Thx, after this nit, I think we're close to landing this and the var module. I'll look it over once more early next week, but should be go" [core] - 10https://gerrit.wikimedia.org/r/425211 (https://phabricator.wikimedia.org/T42792) (owner: 10Jdlrobson) [02:14:43] (03PS2) 10Krinkle: Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [02:14:47] (03CR) 10Krinkle: [C: 032] Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [02:15:06] (03CR) 10Krinkle: [C: 032] "Fine I suppose. Although it's unlikely the commands will change between now and the end of this branch." [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [02:20:08] 10Discovery-Search: Build a unified namespace index - https://phabricator.wikimedia.org/T192699#4147315 (10EBernhardson) p:05Triage>03Normal [02:21:26] 10Discovery-Search: Resolve document id clashes with unified type - https://phabricator.wikimedia.org/T192693#4147326 (10EBernhardson) If we split namespace into it's own single index for all wiks, the main difference remaining may now only be archive documents. Perhaps we need to revisit archive and see if it m... [02:21:40] (03CR) 10Krinkle: [C: 031] "LGTM. Very nice :) - Will verify/land on Monday." [core] - 10https://gerrit.wikimedia.org/r/428021 (https://phabricator.wikimedia.org/T192611) (owner: 10Aaron Schulz) [02:26:08] (03CR) 10jerkins-bot: [V: 04-1] Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [02:26:23] (03CR) 10jerkins-bot: [V: 04-1] Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [02:28:58] 10Design, 10WMF-Design, 10WikimediaUI Style Guide, 10Patch-For-Review: Ensure usage of SVGs where applicable - https://phabricator.wikimedia.org/T156531#4147327 (10Volker_E) For technical reference on why to put `role=img` on SVG `` images, see https://css-tricks.com/accessible-svgs/ [02:37:24] 10Discovery-Search (Current work), 10Patch-For-Review: Resolve elasticsearch latency alerts - https://phabricator.wikimedia.org/T191236#4098231 (10EBernhardson) a:03EBernhardson [02:47:15] 10Design, 10WMF-Design, 10WikimediaUI Style Guide, 10Patch-For-Review: Ensure usage of SVGs where applicable - https://phabricator.wikimedia.org/T156531#4147330 (10Volker_E) @Nirzar This is for everyone picture is currently missing in Imagery file. [03:14:57] 10Product-Analytics, 10Reading-analysis: WMFI want to have fiwiki aggregates top 5000 articles viewed in 2018,2017 and all-time-in-the-database - https://phabricator.wikimedia.org/T192360#4147333 (10Tbayer) Here is the result for the second request. The exact timespan is May 1, 2015 to March 31, 2018. I have n... [03:19:02] 10MediaWiki-HTMLForm, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt, 10User-Jayprakash12345: Remove applications of and deprecate HTMLForm::setSubmitProgressive - https://phabricator.wikimedia.org/T191586#4147335 (10Jayprakash12345) [03:24:58] 10Product-Analytics, 10Reading-analysis: WMFI want to have fiwiki aggregates top 5000 articles viewed in 2018,2017 and all-time-in-the-database - https://phabricator.wikimedia.org/T192360#4147336 (10Tbayer) Here is the result for the third request (covering January 1 to April 20, 2018). For all three of the ab... [03:30:35] 10Product-Analytics, 10Reading-analysis: WMFI want to have fiwiki aggregates top 5000 articles viewed in 2018,2017 and all-time-in-the-database - https://phabricator.wikimedia.org/T192360#4147337 (10Tbayer) 05Open>03Resolved a:03Tbayer >>! In T192360#4136958, @Zache wrote: ... > For #4 it is ok for not d... [03:30:38] (03PS16) 10星耀晨曦: Checks if open_basedir include $wgGitBin before is_file() [core] - 10https://gerrit.wikimedia.org/r/416234 (https://phabricator.wikimedia.org/T74445) [03:54:15] 10MediaWiki-Cache, 10MediaWiki-extensions-CentralNotice: Array to string conversion errors with BagOStuff.php - https://phabricator.wikimedia.org/T189215#4147340 (10Krinkle) [03:54:45] 10MediaWiki-Cache, 10MediaWiki-extensions-CentralNotice: Array to string conversion errors with BagOStuff.php - https://phabricator.wikimedia.org/T189215#4035414 (10Krinkle) Stack comes from extensions/CentralNotice/includes/ChoiceDataProvider.php, not VisualEditor. [04:12:30] 10Multi-Content-Revisions, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: RevisionArchiveRecord incorrectly changes null ar_len to 0 - https://phabricator.wikimedia.org/T192189#4147343 (10GeoffreyT2000) We still need to update the populateRevisionLength.php script to fix... [04:21:30] 10Contributors-Analysis, 10Product-Analytics: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860#4147344 (10Bawolff) The other question, is what about "readers" and non-editors. How do they choose skins? Here is the breakdown of what skin users of enwiki (who are using a non-defa... [05:08:22] 10Design, 10WMF-Design, 10WikimediaUI Style Guide, 10Patch-For-Review: Ensure usage of SVGs where applicable - https://phabricator.wikimedia.org/T156531#4147376 (10Volker_E) Prepared all imagery that is unaltered in SVG and pushed to the repo in order to move on and provide mobile users a better experience... [05:08:37] 10WikimediaUI Style Guide, 10Patch-For-Review: Consider adding rich structured data or microdata to style guide - https://phabricator.wikimedia.org/T177812#4147377 (10Volker_E) a:03Prtksxna [06:07:40] (03PS1) 10Umherirrender: Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 [06:09:20] (03CR) 10jerkins-bot: [V: 04-1] Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:11:12] (03PS2) 10Umherirrender: Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 [06:12:46] (03CR) 10jerkins-bot: [V: 04-1] Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:14:03] (03PS3) 10Umherirrender: Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 [06:16:09] (03CR) 10Umherirrender: "check php" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:19:13] (03CR) 10jerkins-bot: [V: 04-1] Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:21:16] (03CR) 10jerkins-bot: [V: 04-1] Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:41:10] (03CR) 10Umherirrender: "It is a warning from phpunit code and own classes are filtered out from the backtrace shown by phpunit. That why there is nothing to see a" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:46:13] (03PS1) 10Umherirrender: Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 [06:48:06] (03Abandoned) 10Umherirrender: Trigger exception with backtrace on php7 warning [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428042 (owner: 10Umherirrender) [06:50:02] (03PS2) 10Umherirrender: Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 [06:50:24] (03CR) 10Umherirrender: "check php" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [06:52:38] (03CR) 10Umherirrender: "This patch set has a circular reference with I44780a6f4af4ccee21291734578c3f854160fad8 to get tests pass." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/427935 (owner: 10Umherirrender) [06:52:40] (03CR) 10Umherirrender: "This patch set has a circular reference with I09ca2747b1efb3515e74fc8355280505c00c61b3 to get tests pass." [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [06:55:33] (03CR) 10jerkins-bot: [V: 04-1] Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [06:58:02] (03CR) 10Gergő Tisza: Short description can now come from wikitext (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/425911 (https://phabricator.wikimedia.org/T190953) (owner: 10Jdlrobson) [06:58:49] (03CR) 10Gergő Tisza: "Yeah, not showing the edit would probably break some existing tools." [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [07:04:56] (03PS1) 10Hashar: Selenium: pass -no-sandbox to Chrome under Docker [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/428044 [07:06:23] (03PS3) 10Hashar: Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [07:06:31] (03CR) 10Hashar: "webdriver.io fails, most probably because the branch lacks https://gerrit.wikimedia.org/r/#/c/428044/ "Selenium: pass -no-sandbox to Chrom" [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [07:07:24] 10AbuseFilter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove coding standard rule exclusions in AbuseFilter and fix the coding standards - https://phabricator.wikimedia.org/T178007#4147388 (10Daimona) I'm afraid he won't answer :-) He doesn't work for WMF anymore and that phab account... [07:18:51] (03CR) 10Hashar: [C: 032] Selenium: pass -no-sandbox to Chrome under Docker [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/428044 (owner: 10Hashar) [07:18:55] (03CR) 10Hashar: [C: 032] Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [07:32:17] (03Merged) 10jenkins-bot: Selenium: pass -no-sandbox to Chrome under Docker [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/428044 (owner: 10Hashar) [07:32:19] (03Merged) 10jenkins-bot: Selenium: move logic for running tests from package.json to selenium.sh [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [07:34:17] (03CR) 10Hashar: [C: 032] "Updated on tin and rebased the local workspace." [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/428044 (owner: 10Hashar) [07:34:19] (03CR) 10Hashar: [C: 032] "Updated on tin and rebased the local workspace." [core] (wmf/1.31.0-wmf.29) - 10https://gerrit.wikimedia.org/r/426884 (https://phabricator.wikimedia.org/T179190) (owner: 10Zfilipin) [07:38:15] 10AbuseFilter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove coding standard rule exclusions in AbuseFilter and fix the coding standards - https://phabricator.wikimedia.org/T178007#4147405 (10Daimona) I tried inserting a wfDebug inside the if clause and then started to run APIs searchi... [07:46:29] 10AbuseFilter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove coding standard rule exclusions in AbuseFilter and fix the coding standards - https://phabricator.wikimedia.org/T178007#4147420 (10Daimona) No, no no. By chance, I found https://gerrit.wikimedia.org/r/plugins/gitiles/mediawik... [07:54:21] (03PS1) 10Daimona Eaytoy: Remove unused wgTitle + remove exception from PHPCS [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/428045 (https://phabricator.wikimedia.org/T178007) [07:55:26] (03PS2) 10Daimona Eaytoy: Remove unused wgTitle + remove exception from PHPCS [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/428045 (https://phabricator.wikimedia.org/T178007) [08:00:09] (03CR) 10jerkins-bot: [V: 04-1] Remove unused wgTitle + remove exception from PHPCS [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/428045 (https://phabricator.wikimedia.org/T178007) (owner: 10Daimona Eaytoy) [08:04:05] (03PS3) 10Daimona Eaytoy: Remove unused wgTitle + remove exception from PHPCS [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/428045 (https://phabricator.wikimedia.org/T178007) [08:13:04] 10MediaWiki-Configuration, 10Beta-Cluster-Infrastructure, 10Operations, 10Release-Engineering-Team, 10User-MarcoAurelio: Beta Cluster sends password reset mails with prod address - https://phabricator.wikimedia.org/T192686#4147426 (10MarcoAurelio) 05Open>03Resolved p:05Triage>03Normal a:03MarcoA... [08:16:43] (03CR) 10Reedy: Checks if open_basedir include $wgGitBin before is_file() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/416234 (https://phabricator.wikimedia.org/T74445) (owner: 10星耀晨曦) [08:48:23] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147445 (10Rxy) [08:48:26] 10OABot: Unstable choice of random edit - https://phabricator.wikimedia.org/T180672#3765927 (10Nemo_bis) I find the title and description very hard to understand. Is your problem that an article is not discarded even if all the corresponding suggestions have been rejected? [08:50:20] 10OABot: OABot error: 'No edit was made' (timeout or edit conflict?) - https://phabricator.wikimedia.org/T178979#3709189 (10Nemo_bis) This is "by design". Suggestions are kept in a cache and can get stale. Usually OAbot runs rather short of suggestions, so it's currently skewed towards giving a bit more rather t... [08:53:03] 10OABot: Add "undo" button - https://phabricator.wikimedia.org/T166282#3291033 (10Nemo_bis) I would decline this. There's a link to the user page, which I regularly use to reach the contributions and the undo button. Alternatively, one can go back to the previous page, click the title and go to the history. It's... [08:57:06] 10OABot: Link to cowles.yale.edu redirects to home page - https://phabricator.wikimedia.org/T179474#4147462 (10Nemo_bis) 05Open>03Invalid This is an issue in the source data, needs to be fixed there. Some directions are available from https://dissem.in/faq#missing-paper [08:57:38] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147464 (10Rxy) [08:57:55] 10OABot: Strip .pdf from arxiv identifiers before adding them - https://phabricator.wikimedia.org/T187791#4147465 (10Nemo_bis) p:05Triage>03Normal [08:59:29] 10OABot: Detect if link ultimately goes to arxiv, and use arxiv link/parameter instead - https://phabricator.wikimedia.org/T163903#4147466 (10Nemo_bis) 05Open>03Resolved a:03Pintoch Based on my survey of available suggestions yesterday, I'd say it's fixed, yes. Separate tasks exist for specific issues, suc... [09:00:08] 10OABot: Allow free-text editing for better links to add - https://phabricator.wikimedia.org/T172859#4147471 (10Nemo_bis) p:05High>03Low [09:11:43] (03PS16) 10Daimona Eaytoy: [WIP] Add phan configuration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) [09:12:47] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147472 (10Jayprakash12345) How you get this? means If I am a simple user then I will simpl... [09:14:13] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) (owner: 10Daimona Eaytoy) [09:31:15] (03PS2) 10Thiemo Kreuz (WMDE): Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 [09:31:32] (03CR) 10Thiemo Kreuz (WMDE): Performance optimizations and cleanups on CSSMin library (033 comments) [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [09:40:41] (03CR) 10jerkins-bot: [V: 04-1] Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [09:42:54] 10MediaWiki-Cache, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: Last-Modified header makes pages uncacheable in frontend caches when it was modified after $wgSquidMaxage - https://phabricator.wikimedia.org/T178629#4147502 (10Ciencia_Al_Poder) You're right about also cha... [09:45:49] 10OABot: Keyboard shortcuts - https://phabricator.wikimedia.org/T166283#4147504 (10Nemo_bis) 05Open>03Resolved a:03Nemo_bis I'm happy with the current shortcuts for the main buttons. There are two main ways I'm currently "forced" to use the mouse: * a lot of text and assorted clutter has been added on top... [09:47:03] 10OABot: Require users to agree with each instruction before adding link - https://phabricator.wikimedia.org/T179670#4147508 (10Nemo_bis) 05Open>03declined There is no point forcing users to click the same checkboxes hundreds of times. [09:48:54] (03Draft2) 10Reedy: Add since tag to wfRemoveDotSegments [core] - 10https://gerrit.wikimedia.org/r/428047 [09:53:06] 10OABot: Keeping up with the queue - https://phabricator.wikimedia.org/T179035#4147513 (10Nemo_bis) [09:53:08] 10OABot: Provide a way to reject links (instead of skip) - https://phabricator.wikimedia.org/T166308#4147511 (10Nemo_bis) 05Open>03Resolved https://github.com/dissemin/oabot/commit/9f729396ce541147adc0e768dbc9c6350216e123 was merged in February and I see it on https://tools.wmflabs.org/oabot/ . I still recom... [09:53:41] 10OABot: Signal to user whether their edit was made successfully - https://phabricator.wikimedia.org/T179475#4147514 (10Nemo_bis) 05Open>03declined Declining per above. No need to add extra steps or clutter the next page. [09:54:48] 10OABot: Strip .pdf from arxiv identifiers before adding them - https://phabricator.wikimedia.org/T187791#3985929 (10Nemo_bis) I'm not sure if https://github.com/dissemin/oabot/commit/5361bf122c27ac6220fc113e1a3767fe7773f62b has been deployed already when this bug has been observed. [09:57:37] (03PS17) 10Daimona Eaytoy: [WIP] Add phan configuration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) [09:58:50] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) (owner: 10Daimona Eaytoy) [10:00:39] 10OABot: Error: No JSON object could be decoded - https://phabricator.wikimedia.org/T178898#4147518 (10Nemo_bis) 05Open>03Resolved This was fixed at some point. A suggestion was correctly generated: ``` $ stat ~/www/python/src/cache/2015_in_paleontology.json File: ‘/data/project/oabot/www/python/src/cache/... [10:03:21] 10OABot: Keeping up with the queue - https://phabricator.wikimedia.org/T179035#4147520 (10Nemo_bis) [10:04:01] 10MediaWiki-User-login-and-signup, 10Security-Team, 10Patch-For-Review: PasswordBlacklist unit tests fails on 32 bit machine - https://phabricator.wikimedia.org/T188821#4147527 (10Reedy) @Umherirrender Poke :) [10:04:51] 10OABot: Keeping up with the queue - https://phabricator.wikimedia.org/T179035#3711091 (10Nemo_bis) 05Resolved>03Invalid This report is a collection of issues and it was closed despite having a subtask which was open (until today). Better discard this and continue dealing with specific issues in specific tasks. [10:13:45] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Move information from .eslintignore into Gruntfile.js [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/428005 (https://phabricator.wikimedia.org/T179195) (owner: 10Umherirrender) [10:15:24] 10OABot: Facilitate the manual check of proposed PDF/HTML - https://phabricator.wikimedia.org/T192707#4147533 (10Nemo_bis) [10:15:40] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147545 (10Reedy) p:05Triage>03Low >>! In T192705#4147472, @Jayprakash12345 wrote: > Ho... [10:16:52] (03PS18) 10Daimona Eaytoy: [WIP] Add phan configuration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) [10:17:00] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147445 (10MarcoAurelio) > The code seems to work, just doesn't always populate the text bo... [10:18:37] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) (owner: 10Daimona Eaytoy) [10:19:08] (03PS3) 10Thiemo Kreuz (WMDE): Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 [10:20:04] (03PS2) 10Daimona Eaytoy: Fix parameter doc type for matchEditToken [core] - 10https://gerrit.wikimedia.org/r/427869 [10:22:48] 10OABot: Let the prefill run until the end when going through all articles - https://phabricator.wikimedia.org/T192708#4147549 (10Nemo_bis) [10:22:56] 10MediaWiki-Codesniffer: PHPCS should not complain about @covers and @dataProvider being used in traits - https://phabricator.wikimedia.org/T192384#4147558 (10thiemowmde) To me this really sounds like we need to drop all naming convention checks when dealing with traits. Let the author decide how he wants to nam... [10:24:36] (03Merged) 10jenkins-bot: Move information from .eslintignore into Gruntfile.js [extensions/PropertySuggester] - 10https://gerrit.wikimedia.org/r/428005 (https://phabricator.wikimedia.org/T179195) (owner: 10Umherirrender) [10:30:05] (03CR) 10jerkins-bot: [V: 04-1] Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [10:32:59] (03CR) 10jerkins-bot: [V: 04-1] Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [10:37:21] 10MediaWiki-Parser: Ask a summary for any change, even in discussions - https://phabricator.wikimedia.org/T173404#4147562 (10Rical) [10:41:01] (03PS19) 10Daimona Eaytoy: [WIP] Add phan configuration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) [10:42:24] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) (owner: 10Daimona Eaytoy) [10:42:52] 10MediaWiki-Internationalization, 10I18n: Fix collation in Albanian projects - https://phabricator.wikimedia.org/T192709#4147570 (10Amire80) [10:45:17] 10MediaWiki-extensions-CentralAuth, 10UI-Standardization, 10Stewards-and-global-tools, 10User-Jayprakash12345: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147582 (10Jayprakash12345) a:03Jayprakash12345 I know what the... [10:48:33] 10MediaWiki-extensions-CentralAuth, 10Stewards-and-global-tools, 10User-Jayprakash12345: Special:GlobalUserRights does not have a value in username field when access /USERNAME - https://phabricator.wikimedia.org/T192705#4147585 (10Jayprakash12345) [10:49:16] 10MediaWiki-extensions-LoginNotify: LoginNotify should inform users of failed login attempts in the language of their home wiki - https://phabricator.wikimedia.org/T192638#4147587 (10Aklapper) @Scott: The user is free to choose a language in their preferences. What would be your proposal to identify the 'best' l... [10:49:42] (03PS20) 10Daimona Eaytoy: [WIP] Add phan configuration [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) [10:50:57] (03CR) 10Daimona Eaytoy: "check experimental" [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/427851 (https://phabricator.wikimedia.org/T192325) (owner: 10Daimona Eaytoy) [10:51:50] (03PS1) 10Jayprakash12345: Use 'default' instead of 'value' [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/428050 (https://phabricator.wikimedia.org/T192705) [10:58:00] (03PS4) 10Thiemo Kreuz (WMDE): Performance optimizations and cleanups on CSSMin library [core] - 10https://gerrit.wikimedia.org/r/427662 [11:07:53] 10Page-Previews: [Feedback] Personal observations about the page previews feature usuability - https://phabricator.wikimedia.org/T192710#4147604 (10jcrespo) [11:10:22] (03PS3) 10Tacsipacsi: Set $linkTrail for Abkhazian. [core] - 10https://gerrit.wikimedia.org/r/423523 (https://phabricator.wikimedia.org/T189923) [11:14:51] 10Page-Previews: [Feedback] Personal observations about the page previews feature usability - https://phabricator.wikimedia.org/T192710#4147616 (10jcrespo) [11:16:56] 10MediaWiki-extensions-Scribunto, 10User-Urbanecm: Localize Scribunto namespaces into lfn - https://phabricator.wikimedia.org/T184516#4147618 (10MarcoAurelio) [11:17:45] 10MediaWiki-extensions-Scribunto, 10User-Urbanecm: Localize Scribunto namespaces into lfn - https://phabricator.wikimedia.org/T184516#3886089 (10MarcoAurelio) Using `Modulo_Discute` as all namespaces at lfnwiki use `$name_Discute`. [11:23:35] (03CR) 10Gopavasanth: [C: 031] "> Post-merge build succeeded." [core] - 10https://gerrit.wikimedia.org/r/426842 (https://phabricator.wikimedia.org/T117726) (owner: 10Prtksxna) [11:26:38] 10MediaWiki-extensions-CentralAuth, 10CSS, 10Patch-For-Review, 10User-MarcoAurelio: Special:WikiSets should use CSS instead of deprecated width attribute - https://phabricator.wikimedia.org/T192273#4147622 (10MarcoAurelio) p:05Triage>03Normal [11:32:13] 10MediaWiki-General-or-Unknown: Special:Notifications gives a PHP fatal error - https://phabricator.wikimedia.org/T192711#4147627 (10Smartse) [11:32:43] (03PS3) 10Jayprakash12345: Convert Special:MapSources to use OOUI [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/425118 (https://phabricator.wikimedia.org/T191829) [11:33:54] (03CR) 10jerkins-bot: [V: 04-1] Convert Special:MapSources to use OOUI [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/425118 (https://phabricator.wikimedia.org/T191829) (owner: 10Jayprakash12345) [11:34:20] (03PS4) 10Jayprakash12345: Convert Special:MapSources to use OOUI [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/425118 (https://phabricator.wikimedia.org/T191829) [11:34:59] 10OABot: Simple commands to generate suggestions for a set of articles - https://phabricator.wikimedia.org/T192712#4147637 (10Nemo_bis) [11:35:25] (03PS5) 10Jayprakash12345: Convert Special:MapSources to use OOUI [extensions/MapSources] - 10https://gerrit.wikimedia.org/r/425118 (https://phabricator.wikimedia.org/T191829) [11:45:31] (03PS17) 10星耀晨曦: Checks if open_basedir include $wgGitBin before is_file() [core] - 10https://gerrit.wikimedia.org/r/416234 (https://phabricator.wikimedia.org/T74445) [11:45:39] (03CR) 10星耀晨曦: Checks if open_basedir include $wgGitBin before is_file() (032 comments) [core] - 10https://gerrit.wikimedia.org/r/416234 (https://phabricator.wikimedia.org/T74445) (owner: 10星耀晨曦) [11:50:25] 10OABot: Strip .pdf from arxiv identifiers before adding them - https://phabricator.wikimedia.org/T187791#4147671 (10Headbomb) It's not deployed now: * https://en.wikipedia.org/w/index.php?title=Correlation_and_dependence&type=revision&diff=837431132&oldid=831279243 [11:52:36] 10MediaWiki-Internationalization, 10CirrusSearch, 10Discovery, 10Discovery-Search: Serbian language search differentiates between Cyrillic and Latin alphabets - https://phabricator.wikimedia.org/T138857#4147672 (10debt) *hot dog* :-P [12:08:59] 10MediaWiki-Internationalization, 10Patch-For-Review, 10User-Urbanecm: Translate mediawiki namespaces into Gorontalo - https://phabricator.wikimedia.org/T189127#4147678 (10MarcoAurelio) p:05Low>03Unbreak! Wiki created with none of this created == all is in English and the more time we wait in have this d... [12:10:49] 10MediaWiki-Codesniffer: PHPCS should not complain about @covers and @dataProvider being used in traits - https://phabricator.wikimedia.org/T192384#4147681 (10daniel) > @daniel: Please feel free to disable this part of the sniff in your local .phpcs.xml for now. Suppressing it locally doesn't help with the fact... [12:14:17] Hauskatze, do you have some tips how to get reviewers for https://gerrit.wikimedia.org/r/#/c/420123/? It should be merged and backported in a SWAT and everything should be fine IMO. [12:14:20] But I may be wrong [12:15:24] Amire80, Raymond Spekking and Nikerabbit come to my mind [12:15:39] merge to master and backport to the currently version of gorwiki [12:16:48] Urbanecm: also, I think that some of your config was lost when D rebased the patches, etc. [12:17:06] have uploaded some follow-up patches [12:17:38] Hauskatze, I saw them and added for the very next SWAT (Monday, EU), IMO it can wait till then. [12:18:08] yep, then namespaceDupes.php --fix for all of them [12:18:43] Sure :) [12:19:30] you can add https://gerrit.wikimedia.org/r/#/c/428052/ if you'd like too [12:21:26] Added. And we have SWAT almost full (full because a lot of script). [12:22:10] yep, I was thinking on having a window just for this, but the script should be fast enough, the wiki has just been created [12:22:15] *the wikis have [12:22:32] jenkins is the thing that might slow us down a bit [12:22:35] or a lot [12:22:37] :) [12:22:55] (03PS1) 10Gopavasanth: Remove 'UnitTestList' hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) [12:25:40] :) [12:26:05] I've just poked Raymond to have a look at the MW-core patch. [12:26:16] thx [12:26:26] jenkins is capable to even cancel a SWAT window with just one patch [12:26:37] indeed [12:26:52] btw, are you going to the Barcelona hackhathon? ;) [12:27:01] *going to go ofc [12:29:08] Hauskatze, ^ [12:29:10] (03CR) 10Jayprakash12345: [C: 04-1] "Move all files from /tests to /tests/phpunit/" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [12:29:33] Urbanecm: nope [12:30:27] (03CR) 10Jayprakash12345: [C: 04-1] "And also https://www.mediawiki.org/wiki/Manual:Extension_registration#Unit_tests_auto-discovery" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [12:31:16] ok [12:33:02] Urbanecm: I don't think I'd show up in a public event either :) [12:34:39] :) [12:37:32] (03CR) 10Gopavasanth: "> And also https://www.mediawiki.org/wiki/Manual:Extension_registration#Unit_tests_auto-discovery" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [12:39:56] 10MediaWiki-Codesniffer: PHPCS should not complain about @covers and @dataProvider being used in traits - https://phabricator.wikimedia.org/T192384#4147686 (10thiemowmde) > As a workaround, I'm using the following to suppress the sniffer per file […] Please don't do this. This clutters the code and is very hard... [12:40:02] (03CR) 10Raimond Spekking: [C: 04-1] Add Gorontalo language file (032 comments) [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [12:41:43] (03CR) 10Raimond Spekking: [C: 032] MessagesEs.php: add non-camelcase names to some special page names [core] - 10https://gerrit.wikimedia.org/r/427866 (owner: 10MarcoAurelio) [12:52:17] (03Merged) 10jenkins-bot: MessagesEs.php: add non-camelcase names to some special page names [core] - 10https://gerrit.wikimedia.org/r/427866 (owner: 10MarcoAurelio) [12:54:12] (03CR) 10jenkins-bot: MessagesEs.php: add non-camelcase names to some special page names [core] - 10https://gerrit.wikimedia.org/r/427866 (owner: 10MarcoAurelio) [13:07:32] (03CR) 10He7d3r: [C: 031] Replace deprecated HTML 'width' function, use CSS instead [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/428022 (https://phabricator.wikimedia.org/T192273) (owner: 10MarcoAurelio) [13:11:16] 10MediaWiki-extensions-LoginNotify: LoginNotify should inform users of failed login attempts in the language of their home wiki - https://phabricator.wikimedia.org/T192638#4147700 (10Scott) To clarify here: their preferences where? On their home wiki? Or the one they've never used, where a security alert has bee... [13:13:20] (03CR) 10Physikerwelt: "> Yeah but in my search, I didn't find any such function in this" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [13:15:30] 10MediaWiki-Categories, 10MediaWiki-Watchlist, 10Commons: [Commons] A new image added to a category is not shown in Watchlist - https://phabricator.wikimedia.org/T192691#4147701 (10Aklapper) [13:16:07] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: Convert Special:PrefixIndex to OOUI - https://phabricator.wikimedia.org/T117726#4147702 (10Gopavasanth) [13:21:42] (03PS1) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [13:24:54] (03CR) 10jerkins-bot: [V: 04-1] Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) (owner: 10Physikerwelt) [13:26:26] (03PS1) 10Umherirrender: Move information from .eslintignore into Gruntfile.js [skins/Timeless] - 10https://gerrit.wikimedia.org/r/428061 (https://phabricator.wikimedia.org/T179195) [13:26:33] (03PS1) 10Gopavasanth: Convert Special:PrefixIndex to OOUI [core] - 10https://gerrit.wikimedia.org/r/428062 [13:29:17] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: Convert Special:PrefixIndex to OOUI - https://phabricator.wikimedia.org/T117726#4147722 (10Gopavasanth) a:05Haritha28>03Gopavasanth [13:29:43] (03PS2) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [13:30:25] (03CR) 10Zoranzoki21: "recheck" [core] - 10https://gerrit.wikimedia.org/r/428062 (owner: 10Gopavasanth) [13:35:25] (03PS3) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [13:45:48] (03CR) 10jerkins-bot: [V: 04-1] Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) (owner: 10Physikerwelt) [13:47:43] 10UI-Standardization, 10OOUI, 10Patch-For-Review, 10UI-Standardization-Kanban: De-emphasize toolbar tool group borders - https://phabricator.wikimedia.org/T191266#4099184 (10Esanders) >>! In T191266#4101944, @Nirzar wrote: > {F16635282} > > we might wanna get rid of borders for action toolbar simple butto... [13:49:38] (03PS2) 10Zoranzoki21: Remove 'UnitTestList' hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [13:53:43] (03CR) 10Jayprakash12345: [C: 031] Remove 'UnitTestList' hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [14:14:34] (03PS4) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [14:14:57] 10Wikimedia-Site-requests, 10Community-consensus-needed: Enable Extension:Wikilove at it.wikiversity.org - https://phabricator.wikimedia.org/T190621#4147743 (10Tulsi_Bhagat) p:05Triage>03Normal a:03Tulsi_Bhagat Moving ahead..? [14:16:34] (03CR) 10Physikerwelt: [C: 032] Remove 'UnitTestList' hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [14:17:27] (03Merged) 10jenkins-bot: Remove 'UnitTestList' hook [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [14:18:07] 10Wikimedia-Site-requests: Enable Extension:Wikilove at it.wikiversity.org - https://phabricator.wikimedia.org/T190621#4147748 (10Tulsi_Bhagat) We have [[https://it.wikiversity.org/wiki/Discussioni_Wikiversit%C3%A0:Wikilove|a link]]. So, Removing the project. [14:20:16] (03CR) 10Gopavasanth: "> Change has been successfully merged by jenkins-bot" [extensions/MathSearch] - 10https://gerrit.wikimedia.org/r/428057 (https://phabricator.wikimedia.org/T142120) (owner: 10Gopavasanth) [14:24:37] (03CR) 10jerkins-bot: [V: 04-1] Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) (owner: 10Physikerwelt) [14:33:44] 10Wikimedia-Site-requests: Enable Extension:Wikilove at it.wikiversity.org - https://phabricator.wikimedia.org/T190621#4147754 (10Tulsi_Bhagat) 05Open>03stalled After reading whole discussion with the help of google translate, I think I will better wait for green light on discussion page. @LosVegas, Ping me... [14:36:19] 10Wikimedia-Site-requests, 10Community-consensus-needed: Enable Extension:Wikilove at it.wikiversity.org - https://phabricator.wikimedia.org/T190621#4147757 (10Tulsi_Bhagat) >>! In T190621#4147748, @Tulsi_Bhagat wrote: > We have [[https://it.wikiversity.org/wiki/Discussioni_Wikiversit%C3%A0:Wikilove|a link]].... [14:41:38] 10MediaWiki-extensions-Other, 10Easy: Set getGroupName() For Special:SecureAuthInfo - https://phabricator.wikimedia.org/T191195#4147762 (10Tulsi_Bhagat) p:05Triage>03Normal a:03Tulsi_Bhagat [14:47:56] (03CR) 10Zoranzoki21: "recheck" [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/418585 (https://phabricator.wikimedia.org/T189372) (owner: 10Gopavasanth) [15:01:48] (03Draft2) 10Tulsi Bhagat: Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) [15:02:42] (03CR) 10Umherirrender: "The lib folder is defined to allow all files run as standalone without MediaWiki, see README inside - https://gerrit.wikimedia.org/r/plugi" [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [15:05:12] 10MediaWiki-Core-Tests, 10MediaWiki-extensions-General, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: Remove UnitTestsList hook subscribers, move tests to be autodiscovered for extensions that have been converted to ext... - https://phabricator.wikimedia.org/T142120#4147771 [15:06:33] (03CR) 10Jayprakash12345: "recheck" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:07:38] (03CR) 10jerkins-bot: [V: 04-1] Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:07:55] (03Abandoned) 10Daniel Kinzler: [WIP][MCR] Split WikiPage class [core] - 10https://gerrit.wikimedia.org/r/392089 (https://phabricator.wikimedia.org/T174039) (owner: 10Daniel Kinzler) [15:13:53] (03PS3) 10Jayprakash12345: Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:15:42] (03PS4) 10Gopavasanth: Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:17:13] (03CR) 10Gopavasanth: "According to task description return value must be "user" not "users"" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:17:22] 10MobileFrontend, 10Multi-Content-Revisions, 10Readers-Web-Backlog (Tracking), 10Technical-Debt (RW-Tech-Debt): Move InlineDifferenceEngine into core / remove MobileDiff - https://phabricator.wikimedia.org/T117279#4147778 (10Ladsgroup) No, I want it as part of T105518 for Scoring platform team [15:17:30] (03PS140) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [15:18:20] 10MediaWiki-extensions-Other, 10Easy, 10Patch-For-Review: Set getGroupName() For Special:SecureAuthInfo - https://phabricator.wikimedia.org/T191195#4147780 (10Jayprakash12345) [15:19:26] (03CR) 10Jayprakash12345: "> According to task description return value must be "user" not "users"" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:20:08] (03CR) 10Gopavasanth: "> > According to task description return value must be "user" not" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:21:32] (03PS5) 10Gopavasanth: Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:23:10] (03CR) 10Jayprakash12345: "recheck" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:27:06] (03CR) 10Jayprakash12345: [C: 032] Set getGroupName() For Special:SecureAuthInfo [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:32:01] 10MediaWiki-extensions-Other, 10User-Jayprakash12345: Support and Improvement of Extension:SecureAuth (tracking) - https://phabricator.wikimedia.org/T191169#4147788 (10Jayprakash12345) [15:32:07] 10MediaWiki-extensions-Other, 10Easy: Set getGroupName() For Special:SecureAuthInfo - https://phabricator.wikimedia.org/T191195#4147785 (10Jayprakash12345) 05Open>03Resolved [15:32:54] (03CR) 10Jayprakash12345: [C: 032] "Thanks :)" [extensions/SecureAuth] - 10https://gerrit.wikimedia.org/r/428064 (https://phabricator.wikimedia.org/T191195) (owner: 10Tulsi Bhagat) [15:41:53] 10FormWizard, 10Wikimedia Resource Center: Change 'Header' field in FormWizard Form to add new entry to 'Title' and 'URL' fields - https://phabricator.wikimedia.org/T192716#4147789 (10Mrjohncummings) [15:42:07] 10FormWizard, 10Wikimedia Resource Center: Change 'Header' field in FormWizard Form to add new entry to 'Title' and 'URL' fields - https://phabricator.wikimedia.org/T192716#4147801 (10Mrjohncummings) @mcruzWMF [15:43:14] 10FormWizard, 10Wikimedia Resource Center: Change 'Header' field in FormWizard Form to add new entry to 'Title' and 'URL' fields - https://phabricator.wikimedia.org/T192716#4147803 (10Mrjohncummings) [15:55:29] (03PS1) 10Umherirrender: Run php scripts\generate.php on 32 bit [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/428067 (https://phabricator.wikimedia.org/T188821) [15:55:58] (03CR) 10jerkins-bot: [V: 04-1] Run php scripts\generate.php on 32 bit [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/428067 (https://phabricator.wikimedia.org/T188821) (owner: 10Umherirrender) [15:56:18] 10MediaWiki-User-login-and-signup, 10Security-Team, 10Patch-For-Review: PasswordBlacklist unit tests fails on 32 bit machine - https://phabricator.wikimedia.org/T188821#4147806 (10Umherirrender) [It seems I have my 7.0.29 installed as 64, because it works there.] The 32 bit is checked inside BloomFilter cla... [15:56:28] (03CR) 10Umherirrender: [C: 04-2] "For Reedy to work with" [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/428067 (https://phabricator.wikimedia.org/T188821) (owner: 10Umherirrender) [15:57:38] 04(no projects): Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4147807 (10Mrjohncummings) [15:58:21] 10MediaWiki-Gallery, 10Multimedia: Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4147816 (10Mrjohncummings) [15:59:10] (03CR) 10Umherirrender: [C: 04-2] "It seems gerrit diff is not the best for such long lines, but my IDE shows the different only inside the "arr" key of the json" [libs/PasswordBlacklist] - 10https://gerrit.wikimedia.org/r/428067 (https://phabricator.wikimedia.org/T188821) (owner: 10Umherirrender) [16:00:33] 10MediaWiki-Gallery, 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4147818 (10Aklapper) [16:01:50] (03PS8) 10Daniel Kinzler: WIP DNM RevisionStore, multi content mode.. [core] - 10https://gerrit.wikimedia.org/r/416465 (https://phabricator.wikimedia.org/T174024) (owner: 10Addshore) [16:02:48] (03CR) 10jerkins-bot: [V: 04-1] WIP DNM RevisionStore, multi content mode.. [core] - 10https://gerrit.wikimedia.org/r/416465 (https://phabricator.wikimedia.org/T174024) (owner: 10Addshore) [16:03:06] (03CR) 10jerkins-bot: [V: 04-1] WIP DNM RevisionStore, multi content mode.. [core] - 10https://gerrit.wikimedia.org/r/416465 (https://phabricator.wikimedia.org/T174024) (owner: 10Addshore) [16:03:14] 10MediaWiki-User-login-and-signup, 10Security-Team, 10Patch-For-Review: PasswordBlacklist unit tests fails on 32 bit php - https://phabricator.wikimedia.org/T188821#4147820 (10Umherirrender) p:05Triage>03Normal [16:08:17] (03CR) 10Jack Phoenix: [C: 032] Fix sidebar chunk spacing in two-column (desktop-mid) view [skins/Timeless] - 10https://gerrit.wikimedia.org/r/406045 (https://phabricator.wikimedia.org/T181256) (owner: 10Evad37) [16:10:05] (03Merged) 10jenkins-bot: Fix sidebar chunk spacing in two-column (desktop-mid) view [skins/Timeless] - 10https://gerrit.wikimedia.org/r/406045 (https://phabricator.wikimedia.org/T181256) (owner: 10Evad37) [16:13:50] (03CR) 10星耀晨曦: "Same case, var_dump(function_exists('utf8_decode')); return bool(true). utf8_decode() and utf8_encode() are a member of 10MediaWiki-Gallery, 10Multimedia, 10VisualEditor, 10VisualEditor-MediaWiki-Media: Provide button to replace image in Visual Editor Gallery - https://phabricator.wikimedia.org/T192717#4147823 (10Mrjohncummings) @Anthere @Islahaddow [16:17:11] (03CR) 10Jack Phoenix: [C: 04-2] "Why?" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/420384 (https://phabricator.wikimedia.org/T174526) (owner: 10Framawiki) [16:19:38] (03CR) 10星耀晨曦: "I see the change log of two functions:" [core] - 10https://gerrit.wikimedia.org/r/426729 (owner: 10Legoktm) [16:20:05] (03CR) 10Gergő Tisza: [MCR] Factor PageUpdater out of WikiPage (032 comments) [core] - 10https://gerrit.wikimedia.org/r/405015 (https://phabricator.wikimedia.org/T174038) (owner: 10Daniel Kinzler) [16:22:33] (03CR) 10Jack Phoenix: "Has this patch been superseded by the newer one (https://gerrit.wikimedia.org/r/403586/) which has more reviewers and which changes only o" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/407886 (https://phabricator.wikimedia.org/T182533) (owner: 10Himanshuc3) [16:24:18] (03CR) 10Jack Phoenix: [C: 04-1] "You'll probably want to use skinStyles (see skin.json) instead to piggyback on the appropriate ResourceLoader module, which seems to be me" (032 comments) [skins/Timeless] - 10https://gerrit.wikimedia.org/r/407623 (https://phabricator.wikimedia.org/T185331) (owner: 10Evad37) [16:25:27] (03CR) 10Jack Phoenix: [C: 032] Move information from .eslintignore into Gruntfile.js [skins/Timeless] - 10https://gerrit.wikimedia.org/r/428061 (https://phabricator.wikimedia.org/T179195) (owner: 10Umherirrender) [16:26:55] (03Merged) 10jenkins-bot: Move information from .eslintignore into Gruntfile.js [skins/Timeless] - 10https://gerrit.wikimedia.org/r/428061 (https://phabricator.wikimedia.org/T179195) (owner: 10Umherirrender) [16:32:50] 10MediaWiki-extensions-Cargo: Exception on page save: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T192718#4147827 (10Julien.Schmidt) [16:47:55] 04(no projects): Suggestion: Modify and Deploy RC Patrol extension from wikiHow onto Wikimedia projects. - https://phabricator.wikimedia.org/T192719#4147840 (10UpsandDowns1234) [17:08:49] (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] "Ok, thanks! I wasn't aware of this. I will fix this as soon as I'm back from my vacation in a week." [core] - 10https://gerrit.wikimedia.org/r/427662 (owner: 10Thiemo Kreuz (WMDE)) [17:10:17] 10MediaWiki-extensions-Cargo: Exception on page save: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T192718#4147850 (10Julien.Schmidt) Here is the SQL Dump from from right before the exception is thrown: ``` [DBQuery] wiki BEGIN /* WikiPage::doModify */ [DB... [17:23:21] (03CR) 10Bartosz Dziewoński: [C: 031] Fix width of OOUI TextInputWidget with .mw-editfont-... classes (031 comment) [core] - 10https://gerrit.wikimedia.org/r/407416 (https://phabricator.wikimedia.org/T192373) (owner: 10Esanders) [17:23:23] (03PS6) 10Bartosz Dziewoński: Fix width of OOUI TextInputWidget with .mw-editfont-... classes [core] - 10https://gerrit.wikimedia.org/r/407416 (https://phabricator.wikimedia.org/T192373) (owner: 10Esanders) [17:35:40] (03CR) 10Bartosz Dziewoński: "We added these because user JS doing something like `document.write('')` was causin" [core] - 10https://gerrit.wikimedia.org/r/428041 (https://phabricator.wikimedia.org/T192623) (owner: 10Krinkle) [17:39:10] 04(no projects): Suggestion: Modify and Deploy RC Patrol extension from wikiHow onto Wikimedia projects. - https://phabricator.wikimedia.org/T192719#4147852 (10UpsandDowns1234) [17:59:14] 10MediaWiki-extensions-Cargo: Exception on page save: mass commit/rollback of peer transaction required (DBO_TRX set) - https://phabricator.wikimedia.org/T192718#4147854 (10Julien.Schmidt) It indeed works until 8d68145 and stops working with 3975e04 (https://gerrit.wikimedia.org/r/#/c/421496/). [18:00:08] Someone has a example with user script to edit a page section? [18:01:38] (03PS1) 10SamanthaNguyen: Sniff: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428071 [18:01:44] 10MediaWiki-Change-tagging, 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#4147855 (10Daimona) @TTO Right. Actually, I find it quite tricky to properly solve the problem here, but my proposal is to rework the way AbuseFilter stores used tag... [18:03:06] (03PS1) 10Umherirrender: Run stylelint for less [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/428072 [18:10:33] (03CR) 10Gopavasanth: [C: 031] "Looks Good." [core] - 10https://gerrit.wikimedia.org/r/428036 (https://phabricator.wikimedia.org/T192694) (owner: 10Jayprakash12345) [18:14:41] (03CR) 10Bartosz Dziewoński: [C: 032] Run stylelint for less [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/428072 (owner: 10Umherirrender) [18:16:19] (03Merged) 10jenkins-bot: Run stylelint for less [skins/CologneBlue] - 10https://gerrit.wikimedia.org/r/428072 (owner: 10Umherirrender) [18:21:40] https://www.mediawiki.org/wiki/API:Edit [18:32:42] 10MediaWiki-Authentication-and-authorization: Suggestion for forgotten password lookup scheme - https://phabricator.wikimedia.org/T190948#4147864 (10Aklapper) 05stalled>03declined Unfortunately closing this report as no further information has been provided. @Vid2vid: After you have provided the information... [18:34:52] (03PS1) 10Umherirrender: Add RandomPages [extensions] - 10https://gerrit.wikimedia.org/r/428074 [18:35:34] (03CR) 10Umherirrender: [V: 032 C: 032] Add RandomPages [extensions] - 10https://gerrit.wikimedia.org/r/428074 (owner: 10Umherirrender) [18:41:24] 10MediaWiki-Internationalization, 10Patch-For-Review, 10User-Urbanecm: Translate mediawiki namespaces into Gorontalo - https://phabricator.wikimedia.org/T189127#4032223 (10Dereckson) I concur the UBN! prioritization. For a wiki, in a new language, the language file should be committed *before* creating it,... [18:54:52] (03PS6) 10Dereckson: Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [18:56:34] 10MediaWiki-Internationalization, 10Patch-For-Review, 10User-Urbanecm: Add Gorontalo language support to MediaWiki - https://phabricator.wikimedia.org/T189127#4147872 (10Dereckson) [18:57:22] (03PS7) 10Dereckson: Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [18:57:47] (03CR) 10Dereckson: "PS6: Fix namespaces. PS7: Release notes." [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [18:57:57] (03CR) 10Dereckson: [C: 031] Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [19:13:13] 10MediaWiki-extensions-Variables: Create short-hand function for {{#var:x|{{#vardefineecho:x| arg }}}} - https://phabricator.wikimedia.org/T192720#4147873 (10MGChecker) [19:14:28] 10MediaWiki-extensions-Variables, 10Patch-For-Review: Wrong #var and #varexists values due to template caching - https://phabricator.wikimedia.org/T191574#4147884 (10MGChecker) [19:21:37] (03PS141) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [19:23:57] (03PS1) 10Cicalese: Bump version number. [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/428076 [19:24:32] (03CR) 10Raimond Spekking: [C: 032] Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [19:26:49] (03CR) 10Cicalese: [C: 032] Bump version number. [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/428076 (owner: 10Cicalese) [19:27:28] (03PS1) 10Umherirrender: Fix bad spacing in composer.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/428078 [19:28:42] (03PS1) 10Umherirrender: Add SecureAuth [extensions] - 10https://gerrit.wikimedia.org/r/428079 [19:29:00] (03CR) 10Umherirrender: [V: 032 C: 032] Add SecureAuth [extensions] - 10https://gerrit.wikimedia.org/r/428079 (owner: 10Umherirrender) [19:35:42] (03Merged) 10jenkins-bot: Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [19:35:44] (03Merged) 10jenkins-bot: Bump version number. [extensions/SimpleSAMLphp] - 10https://gerrit.wikimedia.org/r/428076 (owner: 10Cicalese) [19:37:26] (03CR) 10jenkins-bot: Add Gorontalo language file [core] - 10https://gerrit.wikimedia.org/r/420123 (https://phabricator.wikimedia.org/T189127) (owner: 10Urbanecm) [19:46:21] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [19:46:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix bad spacing in composer.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/428078 (owner: 10Umherirrender) [19:48:07] (03PS1) 10Umherirrender: Split aliases for special pages and magic words in own files [extensions/WhoIsWatching] - 10https://gerrit.wikimedia.org/r/428080 [19:48:45] 10MediaWiki-extensions-Babel, 10MW-1.28-release (WMF-deploy-2016-08-16_(1.28.0-wmf.15)): Babel language codes should be normalised to lower case when used in categories - https://phabricator.wikimedia.org/T63993#4147888 (10JohanahoJ) I have now blocked the bot account on svwiki. Any progress? [19:49:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Fix strict standard [extensions/TopLists] - 10https://gerrit.wikimedia.org/r/428020 (owner: 10Umherirrender) [19:51:50] (03CR) 10jerkins-bot: [V: 04-1] Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [19:52:05] (03Merged) 10jenkins-bot: Fix bad spacing in composer.json [extensions/GoogleAnalyticsMetrics] - 10https://gerrit.wikimedia.org/r/428078 (owner: 10Umherirrender) [19:52:07] (03Merged) 10jenkins-bot: Fix strict standard [extensions/TopLists] - 10https://gerrit.wikimedia.org/r/428020 (owner: 10Umherirrender) [19:55:48] (03PS1) 10Umherirrender: build: Add .gitignore [extensions/RandomPages] - 10https://gerrit.wikimedia.org/r/428082 [19:56:38] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/428081 (owner: 10L10n-bot) [19:58:58] (03CR) 10VolkerE: [C: 032] "@Gopavasanth Yes, indeed." [core] - 10https://gerrit.wikimedia.org/r/426842 (https://phabricator.wikimedia.org/T117726) (owner: 10Prtksxna) [20:00:50] (03CR) 10Jayprakash12345: "@VolkerE Maybe you can review? Because Iy is part of HTMLForm" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/428050 (https://phabricator.wikimedia.org/T192705) (owner: 10Jayprakash12345) [20:01:50] (03PS5) 10Aaron Schulz: Use CONN_TRX_AUTO in WikiPage speculative revision ID callback [core] - 10https://gerrit.wikimedia.org/r/421699 [20:04:24] (03PS1) 10Umherirrender: Move alias file to root folder [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/428083 [20:09:40] (03PS1) 10Umherirrender: Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/428084 [20:11:53] (03CR) 10jerkins-bot: [V: 04-1] Use CONN_TRX_AUTO in WikiPage speculative revision ID callback [core] - 10https://gerrit.wikimedia.org/r/421699 (owner: 10Aaron Schulz) [20:12:39] (03CR) 10jerkins-bot: [V: 04-1] Require MediaWiki 1.31 in extension.json for AutoloadNamespaces [extensions/BlueSpicePageAssignments] - 10https://gerrit.wikimedia.org/r/428084 (owner: 10Umherirrender) [20:17:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/BetaFeatures] - 10https://gerrit.wikimedia.org/r/428086 (owner: 10L10n-bot) [20:19:19] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/428091 (owner: 10L10n-bot) [20:24:33] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Babel] - 10https://gerrit.wikimedia.org/r/428092 (owner: 10L10n-bot) [20:26:12] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/428108 (owner: 10L10n-bot) [20:28:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Echo] - 10https://gerrit.wikimedia.org/r/428099 (owner: 10L10n-bot) [20:30:04] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/428098 (owner: 10L10n-bot) [20:33:45] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Gadgets] - 10https://gerrit.wikimedia.org/r/428104 (owner: 10L10n-bot) [20:35:01] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Popups] - 10https://gerrit.wikimedia.org/r/428111 (owner: 10L10n-bot) [20:35:12] (03PS1) 10Umherirrender: Fix whitespaces from codesniffer [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428126 [20:36:13] (03PS2) 10Umherirrender: Fix whitespaces issues found by codesniffer [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428126 [20:37:15] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/428109 (owner: 10L10n-bot) [20:38:32] (03CR) 10Umherirrender: [V: 032] "Break circular" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/427935 (owner: 10Umherirrender) [20:38:45] (03PS3) 10Umherirrender: Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 [20:38:51] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [20:43:51] (03CR) 10VolkerE: [C: 032] Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428036 (https://phabricator.wikimedia.org/T192694) (owner: 10Jayprakash12345) [20:44:14] (03Merged) 10jenkins-bot: Remove __construct from phpunit tests [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/428043 (owner: 10Umherirrender) [20:44:26] 10MediaWiki-Change-tagging, 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#4147900 (10Daimona) I tried to figure out where we may store our data. External storage doesn't seem suitable, while DB would be an overkill: basically we only need... [20:44:39] (03PS5) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/426355 (owner: 10Libraryupgrader) [20:44:42] (03CR) 10Umherirrender: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 18.0.0 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/426355 (owner: 10Libraryupgrader) [20:44:46] 10MediaWiki-Special-pages, 10Patch-For-Review, 10Technical-Debt, 10User-Jayprakash12345: Use 'type' => 'user' for username in Special:Newpages - https://phabricator.wikimedia.org/T192694#4147901 (10Volker_E) Would you do this for Special:Unblock as well? [20:45:53] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review: Convert Special:PrefixIndex to OOUI - https://phabricator.wikimedia.org/T117726#4147902 (10Volker_E) [20:54:27] (03Merged) 10jenkins-bot: Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428036 (https://phabricator.wikimedia.org/T192694) (owner: 10Jayprakash12345) [20:56:09] (03CR) 10jenkins-bot: Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428036 (https://phabricator.wikimedia.org/T192694) (owner: 10Jayprakash12345) [21:23:57] (03CR) 10SamanthaNguyen: "Thanks, left a few comments that should be fixed before this patch gets merged." (035 comments) [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428126 (owner: 10Umherirrender) [21:26:59] (03PS1) 10Superyetkin: Fixed the bug [core] - 10https://gerrit.wikimedia.org/r/428129 [21:34:15] 10MediaWiki-extensions-ParserFunctions, 10I18n: {{#time}} parser function produces incorrect dates when displaying dates before 1941 in Thai language - https://phabricator.wikimedia.org/T68648#689810 (10Superyetkin) Patch uploaded at https://gerrit.wikimedia.org/r/#/c/428129/ [21:46:21] (03CR) 10Jack Phoenix: [C: 032] Sniff: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428071 (owner: 10SamanthaNguyen) [21:50:18] (03Merged) 10jenkins-bot: Sniff: Enable MediaWiki.NamingConventions.LowerCamelFunctionsName.FunctionName [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/428071 (owner: 10SamanthaNguyen) [22:57:12] (03PS5) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [23:06:53] (03PS6) 10Physikerwelt: Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) [23:09:31] (03CR) 10jerkins-bot: [V: 04-1] Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) (owner: 10Physikerwelt) [23:11:34] (03CR) 10jerkins-bot: [V: 04-1] Move phpunit test files [extensions/Math] - 10https://gerrit.wikimedia.org/r/428060 (https://phabricator.wikimedia.org/T142120) (owner: 10Physikerwelt) [23:14:22] 10MediaWiki-Special-pages, 10MW-1.32-release-notes (WMF-deploy-2018-04-24 (1.32.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt, 10User-Jayprakash12345: Use 'type' => 'user' for username in Special pages - https://phabricator.wikimedia.org/T192694#4147927 (10Jayprakash12345) [23:20:41] (03PS1) 10Jayprakash12345: Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428131 (https://phabricator.wikimedia.org/T192694) [23:23:23] (03PS2) 10Jayprakash12345: Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428131 (https://phabricator.wikimedia.org/T192694) [23:27:27] (03PS1) 10Jayprakash12345: Remove cssclass in the favor of 'type' => 'user' [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/428132 (https://phabricator.wikimedia.org/T192694) [23:47:38] (03PS1) 10Jayprakash12345: Remove cssclass in the favor of 'type' => 'user' [core] - 10https://gerrit.wikimedia.org/r/428133 (https://phabricator.wikimedia.org/T192694)