[00:06:04] (03PS1) 10Legoktm: Fix some file names to match their class names [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426821 [00:06:06] (03PS1) 10Legoktm: Add COPYING [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426822 [00:06:08] (03PS1) 10Legoktm: Add GPL file header to PHP classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426823 [00:06:10] (03PS1) 10Legoktm: Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 [00:06:20] (03PS1) 10Legoktm: Take advantage of Title::isSpecial() [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426825 [00:06:21] (03PS1) 10Legoktm: Get rid of ICustomizableSkin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426826 [00:06:34] (03PS1) 10Legoktm: Split MenuEntry to its own file [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426827 [00:06:51] (03PS1) 10Legoktm: getUser() will always return a User object [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426828 [00:06:53] (03PS1) 10Legoktm: Use ExtensionRegistry to detect whether Echo is installed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426829 [00:06:55] (03PS1) 10Legoktm: Remove @return bool from hooks that don't return anything [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426830 [00:06:57] (03PS1) 10Legoktm: Remove unused variable [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426831 [00:06:59] (03PS1) 10Legoktm: Let special pages redirect to the login page themselves [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426832 [00:09:50] (03CR) 10Jack Phoenix: [C: 032] Fix some file names to match their class names [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426821 (owner: 10Legoktm) [00:10:02] (03CR) 10Jack Phoenix: [C: 032] Add COPYING [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426822 (owner: 10Legoktm) [00:10:21] (03CR) 10Jack Phoenix: [C: 032] Add GPL file header to PHP classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426823 (owner: 10Legoktm) [00:10:38] (03CR) 10Jack Phoenix: [C: 032] Remove @return bool from hooks that don't return anything [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426830 (owner: 10Legoktm) [00:15:08] (03CR) 10jerkins-bot: [V: 04-1] Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 (owner: 10Legoktm) [00:15:46] (03CR) 10jerkins-bot: [V: 04-1] Take advantage of Title::isSpecial() [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426825 (owner: 10Legoktm) [00:16:24] (03CR) 10jerkins-bot: [V: 04-1] Get rid of ICustomizableSkin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426826 (owner: 10Legoktm) [00:17:24] (03Merged) 10jenkins-bot: Fix some file names to match their class names [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426821 (owner: 10Legoktm) [00:19:31] (03Merged) 10jenkins-bot: Add COPYING [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426822 (owner: 10Legoktm) [00:20:20] (03Merged) 10jenkins-bot: Add GPL file header to PHP classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426823 (owner: 10Legoktm) [00:27:49] (03CR) 10Legoktm: Declare some properties on classes (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/426574 (owner: 10Legoktm) [00:27:51] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry to detect whether Echo is installed [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426829 (owner: 10Legoktm) [00:30:58] (03CR) 10jerkins-bot: [V: 04-1] Remove unused variable [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426831 (owner: 10Legoktm) [00:31:47] (03CR) 10jerkins-bot: [V: 04-1] Let special pages redirect to the login page themselves [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426832 (owner: 10Legoktm) [00:32:48] (03CR) 10jenkins-bot: Fix some file names to match their class names [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426821 (owner: 10Legoktm) [00:33:13] (03CR) 10jenkins-bot: Add GPL file header to PHP classes [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426823 (owner: 10Legoktm) [00:33:28] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle Minerva Neue skin with MW 1.31 - https://phabricator.wikimedia.org/T191743#4132601 (10Legoktm) [00:34:02] (03CR) 10jerkins-bot: [V: 04-1] Remove @return bool from hooks that don't return anything [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426830 (owner: 10Legoktm) [00:34:06] (03CR) 10jenkins-bot: Add COPYING [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426822 (owner: 10Legoktm) [00:40:20] (03PS3) 10Jforrester: tests: Assert that the user who deleted a page is logged as such [core] - 10https://gerrit.wikimedia.org/r/415477 (https://phabricator.wikimedia.org/T188479) [00:41:03] 10MediaWiki-Core-Tests, 10Continuous-Integration-Config, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Use a more complex password for WikiAdmin in selenium tests - https://phabricator.wikimedia.org/T188520#4132613 (10Krinkle) >>! In T188520#4131548, @Reedy wrote: > Obvio... [00:41:07] (03PS1) 10Krinkle: selenium: Clean up wdio.conf.js [core] - 10https://gerrit.wikimedia.org/r/426833 [00:41:55] (03CR) 10Krinkle: "To be merged after Ibb388741fee96ce714 is live. Nothing depends on this, it just removes outdated strings that aren't used anymore after t" [core] - 10https://gerrit.wikimedia.org/r/426833 (owner: 10Krinkle) [00:47:41] (03CR) 10jerkins-bot: [V: 04-1] selenium: Clean up wdio.conf.js [core] - 10https://gerrit.wikimedia.org/r/426833 (owner: 10Krinkle) [00:49:42] (03PS1) 10Krinkle: [WIP] [DNM] resourceloader: Emit PHP/HHVM version as header [core] - 10https://gerrit.wikimedia.org/r/426834 (https://phabricator.wikimedia.org/T190548) [00:52:59] (03CR) 10Krinkle: "PS1: X-MediaWiki-PHP: 5.6.33-0+deb8u1" [core] - 10https://gerrit.wikimedia.org/r/426834 (https://phabricator.wikimedia.org/T190548) (owner: 10Krinkle) [00:53:00] James_F: ^ [00:53:36] Ta. [00:53:56] (03CR) 10Krinkle: [C: 032] rdbms: make LoadBalancer::doWait() cast $timeout to an integer [core] - 10https://gerrit.wikimedia.org/r/422706 (owner: 10Aaron Schulz) [00:54:23] (03CR) 10Krinkle: [C: 031] "LGTM, cc-ing Anomie for approval" [core] - 10https://gerrit.wikimedia.org/r/426274 (owner: 10Aaron Schulz) [00:55:44] (03CR) 10Jforrester: [C: 031] "Already exposed by SpecialVersion::softwareInformation()." [core] - 10https://gerrit.wikimedia.org/r/426834 (https://phabricator.wikimedia.org/T190548) (owner: 10Krinkle) [00:55:54] (03CR) 10Krinkle: [C: 031] "LGTM, needs a merge conflict resolution though" [core] - 10https://gerrit.wikimedia.org/r/424189 (owner: 10Aaron Schulz) [00:57:23] (03CR) 10Krinkle: "That returns wikitext-ish HTML though, not suitable for headers. Anyway, this isn't for merging, it's just for poking the current CI envir" [core] - 10https://gerrit.wikimedia.org/r/426834 (https://phabricator.wikimedia.org/T190548) (owner: 10Krinkle) [00:59:39] (03CR) 10Krinkle: [C: 031] Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 (owner: 10Legoktm) [01:00:11] (03CR) 10Krinkle: [C: 031] Take advantage of Title::isSpecial() [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426825 (owner: 10Legoktm) [01:00:29] (03CR) 10Krinkle: [C: 031] Get rid of ICustomizableSkin [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426826 (owner: 10Legoktm) [01:00:54] (03CR) 10Krinkle: "Is this the only case that violated the phpcs rule, or are there more?" [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426827 (owner: 10Legoktm) [01:01:22] (03Merged) 10jenkins-bot: rdbms: make LoadBalancer::doWait() cast $timeout to an integer [core] - 10https://gerrit.wikimedia.org/r/422706 (owner: 10Aaron Schulz) [01:02:35] (03CR) 10Krinkle: [C: 031] "Worth checking with someone who knows the code better what the original intention was here." (031 comment) [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426828 (owner: 10Legoktm) [01:03:13] (03CR) 10jenkins-bot: rdbms: make LoadBalancer::doWait() cast $timeout to an integer [core] - 10https://gerrit.wikimedia.org/r/422706 (owner: 10Aaron Schulz) [01:08:21] (03CR) 10Krinkle: PHPVersionCheck: Look for another `xml` function (031 comment) [core] - 10https://gerrit.wikimedia.org/r/426729 (owner: 10Legoktm) [01:23:03] (03CR) 10Krinkle: [C: 04-1] "Not sure why it failed, but now that we're here, does it make sense to use the new signature of getAnyOpenCon for this?" [core] - 10https://gerrit.wikimedia.org/r/421699 (owner: 10Aaron Schulz) [01:23:07] (03PS4) 10Krinkle: Use CONN_TRX_AUTO in WikiPage speculative revision ID callback [core] - 10https://gerrit.wikimedia.org/r/421699 (owner: 10Aaron Schulz) [01:23:36] (03PS6) 10Krinkle: rdbms: make select() warn when FOR UPDATE is used with aggregation [core] - 10https://gerrit.wikimedia.org/r/425731 (https://phabricator.wikimedia.org/T160910) (owner: 10Aaron Schulz) [01:27:52] (03PS1) 10GeoffreyT2000: Revert "Special:Preference: Check for changes before enabling Save button" [core] - 10https://gerrit.wikimedia.org/r/426835 (https://phabricator.wikimedia.org/T192147) [01:30:32] (03CR) 10jerkins-bot: [V: 04-1] rdbms: make select() warn when FOR UPDATE is used with aggregation [core] - 10https://gerrit.wikimedia.org/r/425731 (https://phabricator.wikimedia.org/T160910) (owner: 10Aaron Schulz) [01:31:43] 10MediaWiki-User-preferences, 10Anti-Harassment, 10Collaboration-Team-Triage, 10Notifications, and 2 others: Regression: Changes to email blacklist or muted users do not activate Save button in Preferences - https://phabricator.wikimedia.org/T192147#4129518 (10GeoffreyT2000) >>! In T192147#4130609, @TheDJ... [01:34:44] (03CR) 10jerkins-bot: [V: 04-1] rdbms: make select() warn when FOR UPDATE is used with aggregation [core] - 10https://gerrit.wikimedia.org/r/425731 (https://phabricator.wikimedia.org/T160910) (owner: 10Aaron Schulz) [01:58:58] 10MediaWiki-Categories, 10Wikimedia-Site-requests: Change default collation for WMF projects from uppercase to uca-default-u-kn - https://phabricator.wikimedia.org/T192252#4132655 (10kaldari) [02:05:12] (03CR) 10Prtksxna: [C: 031] Revert "Special:Preference: Check for changes before enabling Save button" [core] - 10https://gerrit.wikimedia.org/r/426835 (https://phabricator.wikimedia.org/T192147) (owner: 10GeoffreyT2000) [02:07:16] (03CR) 10Ebe123: [C: 031] "> > Your email is also out-of-date, but that can't be changed in the" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/426769 (owner: 10Guycn2) [02:07:45] (03CR) 10Ebe123: [C: 031] "(By that, I mean future commits)" [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/426769 (owner: 10Guycn2) [02:07:58] (03CR) 10Prtksxna: "I think it did, I've +1'd the revert" [core] - 10https://gerrit.wikimedia.org/r/423364 (https://phabricator.wikimedia.org/T180538) (owner: 10Prtksxna) [02:30:51] (03PS1) 10Samwilson: Add registration check to ensure load order [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/426836 (https://phabricator.wikimedia.org/T190353) [02:42:53] (03CR) 10Jforrester: [C: 04-1] "I'd rather we fix the issue with the mute feature preference code than re-break the preferences Save button." [core] - 10https://gerrit.wikimedia.org/r/426835 (https://phabricator.wikimedia.org/T192147) (owner: 10GeoffreyT2000) [02:43:18] (03CR) 10Legoktm: [C: 04-2] "With extension.json handling dependency management, we've been trying to move away from explicit load order definitions. Requiring an expl" [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/426836 (https://phabricator.wikimedia.org/T190353) (owner: 10Samwilson) [02:44:06] (03CR) 10Jforrester: [C: 031] "> That returns wikitext-ish HTML though, not suitable for headers. Anyway, this isn't for merging, it's just for poking the current CI env" [core] - 10https://gerrit.wikimedia.org/r/426834 (https://phabricator.wikimedia.org/T190548) (owner: 10Krinkle) [02:44:40] (03CR) 10Yaron Koren: [C: 032] "@Cicalese - great! Thank you for preserving backward compatibility with this patch." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/426321 (owner: 10Cicalese) [02:44:48] (03PS3) 10Yaron Koren: Replaced Linker::link() with LinkRenderer [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/426321 (owner: 10Cicalese) [02:52:29] (03PS1) 10Legoktm: [DNM] jenkins testing [extensions/Echo] - 10https://gerrit.wikimedia.org/r/426838 [02:52:42] (03CR) 10Legoktm: "check experimental" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/426838 (owner: 10Legoktm) [02:55:01] (03CR) 10Prtksxna: "James knows better." [core] - 10https://gerrit.wikimedia.org/r/426835 (https://phabricator.wikimedia.org/T192147) (owner: 10GeoffreyT2000) [02:59:19] (03CR) 10Jforrester: [C: 032] Remove gadget special-case from preferences cleanup [core] - 10https://gerrit.wikimedia.org/r/424507 (https://phabricator.wikimedia.org/T188966) (owner: 10Samwilson) [03:03:08] 10WikimediaUI Style Guide: Proof-read Design Style Guide contents - https://phabricator.wikimedia.org/T192181#4131039 (10Prtksxna) >>! From > **Play around** > Download Wikimedia Design Style Guide play? >>! From 10WikimediaUI Style Guide: Proof-read Design Style Guide contents - https://phabricator.wikimedia.org/T192181#4132669 (10Prtksxna) Yikes! Submitted that comment before finishing it. Will add again once I'm ready :) [03:04:45] (03Draft2) 10Yaron Koren: Fix for bcadef37f8d7 for PostgreSQL [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/426839 [03:06:06] (03Merged) 10jenkins-bot: Remove gadget special-case from preferences cleanup [core] - 10https://gerrit.wikimedia.org/r/424507 (https://phabricator.wikimedia.org/T188966) (owner: 10Samwilson) [03:07:52] (03CR) 10jenkins-bot: Remove gadget special-case from preferences cleanup [core] - 10https://gerrit.wikimedia.org/r/424507 (https://phabricator.wikimedia.org/T188966) (owner: 10Samwilson) [03:16:08] (03CR) 10Yaron Koren: [C: 032] Fix for bcadef37f8d7 for PostgreSQL [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/426839 (owner: 10Yaron Koren) [03:18:15] (03Merged) 10jenkins-bot: Fix for bcadef37f8d7 for PostgreSQL [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/426839 (owner: 10Yaron Koren) [03:18:22] 10WikimediaUI Style Guide: Proof-read Design Style Guide contents - https://phabricator.wikimedia.org/T192181#4132671 (10Prtksxna) I did a quick read through of the style guide and found some minor issues. Happy to submit a PR if we think they need to be fixed {icon smile-o}. >>! From (03PS1) 10Isarra: Add options parameter to BaseTemplate::getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [03:26:27] (03CR) 10Isarra: [C: 04-1] "DAMMIT THIS IS COMPLETELY USELESS." [core] - 10https://gerrit.wikimedia.org/r/371952 (owner: 10Isarra) [03:26:45] (03Abandoned) 10Isarra: Make BaseTemplate::getFooter use 'footer' as default id, and make id adjustible (was 'footer-bottom' because I wasn't paying attention) [core] - 10https://gerrit.wikimedia.org/r/371952 (owner: 10Isarra) [03:28:53] (03CR) 10Isarra: "Should this just be an entirely new function since there's no way to not trigger warnings no matter what we do in the same one?" [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [03:34:52] (03CR) 10jerkins-bot: [V: 04-1] Add options parameter to BaseTemplate::getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [03:49:18] (03PS2) 10Isarra: Add new BaseTemplate::getFooterBlock function as replacement for shitty getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [03:53:34] (03PS1) 10Samwilson: Add runtime cache for central IDs [extensions/GlobalPreferences] - 10https://gerrit.wikimedia.org/r/426841 (https://phabricator.wikimedia.org/T190425) [03:57:44] (03PS3) 10Isarra: Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [03:59:31] (03CR) 10Isarra: "Unless I screwed up (again), this should not break anything, and should also serve as a drop-in replacement in basically every skin I've l" [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [04:00:52] (03CR) 10Isarra: "Tested in monobook, vector, and greystuff." [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [04:01:32] 10MediaWiki-extensions-Other, 10Patch-For-Review, 10User-Zoranzoki21: Convert Loops to use extension registration - https://phabricator.wikimedia.org/T192113#4132691 (10Liuxinyu970226) [04:03:46] (03CR) 10Isarra: "Nevermind, I am still a moron." [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [04:03:51] (03CR) 10Isarra: [C: 04-1] Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [04:12:37] (03PS4) 10Isarra: Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [04:16:04] (03CR) 10Yaron Koren: [C: 032] "Trying again..." [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/426321 (owner: 10Cicalese) [04:18:03] (03Merged) 10jenkins-bot: Replaced Linker::link() with LinkRenderer [extensions/ReplaceText] - 10https://gerrit.wikimedia.org/r/426321 (owner: 10Cicalese) [04:20:52] 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech-Sprint, 10MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)), 10Patch-For-Review: GlobalPreferences deploy caused a significant increase in reads on s3 - https://phabricator.wikimedia.org/T190425#4132697 (10Samwilson) Could this be relat... [04:21:08] (03CR) 10Isarra: "Now works properly as far as I can tell in all things listed on https://codesearch.wmflabs.org/skins/?q=getFooter\(&i=nope&files=&repos=" [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [04:24:58] (03CR) 10Yaron Koren: [C: 04-1] "@Umherirrender - unfortunately, I don't want Cargo to switch to the "[]" notation for arrays yet, because it removes support for PHP 5.3, " [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/426266 (owner: 10Libraryupgrader) [04:42:51] (03PS1) 10Prtksxna: Special:PrefixIndex: Convert to HTMLForm [core] - 10https://gerrit.wikimedia.org/r/426842 (https://phabricator.wikimedia.org/T117726) [04:43:38] (03CR) 10Prtksxna: "Revert with fixes - Ieb9713f8346316e9c3cf1e83eae00848f3921b43" [core] - 10https://gerrit.wikimedia.org/r/425225 (owner: 10Fomafix) [04:43:57] (03CR) 10Prtksxna: "Thanks Fomafix, here is a patch with updates Ieb9713f8346316e9c3cf1e83eae00848f3921b43" [core] - 10https://gerrit.wikimedia.org/r/312265 (https://phabricator.wikimedia.org/T117726) (owner: 10Haritha28) [04:52:52] 10MediaWiki-extensions-GlobalPreferences, 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech-Sprint, and 2 others: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given - https://phabricator.wikimedia.org/T190353#4071026 (10Legoktm) I -2'd the pa... [04:56:09] (03CR) 10Legoktm: Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins (032 comments) [core] - 10https://gerrit.wikimedia.org/r/426840 (owner: 10Isarra) [05:04:38] (03PS5) 10Isarra: Add new BaseTemplate::getFooterBlock function as replacement for getFooter for compatibility across all skins [core] - 10https://gerrit.wikimedia.org/r/426840 [05:05:44] 10MediaWiki-Email, 10MW-1.31-release, 10Patch-For-Review: MailAddress needs to be quoting the name part of the mail headers. - https://phabricator.wikimedia.org/T191931#4121811 (10Legoktm) What software requires it to be quoted? I just created "Lego test account number 1" and sent email to and from that acco... [05:16:26] 10MediaWiki-extensions-GlobalPreferences, 10Collaboration-Team-Triage, 10Notifications, 10Community-Tech-Sprint, and 2 others: Argument 1 passed to CentralIdLookup::namesFromCentralIds() must be an instance of array, string given - https://phabricator.wikimedia.org/T190353#4132709 (10Samwilson) It's not on... [05:20:48] 10MediaWiki-Email, 10MW-1.31-release, 10Patch-For-Review: MailAddress needs to be quoting the name part of the mail headers. - https://phabricator.wikimedia.org/T191931#4132710 (10Alexia) I will fix this patch this week. >>! In T191931#4132707, @Legoktm wrote: > What software requires it to be quoted? I jus... [05:28:37] (03CR) 10Jayprakash12345: [C: 04-1] Special:PrefixIndex: Convert to HTMLForm (032 comments) [core] - 10https://gerrit.wikimedia.org/r/426842 (https://phabricator.wikimedia.org/T117726) (owner: 10Prtksxna) [05:34:58] (03PS1) 10Isarra: Add generic getPortlet to BaseTemplate [core] - 10https://gerrit.wikimedia.org/r/426844 [05:40:08] (03CR) 10Prtksxna: Special:PrefixIndex: Convert to HTMLForm (032 comments) [core] - 10https://gerrit.wikimedia.org/r/426842 (https://phabricator.wikimedia.org/T117726) (owner: 10Prtksxna) [06:08:11] (03Draft2) 10Pwirth: BSFoundation: Removed registration of non existing extension function [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/426845 [06:12:05] (03PS5) 10Robert Vogel: [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 [06:14:37] (03CR) 10jerkins-bot: [V: 04-1] [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 (owner: 10Robert Vogel) [06:39:32] 10MediaWiki-Categories, 10MediaWiki-Interface: Cannot reach further results via "Next page" link on category page on ruwp, always reloads current page - https://phabricator.wikimedia.org/T191776#4132738 (10Joe) [06:39:35] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#4132739 (10Joe) [06:50:54] (03PS1) 10Legoktm: Don't conditionally register any hooks [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/426846 [06:50:56] (03PS1) 10Legoktm: Use standard GPL file header [extensions/CategoryTree] - 10https://gerrit.wikimedia.org/r/426847 [06:52:12] 10ContentTranslation, 10Language-2018-Apr-June, 10MW-1.31-release-notes (WMF-deploy-2018-04-17 (1.31.0-wmf.30)): CX2: Warning when page title already exists - https://phabricator.wikimedia.org/T190038#4132747 (10Petar.petkovic) [06:58:09] 10Accessibility, 10AbuseFilter, 10CodeEditor, 10Regression: Abuse filters cannot be edited without javascript - https://phabricator.wikimedia.org/T192241#4132753 (10Nirmos) [06:59:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Ok, thanks for the pointer to the $title property, which is indeed used. The only issue left is about the $lastDate property that is, in m" (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/426574 (owner: 10Legoktm) [07:01:20] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 (owner: 10Legoktm) [07:05:16] (03Merged) 10jenkins-bot: Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 (owner: 10Legoktm) [07:06:36] (03PS1) 10Legoktm: Update wikimedia/utfnormal to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/426849 (https://phabricator.wikimedia.org/T188480) [07:07:33] (03PS1) 10Legoktm: Update wikimedia/utfnormal to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/426850 (https://phabricator.wikimedia.org/T188480) [07:10:04] (03PS2) 10Legoktm: Update ustring data tables [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/410230 (https://phabricator.wikimedia.org/T177498) (owner: 10Anomie) [07:10:30] (03CR) 10Legoktm: [C: 032] "For some reason Gerrit couldn't handle the rebase." [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/410230 (https://phabricator.wikimedia.org/T177498) (owner: 10Anomie) [07:15:39] (03Merged) 10jenkins-bot: Update ustring data tables [extensions/Scribunto] - 10https://gerrit.wikimedia.org/r/410230 (https://phabricator.wikimedia.org/T177498) (owner: 10Anomie) [07:17:39] (03CR) 10jenkins-bot: Simplify SkinUserPageHelper constructor [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/426824 (owner: 10Legoktm) [07:25:34] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle CategoryTree extension with MW 1.31 - https://phabricator.wikimedia.org/T191735#4132769 (10Legoktm) [07:27:42] 10MediaWiki-Releasing, 10MW-1.31-release: Bundle CategoryTree extension with MW 1.31 - https://phabricator.wikimedia.org/T191735#4132770 (10Legoktm) >>! In T191735#4122296, @Legoktm wrote: > The main thing I'd like to get rid of is CategoryTree::initialize(). The hooks should mostly all be set in extension.jso... [07:34:07] (03CR) 10VolkerE: "LGTM, should be a synced effort with design process finishing and rolled-out with 20x20px canvas across Echo icon set though for better QA" [extensions/Thanks] - 10https://gerrit.wikimedia.org/r/426122 (https://phabricator.wikimedia.org/T183749) (owner: 10Esanders) [07:34:59] (03CR) 10VolkerE: "LGTM, should be a synced effort with design process finishing and rolled-out with 20x20px canvas across Echo icon set though for better QA" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/426123 (https://phabricator.wikimedia.org/T183749) (owner: 10Esanders) [07:35:19] (03CR) 10VolkerE: "LGTM, should be a synced effort with design process finishing and rolled-out with 20x20px canvas across Echo icon set though for better QA" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/426124 (https://phabricator.wikimedia.org/T183749) (owner: 10Esanders) [07:56:27] 10MediaWiki-extension-requests, 10MediaWiki-extensions-GlobalPreferences, 10Community-Tech, 10Community-Wishlist-Survey-2016, and 3 others: [Epic] Support global preferences on Wikimedia wikis - https://phabricator.wikimedia.org/T16950#4132789 (10matej_suchanek) [08:01:23] 10Contributors-Analysis: Re-run active editors skin statistics - https://phabricator.wikimedia.org/T180860#3771677 (10Bawolff) I was curious. I did some one off queries just now for quick stats (This is not exactly what's being asked for here.) i did not due enwiki or commons due to slowness. In case anyone is... [08:02:17] 10Wikimedia-Site-requests: Enable Visual Editor in Draft namespace (102) in etwiki - https://phabricator.wikimedia.org/T192254#4132797 (10Cumbril) [08:03:08] 10Wikimedia-Site-requests: Enable Visual Editor in Draft namespace (102) in etwiki - https://phabricator.wikimedia.org/T192254#4132808 (10Cumbril) [08:29:24] 10Upstream, 10WMSE-Association-Involvement-2018 (Zynatic): Enable 2FA in Zynatic - https://phabricator.wikimedia.org/T189296#4132841 (10Lokal_Profil) 05Open>03Resolved [08:29:49] 10Upstream, 10WMSE-Association-Involvement-2018 (Zynatic): Enable 2FA in Zynatic - https://phabricator.wikimedia.org/T189296#4037970 (10Lokal_Profil) [08:39:56] 10Google-Summer-of-Code (2018): [Analytics] Improvements to Wikistats2 front-end - https://phabricator.wikimedia.org/T190799#4132866 (10Aklapper) 05Invalid>03Open You may want to ask questions for clarification if something is you did not understand what was requested, instead of not replying... I'm tentati... [08:46:39] (03PS1) 10Thiemo Kreuz (WMDE): [WIP] Use more performant wmde/hamcrest-html-matchers library branch [core] - 10https://gerrit.wikimedia.org/r/426863 [08:48:43] 10WMNO-Northern-Sami, 10Wikimedia-Site-requests, 10Wikimedia-maintenance-script-run: Switch category collation for sewiki to uca-se-u-kn - https://phabricator.wikimedia.org/T182431#3823065 (10MoritzMuehlenhoff) @jhsoby-WMNO : FYI; the migration to ICU 57 completed over the weekend, you can go ahead with this... [08:51:27] 10Google-Summer-of-Code (2018): [Analytics] Improvements to Wikistats2 front-end - https://phabricator.wikimedia.org/T190799#4132881 (10Donprecious6) thank you [08:53:14] 10Google-Summer-of-Code (2018): [Analytics] Improvements to Wikistats2 front-end - https://phabricator.wikimedia.org/T190799#4132885 (10Donprecious6) pls what chances do I have I will be awareded, this project because its my first time [09:00:23] 10UI-Standardization, 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#4132892 (10Pginer-WMF) [09:03:02] 10Wikimedia-User-Group-Basque: Bergarapedia - https://phabricator.wikimedia.org/T185509#4132899 (10Theklan) Bergaratik bidalitako akta. {F17005238} [09:04:06] 10UI-Standardization, 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#4132904 (10Pginer-WMF) I adjusted several of the icons based on feedback, and updated the image in the ticket description. [09:06:18] (03PS6) 10Robert Vogel: [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 [09:07:23] (03PS2) 10Thiemo Kreuz (WMDE): [WIP] Use more performant wmde/hamcrest-html-matchers library branch [core] - 10https://gerrit.wikimedia.org/r/426863 [09:08:39] 10Wikimedia-User-Group-Basque: Herri batean eduki nahiko genukeen informazioa zein den definitu - https://phabricator.wikimedia.org/T192257#4132905 (10Theklan) p:05Triage>03Unbreak! [09:10:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 (owner: 10Robert Vogel) [09:10:39] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - https://phabricator.wikimedia.org/T181251#4132931 (10Theklan) [09:10:54] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - Ikasleen praktikak - https://phabricator.wikimedia.org/T183547#4132929 (10Theklan) 05Open>03declined Ez da inor aurkeztu. Bide hau itxitzat jo beharko genuke. [09:10:59] 10UI-Standardization, 10Collaboration-Team-Triage, 10Notifications, 10Patch-For-Review: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#4132932 (10Pginer-WMF) [09:11:57] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - Itzulpengintza irakasleak - https://phabricator.wikimedia.org/T192259#4132936 (10Theklan) p:05Triage>03Normal [09:13:32] (03CR) 10Reedy: [C: 032] Update wikimedia/utfnormal to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/426849 (https://phabricator.wikimedia.org/T188480) (owner: 10Legoktm) [09:13:40] (03CR) 10Reedy: [C: 032] Update wikimedia/utfnormal to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/426850 (https://phabricator.wikimedia.org/T188480) (owner: 10Legoktm) [09:14:11] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Use more performant wmde/hamcrest-html-matchers library branch [core] - 10https://gerrit.wikimedia.org/r/426863 (owner: 10Thiemo Kreuz (WMDE)) [09:17:42] 10MediaWiki-Categories, 10Wikimedia-Site-requests: Change default collation for WMF projects from uppercase to uca-default-u-kn - https://phabricator.wikimedia.org/T192252#4132655 (10Reedy) If you ask #operations they should be able to give an indication of how long this will take to run the script over all th... [09:18:23] 10MediaWiki-extensions-WikibaseClient, 10Wikidata: Create Lua module to expose local short descriptions of pages to Lua - https://phabricator.wikimedia.org/T191531#4132959 (10TheDJ) > API every time the page was reloaded But we have parser output caching, so that means that a page reload doesn't query the ap... [09:20:07] 10Google-Summer-of-Code (2018): [Analytics] Improvements to Wikistats2 front-end - https://phabricator.wikimedia.org/T190799#4132962 (10Aklapper) Please see https://www.mediawiki.org/wiki/Google_Summer_of_Code/2018 and its related pages for general information which is not related to the scope ("Improvements to... [09:20:35] (03Merged) 10jenkins-bot: Update wikimedia/utfnormal to 2.0.0 [vendor] - 10https://gerrit.wikimedia.org/r/426849 (https://phabricator.wikimedia.org/T188480) (owner: 10Legoktm) [09:20:37] (03Merged) 10jenkins-bot: Update wikimedia/utfnormal to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/426850 (https://phabricator.wikimedia.org/T188480) (owner: 10Legoktm) [09:21:31] (03PS7) 10Robert Vogel: [WIP] New task interfaces [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/378863 [09:21:55] (03CR) 10Robert Vogel: [C: 032] BSFoundation: Removed registration of non existing extension function [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/426845 (owner: 10Pwirth) [09:22:31] (03CR) 10jenkins-bot: Update wikimedia/utfnormal to 2.0.0 [core] - 10https://gerrit.wikimedia.org/r/426850 (https://phabricator.wikimedia.org/T188480) (owner: 10Legoktm) [09:23:26] (03CR) 10Robert Vogel: [C: 032] Add AND/OR option on filters [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/426758 (owner: 10ItSpiderman) [09:23:30] 10Wikimedia-User-Group-Basque: Wikipediako laguntza orriak hobetzea - https://phabricator.wikimedia.org/T186095#4132968 (10Theklan) Mesedez, honen inguruko argibideak beharko nituzke. Bestela hasiko naiz nik neu antolatzen. [09:24:07] (03CR) 10Robert Vogel: [C: 032] Update version number to 2.27.3 [extensions/BlueSpiceExtendedFilelist] (REL1_27) - 10https://gerrit.wikimedia.org/r/426035 (owner: 10Mglaser) [09:24:10] (03CR) 10Robert Vogel: [V: 032 C: 032] Update version number to 2.27.3 [extensions/BlueSpiceExtendedFilelist] (REL1_27) - 10https://gerrit.wikimedia.org/r/426035 (owner: 10Mglaser) [09:24:12] (03PS1) 10Hashar: (DO NOT SUBMIT) verbose ffmpeg [core] - 10https://gerrit.wikimedia.org/r/426873 [09:24:51] (03CR) 10jerkins-bot: [V: 04-1] (DO NOT SUBMIT) verbose ffmpeg [core] - 10https://gerrit.wikimedia.org/r/426873 (owner: 10Hashar) [09:25:11] (03Merged) 10jenkins-bot: Add AND/OR option on filters [extensions/BlueSpiceExtendedSearch] - 10https://gerrit.wikimedia.org/r/426758 (owner: 10ItSpiderman) [09:25:26] (03PS1) 10Robert Vogel: Update version number to 2.27.3 [extensions/BlueSpiceExtendedFilelist] (REL1_27_dev) - 10https://gerrit.wikimedia.org/r/426874 [09:25:28] (03CR) 10Robert Vogel: [C: 032] Update version number to 2.27.3 [extensions/BlueSpiceExtendedFilelist] (REL1_27_dev) - 10https://gerrit.wikimedia.org/r/426874 (owner: 10Robert Vogel) [09:25:30] (03PS1) 10PortalsBuilder: Assets build - 2018-04-16 09:25:26+00:00 [wikimedia/portals/deploy] - 10https://gerrit.wikimedia.org/r/426875 [09:25:32] (03CR) 10Robert Vogel: [V: 032 C: 032] Update version number to 2.27.3 [extensions/BlueSpiceExtendedFilelist] (REL1_27_dev) - 10https://gerrit.wikimedia.org/r/426874 (owner: 10Robert Vogel) [09:25:40] (03CR) 10Hashar: "recheck" [core] - 10https://gerrit.wikimedia.org/r/422933 (https://phabricator.wikimedia.org/T179188) (owner: 10Zfilipin) [09:26:04] (03CR) 10jerkins-bot: [V: 04-1] Selenium: record video of every test [core] - 10https://gerrit.wikimedia.org/r/422933 (https://phabricator.wikimedia.org/T179188) (owner: 10Zfilipin) [09:26:12] (03CR) 10Hashar: "That needs a rebase" [core] - 10https://gerrit.wikimedia.org/r/422933 (https://phabricator.wikimedia.org/T179188) (owner: 10Zfilipin) [09:26:15] (03CR) 10jerkins-bot: [V: 04-1] BSFoundation: Removed registration of non existing extension function [extensions/BlueSpiceFoundation] - 10https://gerrit.wikimedia.org/r/426845 (owner: 10Pwirth) [09:27:12] (03CR) 10VolkerE: Convert Special:ListSignupDisplay to use OOUI (031 comment) [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/426739 (https://phabricator.wikimedia.org/T192221) (owner: 10Jayprakash12345) [09:27:59] (03PS3) 10VolkerE: Convert Special:ListSignupDisplay to use OOUI [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/426739 (https://phabricator.wikimedia.org/T192221) (owner: 10Jayprakash12345) [09:28:18] (03CR) 10VolkerE: [C: 032] Convert Special:ListSignupDisplay to use OOUI [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/426739 (https://phabricator.wikimedia.org/T192221) (owner: 10Jayprakash12345) [09:29:36] (03PS3) 10Thiemo Kreuz (WMDE): [WIP] Use more performant wmde/hamcrest-html-matchers library branch [core] - 10https://gerrit.wikimedia.org/r/426863 [09:31:43] (03CR) 10VolkerE: "> VolkerE: Do you mean to add before and after pictures of the MMV ui for all the buttons that were converted to the Phabricator issue thr" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/408577 (https://phabricator.wikimedia.org/T161612) (owner: 10HunterH) [09:32:30] (03Merged) 10jenkins-bot: Convert Special:ListSignupDisplay to use OOUI [extensions/ListSignup] - 10https://gerrit.wikimedia.org/r/426739 (https://phabricator.wikimedia.org/T192221) (owner: 10Jayprakash12345) [09:32:40] (03CR) 10VolkerE: [C: 031] Change and
tags to