[00:01:06] (03CR) 10Legoktm: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceAuthors] - 10https://gerrit.wikimedia.org/r/400716 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [00:01:40] (03CR) 10Legoktm: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/400715 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [00:01:51] Ebe123, where are you :c [00:02:09] Albert221: do you need help with something? [00:04:05] I need a substantive help with UX, I'm creating a popup for Score extension (T183736) and I want to know whether link to download midi file should be a text link or a button and if a button then how it should look [00:04:05] T183736: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736 [00:04:11] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/CollaborationKit] - 10https://gerrit.wikimedia.org/r/400766 (owner: 10Libraryupgrader) [00:13:41] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:14:32] Albert221: I doubt that there's a definitive answer to that. The best thing would be to look for similar examples and examine how it's done there. On Wikipedia, download links tend to be text links. [00:18:26] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:25:35] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400794 (owner: 10Libraryupgrader) [00:25:38] (03PS1) 10Legoktm: Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 [00:26:47] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/FlaggedRevs] - 10https://gerrit.wikimedia.org/r/400806 (owner: 10Libraryupgrader) [00:29:50] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/EventLogging] - 10https://gerrit.wikimedia.org/r/400800 (owner: 10Libraryupgrader) [00:33:13] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/400813 (owner: 10Libraryupgrader) [00:41:58] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400814 (owner: 10Libraryupgrader) [00:52:57] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3863858 (10Legoktm) [00:53:30] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400814 (owner: 10Libraryupgrader) [00:58:08] (03PS1) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [00:58:31] if anyone could do a review of it (not code, the popup itself and the task) it would be more than awesome! [00:59:00] https://gerrit.wikimedia.org/r/#/c/400834/ [01:07:08] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/400829 (owner: 10Libraryupgrader) [01:14:35] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/400841 (owner: 10Libraryupgrader) [01:27:01] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LiquidThreads] - 10https://gerrit.wikimedia.org/r/400849 (owner: 10Libraryupgrader) [01:27:43] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Math] - 10https://gerrit.wikimedia.org/r/400855 (owner: 10Libraryupgrader) [01:28:08] (03CR) 10Legoktm: [C: 032] "Dropped the -p from phpcbf since it confused libraryupgrader and that flag doesn't do anything." [extensions/Math] - 10https://gerrit.wikimedia.org/r/400855 (owner: 10Libraryupgrader) [01:29:17] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400864 (owner: 10Libraryupgrader) [01:36:40] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400860 (owner: 10Libraryupgrader) [01:38:16] 01:30:28 - This package requires php >=5.6 but your PHP version (5.5.38) does not satisfy that requirement. [01:38:17] lol [01:45:14] Reedy: Classic. https://phabricator.wikimedia.org/T102094 [01:45:32] :) [01:45:47] (03CR) 10Legoktm: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400860 (owner: 10Libraryupgrader) [01:45:57] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863890 (10Platonides) I expect other developers would be interested on this as well, but I can help mentoring this ([added](https://www.... [01:48:42] (03PS1) 10Legoktm: Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 [01:48:54] 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Commons, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3863891 (10RazeSoldier) >>! In T181651#3863610, @Ebe123 wrote: > 你是GCI的学生吗？If so,... [01:49:32] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400864 (owner: 10Libraryupgrader) [01:53:06] Reedy: https://gerrit.wikimedia.org/r/400879 [01:53:34] (03CR) 10Reedy: [C: 032] Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 (owner: 10Legoktm) [01:55:06] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400872 (owner: 10Libraryupgrader) [01:56:28] (03Merged) 10jenkins-bot: Drop PHP 5.6 requirement [extensions/MetaMaster] - 10https://gerrit.wikimedia.org/r/400879 (owner: 10Legoktm) [02:01:57] (03PS1) 10Reedy: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 [02:04:46] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3863892 (10Reedy) [02:07:00] Albert221, looking at the patch [02:07:08] oh, I've join at the right moment! :D [02:07:13] joined* [02:09:04] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3863905 (10Reedy) [02:09:11] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3821936 (10Reedy) [02:09:36] 10MediaWiki-API, 10MediaWiki-File-management, 10Commons, 10Multimedia, and 2 others: Parameter must be an array or an object that implements Countable - https://phabricator.wikimedia.org/T182377#3821936 (10Reedy) [02:18:54] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/400896 (owner: 10Libraryupgrader) [02:23:21] Ebe123, what do you think? :) [02:23:51] Stylistically, it's way too light, and I find it unreadable :) [02:24:33] But it works. I'll give some comments later; I found a problem of mine making a failure [02:25:19] It would be nice if you could click on another score, and it switches pop-ups automatically, instead of clicking outside and then [02:28:42] (03PS1) 10Ebe123: Revert ExtensionRegistry TMH check [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 [02:31:19] Ebe123: Yeah, I'd guess your reasoning is right [02:31:53] (03CR) 10Reedy: [C: 032] "I think you're right. Should be re-reverted when T87981 is fixed" [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 (owner: 10Ebe123) [02:33:19] 10MobileFrontend, 10Mobile, 10Readers-Web-Backlog (Tracking), 10Reading-Web-Local-Wiki-Issues: Show Navbox templates in mobile skins - https://phabricator.wikimedia.org/T124168#1947834 (10Salgo60) The latest Iphone Wikipedia version 5.7.3 use the concept of **3D Touch** and **Peek quick actions** that fee... [02:34:37] (03PS1) 10Reedy: Only run count() on array() [core] - 10https://gerrit.wikimedia.org/r/400916 (https://phabricator.wikimedia.org/T182377) [02:34:42] Ebe123, sure thing, I'll fix that in today's morning! [02:34:56] if you could write all your issues and suggestions on GCI or Phabricator [02:34:57] Albert221, could you rebase first [02:35:12] because I'll leave IRC soon and won't be able to see what you've written [02:35:17] I'll write them on Gerrit [02:38:47] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/QuickSurveys] - 10https://gerrit.wikimedia.org/r/400900 (owner: 10Libraryupgrader) [02:38:54] (03PS2) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [02:39:12] (03Merged) 10jenkins-bot: Revert ExtensionRegistry TMH check [extensions/Score] - 10https://gerrit.wikimedia.org/r/400915 (owner: 10Ebe123) [02:39:12] I didn't notice any change when rebasing, could you confirm I've done it? [02:39:21] Now [02:39:38] Perfect timing :) [02:39:53] :D [02:42:12] btw, in terms of appearance, I wanted to add box-shadow to that popup, but adding box-shadow to this triangle made the shadow also on the top of the popup box. I'd have gotten with `filter: drop-shadow` but its browser compatibility is too bad :( [02:43:10] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [02:43:28] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/400919 (owner: 10Libraryupgrader) [02:43:45] (03CR) 10Ebe123: "Added some comments on PS1." (036 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [02:43:57] (03CR) 10Ebe123: [C: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [02:44:27] oh, sorry, I didn't mean to commit this Shell::execute, I forgot about that [02:44:58] (03CR) 10Legoktm: [C: 032] "RELEASE-NOTES still says "There is experimental support for HHVM 3.6.5 or later." - we should update that." [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [02:45:05] Little things are what code review points out :) [02:46:14] okay, tomorrow morning I'll sit to that [02:46:31] I'll try my best to do that, I promise! O:) [02:46:57] I'll also fix the animation so it'll be similar or even exactly the same as the popups of references appear [02:48:50] BTW, could you extend the time remaining on the GCI? I'm not sure if I'll complete it in this time, you now, New Years Eve :) [02:50:22] Ok, will do [02:51:46] It's a bigger task, I admit [02:52:30] (03CR) 10jerkins-bot: [V: 04-1] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [02:56:07] 10MediaWiki-General-or-Unknown, 10RfC, 10TechCom-RfC (TechCom-Approved): Require either PHP 7.0+ or HHVM in MW 1.31 - https://phabricator.wikimedia.org/T172165#3863929 (10Reedy) >>! In T172165#3852411, @daniel wrote: > This has been approved after last call as per the TechCom meeting of December 13. What ex... [02:56:46] (03Abandoned) 10Ebe123: Add DOM Structure to Scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (https://phabricator.wikimedia.org/T114757) (owner: 10Ebe123) [02:58:08] (03Merged) 10jenkins-bot: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [02:58:19] (03PS1) 10Reedy: Bump min supported HHVM version to 3.18.5 [core] - 10https://gerrit.wikimedia.org/r/400936 [02:58:21] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863029 (10Legoktm) I can help mentor this too. [02:59:05] (03CR) 10Reedy: "HHVM 3.6.5 is checked in PHPVersionCheck.php...." [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [03:02:16] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400929 (owner: 10Libraryupgrader) [03:05:22] (03PS1) 10Reedy: Test HHVM LTS versions 3.21 and 3.23 on travis [core] - 10https://gerrit.wikimedia.org/r/400942 [03:07:19] 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Fix textarea editor's edit font size - https://phabricator.wikimedia.org/T182320#3863935 (10Whatamidoing-WMF) As this doesn't seem to be an emergency, and as some documentation might be helpful, could s... [03:09:39] (03CR) 10Reedy: Bump min supported HHVM version to 3.18.5 (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400936 (owner: 10Reedy) [03:16:11] (03PS17) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:16:13] (03CR) 10jenkins-bot: Stop testing hhvm 3.12 on travis [core] - 10https://gerrit.wikimedia.org/r/400884 (owner: 10Reedy) [03:17:36] (03PS18) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:18:15] (03CR) 10GeoffreyT2000: [C: 04-1] "Something needs to be fixed in one of the files because there is currently a merge conflict. Also, if this turns out to not make its way i" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:18:24] (03CR) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor (031 comment) [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [03:22:05] (03PS27) 10Reedy: Add `actor` table and code to start using it [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:23:10] (03CR) 10Reedy: "PS27 is a trivial rebase to take account for I2d8bfdee0a30a54f4315c8056b7ac84f47254db2 being merged" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [03:23:46] (03CR) 10jerkins-bot: [V: 04-1] Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) (owner: 10Happy5214) [03:28:10] (03PS1) 10Reedy: De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 [03:29:53] (03PS19) 10Happy5214: Pre-fill fields in image dialog when image code is selected in editor [extensions/WikiEditor] - 10https://gerrit.wikimedia.org/r/176927 (https://phabricator.wikimedia.org/T40829) [03:37:12] (03CR) 10jerkins-bot: [V: 04-1] De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [03:38:50] wtf are those test failures [03:42:37] (03CR) 10Reedy: "recheck" [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [03:48:19] I take it jenkins is moody again (failing tests for no good reason) [03:51:39] if it doesn't fail it's a flaky test [03:51:45] if it does fail, it's a potentially broken test [03:54:32] (03PS1) 10Reedy: [DNM] Test tests... [core] - 10https://gerrit.wikimedia.org/r/400983 [03:54:43] (03CR) 10jerkins-bot: [V: 04-1] De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [04:05:26] (03Draft2) 10Yaron Koren: Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 [04:05:41] (03PS1) 10SamanthaNguyen: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 [04:06:28] (03Abandoned) 10Reedy: [DNM] Test tests... [core] - 10https://gerrit.wikimedia.org/r/400983 (owner: 10Reedy) [04:08:02] (03PS5) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:09:02] (03CR) 10jerkins-bot: [V: 04-1] Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:09:14] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/Moving folder in tests/phpunit shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3863994 (10Reedy) [04:10:06] (03PS1) 10Reedy: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 [04:10:51] (03PS6) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:11:13] (03CR) 10Yaron Koren: [C: 032] Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 (owner: 10Yaron Koren) [04:11:25] (03PS1) 10Reedy: Decapitalise storage folder in includes and tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400998 [04:11:50] (03CR) 10jerkins-bot: [V: 04-1] Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:12:59] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/Moving folder in tests/phpunit shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864005 (10Reedy) Attempting to narrow down cause in https://gerrit.wikimedia.org/r/400997 and https://gerrit.wikimedia.org/r/400998 [04:14:23] (03PS7) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [04:15:11] (03Merged) 10jenkins-bot: Fix for "group by" and "having" in query API [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/400984 (owner: 10Yaron Koren) [04:15:27] (03CR) 10Reedy: "Needs QQQ" (033 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:15:41] (03PS1) 10BryanDavis: wikidata: Install wikibase using individual extensions [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400999 (https://phabricator.wikimedia.org/T181769) [04:16:45] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/400990 (owner: 10Libraryupgrader) [04:17:18] Wgat does "QQQ" mean? [04:17:22] (03CR) 10Reedy: [C: 04-1] "plus previous comments" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:17:24] Reedy [04:17:29] Ebe123: message documentation [04:18:00] the capitalization screwed me up [04:18:02] (03CR) 10Reedy: [C: 04-1] "For qqq see https://www.mediawiki.org/wiki/Help:System_message#Finding_messages_and_documentation" [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:18:09] heh [04:18:11] jenkins would complain [04:18:13] (03CR) 10BryanDavis: "Cherry picked to https://gerrit.wikimedia.org/r/#/c/400999/ on the stretch-migration branch and updated quite a bit. If that patch is acce" [vagrant] - 10https://gerrit.wikimedia.org/r/394689 (https://phabricator.wikimedia.org/T181769) (owner: 10Addshore) [04:19:18] (03CR) 10jerkins-bot: [V: 04-1] Decapitalise storage folder in includes and tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400998 (owner: 10Reedy) [04:19:39] (03CR) 10Ebe123: [C: 04-1] "Really not what I had in mind" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [04:21:14] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864009 (10Reedy) [04:22:29] (03Abandoned) 10Reedy: De-capitalise includes/storage [core] - 10https://gerrit.wikimedia.org/r/400959 (owner: 10Reedy) [04:22:53] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3863994 (10Reedy) [04:23:35] (03PS1) 10Reedy: Only lowercase storage tests... [core] - 10https://gerrit.wikimedia.org/r/401000 [04:39:50] 10MediaWiki-Vagrant, 10Patch-For-Review: Update role::wikidata to work with new (no)build process - https://phabricator.wikimedia.org/T181769#3864013 (10bd808) >>! In T181769#3855613, @Smalyshev wrote: > With the patch above, after enabling wikidata role in vagrant, I get this: (...snip...) > ``` > AND (page_n... [04:47:10] (03PS2) 10SamanthaNguyen: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 [04:47:56] (03CR) 10SamanthaNguyen: "PS2 removes unnecessary top file comment from SpecialUploadAvatar.css (it's now self-explanatory since it's moved)" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [04:55:12] (03CR) 10BryanDavis: "I haven't tested this yet, but I left 2 trivial comments in-line." (032 comments) [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) (owner: 10Nehajha) [04:56:38] (03Draft2) 10Yaron Koren: Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 [04:58:46] (03CR) 10Yaron Koren: [C: 032] Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 (owner: 10Yaron Koren) [04:58:52] 10MediaWiki-Core-Tests, 10Multi-Content-Revisions: Flaky user tests/De-captialising tests/phpunit/includes/Storage shouldn't cause user test breakages - https://phabricator.wikimedia.org/T183798#3864014 (10Reedy) And to narrow it down further... includes/storage is fine https://gerrit.wikimedia.org/r/401001 te... [05:00:25] (03Merged) 10jenkins-bot: Added delimiter for list of "attached templates" [extensions/Cargo] - 10https://gerrit.wikimedia.org/r/401004 (owner: 10Yaron Koren) [05:01:39] (03PS7) 10BryanDavis: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:01:41] (03CR) 10BryanDavis: [C: 032] Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:02:25] (03PS1) 10Reedy: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 [05:07:37] (03Merged) 10jenkins-bot: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:14:55] (03CR) 10BryanDavis: [C: 031] "Needs a release note." [core] - 10https://gerrit.wikimedia.org/r/338911 (https://phabricator.wikimedia.org/T45086) (owner: 10Gergő Tisza) [05:17:38] (03CR) 10jenkins-bot: Try to opportunistically flush statsd data in maintenance scripts [core] - 10https://gerrit.wikimedia.org/r/394779 (https://phabricator.wikimedia.org/T181385) (owner: 10Aaron Schulz) [05:29:46] (03PS8) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [05:36:09] (03CR) 10Ebe123: [C: 04-1] "Quick little fixes" (034 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [05:41:24] (03CR) 10Ebe123: [C: 04-1] "There's also an inconsistency of message name" (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [05:44:12] 10MediaWiki-Vagrant, 10Patch-For-Review: Update role::wikidata to work with new (no)build process - https://phabricator.wikimedia.org/T181769#3864030 (10Smalyshev) With this patch, stretch-migration seems to be able to install Wikidata and I can add items there without any error messages. [05:53:54] (03PS1) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 [05:59:23] (03PS9) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [06:00:43] 10Android-app-Bugs, 10Android-app-feature-Offline, 10Wikipedia-Android-App-Backlog: Continue reading cards on feed are inconsistently shown on the Explore feed when offline - https://phabricator.wikimedia.org/T157343#3864032 (10RHo) [06:01:01] (03CR) 10星耀晨曦: "> (4 comments)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [06:02:19] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 [06:18:29] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog, 10Patch-For-Review: Improve handling of section editing errors - https://phabricator.wikimedia.org/T154805#3864037 (10RHo) [06:18:59] (03CR) 10Ebe123: [C: 04-1] "You're correct. Just pay attention to the messages :)" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [06:20:17] 10Android-app-Bugs, 10Wikipedia-Android-App-Backlog: App login state may be inconsistent with the site(s) - https://phabricator.wikimedia.org/T154813#3864038 (10RHo) [06:21:29] (03PS10) 10星耀晨曦: Display the file sha1 value in the file info page [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) [06:42:26] 10MediaWiki-API: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864041 (10Jacob.jose) [07:06:54] Hello everyone. I am Pranav Ranjan from India. I am here for a task on Google Code-In (GCI). [07:07:19] My nickname on hexchat is Pranav. [07:07:41] My OS is Windows 10. [07:09:58] My client is HexChat. [07:13:06] (03PS3) 10Nehajha: Added Mediawiki OAuth for applicants [wikimedia/wikimania-scholarships] - 10https://gerrit.wikimedia.org/r/398063 (https://phabricator.wikimedia.org/T119534) [07:24:51] Pranav: Welcome! [07:25:20] (03CR) 10D3r1ck01: "Some issues you should fix;" (034 comments) [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (owner: 10OmkarJ) [07:25:32] (03CR) 10D3r1ck01: [C: 04-1] Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (owner: 10OmkarJ) [07:26:31] thanks [07:26:42] Phantom42 [07:27:48] (03CR) 10D3r1ck01: [C: 04-1] "Issues to address!" (034 comments) [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (owner: 10OmkarJ) [07:32:18] 10Wikimedia-IEG-grant-review: Integrate with OAuth - https://phabricator.wikimedia.org/T74292#3864056 (10Nehajha) a:03Nehajha [07:34:42] 10Wikimedia-IEG-grant-review: Test Failures - https://phabricator.wikimedia.org/T176072#3864059 (10Nehajha) 05Open>03Invalid These tests were failing because I did not correctly build the grants app. [07:35:48] 10Wikimedia-IEG-grant-review: Group related mass DB transactions into a single one - https://phabricator.wikimedia.org/T91253#3864061 (10Nehajha) a:03Nehajha [07:53:14] anyone [07:53:24] Pranav: Yup! [07:53:28] Welcome :) [07:54:07] d3r1ck: welcome you too [07:54:24] Pranav: Are you here for Google Code-In? [07:54:35] Yup ! [07:54:54] You've done your first task? [07:55:01] My task needed some review [07:55:07] so i am here again [07:55:15] this is my firsty task [07:55:23] *first [08:05:51] hey !!!!! [08:06:42] Pranav: Okay! [08:06:51] Can you send me a link to it? [08:06:59] to what ?? [08:07:15] To your first task! The link on Google Code-In website [08:08:12] Pranav: It's okay! I found the link: https://codein.withgoogle.com/dashboard/task-instances/4855629405487104/ [08:08:36] You need to idle here for 1 hour at least! [08:08:59] Also, use a valid IRC client and a good operating system and make sure to register your nick [08:09:22] Yeah i been here for 1 hour 5 min [08:09:24] Pranav: The task description is quite clear :) [08:09:37] what is that IRC client [08:09:46] I didnt understand that [08:09:51] Okay! Double check to see that the tasks requirement have been complete. [08:10:02] IRC client is the application you used in connecting to IRC [08:10:11] Which application did you use to get here? [08:10:20] thats HexChat right ?? [08:10:30] HexChat [08:11:36] Okay d3r1ck [08:11:47] good bye and good luck [08:11:49] Yes HexChat is your IRC client [08:11:57] thanks [08:12:01] Pranav: So make sure you meet al the requirements of th task [08:12:03] *the [08:12:07] And then submit for review! [08:12:14] yeah i have done it [08:12:19] gonna submit it [08:12:20] I can quickly look at it [08:17:06] hi i am mansi jain. participating in wikimedia google code-in task: getting into irc [08:18:15] sambhav2612: Hello Jain, welcome to Wikimedia development channel :) [08:18:24] Where are you from? [08:20:06] delhi, india [08:21:16] Perfect! Welcome again! [08:21:30] Read your first task description very well and make sure to understand it :) [08:22:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/401012 (owner: 10L10n-bot) [08:22:39] 10MediaWiki-extensions-CentralAuth, 10Easy: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864067 (10Reception123) Was looking at CentralAuth and found this request, so might as well do it (even after 4 years :P) [08:23:55] (03Draft2) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:25:26] (03CR) 10Legoktm: [C: 032] Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:27:58] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864068 (10Reception123) https://gerrit.wikimedia.org/r/#/c/401013/ [08:30:04] (03CR) 10Legoktm: [C: 04-1] "The PSR-4 future is capitalized directory names, because they need to match the namespace name." [core] - 10https://gerrit.wikimedia.org/r/400998 (owner: 10Reedy) [08:31:05] (03CR) 10jerkins-bot: [V: 04-1] Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:31:57] (03PS2) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) [08:32:02] (03CR) 10Legoktm: [C: 032] "..." [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:32:58] (03PS2) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) [08:33:57] (03CR) 10D3r1ck01: "Another minor fix" (031 comment) [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:34:57] (03CR) 10D3r1ck01: "Minor fix!" (031 comment) [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:37:13] (03PS3) 10OmkarJ: add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) [08:37:48] (03PS3) 10OmkarJ: Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) [08:37:50] (03Merged) 10jenkins-bot: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:37:58] 10MediaWiki-Special-pages: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864073 (10Legoktm) Template:! isn't a real template any more, it's a magic word handled by the software: https://www.mediawiki.org/wiki/Help:Magic_words#Other for Template:AMG, https://ml.wik... [08:38:56] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:41:08] (03PS4) 10D3r1ck01: Add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:41:53] (03CR) 10D3r1ck01: [C: 031] "LGTM! Thank you Omkar! :)" [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [08:47:12] (03CR) 10jenkins-bot: Append leading \ to BlobStoreFactoryTest covers [core] - 10https://gerrit.wikimedia.org/r/401005 (owner: 10Reedy) [08:51:51] (03CR) 10Tpt: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400899 (owner: 10Libraryupgrader) [08:52:03] (03CR) 10TerraCodes: [C: 031] "LGTM, but its missing patch one?" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:52:43] (03Draft1) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:52:52] (03CR) 10TerraCodes: [C: 031] "nvm, patch one is showing up now..." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:52:57] (03CR) 10Tpt: [V: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/400841 (owner: 10Libraryupgrader) [08:53:15] (03CR) 10Reception123: "I forgot to click "publish" for patch one, done now." [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:53:42] (03CR) 10D3r1ck01: "A minor fix :)" (031 comment) [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:54:07] (03PS3) 10Reception123: Make Special:GlobalAccount alias for Special:CentralAuth [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) [08:55:01] 10MediaWiki-Special-pages: Special:Unusedtemplates listing templates in use - https://phabricator.wikimedia.org/T183800#3864081 (10Jacob.jose) {F12142536} Here is a screenshot of whatlinkshere for template:AMG. The templates listed here are used in various pages, for instance: {F12142538} [08:55:16] (03CR) 10D3r1ck01: "recheck" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [08:57:24] (03CR) 10D3r1ck01: [C: 031] "LGTM!" [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/401013 (https://phabricator.wikimedia.org/T73275) (owner: 10Reception123) [09:14:24] andre__: FlorianSW: would it be possible to include some MediaWiki (but non WMF related) tasks for GCI? [09:14:38] They're developing tasks for a MediaWiki extension [09:23:03] hi this is mansi jain again [09:23:08] Reception|away: of course [09:23:56] mansijain16: Welcome :) [09:24:02] legoktm: Ok, where could I submit one? for example https://phabricator.miraheze.org/T100 [09:25:30] Reception|away: well I'd think you need tasks in Wikimedia Phabricator, but that doesn't look like a good task at all [09:26:09] hmm, ok [09:26:19] that was just an example [09:26:39] see pm [09:38:09] 04(no projects): Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864084 (10Reception123) [09:40:58] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, and 2 others: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete ho... - https://phabricator.wikimedia.org/T183716#3864093 [09:45:12] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3864095 (10Legoktm) a:03Legoktm [09:58:36] 10MediaWiki-Change-tagging, 10AbuseFilter: After changing a filter to apply a tag B instead of a tag A, there is no way to undo this and make it apply tag A again - https://phabricator.wikimedia.org/T183784#3864112 (10matej_suchanek) [09:58:38] 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3864115 (10matej_suchanek) [10:00:36] Phantom42: Done! [10:01:25] d3r1ck: Great! Thank you! [10:01:28] 10MediaWiki-Codesniffer, 10Continuous-Integration-Config, 10Patch-For-Review: Publish test coverage report for MediaWiki-CodeSniffer - https://phabricator.wikimedia.org/T183793#3864116 (10Legoktm) 05Open>03Resolved https://doc.wikimedia.org/cover/mediawiki-tools-codesniffer/ 90% but we can do better :) [10:01:53] Phantom42: Hey! You are welcome and legoktm deserve some of your thanks :) [10:02:22] legoktm: Thank you for merging my patches! [10:02:57] * d3r1ck smiles at Phantom42 [10:05:14] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864119 (10D3r1ck01) [10:06:44] 10MediaWiki-General-or-Unknown, 10MediaWiki-Parser, 10Contributors-Team, 10VisualEditor, and 4 others: Selflinks should still be tags with CSS styling via a class, not tags - https://phabricator.wikimedia.org/T160480#3100391 (10Od1n) I was about to completely agree with Jdlrobson, but actually... [10:10:46] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia, 10Google-Code-in-2017: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3864123 (10Phantom42) a:03Phantom42 This task seems to be interesting. I will work on this! [10:11:08] (03PS1) 10Legoktm: Add BlueSpiceAbout [extensions] - 10https://gerrit.wikimedia.org/r/401048 [10:11:18] (03CR) 10Legoktm: [V: 032 C: 032] Add BlueSpiceAbout [extensions] - 10https://gerrit.wikimedia.org/r/401048 (owner: 10Legoktm) [10:13:05] * Phantom42 hopes to work on more tasks mentored by d3r1ck in the future :) [10:14:36] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864134 (10D3r1ck01) [10:14:46] Phantom42: :D [10:14:47] (03PS1) 10Legoktm: Add "composer test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 [10:16:11] (03CR) 10jerkins-bot: [V: 04-1] Add "composer test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:16:21] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864136 (10Legoktm) [10:17:36] (03PS2) 10Legoktm: Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 [10:18:47] (03PS1) 10Tpt: Makes parser tests pass [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) [10:25:18] (03CR) 10Legoktm: [C: 04-1] "I think this is a regression in core. I git bisected this to 3d560be428920fd4eb10ea6e9760dafbba8f9ddc." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:26:15] (03CR) 10Legoktm: "Git bisect points to this commit as the reason for the LabeledSectionTransclusion parser test failures." [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [10:26:23] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins, 10Patch-For-Review: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3864140 (10D3r1ck01) [10:29:06] (03CR) 10D3r1ck01: [C: 031] Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:30:18] (03CR) 10D3r1ck01: [C: 031] Add "composer test" and dummy "npm test" configuration (031 comment) [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:32:31] (03CR) 10D3r1ck01: [C: 031] "Ohh as a follow up, I saw this: https://github.com/npm/npm/issues/4718." [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [10:33:03] (03CR) 10Tpt: "> I think this is a regression in core." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:33:17] legoktm: Sometimes I really get mixed up :), https://github.com/npm/npm/issues/4718. [10:33:39] extension.json, package.json and composer.json are just so different that I get it twisted :) [10:33:44] (03PS1) 10Legoktm: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 [10:34:25] (03CR) 10Legoktm: [C: 04-1] "Check out Change-Id: If4c140aedf16fc16a4ae2361f465798055748255 - with that applied, the parser tests pass for me." [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:34:38] (03CR) 10Bartosz Dziewoński: [C: 032] Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:35:28] (03CR) 10Legoktm: "See Change-Id: If4c140aedf16fc16a4ae2361f465798055748255 for follow-up." [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [10:35:54] (03Abandoned) 10Tpt: Makes parser tests pass [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401050 (https://phabricator.wikimedia.org/T160240) (owner: 10Tpt) [10:36:17] (03CR) 10Tpt: [C: 031] "This fixes LabeledSectionTransclusion in my local installation" [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [10:38:10] mansijain16: A quick question on your GCI task :) [10:38:56] (03PS1) 10Tpt: Applies some coding standards [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 [10:40:46] (03CR) 10jerkins-bot: [V: 04-1] Applies some coding standards [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 (owner: 10Tpt) [10:42:40] (03Merged) 10jenkins-bot: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:50:53] (03CR) 10jenkins-bot: Decapitalise services folder in tests/phpunit [core] - 10https://gerrit.wikimedia.org/r/400997 (owner: 10Reedy) [10:52:09] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/ScopedCallback] - 10https://gerrit.wikimedia.org/r/401055 (owner: 10Libraryupgrader) [10:52:45] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/Equivset] - 10https://gerrit.wikimedia.org/r/401056 (owner: 10Libraryupgrader) [10:52:50] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata Query UI, and 3 others: Implement keyboard accessibility for Query.Wikidata.org - https://phabricator.wikimedia.org/T173213#3864145 (10eflyjason) Added `R` to jump to query result and `Arrow Up`/`Arrow Down` to select item in query result [10:53:06] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/Timestamp] - 10https://gerrit.wikimedia.org/r/401057 (owner: 10Libraryupgrader) [10:53:13] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RunningStat] - 10https://gerrit.wikimedia.org/r/401064 (owner: 10Libraryupgrader) [10:53:28] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [IPSet] - 10https://gerrit.wikimedia.org/r/401063 (owner: 10Libraryupgrader) [10:53:30] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [libs/WaitConditionLoop] - 10https://gerrit.wikimedia.org/r/401058 (owner: 10Libraryupgrader) [10:53:32] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RelPath] - 10https://gerrit.wikimedia.org/r/401062 (owner: 10Libraryupgrader) [10:54:17] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RunningStat] - 10https://gerrit.wikimedia.org/r/401064 (owner: 10Libraryupgrader) [10:54:42] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [10:54:46] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [10:54:55] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/401060 (owner: 10Libraryupgrader) [10:55:02] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [AhoCorasick] - 10https://gerrit.wikimedia.org/r/401059 (owner: 10Libraryupgrader) [10:55:44] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [10:55:48] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [10:56:18] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [10:56:21] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [10:56:31] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [php-session-serializer] - 10https://gerrit.wikimedia.org/r/401072 (owner: 10Libraryupgrader) [10:56:46] (03PS2) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [10:56:49] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [10:58:32] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [cdb] - 10https://gerrit.wikimedia.org/r/401068 (owner: 10Libraryupgrader) [10:58:40] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [base-convert] - 10https://gerrit.wikimedia.org/r/401067 (owner: 10Libraryupgrader) [10:58:51] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [at-ease] - 10https://gerrit.wikimedia.org/r/401066 (owner: 10Libraryupgrader) [10:58:59] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [WrappedString] - 10https://gerrit.wikimedia.org/r/401065 (owner: 10Libraryupgrader) [11:00:17] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [IPSet] - 10https://gerrit.wikimedia.org/r/401063 (owner: 10Libraryupgrader) [11:00:46] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [RelPath] - 10https://gerrit.wikimedia.org/r/401062 (owner: 10Libraryupgrader) [11:02:32] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [HtmlFormatter] - 10https://gerrit.wikimedia.org/r/401061 (owner: 10Libraryupgrader) [11:02:52] legoktm: https://phabricator.wikimedia.org/diffusion/MTPS/browse/master/composer.json uses mw-cs and I think I added it to the bot list of projects to autoupdate [11:03:04] no change for that repo though [11:03:47] (03PS1) 10Legoktm: Use @composer for calling composer commands in scripts [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401077 [11:05:10] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [CLDRPluralRuleParser] - 10https://gerrit.wikimedia.org/r/401060 (owner: 10Libraryupgrader) [11:07:37] - The requested PHP extension ext-ast <=0.1.4 is missing from your system. Install or enable PHP's ast extension. [11:07:44] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [AhoCorasick] - 10https://gerrit.wikimedia.org/r/401059 (owner: 10Libraryupgrader) [11:07:50] composer install failed [11:08:05] * legoktm fixes [11:08:30] ktnx [11:08:42] 10MediaWiki-extensions-Contributors, 10MediaWiki-extensions-Page_Forms: Special:Contributors throws "MediaWiki internal error" when used in a Page Form template - https://phabricator.wikimedia.org/T181903#3864147 (10Stefahn) That didn't help but I found the culprit at another place. If I edit [[ https://phabri... [11:11:24] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [base-convert] - 10https://gerrit.wikimedia.org/r/401067 (owner: 10Libraryupgrader) [11:11:44] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [utfnormal] - 10https://gerrit.wikimedia.org/r/401075 (owner: 10Libraryupgrader) [11:12:05] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [testing-access-wrapper] - 10https://gerrit.wikimedia.org/r/401073 (owner: 10Libraryupgrader) [11:12:27] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [php-session-serializer] - 10https://gerrit.wikimedia.org/r/401072 (owner: 10Libraryupgrader) [11:14:38] oh this is interesting [11:14:42] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [11:14:44] it's broken because we renamed a sniff [11:14:51] Hauskatze: I'll try and figure it out tomorrow [11:15:03] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [at-ease] - 10https://gerrit.wikimedia.org/r/401066 (owner: 10Libraryupgrader) [11:15:41] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [cdb] - 10https://gerrit.wikimedia.org/r/401068 (owner: 10Libraryupgrader) [11:15:44] 10MediaWiki-Special-pages: Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864148 (10Peachey88) [11:16:06] (03PS1) 10Legoktm: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 [11:16:58] (03CR) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [WrappedString] - 10https://gerrit.wikimedia.org/r/401065 (owner: 10Libraryupgrader) [11:19:27] (03CR) 10Legoktm: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 (owner: 10Legoktm) [11:19:34] Hauskatze: ^^ [11:20:23] legoktm: gracias :) [11:20:47] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/401080 (owner: 10Legoktm) [11:53:57] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864174 (10Rameho) [11:54:28] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864183 (10Rameho) [11:59:54] (03PS12) 10MarcoAurelio: Actually mark abusefilter creations as such in the AbuseFilter log [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/384496 (https://phabricator.wikimedia.org/T178283) [12:01:26] (03PS1) 10Tpt: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 [12:02:39] (03CR) 10Tpt: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [12:22:29] legoktm: Are https://gerrit.wikimedia.org/r/#/c/401008/ and https://gerrit.wikimedia.org/r/#/c/401009/ on your plate please? [12:23:53] 10MediaWiki-General-or-Unknown, 10Wikidata: Links from Wikidata generate errors on huWiki - https://phabricator.wikimedia.org/T183804#3864197 (10Bencemac) [13:04:49] (03CR) 10Jack Phoenix: [C: 032] "This is clearly an improvement over the status quo so I'm more than happy to +2 this, but we should see if we could in the future make Use" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [13:06:31] (03Merged) 10jenkins-bot: Separate styles for Special:UploadAvatar into a separate ResourceLoader module [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400996 (owner: 10SamanthaNguyen) [13:06:56] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864210 (10Rameho) [13:17:21] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864216 (10Rameho) [13:21:31] 04(no projects): Notification Server NOT WORKING - https://phabricator.wikimedia.org/T183803#3864217 (10Aklapper) 05Open>03Invalid Welcome to Wikimedia's Phabricator instance. Wikimedia does not develop Phabricator. To report bugs about Phabricator, you need to report them to the Phabricator developers: ht... [13:23:52] 10MediaWiki-General-or-Unknown, 10Cite, 10Wikidata: Links from Wikidata generate errors on huWiki - https://phabricator.wikimedia.org/T183804#3864220 (10Tacsipacsi) Seems more like a bug in the Cite extension for me. [13:27:53] hello everyone! :) [13:27:56] 10MediaWiki-General-or-Unknown, 10Cite, 10Wikidata: Citations from Wikidata generate errors on huWiki: "Invalid tag; name defined multiple times with different content" - https://phabricator.wikimedia.org/T183804#3864232 (10Aklapper) [13:28:11] Albert221, Hello :D [13:28:30] Albert221: Hi! [13:29:03] Hi [13:29:29] I'm configuring gerrit but got this error publickey denied [13:29:39] see https://www.mediawiki.org/wiki/Gerrit/Tutorial [13:30:10] Solution given here https://www.mediawiki.org/wiki/Gerrit/Troubleshooting#SSH_and_%22Permission_denied_(publickey)%22_error can't help me [13:32:29] bam_, why not? [13:32:54] I've tried the solution but in vain [13:32:59] I still get the error [13:33:04] bam_, which exact, complete command do you enter? [13:33:10] bam_, which exact, complete output do you get? [13:33:27] Permission denied (publickey). [13:34:17] bam_, which exact, complete command do you enter? [13:34:18] bam_, which exact, complete output do you get? [13:34:48] This one Permission denied (publickey). [13:35:10] You ignore my question. [13:36:59] That is the output I get after I type ssh -p 29418 BamLifa@gerrit.wikimedia.org [13:54:23] (03CR) 10Albert221: Add popup with score stuff (033 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [13:55:16] hello Ebe123! [13:55:39] Hi! [13:55:55] Hope 2 extra days is enough, can add more if need be [13:56:47] Also, the MIDI link doesn't work if it's over another score [13:56:59] it should be enough :) I'll check it [14:00:06] This is my test page: https://pastebin.com/fPXN2gmy [14:01:43] bam_: have you added your public key into https://gerrit.wikimedia.org/r/#/settings/ssh-keys ? [14:02:22] Yes, I did [14:02:27] twice even [14:02:42] Is the pop-up supposed to be translucent? It is when over another score [14:03:23] hm, no, it isn't, I've set up your test page and will test everything [14:03:46] BTW, I have a minor issue that the image of the Score is much bigger than it should, can I do something about it? [14:04:05] How is that possible? [14:04:17] big like this: https://i.imgur.com/BW4hSca.png [14:04:54] Is ImageMagick installed? [14:05:30] The extension uses it to crop the scores (I'm getting rid of it soon) [14:06:26] (03CR) 10Seb35: "Thanks for merging!" [extensions/HitCounters] - 10https://gerrit.wikimedia.org/r/393010 (https://phabricator.wikimedia.org/T142127) (owner: 10Seb35) [14:06:44] hm, no, it isn't, let me install it then :) [14:07:48] * d3r1ck checks in [14:08:04] bam_: You need to add your SSH public key to your Wikitech account! [14:08:09] And also to your Gerrit account [14:08:11] Albert221: Hey! [14:11:17] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3864251 (10Seb35) 05Open>03Resolved a:03Seb35 [14:12:23] I am doing it [14:12:45] Okay! [14:14:42] Sorry, still the same issue [14:15:38] In wikitech I use OpenStack tab to add it, don't you? [14:15:52] bam_: When copying your key.pub file, make sure to end at the last character [14:16:06] Very sure [14:16:15] Don't include those spaces at the end. It usually ends with your email, make sure to end at the last character. [14:16:29] Okay! [14:16:32] So run these commands [14:16:38] 1. eval `ssh-agent` [14:16:38] Is it may be because I'm using different emails [14:16:56] did it already [14:17:00] 2. ssh-add ~/.ssh/.pub [14:17:08] already [14:17:15] I've the tuto [14:17:22] Okay! [14:17:34] So you used a different email on Gerrit / Wikitech? [14:17:46] No [14:18:01] I think the email you use to generate the key shouldn't matter [14:18:11] You are missing something, that's why it's not working [14:18:12] Ok [14:18:32] I tried every solution found on INternet but in vain [14:18:37] Can you run the ssh command, add -vvv after ssh? [14:18:52] bam_: You are the solution, there is something you are missing [14:19:39] I run it [14:19:42] Before -P port, add -vvv [14:19:53] Then paste the output lets see [14:20:51] don't paste the output on the channel though, paste it on https://dpaste.de/ [14:21:21] Vulpix: Sure! [14:22:15] https://dpaste.de/SeDm [14:22:15] bam_: Take note, use https://dpaste.de/ [14:22:24] Done [14:23:23] bam_ : Could you also check that the username shown in https://gerrit.wikimedia.org/r/#/settings/ matches with your username in the ssh command? [14:25:09] Sorryyyy [14:25:15] hi d3r1ck! [14:25:17] That's the problem [14:25:34] bam_: I had the same issue before, the case was my gerrit fullname is "Rafidaslam" so I entered "Rafidaslam" in the ssh command, then I got "Permission denied (public key)", then I checked my username on the settings page, it turned out that my username actually is "rafid" [14:25:40] Okay! Try to authenticate with the correct one let's see [14:25:45] the username is not BamLifa but bam92 [14:26:01] Hmmm.... so an issue with the docs, updating right away [14:26:06] It's ok now [14:26:19] Thx all [14:26:21] refeed[m]: Thanks for saving the day! [14:26:29] Hi [14:26:31] bam_: refeed[m] needs a christmas chicken :) [14:26:34] Zppix: Hey! [14:26:42] Zppix: Hello! [14:26:51] Sure sure [14:27:32] A big marry xmas and happy new year to refeed[m] first and to u all [14:27:54] Hope that someone will update the doc [14:28:31] bam_: thank you :), I hope so [14:29:24] d3r1ck: np :) [14:30:11] Phantom42: Hello :) [14:30:28] bam_: I just did now, you can check around here: https://www.mediawiki.org/wiki/Gerrit/Tutorial#Add_SSH_key_to_use_with_Git [14:30:35] d3r1ck: Hi! Glad to see you again :) [14:30:40] The section that says you should test connection :) [14:30:56] Phantom42: Glad to see you too :), you got patches for me to review? [14:31:11] d3r1ck: Nothing yet :) [14:31:16] Okay! [14:33:20] hello Zppix! [14:34:08] Ebe123, installing ImageMagick didn't help :/ only thing that changes was that I didn't see scores but "Image could not be trimmed" or something like that error. I'll just leave that big images as they are to not waste time :) [14:36:52] de3r1ck, In addition to your line, I added the link to the publickey error solution [14:37:28] https://www.mediawiki.org/wiki/Gerrit/Tutorial [14:37:42] https://www.mediawiki.org/wiki/Gerrit/Tutorial#Add_SSH_key_to_use_with_Git [14:38:29] (03PS2) 1001tonythomas: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:40:03] You're having the same problem like with lilypond --version . I'm just wondering why the rendering step works for you [14:40:38] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3864259 (10BamLifa) @ >>! In T176575#3862798, @D3r1ck01 wrote: >>>! In T176575#3858900, @BamLifa wrote: >> @D3r1ck01 I am ready to improve the README.... [14:44:56] bam_: Sure! Thanks :) [14:44:56] (03CR) 1001tonythomas: [C: 032] Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:45:52] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3864263 (10D3r1ck01) Okay! Looking forward to your patch :) Happy New Year to you too :) [14:46:00] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3864265 (1001tonythomas) [14:46:01] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183620#3864264 (1001tonythomas) 05Open>03Resolved [14:46:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3858732 (1001tonythomas) [14:46:17] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183618#3864266 (1001tonythomas) 05Open>03Resolved [14:46:39] (03Merged) 10jenkins-bot: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [14:49:01] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `addNewsletterIssue` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183806#3864272 (1001tonythomas) [14:49:31] (03PS3) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [14:50:01] I pushed next change addresing some of the issues [14:50:13] I didn't change background color and link appearance only [14:51:09] (03CR) 10jerkins-bot: [V: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [14:51:40] Don't have to change background colour, fix the transparency and I'll be good [14:52:22] can you send me a screenshot of this transparency? [14:52:29] I didn't do any transparency anywhere at all [14:52:59] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata Query UI: Add highlight and selection feature for query result table for Query.Wikidata.org - https://phabricator.wikimedia.org/T183807#3864290 (10eflyjason) [14:53:39] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletterSubscribersCount` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183808#3864304 (1001tonythomas) [14:54:57] https://i.imgur.com/maXSa0w.png [14:55:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getPublishersFromID` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183809#3864316 (1001tonythomas) [14:56:03] try clearing the cache [14:56:48] oh, pull new patch first! :) [14:57:49] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183810#3864326 (1001tonythomas) [14:59:33] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getNewsletterFromName` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183811#3864339 (1001tonythomas) [15:00:09] Awesome! [15:00:58] did it resolve your transparency issue? [15:01:05] Yes it did [15:01:18] and the clicking on other scores issue [15:01:40] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `getSubscribersFromID` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183812#3864351 (1001tonythomas) [15:01:40] is it fixed too/ [15:01:41] ? [15:01:50] Yes [15:01:54] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/WPtouch] - 10https://gerrit.wikimedia.org/r/400717 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:02:01] Now, could the pop-up be automatically sized to the content? [15:02:05] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/400718 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:02:17] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/400719 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:02:30] yes, I'll work on that [15:02:34] do you see the animation also? [15:02:53] Yes I did. Smooth! [15:02:55] BTW, do you have any suggestion on how could I calculate the width of the popup? [15:03:07] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `newsletterExistsForMainPage` in newsletters `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183813#3864361 (1001tonythomas) [15:03:10] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/WPtouch] - 10https://gerrit.wikimedia.org/r/400717 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:19] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/DuskToDawn] - 10https://gerrit.wikimedia.org/r/400718 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:31] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Bouquet] - 10https://gerrit.wikimedia.org/r/400719 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [15:03:37] Ebe123 code is a little bit more messy than it would be if I had used top for the animation, but translateY is hardware accelerated and will be a muuuuch better solution for animations [15:04:51] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:04:59] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove code duplication in EditPage and NewsletterContentUpdate - https://phabricator.wikimedia.org/T178743#3864374 (1001tonythomas) 05Open>03Resolved Oh yes. resolving then. [15:05:28] _farmax_: [15:05:48] <_farmax_> Yes [15:05:51] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-10-17 (1.31.0-wmf.4)), 10Patch-For-Review: 'Wiki page to be linked as main page' field in the 'Create Newsletter' form is unclear - https://phabricator.wikimedia.org/T166002#3864377 (1001tonythomas) 05Open>03Resolved [15:05:53] _farmax_: Your patches have been merged. I think you can move on! Thanks to FlorianSW :) [15:05:58] (03CR) 10Florianschmidtwelzow: "This repo seems to doesn't have any CI jobs running automatically. OmkarJ: Do you want to open a phabrucator task for that, so we do not f" [extensions/BlueSpiceAvatars] - 10https://gerrit.wikimedia.org/r/401008 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:06:18] what patches? :D [15:06:22] (03CR) 10Florianschmidtwelzow: [V: 032 C: 032] Add minusx to composer.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/401009 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:06:34] FlorianSW: Ohhh "patch" [15:06:44] what patch then? :D [15:06:51] Now patches, [15:06:58] those you just +2ed :D [15:07:06] <_farmax_> Oh! Thank you so much d3r1ck and FlorianSW [15:07:15] They belong to _farmax_ and has been waiting :) [15:07:30] _farmax_: you're OmkarJ in gerrit? [15:07:52] :D [15:08:58] <_farmax_> Yes [15:09:10] Albert221: width: fit-content; [15:09:45] :O are you sure about that? https://caniuse.com/#feat=intrinsic-width [15:10:02] (03CR) 1001tonythomas: [C: 032] Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [15:11:32] _farmax_: do you want to open a task in phabricator for enabling some basic CI jobs for both repositories? :) [15:11:37] (03Merged) 10jenkins-bot: Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [15:14:50] Darn IE! [15:16:52] <_farmax_> FlorianSW: Yes, I would love that [15:18:11] I'm worried about hard-coding the width due to translations and extending the options of the pop-up [15:20:13] _farmax_: Then go ahead and file a task on Phabricator :) [15:22:11] Ebe123, we could always use fit-content with a polyfill [15:23:11] Sure [15:25:58] 10MediaWiki-Configuration, 10Google-Code-in-2017: [Recurring] Migrate an extension to use extension registration (extension.json) - https://phabricator.wikimedia.org/T183763#3863029 (10Fz-29) @Aklapper : I cannot find this task on https://codein.withgoogle.com/tasks/, should I add it there? I want to mentor t... [15:28:46] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3864383 (1001tonythomas) 05Resolved>03Open My patchset https... [15:29:28] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) [15:29:34] (03CR) 10Tpt: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [15:30:18] (03CR) 10D3r1ck01: "Why does Jenkins said it can't be merged?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) (owner: 1001tonythomas) [15:30:41] (03PS5) 1001tonythomas: Add a unit test to check newsletter creation validation [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/399995 (https://phabricator.wikimedia.org/T183632) [15:31:40] (03CR) 10jerkins-bot: [V: 04-1] Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [15:32:25] (03PS1) 10OmkarJ: Add minusx to composer.json [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) [15:33:29] (03CR) 10D3r1ck01: "recheck" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:34:25] (03CR) 10jerkins-bot: [V: 04-1] Add minusx to composer.json [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:37:06] (03CR) 10D3r1ck01: [C: 04-1] "So you have to change the mode of the file called `TimelineTable.php` in that extension from 100755 to 100644." [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401084 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:39:28] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864395 (1001tonythomas) [15:40:33] (03CR) 10D3r1ck01: "recheck" [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:41:19] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864405 (1001tonythomas) [15:41:27] (03CR) 10jerkins-bot: [V: 04-1] Add minusx to composer.json [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:41:57] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Add unit tests to Newsletter create operations - https://phabricator.wikimedia.org/T183816#3864395 (1001tonythomas) This should possibly go to tests/specials/SpecialNewsletterCreateTest.php as well. [15:44:02] (03PS4) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:44:04] (03CR) 10D3r1ck01: "SkinPerPage.php and SkinPerPage.i18n.magic.php should not be executable. Use the command I mentioned here: I2dc666d5237f689d." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:44:30] I've just added `width: fit-content` on the line below `width: 300px`, so that browsers who'll find `fit-content` invalid will fallback to 300px [15:44:45] (03CR) 10D3r1ck01: [C: 04-1] "Ops sorry, here: Ied331a7fd4a17148a." [extensions/SkinPerPage] - 10https://gerrit.wikimedia.org/r/401085 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [15:45:40] (03CR) 10jerkins-bot: [V: 04-1] Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [15:46:02] _farmax_: Some fixes you need to do :) [15:46:42] (03PS5) 10Albert221: Add popup with score stuff [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:48:15] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to API operations on Newsletter namespace - https://phabricator.wikimedia.org/T183817#3864408 (1001tonythomas) [15:51:31] 10MediaWiki-extensions-Newsletter: [Unit testing] Add unit tests to API operations on Newsletter namespace - https://phabricator.wikimedia.org/T183817#3864420 (1001tonythomas) [15:52:15] 10MediaWiki-extensions-Newsletter: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created - https://phabricator.wikimedia.org/T183818#3864421 (1001tonythomas) [15:55:04] Albert221, now spiffy-up the commit message. It's somewhat lacking. [15:55:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edit should reflect changes - https://phabricator.wikimedia.org/T183819#3864432 (1001tonythomas) [15:56:03] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] On successful API edit to newsletter namespace, a newsletter should be created - https://phabricator.wikimedia.org/T183818#3864442 (1001tonythomas) [15:56:05] (03PS6) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [15:56:15] ^Ebe123 [15:58:11] I'd like a message body (not just title) that talks about removing the MIDI attribute (btw, remove it from the README), the function of the js/css and the like [15:58:20] okay okay [15:58:25] Ebe123: "I've just added `width: fit-content` on the line below `width: 300px`, so that browsers who'll find `fit-content` invalid will fallback to 300px" [15:58:38] I noticed :) [15:59:21] I changed appearance a little, what do you think? https://i.imgur.com/GmDTAsm.png [15:59:28] border 1px #ccc and background #fff [16:01:07] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edits to add publishers should work - https://phabricator.wikimedia.org/T183820#3864445 (1001tonythomas) [16:02:17] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] For an existing newsletter `FooBarExists`, API edits to remove publishers should work - https://phabricator.wikimedia.org/T183821#3864455 (1001tonythomas) [16:02:22] * d3r1ck checks out... brb soon... [16:03:02] I like both! [16:08:34] Maybe the new one is more in line with other MediaWiki notifications (such as postedit-confirmation-saved) [16:08:54] (03PS7) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:09:09] check it out Ebe123! [16:09:15] I think the appearance is final :) [16:09:59] now I'm gonna test it across modenr browsers [16:10:44] Firefox: everything works (popup is 300px because FF doesn't handle fit-content) [16:11:10] Opera: perfect [16:11:37] Edge: exactly as in Firefox [16:12:06] IE11: exactly as in Firefox [16:12:10] Edge is horrible [16:12:16] I don't have more browsers [16:12:28] 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3544310 (10Huji) Even when a tag is actively being used by another filter, why should it not be available to another filter? Why shouldn't multiple filters be able to assign the same tag? [16:12:40] and Chrome: perfect of course, that's my base browser [16:13:27] Firefox I think needs the moz- prefix [16:14:00] you are right [16:14:07] -moz- Safari -webkit- [16:14:59] And for Edge, center the text [16:15:12] Looks nicer than on one side [16:15:48] (03PS8) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:16:42] (03PS9) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [16:16:52] ^final I think [16:17:09] I'm used to Autoprefixer, I must admit [16:17:52] :) [16:18:38] (03PS1) 10OmkarJ: Add minusx to composer.json Change mode of TimelineTable.php to 100644 [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 [16:20:57] (03PS2) 10OmkarJ: Add minusx to composer.json Change mode of TimelineTable.php to 100644 [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) [16:24:49] <_farmax_> d3r1ck: For which files I am supposed to change the mode? [16:25:27] <_farmax_> I have done it for TimelineTable.php [16:25:55] _farmax_: That's for MinusX task? [16:26:02] <_farmax_> Yup [16:26:19] _farmax_: Run MinusX check and it will tell you which files need changing the mode [16:26:23] 10MediaWiki-extensions-Scribunto, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10User-MarcoAurelio: "Module:" on abwiki is in Russian instead of Abkhazian - https://phabricator.wikimedia.org/T182654#3864468 (10Surprizi) Good evening! Happy new year! If there is no late, please instead of... [16:26:31] <_farmax_> for TimelineTable extension [16:26:40] After that you can run MinusX fix and it automatically fix all issues [16:29:47] <_farmax_> Ok.Thank you Phantom42 [16:32:04] Albert221, on Safari, the width is a flat 118px [16:33:00] Ebe123, I don't have Safari and I'm unable to reproduce this, unfortunately [16:33:51] https://caniuse.com/#search=width [16:38:00] which version of Safari has the problem? [16:38:33] specs indicate unprefixed support since 11 (Sept 2017) [16:38:47] https://i.imgur.com/3LohQDy.png [16:39:37] The width won't change, and it's not even 300px [16:43:05] i am on irc for google code in [16:43:42] i am on kvirc for a google code in task [16:43:48] Hello rachitbhatia [16:44:08] hi [16:44:30] rachitbhatia: Ebe123: hi [16:44:40] Don't forget to register your nickname! [16:45:48] 10MediaWiki-Change-tagging, 10AbuseFilter: Cannot add a previously used change tag to an abuse filter - https://phabricator.wikimedia.org/T173917#3864469 (10He7d3r) [16:45:55] I have submitted an update for the MinusX task [16:47:02] Phantom42: hi, i saw you claimed the globalusage task. Just a heads up i might not be on irc all that much in the next couple days. If you have any questions and im not here please dont hesitate to email [16:47:25] bawolff: Could you PM me your email please? [16:48:07] bawolff: But I think I am almost done. Just a bit of testing a will submit a patch... Thank you for very detailed description! [16:48:25] and I will* submit a patch [16:49:40] Ebe123: how to register nickname [16:50:21] Phantom42: Where are you from? [16:50:29] type "/msg nickserv register ", replacing and . Then check your email [16:50:36] farmax: I am from Ukraine. And you? :) [16:50:48] India :) [16:51:06] All the best for GCI :) [16:51:24] Thank you! I wish you good luck too! :) [16:51:28] Also just in general you can email anyone by going to special:emailuser on mediawiki.org [16:51:45] Oh. Okay! [16:51:53] Thank you :) [16:52:03] but only if they have email enabled [16:52:39] RexxS: Sir, are you a mentor for Lua tasks? [16:52:56] if they do, then the link 'Email this user' will appear on thier user page [16:53:05] I am, farmax [16:53:09] purrr [16:53:27] but I'm only mentoring the Lua tasks for now [16:54:39] * refeed[z] triggered by Nikerabbit's purr [16:55:04] Ebe123, what is the version of you Safari? [16:55:24] Version 11.0.2 (13604.4.7.1.3) [16:55:30] I am a beginner for Lua.. Like I started learning from Yesterday when I came to know Wikimedia is offering lua tasks. I would like to know the overall level of tasks [16:56:06] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/401027 (owner: 10L10n-bot) [16:56:17] refeed[m]: oh [16:56:32] Ebe123, what happens if you just remove the fit-content line? [16:58:22] famax: the first few tasks are deliberately simple [16:58:32] so that you can learn [16:58:46] they get a little harder from 1 to 9 [16:59:03] then there are three much harder tasks [16:59:30] Nikerabbit: nope, just kidding, I love cat purrs :3 [17:01:42] (03CR) 10Daniel Kinzler: [MCR] Revision::newFromArchiveRow remove recently added $title param (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400605 (owner: 10Addshore) [17:01:53] CoCC: Code of Cat Contact [17:02:29] farmax: you have to be on IRC for at least an hour; you could look at different tasks and ask the folks here about them [17:02:58] Ebe123 I'll try with max-content, it shouldn't change anything for that small width [17:03:09] One sec [17:03:53] RexxS:Thank you Sir [17:04:39] bawolff: xD [17:04:45] (03CR) 10Daniel Kinzler: [C: 032] Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:05:49] Without fit-content, same thing [17:06:30] I cant find the task one.. It just starts from 2. Can you please link the 1st task? [17:07:51] Ebe123, so Safari... disrespects also `width: 300px`? Very strange for me [17:08:05] yes. Odd [17:08:07] farmax: you mean the Lua tasks? [17:08:16] Yes [17:08:23] (03CR) 10Anomie: Only run count() on array() (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400916 (https://phabricator.wikimedia.org/T182377) (owner: 10Reedy) [17:08:42] Task one for lua tasks [17:08:54] 10Wikimedia-IEG-grant-review: Group related mass DB transactions into a single one - https://phabricator.wikimedia.org/T91253#1077999 (10bd808) > This will take some work in the AbstractDao class to make it possible. @Nehajha has noted in an email that `Wikimedia\Slimapp\Dao\AbstractDao` already uses transactio... [17:09:25] search for "[Lua task #01] Set up your sandbox for programming in Lua on English Wikipedia" [17:09:51] i'm not sure my links will be the same for you [17:10:01] Ebe123 and if you add display: block or inline-block to it? does it work then? [17:10:07] the GCI website is a bit clunky [17:10:25] or if you add `width: intrinsic` to the popup class [17:10:42] (`intrinsic` is a Safari version of `max-content`) [17:10:59] (03Merged) 10jenkins-bot: Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:13:29] Nope.. Its not there.. [17:13:56] Ebe123, I'll try to fix that with a friend who has macOS :) [17:14:15] ok [17:14:21] farmax: try this https://codein.withgoogle.com/dashboard/tasks/5368146359746560/ [17:14:54] * Albert221 is looking for a friend with macOS :v [17:15:00] (03PS1) 10Anomie: Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 [17:16:11] Albert221: Good luck :v [17:18:39] Its redirects me somewhere else :( [17:19:18] (03PS1) 10Anomie: Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 [17:20:07] (03CR) 10jenkins-bot: Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [17:20:19] Albert221: have you got a moment to spare, please? [17:20:36] yes :) [17:20:56] farmax can't find the task "[Lua task #01] Set up your sandbox for programming in Lua on English Wikipedia" [17:21:06] sure, gimme second [17:21:16] could you see if you can find it (I don't have the same interface as you) [17:21:22] https://codein.withgoogle.com/tasks/5368146359746560/ [17:21:25] (03CR) 10Anomie: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 (031 comment) [css-sanitizer] - 10https://gerrit.wikimedia.org/r/401071 (owner: 10Libraryupgrader) [17:21:41] you just remove `dashboard` part of the link as we can see [17:21:42] thank you Albert [17:21:55] farmax: does that work for you now? [17:22:36] by the way, this link with `dashboard` in it worked for me too, it redirected me to `/tasks/` which is [17:22:41] which is the corect link for that [17:22:57] aha - thank you [17:23:21] I ll check [17:23:30] 10Timeless: Thumbs' captions dont display the "Enlarge" button - https://phabricator.wikimedia.org/T183822#3864480 (10Automatik) [17:23:50] but in general, going to https://codein.withgoogle.com/tasks/ allows you do a search, right? [17:24:14] yes, I've searched for "lua" and it was fifth task [17:24:50] 10Timeless: Thumbs' captions dont display the "Enlarge" button - https://phabricator.wikimedia.org/T183822#3864480 (10Automatik) a:03Isarra [17:24:51] yes, I just did the same [17:25:18] i am barry allen aka flash the fastest man alive [17:25:29] but the view info link redirects me to the last instance I approved [17:25:52] which is understandable [17:26:02] but less than optimal [17:26:06] btw, iirc that task is a beginner task, participants are just allowed to take 2 beginner tasks, if the participants already done 2 beginner tasks, they can't find another beginner task anymore in the GCI UI [17:26:22] indeed [17:26:32] which is another problem [17:27:22] I didn't know whether to mark the first task as beginner to attract beginners, or leave it unmarked to allow more folks to take it [17:27:34] Nope.. I cant [17:27:47] Yes.. The beginner task issue [17:32:02] So.. Whats the alternative now [17:32:05] Ok - I've created a copy of the task at https://en.wikipedia.org/wiki/User:RexxS/sandbox/GCI01 [17:32:25] do that. Then claim task Lua #02 [17:32:35] and carry on from there [17:32:38] RexxS:Thank you so much. [17:32:45] you're welcome [17:32:53] sorry for the restictions [17:33:03] restrictions* [17:45:42] (03Abandoned) 10NikiWiki: CategoryViewer: Remove 100% width from table listing [core] - 10https://gerrit.wikimedia.org/r/178068 (owner: 10NikiWiki) [17:54:36] 10MediaWiki-API: Add 'fromsection' and 'tosection' to action=compare - https://phabricator.wikimedia.org/T183823#3864493 (10Anomie) [17:54:47] 10MediaWiki-API, 10MW-1.30-release-notes, 10Patch-For-Review, 10Technical-Debt: Deprecate parsing and diff options in ApiQueryRevisionsBase - https://phabricator.wikimedia.org/T164106#3221891 (10Anomie) >>! In T164106#3863104, @Od1n wrote: > But it seems there is no equivalent for the `rvsection` parameter... [17:55:00] 10MediaWiki-API: Add 'fromsection' and 'tosection' to action=compare - https://phabricator.wikimedia.org/T183823#3864493 (10Anomie) [18:02:07] (03PS1) 10Anomie: ApiComparePages: Add 'fromsection' and 'tosection' parameters [core] - 10https://gerrit.wikimedia.org/r/401090 (https://phabricator.wikimedia.org/T183823) [18:06:12] Hi [18:06:27] Zenit: Hello! [18:06:35] Zenit: Hi [18:06:48] Hi Zenit [18:07:18] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864513 (10MZMcBride) Thanks for working on this. I'd prefer that the Special page be renamed to "Special:GlobalAccount" or maybe even "Special:AccountInfo" over keepin... [18:08:22] Ebe123, okay, I'm on TeamViewer on Macbook right now :D [18:08:29] and I see why there is an issue with that [18:08:38] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864514 (10Reception123) Since this is a WMF-used extension, I assume someone needs to decide this / approve? [18:09:01] that's because if there is more that one time the same property, Safari ignores all [18:09:16] (03CR) 10Anomie: "> Something needs to be fixed in one of the files because there is" [core] - 10https://gerrit.wikimedia.org/r/380669 (https://phabricator.wikimedia.org/T167246) (owner: 10Anomie) [18:09:31] if there would be only width: 300px it would work fine, but if there are the ones with vendor prefixes or just fit-content or max-content then it will not work [18:09:54] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864515 (10MZMcBride) >>! In T73275#3864514, @Reception123 wrote: > Since this is a WMF-used extension, I assume someone needs to decide this / approve? Not really. It... [18:10:12] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864516 (10MZMcBride) [18:10:33] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864517 (10Reception123) Well it should probably be discussed more anyway :D [18:10:35] and the weird thing is that -moz-max-contend doesn't make it don't work o.O it's very, veeeery strange [18:10:38] Ebe123^ [18:10:57] Safari uses webkit, doesn't it? [18:11:02] Yes [18:11:23] so i wouldn't expect it to understand moz- prefixes [18:14:35] but it understands -moz and doesn't understand -webkit? [18:14:48] 10MediaWiki-extensions-CentralAuth, 10Easy, 10Patch-For-Review: Add alias for or rename Special:CentralAuth - https://phabricator.wikimedia.org/T73275#3864521 (10MZMcBride) >>! In T73275#3864517, @Reception123 wrote: > Well it should probably be discussed more anyway :D All right. This task has been sitting... [18:15:51] What? [18:17:15] I'll make short screencast to show you this [18:17:34] Very strange [18:18:56] https://streamable.com/6m5ox don't mind slow reactions, it is throught TeamViewer [18:22:57] let me test something [18:31:36] Can i talk to a mentor incharge for MinusX task [18:33:38] What about? [18:35:16] The latest commit for the task [18:35:40] What about it? [18:36:41] The Review for it. [18:36:51] Why? [18:36:53] What's wrong? [18:37:00] Reedy: are you a mentor, Sir [18:37:07] Yes [18:38:06] Ebe123, can I use this hack for Safari? https://stackoverflow.com/a/25975282/3158312 [18:41:47] no, it doesn't work [18:41:57] I give up Ebe123 [18:44:17] Ok, it works well enough fir Safari [18:45:01] I'll take a final peak and we'll +2 [18:47:50] okay [18:50:08] (03PS2) 10Umherirrender: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:50:12] (03CR) 10Umherirrender: [C: 032] Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:52:41] As you removed link_midi, remove it from the logic line 571 [18:55:14] okay! [18:56:41] (03PS10) 10Albert221: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) [18:56:58] (03Merged) 10jenkins-bot: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [18:58:03] (03CR) 10Umherirrender: [C: 032] Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 (owner: 10Legoktm) [18:58:07] 9px now? :) [18:58:52] (03CR) 10Ebe123: [C: 032] Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [18:59:14] yes, it's exactly how it should be :) [18:59:34] (03CR) 10Ebe123: [C: 032] "Even though it is not perfect on Safari, it works well." [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [19:00:31] More that ps9 was 7.5, and ps10 9 [19:00:51] (03Merged) 10jenkins-bot: Fix @covers tags [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400807 (owner: 10Legoktm) [19:00:53] (03Merged) 10jenkins-bot: Add popup showing midi DL link on score click [extensions/Score] - 10https://gerrit.wikimedia.org/r/400834 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [19:01:24] Ebe123, yes, initially I used 7.5, but when I added border I saw that it wasn't perfectly fitted so I fixed it :) [19:01:54] I let the commit message slide, but check https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines [19:03:52] Quite an eye for detail :) Thank you for the patch! Now, submit the GCI for review! [19:05:08] (03CR) 10jenkins-bot: Parser: extract $title, follow-up 3d560be428 [core] - 10https://gerrit.wikimedia.org/r/401052 (owner: 10Legoktm) [19:05:58] Ebe123 and what about the code part? [19:06:16] that the popup should show code of the score [19:06:47] or maybe I misunderstood something " includes information about the score (such as its code)" [19:07:26] (03PS1) 10Phantom42: Create Special:GloballyUnusedFiles [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [19:07:38] If you want to put a download link to it's code, great! [19:07:57] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/400846 (owner: 10Libraryupgrader) [19:08:02] (03CR) 10Umherirrender: [C: 032] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/LifeWeb] - 10https://gerrit.wikimedia.org/r/400846 (owner: 10Libraryupgrader) [19:08:43] can you explain what I should do afterall? :) [19:09:04] I mean I don't understand this task's part [19:10:01] I took it to mean "includes information about the score with a link to download MIDI" [19:10:28] I'd think you're done [19:11:39] (03CR) 10Umherirrender: [V: 032] "T178517" [extensions/PoolCounter] - 10https://gerrit.wikimedia.org/r/400896 (owner: 10Libraryupgrader) [19:11:52] If you want to add a download link to the code, near line 620, add an operation to store the LY file (like its done with MIDI/PNG) [19:12:58] (should be a quick copy-paste with some tweaking) then add the link to the popup. [19:16:04] (03PS2) 10Phantom42: Create Special:GloballyUnusedFiles page [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [19:20:35] Hi, Im here for Google Code-in task. have a nice day everyone :> [19:20:52] Zenit: Hi! Thank you! Have a good day too! [19:21:58] hello Zenit! [19:22:02] thanks, same to you :) [19:22:41] You too, Zenit! [19:25:10] (03PS2) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400947 (owner: 10Libraryupgrader) [19:26:04] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia, 10Google-Code-in-2017, 10Patch-For-Review: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3864536 (10Phantom42) > Have 2 wikis setup, one of which setup like "Commons"... [19:26:14] (03CR) 10Ebe123: "Message thing. Please read https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines for the commit." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400695 (https://phabricator.wikimedia.org/T181651) (owner: 10星耀晨曦) [19:31:00] Ebe123: https://i.imgur.com/B6cpEas.png it passes this filename to frontend, but the files do not exist :/ they aren't created, in lilypond directiory are only json, midi and png files [19:31:59] Don't bother renaming functions [19:32:11] use $factoryLy , not $code [19:32:26] it's private, used in one place, I have to rename it or I won't sleep calmly :) [19:32:49] json isn't included!!! :p [19:33:07] and it isn't generating lilypond code [19:33:27] you're right [19:33:29] the user has [19:33:33] I'll add JSON to its signature too [19:34:04] not my point... [19:35:21] I know, that was a joke :) but I'd really like to make the signature of this method tell what it's doing [19:36:16] maybe "engraveLilypond" or something [19:36:50] The function renders the sheet music (called engraving), but it also stores the files [19:40:56] Good evening Albert221, refeed[z], Phantom42, Ebe123 and everyone else :) [19:41:08] hey! [19:41:10] Hello divadsn! [19:41:44] Ebe123, I am now working on my task, I had to work the past 2 days on how to get Linux running instead of ChromeOS on my Chromebook :D [19:42:01] No problem [19:42:15] And as far as I understand I should remove ogg/vorbis and make it general for any sort of audio file, right? :) [19:42:29] (but not remove where the midi is converted to ogg) [19:42:35] correct [19:43:00] divadsn: Good evening! [19:43:55] Like in comments, attributes, variables, messages, etc [19:44:25] And the aliases, where should I define them? [19:45:25] next to the new ones [19:46:02] Alright, thanks :) [19:46:23] Their values are passed to $options, and so if one exists but not the other, it should be simple [19:46:24] Ebe123, looks like it doesn't work for me either [19:46:40] neither with create content or store src [19:47:00] em, wrong, neither with store content nor create src [19:48:18] wrong again, eh, it doesn't work with ['op' => 'create', 'content' => $code] nor with ['op' => 'store', 'src' => $factoryLy] [19:51:07] em, it could be MW cache again, I forgot about it... [19:51:30] Albert221, just make a cronjob which clears cache every 5 minutes :P [19:51:34] create a new score [19:52:01] \relative c'' { \time 5/4 \key g \minor \clef treble \tempo "Allegro giusto, nel modo russico; senza allegrezza, ma poco sostenuto." g--\f f-- bes-- c8--( f d4-- ) \bar "||" \time 6/4 c8--( f d4-- ) bes-- c-- g-- f-- } [19:52:02] divadsn, how to clear cache? :O [19:52:17] for store, you need to set a destination [19:52:43] should then be found at /images/lilypond/1/7/174kpko9c5javhfabzuov24h7lo4slg [19:52:55] yes, it works now [19:53:00] Reedy, he does have the dst set [19:53:10] https://i.imgur.com/B6cpEas.png [19:53:11] it was due to the cache [19:53:29] ^the diff above contains code with error anyway [19:53:32] but it works :) [19:53:41] ^*now [19:54:20] ?action=purge did the trick? [19:55:33] Or did you manually delete the png? [19:56:28] Because it will only create the .ly file when engraving, not just for HTML generation [20:02:31] 10ContentTranslation: ContentTranslator tries to load an old published translation when starting a new translation of the same article - https://phabricator.wikimedia.org/T183824#3864539 (10He7d3r) [20:03:23] (03CR) 10Umherirrender: [C: 031] Add @covers tags for more tests [core] - 10https://gerrit.wikimedia.org/r/400780 (owner: 10Legoktm) [20:06:16] (03PS1) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:06:27] Ebe123^ [20:06:46] (03CR) 10Umherirrender: "Please amend your first patch set and not uploading a new one" [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [20:07:29] (03CR) 10Albert221: [C: 04-1] Add minusx to composer.json Change mode of TimelineTable.php to 100644 (031 comment) [extensions/TimelineTable] - 10https://gerrit.wikimedia.org/r/401086 (https://phabricator.wikimedia.org/T175794) (owner: 10OmkarJ) [20:07:52] (03CR) 10jerkins-bot: [V: 04-1] Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [20:09:11] (03PS2) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:09:22] 10ConfirmEdit (CAPTCHA extension), 10Technical-Debt: Define an interface for CAPTCHA modules - https://phabricator.wikimedia.org/T178597#3864552 (10Florian) When I think about that, it isn't really suitable for GCI :/ [20:10:32] (03CR) 10Umherirrender: [C: 032] Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 (owner: 10Anomie) [20:12:00] (03Merged) 10jenkins-bot: Add missing visibility declarations [extensions/ApiFeatureUsage] - 10https://gerrit.wikimedia.org/r/401088 (owner: 10Anomie) [20:12:20] Ebe123, could you take a look? :) [20:12:27] I am right now [20:12:44] make sure you've got the newest version [20:12:48] of the patch [20:12:55] (03CR) 10Umherirrender: [C: 032] Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 (owner: 10Anomie) [20:13:01] c18eff5cd3295dd8f7028dfe3f278e357f492423 [20:13:35] evening [20:13:44] (03CR) 10Umherirrender: "recheck" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (owner: 10Tpt) [20:14:25] (03Merged) 10jenkins-bot: Add missing visibility declarations [extensions/TemplateSandbox] - 10https://gerrit.wikimedia.org/r/401089 (owner: 10Anomie) [20:14:41] dobry wieczór Nikerabbit! :) [20:16:20] Albert221: wow I can understand that :) [20:16:34] what's your native lang? :D [20:16:51] Finnish [20:17:13] what is it in Finnish? [20:17:38] hyvää iltaa [20:18:08] andre__: have you added the "DONOTPUBLISH" prefix to this task: https://codein.withgoogle.com/dashboard/tasks/6066959961554944/ ? *wondering* [20:18:28] but I am ru-1 in Wikimedia slang [20:19:44] I can't see it so I think yes FlorianSW :) [20:20:14] what does it mean Nikerabbit? [20:20:55] (03CR) 10Ebe123: "Almost there!" (034 comments) [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [20:20:58] Albert221: sorry for the confusion :) Yes, the task is of course not published (that's what I see, here on my side, too :P) My question would be why :P (We internally tag some tasks we want to publish at a certain time or tasks which should not be published with a reason. These tasks can not be seen by a student, obviously :) [20:21:15] that's why I hope andre__ can give some info, as the reason is not really clear :P [20:21:44] Albert221: https://en.wikipedia.org/wiki/Wikipedia:Babel [20:21:54] Albert221: Beginner in Russian [20:22:39] 10MediaWiki-extensions-Translate, 10Easy: Fix dropdown position for autocomplete suggestions for Special:SearchTranslations - https://phabricator.wikimedia.org/T178872#3705775 (10Florian) Deleted task in GCI. [20:22:51] Nikerabbit: привет! :) [20:23:07] :O :D I'd classify myself as ru-0.5 :D I have russian in school, I know cyrillic but I don't really know how to build sentences [20:23:11] the more complex ones [20:23:20] I took -0 to be "beginning to learn" [20:23:23] which english class would you classify me to? [20:23:29] 10ContentTranslation: ContentTranslation should not reload the whole page after 10 seconds (FOUC?) - https://phabricator.wikimedia.org/T183825#3864557 (10He7d3r) [20:24:12] Phantom42: привет :) [20:24:31] :D [20:24:59] 我的俄语不好。 [20:25:14] Albert221: there aren't that clear rules... usually people just pick what they feel comfortable using :) [20:25:44] Ebe123 here he is with his bushes again... :D [20:25:59] Reading cyrillic took a little time to get used to [20:26:11] 10ContentTranslation: ContentTranslator tries to load an old published translation when starting a new translation of the same article - https://phabricator.wikimedia.org/T183824#3864567 (10He7d3r) [20:26:32] (03CR) 10Umherirrender: "recheck" [extensions/LabeledSectionTransclusion] - 10https://gerrit.wikimedia.org/r/401053 (owner: 10Tpt) [20:27:29] Albert221: The question would be: What class do you put yourself into :P [20:27:53] Ebe123, here: https://gerrit.wikimedia.org/r/#/c/401093/1/includes/Score.php second comment, what exactly should I do instead? [20:28:18] Would -1 (negative 1) be "I don't speak the language nor have any reason to"? [20:28:57] it would be en--1 that is en+1 [20:30:18] If $existingFiles does not include the .ly file, don't include the link [20:30:50] For me, pl+1 [20:32:01] I am fi+1, but I do have a finnish phrasebook (I found one). I've never left Canada though [20:36:40] Albert221: haha :D [20:38:55] (03PS1) 10NikiWiki: Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 [20:39:26] (03PS3) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:39:29] Ebe123, fix^ [20:40:16] Also put the file check for the midi link please [20:41:13] Because if it's a raw score without a midi block, it won't be generated [20:41:29] ^MIDI won't be generated. [20:46:21] (03PS23) 10Huji: Links to blocked/locked users should have a class indicating so [core] - 10https://gerrit.wikimedia.org/r/370137 (https://phabricator.wikimedia.org/T172348) [20:46:29] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) [20:47:14] (03CR) 10Huji: "@Gergo: I removed the caching, it should be ready to merge now." [core] - 10https://gerrit.wikimedia.org/r/370137 (https://phabricator.wikimedia.org/T172348) (owner: 10Huji) [20:48:02] (03PS82) 10Huji: Log accessing private information in abuse filter logs [extensions/AbuseFilter] - 10https://gerrit.wikimedia.org/r/326465 (https://phabricator.wikimedia.org/T152934) [20:48:53] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) [20:49:33] 10AbuseFilter, 10Security-Team, 10Stewards-and-global-tools, 10Patch-For-Review: Log accessing private information by those with 'abusefilter-private' permission - https://phabricator.wikimedia.org/T152934#3864571 (10Huji) p:05High>03Unbreak! We have an LTA actively harassing the fawiki community, who... [20:52:07] (03CR) 10Florianschmidtwelzow: [C: 04-1] Check the dismissed cookie on client-side before calling geolocation (031 comment) [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/400099 (https://phabricator.wikimedia.org/T183657) (owner: 10Martineznovo) [20:52:16] (03CR) 10Florianschmidtwelzow: [C: 04-1] "Sorry for the late review :(" [extensions/CookieWarning] - 10https://gerrit.wikimedia.org/r/400099 (https://phabricator.wikimedia.org/T183657) (owner: 10Martineznovo) [20:54:11] (03PS4) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [20:54:13] Ebe123, fixed^ [20:55:17] you have a typo [20:55:40] 482 [20:56:03] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:56:11] (03CR) 10Florianschmidtwelzow: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:57:07] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Truglass] - 10https://gerrit.wikimedia.org/r/401096 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:57:19] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/DeskMessMirrored] - 10https://gerrit.wikimedia.org/r/401097 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [20:58:01] and make it either MIDI is generated or MIDI was given [20:58:41] (03CR) 10Legoktm: "I'm pretty skeptical about trying to hide libraries like this. What about the API which exposes library versions? Or even wikis that keep " [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [20:58:53] (03CR) 10Florianschmidtwelzow: [C: 032] Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [20:59:09] FlorianSW: errr [20:59:16] legoktm: err [20:59:22] did you see my comment? [20:59:27] or mid-air collision? [20:59:31] (03CR) 10Florianschmidtwelzow: Specials: Add LibraryInfoHook [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [20:59:45] hum... I haven't seen your comment :( [20:59:59] oops, :P [21:01:10] AHHH!!! Now I see the timestamp, so there were no comment when I +2ed the change :P For a short moment I was skeptical about myself :D [21:01:15] (03PS2) 10Legoktm: Use MediaWikiCoversValidator for tests that don't use MediaWikiTestCase [core] - 10https://gerrit.wikimedia.org/r/400748 [21:02:16] (03CR) 10Florianschmidtwelzow: "Ok, having legoktm's comment in mind, I think you should go with the solution he proposes, instead of semi-hiding this information using a" [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:03:37] (03PS5) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:04:21] what about if $options['override_midi'] is specified, Albert221? [21:05:53] (03CR) 10Legoktm: Improve (weak and strict) type hints invarious places (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400587 (owner: 10Thiemo Kreuz (WMDE)) [21:06:38] (03CR) 10NikiWiki: "I added the hook to keep the class consistent, as it has hooks to overwrite *all* other information." [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:10:27] Ebe123 I should include the link to midi file only if override_midi option exists, right>? [21:10:43] No! [21:10:45] (03CR) 10Brian Wolff: [C: 04-1] "Overall this looks very good. I havent reviewed this fully yet, but a few small things" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) (owner: 10Phantom42) [21:11:35] There are 2 situations to link to the MIDI file: if one was created (most of the time), or specified (override_midi) [21:12:59] ok, I understand now :) [21:13:54] (03PS103) 10Qdinar: Add Tatar LanguageConverter [core] - 10https://gerrit.wikimedia.org/r/164049 (https://phabricator.wikimedia.org/T27537) [21:14:10] so I should firstly check whether there is override_midi parameter and it's true OR whether there is a midi file in $existingFiles, right? [21:15:09] if the override_midi parameter is set, not if true [21:15:18] (03CR) 10Florianschmidtwelzow: "I personally agree, that having comments that does not help at all is worse then having no comment at all. However, I also think that fixi" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [21:15:50] second part is fine [21:17:18] (03CR) 10Florianschmidtwelzow: [C: 031] "+1 from my side. I'm not sure, if the copyright header is somehow needed, though. So keeping this change open for some time so someone cou" [core] - 10https://gerrit.wikimedia.org/r/400584 (owner: 10Thiemo Kreuz (WMDE)) [21:18:41] if ( isset( $options['override_midi'] ) || isset( $existingFiles["{$options['file_name_prefix']}.midi"] ) ), right? [21:19:10] (03CR) 10Florianschmidtwelzow: [C: 032] Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:19:14] Try it. Looks good [21:19:31] (03PS2) 10Tpt: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) [21:20:24] How about just $existingFiles["{$options['file_name_prefix']}.midi"], no isset() on the second part [21:21:04] as it would either be true or unset, so we want to reduce function calls [21:22:15] Same thing for the source file [21:23:18] Or I'm mistaken and it's required [21:23:34] *isset() is needed [21:25:16] (03Merged) 10jenkins-bot: Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:25:51] (03CR) 10Florianschmidtwelzow: [C: 032] Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:28:08] Ebe123, if it would be unset it would produce E_NOTICE [21:28:21] yeah, it's needed [21:29:02] (03PS3) 10Phantom42: Create Special:GloballyUnusedFiles page [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) [21:29:51] (03PS6) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:29:53] (03CR) 10Phantom42: "Thank you for reviewing! I fully agree with your comments and fixed those issues!" [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/401092 (https://phabricator.wikimedia.org/T183673) (owner: 10Phantom42) [21:30:58] (03CR) 10jerkins-bot: [V: 04-1] Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) (owner: 10Albert221) [21:31:43] eh jerkins [21:32:10] (03Merged) 10jenkins-bot: Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:33:56] (03CR) 10Legoktm: [C: 04-2] "As I said on the Cite patch, don't remove the copyright holders." [core] - 10https://gerrit.wikimedia.org/r/400584 (owner: 10Thiemo Kreuz (WMDE)) [21:34:06] (03CR) 10jenkins-bot: Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 (owner: 10Thiemo Kreuz (WMDE)) [21:34:15] (03PS7) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [21:34:34] (03CR) 10jenkins-bot: Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [21:36:09] (03CR) 10Florianschmidtwelzow: [C: 04-1] "This changes the default behaviour for all non-extsing pages to something which would evaluate to "No edit restrictions apply". This is no" [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [21:36:30] (03CR) 10Legoktm: [C: 032] Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 (owner: 10Thiemo Kreuz (WMDE)) [21:37:57] It's great! [21:38:19] 10MediaWiki-Page-protection, 10MediaWiki-extensions-EducationProgram, 10Ladies-That-FOSS-MediaWiki, 10Easy, and 3 others: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#2227133 (10Florian) Couldn't this be changed somewhere in... [21:38:36] :) [21:38:41] (03Merged) 10jenkins-bot: Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 (owner: 10Thiemo Kreuz (WMDE)) [21:38:51] Safari's pop-up is wider, but still 2 lines [21:39:02] Funny [21:43:12] (03CR) 10Florianschmidtwelzow: "Having the other hooks here has the same implications as the one proposed here: YOu can still request version information of each extensio" [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [21:49:20] mehh, nearly one hour code-review and my inbox still tells me (with a stupid smile on the face, you know, like something which directly comes from the hell): "You're a looser, you literally do nothing, do you? You'll never get my unread count to zero. muahahaha" [21:49:52] FlorianSW: Haha :)) [21:56:37] (03PS1) 10Umherirrender: Use relative path in require_once [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 [22:02:23] (03CR) 10Legoktm: "> I added the hook to keep the class consistent, as it has hooks to overwrite *all* other information." [core] - 10https://gerrit.wikimedia.org/r/401094 (owner: 10NikiWiki) [22:02:30] (03CR) 10Umherirrender: [C: 031] "I have no idea if tests in /libs/ folder also should have no MediaWiki* inside or if that is just for the includes/libs/ folder." [core] - 10https://gerrit.wikimedia.org/r/400748 (owner: 10Legoktm) [22:03:56] Ebe123, is there something to do more? [22:04:55] Not that I can see, but I'm eating. Good night! [22:05:51] should I submit the GCI task? [22:05:55] and have a good meal! [22:06:19] One little thing. Why is the bullet linked? [22:06:28] (to the ly file) [22:06:51] it's because it was applies as a before pseudoelement, that way I'm not creating any additional HTML markup [22:07:09] I can just remo it if you want and there would be no linked bullet [22:07:24] I like the bullet! [22:07:51] <3 [22:07:51] just not the link [22:08:11] I can try something with it [22:08:17] you said good night, are you leaving or something? [22:08:29] (03CR) 10Legoktm: "I think it should be fine for tests/, MediaWikiCoversValidator has no dependency upon MediaWiki itself, I just named it that to match Medi" [core] - 10https://gerrit.wikimedia.org/r/400748 (owner: 10Legoktm) [22:08:33] Isn't it 23h for you? [22:08:47] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 [22:09:20] yes it is [22:09:39] but why did you think that I'm going to sleep? :D [22:10:18] I'm also going to sleep soon, not feeling too well :) [22:10:28] oh, I'll hurry then [22:11:34] (03PS3) 10Umherirrender: Add "composer test" and dummy "npm test" configuration [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:11:58] 10Timeless: Timeless: images (eg smileys) are not middle aligned with text - https://phabricator.wikimedia.org/T183827#3864605 (10Automatik) [22:12:19] No no, take your time [22:12:49] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:13:05] Ebe123 I found the solution, but it needs additional element [22:13:39] it works 100%. in browsers that support `pointer-events` it works perfect, on browsers which don't support it, bullet is also clickable [22:14:21] Let's try it [22:15:38] (03PS8) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [22:16:13] (03PS4) 10Umherirrender: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:17] (03PS5) 10Umherirrender: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:20] (03CR) 10Umherirrender: [C: 032] Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:16:26] (03CR) 10Legoktm: [C: 032] "Weird...it looks like libraryupgrader missed this repo entirely, there's not even an error log." [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:18:31] (03Merged) 10jenkins-bot: Add php-parallel-lint, grunt-jsonlint and grunt-banana-checker [extensions/BlueSpiceAbout] - 10https://gerrit.wikimedia.org/r/401049 (owner: 10Legoktm) [22:18:37] (03Merged) 10jenkins-bot: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [skins/Timeless] - 10https://gerrit.wikimedia.org/r/401099 (owner: 10Umherirrender) [22:23:11] 10MediaWiki-Special-pages: Add "Previous blocks" to footer of Special:Block - https://phabricator.wikimedia.org/T183801#3864084 (10Umherirrender) A log extract is shown under this links ("This user has been blocked previously. The block log is provided below for reference: "), I am not sure if a link to the same... [22:23:28] oh, for the second time this winter we have snow! [22:24:26] Albert221: In Ukraine this winter we have not much snow. Same in Poland? [22:24:32] You don't have snow before winter? [22:24:55] same, in my location I had snow for like one and half day this winter [22:24:59] and now it's snowing again! [22:25:08] let's hope it won't melt in a quarter [22:25:22] (03PS1) 10Umherirrender: Use always tabs in composer.json [extensions/BlueSpiceAuthors] - 10https://gerrit.wikimedia.org/r/401100 [22:25:28] quarter hour* [22:25:30] (03PS1) 10Umherirrender: Use always tabs in composer.json [extensions/BlueSpiceArticleInfo] - 10https://gerrit.wikimedia.org/r/401101 [22:25:31] Here, it snows and melts, leaving inches of ice [22:25:43] 10AbuseFilter, 10Security-Team, 10Stewards-and-global-tools, 10Patch-For-Review: Log accessing private information by those with 'abusefilter-private' permission - https://phabricator.wikimedia.org/T152934#3864617 (10Bawolff) >>! In T152934#3864571, @Huji wrote: > We have an LTA actively harassing the fawi... [22:31:03] Ebe123, I've submited the patch fyi [22:33:19] Lets go with ps7 [22:33:33] I don't really like having the other divs [22:34:11] (03CR) 10Albert221: [C: 031] build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/TweetANew] - 10https://gerrit.wikimedia.org/r/400947 (owner: 10Libraryupgrader) [22:34:40] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/AdminLinks] - 10https://gerrit.wikimedia.org/r/401103 [22:35:17] can I rebase from Gerrit? [22:35:23] revert* [22:36:20] don't think so [22:37:16] looks like Wikimedia's Gerrit is too old and don't have it? https://stackoverflow.com/a/45072866/3158312 [22:41:54] (03PS9) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [22:41:59] let's hope I did everything correctly [22:42:52] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/401105 [22:42:55] tbh I liked PS8 more [22:43:23] (03CR) 10Umherirrender: "Missed by Libraryupgrader" [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/401105 (owner: 10Umherirrender) [22:51:42] everything okay? :) [23:01:33] 10MediaWiki-Codesniffer: Undefined index: scope_opener in IfElseStructureSniff - https://phabricator.wikimedia.org/T183828#3864623 (10Umherirrender) [23:01:46] We can go with 8 if it's your favorite, and the extra tags aren't really a problem [23:02:03] Sorry there Albert221 [23:03:29] Do I give a little write-up when approving a task? [23:04:11] (03PS10) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:04:17] ^there is PS8 as PS10 [23:04:25] you can, but you don't have to Ebe :) [23:04:42] Will do a final check, and approve x2 [23:04:45] some mentors where givin a summary of student's work, some just approved [23:04:50] were* [23:06:36] but neccessarily tell me how it was to be a mentor for the first time when you'll be done with it! :) [23:07:16] Will do [23:11:23] today was the first day when I had no tasks to review [23:12:10] I like giving feedback to the students [23:12:45] usually "Well done" or similar - then if I can give them some pointers, I do [23:12:58] sometimes there's nothing more to say [23:13:05] :D helping is really nice [23:13:07] There's one little logic problem I see [23:13:51] once in my life I gave my sandwiches to a homeless man, for the rest of this day I was just shining and happy like I did I don't know what [23:13:58] Ebe123, what is it? [23:14:21] try to spot the problem line 580-581 [23:15:44] we don't need to check for midi file because it's already checked and if it doesn't exist, exception is thrown? [23:16:16] That is where it's checked [23:17:15] let mi focus on this to find the issue [23:17:17] me* [23:20:35] sorry, no clue [23:20:49] (03CR) 10Ladsgroup: [C: 032] Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) (owner: 10Tpt) [23:22:48] (03Merged) 10jenkins-bot: Uses PSR-4 autoloader [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/401082 (https://phabricator.wikimedia.org/T182943) (owner: 10Tpt) [23:25:35] I'm just getting an odd thing, one sec [23:28:57] !$options['raw'] || ( $options['generate_ogg'] && !$options['override_midi'] ) returns true on scores in raw mode without the vorbis attribute [23:29:13] these parenthesizes are redundant btw [23:29:17] !$options['raw'] || ( $options['generate_ogg'] || !$options['override_midi'] ) as well [23:30:07] (03CR) 10SamanthaNguyen: [C: 032] "Thanks!" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 (owner: 10Umherirrender) [23:30:38] yes, but the point is that generate_ogg seems to be passed as true even if it shouldn't be [23:31:19] hm, I don't know it then [23:31:29] but I didn't touch anything related to this piece of code [23:31:46] (03Merged) 10jenkins-bot: Use relative path in require_once [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/401098 (owner: 10Umherirrender) [23:32:06] The odd thing is that $needMidi seems to be true in both cases [23:33:00] maybe put var_dump($options) and see what happens when? [23:36:03] (03PS1) 10Umherirrender: build: Updating mediawiki/mediawiki-codesniffer to 15.0.0 [extensions/cldr] - 10https://gerrit.wikimedia.org/r/401107 [23:36:20] (03CR) 10Umherirrender: "There was an error on update: T183828" [extensions/cldr] - 10https://gerrit.wikimedia.org/r/401107 (owner: 10Umherirrender) [23:40:21] Line 580: If normal or vorbis requested or with MIDI override, set needMidi true [23:40:37] Should be an AND, If normal or vorbis requested, without MIDI override, set needMidi true [23:41:37] line 479: override_midi is a bool, so even if its value is false, with isset, becomes true [23:41:46] Remove isset there [23:43:01] And then it'll be perfect, Albert221 [23:43:07] 22:15 if the override_midi parameter is set, not if true [23:43:33] (03PS11) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:43:50] $options['override_midi'] is either true or false [23:43:54] It's always set [23:44:15] Couple lines after, you use it like that [23:44:23] yes, I know, that's why I was testing its value, not its existence :D [23:44:40] I quoted you few messages above [23:45:39] What do you mean by that? [23:46:28] (03PS1) 10Umherirrender: Revert "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:47:22] I just thought that it would somehow relate to that change [23:48:53] ??? [23:49:56] Still have to fix line 581. You could also remove the un-necessary parentheses and line-breaks [23:51:20] like this, right? [23:51:20] if ( !$options['raw'] || $options['generate_ogg'] && !$options['override_midi'] ) { [23:52:17] If code isn't raw or vorbis requested, without MIDI override [23:52:23] Sounds good, yes! [23:52:51] (03PS12) 10Albert221: Add source DL link to popup [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:53:03] the thing that this change isn't in separate patch doesn't change anything, right? [23:53:18] because it was already in master and doesn't belong to that task [23:53:27] so I can make it a separate patch [23:53:58] No, it's fine [23:54:20] okay then, it's fixed^ :) [23:54:24] Just say you did it in the commit message [23:54:30] oh sure [23:55:18] There have been changes that did more than what the commit message said it did, and it gets on my nerves when there's a problem [23:56:05] (03PS13) 10Albert221: Add source DL link to popup, fix $needMidi cond [extensions/Score] - 10https://gerrit.wikimedia.org/r/401093 (https://phabricator.wikimedia.org/T183736) [23:56:19] (03PS2) 10Umherirrender: Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:56:24] (03PS3) 10Umherirrender: Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 [23:56:33] Ebe123, yes, sure, I second that! [23:56:38] (03CR) 10Umherirrender: [V: 032 C: 032] Revert some parts of "Add BlueSpiceAbout" [extensions] - 10https://gerrit.wikimedia.org/r/401108 (owner: 10Umherirrender) [23:57:40] But the code looks good and functions well. Tested where MIDI or the score is unavailable [23:57:48] still looks good