[00:08:54] (03PS1) 10Boboivancich: Add a label to the logout link, which is otherwise presented as <0> in MW 1.29 when UserSwitch is not allowed [extensions/Auth_remoteuser] - 10https://gerrit.wikimedia.org/r/400453 [01:30:57] 10MediaWiki-Parser: Add a magic word to identify the wiki with its name - https://phabricator.wikimedia.org/T183733#3862083 (10Cyberpower678) [01:30:58] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateDescription` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183618#3862094 (10divadsn) a:03divadsn Will do that now, patch coming soon :) [01:35:05] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862096 (10Legoktm) [01:48:26] Hi, I am Nithilan and I am on IRC for a Google Code In Task.(Get onto Internet Relay Chat) [01:49:06] Nithi: welcome are you using a webclient? [01:49:16] no [01:49:21] Ok [01:49:27] Im using KVIrc [01:49:33] Ok [01:53:46] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862098 (10divadsn) >>! In T179202#3861385, @jayvdb wrote: > Repeating some of what I put into the code review of https://github.com/python-social-auth/social-core/pull/169 > > I... [01:58:37] (03Abandoned) 10Isarra: Fix language and category wrapping issue [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/396809 (owner: 10Isarra) [02:24:53] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862044 (10Reedy) Do you know if this was a problem before? It uses TINYTEXT, which is 255 bytes... But, if we look at the code, it does truncate... https://github.com/wi... [02:28:55] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862101 (10Reedy) ``` > echo mb_strlen( $wgContLang->truncate( 'Unnecessary page: content was: "Hi everyone, I am translating the system messages in Translatewiki.net to S... [02:29:56] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862102 (10Reedy) [02:54:18] (03PS1) 10Legoktm: Run Pygments using Python 3 [extensions/SyntaxHighlight_GeSHi] - 10https://gerrit.wikimedia.org/r/400457 (https://phabricator.wikimedia.org/T182851) [02:57:27] 10SyntaxHighlight, 10MW-1.31-release, 10Patch-For-Review: SyntaxHighlight should run Pygments with Python 3 - https://phabricator.wikimedia.org/T182851#3862109 (10Legoktm) a:03Legoktm [03:03:02] (03PS1) 10Divadsn: Unit test NewsletterDb::updateDescription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) [03:08:26] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862113 (10jayvdb) @divadsn , you have three commits on https://github.com/python-social-auth/social-core/pull/169/commits ; that is unnecessary , and in gerrit world it would be... [03:18:31] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862114 (10Glendales) @Legoktm I am using Safari on an Apple iPhone 7 and an iPad Air 2, both of which give the problem. I don’t have... [03:40:20] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3862115 (10divadsn) @jayvdb but isn't it how it's supposed to be done on GitHub where you squash those commits during merge? I mean, people are always telling you not to force pus... [03:42:25] (03PS1) 10Ebe123: Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) [03:43:56] (03CR) 10Ebe123: "To not invalidate too many existing keys, especially as this is a follow-" [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [03:46:42] (03CR) 10Ebe123: "Please check I56c603483, removing logic that came from this change." [extensions/Score] - 10https://gerrit.wikimedia.org/r/102367 (owner: 10Brian Wolff) [03:55:06] (03CR) 10Pwirth: [C: 032] Fix use of boolean in extension.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/400418 (owner: 10Umherirrender) [03:55:32] (03CR) 10Pwirth: [C: 032] Fix register of extension in extension.json [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/400419 (owner: 10Umherirrender) [03:55:51] (03PS1) 10MarkAHershberger: Add methods to retrieve log and latest entry [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 [03:57:17] (03CR) 10jerkins-bot: [V: 04-1] Add methods to retrieve log and latest entry [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [04:04:55] 10MediaWiki-extensions-Score, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Add version to Score hashes - https://phabricator.wikimedia.org/T49448#3862124 (10Ebe123) [04:10:59] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862126 (10Pppery) [04:11:03] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3862125 (10Pp... [04:11:45] (03PS1) 10Ebe123: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) [04:12:37] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3862129 (10Ebe123) [04:21:16] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The main page should be unique per newsletter" in NewsletterCreate - https://phabricator.wikimedia.org/T183637#3859134 (10Ry... [04:23:06] (03PS6) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [04:23:17] (03PS1) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [04:26:23] 10MediaWiki-extensions-Newsletter, 10MW-1.31-release-notes (WMF-deploy-2017-11-07 (1.31.0-wmf.7)): Remove code duplication in EditPage and NewsletterContentUpdate - https://phabricator.wikimedia.org/T178743#3862140 (10Pppery) (patch was merged a more month ago) [05:05:30] hello this is vikx from Google-Code in [05:06:06] hi Vikx, welcome! :-) [05:06:32] Are you from Google-Code in [05:07:21] Vikx: Welcome! [05:13:25] Vikx, what tasks are you interested in? [05:13:50] mostly research based tasks [05:13:58] i am just a beggier [05:14:10] What about you? [05:16:13] I'm not participating in GCI, but I mostly focus on maintaining the sheet music extension [05:16:25] beggier? [05:16:41] beginner [05:17:50] Ah. Check https://phabricator.wikimedia.org/tag/google-code-in-2017/ for some tasks that might interest you [05:18:05] thank you [05:18:10] Will do that [05:20:17] Research in what area? There are tasks like https://phabricator.wikimedia.org/T181593 [05:20:32] but there doesn't seem to be much. [05:30:40] There are also tasks like https://phabricator.wikimedia.org/T181539 and https://phabricator.wikimedia.org/T181577 [05:52:02] 10SyntaxHighlight: Support ignoring the line attribute when attribute "line" set to "off" (or 0) - https://phabricator.wikimedia.org/T114483#1697073 (10jayvdb) The entire problem space has moved, as Wikimedia now uses Pygments. @Oetterer , are you still using the syntax highlighter that uses GeSHi ? [06:06:47] (03PS1) 10Prtksxna: Use findItemFromData instead getItemFromData [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400466 (https://phabricator.wikimedia.org/T76630) [06:07:08] (03CR) 10Prtksxna: [C: 04-2] "(Wait till the right version of OOUI is included in core.)" [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400466 (https://phabricator.wikimedia.org/T76630) (owner: 10Prtksxna) [06:07:38] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862151 (10Prtksxna) [06:14:20] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862153 (10Prtksxna) [06:17:21] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862155 (10Prtksxna) [06:17:25] Good night! [06:20:28] 10MediaWiki-extensions-Score, 10Multimedia: Score doesn't output image size (width/height) - https://phabricator.wikimedia.org/T50088#3862156 (10Ebe123) [06:21:47] 10MediaWiki-extensions-Score, 10Multimedia, 10TimedMediaHandler, 10Wikisource, 10Performance: Audio player takes a long time to initialize when requesting Vorbis output via invocation - https://phabricator.wikimedia.org/T49533#3862157 (10Ebe123) [06:24:19] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862159 (10Tgr) [06:24:23] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862169 (10Prtksxna) [06:28:53] 10OOjs-UI, 10MW-1.31-release-notes (WMF-deploy-2017-09-26 (1.31.0-wmf.1)), 10Patch-For-Review, 10Technical-Debt: Rename a lot of getters for consistency - https://phabricator.wikimedia.org/T76630#3862171 (10Prtksxna) [06:29:48] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862172 (10Tgr) [06:30:09] 10Support-and-Safety: Change email address for Mrszelvesz - https://phabricator.wikimedia.org/T183734#3862159 (10Tgr) 05Open>03Resolved a:03Tgr Ran `resetUserEmail.php`. [06:37:43] (03PS14) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [06:53:37] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862177 (10Aklapper) What would this show for `www.mydomain.xyz/wiki`? [06:56:20] (03CR) 10Umherirrender: [V: 032] Fix use of boolean in extension.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/400418 (owner: 10Umherirrender) [06:56:28] 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Multimedia: Error uploading XML files: "This file contains HTML or script code that may be erroneously interpreted by a web browser." - https://phabricator.wikimedia.org/T183727#3862183 (10Aklapper) [06:56:30] (03CR) 10Umherirrender: [V: 032] Fix register of extension in extension.json [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/400419 (owner: 10Umherirrender) [06:57:01] (03CR) 10Umherirrender: [C: 032] "Resubmit" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [07:00:29] (03CR) 10Umherirrender: Change php extract() to explicit code (032 comments) [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [07:02:56] 10MediaWiki-Codesniffer, 10Patch-For-Review: IfElseStructureSniff creates php error on autofix with alternative if else - https://phabricator.wikimedia.org/T178772#3862184 (10Umherirrender) 05Open>03Resolved [07:02:59] (03Merged) 10jenkins-bot: @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [07:03:01] (03CR) 10Yaron Koren: "Hi - could you explain the purpose of the ShowLog.php script? I understand what it does, but I don't understand what benefit it provides, " [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [07:30:56] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [07:32:29] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [07:34:42] (03CR) 10Nikerabbit: [C: 04-1] Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [07:56:01] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10Legoktm) Whatever the output of `wfWikiID()` is. [08:03:40] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3732727 (10takidelfin) It's acctually done? I'm interested in this task. But I can't see it on GCI website, and on WIkimedia Commons are some designs (but old, after it many users propose... [08:11:47] (03PS9) 10Ebe123: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) [08:12:24] (03CR) 10Ebe123: Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [08:13:35] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400474 (owner: 10L10n-bot) [08:24:16] 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3862216 (10Od1n) Thanks :) `@grey-bright` [[ https://github.com/wikimedia/mediawiki-skins-Timeless/blob/master/resources/variables.less | variable ]] is `#eee`.... [08:29:12] /c [08:35:55] 10MediaWiki-extensions-TweetANew, 10Google-Code-in-2017: Re-enable codesniffer sniffs disabled in TweetANew - https://phabricator.wikimedia.org/T183676#3862219 (10Aklapper) Hmm, I wonder how maintained [[ https://www.mediawiki.org/wiki/Extension_talk:TweetANew | TweetANew ]] is, and how large a chunk of work s... [08:38:02] (03CR) 10Legoktm: [C: 04-1] Replace class_exists with ExtensionRegistry checks (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:38:52] 10MediaWiki-Special-pages: Allow for an easy copy-paste representation of information on "Special:Version" - https://phabricator.wikimedia.org/T176643#3632223 (10Rical) In fr.wikisource.org with 10.0.32-MariaDB which differ from 10.0.31-MariaDB in www.mediawiki.org, I get and error, 10 minuts after a good run: *... [08:40:21] (03PS2) 10Ebe123: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) [08:40:56] (03CR) 10Ebe123: Replace class_exists with ExtensionRegistry checks (031 comment) [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:44:10] (03PS1) 10Legoktm: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 [08:44:12] (03PS1) 10Legoktm: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 [08:44:14] (03PS1) 10Legoktm: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 [08:44:17] (03PS1) 10Legoktm: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 [08:44:19] (03PS1) 10Legoktm: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 [08:44:19] https://gerrit.wikimedia.org/r/#/c/400460/ would be more important to review (just check my logic in the commitmsg) Legoktm [08:44:21] (03PS1) 10Legoktm: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 [08:44:23] (03PS1) 10Legoktm: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 [08:44:25] (03PS1) 10Legoktm: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 [08:44:30] Ebe123: will take a look [08:44:41] hello everyone [08:44:54] Hello Lucifer_ ! [08:45:04] hi! [08:45:52] Google Code-in? What projects are you taking on? [08:47:40] 10MediaWiki-extensions-General, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Move namespaced extensions to use PSR-4 autoloading - https://phabricator.wikimedia.org/T182943#3862228 (10Aklapper) @Reedy: How can a contributor identify such an ext... [08:48:47] yes GCI [08:49:39] What type of task would you be interested in? [08:49:45] (03CR) 10jerkins-bot: [V: 04-1] tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [08:50:12] oops [08:50:19] (03CR) 10Legoktm: [C: 032] Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [08:51:03] Thank you legoktm [08:52:17] (03CR) 10Legoktm: [C: 032] Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:52:38] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3862230 (10Aklapper) > extensions/Collection/OfflineContentGenerator/epub_renderer - not... [08:52:49] (03PS2) 10Legoktm: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 [08:52:52] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [08:52:58] (03PS2) 10Legoktm: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 [08:53:05] (03PS2) 10Legoktm: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 [08:53:13] (03PS2) 10Legoktm: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 [08:53:17] (03Merged) 10jenkins-bot: Remove rawAndMidi from cache options [extensions/Score] - 10https://gerrit.wikimedia.org/r/400460 (https://phabricator.wikimedia.org/T49448) (owner: 10Ebe123) [08:53:24] (03PS2) 10Legoktm: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 [08:53:33] (03PS2) 10Legoktm: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 [08:53:41] (03PS2) 10Legoktm: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 [08:54:00] anyone here who has PHP with the YAML extension installed? [08:55:03] Nikerabbit: I could install it I guess [08:55:14] (03Merged) 10jenkins-bot: Replace class_exists with ExtensionRegistry checks [extensions/Score] - 10https://gerrit.wikimedia.org/r/400463 (https://phabricator.wikimedia.org/T183096) (owner: 10Ebe123) [08:56:19] (03PS2) 10Legoktm: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 [08:56:24] legoktm: 3v4l doesn't have it: https://3v4l.org/SLo00 I am curious what this returns in PHP [08:57:22] * legoktm waits to get pwned [08:57:35] Nikerabbit: https://paste.fedoraproject.org/paste/XeqcBX6VJ-d1QQzHGkTzjA/raw [08:57:40] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3862233 (10Aklapper) [08:58:24] legoktm: thanks! I'll file a bug against HHVM [08:58:35] Nikerabbit: interestingly, fedora default configuration has yaml.decode_php set to false [08:59:20] legoktm: good! it should default to false in upstream as well [08:59:35] in hhvm it cannot be disabled [08:59:47] http://www.php.net/manual/en/yaml.configuration.php says on by default [08:59:51] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Special:Newsletter/id/subscribers does not properly update subscriber count - https://phabricator.wikimedia.org/T183189#3862234 (10Aklapper) @01tonythomas : Once this task is ready / its task description is clear enough for #GCI2017, please give a heads... [09:00:02] legoktm: yes, "should" as in my opinion :) [09:00:29] Nikerabbit: try convincing the maintainer :) https://pecl.php.net/package/yaml [09:01:31] hmm [09:01:35] https://github.com/php/pecl-file_formats-yaml/pull/18 maybe the docs are out of date [09:01:41] 10UI-Standardization, 10Documentation: Update documentation about where page styling and skin css comes from - https://phabricator.wikimedia.org/T178641#3862237 (10Aklapper) @Zppix: No reply, hence removing the #GCI2017 tag. Feel free to re-add once my previous comment has been answered. Thanks! [09:02:36] legoktm: uuh, could be [09:06:43] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862244 (10Ebe123) p:05Triage>03Low [09:07:15] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862244 (10Ebe123) I don't know if this would be admissible as a little project, but here's an idea. [09:07:25] (03PS15) 10Legoktm: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [09:08:37] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400519 (owner: 10L10n-bot) [09:08:42] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/GuidedTour] - 10https://gerrit.wikimedia.org/r/400522 (owner: 10L10n-bot) [09:08:49] hello [09:08:55] welcome to irc [09:09:14] Hey guys. I am here for Google CodeIn 2017 (first task) [09:09:28] Hello anpans! [09:09:39] Hi :) [09:09:55] Welcome :-) [09:10:09] Have you looked around for tasks you're interested in doing? [09:10:53] I have just registered so I'm doing that now [09:13:44] 10MediaWiki-extensions-InputBox, 10UI-Standardization, 10Google-Code-in-2017: Convert InputBox to use OOUI where possible - https://phabricator.wikimedia.org/T106948#3862258 (10Aklapper) @Prtksxna, @matmarex: Could you answer the last comment please, if you still think this could be suitable for creating #GC... [09:13:47] (03CR) 10Legoktm: [C: 032] maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:14:13] 10UI-Standardization, 10Collaboration-Team-Triage, 10Possible-Tech-Projects, 10WikiLove, 10Google-Code-in-2017: Convert WikiLove from jQuery UI to OOjs UI - https://phabricator.wikimedia.org/T89815#3862259 (10Aklapper) If anyone knowledgeable enough could use T89815#3743426 to edit the task description t... [09:16:03] (03PS3) 10Legoktm: Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:17:37] (03CR) 10Legoktm: [C: 032] Add AvailableRights in extension.json [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/400422 (owner: 10Umherirrender) [09:17:54] (03CR) 10D3r1ck01: "Minor fix :)" (032 comments) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [09:18:22] (03CR) 10Legoktm: [C: 032] Skip unit tests, if diff3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 (owner: 10Umherirrender) [09:18:45] (03CR) 10Legoktm: [C: 032] Fix strict standard about ApiBase::getWebUITokenSalt [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400399 (owner: 10Umherirrender) [09:18:47] (03CR) 10Nikerabbit: [C: 032] Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [09:20:53] (03CR) 10Legoktm: Use ExtensionRegistry instead of class_exists (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [09:21:21] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10Patch-For-Review: Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#3862261 (10Ebe123) [09:21:29] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10Patch-For-Review: Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#741300 (10Ebe123) 05Open>03Resolved [09:22:01] (03CR) 10Legoktm: [C: 04-1] Use ExtensionRegistry instead of class_exists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [09:22:03] (03Merged) 10jenkins-bot: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:22:05] (03Merged) 10jenkins-bot: Add AvailableRights in extension.json [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/400422 (owner: 10Umherirrender) [09:22:07] (03Merged) 10jenkins-bot: Skip unit tests, if diff3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 (owner: 10Umherirrender) [09:22:26] (03Merged) 10jenkins-bot: Fix strict standard about ApiBase::getWebUITokenSalt [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400399 (owner: 10Umherirrender) [09:22:29] (03Merged) 10jenkins-bot: Fix """ in title on infopages [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [09:26:46] hdukyawe [09:26:51] sorry [09:27:59] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:28:48] (03CR) 10Legoktm: [C: 032] Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:29:58] (03Merged) 10jenkins-bot: Avoid PHP 7.1 warning of &$this usage [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) (owner: 10LukBukkit) [09:31:04] (03CR) 10Legoktm: [C: 031] tests: Commit initial version of DevelopmentSettings.php (031 comment) [core] - 10https://gerrit.wikimedia.org/r/383041 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [09:31:59] (03CR) 10Legoktm: [C: 032] Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:32:05] (03CR) 1001tonythomas: [C: 032] Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:33:42] (03CR) 10jenkins-bot: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [09:35:15] 10MediaWiki-Gallery, 10Multimedia, 10Parsing-Team, 10Patch-For-Review: gallery syntax claims to require 'px' for widths/heights attributes, but actually discards all strings after the number - https://phabricator.wikimedia.org/T129372#3862276 (10Legoktm) Adding #parsing-team since this is apparently blocke... [09:35:34] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/erudite] - 10https://gerrit.wikimedia.org/r/400562 (https://phabricator.wikimedia.org/T153505) [09:36:57] (03CR) 10Legoktm: [C: 032] build: Run phplint for inc files [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 (owner: 10Umherirrender) [09:37:19] (03PS16) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) [09:37:48] (03Merged) 10jenkins-bot: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:37:50] (03Merged) 10jenkins-bot: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [09:38:09] .jy [09:38:41] (03Merged) 10jenkins-bot: build: Run phplint for inc files [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 (owner: 10Umherirrender) [09:38:46] (03PS1) 10LukBukkit: Avoid PHP 7.1 warning of &$this usage [skins/Gamepress] - 10https://gerrit.wikimedia.org/r/400563 (https://phabricator.wikimedia.org/T153505) [09:38:54] (03CR) 10Legoktm: [C: 032] Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:40:43] (03CR) 10Legoktm: [C: 032] Fix class name for QueryPages (no behaviour change) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/400235 (owner: 10Brian Wolff) [09:41:11] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862285 (1001tonythomas) [09:41:13] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate - https://phabricator.wikimedia.org/T183638#3862282 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 Great work. Thanks ! [09:43:30] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) (owner: 10Divadsn) [09:45:00] (03Merged) 10jenkins-bot: Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:45:02] (03Merged) 10jenkins-bot: Fix class name for QueryPages (no behaviour change) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/400235 (owner: 10Brian Wolff) [09:45:06] (03Merged) 10jenkins-bot: Unit test NewsletterDb::updateDescription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400459 (https://phabricator.wikimedia.org/T183618) (owner: 10Divadsn) [09:46:39] (03CR) 10jenkins-bot: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [09:47:07] (03CR) 10Legoktm: "I'm not really sure about this, the capitalization comes from the GPL, which was probably meant for plain text, not HTML. The only differe" [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [09:47:26] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3862287 (10Framawiki) >>! In T179677#3862214, @takidelfin wrote: > It's acctually done? I'm interested in this task. But I can't see it on GCI website, and on WIkimedia Commons are some de... [09:48:27] 10Design, 10PAWS, 10Google-Code-in-2017: Propose a logo for the PAWS project - https://phabricator.wikimedia.org/T179677#3862288 (10takidelfin) Ok, thanks! [09:48:53] (03CR) 1001tonythomas: [C: 031] "Looking good actually. Sadly, I cannot really test it before another 10 hours or so. Adding in others so that they can review and +2." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [09:49:27] (03CR) 10Legoktm: [C: 032] Clean up ESLint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399822 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [09:50:07] (03CR) 10Legoktm: [C: 032] Switch from jshint to eslint [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398640 (owner: 10Fomafix) [09:50:25] 10MediaWiki-Containers, 10Services (next): Separate RESTBase and Parsoid into their own images and deployments - https://phabricator.wikimedia.org/T183738#3862289 (10mobrovac) p:05Triage>03Normal [09:51:32] hi [09:51:55] (03CR) 10Legoktm: "recheck" [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [09:52:03] (03Merged) 10jenkins-bot: Clean up ESLint configuration [extensions/Popups] - 10https://gerrit.wikimedia.org/r/399822 (https://phabricator.wikimedia.org/T177262) (owner: 10Zfilipin) [09:52:06] (03Merged) 10jenkins-bot: Switch from jshint to eslint [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/398640 (owner: 10Fomafix) [09:52:15] i am vansh and i am from gci [09:52:46] vanshaggarwal: Welcome! [09:52:46] i am here to complete my task [09:52:51] (03CR) 10Legoktm: [C: 032] make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [09:52:56] hello phantom [09:53:07] Great! Good luck with your GCI tasks! [09:53:46] thank you [09:53:57] main sps [09:53:58] aur bhai vansh [09:54:14] sps [09:54:19] ?? [09:54:31] to pagal [09:54:42] bta yaar [09:55:55] (03CR) 10jenkins-bot: Change php extract() to explicit code [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [09:56:10] anybody here [09:57:04] vanshaggarwal: If you have any questions - feel free to ask, we are always happy to help :) [09:57:42] (03CR) 10D3r1ck01: [C: 04-1] "No, I asked for just the commit message. Not to include the files Legoktm has changed. I clearly see you worked from your branch, but inst" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) (owner: 10Noella94) [09:58:08] (03CR) 10jerkins-bot: [V: 04-1] Let Html::element do the HTML encoding [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [09:58:17] bro who i have to do connect to irc task [09:58:34] how [09:59:11] (03Merged) 10jenkins-bot: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [09:59:17] emmm.... what? [09:59:33] You have already joined needed irc channel :) Now you can ask any questions here and communicate with other developers [09:59:44] how i have to do get onto irc task [09:59:44] But before submitting this task for review, you need to wait 1 hour [09:59:52] ok [09:59:55] and students, heh [10:00:01] Yep :) [10:00:19] where are you all from [10:00:48] From all over the world :) [10:00:54] ok [10:01:10] I am from Ukraine. There are a lot of other GCI students from countries like Poland, India and others [10:01:20] i am from india [10:01:30] Nice! [10:01:32] i'm from poland :D [10:01:34] phantom we chatted yesterday also [10:01:47] hello neighbor [10:01:48] :D [10:01:59] :) [10:02:05] but yesterday i was connected by freenode [10:02:21] takidelfin u from [10:03:00] poland [10:03:13] ok [10:03:38] how many tasks you two have done [10:03:40] vanshaggarwal: It doesn't matter which IRC client you use. Use are still connected to the same network :) [10:04:08] but freenode is not to be used [10:04:40] why is it not to be used? [10:05:04] it was wriiten in the task not to use freenode [10:05:17] link? [10:05:31] yes [10:05:40] vanshaggarwal: That's for the task. But later, after the task, you may use whichever you like [10:05:51] yes [10:06:12] erm [10:06:25] I think you're a bit confused, freenode is the name of the IRC network that we are all connected to [10:06:51] ok [10:08:12] how are you all [10:08:28] (03CR) 10jenkins-bot: make 7zip wrapper usable for dumping text revisions again [core] - 10https://gerrit.wikimedia.org/r/399947 (owner: 10ArielGlenn) [10:10:57] sandy where are you from [10:12:22] vanshaggarwal: right now in UK. Just here for interest :-) [10:14:07] legoktm: could extensions be also added to https://doc.wikimedia.org/cover/ ? [10:14:34] anyone know hindi [10:15:39] Nikerabbit: https://phabricator.wikimedia.org/T71685 I'm planning on working on it next year (so in a few days ;)) [10:16:19] legoktm: yay! [10:16:28] yay [10:19:08] hi [10:21:55] anyone online' [10:22:24] 10MediaWiki-Codesniffer: Forbid parse_str() without a second argument - https://phabricator.wikimedia.org/T183739#3862318 (10Ricordisamoa) [10:22:26] (03CR) 10Thiemo Kreuz (WMDE): Add tests for TextboxBuilder (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [10:23:54] anyone online [10:24:25] please chat [10:24:53] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3862330 (10kai.nissen) @Pablo-WMDE as you see fit. we can target the devices using centralnotice, so it's fine to not... [10:25:01] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [10:25:20] anyone online [10:25:51] yes [10:25:58] but we're doing other things too :) [10:26:44] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [10:27:15] 04(no projects): not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862331 (10Rameho) [10:27:17] (03CR) 10Legoktm: tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [10:28:36] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "TemplateParser is a nice little 220 lines class. I agree that having a single top-level @covers tag is fine in such cases." [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:30:59] hello [10:31:03] vanshaggarwal: Hey! [10:31:09] Are you here for GCI? [10:31:14] yes [10:31:19] Okay! [10:31:27] Is this your first ticket? Stay on IRC for 1 hour? [10:31:47] yes [10:31:51] Okay! [10:31:58] where r you from [10:32:05] So there are a lot of people here (192 to be specific) + bots [10:32:09] vanshaggarwal: I'm from Cameroon :) [10:32:18] okay [10:32:22] me from india [10:32:36] Some people are on holidays [10:32:41] vanshaggarwal: Okay great :) [10:32:48] yes [10:32:52] Some people are busy, some are .... [10:33:10] on which task you are [10:33:46] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Add @covers tags to database tests (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [10:33:47] vanshaggarwal: So I'm a mentor! Helping out GCI participants (if possible) like you to review code and guide you [10:33:57] ok [10:34:35] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Remove resolved todo from MWNamespace test (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:34:41] can you tell how i have to submit this task [10:34:49] (03Merged) 10jenkins-bot: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:34:49] So while iddling for 1 hour, read this: http://www.catb.org/esr/faqs/smart-questions.html [10:34:58] vanshaggarwal: Yes, I can help you on that [10:35:22] vanshaggarwal: But first did you claim the task on Google Code-In website? [10:35:25] (03PS17) 10Noella94: Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) [10:35:40] i claimed [10:36:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "The test serves one purpose: it makes sure the constructor is not made private. But it's redundant anyway because there are a ton more "ne" [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [10:38:27] vanshaggarwal: Perfect! So when you are done, you will just go to your claimed instance and submit for approval [10:38:38] ok [10:38:51] Hope you read the task very well because you have to submit with a message about the IRC client you used, your IRC nick you used etc... [10:38:56] Do you understand? :) [10:39:01] ok [10:39:07] 10Design, 10WMDE-Design, 10Wikidata, 10Wikidata Query UI, and 3 others: Implement keyboard accessibility for Query.Wikidata.org - https://phabricator.wikimedia.org/T173213#3862346 (10Lydia_Pintscher) [10:40:12] (03Merged) 10jenkins-bot: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:40:34] can you tell me which task i should do after this [10:40:43] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Individual review done. This looks absolutely fine for me, and I'm willing to merge this within the next days. I just want to give others " (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [10:41:44] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (https://phabricator.wikimedia.org/T178215) (owner: 10Noella94) [10:42:15] (03Merged) 10jenkins-bot: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [10:43:56] (03CR) 10jenkins-bot: Improve @covers for TemplateParserTest [core] - 10https://gerrit.wikimedia.org/r/400491 (owner: 10Legoktm) [10:44:05] vanshaggarwal: Honestly I don't know :) [10:44:19] It all depends on you and what interests you, I mean what is within your reach :) [10:44:26] ok [10:44:43] (03CR) 10Legoktm: Add @covers tags to database tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [10:48:42] hi [10:49:43] bye all [10:49:53] vanshaggarwal: Have you made 1 hour already? [10:49:58] my time is over [10:50:02] Ohh perfect! [10:50:06] 1 min left [10:50:11] :D [10:50:17] vanshaggarwal: Make sure to submit on GCI [10:50:23] ok [10:50:24] Read the submission instructions [10:50:29] thanks [10:50:31] Then submit and I'll quickly review :) [10:50:34] vanshaggarwal: You are welcome :) [10:50:37] ok [10:50:45] Good luck in Google Code-In 2017 [10:50:59] bye [10:51:06] vanshaggarwal: Bye bye! :) [10:51:11] See you again soon [10:51:18] 10§ Phabricator Sprint Extension [2014-12-11]: not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862353 (10Aklapper) 05Open>03Invalid If your Phabricator installation is not installed in the path `/srv/phab/` then you need to adjust that path accor... [10:51:40] 10Phabricator-Sprint-Extension: not path "/srv/phab/phabricator/bin" to install sprint extension - https://phabricator.wikimedia.org/T183740#3862356 (10Aklapper) [10:52:23] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Screenreaders typically ignore capitalization entirely. What blind users read on their Braille line is typically all uppercase." (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399818 (owner: 10Lucas Werkmeister (WMDE)) [10:52:54] (03CR) 10jenkins-bot: Remove resolved todo from MWNamespace test [core] - 10https://gerrit.wikimedia.org/r/400489 (owner: 10Legoktm) [10:52:56] (03CR) 10Legoktm: [C: 04-1] "Needs parser test updates" [core] - 10https://gerrit.wikimedia.org/r/390896 (owner: 10Fomafix) [10:53:18] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] thumb.php: Set ENT_NOQUOTES for htmlspecialchars [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [10:54:00] i submitted my task [10:54:33] Does GCI only require 1 hour of commitment each day? [10:55:10] no my task was to be in one irc client for 1 hour [10:55:35] its on you how much time you want to devote [10:55:36] heh, okay [10:56:49] d3r1ck are you on [10:57:35] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862360 (10Kghbln) > Do you know if this was a problem before? I cannot tell for sure since I very rarely delete threads but I am pretty sure that this did not happen when... [10:59:09] sandybatman: Nope, it's just a task :) [10:59:20] vanshaggarwal: Sure! [10:59:23] Reviewing now :) [10:59:34] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] tests: Complete test coverage of HtmlArmor (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:00:19] 10MediaWiki-Core-Tests, 10Continuous-Integration-Infrastructure: Figure out how to accurately backfill MediaWiki core test code coverage data - https://phabricator.wikimedia.org/T182750#3862361 (10Legoktm) p:05Triage>03Low I'm not really convinced this is worth spending time on any more. My current investi... [11:00:27] anything more required [11:00:55] (03CR) 10jenkins-bot: Remove useless StatusTest::testCanConstruct() [core] - 10https://gerrit.wikimedia.org/r/400488 (owner: 10Legoktm) [11:02:33] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to database tests (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:02:53] bye all [11:03:03] 10MediaWiki-extensions-Quiz: Problem with ' caracter in answer textfields - https://phabricator.wikimedia.org/T183741#3862364 (10MarcodeFreitas) [11:05:53] (03Merged) 10jenkins-bot: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:08:11] (03Merged) 10jenkins-bot: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:12:05] 10MediaWiki-Codesniffer: Investigate upstreaming some of our custom sniffs - https://phabricator.wikimedia.org/T103642#3862382 (10Legoktm) [11:13:55] bye [11:17:08] (03CR) 10jenkins-bot: tests: Complete test coverage of HtmlArmor [core] - 10https://gerrit.wikimedia.org/r/400485 (owner: 10Legoktm) [11:19:00] (03PS18) 10Fomafix: Hide TOC with CSS instead of JavaScript [core] - 10https://gerrit.wikimedia.org/r/372515 [11:19:21] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/372515 (owner: 10Fomafix) [11:26:20] (03CR) 10jenkins-bot: Add @covers tags to database tests [core] - 10https://gerrit.wikimedia.org/r/400490 (owner: 10Legoktm) [11:26:30] 10MediaWiki-Special-pages: Allow for an easy copy-paste representation of information on "Special:Version" - https://phabricator.wikimedia.org/T176643#3862394 (10Kghbln) @Rical I am pretty sure you are on the wrong issue here. It looks to me like you should first conact the creator of the module in question. [11:32:41] 10MediaWiki-Templates, 10VisualEditor, 10VisualEditor-Tables, 10User-Ryasmeen, and 3 others: Support editing table cells whose formatting is defined by a template - https://phabricator.wikimedia.org/T85648#3862413 (10Magol) [11:34:05] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862414 (10Addshore) [11:34:20] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862415 (10Aklapper) @Ebe123: Thanks a lot! I've sent an invitation email to register as a #GCI2017 mentor. Could you also add yourself to the [[ https://www.mediawiki... [11:41:36] (03PS1) 10Phantom42: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) [11:43:30] 10MediaWiki-Containers, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862426 (10mobrovac) p:05Triage>03Normal [11:43:52] 10MediaWiki-Containers, 10Operations, 10Release-Engineering-Team, 10Epic, and 3 others: FY2017/18 Program 6 - Outcome 2 - Objective 3: Integrated, container-based development environment - https://phabricator.wikimedia.org/T170456#3862438 (10mobrovac) [11:43:55] 10MediaWiki-Containers, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862437 (10mobrovac) [11:44:05] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862439 (10Glendales) @Legoktm I am using Safari on an Apple iPhone 7 and an iPad Air 2, both of which give the problem. I don’t have... [11:44:17] 10MediaWiki-Containers, 10Goal, 10Services (doing): FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862426 (10mobrovac) [11:45:57] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862441 (10Glendales) @Aklapper I don’t see the “network” link you were talking about earlier. Can you point out on the screenshot bel... [11:48:58] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862442 (10Addshore) [11:49:38] (03PS1) 10Thiemo Kreuz (WMDE): Slightly improve some type hints in PHPDoc blocks [extensions/EducationProgram] - 10https://gerrit.wikimedia.org/r/400573 [11:49:41] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862443 (10Addshor... [11:54:34] 10MediaWiki-extensions-WikimediaIncubator, 10Easy, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Quotation marks are shown as " in title - https://phabricator.wikimedia.org/T72240#3862444 (10Nikerabbit) [11:55:45] (03PS1) 10Thiemo Kreuz (WMDE): Remove some superfluous parameter descriptions [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 [11:56:12] (03CR) 10Mobrovac: [C: 04-1] "Looking good, but could you please group these methods to the top of the class where the private static functions are? Mixing private and " (033 comments) [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [11:57:09] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862445 (10Addshor... [11:58:11] (03PS1) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [12:00:41] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862447 (10Addshore) [12:00:47] 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3862449 (10Addshore) p:05Triage>03Unbreak! [12:00:54] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3862450 (10Addshor... [12:01:07] 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible, 10User-Addshore: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComple... - https://phabricator.wikimedia.org/T183716#3862455 [12:01:20] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [12:13:56] (03PS2) 10Phantom42: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) [12:14:20] (03CR) 10Phantom42: "Thank you for reviewing! I agree with you and fixed those issues!" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [12:15:43] purrr [12:17:00] (03CR) 10Cindy-the-browser-test-bot: [C: 04-1] "I ran tests for your patch and there were some errors: clean_api_prefix_redirect_accent_squashing_accented_namespace_suggest_search_prefer" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [12:19:39] niaou? [12:20:15] * refeed[m] purrs back [12:22:09] :) [12:26:58] free ear scritches for everyone! [12:27:14] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [12:28:09] (03PS6) 10Fomafix: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [12:28:29] (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [12:37:15] 10MediaWiki-Containers, 10Goal, 10Services (doing), 10User-mobrovac: FY17/18 Q3 Program 6 Services Goal: Tools for managing services in minikube - https://phabricator.wikimedia.org/T183743#3862469 (10mobrovac) a:03mobrovac [12:38:53] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#3862471 (10Scott) [12:39:26] 10WMF-Legal, 10Tracking: Copyright license and attribution issues (tracking) - https://phabricator.wikimedia.org/T87268#3862474 (10Scott) [12:39:28] 10MediaWiki-General-or-Unknown, 10WorkType-NewFunctionality: Include action=credits output into action=info as well - https://phabricator.wikimedia.org/T41533#3862475 (10Scott) [12:39:30] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#323614 (10Scott) 05duplicate>03Open [12:39:32] 10MediaWiki-Database, 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extensions-CentralAuth, and 3 others: Provide consistent native way to attribute offsite users in revision history - https://phabricator.wikimedia.org/T20209#3862476 (10Scott) [12:39:54] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#323614 (10Scott) [12:39:56] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3862479 (10Scott) [12:40:36] 10MediaWiki-JobQueue, 10Analytics, 10EventBus, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862480 (10mobrovac) p:05Triage>03Normal [12:42:23] 10MediaWiki-Export-or-Import, 10MediaWiki-History-or-Diffs, 10MediaWiki-extension-requests: Mechanism for crediting external authors of a page - https://phabricator.wikimedia.org/T29629#3862493 (10Scott) Per Helder at T4994#3860813, rephrased task to only be about external authors as T4994 already covers on-... [12:42:30] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3862494 (10Scott) @He7d3r - you're right, sorry; looks like I glossed over that part. Done. [12:42:41] 10MediaWiki-JobQueue, 10Analytics, 10EventBus, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862495 (10mobrovac) [12:42:42] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 3 others: [EPIC] Develop a JobQueue backend based on EventBus - https://phabricator.wikimedia.org/T157088#3862496 (10mobrovac) [12:44:39] 10MediaWiki-JobQueue, 10Analytics, 10EventBus, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862480 (10mobrovac) [12:44:44] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 5 others: Select candidate jobs for transferring to the new infrastucture - https://phabricator.wikimedia.org/T175210#3862498 (10mobrovac) [12:46:12] 10MediaWiki-JobQueue, 10Analytics, 10EventBus, 10Goal, 10Services (doing): FY17/18 Q3 Program 8 Services Goal: Migrate two high-traffic jobs over to EventBus - https://phabricator.wikimedia.org/T183744#3862501 (10mobrovac) [12:46:16] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 3 others: Services Q2 2017/18 goal: Migrate a subset of jobs to multi-DC enabled event processing infrastructure. - https://phabricator.wikimedia.org/T175212#3862502 (10mobrovac) [12:46:21] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 4 others: Migrate htmlCacheUpdate job to Kafka - https://phabricator.wikimedia.org/T182023#3862500 (10mobrovac) [12:49:17] 10MediaWiki-Platform-Team, 10Operations, 10Epic, 10Performance-Team (Radar), 10Services (watching): 2017/18 Annual Plan Program 8: Multi-datacenter support, Q2 goals - https://phabricator.wikimedia.org/T175213#3862507 (10mobrovac) [12:49:18] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 3 others: [EPIC] Develop a JobQueue backend based on EventBus - https://phabricator.wikimedia.org/T157088#3862508 (10mobrovac) [12:49:25] 10MediaWiki-JobQueue, 10Analytics, 10ChangeProp, 10EventBus, and 2 others: Services Q2 2017/18 goal: Migrate a subset of jobs to multi-DC enabled event processing infrastructure. - https://phabricator.wikimedia.org/T175212#3862504 (10mobrovac) 05Open>03Resolved For all intents and purposes, this task h... [12:58:29] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862510 (10Aklapper) See https://developer.apple.com/safari/tools/ which shows a "Network" tab. I do not have any systems that can run... [13:02:01] * Albert221 waves to other people on the channel. [13:02:06] o/ [13:02:37] * Phantom42 waves to Albert [13:06:55] (03CR) 10Mobrovac: [C: 031] "LGTM, +1. Leaving to Petr and Kunal to double-check it." [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [13:07:39] 10MediaWiki-extensions-Linter: Provide additional Linter statistics about template-generated issues - https://phabricator.wikimedia.org/T170874#3862538 (10He7d3r) On ptwiki, I prioritized the list of "tidy-font-bug" by starting with the most transcluded templates containing errors: https://quarry.wmflabs.org/que... [13:09:28] o/ [13:15:37] (03PS1) 10Addshore: [MCR] pass $queryFlags into RevisionStore::getTitle [core] - 10https://gerrit.wikimedia.org/r/400577 (https://phabricator.wikimedia.org/T183716) [13:16:12] (03PS1) 10Addshore: Remove duplicate getTitle call in RevisionStore::getNextRevision [core] - 10https://gerrit.wikimedia.org/r/400578 [13:16:38] Hi this is Priyanshu Ahuja joined #wikimedia-dev for google code in [13:17:13] PriyanshuAhuja1: Welcome to Wikimedia development channel! [13:17:39] hello PriyanshuAhuja1 ! [13:18:13] welcome PriyanshuAhuja1 [13:21:58] hello PriyanshuAhuja1! Where are you from? How old are you? Tell something about yourself :) [13:22:44] looking forward to have a great time here [13:23:11] I am from Delhi 16 years old [13:23:30] PriyanshuAhuja1: Hello :) [13:23:34] Welcome [13:24:52] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862556 (10He7d3r) [13:25:37] Thanks everyone for the warm welcome!! [13:26:17] PriyanshuAhuja1: You're welcome! While idling, you can have a look at: https://www.mediawiki.org/wiki/New_Developers [13:32:34] thanks d3rick for the suggestion,having a look on it. [13:34:02] :) [13:40:39] 10MediaWiki-Containers: Apache in mediawiki-docker(wikimedia/mediawiki) crashes because the Apache was complaining about MEDIAWIKI_RESTBASE_URL - https://phabricator.wikimedia.org/T151051#3862576 (10Addshore) [13:40:42] 10MediaWiki-Containers: Apache in mediawiki-docker(wikimedia/mediawiki) crashes because the Apache was complaining about MEDIAWIKI_RESTBASE_URL - https://phabricator.wikimedia.org/T151051#2805758 (10Addshore) [13:45:25] 04(no projects): Context-dependent sort key: SECTIONSORT - https://phabricator.wikimedia.org/T183747#3862579 (10Takasugi_Shinji) [13:46:09] (03CR) 10Esanders: "This changes the DOM output from being inline-block (img) to block (div). While it wouldn't be very sensible to use scores inline, people " [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (https://phabricator.wikimedia.org/T114757) (owner: 10Ebe123) [13:47:04] 10MediaWiki-Parser: Create context-dependent sort key SECTIONSORT for use on Wiktionary (in addition to DEFAULTSORT) - https://phabricator.wikimedia.org/T183747#3862590 (10Aklapper) p:05Triage>03Low [13:58:55] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: class="wikitable plainrowheaders" does not work in mobile - https://phabricator.wikimedia.org/T183704#3862620 (10Izno) This is not a code-in task. Plainrowheaders are supported at the community level, not the code level, and nee... [14:02:32] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10Izno) I'm sure there's a reason for this request, but what is that reason? [14:08:31] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862627 (10Cyberpower678) >>! In T183733#3862625, @Izno wrote: > I'm sure there's a reason for this request, but what is that reason? IABot makes use of these identifiers to identify which wiki to access. Making... [14:14:27] 04(no projects): Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862628 (10Pginer-WMF) [14:14:42] 10UI-Standardization, 10Collaboration-Team-Triage, 10Notifications: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862638 (10Pginer-WMF) [14:16:43] Hello. I am Omkar Jadhav. I am here to see how IRC actually works, under a Google Code-in (GCI) task [14:16:57] Welcome farmax [14:17:10] farmax: Welcome! [14:17:20] welcome farmax [14:18:37] farmax: Welcome :) [14:20:53] 10UI-Standardization, 10Collaboration-Team-Triage, 10Notifications: Align notification icons with the icon styleguide - https://phabricator.wikimedia.org/T183749#3862628 (10Pginer-WMF) [14:23:39] <_farmax_> help -i [14:23:51] 10MediaWiki-General-or-Unknown: W3C Validator complains about
elements missing
children, and some unknown "language" parameter values - https://phabricator.wikimedia.org/T168624#3862651 (10Izno) [14:23:53] 10Accessibility, 10MediaWiki-Parser, 10Parsoid: Colon (:) & semicolon (;) shouldn't output as HTML definition list when used for indentation, boldfacing - https://phabricator.wikimedia.org/T6521#3862649 (10Izno) [14:24:05] _farmax_: What do you need help with? Feel free to ask :) [14:25:08] <_farmax_> How do I reply to mentioning a specific person? [14:25:40] _farmax_: like this: "name: message" [14:27:56] PriyanshuAhuja1: You can submit :) [14:29:05] Hi guys, I'm Liza and I'm here for a google code-in task [14:29:21] lizaa: Welcome! Good luck with GCI tasks! [14:29:53] d3rick sir i have submitted [14:29:55] Thanks :) [14:29:57] lizaa: welcome [14:30:13] welcome lizaa [14:30:17] Phantom42: Thanks [14:30:35] PriyanshuAhuja1: Hey, no need for the sir. It's just d3r1ck [14:30:48] lizaa: Welcome :) [14:30:50] 10MediaWiki-General-or-Unknown: W3C Validator complains about
elements missing
children, and some unknown "language" parameter values - https://phabricator.wikimedia.org/T168624#3862667 (10Izno) I've merged the task because the rest of it is invalid. The reason the validator complains about the languag... [14:30:57] PriyanshuAhuja1: Approved :) [14:30:58] ok d3r1ck [14:31:30] (03CR) 10MarkAHershberger: "The script was a quick way for me to test the functionality of the code I wrote. Looking at this again, after a night of sleep, though, I" [extensions/ApprovedRevs] - 10https://gerrit.wikimedia.org/r/400462 (owner: 10MarkAHershberger) [14:31:41] (03CR) 10Awight: [C: 04-1] "Please also include tests for updateModelVersion" (037 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) (owner: 10Ladsgroup) [14:31:48] PriyanshuAhuja1: Move on with your next task (if possible) [14:31:57] lizaa: Where are you from? [14:34:00] d3r1ck: I have submitted it. [14:34:26] farmax: have you been here an hour? [14:34:54] Hmmm... You've not been for an hour :) [14:35:23] d3r1ck: I'm from the UK [14:36:12] lizaa: Ohh wow! [14:37:05] <_farmax_> What Im I supposed to do now. Can I undo the submission and submit it again [14:37:48] <_farmax_> I will be here for an hour ofcourse. More than that. [14:37:59] PriyanshuAhuja1: You got a question on GCI, can you answer it? :) [14:38:08] _farmax_: No [14:38:18] I've marked the task as "More work needed" [14:38:34] So you will need to be here for at least an hour for you to complete the task [14:38:47] _farmax_: Also, make sure to read the task well and understand what is required [14:39:23] lizaa: Get yourself busy and feel free to ask your questions! We're here to help you out :) [14:39:34] Lines should be indented with 4 spaces. this was mean i need to using space 4 times than using tab right? this was python writing convention for pywikibot [14:40:13] eisenhaus335: Looking at what you just wrote yes [14:40:16] But let me read the docs too :) [14:40:26] https://www.mediawiki.org/wiki/Manual:Coding_conventions/Python [14:40:27] Not very familiar with Pywikibot [14:41:01] the tab button was used for insert /t right? (i am not sure /t or /n or /p [14:41:08] eisenhaus335: yes. And you can try running code style checks (flake8 if I remember correctly) to test that you do everything right [14:41:19] d3r1ck answered it [14:41:26] eisenhaus335: Yes, I now see that. You are correct! "4 spaces" instead of a tab :) [14:41:41] PriyanshuAhuja1: Okay! Thank you very much and move over to your next task :) [14:42:11] on it d3r1ck. [14:42:18] 10Internet-Archive, 10InternetArchiveBot: Bad url not recognized - https://phabricator.wikimedia.org/T183751#3862669 (10Igel_B_TyMaHe) [14:42:36] :) [14:45:17] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): [QA] Exploratory testing when users with multiple devices use synced reading lists - https://phabricator.wikimedia.org/T177309#3862680 (10RHo) [14:46:24] <_farmax_> d3r1ck: I have joined again [14:46:44] Sure! [14:46:57] You've exercised 3 different nicks [14:48:22] <_farmax_> d3r1ck: It disconnects me automatically sometimes. Problem with the ping or something else? [14:49:18] _farmax_: Maybe the problem is with stability of your connection. By the way, which IRC client do you use? [14:49:39] _farmax_: youre losing connection that is why [14:50:04] <_farmax_> Im using HexChat [14:50:10] my hexchat was like that too. just wait for 10 minute and then disconnect from channel [14:50:35] <_farmax_> eisenhaus355: so how to resolve it [14:50:37] _farmax_, its normal for us haha [14:50:44] nope you cant haha [14:51:06] i am just dont search the solution actually tehee [14:51:46] <_farmax_> Phantom42 , eisenhaus355 Mentors for Google Code-In? [14:52:05] nein we actually "participant" and student [14:52:11] _farmax_: no, Myself and d3r1ck are some of them [14:52:44] https://www.mediawiki.org/wiki/Google_Code-in/Mentors if you interested [14:52:59] <_farmax_> Zppix: I have restarted it again. This time I ll submit after an hour [14:53:04] eisenhaus335: wrong link [14:53:05] _farmax_: I am a GCI participant like you :) [14:53:22] https://www.mediawiki.org/wiki/Google_Code-in/2017 is the correct one [14:53:27] oops? tehee [14:54:03] _farmax_: Okay! Thanks [14:54:19] <_farmax_> Zppix: Can I discuss some of the coding issues here [14:54:23] (03PS1) 10Thiemo Kreuz (WMDE): Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 [14:54:30] _farmax_: sure [14:54:36] <_farmax_> This place seems to be full of developers [14:54:48] _farmax_: it is [14:55:25] (03CR) 10jerkins-bot: [V: 04-1] Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 (owner: 10Thiemo Kreuz (WMDE)) [14:56:54] _farmax_: 200 to be specific + bots too :) [14:58:48] <_farmax_> I actually wanted to know how do the developers manage the memory issues. You build good quality apps but at the end of the day you need that your android apk size must not exceed than certain limits. I always face the issue. How is it that companies having great apps with alot of features manage to shrink down the apk size? [14:58:58] (03PS1) 10Thiemo Kreuz (WMDE): Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 [15:00:08] _farmax_: Great question but I'm wondering if it's GCI related [15:00:21] <_farmax_> No its not [15:00:26] _farmax_: While idling for a while, you can ping privately on that let's talk [15:00:38] but here, it's really about GCI for now! [15:00:51] _farmax_: Hope you understand what I mean? :) [15:00:52] <_farmax_> I just wanted to know about it.. And make this 1 hour more fruitful [15:01:06] _farmax_: Sure, you'll know about it! [15:01:33] <_farmax_> how do I ping privately? [15:02:07] 10MediaWiki-Vagrant, 10Scoring-platform-team, 10Patch-For-Review: Clean up ORES vagrant role - https://phabricator.wikimedia.org/T181850#3862683 (10awight) [15:02:56] There are a lot of other great freenode channels related to development where you may ask your questions. For example #android-dev [15:03:08] right click and choose open dialog window its should do the trick [15:03:54] This channel is mainly related to Wikimedia Development questions, but there is some offtopic here sometimes too :) [15:03:58] _farmax_: Hope eisenhaus335 answered your question? :) [15:04:40] (03CR) 10jerkins-bot: [V: 04-1] Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [15:05:42] FlorianSW, hey! could you take a look at my patch? https://gerrit.wikimedia.org/r/#/c/400451/ [15:06:20] hi Albert221! It's already on my list, however, I need to ask for a little bit of patience, though :( Sorry, for the delay! [15:06:48] okay, I just didn't know if you're aware of it :) [15:08:04] (03PS1) 10Thiemo Kreuz (WMDE): Remove @param comments that literally repeat what the code says [core] - 10https://gerrit.wikimedia.org/r/400582 [15:13:53] (03PS1) 10Thiemo Kreuz (WMDE): Remove self-explaining "section heading" comments from classes [core] - 10https://gerrit.wikimedia.org/r/400583 [15:16:13] 10MediaWiki-extensions-Newsletter: Newsletters with non-main-namespace pages don't work correctly - https://phabricator.wikimedia.org/T183752#3862684 (10Pppery) [15:17:23] can i ask for issue on pywikibot here? its still on same organization right? *laugh [15:17:52] eisenhaus335: Yes [15:17:57] but you can also ask on #pywikibot [15:18:23] eisenhaus335: Check this out: https://www.mediawiki.org/wiki/Manual:Pywikibot/Communication [15:18:53] <_farmax_> harshal:Hello [15:19:17] Hello World I am Harshal Mandhare [15:19:36] (03PS1) 10Thiemo Kreuz (WMDE): Simplify documentation headers of includes/widgets/…Widget.php files [core] - 10https://gerrit.wikimedia.org/r/400584 [15:20:54] Harshal: Welcome :) [15:22:05] (03PS1) 10Thiemo Kreuz (WMDE): Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 [15:22:41] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [Unit testing] Add unit tests to Newsletter validations - https://phabricator.wikimedia.org/T183632#3862695 (10Pppery) 05Open>03Resolved Closing task as resolve... [15:25:15] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3862698 (10Glendales) Ok, i found the network tab - but what do I do with it? [15:27:47] (03CR) 10jerkins-bot: [V: 04-1] Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 (owner: 10Thiemo Kreuz (WMDE)) [15:30:39] 10MediaWiki-extensions-Newsletter: Add a way to view the list of subscribers to newsletter - https://phabricator.wikimedia.org/T110192#3862700 (10Pppery) [15:30:42] 10MediaWiki-extensions-Newsletter, 10Google-Code-In-2016: New subpage to list down subscribers for a newsletter - https://phabricator.wikimedia.org/T153639#3862703 (10Pppery) [15:31:00] (03PS1) 10Thiemo Kreuz (WMDE): Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 [15:31:56] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849035 (10Pablo-WMDE) a:05Pablo-WMDE>03None [15:32:21] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862706 (10Reedy) It's nothing to do with MySQL, AFAIK. It's obvious that MW hasn't truncated the string properly, the question is why. What content language is set on the... [15:32:32] (03PS1) 10Thiemo Kreuz (WMDE): Improve (weak and strict) type hints invarious places [core] - 10https://gerrit.wikimedia.org/r/400587 [15:32:41] 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3849035 (10Pablo-WMDE) * made 660px the break point for "Mobile Banner", kept it in the same code PR https://github.c... [15:33:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `updateMainPage` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183620#3862709 (10divadsn) a:03divadsn Will do that :) [15:41:49] (03PS7) 10Thiemo Kreuz (WMDE): Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:42:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:43:08] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862711 (10Izno) >>! In T183733#3862627, @Cyberpower678 wrote: >>>! In T183733#3862625, @Izno wrote: >> I'm sure there's a reason for this request, but what is that reason? > > IABot makes use of these identifiers... [15:43:10] (03CR) 10Thiemo Kreuz (WMDE): "The test failure can not be related as this patch exclusively touches PHPDoc comments." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [15:46:32] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862712 (10Cyberpower678) I believe it does. I believe the global user page is transmitted as wiki text to the local page, and then rendered locally. If I place a working template on my meta template, that doesn'... [15:48:06] wow this seems to be exciting [15:48:36] Harshal: Sure it is :) [15:48:56] Harshal: https://www.mediawiki.org/wiki/New_Developers (if I've not sent to you already). [15:49:16] (03PS2) 10Thiemo Kreuz (WMDE): Cleanup and unify class level PHPDoc blocks [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400580 [15:49:36] (03PS1) 10Pppery: Allow newsletters to have non-mainspace main pages [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) [15:50:22] (03Merged) 10jenkins-bot: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [15:54:20] 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Commons, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3797130 (10Ebe123) I'd be willing to mentor this task. [15:59:12] (03CR) 10jenkins-bot: Simplify autocomplete attribute in HTMLForm [core] - 10https://gerrit.wikimedia.org/r/280938 (owner: 10Gerrit Patch Uploader) [16:10:55] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862083 (10matmarex) You can already use `{{SERVERNAME}}`, "en.wikipedia.org" is probably more useful than "enwiki" for most cases anyway. https://www.mediawiki.org/wiki/Help:Magic_words#Technical_metadata This wi... [16:12:12] 10MediaWiki-Parser: Add a magic word to expose wiki ID - https://phabricator.wikimedia.org/T183733#3862723 (10Cyberpower678) >>! In T183733#3862720, @matmarex wrote: > You can already use `{{SERVERNAME}}`, "en.wikipedia.org" is probably more useful than "enwiki" for most cases anyway. https://www.mediawiki.org/w... [16:24:05] Albert221: looking at https://codein.withgoogle.com/dashboard/task-instances/5993528326881280/ now, sorry for the delay! :] [16:30:41] (03CR) 1001tonythomas: "Can you add a unit test which verify the same ?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:32:16] Harshal: Welcome :) [16:32:23] (03CR) 10Ladsgroup: [C: 032] Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [16:32:52] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improve visual hierarchy on Newsletter page (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [16:33:59] (03CR) 10Ladsgroup: [C: 032] Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:34:25] okay FlorianSW, you there? I'll tel you why's this and that [16:34:40] I'm here, Albert221 :) [16:35:15] So my question was what benefits do we get from irc chats ? [16:35:48] so about your css comment: I'd like to, but line-height wouldn't work if I had used selector proposed by you, because specificity of the other, OOUI selector that has line-height was higher [16:35:57] so I had to use that specific selector :( [16:36:02] Being able to communicate efficiently, Harshal [16:36:04] as it is written in the comment line above [16:36:24] <_farmax_> This place is awesome [16:36:41] <_farmax_> You can clarify your coding related doubts [16:36:46] IRC is very open for anyone [16:37:00] okay [16:37:13] to the comment whether that change was intentional, yes, it was, I had to remove actions from breadcrumbs because they were repeated, once in breadcrumbs and once like 10px below it [16:37:19] (03CR) 10Ladsgroup: [C: 032] Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [16:37:45] farmax u still here [16:38:20] (03CR) 10Ladsgroup: [C: 032] Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [16:38:31] and yes, class is actually used, in this big selector, I could theoretically remove it, but that would make specificities of my selector and OOUI one the same and I don't know if that would be behaviour we could be 100% sure it would work [16:38:59] <_farmax_> Yup. here Harshal [16:39:12] (03Merged) 10jenkins-bot: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [16:39:33] (03CR) 10Pppery: "The code with which I'm making changes to has no tests at all to begin with, so it's not exactly clear where I should put such a test." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:39:57] _farmax_ are you already know you can use tab to automatically tag someone... maybe "tagging" [16:40:10] So what does Magic word means, its a pretty catchy word : ) [16:40:32] (03PS4) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) [16:40:37] (03CR) 10Ladsgroup: "Done :)" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [16:41:13] (03CR) 10jerkins-bot: [V: 04-1] Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:42:25] (03CR) 10Ladsgroup: [C: 032] "Kicking jenkins" [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:43:38] <_farmax_> Any bot here? [16:44:04] Harshal, magic words are special words that MediaWiki associates with a return value or function, such as time, site details, or page names [16:44:04] _farmax_: yes! many [16:44:11] wikibugs is one of them :) [16:44:18] wm-bot too [16:44:58] ooh [16:45:18] (03Merged) 10jenkins-bot: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [16:45:20] so here ur trying to get Wiki ID in return??? [16:46:49] <_farmax_> What decides the priority for a bot to reply [16:47:05] (03CR) 1001tonythomas: "Ideally, it should go to mediawiki-extensions-Newsletter/tests/content/" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400589 (https://phabricator.wikimedia.org/T183752) (owner: 10Pppery) [16:47:11] <_farmax_> As In how does the bot get to know that he has to reply [16:47:23] uploading to gerrit sure case-sensitive when testing on flask8. i am just leave a single whitespace and its being fail and i need to commit again [16:47:36] mayb soe specific words triggers the bot [16:47:47] (03Merged) 10jenkins-bot: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [16:48:54] <_farmax_> Ofcourse.. that what even I feel.. But may be its not that easy [16:49:13] FlorianSW, what do you think of what I wrote? [16:50:13] Some bots are triggered due to certain activities [16:50:23] Like phabricator ticket changes, gerrit patch uploads etc... [16:50:59] Albert221: sorry, haven't seen that, I'm currently in a call, will look at it again later. Sorry again for that delay :( [16:51:02] ooh [16:51:28] okay okay [16:51:29] (03PS2) 10Pppery: Update i18n messages using old "view subscribers" terminology [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/331202 [16:51:46] <_farmax_> d3r1ck: Great! [16:51:56] :) [16:52:18] So are we disturbing this IRC chat because right now many developers are working and communicating over here [16:53:22] Kinda [16:53:40] (03Merged) 10jenkins-bot: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [16:53:48] Harshal: http://www.catb.org/esr/faqs/smart-questions.html (to keep in mind) [16:55:08] Hello back everyone :) [16:55:27] wait wut? hello back [16:55:34] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [16:55:49] And hi Albert221, refeed[m], d3r1ck :D [16:55:59] hello divadsn! [16:56:03] eisenhaus335, I took a break for the last 2 days ^^ [16:56:42] divadsn: hello :D [16:56:46] no the grammar is wrong on many way lol. welcome again to our daily life [16:57:15] eisenhaus335 lmao, at least it's understandable :P [16:57:56] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Generalize wording of audio formats in the code - https://phabricator.wikimedia.org/T183753#3862728 (10Ebe123) p:05Triage>03Normal [16:58:16] And I got my hands on my new Chromebook, tbh Google has improved a lot in ChromeOS, so I am not sure about using Linux instead :D [17:00:56] (03CR) 10Ladsgroup: "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [17:01:29] divadsn: Hey! [17:01:59] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Generalize wording of audio formats in the code - https://phabricator.wikimedia.org/T183753#3862739 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/6221738243260416/ [17:02:24] eisenhaus335: Daily life? :D [17:02:34] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862741 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/4771869758586880/ [17:02:44] divadsn: Ohh nice :) [17:03:07] 10MediaWiki-File-management, 10MediaWiki-Special-pages, 10Commons, 10Multimedia, and 2 others: Add the file hash value (sha1) to the action=info page for files uploaded in MediaWiki - https://phabricator.wikimedia.org/T181651#3862743 (10Ebe123) https://codein.withgoogle.com/dashboard/tasks/5677924248190976/ [17:03:50] (03CR) 10jenkins-bot: Add @coversNothing in places where @covers does not apply [core] - 10https://gerrit.wikimedia.org/r/400492 (owner: 10Legoktm) [17:07:09] joining GCI adding my meme "developer" collection. missing whitespace will ruin your day [17:07:23] 10MediaWiki-extensions-Newsletter, 10Patch-For-Review: Newsletters with non-main-namespace main pages don't work correctly - https://phabricator.wikimedia.org/T183752#3862745 (10Pppery) [17:10:19] 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862746 (10Kghbln) > It's nothing to do with MySQL, AFAIK. It's obvious that MW hasn't truncated the string properly, the question is why. Ah, ok. No worries. I trust your... [17:10:23] (03CR) 10Brian Wolff: "tbh, I'm undecided if removing these is actually best" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [17:13:11] (03CR) 10jenkins-bot: Add @covers tags to miscellaneous tests (#2) [core] - 10https://gerrit.wikimedia.org/r/400486 (owner: 10Legoktm) [17:14:00] (03CR) 10Brian Wolff: "Well this is correct that there is no need to escape quotes, is there really any benefit here? Using ENT_NOQUOTES means that reviewers hav" [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [17:21:52] (03CR) 10jenkins-bot: Add @covers tags to languages tests [core] - 10https://gerrit.wikimedia.org/r/400487 (owner: 10Legoktm) [17:25:32] 10Google-Code-in-2017: Convert MediaWiki Templates on Commons to make them Translateable - https://phabricator.wikimedia.org/T179225#3862747 (10Aklapper) I think both could be fine, however I simply would not know how to //identify// templates //in need// of being marked as translatable. That should be covered i... [17:30:33] (03CR) 10jenkins-bot: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [17:31:29] Albert221: is the line height really that important? [17:31:52] 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3862748 (10Isarra) @grey-bright is what is used for image borders in thumbs. It should be the same. Whether or not the value is too light in general is a separa... [17:32:11] theoretically no, I can achieve same results using margin [17:32:48] Albert221: because I really do not like the chained css selector :/ If we can get rid of it using margins I would be really happy :) [17:32:49] ok, I convinced myself to fix that! :D [17:33:57] (03CR) 10Florianschmidtwelzow: [C: 04-1] Improve visual hierarchy on Newsletter page (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:34:02] :P [17:34:08] Albert221: ^ (comment in gerrit) :) [17:35:35] FlorianSW, yes it is related to task! [17:35:47] T180982 look at the last point! [17:35:47] T180982: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982 [17:36:10] oh come on :D Damn, sorry for that, I missed that point :P [17:40:42] D100 Missing docstring in public module [17:40:43] D100: Make anyone know where to find docstring? its not module when i am search it [17:41:13] Harshal: On it :) [17:42:58] FlorianSW, pushing the changes! [17:43:16] (03PS2) 10Albert221: Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) [17:43:24] :) [17:43:52] eisenhaus335: docstring is just a description of what your function does. [17:43:55] eisenhaus335 I think that "docstring" is for phpDoc [17:44:03] that is for example this: [17:44:13] /** [17:44:15] * [17:44:24] * @param string Some param name [17:44:27] */ [17:44:34] 10Wiki-Loves-Monuments (2017): Move WLM-IL tasks to Wikidata - https://phabricator.wikimedia.org/T183713#3862750 (10eranroz) >>! In T183713#3861489, @LilyOfTheWest wrote: > Can you also check if Wikidata already has a property corresponding to your monuments? Can you please clarify what kind of property we are... [17:44:39] ^this is doctrings I suppose [17:44:43] Albert221: eisenhaus335 needs docstring for python [17:44:47] oh, nvm [17:44:59] same but prefixed with: """ ? [17:45:10] Yes: [17:45:16] Albert221: yup [17:45:23] def function(params): [17:45:27] this may helps http://www.pythonforbeginners.com/basics/python-docstrings [17:45:34] """Description...""" [17:46:32] thanks. let see what will happend [17:48:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982#3862751 (10Florian) That's the result of the patch: {F12107908} [17:49:12] (03CR) 10Florianschmidtwelzow: [C: 032] Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:49:22] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982#3862752 (10Florian) 05Open>03Resolved a:03Florian [17:49:29] Albert221: can you submit your GCI task, as well? :) [17:50:08] FlorianSW I'll think about that :D [17:50:19] :P [17:50:48] (03Merged) 10jenkins-bot: Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) (owner: 10Albert221) [17:59:17] (03PS2) 10Ladsgroup: Update model version when it's different in ScoreParser [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) [17:59:34] (03CR) 10Ladsgroup: "Tests added" (034 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400183 (https://phabricator.wikimedia.org/T183468) (owner: 10Ladsgroup) [18:12:42] Albert221: Think? :D [18:13:33] 10Research, 10Research-management: Baha: Systems and programs onboarding - https://phabricator.wikimedia.org/T183754#3862759 (10DarTar) [18:13:43] 10Research, 10Research-management: Baha: Systems and programs onboarding - https://phabricator.wikimedia.org/T183754#3862774 (10DarTar) p:05Triage>03Normal [18:14:57] _farmax_: Hey! You're good to go [18:19:20] (03PS1) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [18:20:46] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:20:56] farmax_: Hey, i'm getting confused! Your irc nicks are too many :) [18:21:17] Has your first ask been approved? farmax_? [18:23:08] 10Research, 10Research-management, 10Research-outreach, 10Epic: Subdomain and hosting for research landing page - https://phabricator.wikimedia.org/T179871#3862778 (10DarTar) a:05DarTar>03bmansurov [18:28:12] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:31:14] hey! I'm writing a message to GCI with suggestions about Google Code-In website. do you have any suggestions from yourself that you'd want me to include? :) divadsn Phantom42 refeed[m] [18:32:50] Albert221: I don't have any suggestions. It is slow sometimes but I am fine with that. Anyway, I will think and let you know if I have any ideas [18:33:54] And by the way, you may ask mentors too :) [18:37:25] (03CR) 10Divadsn: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [18:38:06] (03PS2) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [18:41:49] (03Draft1) 10Addshore: Revert "[MCR] Add optional $title param to Revision byId methods" [core] - 10https://gerrit.wikimedia.org/r/400602 (https://phabricator.wikimedia.org/T183505) [18:43:09] (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [18:43:21] (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400575 (owner: 10Thiemo Kreuz (WMDE)) [18:44:35] (03PS2) 10Thiemo Kreuz (WMDE): Remove very, very old disabled test cases and todos [core] - 10https://gerrit.wikimedia.org/r/400585 [18:44:51] (03PS1) 10Addshore: Revert "Pass a Title to Revision::newFromId in onRevisionInsertComplete" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400603 [18:45:36] (03PS2) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [18:49:08] (03CR) 10jerkins-bot: [V: 04-1] Remove some obscure comments [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [18:49:43] (03CR) 10Ppchelko: [C: 031] "LGTM as well" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [18:52:11] (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [18:57:53] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3857804 (10Tgr) Is this (list name uniqueness) something that should be enforced... [18:58:39] hey! [18:58:55] RootKlawiter: Welcome back! [18:59:15] I made two Discord bots [18:59:19] one as a lawyer [18:59:26] one as a teacher for coders [19:00:53] RootKlawiter: Hello :) [19:01:10] I saw that you starred bot of my friends d3r1ck [19:01:18] nice! [19:01:23] hello anyway [19:01:32] Sure! I love showing appreciation for work done :) [19:01:41] :) [19:01:55] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [19:02:47] do you know that smroot bot have my quotes? :P [19:03:21] (03PS1) 10Thiemo Kreuz (WMDE): Improve 1-letter variable names in MutableContext and implementations [core] - 10https://gerrit.wikimedia.org/r/400606 [19:03:39] RootKlawiter: Nope I don't! [19:03:45] So which task are you working on please? [19:05:17] now I'm building a website for Hackintosh Poland team [19:05:29] and trying to improve my bots [19:09:02] 10MediaWiki-extensions-InputBox, 10UI-Standardization, 10Google-Code-in-2017: Convert InputBox to use OOUI where possible - https://phabricator.wikimedia.org/T106948#3862791 (10matmarex) I don't think it makes sense to convert only one of the many forms. Using OOUI instead of plain HTML elements d... [19:09:36] (03CR) 10Thiemo Kreuz (WMDE): "I'm happy to revert individual lines if you think it's better to keep some of these comments. (TBH, I will most probably write an actual c" [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [19:11:36] (03CR) 10Thiemo Kreuz (WMDE): "I get a weird error message about Phan in an unrelated patch now, see I9c128f7. Can you tell me what's going on there, or help me fix this" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:13:29] (03PS3) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:14:35] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:15:31] (03PS4) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:15:50] (03PS1) 10Thiemo Kreuz (WMDE): Remove leading backslashes from "use \…" tags [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400607 [19:16:23] (03CR) 10Phantom42: [C: 031] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:16:51] (03Draft1) 10Addshore: Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" [core] - 10https://gerrit.wikimedia.org/r/400604 [19:16:56] (03CR) 10Addshore: [V: 031] Revert "[MCR] Add and use $title param to RevisionStore getPrevious/Next" [core] - 10https://gerrit.wikimedia.org/r/400604 (owner: 10Addshore) [19:17:01] (03CR) 10Addshore: [V: 031] Revert "[MCR] Add optional $title param to Revision byId methods" [core] - 10https://gerrit.wikimedia.org/r/400602 (https://phabricator.wikimedia.org/T183505) (owner: 10Addshore) [19:17:02] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:17:11] (03CR) 10Addshore: [V: 031] [MCR] pass $queryFlags into RevisionStore::getTitle [core] - 10https://gerrit.wikimedia.org/r/400577 (https://phabricator.wikimedia.org/T183716) (owner: 10Addshore) [19:18:05] (03PS2) 10Addshore: [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 [19:19:35] (03CR) 10Phantom42: "The problem is that change I4cc1fab which added phan checks to zuul is already merged, while this one, which adds needed config and fixes " [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [19:19:38] (03CR) 10Divadsn: "Ok, let me see later why it fails" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:23:56] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:24:05] (03CR) 10jerkins-bot: [V: 04-1] [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 (owner: 10Addshore) [19:24:51] Mentors for OpenWisp task Google Code In? [19:25:55] (03PS3) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) [19:26:11] farmax: Can you rephrase your question? [19:29:10] (03PS5) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:29:15] (03CR) 10Divadsn: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:29:38] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Brian, I understand the concern and find it very valid, but unfortunately can't see how it applies here. These two methods don't return an" [core] - 10https://gerrit.wikimedia.org/r/390223 (owner: 10Fomafix) [19:30:00] (03PS6) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:30:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [19:31:29] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:31:56] (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [19:32:14] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400607 (owner: 10Thiemo Kreuz (WMDE)) [19:34:53] Albert221, push notifications in browser, else nothing more :P [19:36:29] (03CR) 10Phantom42: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:37:01] legoktm: Hi! Around? [19:38:38] (03PS7) 10Divadsn: Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) [19:41:47] (03CR) 10Divadsn: "Anyway, thanks Phantom42 :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:43:08] (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Clean up ThresholdLookup, make the cache key use model version (033 comments) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) (owner: 10Ladsgroup) [19:44:25] (03CR) 10Phantom42: [C: 031] Unit test NewsletterDb::updateMainPage [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [19:44:50] (03Merged) 10jenkins-bot: Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) (owner: 10Ladsgroup) [19:45:19] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3862798 (10D3r1ck01) [19:46:05] 10MediaWiki-extensions-SendGrid, 10Africa-Wikimedia-Developers: README.md file is too skeletal, needs some updates - https://phabricator.wikimedia.org/T176575#3630149 (10D3r1ck01) >>! In T176575#3858900, @BamLifa wrote: > @D3r1ck01 I am ready to improve the README. Assign it to me @BamLifa, what's your progre... [19:48:41] But I don't expect anything, I filed too many bugs on their issue tracker in Android and still nothing changed ^^ [19:52:20] (03CR) 10Cindy-the-browser-test-bot: [C: 031] "Cindy says good job \o/. Keep it up." [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [19:58:26] (03PS3) 10Addshore: [MCR] Revision::newFromArchiveRow remove recently added $title param [core] - 10https://gerrit.wikimedia.org/r/400605 [20:00:30] (03PS1) 10Ryan10145: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) [20:04:21] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862807 (10Legoktm) For cases where Remex changes the rendering, the "edit" link uses the ParserMigration tool that will show a diff of the current rendering, and the future broken rend... [20:05:48] (03CR) 10Anomie: "I note that the MediaWiki.Commenting.FunctionComment.MissingParamComment phpcs sniff (currently disabled here) complains about the lack of" (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400582 (owner: 10Thiemo Kreuz (WMDE)) [20:06:24] 10MediaWiki-Page-editing, 10MediaWiki-extensions-WikibaseRepository, 10Community-Liaisons, 10Contributors-Team, and 8 others: Re-label the "Save" links to be "Publish" in structured data inline edit links on Wikidata.org - https://phabricator.wikimedia.org/T161367#3862809 (10Lea_Lacroix_WMDE) Announcement... [20:06:43] (03CR) 10Legoktm: [C: 032] "Nice work :)" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:07:49] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862810 (10ssastry) >>! In T183746#3862807, @Legoktm wrote: > For cases where Remex changes the rendering, the "edit" link uses the ParserMigration tool that will show a diff of the cur... [20:08:16] (03Merged) 10jenkins-bot: Fix unintentionally created global functions in EventBusHooks [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:09:14] 10MediaWiki-extensions-Linter: Provide link to (visual?) diff caused by lint errors - https://phabricator.wikimedia.org/T183746#3862812 (10ssastry) >>! In T183746#3862810, @ssastry wrote: >>>! In T183746#3862807, @Legoktm wrote: >> For cases where Remex changes the rendering, the "edit" link uses the ParserMigra... [20:09:33] /ns glist [20:10:16] (03CR) 10Phantom42: "Thank you for reviewing and merging!" [extensions/EventBus] - 10https://gerrit.wikimedia.org/r/400571 (https://phabricator.wikimedia.org/T183730) (owner: 10Phantom42) [20:13:41] 10CirrusSearch, 10Discovery, 10Discovery-Search, 10Easy, and 2 others: Create maintenance script for cleaning up stale indexes - https://phabricator.wikimedia.org/T166243#3862815 (10Smalyshev) > It's unclear to me which codebase this is about, CirrusSearch extension, specifically maintenance scripts. I've... [20:22:25] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862819 (10Phantom42) a:03Phantom42 I will work on this migration! [20:23:52] (03CR) 10Legoktm: [C: 04-1] "Please do not remove copyright statements without the approval of the copyright holders." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400581 (owner: 10Thiemo Kreuz (WMDE)) [20:25:42] Ebe123? :D [20:25:58] Salut divadsn [20:26:17] (03CR) 1001tonythomas: [C: 04-1] "https://phabricator.wikimedia.org/source/mediawiki/browse/master/tests/phpunit/MediaWikiTestCase.php;8eaee6fd06d9089ef90032530af9a9d25a52a" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [20:26:23] O hey Ebe123 ;) [20:26:43] (03CR) 10Legoktm: "Sorry for letting this sit - I'll make sure this gets reviewed/merged today." [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [20:26:44] What's up? [20:28:18] (03CR) 1001tonythomas: [C: 04-1] "recheck" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:29:17] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:29:37] there you go. \ [20:29:45] (03PS2) 10Ryan10145: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) [20:31:03] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:33:30] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks!" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:33:55] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3862827 (1001tonythomas) [20:33:58] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test removePublisher in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183616#3862824 (1001tonythomas) 05Open>03Resolved a:03Ryan10145 Nice one! Thanks. [20:34:15] andre____, FlorianSW, submitted 3 new tasks [20:34:48] in fact, I had new newsletter unit testing tasks in mind - specially the API ones, but sadly - need to wait till weekend [20:35:07] (03Merged) 10jenkins-bot: Unit test NewsletterDb::removePublisher [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400609 (https://phabricator.wikimedia.org/T183616) (owner: 10Ryan10145) [20:35:42] 10MediaWiki-Parser, 10Tracking: HTML validity (tracking) - https://phabricator.wikimedia.org/T2209#3862830 (10divadsn) [20:35:48] 10EasyTimeline, 10Easy, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: Timeline extension error messages should not use deprecated tag - https://phabricator.wikimedia.org/T182968#3862829 (10divadsn) 05Open>03Resolved [20:40:08] tonythomas I have pushed a new unit test on Gerrit :) [20:40:33] divadsn: can you share a link ? [20:40:39] I still need to dig deeper into the docs, I am not used to unit tests :D [20:40:46] One minute, hang on [20:41:41] Oh, I see you left a comment, weird that I haven't received a notification [20:45:47] Albert221: you might be interested by https://phabricator.wikimedia.org/T183736 . It'll be officially posted *sous peu* [20:50:15] 10MediaWiki-Codesniffer: Forbid parse_str() without a second argument - https://phabricator.wikimedia.org/T183739#3862318 (10Umherirrender) Usage: http://codesearch.wmflabs.org/search/?q=parse_str&i=nope&files=&repos= It seems to exists as `mb_parse_str`, too. [20:51:21] (03CR) 10Umherirrender: [C: 031] "I was always wonder, if there are required or not. Should one usage be part of the code style (and codesniffer)?" [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [20:58:36] (03PS1) 1001tonythomas: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 [20:59:46] (03CR) 1001tonythomas: [C: 031] "sadly, this needs to go after https://gerrit.wikimedia.org/r/#/c/400610/ as the API edit was broken sadly :-(" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:00:04] addshore: are you around for a quick review ? [21:00:51] or FlorianSW ? [21:01:08] (single line change actually), well like 3 single lines [21:02:01] tonythomas: too hard to review [21:02:24] ah. look at the Reedy popping up. https://gerrit.wikimedia.org/r/#/c/400610/ one~ [21:02:44] there were some terrible mistakes from the past - since it was only affecting API edit - nobody noticed [21:03:02] `$this->newsletter` there was mostly None :/ [21:03:14] protected $newsletter; /** @var Newsletter */ [21:03:16] Is that unused? [21:03:19] If so, remove it :P [21:03:30] I thought about that. Phpstorm didnt grey it out. strnage [21:03:48] (03PS4) 10Umherirrender: Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 [21:03:52] (03CR) 10Umherirrender: [C: 032] Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 (owner: 10Umherirrender) [21:04:01] find for `$this->newsletter` doesnt say anything found though [21:04:02] so removing [21:04:10] Yeah, ditto [21:04:11] let me do an API edit though. [21:04:20] Might be laggy [21:04:24] (cant trust those functions) [21:04:30] phpstorm does say private $name; /** @var string */ is unused too [21:04:34] (03Merged) 10jenkins-bot: Install mediawiki/maps over composer [extensions/WikivoteMapsYandex] - 10https://gerrit.wikimedia.org/r/393107 (owner: 10Umherirrender) [21:04:46] exactly :P [21:04:49] (03CR) 10Reedy: [C: 04-1] "per irc" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:05:18] (03PS2) 1001tonythomas: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 [21:05:45] okey - API edit works [21:06:59] even normal works. [21:07:01] review ? [21:07:15] (03CR) 1001tonythomas: [C: 031] "Locally tested, works." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:07:28] (03CR) 10Reedy: [C: 032] Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:07:45] yay. [21:08:11] (03PS6) 10Umherirrender: Check if $responseData['responses'] is set before use [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/395883 (https://phabricator.wikimedia.org/T161283) [21:08:20] now ppery should rebase https://gerrit.wikimedia.org/r/#/c/400464 and we should be good to go [21:08:28] (03PS2) 1001tonythomas: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:08:35] in fact, I can rebase [21:08:52] oh damn - that was before the thing got `merged` [21:09:08] (03Merged) 10jenkins-bot: Fix broken API edit after notifyPublishers change [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400610 (owner: 1001tonythomas) [21:09:38] conflicts! :D [21:10:02] (03CR) 10jerkins-bot: [V: 04-1] Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:10:31] Hi guys, I'm Liza and I'm doing this as a task on Google Code-in, I'm re-introducing myself since I forgot to register my account the first time around [21:11:24] Have fun lizaa! [21:13:53] (03PS3) 1001tonythomas: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:15:20] (03CR) 10jerkins-bot: [V: 04-1] Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:15:20] Reedy, mind publishing my tasks? [21:16:21] Done [21:16:29] Thank you! [21:16:51] (03CR) 1001tonythomas: [C: 04-1] "You will have to fix tests now. Something is not working on removal." (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:23:42] (03CR) 10Pppery: "Test failure was caused by a conflict with 8df149be2bc0543af897669f2f3c25c4b3bebeee" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:24:24] Lol, got pinged as "ebe" is in the hash :) [21:24:53] Haha :) [21:27:07] (03PS4) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [21:32:55] 10MediaWiki-extensions-Score, 10Google-Code-in-2017: Create pop-up for scores showing more features - https://phabricator.wikimedia.org/T183736#3862846 (10Albert221) a:03Albert221 [21:41:03] (03PS5) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [21:42:43] (03CR) 10Pppery: Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:43:48] (03CR) 1001tonythomas: [C: 04-1] Unit test NewsletterDb::updateMainPage (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:44:47] (03CR) 10Divadsn: "I am currently not on my dev environment, could someone tell me if UTPage is saved please? :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400600 (https://phabricator.wikimedia.org/T183620) (owner: 10Divadsn) [21:45:10] 10MediaWiki-Codesniffer: Detect global functions definied inside static functions - https://phabricator.wikimedia.org/T183756#3862847 (10Umherirrender) [21:46:48] (03CR) 1001tonythomas: Publisher add/remove functions now take user ids array (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:47:20] (03CR) 1001tonythomas: "recheck" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:51:09] 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3862859 (10Umherirrender) [21:54:43] Ebe123, I've just claimed your task! [21:55:38] (03CR) 1001tonythomas: [C: 04-1] "I get this on an API edit on this branch :-(" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [21:56:36] I see! It should be a simple task, but there may be some intricacies, and a new structure for the HTML is needed. Hope you enjoy! [21:58:13] Ebe123 finally a task where I can create soemthing that will be truly visible on the Wikipedia itself! [21:59:12] I was wondering if those were allowed as I didn't see any listed :) [21:59:38] why couldn't it be allowed?! :D [22:00:12] I was always bragging how one single cog icon for settings on the Wikipedia were made by me in 2014 xD [22:00:18] was* [22:00:42] Reedy: anything you can make out from https://dpaste.de/TDR7/raw ? [22:01:14] tonythomas: ? [22:01:26] I asked the same question. No precedent, so why not? Maybe it would be called "too complex" or something... [22:01:29] that was showing up on APIEdits after https://gerrit.wikimedia.org/r/#/c/400464/5 [22:01:51] like the usualy success response was not showing up [22:02:01] possibly because of those last few lines I guess [22:02:07] The notices? [22:02:10] `rray to string conversion...` [22:02:12] yeah. [22:02:31] (03CR) 10Pppery: "Just to make sure, where is that output displayed?" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:02:32] tonythomas thats the longest paste in the world [22:02:46] tonythomas: yeah, you should've pasted it straight into irc [22:02:53] Lol [22:03:03] Zppix: ahaha. I had even worse ones :P [22:03:07] Reedy: he wouldnt get kicked at all [22:03:25] kicked even before pasting. [22:03:27] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3862860 (10Seb35) @maiden_taiwan: can you try my patch, either downloading it with git or as as .tar file (link “down... [22:04:16] I suspect the query https://gerrit.wikimedia.org/r/#/c/400464/5/includes/NewsletterDb.php though [22:04:17] (03PS3) 10BryanDavis: rake: move test definitions to tests directory [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400201 [22:07:06] (03CR) 1001tonythomas: [C: 04-1] "Special:ApiSandbox and try to action=edit, with title=Newsletter:Foo and content to match a newslettercontent JSON, like:" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:09:34] there is no other way to get better error logs or what actually happened right ? [22:11:29] (03CR) 10Pppery: "Cannot reproduce" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:12:33] (03CR) 1001tonythomas: [C: 04-1] "oh - this is available on the inspector console > networks > check the response of request to api.php." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:17:09] shove an is_array and var_dump at the point it' complaining? [22:17:14] see what was in it [22:22:03] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3862871 (10RHo) + @Fjalepeno @cmadeo Hi @Tgr - this ticket was per my understand... [22:22:56] (03CR) 10Pppery: "Still not seeing this error" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:24:27] Im going to pull my hair out [22:24:40] Never Ever use google cloud and postfix [22:28:02] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862877 (10Phantom42) I just pushed a change to translatewiki.net repo. That patch removes... [22:33:52] (03PS6) 10Pppery: Publisher add/remove functions now take user ids array [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) [22:34:51] how can I disable Parsoid so that I will be able to use VisualEditor without it? [22:35:20] 10MediaWiki-extensions-HitCounters, 10Patch-For-Review: NUMBEROFVIEWS variable throws HitCounters error, "numberOfViews() expected to be a reference" - https://phabricator.wikimedia.org/T142127#3862881 (10maiden_taiwan) Works for me! Thanks so much, @Seb35!! [22:35:35] I think VisualEditor cannot be used without Parsoid [22:36:42] (03CR) 10Pppery: "Fixes one case I forgot to fix before, which previously broke newsletter creation via API" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400464 (https://phabricator.wikimedia.org/T183658) (owner: 10Pppery) [22:39:11] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862882 (10Phantom42) And I pushed a second patch (to Translate extension) which changes de... [22:40:20] 10MassMessage, 10Outreachy (Round-15), 10Patch-For-Review: [Outreachy/Round 15] Proposal : Refactoring the MediaWiki MassMessage Extension - https://phabricator.wikimedia.org/T178215#3862883 (10Noella94) [22:42:39] (03CR) 10Ladsgroup: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [22:44:10] Albert221: parsoid must be used if your wanting visualeditor [22:45:04] 10Reading Epics (Synchronized Reading Lists), 10Wikipedia-Android-App-Backlog (Android-app-release-v2.7.23x-G): Change the user-created list name if it the same name as the default list - https://phabricator.wikimedia.org/T183588#3862901 (10Tgr) Current server behavior is to identify the lists by ID (which is... [22:47:31] 10MediaWiki-Special-pages, 10Collaboration-Team-Triage, 10TechCom-RfC, 10Patch-For-Review: Introduce article creation log - https://phabricator.wikimedia.org/T12331#3862903 (10kaldari) @WMDE-leszek fixed it! @daniel: Do you still want to have an IRC meeting about this? There's clearly desire for this from... [22:49:35] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/CirrusSearch] - 10https://gerrit.wikimedia.org/r/400576 (https://phabricator.wikimedia.org/T183096) (owner: 10Thiemo Kreuz (WMDE)) [22:51:08] 10MediaWiki-extensions-Translate, 10translatewiki.net, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review: Migrate default GettextFFS keyAlgorithm default value to simple - https://phabricator.wikimedia.org/T178882#3862907 (10Phantom42) I checked #mediawiki_language_extension_bundle and #release workboard... [22:57:27] Ebe123, I got an issue with Score extension BTW [22:57:35] Explain [22:57:46] or rather the \MediaWiki\Shell\Shell::command() on Windows [22:57:55] it wrongly executes command [22:58:14] I had to edit the vendor file so it could work: https://i.imgur.com/eleTssB.png [22:58:15] Which command? [22:58:35] this is the error I got before editing it: https://i.imgur.com/HO6BMDv.png [22:59:08] You're not using Vagrant? [22:59:16] nope, XAMPP [22:59:17] https://www.mediawiki.org/wiki/MediaWiki-Vagrant [22:59:43] okay, so it isn't just meant to be run on Windows, right? [22:59:58] That looks like a bug [23:00:28] the quotes are messed up [23:00:29] Shgould work on Windows though [23:01:07] The quotes are fine in the code [23:02:57] Seems like a Core bug, but it does work under Vagrant [23:03:15] I can look closer at that tomorrow [23:03:37] Ebe123, tell me one thing, do I have to write whole popup by myself or is there any library for popups or anything? :) [23:03:47] if there is any place where to start [23:03:47] 10MediaWiki-extensions-ORES, 10ORES, 10Scoring-platform-team (Current), 10User-Ladsgroup: Wikidata beta edit filters are showing every edit in watchlist as damaging - https://phabricator.wikimedia.org/T180686#3766448 (10Ladsgroup) 05Open>03Resolved [23:04:24] I don't know of any MediaWiki library for pop-ups [23:05:30] It could also be in the form of a onclick tooltip, just attached to the score, or MediaViewer-esque [23:08:37] I'll try and do my best c: [23:08:48] this popup should include download button for midi and source code for it, right? [23:10:54] Yes. Focus on just MIDI for now, as the source would be harder to fetch [23:11:12] I'm writing a bug report about score-versionerr now [23:12:21] (03CR) 10Ladsgroup: Use ExtensionRegistry instead of class_exists (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:12:38] (03PS4) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) [23:14:59] 10MediaWiki-Shell, 10MediaWiki-extensions-Score: MediaWiki::shell with parameter fails on Windows - https://phabricator.wikimedia.org/T183759#3862943 (10Ebe123) [23:19:23] 10MediaWiki-Shell, 10MediaWiki-extensions-Score: MediaWiki::shell with parameter fails on Windows - https://phabricator.wikimedia.org/T183759#3862955 (10Ebe123) p:05Triage>03High `Shell::command( $wgScoreLilyPond . '--version' )` works (notice concatenation instead of parametration) on Windows. [23:34:02] I'm samspeiol on the IRC for a Google Code-in task [23:34:29] samspeiol: Welcome! Good luck with your GCI tasks! [23:34:49] Which country are you from, samspeiol? :) [23:34:58] Thanks, you too! [23:41:47] (03CR) 10Legoktm: [C: 032] "I can't think of a reason they'd ever be needed...if there are none, I think we should add it to MW-CS." [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [23:42:36] (03CR) 10Legoktm: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:43:22] (03CR) 10Legoktm: [C: 032] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:48:22] (03Merged) 10jenkins-bot: Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE)) [23:48:48] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:50:26] (03Merged) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:53:03] (03CR) 10jenkins-bot: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [23:53:15] 10Wiki-Setup (Create): Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861294 (10Baloch007) After four months of work and 1,848 edits (150 pages) I think we deserve our own wiki. Because only in Afghanistan and Pakistan there is more than 50 million people's who speaks Pashto as there moth... [23:58:56] (03CR) 10jenkins-bot: Remove leading backslashes from "use \…" tags [core] - 10https://gerrit.wikimedia.org/r/400586 (owner: 10Thiemo Kreuz (WMDE))