[00:11:23] (03PS1) 10Umherirrender: build: Run phplint for inc files [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 [00:16:25] (03PS1) 10Umherirrender: build: Run phplint for inc files [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/400262 [00:35:01] (03CR) 10Huji: [C: 032] build: Run phplint for inc files [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/400262 (owner: 10Umherirrender) [00:36:44] (03Merged) 10jenkins-bot: build: Run phplint for inc files [extensions/SecurePoll] - 10https://gerrit.wikimedia.org/r/400262 (owner: 10Umherirrender) [01:06:11] 10MediaWiki-Database, 10MediaWiki-Platform-Team (MWPT-Q3-Jan-Mar-2018), 10Epic, 10MW-1.30-release-notes (WMF-deploy-2017-07-11_(1.30.0-wmf.9)), 10Patch-For-Review: Refactor "user" & "user_text" fields into "actor" reference table - https://phabricator.wikimedia.org/T167246#3321938 (10GeoffreyT2000) With... [01:17:13] 10MediaWiki-extensions-NewUserMessage, 10TestMe: Minor edit of bots on the user talk pages doesn't change the notification and talk label to orange - https://phabricator.wikimedia.org/T62763#3861332 (10Peachey88) [01:20:11] 10MediaWiki-extensions-NewUserMessage, 10TestMe: Minor edit of bots on the user talk pages doesn't change the notification and talk label to orange - https://phabricator.wikimedia.org/T62763#676027 (10Luke081515) I'd say this is expected? Bots have: `Not have minor edits to discussion pages trigger the new mes... [01:55:07] Albert221, try mw.config.get maybe? [01:55:43] https://www.mediawiki.org/wiki/Manual:Interface/JavaScript [02:05:09] (03PS1) 10Umherirrender: Add grep comment for js vars wgRestriction* [core] - 10https://gerrit.wikimedia.org/r/400265 [02:17:51] 10MediaWiki-Page-protection, 10MediaWiki-extensions-EducationProgram, 10Ladies-That-FOSS-MediaWiki, 10Easy, and 3 others: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#3861359 (10Umherirrender) According to Title::getFilteredR... [02:19:41] (03CR) 10Umherirrender: [C: 04-1] "I have add a comment on the task for another solution." [core] - 10https://gerrit.wikimedia.org/r/400134 (https://phabricator.wikimedia.org/T133289) (owner: 10Divadsn) [02:25:21] hello [02:25:40] i am here for GCI a competition for google [02:25:47] google code in [02:33:42] (03CR) 10TerraCodes: [C: 04-1] "in the patch, it says" [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) (owner: 10Eugene233) [02:38:43] (03CR) 10Jdlrobson: "Note this will break the styles for printed pages which have cached HTML page views so re-reverting this and fixing this should be conside" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [02:55:29] hi i am SwagKEEEED [02:56:11] anyone? [02:56:22] lol [02:56:52] Yes SwagKEEED [02:56:58] ? [02:57:55] i dont know [02:59:45] GCI? [03:00:05] Google Code In :) [03:00:13] hey swagkeed! [03:00:23] and Ebe123, I'm going to sleep :) [03:00:45] good night Albert221 [03:16:39] 10Accessibility, 10OOjs-UI, 10I18n: Consider adding `` element, ARIA `role=img` and `aria-labelledby` attributes to OOjs UI's icon SVGs - https://phabricator.wikimedia.org/T157836#3861368 (10Prtksxna) #patch-for-review at https://gerrit.wikimedia.org/r/#/c/400091/? [03:26:12] <wikibugs> 10MediaWiki-Parser, 10Epic: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - https://phabricator.wikimedia.org/T14974#3861369 (10Od1n) I would suggest "normal" priority. This issue gives template editors... [03:37:19] <wikibugs> 10MediaWiki-Recent-changes: Test wiki filtering option no longer available in Incubator Recent Changes - https://phabricator.wikimedia.org/T183709#3861371 (10Yair_rand) [03:48:05] <wikibugs> 10Design, 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review, 10WorkType-NewFunctionality: Improve the New Translation dialog to easily find articles to translate - https://phabricator.wikimedia.org/T111094#3861383 (10Petar.petkovic) [04:06:17] <wikibugs> 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3861385 (10jayvdb) Repeating some of what I put into the code review of https://github.com/python-social-auth/social-core/pull/169 I suspect that the default OAuth scope is actua... [05:29:28] <wikibugs> (03CR) 10Bartosz Dziewoński: "Sorry, and thank you for fixing this!" [skins/Vector] - 10https://gerrit.wikimedia.org/r/399802 (https://phabricator.wikimedia.org/T183442) (owner: 10Petar.petkovic) [05:33:15] <wikibugs> (03PS4) 10Bartosz Dziewoński: OOjs UI: Fix z-index and font size for default overlay [skins/Vector] - 10https://gerrit.wikimedia.org/r/398199 (https://phabricator.wikimedia.org/T183069) [05:46:11] <wikibugs> 10Wikimedia-Site-requests: Request new namespace aliases for "User:", "File:" and their talk page spaces on zh wikipedia - https://phabricator.wikimedia.org/T183711#3861408 (10RanD) [06:38:46] <refeed[m]> Good morning! [06:39:44] <PriyanshuAhuja_> Hi this is Priyanshu Ahuja joined IRC for Google Code in. Thanks. [06:43:29] <refeed[m]> PriyanshuAhuja_: Welcome! [07:02:31] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861425 (10Pine) 05Invalid>03Open I appreciate WMF staff working on this during what I think is supposed to be their winter break. :) Unless I'm misunderstanding somet... [07:06:31] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861429 (10Pine) @Doc_James perhaps it would be good to make the title of this ticket more general to reflect that the source of the problem is currently unknown and might... [07:20:30] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861432 (10Doc_James) Thanks Pine. Yes it is not really related to WikEd. WikEd just reveals a problem created by something else. I suspect it is VE. [08:06:57] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3859366 (10matmarex) You can type non-breaking spaces on Mac just by pressing Option+Space. You can't insert non-breaking spaces in VE, even if you wanted to ({T96701}), s... [08:33:17] <wikibugs> 10Epic, 10Wiki-Loves-Monuments (2017): Move WLM monuments data to Wikidata - https://phabricator.wikimedia.org/T183712#3861460 (10LilyOfTheWest) [08:33:33] <wikibugs> 10Epic, 10Wiki-Loves-Monuments (2017): Move WLM monuments data to Wikidata - https://phabricator.wikimedia.org/T183712#3861460 (10LilyOfTheWest) p:05Triage>03Normal [08:36:21] <wikibugs> 10Connected-Open-Heritage-Wikidata-migration (Ir_fa), 10Wiki-Loves-Monuments (2017): Move WLM-IR data to Wikidata - https://phabricator.wikimedia.org/T174966#3861472 (10LilyOfTheWest) [08:36:23] <wikibugs> 10Wiki-Loves-Monuments (2017): Move WLM-SK lists to Wikidata - https://phabricator.wikimedia.org/T173007#3861473 (10LilyOfTheWest) [08:36:25] <wikibugs> 10Connected-Open-Heritage-Wikidata-migration (ve-es), 10Wiki-Loves-Monuments (2017): Move WLM-VE lists to Wikidata - https://phabricator.wikimedia.org/T172483#3861474 (10LilyOfTheWest) [08:36:28] <wikibugs> 10Connected-Open-Heritage-Wikidata-migration (ge-ka), 10Wiki-Loves-Monuments (2017): Move WLM-GE lists to Wikidata - https://phabricator.wikimedia.org/T172053#3861475 (10LilyOfTheWest) [08:36:30] <wikibugs> 10Epic, 10Wiki-Loves-Monuments (2017): Move WLM monuments data to Wikidata - https://phabricator.wikimedia.org/T183712#3861471 (10LilyOfTheWest) [08:37:40] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861476 (10Doc_James) Okay I have just verified that it is a problem with VE. VE is adding these non breaking spaces per here https://en.wikipedia.org/wiki/Wikipedia:Villa... [08:39:44] <wikibugs> 10Wiki-Loves-Monuments (2017): Move WLM-IL tasks to Wikidata - https://phabricator.wikimedia.org/T183713#3861477 (10LilyOfTheWest) p:05Triage>03Normal [08:44:21] <wikibugs> 10Wiki-Loves-Monuments (2017): Move WLM-IL tasks to Wikidata - https://phabricator.wikimedia.org/T183713#3861489 (10LilyOfTheWest) @eranroz Can you link to where the WLM-IL monuments lists are located right now in the task description? Can you also check if Wikidata already has a property corresponding to your m... [08:50:42] <wikibugs> 10OOjs-UI: grunt-image 4 doesn't work on local machine - https://phabricator.wikimedia.org/T179992#3743032 (10matmarex) It doesn't work for me either, with a different error: ``` Warning: Command failed: F:\mediawiki\oojs\ui\node_modules\grunt-image\node_modules\zopflipng-bin\vendor\zopflipng.exe -y --lossy_8bit... [09:06:10] <wikibugs> (03PS3) 10Bartosz Dziewoński: Fix 'flow_topic_list' table to use non-nullable fields in the primary key [extensions/Flow] - 10https://gerrit.wikimedia.org/r/364289 [09:10:41] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400270 (owner: 10L10n-bot) [09:11:58] <wikibugs> (03PS3) 10Bartosz Dziewoński: Use PHP 7 '??' operator instead of '?:' with 'isset()' where convenient [core] - 10https://gerrit.wikimedia.org/r/382902 [09:12:35] <wikibugs> (03PS3) 10Bartosz Dziewoński: Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 [09:12:45] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 '??' operator instead of '?:' with 'isset()' where convenient [core] - 10https://gerrit.wikimedia.org/r/382902 (owner: 10Bartosz Dziewoński) [09:13:33] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 (owner: 10Bartosz Dziewoński) [09:17:59] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/400271 (owner: 10L10n-bot) [09:34:59] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/Flow] - 10https://gerrit.wikimedia.org/r/400302 (owner: 10L10n-bot) [09:35:35] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] @parma -> @param in javascript [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/400254 (owner: 10Umherirrender) [09:36:48] <wikibugs> (03PS2) 10Thiemo Kreuz (WMDE): @parma -> @param in javascript [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [09:37:28] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400310 (owner: 10L10n-bot) [09:37:38] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861510 (10Pablo-WMDE) WIP PR https://github.com/wmde/fundraising-banners/pull/102 [09:38:25] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] @parma -> @param in javascript (032 comments) [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [09:39:01] <wikibugs> 04(no projects): disks behind a number of templates in mac/chrome in enwiki - https://phabricator.wikimedia.org/T182551#3861511 (10Aklapper) 05stalled>03declined Unfortunately closing this report as no further information has been provided. @Effeietsanders: After you have provided the information asked for... [09:39:44] <wikibugs> (03PS2) 10Bartosz Dziewoński: Use PHP 5.6 constant expressions for some bitfield constants [core] - 10https://gerrit.wikimedia.org/r/382899 [09:39:46] <wikibugs> (03PS2) 10Bartosz Dziewoński: Use PHP 5.6 '**' operator instead of 'pow()' function [core] - 10https://gerrit.wikimedia.org/r/382900 [09:39:48] <wikibugs> (03PS4) 10Bartosz Dziewoński: Use PHP 7 '<=>' operator in 'sort()' callbacks [core] - 10https://gerrit.wikimedia.org/r/382901 [09:39:50] <wikibugs> (03PS4) 10Bartosz Dziewoński: Use PHP 7 '??' operator instead of '?:' with 'isset()' where convenient [core] - 10https://gerrit.wikimedia.org/r/382902 [09:39:53] <wikibugs> (03PS4) 10Bartosz Dziewoński: Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 [09:40:00] <wikibugs> (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [extensions/MultimediaViewer] - 10https://gerrit.wikimedia.org/r/400312 (owner: 10L10n-bot) [09:41:15] <wikibugs> (03PS3) 10Thiemo Kreuz (WMDE): @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [09:41:19] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [09:41:52] <wikibugs> (03Merged) 10jenkins-bot: @parma -> @param in javascript [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/400254 (owner: 10Umherirrender) [09:41:54] <wikibugs> (03Merged) 10jenkins-bot: @parma -> @param in javascript [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [09:43:37] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861513 (10Doc_James) I have started a request for an edit filter to potentially block these edits by VE until VE is fixed. https://en.wikipedia.org/wiki/Wikipedia:Edit_fi... [09:44:25] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Looks good, from what I can see." (031 comment) [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 (owner: 10Umherirrender) [09:45:32] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 5.6 constant expressions for some bitfield constants [core] - 10https://gerrit.wikimedia.org/r/382899 (owner: 10Bartosz Dziewoński) [09:45:43] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Replace create_function by closure (031 comment) [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 (owner: 10Umherirrender) [09:47:18] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Add grep comment for js vars wgRestriction* (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [09:47:45] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 5.6 '**' operator instead of 'pow()' function [core] - 10https://gerrit.wikimedia.org/r/382900 (owner: 10Bartosz Dziewoński) [09:47:48] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3861514 (10Betacommand) >>! In T183647#3861456, @matmarex wrote: > The real bug here is that WikEd converts normal non-breaking spaces to their HTML entities. This behavio... [09:48:23] <wikibugs> 10Wiki-Loves-Monuments (2017): Move WLM-IL tasks to Wikidata - https://phabricator.wikimedia.org/T183713#3861516 (10eranroz) [09:48:47] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I see at least one .inc file in this repository." [extensions/WikimediaMaintenance] - 10https://gerrit.wikimedia.org/r/400261 (owner: 10Umherirrender) [09:49:39] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 '??' operator instead of '?:' with 'isset()' where convenient [core] - 10https://gerrit.wikimedia.org/r/382902 (owner: 10Bartosz Dziewoński) [09:50:08] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 '<=>' operator in 'sort()' callbacks [core] - 10https://gerrit.wikimedia.org/r/382901 (owner: 10Bartosz Dziewoński) [09:50:58] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Change doc type from DatabaseBase to IDatabase [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/399959 (owner: 10Umherirrender) [09:52:59] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 (owner: 10Bartosz Dziewoński) [09:53:16] <Aaryu> hi [09:53:24] <wikibugs> (03CR) 10Umherirrender: [V: 032] Change doc type from DatabaseBase to IDatabase [extensions/BlueSpiceReaders] - 10https://gerrit.wikimedia.org/r/399959 (owner: 10Umherirrender) [09:56:35] <wikibugs> (03CR) 10Nikerabbit: "Grep is like google nowadays: the meaning has become more general: https://en.wiktionary.org/wiki/grep#Verb" [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [09:56:53] <wikibugs> 10Wikimedia-General-or-Unknown: Hard Spaces added by seemingly unrelated edits performed by WikEd - https://phabricator.wikimedia.org/T183647#3859366 (10TheDJ) @Doc_James Please document the browser and the version of the browser you are using.. [09:57:09] <Aaryu> Hi I am Aaryan and joined wikimedia-dev for Google code in task (GCT) [09:57:42] <wikibugs> (03PS5) 10Bartosz Dziewoński: Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 [09:59:25] <Nikerabbit> Albert221: did you solve your issue with DB_REPLICA? [09:59:47] <wikibugs> (03CR) 10Hashar: "Sound good. I would invoke rspec with -I to add /tests/ to LOAD_PATH. This way you don't even have to change the 'require spec-helper' lin" (031 comment) [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400201 (owner: 10BryanDavis) [10:00:03] <wikibugs> (03CR) 10Umherirrender: Replace create_function by closure (031 comment) [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 (owner: 10Umherirrender) [10:00:12] <wikibugs> (03PS6) 10Bartosz Dziewoński: Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 [10:01:58] <wikibugs> 10Wikimedia-General-or-Unknown: Read/View version of VE adds nbsp's when copying from it - https://phabricator.wikimedia.org/T183647#3861523 (10TheDJ) [10:02:43] <wikibugs> 10Wikimedia-General-or-Unknown: Read/View version of VE adds nbsp's when copying from it - https://phabricator.wikimedia.org/T183647#3859366 (10TheDJ) [10:04:36] <wikibugs> (03CR) 10Umherirrender: @parma -> @param in javascript (031 comment) [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [10:07:13] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use PHP 7 "\u{NNNN}" Unicode codepoint escapes in string literals [core] - 10https://gerrit.wikimedia.org/r/382903 (owner: 10Bartosz Dziewoński) [10:10:29] <wikibugs> (03PS4) 10Bartosz Dziewoński: Remove deprecated hook EditPageBeforeEditChecks [core] - 10https://gerrit.wikimedia.org/r/374870 [10:10:44] <wikibugs> 10Wikimedia-General-or-Unknown: Read/View version of VE adds nbsp's when copying from it - https://phabricator.wikimedia.org/T183647#3861527 (10Doc_James) I am using Chrome version 62. [10:10:46] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Remove deprecated hook EditPageBeforeEditChecks [core] - 10https://gerrit.wikimedia.org/r/374870 (owner: 10Bartosz Dziewoński) [10:11:55] <wikibugs> 10Wikimedia-General-or-Unknown: Read/View version of VE adds nbsp's when copying from it - https://phabricator.wikimedia.org/T183647#3861528 (10TheDJ) [10:13:02] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): @parma -> @param in javascript (031 comment) [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [10:15:28] <wikibugs> (03PS6) 10WMDE-leszek: [WIP] Record a log entry on page creation [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [10:16:26] <wikibugs> (03PS7) 10Bartosz Dziewoński: EditPage: Remove methods deprecated since MW 1.30 [core] - 10https://gerrit.wikimedia.org/r/374869 [10:16:28] <wikibugs> (03PS5) 10Bartosz Dziewoński: Remove deprecated hook EditPageBeforeEditChecks [core] - 10https://gerrit.wikimedia.org/r/374870 [10:17:08] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Replace create_function by closure (031 comment) [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 (owner: 10Umherirrender) [10:17:50] <wikibugs> (03Merged) 10jenkins-bot: Replace create_function by closure [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 (owner: 10Umherirrender) [10:20:11] <wikibugs> (03CR) 10WMDE-leszek: "PS6: adjusted tests of watchlist query api, as they are now going to contain page create log entries!" [core] - 10https://gerrit.wikimedia.org/r/399897 (https://phabricator.wikimedia.org/T12331) (owner: 10Kaldari) [10:23:21] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "Sure. But my comment still applies: I don't think it's helpful to mention "grep" in such a comment. We do have some similar comments in th" [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [10:24:13] <wikibugs> (03CR) 10Umherirrender: @parma -> @param in javascript (031 comment) [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 (owner: 10Umherirrender) [10:25:56] <andre__> Hi Aaryu and a belated welcome! :) [10:26:42] <wikibugs> (03PS2) 10Umherirrender: Replace create_function by php function [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 [10:27:44] <wikibugs> (03CR) 10Umherirrender: "Patch Set 2: Addressed comment" [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 (owner: 10Umherirrender) [10:32:07] <wikibugs> (03PS6) 10Bartosz Dziewoński: Special:ProtectedPages: Use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/376710 (https://phabricator.wikimedia.org/T117722) (owner: 10Prtksxna) [10:32:10] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 032] Special:ProtectedPages: Use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/376710 (https://phabricator.wikimedia.org/T117722) (owner: 10Prtksxna) [10:32:49] <wikibugs> 10MediaWiki-Page-protection, 10UI-Standardization: Convert Special:ProtectedPages to OOUI - https://phabricator.wikimedia.org/T117722#3861531 (10matmarex) [10:33:40] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Replace create_function by php function [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 (owner: 10Umherirrender) [10:34:59] <wikibugs> (03CR) 10Umherirrender: "There are some places with "grep": http://codesearch.wmflabs.org/core/?q=grep&i=nope&files=&repos=" [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [10:37:32] <wikibugs> (03CR) 10Nikerabbit: [C: 04-1] Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [10:38:11] <wikibugs> (03Merged) 10jenkins-bot: Special:ProtectedPages: Use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/376710 (https://phabricator.wikimedia.org/T117722) (owner: 10Prtksxna) [10:38:41] <wikibugs> 10ContentTranslation, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)): Fix JQMIGRATE: jQuery.fn.hover() is deprecated in ContentTranslation - https://phabricator.wikimedia.org/T182758#3861533 (10Nikerabbit) [10:39:32] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 04-2] "We should probably get the OOUI release in first." [core] - 10https://gerrit.wikimedia.org/r/398198 (https://phabricator.wikimedia.org/T183069) (owner: 10Bartosz Dziewoński) [10:42:42] <wikibugs> (03Merged) 10jenkins-bot: Replace create_function by php function [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 (owner: 10Umherirrender) [10:43:43] <wikibugs> (03PS2) 10Umherirrender: Add grep comment for js vars wgRestriction* [core] - 10https://gerrit.wikimedia.org/r/400265 [10:50:15] <wikibugs> (03CR) 10jenkins-bot: Special:ProtectedPages: Use HTMLForm [core] - 10https://gerrit.wikimedia.org/r/376710 (https://phabricator.wikimedia.org/T117722) (owner: 10Prtksxna) [11:02:26] <wikibugs> 10Wikipedia-Android-App-Backlog, 10Technical-Debt: Use auto-sizing TextView for page title. - https://phabricator.wikimedia.org/T180000#3743393 (10TheDJ) Also, try testing with some of these :) https://en.wikipedia.org/wiki/Longest_word_in_English [11:15:59] <wikibugs> 10Multi-Content-Revisions: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3861542 (10Addshore) [11:16:53] <wikibugs> (03CR) 10Bartosz Dziewoński: "This revert looks broken. Changes in print.less were not reverted, and there's a mistake in SkinVector.php too ("$className .= ' vector-na" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [11:19:38] <wikibugs> (03PS1) 10Umherirrender: Skip unit tests, if diff 3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 [11:25:25] <wikibugs> (03CR) 10Bartosz Dziewoński: "I'm going to revert this revert and submit a more specific fix. Let's continue on the task." [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [11:26:32] <wikibugs> (03PS1) 10Bartosz Dziewoński: Revert "Revert "Print styles in Vector are no longer feature flagged"" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400389 (https://phabricator.wikimedia.org/T178028) [11:27:27] <wikibugs> (03PS1) 10Bartosz Dziewoński: Do not fail when we can't get the config [skins/Vector] - 10https://gerrit.wikimedia.org/r/400390 (https://phabricator.wikimedia.org/T183640) [11:28:12] <wikibugs> 10MediaWiki-Configuration, 10MediaWiki-Installer, 10Vector, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: No registered builder available for vector. - https://phabricator.wikimedia.org/T183640#3861564 (10matmarex) 05Resolved>03Open a:05Paladox>03matmarex [11:29:28] <wikibugs> (03CR) 10Bartosz Dziewoński: "My fix: https://gerrit.wikimedia.org/r/400390" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400000 (https://phabricator.wikimedia.org/T183640) (owner: 10Paladox) [11:29:37] <wikibugs> (03CR) 10Bartosz Dziewoński: "My fix: https://gerrit.wikimedia.org/r/400390" [skins/Vector] - 10https://gerrit.wikimedia.org/r/388133 (https://phabricator.wikimedia.org/T178028) (owner: 10Jdlrobson) [11:29:44] <wikibugs> 10MediaWiki-extensions-Translate, 10Easy, 10Google-Code-in-2017, 10I18n, 10RTL: Supporting RTL direction in the Special:PageMigration - https://phabricator.wikimedia.org/T139463#3861566 (10Nikerabbit) 05Open>03Resolved [11:33:52] <wikibugs> 10MediaWiki-Watchlist, 10Mail, 10Operations: Mails from MediaWiki seem to get (partially) lost - https://phabricator.wikimedia.org/T121105#3861569 (10hoo) >>! In T121105#3860761, @Aklapper wrote: > @hoo, @Lydia_Pintscher : Still an issue, 18 months later? Or should this task be closed? I haven't had any (ap... [11:35:25] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Fix inconsistent capitalization of different method calls [core] - 10https://gerrit.wikimedia.org/r/400392 [11:36:43] <wikibugs> 10MediaWiki-Watchlist, 10Mail, 10Operations: Mails from MediaWiki seem to get (partially) lost - https://phabricator.wikimedia.org/T121105#3861570 (10Lydia_Pintscher) 05Open>03Resolved a:03Lydia_Pintscher Yeah it seems ok now. [11:40:43] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 [11:43:52] <wikibugs> (03CR) 10Bartosz Dziewoński: "Is this mergeable, or do you want to work on that more?" [core] - 10https://gerrit.wikimedia.org/r/396323 (owner: 10Fomafix) [11:44:05] <wikibugs> 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3861577 (10Ladsgroup) [11:44:09] <wikibugs> 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10User-Huji: LoginNotify should inform users of the IP address of successful login attemps to their account - https://phabricator.wikimedia.org/T174562#3565878 (10Tacsipacsi) Any progress? The Legal team approved this two and a half months ago. [11:46:19] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 032] Fix inconsistent capitalization of different method calls [core] - 10https://gerrit.wikimedia.org/r/400392 (owner: 10Thiemo Kreuz (WMDE)) [11:46:23] <wikibugs> 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3861584 (10Addshore) [11:47:06] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 032] Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [11:47:45] <wikibugs> 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: Argument 1 passed to MediaWiki\Storage\RevisionStore::getKnownCurrentRevision() must be an instance of Title, null given - https://phabricator.wikimedia.org/T183714#3861542 (10Addshore) [11:49:01] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [11:52:48] <wikibugs> (03Merged) 10jenkins-bot: Fix inconsistent capitalization of different method calls [core] - 10https://gerrit.wikimedia.org/r/400392 (owner: 10Thiemo Kreuz (WMDE)) [11:54:13] <wikibugs> (03PS3) 10Bartosz Dziewoński: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2 [core] - 10https://gerrit.wikimedia.org/r/393687 (owner: 10Jforrester) [11:55:39] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [11:57:07] <wikibugs> 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" - https://phabricator.wikimedia.org/T183716#3861600 (10Addshore) [11:57:31] <wikibugs> 10MediaWiki-extensions-PageCuration, 10Collaboration-Team-Triage, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in PageTriage LinksUpdateComplete hook - https://phabricator.wikimedia.org/T183716#3861613 (10Addshor... [11:59:45] <Albert221> Nikerabbit yes, the problem wasn't with DB_REPLICA but with something other, but I managed to fix it [11:59:58] <wikibugs> (03CR) 10Umherirrender: Document "arrays of UserGroupMembership objects" as such (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [12:00:05] <Albert221> Could you answer those questions I left on GCI task page? [12:02:22] <wikibugs> 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3861617 (10Addshore) [12:02:59] <wikibugs> 10GeoData, 10Multi-Content-Revisions, 10Beta-Cluster-reproducible: RevisionAccessException, "Could not determine title for page ID X and revision ID Y" in GeoData FileUpload hook - https://phabricator.wikimedia.org/T183717#3861627 (10Addshore) [12:04:21] <wikibugs> (03CR) 10Bartosz Dziewoński: [C: 032] resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2 [core] - 10https://gerrit.wikimedia.org/r/393687 (owner: 10Jforrester) [12:06:31] <Nikerabbit> Albert221: me? [12:06:35] <wikibugs> (03CR) 10jenkins-bot: Fix inconsistent capitalization of different method calls [core] - 10https://gerrit.wikimedia.org/r/400392 (owner: 10Thiemo Kreuz (WMDE)) [12:12:36] <wikibugs> (03Merged) 10jenkins-bot: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2 [core] - 10https://gerrit.wikimedia.org/r/393687 (owner: 10Jforrester) [12:14:10] <wikibugs> (03PS1) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) [12:22:22] <wikibugs> 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3861635 (10Ladsgroup) http://codesearch.wmflabs.org/extens... [12:23:11] <wikibugs> (03CR) 10jenkins-bot: resources: Upgrade jquery.chosen from 0.9.14 to 1.8.2 [core] - 10https://gerrit.wikimedia.org/r/393687 (owner: 10Jforrester) [12:26:35] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Simplify ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/400396 [12:27:37] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "I already uploaded a follow up patch that tackles all comments I wrote." (035 comments) [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [12:27:45] <wikibugs> (03PS1) 10Umherirrender: Simplify use of --plugin argument of BackupDumper [extensions/ActiveAbstract] - 10https://gerrit.wikimedia.org/r/400397 [12:28:31] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861636 (10Od1n) [12:29:52] <Albert221> Nikerabbit, yes, aren't you mentor of this? [12:30:44] <wikibugs> 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3861646 (10thiemowmde) [12:32:34] <wikibugs> (03CR) 10Umherirrender: "Rest looks good" (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:32:50] <wikibugs> (03PS1) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) [12:33:28] <wikibugs> (03Merged) 10jenkins-bot: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [12:34:33] <wikibugs> 10MediaWiki-extensions-WikibaseClient, 10MediaWiki-extensions-WikibaseRepository, 10Advanced-Search, 10TCB-Team, and 7 others: Use ExtensionRegistry instead of class_exists to check for enabled extensions - https://phabricator.wikimedia.org/T183096#3861649 (10thiemowmde) @Ladsgroup, the numbers in my comme... [12:35:46] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:37:42] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): Use ExtensionRegistry instead of class_exists (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:39:05] <Santosh3007> Hi Guys! I am Santosh and I am new to IRC. I am here for a Google Code-in task(GCI) [12:39:25] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists (032 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:40:11] <refeed[m]> Santosh3007: Welcome! [12:40:57] <Santosh3007> refeed: So how exactly does this work? Is it like an open chat room where anyone can send messages and everyone can see? [12:42:03] <wikibugs> (03CR) 10jenkins-bot: Integration tests for ApiQueryRecentChanges [core] - 10https://gerrit.wikimedia.org/r/400135 (owner: 10Ladsgroup) [12:42:44] <Phantom42> Santosh3007: Yes, it is :) [12:42:48] <Nikerabbit> Albert221: to answer one of your questions: https://doc.wikimedia.org/mediawiki-core/master/js/ [12:43:22] <Santosh3007> Phantom42: Thank you :) [12:43:28] <Nikerabbit> Albert221: wouldn't it be sufficient to add <a name=something-unique> instead of making links? [12:43:43] <wikibugs> (03PS1) 10Umherirrender: Fix strict standard about ApiBase::getWebUITokenSalt [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400399 [12:45:25] <wikibugs> (03CR) 10Ladsgroup: [C: 032] Simplify ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/400396 (owner: 10Thiemo Kreuz (WMDE)) [12:47:23] <wikibugs> (03PS2) 10Thiemo Kreuz (WMDE): Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 [12:47:41] <wikibugs> (03PS2) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) [12:47:49] <wikibugs> (03CR) 10Ladsgroup: Use ExtensionRegistry instead of class_exists (032 comments) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:51:12] <wikibugs> (03PS2) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) [12:51:17] <wikibugs> (03CR) 10Ladsgroup: Use ExtensionRegistry instead of class_exists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:51:50] <wikibugs> (03CR) 10Umherirrender: [C: 031] Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [12:51:55] <wikibugs> (03Merged) 10jenkins-bot: Simplify ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/400396 (owner: 10Thiemo Kreuz (WMDE)) [12:53:18] <wikibugs> (03PS3) 10Umherirrender: Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [12:53:21] <wikibugs> (03CR) 10Umherirrender: [C: 032] Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [12:56:33] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Split ThresholdLookup into two class (031 comment) [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [13:00:41] <wikibugs> (03Merged) 10jenkins-bot: Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [13:00:44] <wikibugs> (03Merged) 10jenkins-bot: Split ThresholdLookup into two class [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) (owner: 10Ladsgroup) [13:07:49] <wikibugs> (03CR) 10jenkins-bot: Simplify ApiQueryRecentChangesIntegrationTest [core] - 10https://gerrit.wikimedia.org/r/400396 (owner: 10Thiemo Kreuz (WMDE)) [13:09:32] <Albert221> Nikerabbit I was writing from my phone, fortunately I'm now on the desktop [13:09:57] <Albert221> hm, if a[name] would make a good solution then I think that I don't exactly understand the task point [13:10:07] <Albert221> could you help me with understanding of it? :) [13:10:20] <Albert221> and yes, I needed that documentation! [13:11:17] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861667 (10Pablo-WMDE) * generally used a line height of 140% to achieve the spacing as seen in the screens (as oppose... [13:12:35] <Nikerabbit> Albert221: per my understanding the main point is to make it possible to link directly to some particular section of the page [13:13:08] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Add strict type hints to test function headers [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400401 [13:13:11] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Add strict type hints to productin code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 [13:13:17] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add strict type hints to productin code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [13:13:39] <Nikerabbit> Albert221: secondary point would be making it easier to make such link, but for experts it is enough to have name attribute on "a" tag (or just id on the heading itself, that is simpler) [13:16:23] <wikibugs> (03CR) 10Ladsgroup: [C: 032] Add strict type hints to test function headers [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400401 (owner: 10Thiemo Kreuz (WMDE)) [13:17:16] <Albert221> so I have to add IDs to those headings (in https://en.wikipedia.org/wiki/Special:ContentTranslationStats): Translations to all languages, Translations to English and et cetera? [13:17:59] <wikibugs> (03CR) 10jenkins-bot: Document "arrays of UserGroupMembership objects" as such [core] - 10https://gerrit.wikimedia.org/r/400393 (owner: 10Thiemo Kreuz (WMDE)) [13:18:02] <Albert221> and the bonus "to link to a particular tab that is not open by default" is to have such an anchors that open specific tab on Special:ContentTranslation (not Stats), right? [13:18:04] <wikibugs> (03Merged) 10jenkins-bot: Add strict type hints to test function headers [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400401 (owner: 10Thiemo Kreuz (WMDE)) [13:18:49] <Albert221> do I understand everything correctly now Nikerabbit? [13:19:11] <wikibugs> 10Accessibility, 10Collaboration-Team-Triage, 10Notifications: Echo: placement of notifications flyout in DOM (HTML) makes it hard for screen-reader users to access - https://phabricator.wikimedia.org/T49993#3861669 (10matmarex) [13:26:17] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861670 (10tmletzko) I answer what I can (the rest goes to @kai.nissen > how should list bullets be shown? Are not c... [13:30:14] <Nikerabbit> Albert221: for example https://en.wikipedia.org/wiki/Special:ContentTranslationStats#global-translations-weekly would open the "translation to all languages per week" graph [13:30:49] <Albert221> okay, I got this! [13:38:24] <wikibugs> 10Wikipedia-Android-App-Backlog, 10Technical-Debt: Use auto-sizing TextView for page title. - https://phabricator.wikimedia.org/T180000#3861688 (10Jcasariego) thanks @TheDJ I'll see how it look with this titles! [13:40:36] <wikibugs> 10OOjs-UI, 10Apex, 10Notifications, 10Collaboration-Team-Triage (Collab-Team-This-Quarter): Secondary links broken in Echo in Monobook (possibly a MenuOptionWidget regression in Apex?) - https://phabricator.wikimedia.org/T183435#3861692 (10matmarex) a:03matmarex There is a `position: absolute` defined fo... [13:40:47] <wikibugs> (03PS1) 10Bartosz Dziewoński: mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) [13:48:02] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) (owner: 10Bartosz Dziewoński) [13:50:26] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861699 (10kai.nissen) > * are there hosted versions of the up/down arrow? We don't have that image, it seems. I sugg... [13:53:32] <wikibugs> (03PS2) 10Bartosz Dziewoński: mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) [13:54:46] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861702 (10tmletzko) yes, only Fördermitgliedschaft. even with stickyness, there is always a way out after clicking on... [13:59:21] <wikibugs> 10MediaWiki-Special-pages: Two date pickers (calendars) appear on Contributions page if form is clicked before page load - https://phabricator.wikimedia.org/T183624#3861703 (10Krinkle) [14:00:04] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) (owner: 10Bartosz Dziewoński) [14:04:51] <wikibugs> 10Navigation-Popups: Remove Cookie library from popups - https://phabricator.wikimedia.org/T178506#3861708 (10TheDJ) 05Open>03Resolved a:03TheDJ Done: https://en.wikipedia.org/w/index.php?title=MediaWiki:Gadget-popups.js&diff=817301841&oldid=811267057 [14:07:57] <wikibugs> (03PS3) 10Bartosz Dziewoński: mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) [14:32:23] <Albert221> d3r1ck, Nikerabbit: I've done the first part of the task, but I'd like to get some feedback whether this is how this should work/look: https://gerrit.wikimedia.org/r/#/c/400260/ (look at the commit message)! :) [14:32:47] <Albert221> if you can leave that feedback on GCI not IRC, because it will disappear on IRC after some time... :) [14:34:27] <wikibugs> (03PS4) 10Eugene233: Remove "viewmywatchlist" user right from anonymous users [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) [14:36:27] <wikibugs> (03CR) 10Eugene233: "TerraCodes: Thanks very much for the highlight." [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) (owner: 10Eugene233) [14:39:14] <Zppix> O/ [14:44:09] <Albert221> hey Zppix o/ [14:44:41] <Zppix> Albert221: hows everything gojng [14:45:27] <Albert221> I got cold yesterday, but except that, as always, doing task for now :) [14:45:29] <Albert221> you? [14:45:50] <Zppix> Busy [14:45:56] <Zppix> With life and everything [14:51:05] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861722 (10Pavliukdanila) [14:51:12] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861734 (10Pavliukdanila) [14:52:14] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights for ruwikitonary - https://phabricator.wikimedia.org/T183719#3861735 (10Zppix) [14:52:16] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861736 (10Pavliukdanila) [14:52:18] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861722 (10Pavliukdanila) [14:54:19] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861739 (10Pavliukdanila) [15:02:44] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861743 (10Pavliukdanila) a:05Pavliukdanila>03None [15:03:03] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861722 (10Pavliukdanila) a:03Pavliukdanila [15:03:21] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861722 (10Pavliukdanila) a:05Pavliukdanila>03None [15:04:20] <wikibugs> 10Wikimedia-Site-requests: Creating Additional Rights - https://phabricator.wikimedia.org/T183719#3861746 (10Aklapper) @Pavliukdanila: Thanks for reporting this. Which specific permission or right should be added to which specific group(s) on which specific website? Please edit the task to summarize this. Thanks. [15:06:29] <wikibugs> 10Wikimedia-Site-requests: Add suppressredirect permission to groups (?) on Russian Wiktionary. - https://phabricator.wikimedia.org/T183719#3861760 (10Aklapper) [15:06:50] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861761 (10Eugene233) [15:07:31] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861636 (10Eugene233) @Od1n I will be adding this task on google code-in site :) [15:07:54] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861636 (10Aklapper) @Eugene233: Would you mentor this in #GCI2017 or why was the tag added? :) [15:09:18] <Albert221> Nikerabbit, I've pushed an update :) [15:10:10] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861766 (10Eugene233) Yes @Od1n I wish to mentor this task [15:11:44] <wikibugs> 10Wikimedia-Site-requests: Add suppressredirect permission to groups (?) on Russian Wiktionary. - https://phabricator.wikimedia.org/T183719#3861767 (10Pavliukdanila) [15:11:46] <wikibugs> 10Wikimedia-Site-requests: Add suppressredirect permission to groups (?) on Russian Wiktionary. - https://phabricator.wikimedia.org/T183719#3861722 (10Pavliukdanila) **Permissions have been added to the site:** https://ru.wiktionary.org/ **Permission to add:** (suppressredirect) The permission must be added to... [15:12:20] <wikibugs> (03PS1) 10Phuedx: Revision: Handle all return values of Title::newFromId [core] - 10https://gerrit.wikimedia.org/r/400408 [15:13:54] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861769 (10Od1n) [15:15:56] <puru> Hello everyone, there is this small task for Google Code in to introduce myself on this platform. I am Paritosh Kakkar from India. [15:16:25] <Phantom42> puru: Welcome! Good luck with your GCI tasks! [15:16:45] <puru> Thank you so much. :) [15:17:47] <sanjay_tharagesh> puru: hi [15:18:20] <puru> Hello! [15:21:03] <puru> sanjay_tharagesh: Sir, am I expected to wait for 1 hour? :p [15:21:40] <wikibugs> (03CR) 10Phuedx: "This also affects Revision::newNullRevision but I'm not sure what the short-circuit path would look like (if one is actually needed)." [core] - 10https://gerrit.wikimedia.org/r/400408 (owner: 10Phuedx) [15:22:49] <wikibugs> 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: class="wikitable plainrowheaders" does not work in mobile - https://phabricator.wikimedia.org/T183704#3861216 (10Eugene233) @Neve-selbert Can this task be added to the Code-In tasks and mentored? [15:22:51] <wikibugs> (03CR) 10Phuedx: MCR: Deprecate and gut Revision class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [15:28:21] <wikibugs> 10Security-Team, 10Wikimedia-Site-requests: Implement results of enwiki Security review RfC - https://phabricator.wikimedia.org/T121186#3861773 (10Samtar) >>! In T121186#3825194, @Bawolff wrote: >> Regular audits will take some work to get setup > > I don't think anyone ever decided what is meant by this (run... [15:30:21] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] Use ExtensionRegistry instead of class_exists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [15:32:32] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Use ExtensionRegistry instead of class_exists (031 comment) [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [15:37:12] <sanjay_tharagesh> @puru: yes, you have to wait for at least 1hr in this channel [15:37:52] <puru> okay :) [15:38:18] <apergos> hello puru and welcome! [15:38:24] <wikibugs> 10Design, 10WMDE-Fun-Team, 10WMDE-Fundraising-Tech, 10WMDE-Design (WMDE-Design-Workboard Doing), 10WMDE-Fundraising-Funban-2: Thank You-Banner - https://phabricator.wikimedia.org/T183280#3861778 (10Pablo-WMDE) Thanks for the answers. What about the mentioned mobile layout? Should this become a dedicated... [15:39:16] <puru> hello apergos. thank you. [15:39:51] <apergos> is this your first time using irc or are you a regular? :-) [15:40:48] <puru> no, this is my first time. May [15:41:24] <puru> May I know what do we basically use it for? [15:41:44] <apergos> well, at wikimedia we have a lot of these irc channels [15:42:05] <apergos> so people that are working on mediawiki development might be in here, discussing issues [15:42:23] <apergos> or also looking at reports of patches that have been published [15:42:27] <apergos> (there are bots for that) [15:42:45] <apergos> for people that put together the releases of mediawiki, there's another channel [15:43:04] <puru> oh okay. sounds interesting. [15:43:08] <apergos> for people that are working on research, there's another channel [15:43:09] <apergos> and so on [15:43:43] <apergos> hey yurik, what's up? [15:44:58] <wikibugs> (03CR) 10Fomafix: [C: 04-1] "This is a general problem on all margins in multi-columns. I don't not know how to solve this in general." [core] - 10https://gerrit.wikimedia.org/r/396323 (owner: 10Fomafix) [15:45:11] <wikibugs> (03CR) 10Daniel Kinzler: "Please add a unit test for the new behavior. It seems like we are in fact lacking a test for passing a page ID here, valid or invalid. See" [core] - 10https://gerrit.wikimedia.org/r/400408 (owner: 10Phuedx) [15:46:06] <apergos> puru: how did you find out about google code in and end up here? :-) [15:47:44] <puru> So basically it all started with my sister. She used to do tasks in GCI and I got to know it from her. [15:47:46] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 [15:47:57] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [15:48:07] <puru> Just started with the tasks. This is my first one. [15:49:00] <apergos> awesome! did you already decide on a task? [15:49:24] <wikibugs> 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10User-Huji: LoginNotify should inform users of the IP address of successful login attemps to their account - https://phabricator.wikimedia.org/T174562#3861787 (10Huji) I started working on it but I found out that the first thing we need is a way to creat... [15:50:01] <puru> no no I just came across this one. [15:50:13] <puru> I am searching for the next one [15:52:05] <wikibugs> 04(no projects): Thank you Message in German too long for Window - https://phabricator.wikimedia.org/T183721#3861789 (10JoKalliauer) [15:53:58] <wikibugs> 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10User-Huji: Maintenance script to generate fake login attemps from any IP - https://phabricator.wikimedia.org/T183722#3861799 (10Huji) [15:54:00] <wikibugs> 10MediaWiki-extensions-LoginNotify, 10Community-Tech, 10User-Huji: Maintenance script to generate fake login attemps from any IP - https://phabricator.wikimedia.org/T183722#3861799 (10Huji) [15:56:34] <Vansh> Hi [15:56:45] <Phantom42> Vansh: Hello! [15:57:15] <Vansh> I I am vanshaggarwal and I am here to complete my task to chat in orc [15:57:27] <Vansh> Sorry orc clieny [15:57:33] <Vansh> Irc [15:57:48] <Vansh> I am from gci [15:57:59] <Vansh> Phantom where are you from [15:58:12] <Phantom42> Great! Which IRC client are you using? [15:58:25] <Phantom42> Vansh: I am from Ukraine. And you? [15:58:31] <Vansh> www.freenode [15:58:41] <Vansh> India [15:59:08] <Phantom42> Nice! We have a lot of other GCI participants from India here too :) [15:59:15] <Vansh> How old are you [15:59:24] <Phantom42> I am 17. And you? :) [15:59:33] <Vansh> Can you tell how I have to submit this task [15:59:44] <Vansh> 14 [16:00:13] <Phantom42> By the way, I am afraid that web IRC clients like (freenode webchat) are not allowed by task description :( [16:00:15] <apergos> I think you need to hang out for awhile here first, chat, meet people, see how we use irc, stuff like that [16:00:39] <apergos> yeah, no webchat for the task, you want to find a free software client [16:00:48] <apergos> so where the source is available [16:01:04] <apergos> not that you have to build the source yourself, just that the source is there and could be looked at [16:01:32] <Vansh> Can u suggest a client [16:01:57] <apergos> there should be some linked on the description of the google code-in [16:02:06] <apergos> where you got the instructions to come here, I mean [16:02:41] <Vansh> There are only written the the client which we have. Not to use [16:03:43] <Vansh> It is written that connect to freenode [16:04:17] <Vansh> Anyone online [16:04:23] <apergos> yes, the client [16:04:24] <wikibugs> 10MediaWiki-ContentHandler, 10MW-1.28-release (WMF-deploy-2016-10-04_(1.28.0-wmf.21)), 10MW-1.28-release-notes, 10Patch-For-Review, 10Technical-Debt: WikiPage::getText() is deprecated - https://phabricator.wikimedia.org/T145750#3861814 (10Florian) [16:04:26] <wikibugs> 10MediaWiki-extensions-Wikilog, 10Easy, 10Google-Code-in-2017, 10Patch-For-Review, 10Technical-Debt: Call to undefined method WikiPage::getText() - https://phabricator.wikimedia.org/T179532#3861813 (10Florian) 05Open>03Resolved [16:04:35] <apergos> that's what we mean, you want to use an open source client [16:04:40] <apergos> not to come through a web page [16:05:45] <Vansh> But can u tell me a Na pp [16:05:56] <Vansh> An app [16:06:14] <Zppix> Vansh: use hexchat [16:06:23] <Vansh> 9k [16:06:27] <Vansh> Ok [16:08:04] <apergos> it should say in the task description "install an irc client you like" [16:08:13] <apergos> there is a link in that phrase [16:08:17] <Zppix> It dors [16:08:18] <apergos> to a list [16:08:30] <Zppix> It does* [16:12:58] <puru> can someone please check on my task? I think my task is done. [16:13:36] <wikibugs> 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: class="wikitable plainrowheaders" does not work in mobile - https://phabricator.wikimedia.org/T183704#3861815 (10Neve-selbert) @Eugene233 I'm not sure how to do that, sorry. [16:15:01] <puru> ping @Zppix [16:15:29] <sanjay_tharagesh> puru: Great, I've approved your task, Go ahead [16:16:18] <puru> thank you so much :) It was nice talking to you guys. [16:16:55] <Albert221> okay Nikerabbit, Stats page is done I think [16:17:08] <Albert221> now I'll do the same for tabs on SpecialContentTranslation [16:17:38] <puru> @sanjay_tharagesh I am unable to clain any other task? [16:17:51] <Nikerabbit> Albert221: I'll test [16:18:13] <apergos> puru, come back any time, you know where to find us! [16:18:31] <Albert221> puru, you'll be able to claim new task once your first task is accepted and your parental consent is verified! [16:18:59] <sanjay_tharagesh> puru: you have to wait now for google to approve your parent consent [16:19:31] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Remove superfluous documentation snippets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400412 [16:22:19] <Albert221> Nikerabbit, I wanted to push some changes after I'll do same for ContentTranslations and you already merged that! :D [16:23:02] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Remove superfluous documentation snippets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400412 (owner: 10Thiemo Kreuz (WMDE)) [16:23:35] <PriyanshuAhuja1> Hi everyone this is Priyanshu Ahuja joined #wikimedia-dev for google code in. [16:24:13] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Utilize the …::class feature instead of class names in strings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400413 [16:24:31] <Nikerabbit> Albert221: use separate patches for separate things [16:25:24] <apergos> welcome, PriyanshuAhuja1 ! [16:25:27] <wikibugs> (03PS2) 10Thiemo Kreuz (WMDE): Remove superfluous documentation snippets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400412 [16:25:31] <Phantom42> PriyanshuAhuja1: Welcome! [16:27:26] <wikibugs> (03PS2) 10Thiemo Kreuz (WMDE): Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 [16:28:37] <Nikerabbit> Albert221: in fact Special:ContentTranslation is not even part of the task :) [16:30:29] <puru> hi,got disconnected sorry. So yes my parental consent will be approved by? [16:30:51] <Albert221> sorry but I found myself a little bit retarded when it comes to understanding tasks' descriptions ._. [16:30:56] <Albert221> okay, so I'm submitting it then! [16:31:14] <Albert221> puru, yes, all you have to do is to wait for some Google employee to take care of that :) [16:32:46] <puru> Since I completed with my first task today, so will it be done by like tomorrow or day after? If you have any idea @Albert221 [16:32:59] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "The suggested change looks fine for me, but as said, please add a test." [core] - 10https://gerrit.wikimedia.org/r/400408 (owner: 10Phuedx) [16:33:43] <Albert221> puru I had to wait like 2 hours to get my parental consent approved, it will close in 24hrs for sure, but I'd expect that to be accepted in a matter of 2-3 hours most [16:34:05] <puru> alright, thank you so much. [16:34:34] <Albert221> no problem, if you have any questions, feel free to ask! :) [16:34:37] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Remove "viewmywatchlist" user right from anonymous users (032 comments) [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) (owner: 10Eugene233) [16:36:12] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 031] "I'm not familiar with this extension. The change looks right from a distance. In case nobody else is actively watching this repository I'm" [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 (owner: 10Umherirrender) [16:37:38] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Remove PHPDoc block repeating the file name [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [16:38:38] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to utils tests [core] - 10https://gerrit.wikimedia.org/r/400167 (owner: 10Legoktm) [16:39:16] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to user tests [core] - 10https://gerrit.wikimedia.org/r/400166 (owner: 10Legoktm) [16:39:59] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to specials tests [core] - 10https://gerrit.wikimedia.org/r/400165 (owner: 10Legoktm) [16:40:14] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to parser tests [core] - 10https://gerrit.wikimedia.org/r/400164 (owner: 10Legoktm) [16:40:17] <wikibugs> 10ContentTranslation, 10ContentTranslation-Analytics, 10Easy, 10Google-Code-in-2017, and 2 others: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546#3861821 (10Albert221) 05Open>03Resolved [16:40:38] <wikibugs> (03PS1) 10Umherirrender: Fix typo in @covers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/400414 [16:40:58] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to page tests [core] - 10https://gerrit.wikimedia.org/r/400163 (owner: 10Legoktm) [16:42:21] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] "I prefer to have the @covers line at the top of each comment block. You already did it like this in a few of your patches, but different i" [core] - 10https://gerrit.wikimedia.org/r/400161 (owner: 10Legoktm) [16:43:00] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to objectcache tests [core] - 10https://gerrit.wikimedia.org/r/400162 (owner: 10Legoktm) [16:43:20] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 (owner: 10Legoktm) [16:44:03] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 (owner: 10Legoktm) [16:44:14] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 (owner: 10Legoktm) [16:44:39] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 (owner: 10Legoktm) [16:45:01] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 (owner: 10Legoktm) [16:46:22] <takidelfin> Hey, dear Mentors! Could someone review my design task? https://codein.withgoogle.com/dashboard/task-instances/6424617684041728/ [16:49:10] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Add tests for TextboxBuilder (035 comments) [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [16:50:24] <n0n4me> Hi [16:50:56] <n0n4me> I am here for a Google Code In task [16:51:07] <Phantom42> n0n4me: Welcome! Good luck with your GCI tasks! :) [16:51:26] <n0n4me> thanks a lot, Phantom42' [16:51:34] <n0n4me> I guess ur one of the mentors? [16:51:59] <Phantom42> No, I am other gci participant [16:52:09] <andre__> takidelfin: We're late, sorry. Done now. :) [16:52:14] <andre__> hi n0n4me and welcome [16:52:24] <Phantom42> n0n4me: If you have any questions please feel free to ask - we will be happy to help :) [16:52:25] <takidelfin> andre__: Can you review my task? https://codein.withgoogle.com/dashboard/task-instances/6424617684041728/ [16:53:17] <wikibugs> (03PS1) 10Thiemo Kreuz (WMDE): Remove redundant documentation snippets [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400417 [16:56:04] <andre__> takidelfin: done already :) [16:56:43] <andre__> takidelfin: also see my private message here on IRC [16:56:45] <n0n4me> Hi andre__ [16:56:49] <andre__> hi n0n4me [16:56:55] <wikibugs> (03PS1) 10Umherirrender: Fix use of boolean in extension.json [extensions/BlueSpiceBlog] - 10https://gerrit.wikimedia.org/r/400418 [16:56:56] <n0n4me> could you please review my task as well [16:57:20] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 032] Move methods of Cache to PurgeScoreCache [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399994 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [16:58:21] <wikibugs> (03PS1) 10Umherirrender: Fix register of extension in extension.json [extensions/BlueSpiceWhoIsOnline] - 10https://gerrit.wikimedia.org/r/400419 [16:58:28] <andre__> n0n4me: what is your task? [16:58:38] <andre__> n0n4me, mentors review tasks within 36 hours, normally. [16:58:40] <n0n4me> Connecting to IRC [16:58:50] <andre__> n0n4me, that task is not finished yet. So nobody can review it yet. [16:59:02] <wikibugs> (03Merged) 10jenkins-bot: Move methods of Cache to PurgeScoreCache [extensions/ORES] - 10https://gerrit.wikimedia.org/r/399994 (https://phabricator.wikimedia.org/T181334) (owner: 10Ladsgroup) [16:59:26] <n0n4me> oh, alright thanks a lot for help [17:00:28] <andre__> n0n4me, you're welcome [17:00:54] <n0n4me> what do I need to do to finish the task? [17:01:26] <wikibugs> (03PS2) 10Thiemo Kreuz (WMDE): Add strict type hints to productin code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 [17:01:32] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add strict type hints to productin code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [17:02:53] <andre__> n0n4me, see the GCI task description. [17:03:03] <n0n4me> Wait for an hour [17:04:32] <wikibugs> (03PS3) 10Thiemo Kreuz (WMDE): Add strict type hints to production code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 [17:05:08] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): "recheck" [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400410 (owner: 10Thiemo Kreuz (WMDE)) [17:05:26] <wikibugs> (03PS9) 10Fomafix: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [17:05:37] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add strict type hints to production code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [17:05:39] <wikibugs> (03CR) 10Fomafix: "Rebased after merge conflict." [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [17:09:14] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to miscellaneous tests [core] - 10https://gerrit.wikimedia.org/r/400168 (owner: 10Legoktm) [17:09:52] <wikibugs> (03CR) 10Ladsgroup: [C: 032] "https://twitter.com/AmirSarabadani/status/926886484690522112" [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400417 (owner: 10Thiemo Kreuz (WMDE)) [17:10:02] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to logging tests [core] - 10https://gerrit.wikimedia.org/r/400160 (owner: 10Legoktm) [17:11:19] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 (owner: 10Legoktm) [17:11:41] <wikibugs> (03Merged) 10jenkins-bot: Remove redundant documentation snippets [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400417 (owner: 10Thiemo Kreuz (WMDE)) [17:12:33] <wikibugs> (03PS2) 10Umherirrender: Skip unit tests, if diff3 is not installed [extensions/ProofreadPage] - 10https://gerrit.wikimedia.org/r/400388 [17:12:46] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [17:15:14] <wikibugs> (03PS4) 10Ladsgroup: Add strict type hints to production code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [17:16:59] <wikibugs> (03PS10) 10Fomafix: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [17:19:27] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to logging tests [core] - 10https://gerrit.wikimedia.org/r/400160 (owner: 10Legoktm) [17:19:30] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to media tests [core] - 10https://gerrit.wikimedia.org/r/400161 (owner: 10Legoktm) [17:19:58] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to objectcache tests [core] - 10https://gerrit.wikimedia.org/r/400162 (owner: 10Legoktm) [17:22:20] <wikibugs> (03CR) 10Ladsgroup: [C: 032] Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 (owner: 10Legoktm) [17:23:42] <wikibugs> (03CR) 10Ladsgroup: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [17:24:05] * d3r1ck checks in [17:24:29] <d3r1ck> Albert221: Great work! [17:24:39] * d3r1ck reads log [17:27:05] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to page tests [core] - 10https://gerrit.wikimedia.org/r/400163 (owner: 10Legoktm) [17:27:06] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to parser tests [core] - 10https://gerrit.wikimedia.org/r/400164 (owner: 10Legoktm) [17:27:08] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): "What's going on here? I just found a weird pointless "@param Foo $foo Foo" in some random code, did a global search in my local code base," (033 comments) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/396296 (https://phabricator.wikimedia.org/T170579) (owner: 10Albert221) [17:29:01] <wikibugs> (03CR) 10D3r1ck01: [C: 04-1] Remove "viewmywatchlist" user right from anonymous users (031 comment) [core] - 10https://gerrit.wikimedia.org/r/365524 (https://phabricator.wikimedia.org/T71301) (owner: 10Eugene233) [17:30:29] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to specials tests [core] - 10https://gerrit.wikimedia.org/r/400165 (owner: 10Legoktm) [17:30:53] <wikibugs> (03CR) 10D3r1ck01: [C: 031] "LGTM! Great work Phantom42 :)" [extensions/Cite] - 10https://gerrit.wikimedia.org/r/400174 (https://phabricator.wikimedia.org/T179554) (owner: 10Phantom42) [17:33:26] <wikibugs> 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861836 (10D3r1ck01) >>! In T183674#3861278, @Umherirrender wrote: > https://gerrit.wikime... [17:34:52] <wikibugs> 10Discovery-Search, 10Easy, 10Google-Code-in-2017, 10Need-volunteer: Create maintenance script for cleaning up stale indexes - https://phabricator.wikimedia.org/T166243#3861838 (10D3r1ck01) Removing AWMD as this is going in for #google-code-in-2017. [17:36:13] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to user tests [core] - 10https://gerrit.wikimedia.org/r/400166 (owner: 10Legoktm) [17:36:16] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to utils tests [core] - 10https://gerrit.wikimedia.org/r/400167 (owner: 10Legoktm) [17:39:34] <wikibugs> (03PS3) 10Thiemo Kreuz (WMDE): Remove superfluous documentation snippets [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400412 (https://phabricator.wikimedia.org/T170579) [17:39:37] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861852 (10Aklapper) Thanks. Published as https://codein.withgoogle.com/tasks/6332632772116480/ [17:40:53] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to miscellaneous tests [core] - 10https://gerrit.wikimedia.org/r/400168 (owner: 10Legoktm) [17:40:56] <wikibugs> (03CR) 10Ladsgroup: [C: 032] "PS4 was only fixing phpcs warnings." [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [17:42:04] <wikibugs> 10Discovery-Search, 10Easy, 10Google-Code-in-2017, 10Need-volunteer: Create maintenance script for cleaning up stale indexes - https://phabricator.wikimedia.org/T166243#3861855 (10Aklapper) @Eugene233, @Zppix: It's unclear to me which codebase this is about, and the task description misses pointers / links... [17:42:24] <wikibugs> (03CR) 10Ladsgroup: [C: 032] Utilize the …::class feature instead of class names in strings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400413 (owner: 10Thiemo Kreuz (WMDE)) [17:43:30] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [17:43:46] <wikibugs> 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Add/Remove/Notify of Publishers should happen in bulk - https://phabricator.wikimedia.org/T183658#3861860 (10Aklapper) https://codein.withgoogle.com/tasks/4641442825764864/ [17:43:51] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 (owner: 10Legoktm) [17:43:56] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 (owner: 10Legoktm) [17:44:19] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 (owner: 10Legoktm) [17:44:25] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 (owner: 10Legoktm) [17:44:29] <wikibugs> (03CR) 10Thiemo Kreuz (WMDE): [C: 04-1] Use ExtensionRegistry instead of class_exists (031 comment) [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [17:44:36] <wikibugs> (03Merged) 10jenkins-bot: Add strict type hints to production code [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400402 (owner: 10Thiemo Kreuz (WMDE)) [17:44:38] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 (owner: 10Legoktm) [17:44:40] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 (owner: 10Legoktm) [17:44:48] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 (owner: 10Legoktm) [17:44:52] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 (owner: 10Legoktm) [17:47:19] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 (owner: 10Legoktm) [17:47:23] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 (owner: 10Legoktm) [17:47:31] <wikibugs> (03PS1) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [17:47:33] <wikibugs> (03PS2) 10Umherirrender: Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 (owner: 10Legoktm) [17:47:42] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 (owner: 10Legoktm) [17:48:57] <wikibugs> (03PS3) 10Umherirrender: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 (owner: 10Legoktm) [17:49:01] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 (owner: 10Legoktm) [17:49:22] <wikibugs> (03PS2) 10Umherirrender: Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [17:49:26] <wikibugs> (03CR) 10Umherirrender: [C: 032] Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [17:49:52] <wikibugs> (03Merged) 10jenkins-bot: Utilize the …::class feature instead of class names in strings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400413 (owner: 10Thiemo Kreuz (WMDE)) [17:50:04] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to media tests [core] - 10https://gerrit.wikimedia.org/r/400161 (owner: 10Legoktm) [17:50:07] <wikibugs> (03PS4) 10Umherirrender: Add @covers tags API tests without them [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [17:52:00] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 (owner: 10Legoktm) [17:52:26] <wikibugs> (03PS3) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) [17:52:35] <wikibugs> (03CR) 10Ladsgroup: "Fixed" [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400395 (https://phabricator.wikimedia.org/T183096) (owner: 10Ladsgroup) [17:54:41] <wikibugs> (03CR) 10Phantom42: [C: 031] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [17:57:05] <Phantom42> FlorianSW: Hi! Around? [17:57:27] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 (owner: 10Legoktm) [17:57:49] <wikibugs> 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861880 (10Umherirrender) [17:58:21] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to logging tests [core] - 10https://gerrit.wikimedia.org/r/400160 (owner: 10Legoktm) [17:58:57] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 (owner: 10Legoktm) [17:59:23] <wikibugs> 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10Umherirrender) [18:00:05] <wikibugs> 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861882 (10Umherirrender) >>! In T183674#3861836, @D3r1ck01 wrote: >>>! In T183674#3861278... [18:01:00] <wikibugs> 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3861883 (10D3r1ck01) Okay @Umherirrender, thanks very much! Wondering if this task will go... [18:01:46] <wikibugs> (03PS1) 10Umherirrender: Move ApiRawJsonPrinter to own file [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/400421 [18:02:14] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 (owner: 10Legoktm) [18:04:45] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 (owner: 10Legoktm) [18:08:46] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 (owner: 10Legoktm) [18:11:27] <wikibugs> (03Merged) 10jenkins-bot: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 (owner: 10Legoktm) [18:14:33] <wikibugs> (03Merged) 10jenkins-bot: Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [18:20:15] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to objectcache tests [core] - 10https://gerrit.wikimedia.org/r/400162 (owner: 10Legoktm) [18:20:34] <wikibugs> (03CR) 10Paladox: [C: 031] "Tested locally and this works." [skins/Vector] - 10https://gerrit.wikimedia.org/r/400390 (https://phabricator.wikimedia.org/T183640) (owner: 10Bartosz Dziewoński) [18:20:44] <wikibugs> (03CR) 10Paladox: [C: 031] "This should be merged at the same time as https://gerrit.wikimedia.org/r/#/c/400390/1" [skins/Vector] - 10https://gerrit.wikimedia.org/r/400389 (https://phabricator.wikimedia.org/T178028) (owner: 10Bartosz Dziewoński) [18:28:45] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to page tests [core] - 10https://gerrit.wikimedia.org/r/400163 (owner: 10Legoktm) [18:29:43] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [18:31:26] <yurik> hi apergos, not much, hacking on fun stuff :) Have you seen https://wiki.openstreetmap.org/wiki/Sophox_query_service ? [18:32:28] <apergos> I have not, was going to ask what you're working on these days but looks like you just answered that :-) [18:33:31] <apergos> is wikidata being replicated for this service then? [18:37:42] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to parser tests [core] - 10https://gerrit.wikimedia.org/r/400164 (owner: 10Legoktm) [18:38:25] <wikibugs> (03PS2) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [18:39:13] <wikibugs> (03PS3) 10Ladsgroup: Use ExtensionRegistry instead of class_exists [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400398 (https://phabricator.wikimedia.org/T183096) [18:39:48] <wikibugs> (03CR) 10jenkins-bot: Utilize the …::class feature instead of class names in strings [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400413 (owner: 10Thiemo Kreuz (WMDE)) [18:43:27] <yurik> apergos, yep, I have both OSM & Wikidata, as well as some pageviews data. WD & OSM is up to minute [18:43:48] <yurik> this is my fun project. For work i do elasticsearch [18:43:56] <yurik> dataviz, maps, etc [18:44:41] <apergos> are you polling recent changes, or grabbing from event stream, or how are you doing it? [18:44:49] * apergos puts their dumps + api hat on [18:44:49] <wikibugs> (03CR) 10Legoktm: "@Thiemo: I tried to file the style that was already used in each file, but I might have gotten it a bit mixed up across all the patches." [core] - 10https://gerrit.wikimedia.org/r/400161 (owner: 10Legoktm) [18:46:17] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to specials tests [core] - 10https://gerrit.wikimedia.org/r/400165 (owner: 10Legoktm) [18:47:41] <wikibugs> (03CR) 10Ebe123: Fix """ in title on infopages (031 comment) [extensions/WikimediaIncubator] - 10https://gerrit.wikimedia.org/r/157686 (https://phabricator.wikimedia.org/T72240) (owner: 10Ebe123) [18:51:39] <wikibugs> (03CR) 10Legoktm: [C: 04-1] "See inline comment, which applies to all of the test files, looks pretty close otherwise :)" (031 comment) [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:52:23] <aayushagra> Hey guys! I'm new to open source but eager to contribute. Can somebody give me some help about getting started? [18:54:26] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to utils tests [core] - 10https://gerrit.wikimedia.org/r/400167 (owner: 10Legoktm) [18:54:30] <wikibugs> (03CR) 10Yurik: [C: 032] Move ApiRawJsonPrinter to own file [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/400421 (owner: 10Umherirrender) [18:54:32] <wikibugs> (03CR) 10Legoktm: Add tests for TextboxBuilder (032 comments) [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [18:59:17] <apergos> hello aayushagra! [18:59:45] <apergos> are you thinking about contributing to mediawiki, or to one of the related projects instead? [19:01:14] <aayushagra> Well to be honest i don't really know. I'm a total newbie so I'm looking to contribute to anything where i can be of use [19:01:32] <wikibugs> (03Merged) 10jenkins-bot: Move ApiRawJsonPrinter to own file [extensions/ZeroBanner] - 10https://gerrit.wikimedia.org/r/400421 (owner: 10Umherirrender) [19:03:43] <swayam> Hi, I am Swayam and I am here for Google Code-in. I just joined IRC! [19:04:11] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to user tests [core] - 10https://gerrit.wikimedia.org/r/400166 (owner: 10Legoktm) [19:04:59] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:05:35] <RexxS> aayushagra: have a look at https://www.mediawiki.org/wiki/New_Developers if you want to be a developer [19:06:01] <RexxS> Hi swayam: welcome to IRC and wikimedia [19:06:18] <wikibugs> (03PS3) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:06:53] <swayam> Thanks! [19:07:23] <aayushagra> RexxS Actually i did take a look there, but the few beginner projects with mentors were built with C/C++ an Java. I'm skilled in PHP an Python :/ [19:11:23] <wikibugs> (03PS1) 10Umherirrender: Add AvailableRights in extension.json [extensions/MultiLanguageManager] - 10https://gerrit.wikimedia.org/r/400422 [19:12:35] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to miscellaneous tests [core] - 10https://gerrit.wikimedia.org/r/400168 (owner: 10Legoktm) [19:20:42] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags for RevisionStoreDbTest [core] - 10https://gerrit.wikimedia.org/r/400147 (owner: 10Legoktm) [19:21:53] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861884 (10Od1n) I just noticed this border's color is varying across the skins… * [[ https://github.com/wikimedia/mediawiki/blob/master/resources/src/mediawik... [19:23:34] <wikibugs> (03PS1) 10Umherirrender: Use absolute class name in @covers [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/400423 [19:25:23] <d3r1ck> aayushagra: Hey! [19:25:34] <d3r1ck> Then MediaWiki and Pywikibot maybe where you fit? :) [19:26:04] <wikibugs> (03PS1) 10Umherirrender: Use absolute class name in @covers [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/400424 [19:26:26] <wikibugs> (03PS11) 10Fomafix: Add HTML attributes lang and dir to toctitle [core] - 10https://gerrit.wikimedia.org/r/214649 (owner: 10Gerrit Patch Uploader) [19:29:41] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:30:02] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to includes/debug tests [core] - 10https://gerrit.wikimedia.org/r/400148 (owner: 10Legoktm) [19:34:41] <wikibugs> (03CR) 10Legoktm: Add @covers tags API tests without them (031 comment) [core] - 10https://gerrit.wikimedia.org/r/400127 (owner: 10Legoktm) [19:37:55] <wikibugs> 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861114 (10Legoktm) @Glendales What browser/OS are you using? Do you have any add-ons/extensions installed in your browser? Have you t... [19:37:59] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to LinksUpdate test [core] - 10https://gerrit.wikimedia.org/r/400149 (owner: 10Legoktm) [19:39:28] <aayushagra> d3rick I'd love to work on them. Could use some guidance on getting started though [19:39:41] <d3r1ck> aayushagra: Sure! [19:39:50] <aayushagra> I read that only experienced devs should touch the main Mediawiki code [19:40:20] <legoktm> aayushagra: oh, definitely not! everyone can contribute to MediaWiki, there's plenty to do :) [19:40:37] <d3r1ck> aayushagra: Nah, you can contribute too :) [19:40:40] <d3r1ck> aayushagra: https://www.mediawiki.org/wiki/How_to_become_a_MediaWiki_hacker [19:40:47] <d3r1ck> aayushagra: https://www.mediawiki.org/wiki/Gerrit/Tutorial [19:41:00] <d3r1ck> legoktm: I noticed a hube number of nicks went offline, now they are rejoining [19:41:04] <d3r1ck> Was it a netsplit? [19:41:10] <d3r1ck> *huge [19:42:22] <d3r1ck> aayushagra: You can start with those! For Pywikibot, let me find a link [19:42:47] <legoktm> d3r1ck: irccloud I think [19:42:59] <d3r1ck> :( [19:43:08] <wikibugs> 10MediaWiki-Internationalization, 10Collaboration-Team-Triage, 10StructuredDiscussions: Update language used in MediaWiki:Flow-edit-header-submit - https://phabricator.wikimedia.org/T183725#3861890 (10Whatamidoing-WMF) [19:43:24] <d3r1ck> aayushagra: See this: https://www.mediawiki.org/wiki/Manual:Pywikibot/Installation, https://www.mediawiki.org/wiki/Manual:Pywikibot/Development [19:44:05] <aayushagra> I'll get started with those links then :D [19:44:29] <d3r1ck> legoktm: Yeah, makes sense, just looked at the hosts now but seems it went beyond that? Or maybe it's the cloaks? [19:44:30] <wikibugs> (03PS4) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:44:40] <d3r1ck> aayushagra: Are you a GCI participant? [19:44:56] <aayushagra> Nope, I'm a first year university student [19:45:23] <d3r1ck> aayushagra: Okay! Great! There is plenty to do so stick around and get your fingers dirty :D [19:45:36] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:46:26] <wikibugs> (03PS5) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:46:30] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to filerepo tests [core] - 10https://gerrit.wikimedia.org/r/400150 (owner: 10Legoktm) [19:46:50] <wikibugs> (03CR) 10Mooeypoo: [C: 032] mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) (owner: 10Bartosz Dziewoński) [19:47:59] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:50:14] <wikibugs> (03PS6) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:51:43] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:52:25] <Albert221> please work now [19:52:35] <wikibugs> (03PS7) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:53:12] <wikibugs> (03PS1) 10Umherirrender: Use absolute class name in @covers [extensions/Popups] - 10https://gerrit.wikimedia.org/r/400426 [19:53:42] <wikibugs> (03Merged) 10jenkins-bot: mw.echo.ui.MenuItemWidget: Override OOUI styles harder [extensions/Echo] - 10https://gerrit.wikimedia.org/r/400404 (https://phabricator.wikimedia.org/T183435) (owner: 10Bartosz Dziewoński) [19:54:05] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [19:54:12] <Albert221> rip [19:55:09] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to HTMLForm test [core] - 10https://gerrit.wikimedia.org/r/400151 (owner: 10Legoktm) [19:56:45] <wikibugs> (03PS8) 10Albert221: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) [19:56:48] <Albert221> this must work [19:57:00] <Albert221> jenkins pls [19:59:06] <d3r1ck> Albert221: :D [20:02:12] <d3r1ck> Albert221: I've not been around frequently late :( [20:02:38] <Albert221> My prayers have been heard! It passed! [20:03:39] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to jobqueue tests [core] - 10https://gerrit.wikimedia.org/r/400152 (owner: 10Legoktm) [20:06:18] <wikibugs> (03PS1) 10Umherirrender: Fix class name in @covers [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400427 [20:12:27] <wikibugs> (03CR) 10jenkins-bot: Add @covers tags to ContentHandler tests [core] - 10https://gerrit.wikimedia.org/r/400129 (owner: 10Legoktm) [20:20:53] <wikibugs> (03CR) 10jenkins-bot: Add tests for TextboxBuilder [core] - 10https://gerrit.wikimedia.org/r/400130 (owner: 10Legoktm) [20:22:20] <wikibugs> (03CR) 1001tonythomas: [C: 032] Fix class name in @covers [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400427 (owner: 10Umherirrender) [20:23:56] <wikibugs> (03Merged) 10jenkins-bot: Fix class name in @covers [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400427 (owner: 10Umherirrender) [20:26:40] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/400429 [20:28:39] <wikibugs> 10Timeless: Cannot correctly select text in chromium - https://phabricator.wikimedia.org/T183215#3861925 (10Isarra) This has nothing to do with SWAP. Probably caused by disabling hardware acceleration combined with some css chromium doesn't handle well? [20:29:54] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400430 [20:31:31] <wikibugs> 10MediaWiki-Interface, 10Timeless, 10CSS, 10Google-Code-in-2017: Image border missing in Timeless skin - https://phabricator.wikimedia.org/T183718#3861636 (10Isarra) @Od1n: Use the @grey-bright variable. [20:37:33] <tonythomas> wow. is someone around here who can help me with something on PHP unit tests ? I find that the tables are not recreated across tests :o is this the default behavior ? My only option now seems to be to fit `$this->teardownTestDB();` into `tearDown()` :/ [20:38:25] <wikibugs> (03PS1) 10Umherirrender: Fix class name in @covers [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/400431 [20:41:09] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Refactor BlueSkyTemplate [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/396808 (owner: 10Isarra) [20:42:19] <wikibugs> (03Merged) 10jenkins-bot: Refactor BlueSkyTemplate [skins/BlueSky] - 10https://gerrit.wikimedia.org/r/396808 (owner: 10Isarra) [20:43:55] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/400429 (owner: 10SamanthaNguyen) [20:44:13] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400430 (owner: 10SamanthaNguyen) [20:44:21] <wikibugs> (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [20:44:29] <Albert221> hey tonythomas! [20:44:38] <tonythomas> Albert221: hej! [20:44:54] <wikibugs> (03PS1) 10Krinkle: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 [20:45:37] <wikibugs> 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3861936 (1001tonythomas) [20:45:40] <wikibugs> 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test `updateName` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183619#3861934 (1001tonythomas) 05Open>03Resolved a:03Albert221 [20:45:43] <tonythomas> approved! [20:45:50] <Albert221> thanks! [20:45:54] <wikibugs> (03CR) 10Krinkle: [C: 04-1] "The two changes in resources/ are fine, but ogv.js is an external lib that shouldn't be modified in this repo. It is also excluded from li" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [20:45:56] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/ArticleRatings] - 10https://gerrit.wikimedia.org/r/400429 (owner: 10SamanthaNguyen) [20:45:56] <Albert221> hello TheresNoTime! [20:46:12] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400430 (owner: 10SamanthaNguyen) [20:46:32] <wikibugs> (03Merged) 10jenkins-bot: Add unit test for NewsletterDb::updateName [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400420 (https://phabricator.wikimedia.org/T183619) (owner: 10Albert221) [20:46:49] <TheresNoTime> Hi Albert221 :-) [20:48:29] <wikibugs> (03CR) 10SamanthaNguyen: [C: 031] Use protocol-relative URLs to avoid mixed content warnings when using HTTPS [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/400208 (https://phabricator.wikimedia.org/T183677) (owner: 10Jack Phoenix) [20:52:11] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/400433 [20:52:27] <wikibugs> (03PS4) 10Umherirrender: @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 [20:52:32] <wikibugs> (03PS5) 10Umherirrender: @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 [20:52:34] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [20:52:56] <tonythomas> or we got `resetDB()` which might be faster actually. lets see [20:53:21] <wikibugs> (03PS1) 10Krinkle: phpunit: Remove outdated comment about calling of LinkCache::clear() [core] - 10https://gerrit.wikimedia.org/r/400434 [20:53:41] <wikibugs> (03CR) 10Umherirrender: "Patch Set 3: Removed changes to lib" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [20:53:45] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/400433 (owner: 10SamanthaNguyen) [20:54:32] <wikibugs> (03PS2) 10Krinkle: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 [20:54:50] <wikibugs> 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982#3861955 (10Albert221) [20:56:02] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/FanBoxes] - 10https://gerrit.wikimedia.org/r/400433 (owner: 10SamanthaNguyen) [20:56:14] <Urbanecm> I would like to see T182407 completed. I am member of Czech Arbitation Comittee and I NEED my arbcomwiki account to do my work. If any other identity-prove is needed, please notify me. [20:56:15] <stashbot> T182407: Strip 2FA for 'Martin Urbanec' account at arbcom-cs.wikipedia.org - https://phabricator.wikimedia.org/T182407 [20:56:42] <wikibugs> (03CR) 10Phuedx: [C: 032] Use absolute class name in @covers [extensions/Popups] - 10https://gerrit.wikimedia.org/r/400426 (owner: 10Umherirrender) [20:56:46] <wikibugs> (03CR) 10Phuedx: [C: 032] "Thanks!" [extensions/Popups] - 10https://gerrit.wikimedia.org/r/400426 (owner: 10Umherirrender) [20:57:04] <tonythomas> self::useTemporaryTables = True; [20:57:32] <wikibugs> (03CR) 10Krinkle: [C: 032] @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [20:57:34] <wikibugs> (03CR) 10Isarra: [C: 031] Use protocol-relative URLs to avoid mixed content warnings when using HTTPS [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/400208 (https://phabricator.wikimedia.org/T183677) (owner: 10Jack Phoenix) [20:57:52] <wikibugs> (03CR) 10Krinkle: [C: 032] Use absolute class name in @covers [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/400423 (owner: 10Umherirrender) [20:58:11] <wikibugs> (03CR) 10Krinkle: [C: 032] Use absolute class name in @covers [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/400424 (owner: 10Umherirrender) [20:58:17] <wikibugs> (03CR) 10Krinkle: [C: 032] Fix typo in @covers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/400414 (owner: 10Umherirrender) [20:58:36] <wikibugs> 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Multimedia: Uploading XML files broken? - https://phabricator.wikimedia.org/T183727#3861956 (10Cavila) [20:58:56] <wikibugs> 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Multimedia: Uploading XML files broken? - https://phabricator.wikimedia.org/T183727#3861968 (10Cavila) [20:59:08] <wikibugs> (03CR) 10Krinkle: [C: 032] Fix class name in @covers [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/400431 (owner: 10Umherirrender) [20:59:49] <wikibugs> (03CR) 10Krinkle: [C: 032] "Thanks!" [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [20:59:51] <wikibugs> (03PS1) 10Umherirrender: Register QuestyCaptcha class ealier in unit tests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/400435 [21:00:13] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/400436 [21:01:01] <wikibugs> (03Merged) 10jenkins-bot: Use absolute class name in @covers [extensions/Popups] - 10https://gerrit.wikimedia.org/r/400426 (owner: 10Umherirrender) [21:01:04] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 (owner: 10Krinkle) [21:03:46] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/400437 [21:07:12] <wikibugs> (03Merged) 10jenkins-bot: Use absolute class name in @covers [extensions/GWToolset] - 10https://gerrit.wikimedia.org/r/400423 (owner: 10Umherirrender) [21:07:22] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [21:08:58] <wikibugs> (03Merged) 10jenkins-bot: Use absolute class name in @covers [extensions/PageImages] - 10https://gerrit.wikimedia.org/r/400424 (owner: 10Umherirrender) [21:08:59] <wikibugs> (03Merged) 10jenkins-bot: Fix typo in @covers [extensions/CentralAuth] - 10https://gerrit.wikimedia.org/r/400414 (owner: 10Umherirrender) [21:09:01] <wikibugs> (03Merged) 10jenkins-bot: Fix class name in @covers [extensions/Quiz] - 10https://gerrit.wikimedia.org/r/400431 (owner: 10Umherirrender) [21:10:25] <wikibugs> 10MediaWiki-Codesniffer: Add PHPCS rule to autofix some aliased PHP function names for consistency - https://phabricator.wikimedia.org/T183220#3861984 (10Krinkle) [21:10:29] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/400439 [21:10:32] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use protocol-relative URLs to avoid mixed content warnings when using HTTPS [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/400208 (https://phabricator.wikimedia.org/T183677) (owner: 10Jack Phoenix) [21:10:44] <wikibugs> (03CR) 10Umherirrender: "recheck" [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 (owner: 10Umherirrender) [21:13:00] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400440 [21:14:02] <swayam> Hi All, I have created the IRC account and followed all the steps. How do i create this as a file, so i can submit the task on Google Code-in [21:14:17] <swayam> Can someone please help me ? [21:14:44] <Phantom42> swayam: Welcome! [21:14:55] <Phantom42> For this task you do not need to submit any file [21:14:56] <wikibugs> (03Merged) 10jenkins-bot: Add grep comment for js vars wgRestriction* [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [21:14:58] <wikibugs> (03Merged) 10jenkins-bot: Use protocol-relative URLs to avoid mixed content warnings when using HTTPS [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/400208 (https://phabricator.wikimedia.org/T183677) (owner: 10Jack Phoenix) [21:15:09] <Phantom42> Just include your username in comments under the task [21:15:13] <swayam> Hi Phantom42 thanks. [21:15:20] <Albert221> tonythomas, hey, I'm at point of styling the labels for the fields for this: T180982. I thought of creating new HTMLElement for that, because I don't see other option to change the label appearance of OOUI element. What do you think? [21:15:21] <stashbot> T180982: Individual newsletter pages should have a visual hierarchy - https://phabricator.wikimedia.org/T180982 [21:15:35] <swayam> Thanks [21:15:49] <wikibugs> (03CR) 10Krinkle: Change php extract() to explicit code (031 comment) [core] - 10https://gerrit.wikimedia.org/r/396131 (owner: 10Umherirrender) [21:16:58] <wikibugs> 10MediaWiki-General-or-Unknown, 10Technical-Debt: PHP extract() sucks (change for explicit definition) - https://phabricator.wikimedia.org/T28496#3861988 (10Krinkle) [21:17:26] <wikibugs> 10MediaWiki-General-or-Unknown, 10Technical-Debt: Remove use of PHP extract() function (use explicit assignment) - https://phabricator.wikimedia.org/T28496#307976 (10Krinkle) [21:17:45] <tonythomas> Albert221: tbh I do not have an answer for you sadly. Can you just ask this in #wikimedia-design ? [21:18:33] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/400437 (owner: 10SamanthaNguyen) [21:18:40] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/400436 (owner: 10SamanthaNguyen) [21:18:55] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/400439 (owner: 10SamanthaNguyen) [21:19:02] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400440 (owner: 10SamanthaNguyen) [21:21:08] <Albert221> btw this is somewhat not nice that Wikimedia uses it's own library for UI because googling almost always doesn't help [21:21:52] <wikibugs> (03PS1) 10LukBukkit: Moved the $this references into variables [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) [21:22:20] <Phantom42> Well, docs for OOUI are pretty helpful [21:22:46] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/MiniInvite] - 10https://gerrit.wikimedia.org/r/400437 (owner: 10SamanthaNguyen) [21:22:48] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/LinkFilter] - 10https://gerrit.wikimedia.org/r/400436 (owner: 10SamanthaNguyen) [21:22:55] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/PictureGame] - 10https://gerrit.wikimedia.org/r/400439 (owner: 10SamanthaNguyen) [21:23:01] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400440 (owner: 10SamanthaNguyen) [21:23:21] <wikibugs> (03CR) 1001tonythomas: [C: 04-1] "Almost there, minor improvements." (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [21:23:44] <swayam> On Google code-in i have submitted my task for Review. It is not allowing me to claim another task. Do i need to wait to pick up another task until my previous task gets approved ? [21:24:21] <RexxS> that's right [21:24:22] <Phantom42> swayam: Yes, you need to wait [21:24:36] <swayam> okay thank you. [21:24:43] <wikibugs> (03PS2) 10LukBukkit: Moved the $this references into variables [skins/Dusk] - 10https://gerrit.wikimedia.org/r/400441 (https://phabricator.wikimedia.org/T153505) [21:24:58] <Phantom42> By the way, did you read IRC task description attentively? I am afraid it said to wait 1 hour before submitting [21:26:20] <wikibugs> (03CR) 10jenkins-bot: Add grep comment for js vars wgRestriction* [core] - 10https://gerrit.wikimedia.org/r/400265 (owner: 10Umherirrender) [21:26:29] <RexxS> joined 19:56 [21:27:04] <Phantom42> Oh, I am sorry. My mistake [21:27:12] <Phantom42> Everything is right then [21:27:18] <RexxS> doesn't time fly when you're enjoying yourself :) [21:27:27] <Phantom42> :D [21:27:33] <Zppix> Approved must wait for parental consent to be approved. By google [21:30:11] <RexxS> swayam: have you decided which task you're going to do next? [21:30:56] <RexxS> I know d3r1ck was keen for folks to do one of his latest ones [21:31:49] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/400442 [21:32:29] <Albert221> BTW, did Wikimedia thought about implementing WebRTC so that users would send data to each other in P2P mode? This could potentially decrease costs of the servers because servers would be balanced [21:32:53] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/400442 (owner: 10SamanthaNguyen) [21:33:05] <wikibugs> (03CR) 10Krinkle: [C: 032] mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option [core] - 10https://gerrit.wikimedia.org/r/397976 (owner: 10Bartosz Dziewoński) [21:34:01] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/400443 [21:34:27] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/QuizGame] - 10https://gerrit.wikimedia.org/r/400442 (owner: 10SamanthaNguyen) [21:36:57] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/400444 [21:39:09] <tonythomas> Albert221: alright. I looked it up a bit, and do you see that to define a new OOUI element you might need a core change ? [21:39:24] <tonythomas> a better option would bet o just add a `'cssclass' => 'AClassForField1'` to our elements ? [21:39:31] <tonythomas> and define it in our extension css files ? [21:39:32] <tonythomas> simple ? [21:39:38] <wikibugs> (03Merged) 10jenkins-bot: mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option [core] - 10https://gerrit.wikimedia.org/r/397976 (owner: 10Bartosz Dziewoński) [21:39:40] <Albert221> no, I don't have, I'd just have to add 'class' => 'FQCN' [21:39:47] <Albert221> but yes, that might be a better option, thanks! [21:39:53] <tonythomas> FQCN ? [21:40:21] <tonythomas> oh, I thought it was a default OOUI class :P [21:40:23] <tonythomas> nvm. [21:40:35] <tonythomas> anyway, I am off for today. hope to review this tomorrow morning or evening. [21:40:36] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/400445 [21:42:01] <wikibugs> (03PS3) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [21:43:44] <Albert221> FQCN stands for Fully-Qualified Class Name [21:46:48] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/400446 [21:48:17] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/400443 (owner: 10SamanthaNguyen) [21:48:23] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/400444 (owner: 10SamanthaNguyen) [21:48:25] <wikibugs> (03CR) 10jenkins-bot: mw.rcfilters.ui.SaveFiltersPopupButtonWidget: Remove pointless option [core] - 10https://gerrit.wikimedia.org/r/397976 (owner: 10Bartosz Dziewoński) [21:48:31] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/400445 (owner: 10SamanthaNguyen) [21:48:47] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/400446 (owner: 10SamanthaNguyen) [21:50:14] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/RegexBlock] - 10https://gerrit.wikimedia.org/r/400443 (owner: 10SamanthaNguyen) [21:50:16] <wikibugs> (03CR) 1001tonythomas: [C: 04-1] "Few more nits, and good to go." (032 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [21:50:53] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/SpamRegex] - 10https://gerrit.wikimedia.org/r/400444 (owner: 10SamanthaNguyen) [21:50:55] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/SportsTeams] - 10https://gerrit.wikimedia.org/r/400445 (owner: 10SamanthaNguyen) [21:51:03] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/UserStatus] - 10https://gerrit.wikimedia.org/r/400446 (owner: 10SamanthaNguyen) [21:51:42] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/Video] - 10https://gerrit.wikimedia.org/r/400447 [21:53:15] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/Video] - 10https://gerrit.wikimedia.org/r/400447 (owner: 10SamanthaNguyen) [21:55:00] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/Video] - 10https://gerrit.wikimedia.org/r/400447 (owner: 10SamanthaNguyen) [21:55:07] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/400448 [21:57:45] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/400448 (owner: 10SamanthaNguyen) [21:58:21] <wikibugs> (03CR) 10Legoktm: [C: 032] phpunit: Remove outdated comment about calling of LinkCache::clear() [core] - 10https://gerrit.wikimedia.org/r/400434 (owner: 10Krinkle) [21:59:14] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/WhosOnline] - 10https://gerrit.wikimedia.org/r/400448 (owner: 10SamanthaNguyen) [22:01:30] <wikibugs> (03CR) 10Legoktm: [C: 032] Register QuestyCaptcha class ealier in unit tests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/400435 (owner: 10Umherirrender) [22:02:50] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater functions [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/400449 [22:04:39] <wikibugs> (03Merged) 10jenkins-bot: phpunit: Remove outdated comment about calling of LinkCache::clear() [core] - 10https://gerrit.wikimedia.org/r/400434 (owner: 10Krinkle) [22:07:25] <wikibugs> (03Merged) 10jenkins-bot: Register QuestyCaptcha class ealier in unit tests [extensions/ConfirmEdit] - 10https://gerrit.wikimedia.org/r/400435 (owner: 10Umherirrender) [22:08:21] <wikibugs> (03PS1) 10SamanthaNguyen: Use newer DatabaseUpdater function [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/400450 [22:10:43] <Albert221> tonythomas, you maybe still here? [22:10:56] <tonythomas> yep! ssup ? [22:11:44] <wikibugs> (03PS8) 10Krinkle: tests: Commit initial version of DevelopmentSettings.php [core] - 10https://gerrit.wikimedia.org/r/383041 (https://phabricator.wikimedia.org/T177669) [22:11:55] <Albert221> https://i.imgur.com/1hYN1r4.png would that be good or something to fix? [22:12:08] <Albert221> I'll play around heading styles, but how's that except headings? [22:12:41] <tonythomas> Looks good actually. [22:13:25] <tonythomas> feel free to submit the patch set, and add FlorianSW and others on the same. (have to leave now, sorry) \ [22:13:28] <wikibugs> (03PS9) 10Krinkle: tests: Commit initial version of DevelopmentSettings.php [core] - 10https://gerrit.wikimedia.org/r/383041 (https://phabricator.wikimedia.org/T177669) [22:13:42] <Albert221> okay, good night tony! :) [22:14:11] <wikibugs> (03PS4) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [22:14:23] <wikibugs> 10MediaWiki-File-management, 10MediaWiki-Uploading, 10Commons, 10Multimedia: Uploading XML files broken? - https://phabricator.wikimedia.org/T183727#3861956 (10Bawolff) Its an intentional check. IE6 will execute the file as if its html with javascript if any of the tags are htmlish (<head>, <title>, etc)... [22:14:25] <wikibugs> (03CR) 10Krinkle: "@Reedy: Done. Just hoping it won't cause any test failures, but should be fine indeed." [core] - 10https://gerrit.wikimedia.org/r/383041 (https://phabricator.wikimedia.org/T177669) (owner: 10Krinkle) [22:15:24] <wikibugs> (03PS3) 10Krinkle: maintenance: Add unit test for Benchmarker class [core] - 10https://gerrit.wikimedia.org/r/400432 [22:16:24] <wikibugs> (03CR) 10jenkins-bot: phpunit: Remove outdated comment about calling of LinkCache::clear() [core] - 10https://gerrit.wikimedia.org/r/400434 (owner: 10Krinkle) [22:18:35] <wikibugs> (03PS1) 10Albert221: Improve visual hierarchy on Newsletter page [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400451 (https://phabricator.wikimedia.org/T180982) [22:19:10] <wikibugs> (03CR) 1001tonythomas: [C: 032] "LGTM. Thanks :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [22:20:34] <wikibugs> (03CR) 10jerkins-bot: [V: 04-1] Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [22:20:42] <wikibugs> 10MediaWiki-Codesniffer, 10Patch-For-Review: ExtendClassUsageSniff is buggy because it maintains state in the sniff - https://phabricator.wikimedia.org/T179753#3862016 (10Legoktm) 05Open>03Resolved [22:21:06] <wikibugs> 10MediaWiki-Codesniffer, 10Patch-For-Review: Ignore returns in inner functions for MissingReturn sniff - https://phabricator.wikimedia.org/T178243#3862017 (10Legoktm) 05Open>03Resolved [22:21:28] <Albert221> legoktm, do you maybe need a help on something minor? :) [22:21:41] <legoktm> what do you mean? [22:23:07] <wikibugs> (03CR) 1001tonythomas: [C: 04-1] "Oopsie. Please update the complains. Strange" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [22:23:19] <wikibugs> (03PS5) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [22:25:53] <Vulpix> looks like Albert221 is idle and wants something to help :) [22:27:20] <legoktm> ah [22:29:29] <legoktm> Albert221: https://codein.withgoogle.com/tasks/6046218155196416/ should be pretty straightforward if you're interested [22:30:55] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater functions [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/400449 (owner: 10SamanthaNguyen) [22:31:06] <wikibugs> (03CR) 10Jack Phoenix: [C: 032] Use newer DatabaseUpdater function [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/400450 (owner: 10SamanthaNguyen) [22:32:42] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater functions [extensions/WikiForum] - 10https://gerrit.wikimedia.org/r/400449 (owner: 10SamanthaNguyen) [22:33:18] <Albert221> Vulpix, not exactly idle in GCI website terms :D I was thinking if there is something non-GCI to help [22:33:26] <wikibugs> (03Merged) 10jenkins-bot: Use newer DatabaseUpdater function [extensions/Challenge] - 10https://gerrit.wikimedia.org/r/400450 (owner: 10SamanthaNguyen) [22:35:04] <wikibugs> 10MediaWiki-extensions-Other: Quantcast: switch to HTTPS - https://phabricator.wikimedia.org/T183677#3862032 (10SamanthaNguyen) 05Open>03Resolved p:05Triage>03Normal [22:37:49] <Vulpix> Albert221: you may want to improve documentation on mediawiki.org. I'm pretty sure there are some hooks https://www.mediawiki.org/wiki/Manual:Hooks or maintenance scripts https://www.mediawiki.org/wiki/Manual:Maintenance_scripts without documentation pages, or with undocumented parameters [22:40:24] <bawolff> $wgConf $wgLBFactoryConfig (or whatever it is) sure could use better docs [22:40:43] <bawolff> maybe thats throwing you off the deep end though [22:41:02] <bawolff> in terms of missing documentation [22:43:41] <RexxS> https://en.wikipedia.org/wiki/Category:Templates_with_missing_or_incorrect_documentation [22:43:43] <wikibugs> 10ContentTranslation, 10Language-2017-Oct-Dec, 10Patch-For-Review: Support long titles in confirmation step of the new translation dialog - https://phabricator.wikimedia.org/T181701#3862041 (10Petar.petkovic) [22:43:49] <RexxS> you could start there :D [22:44:17] <legoktm> there's also a script that finds hooks that are missing documentation on mediawiki.org [22:47:14] <bawolff> You could fix my totally broken user script https://commons.m.wikimedia.org/wiki/MediaWiki:Gadget-advanced-search.js [22:48:02] <bawolff> I have no idea whats wrong with it other than users complained it stopped working. (It was hacky from get-go) [22:49:27] <wikibugs> 10MediaWiki-extensions-LiquidThreads: 1406 Data too long for column 'th_change_comment' at row 1 - https://phabricator.wikimedia.org/T183731#3862044 (10Kghbln)