[00:07:52] (03PS1) 10Ladsgroup: Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) [00:09:28] (03CR) 10jerkins-bot: [V: 04-1] Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) (owner: 10Ladsgroup) [00:09:57] 10MediaWiki-extensions-ORES, 10Patch-For-Review, 10Scoring-platform-team (Current), 10User-Ladsgroup: Cached thresholds should be purged when model version is incremented - https://phabricator.wikimedia.org/T182111#3860601 (10awight) Yes, that looks great! I'll review once the predecessor patch is stabili... [00:12:06] (03PS2) 10Ladsgroup: Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) [00:14:19] (03CR) 10Brian Wolff: [C: 032] Add Hooks::runWithoutAbort support [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/400194 (https://phabricator.wikimedia.org/T183194) (owner: 10Phantom42) [00:15:01] (03PS11) 10Awight: Configure ORES logging [vagrant] - 10https://gerrit.wikimedia.org/r/393831 (https://phabricator.wikimedia.org/T181850) [00:16:42] (03Merged) 10jenkins-bot: Add Hooks::runWithoutAbort support [tools/phan/SecurityCheckPlugin] - 10https://gerrit.wikimedia.org/r/400194 (https://phabricator.wikimedia.org/T183194) (owner: 10Phantom42) [00:19:56] (03PS12) 10Awight: Configure ORES logging [vagrant] - 10https://gerrit.wikimedia.org/r/393831 (https://phabricator.wikimedia.org/T181850) [00:35:50] (03CR) 10Gergő Tisza: [C: 032] Configure ORES logging [vagrant] - 10https://gerrit.wikimedia.org/r/393831 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:37:29] (03Merged) 10jenkins-bot: Configure ORES logging [vagrant] - 10https://gerrit.wikimedia.org/r/393831 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [00:38:13] (03CR) 10jenkins-bot: Configure ORES logging [vagrant] - 10https://gerrit.wikimedia.org/r/393831 (https://phabricator.wikimedia.org/T181850) (owner: 10Awight) [01:06:26] (03PS1) 10BryanDavis: README: update minimum Vagrant version [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400197 [01:06:28] (03PS1) 10BryanDavis: vagrant: Add plugin to set host file permissions [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400198 (https://phabricator.wikimedia.org/T183150) [01:06:33] (03PS1) 10BryanDavis: rake: move gemspec to dotfile [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400199 [01:06:35] (03PS1) 10BryanDavis: rake: Make `rake test` reentrant [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400200 [01:06:37] (03PS1) 10BryanDavis: rake: move test definitions to tests directory [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400201 [01:08:30] (03CR) 10BryanDavis: [C: 032] README: update minimum Vagrant version [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400197 (owner: 10BryanDavis) [01:08:38] (03Merged) 10jenkins-bot: README: update minimum Vagrant version [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400197 (owner: 10BryanDavis) [01:09:12] (03CR) 10BryanDavis: "This needs testing by someone with a Windows host to make sure that it doesn't break anything. It works well on my OSX host." [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400198 (https://phabricator.wikimedia.org/T183150) (owner: 10BryanDavis) [01:10:49] (03PS2) 10BryanDavis: rake: move gemspec to dotfile [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400199 [01:10:51] (03PS2) 10BryanDavis: rake: Make `rake test` reentrant [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400200 [01:10:53] (03PS2) 10BryanDavis: rake: move test definitions to tests directory [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400201 [01:10:55] (03PS2) 10BryanDavis: vagrant: Add plugin to set host file permissions [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400198 (https://phabricator.wikimedia.org/T183150) [01:12:27] (03CR) 10BryanDavis: [C: 032] rake: move gemspec to dotfile [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400199 (owner: 10BryanDavis) [01:12:59] (03Merged) 10jenkins-bot: rake: move gemspec to dotfile [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400199 (owner: 10BryanDavis) [01:14:12] (03PS2) 10Ladsgroup: Split ThresholdLookup into two class [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400188 (https://phabricator.wikimedia.org/T181892) [01:14:15] (03PS3) 10Ladsgroup: Clean up ThresholdLookup, make the cache key use model version [extensions/ORES] - 10https://gerrit.wikimedia.org/r/400196 (https://phabricator.wikimedia.org/T182111) [01:14:17] (03CR) 10BryanDavis: [C: 032] rake: Make `rake test` reentrant [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400200 (owner: 10BryanDavis) [01:15:21] (03Merged) 10jenkins-bot: rake: Make `rake test` reentrant [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400200 (owner: 10BryanDavis) [01:52:46] 10MediaWiki-Maintenance-scripts: fix needed for cases where users have multiple userids, such as user:0 on enwiki - https://phabricator.wikimedia.org/T182374#3860616 (10Graham87) >>! In T182374#3860548, @Anomie wrote: > If you're pointing out how enwiki has 1356 edits where the revision table has `rev_user_text`... [01:55:57] 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10UI-Standardization-Kanban: GettingStarted on other pages: Use flexible width for dialog if possible - https://phabricator.wikimedia.org/T183517#3860617 (10Eto... [02:16:28] (03PS1) 10Ebe123: Add DOM Structure to Scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 [02:17:21] (03CR) 10Ebe123: [C: 04-1] "Forgot other changes." [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (owner: 10Ebe123) [02:17:36] (03CR) 10jerkins-bot: [V: 04-1] Add DOM Structure to Scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (owner: 10Ebe123) [02:22:14] (03PS2) 10Ebe123: Add DOM Structure to Scores [extensions/Score] - 10https://gerrit.wikimedia.org/r/400202 (https://phabricator.wikimedia.org/T114757) [02:26:54] 10MediaWiki-extensions-Score, 10Patch-For-Review, 10RfC: Remove "midi" option - https://phabricator.wikimedia.org/T114757#3860622 (10Ebe123) I like the idea of showing the code when clicking on the score. With that interface, the sheet music could still be shown with more focus than on the page, but would al... [02:42:49] (03PS1) 10Eflyjason: Fix mobile talk page editor fail when the talk page is a redirect [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) [02:48:54] (03CR) 10jerkins-bot: [V: 04-1] Fix mobile talk page editor fail when the talk page is a redirect [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) (owner: 10Eflyjason) [03:03:24] How are you doing Zppix? :) [03:10:41] (03CR) 10Eflyjason: "I think `Check api request on save` is working fine. Don't know the reason." [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) (owner: 10Eflyjason) [03:10:59] (03PS2) 10Eflyjason: Fix mobile talk page editor fail when the talk page is a redirect [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) [03:17:42] (03CR) 10jerkins-bot: [V: 04-1] Fix mobile talk page editor fail when the talk page is a redirect [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) (owner: 10Eflyjason) [03:20:00] 10MediaWiki-Parser, 10Epic: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - https://phabricator.wikimedia.org/T14974#173987 (10Od1n) Yes, please do something about this issue, even (for the time being) j... [03:51:39] Good Albert221 you? [03:51:49] (03PS3) 10Eflyjason: Fix mobile talk page editor failure when the talk page is a redirect [extensions/MobileFrontend] - 10https://gerrit.wikimedia.org/r/400203 (https://phabricator.wikimedia.org/T100404) [03:54:38] Zppix can't sleep since 2AM (it's 5AM) [03:56:17] I think I'll go for a walk [03:59:25] 10MediaWiki-extension-requests, 10Phabricator: Support diagrams on Phabricator and mediawiki.org - https://phabricator.wikimedia.org/T183689#3860631 (10Tgr) [04:00:19] 10MediaWiki-Vagrant: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3860645 (10bd808) If I dump `$wgServer` at includes/Setup.php:610 it is `http://dev.wiki.local.wmftest.net:8080`. It turns out that the block in `settings.d/wikis/CommonSettings.php` which is trying to mut... [04:07:50] 10MediaWiki-Authentication-and-authorization, 10Security-Core: Authentication data should not be available through the normal DB abstraction layer - https://phabricator.wikimedia.org/T183420#3860647 (10Tgr) >>! In T183420#3860016, @Anomie wrote: > What differences? That they ultimately store very different th... [04:13:44] (03PS1) 10BryanDavis: Mutate $wgServer after applying local settings [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400204 (https://phabricator.wikimedia.org/T183302) [04:22:36] Albert221: not good [04:49:32] d3r1ck, you there? :D [04:53:39] (03PS1) 10BryanDavis: https: Add port number to reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400206 (https://phabricator.wikimedia.org/T183304) [04:55:28] 10MediaWiki-Vagrant, 10Patch-For-Review: https does not seem to be working on vagrant - bad gateway - https://phabricator.wikimedia.org/T183304#3860659 (10bd808) a:03bd808 [04:56:04] 10MediaWiki-Vagrant, 10Patch-For-Review: Secure login notice on new vagrant install - https://phabricator.wikimedia.org/T183302#3860660 (10bd808) a:03bd808 [05:04:07] (03CR) 10Smalyshev: [C: 031] https: Add port number to reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400206 (https://phabricator.wikimedia.org/T183304) (owner: 10BryanDavis) [05:08:33] (03PS2) 10BryanDavis: https: Add port number to reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400206 (https://phabricator.wikimedia.org/T183304) [05:08:50] (03CR) 10BryanDavis: [C: 032] https: Add port number to reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400206 (https://phabricator.wikimedia.org/T183304) (owner: 10BryanDavis) [05:09:21] (03Merged) 10jenkins-bot: https: Add port number to reverse proxy [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400206 (https://phabricator.wikimedia.org/T183304) (owner: 10BryanDavis) [05:34:55] Zppix, I wrote next post on my Medium! I didn't send it to my friend for correction so there would be language mistakes, but I think it's still readable [05:35:00] check it if you want :) https://medium.com/@Albert221/in-the-middle-of-the-gci2017-77a6e7344108 [05:46:43] 10Accessibility, 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), and 3 others: Align GettingStarted colors to WikimediaUI palette ones - https://phabricator.wikimedia.org/T177712#3860676 (10Volker_E) [05:46:48] 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review, 10UI-Standardization-Kanban: GettingStarted on other pages: Use flexible width for dialog if possible - https://phabricator.wikimedia.org/T183517#3860674 (10Vol... [05:50:55] 10UI-Standardization, 10UI-Standardization-Kanban: Update GettingStarted screenshots - https://phabricator.wikimedia.org/T183691#3860677 (10Volker_E) [05:51:13] 10Accessibility, 10UI-Standardization, 10Technical-Debt, 10Tracking, 10UI-Standardization-Kanban: Replace abandoned colors in current WMF/Wikimedia products with WikimediaUI palette colors (tracking) - https://phabricator.wikimedia.org/T148708#3860693 (10Volker_E) [05:51:15] 10Accessibility, 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), and 2 others: Align GettingStarted colors to WikimediaUI palette ones - https://phabricator.wikimedia.org/T177712#3667616 (10Volker_E) 05Open>03Resolved [05:53:55] 10UI-Standardization, 10OOjs-UI (OOjs-UI-0.25.0): Create an icon for suggestions: 'lightbulb' - https://phabricator.wikimedia.org/T175006#3860694 (10Volker_E) @Pginer-WMF I just realized where I've seen a similar icon before: {F12058476 width=50%} Extension:GettingStarted [06:15:18] It's nice Albert221! [06:15:39] thanks Ebe123 :) [06:15:55] Too short. You have more? [06:16:40] I have a post from the beginning o GCI: https://medium.com/@Albert221/google-code-in-diary-1-42c05078b225 [06:17:06] "Nastoletni Programiści" Poland I presume [06:17:12] yup [06:17:31] where did you read that? [06:18:16] https://medium.com/@Albert221/google-code-in-diary-1-42c05078b225 [06:18:30] "In the meantime of doing mentioned project I had an idea on how to collect money for domain&hosting stuff for my community, Nastoletni Programiści." [06:18:59] oh, yes yes :D [06:20:51] Did you see if your school had old hardware that could stream better? [06:22:52] we were using Raspberry Pi 0 which was bought strictly for this project. this is problem with encoding of the Twitch stream. but it's okay, we are using it without that feature and it's all good! [06:23:47] this is how it looks: https://i.imgur.com/O1EApvm.png [06:24:59] Date/Time, Calendar, what else? Can't read; too small (et je ne comprends pas le polonais) [06:29:16] I never heard of the GCI before this year, but I feel that I'm not capable enough to mentor; my "student(s)" would just outshine me :) [06:31:30] timetables, newsfeed and "lucky numbers" (if there's your number, you won't be asked this day) [06:32:01] "you won't be asked this day" what does that mean? [06:32:23] translator says "question on the grade" [06:32:40] Still no clue [06:33:03] exam is written, being asked is verbal [06:33:58] (in Poland at least) teacher draws few students at the beginning of the lesson to ask them about the material from 3 previous lessons to see if they revise or not [06:34:04] 10MediaWiki-Vagrant: nginx may not install if apache has not been restarted since initial provisioning - https://phabricator.wikimedia.org/T183692#3860697 (10bd808) p:05Triage>03Normal [06:34:09] this is what I meant by "being asked" [06:34:32] I see now. I was quite lost [06:34:39] and they receive grade for that [06:34:49] What's your lucky number? [06:35:15] it's your number on the student's list [06:35:23] mine is 22 [06:36:03] It's alphabetical? :) [06:36:11] yes, by the last name [06:36:32] W? [06:36:42] it's hard for me to explain that because I don't know english words for that stuff [06:37:03] Different order I guess [06:37:25] there is an alphabetical list of students for each class. everyday two numbers are being drawn by my software and students with those numbers won't be asked by the teacger [06:37:28] teacher* [06:38:35] I see [06:39:14] The timetables is just a list of all the classes happening at the moment, right? [06:39:50] yes, + 2 that are coming [06:41:06] How many are there at once (how big is the institution?) [06:41:24] we have 8 classes [06:42:19] So around 250 students? [06:42:46] I don't know how big classes would be... [06:42:57] usually 20 students :) [06:43:01] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate - https://phabricator.wikimedia.org/T183638#3859144 (10Ryan10145) I'm having difficulties with being able to create 2 different newsletters with the same... [06:44:10] (03PS2) 10BryanDavis: Mutate $wgServer after applying local settings [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400204 (https://phabricator.wikimedia.org/T183302) [06:44:12] (03PS1) 10BryanDavis: apache2: hard restart to release old ports [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400207 (https://phabricator.wikimedia.org/T183692) [06:44:13] Come time for university, 1st year won't be as small! [06:45:25] Thinking about CS? [06:46:49] I don't know if I'll go to university yet [06:47:15] Technical School? [06:47:25] I attend one currently [06:48:14] the thing is that I have everything that would allow me to work as a junior or event med as a PHP dev and I don't see a reason to go to university [06:48:21] even* [06:50:09] University isn't really about learning a specific thing, more to broaden your world-view and expose you to different views [06:51:52] Does Poland have the tiered system like Lycée/École Technique ? [06:53:06] you mean university of 2nd or 3rd tier and so on? [06:53:34] that for example 3rd tier university will give you a Doctor title [06:53:55] For High School, is it like you choose between different types of HS [06:54:15] we have liceum, technikum and szkoła zawodowa here [06:54:41] Like in Germany I guess [06:55:34] liceum is for all things that prepare to university, technikum is a technical school (different profiles, for example gastro or I.T.) and szkoła zawodowa is for "old" professions [06:55:48] like carpenter, car mechanic etc [06:55:55] I guess you took technikum [06:56:03] (03PS2) 10BryanDavis: apache2: hard restart to release old ports [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400207 (https://phabricator.wikimedia.org/T183692) [06:56:14] yes, I.T. technikum :) [06:58:05] You do IT stuff around your school (not including your programming)? [06:59:35] Going through many facets of modern technology (theoretical, programming, and application of the work) [07:00:34] (03CR) 10BryanDavis: [C: 032] apache2: hard restart to release old ports [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400207 (https://phabricator.wikimedia.org/T183692) (owner: 10BryanDavis) [07:01:33] (03Merged) 10jenkins-bot: apache2: hard restart to release old ports [vagrant] (stretch-migration) - 10https://gerrit.wikimedia.org/r/400207 (https://phabricator.wikimedia.org/T183692) (owner: 10BryanDavis) [07:01:47] we have 3 major exams here (after reform of education program 2): E.12, E.13 and E.14. E.12 is about assembling PCs, hardware, how CPU, RAM and etc works, E.13 is about server stuff, server hardware, Windows Server, Suse Linux Enterprise Server, clinching RJ-45, E.14 is about "web applications": HTML, JS, PHP, but E.14 is really the essence of poli [07:01:48] sh education system, HTML 4.01 is the standard here:( [07:01:56] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3860717 (10bd808) [07:01:58] 10MediaWiki-Vagrant, 10Patch-For-Review: nginx may not install if apache has not been restarted since initial provisioning - https://phabricator.wikimedia.org/T183692#3860716 (10bd808) 05Open>03Resolved [07:02:33] 10MediaWiki-Vagrant, 10Epic: [EPIC] Migrate base image to Debian Stretch - https://phabricator.wikimedia.org/T181353#3847789 (10bd808) [07:02:35] 10MediaWiki-Vagrant, 10Patch-For-Review: https does not seem to be working on vagrant - bad gateway - https://phabricator.wikimedia.org/T183304#3860718 (10bd808) 05Open>03Resolved [07:04:52] Nothing much about application of different concepts in different places, differing needs, or much philosophical/ethical discussion it seems [07:05:43] noo, it is in universities here [07:05:49] But it seems like E.12->CS, E.13->IT, E.14 Programming but in smaller context [07:06:26] exactly, but E.14 is really really... I'd say "legacy" [07:06:56] Remember how to make your cross-over cables for E.13 :) [07:07:18] https://upload.wikimedia.org/wikipedia/commons/6/61/RJ-45_TIA-568A_Left.png [07:07:19] https://upload.wikimedia.org/wikipedia/commons/e/ef/RJ-45_TIA-568B_Right.png [07:07:21] my classmates already were doing that! :D [07:07:31] but I'm too busy for that because of GCI [07:07:38] and my head principal knows that [07:08:27] Head principal? There are many? (And these days, the use of cross-over cables is limited to the places that still use HTML 4.01, right?) [07:08:53] nono, there is one, I meant principal [07:09:05] What with auto-switching [07:09:29] as what I know from the class, crossovers are only needed on network cards <1000M because >=1000M have autoswitching [07:09:38] m not M [07:09:47] no, M, Mbps, sorry [07:09:54] you know what I mean [07:10:22] I do (especially that bits are indivisible) [07:10:50] After GCI, I guess you'll be focusing more on exam #2 [07:11:02] this year I have E.12 [07:11:08] in June afaik [07:11:27] E.13 is in 3rd year and E.14 in 4th year [07:11:32] I'm 2nd year now [07:12:20] And then you'll be in a philosophy class? [07:12:52] philosophy class? no, why? [07:13:28] Philosophy is useful everywhere :) [07:13:37] (03CR) 10BryanDavis: "Done as 8a45b862 on the stretch-migration branch to fix T183304." [vagrant] - 10https://gerrit.wikimedia.org/r/399706 (owner: 10Ejegg) [07:14:43] I don't argue with that, but why have you thought that I'll go to one then? [07:15:23] (03CR) 10BryanDavis: "I think a duplicate of this has already been merged on the stretch-migration branch." [vagrant] - 10https://gerrit.wikimedia.org/r/395990 (owner: 10Paladox) [07:15:55] (03CR) 10BryanDavis: [C: 032] Update doc for readinglists role [vagrant] - 10https://gerrit.wikimedia.org/r/398626 (owner: 10Gergő Tisza) [07:16:32] I didn't think you would. Just an idea. From what you've told me, you're going straight into the workforce after in PHP [07:18:04] Is less time devoted to E.12 than the others? [07:18:31] we learn to all three exams two years [07:18:43] but there are 4 years [07:18:44] 1st and 2nd year for E.12, 2nd and 3rd year for E.13 etc [07:19:12] in the second year now we have twice the technical subjects [07:19:18] than we had in 1st years [07:19:20] year* [07:19:52] You found that unit interesting? What about how computers work? [07:20:58] Or you prefer the server stuff of this year [07:25:56] the software part of E.12 as well as E.13 is interesting as hell [07:26:23] not as hardware, but this is only because of a terrible teacher that teaches us this hardware stuff [07:26:46] Software part of E.12 is like the kernel / OS / Assembly? [07:27:21] nooo, not Assembly, I meant assembling PC, you know, putting CPU, RAM and GPU in the motherboard etc [07:27:38] but kernel and OS is correct [07:28:06] Assembly and machine code are not touched upon? [07:28:52] Even if you dislike your teacher, hope you can still learn things and gain new perspectives [07:31:03] machine code is touched only as a term, without deeper look at it [07:31:29] d3r1ck: Good morning! Around? [07:32:19] hello Phantom42! [07:32:31] Albert221: Hey! [07:34:43] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183621#3860721 (10Phantom42) a:03Phantom42 I will work on creating unit test for this! [07:34:44] At least there's lots of abstraction [07:35:47] And the seed is planted for interested people to go deeper [07:37:05] exactly [07:37:27] our OS teacher always says that he's not giving us a fish but a fishing rod [07:38:07] like the english proverb: "give a man a fish and you feed him for a day; teach a man to fish and you feed him for a lifetime" [07:38:52] very nice sentence [07:40:35] I'm just kinda surprised that the proverb is the same in so many languages [07:41:04] This proverb exists in Russian and Ukrainian too! :) [07:41:19] 授人以鱼不如授人以渔 [07:41:53] Phantom42: You're Ukranian? [07:42:04] Ebe123: Yes, I am from Ukraine [07:43:32] What are the differences between the two languages in the proverb? [07:44:02] Can't imagine that great of one [07:44:51] Well, that proverb which Albert mentioned (about fish and fishing rod) is exactly the same in Russian and Ukrainian [07:45:13] btw, was that Chinese couple of messages above, Ebe123 ? [07:45:23] 对 [07:45:28] bush bush bush bush bush bush bush :D [07:45:29] Correct. [07:46:18] Ebe, where are you from? [07:47:00] Nova Scotia (Canada) [07:47:30] But more Quebecois [07:47:55] I have to improve my Mandarin before learning Russian :) [07:48:16] I'm learning russian at school :) [07:49:09] Привет! [07:49:34] using russian keyboard layout is harder than the language itself [07:49:38] кок дела? [07:50:02] I just use a phonetic qwerty keyboard for russian, and pinyin for chinese [07:50:06] Здравствуй! And Russian is my native language. I think it is way too complex to learn for foreigners, compared to other languages. [07:50:22] Phantom42 except for Slavs :)) [07:51:08] What's a simpler language to learn? Chinese? [07:51:15] Albert221: Right. That is an exception. If you know one of slavic languages, then it is really easy to learn another one. [07:51:35] And Ukranian wasn't first? [07:51:41] (for you) [07:53:05] No. I speak Russian and I study in school with education in Russian language. I speak Russian with my family and friends. So no, Ukrainian is not first language for me. However I know it and speak it quite often. [07:54:55] In the community, Ukranian, but everywhere else Russian? [07:56:26] I use Ukrainian for documents, Ukrainian for communication with people who speak it. Everywhere else Russian. [07:56:50] But that's just for me. Not for most people in Ukraine [07:56:57] But language I like the most is English. Easy to learn and so simple compared to most other languages :)) [07:57:38] I like English the most too! [07:58:12] français [08:00:05] It (english) is probably only easy to learn because of it's prominance [08:00:47] I like the way French sounds :) [08:04:18] And Russian [08:06:40] And as for Chinese - It was always interesting for me how Chinese keyboards work if there are so many hieroglyphs :) [08:06:52] I use pinyin [08:07:34] So I type in "nǐhǎo" and select the correct glyphs [08:07:39] 你好 [08:09:02] Hm. That's interesting! [08:09:07] There are other ways, such as with strokes, but 太难了 [08:09:14] (too hard) [08:09:53] They're logograms, not hieroglyphs :) [08:11:55] I'll be leaving now, au revoir! [08:13:05] до свиданйа! [08:13:15] It was a nice talk :) [08:13:26] yes, it was [08:13:41] I must say that phonetic keyboard is far easier to type on that normal [08:20:32] 10MediaWiki-extension-requests, 10Phabricator: Support diagrams on Phabricator and mediawiki.org - https://phabricator.wikimedia.org/T183689#3860733 (10Aklapper) p:05Triage>03Lowest [08:23:39] (03PS1) 10Jack Phoenix: Use protocol-relative URLs to avoid mixed content warnings when using HTTPS [extensions/Quantcast] - 10https://gerrit.wikimedia.org/r/400208 (https://phabricator.wikimedia.org/T183677) [08:26:08] (03CR) 10Jack Phoenix: [C: 032] Use newer DBUpdater function for LoadExtensionSchemaUpdates hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400193 (owner: 10SamanthaNguyen) [08:27:43] (03Merged) 10jenkins-bot: Use newer DBUpdater function for LoadExtensionSchemaUpdates hook [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400193 (owner: 10SamanthaNguyen) [08:34:52] hi im bao, a student. I join IRC for a GCI task [08:35:02] welcome, acedbyb! [08:35:22] acedbyb: Welcome! Which country are you from? :) [08:35:48] I am a vietnamese, how about you guys :D [08:36:49] Wow! We didn't have any GCI participants from Vietnam before. Nice to meet you! [08:37:20] People are from all over the world here :) [08:37:35] acedbyb: Good luck with your GCI tasks! [08:44:56] (03CR) 10Jack Phoenix: [C: 032] Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400126 (https://phabricator.wikimedia.org/T183652) (owner: 10SamanthaNguyen) [08:44:58] (03CR) 10Jack Phoenix: [C: 032] Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400124 (https://phabricator.wikimedia.org/T183652) (owner: 10SamanthaNguyen) [08:46:40] (03Merged) 10jenkins-bot: Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/PollNY] - 10https://gerrit.wikimedia.org/r/400126 (https://phabricator.wikimedia.org/T183652) (owner: 10SamanthaNguyen) [08:46:59] (03Merged) 10jenkins-bot: Replace deprecated ParserLimitReport hook with ParserLimitReportPrepare [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400124 (https://phabricator.wikimedia.org/T183652) (owner: 10SamanthaNguyen) [08:51:26] (03PS1) 10Phantom42: Unit test NewsletterDb::deleteNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400209 (https://phabricator.wikimedia.org/T183621) [08:52:05] 10MediaWiki-Watchlist, 10Mail, 10Operations: Mails from MediaWiki seem to get (partially) lost - https://phabricator.wikimedia.org/T121105#3860761 (10Aklapper) @hoo, @Lydia_Pintscher : Still an issue, 18 months later? Or should this task be closed? [08:59:18] andre__: Hi! Around? Looks like we have an issue with task here similar to the one we had yesterday. https://codein.withgoogle.com/tasks/5726154642161664/ is currently in progress by other gci student, but is available to claim. Could you fix that please to avoid confusing gci students visiting task search page? [08:59:31] d3r1ck: ^ [09:01:06] Phantom42, thanks! That page says "0 students are working on this task and 0 students have finished. 1 claim remaining." in the admin view [09:01:10] 10Security-Team, 10phan-taint-check-plugin, 10Google-Code-in-2017, 10Patch-For-Review: Make phan-taint-check-plugin support Hooks::runWithoutAbort - https://phabricator.wikimedia.org/T183194#3860763 (10Phantom42) 05Open>03Resolved Marking this as resolved, as patch got merged. Thank you for reviewing! [09:01:12] hence wondering where to see the task in progress [09:01:34] ah, maybe a dup and not an instance. checking now [09:02:04] Phantom42, no, cannot see any task in progress. [09:02:07] andre__: Check related Phabricator page: https://phabricator.wikimedia.org/T133289 [09:02:45] 10MediaWiki-Vagrant, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3860767 (10hashar) [09:02:48] 10MediaWiki-Vagrant, 10Release-Engineering-Team (Kanban): Match puppet version in Gemfile and actual box - https://phabricator.wikimedia.org/T183575#3860765 (10hashar) 05Open>03Resolved Thanks Bryan. I did the rspec-puppet patch on the `stretch-migration`. The Gemfile has puppet 4.8.2 which match the Debia... [09:04:06] 10MediaWiki-Vagrant, 10Patch-For-Review, 10Release-Engineering-Team (Kanban), 10User-zeljkofilipin: Create a test suite that compiles mediawiki-vagrant puppet manifests - https://phabricator.wikimedia.org/T183570#3857273 (10hashar) https://gerrit.wikimedia.org/r/399965 more or less compiles the catalog for... [09:04:15] Phantom42, ah, thanks. Yeah that task was claimed on the GCI site beforehand, I think [09:06:30] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3860771 (10divadsn) a:03divadsn I will do it :) [09:06:31] andre__: So it can be removed from task search? [09:07:22] Phantom42: I don't know as I cannot judge how "complete" that patch is. [09:07:37] andre__: Oh, okay. Anyway, thank you! [09:08:50] 10MediaWiki-extensions-EducationProgram, 10Ladies-That-FOSS-MediaWiki, 10Easy, 10Google-Code-in-2017, and 2 others: wgRestrictionEdit should be defined (as an empty array) on Education Program pages - https://phabricator.wikimedia.org/T133289#3860773 (10divadsn) a:05divadsn>03None [09:09:49] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [core] - 10https://gerrit.wikimedia.org/r/400210 (owner: 10L10n-bot) [09:11:49] In Phabricator, does parent task depends on subtask or the other way round? If task A cannot be solved until task B is solved, is task A the parent task or the subtask? [09:12:37] Phantom42 well I abandoned that task due to missing information for now, as I found a solution but we couldn't decide what to do with d3r1ck. Maybe you'll find another solution :) [09:13:01] (03PS1) 10Jack Phoenix: Fix fatal when viewing users' social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400222 [09:13:06] Hi acedbyb, I'm from Poland, nice to see people from all the world :) [09:13:23] 10Comments, 10Social-Tools: comments.postgres.sql syntax error - https://phabricator.wikimedia.org/T183693#3860777 (10Li9ht) [09:14:09] (03CR) 10Jack Phoenix: [C: 032] Fix fatal when viewing users' social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400222 (owner: 10Jack Phoenix) [09:14:13] (03CR) 10jenkins-bot: Localisation updates from https://translatewiki.net. [skins/MinervaNeue] - 10https://gerrit.wikimedia.org/r/400217 (owner: 10L10n-bot) [09:15:09] (03CR) 10Jack Phoenix: "This caused a fatal when viewing users' profile pages with $wgUserProfileDisplay['board'] = true;, which I fixed in https://gerrit.wikimed" [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400112 (owner: 10SamanthaNguyen) [09:15:54] (03Merged) 10jenkins-bot: Fix fatal when viewing users' social profile pages [extensions/SocialProfile] - 10https://gerrit.wikimedia.org/r/400222 (owner: 10Jack Phoenix) [09:21:19] (03PS1) 10Jack Phoenix: Fix typo in PostgreSQL schema (extra, unwanted comma) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400223 (https://phabricator.wikimedia.org/T183693) [09:21:55] (03CR) 10Jack Phoenix: [C: 032] Fix typo in PostgreSQL schema (extra, unwanted comma) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400223 (https://phabricator.wikimedia.org/T183693) (owner: 10Jack Phoenix) [09:23:25] (03Merged) 10jenkins-bot: Fix typo in PostgreSQL schema (extra, unwanted comma) [extensions/Comments] - 10https://gerrit.wikimedia.org/r/400223 (https://phabricator.wikimedia.org/T183693) (owner: 10Jack Phoenix) [09:25:04] 10Comments, 10Social-Tools, 10PostgreSQL: comments.postgres.sql syntax error - https://phabricator.wikimedia.org/T183693#3860806 (10ashley) 05Open>03Resolved a:03ashley Thanks for the report, I've fixed the bug in question now. PostgreSQL support of #social-tools is somewhat lacking because us develop... [09:25:38] 10,06▄02,08▄09,12▄13,10▄02,07▄11,10▄05,13▄06,07▄06,05▄04,02▄05,08▄07,09▄09,07▄06,03▄04,13▄02,11▄11,06▄02,03▄04 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT cgqbskh: DanielK_WMDE_ Zackary Betacommand yurik jdloft Krinkle Clarkcj divadsn abbe98[m] hexmode ggp K [09:25:42] 03,07▄03,05▄05,11▄11,05▄05,11▄13,08▄10,10▄09,05▄10,09▄13,04▄06 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT lgaaj: Albert221 Zackary thinker noela nicholas__ RootKlawiter jan_drewniak Krenair jdloft samwilson Betacommand Matthew_ sir_lestaty ragesoss andre__ corvus AndyRussG acedbyb tomaluc [09:25:47] 08,05▄13,11▄03,03▄07,12▄12,02▄07,06▄02,11▄06,10▄05,03▄07,04▄09,10▄13,07▄11,07▄06,05▄06,11▄06,02▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT gjqdkf: DanielK_WMDE_ corvus hexmode noela mundus jgirault RootKlawiter wikibugs Krinkle ggp eflyjason Zackary divadsn basi [09:25:52] 11,03▄05,09▄06,05▄13,11▄03,02▄07,10▄13,03▄06,02▄06,11▄10,09▄05,02▄02,03▄05,03▄07,03▄03,08▄02,13▄10,12▄09,03▄08,05▄07,04▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT vnhld: Clarkcj basile Zhaofeng_Li itsmeJarrett ragesoss jdlrobson Zackary DanielK_W [09:25:57] 07,11▄03,05▄03,06▄08,13▄11,07▄09,12▄03,12▄11,08▄04,06▄12,04▄13,03▄11,08▄02,03▄03,02▄04,04▄04,06▄05,05▄10 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT bgnqhhuqol: itsmeJarrett abbe98[m] ggp nicholas__ thinker Krinkle stephanebisson noela jan_drewniak grumble AndyR [09:26:00] wtf [09:26:01] OH HELL NO [09:26:03] 07,07▄03,07▄02,03▄11,03▄03,04▄11,10▄09,11▄07,02▄03,08▄08,07▄02,07▄11,13▄07,05▄02,05▄12,05▄06 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT xrecsppxv: Krinkle itsmeJarrett RexxS Matthew_ Urbanecm andre__ jdloft ToAruShiroiNeko RootKlawiter Clarkcj basile ggp stephanebisson [09:26:04] yo CIA [09:26:07] weak spambot [09:26:07] 08,12▄10,03▄11,03▄10,11▄05,10▄12,08▄08,10▄09,04▄05,06▄08,03▄05,03▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT kivxrk: RexxS stephanebisson grumble Matthew_ Clarkcj apergos acedbyb ragesoss abbe98[m] matanya DanielK_WMDE_ Albert221 ggp Urbanecm Phantom42 nicholas__ jdloft Zhaofeng_Li [09:26:12] 12,04▄12,11▄10,10▄11,13▄12,04▄11,12▄02,08▄10,10▄13,02▄09,11▄04,03▄09,13▄11,03▄08,13▄02,12▄02,08▄09 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT nlxtn: Albert221 lindseyanne thinker stephanebisson Krenair AndyRussG samwilson sir_lestaty wikibugs Clarkcj jdlrobson jdlo [09:26:13] just ignore it [09:26:17] 13,04▄02,07▄11,03▄06,09▄09,13▄07,04▄05,13▄06,12▄07,02▄08,08▄04,07▄04,05▄04,11▄11,10▄11,06▄02,08▄06,08▄12,07▄12 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT tvgdyfo: Albert221 mundus Krinkle apergos nicholas__ acedbyb samwilson andre__ RexxS wikibugs stephaneb [09:26:21] ur spambot is really impressibe d00d [09:26:22] 02,04▄02,04▄07,03▄06,10▄05,10▄05,08▄04,07▄12,06▄12,04▄06,10▄13,13▄12,09▄06 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT jlqen: RexxS acedbyb ToAruShiroiNeko yurik nicholas__ apergos mundus stephanebisson Urbanecm eflyjason tomaluca95_ RootKlawiter jgirault thinker grumble jan_drewni [09:26:27] 04,02▄03,04▄07,12▄05,08▄08,10▄08,03▄13,08▄06,08▄09,08▄12,03▄08,05▄10,08▄11,04▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT hfnhqyhw: jdloft lindseyanne thinker Krinkle basile AndyRussG noela itsmeJarrett RootKlawiter JeroenDeDauw samwilson RexxS tomaluca95_ Zackary matanya jd [09:26:33] 06,03▄06,12▄03,12▄02,12▄10,08▄08,03▄02,10▄07,07▄06,02▄08,06▄08,05▄13,08▄04,11▄03,12▄07,13▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT wyspcgb: stephanebisson jan_drewniak nicholas__ sir_lestaty matanya Betacommand Krinkle mundus tomaluca95_ jdlrobson abbe98[m] Urbane [09:26:35] what [09:26:37] 13,02▄04,05▄05,08▄02,04▄08,06▄07,02▄10,05▄09,08▄02,08▄03,11▄08,09▄06,09▄06,13▄13,04▄10,04▄08,06▄03,03▄07,11▄03,10▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT cuzjrtyen: basile itsmeJarrett Zhaofeng_Li AndyRussG RootKlawiter DanielK_WMDE_ matanya wikib [09:26:42] 06,13▄13,07▄09,05▄08,10▄02,08▄12,02▄02,08▄13,02▄11,13▄09,13▄03,04▄04,04▄10,09▄05,11▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT yhuwlekx: divadsn mundus eflyjason Matthew_ stephanebisson nicholas__ jgirault JeroenDeDauw Krinkle jdloft Urbanecm Zhaofeng_Li jdlrobson Zacka [09:26:47] 02,06▄09,05▄07,03▄06,08▄13,03▄11,12▄02,04▄08,11▄03,02▄04,07▄12,09▄10,08▄11,04▄04,07▄05,07▄06,06▄13,05▄05 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ngqqla: grumble AndyRussG RexxS jgirault Matthew_ jdlrobson Clarkcj Krenair samwilson stephanebisson basile acedb [09:26:53] 12,11▄10,08▄08,03▄08,13▄11,06▄08,07▄04,10▄04,03▄11,04▄04,04▄11,10▄05,12▄13,13▄11,09▄10,08▄05,11▄11,10▄10,11▄06,08▄02 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT aehazlqgbz: JeroenDeDauw Matthew_ lindseyanne basile itsmeJarrett andre__ Clarkcj grumble efl [09:26:58] 05,09▄11,06▄09,11▄03,04▄06,03▄10,06▄04,07▄02,09▄02,06▄12,13▄10,02▄09,06▄06,05▄03,07▄07,07▄09,10▄04,07▄03,06▄11,06▄12,12▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT rjvobohtz: andre__ Phantom42 Urbanecm Clarkcj sir_lestaty Matthew_ samwilson jgirau [09:27:01] Where is freenode :( [09:27:03] 05,11▄05,04▄04,05▄06,12▄09,04▄07,12▄08,09▄11,05▄07,04▄06,06▄13,08▄03,08▄07,03▄04,06▄10,06▄04 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT vbnifmgxmh: Zhaofeng_Li AndyRussG stephanebisson andre__ ragesoss Urbanecm thinker matanya sir_lestaty apergos jdlrobson eflyjason he [09:27:08] 04,05▄05,09▄06,05▄05,04▄11,11▄05,10▄07,02▄06,06▄12,03▄08,09▄11,11▄08,08▄02,12▄12,09▄13,13▄10,03▄09,13▄13,03▄10 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT dxdjjtvxj: sir_lestaty RootKlawiter Zhaofeng_Li jdlrobson tomaluca95_ nicholas__ yurik noela ggp jgirau [09:27:12] ez [09:27:13] 08,08▄12,07▄08,04▄09,04▄12,09▄08,12▄13,08▄11,09▄11,05▄10,09▄10,03▄02,02▄08,10▄05,09▄08,04▄04,03▄10,06▄09,10▄13,10▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT eizaw: Betacommand ggp apergos jdloft AndyRussG acedbyb wikibugs eflyjason RootKlawiter Matth [09:27:15] https://en.wikipedia.org/w/index.php?title=Wikipedia:DENY&redirect=no [09:27:18] 11,08▄04,07▄04,10▄10,11▄02,02▄02,05▄06,04▄02,09▄02,13▄12,12▄12,06▄07,11▄03,08▄03,11▄13,10▄09,12▄03,09▄07 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT vhtxif: jdloft sir_lestaty Albert221 AndyRussG Clarkcj mundus jgirault acedbyb Urbanecm wikibugs hexmode Phantom4 [09:27:22] 09,05▄08,13▄09,03▄05,08▄09,11▄09,06▄04,05▄04,05▄05,12▄05,12▄12,04▄11,02▄07,04▄10,09▄07,09▄02,06▄13,09▄11,02▄11,05▄06,06▄07 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT wqxphedl: jdloft thinker Krinkle yurik corvus basile lindseyanne mundus matanya nic [09:27:28] 07,10▄12,13▄05,08▄13,04▄12,04▄10,03▄02,11▄07,07▄05,05▄04,12▄10,05▄10 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT laefnvkh: apergos acedbyb eflyjason Zackary samwilson Phantom42 grumble Albert221 Urbanecm RootKlawiter hexmode tomaluca95_ jgirault nicholas__ itsmeJarrett noela divadsn Be [09:27:32] I'll disconnect for a while [09:27:33] 08,03▄07,05▄10,06▄10,09▄10,12▄09,05▄06,03▄06,09▄03,06▄02,09▄04,06▄03,09▄08,04▄09,05▄04,06▄06,04▄06,11▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT nwtvy: wikibugs Zhaofeng_Li mundus DanielK_WMDE_ ggp ragesoss noela hexmode samwilson grumble yurik Albert221 And [09:27:37] 10,02▄09,07▄06,05▄04,03▄10,08▄11,11▄05,07▄06,02▄02,05▄12,13▄07,03▄05,09▄12,09▄13,11▄07,11▄02 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT wnoqmwukis: matanya RootKlawiter basile acedbyb Clarkcj AndyRussG lindseyanne RexxS Albert221 nicholas__ Krenair ggp jdloft divadsn w [09:27:43] 05,04▄12,12▄03,08▄05,12▄04,08▄07,05▄10,03▄13,11▄09,12▄08,05▄10,08▄07,04▄09,04▄08,06▄02 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT swpyacxamd: ToAruShiroiNeko JeroenDeDauw wikibugs Urbanecm itsmeJarrett corvus yurik Krenair Zackary Betacommand eflyjason nicholas__ tomaluca9 [09:27:47] * https://en.wikipedia.org/wiki/WP:DENY [09:27:48] 02,04▄05,09▄12,06▄04,09▄05,09▄05,06▄07,05▄12,13▄04,03▄12,09▄08,08▄03,07▄09,09▄09,05▄04,07▄05,03▄03,02▄02,10▄12 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT qupore: noela RootKlawiter acedbyb Krinkle sir_lestaty jdlrobson nicholas__ jdloft JeroenDeDauw corvus [09:27:54] 10,13▄04,07▄03,05▄07,12▄07,06▄07,08▄03,13▄04,11▄11,12▄02,04▄07,02▄11,08▄04,13▄03,02▄13,07▄06 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT qeghtatuxs: grumble acedbyb jgirault itsmeJarrett Krinkle abbe98[m] Phantom42 jdlrobson eflyjason mundus Urbanecm corvus JeroenDeDauw [09:27:58] 07,06▄03,13▄08,04▄05,10▄07,13▄05,09▄13,11▄02,05▄07,07▄03,13▄11,07▄02,03▄07,11▄06,04▄09 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ocetksac: Phantom42 Albert221 tomaluca95_ nicholas__ Clarkcj divadsn Matthew_ Krinkle acedbyb jan_drewniak andre__ samwilson AndyRussG Urbanecm [09:28:04] 08,07▄11,12▄04,13▄11,02▄07,12▄11,06▄11,02▄12,11▄11,05▄07,02▄07 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT gjytdul: lindseyanne yurik Phantom42 Albert221 abbe98[m] jgirault Matthew_ RootKlawiter nicholas__ AndyRussG ggp matanya Krenair tomaluca95_ noela andre__ Betacommand corvus jdlrobson [09:28:05] Can someone ban it? [09:28:08] 09,03▄03,03▄11,12▄11,08▄06,02▄08,10▄09,10▄02,05▄02,02▄04,03▄06,09▄13,12▄03,07▄10 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ewmjbmbnvl: Urbanecm Zackary mundus divadsn stephanebisson wikibugs Betacommand corvus Matthew_ noela JeroenDeDauw samwilson jan_drewniak jgirault matany [09:28:13] 08,02▄08,12▄08,07▄03,12▄13,13▄11,12▄07,03▄05,10▄02,04▄09,07▄04,06▄10,03▄07,07▄09,05▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT abjugv: Clarkcj RootKlawiter RexxS Matthew_ itsmeJarrett divadsn tomaluca95_ ToAruShiroiNeko acedbyb eflyjason apergos matanya lindseyanne Andy [09:28:19] 02,04▄07,08▄07,09▄09,13▄04,03▄02,11▄13,08▄08,13▄10,03▄08,13▄12,09▄06,06▄09,05▄12,09▄03,09▄09,13▄11,11▄07,07▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ycgbzu: basile jgirault abbe98[m] Krenair matanya AndyRussG grumble ggp Zhaofeng_Li itsmeJarrett mundus [09:28:23] 05,03▄09,09▄02,04▄12,06▄05,11▄06,09▄09,07▄11,06▄10,03▄07,12▄06,04▄07 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT febkqrb: itsmeJarrett noela matanya basile wikibugs jdloft sir_lestaty acedbyb lindseyanne eflyjason thinker mundus apergos tomaluca95_ Zackary abbe98[m] Urbanecm Zhaofeng_L [09:28:28] 06,05▄05,04▄07,08▄07,04▄11,12▄05,10▄07,04▄09,04▄05,06▄06,13▄02,09▄07,06▄12,02▄09,09▄02,04▄11,12▄08,08▄09 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT iytueqqv: yurik ToAruShiroiNeko sir_lestaty abbe98[m] divadsn Urbanecm wikibugs matanya grumble Clarkcj RootKlawi [09:28:33] 07,12▄03,05▄05,11▄13,10▄10,12▄12,13▄02,04▄03,12▄06,03▄04,05▄13,12▄06,09▄11,12▄04 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT fwemb: jan_drewniak ToAruShiroiNeko yurik itsmeJarrett Phantom42 RootKlawiter lindseyanne hexmode acedbyb JeroenDeDauw Albert221 Krinkle nicholas__ AndyR [09:28:38] 12,07▄05,10▄11,05▄05,07▄02,09▄13,03▄02,11▄06,09▄08,09▄04,02▄13,06▄04,09▄10,11▄09,07▄04,08▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT tqidjxuwl: eflyjason Albert221 RootKlawiter acedbyb Phantom42 mundus JeroenDeDauw corvus jgirault Krinkle apergos matanya ragesoss di [09:28:43] 13,06▄13,02▄05,10▄11,08▄02,11▄10,11▄05,04▄06,03▄08,10▄02,06▄08,12▄11,12▄12 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT qkbziu: matanya ragesoss jdloft andre__ samwilson eflyjason mundus Zhaofeng_Li lindseyanne jdlrobson divadsn grumble jgirault Zackary stephanebisson hexmode wikibu [09:28:47] 09,03▄04,12▄04,09▄09,13▄06,06▄06,09▄07,13▄11,08▄10,13▄03,06▄04,05▄06,03▄02,11▄13,04▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ywwmkrowyk: matanya Zackary Betacommand nicholas__ basile JeroenDeDauw jdloft itsmeJarrett grumble yurik sir_lestaty corvus Matthew_ stephanebi [09:28:53] 13,13▄02,04▄11,02▄11,07▄10,06▄11,09▄04,10▄12,11▄06,08▄05,13▄06,02▄05,03▄03,11▄06,05▄11,12▄11 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT spxzjebec: JeroenDeDauw RootKlawiter jan_drewniak jdloft basile acedbyb grumble Matthew_ RexxS eflyjason Urbanecm ggp matanya divadsn [09:28:58] 10,05▄10,08▄12,11▄08,13▄10,12▄02,04▄08,04▄08,03▄07,04▄07,13▄10,04▄11,09▄10,12▄10,05▄09,10▄09 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT kqdrcl: Zackary RootKlawiter samwilson DanielK_WMDE_ JeroenDeDauw thinker abbe98[m] ragesoss jdlrobson corvus grumble eflyjason ToAru [09:28:59] Bye, I leave this spamwave [09:29:03] 11,07▄03,11▄06,03▄12,04▄05,09▄02,02▄11,05▄06,12▄05,03▄06,10▄05,02▄02,08▄06,03▄12,13▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT oofting: ToAruShiroiNeko jdlrobson Phantom42 Urbanecm jgirault DanielK_WMDE_ itsmeJarrett thinker matanya ragesoss acedbyb andre__ nicholas__ s [09:29:08] 10,07▄13,02▄08,05▄12,12▄10,09▄13,02▄08,04▄11,13▄12,10▄05,12▄10,05▄08,07▄02 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT jterflcjth: Urbanecm mundus corvus apergos Betacommand eflyjason DanielK_WMDE_ RootKlawiter samwilson grumble andre__ stephanebisson itsmeJarrett noela wikibugs ab [09:29:13] 07,12▄07,08▄10,04▄04,02▄13,10▄08,11▄11,07▄12,13▄03,09▄10,02▄08,03▄04,08▄08,07▄05,05▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT tjrrsieupj: noela abbe98[m] Betacommand Krenair Matthew_ Zhaofeng_Li matanya jgirault Phantom42 andre__ Urbanecm hexmode ToAruShiroiNeko yurik [09:29:18] 06,02▄02,06▄06,13▄05,09▄08,10▄03,07▄04,06▄07,04▄05,11▄11,05▄12,11▄03,12▄07,13▄04,05▄08,11▄13,06▄11,06▄05,13▄07 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT rrlgwetuti: itsmeJarrett ToAruShiroiNeko Albert221 ragesoss thinker Krinkle eflyjason Betacommand Phant [09:29:23] 09,04▄03,05▄03,11▄11,05▄02,03▄11,12▄03,02▄13,09▄09,07▄05,07▄02,05▄09,08▄10,02▄09,02▄04,12▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT iqaiei: hexmode noela stephanebisson jgirault andre__ RexxS sir_lestaty jdloft RootKlawiter itsmeJarrett Phantom42 Urbanecm yurik Zha [09:29:28] 04,07▄05,11▄06,12▄04,03▄13,03▄13,06▄08,10▄08,04▄08,07▄07,09▄13,03▄11,08▄07,11▄13,05▄09,05▄12,06▄13,03▄12,11▄08,10▄08 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT zdont: stephanebisson jan_drewniak nicholas__ grumble Krinkle jdloft basile eflyjason Albert2 [09:29:33] 12,07▄05,10▄09,05▄07,10▄04,06▄06,05▄04,13▄03,10▄03,08▄13,09▄11,04▄09,02▄04,08▄07,02▄12,09▄05,07▄13,12▄10,10▄09,12▄10 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT paeaik: apergos yurik matanya eflyjason Krinkle ToAruShiroiNeko RexxS ragesoss Clarkcj Jeroen [09:29:38] 03,05▄11,10▄07,07▄13,09▄02,10▄12,13▄06,04▄07,08▄04,03▄04,12▄02,12▄09,11▄03,11▄02,02▄08,07▄09,02▄09,13▄13,11▄05 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT gzrroqa: hexmode Phantom42 DanielK_WMDE_ jdlrobson itsmeJarrett Krenair jgirault AndyRussG Matthew_ Zac [09:29:43] 10,09▄11,07▄05,10▄12,07▄11,11▄11,04▄06,12▄07,08▄12,10▄03,12▄12,12▄12 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT fkvntkrc: eflyjason basile Krinkle andre__ hexmode ragesoss yurik corvus jan_drewniak Betacommand JeroenDeDauw sir_lestaty apergos jdlrobson wikibugs itsmeJarrett divadsn Da [09:29:48] 13,09▄07,07▄02,02▄11,09▄03,02▄11,05▄13,11▄09,10▄02,11▄05,04▄08,09▄09,10▄02,02▄05,09▄09,04▄13 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT wwbqi: Krenair DanielK_WMDE_ Albert221 corvus Krinkle JeroenDeDauw Zhaofeng_Li RootKlawiter Urbanecm ragesoss jdlrobson mundus basile [09:29:53] 04,09▄07,12▄12,07▄11,06▄05,03▄06,04▄10,05▄06,06▄05,02▄02,07▄05,03▄03 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT ppmkzj: grumble jgirault jdlrobson stephanebisson Urbanecm Matthew_ Zackary samwilson RootKlawiter Betacommand jdloft yurik wikibugs Krinkle RexxS DanielK_WMDE_ hexmode Clar [09:29:58] 04,12▄03,13▄04,07▄11,12▄13,09▄07,03▄11,11▄02,07▄13,11▄07,09▄02,07▄09,02▄03,07▄05,03▄12 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT hselbei: lindseyanne hexmode noela Phantom42 grumble Zhaofeng_Li ggp samwilson sir_lestaty thinker JeroenDeDauw basile mundus Krenair ragesoss [09:30:03] 07,05▄09,06▄08,02▄05,06▄09,02▄06,10▄07,07▄02,10▄13,06▄06,08▄13,08▄11,07▄12,09▄04 DO YOU WANT TO KEEP YOUR MAN SATISFIED DURING THE CHRISTMAS BREAK?? EL IS GIVING ANAL SEX TIPS IN ##FEMINISM RIGHT NOW DONT MISS IT phwtazpat: hexmode RootKlawiter matanya Zackary RexxS DanielK_WMDE_ Urbanecm thinker jdloft eflyjason jdlrobson jan_drewniak abbe98[m] corvus sir_lestaty [09:33:18] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3860810 (10jayvdb) [09:33:47] 10Timeless: References bug - https://phabricator.wikimedia.org/T183669#3859912 (10ashley) Can you provide some screenshots of this bug and/or a URL where this issue is occurring as well as further details about your platform (operating system, browser + their versions)? I'm not sure if I'm able to reproduce this... [09:39:50] Oh, no... That spam again :( [09:40:17] 10MediaWiki-History-or-Diffs: Automatically generated count and list of contributors to an article (authorship tracking) - https://phabricator.wikimedia.org/T4994#3860813 (10He7d3r) > Scott merged a task: T29629: Customizable summary of page editors/authors.Sun, Dec 24, 1:11 PM @Scott: I don't see how solving th... [09:41:34] ignore the user in irc client saves live, but someone still need to ban it since it pollutes the logs :/ [09:42:07] refeed[m] still, you receive those notifications spammed >.> [09:44:19] there is one in #wikimedia-editing right now [09:45:28] tonythomas: Hi! [09:45:39] O hi Nikerabbit [09:45:40] hey hey. say your queries. replying very soon [09:46:07] tonythomas: Just letting you know what I claimed task mentored by you and submitted a patch :) [09:46:14] that * [09:46:23] oh - so that was this one. there was another one wiht a query [09:46:35] https://phabricator.wikimedia.org/T183638 [09:47:59] I am afraid I don't know Ryan IRC nickname :( [09:48:56] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400209 (https://phabricator.wikimedia.org/T183621) (owner: 10Phantom42) [09:49:10] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3860820 (1001tonythomas) [09:49:14] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test `deleteNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183621#3860818 (1001tonythomas) 05Open>03Resolved Thanks! [09:49:31] even though next time, I would like a doc on the function telling what exact internal function the unit test is covering [09:50:32] (03Merged) 10jenkins-bot: Unit test NewsletterDb::deleteNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400209 (https://phabricator.wikimedia.org/T183621) (owner: 10Phantom42) [09:50:40] Phantom42: approved! [09:50:58] tonythomas: I may create another patch set which adds that doc for my test case and others in that file [09:51:09] Thank you for approving! [09:51:34] that would be great. I dont know if it would be worth a GCI task though [09:52:09] tonythomas: I think we may do it apart from GCI. No need to create a task for that minor issue :) [09:52:16] true. makes sense [09:52:28] hi divadsn [09:53:00] tonythomas: I will submit a patch soon. Will notify you once I am ready [09:53:09] nice [09:55:08] also, people who are doing unit tests, there is a thread in wikitech-l which says how to inject context to set logged in user (answers by Gergo and Amir) on thread `Setting logged in user context on unit tests` \ [09:56:29] tonythomas: Yes. Seen it. Will use as a reference :) Thank you! [09:57:04] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183617#3860825 (10Phantom42) a:03Phantom42 I will add this unit test! [09:57:07] 10MediaWiki-extensions-LoginNotify, 10Collaboration-Team-Triage, 10Community-Tech, 10Notifications, and 3 others: LoginNotify should inform users of the IP address of failed login attempts to their account - https://phabricator.wikimedia.org/T174388#3560134 (10revi) >>! In T174388#3827719, @Xaosflux wrote:... [09:57:10] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [GCI][Unit testing] Unit test condition "The newsletter name should be unique" in NewsletterCreate - https://phabricator.wikimedia.org/T183638#3860827 (1001tonythomas) @Ryan10145 I see the point. Can you try creating the first one like - https://github.... [10:01:16] 10MediaWiki-Parser, 10Tracking: HTML validity (tracking) - https://phabricator.wikimedia.org/T2209#3860833 (10He7d3r) [10:02:03] 10Dumps-Generation: Find out why file sizes of dump jobs currently running aren't reported during status updates - https://phabricator.wikimedia.org/T183694#3860834 (10ArielGlenn) p:05Triage>03Normal [10:02:08] Hey! [10:02:24] I'm Ojash Kumar Jana (Nick: OKJ). I am in GCI (Google Code-In) [10:02:30] Im 13 years old currently [10:02:40] And I am trying to understand and going into IRC [10:02:41] Hi and welcome OKJ [10:03:00] Thanks :) [10:03:18] welcome, OKJ! [10:03:22] Google Code-in is pretty awesome.. [10:03:30] Thx @apergos :D [10:04:25] OKJ: Welcome! Which country are you from by the way? [10:04:30] I'm from India. [10:04:48] Great! There are some other GCI students from India here. Hope you meet them soon! [10:05:10] Uh it says 'Received a CTCP VERSION from Zackary' [10:05:12] what it means? [10:05:29] it means I asked your irc client what irc you're running [10:05:43] Ohh [10:05:46] Thx for letting me know [10:05:52] np [10:15:37] ChanServ is a bot? [10:15:44] And how to access more other channels on HexChat? [10:15:50] If more channels are existing. [10:16:07] Yes, ChanServ is a bot (ChannelService) [10:17:16] This is freenode. I've like 2 years ago, access the Rizon also [10:17:19] I don't use HexChat, but there should be a button to join a channel, alternatively you can use /join command [10:17:21] accessed* [10:17:41] I think I better refer to documentation than asking [10:24:29] (03PS1) 10Phantom42: Add @covers annotation to each NewsletterDb test case [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400224 (https://phabricator.wikimedia.org/T183613) [10:27:04] tonythomas: I added @covers annotation to each test case: https://gerrit.wikimedia.org/r/400224 [10:27:28] 10MediaWiki-Parser, 10Epic: The newline added to a template, magic word, variable, or parser function that returns line-start wikicode formatting (*#:; {|) causes unexpected parsing - https://phabricator.wikimedia.org/T14974#3860852 (10Aklapper) p:05High>03Low [[ https://www.mediawiki.org/wiki/Phabricator/... [10:28:46] (03CR) 1001tonythomas: [C: 032] Add @covers annotation to each NewsletterDb test case [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400224 (https://phabricator.wikimedia.org/T183613) (owner: 10Phantom42) [10:29:23] Phantom42: :) thanks. (even though I dont know if mw devs keep @covers just for the classname or the tests itself. Anyway, it doesnt do any harm IMHO [10:30:30] (03Merged) 10jenkins-bot: Add @covers annotation to each NewsletterDb test case [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400224 (https://phabricator.wikimedia.org/T183613) (owner: 10Phantom42) [10:34:31] tonythomas: Well, in Core tests @covers is used for test cases quite often. I don't know how you agreed to use it in Newsletter test cases too. Anyway, if needed we may easily and quickly change this in the future :) Thank you for merging! [10:34:55] `in Core tests @covers is used for test cases quite often` -- then its a good to go for our extension too :D [10:35:38] Okay :) [10:53:32] Wew, my editor's intelisense parser uses 5GB ++ to parse mediawiki codes [11:01:32] (03PS1) 10Phantom42: Unit test NewsletterDb::addNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400225 (https://phabricator.wikimedia.org/T183617) [11:02:32] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::addNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400225 (https://phabricator.wikimedia.org/T183617) (owner: 10Phantom42) [11:04:16] (03PS2) 10Phantom42: Unit test NewsletterDb::addNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400225 (https://phabricator.wikimedia.org/T183617) [11:06:20] 10Dumps-Generation, 10Patch-For-Review: Find out why file sizes of dump jobs currently running aren't reported during status updates - https://phabricator.wikimedia.org/T183694#3860876 (10ArielGlenn) Should be fixed but leaving this open until we see a few wikis do the right thing during the next run. [11:09:02] (03CR) 1001tonythomas: [C: 032] "LGTM :) Thanks." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400225 (https://phabricator.wikimedia.org/T183617) (owner: 10Phantom42) [11:09:11] 10Wikimedia-SVG-rendering: SVG masks fail to render (or even display) - https://phabricator.wikimedia.org/T55899#3860878 (10Perhelion) https://commons.wikimedia.org/wiki/File:SVG_mask_gradient_bug.svg renders correctly on [[ https://commons.wikimedia.org/wiki/Commons:Commons_SVG_Checker?withJS=MediaWiki:CommonsS... [11:09:33] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3860882 (1001tonythomas) [11:09:37] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test `addNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183617#3860880 (1001tonythomas) 05Open>03Resolved Thanks. Keep it coming! [11:10:41] (03Merged) 10jenkins-bot: Unit test NewsletterDb::addNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400225 (https://phabricator.wikimedia.org/T183617) (owner: 10Phantom42) [11:15:11] 10Wikimedia-SVG-rendering: SVG masks fail to render (or even display) - https://phabricator.wikimedia.org/T55899#3860884 (10Perhelion) [11:18:17] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183614#3860886 (10Phantom42) a:03Phantom42 I will create unit test for this! [11:43:24] (03Abandoned) 10Paladox: Use apt components for elastic [vagrant] - 10https://gerrit.wikimedia.org/r/395990 (owner: 10Paladox) [11:44:22] tonythomas: While working on my current task, I noticed that `testAddSubscriber` does not check if newsletter subscriber count (`nl_subscriber_count`) has changed after subscribing. Do we need to fix that or it is not important to test that? [11:44:44] would be an improvement, yes! yay. [11:45:34] tonythomas: Can I do it in my patch set regarding `testRemoveSubscriber`. Or it is better to create a separate patch for that? [11:45:40] well - even though - that tests there just check the db layer operations [11:45:46] I am not sure if it is necessary though [11:46:13] we will have the functionality tests coming up - specially with subscription, publisher addition where we would check this extensively [11:50:37] tonythomas: Well, then we better test it because in `addSubscription` function there is a db update operation which changes `nl_subscriber_count` right after doing insert to `nl_subscriptions`. The same for `removeSubscription` [11:52:02] of course. that will come in another group of tests. btw, if you want to add that - adding them to both of those would be an improvement. It would be sad to have it on one function, and not on the other :-( [11:52:29] I guess you might be able to use somethign like `$newsletter->getSubscirbersCount()` or something like that ? hope we have it [11:52:38] tonythomas: I will add to both :) Thank you! [11:52:44] nice then. [11:53:17] its `getSubscribersCount()` btw :P [11:54:32] We don't need to check `getSubscribersCount()`. Everything needing to be done is just to mock one more database operation (subscriber change) to check if it is being run :) [11:55:46] Anyway, I will submit a patch soon and you will see. Thank you again! [11:59:01] 10MediaWiki-extensions-Linter, 10CSS, 10Easy: Linter's namespace selector should appear above other interface elements - https://phabricator.wikimedia.org/T183697#3860913 (10He7d3r) [12:16:35] * d3r1ck checks in :) [12:17:16] * Phantom42 is glad to see d3r1ck [12:17:29] Phantom42: :) [12:22:16] * refeed[m] waves :D [12:23:33] (03PS1) 10Phantom42: Unit test NewsletterDb::removeSubscription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400229 (https://phabricator.wikimedia.org/T183614) [12:28:43] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3860943 (10divadsn) Oh, thanks for the tip, I was going to use Docker to create a local Phabricator instance :) [12:31:20] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [12:32:26] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [12:33:03] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - https://phabricator.wikimedia.org/T181251#3860944 (10Theklan) Hainbat irakasleri idatzi diet, kontaktua egiteko, Koldo Bigurik emandako zerrendatik tiraka. Ea erantzunik dagoen. [12:44:18] hello i am sachin and i am a participant of google code in contest. [12:44:40] elzatch4219: Welcome! [12:44:50] elzatch4219: Welcome [12:44:57] Which country are you from, elzatch4219 ? [12:45:39] elzatch4219: Welcome :) [12:45:40] india [12:46:07] elzatch4219: Great! There are a lot of other GCI participants from India here. Hope you meet them soon! [12:46:27] And which IRC client are you using? [12:46:31] 10Wikimedia-User-Group-Basque: EHU - Arabako Campusa - Letren Fakultatea - https://phabricator.wikimedia.org/T181251#3860949 (10Theklan) Itzulpengintzako graduko koordinatzailearekin bildu nintzen aurrekoan, espreski eremu honetan egin daitekeenaz mintzatzeko. Gaur informazioa bidali diot, hainbat lotura eta pro... [12:47:02] currently i am using hexchat [12:47:14] Great! Good luck with your GCI tasks! [12:49:55] 10Phabricator, 10Operations: phab.wmflabs.org: Unhandled Exception: setConsumerKey() is required! - https://phabricator.wikimedia.org/T183698#3860951 (10jayvdb) [12:52:27] 10MediaWiki-Vagrant: Error: /usr/local/bin/mwscript createAndPromote.php --wiki='wiki' 'Admin' 'vagrant' returned 255 instead of one of [0] - https://phabricator.wikimedia.org/T183699#3860961 (10Paladox) [12:53:29] 10MediaWiki-Vagrant: Error: /usr/local/bin/mwscript createAndPromote.php --wiki='wiki' 'Admin' 'vagrant' returned 255 instead of one of [0] - https://phabricator.wikimedia.org/T183699#3860971 (10Paladox) [13:07:09] 10Phabricator, 10Operations: phab.wmflabs.org: Unhandled Exception: setConsumerKey() is required! - https://phabricator.wikimedia.org/T183698#3860951 (10Paladox) You shoulden't be using mediawiki auth, i added that to work around a issue that was preventing login form from showing. Please use the wikitech auth... [13:07:16] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3860976 (10divadsn) Alright, I finally could get my local Docker instance running and added a testapp in OAuth Server which will then return the data I want to my dummy script. {... [13:13:45] 10Google-Code-in-2017: Research how to make events more "green" - https://phabricator.wikimedia.org/T181593#3860977 (10Coolchowder) [13:17:35] 10Google-Code-in-2017: Research how to make events more "green" - https://phabricator.wikimedia.org/T181593#3860978 (10Coolchowder) Added 2 new examples - there would always be leftovers even if you plan ahead,as not everyone eats everything,so those can be donated to a foodbank - By sending invitations digitall... [13:29:56] 10MediaWiki-General-or-Unknown: W3C Validator complains about
elements missing
children, and some unknown "language" parameter values - https://phabricator.wikimedia.org/T168624#3370259 (10Izno) The main issue described in this task is a duplicate of {T6521}. Is the other item an actual issue or should... [13:30:04] 10Support-and-Safety, 10Wikimedia-Site-requests: Enable SecurePoll on Arabic Wikipedia - https://phabricator.wikimedia.org/T183358#3860985 (10Ibrahim.ID) @Huji yes, I'm sysop in (test.wikipedia.org) and I tried to create a poll and I saw the configuration page. anyway, we thought the Securepoll enabled local... [13:33:44] 10CSS: Linter's namespace selector should appear above other interface elements - https://phabricator.wikimedia.org/T183697#3860987 (10Mainframe98) This isn't specific to #MediaWiki-extensions-Linter. Based on {T182602}, I'm wagering it isn't exactly easy either. [13:34:00] 10CSS: Linter's namespace selector should appear above other interface elements - https://phabricator.wikimedia.org/T183697#3860992 (10Mainframe98) [13:41:59] 10Google-Code-in-2017: Research how to make events more "green" - https://phabricator.wikimedia.org/T181593#3860997 (10Coolchowder) [13:46:13] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3861002 (10jayvdb) [13:46:22] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3716745 (10jayvdb) [13:46:25] 10MediaWiki-extensions-FlaggedRevs, 10Editing-team, 10VisualEditor, 10VisualEditor-MediaWiki: Editing a page with unflagged changes should edit latest version in VE, even if you view the stable version - https://phabricator.wikimedia.org/T165283#3861004 (10stjn) I would ask Editing team to look into this b... [13:49:35] (03CR) 1001tonythomas: [C: 032] "LGTM. nice work :)" (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400229 (https://phabricator.wikimedia.org/T183614) (owner: 10Phantom42) [13:49:57] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3861009 (1001tonythomas) [13:50:00] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test removeSubscription in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183614#3861007 (1001tonythomas) 05Open>03Resolved Thanks, keep it coming! [13:51:12] (03Merged) 10jenkins-bot: Unit test NewsletterDb::removeSubscription [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400229 (https://phabricator.wikimedia.org/T183614) (owner: 10Phantom42) [13:52:49] 10CSS: Linter's namespace selector should appear above other interface elements - https://phabricator.wikimedia.org/T183697#3861011 (10Aklapper) @He7d3r: Please do not add #easy without providing sufficient pointers. See the project description. Thanks! [13:57:36] Someone can help me here with Phabricator API? :/ [13:57:41] tonythomas: Thank you for reviewing the patch! I claimed one more unit testing task, but I think that this will be my last one, so other GCI students can get some experience doing other instances of those too! [13:57:49] divadsn: What exactly do you need help with? [13:57:55] exactly. :D [13:58:03] divadsn: I was added as a mentor that recently :P [13:58:10] divadsn: what problem are you having ? [13:58:30] tonythomas: I can't get this here passed with my userinfo: david@Gamer-PC ~/Dokumente/Docker/phabricator $ curl "https://127.0.0.1/api/user.whoami?scope=read_user" -H "Authorization: Bearer tuzzex7hjzsfjev2xwxj3wk2radetnsc" --insecure [13:58:30] {"result":null,"error_code":"ERR-INVALID-SESSION","error_info":"Session key is not present."} [13:58:51] And now after googling it seems like a bug: https://github.com/Zolli/Phabricator-PHP-API/issues/4 [13:59:10] But then the question is if then the PHP OAuth library is also affected by that [13:59:37] let me look at the phab API again [13:59:55] divadsn: Maybe that's because `api.token` is missing? [13:59:57] Yeah, their docs are also very bad [14:00:06] Phantom42, that's not related with OAuth tokens [14:00:44] And this here suggest using the access_token in the query, which doesn't work too https://secure.phabricator.com/book/phabcontrib/article/using_oauthserver/ [14:00:50] Total mess in my opinion [14:01:23] (03PS5) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [14:01:57] divadsn: what do you get when you do the `access_token` in the query param ? [14:02:30] tonythomas: error_info "You are trying to save some data to Phabricator, but the request your browser made included an incorrect token. Reload the page and try again. You may need to clear your cookies.\nThis was a Web request.\nThis request had no CSRF token." [14:02:54] Let me restart the docker container maybe [14:02:56] of course, that thing should happen from a browser. [14:04:02] tonythomas but I executed it with curl, same result when opening it in Firefox [14:04:06] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183622#3861014 (10Phantom42) a:03Phantom42 I will create a unit test for this! [14:04:29] I am rebuilding the container, maybe I have messed up the configuration [14:04:49] divadsn: well. is your code to use PHP OAuth library available somewhere for me to take a look ? [14:05:42] tonythomas, no my task is to make a backend for python-social-auth and the PHP lib is an example given in the task: https://phabricator.wikimedia.org/T179202 [14:05:47] https://github.com/ofbeaton/oauth2-phabricator/blob/master/test/src/Provider/PhabricatorTest.php [14:06:47] :D perfect - so this is apython task ? [14:07:14] Yes exactly, tonythomas ^^ [14:07:14] I wouldnt even try out this on PHP then. [14:07:23] I am right back, eating lunch [14:09:00] sad phabricator do not have a Python client though. but implementing one should not be that hard [14:16:58] 10Wikipedia-Android-App-Backlog, 10Easy, 10Reading Epics (Feed 2.0): Enable sharing of ‘On this day’ event content - https://phabricator.wikimedia.org/T180385#3755983 (10Jcasariego) Hi @RHo I've been reading this task and I find it very similar to T180391 What is the difference in this task? [14:18:42] (03PS1) 10Phantom42: Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183613) [14:19:31] (03PS2) 10Phantom42: Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) [14:19:38] I don't know what magic is that, but after a reboot the same curl request with the access_token parameter now returns the user data for the backend to use :D [14:20:02] (03CR) 1001tonythomas: [C: 04-1] Unit test NewsletterDb::restoreNewsletter (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:20:12] So I think I'm close to have it finished, only small changes and I can push my changes on my fork [14:20:21] true :D [14:20:48] btw - the task needs you to implement this as a backend for ` python-social-auth ` right ? [14:24:07] (03CR) 10Phantom42: Unit test NewsletterDb::restoreNewsletter (031 comment) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:26:23] Yep :) [14:26:57] alright. should be straight forward then. will wait for the PR. [14:27:37] (03CR) 1001tonythomas: [C: 04-1] "Well, even though technically the requirements are enough, I would better put `$deleteNewsletter( $newsletter );` - which would change tha" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:30:12] 10MediaWiki-ResourceLoader, 10Performance-Team, 10Wikimedia-log-errors: PHP Notice: Uninitialized string offset: includes/libs/JavaScriptMinifier.php on line 571 - https://phabricator.wikimedia.org/T75556#3861029 (10Krinkle) [14:35:11] tonythomas, as the task requires a manual review before creating a PR, here it is: https://github.com/divadsn/social-core/commit/af485ef0fba6e5269015948b942716b38d23abdc [14:35:18] nice [14:35:24] let me go through quick [14:36:10] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3861031 (10divadsn) I pushed my changes on my fork to GitHub: https://github.com/divadsn/social-core/commit/af485ef0fba6e5269015948b942716b38d23abdc [14:37:08] Ok, I am back at dining table now, christmas ^^ [14:37:13] *2nd day [14:37:39] (03PS3) 10Phantom42: Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) [14:37:50] :D alrirght [14:38:43] (03CR) 10jerkins-bot: [V: 04-1] Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:39:40] (03CR) 10Phantom42: "Well, I did it. But now we have deleteNewsletter here with all needed mocks, so maybe we can even remove `testDeleteNewsletter` as this te" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:40:08] divadsn btw - did you test this on your local ? [14:40:19] I think the PR to get merged would need unit tests as well! [14:40:30] but for the task requirements, thsi should work [14:41:12] (03PS4) 10Phantom42: Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) [14:41:25] tonythomas, sort of, couldn't get the full example to work, but will try again when I am back from christmas lunch :) [14:41:33] alriht! [14:41:39] Also, had to force push as the rebase was refusing :/ [14:42:02] people say not to force push :zz [14:42:05] so it's now here: https://github.com/divadsn/social-core/commit/06ab0675c3c9f79fd3cb17133fda2e0793367be0 [14:42:20] tonythomas it's my fork, I wouldn't do that on master :P [14:44:38] (03CR) 1001tonythomas: [C: 032] "Well, even though I would've expected `deleteNewsletter()` to *not* to be kept in the expect of mock db in this function -- its an additi" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:44:50] tonythomas: I fixed the issue you mentioned :) [14:44:59] (03CR) 10Phuedx: MCR: Deprecate and gut Revision class (031 comment) [core] - 10https://gerrit.wikimedia.org/r/399174 (https://phabricator.wikimedia.org/T174025) (owner: 10Daniel Kinzler) [14:45:00] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)), 10Patch-For-Review: [GCI][Unit testing] Unit test db operations on Newsletter extension - https://phabricator.wikimedia.org/T183613#3861039 (1001tonythomas) [14:45:03] 10MediaWiki-extensions-Newsletter, 10Google-Code-in-2017, 10Patch-For-Review: [Unit testing] Unit test `restoreNewsletter` in `includes/NewsletterDb.php` - https://phabricator.wikimedia.org/T183622#3861037 (1001tonythomas) 05Open>03Resolved Nice. Thank you! [14:46:09] (03Merged) 10jenkins-bot: Unit test NewsletterDb::restoreNewsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:47:55] Hi this is Pari. I am in this group as part of my GCI(Google Code-in)task [14:48:06] Pari: Welcome! [14:48:24] Which country are you from, Pari? [14:48:42] I am from India [14:48:51] Where are you from? [14:49:00] Great! Hope you meet other GCI students from India soon here :) [14:49:07] I am from Ukraine [14:49:13] Which IRC client do you use? [14:49:37] Phantom42 you can ask it yourself :P [14:49:41] I am using HexChat [14:50:06] Pari: Great! Good luck with GCI tasks! [14:50:20] divadsn: Sorry, I am afraid I don't understand what you mean :( [14:50:29] Thanks Phantom42 and same to you! [14:50:32] Uh, HexChat is giving too much information about the host [14:50:54] Phantom42 /ctcp ;) [14:51:33] divadsn: Oh. I see. But I prefer to ask it, just to start a conversation with a newcomer :) [14:52:02] Hey Pari, welcome to the great world of IRC and have a good stay here :) [14:52:30] Phantom42 I see, it looks like a bot sometimes too be honest :D [14:52:45] Welcome Pari! [14:53:50] Thank you andre_ [14:55:05] (03CR) 10Phantom42: "Well I decided that it is better to mock this delete function if we are calling it here :)" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400232 (https://phabricator.wikimedia.org/T183622) (owner: 10Phantom42) [14:55:17] divadsn: :D [14:57:12] If anyone else here is in for the GCI task, would you mind explaining what exactly we are supposed to do. [14:58:02] Well, for this task you need to wait 1 hour first (according to task description) before submitting [14:58:44] After you submit this task and it gets approved, you may claim the next one [14:59:25] Yes Phantom42, I read about it in the description but I dont get what exactly the task is waiting here for about an hour [15:00:59] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3861048 (10jayvdb) Looking good so far. The most recent PRs included a unit test module. https://github.com/python-social-auth/social-core/pull/162/files But some other recent... [15:01:04] That hour is needed so you can meet the community here and communicate a bit with it :) [15:01:35] Oh ok..no issues:) I was just asking [15:19:37] Hi *masti! [15:19:51] Welcome! [15:20:58] Pari: in fact, this 1 hour thing is for organizational sake - if I were you, I would be looking at sample tasks in http://g.co/gci - or even https://phabricator.wikimedia.org/project/view/3048/ and look at what kind of tasks you can expect, etc [15:22:21] tonythomas: thanks for the advice, I will check out the sites:) [15:22:32] have fun! [15:23:58] 10Phabricator, 10Google-Code-in-2017: Create Phabricator backend for python-social-auth - https://phabricator.wikimedia.org/T179202#3861049 (10divadsn) Sure! Will do that in about 1 hour :) [15:56:03] Hahaha opened IRC this morning to find I had a zillion pings... At first II was like, what have I done? [16:09:27] tonythomas or read some guides or articles :P [16:09:36] AndyRussG spambots ._. [16:13:17] makes sense. [16:13:47] I think the task description by AndyRussG andre__ should be updated to reflect those. It would be a shame if someone just shows up and stays here for an hour [16:16:01] ? [16:16:21] andre__: the show up on IRC task. [16:16:29] tonythomas, feel free to edit: https://www.mediawiki.org/wiki/Google_Code-in/Admins#Beginner:_get_on_Internet_Relay_Chat_(IRC)_(2015/2016) [16:16:40] as I am not sure what to change :P [16:17:14] :D god. show up and then wait an hour before leaving. garten stuff [16:17:35] oh oh - but I think its already there in `OPTIONAL` [16:17:39] good enough then. [16:18:01] tonythomas: It might sound easy to you. Last year about 30% of GCI students failed on the IRC task. [16:18:19] either because of using a non-free client, or not staying for an hour, or not going to Freenode. [16:26:06] divadsn: yeah I did that was it... [16:26:57] *did see [16:27:31] There was a similar one hitting at least one other channel maybe a week or so ago [16:34:31] tonythomas, I have added tests for the backend [16:35:29] https://github.com/divadsn/social-core/commit/e976641823aeb18cc9632a3ef6c3551fbbe34713 [16:36:03] hi [16:36:17] i am new to irc [16:37:33] any one there ?? [16:38:28] sajenjeshan1222: Welcome :) [16:38:38] sajenjeshan1222: lots of people here, probably not really interested in talking with others :) [16:38:39] Are you a GCI participant? [16:38:50] Vulpix: :) [16:39:07] It's holidays so it's silent for a while [16:39:14] hey i am having a doubt [16:39:25] what does:) means [16:39:28] sajenjeshan1222: What's your doubt? [16:40:25] :) means ?? [16:40:26] sajenjeshan1222: It's a smile [16:40:34] oh ok [16:40:41] i understood [16:40:44] sajenjeshan1222: Hi and welcome to IRC. How can we help you? What brings you to #wikimedia-dev ? [16:41:58] because i am intersted in developing [16:42:29] guys could any one say why irc is used ?? [16:43:25] sajenjeshan1222, https://www.mediawiki.org/wiki/MediaWiki_on_IRC [16:43:43] sajenjeshan1222: Traditions, I'd say. What else would you propose, instead of IRC? [16:44:16] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3861075 (10Urbanecm) Uploaded intiial configuration. Just a note that it's depending on 399805 which will switch all Wikipedia logos to direct using of SVG (PNG as fallback). But the wik... [16:44:42] andre__: makes sense then :D [16:45:04] divadsn: why do you have ` expected_username = 'foobar'` and then from the OAuth data, the username is `user` ? [16:45:15] did you run the tests locally - did it all run good ? [16:45:52] 10Patch-For-Review, 10Wiki-Setup (Create): Create Wikipedia Lingua Franca Nova 2 - https://phabricator.wikimedia.org/T183561#3861076 (10Urbanecm) [16:45:56] tonythomas: ooops, gonna fix [16:46:10] divadsn: yes, please run the tests locally. [16:46:25] tonythomas how can I run those tests? [16:47:05] divadsn: http://python-social-auth.readthedocs.io/en/latest/tests.html ? [16:47:40] Hmm, maybe https://phabricator.wikimedia.org/T183673 would be suitable for a gci task [16:48:58] tonythomas, ah alright, good :) [16:49:53] does any one use ubuntu here ?? [16:50:16] sajenjeshan1222: That is likely that some folks do. [16:50:29] k [16:51:14] hey how to install and run sugar in ubuntu does any one know ?? [16:52:53] ?? [16:55:10] sajenjeshan1222: what is "sugar" in MediaWiki? [16:55:53] tonythomas, hmm still doesn't work, fails on the same openid [16:56:04] divadsn: can you paste the error ? [16:56:05] hi sanjay_tharagesh welcome [16:57:33] tonythomas: https://github.com/divadsn/social-core/commit/e976641823aeb18cc9632a3ef6c3551fbbe34713#commitcomment-26487232 [16:58:03] this is due to an improperly setup environment [16:58:23] did you do: Go to the tests directory and install the dependencies listed in the requirements.txt. Then run with nosetests command, or with the run_tests.sh script. [17:01:23] Yes, I did it even again by resetting the virtualenv [17:03:12] divadsn: can you give me the output of `pip freeze | grep "openid" ` [17:03:14] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [17:03:18] inside your virtualenv ? [17:03:40] tonythomas empty output [17:03:54] divadsn: that means python-openid is not installed ? [17:04:02] https://pypi.python.org/pypi/python-openid/ [17:04:09] strange its not in requirements-xx.txt [17:04:14] tonythomas well where should I knew that :P [17:04:23] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [17:04:35] the error is thrown on ` from openid.association import Association as OpenIdAssociation ` :D guess ? [17:05:23] works for me after `pip install python-openid` [17:05:43] can you create an issue in that repo stating your error ? would be great [17:06:55] hi guys i am in irc for google code-in task [17:07:38] which was given by google to me [17:08:17] Welcome sajenjeshan1222 [17:08:21] tonythomas still every test failing, hrm [17:08:31] divadsn: only yours or - all the others ? [17:08:38] all others this time [17:08:58] divadsn: then you know the issue - something wrong with your environment or how you run the tests ? [17:09:11] sajenjeshan1222: Which org are you doing the task for? [17:09:14] (or if you paste the output, I can even take al ook) [17:09:31] wikimedia [17:10:22] Cool, cool. You're in the right place [17:10:33] 10Timeless: References are misplaced when highlighted - https://phabricator.wikimedia.org/T183700#3861084 (10Ltrlg) [17:10:53] I was wondering because you seemed to be asking about sugar labs [17:10:54] tonythomas, I can't even deal with those now: SSLError: HTTPSConnectionPool(host='github.com', port=443): Max retries exceeded with url: /login/oauth/authorize?state=txfBoKGOal6pTqiXY46ZQlkhhHzg7LoB&redirect_uri=http%3A%2F%2Fmyapp.com%2Fcomplete%2Fgithub%3Fredirect_state%3DtxfBoKGOal6pTqiXY46ZQlkhhHzg7LoB&response_type=code&client_id=a-key (Caused [17:10:54] by SSLError(SSLError("bad handshake: SysCallError(32, 'EPIPE')",),)) [17:11:40] for some reason it seems like the people participating in gci for sugarlabs seem to sometimes show up in this channel. I'm not sure why [17:11:48] divadsn: hmm. this docker you are running on - it has working internet right ? [17:12:10] Yes [17:13:13] divadsn: can you paste the whole ouput in dpaste.de ? [17:14:36] hi [17:15:52] sajenjeshan1222: You already said Hi here earlier, I think, and didn't get disconnected? Anyway, hi again! [17:16:08] * tonythomas hugs andre__ [17:16:24] ya ok hi for u [17:21:09] tonythomas, now every test passed except some onelogin saml, but I don't care about those for now :P [17:21:37] divadsn: lucky you, I had to work with onelogin saml before - can you paste the error ? [17:22:14] tonythomas https://dpaste.de/kgTg [17:23:44] divadsn: can you `sudo apt-get install libxmlsec1-dev libxml2-dev` and run `pip install dm.xmlsec.binding==1.3.3` after that ? [17:24:59] still failing on the same SyntaxError :/ [17:26:37] divadsn: can you paste the output this time ? [17:26:40] is it the same ? [17:27:01] oh I see. that print statement is not python 3.x compatiable [17:27:13] I think you have to just run it for python 2.x versions [17:27:15] And after installing pysaml2 every test is failing again, tf? [17:27:33] divadsn: can you share the command you used to run the tests ? [17:27:55] most python 3.x tests would fail for code written for python 2.x [17:27:57] tonythomas: (socialtests) david@Gamer-PC ~/Dokumente/Docker/socialtests/social-core/social_core/tests $ nosetests [17:29:21] I will retry with Python2 [17:29:36] of course, please [17:29:57] or if I were you - I would just selectively run the test I just wrote [17:30:09] (once I can see atleast one another test passing) [17:31:56] My test is passing fine no matter how I launch the test :) [17:32:12] well, then I would say its a good to go then [17:32:17] PR time ! [17:33:07] https://dpaste.de/8RpK on Python2 it passes everything! [17:33:19] of course. cool [17:34:59] Yay https://github.com/python-social-auth/social-core/pull/169 tonythomas :) [17:35:29] divadsn: please edit the PR description to clearly state what you did. Those people might not evne want to click on a link ... [17:36:13] tonythomas ok, the one example PR had only linked an issue [17:36:34] ***not a good excuse *** :P [17:36:47] http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/ [17:37:36] oh wow - Github has their own - https://github.com/blog/1943-how-to-write-the-perfect-pull-request [17:39:53] "This adds a OAuth2 backend for Phabricator to allow users to authentificate using Phabricator login." what else is there to say :P [17:40:35] divadsn upto you :) [17:41:34] I'm leaving now. hopefully jayvdb would approve and close the task. Neat work. [17:42:13] tonythomas me too, thanks for your help :) [17:46:48] 10PollNY, 10Social-Tools, 10SocialProfile: SocialProfile: UserProfile conditionally runs deprecated ParserLimitReport hook within a ArticleFromTitle hook - https://phabricator.wikimedia.org/T183652#3861097 (10SamanthaNguyen) 05Open>03Resolved p:05Triage>03Normal [17:51:28] Hmm. So 347daf20252 broke the global usage special pages for like a year. And I guess just nobody noticed [17:51:40] Guess that's a sign that nobody actually reads these special pages [17:52:08] The more interesting question, is why doesn't this spam the logs with fatal errors [17:56:43] even in the log, it says it completed succesfully [17:56:46] This is really odd [17:57:38] GloballyWantedFiles [QueryPage] got 5000 rows in 3h 9m 17.74s [17:58:43] right, and the special page on commons says its updated recently [17:58:48] so maybe it really does work [17:59:46] * bawolff is clearly confusing myself [18:01:17] Oh, its because the $class variable is totally unsued in all of mediawiki code [18:01:27] so it doesn't matter that the value is wrong [18:05:34] operation completed successfully, something must Be wrong :P https://woobsing.com/wp-content/uploads/2016/06/image_2.jpg [18:06:21] (03PS1) 10Brian Wolff: Fix class name for QueryPages (no behaviour change) [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/400235 [18:06:59] Vulpix: lol [18:09:54] (03CR) 10Legoktm: [C: 032] Replace deprecated tag with custom styled
tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [18:11:22] (03Merged) 10jenkins-bot: Replace deprecated tag with custom styled
tag in error output [extensions/timeline] - 10https://gerrit.wikimedia.org/r/400108 (https://phabricator.wikimedia.org/T182968) (owner: 10Divadsn) [18:11:24] (03PS14) 10Brian Wolff: Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://phabricator.wikimedia.org/T8220) [18:12:12] (03CR) 10jerkins-bot: [V: 04-1] Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://phabricator.wikimedia.org/T8220) (owner: 10Brian Wolff) [18:17:09] (03PS15) 10Brian Wolff: Make Special:Wantedfiles not include foreign false positives. [extensions/GlobalUsage] - 10https://gerrit.wikimedia.org/r/143835 (https://phabricator.wikimedia.org/T8220) [18:30:39] (03PS6) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [18:40:55] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:42:01] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:47:23] 04(no projects): Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861114 (10Glendales) [18:48:24] 04(no projects): Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861123 (10Glendales) p:05Triage>03High High priority as privacy/security issue. Pinging @Matiia and @Bsadowski1 as the two stewards who have been involved with the case thus far [18:52:26] (03PS7) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [18:53:31] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:54:49] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:55:55] (03PS8) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [18:56:20] 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861126 (10Paladox) [18:56:58] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [18:58:34] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [19:00:00] 04(no projects): Asad Ali Palijo - https://phabricator.wikimedia.org/T183703#3861151 (10Glendales) a:05Asad_Ali_Palijo>03None Spam [19:00:29] 04(no projects): [SPAM] Asad Ali Palijo - https://phabricator.wikimedia.org/T183703#3861154 (10mobrovac) 05Open>03Invalid p:05Triage>03Lowest [19:02:04] (03PS9) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [19:03:56] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [19:05:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [19:17:27] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3861158 (10Bawolff) Ok. So I think this may be suitable as a Google code-in task. [This is a slightly harder to task, you s... [19:17:42] 10MediaWiki-Special-pages, 10GlobalUsage, 10Multimedia, 10Google-Code-in-2017: Exclude files used in other wikis from Special:UnusedFiles, by Extension:GlobalUsage - https://phabricator.wikimedia.org/T183673#3861159 (10Bawolff) [19:18:12] 10MediaWiki-extensions-Translate, 10Easy, 10Google-Code-in-2017, 10I18n, 10RTL: Supporting RTL direction in the Special:PageMigration - https://phabricator.wikimedia.org/T139463#3861161 (10Phantom42) a:03Phantom42 I will work on adding support for RTL direction! :) [19:21:10] 10Wikipedia-Android-App-Backlog, 10Technical-Debt: Use auto-sizing TextView for page title. - https://phabricator.wikimedia.org/T180000#3743393 (10Jcasariego) Hi @Dbrant , according to the documentation when Autosizing is enabled, this scales the text uniformly on horizontal and vertical axes, ignoring the tex... [19:25:00] (03PS10) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [19:30:27] 10MediaWiki-extensions-Score, 10Wikimedia-SVG-rendering, 10Patch-For-Review, 10Upstream: Score should output SVG - https://phabricator.wikimedia.org/T49578#3861166 (10Ebe123) After this blocker, there is also the problem with librsvg, which renders text in SVG scores very badly. As an example: {F12070451}... [19:43:49] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [19:44:39] hello! [19:45:05] Albert221: Hi! :) [19:45:31] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [19:46:20] 10MediaWiki-extensions-WikibaseRepository, 10Wikidata, 10Patch-For-Review, 10User-Ladsgroup, 10Wikidata-Sprint-2017-12-20: Move all repoXXX client settings from $wgWBClientSettings to $wgWBClientSettings['foreignRepositories'] - https://phabricator.wikimedia.org/T153767#3861176 (10Ladsgroup) a:03Ladsgro... [19:52:03] Albert221: Hey! [19:53:51] Albert221: hello :D [19:54:24] \o [19:54:48] refeed[m]: Hey! [19:55:08] looks like Christmas days are coming to end [19:55:54] 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861114 (10Framawiki) See {T172560} too. [19:58:59] Albert221: Yup! [20:10:10] Albert221: o/ [20:10:16] refeed[m]: hello! [20:10:31] andre__: Hey nice to see you around! [20:10:34] (03PS11) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [20:10:59] * refeed[m] waves to Zppix and d3r1ck [20:12:42] refeed[m]: :) [20:12:43] 10MediaWiki-Codesniffer, 10Patch-For-Review: IfElseStructureSniff creates php error on autofix with alternative if else - https://phabricator.wikimedia.org/T178772#3861199 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [20:13:59] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:14:09] 10Developer-Relations (Jan-Mar-2018), 10Goal, 10Google-Code-in-2017: Organize and coordinate Wikimedia's participation in Google Code-In 2017 - https://phabricator.wikimedia.org/T176219#3861201 (10Aklapper) [20:15:32] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:15:54] Hey guys [20:16:03] Hello! [20:16:19] hi bobstech! [20:16:25] I'm here for the Google Code-in thing. What are you guys up to? [20:17:30] 10Accessibility, 10MediaWiki-extensions-GettingStarted, 10UI-Standardization, 10MW-1.31-release-notes (WMF-deploy-2017-10-24 (1.31.0-wmf.5)), and 2 others: Align GettingStarted colors to WikimediaUI palette ones - https://phabricator.wikimedia.org/T177712#3861205 (10Etonkovidova) Btw, @Volker_E - regarding... [20:17:45] bobstech: Hello and welcome! [20:17:58] we're just idling here waiting for you to show up [20:18:03] 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861207 (10Aklapper) p:05High>03Triage [[ https://www.mediawiki.org/wiki/Phabricator/Project_management#Setting_task_priorities | Resetting priority. ]] Nothing security related... [20:20:45] While you're spending an hour in here, bobstech, you can see the stream of notices that happen here [20:20:55] What are those about? [20:21:04] (03PS12) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [20:22:00] there is an automated program (a bot) that reports some of the messages that are going on in phabricator [20:22:15] which is our bug-reporting system [20:22:29] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:23:22] plus some other stuff [20:23:53] Have you had a chance to look at the other tasks available to do? [20:24:07] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:24:23] bobstech: To add to what RexxS said, "Phabricator + Gerrit". Gerrit is the code development and review platform for Wikimedia [20:25:01] Interesting [20:25:11] so kind of like git, but not really? [20:25:19] bobstech: Yes :) [20:25:45] bobstech: https://www.mediawiki.org/wiki/Gerrit [20:25:59] bobstech: https://www.mediawiki.org/wiki/Phabricator [20:26:02] 10MediaWiki-Codesniffer: phpcbf formatting error - https://phabricator.wikimedia.org/T183298#3849568 (10Umherirrender) Seems to be the upstream Generic.ControlStructures.InlineControlStructure On windows it results in ``` if ( !$title->isSpecial( $page ) ) { continue; }$groups = $g; ``` needs isolate test, if... [20:26:06] 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861214 (10Glendales) @Aklapper: * All three parts of the first tip make no difference * The second tip is irrelevant since I don’t have another account * The third tip (“remember... [20:26:19] Good evening d3r1ck, Phantom42, Albert221 and refeed[m], I'm tired a bit of those Christmas days and struggling with Python today :D [20:26:33] divadsn: Good evening! [20:26:39] and good evening to you too [20:26:46] 10MediaWiki-Codesniffer: phpcbf formatting error on inline control structure - https://phabricator.wikimedia.org/T183298#3861215 (10Umherirrender) [20:27:01] RexxS oh hey to you too :D [20:27:06] lol [20:27:22] Time to learn some Docker now ^^ [20:27:27] divadsn: Good evening :) [20:27:35] While my PR is not merged yet :P [20:28:57] divadsn: Which one? [20:29:48] RexxS: Any general thoughts on this? https://phabricator.wikimedia.org/T183674 [20:30:52] d3r1ck, Python related :/ [20:31:11] I do some python but not related to Wikimedia [20:31:18] Is it Pywikibot? divadsn [20:31:28] 10MediaWiki-jQuery-Tablesorter, 10VisualEditor, 10VisualEditor-Tables, 10CSS: class="wikitable plainrowheaders" does not work in mobile - https://phabricator.wikimedia.org/T183704#3861216 (10Neve-selbert) [20:31:55] https://github.com/python-social-auth/social-core/pull/169 [20:32:11] No it's OAuth backend for Phabricator [20:33:36] divadsn: Okay! [20:34:03] On Github UI, there is a possibility to request for review [20:34:06] Can you do that? [20:34:10] hey! I think that almost nobody from you actually know, that I have written second article about my experiences on Google Code-In! [20:34:15] check it out here if you want! https://medium.com/@Albert221/in-the-middle-of-the-gci2017-77a6e7344108 [20:36:39] Ohhh great Albert221 [20:36:42] Let me have a look :) [20:39:37] Albert221: Read it, nice! 10 claps for you not looking like a zombie during the day :D [20:45:16] (03PS13) 10Noella94: [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 [20:45:46] (03CR) 10D3r1ck01: "recheck" [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:46:16] :D thanks d3r1ck [20:47:22] (03CR) 10jerkins-bot: [V: 04-1] [WIP] Putting MassMessage Extension in PHP namespace MediaWiki\MassMessage [extensions/MassMessage] - 10https://gerrit.wikimedia.org/r/399538 (owner: 10Noella94) [20:51:19] d3r1ck I actually have done it :) [20:51:46] divadsn: Okay! [20:54:16] Does the wikimedia project use Java at all? [20:54:35] bobstech: Yes. For example mobile Kiwix app for Android [20:54:45] (03PS1) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [20:54:54] Hi d3r1ck - sorry I was dealing copyvios in another channel [20:55:11] RexxS: No problem :) [20:55:13] Phantom42: Oh, I remember seeing that some time ago. Might try to contribute there. [20:55:28] the tasks look quite reasonable for GCI at first glance [20:55:31] bobstech: Jenkins is Java :D [20:55:42] RexxS: Okay! [20:55:59] Trying to get feedback from community to see if it can be pushed to GCI RexxS [20:56:05] Oooo automation [20:56:08] you could break them into chunks and offer them as multiple tasks so that you involve more students [20:56:20] RexxS: Exactly [20:56:30] It will be similar to what legoktm did for Minus-X [20:56:41] you're only asking for patch sets, right? [20:56:57] yes! [20:57:50] RexxS: The repo that's gonna be on fire here will be integration-config :) [20:58:18] https://github.com/wikimedia/integration-config [20:58:21] it will survive [20:58:31] 10Wikipedia-Android-App-Backlog, 10Easy, 10Reading Epics (Feed 2.0): Enable sharing of ‘On this day’ event content - https://phabricator.wikimedia.org/T180385#3861232 (10RHo) Hi @Jcasariego - this task is about extending the "share-a-fact" card to share an event description when the user is on the full scree... [20:58:35] you might want to rope in some co-mentors :) [20:58:55] bobstech: https://en.wikipedia.org/wiki/Jenkins_(software) [20:59:23] RexxS: Exactly, looking for as much co-mentors as possible [20:59:37] d3r1ck: Thanks! [20:59:37] As this cuts across different extensions and the patches won't be the same [20:59:39] if want to retain your sanity [20:59:59] i've now interacted with 93 tasks [21:00:03] RexxS: :D [21:00:17] you'd think they'd have a rest over Xmas [21:00:18] RexxS: Ohhh wow! [21:00:34] 10Wikipedia-Android-App-Backlog, 10Easy, 10Patch-For-Review, 10Reading Epics (Feed 2.0): Enable secondary actions on articles shown within On this day - https://phabricator.wikimedia.org/T180391#3861233 (10RHo) Thanks @Jcasariego - looks good to me from design perspective (assuming the icon colors will be... [21:00:44] $ sanity check RexxS [21:01:09] Loading.... 100%, Sanity Check returns OK for RexxS :D [21:02:02] fortunately I'm retired and was a teacher for 25 years, so it's not as bad as it might be [21:02:13] True :) [21:02:17] god help the rest of you :P [21:02:30] :D [21:02:39] RexxS: The ticket may go in for GCI, hopefully! [21:05:29] (03CR) 10Pppery: [C: 04-1] Added a unit test to check that the name must be unique per newsletter (033 comments) [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [21:07:18] RexxS: Maybe you could help advertise the task a little on my behalf? :D [21:07:41] if i can [21:07:53] ping me when it's available [21:08:45] I mean help advertise to get co-mentors [21:08:55] So the ticket can hopefully go into GCI [21:14:46] 10MediaWiki-Codesniffer, 10Patch-For-Review: ExtendClassUsageSniff is buggy because it maintains state in the sniff - https://phabricator.wikimedia.org/T179753#3861241 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [21:15:25] 10Wikipedia-Android-App-Backlog, 10Easy, 10Reading Epics (Feed 2.0): Enable sharing of ‘On this day’ event content - https://phabricator.wikimedia.org/T180385#3861243 (10Jcasariego) Yes... now I understand the difference between one task and the other. Thanks for clarifying! [21:17:27] 10MediaWiki-Codesniffer: Mediawiki CodeSniffer MediaWiki.Classes.UnusedUseStatement.UnusedUse does not recognize Annotations - https://phabricator.wikimedia.org/T176885#3861244 (10Umherirrender) [21:17:36] andre__ you there? [21:17:48] Niklas said that he'll take a look tonight [21:17:57] 11:07 <+Nikerabbit> Albert221: I'll check it tonight when I am back home [21:18:50] Albert221: Oh, heh. Also fine. :P Well, I assume if there is more to fix that you may follow up :) [21:18:55] but thanks for the info! [21:20:48] and thanks for the approving anyway! [21:21:11] Thanks everyone for the great stay. Now I'm off the explore more Open-source projects! [21:21:13] heh, sure [21:21:22] bobstech: good luck! :) [21:22:09] 10ContentTranslation: Issue with autoloading of ContentTranslation\Translation from SpecialContentTranslation.php - https://phabricator.wikimedia.org/T183683#3861245 (10Albert221) 05Open>03Invalid @Nikerabbit yes, you are right. [21:24:17] did I already told you that GCI website sucks? [21:24:38] Albert221: sorry, train was late and some plans changed :) [21:25:15] no problem for me! but I hope that late train didn't destroy your evening plans? [21:27:11] d3r1ck or Nikerabbit, could you please explain to me T116546? I'm not sure what exactly I should add [21:27:11] T116546: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546 [21:30:01] Albert221: i read your post on medium I like the update! [21:30:33] Albert221: There is one more hover() call in the same file I missed earlier. Would you like to fix that one too in the same patch? [21:30:44] Nikerabbit, sure! [21:31:02] but I thought that I've searched for other occurences [21:31:22] Albert221: also one thing swat isnt for emergency deployments per say its just if we need to have something deployed like for example configuration for mediawiki [21:31:27] Albert221: I thought so too [21:31:30] ext.cx.translation.js?008ce:401 [21:33:15] done Nikerabbit! [21:33:42] Mind taking a look Nikerabbit? https://gerrit.wikimedia.org/r/#/c/157686/ [21:36:37] 10ContentTranslation, 10ContentTranslation-Analytics, 10Easy, 10Google-Code-in-2017, 10WorkType-Maintenance: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546#3861258 (10Albert221) a:03Albert221 [21:36:54] (03CR) 10Ryan10145: "There is already a newsletter in the database that is using UTPage as its main page. Therefore, if I changed this to use UTPage, the error" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [21:37:01] oh my [21:37:09] I was just planning to go to sleep [21:37:28] Sorry. It can wait [21:37:49] Nikerabbit: i can do a basic cr and you can do it later [21:37:50] 3 years, couple days can't hurt :) [21:38:21] Nikerabbit, good night then! [21:38:28] !gn [21:38:28] There is no such key, you probably want to try: !bot, !cms, !foreignfilerepos, !gnu, !iamabot, !instantcommons, !nofollow, !numberedparams, !safemode, !secrets, !shell, !sorttable, !subpages, !userapproval, !wiki2pdf, !wiki2xml, !memoserv, !autowikibrowser, !namespaceprotection, !screenshot, [21:38:37] d3r1ck, are you able to help me with ContentTranslation setup? :) [21:38:55] Albert221: i may possibly be able to [21:39:00] Im no expert but i can try [21:40:16] okay! this is some basic stuff I think. When I'm on Special:ContentTranslation&campaign=specialcx and I click New translation, it shows me an error that I couldn't connect to server. And in Javascript console there is a request to http://localhost:8080/v1/list/languagepairs (I'm running mediawiki on :80) [21:40:37] Hmm [21:40:51] Let me pull up the documentation quickly [21:41:02] that means that it needs https://www.mediawiki.org/wiki/Content_translation/cxserver/Setup, right? [21:41:15] Zppix look here: [21:41:16] https://www.mediawiki.org/wiki/Extension:ContentTranslation#Installation [21:41:47] it says something about cxserver, but I thought that's for mediawiki <=24 [21:41:59] Have you setup cxserver? [21:42:34] Albert221: as you may or may not know wikimedia documentation isnt always up to date [21:42:42] the default config except local cxserver setup [21:43:09] I would setup cxserver, but thats just my opinion [21:43:11] you can also set: $wgContentTranslationSiteTemplates['cx'] = 'https://cxserver.wikimedia.org/v1'; [21:45:13] oh, that would make my life much simpler Nikerabbit! as I proceed with cxserver setup docs looks like I need an Ubuntuish linux [21:46:17] and it indeed works as it should! thank you Nikerabbit! [21:46:39] I must say that MediaWiki needs or runs soooo much other software than one could have ever imagined... [21:46:53] much more* [21:47:30] Albert221: technically we could bundle all this with the main install but considering each sysadmin has different needs we cant [21:48:00] yes, of course, but what about something like "mediawiki-bundled" or something? [21:48:03] It is even funnier when you try playing with ElasticSearch or Wikidata stuff :) [21:48:30] plus Parsoid [21:48:42] 10ContentTranslation, 10Google-Code-in-2017, 10Patch-For-Review: Fix JQMIGRATE: jQuery.fn.hover() is deprecated in ContentTranslation - https://phabricator.wikimedia.org/T182758#3861261 (10Albert221) 05Open>03Resolved a:03Albert221 [21:54:57] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861264 (10Aklapper) Thanks! See the first bullet point under "If the above information is not enough to diagnose the issue (which is... [21:55:27] Nikerabbit, does your workaround work for everything? Because when I search for something to begin translating it gives me a critical exception "Wikimedia\Rdbms\DBQueryError" :( I imported this contenttranslation.sql [21:57:23] okay, nevermind, you wanted to go to sleep :) I'll get to that somehow [22:02:26] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861267 (10Glendales) @Aklapper and how exactly am I supposed to do that when the issue is happening on a Wikimedia Foundation site wh... [22:02:31] yes, I fixed that, sorry [22:03:25] (03CR) 10Ryan10145: "> I can use UTPage for the first newsletter, but I would still have" [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [22:04:20] (03PS2) 10Ryan10145: Added a unit test to check that the name must be unique per newsletter [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) [22:11:43] (03CR) 10Kaldari: [C: 031] "Tested and reviewed. Looks good. Do we want to merge this now, or wait until after the wmf.12->wmf.15 clusterfuck?" [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [22:14:35] (03CR) 10Pppery: "Oh, I see the situation here, you want to have two newsletters with the same main page but can't. Unsure what to do here." [extensions/Newsletter] - 10https://gerrit.wikimedia.org/r/400242 (https://phabricator.wikimedia.org/T183632) (owner: 10Ryan10145) [22:14:40] 10MediaWiki-Codesniffer, 10Patch-For-Review: Ignore returns in inner functions for MissingReturn sniff - https://phabricator.wikimedia.org/T178243#3861271 (10Umherirrender) p:05Triage>03Normal a:03Umherirrender [22:19:07] 10MediaWiki-Codesniffer: Add sniff to ensure doc blocks don't use "@cover", but "@covers" instead - https://phabricator.wikimedia.org/T176031#3861273 (10Umherirrender) a:05Jdforrester-WMF>03None [22:21:50] 10MediaWiki-extensions-General, 10Continuous-Integration-Config, 10Google-Code-in-2017, 10Jenkins: Add MediaWiki extensions to zuul/layout.yaml in so Jenkins can run builds - https://phabricator.wikimedia.org/T183674#3860109 (10Umherirrender) https://gerrit.wikimedia.org/r/#/c/394578/ will handle many of t... [22:22:10] 10MediaWiki-extensions-Translate, 10Easy, 10Google-Code-in-2017, 10I18n, and 2 others: Supporting RTL direction in the Special:PageMigration - https://phabricator.wikimedia.org/T139463#3861280 (10Phantom42) Issue fixed and tested! I didn't use PHP-side solution (it is not suitable here) and I decided not t... [22:34:39] 10MediaWiki-Authentication-and-authorization, 10Wikimedia-General-or-Unknown: Unable to remain logged in on Simple English Wikipedia - https://phabricator.wikimedia.org/T183702#3861282 (10Aklapper) >>! In T183702#3861267, @Glendales wrote: > how exactly am I supposed to do that when the issue is happening on a... [22:39:03] Zppix, do you know how can I make ContentTranslation not use DB_REPLICA but DB_MASTER? [22:40:30] 10MediaWiki-Codesniffer: Relax MediaWiki.WhiteSpace.SpaceBeforeSingleLineComment.EmptyComment for multiline comments - https://phabricator.wikimedia.org/T133743#3861284 (10Umherirrender) 05Open>03Resolved a:03Tgr Sniff was removed in https://gerrit.wikimedia.org/r/#/c/390178/ [22:40:38] Albert221: hmm [22:40:47] Albert221: i think theres a config var [22:41:02] or maybe I can use this replica, but looks like it doesn't exist in my setup [22:41:33] I've been debugging all the time and I got that `$dbr = Database::getConnection( DB_REPLICA );` doesn't work for me [22:42:03] 10OOjs-UI: PHP code documentation comments inconsistently use int/number and bool/boolean for types of parameters and return values - https://phabricator.wikimedia.org/T143623#3861289 (10Umherirrender) [22:42:08] 10MediaWiki-Codesniffer, 10Patch-For-Review: Provide Codesniffer rules to enforce "short" type definitions (int/bool, not integer/boolean) - https://phabricator.wikimedia.org/T145162#3861287 (10Umherirrender) 05Open>03Resolved I would say that all work is done here. Feel free to create a new task, if anyth... [22:44:23] Albert221: i dont know sorry [22:45:09] (03CR) 10MaxSem: "Definitely let's not make January 2 more fun than it will already be." [core] - 10https://gerrit.wikimedia.org/r/389665 (https://phabricator.wikimedia.org/T178449) (owner: 10Samwilson) [22:49:56] 10MediaWiki-Codesniffer: Look for @parma typo (should be @param) - https://phabricator.wikimedia.org/T182057#3811450 (10Umherirrender) Looks not like a common case/common typo in php code http://codesearch.wmflabs.org/search/?q=%40parma&i=nope&files=&repos= I would suggest to detect this by using a whitelist of... [22:50:01] okay, I finally found the actual reason of the error and fixed it [22:50:29] it was somewhere else than I thought, not related to DB_REPLICA tho [22:51:17] Oh [22:53:11] (03PS1) 10Umherirrender: @parma -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 [22:55:54] (03PS1) 10Umherirrender: @parma -> @param in javascript [extensions/MwEmbedSupport] - 10https://gerrit.wikimedia.org/r/400254 [22:56:54] 10Wikimedia-Site-requests: Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861294 (10StevenJ81) [22:57:16] 10Wikimedia-Site-requests: Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861304 (10StevenJ81) @MF-Warburg [22:58:08] (03PS1) 10Umherirrender: @parma -> @param in javascript [extensions/VirtualKeyboard] - 10https://gerrit.wikimedia.org/r/400255 [22:58:15] d3r1ck, you there? :) [23:00:02] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3847140 (10Umherirrender) With T171899 these would be found to, but having them checked by phpcs sounds also good [23:00:17] (03PS2) 10Umherirrender: @parma and @params -> @param in javascript [extensions/TimedMediaHandler] - 10https://gerrit.wikimedia.org/r/400253 [23:01:41] d3r1ck, what headings does T116546 say about? [23:01:41] T116546: add anchors to headings in CXStats - https://phabricator.wikimedia.org/T116546 [23:01:57] 10Wiki-Setup (Create): Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861310 (10StevenJ81) [23:02:03] https://i.imgur.com/JiBobAO.png this "Opublikowane tłumaczenia"? [23:02:19] 10MediaWiki-Codesniffer: PHPCS should make sure @covers tags are absolute - https://phabricator.wikimedia.org/T183218#3861311 (10Umherirrender) Should than also check @coversDefaultClass for full qualified class name [23:09:23] Amir1, hey! are you Amire80 from Phabricator? [23:09:52] Albert221: hey, No, I'm Ladsgroup from Phabricator [23:09:54] :D [23:10:14] (03PS1) 10Umherirrender: Replace create_function by closure [extensions/Contest] - 10https://gerrit.wikimedia.org/r/400256 [23:16:40] (03PS1) 10Umherirrender: Replace create_function by closure [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 [23:17:10] (03CR) 10jerkins-bot: [V: 04-1] Replace create_function by closure [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 (owner: 10Umherirrender) [23:27:12] 10Wiki-Setup (Create): Create Wikivoyage Pashto - https://phabricator.wikimedia.org/T183706#3861315 (10StevenJ81) 05Open>03stalled I was apparently premature in marking this approved. I'm going to stall this for now, and we'll see how it resolves. My apologies. [23:30:45] (03PS2) 10Umherirrender: Replace create_function by closure [extensions/DumpHTML] - 10https://gerrit.wikimedia.org/r/400257 [23:31:46] how do I get language of MediaWiki in JavaScript? [23:33:19] or where are the docs of `mw.*` methods? [23:37:16] hi [23:55:57] hi sajenjeshan1222